| 00:03:36 | *** lakkarau has quit IRC |
| 00:41:54 | *** maurya has joined #openmrs |
| 01:03:30 | *** deepaganu has joined #openmrs |
| 01:04:07 | <deepaganu> hey guys i am getting an errror org.openmrs.module.ModuleException: Unable to load/find moduleActivator: 'org.openmrs.module.exportccd.ExportCCDActivator' Module: Export CCD Module |
| 01:05:13 | <deepaganu> hi djazayeri |
| 01:21:54 | *** bwolfe has joined #openmrs |
| 01:21:54 | *** ChanServ sets mode: +o bwolfe |
| 01:22:26 | *** wyclif has joined #openmrs |
| 01:30:59 | <deepaganu> hi bwolfe |
| 01:31:02 | <deepaganu> org.openmrs.module.ModuleException: Unable to load/find moduleActivator: 'org.openmrs.module.exportccd.ExportCCDActivator' Module: Export CCD Module |
| 01:31:12 | <deepaganu> i am unable to start my module |
| 01:31:52 | <bwolfe> hi deepaganu |
| 01:32:19 | <bwolfe> deepaganu, ok. is this somethign new? what have you changed since you were last able to start it? |
| 01:32:37 | <deepaganu> i had my code written in the module ExportCCD |
| 01:33:04 | <deepaganu> then i tried to rename it to exportccd following the code conventions and now it gives me an error |
| 01:33:23 | <bwolfe> deepaganu, check the ExportCCDActivator class. what is the package there? |
| 01:33:28 | <bwolfe> (it is case sensitive) |
| 01:33:34 | <deepaganu> i tried to create a different module using archtype with name exportccd |
| 01:34:03 | <deepaganu> package org.openmrs.module.exportccd; |
| 01:35:11 | <deepaganu> bwolfe: |
| 01:35:12 | <deepaganu> http://pastebin.com/8hv4G7yE |
| 01:36:12 | <deepaganu> when i try to run the basic archtype module it is running fine |
| 01:36:25 | <deepaganu> problemhappens when i copy the code |
| 01:43:09 | <bwolfe> deepaganu, did you copy over that activator class? can you pastebin that? |
| 01:51:53 | <deepaganu> bwolfe: my problemis solved |
| 01:51:57 | <deepaganu> thanks |
| 01:52:06 | <bwolfe> deepaganu, great! |
| 01:52:08 | <deepaganu> bwolfe: i had written you a mail |
| 01:52:26 | <deepaganu> regarding putting my third party lib in the openmrs nexus repo |
| 01:52:52 | <deepaganu> right now i have installed them manullay on my system |
| 01:52:54 | <deepaganu> basic`: |
| 01:52:58 | <deepaganu> bwolfe: |
| 01:59:25 | <bwolfe> deepaganu, ok, before you release the module you should put those jars in the repo |
| 02:07:38 | <deepaganu> yes |
| 02:07:46 | <deepaganu> how do i do that |
| 02:08:00 | <deepaganu> do i need to have any kind of credentials |
| 02:08:03 | <deepaganu> bwolfe: |
| 02:10:56 | <bwolfe> deepaganu, yes, you need credentials. did you see my email reply to you today? |
| 02:18:53 | <deepaganu> no i will check it |
| 02:25:25 | *** deepaganu has quit IRC |
| 02:32:21 | *** jordank has quit IRC |
| 02:37:19 | <harshadura> hi bwolfe |
| 02:38:08 | <bwolfe> hi harshadura |
| 02:39:30 | <harshadura> bwolfe, did u checked my release omod, anything I need to enhance more? |
| 02:44:33 | *** upul` has joined #openmrs |
| 02:44:33 | *** ChanServ sets mode: +v upul` |
| 02:58:35 | <harshadura> bwolfe, sorry for bother i will ping u tomo morning then |
| 02:59:17 | <bwolfe> harshadura, I haven't checked it. too many things going on this week to get my instance working and try out modules. :-( |
| 03:00:03 | <harshadura> ok np bwolfe, I did those changes as u said in previous reviews |
| 03:00:41 | <bwolfe> all of them? :-) |
| 03:00:59 | <harshadura> yes bwolfe |
| 03:01:04 | <bwolfe> cool |
| 03:13:50 | *** suranga has joined #openmrs |
| 03:13:50 | *** ChanServ sets mode: +v suranga |
| 03:13:55 | <suranga> hiii bwolfe :) |
| 03:15:53 | <bwolfe> hi suranga |
| 03:16:31 | <suranga> bwolfe, sorry, was tied up with some office stuff, but wanted to catch u before u sign out :) |
| 03:16:57 | <suranga> bwolfe, as of now, it'll be just daniel and Uma for the remaining two days right ? |
| 03:17:19 | <bwolfe> yes |
| 03:17:26 | <bwolfe> did wyclif get his stuff wrapped up? |
| 03:18:01 | <suranga> bwolfe, last time I asked, he said he would (4 hours back) |
| 03:18:48 | <suranga> bwolfe, do we have much hope of releasing by end of sprint ? :( |
| 03:20:30 | <suranga> bwolfe, hmm... wyclif has not left me any pulls :) |
| 03:20:51 | <bwolfe> any tickets assigned to him? |
| 03:22:32 | *** robbyoconnor has joined #openmrs |
| 03:22:32 | *** ChanServ sets mode: +v robbyoconnor |
| 03:22:39 | <suranga> bwolfe, yeps,. there were, unfortunately. 24, and 6 too, as I remember |
| 03:23:53 | <bwolfe> suranga, 6 is closed |
| 03:24:11 | <suranga> bwolfe, he was working on 24 too |
| 03:25:31 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: HTML Widgets 1.6.1 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=htmlwidgets&version=&1.6.1> |
| 03:25:39 | <bwolfe> 24 is non-essential. but email him to make sure whatever code is pushed to his github branch |
| 03:26:12 | <suranga> bwolfe, umm... in the intrests of getting a working version out by friday, I want to do the following |
| 03:26:27 | <suranga> bwolfe, my mail regarding the structure of the message is on the dev list |
| 03:26:59 | <suranga> bwolfe, I want to add it into the module, and create a ticket for daniel to get the real generated message matching 100% with it |
| 03:27:50 | <suranga> bwolfe, when darius asked for the full version of the ORUR0 generated so far, I was left embarassed because apparently all the segments were created were not going into the parent template |
| 03:28:16 | <bwolfe> suranga, I don't think wyclif's template or daniel's template was being called |
| 03:28:16 | <suranga> bwolfe, so I want to make sure that (at very least) a call to our url will result in a valid response.. |
| 03:28:20 | <bwolfe> or that daniel's wasn't merged yet |
| 03:29:17 | <suranga> bwolfe, mm... daniels 38 was merged, right ? |
| 03:29:39 | <bwolfe> you tell me! |
| 03:31:02 | <suranga> bwolfe, it was initially, he also made a commit yesterday, and you had reviewd it |
| 03:31:22 | <suranga> bwolfe, so its undergoing its second review at the moment |
| 03:31:37 | <bwolfe> oh, then perhaps you just had to modify wyclif's template so that it actually called daniel's |
| 03:32:38 | <suranga> bwolfe, shall I create a ticket for daniel, which basically asks him to do those fixes ? |
| 03:33:00 | <suranga> bwolfe, 1) remove the call to OBR-ENC from the parent template |
| 03:33:10 | <suranga> 2) update the controller to work |
| 03:33:24 | <suranga> 3) ensure that the generated message is complete ? |
| 03:33:39 | <bwolfe> sure |
| 03:34:31 | <bwolfe> ok, signing out now suranga. |
| 03:34:40 | <suranga> bwolfe, ooops |
| 03:34:50 | <suranga> bwolfe, i may be tried up with some Jembi stuff today |
| 03:35:00 | <suranga> bwolfe, but will try to make this happen :( |
| 03:35:10 | <suranga> bwolfe, have a nice evening :) |
| 03:35:27 | <bwolfe> ok, at the very least try to just communicate it to him |
| 03:35:40 | <suranga> oh yeah, i will definitely do that now :) |
| 03:35:51 | <suranga> what i meant was, to physically do some work myself |
| 03:35:55 | <suranga> bwolfe, ^^ |
| 03:36:00 | <bwolfe> oh, ok |
| 03:36:11 | <bwolfe> I'll be sure to do some reviews for you tomorrow then |
| 03:36:28 | <bwolfe> I've been reviewing a lot of non-sprint things this last week, sorry! |
| 03:37:34 | <suranga> bwolfe, looks like we're both tied up with non sprint things :D |
| 03:37:51 | <suranga> bwolfe, hope my student has not run off too :P |
| 03:39:06 | *** bwolfe has quit IRC |
| 03:57:31 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: HTML Widgets 1.6.2 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=htmlwidgets&version=&1.6.2> |
| 04:39:52 | *** harshadura has quit IRC |
| 04:45:53 | *** nadee has joined #openmrs |
| 05:18:27 | *** suranga has quit IRC |
| 05:45:08 | *** kishoreyekkanti has joined #openmrs |
| 05:46:02 | *** kishoreyekkanti has quit IRC |
| 05:46:18 | *** kishoreyekkanti has joined #openmrs |
| 06:00:19 | *** lakkarau has joined #openmrs |
| 06:06:35 | *** dkayiwa has joined #openmrs |
| 06:39:21 | *** kishoreyekkanti_ has joined #openmrs |
| 06:42:00 | *** kishoreyekkanti_ has quit IRC |
| 06:42:19 | *** kishoreyekkanti_ has joined #openmrs |
| 06:43:00 | *** kishoreyekkanti has quit IRC |
| 06:45:05 | *** rram_ has joined #openmrs |
| 06:46:05 | *** shortend has joined #openmrs |
| 06:47:22 | *** dawn_ has joined #openmrs |
| 06:47:22 | *** ChanServ sets mode: +v dawn_ |
| 06:48:24 | *** dkayiwa has quit IRC |
| 06:59:19 | *** dawn_ has quit IRC |
| 06:59:21 | *** suranga has joined #openmrs |
| 06:59:21 | *** ChanServ sets mode: +v suranga |
| 07:08:25 | *** dawn_ has joined #openmrs |
| 07:08:25 | *** ChanServ sets mode: +v dawn_ |
| 07:08:58 | *** shortend has quit IRC |
| 07:11:54 | *** dawn__ has joined #openmrs |
| 07:11:54 | *** ChanServ sets mode: +v dawn__ |
| 07:11:55 | *** dawn_ has quit IRC |
| 07:11:56 | *** dawn__ is now known as dawn_ |
| 07:28:17 | *** goutham has joined #openmrs |
| 07:39:20 | *** harshadura has joined #openmrs |
| 07:50:55 | *** goutham has quit IRC |
| 07:54:02 | *** shortend has joined #openmrs |
| 07:59:10 | *** dawn_ has quit IRC |
| 08:01:32 | *** kishoreyekkanti has joined #openmrs |
| 08:02:10 | *** kishoreyekkanti_ has quit IRC |
| 08:03:13 | *** dawn_ has joined #openmrs |
| 08:03:13 | *** ChanServ sets mode: +v dawn_ |
| 08:07:21 | *** goutham has joined #openmrs |
| 08:17:37 | *** shortend has quit IRC |
| 08:20:20 | *** upul` has quit IRC |
| 08:29:53 | *** shortend has joined #openmrs |
| 08:48:57 | *** kishoreyekkanti_ has joined #openmrs |
| 08:51:40 | *** kishoreyekkanti has quit IRC |
| 08:52:47 | *** kishoreyekkanti_ has quit IRC |
| 08:53:02 | *** kishoreyekkanti has joined #openmrs |
| 08:53:55 | *** apremalal has joined #openmrs |
| 09:07:26 | *** djazayeri1 has joined #openmrs |
| 09:08:55 | *** djazayeri has quit IRC |
| 09:19:29 | *** suranga has quit IRC |
| 09:19:41 | *** suranga has joined #openmrs |
| 09:25:55 | *** suranga has quit IRC |
| 09:35:22 | *** kishoreyekkanti has quit IRC |
| 09:38:31 | *** mvorobey has joined #openmrs |
| 09:39:54 | <mvorobey> ÑÑ Ñдд |
| 09:39:58 | <mvorobey> hi all |
| 09:45:35 | *** suranga has joined #openmrs |
| 09:50:11 | *** dawn_ has quit IRC |
| 09:52:09 | *** dawn_ has joined #openmrs |
| 09:52:10 | *** ChanServ sets mode: +v dawn_ |
| 10:09:27 | *** goutham_ has joined #openmrs |
| 10:12:57 | *** suranga has quit IRC |
| 10:13:21 | *** rafa has joined #openmrs |
| 10:13:21 | *** ChanServ sets mode: +v rafa |
| 10:15:55 | *** dawn_ has quit IRC |
| 10:30:00 | *** dkayiwa has joined #openmrs |
| 10:36:45 | <rafa> mvorobey: hi! |
| 10:37:41 | <rafa> mvorobey: will you have any spare cycles to look at TRUNK-3300? |
| 10:49:40 | *** suranga has joined #openmrs |
| 10:49:40 | *** ChanServ sets mode: +v suranga |
| 10:49:54 | <suranga> hhiii dkayiwa :):) |
| 10:57:31 | *** james_regen has joined #openmrs |
| 10:57:31 | *** ChanServ sets mode: +v james_regen |
| 10:59:09 | <dkayiwa> hi suranga :) |
| 10:59:33 | <suranga> dkayiwa, hi, I aaam so relieved to so you :):) |
| 10:59:47 | <suranga> dkayiwa, umm.. what are you working on at the moment ? |
| 11:00:06 | *** dkayiwa has quit IRC |
| 11:01:20 | *** dkayiwa has joined #openmrs |
| 11:04:52 | <suranga> mm.. hi dkayiwa sorry, got cut off earlier... |
| 11:05:05 | <dkayiwa> suranga: no problem |
| 11:07:59 | <suranga> dkayiwa, are you working on changes to the obs groupings, which we discussed yesterday ? |
| 11:08:08 | <dkayiwa> suranga: yes |
| 11:08:23 | <mvorobey> rafa, hey, sorry, was away from keyboard, actually I've been on my dinner |
| 11:08:28 | <suranga> dkayiwa, great, let me know when u are done, because I have another ticket in mind :) |
| 11:08:37 | <mvorobey> rafa, no problem, will look at it right now |
| 11:08:38 | <dkayiwa> suranga: ok :) |
| 11:08:45 | <mvorobey> !ticket TRUNK-3300 |
| 11:08:46 | <rafa> mvorobey: great! thanks! |
| 11:08:47 | <OpenMRSBot> mvorobey: [#TRUNK-3300] Concept Drug Search doesnt work when searching by Drug ID - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3300 |
| 11:25:17 | <mvorobey> rafa, aha, will try to fix it by tomorrow, is it good ? |
| 11:26:35 | <mvorobey> dkayiwa, hey, how it's going ? |
| 11:26:47 | <dkayiwa> mvorobey: going on well and you? |
| 11:26:49 | <rafa> mvorobey: tomorrow morning? :D |
| 11:27:06 | <mvorobey> rafa, yeah, maybe todays deep eve :) |
| 11:27:25 | <rafa> mvorobey: cool |
| 11:27:49 | <rafa> mvorobey: It's one of the only tickets left stopping me from releasing |
| 11:28:06 | <mvorobey> dkayiwa, then will pay the most attention to it |
| 11:28:07 | <rafa> mvorobey: I'll wait till tomorrow :) |
| 11:28:22 | <mvorobey> rafa, then will pay the most attention to it |
| 11:28:36 | <rafa> mvorobey: thanks |
| 11:29:16 | <mvorobey> dkayiwa, I just noticed that we have the most prioritized blocker about XFRMS-90, there is already a patch for that, could you please have a look at it so we will be able to deal with that patch ? |
| 11:29:41 | <mvorobey> !ticket https://tickets.openmrs.org/browse/XFRM-90 |
| 11:29:42 | <OpenMRSBot> mvorobey: HTTP Error 404: Not Found - https://tickets.openmrs.org/browse/https://tickets.openmrs.org/browse/XFRM-90 |
| 11:29:51 | <mvorobey> dkayiwa, https://tickets.openmrs.org/browse/XFRM-90 |
| 11:37:39 | *** bwolfe has joined #openmrs |
| 11:37:39 | *** ChanServ sets mode: +o bwolfe |
| 11:37:56 | <suranga> aaaaaaaaaaaaaaaaaaand bwolfe is here ! |
| 11:38:12 | <bwolfe> where?!?! |
| 11:42:05 | <mvorobey> bwolfe, hi, have a minute ? |
| 11:42:44 | <suranga> aaaaaaand bwolfe is booked for a minute ") |
| 11:43:05 | <bwolfe> I have 56 seconds |
| 11:43:45 | <mvorobey> bwolfe, ok, let's hurry up then :) I am afraid that I did not really get what you meant within your last comment on ticket TRUNK-3300 |
| 11:43:52 | <mvorobey> !ticket TRUNK-3300 |
| 11:43:53 | <OpenMRSBot> mvorobey: [#TRUNK-3300] Concept Drug Search doesnt work when searching by Drug ID - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3300 |
| 11:44:17 | <mvorobey> bwolfe, do I need to move code from ConceptService back to DwrConceptService |
| 11:46:28 | * bwolfe looks |
| 11:48:47 | *** dawn_ has joined #openmrs |
| 11:48:47 | *** ChanServ sets mode: +v dawn_ |
| 11:49:46 | <bwolfe> mvorobey, ok, added two comments to the review |
| 11:49:59 | <bwolfe> I apologize for the confusing comment. when I reread it I was confused too. :-) |
| 11:50:57 | <mvorobey> bwolfe, np, thanks, looking at them right now |
| 11:51:46 | <mvorobey> bwolfe, so, do we still need extra unit tests for that ? |
| 11:52:51 | *** applecool has joined #openmrs |
| 11:52:51 | *** ChanServ sets mode: +v applecool |
| 11:52:55 | <applecool> hi rafa |
| 11:53:00 | <rafa> applecool: hi |
| 11:53:03 | <applecool> sorry little late |
| 11:53:29 | <applecool> i am getting the same error even though i added it in the core! |
| 11:53:47 | <rafa> applecool: committed? |
| 11:53:52 | <applecool> rafa: can you tell me what was wrong in that? |
| 11:53:56 | <applecool> yes last night it self |
| 11:54:11 | <rafa> applecool: I haven't looked at it |
| 11:54:18 | <applecool> committed last night! pushed it in the morning! |
| 11:54:20 | <applecool> okay! |
| 11:54:34 | <rafa> applecool: will get back to you in 30 minutes |
| 11:54:58 | <applecool> okay! cool by that time i will reach my home too :) i am travelling ;) |
| 11:55:13 | <applecool> goutham: congo on the release :) |
| 11:55:41 | <bwolfe> mvorobey, yes, I would like at least one test for it |
| 11:56:08 | <mvorobey> bwolfe, ok, will add |
| 12:01:22 | <suranga> bwolfe, let me know when that minute is up, i'd like a minute for an undate too :-) |
| 12:01:44 | *** applecool has quit IRC |
| 12:01:48 | <goutham> Thanks applecool :-) |
| 12:01:58 | <bwolfe> suranga, go ahead whenever |
| 12:02:17 | <suranga> bwolfe, great... so my update |
| 12:02:48 | <suranga> bwolfe, 1) it seems wylif has not commited the changes to his tickets, so I mailed him to clarify |
| 12:03:30 | <suranga> bwolfe, 2) dkayiwa is not working on changes to the obs grouping (which we disucssed yesterday. once this is done, we will build on the unit tests, and work on the controller |
| 12:03:54 | <suranga> bwolfe, 3) I've been making some of the changes we need to the liquibase files |
| 12:04:45 | <suranga> bwolfe, oh sorry, at 2) ^^ above, I ment dkayiwa is NOW working on , not 'not working' :-( |
| 12:05:06 | <suranga> bwolfe, umm... im also trying to work on the UI end, as time permits :( |
| 12:05:42 | <bwolfe> ok |
| 12:05:51 | <bwolfe> are you working against tickets for any of those? |
| 12:07:03 | <mvorobey> bwolfe, done it, added unit test which verifies that ConceptService returns drugs by drug concept id, do I need to recreate a patch or just can commit it letting you to do post-commit review ? |
| 12:07:43 | *** maurya has joined #openmrs |
| 12:07:53 | <suranga> bwolfe, no, they are minor fixes to other tickets |
| 12:08:11 | <suranga> bwolfe, I could probably log them as comments on tickets ? |
| 12:10:00 | <rafa> bwolfe: hi, have you reviewed https://tickets.openmrs.org/browse/TRUNK-3319? |
| 12:10:46 | *** ChanServ sets mode: +v maurya |
| 12:12:04 | <bwolfe> mvorobey, post commit is fine |
| 12:12:15 | <bwolfe> suranga, comments on tickets is fine |
| 12:12:29 | <mvorobey> bwolfe, ok, will do that in couple of minutes |
| 12:19:23 | *** robbyoconnor has quit IRC |
| 12:22:11 | *** harshadura has quit IRC |
| 12:27:02 | <mvorobey> bwolfe, hey, is there a chance that you can do post commit review for TRUNK-3300 before I actually backport it to 1.9.x and 1.8.x ? |
| 12:27:17 | <mvorobey> !ticket TRUNK-3300 |
| 12:27:18 | <OpenMRSBot> mvorobey: [#TRUNK-3300] Concept Drug Search doesnt work when searching by Drug ID - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3300 |
| 12:28:13 | <bwolfe> sure |
| 12:28:44 | <mvorobey> bwolfe, thanks |
| 12:28:48 | <bwolfe> rafa, ok, finished my review |
| 12:28:52 | <mvorobey> dkayiwa, hey, you there ? |
| 12:28:56 | <rafa> bwolfe: thx |
| 12:29:04 | <bwolfe> rafa, I remember looking at it before...I must have gotten distracted before finishing though |
| 12:29:27 | *** shortend has quit IRC |
| 12:29:58 | <rafa> bwolfe: yes, that's why I wasn't sure you've finished |
| 12:33:09 | *** harshadura has joined #openmrs |
| 12:40:52 | <dkayiwa> hey mvorobey |
| 12:42:04 | <mvorobey> dkayiwa, what about my last question to you above ? |
| 12:43:17 | <dkayiwa> mvorobey: which one? |
| 12:44:54 | <mvorobey> dkayiwa, I just noticed that we have the most prioritized blocker about XFRMS-90, there is already a patch for that, could you please have a look at it so we will be able to deal with that patch ? |
| 12:44:58 | <harshadura> hi rafa, can i get a min |
| 12:45:08 | <rafa> harshadura: yes |
| 12:45:25 | <dkayiwa> !ticket XFRMS-90 |
| 12:45:26 | <OpenMRSBot> dkayiwa: Issue Does Not Exist - OpenMRS JIRA - https://tickets.openmrs.org/browse/XFRMS-90 |
| 12:45:41 | <dkayiwa> !ticket XFRM-90 |
| 12:45:42 | <OpenMRSBot> dkayiwa: [#XFRM-90] Timeouts on download of large cohorts - OpenMRS JIRA - https://tickets.openmrs.org/browse/XFRM-90 |
| 12:45:49 | <harshadura> rafa, I hv 2 priviliges in my module add feedback and admin feedback, I want to allow one of a method in service IMPL to access by normal user who got add feedback privlige only |
| 12:46:08 | <dkayiwa> mvorobey: ok let me do so now |
| 12:46:36 | <mvorobey> dkayiwa, you are welcome to do it :D |
| 12:46:44 | <harshadura> rafa, when i try the same method using admin feedback privilige it works, but when i use a normal user its not working |
| 12:46:58 | <dkayiwa> mvorobey: only reviewing and applying :) |
| 12:47:07 | <rafa> harshadura: stack trace? |
| 12:48:23 | *** applecool has joined #openmrs |
| 12:48:23 | *** ChanServ sets mode: +v applecool |
| 12:50:36 | <applecool> hey rafa there? |
| 12:50:42 | <rafa> applecool: yes |
| 12:51:09 | <applecool> did you check that? |
| 12:51:27 | <rafa> applecool: remind me which test fails? |
| 12:51:41 | <harshadura> rafa, sorry for bit of lateness, here is the log > http://pastebin.com/tKy2Fye0 |
| 12:52:00 | <applecool> FileUploadControllerTest rafa |
| 12:52:49 | <harshadura> rafa, currently I hv coded the service class like below. |
| 12:52:50 | <harshadura> @Authorized({ "Add Feedback" }) |
| 12:52:50 | <harshadura> public void saveFeedback(Feedback Feedback) throws APIException; |
| 12:53:03 | <harshadura> public void saveFeedbackUser(FeedbackUser FeedbackUser) throws APIException; |
| 12:55:33 | <rafa> harshadura: the log says nothing about you being unauthorized |
| 12:56:01 | <rafa> harshadura: why do you say it's not working? |
| 12:56:20 | <harshadura> rafa, but it works properly in Super user. |
| 12:56:44 | <harshadura> rafa, when i try using a normal user its not getting saved in thr. |
| 12:56:50 | <rafa> harshadura: well show me it doesn't work |
| 12:57:21 | <rafa> harshadura: what error message you get when you use a normal user? |
| 13:03:12 | <applecool> rafa: ? |
| 13:03:26 | <rafa> applecool: looking into that |
| 13:03:36 | <applecool> rafa: okay |
| 13:03:53 | <rafa> applecool: I think a problem is with maven filtering test resources |
| 13:04:01 | <applecool> oh |
| 13:04:31 | <rafa> applecool: djazayeri1 has had the same thing recently |
| 13:05:01 | <applecool> oh! so what we will do then? should we skip that test and move on? |
| 13:05:18 | <applecool> thhere might be a solution i guess right |
| 13:05:23 | <applecool> :) |
| 13:05:53 | <rafa> applecool: just pushed a solution |
| 13:06:00 | <rafa> applecool: let me know if it works for you now |
| 13:06:04 | <applecool> ok |
| 13:10:41 | *** goutham has quit IRC |
| 13:12:12 | <harshadura> rafa, thx lot i got fixed the issue, need proxy privileges to view users |
| 13:14:24 | <applecool> rafa: success :) |
| 13:14:47 | *** downey has joined #openmrs |
| 13:14:47 | *** ChanServ sets mode: +o downey |
| 13:14:47 | *** OpenMRSBot sets mode: +o downey |
| 13:15:42 | <applecool> rafa: so next? |
| 13:16:06 | <rafa> applecool: there are still some tickets right? |
| 13:16:55 | <rafa> applecool: none for the 1.0 version I guess? |
| 13:17:46 | <rafa> applecool: you can work on non 1.0 tickets, but on a separate branch |
| 13:18:27 | <rafa> applecool: create "1.1" branch, we'll merge it after releasing 1.0 |
| 13:18:36 | <rafa> applecool: I still need to review your commits |
| 13:18:45 | <rafa> applecool: and test the app |
| 13:18:51 | *** applecoo_ has joined #openmrs |
| 13:19:08 | <applecoo_> rafa: sorry powercut due to rain |
| 13:19:16 | <applecoo_> yes there are 3 tickets |
| 13:19:17 | *** ibewes has joined #openmrs |
| 13:19:19 | <rafa> ~-+91930272+-~7[15:14] rafa: applecool: there are still some tickets right? |
| 13:19:19 | <rafa> ~-+91926960+-~7[15:15] rafa: applecool: none for the 1.0 version I guess? |
| 13:19:19 | <rafa> ~-+91928328+-~7[15:16] rafa: applecool: you can work on non 1.0 tickets, but on a separate branch |
| 13:19:19 | <rafa> ~-+91927536+-~7[15:16] rafa: applecool: create "1.1" branch, we'll merge it after releasing 1.0 |
| 13:19:19 | <rafa> ~-+91926816+-~7[15:16] rafa: applecool: I still need to review your commits |
| 13:19:20 | <rafa> ~-+91929264+-~7[15:17] rafa: applecool: and test the app |
| 13:20:06 | <applecoo_> yes none for 1.0 all done with 1.0 |
| 13:20:10 | <applecoo_> 2 for 1.1 |
| 13:20:28 | *** applecool has quit IRC |
| 13:21:04 | <ibewes> is anyone having trouble dowloading modules from mavenrepo.openmrs.org? |
| 13:21:06 | <applecoo_> okay so we are not going to release 1.0 now :) rafa |
| 13:21:28 | <rafa> applecoo_: not before code reviews and me testing the app |
| 13:21:42 | <rafa> applecoo_: have you tested the app? |
| 13:21:54 | <applecoo_> rafa: yes |
| 13:21:59 | <rafa> applecoo_: ok |
| 13:22:06 | <mvorobey> bwolfe, hey, I just finished with backporting, so can I go ahead and close the ticket TRUNK-3300? |
| 13:22:12 | <mvorobey> !ticket TRUNK-3300 |
| 13:22:13 | <OpenMRSBot> mvorobey: [#TRUNK-3300] Concept Drug Search doesnt work when searching by Drug ID - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3300 |
| 13:22:34 | <applecoo_> rafa: okay then i will move on with the 1.1 version tickets as you said :) |
| 13:22:39 | *** applecoo_ is now known as applecool |
| 13:22:40 | *** ChanServ sets mode: +v applecool |
| 13:22:57 | <rafa> applecool: remember to create a branch |
| 13:23:04 | <ibewes> I am getting a 403 Forbidden error when attempting to download 'http://mavenrepo.openmrs.org/nexus/content/repositories/public/com/thoughtworks/xstream/xstream/1.3.1/xstream-1.3.1.pom', but only on one computer (our build server) |
| 13:23:05 | <rafa> applecool: git branch 1.1 |
| 13:23:09 | <rafa> git checkout 1.1 |
| 13:23:09 | <bwolfe> mvorobey, yes, assuming you got all the commits in that backport. :-) |
| 13:23:17 | <rafa> git push origin 1.1 |
| 13:23:28 | <rafa> applecool: these are 3 commands you need to run |
| 13:23:29 | <mvorobey> bwolfe, each |
| 13:23:39 | <applecool> rafa: will git branch 1.1 creates the branch right away? |
| 13:24:08 | <rafa> applecool: yes |
| 13:24:20 | <rafa> applecool: checkout let's you start working on it |
| 13:24:31 | <applecool> oh |
| 13:24:32 | <rafa> applecool: push makes your branch public on github |
| 13:24:47 | <applecool> okay! will do them right away |
| 13:26:24 | <mvorobey> bwolfe, closed! |
| 13:27:23 | <applecool> rafa: done just created it :) |
| 13:28:27 | <mvorobey> dkayiwa, so, does XFRM-90 require some changes with mobile client ? |
| 13:28:42 | <dkayiwa> mvorobey: yes |
| 13:29:13 | *** harshadura has quit IRC |
| 13:29:21 | <dkayiwa> mvorobey: but that is not part of that ticket |
| 13:29:27 | <dkayiwa> mvorobey: that ticket is only for the server side |
| 13:29:55 | <mvorobey> dkayiwa, aha, so, can we apply it ? |
| 13:32:03 | <applecool> rafa: how to switch back to 1.0 branch i mean the master |
| 13:32:48 | <applecool> actually i formatted the test and committed it ! it went onto the 1.1 rafa |
| 13:32:56 | <applecool> is it okay? rafa |
| 13:33:36 | <dkayiwa> mvorobey: yes |
| 13:33:45 | *** shortend has joined #openmrs |
| 13:35:54 | <bwolfe> mvorobey++ |
| 13:37:31 | <suranga> dkayiwa, hwodyyy |
| 13:37:42 | <suranga> dkayiwa, did you see bwolfe 's mail on OBX'es ? |
| 13:38:46 | <dkayiwa> suranga: the discusion on dev list? |
| 13:39:00 | <suranga> dkayiwa, regarding the OBX segment, with grahame |
| 13:39:09 | <suranga> dkayiwa, ah, i rememberd that the OBX is not yours |
| 13:39:15 | <suranga> no worries, ill take it up |
| 13:39:51 | <suranga> dkayiwa, umm.. hows your obs grou ticket going ? its very tricky, isnt it ? :) |
| 13:40:06 | <dkayiwa> suranga: hahahah :) |
| 13:40:27 | <rafa> applecool: it's fine leave it |
| 13:40:35 | <applecool> okay rafa |
| 13:41:51 | <applecool> rafa: so after doing git commit -m "msg" next would be git push -u 1.1 or just git push 1.1 |
| 13:41:53 | <applecool> ? |
| 13:42:09 | <rafa> applecool: have you done git push origin 1.1? |
| 13:42:11 | <applecool> sorry forgot origin in between * |
| 13:42:18 | <applecool> yes done already |
| 13:42:32 | <applecool> while creating the branch |
| 13:42:36 | <rafa> applecool: so you've already told git to push to that branch as well |
| 13:42:48 | <applecool> but not after committing |
| 13:42:50 | <rafa> applecool: now when you do git push it will push every branch that has changes |
| 13:43:03 | <applecool> oh |
| 13:43:04 | <rafa> applecool: so git push is enough |
| 13:43:42 | <shortend> Hey, I'm getting a 403 Forbidden trying to retrieve a pom file from the openmrs maven repository. |
| 13:43:59 | <shortend> Does anyone have any ideas about why that would happen? |
| 13:44:02 | <shortend> http://mavenrepo.openmrs.org/nexus/content/repositories/public/com/thoughtworks/xstream/xstream/1.3.1/xstream-1.3.1.pom |
| 13:44:16 | <shortend> Using Wget v1.12 |
| 13:44:27 | <mvorobey> dkayiwa, but once we applied it, do we need to proceed with maintance release of XForms for that fix ? |
| 13:44:38 | <rafa> shortend: can you open it in web browser? |
| 13:44:43 | <shortend> Yes. |
| 13:44:52 | <dkayiwa> mvorobey: we can just release the next version |
| 13:45:28 | <rafa> shortend: http://click.1134972.n2.nabble.com/Maven-Repo-and-wget-td1139283.html |
| 13:45:30 | <OpenMRSBot> <http://ln-s.net/$ao4> (at click.1134972.n2.nabble.com) |
| 13:45:36 | <rafa> third answer |
| 13:46:04 | <rafa> shortend: the next time use google |
| 13:46:39 | <shortend> rafa: Appologies, have been to the great oracle of Google... |
| 13:46:56 | <shortend> rafa: My keyword kung-fu must be a bit weak. |
| 13:46:58 | <mvorobey> dkayiwa, am not really a big XForms person so would let you to do module releasing :D |
| 13:47:06 | <rafa> shortend: haha |
| 13:47:27 | *** kavuri has joined #openmrs |
| 13:48:10 | <ibewes> rafa: any idea why only the xstream pom would fail like this? All the other pom's we tried came down just fine |
| 13:48:30 | <mvorobey> dkayiwa, but can apply that patch to XForms, by the way, can I apply it directly to master or do I need to intruduce new branch for it ? |
| 13:48:34 | <rafa> ibewes: no sorry |
| 13:48:57 | <ibewes> rafa: no worries, thanks for the help |
| 13:49:11 | <rafa> ibewes: np |
| 13:49:18 | <dkayiwa> mvorobey: will going through the branch add any value? :) |
| 13:49:41 | <mvorobey> dkayiwa, sorry, did not get what you mean :) |
| 13:50:07 | <dkayiwa> mvorobey: what i mean is that i do not believe in extra work unless it adds value :) |
| 13:50:29 | <dkayiwa> mvorobey: so will going through the branch add any advantage? :) |
| 13:50:37 | <bwolfe> suranga, you should link to commits in github on the jira ticket when you make a comment. (I'm looking at your last comment on this ticket: https://tickets.openmrs.org/browse/HLQRY-11) |
| 13:51:02 | <suranga> bwolfe, sorry, let me do that :-( |
| 13:53:03 | <dkayiwa> mvorobey: if you cannot think of any advantage, then instead of doing unnecessary extra work, just go ahead and apply it to the master. :) |
| 13:53:30 | <mvorobey> dkayiwa, I think that not really, but there's a protocol that says that we need to have new branch for bug fixes and features, but I do agree that we can push it to master |
| 13:55:08 | <dkayiwa> mvorobey: we shall follow the protocal later after we have got the advantages that apply to us :) |
| 13:55:13 | *** downey has quit IRC |
| 13:55:43 | *** downey has joined #openmrs |
| 13:55:44 | *** ChanServ sets mode: +o downey |
| 13:55:44 | *** OpenMRSBot sets mode: +o downey |
| 13:55:50 | <mvorobey> dkayiwa, yeah, that makes sence |
| 14:01:30 | *** bwolfe has quit IRC |
| 14:03:10 | *** pushkar has joined #openmrs |
| 14:07:35 | *** jordank has joined #openmrs |
| 14:09:57 | *** jkeiper_ has joined #openmrs |
| 14:16:28 | *** bwolfe has joined #openmrs |
| 14:16:28 | *** ChanServ sets mode: +o bwolfe |
| 14:29:14 | <pushkar> bwolfe, Hi |
| 14:30:53 | <bwolfe> !refer pushkar [devmtg] |
| 14:30:54 | * OpenMRSBot refers pushkar to "devmtg" --- Reminder: Developer Forum Thursday at 10:00 AM Eastern Time - https://wiki.openmrs.org/display/RES/Developers+Forum |
| 14:41:35 | *** dkayiwa has quit IRC |
| 14:49:36 | <rafa> downey: hi, do we have any spare hardware to run metadata repository? It needs mysql and tomcat. Or should I try with some cloud? |
| 14:50:19 | <downey> rafa: eventually yes :) can you send me an email about it? |
| 14:50:37 | <rafa> downey: sure |
| 14:51:13 | <rafa> downey: I'd love to set it up within a week or so |
| 14:51:32 | <rafa> downey: is it eventually? :) |
| 14:52:51 | <rafa> downey: or eventually is within months or so? :) |
| 14:54:20 | *** goutham has joined #openmrs |
| 14:55:22 | *** shortend has quit IRC |
| 14:57:20 | *** lh has joined #openmrs |
| 14:57:24 | *** suranga has quit IRC |
| 14:57:43 | *** mccallumg has joined #openmrs |
| 14:57:43 | *** ChanServ sets mode: +v mccallumg |
| 15:00:00 | *** mvorobey has quit IRC |
| 15:05:33 | *** maurya has quit IRC |
| 15:09:44 | *** dawn_ has quit IRC |
| 15:12:48 | *** harshadura has joined #openmrs |
| 15:13:33 | *** rafa has quit IRC |
| 15:15:28 | *** robbyoconnor has joined #openmrs |
| 15:15:28 | *** ChanServ sets mode: +v robbyoconnor |
| 15:23:32 | *** rram_ has quit IRC |
| 15:24:52 | *** downey has quit IRC |
| 15:28:58 | *** applecool has quit IRC |
| 15:32:02 | *** jkeiper_ has quit IRC |
| 15:33:17 | *** harshadura has quit IRC |
| 15:36:15 | *** goutham has quit IRC |
| 15:42:00 | *** r0bby has joined #openmrs |
| 15:42:00 | *** ChanServ sets mode: +v r0bby |
| 15:45:01 | *** applecool has joined #openmrs |
| 15:45:02 | *** ChanServ sets mode: +v applecool |
| 15:45:23 | *** robbyoconnor has quit IRC |
| 15:46:51 | *** mvorobey has joined #openmrs |
| 15:56:45 | *** maurya has joined #openmrs |
| 16:00:30 | *** kavuri has quit IRC |
| 16:00:47 | *** mccallumg has quit IRC |
| 16:06:33 | *** lh has quit IRC |
| 16:08:17 | *** deepaganu has joined #openmrs |
| 16:08:25 | <deepaganu> hi all |
| 16:09:00 | <deepaganu> i am getting an error for DWR Service |
| 16:09:01 | <deepaganu> java.lang.SecurityException: No class by name: DWRMyModuleService |
| 16:10:34 | <mvorobey> deepaganu, can you please pastebin your error and example of you DWR config section from module.xml |
| 16:11:18 | <mvorobey> deepaganu, module config.xml, sorry :) |
| 16:11:42 | <mvorobey> you DWR = your DWR |
| 16:12:28 | *** lh has joined #openmrs |
| 16:17:35 | *** r0bby has quit IRC |
| 16:20:22 | *** wyclif has quit IRC |
| 16:20:46 | <deepaganu> mvorobey: http://pastebin.com/ufrF50Fw |
| 16:34:27 | *** lh has quit IRC |
| 16:34:31 | *** mccallumg has joined #openmrs |
| 16:34:31 | *** ChanServ sets mode: +v mccallumg |
| 16:38:31 | *** downey has joined #openmrs |
| 16:38:31 | *** ChanServ sets mode: +o downey |
| 16:38:31 | *** OpenMRSBot sets mode: +o downey |
| 16:44:38 | *** yanokwa has joined #openmrs |
| 16:44:38 | *** ChanServ sets mode: +v yanokwa |
| 16:47:26 | *** harshadura has joined #openmrs |
| 16:51:27 | <mvorobey> deepaganu, Config that you pasted there seems to be right, looks like that module classloader unable to locate class metadata for DWRMyModuleService. Is this class included to your .omod file ? |
| 16:51:59 | <deepaganu> i solved the error thanks anyway mvorobey |
| 16:52:30 | <mvorobey> deepaganu, what was the problem by the way ? |
| 16:53:00 | <deepaganu> @modulepackage@ should be replacedby the package name |
| 16:53:28 | *** yanokwa has quit IRC |
| 16:54:52 | <mvorobey> deepaganu, huh, that's a very common thing but I thought that you've properly configured maven resource plugin, anyway, good for you on this finding, keep it up! |
| 16:57:30 | *** deepaganu has quit IRC |
| 17:01:15 | *** suranga has joined #openmrs |
| 17:01:15 | *** ChanServ sets mode: +v suranga |
| 17:08:49 | <suranga> aaand im back :) |
| 17:10:32 | *** pulasthi7 has joined #openmrs |
| 17:14:31 | *** pushkar has quit IRC |
| 17:14:52 | *** mccallumg has quit IRC |
| 17:15:10 | <suranga> hi pulasthi7 |
| 17:15:19 | <suranga> pulasthi7, happy bug fixin :) |
| 17:20:31 | <mvorobey> bwolfe, hi |
| 17:20:38 | *** kavuri has joined #openmrs |
| 17:21:16 | <bwolfe> hi mvorobey |
| 17:21:54 | <mvorobey> bwolfe, is there a chance that you could join to review https://source.openmrs.org/cru/CR-TRUNK-689 ? |
| 17:22:06 | <bwolfe> maaaybe |
| 17:22:21 | <pulasthi7> hi suranga |
| 17:22:35 | <mvorobey> bwolfe, would be great, thanks in advance! |
| 17:22:38 | <suranga> pulasthi7, just saw you log in.. neat |
| 17:23:33 | <pulasthi7> suranga, i had been working on that fix, |
| 17:28:55 | <mvorobey> djazayeri1, hey |
| 17:29:04 | *** djazayeri1 is now known as djazayeri |
| 17:29:04 | *** ChanServ sets mode: +o djazayeri |
| 17:29:06 | <djazayeri> hi mvorobey |
| 17:30:34 | <mvorobey> djazayeri, that's why I said "Lara, please, see the comment in review", I did not say "Lara, please, fix ..." :) I just wanted to turn her attention to naming methods for future times :) |
| 17:30:50 | <djazayeri> mvorobey: I figured, I just wanted to make sure. :-) |
| 17:30:59 | <mvorobey> djazayeri, ok, np |
| 17:31:09 | <djazayeri> mvorobey: I'm sure you wouldn't have wanted to wait for another patch anyway, when it's a trivial fix. |
| 17:31:30 | <mvorobey> djazayeri, definitely true |
| 17:33:27 | <mvorobey> djazayeri, looks like that we need to backport Lara's patch to 1.9.x, right ? what about 1.8.x (it's actually not listen in fix versions field in JIRA) ? |
| 17:33:50 | <djazayeri> mvorobey: should backport to 1.8.x and 1.7.x yes |
| 17:34:09 | <mvorobey> djazayeri, even to 1.7.x :) |
| 17:34:26 | <mvorobey> djazayeri, will be done! |
| 17:34:44 | <djazayeri> Generally speaking we should backport to all supported versions (i.e. as far as 1.7.x) |
| 17:35:23 | <djazayeri> I don't know if Rafal has already tagged 1.9.1, 1.8.? and 1.7.?. You should generally check that so you know which precise fixversions to set (i.e. 1.9.1 or 1.9.2) |
| 17:35:24 | <suranga> hi bwolfe :) |
| 17:35:29 | <djazayeri> mvorobey: ^^ |
| 17:36:34 | <mvorobey> djazayeri, look like 1.9.1 is the right version |
| 17:36:41 | <mvorobey> look = looks |
| 17:37:55 | <bwolfe> hi suranga |
| 17:38:08 | <suranga> hi bwolfe sorry to bug |
| 17:38:16 | <suranga> i was wondering if we had a scrum today |
| 17:38:34 | <suranga> bwolfe, ummm.. any updates from Daniel ? |
| 17:39:26 | <bwolfe> I haven't talked to him |
| 17:39:33 | <bwolfe> the scrum is in a few hours |
| 17:39:55 | <suranga> oh, I see . cool |
| 17:44:50 | *** burke_away has joined #openmrs |
| 17:44:50 | *** ChanServ sets mode: +o burke_away |
| 17:52:36 | *** dkayiwa has joined #openmrs |
| 17:53:30 | *** goutham has joined #openmrs |
| 17:57:02 | *** kavuri has quit IRC |
| 17:58:49 | *** dkayiwa has quit IRC |
| 18:03:39 | *** downey has quit IRC |
| 18:03:48 | *** downey has joined #openmrs |
| 18:03:48 | *** OpenMRSBot sets mode: +o downey |
| 18:03:48 | *** ChanServ sets mode: +o downey |
| 18:04:55 | *** mgielow has joined #openmrs |
| 18:09:41 | *** mccallumg has joined #openmrs |
| 18:09:41 | *** ChanServ sets mode: +v mccallumg |
| 18:11:47 | *** dkayiwa has joined #openmrs |
| 18:14:01 | *** lh has joined #openmrs |
| 18:14:01 | *** lh has joined #openmrs |
| 18:14:27 | *** mvorobey has quit IRC |
| 18:14:40 | *** applecool has quit IRC |
| 18:15:03 | *** mvorobey has joined #openmrs |
| 18:23:21 | <mvorobey> djazayeri, hi |
| 18:23:35 | <djazayeri> hi mvorobey: on a call |
| 18:23:44 | <mvorobey> djazayeri, sorry |
| 18:23:48 | <djazayeri> np |
| 18:23:50 | <mvorobey> bwolfe, hey |
| 18:23:56 | <djazayeri> mvorobey: he's on the same call. :-) |
| 18:24:25 | <mvorobey> dkayiwa, are you on a call with Ben and Darius ? :) |
| 18:24:31 | <djazayeri> nope :-) |
| 18:24:54 | <dkayiwa> mvorobey: no |
| 18:24:56 | <mvorobey> then he is that man what am looking for :) |
| 18:25:12 | <dkayiwa> mvorobey: can you give me like 15 mis? :) |
| 18:25:29 | <mvorobey> dkayiwa, yes I can |
| 18:25:37 | <mvorobey> dkayiwa, no problem :) |
| 18:26:05 | <mvorobey> dkayiwa, ping me when you'll be free, ok ? |
| 18:26:12 | <dkayiwa> ok |
| 18:59:22 | *** rafa has joined #openmrs |
| 18:59:22 | *** ChanServ sets mode: +v rafa |
| 19:00:09 | *** lakkarau has joined #openmrs |
| 19:02:10 | <mvorobey> bwolfe, scrum time is coming :) |
| 19:05:51 | <bwolfe> yes, and our call is still going |
| 19:05:58 | <bwolfe> but cpower isn't here yet, so we have time ;-) |
| 19:06:17 | <mvorobey> but I haven't :D |
| 19:06:35 | <suranga> dkayiwa, yayy !!! |
| 19:06:41 | <dkayiwa> :) |
| 19:06:42 | <suranga> I just saw your commit ! |
| 19:06:49 | <dkayiwa> mvorobey: ready for you now |
| 19:06:53 | <dkayiwa> suranga: :) |
| 19:06:59 | <mvorobey> bwolfe: 5 mins and I'll turn into pumpkin |
| 19:07:18 | <suranga> dkayiwa, I got the GET request on the controller working, so now we can get basic data requests... :):):) |
| 19:07:26 | <mvorobey> dkayiwa, could you please do a quick post-commit review for TRUNK-3668 |
| 19:07:31 | <dkayiwa> suranga: oh thats so cool |
| 19:07:34 | <mvorobey> !ticket TRUNK-3668 |
| 19:07:35 | <OpenMRSBot> mvorobey: [#TRUNK-3668] PatientSetService getCurrentStates method errors if passed an empty cohort - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3668 |
| 19:07:45 | <dkayiwa> suranga: which ticket should i pick next? |
| 19:08:11 | <suranga> dkayiwa, did you add unit tests to check if your segment is 100% good ? :) |
| 19:08:24 | <mvorobey> dkayiwa, thanks in advance, gotta run for a little while :) |
| 19:08:32 | <dkayiwa> mvorobey: ok :) |
| 19:08:40 | <dkayiwa> suranga: for which ticket? |
| 19:09:05 | <suranga> dkayiwa sorry, i mean, did you do that as part of the ticket u just committed ? |
| 19:09:37 | <dkayiwa> suranga: am hoping the test i did is what you are looking for :) |
| 19:10:34 | <suranga> dkayiwa, aha, in that case, tomorrow we will work on a ticket aimed at getting properly formatted hl7 messages using the GET requst, for both XML and pipe delimited formats |
| 19:10:48 | <suranga> dkayiwa, this will be relatively much much easier |
| 19:10:56 | <dkayiwa> suranga: which ticket number? |
| 19:10:57 | <suranga> dkayiwa, after that, maybe work on the UI :) |
| 19:11:17 | <suranga> dkayiwa, i need to create that based on what I manage to accomlish today |
| 19:11:34 | <suranga> dkayiwa, are you in a mood to work right now ? :P |
| 19:11:34 | <dkayiwa> suranga: ok |
| 19:11:45 | <dkayiwa> suranga: you never know :) |
| 19:12:15 | <suranga> dkayiwa, if you are having trouble sleeping, maybe u could look at the manage template link, and see why it is not displaying any of the templates :( |
| 19:12:51 | <suranga> dkayiwa, i fixed it partially (moved from openmrs:message to spring:message) but still there seems to be a minor problem there... |
| 19:12:53 | <dkayiwa> suranga: which number? |
| 19:13:22 | *** lakkarau_ has joined #openmrs |
| 19:13:54 | *** cpower has joined #openmrs |
| 19:13:55 | <suranga> dkayiwa, this is a bug fix linked to Wyclifs https://tickets.openmrs.org/browse/HLQRY-11 |
| 19:14:01 | *** lakkarau has quit IRC |
| 19:14:04 | <cpower> hello! |
| 19:14:08 | <cpower> Scrum time? |
| 19:14:19 | <bwolfe> scrum time was 14 mins ago... |
| 19:14:25 | <bwolfe> but we were waiting for you |
| 19:14:32 | <dkayiwa> suranga: ok |
| 19:14:36 | <cpower> sorry trying to get the other teams running lost track of time |
| 19:14:41 | <cpower> ok, let's go |
| 19:14:48 | <cpower> !scrumon cpower |
| 19:14:48 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 19:15:30 | <cpower> Order: mvorobey, lakkarau, dkayiwa, suranga, rafa, djazayeri, bwolfe |
| 19:16:27 | <bwolfe> mvorobey, might be a pumpkin already... |
| 19:16:44 | <cpower> ok, next |
| 19:16:46 | <cpower> lakkarau |
| 19:16:48 | <lakkarau_> wednesday: |
| 19:16:48 | <lakkarau_> worked on TRUNK-3589 |
| 19:16:48 | <lakkarau_> worked on HLQRY-26 HLQRY-43 |
| 19:16:48 | <lakkarau_> thursday: |
| 19:16:48 | <lakkarau_> working on HLQRY-26 and TRUNK-3589. |
| 19:16:49 | <lakkarau_> blocker not able to compile the application. |
| 19:17:16 | <cpower> dkayiwa you are up |
| 19:17:36 | <dkayiwa> Did code review with my GSOC student |
| 19:17:36 | <dkayiwa> Reviewed: Timeouts on download of large cohorts - XFRM-90 |
| 19:17:37 | <dkayiwa> Dev Call |
| 19:17:37 | <dkayiwa> Committed: Committed: Create a groovy template to create the OBR Obs group segment of an ORUR01 message - HLQRY-38 |
| 19:17:37 | <dkayiwa> Now looking into: Whatever suranga tells me. :) |
| 19:17:38 | <dkayiwa> No Blockers |
| 19:18:19 | <suranga> hi |
| 19:18:23 | <suranga> Yesterday : |
| 19:18:23 | <suranga> general fixes / reviews / admin |
| 19:18:23 | <suranga> Found out that we need to change the message structure during yesterdays design call, so |
| 19:18:23 | <suranga> 1) preparing a new sample message / testing |
| 19:18:23 | <suranga> 2) validating new messages with unit tests |
| 19:18:24 | <suranga> today : |
| 19:18:25 | <suranga> manual merging of rafa's hl7 segments |
| 19:18:27 | <suranga> Easy (but essential) fixes for other peoples bugs |
| 19:18:31 | <suranga> 1) adding OBX.11 degment |
| 19:18:33 | <suranga> 2) removing call to OBR-ENC template |
| 19:18:35 | <suranga> 3) updates to messagetemplate jsp |
| 19:18:37 | <suranga> 4) general worrying |
| 19:18:39 | <suranga> 5) got the GET request working on the controller.I can not make a very basic request, and im getting back the data ! yayyyy !!!!!! |
| 19:18:59 | <cpower> blockers |
| 19:19:12 | *** james_regen has left #openmrs |
| 19:19:49 | <djazayeri> assuming suranga has no blockers, rafa? |
| 19:19:54 | <rafa> Today: |
| 19:19:54 | <rafa> * Reviewed & back ported & closed more tickets before releasing: DAY 3 |
| 19:19:54 | <rafa> * Dev call |
| 19:19:54 | <rafa> Tomorrow and probably sometime over the weekend: |
| 19:19:54 | <rafa> * The release day(s): 1.6.6 EOL, 1.7.5, 1.8.5, 1.9.1 |
| 19:19:54 | <rafa> No blockers. |
| 19:19:54 | <suranga> none, sorry |
| 19:20:16 | <djazayeri> All week |
| 19:20:16 | <djazayeri> * OpenMRS Calls |
| 19:20:16 | <djazayeri> * I-TECH work |
| 19:20:16 | <djazayeri> * sporadic code reviews and ticket comments |
| 19:20:16 | <djazayeri> No blockers |
| 19:20:29 | <djazayeri> rafa: have you tagged 1.9.1 yet? (mvorobey will want to know) |
| 19:20:37 | <rafa> djazayeri: no |
| 19:20:50 | *** jkeiper_ has joined #openmrs |
| 19:20:53 | <cpower> next |
| 19:21:20 | <cpower> bwolfe..you are up |
| 19:21:36 | <bwolfe> Wednesday |
| 19:21:37 | <bwolfe> emails |
| 19:21:37 | <bwolfe> triaged a bunch of tickets |
| 19:21:37 | <bwolfe> reviewed tickets for rafa, mykola |
| 19:21:37 | <bwolfe> univ call |
| 19:21:37 | <bwolfe> design call |
| 19:21:38 | <rafa> mvorobey: please do not back port anything tomorrow without letting me know :) |
| 19:21:39 | <bwolfe> pm call |
| 19:21:43 | <bwolfe> Thursday |
| 19:21:45 | <bwolfe> dev call |
| 19:21:47 | <bwolfe> ldrship call |
| 19:21:49 | <bwolfe> review sprint tickets |
| 19:21:51 | <bwolfe> reviewed tickets for mykola |
| 19:21:53 | <bwolfe> week in review with paul |
| 19:21:55 | <bwolfe> emails, omg, the emails |
| 19:21:57 | <bwolfe> no blockers |
| 19:22:01 | <djazayeri> rafa: email mvorobey that, in case he's asleep |
| 19:22:34 | <cpower> blockers: lakkarau not able to compile the app |
| 19:22:35 | <rafa> djazayeri: will speak to him tomorrow :) |
| 19:22:46 | *** maurya has quit IRC |
| 19:23:29 | <cpower> Discussion topics: rafa tagging 1.9.1 |
| 19:23:29 | *** downey has quit IRC |
| 19:23:49 | <djazayeri> lakkarau_: are you still blocked on compiling the application? |
| 19:24:05 | *** jkeiper_ has quit IRC |
| 19:24:07 | <lakkarau_> suranga:was getting Failed tests: |
| 19:24:08 | <lakkarau_> shouldEvaluateCompleteORUR01Template(org.openmrs.module.hl7query.HL7CompleteORUR01TemplateTest) |
| 19:24:08 | <lakkarau_> error |
| 19:24:28 | <suranga> lakkarau_, yes, im afraid.. |
| 19:24:45 | <suranga> lakkarau_, can u ignore tests with -Dmaven.test.skip=true |
| 19:24:52 | <cpower> !scrumoff |
| 19:24:52 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 19:25:00 | <bwolfe> lakkarau_, so you can't compile the module. have you updated? |
| 19:25:03 | <lakkarau_> suranga:yes |
| 19:25:39 | <bwolfe> lakkarau_, suranga: or just "-DskipTests" https://wiki.openmrs.org/display/docs/Maven |
| 19:26:00 | <bwolfe> suranga, having failing tests is bad. you should keep those commented out until they're working! |
| 19:26:01 | <suranga> bwolfe, lakkarau_ djazayeri that unit tests is failing because I added in the correct format of the message we need as test data, and gradually improving ou our output... |
| 19:26:18 | <suranga> bwolfe, sorry.. will do that :( |
| 19:26:25 | <djazayeri> suranga: so maybe you should add @Ignore("need to improve our output to match this") |
| 19:26:29 | <djazayeri> :-) |
| 19:26:57 | <suranga> djazayeri, we're not too far away from reaching that :):) |
| 19:27:21 | <suranga> dkayiwa, umm.. hi.. did u see that error I referred to in the managetemplates jsp ? |
| 19:27:37 | <dkayiwa> suranga: ok |
| 19:27:49 | *** lakkarau_ has quit IRC |
| 19:27:53 | *** lakkarau has joined #openmrs |
| 19:28:06 | <suranga> dkayiwa, feel free to comment on the existing ticket, or open a new one... |
| 19:28:15 | <dkayiwa> suranga: ok |
| 19:28:55 | *** jkeiper_ has joined #openmrs |
| 19:29:01 | <lakkarau> when skiped the test it worked |
| 19:29:09 | <bwolfe> lakkarau, why do you need that test to pass to keep working ? |
| 19:29:16 | <bwolfe> lakkarau, oh, just to get the omod output to test? |
| 19:30:54 | <djazayeri> suranga: I suggest that you commit and push an @Ignore on that test. |
| 19:31:06 | <suranga> djazayeri, will do that now :) |
| 19:31:45 | <djazayeri> suranga: people who are specifically working on tickets that will make that test pass can unignore it |
| 19:32:55 | *** cpower has quit IRC |
| 19:36:03 | *** rafa has quit IRC |
| 19:36:49 | *** lakkarau has quit IRC |
| 19:45:26 | *** lakkarau has joined #openmrs |
| 19:49:05 | *** lakkarau has quit IRC |
| 19:53:43 | *** downey has joined #openmrs |
| 19:53:43 | *** ChanServ sets mode: +o downey |
| 19:53:43 | *** OpenMRSBot sets mode: +o downey |
| 20:04:10 | *** david_ has joined #openmrs |
| 20:04:17 | <downey> Hi david_ and welcome to the #openmrs IRC channel. |
| 20:06:56 | <david_> Hey, quick question I'm hoping someone can answer. I'm wondering how concepts with multiple levels are used, e.g. Test Order -> X-ray -> Normal. When I fill an observation and select Test Order, then select X-ray I can't go any further. I have to start a new obs with concept X-ray and value normal. is that the typical workflow? |
| 20:08:02 | *** lakkarau has joined #openmrs |
| 20:08:15 | *** bwolfe has quit IRC |
| 20:08:35 | *** bwolfe has joined #openmrs |
| 20:08:35 | *** ChanServ sets mode: +o bwolfe |
| 20:11:55 | <mccallumg> david_: look at conceptid=377 on demo.openmrs.or |
| 20:12:01 | <mccallumg> demo.openmrs.org |
| 20:12:34 | <mccallumg> david_: note the use of "Concept Class" |
| 20:12:35 | <david_> ok, there |
| 20:12:49 | <david_> alright, i see that |
| 20:15:28 | <david_> mccallumg: what is there was another concept, "Test Ordered" and one of the answers was this concept |
| 20:16:04 | <mvorobey> djazayeri, am I late to scrum ? |
| 20:16:11 | <djazayeri> mvorobey: we all went already |
| 20:16:15 | *** goutham has quit IRC |
| 20:16:15 | <djazayeri> but go ahead now |
| 20:16:56 | <mvorobey> my scrum begins ... |
| 20:16:56 | <mvorobey> * Prepared follow up, committed and closed - TRUNK-3377 |
| 20:16:56 | <mvorobey> * Finished and closed - TRUNK-3300 |
| 20:16:56 | <mvorobey> * Committed patch for XFRM-90 |
| 20:16:57 | <mvorobey> * Created review, reviewed and committed Lara's fix for TRUNK-3668 |
| 20:16:57 | <mvorobey> No blockers |
| 20:17:02 | <mvorobey> my scrum ends |
| 20:17:06 | <dkayiwa> :) |
| 20:17:06 | <mvorobey> :) |
| 20:17:27 | <mvorobey> djazayeri, can I backport something today ? |
| 20:17:32 | <djazayeri> mvorobey: btw, rafa has not tagged 1.9.1 yet, but wants you to warn him before you backport anything tomorrow. |
| 20:17:34 | <djazayeri> today is fine. |
| 20:17:43 | *** lh has quit IRC |
| 20:18:10 | <mccallumg> david_: then that would be two different observations, right? One would document the test that was ordered. Later, another observation would document the result of that test. |
| 20:18:13 | <mvorobey> djazayeri, let me clarify bit more, next two our are fine, right ? |
| 20:18:59 | <djazayeri> mvorobey: rafa said that you should ask him before backporting anything *tomorrow*. I interpret that to mean that anytime before he wakes up tomorrow morning is fine. |
| 20:19:55 | <mvorobey> djazayeri, aha, ok, then I will trying to backport TRUNK-3668 by 2AM in Ukraine just to not trouble rafa tomorrow :) |
| 20:20:27 | <djazayeri> mvorobey: you are dedicated! |
| 20:20:44 | *** lakkarau_ has joined #openmrs |
| 20:20:45 | <david_> mccallumg: yes makes sense. Do you know, how you would interpret a concept with class: Question and datetype:Coded? |
| 20:21:07 | *** lakkarau has quit IRC |
| 20:23:10 | <mccallumg> david_ There is some documentation on this. See: https://wiki.openmrs.org/display/docs/Concept+Dictionary |
| 20:23:11 | <OpenMRSBot> <http://ln-s.net/8stL> (at wiki.openmrs.org) |
| 20:24:44 | <david_> mccallumg: got it |
| 20:26:11 | <david_> mccallumg: so it should never be the case that a single observation is tied to 3 concepts? The max is only 2, e.g. question/answer? |
| 20:26:59 | <mccallumg> david_: given the way it is modelled in openmrs. yes. |
| 20:30:23 | <dkayiwa> hi suranga |
| 20:30:28 | <david_> mccallumg: Thanks for the help |
| 20:31:25 | <suranga> dkayiwa, hii |
| 20:31:42 | <dkayiwa> suranga: are you referring to this error? javax.el.PropertyNotFoundException: Property 'hl7Entity' not found on type org.openmrs.module.hl7query.HL7Template |
| 20:31:58 | <dkayiwa> suranga: when i click manage templates |
| 20:32:03 | <suranga> dkayiwa, aha yes |
| 20:32:10 | <dkayiwa> suranga: ok |
| 20:32:23 | <mccallumg> Np david_ . What are you working on? Who are you working for? |
| 20:33:49 | <david_> mccallumg: am looking at ways for integrating commcare and the openmrs |
| 20:34:05 | <mccallumg> david_: are you at dimagi? |
| 20:34:26 | <david_> mccallumg: no I'm not |
| 20:35:26 | *** lakkarau has joined #openmrs |
| 20:35:58 | *** lakkarau_ has quit IRC |
| 20:38:52 | *** mseaton has joined #openmrs |
| 20:38:52 | *** ChanServ sets mode: +v mseaton |
| 20:40:13 | *** jkeiper_ has quit IRC |
| 20:40:43 | <mseaton> djazayeri / bwolfe: i thought i remember hearing that there is a way to specify, when upgrading concept maps from 1.6 - 1.9, that you can put something in the comment field or somewhere to specify whether they are same as, narrower than, etc... is that documented somewhere? i don't see it here: https://wiki.openmrs.org/display/RES/Release+Notes+1.9.0 |
| 20:41:09 | <mseaton> i came across this thread: http://listarchives.openmrs.org/Migrating-concept-mappings-to-1-9-td7527427.html |
| 20:41:15 | <djazayeri> wyclif was the authority on that, but he's on vacation |
| 20:41:35 | <djazayeri> or maybe rafa, but he's asleep |
| 20:41:42 | *** harshadura has quit IRC |
| 20:41:43 | <mseaton> did no one document this? |
| 20:42:40 | <djazayeri> reading the email thread now... |
| 20:43:07 | <mseaton> the feature would seem to only have value if implementers know about it. |
| 20:44:54 | <mseaton> djazayeri: documented here https://tickets.openmrs.org/browse/TRUNK-3296 |
| 20:47:08 | *** wyclif has joined #openmrs |
| 20:48:07 | <djazayeri> mseaton: would you mind adding one line to the Release Notes 1.9.0 page, or to the Migrating from 1.8 to 1.9 page, about this? Or else ask Rafal to, since he did the work? |
| 20:48:30 | <djazayeri> mseaton: behavior is in org.openmrs.util.databasechange.MigrateConceptReferenceTermChangeSet.determineMapTypeId(String, Map<String, Integer>) |
| 20:49:37 | <mseaton> djazayeri: where is the migrating to 1.9 page? |
| 20:49:41 | <djazayeri> mseaton: specifically the bit that if you put the comment "MAP TYPE: name of one of the core map types", that will be respected |
| 20:50:16 | *** lakkarau has quit IRC |
| 20:50:17 | <djazayeri> mseaton: https://wiki.openmrs.org/x/n4W5AQ but looking at it, I see this is actually for developers |
| 20:50:21 | *** lakkarau_ has joined #openmrs |
| 20:50:25 | <djazayeri> so just the release notes, I guess. |
| 20:52:27 | <mseaton> djazayeri: yes i can do that. let's also think on how we can improve this documentation as we go... |
| 20:52:56 | <djazayeri> mseaton: so, even if you change it yourself, you should chide rafal for not having documented this outside of the midst of a ticket comment |
| 20:58:15 | <mseaton> i'd love to chide. not sure i'm in a position to throw stones myself though... |
| 20:59:01 | <djazayeri> mseaton: chide when appropriate, and expect it in return. :-) |
| 21:00:34 | <djazayeri> off to lunch |
| 21:03:50 | *** lakkarau_ has quit IRC |
| 21:04:25 | *** bwolfe has quit IRC |
| 21:09:36 | <dkayiwa> hi suranga |
| 21:10:08 | <mvorobey> mseaton, hi |
| 21:11:59 | *** wyclif has quit IRC |
| 21:13:10 | <dkayiwa> suranga: done a commit for HLQRY-11 Can you test it out and tell me |
| 21:13:11 | <dkayiwa> ? |
| 21:22:41 | <mseaton> hi mvorobey |
| 21:23:46 | *** mseaton has left #openmrs |
| 21:27:44 | *** jkeiper_ has joined #openmrs |
| 21:35:35 | *** lakkarau has joined #openmrs |
| 21:35:48 | *** dkayiwa has quit IRC |
| 21:37:33 | *** mvorobey has quit IRC |
| 21:38:18 | <lakkarau> suranga:hi |
| 21:38:58 | <lakkarau> djazayeri:hi |
| 21:39:08 | <djazayeri> hi lakkarau |
| 21:39:19 | <lakkarau> djazayeri:javax.el.PropertyNotFoundException: The class 'org.openmrs.module.hl7query.HL7Template' does not have the property 'hl7Entity'. |
| 21:40:19 | <djazayeri> lakkarau: that means that in a JSP page you're doing ${ (something).hl7Entity } but that property isn't defined on that class |
| 21:40:24 | <lakkarau> djazayeri: i am getting this error when i click on ManageTempletes link |
| 21:40:48 | <djazayeri> lakkarau: I would look at the code for that page and see if someone committed something bad... |
| 21:41:01 | *** dkayiwa has joined #openmrs |
| 21:44:42 | *** burke_away has quit IRC |
| 21:46:24 | <lakkarau> djazayeri:i checked the class HL7Template.java and property hl7Entity exists. |
| 21:46:54 | <dkayiwa> lakkarau: can you git pull upstream master ? |
| 21:47:26 | <dkayiwa> lakkarau: you seem to be talking about what i have just pushed |
| 21:47:35 | <dkayiwa> lakkarau: HLQRY-11 |
| 21:49:22 | *** lakkarau_ has joined #openmrs |
| 21:50:07 | *** lakkarau has quit IRC |
| 21:52:55 | *** jkeiper_ has quit IRC |
| 21:57:12 | *** dkayiwa has quit IRC |
| 22:03:06 | *** lakkarau_ has quit IRC |
| 22:03:40 | *** lakkarau has joined #openmrs |
| 22:08:20 | *** pulasthi7 has quit IRC |
| 22:10:25 | *** david_ has quit IRC |
| 22:17:10 | *** lakkarau has quit IRC |
| 22:17:58 | *** lakkarau has joined #openmrs |
| 22:18:00 | *** downey has quit IRC |
| 22:31:38 | *** lakkarau has quit IRC |
| 22:32:41 | *** lakkarau has joined #openmrs |
| 22:33:12 | *** suranga has quit IRC |
| 22:37:10 | *** lakkarau has quit IRC |
| 22:55:54 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Spreadsheet Import 0.5.15 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=spreadsheetimport&version=&0.5.15> |
| 23:29:27 | *** mgielow has quit IRC |
| 23:36:47 | *** mccallumg has quit IRC |