IRC Chat : 2012-08-08 - OpenMRS

00:14:42 *** jkeiper has quit IRC
00:15:13 *** jkeiper has joined #openmrs
00:32:37 *** lh has joined #openmrs
00:55:16 *** lh has quit IRC
00:55:50 *** lh has joined #openmrs
00:58:49 *** lh has quit IRC
01:07:12 *** jkeiper has quit IRC
01:07:48 *** jkeiper has joined #openmrs
01:21:20 *** jkeiper_ has joined #openmrs
01:24:36 *** jkeiper has quit IRC
02:14:30 *** maurya has joined #openmrs
02:48:42 *** bwolfe has quit IRC
03:20:40 *** suranga has joined #openmrs
03:20:40 *** ChanServ sets mode: +v suranga
03:22:38 *** maurya has quit IRC
03:31:57 *** harshadura has quit IRC
03:34:42 <suranga> hiii wluyima :)
03:34:49 <suranga> wluyima, you still awake ?
03:54:00 *** jkeiper_ has quit IRC
03:54:34 *** jkeiper_ has joined #openmrs
03:55:02 *** maurya has joined #openmrs
04:03:11 *** jkeiper_ has quit IRC
04:03:40 *** jkeiper_ has joined #openmrs
04:35:38 *** jkeiper_ has quit IRC
04:36:11 *** jkeiper_ has joined #openmrs
04:46:41 *** jkeiper_ has quit IRC
05:15:42 *** robbyoconnor has joined #openmrs
05:15:42 *** ChanServ sets mode: +v robbyoconnor
05:19:48 *** robbyoconnor has quit IRC
05:20:43 *** robbyoconnor has joined #openmrs
05:20:43 *** ChanServ sets mode: +v robbyoconnor
05:27:34 *** robbyoconnor has quit IRC
05:33:26 *** maurya has quit IRC
05:56:41 *** scsibug has quit IRC
05:58:42 *** goutham has joined #openmrs
05:59:55 *** robbyoconnor has joined #openmrs
05:59:55 *** ChanServ sets mode: +v robbyoconnor
06:08:19 <suranga> wow wluyima , thanks :):)
06:08:35 <suranga> wluyima, you willl be on leave from today onwards, right ?
06:08:58 <wluyima> suranga, i went for dinner with some friends leaving the US, so i had to come back and work on this that is why it has been late
06:09:09 <wluyima> suranga, got to g ot obed
06:09:17 <suranga> wluyima, cool, thanks
06:09:27 <suranga> wluyima, umm.. u are on leave from now on, right ?
06:09:38 <wluyima> suranga, i have noticed there are templates not yet in the DB
06:10:14 <suranga> wluyima, no, some need to be added. they exist, but we had not added them to liquibase since they needed changes :)
06:10:58 <wluyima> e.g the 'Generic patient' that combines PID and PVI because i shoudl be calling that one
06:11:09 *** rram_ has joined #openmrs
06:11:10 <wluyima> suranga, ok talk to you later
06:11:25 <suranga> wluyima, cool, thanks :):)
06:11:48 <wluyima> suranga, in that pull request you wil notice i got rid of the patient result template and put its code in the orur01 master template
06:12:02 <wluyima> suranga, as we discussed
06:12:22 <suranga> wluyima, so now there is no patient result template anywhere in the code right ?
06:12:42 <wluyima> suranga, tomorrow (wednesday is my last day, my vacation starts thursday)
06:13:04 <suranga> ahh... thats great news from my end :-) ;-)
06:13:19 <wluyima> suranga, i wanted to work half day on thursday but my flight is at an awkward time
06:13:40 <wluyima> suranga, yeah got rid of the patient result template
06:13:53 <suranga> wluyima, you'll be back in a week,right ? umm.. r u going home ?
06:14:17 <wluyima> yeah i should be back on the 20th i get back to work on 21st
06:14:26 <wluyima> suranga, not home
06:15:09 <wluyima> suranga, i will be attending a wedding in belgium and then spend a few days after there and may be amsterdam
06:15:28 <suranga> wluyima, niceeeee ! thats very cool
06:15:37 <suranga> wluyima, that a great place for sightseeing :):)
06:15:44 <wluyima> suranga,i guess so
06:16:11 <wluyima> suranga, well talk to you later
06:16:34 <suranga> wluyima, :-)
06:17:47 *** sgithens has joined #openmrs
06:28:36 *** sgithens has quit IRC
06:30:18 *** suranga has quit IRC
06:43:24 <goutham> hi djazayeri
06:44:23 <goutham> hi robbyoconnor
06:47:39 *** dkayiwa has joined #openmrs
07:00:16 *** rram__ has joined #openmrs
07:00:16 *** rram_ has quit IRC
07:01:19 *** rram_ has joined #openmrs
07:01:19 *** rram__ has quit IRC
07:02:11 <mvorobey> dkayiwa, good morning!
07:02:22 <dkayiwa> mvorobey: good morning
07:02:35 <mvorobey> dkayiwa, how are you ?
07:03:24 <dkayiwa> mvorobey: am doing fine
07:03:26 <dkayiwa> and you?
07:03:53 <mvorobey> dkayiwa, very well, just woke up and full of energy :D
07:04:02 <dkayiwa> mvorobey: hahahaha :)
07:05:40 <mvorobey> dkayiwa, I just wanted to ask if you have a chance to review my last patch for https://tickets.openmrs.org/browse/TRUNK-3377 ?
07:05:53 <dkayiwa> mvorobey: ok
07:06:19 <goutham> Hi dkayiwa
07:06:27 <dkayiwa> hi goutham
07:06:53 <goutham> dkayiwa: you have any example for me?
07:07:03 <dkayiwa> goutham: looking now....
07:07:30 <goutham> dkayiwa: ok
07:07:47 <dkayiwa> goutham: EncounterDisplayControllerTest
07:09:08 <dkayiwa> goutham: and there are many such examples in the openmrs-web project under src/test/java
07:09:36 <dkayiwa> goutham: you can look at packages that have web.controller
07:09:42 <mvorobey> dkayiwa, thanks!
07:13:08 <goutham> dkayiwa: EncounterDisplayController implements a controller. So controller.handleRequest(request, response); is present using which we can test it but with we use annotated controllers , handleRequest method is not available
07:13:47 <dkayiwa> goutham: ok
07:15:17 <dkayiwa> goutham: can you look at? ChangePasswordFormControllerTest
07:16:27 <dkayiwa> goutham: that one should satisfy you needs since it is dealing with an annotated controller
07:21:13 <goutham> dkayiwa: i am getting an error as mentioned in mail. Can you tell me where i went wrong?
07:21:35 <dkayiwa> goutham: when trying to run the test?
07:22:27 <goutham> dkayiwa: yes
07:22:42 <dkayiwa> goutham: can you commit and i try run it too?
07:23:50 <goutham> dkayiwa: i made the commit . You can have a look at it
07:24:00 <dkayiwa> goutham: ok
07:30:22 *** snoppy has joined #openmrs
07:34:31 <dkayiwa> goutham: in which project did you put that test?
07:35:07 <goutham> dkayiwa: omod
07:35:20 <dkayiwa> goutham: ok
07:36:21 <dkayiwa> goutham: did you read the error message?
07:40:40 <goutham> dkayiwa: :( oops got it. sorry for the trouble.
07:40:51 <dkayiwa> goutham: :)
07:41:05 <goutham> dkayiwa: thank you :)
08:04:05 *** suranga has joined #openmrs
08:04:05 *** ChanServ sets mode: +v suranga
08:04:15 <suranga> hi dkayiwa
08:04:24 <dkayiwa> suranga: hi
08:04:25 <suranga> dkayiwa, power has returned, and im back ! :)
08:04:32 <dkayiwa> suranga: oh great!!! :)
08:04:32 <suranga> dkayiwa, umm.. hows it doing ?
08:04:47 <dkayiwa> suranga: reviewing mvorobey 's patch and then get back :)
08:05:11 <suranga> dkayiwa, cool... mvorobey is still awake ? what time zone does he stick to ? :D
08:05:26 <dkayiwa> suranga: he has just woken up :)
08:06:15 <suranga> dkayiwa, i'll write in my comments here, so you can read when u are done...
08:06:25 <suranga> dkayiwa, there was some changes that Ben wanted, basically we removed one tempalate. Wyclif took care of that, so it wont affect your work.
08:06:28 <dkayiwa> suranga: ok
08:06:35 <mvorobey> suranga, am already awoke :) now it's 11 AM in Ukraine
08:06:51 <suranga> dkayiwa, so when you complete your template, we can test the entire message from end to end :)
08:07:03 <dkayiwa> suranga: ok :)
08:07:07 <suranga> mvorobey, umm.. so arnt you at university or something ?
08:09:04 <mvorobey> suranga, actually, am at home :) we usually starting our lessons on 1st of September, now we have summer holidays :D
08:30:04 *** rafa has joined #openmrs
08:30:04 *** ChanServ sets mode: +v rafa
08:48:03 <dkayiwa> mvorobey: reviewed and applied your patch :)
08:48:45 <mvorobey> dkayiwa, thanks a lot!
08:55:40 <mvorobey> dkayiwa, have a minute?
08:55:45 <dkayiwa> mvorobey: ok
08:56:24 <mvorobey> dkayiwa, what do you say about of we re-write the code in this manner (about your comment on review):
08:56:28 <mvorobey> dkayiwa, if (encounter == null || encounter.getEncounterType() == null) {
08:56:28 <mvorobey> throw new IllegalArgumentException("Either encounter or encounter type is null");
08:56:28 <mvorobey> }
08:56:33 <mvorobey> dkayiwa, ?
08:57:00 <dkayiwa> mvorobey: how about separating them?
08:57:20 <dkayiwa> hi suranga
08:57:36 <suranga> dkayiwa, helooo
08:57:49 <dkayiwa> suranga: do you also get java.lang.OutOfMemoryError when you try running the unit tests?
08:58:03 <suranga> dkayiwa, mmm... no
08:58:09 <suranga> dkayiwa, I just checked out the latest
08:58:14 * suranga goes to confirm
08:58:57 <dkayiwa> suranga: please do
08:59:06 <suranga> mm.. dkayiwa no.. I just get a single failed test : shouldEvaluatePatientORUR01Template
08:59:16 <suranga> dkayiwa, which method causes it ? :(
08:59:26 <dkayiwa> suranga: ok. could be my side. let me look at it closely
09:00:08 <suranga> dkayiwa, this could be because the xml data files are too large, you could try increasing memory. or commenting out the ones you dont need to test, i think :)
09:00:24 <dkayiwa> suranga: ok :)
09:02:28 <rafa> dkayiwa: was it me or you that Bamboo is angry with? :)
09:07:08 <dkayiwa> rafa: hahaha let me cross check :)
09:07:35 <rafa> dkayiwa: sorry, but it's you :P
09:07:43 <dkayiwa> rafa: hahahaha :)
09:08:33 <dkayiwa> rafa: could that be a random failure? :)
09:08:57 <dkayiwa> rafa: i first did an mvn clean install and all was well :)
09:08:57 <rafa> dkayiwa: let's test
09:09:17 <rafa> dkayiwa: I've scheduled a manual build
09:09:23 <dkayiwa> rafa: ok
09:10:50 <mvorobey> dkayiwa, no problem
09:11:21 <mvorobey> dkayiwa, so, can I separate them and then do follow up commit ?
09:11:40 <dkayiwa> mvorobey: yes including some new unit tests :)
09:11:54 <mvorobey> dkayiwa, about ?
09:12:02 <dkayiwa> mvorobey: encounter type being null
09:12:08 <mvorobey> dkayiwa, passing encounter with null type
09:12:10 <dkayiwa> mvorobey: i already committed your other patch
09:12:20 <mvorobey> dkayiwa, which one ?
09:12:39 <dkayiwa> mvorobey: passing in null encounter type should throw exception
09:15:46 <mvorobey> dkayiwa, you're talking about patch for TRUNK-3377, right ?
09:15:54 <dkayiwa> mvorobey: yes
09:16:02 <dkayiwa> mvorobey: i applied the patch
09:17:22 <mvorobey> dkayiwa, good, thanks, will do follow up commit with separated IAE throwing when null check passes for encounter type and additional unit tests for this
09:18:30 <dkayiwa> mvorobey: ok
09:26:42 <rafa> mvorobey: hi
09:26:56 <rafa> mvorobey: can you please have a look at TRUNK-3240?
09:27:03 <rafa> !ticket TRUNK-3240
09:27:05 <OpenMRSBot> rafa: [#TRUNK-3240] Trying to upgrade a stopped module gives me an error related to extensions - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3240
09:27:16 <mvorobey> rafa, hi
09:27:22 <mvorobey> rafa, doing it right now
09:27:27 <rafa> mvorobey: thx!
09:28:04 <rafa> dkayiwa: bamboo is happy now :)
09:28:21 <dkayiwa> rafa: stupid bamboo :D
09:28:57 <rafa> dkayiwa: haha
09:29:08 <dkayiwa> :)
09:30:14 *** sgithens has joined #openmrs
09:31:01 <mvorobey> rafa, bwolfe says that we may left previous commits. And I agree with him that it would not heart, because it's a part of defensive coding concept so we should check if variable is null before we start using it
09:33:13 <rafa> mvorobey: good, if they don't hurt we can leave them
09:33:59 <mvorobey> rafa, they definitely would not heart because they only prevent NPE, nothing more
09:34:17 <mvorobey> heart = hurt
09:34:55 <rafa> mvorobey: it's fine, so just need to apply the patch
09:35:32 <mvorobey> rafa, yeah, will do it, thanks for helping me with it!
09:35:48 <rafa> mvorobey: thank you!
09:36:27 <mvorobey> rafa, by the way, how it's going ?
09:37:14 <rafa> mvorobey: good! preparing for maintenance releases
09:37:39 <rafa> mvorobey: custom messages module can't wait for that ;D
09:38:22 <rafa> mvorobey: are all changes you wanted committed and back ported?
09:39:15 <rafa> mvorobey: I haven't seen them yet so probably yes
09:39:27 <mvorobey> rafa, yeah, but for 1.4 am preparing feature that will allow to work with limited functionality without openmrs:message tag :)
09:40:12 <rafa> mvorobey: sounds good
09:40:44 <mvorobey> rafa, really good :)
09:42:18 <mvorobey> rafa, imagine, we won't need mention that implementers need to use maintaned releases, it will accompany to spread module more widely
09:43:19 <rafa> mvorobey: definitely
09:45:27 <mvorobey> rafa, BTW, when are you going to release maintenance version ?
09:45:39 <rafa> mvorobey: by the end of this week
09:45:58 <mvorobey> rafa, cool
09:46:07 <mvorobey> rafa, really good!
09:46:17 <mvorobey> rafa, looking forward to it! :)
09:46:22 *** judygichoya has joined #openmrs
09:46:52 <judygichoya> dkayiwa i am trying to increase my -Xmx256M in eclipse on the mac...
09:47:00 <judygichoya> but i cannot locate my eclipse.ini
09:47:14 <judygichoya> is it it the same as config.ini
09:47:21 <judygichoya> or do i need to create one?
09:47:50 <dkayiwa> judygichoya: i set mine in the eclipse run configuration
09:47:59 <judygichoya> for the project?
09:48:05 <dkayiwa> judygichoya: yes
09:48:10 <judygichoya> that is not working for me… :(
09:48:26 <dkayiwa> judygichoya: may be you need to increase
09:48:38 <judygichoya> so i cannot compile the module cos i get Exception in thread "main" java.lang.OutOfMemoryError: PermGen space
09:48:58 <dkayiwa> judygichoya: which module
09:49:05 <judygichoya> hl7 query
09:49:23 <dkayiwa> judygichoya: i wonder why suranga is not getting the same
09:49:40 <dkayiwa> judygichoya: may be for mac users only :)
09:50:00 <suranga> dkayiwa, judygichoya um... it works fine for me.
09:50:04 <judygichoya> did you get the same error
09:50:06 <judygichoya> ?
09:50:07 <judygichoya> dkayiwa
09:50:11 <dkayiwa> judygichoya: i get the same error
09:50:26 <dkayiwa> judygichoya: i just now put @Ignore on HL7PatientORUR01TemplateTest
09:50:38 <dkayiwa> judygichoya: on the class
09:50:46 <dkayiwa> judygichoya: then i can compile
09:50:54 <suranga> i did face that problem once about 3-4 days ago, and commited out one unit test. now I dont do that, but umm... it works just fine for me :(
09:51:13 <suranga> judygichoya, dkayiwa s solution will help you. @ignore it :)
09:51:51 <judygichoya> above this ?
09:51:52 <judygichoya> public class HL7CompleteORUR01TemplateTest extends MockBaseTest {
09:51:56 <judygichoya> ...
09:51:57 <judygichoya> ?
09:52:01 <dkayiwa> judygichoya: yes
09:52:07 <dkayiwa> judygichoya: no
09:52:29 <dkayiwa> judygichoya: read my comment above well :)
09:54:41 <judygichoya> did..
09:54:44 <judygichoya> working now...
09:55:42 <dkayiwa> judygichoya: :)
09:55:48 <judygichoya> by the way where is openmrs core?
09:55:59 <judygichoya> thanks dkayiwa … :) and i get the hint!
09:56:10 <judygichoya> btw i love irc,...
09:56:20 <judygichoya> even with the worst internet it still works...!
09:56:23 <dkayiwa> judygichoya: and me? :)
09:56:32 <judygichoya> what part?
09:56:41 <judygichoya> still works..@dkayiwa
09:56:50 <dkayiwa> judygichoya: :D
09:56:50 <judygichoya> when is my invite to visit btw
09:56:59 <dkayiwa> judygichoya: any time :)
10:02:53 <judygichoya> dkayiwa where is the main trunk
10:03:04 <judygichoya> of openmrs
10:03:11 <judygichoya> in github or svn
10:03:12 <dkayiwa> judygichoya: is it yet moved from svn?'
10:03:14 <judygichoya> cc suranga
10:03:23 <judygichoya> thats why i am asking.. :)
10:03:27 <dkayiwa> judygichoya: i think still in svn
10:03:50 <mvorobey> rafa, hey, you there ?
10:03:55 <rafa> mvorobey: yes
10:04:28 <mvorobey> rafa, once I applied patch for TRUNK-3240, can I go ahead with back-porting it ?
10:04:37 <rafa> mvorobey: yes
10:04:45 <mvorobey> rafa, ok, thanks!
10:12:13 *** sgithens has quit IRC
10:17:53 <mvorobey> rafa, hey, just applied patch for TRUNK-3240 and backported it to 1.9.x/1.8.x/1.7.x. Could you, please, verify that we can close it now ?
10:18:10 <rafa> mvorobey: great, will do, thanks!
10:18:58 <mvorobey> rafa, proszę :D
10:20:18 <rafa> mvorobey: looks good
10:20:29 <rafa> mvorobey: you need to close the review first
10:21:33 <mvorobey> rafa, closed
10:23:04 <rafa> mvorobey: that was fast, thanks!
10:23:31 <mvorobey> rafa, and now closed the ticket :)
10:24:02 <rafa> lol interesting we now have the Translate button in JIRA :D
10:28:56 <dkayiwa> judygichoya: meaning???
10:29:05 <judygichoya> does forms
10:29:25 <dkayiwa> judygichoya: some more explanation
10:32:52 <judygichoya> i am working on https://tickets.openmrs.org/browse/HLQRY-37
10:33:02 <judygichoya> @authorized annotations
10:33:14 <judygichoya> so i guess there are 2 questions...
10:33:28 <judygichoya> what privilege do we need auger to have to view/manage templates
10:34:54 <judygichoya> i checked the idcards module with a similar task but they us e
10:34:55 <judygichoya> <openmrs:requireprivilege="ManageIdCardTemplates"otherwise="/login.htm"redirect="/module/idcards/templates.list"/>
10:35:06 <judygichoya> a "manage Id card templates"
10:35:16 <dkayiwa> suranga: looks like those are your questions :)
10:41:31 <dkayiwa> judygichoya: can you also ask on the ticket?
10:41:48 <dkayiwa> judygichoya: assuming it has enough watchers
10:41:57 <judygichoya> will do ...
10:54:18 <suranga> hi judygichoya I saw your comment
10:54:33 <suranga> sorry about that, im not too good at multi taskin yet :(
10:54:39 <suranga> i;ve just responded...
10:55:37 <dkayiwa> judygichoya: on the ticket, you can also add as many watchers as you want to answer :)
10:56:08 <dkayiwa> suranga: ladies are the best at multitasking :)
10:57:41 <judygichoya> great
10:57:50 <judygichoya> suranga s comment was on point btw...
11:09:27 <judygichoya> btw dkayiwa which is the next sprint?
11:10:10 <dkayiwa> judygichoya: https://wiki.openmrs.org/display/RES/Sprint+Schedule
11:18:11 <suranga> dkayiwa, hi..umm.. hows it going with your ticket? anythin i can help with ?
11:18:27 <dkayiwa> suranga: going on well :)
11:18:46 <suranga> dkayiwa, cool, that means we can test the entire mesage out soon
11:18:56 <dkayiwa> suranga: yes :)
11:18:56 <suranga> dkayiwa, the msh segment was also added yesterday
11:19:08 <dkayiwa> suranga: yes i saw it
11:20:05 *** james_regen has joined #openmrs
11:20:05 *** ChanServ sets mode: +v james_regen
11:37:09 *** bwolfe has joined #openmrs
11:37:09 *** ChanServ sets mode: +o bwolfe
11:37:27 <mvorobey> bwolfe, hey
11:38:58 <mvorobey> bwolfe, is it possible to have encounter without encounter type set, or it's abnormal case and once we encountered such encounter we should throw IllegalArgumentException ?
11:40:43 <dkayiwa> hi suranga
11:41:26 <suranga> dkayiwa, helooo
11:41:30 *** bwolfe has quit IRC
11:41:34 <suranga> dkayiwa, I think I saw a pull request
11:41:36 <suranga> :)
11:41:40 <dkayiwa> suranga: which ticket should i do next?
11:41:57 <suranga> dkayiwa, umm.. so what you just finished was a big step
11:42:20 <dkayiwa> suranga: and should have alot of followup commits :)
11:42:22 <suranga> dkayiwa, so now, we should be able to generate a complete hl7 message, at least via the unit test
11:42:36 <dkayiwa> suranga: i guess so :)
11:42:56 <suranga> dkayiwa, i didnt really look at the unit test u wrot e yet, but is that the case ?
11:43:08 <suranga> dkayiwa, have u updated it to create the entire message ?
11:43:13 *** snoppy has quit IRC
11:43:45 <dkayiwa> suranga: is 38 the one to create the entire message?
11:45:23 <suranga> dkayiwa, not really, what I meant was that after this commit, the parent orur01 template would be able to generate the entire message
11:45:36 <dkayiwa> suranga: ok
11:46:06 <suranga> dkayiwa, I would really love it if we could confirm this. I think its worth creating a new ticket, just to write a really big unit test to show the entire template (with obs groups) works well ... :)
11:46:14 *** maurya has joined #openmrs
11:46:36 <dkayiwa> suranga: so are you creating the ticket? :)
11:46:55 <suranga> dkayiwa, let me first take a checkout and see how it looks :)
11:47:05 <dkayiwa> suranga: ok
11:50:52 <suranga> mm.. dkayiwa i seem to get 6 unit test faliures... :(
11:51:10 <dkayiwa> suranga: which ones?
11:51:28 <suranga> dkayiwa, shouldEvaluateOBRORUR01TemplateForOBSGroup
11:51:42 <suranga> shouldEvaluateOBXORUR01TemplateForNumericConcept
11:51:43 <dkayiwa> suranga: oh
11:51:54 <dkayiwa> suranga: i think i broke the second
11:51:59 <dkayiwa> suranga: let me fix it
11:52:20 <suranga> dkayiwa, i think several of thse obs group tests are failin :(
11:54:46 <dkayiwa> suranga: can you create a ticket for fixing them? I think some were commented out
11:55:38 <suranga> dkayiwa, oh, you mean a ticket to fix up all unit tests that need re-work following the latest updates, right ?
11:55:57 <dkayiwa> suranga: yes
11:56:03 <suranga> dkayiwa, cool, will do
11:59:08 <suranga> dkayiwa, righto , done
11:59:11 <suranga> ticket 44
11:59:28 <judygichoya> dkayiwa can u create a table in xforms?
11:59:34 <dkayiwa> suranga: ok
11:59:43 <dkayiwa> judygichoya: on the design surface?
12:00:37 <judygichoya> yes
12:00:45 <dkayiwa> judygichoya: as an end user?
12:00:46 <judygichoya> is there any other place to do this?
12:11:34 *** bwolfe has joined #openmrs
12:11:34 *** ChanServ sets mode: +o bwolfe
12:11:36 <dkayiwa> suranga: can u update
12:11:52 <dkayiwa> suranga: and tell me if the tests still fail
12:12:52 <suranga> dkayiwa, cool, wiilldo
12:16:00 <dkayiwa> suranga: will wait for u to tell me what to do next :)
12:16:19 <suranga> dkayiwa, umm.. two tests are still failin, im afraid...
12:16:27 <suranga> dkayiwa, i was taking a closer look at em
12:16:28 <dkayiwa> suranga: which ones?
12:16:39 <suranga> dkayiwa, shouldEvaluateOBRORUR01TemplateForOBSGroup
12:16:54 <suranga> dkayiwa, shouldEvaluatePatientORUR01Template
12:17:00 <dkayiwa> suranga: how are you running them?
12:17:25 <suranga> dkayiwa, mm.. mvn clean install
12:17:39 <dkayiwa> suranga: can you try run one by one using eclipse Run As JUnit test?
12:17:44 <suranga> cool
12:17:47 <dkayiwa> suranga: then tell me if they still fail
12:19:15 <suranga> dkayiwa, Itried shouldEvaluateOBRORUR01TemplateForOBSGroup()
12:19:20 <suranga> apparently that fails
12:19:49 *** wluyima has quit IRC
12:19:51 <suranga> dkayiwa, I get a null expected:<...BX.14><TS.1>87270114[093]130</TS.1></OBX.14><...> but was:<...BX.14><TS.1>87270114[120]130</TS.1></OBX.14><...>
12:20:11 <suranga> dkayiwa, the date here seems to be different...
12:20:38 <suranga> dkayiwa, is it becoz our machines are in diff timezones ?
12:21:46 *** goutham has quit IRC
12:23:17 <dkayiwa> suranga: oh
12:23:32 <dkayiwa> suranga: does the other one also fail?
12:23:36 <mvorobey> dkayiwa, hey
12:23:39 <dkayiwa> suranga: or only this one?
12:23:42 <dkayiwa> mvorobey: hey
12:24:03 <mvorobey> dkayiwa, let me know when you will be free to answer to my question, ok ?
12:24:13 <dkayiwa> mvorobey: am free all the time :)
12:24:22 <dkayiwa> mvorobey: am a multi tasker :)
12:24:39 <mvorobey> dkayiwa, clearly right !
12:24:43 <suranga> dkayiwa, yes, it seems so
12:24:45 <suranga> expected:<...V1.44><TS.1>87270114[093]130</TS.1></PV1.44><...> but was:<...V1.44><TS.1>87270114[120]130</TS.1></PV1.44><...>
12:25:04 <dkayiwa> suranga: so only one test failing???
12:25:07 <suranga> dkayiwa, i thin k its a system time problem. it gets 130, but looks for 93
12:25:19 <dkayiwa> suranga: i can fix that right away
12:25:22 <suranga> dkayiwa, sorry, i mean both fail for the same reason... :(
12:25:25 <suranga> dkayiwa, coool
12:25:36 <dkayiwa> suranga: ok tell me the classes and i fix now :)
12:26:14 <suranga> dkayiwa, its HL7PatientORUR01TemplateTest
12:26:25 <mvorobey> dkayiwa, I added throwing on IAE when encounter type is null and now about 23 tests from org.openmrs.hl7.HL7ServiceTest are failing because of the IllegalArgumentException, what am supposed to do in this case ?
12:26:26 <suranga> dkayiwa, and HL7OBRORUR01TemplateTest
12:28:17 <dkayiwa> mvorobey: i think the tests are creating an invalid encounter. can you fix the tests? i guess by simply supplying a dummy encounter type
12:28:52 <mvorobey> dkayiwa, ok, will try to dela with them
12:28:56 <mvorobey> dela = deal
12:34:42 <dkayiwa> suranga: can you update now and tell me?
12:35:35 <suranga> dkayiwa, nice
12:38:17 <suranga> dkayiwa, niceeee
12:38:24 <suranga> dkayiwa, all tests passs :):)
12:38:55 <dkayiwa> suranga: oh good :)
12:39:10 <suranga> dkayiwa, aaandddddd next comes............
12:39:46 <dkayiwa> suranga: what should i work on next? :)
12:40:02 <suranga> dkayiwa, im thinking, but have you any ideas ? :)
12:41:08 <mvorobey> dkayiwa, how to specify encounter type within HL7 segment string ?
12:41:45 <dkayiwa> suranga: you can create me a ticket of trying to come up with ideas :)
12:42:05 <dkayiwa> mvorobey: oh if you need to modify the segment string, then do not
12:42:15 <suranga> dkayiwa, i'd be most willing to, but I dont think bwolfe will like it :P
12:42:27 <dkayiwa> mvorobey: just do not throw out agreed upon exception, lest we introduce some bugs :)
12:42:34 <dkayiwa> out = our
12:42:59 <dkayiwa> suranga: was [:)
12:43:22 <suranga> dkayiwa, have you tried installing the module ?
12:43:34 <dkayiwa> suranga: not this week
12:43:39 <mvorobey> dkayiwa, so, what I must do with that ticket considering with it ?
12:43:56 <bwolfe> a ticket to come up with ideas? that doesn't make sense
12:44:00 <dkayiwa> mvorobey: just change the comment only
12:44:11 <dkayiwa> bwolfe: suranga :D
12:44:21 <mvorobey> dkayiwa, will do it, thanks
12:44:35 <mvorobey> bwolfe, TRUNK-3377
12:44:41 <mvorobey> !ticket TRUNK-3377
12:44:42 <OpenMRSBot> mvorobey: [#TRUNK-3377] Should be able to define a privilege required to view or edit an encounter - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3377
12:45:07 <dkayiwa> suranga: i will in the meantime review and apply patch for XFRM-90 :)
12:45:13 <bwolfe> suranga, dkayiwa, I see three unassigned tickets on the dashboard: https://tickets.openmrs.org/secure/Dashboard.jspa?selectPageId=12052
12:45:25 <bwolfe> why are you worried about work to do if there are unassigned tickets?!
12:45:43 <dkayiwa> bwolfe: so i can do the non essential? :)
12:45:43 <bwolfe> dkayiwa, there are also many "Needs Review" tickets. you can always review someone elses commits!
12:45:54 <dkayiwa> bwolfe: ok
12:46:01 <bwolfe> dkayiwa, non essential tickets are >> anything outside the sprint!
12:46:11 <dkayiwa> bwolfe: ok :)
12:46:15 <suranga> dkayiwa, bwolfe i want to give him a hard one. he;s anexpert :)
12:46:35 <bwolfe> non essential doesn't mean easy
12:46:43 <suranga> dkayiwa, can u try installing the module, and tell me what you get ? I think that wil be your next ticket :)
12:46:45 <dkayiwa> suranga: thats a lie ;)
12:46:59 <dkayiwa> suranga: hahahaha ok :)
12:47:22 <dkayiwa> bwolfe: suranga oh yes we have a very complicated non essential
12:47:42 <dkayiwa> HLQRY-2
12:47:57 <judygichoya> suranga
12:48:02 <judygichoya> i sent you an email...
12:48:10 <dkayiwa> i rarely see tickets with complexit HIGH
12:48:14 <dkayiwa> and this is one of them :)
12:48:49 <dkayiwa> suranga: do you think i should burry my self into HLQRY-2 after installing the module?
12:49:15 <suranga> dkayiwa, i think that will be a good idea, then when Wyclif comes in, he can work on the UI end... :)
12:49:28 <suranga> judygichoya, mm.. didnt get it yet.. to my gmail ?
12:49:39 <dkayiwa> suranga: ok
12:49:52 <judygichoya> yes
12:51:58 *** shortend has joined #openmrs
12:52:26 *** downey has joined #openmrs
12:52:26 *** OpenMRSBot sets mode: +o downey
12:52:26 *** ChanServ sets mode: +o downey
12:55:45 *** jordank has joined #openmrs
12:56:46 <suranga> hi bwolfe
12:57:10 <suranga> bwolfe, could you plz take a quick look at https://tickets.openmrs.org/browse/HLQRY-37
12:57:26 <suranga> bwolfe, and tell me if my comment is correct ? (regarding the previleges? :)
12:57:35 <suranga> dkayiwa, umm... did it install ok ?
12:57:56 <dkayiwa> outofmemory for mvn install
12:58:12 <dkayiwa> suranga: ^^
12:58:23 <suranga> dkayiwa, :(
12:58:50 <suranga> dkayiwa, Um.. I got that too..
12:59:14 <suranga> dkayiwa, im 100% sure its because of the immense sizes of our unit test files (the xml's we use)
12:59:24 <dkayiwa> suranga: even now?
13:00:12 *** suranga_ has joined #openmrs
13:00:26 <suranga_> dkayiwa, sorry, got cut off
13:00:33 <dkayiwa> ok
13:01:07 <suranga_> dkayiwa, what will you be working on ? :)
13:01:14 <suranga_> dkayiwa, :) :)
13:01:44 <dkayiwa> suranga_: HLQRY-2 :)
13:01:48 <dkayiwa> !ticket HLQRY-2
13:01:49 <OpenMRSBot> dkayiwa: [#HLQRY-2] Validate the template xml on-save via pseudo parsing through HAPI - OpenMRS JIRA - https://tickets.openmrs.org/browse/HLQRY-2
13:02:22 <suranga_> dkayiwa, o, by default, you have given over this new issue to wyclif, when he logs in :) :)
13:03:01 <dkayiwa> suranga_: yes :)
13:03:48 *** suranga has quit IRC
13:04:53 <rafa> bwolfe: what is the fastest way to find which rev is the released 1.9.0, etc?
13:05:00 <rafa> bwolfe: do we have a wiki listing it all?
13:05:54 <rafa> dkayiwa: maybe you know?
13:06:16 <dkayiwa> rafa: i think it should be on the release notes page
13:06:58 <dkayiwa> rafa: OpenMRS 1.9.0 represents revision 27760.
13:07:29 <rafa> dkayiwa: okay, thx
13:07:51 <bwolfe> rafa, dkayiwa, correct: I make a habit of putting it on the release notes page
13:08:18 <bwolfe> the other way is to download it and look at the "long version" printed inside the war file
13:09:54 <rafa> bwolfe: I found it in MEAT-INF in jars too
13:10:11 <rafa> META-INF ;)
13:10:50 <mvorobey> dkayiwa, hey, I've already committed follow up javadoc fix, any chance that you could verify it and approve so we can proceed with ticket closing ?
13:11:08 <mvorobey> dkayiwa, TRUNK-3377 - https://tickets.openmrs.org/browse/TRUNK-3377
13:11:48 <dkayiwa> mvorobey: ok
13:12:04 <mvorobey> dkayiwa, thanks a lot!
13:18:33 *** wluyima has joined #openmrs
13:18:54 <suranga_> dkayiwa, i hate to say this, but apparently one of your liquibase changsets are throwing an error ...
13:18:59 <suranga_> dkayiwa, it seems to give
13:19:00 <suranga_> Caused by: liquibase.exception.ValidationFailedException: Validation Failed:
13:19:01 <suranga_> 1 change sets check sum
13:19:01 <suranga_> liquibase.xml::1641256230538-332231::dkayiwa::(MD5Sum: fed2cce6e7596f2cd582c28a94ce)
13:19:01 <suranga_> at liquibase.DatabaseChangeLog.validate(DatabaseChangeLog.java:119)
13:19:01 <suranga_> at liquibase.Liquibase.listUnrunChangeSets(Liquibase.java:524)
13:19:01 <suranga_> at org.openmrs.util.DatabaseUpdater.executeChangelog(DatabaseUpdater.java:207)
13:19:03 <suranga_> at org.openmrs.module.ModuleFactory.runLiquibase(ModuleFactory.java:736)
13:19:14 <suranga_> hi wluyima !
13:19:21 <dkayiwa> suranga_: yes because it was modified
13:19:42 <dkayiwa> suranga_: just delete its id from the liquibasechangelog table
13:19:53 <dkayiwa> and also delete the old template
13:19:55 <wluyima> hi suranga_
13:19:57 <suranga_> dkayiwa, i deleted my table, and am building it nwly
13:20:04 <suranga_> dkayiwa, cool, will do
13:20:16 <dkayiwa> suranga_: that will happen until when we release the module :)
13:20:23 <suranga_> wluyima, howdy. sorry, im getting really good at hunting peopple on IRC :P
13:21:24 <wluyima> suranga_, np
13:21:37 *** apple has joined #openmrs
13:21:49 <downey> Hi apple and welcome to the #openmrs IRC channel.
13:22:01 *** apple is now known as Guest14504
13:22:13 <dkayiwa> Guest14504: are you applecool? :)
13:22:38 <suranga_> wluyima, aaand what will u be picking up today ?
13:22:46 *** Guest14504 is now known as applecool
13:22:56 <dkayiwa> suranga_: does he have an option? :)
13:23:10 <wluyima> suranga_, am finishing up HLQRY-24
13:23:24 <suranga_> dkayiwa, ah, i think he has one, unfortunately :(
13:23:42 <dkayiwa> suranga_: not for long though :)
13:24:35 <suranga_> wluyima, i was kinda wondering if you could look into why we cant install the module into openmrs :) :)
13:24:53 <suranga_> wluyima, it seems to be rather a blocker for other stuff.....
13:25:08 *** judygichoya has left #openmrs
13:26:18 <wluyima> suranga_, sure i can do that
13:26:37 <wluyima> suranga_, so you mean right now it can't be installed
13:27:17 <suranga_> wluyima, can you do the following .. delete your hl7qry table from the db, and try creating newly. you should get a memory problem
13:27:33 <wluyima> suranga_, will see
13:27:50 <suranga_> wluyima, i think that this is happening because the size of the xml data files we use fr testing :):)
13:28:57 <wluyima> suranga_, but we use the same in other modules
13:31:56 <applecool> dkayiwa yes it was me :)
13:32:02 <dkayiwa> :)
13:32:44 <suranga_> applecool, did you finally realize that apple products are not cool, so edited your nick ? :P
13:34:36 <applecool> Haha . Yeah seriously I am now feeling very uncomfortable using webchat on iPhone. I struggled 5 min to type this MSG : P
13:35:26 *** applecool has quit IRC
13:40:11 <suranga_> wluyima, um.. i tried deleting the entire table and re installing. it seems there are issues with several chngesets as well...
13:40:20 <suranga_> shall I add these into a nice ticket for you :):)
13:43:01 <rafa> dkayiwa: bwolfe why do we have these strange unrelease versions: "1.9 Road Map Sprint 4", "1.9 Provider Sprint", "1,9 Beta Sprint"?
13:43:11 <rafa> *unreleased
13:43:11 <wluyima> suranga_, everything works for me well with the latest bui;d of the module
13:43:20 <rafa> in JIRA
13:43:48 <bwolfe> rafa, they were used for sprints only
13:44:24 <suranga_> wluyima, could you please check that please ? in mine its failn :(
13:44:35 <rafa> bwolfe: there's a small problem with them
13:44:55 <bwolfe> ?
13:44:59 <rafa> bwolfe: some ended up committed to 1.9.0 and are not marked as fix version 1.9.0
13:45:47 <rafa> bwolfe: I have just found TRUNK-2099 and changed the fixVersion to 1.9.0
13:45:52 <wluyima> suranga_, check what?
13:46:12 <rafa> bwolfe: but I'm looking at them and there may be more
13:46:24 <suranga_> wluyima, sorry, by deleting yout hl7 module tables, can u successfully install the module omod again ?
13:46:42 <suranga_> wluyima, just to confirm that nothing breaks ?
13:47:00 <rafa> bwolfe: TRUNK-2595 still in code-review but probably in 1.9.0 already
13:47:50 <rafa> bwolfe: they need to be cleaned up right?
13:47:59 <bwolfe> rafa, yes, it was a mistake to not put the fixVersion of 1.9.0 on there
13:48:30 *** snoppy has joined #openmrs
13:49:05 <mvorobey> bwolfe, hey, how it's going ?
13:49:26 <rafa> bwolfe: ok so how to fix them? put fixVersion 1.9.0 if already in 1.9.0 and if not bump them to 1.9.2?
13:49:59 <rafa> bwolfe: then release these these sprint fixVersions?
13:50:00 <wluyima> suranga_, i deleted the table and everything worked
13:50:17 <rafa> bwolfe: I mean only marked them as released in JIRA
13:50:28 <suranga_> wluyima, cool, in that case u should focus on the out of memory problem only...
13:50:41 <wluyima> suranga_, i didntt get it too
13:51:05 <suranga_> wluyima, umm.. i module loads and starts successfuly ??
13:51:20 <suranga_> dkayiwa, umm apparently everything works for wluyima :)
13:51:23 <wluyima> suranga_, but i had to delete all my changesets from the liquibasechangelog table
13:51:48 <suranga_> wluyima, so your module starts successfully ? nice....
13:51:56 *** lh has joined #openmrs
13:51:56 *** lh has joined #openmrs
13:53:02 <suranga_> wluyima, if thats the case, and it all works for you, there is one more issues i would like you to look at, before you head off to HL&QRY-24...
13:53:50 <wluyima> suranga_, which issues?
13:54:05 <wluyima> suranga_, am almost already done with 42
13:54:50 <suranga_> wluyima, i think u mean 24, not 42
13:55:02 <bwolfe> rafa, yeah, that sounds right
13:55:16 <suranga_> wluyima, a long time back, you wrote the controller, with the optional / mandatory parameters that we hit, righ ?
13:55:54 <wluyima> suranga_, yeah
13:55:59 <rafa> bwolfe: okay, thx
13:56:00 <suranga_> wluyima, wluyima can you re-visit that ticket, and make sure the get request works will all the parameters you specified ?
13:56:16 *** lakkarau has joined #openmrs
13:56:34 <suranga_> wluyima, now, since all the segments are in, we should get a correctly formatted hl7 message response for each request...
13:56:37 <rafa> bwolfe: archive them later so that they don't show up in the autocomplete for fixVersion?
13:57:07 <suranga_> wy unfortunately, i cant do this right now bwcause Im tied up with another problem on the other screen:)
13:57:20 <suranga_> wluyima, ^^ :-(
13:57:24 <bwolfe> rafa, if we can hide them, yes, do that
13:57:39 <wluyima> suranga_, unit tests?
13:58:00 *** cpower has joined #openmrs
13:58:14 <wluyima> suranga_, i think the way it is right now it takes them already into consideration
13:58:54 <suranga_> wluyima, did you write unit tests too ? thats great. obviously I have not paid enough attention to the tests... :(
13:59:05 <suranga_> wluyima, in that case, you can proceed with that ticket :):)
13:59:47 <wluyima> suranga_, no unit tests since the segments were not ready
14:00:05 <wluyima> suranga_, we probably need tests for that controller
14:00:13 <suranga_> wluyima, ahaaaa ! in that case, we can add then now ;-)
14:00:15 <wluyima> suranga_, you can create a ticket for that
14:00:30 <cpower> Hello everyone!
14:01:34 *** jriley has joined #openmrs
14:02:31 <cpower> let's get down to business shall we?
14:02:38 <cpower> !scrumon cpower
14:02:38 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
14:02:54 <bwolfe> power to the scrum
14:02:58 <bwolfe> cpower to the scrum
14:04:08 <cpower> Order: wluyima, suranga, mvorobey, bwolfe, djazayeri, downey, rafa, dkayiwa, lakkarau
14:04:18 <cpower> and anyone I might be missing
14:04:25 <wluyima> Tuesday:
14:04:25 <wluyima> HLQRY-32 - Create the ORUR01 template which produces the complete ORUR01 message
14:04:25 <wluyima> IRC chats with daniel, suranga and ben about a couple of sprint tickets
14:04:25 <wluyima> HLQRY-24(Not yet committed) - Add generic controller method to get any template
14:04:25 <wluyima> Wednesday:
14:04:26 <wluyima> Add unit tests for HLQRY-8 - Create a controller class to get encounters in orur01 hl7 format
14:04:28 <wluyima> design call
14:04:30 <wluyima> Blockers: None
14:04:58 <suranga_> hi: reviewing / assigning tickets, and testing
14:04:59 *** lakkarau_ has joined #openmrs
14:05:02 *** lakkarau has quit IRC
14:05:22 <suranga_> more design discusiions + amendments to design plans
14:05:25 *** lakkarau_ has quit IRC
14:05:39 <suranga_> today : clean up tikets and closing / reopening them
14:05:48 *** lakkarau has joined #openmrs
14:05:49 <suranga_> adding new tickets for unit tests
14:05:56 <suranga_> no blockers :)
14:05:58 <mvorobey> * Completed and closed - TRUNK-3240
14:05:58 <mvorobey> * Committed follow up fix and prepared for closing - TRUNK-3377
14:05:58 <mvorobey> * REPORT-352 - awaiting for mseaton to get information
14:05:58 <mvorobey> * Gonna pick the next ticket from bug fixing swim lane
14:05:58 <mvorobey> No blockers
14:06:10 <bwolfe> uesday
14:06:10 <bwolfe> reviewed scholarship apps
14:06:10 <bwolfe> emails
14:06:10 <bwolfe> minor wiki page updates
14:06:10 <bwolfe> reviewed a few of Mykola's tickets
14:06:11 <bwolfe> triaged 1 ticket (so far)
14:06:13 <bwolfe> reviewed uma's commit
14:06:15 <bwolfe>
14:06:17 <bwolfe> Wednesday
14:06:19 <bwolfe> emails
14:06:21 <bwolfe> triaged a bunch of tickets
14:06:23 <bwolfe> reviewed tickets for rafa, mykola
14:06:25 <bwolfe> univ call
14:06:27 <bwolfe> design call
14:06:29 <bwolfe> pm call
14:06:44 *** harshadura has joined #openmrs
14:06:47 <bwolfe> (no blockers)
14:06:59 <djazayeri> All week
14:07:02 <djazayeri> * lots of calls
14:07:05 <djazayeri> * I-TECH work
14:07:07 <djazayeri> no blockers
14:07:28 <lakkarau> Tuesday:
14:07:29 <lakkarau> HLQRY-26
14:07:29 <lakkarau> HLQRY-43
14:07:29 <lakkarau> Checked for the changes that are to be made in HLQRY-26.
14:07:29 <lakkarau> Wednesday:
14:07:29 <lakkarau> make the nessary changes to the branch HLQRY-26.
14:07:31 <lakkarau> resend both HLQRY-26 and HLQRY-43
14:07:35 <lakkarau> work on the location service new methods and attach the patch.
14:07:37 <lakkarau> no blockers
14:07:47 <bwolfe> djazayeri, you're getting lazy with your updates ;-)
14:08:27 <djazayeri> well, it's more like you all don't really care about the specifics of "I-TECH" work. :-)
14:08:37 <djazayeri> I mean "I-TECH work"
14:08:58 <rafa> whose turn?
14:09:08 <djazayeri> downey:
14:09:12 <djazayeri> (then rafa)
14:09:13 <downey> Tuesday: Exams
14:09:14 <downey> Wednesday: Work & Exams
14:09:14 <downey> Blockers: Exams
14:09:22 <downey> (attempting to beat darius)
14:09:27 <cpower> rafa
14:09:36 <rafa> Today:
14:09:36 <rafa> * Reviewing and back porting committed tickets before the maintenance releases DAY 2
14:09:36 <rafa> * Had a lust to code ;) so reworked TRUNK-2511: When creating a new patient, pre-populate the "Identifier Type" field
14:09:36 <rafa> https://tickets.openmrs.org/browse/TRUNK-2511
14:09:36 <rafa> No blockers.
14:09:41 <cpower> dk
14:09:42 <dkayiwa> Some code review with my GSOC student
14:09:43 <dkayiwa> Reviewed and applied patch for: Should be able to define a privilege required to view or edit an encounter - TRUNK-3377
14:09:43 <dkayiwa> Committed: Create a groovy template to create the OBR Obs group segment of an ORUR01 message - HLQRY-38
14:09:43 <dkayiwa> Committed: Fix / upgrade failing unit tests - HLQRY-44
14:09:43 <dkayiwa> University Call
14:09:44 <dkayiwa> Now working on: Validate the template xml on-save via pseudo parsing through HAPI - HLQRY-2
14:09:44 <dkayiwa> No Blockers
14:10:07 <cpower> ok anyone else want to share?
14:11:13 <cpower> Blockers: downey: Exams (who wants to help him ;-) )
14:11:34 <downey> my blocker will be resolved on friday :)
14:11:47 <suranga_> downey, I will help if I can get into the PHD program too ;-)
14:11:59 <cpower> Discussion topics: None
14:12:01 <dkayiwa> automated blocker :D
14:12:04 <cpower> !scrumoff
14:12:04 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
14:12:12 *** lakkarau has quit IRC
14:12:49 <dkayiwa> u can miss the exam to unblock :)
14:12:55 *** suranga_ has quit IRC
14:13:03 <cpower> yeah, that would be baaaad
14:13:29 <dkayiwa> d:)
14:14:04 <cpower> anyone need me for anything before I sign off for a bit?
14:14:21 <cpower> *trying to be more available to the group*
14:15:34 <cpower> silence goes to whatever answer I want to give....
14:15:49 *** cpower has quit IRC
14:28:05 <jordank> hi jriley, djazayeri… do you know how/ where I can catch a null pointer exception that can happen when submitting a jsp form?
14:28:39 <jriley> jordank , what's happening to make it throw the NPE?
14:29:06 <jordank> jriley: I purposely don't choose two concepts
14:29:17 <jordank> with the search widgets
14:29:34 <jriley> ok, what part of the code is creating the error?
14:30:34 <jordank> I think submitting the form on the chooseConcepts page
14:31:19 <jriley> Ok, and in the error trace, what line in the controller is freaking out
14:37:38 <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @icebrk: @CapeTown @Westlake @Jembi_hs Health Systems working on Open health system @OpenMRS, getting Africa onboard by advancing use ... <http://twitter.com/OpenMRS/statuses/233203852864782336> || On Twitter: OpenMRS: RT @mccallumg: I'm starting to learn how many silent members of the #openMRS community there are around the world. Time to join a call a ... <http://twitter.com/OpenMRS/statuses/233203539588022272>
14:39:59 *** mvorobey has quit IRC
14:42:06 <djazayeri> jordank: do you have something like this? @RequestParam("concept1") Concept one
14:43:04 <jordank> djazayeri: @RequestParam(required=false, value= "oldConceptId") Integer oldConceptId….
14:43:19 <jordank> jriley: sorry, I'm having trouble with goose
14:43:30 <jriley> np
14:44:02 <jriley> jordank, I'm also curious if it's from the @ModelAtribute section
14:44:17 <djazayeri> jordank: the general answer for best usability is that you should catch that sort of error via javascript before submitting the form in the first place.
14:44:25 <djazayeri> e.g. don't allow invalid submissions
14:44:59 <jordank> ooh okay
14:45:12 *** jordank has quit IRC
14:46:44 <djazayeri> jordank: once the submission has already happened, it's a pain to show an error message with good usability. The following doesn't require a ton of extra work, but is still a stack trace: if (oldConceptId == null || newConceptId == null) throw new IllegalArgumentException("You must choose both concepts")
14:48:44 *** jordank has joined #openmrs
14:49:47 <jordank> jriley: the line in my controller that is not happy is "Concept oldConcept = conceptService.getConcept(oldConceptId); "
14:50:55 <jordank> that's after a bunch of lines from hibernate/ service/ dao
14:51:29 *** kishoreyekkanti has joined #openmrs
14:52:09 *** rram_ has quit IRC
14:52:34 *** kishoreyekkanti_ has joined #openmrs
14:53:06 *** judygichoya has joined #openmrs
14:53:14 *** kishoreyekkanti_ has quit IRC
14:53:21 *** kishoreyekkanti has quit IRC
14:53:32 *** kishoreyekkanti has joined #openmrs
14:54:56 <jriley> jordank, so is that in your preview method?
14:55:05 <jordank> right
14:57:05 <jordank> jriley: so I should try/ catch that in my preview method, or catch that situation using javascript like Darius suggested?
14:57:06 <jriley> Ok. It's also good practice to make sure everything's ready to go before getting down to business. So at the beginning of preview(), do a couple checks that the required parameters are sent in. If they're missing, send the user back to choose concepts and show an error message, so they can try again
14:58:22 <jriley> Well, you can make the call about javascript. How does that rank compared to the other features in this week's iteration?
14:58:40 *** dkayiwa has quit IRC
14:59:18 <jriley> I would scold the user rather than a try/catch. It's easy to see that the problem is the user missed something
14:59:35 <jriley> Hey, what happens if you make that required flag = true for the request param?
15:00:00 <jriley> for preview it isn't optional
15:00:01 <jordank> api exception I think
15:00:10 *** harshadura has quit IRC
15:00:18 <jordank> some kind of exception
15:00:19 <jriley> Hum! How interesting!
15:00:45 <jriley> exceptions are ugly and distressing to users. I recommend redirecting with a scolding.
15:01:05 <jriley> "Now Timmy, in our family we always send in both concept ids. Let me see you do that again."
15:01:13 <jriley> GOOD JOBBBB!
15:01:24 <jordank> hahahah
15:01:27 <jordank> :)
15:02:12 *** judygichoya has left #openmrs
15:02:22 <jriley> Javascript is even gentler and nicer, but you decide how that fits into your sprint this week
15:03:01 <jordank> you should come teach at Creighton.
15:03:36 <jordank> jriley: we didn't really talk about this as part of this week's iteration, but it is ugly and distressing to me too
15:03:41 <djazayeri> bwolfe: by the way, what's the plan/schedule for github migration again?
15:03:51 <jriley> And then you might check your other controller methods to see if they need to do the same kinds of things
15:05:36 <jriley> jordank, exceptions look so fierce on the UI, like you really broke something badly. If it's a method talking to another method, sure, throw an exception. It can be a clear way to communicate to another method what went wrong.
15:07:00 <jordank> jriley, okay
15:07:21 <shortend> Haha... fierce-looking exceptions.
15:08:23 *** Jibesh has joined #openmrs
15:14:18 <jordank> jriley: when I tried checking at the beginning of preview(), I got a null pointer at this line…. "if(oldConceptId.equals(null) || newConceptId.equals(null)){"
15:14:39 <jordank> is there a better way to do that ^ ?
15:15:00 <jriley> Yes, if oldConceptId == null .
15:15:17 <jordank> even though it's an Integer?
15:15:26 <jriley> The problem is you're calling .equals
15:15:52 <jriley> oldConceptId is an Integer object - since it's a null object, Java doesn't know how to call its equals method and throws the NPE
15:16:12 <jriley> You want to check if oldConceptId was assigned anything at all - so you say if oldConceptId == null
15:16:56 <jriley> NULL.equals() throws an NPE, because NULL doesn't have a method called equals.
15:17:58 <jordank> jriley: makes sense… I'll try that
15:19:46 <jordank> jriley: that worked! thanks :) I'm going to say that's good for this week & think about javascript later
15:20:02 <jriley> cool
15:20:28 *** harshadura has joined #openmrs
15:27:51 *** shortend has left #openmrs
15:39:23 *** pulasthi7 has joined #openmrs
15:40:23 *** rafa has quit IRC
15:41:26 *** kishoreyekkanti has quit IRC
15:59:02 *** rram_ has joined #openmrs
15:59:15 <downey> Hi rram_ and welcome to the #openmrs IRC channel.
16:01:04 *** rram_ has quit IRC
16:09:24 *** rfriedman has joined #openmrs
16:09:41 <rfriedman> bwolfe, hey ben
16:10:19 <rfriedman> downey, hey mike
16:23:57 *** r0bby has joined #openmrs
16:23:57 *** ChanServ sets mode: +v r0bby
16:25:30 *** robbyoconnor has quit IRC
16:31:07 *** kreddy has joined #openmrs
16:39:17 *** suranga has joined #openmrs
16:39:17 *** ChanServ sets mode: +v suranga
16:40:11 <suranga> hi wluyima , I was testing your managetemplates.jsp page.. mm.. are you using mykolas custom messaging module here ?
16:40:21 <suranga> wluyima, I see tags like <openmrs:message code=
16:40:36 <suranga> hi pulasthi7 :)
16:41:26 <pulasthi7> hi suranga
16:41:57 <suranga> pulasthi7, hi, busy with that upgrade, right ? :)
16:44:24 <pulasthi7> suranga, i did that and committed
16:44:38 <suranga> pulasthi7, woo hooo ! really !
16:44:51 <suranga> pulasthi7, did you test it out thourougly too ?
16:44:54 <bwolfe> hi rfriedman
16:45:59 <pulasthi7> suranga, i did a some quick tests and seems ok. now i'm going to do some thorough tests
16:46:15 <suranga> pulasthi7, cool, let me knoe how it goes
16:47:14 <downey> Hi rfriedman - sorry to have missed you
16:47:14 <pulasthi7> suranga, ok :-)
16:48:30 *** wyclif has joined #openmrs
16:48:30 *** wluyima has quit IRC
16:48:40 *** wyclif has quit IRC
16:48:52 *** wyclif has joined #openmrs
16:50:06 <suranga> hi wyclif :)
16:50:17 *** lh has quit IRC
16:50:21 <wyclif> hi suranga
16:50:39 <suranga> wyclif, sorry, did you see my mesage above ? ^^
16:50:47 <suranga> hi wluyima , I was testing your managetemplates.jsp page.. mm.. are you using mykolas custom messaging module here ?
16:50:53 <suranga> wluyima, I see tags like <openmrs:message code=
16:51:26 *** lh has joined #openmrs
16:51:26 *** lh has joined #openmrs
16:52:56 <wyclif> suranga, no
16:53:12 <wyclif> suranga, i have no template with message codes
16:53:37 <suranga> wyclif, umm... did you create the managetemplates.jsp page ?
16:53:53 <wyclif> suranga, oh you mean that?
16:54:26 <suranga> wyclif, yep, umm... arnt we supposed to be using spring.message code=
16:56:27 <rfriedman> bwolfe, hi, can you do 10:30 or 11 on Fri?
16:57:03 <rfriedman> downey, hi mike, any firming up of pre/post Implementers Meeting activities?
16:57:04 <wyclif> suranga, yeah those should be spring message tags, nice catch, i didnt even realize i used those
16:57:48 <suranga> wyclif, actually, it took me some time to notice it too :)
16:58:31 <bwolfe> rfriedman, 10:30 should be doable
16:58:53 <rfriedman> bwolfe, great, sorry for all the changes
17:00:05 <downey> rfriedman: the hackathon dates should be finalized by 10th
17:00:37 <downey> rfriedman: & site visits (part of the conference schedule) will be hopefully available by the 17th
17:01:15 <rfriedman> downey, tks, i will wait to make my plane reservations until i hear more
17:01:27 <rfriedman> downey, i had a problem with the registration form, it wouldn't show the early bird rate
17:01:39 *** lh has quit IRC
17:02:23 <downey> rfriedman: fyi if you want to stalk the process, a large portion of it is happening in the eventplanning@ group. https://groups.google.com/a/openmrs.org/forum/?fromgroups#!forum/eventplanning
17:02:27 <OpenMRSBot> <http://ln-s.net/$aTb> (at groups.google.com)
17:02:41 *** goutham has joined #openmrs
17:02:49 <rfriedman> downey, tks, helpful
17:03:07 <downey> rfriedman: you're also welcome to join if you would like to assist etc. :)
17:08:41 *** lakkarau has joined #openmrs
17:10:33 <lakkarau> bwolfe:hi
17:11:43 <bwolfe> hi lakkarau
17:12:11 <lakkarau> bwolfe:after i followed the steps regarding the HLQRY-43 after creating the new branch when i check the code i dont see the HL7TempleteFunction class file and its test class file
17:14:26 <bwolfe> lakkarau, did you pull the upstream onto your master before creating the new branch?
17:14:37 <lakkarau> bwolfe:yes
17:14:44 <bwolfe> lakkarau, do "git pull upstream master" on your branch now
17:15:10 <lakkarau> bwolfe :ok
17:17:23 <bwolfe> did anything come in as an update?
17:17:39 <bwolfe> lakkarau, are you using egit in eclipse or using the command line?
17:20:13 *** lakkarau has quit IRC
17:22:38 <rfriedman> downey, I don't think I can do much before the event, but I do intend to be there through the whole thing and if there's any way I can help, please feel free to call on me
17:23:02 *** applecool has joined #openmrs
17:23:02 *** ChanServ sets mode: +v applecool
17:24:06 *** r0bby is now known as robbyoconnor
17:24:28 *** lh has joined #openmrs
17:24:28 *** lh has joined #openmrs
17:31:52 <suranga> wyclif, um sorry, you are moving from openmrs:messages to spring:messages, right ?
17:32:28 *** harshadura has quit IRC
17:32:38 <wyclif> suranga, am not working on that right now
17:33:16 <suranga> wyclif, cool, its not urgent, as long as it happens sometime along the line :)
17:35:08 *** applecool has quit IRC
17:39:43 *** robbyoconnor has quit IRC
17:44:10 <suranga> hi bwolfe , for a url to map to a controller, it only needs a) the @controller annotation, the request mapping, the <context:component-scan and the spring .DefaultAnnotationHandlerMapping bean, right ? :)
17:45:31 *** harshadura has joined #openmrs
17:45:48 <bwolfe> suranga, I think so. make sure the requestmap is right
17:46:01 <bwolfe> and I don't know if hte defaultannotationhandlermap bean is needed. which one is that you are referring to?
17:46:42 <suranga> bwolfe, do you like this url ? @RequestMapping(value = "module/hl7query/ORUR01?
17:47:34 <bwolfe> then accessed by openmrs/module/hl7query/ORUR01.htm or .list or .form
17:47:37 <suranga> bwolfe, umm.. to identify annotations, we need to specify the <bean class="org.springframework.web.servlet.mvc.annotation.DefaultAnnotationHandlerMapping"/> bean, right ?
17:47:49 <bwolfe> suranga, I think core does that already
17:48:00 <bwolfe> you only need it once across all spring app context files
17:48:11 <suranga> bwolfe, ah, I will check. I wanted to see if you liked my url :)
17:49:34 <bwolfe> suranga, thats as good as any. :-)
17:50:45 *** pulasthi7 has quit IRC
17:55:08 *** jordank has quit IRC
17:55:08 *** deadpool has quit IRC
17:55:08 *** djazayeri has quit IRC
17:58:00 *** jordank has joined #openmrs
17:58:00 *** deadpool has joined #openmrs
17:58:00 *** djazayeri has joined #openmrs
17:58:00 *** zelazny.freenode.net sets mode: +o djazayeri
17:58:12 *** jriley has quit IRC
18:00:06 *** bwolfe has quit IRC
18:01:15 *** goutham has quit IRC
18:02:22 *** downey has quit IRC
18:02:28 *** downey_ has joined #openmrs
18:02:28 *** ChanServ sets mode: +o downey_
18:03:00 *** wyclif has quit IRC
18:04:14 <kreddy> suranga, Are you joining the design call?
18:04:28 <suranga> kreddy, yeap, thats in 30 mins, right ?
18:04:41 <kreddy> suranga, nope. Its right now
18:04:46 <suranga> ooops
18:04:51 <suranga> kreddy, logging in
18:04:55 *** bwolfe has joined #openmrs
18:04:55 *** ChanServ sets mode: +o bwolfe
18:04:56 <kreddy> suranga, thanks
18:17:13 *** mvorobey has joined #openmrs
18:17:51 *** wyclif has joined #openmrs
18:20:06 *** rram_ has joined #openmrs
18:21:47 <mvorobey> bwolfe, hi
18:25:27 <bwolfe> hi
18:35:27 *** dkayiwa has joined #openmrs
18:39:15 <mvorobey> bwolfe, I saw that you put a comment on TRUNK-3377. From that comment I understand that we firstly need to create new ticket for improvements you've outlined there and then we will be able to close TRUNK-3377, right?
18:39:46 *** downey_ has quit IRC
18:39:52 *** downey has joined #openmrs
18:39:52 *** ChanServ sets mode: +o downey
18:39:52 *** OpenMRSBot sets mode: +o downey
18:42:55 *** dkayiwa_ has joined #openmrs
18:44:54 *** dkayiwa has quit IRC
18:44:55 *** dkayiwa_ is now known as dkayiwa
18:45:11 <mvorobey> djazayeri, hey
18:45:43 <suranga> dkayiwa, hellooo
18:45:48 <dkayiwa> suranga: hi
18:45:54 <suranga> dkayiwa, you missed our design calll :)
18:45:59 <suranga> ha haa
18:46:00 <dkayiwa> suranga: am on
18:46:01 <dkayiwa> :)
18:46:13 <suranga> ah, i see :)
18:46:54 <djazayeri> mvorobey: I'm on design call now
18:46:59 <djazayeri> what's up?
18:49:23 <mvorobey> djazayeri, np, just noticed that RESTWS-218 (about custom rep) is still not claimed by anyone, so, just decided that it's waiting for me :) gotta be really tough ticket by the way ...
18:51:39 <suranga> hi wyclif .. sorry, me again...
18:52:06 <bwolfe> !ticket TRUNK-3377
18:52:07 <OpenMRSBot> bwolfe: [#TRUNK-3377] Should be able to define a privilege required to view or edit an encounter - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3377
18:52:58 <mvorobey> djazayeri, and also gotta be very interesting and will improve the skill, so if it won't be picked by someone during the first week of next sprint, it would be honor for me to work om it and I'll rely on your support in this stuff
18:53:17 <mvorobey> om = on
18:53:25 *** Jibesh has quit IRC
18:54:27 *** james_regen has left #openmrs
18:55:09 *** Magoo_ has joined #openmrs
18:58:11 *** mvorobey has quit IRC
19:08:38 *** maurya has quit IRC
19:14:00 *** goutham has joined #openmrs
19:14:17 *** maurya has joined #openmrs
19:14:59 *** jordank has quit IRC
19:15:16 *** Magoo_ has quit IRC
19:17:58 *** magoo_ has joined #openmrs
19:20:08 *** maurya has quit IRC
19:26:59 <wyclif> hi suranga
19:27:11 <suranga> hi wyclif
19:27:21 <bwolfe> mvorobey, yes, you can create those other tickets and close 3377
19:27:31 <suranga> i was wondering which tasks you were planning to complete + commit today :)
19:27:33 <bwolfe> oh, guess I should have hit enter on that sooner. :-(
19:29:53 <suranga> wyclif, I just switched from openmrs:message to spring:message
19:29:56 <goutham> hi dkayiwa
19:30:03 <dkayiwa> hi goutham
19:30:04 <suranga> wyclif, i guess you will be finishing 24 ?
19:30:37 <goutham> dkayiwa: i made the commit related to controller tests
19:30:45 <dkayiwa> goutham: all of them?
19:30:58 <goutham> dkayiwa: yes four of them
19:31:08 <dkayiwa> goutham: oh thats great
19:31:36 <dkayiwa> goutham: so what is remaining among the review issues?
19:32:21 *** rram_ has quit IRC
19:32:35 <goutham> dkayiwa: should i remove author from liquibase and pom.xml ?
19:33:59 <dkayiwa> goutham: for liquibase, leave it :)
19:34:10 *** goutham_ has joined #openmrs
19:34:12 <wyclif> suranga, ok
19:34:26 <goutham> dkayiwa: parent pom.xml ?
19:34:28 <wyclif> suranga, am still working on the tests for HLQRY-8
19:34:38 *** goutham_ has quit IRC
19:34:49 <dkayiwa> goutham: you can leave the pom
19:34:57 <wyclif> suranga, HLQRY-24 is fairly easy
19:35:02 <dkayiwa> goutham: so do i consider it all done?
19:35:12 <wyclif> suranga, i will have to un assign myslef from it if i dont get time
19:35:31 <suranga> wyclif, from 24 ? ok...
19:35:36 <wyclif> suranga, yeah
19:35:43 <goutham> dkayiwa: yes
19:35:49 <suranga> wyclif, do you think testing ticket 6 will take a lot of time ?
19:35:49 * goutham finger crossed
19:36:12 <dkayiwa> goutham: ok thanks let me review and get back to you :)
19:36:48 <goutham> dkayiwa: i have a question about who can assign filters ? what privilege should he have?
19:37:04 <wyclif> suranga, i thought those already have tests
19:37:39 <dkayiwa> goutham: how the same privileges are require to manage forms?
19:38:06 <dkayiwa> goutham: how about the same privileges as required to manage forms?
19:38:32 <goutham> dkayiwa: that would be perfect :)
19:39:07 <dkayiwa> goutham: so are you adding that?
19:39:12 <dkayiwa> now?
19:39:18 <goutham> dkayiwa: yes will add now.
19:39:30 <dkayiwa> goutham: ok tell me after you commit :)
19:39:30 *** magoo_ has quit IRC
19:40:10 <goutham> dkayiwa: i wrote service test in api and controller tests in omod . Is that fine ? i think previously all the tests are included in omod
19:40:29 <dkayiwa> goutham: yes very fine!!!
19:41:02 <goutham> dkayiwa: ok
19:41:18 <dkayiwa> goutham: so waiting for your other commit :)
19:41:21 *** magoo_ has joined #openmrs
19:41:40 <goutham> yes dkayiwa , given me 5min
19:41:51 <dkayiwa> goutham: ok
19:42:25 *** mvorobey has joined #openmrs
19:45:01 <suranga> dkayiwa, so based on the call we just had, tomorrow is going to be a loong day :-)
19:45:16 <suranga> dkayiwa, we're loosing wyclif tonight too :-(
19:45:20 <dkayiwa> why :)
19:45:23 <dkayiwa> suranga: oh
19:45:42 <dkayiwa> suranga: because of fewer tickets
19:46:04 <suranga> dkayiwa, because he is escaping to go on holiday :P
19:46:19 <dkayiwa> suranga: hahahaha :D
19:46:29 <suranga> dkayiwa, the problem is, even though the tickets have been trimmed down, some of the inner functionality is not exactly workin
19:46:44 <suranga> dkayiwa, did you hear what they said about changes to your OBS grouper ?
19:46:54 <dkayiwa> suranga: can you create tickets for that?
19:47:08 <suranga> dkayiwa, we can simply remove / ignore the OBR-ENc, its no longer needed at all
19:47:20 <dkayiwa> suranga: ok
19:47:23 <suranga> dkayiwa, will do, i wanted to check if you understood what needed to be done...
19:47:39 <dkayiwa> suranga: ok
19:48:34 <downey> lh: ping
19:49:40 <dkayiwa> suranga: do you think i should leave HLQRY-2 and jump onto those tickets?
19:49:51 <suranga> dkayiwa, yes, definitely
19:50:02 <lh> downey, pong
19:50:08 <lh> mail received, it's in my queue for today
19:50:34 <suranga> dkayiwa, lets just forget the UI totally for now... my target is, if the user makes a GET request, he gets a valid xml as response
19:50:59 <dkayiwa> suranga: ok create and i immediately jump onto them
19:51:18 <suranga> dkayiwa, tomorrow, after you fix that changes to the template, lets work on getting the controlller up and running for requests :)
19:51:41 <suranga> dkayiwa, umm.. u dont want to jump at them right now, right ?
19:51:48 <suranga> its 1.30 am my time :P
19:52:40 *** dkayiwa_ has joined #openmrs
19:52:42 *** dkayiwa has quit IRC
19:52:43 *** dkayiwa_ is now known as dkayiwa
19:52:53 <dkayiwa> suranga: can you put the comments of what i need to do on the existing tickets?
19:53:07 <suranga> dkayiwa, sure thing :)
19:53:18 <dkayiwa> suranga: waiting.... :)
19:53:39 <suranga> dkayiwa, whats the ticket number again, plese ?
19:53:47 <dkayiwa> 38
19:55:21 *** magoo_ has quit IRC
19:56:16 *** dkayiwa_ has joined #openmrs
19:56:44 <dkayiwa_> suranga: HLQRY-38
19:56:47 <dkayiwa_> !ticket HLQRY-38
19:56:48 <OpenMRSBot> dkayiwa_: [#HLQRY-38] Create a groovy template to create the OBR Obs group segment of an ORUR01 message - OpenMRS JIRA - https://tickets.openmrs.org/browse/HLQRY-38
19:57:25 *** dkayiwa has quit IRC
19:57:26 *** dkayiwa_ is now known as dkayiwa
19:58:15 <suranga> dkayiwa, bwolfe , added comment to hl7qry - 38 based on the new changes
19:58:38 <dkayiwa> suranga: on the ticket in JIRA?
19:58:47 <dkayiwa> ok
19:58:59 <suranga> dkayiwa, yep, that one :)
19:59:15 <dkayiwa> ok
20:01:40 <suranga> hi bwolfe :-(
20:02:02 <bwolfe> why do you say hi with a sad face ?!
20:02:21 <goutham> dkayiwa: i made the commit .
20:02:28 <suranga> bwolfe, well, my planning does not seem to be all that good.. :(
20:02:33 <dkayiwa> goutham: ok let me update now. thanks :)
20:02:44 <bwolfe> suranga, meh. it happens. often changes happen after coding
20:02:50 <bwolfe> you're still batting a 90% or so :-)
20:03:07 <suranga> bwolfe, djazayeri i wrote up a new model for the hl7 message, with the changes you mentioned
20:03:08 <bwolfe> gotta run, email me questions or find me later tonight suranga
20:03:09 *** downey has quit IRC
20:03:20 <suranga> bwolfe, oh, sure, will mail you..
20:03:21 <bwolfe> suranga, awesome, where is it?
20:03:28 <suranga> bwolfe, djazayeri https://wiki.openmrs.org/display/projects/The+new+structure+of+the+ORUR01+message
20:03:41 *** downey has joined #openmrs
20:03:41 *** ChanServ sets mode: +o downey
20:03:41 *** OpenMRSBot sets mode: +o downey
20:03:55 <suranga> bwolfe, message contains two encounters, each with three ungrouped obs, and 3 grouped ones
20:04:01 <bwolfe> suranga, haha, why not the old page?
20:04:28 <suranga> bwolfe, umm.. I edited the page which contained the old message i just sent you :P
20:04:36 <dkayiwa> suranga: old page sounds better :)
20:04:49 <bwolfe> suranga, oh, you edited + renamed ?
20:04:59 <suranga> bwolfe, dkayiwa yeappp
20:05:07 <bwolfe> ok, np
20:05:11 <bwolfe> ok, leaving now
20:05:25 <suranga> bwolfe, cool, will try to catch u later
20:05:33 *** wyclif has quit IRC
20:06:45 *** bwolfe has quit IRC
20:08:37 <dkayiwa> suranga: can you now look into how we can make it run on 1.6?
20:08:45 <dkayiwa> sorry i meant goutham
20:08:51 <dkayiwa> :)
20:08:58 <dkayiwa> goutham: can you now look into how we can make it run on 1.6?
20:09:27 <dkayiwa> goutham: if it requires a lot, then we can raise required version to 1.7
20:10:31 <suranga> dkayiwa, umm.. is that a major requirement ?
20:10:47 <dkayiwa> suranga: was meant for goutham :)
20:10:49 <suranga> aaah, right I see dkayiwa
20:11:11 <goutham> dkayiwa: yes , i am trying to do but where i should commit those changes. Should i start a branch ?
20:11:49 <dkayiwa> goutham: i thought we are committing same place????
20:12:33 *** sunbiz has joined #openmrs
20:12:33 *** ChanServ sets mode: +v sunbiz
20:12:35 <dkayiwa> goutham: did you update the user guide wiki page?
20:12:39 <mvorobey> bwolfe, hey, sorry, my connection is choppy, so I might missed your answer on my question about TRUNK-3377
20:13:28 <goutham> dkayiwa:i think the dependencies for openmrs 1.6 and 1.8 are different
20:13:50 <dkayiwa> goutham: how about 1.7?
20:15:14 <dkayiwa> goutham: can you add some punctuations (like commas) for the using form filter module wiki page?
20:15:43 <goutham> dkayiwa: for 1.7 and above they are same , i think
20:16:01 <dkayiwa> goutham: did you test and confirm so?
20:16:41 <goutham> dkayiwa: no i dint test yet
20:17:31 <goutham> dkayiwa: will update using form filter module wiki page.
20:17:32 <dkayiwa> goutham: you need to test that such that we change the required module version
20:17:56 <dkayiwa> goutham: such that we change the required openmrs version
20:18:52 <goutham> dkayiwa: yes will test it.
20:19:00 <dkayiwa> goutham: ok
20:19:41 *** wyclif has joined #openmrs
20:20:19 <dkayiwa> goutham: @should not return FormFilterProperty with given id
20:20:39 <dkayiwa> goutham: why should'nt it?
20:22:12 <goutham> dkayiwa: :) for the given set of input parameters it should not return FormFilterProperty
20:22:29 <dkayiwa> goutham: why not
20:22:52 <dkayiwa> goutham: if it should not, then what is the use of the method?
20:25:40 <goutham> dkayiwa: its not mandatory that for all formFilterPropertyId there is a FormFilteryProperty .
20:26:11 <goutham> dkayiwa: the referenced might be deleted then that function returns null
20:26:22 <goutham> dkayiwa: thats what i want to assert there
20:27:06 <dkayiwa> goutham: then the should text should explicitly mention why it should not return a FormFilterProperty
20:27:27 <dkayiwa> goutham: you can copy this patter from existing unit test in core openmrs
20:27:45 <dkayiwa> goutham: they explicitly mention why it should NOT return a value
20:28:28 <dkayiwa> goutham: does this make sense?
20:28:53 <goutham> dkayiwa: ok. I dint notice it specifically. Thanks for pointing it.
20:29:12 *** jordank has joined #openmrs
20:29:17 <goutham> dkayiwa: will look back to openmrs core again
20:29:25 <dkayiwa> goutham: ok
20:29:39 <dkayiwa> goutham: how is updateFormFilterProperty different from saveFormFilterProperty ?
20:33:17 <goutham> dkayiwa: where are these methods mentioned ?
20:33:48 <dkayiwa> goutham: in FormFilterService
20:34:18 <dkayiwa> am wondering why in some instances you have update.... while others you have save.... (as method names)
20:35:16 <goutham> dkayiwa: i am unable to find saveFormFilterProperty method
20:35:46 <dkayiwa> goutham: ok let me ask this way
20:35:47 <goutham> dkayiwa: there is only one saveFormFilter method in it
20:36:09 <dkayiwa> goutham: why do you have saveFormFilter instead of updateFormFilter?
20:39:20 <goutham> dkayiwa: my point of view was , updateFormFilterProperty should update only an existing FormFilterProperty
20:40:15 <dkayiwa> goutham: how about updating an existing FormFilter?
20:41:22 <goutham> dkayiwa: i dint add saveFormFilterProperty because if a user want to save a formFilterProperty he has to use addFormFilterProperty(int, FormFilterProperty) method
20:41:43 <goutham> dkayiwa: to update a FormFilter he can use saveFormFilter(FormFilter)
20:42:05 <suranga> wyclif, hi.. one final comment, if you dont mind :)
20:42:08 <dkayiwa> goutham: the convention we have is the the methods save..... (both save a new and existing item)
20:42:32 <dkayiwa> goutham: if you look in the core openmrs services, if you see an update... method, it is deprecated
20:42:43 <dkayiwa> goutham: so can we also follow the same convention? :)
20:43:10 <goutham> dkayiwa: yes thats y FormFilter has a save and FormFilterProperty dont
20:43:24 <dkayiwa> goutham: so can we remove the update..... method?
20:44:11 <goutham> dkayiwa: but i dont want a user to just save a new FormFilterProperty
20:44:40 <dkayiwa> goutham: yes they can save an existing one using a save... method. not so?
20:45:34 <goutham> dkayiwa: but what if a user want to save a new one using this save method
20:46:01 <dkayiwa> goutham: yes the save should handle both new and existing ones
20:46:28 <dkayiwa> goutham: can you look at for instance the openmrs ConceptService.saveConcept(Concept) ?
20:46:45 <dkayiwa> goutham: it is used when saving a new concept and also when updating an existing one
20:47:57 <goutham> dkayiwa: Ok will change it.
20:50:37 <dkayiwa> goutham: ok good :)
20:51:09 <dkayiwa> goutham: i still see the user guide wiki page stating that the module depends on the formentry module
20:53:21 <goutham> dkayiwa: Removed now.
20:53:46 <dkayiwa> goutham: did you also mention about doing filters using the form schema screen?
20:54:55 <goutham> dkayiwa: Its under the note at the bottom of Using form filter module
20:55:07 <goutham> dkayiwa: Note title"
20:55:20 <dkayiwa> goutham: can you also include a screenshot for it?
20:56:51 <goutham> dkayiwa: Its there https://wiki.openmrs.org/display/projects/Using+Form+Filter+Module . The link is marked yellow in that screen shot
20:57:29 <dkayiwa> goutham: oh i see thanks :)
20:57:54 <dkayiwa> goutham: can you look at the unit tests for the different types of filters?
20:58:02 <dkayiwa> goutham: their names need to be changed
20:58:29 <dkayiwa> goutham: for instance a method name like shouldNotDisplayForm() needs to add why it should not display the form
20:58:37 <dkayiwa> goutham: does this make sense? :)
20:59:35 <goutham> dkayiwa: i will give an example let me know if iam on right track
20:59:47 <dkayiwa> goutham: ok shoot :)
21:00:36 <dkayiwa> goutham: infact they should match with your already existing @should :)
21:01:01 <dkayiwa> goutham: for instance am looking at your CohortFormFilter
21:01:33 <dkayiwa> goutham: and the should states well why it should not display the form. So the test method name needs to match the should
21:01:45 <dkayiwa> goutham: just like you did for the service interface
21:01:54 <goutham> dkayiwa:ok lately i got to know that @should can be as descriptive as possible
21:02:34 <dkayiwa> goutham: yes we do all we can to make things as clear as possible to everyone who looks at the code :)
21:02:50 <goutham> dkayiwa: :)
21:03:16 <dkayiwa> goutham: so the module is working pretty well and we are now cleaning the code :)
21:04:06 <goutham> dkayiwa: :)))))))))))))))
21:04:17 <dkayiwa> :)
21:06:44 <dkayiwa> goutham: so you will do that for all the filter type tests?
21:07:25 <goutham> dkayiwa: yes i started doing it also :)
21:07:34 <dkayiwa> goutham: ok great :)
21:08:15 <goutham> dkayiwa: can you once go to PersonFormFilterEntryPortletControllerTest
21:08:29 <dkayiwa> goutham: ok
21:09:46 <goutham> dkayiwa: controller.populateModel(request, model); always return empty list
21:10:23 <goutham> dkayiwa: its because the controller code will look for FormEntryHandler extensions
21:10:50 <goutham> dkayiwa: and in test cycle there are nothing present
21:11:12 <dkayiwa> goutham: ok. let me look into that and give a suggestion :)
21:11:27 <goutham> dkayiwa: ok
21:11:29 <goutham> :)
21:14:31 <dkayiwa> goutham: can you change the openMRSVersion in the pom to 1.7.0?
21:15:36 <goutham> dkayiwa: will test it now
21:16:25 <dkayiwa> goutham: ok try it out and tell me :)
21:21:43 *** scsibug has joined #openmrs
21:21:50 <downey> Hi scsibug and welcome to the #openmrs IRC channel.
21:23:43 <scsibug> downey: thanks :)
21:24:30 <dkayiwa> goutham: can you upload version 0.9 of the module to the openmrs module repository and then send out and email to the implementers and dev lists for people to test it out?
21:24:58 <dkayiwa> goutham: same way as mvorobey has done for his module :)
21:25:53 <dkayiwa> goutham: do you think you can do that before you sleep? You can finish the unit tests tomorrow :)
21:25:58 <goutham> dkayiwa: after making the changes
21:26:22 <dkayiwa> goutham: you can do the changes tomorrow but upload the module today
21:26:34 <dkayiwa> goutham: since those changes do not affect the functionality
21:26:54 <goutham> dkayiwa: ok then should the dependent openmrs version be 1.7 or 1.8
21:27:11 <dkayiwa> goutham: does changing to 1.7 compile?
21:28:22 <goutham> dkayiwa: no
21:28:36 <dkayiwa> goutham: then make it 1.8.0 and upload
21:28:55 <goutham> dkayiwa: Ok :)
21:29:14 <dkayiwa> goutham: waiting for the email... :D
21:29:43 <dkayiwa> goutham: also in the email, remember to point them to the users guide wiki page
21:29:47 *** rfriedman has quit IRC
21:29:55 <dkayiwa> goutham: and ask them for feedback
21:30:04 <goutham> dkayiwa: ok
21:30:09 <goutham> :)
21:30:26 <dkayiwa> goutham: thanks!!!! :D
21:30:35 <mvorobey> dkayiwa, hey, what's up ? how you doing ? why you aren't sleeping yet ? :)
21:30:57 <dkayiwa> mvorobey: because i want to maximize goutham 's time :)
21:31:54 *** downey has quit IRC
21:31:56 *** snoppy has left #openmrs
21:32:39 <mvorobey> dkayiwa, ah, that's great! but you also need to sleep because tomorrow i'll bring you lots of new questions :D
21:33:13 <dkayiwa> mvorobey: ahahha. will sleep immediately he uploads the module and sends out an email to dev and impl lists :)
21:34:22 <mvorobey> dkayiwa, BTW, what time's it in Uganda ?
21:34:54 <dkayiwa> mvorobey: 20 mins to 1am :)
21:36:00 <mvorobey> dkayiwa, cool, now I'm sure that we are in the same time zone :) just thought that you are 1h before mine :D
21:36:33 <dkayiwa> mvorobey: in that case, why don't you also sleep? :)
21:37:35 *** wyclif has quit IRC
21:39:55 <mvorobey> dkayiwa, mine reason is simple - trying to get into REPORT-352, but without mseaton am feeling so helpless ...
21:40:18 <dkayiwa> mvorobey: did you try out djazayeri :)
21:40:39 <mvorobey> dkayiwa, so simply waiting 1AM, if he show up :D
21:40:44 <goutham> dkayiwa: do you want me to release the module by mvn release:perform/prepare or upload .omod to openmrs.module repository
21:40:52 <mvorobey> dkayiwa, no I did not :)
21:41:06 <dkayiwa> goutham: do whichever is easier for you :)
21:41:16 <mvorobey> dkayiwa, he might be on a call right now
21:41:28 <dkayiwa> mvorobey: maybe you will feel more helpful when you do :)
21:41:42 <djazayeri> mvorobey: I am not on a call anymore
21:41:59 <dkayiwa> mvorobey: hahahha. yes he is a call addict. but not now :)
21:42:06 <dkayiwa> !ticket REPORT-352
21:42:07 <OpenMRSBot> dkayiwa: [#REPORT-352] Provide ability to stop reports during the course of an execution - OpenMRS JIRA - https://tickets.openmrs.org/browse/REPORT-352
21:42:42 <mvorobey> djazayeri, great, so, bwolfe's solution for problem outlined in that ticket isn't so good
21:42:42 <djazayeri> mvorobey: do you have a specific question about it? In general I think that ticket is hard, and I haven't thought about it much. :-)
21:43:10 <dkayiwa> :D
21:43:56 <mvorobey> djazayeri, no, no specific questions yet, I thought that mseaton could help me with it, so will better wait for him if he shows up :)
21:44:42 <dkayiwa> mvorobey: even then, you will need to tell him what exactly you need him help you with :)
21:45:08 <djazayeri> right, I don't think anyone really knows the solution to this...
21:46:21 <mvorobey> djazayeri, dkayiwa rafa made an assumption that we can fix it by rolling back a transaction and closing the Hibernate session used by a scheduler thread from some other thread, but I did not really get what he meant ...
21:46:59 <dkayiwa> mvorobey: a good starting step is ask on the ticket. :)
21:47:32 <mvorobey> dkayiwa, thanks, then will do it tomorrow :)
21:47:36 <dkayiwa> mvorobey: and then also add as many watchers as you think would be helpful :)
21:48:34 <mvorobey> dkayiwa, hahaha :D will do it, thanks, gotta go sleep, bye guys!
21:48:57 *** mvorobey has quit IRC
21:48:58 <dkayiwa> mvorobey: have a good night and dream about REPORT-352 :D
21:54:32 *** sunbiz has quit IRC
22:01:18 <dkayiwa> goutham: how is it going?
22:02:43 <goutham> dkayiwa: doing mvn release
22:02:52 <dkayiwa> goutham: ok
22:04:32 <dkayiwa> goutham: i think you can do the rest without my help?
22:04:41 <dkayiwa> goutham: looks like i need to sleep :)
22:05:09 <goutham> dkayiwa: Ya its late for you. Good night :)
22:05:20 <dkayiwa> goutham: sure thanks :0
22:05:29 <goutham> dkayiwa: have a look at the mail in the morning :)
22:05:39 <dkayiwa> goutham: feel free to ask anyone here incase of anything
22:05:51 <dkayiwa> goutham: oh i can't wait!!! :D
22:05:59 <goutham> dkayiwa: sure
22:06:22 *** dkayiwa has quit IRC
22:15:42 *** lh has quit IRC
22:17:13 *** lakkarau has joined #openmrs
22:26:10 *** scsibug has quit IRC
22:29:22 *** goutham has quit IRC
22:43:07 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Form Filter Module 0.9 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=formfilter&ampversion=&amp0.9>
22:49:14 *** lh has joined #openmrs
22:49:14 *** lh has joined #openmrs
22:52:16 *** suranga has quit IRC
23:13:44 *** lh has quit IRC
23:26:30 *** kreddy has quit IRC