| 00:04:44 | *** r0bby has quit IRC |
| 00:16:26 | *** djazayeri has quit IRC |
| 00:34:10 | *** jordank has joined #openmrs |
| 00:50:31 | *** jordank has quit IRC |
| 00:57:53 | *** jordank has joined #openmrs |
| 00:58:08 | *** kreddy has quit IRC |
| 01:02:03 | *** jordank has quit IRC |
| 01:02:32 | *** jordank has joined #openmrs |
| 01:06:14 | *** mseaton has joined #openmrs |
| 01:06:14 | *** ChanServ sets mode: +v mseaton |
| 01:13:15 | *** jordank has quit IRC |
| 01:53:31 | *** harshadura has joined #openmrs |
| 02:02:55 | *** harshadura has quit IRC |
| 02:27:31 | *** harshadura has joined #openmrs |
| 02:57:13 | *** djazayeri has joined #openmrs |
| 02:57:13 | *** ChanServ sets mode: +o djazayeri |
| 02:58:05 | *** wluyima has joined #openmrs |
| 03:14:52 | *** scsibug has joined #openmrs |
| 03:21:50 | *** mseaton has left #openmrs |
| 03:36:33 | *** jordank has joined #openmrs |
| 03:36:48 | *** suranga has joined #openmrs |
| 03:36:48 | *** ChanServ sets mode: +v suranga |
| 03:44:46 | *** jordank has quit IRC |
| 03:46:07 | <suranga> hi bwolfe . good morning :) |
| 03:47:07 | *** harshadura has quit IRC |
| 04:45:53 | <suranga> hi wluyima :) |
| 04:47:24 | <wluyima> hi suranga |
| 04:47:46 | <suranga> wluyima, thanks for commitng that ticket yesterday. this will help daniels work |
| 04:48:01 | <suranga> wluyima, i didnt have a very close look at it, but it looks quite good :) |
| 05:02:49 | <wluyima> thanks |
| 05:17:37 | *** deadpool has quit IRC |
| 05:19:35 | *** mgielow has joined #openmrs |
| 05:21:11 | *** rram_ has joined #openmrs |
| 05:45:08 | *** judygichoya has joined #openmrs |
| 05:56:00 | *** robbyoconnor has joined #openmrs |
| 05:56:00 | *** ChanServ sets mode: +v robbyoconnor |
| 06:06:02 | *** rram__ has joined #openmrs |
| 06:06:02 | *** rram_ has quit IRC |
| 06:09:34 | *** maurya has joined #openmrs |
| 06:15:50 | *** maurya has quit IRC |
| 06:19:34 | *** maurya has joined #openmrs |
| 06:19:43 | <maurya> djazayeri: is there any way for maintaining the count of observations submitted by the dynamicRepeat ?? |
| 06:32:19 | *** scsibug has quit IRC |
| 06:33:34 | *** mgielow has quit IRC |
| 06:51:15 | *** maurya has quit IRC |
| 06:52:02 | *** maurya has joined #openmrs |
| 07:04:35 | *** maurya has quit IRC |
| 07:21:36 | *** snoppy has joined #openmrs |
| 08:01:28 | *** dkayiwa has joined #openmrs |
| 08:06:55 | <judygichoya> dkayiwa wluyima and djazayeri is there a specific case when one would prefer to use the api calls versus the web services especially when using java to program? |
| 08:07:05 | <judygichoya> and vice versa |
| 08:10:56 | <dkayiwa> judygichoya: an example is when developing an openmrs module :) |
| 08:11:25 | <judygichoya> for a module the api is preferable... |
| 08:11:42 | <judygichoya> but for a complete rewrite of the system..better to use the web services? |
| 08:16:19 | *** foozo has joined #openmrs |
| 08:32:46 | <suranga> hiii dkayiwa ! :) |
| 08:40:57 | *** foozo has quit IRC |
| 08:48:24 | *** Jibesh has joined #openmrs |
| 08:54:55 | <dkayiwa> hi suranga :) |
| 08:55:14 | <suranga> dkayiwa, howdy ! hows it going with 38 ? :) |
| 08:55:20 | <dkayiwa> judygichoya: if it is java, i would find it simpler to use the api jars :) |
| 08:55:50 | <dkayiwa> suranga: not bad. i should be able to commit soon |
| 08:56:23 | <suranga> dkayiwa, that would be awesom, because I already have another ticket picked out for you :) :) :) |
| 08:56:48 | <dkayiwa> suranga: :) |
| 08:57:05 | <dkayiwa> judygichoya: are you trying to do something like that? |
| 08:57:33 | <judygichoya> i just wondered when is it good to go web services |
| 08:57:36 | <judygichoya> versus apis... |
| 08:57:44 | <judygichoya> of course in java they are easier to use |
| 08:58:16 | <dkayiwa> judygichoya: one good example is when you are doing an non java interface (eg php, python, etc) |
| 08:58:54 | <dkayiwa> judygichoya: something to also note is that, our web services do not yet cover everything that the api offers |
| 08:58:58 | *** Jibesh has quit IRC |
| 08:59:05 | <dkayiwa> judygichoya: so you would miss out on plenty |
| 08:59:10 | <dkayiwa> judygichoya: does this make sense? |
| 09:06:34 | <judygichoya> yes |
| 09:06:47 | <judygichoya> so in python /php.. better to try the web service |
| 09:06:49 | <judygichoya> Thanks |
| 09:06:52 | <dkayiwa> judygichoya: yes |
| 09:09:28 | <dkayiwa> suranga: i should have committed yesterday but got taken in lost of IRC :) |
| 09:10:00 | <suranga> dkayiwa, do you mean "but got talking and lost on IRC " :) |
| 09:10:20 | <dkayiwa> suranga: almost :) |
| 09:13:06 | <suranga> dkayiwa, I hope im being supportive enough on this sprint. I havent been able to do a lot of work, unfortunately :( |
| 09:13:26 | <suranga> ah judygichoya ! do you want to pick up a ticket for us ? :):):) |
| 09:13:33 | <dkayiwa> suranga: i think you have done enough |
| 09:13:47 | <dkayiwa> judygichoya: yes :D |
| 09:14:06 | <dkayiwa> ? |
| 09:14:47 | *** rafa has joined #openmrs |
| 09:14:47 | *** ChanServ sets mode: +v rafa |
| 09:26:01 | <judygichoya> ha ha |
| 09:26:13 | <judygichoya> did dkayiwa just become judygichoya? |
| 09:26:19 | <judygichoya> suranga what do u need done? |
| 09:28:46 | <suranga> judygichoya, well.. you are wellcome to pick any you want.. if you want a quick and eassy one, how about https://tickets.openmrs.org/browse/HLQRY-37 |
| 09:33:07 | <dkayiwa> judygichoya: hahahahaha :D |
| 09:40:58 | *** Jibesh has joined #openmrs |
| 09:44:20 | <suranga> it looks like bwolfe fell asleep in front of his laptop today. ANd I thought that I was the only person who did that :) |
| 09:44:38 | <dkayiwa> suranga: i did that yesterday :) |
| 09:45:27 | <suranga> dkayiwa, :D :D its either that, or his son is using his laptop again :) |
| 09:45:56 | <dkayiwa> suranga: the son sleeps more than him :) |
| 09:53:48 | *** maurya has joined #openmrs |
| 10:09:14 | *** judygichoya has quit IRC |
| 10:17:19 | <dkayiwa> suranga: did anyone fix the unit tests whicy wluyima reported to be failing yesterday? |
| 10:24:22 | <suranga> dkayiwa, sorry, I was away :( |
| 10:24:27 | <suranga> dkayiwa, afraid not :( :( |
| 10:24:36 | <suranga> rafa, helooooooooooooo ! |
| 10:24:41 | <rafa> suranga: hi |
| 10:25:17 | <suranga> rafa, will you be sending that liquibase changeset to us before you leave our sprint ? |
| 10:25:27 | <dkayiwa> suranga: ok let me fix them now |
| 10:25:29 | <rafa> suranga: yes |
| 10:26:09 | <rafa> suranga: actually I wanted to suggest to create changesets after all templates are done and verified they work |
| 10:26:29 | <rafa> suranga: because editing them is a pain |
| 10:26:41 | <suranga> rafa, but wont that affect testing of parent templates ? |
| 10:26:56 | <rafa> suranga: no, I setup mocks for that |
| 10:27:16 | <rafa> suranga: no need to go to the db to test them |
| 10:27:16 | *** rram__ has quit IRC |
| 10:27:21 | <rafa> suranga: see MockBaseTest |
| 10:27:33 | *** rram_ has joined #openmrs |
| 10:28:06 | <rafa> suranga: and HL7PatientORUR01TemplateTest for example |
| 10:28:43 | <rafa> suranga: it looks as if templates come from the db, but actually they come from mocks |
| 10:28:43 | *** rram_ has quit IRC |
| 10:29:23 | *** rram_ has joined #openmrs |
| 10:29:48 | <suranga> rafa, mm.. yes, but allmost all the other templates are done now, arnt they ? rafa you could always write the liquibase code, comment it, and commit the commented code for us : ) : ) |
| 10:30:14 | <rafa> suranga: yes, that is fine |
| 10:30:36 | <suranga> rafa, too bad i did not think of it earlier :( |
| 10:31:18 | <suranga> dkayiwa, yay ! I see u are working on the unit tests |
| 10:31:33 | <suranga> dkayiwa, so ticket 38 is done, right ? |
| 10:31:34 | <dkayiwa> suranga: yes because they are a blocker for me :) |
| 10:32:20 | <dkayiwa> suranga: was trying to test it, and the test is not working. so tried to run others, they all did not work |
| 10:32:45 | <dkayiwa> suranga: so fixing those that used to run fine is my way of troubleshooting why mine is not working :) |
| 10:34:22 | *** Jibesh has quit IRC |
| 10:45:41 | *** applecool has joined #openmrs |
| 10:45:41 | *** ChanServ sets mode: +v applecool |
| 10:45:56 | <applecool> Hi rafa :) good afternoon |
| 10:46:02 | <rafa> applecool: hi |
| 10:46:28 | <applecool> didnt commit the code yesterday! will just do it right away |
| 10:47:40 | <rafa> applecool: neither you've entered a ticket about adding fields to edit packge page |
| 10:47:51 | <rafa> applecool: please remember about that |
| 10:48:19 | <applecool> yes |
| 10:49:02 | <rafa> applecool: I changed my mind and only name and description should be editable |
| 10:49:10 | <rafa> applecool: the rest should be only displayed there |
| 10:49:24 | <applecool> okay |
| 10:56:42 | <applecool> rafa: its a new feature? or a bug? |
| 10:56:52 | <rafa> applecool: feature :) |
| 10:56:57 | <applecool> ok |
| 11:01:20 | *** james_regen has joined #openmrs |
| 11:01:20 | *** ChanServ sets mode: +v james_regen |
| 11:06:28 | *** sunbiz has joined #openmrs |
| 11:06:28 | *** ChanServ sets mode: +v sunbiz |
| 11:06:48 | <applecool> rafa: i dont see the Affect Versions,Fix Versions,Priority fields |
| 11:07:13 | <rafa> applecool: they come later when the ticket is prepared for work |
| 11:07:24 | <applecool> oh okay ! |
| 11:07:33 | <applecool> complexity is Low right ? |
| 11:07:34 | <applecool> :) |
| 11:07:41 | <rafa> applecool: right |
| 11:08:05 | <applecool> original estimate? |
| 11:08:09 | <applecool> 2h? |
| 11:08:53 | <rafa> applecool: sounds doable |
| 11:09:13 | <rafa> applecool: I've just added you to approvers so that you can make the ticket ready for work |
| 11:09:25 | <applecool> okay |
| 11:09:46 | <dkayiwa> hi suranga |
| 11:09:59 | <suranga> dkayiwa, helooo |
| 11:10:07 | <dkayiwa> suranga: in hl7, should date be in EAT or CET? |
| 11:10:08 | <applecool> rafa: done |
| 11:10:28 | <suranga> dkayiwa, umm... sorry, me not understand... |
| 11:10:50 | <dkayiwa> suranga: eg <TS.1>FriJan1407:31:30CET8727</TS.1> versus <TS.1>FriJan1409:31:30EAT8727 |
| 11:10:51 | <rafa> applecool: looks good |
| 11:11:13 | <suranga> dkayiwa, I always used YYYYMMDDHHMMSS |
| 11:11:28 | <dkayiwa> suranga: as the data format? |
| 11:11:29 | <suranga> dkayiwa, do we need to mention the day(friday) as well ? |
| 11:11:41 | <dkayiwa> suranga: you are the expert :) |
| 11:11:48 | <suranga> dkayiwa, umm.. not really |
| 11:11:55 | <suranga> dkayiwa, what is CET and EAT ? |
| 11:12:25 | <dkayiwa> suranga: Central Europe Time and EAT-East Africa Time :) |
| 11:12:48 | <suranga> dkayiwa, um... im totally lost on that one, im afraid :( |
| 11:13:04 | <dkayiwa> suranga: http://timezoneguide.com/abbdiff-CET-EAT.php |
| 11:13:15 | <suranga> dkayiwa, if im getting a time back, i would like to have a timezone, yep |
| 11:13:16 | <dkayiwa> suranga: http://www.endmemo.com/timezone/centraleuropeaneastafrica.php |
| 11:14:25 | <suranga> dkayiwa, hmm... |
| 11:14:40 | <suranga> dkayiwa, i think its good if we can let the user decide which to use |
| 11:14:50 | <dkayiwa> suranga: ok |
| 11:14:54 | <suranga> dkayiwa, what would you recomend ? u are th time zone expert ? :) |
| 11:15:18 | <dkayiwa> suranga: i completely have no idea on hl7 stuff :) |
| 11:16:07 | <suranga> dkayiwa, shall we leave outonly that part till ben or darius or roger come online ? :( |
| 11:16:20 | <dkayiwa> suranga: ok |
| 11:28:50 | <applecool> rafa: METAREPO-12 is done |
| 11:34:44 | *** sunbiz1 has joined #openmrs |
| 11:36:22 | *** snoppy has left #openmrs |
| 11:36:31 | *** sunbiz has quit IRC |
| 11:40:11 | <applecool> rafa: lucene is damn gorgeous! Search is also done |
| 11:40:55 | <rafa> applecool: haha we're only using 5% of its power ;) |
| 11:41:32 | <bwolfe> suranga, dkayiwa, what are we leaving out? |
| 11:42:02 | <applecool> absolutely true! i read a little bit of documentation! it was jaw dropping :) i will surely implement the searching inside the package with your help after GSOC :) i promise! loving it :) |
| 11:42:12 | <applecool> rafa: |
| 11:42:27 | <dkayiwa> bwolfe: he was talking about hl7 template dates. but i ended up using func.formatDate |
| 11:42:36 | <rafa> applecool: happy to hear |
| 11:42:41 | <applecool> :) |
| 11:47:45 | <bwolfe> applecool, thats nice to hear. how difficult was it to adapt and use it? |
| 11:48:05 | <applecool> bwolfe: u mean the lucene? |
| 11:48:39 | *** pulasthi7 has joined #openmrs |
| 11:48:39 | <bwolfe> yeah |
| 11:50:05 | <applecool> i didnt feel so difficult because rafa made it easy for me :) And for you it would be a piece of cake :) bwolfe |
| 11:50:34 | <pulasthi7> hi james_regen, |
| 11:51:37 | <applecool> bwolfe: but i do agree that the documentation for Lucene is perfect and uncomplicated |
| 11:51:37 | *** rram_ has quit IRC |
| 11:51:48 | <applecool> bwolfe: very easy to understand :) |
| 11:51:54 | *** rram_ has joined #openmrs |
| 11:52:32 | <applecool> rafa: we have a problem with METAREPO-7 displaying the view page immediately after uploading the package |
| 11:52:32 | *** rram_ has quit IRC |
| 11:52:43 | <james_regen> hi pulasthi7 |
| 11:52:51 | *** rram_ has joined #openmrs |
| 11:53:06 | *** rfriedman has joined #openmrs |
| 11:53:18 | <applecool> rafa: because we wont be able to get all the fields to display until we press the save button on the edit package page |
| 11:53:20 | <rfriedman> hi rafa, u there? |
| 11:53:32 | <rafa> applecool: why is that? |
| 11:53:37 | <rafa> rfriedman: yes :) |
| 11:53:42 | *** rram_ has quit IRC |
| 11:53:50 | <applecool> rafa: because we wont be able to get all the fields to display until we press the save button on the edit package page |
| 11:53:56 | *** rram_ has joined #openmrs |
| 11:54:01 | <rafa> applecool: yes, but why? |
| 11:54:05 | <rfriedman> rafa, i notice you are marking all wsrestext19 tickets for 1.1 -- has there been a release of wsrestext19? |
| 11:54:24 | <pulasthi7> james_regen, while i was working on the code to move the old reports and configurations to database, i found that the report generation is using the configuration in flat file |
| 11:54:39 | <rafa> rfriedman: there's no separate project for ext19 |
| 11:54:44 | <pulasthi7> james_regen, not the data in the database |
| 11:54:52 | <rafa> rfriedman: and we releasead restws 1.0 |
| 11:54:53 | <applecool> rafa: y because we are getting the field details from the db in the viewpackage page |
| 11:55:03 | <rafa> rfriedman: I neeed to mark it as released in JIRA |
| 11:55:13 | <rafa> rfriedman: that's why some ext19 tickets got bumped too |
| 11:55:14 | <applecool> as we did yesterday rafa |
| 11:55:35 | <pulasthi7> james_regen, I'll first summarize what i got from code |
| 11:55:43 | <james_regen> pulasthi7: ok |
| 11:55:49 | <rafa> applecool: yes, but by the time we want to display the view or edit page it's all in the db |
| 11:56:29 | <pulasthi7> james_regen, when a configuration is created it saves the new configuration in both flat-file and database |
| 11:56:34 | <rafa> rfriedman: we should probably release ext19 together with restws |
| 11:57:04 | <pulasthi7> james_regen, when they are listed/deleted the data from the db is used |
| 11:57:29 | <rafa> rfriedman: actually I would love to integrate it with restws itself |
| 11:57:33 | <pulasthi7> james_regen, but when they are used in report generation, it uses the flat-file |
| 11:57:49 | <rafa> rfriedman: so that we don't have to maintain it separately |
| 11:58:03 | <applecool> no i didnt get you! the flow is packageupload: selecting the package and pressing upload button -> packageform: here when we press save button, then only the details are getting saved in the db right? |
| 11:58:24 | <rafa> applecool: no, when you hit upload button it's already saved in the db |
| 11:58:46 | <rafa> applecool: you can test it easily, hit upload button and do not save |
| 11:58:47 | <pulasthi7> james_regen, I have already done the report migration part and that was of no use as those migrated data is still of no use |
| 11:59:03 | <rafa> applecool: you will see that it's listed among other packages |
| 11:59:12 | <james_regen> pulasthi7: is it easy to change the code to use the db? is this the last place the flat file is used? |
| 11:59:21 | <applecool> ok i will test it once again rafa give me a minute :) |
| 12:00:42 | <pulasthi7> james_regen, the flat file data is parsed to classes called MatchingConf, and MatchingConfRow but the data base equivalant are PatientMatchingConfiguration and ConfigurationEntry |
| 12:01:20 | <pulasthi7> james_regen, and i saw that MatchingConf, and MatchingConfRow are also used in swing app |
| 12:01:53 | <pulasthi7> james_regen, so i decided not to change the whole code to use db classes as it would break the swing app |
| 12:02:10 | <pulasthi7> james_regen, i decided to do a conversion between them, |
| 12:02:17 | <pulasthi7> james_regen, will it be ok |
| 12:02:40 | <suranga> hi james_regen as you see, if we ignre those, we will end up breaking the swing ui :-) |
| 12:02:40 | <rfriedman> rafa, i am thinking of takin on restws-267, i think it should be part of restwsext19, do you agree? |
| 12:02:58 | <james_regen> pulasthi7: that's what i was about to suggest. if they're similar, then it should be easy. is the difference that the MatchingConfig and MathcingConfigRow objects have more options and fields? |
| 12:03:02 | <applecool> rafa: you are true :D i was wrong! :) |
| 12:03:03 | <rafa> !ticket RESTWS-267 |
| 12:03:04 | <OpenMRSBot> rafa: [#RESTWS-267] Need to expose concept_source - OpenMRS JIRA - https://tickets.openmrs.org/browse/RESTWS-267 |
| 12:03:45 | <rafa> rfriedman: it's both RESTWS and RESTWSEXT19 |
| 12:03:56 | <pulasthi7> james_regen, yes, as in the web app it uses default values for those, i'll assign those default value when doing the conversion |
| 12:04:02 | <rfriedman> rafa, we had an i think fruitless discussion of how to maintain compatibility between RESTWS versions and data model versions |
| 12:04:19 | <james_regen> pulasthi7: ok, that sounds like a good plan |
| 12:04:27 | <rfriedman> rafa, are you suggesting a 1.8 version in RESTWS and a 1.9 version in RESTWSEXT19? |
| 12:05:31 | <rafa> rfriedman: well, actually I looked again at ConceptSource in 1.8 and 1.9 |
| 12:05:41 | <rafa> rfriedman: it seems they don't differ |
| 12:05:57 | <rfriedman> rafa, right, but concept_map is gone |
| 12:06:08 | <rafa> rfriedman: right |
| 12:06:14 | <rfriedman> rafa, it is finding by map:code that is the value |
| 12:06:22 | <pulasthi7> james_regen, ok, I'll continue with that then :-) |
| 12:06:49 | <rafa> rfriedman: yes, so this should be handled by RESTWS in 1.8 and RESTWSEXT19 in 1.9 |
| 12:06:52 | <rfriedman> rafa, maybe i need to look at your trick of writing for 2 versions at once |
| 12:07:28 | <rafa> rfriedman: yes, I would really like us to move in that direction |
| 12:07:57 | <rafa> rfriedman: I still haven't documented it though :( |
| 12:08:01 | *** robbyoconnor has quit IRC |
| 12:08:17 | <rfriedman> rafa, i can read your mind, the problem is i don't speak polish |
| 12:08:28 | <rfriedman> rafa, only reverse polish |
| 12:08:28 | <rafa> rfriedman: haha |
| 12:09:37 | <rafa> rfriedman: I'm busy this week releasing OMRS maintenance versions |
| 12:10:06 | <rfriedman> rafa, no problem, i can work on 1.9 which is what i need for my projects |
| 12:11:24 | <rafa> rfriedman: great, it should be easy to integrate it later with RESTWS if we decide to take that path |
| 12:11:43 | <rafa> rfriedman: meanwhile you can work with RESTWSEXT19 |
| 12:11:58 | <rfriedman> rafa, ok tks |
| 12:13:58 | *** judygichoya has joined #openmrs |
| 12:20:48 | <applecool> rafa: all tickets are done |
| 12:20:51 | <applecool> :) |
| 12:21:18 | <rafa> applecool: all tests passing? |
| 12:21:36 | <applecool> except for fileuploadcontrollertest |
| 12:21:45 | <rafa> applecool: fix that one too |
| 12:21:45 | <applecool> i need your help in that |
| 12:22:05 | <rafa> applecool: ok, what is the problem? |
| 12:22:32 | <applecool> give me few minutes. i will get back rafa :) |
| 12:22:43 | <rafa> applecool: all right |
| 12:26:48 | *** mvorobey has joined #openmrs |
| 12:26:51 | <mvorobey> hi all |
| 12:27:17 | <dkayiwa> mvorobey: hi all :) |
| 12:27:40 | <mvorobey> dkayiwa, how it's going ? |
| 12:27:49 | <dkayiwa> mvorobey: not bad |
| 12:27:52 | <dkayiwa> and u |
| 12:28:19 | <applecool> rafa: here we go! http://pastebin.com/RFLyjpC5 this is the earlier controller test |
| 12:28:41 | <applecool> rafa: http://pastebin.com/ghgCjWph is the stack trace for failure |
| 12:28:52 | <rfriedman> bwolfe, u there? |
| 12:29:04 | <bwolfe> rfriedman, yes |
| 12:29:07 | <applecool> rafa: so how can i tweak this onsubmit() |
| 12:29:28 | <rfriedman> bwolfe, any chance you could participate in a code review Thu 10 am EDT? |
| 12:29:54 | <mvorobey> dkayiwa, good-good, hiding away from the red-hot sun, it's very hot in Ukraine :) |
| 12:29:55 | <rafa> applecool: you need to feed the test with a real package |
| 12:30:08 | <applecool> oh! |
| 12:30:23 | <rfriedman> bwolfe, sorry, 9 am |
| 12:30:29 | <bwolfe> rfriedman, during the dev call? |
| 12:30:29 | <rafa> applecool: not sample-data.xml |
| 12:30:33 | <bwolfe> oh, before |
| 12:30:35 | <dkayiwa> mvorobey: oh i see :D |
| 12:31:14 | <mvorobey> dkayiwa, just wanted to ask you, do I need to unassign https://tickets.openmrs.org/browse/XFRM-76 from myself since we've already found the cause problem ? |
| 12:31:47 | <applecool> rafa: so should i just give the path to a directory in which the metadatapackage zip file is residing? |
| 12:32:02 | <dkayiwa> mvorobey: yes |
| 12:32:53 | <rafa> applecool: put the zip in src/test/resources |
| 12:33:05 | <applecool> oh okay! any zip |
| 12:33:35 | <rafa> applecool: and then use "/package-name.zip" in getResourceAsStream |
| 12:33:48 | <rafa> applecool: any valid package zip |
| 12:33:49 | <bwolfe> rfriedman, probably. who/what/why ? |
| 12:33:55 | <applecool> rafa: okay |
| 12:34:08 | <rafa> applecool: a small one |
| 12:34:17 | <rafa> applecool: the smallest you have |
| 12:34:49 | <rafa> applecool: < 100 kB if possible |
| 12:34:54 | <applecool> rafa: small one in the sense? every package is almost of the same size which i have downloaded from the RES FORM Bank |
| 12:34:56 | <applecool> okay |
| 12:34:59 | <rfriedman> would be hr module, not all, mostly js webpage(s), Sandeep Joshi, because I don't know enough js to help them |
| 12:35:03 | <rfriedman> bwolfe, |
| 12:35:34 | <applecool> rafa: great news all the packages i have are below 60 KB :) |
| 12:35:48 | <rafa> applecool: good enough |
| 12:37:46 | <bwolfe> rfriedman, ok, is this something that is better on a call? is that why you don't want asynchronous? |
| 12:38:09 | <rfriedman> i'd like some interaction possibility |
| 12:38:52 | <rfriedman> bwolfe, i will send you list of stuff to look at after i speak to him later today |
| 12:39:25 | <bwolfe> mmk |
| 12:40:10 | <rfriedman> bwolfe, how many pages do you think you could do, two? three? |
| 12:40:24 | <mvorobey> dkayiwa, have a minute ? |
| 12:40:26 | <bwolfe> depends how heavy they are |
| 12:40:42 | <dkayiwa> mvorobey: i have an hour instead :) |
| 12:41:02 | <rfriedman> bwolfe, to be sure, they are mostly add/edit of a single table |
| 12:41:04 | <mvorobey> dkayiwa, great! let's use that hour partially :) |
| 12:41:25 | <dkayiwa> mvorobey: :D |
| 12:41:43 | <rfriedman> bwolfe, but with dropdowns and stuff for related tables |
| 12:43:19 | *** pulasthi7 has quit IRC |
| 12:44:20 | <applecool> rafa: how do i set the dateCreated? |
| 12:45:06 | <mvorobey> dkayiwa, looking at https://tickets.openmrs.org/browse/XFRM-75 I can make an assumption that it's also because of purcforms issue, do you agree ? |
| 12:45:19 | <dkayiwa> hi suranga |
| 12:45:39 | <suranga> dkayiwa, howdy :) |
| 12:49:27 | <dkayiwa> suranga: did anyone work on the MSH template? |
| 12:49:54 | <suranga> dkayiwa, we have a voluenteer working on it, he's about to finish it, i think |
| 12:50:06 | <suranga> dkayiwa, did you just run out of tickets ? :P |
| 12:51:42 | <dkayiwa> suranga: no. was getting errors about it |
| 12:51:59 | <suranga> dkayiwa, yep, that segment is a madatory one.. |
| 12:52:30 | <suranga> dkayiwa, for now, we can avoid tests that fail because of it, or we can hard code <MSH> </MSH> tags into the unit test :) |
| 12:52:58 | <dkayiwa> mvorobey: correct |
| 12:53:13 | <dkayiwa> suranga: ok :) |
| 12:54:25 | <mvorobey> dkayiwa, so, what I a, supposed to do in this case ? Comment about it on ticket or start learning purcforms ? :) |
| 12:54:34 | <dkayiwa> mvorobey: yes |
| 12:54:35 | <mvorobey> dkayiwa, so, what I am, supposed to do in this case ? Comment about it on ticket or start learning purcforms ? :) |
| 12:55:03 | <dkayiwa> mvorobey: first start with those tickets that do not involve purcforms :) |
| 12:55:19 | <mvorobey> dkayiwa, cool :) |
| 12:58:15 | *** lim has joined #openmrs |
| 12:58:29 | <lim> hey |
| 12:58:46 | <bwolfe> hi lim |
| 12:58:51 | <lim> hi |
| 12:59:05 | <lim> I am looking for openmrs 1.6.0 trunk |
| 12:59:17 | <lim> where will I be able to find it |
| 13:01:42 | <rfriedman> lim you can find it at svn.openmrs.org, look in the openmrs directory, choose tags, choose 1.6.0 |
| 13:02:09 | <rfriedman> lim you are the 2nd person whose asked for 1.6.0 in 3 days ... is there a project or a class or something using it? |
| 13:05:20 | <dkayiwa> hi rafa |
| 13:05:26 | <rafa> dkayiwa: hi |
| 13:05:55 | <dkayiwa> rafa: do i git push changes in a branch with: git push BRANCH_NAME |
| 13:05:57 | <dkayiwa> ? |
| 13:07:50 | <rafa> dkayiwa: I think you need to add a remote before BRANCH_NAME but I'm not sure |
| 13:07:59 | <dkayiwa> rafa: ok |
| 13:08:02 | <rafa> dkayiwa: git push origin BRANCH_NAME |
| 13:08:08 | <dkayiwa> rafa: ok |
| 13:08:21 | <dkayiwa> git push origin HLQRY-42 |
| 13:08:41 | <dkayiwa> sorry i thought this was my command line :) |
| 13:11:22 | *** maurya has quit IRC |
| 13:11:27 | *** Maurya_ has joined #openmrs |
| 13:13:12 | *** lim has quit IRC |
| 13:13:47 | *** rfriedman is now known as rfriedman_away |
| 13:14:31 | *** mseaton has joined #openmrs |
| 13:14:31 | *** ChanServ sets mode: +v mseaton |
| 13:14:48 | *** mseaton has left #openmrs |
| 13:19:52 | <rafa> dkayiwa: hahaha |
| 13:20:14 | <dkayiwa> rafa: :D i was about to enter user name and password too |
| 13:20:15 | <rafa> dkayiwa: almost |
| 13:20:25 | <rafa> dkayiwa: lol |
| 13:20:30 | <dkayiwa> :D |
| 13:22:21 | *** snoppy has joined #openmrs |
| 13:31:56 | <applecool> rafa: i have problem setting the date on the package. can you please help |
| 13:32:30 | <rafa> applecool: what date? |
| 13:32:37 | <applecool> datecreated |
| 13:33:04 | <applecool> field |
| 13:33:08 | <applecool> on pkg |
| 13:33:31 | <rafa> applecool: what is the problem? |
| 13:36:02 | *** Maurya_ has quit IRC |
| 13:36:36 | <applecool> oh oops sorry |
| 13:37:12 | <applecool> i didnt see that! it got swapped! |
| 13:37:14 | <applecool> when i am trying to pass the Date into the pkg.setdateCreated() i am getting type mismatch cannot convert int to boolean |
| 13:37:31 | <applecool> but its of type Date right? |
| 13:37:42 | <applecool> and in the proper format! |
| 13:37:55 | <applecool> Do i need to convert it by passing it to the DateTimeConverter? |
| 13:38:04 | <rafa> applecool: can you pastebin the stacktrace? |
| 13:38:23 | <applecool> http://pastebin.com/0JVDDCUw |
| 13:38:57 | <rafa> applecool: is that all? |
| 13:39:02 | <applecool> yes |
| 13:39:09 | *** maurya has joined #openmrs |
| 13:39:20 | *** pushkar has joined #openmrs |
| 13:40:01 | <applecool> rafa: this is the main stack trace http://pastebin.com/GUqHWbGu |
| 13:40:45 | <applecool> rafa: http://pastebin.com/JFHMsrfy is the onsubmit() |
| 13:40:51 | *** pushkar_ has joined #openmrs |
| 13:41:19 | <rafa> applecool: line 54 in onsubmit doesn't look right |
| 13:41:34 | <rafa> applecool: does it even compile? |
| 13:41:49 | <applecool> yes that is the problem! i am getting an eclipse error there |
| 13:41:58 | <applecool> on line 5 |
| 13:42:02 | <applecool> 54* sorry |
| 13:42:22 | <rafa> applecool: haha then why are you giving me stack traces if it doesn't even compile :D |
| 13:42:46 | <applecool> you asked me so i gave :D though its not useful :P |
| 13:42:48 | <rafa> applecool: you need to pass there date object |
| 13:42:58 | <rafa> applecool: new Date() |
| 13:43:46 | *** rfriedman_away is now known as rfriedman |
| 13:43:48 | <applecool> oh |
| 13:43:58 | *** pushkar has quit IRC |
| 13:44:02 | <rafa> applecool: change pkg.setDateCreated(2012-02-24 09:04:43); to pkg.setDateCreated(new Date()); |
| 13:44:28 | <applecool> yea changed it |
| 13:45:49 | <rafa> bwolfe: see I can be a good teacher :) |
| 13:46:10 | <bwolfe> rafa++ |
| 13:46:23 | <applecool> :) |
| 13:46:30 | <applecool> rafa: you are :) |
| 13:48:29 | *** pushkar has joined #openmrs |
| 13:48:30 | *** pushkar_ has quit IRC |
| 13:48:55 | *** Maurya_ has joined #openmrs |
| 13:49:49 | *** pushkar_ has joined #openmrs |
| 13:49:58 | <applecool> rafa: is that newPost() url correct ? |
| 13:49:59 | *** maurya has quit IRC |
| 13:50:13 | <applecool> in the onSubmit() |
| 13:50:21 | *** robbyoconnor has joined #openmrs |
| 13:50:21 | *** ChanServ sets mode: +v robbyoconnor |
| 13:51:09 | <rafa> applecool: if I remember right the request mapping is "/packageupload*"? |
| 13:51:25 | <rafa> applecool: then anything which starts with that is correct |
| 13:51:53 | <rfriedman> bwolfe, the migration of core to git has occurred? |
| 13:52:09 | <applecool> rafa: yes. okay |
| 13:52:30 | <bwolfe> rfriedman, no, it was on hold pending feedback. now it is on hold until next week pending getting dev time |
| 13:52:49 | <applecool> http://pastebin.com/UTmQ0Syd rafa |
| 13:52:56 | *** pushkar has quit IRC |
| 13:52:59 | <rfriedman> bwolfe, has there been a version change in fisheye? |
| 13:53:10 | <bwolfe> rfriedman, potentially |
| 13:53:16 | <dkayiwa> rafa after putting my template in MockBaseTest.setupStandardTemplates() is there anything else i need to do to prevent my hl7QueryService.getHL7TemplateByName in unit test from returning null? |
| 13:53:21 | <bwolfe> downey upgraded most of the atlassian tools this week |
| 13:53:24 | <rfriedman> bwolfe, let me just ask you, you played with it recently |
| 13:53:42 | <rafa> dkayiwa: it should be enough |
| 13:53:46 | <rfriedman> bwolfe, conceptsourceresource extends metadata but implements voidable |
| 13:53:55 | <rafa> dkayiwa: getting null? |
| 13:54:03 | <dkayiwa> rafa: yes |
| 13:54:10 | *** rram_ has quit IRC |
| 13:54:13 | <bwolfe> rfriedman, why does it do that? |
| 13:54:15 | <rafa> dkayiwa: what did you add there? |
| 13:54:15 | <rfriedman> bwolfe, the pojo has deprecated void methods but the hbm has retired in 1.8 and 1.9 |
| 13:54:21 | <rfriedman> bwolfe, that's my question |
| 13:54:30 | <dkayiwa> rafa: templateNamesToPaths.put("Generic Obs Group", "templates/OBR-OBS-GROUP.xml"); |
| 13:54:30 | *** deadpool has joined #openmrs |
| 13:54:32 | *** robbyoconnor has quit IRC |
| 13:55:05 | <rfriedman> i'm sorry, i mean conceptsource the pojo |
| 13:55:15 | <rfriedman> bwolfe, ^ |
| 13:55:28 | <bwolfe> rfriedman, yeah, figured |
| 13:55:34 | <rafa> dkayiwa: looks right, can you test Assert.assertNotNull(hl7QueryService.getHL7TemplateByName("Generic Obs Group"))? |
| 13:55:41 | <bwolfe> rfriedman, the "implements Voidable" might be there from before |
| 13:55:45 | <bwolfe> for backwards compatibility? |
| 13:55:47 | <dkayiwa> rafa: ok |
| 13:55:55 | *** skathol has joined #openmrs |
| 13:56:29 | *** judygichoya has quit IRC |
| 13:56:36 | <rfriedman> bwolfe, right, those methods all call the corresponding retired method |
| 13:57:05 | <rfriedman> bwolfe, how long do we want to keep those? |
| 13:57:16 | <bwolfe> seemingly forever |
| 13:57:21 | <bwolfe> at minimum one version |
| 13:57:46 | <rfriedman> bwolfe, ok, i will not let it trouble me |
| 13:58:34 | <dkayiwa> rafa: that works. thanks :) |
| 13:58:47 | <rafa> dkayiwa: and what didn't work? |
| 13:58:56 | <dkayiwa> rafa: OBS vs Obs |
| 13:58:56 | *** rfriedman is now known as rfriedman_away |
| 13:59:01 | <rafa> dkayiwa: ohh ok |
| 13:59:01 | <dkayiwa> rafa: yours had Obs :) |
| 13:59:07 | <applecool> rafa: something is wrong from 59 to 64 line |
| 13:59:33 | <applecool> rafa: it should be ZipInputStream instead of the InputStream right? |
| 13:59:34 | <rafa> dkayiwa: yeah mysql is case insensitive, but mocks are not :D |
| 13:59:47 | <dkayiwa> rafa: hahaha correct :D |
| 14:00:33 | <mvorobey> dkayiwa, there is a ticket https://tickets.openmrs.org/browse/TRUNK-3377. It's assigned to me. Can I ask you to review last attached patch to it so I'll be able to commit it to trunk ? |
| 14:00:38 | <bwolfe> !seen cpower |
| 14:00:38 | <OpenMRSBot> bwolfe: cpower was last seen in #openmrs 23 hours, 48 minutes, and 35 seconds ago: <cpower> !scrumoff |
| 14:00:41 | <rafa> applecool: I don't have a code in front of me |
| 14:00:52 | <applecool> rafa: okay :) |
| 14:01:01 | <rafa> applecool: can you give me a link? |
| 14:01:25 | <applecool> http://pastebin.com/JFHMsrfy |
| 14:01:39 | <dkayiwa> mvorobey: ok |
| 14:02:11 | <rafa> applecool: still not corrected DateCreated? |
| 14:02:27 | <applecool> actually its the previous link |
| 14:02:29 | <applecool> sorry |
| 14:03:16 | <applecool> http://pastebin.com/2Vn57mEW |
| 14:03:23 | <mvorobey> dkayiwa, you're the model of pithiness :) |
| 14:03:29 | *** lakkarau has joined #openmrs |
| 14:03:37 | <dkayiwa> mvorobey: what does that word mean? :) |
| 14:03:48 | <rafa> applecool: don't use ZipInputStream, just InputStream |
| 14:03:59 | <rafa> applecool: check if fis is not null |
| 14:04:59 | <mvorobey> dkayiwa, it was a joke about how shorty was your answer (only two letters) :D |
| 14:05:15 | <dkayiwa> mvorobey: hahahah :D |
| 14:05:23 | *** sunbiz1 has left #openmrs |
| 14:05:36 | *** cpower has joined #openmrs |
| 14:05:41 | <djazayeri> applecool: pkg.setDateCreated(new SimpleDateFormat("yyyy-MM-dd hh:mm:ss").parse("2012-02-24 09:04:43")) |
| 14:05:43 | <cpower> Hello! |
| 14:05:49 | <bwolfe> there he is! |
| 14:05:58 | <bwolfe> speak of the devil! |
| 14:06:01 | <bwolfe> errr, project manager |
| 14:06:08 | <cpower> Sorry I'm late, having a chicken and egg debate in another scrum |
| 14:06:22 | <mvorobey> cpower, hi :) |
| 14:06:24 | <dkayiwa> hi suranga |
| 14:06:27 | <applecool> djazayeri: oh :) |
| 14:06:29 | <cpower> Please to meet you, won't you guess my name? - Rolling Stones |
| 14:06:37 | <suranga> dkayiwa, helooo |
| 14:06:47 | <cpower> Ok let's get going |
| 14:06:53 | <cpower> !scrumon cpower |
| 14:06:53 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 14:07:01 | <dkayiwa> suranga: do i put members of an obs group inside <OBR> ???? |
| 14:07:34 | <cpower> Order: skathol, mvorobey, lakkarau, dkayiwa, suranga, rafa, djazayeri, bwolfe |
| 14:07:45 | <skathol> done: HLQRY-5: Generic MSH |
| 14:07:47 | <skathol> will do: submit changes to Git |
| 14:07:48 | <skathol> blockers: none |
| 14:07:56 | <mvorobey> * Closed - TRUNK-2582 |
| 14:07:56 | <mvorobey> * Reviewed and verified - TRUNK-3332 |
| 14:07:56 | <mvorobey> * Created code review and reviewed - TRUNK-3491 |
| 14:07:56 | <mvorobey> * Investigated and found the source problem for XFRM-79 |
| 14:07:56 | <mvorobey> * Gonna pick up the next ticket from bug fixing swim lane |
| 14:07:57 | <mvorobey> No blockers |
| 14:08:00 | <cpower> Git this guy some more stuff |
| 14:08:27 | <lakkarau> facing isses with internet |
| 14:09:02 | <lakkarau> but i will send the patches today for hlqry26 |
| 14:09:12 | <lakkarau> no blockers |
| 14:09:15 | <dkayiwa> IRC |
| 14:09:15 | <dkayiwa> Committed: Fix all failling unit tests - HLQRY-42 |
| 14:09:16 | <dkayiwa> Finishing: Create a groovy template to create the OBR Obs group segment of an ORUR01 message - HLQRY-38 |
| 14:09:16 | <dkayiwa> No Blockers |
| 14:10:06 | <suranga> hi, DiD - HLQRY - 39, commited, and also added review comments |
| 14:10:19 | <suranga> also general review and aswering questions |
| 14:10:28 | <bwolfe> lakkarau, lets discuss after the scrum. can you stick around or do you have to leave immediately? |
| 14:10:33 | <suranga> planning the message templates, as usual :) |
| 14:10:47 | <lakkarau> no i will be available |
| 14:11:06 | <rafa> my turn? |
| 14:11:06 | <bwolfe> suranga, blockers? |
| 14:11:20 | <suranga> none |
| 14:11:34 | <rafa> Today: |
| 14:11:34 | <rafa> * Reviewing and approving tickets before maintenance releases |
| 14:11:34 | <rafa> * Committed HLQRY-35: Create a hl7 PATIENT segment which combines the PID and PV1 segments. |
| 14:11:34 | <rafa> https://tickets.openmrs.org/browse/HLQRY-35 |
| 14:11:34 | <rafa> No blockers. |
| 14:12:56 | <wluyima> which is the order? |
| 14:13:29 | <bwolfe> wluyima, you go after me. cpower forgot you :-/ |
| 14:13:35 | <bwolfe> djazayeri? |
| 14:13:45 | <djazayeri> sorry, on a phone call now |
| 14:14:29 | <cpower> ok wolfe go |
| 14:14:51 | <bwolfe> Friday |
| 14:14:51 | <bwolfe> email catchup |
| 14:14:51 | <bwolfe> lots of reviews of hl7query tickets/design |
| 14:14:51 | <bwolfe> interview for merck dev |
| 14:14:51 | <bwolfe> (half day) |
| 14:14:52 | <cpower> and then if wluyima has something to contribute you can as well. |
| 14:14:53 | <bwolfe> Monday |
| 14:14:55 | <bwolfe> swim lane setup |
| 14:14:57 | <bwolfe> review pull requests on hl7query project |
| 14:14:59 | <bwolfe> review all recently commented tickets in hl7query |
| 14:15:01 | <bwolfe> dev interview |
| 14:15:03 | <bwolfe> (didn't) do an hl7 query ticket |
| 14:15:05 | <bwolfe> added modrepo tickets |
| 14:15:07 | <bwolfe> reviewed tickets for next week |
| 14:15:09 | <bwolfe> review scholarship apps |
| 14:15:11 | <bwolfe> no blockers |
| 14:15:13 | <bwolfe> wluyima, you're up |
| 14:15:19 | <wluyima> NOTE: My main priority is to make sure i complete tasks i have been working on |
| 14:15:19 | <wluyima> Including the GSoC project reviews before i go for vacation |
| 14:15:19 | <wluyima> Monday: |
| 14:15:19 | <wluyima> Catch up with Email back log and Sent out email for bug fixing swin lane update |
| 14:15:19 | <wluyima> HLQRY-31 - Create the 'Generic Patient Result' template which is called per each encounter |
| 14:15:20 | <wluyima> Todos for form entry tickets before building a new version of form entry for matthew to test |
| 14:15:20 | <rafa> bwolfe: we have Tuesday :D |
| 14:15:22 | <wluyima> error logging code review |
| 14:15:23 | <wluyima> Tuesday: |
| 14:15:26 | <wluyima> HLQRY-32 - Create the ORUR01 template which produces the complete ORUR01 message |
| 14:15:28 | <wluyima> HLQRY-24 - Add generic controller method to get any template |
| 14:15:30 | <wluyima> Blockers: None |
| 14:16:27 | <bwolfe> rafa, good catch, I copied from stale file |
| 14:17:46 | <bwolfe> Monday |
| 14:17:46 | <bwolfe> swim lane setup |
| 14:17:46 | <bwolfe> review pull requests on hl7query project |
| 14:17:46 | <bwolfe> review all recently commented tickets in hl7query |
| 14:17:46 | <bwolfe> dev interview |
| 14:17:47 | <bwolfe> (didn't) do an hl7 query ticket |
| 14:17:51 | <bwolfe> added modrepo tickets |
| 14:17:52 | <bwolfe> reviewed tickets for next week |
| 14:17:55 | <bwolfe> review scholarship apps |
| 14:17:56 | <bwolfe> Tuesday |
| 14:17:59 | <bwolfe> reviewed scholarship apps |
| 14:18:00 | <bwolfe> emails |
| 14:18:02 | <dkayiwa> bwolfe: second time :) |
| 14:18:03 | <bwolfe> minor wiki page updates |
| 14:18:05 | <bwolfe> reviewed a few of Mykola's tickets |
| 14:18:06 | <bwolfe> triaged 1 ticket (so far) |
| 14:18:21 | <cpower> Discussion points: Lakkarau's internet issues, |
| 14:18:26 | <cpower> No blockers |
| 14:18:30 | <cpower> !srumoff |
| 14:18:31 | <OpenMRSBot> cpower: Error: "srumoff" is not a valid command. |
| 14:18:34 | <rafa> wluyima: when do you have vacation? |
| 14:18:41 | <cpower> !scrumoff |
| 14:18:41 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 14:18:58 | <wluyima> rafa, starting thursday |
| 14:19:10 | <bwolfe> srumoff! thats what you say after an evening of drinking |
| 14:19:11 | <wluyima> rafa, so tomorrow is my last day before i go |
| 14:19:30 | <rafa> wluyima: when will we have you back? :) |
| 14:19:45 | <wluyima> rafa, 21th |
| 14:19:50 | <wluyima> rafa, 21st |
| 14:20:02 | <rafa> wluyima: nice, have a good rest :D |
| 14:20:13 | <dkayiwa> nice wedding :) |
| 14:20:22 | <bwolfe> dkayiwa, lakkarau, suranga, skathol: lets make a strong push to get all these tickets done and documented this week! I'd love to have something for suranga to release this weekend! |
| 14:20:27 | <wluyima> rafa, about 7 working days off |
| 14:20:36 | <bwolfe> so please clear your distractions, ask questions early, and help each other out |
| 14:20:36 | <dkayiwa> bwolfe: sure |
| 14:20:39 | <rafa> dkayiwa: wedding? :D |
| 14:20:41 | <bwolfe> (and wyclif for hte next few days) |
| 14:20:51 | <dkayiwa> bwolfe: ok |
| 14:21:03 | <lakkarau> bwolfe:ok |
| 14:21:04 | <skathol> suranga: MSH is done, I'll submit to git later today. It's unlikely I'll be able to take another ticket this sprint (busy with other things), but I'd like to stay involved later. |
| 14:21:05 | <dkayiwa> rafa: wluyima is attending :) |
| 14:21:23 | <wluyima> so rafa and dkayiwa , what is the datatype of your clob_datatype_storage.value column |
| 14:21:50 | <rafa> dkayiwa: haha so it's not his wedding :D |
| 14:21:58 | <suranga> skathol, no problem, this was a 'major' ticket for us, so we really appreciate your work :) :) |
| 14:23:04 | <rafa> wluyima: not sure what you are asking? |
| 14:23:45 | <rafa> wluyima: is clob_datateyp_storage some table? |
| 14:23:47 | <wluyima> so rafa and dkayiwa , In the DB what is the datatype of your clob_datatype_storage.value column |
| 14:23:57 | <wluyima> rafa, yes it is |
| 14:24:21 | <wluyima> rafa, i think it was added in 1.9 |
| 14:24:40 | <rafa> wluyima: sorry I know nothing about it |
| 14:24:47 | <bwolfe> lakkarau, what are you internet issues? |
| 14:24:50 | <wluyima> rafa, np |
| 14:25:07 | <wluyima> rafa, even me i just saw it last week |
| 14:25:12 | <lakkarau> bwolfe:it was going slow yesturday |
| 14:25:16 | <bwolfe> lakkarau, can you commit and push to your local repo asap? see "submitting your code" on https://wiki.openmrs.org/display/docs/Using+Git |
| 14:25:30 | <bwolfe> lakkarau, it always goes slow. disconnect from vpn and it is faster |
| 14:25:43 | <lakkarau> bwolfe:yes |
| 14:26:22 | <lakkarau> bwolfe : i will push it. |
| 14:30:21 | <wluyima> rafa, dkayiwa did you check that column? |
| 14:32:23 | <bwolfe> lakkarau, send me a msg/note/email/skype/whatever as soon as you push it |
| 14:32:48 | <lakkarau> bwolfe:ok |
| 14:33:27 | <applecool> rafa: still not solved ..i have been struck with the same errors ! any clue! http://pastebin.com/2AXLU1AK |
| 14:34:26 | <applecool> rafa: i even tried with the line which darius has given me but no luck! |
| 14:37:57 | *** dkayiwa has quit IRC |
| 14:39:39 | *** lakkarau_ has joined #openmrs |
| 14:40:06 | *** lakkarau has quit IRC |
| 14:48:02 | <suranga> skathol, howdy... I was wondering, by what about time would you be commiting in your code ? :) |
| 14:50:24 | <suranga> hi wluyima I see you picked up https://tickets.openmrs.org/browse/HLQRY-32 |
| 14:50:33 | <suranga> wluyima, this is a very importaint, but very easy ticket |
| 14:51:03 | <suranga> wluyima, check out the template already in the module, most of its completed, you just have to get it working :P |
| 14:51:34 | <wluyima> suranga, ok |
| 14:53:58 | <applecool> rafa: there? |
| 14:54:28 | *** lh has joined #openmrs |
| 15:05:09 | *** applecool has quit IRC |
| 15:05:32 | *** Maurya_ has quit IRC |
| 15:11:24 | *** suranga has quit IRC |
| 15:14:33 | *** rfriedman_away is now known as rfriedman |
| 15:15:12 | <rfriedman> bwolfe, could you do Thu after the dev call rather than before? |
| 15:20:11 | <mvorobey> djazayeri, hi |
| 15:22:04 | *** rafa has quit IRC |
| 15:23:30 | <mvorobey> djazayeri, is there a chance you could give me an answer to the question I've just put on https://tickets.openmrs.org/browse/TRUNK-3240 ? |
| 15:25:16 | <djazayeri> mvorobey: reading now |
| 15:30:17 | <djazayeri> mvorobey: is the fundamental issue that the code is trying to stop a module that is already stopped? |
| 15:30:35 | <djazayeri> bwolfe: thoughts on TRUNK-3240 ? |
| 15:31:55 | <djazayeri> mvorobey: I do see this: |
| 15:31:56 | <djazayeri> if (getModuleClassLoaderMap().containsKey(mod)) { |
| 15:31:56 | <djazayeri> log.debug("Mod was in classloader map. Removing advice and extensions."); |
| 15:32:40 | *** mseaton has joined #openmrs |
| 15:32:40 | *** ChanServ sets mode: +v mseaton |
| 15:32:53 | <djazayeri> mvorobey: (that's from ModuleFactory.stopModule) |
| 15:33:35 | <djazayeri> mvorobey: so I would have thought that inside that test, we should have access to the module class loader |
| 15:40:03 | *** jordank has joined #openmrs |
| 15:41:38 | *** judygichoya has joined #openmrs |
| 15:42:13 | *** cpower has quit IRC |
| 15:52:29 | *** harshadura has joined #openmrs |
| 15:53:21 | *** judygichoya_ has joined #openmrs |
| 15:53:22 | *** judygichoya has quit IRC |
| 15:53:22 | *** judygichoya_ is now known as judygichoya |
| 15:53:58 | <djazayeri> mvorobey: I commented on the ticket, I approve of your proposed fix, though it would be nice to know why this is happening in the big picture. |
| 15:56:08 | *** mseaton has left #openmrs |
| 15:57:57 | *** harshadura has quit IRC |
| 16:03:52 | <pushkar_> bwolfe, Hi |
| 16:04:54 | *** gauravpaliwal has joined #openmrs |
| 16:04:54 | *** ChanServ sets mode: +v gauravpaliwal |
| 16:07:39 | *** jkeiper has joined #openmrs |
| 16:07:49 | *** ChanServ sets mode: +v jkeiper |
| 16:10:52 | <skathol> suranga: Just created a pull request. Let me know how it looks! |
| 16:12:19 | <pushkar_> hi rfriedman |
| 16:13:06 | *** lakkarau_ has quit IRC |
| 16:14:19 | *** mvorobey_ has joined #openmrs |
| 16:15:28 | *** mvorobey_ has quit IRC |
| 16:15:48 | *** mvorobey_ has joined #openmrs |
| 16:17:22 | <mvorobey_> djazayeri, hey, thanks for commenting on TRUNK-3240! Do I need to backport fix for it to 1.9.x and 1.8.x ? |
| 16:18:34 | <djazayeri> mvorobey_: personally I need it in 1.9.x. In general you should backport as far as 1.7.x (the oldest supported OpenMRS version) |
| 16:19:00 | <djazayeri> mvorobey_: gotta run for a while |
| 16:19:02 | <mvorobey_> djazayeri, will be done, thanks! |
| 16:22:01 | *** skathol has quit IRC |
| 16:25:12 | <bwolfe> hi pushkar_ |
| 16:25:50 | *** harshadura has joined #openmrs |
| 16:26:30 | *** mseaton has joined #openmrs |
| 16:26:31 | *** ChanServ sets mode: +v mseaton |
| 16:26:46 | <pushkar_> bwolfe I finished the templates . Now I need the images |
| 16:26:54 | *** mseaton has left #openmrs |
| 16:28:27 | <bwolfe> pushkar_, did you just google around for some nice line drawings? |
| 16:29:12 | <rfriedman> pushkar_, hi pushkar |
| 16:29:15 | <pushkar_> bwolfe, I can get the basic drawings line hand foot |
| 16:29:53 | <rfriedman> pushkar_, are you able to use PDFs? |
| 16:30:16 | *** judygichoya_ has joined #openmrs |
| 16:30:49 | <pushkar_> rfriedman, I was about to ask you that. where can I get those pdf ? |
| 16:30:53 | <bwolfe> rfriedman, can't you extract images out of pdfs? |
| 16:31:13 | *** judygichoya has quit IRC |
| 16:31:14 | *** judygichoya_ is now known as judygichoya |
| 16:31:37 | <rfriedman> bwolfe, pushkar_ i don't know if they are vector or raster graphics, or what's important to pushkar |
| 16:32:37 | <rfriedman> pushkar_, i sent you the link www.medscape.com/features/ald. I think you can sign up for no cost, but if not I can download those |
| 16:33:16 | <rfriedman> you can try google images for teeth, I think I found a standard tooth chart with both baby and adult teeth on it |
| 16:34:44 | *** lakkarau has joined #openmrs |
| 16:35:07 | <lakkarau> bwolfe:hi |
| 16:35:07 | <rfriedman> bwolfe, could you do the review Thu at 11 after the dev call? |
| 16:35:20 | <bwolfe> hi lakkarau |
| 16:35:29 | <bwolfe> rfriedman, its easier for me to do 9am |
| 16:35:33 | <pushkar_> rfriedman, I tried jpeg and png are there any other formats that we should support ? |
| 16:35:43 | <lakkarau> bwolfe:i pushed the branch HLQRY-26 |
| 16:36:05 | <rfriedman> bwolfe, how about 8 or 9 or 10 am Fri? |
| 16:37:12 | <rfriedman> pushkar_, I mean what do you need for input? |
| 16:37:30 | <pushkar_> png or jpeg |
| 16:38:59 | <bwolfe> lakkarau, great! I'll comment on your commits there |
| 16:39:43 | <lakkarau> bwolfe:ok |
| 16:41:51 | <judygichoya> had the id cards module moved to github? |
| 16:43:29 | <rfriedman> pushkar_, it's easy to display a screen image of the pdf and then screen capture and edit in powerpoint |
| 16:43:37 | <bwolfe> judygichoya, doesn't look like it: http://svn.openmrs.org/openmrs-modules/idcards/ |
| 16:43:39 | *** judygichoya has quit IRC |
| 16:43:42 | <rfriedman> pushkar_, you might also look at pdf2jpg.net |
| 16:43:48 | <bwolfe> judygichoya, if it was moved somewhere it woul dhave a "migrated" file there instead of code |
| 16:44:23 | *** judygichoya has joined #openmrs |
| 16:45:27 | <pushkar_> rfriedman, i am trying http://www.convertpdftoimage.com/ but the pdf file seems to lose detail after converting |
| 16:46:16 | <bwolfe> lakkarau, ok, done commenting |
| 16:46:25 | <bwolfe> lakkarau, you should get emails about my comments |
| 16:46:53 | <bwolfe> lakkarau, FYI: if you ever find yourself copying/pasting a lot of code like that, you should ask "Is this done some place else that I can just make one simple call?" |
| 16:48:37 | <pushkar_> bwolfe, rfriedman do you want to have a look at the module ? |
| 16:48:46 | <lakkarau> bwolfe:yes,that is from globalprop.jsp |
| 16:49:36 | *** judygichoya has quit IRC |
| 16:49:57 | <rfriedman> pushkar_, you want to do a join.me or a skype screen share? |
| 16:50:39 | <pushkar_> rfriedman, I just wanted to send you the omod nut skype screen share is fine by me |
| 16:50:49 | <pushkar_> nut=but |
| 16:51:31 | <rfriedman> then let's do skype, i think it has to be one-on-one for screen share to work. |
| 16:52:16 | <rfriedman> pushkar_, i am roxanne.feline there |
| 16:52:46 | <bwolfe> rfriedman, 8 or 9 on Friday is ok |
| 16:52:58 | *** james_regen has quit IRC |
| 16:53:10 | <rfriedman> bwolfe, thanks, will let you know |
| 16:54:50 | <pushkar_> okay |
| 16:57:24 | *** jkeiper__ has joined #openmrs |
| 17:00:58 | *** jkeiper has quit IRC |
| 17:03:48 | *** gauravpaliwal has quit IRC |
| 17:11:10 | *** jkeiper has joined #openmrs |
| 17:13:55 | *** jkeiper__ has quit IRC |
| 17:14:54 | *** jkeiper__ has joined #openmrs |
| 17:15:16 | <bwolfe> rfriedman, lol. https://tickets.openmrs.org/secure/ViewVoters!default.jspa?id=67783 |
| 17:15:20 | <bwolfe> rfriedman, you got it! :-) |
| 17:15:46 | <bwolfe> rfriedman, the first ticket to have more votes than the silly TRUNK-1 ticket! https://wiki.openmrs.org/display/docs/Vote+on+What+We+Do |
| 17:15:48 | <bwolfe> :-D |
| 17:18:33 | *** jkeiper has quit IRC |
| 17:19:36 | *** jkeiper__ has quit IRC |
| 17:36:12 | *** pushkar_ has quit IRC |
| 17:38:53 | *** maurya has joined #openmrs |
| 17:39:24 | *** ChanServ sets mode: +v maurya |
| 17:43:26 | *** suranga has joined #openmrs |
| 17:43:26 | *** ChanServ sets mode: +v suranga |
| 17:43:44 | <suranga> hi guys, Im back. sorry for the delay |
| 17:47:56 | <djazayeri> mvorobey_: by the way, often you may want to wait for code review before you backport |
| 17:48:09 | <djazayeri> in case there are changes required, you can fix them just once. |
| 17:49:03 | *** test__ has joined #openmrs |
| 17:49:16 | <wluyima> hi suranga |
| 17:49:29 | <suranga> wluyima, howdy ! :) |
| 17:49:46 | <wluyima> suranga, what is the hl7 entity for the ORURO1 template see HLQRY-32 |
| 17:50:00 | <suranga> wluyima, oh, let me see |
| 17:50:39 | *** test__ has quit IRC |
| 17:51:32 | <suranga> wluyima, its ORUR01 |
| 17:51:51 | <suranga> wluyima, thats ORUR(thenumberzero)(thenumberone) |
| 17:52:09 | <wluyima> suranga, ok thanks |
| 17:52:17 | <suranga> wluyima, i'll edit the ticket discription to contain this data too' |
| 17:52:54 | <wluyima> suranga, k |
| 17:53:03 | *** Jibesh has joined #openmrs |
| 17:55:07 | <suranga> bwolfe, hi, SPencer has commited his ticket. which looks very good. there are a few small changes i'd like to make. Since he mentioned that he would be rather busy, shall I pull his changes, and then correct them myself ? |
| 17:55:23 | <bwolfe> suranga, yep |
| 17:55:32 | <bwolfe> suranga, not sure if its easier to just merge his automatically |
| 17:55:37 | <bwolfe> then update your copy and push changes |
| 17:55:51 | <suranga> bwolfe, cool, will do.. yep , thats what I had in mind :) |
| 17:57:19 | *** Jibesh has quit IRC |
| 17:59:56 | <wluyima> suranga, is the template for the default MSH existent |
| 18:00:18 | <suranga> wluyima, it will be very soon.. |
| 18:00:33 | <suranga> wluyima, cant you use the mocks for testing it out at the moment ? :-) |
| 18:01:28 | <wluyima> suranga, i will, i was just confirming |
| 18:02:16 | <suranga> wluyima, cool, I want to get it in as soon as possible too. the tiket u are working on now is like the most importaint one in the entire sprint :P |
| 18:03:10 | <wluyima> suranga, but it depends on that one, apparently this ticket is the least important since it depends on all others |
| 18:03:31 | <wluyima> suranga, i.e all the others have to be done before it is actually working |
| 18:03:44 | <suranga> wluyima, I just committed in the MSh segment |
| 18:03:56 | <suranga> wluyima, but there is a small error that I need to fix in it.. |
| 18:04:34 | <mvorobey_> djazayeri, :) sorry, I thought that fix is pretty simple, so not waited for review. But definitely will take it into my account. |
| 18:04:50 | <suranga> wluyima, yes, but once your ticket is done, we can verify that the end to end process of the module works :( |
| 18:05:15 | <bwolfe> suranga, you can verify it end to end other ways, can't you? you just have to put in some dummy code |
| 18:05:47 | <suranga> bwolfe, once wluyima 's ticket is doen, will an use mock tests to validate it |
| 18:06:29 | <suranga> bwolfe, *once wluyima ticket is done, we will use mock tests to validate it |
| 18:16:45 | *** kreddy has joined #openmrs |
| 18:18:14 | *** nadee has joined #openmrs |
| 18:20:12 | <suranga> hi wy, I justed pulled the MSH segment, and made some small chages |
| 18:20:21 | <suranga> wluyima, you;re free to use this now |
| 18:24:34 | <wluyima> suranga, thanks |
| 18:24:40 | *** applecool has joined #openmrs |
| 18:24:40 | *** ChanServ sets mode: +v applecool |
| 18:40:33 | *** jordank has quit IRC |
| 18:53:23 | <wluyima> suranga, did yiu pull the code for HLQRY-31 |
| 18:53:36 | <wluyima> suranga, i dont seem to see it in the main master |
| 18:53:45 | <wluyima> and am running into issues because if that |
| 18:53:56 | *** lakkarau has quit IRC |
| 18:53:58 | <wluyima> i cant merge the latest code you have just committed |
| 18:54:06 | <wluyima> suranga, i cant merge the latest code you have just committed |
| 18:54:06 | *** lakkarau has joined #openmrs |
| 18:55:51 | *** lh has quit IRC |
| 18:58:36 | *** lakkarau has quit IRC |
| 19:00:57 | *** lakkarau has joined #openmrs |
| 19:05:20 | *** lakkarau has quit IRC |
| 19:06:03 | *** dkayiwa has joined #openmrs |
| 19:07:28 | <wluyima> suranga, can you pull that code for HLQRY-31 |
| 19:13:11 | <wluyima> suranga, bwolfe i think the pull requests need to be pulled in in time |
| 19:13:33 | <wluyima> suranga, bwolfe this was not pulled https://github.com/OpenMRS/openmrs-module-hl7query/pull/39 and now it is in conflict |
| 19:13:38 | <OpenMRSBot> <http://ln-s.net/$a$:> (at github.com) |
| 19:14:01 | <wluyima> suranga, bwolfe currently dealing with git conflicts seems a pain |
| 19:18:21 | *** jkeiper has joined #openmrs |
| 19:18:21 | <mvorobey_> bwolfe, hey |
| 19:21:15 | *** nadee has quit IRC |
| 19:21:51 | <mvorobey_> bwolfe, it's good that you pointed to more "proper" solution on TRUNK-3240. Do I need to get rid of the temporary fix, that I've already provided or just can leave it as is ? |
| 19:23:45 | <bwolfe> mvorobey, add the one I put in there on top. :-) |
| 19:24:00 | <bwolfe> wluyima, have you read up on the "correct" way to deal with them? |
| 19:24:24 | <bwolfe> wluyima, I find it hard to believe its difficult...git touts "dealing with conflicts" as its big selling point over svn! |
| 19:25:03 | <wluyima> bwolfe, i still find it strange |
| 19:25:52 | <bwolfe> what is strange? |
| 19:26:27 | <mvorobey_> bwolfe, this one : if (!ModuleFactory.isModuleStarted(mod)) |
| 19:26:27 | <mvorobey_> return dependentModulesStopped; ? |
| 19:28:02 | <bwolfe> mvorobey_, what about it? |
| 19:28:18 | <bwolfe> wluyima, what is strange? |
| 19:31:22 | <mvorobey_> bwolfe, it definitely has logic as for me, but I did not write that class, it was written by you so you know what is good and what is bad solution. |
| 19:31:56 | <wluyima> normally whenever i attempt to resolve conflicts on merge, when i push the results it fails because they can't get to my origin master folk |
| 19:32:31 | <bwolfe> wluyima, folk == fork |
| 19:32:32 | <wluyima> bwolfe, but this was caused because some code was never pulled |
| 19:32:36 | <wluyima> fork |
| 19:33:11 | <bwolfe> wluyima, are you pull down to your branch and then pushing to your branch? |
| 19:33:19 | <bwolfe> what do you mean "can't get to your origin master fork" ? |
| 19:33:19 | <mvorobey_> bwolfe, but do I need to left my previous fix for that issue if I add the fix you've mentioned ? |
| 19:33:40 | <bwolfe> mvorobey_, you can leave your previous fix. it still is ok |
| 19:33:51 | <bwolfe> wluyima, you should pull/push separate for your master fork |
| 19:34:02 | <bwolfe> wluyima, and push/pull for each branch as you need it. |
| 19:34:08 | <bwolfe> (at least thats how rafa recommends it) |
| 19:34:44 | <mvorobey_> bwolfe, so, how to be with that ticket, can we close it now ? |
| 19:35:34 | <bwolfe> mvorobey_, did you add in my true fix on top? |
| 19:35:46 | *** jkeiper__ has joined #openmrs |
| 19:36:57 | <mvorobey_> bwolfe, actually trying it right now :) |
| 19:39:10 | *** jkeiper has quit IRC |
| 19:41:40 | *** suranga has quit IRC |
| 19:42:37 | <wluyima> bwolfe, do you mind pulling this code https://github.com/OpenMRS/openmrs-module-hl7query/pull/39 |
| 19:42:37 | <OpenMRSBot> <http://ln-s.net/$a$:> (at github.com) |
| 19:42:50 | <wluyima> bwolfe, i have addressed the review comment |
| 19:44:40 | *** jkeiper__ has quit IRC |
| 19:45:12 | *** jkeiper__ has joined #openmrs |
| 19:45:54 | <bwolfe> wluyima, are your changes mixed in with the merge from upstream? :-/ |
| 19:47:23 | <wluyima> bwolfe, yeah otherwise you couldnt pull it since it had conflicts, but hold on |
| 19:47:40 | <wluyima> bwolfe, hold onto pull it i need to add something before you pull it |
| 19:47:49 | <wluyima> bwolfe, i will let you know to pull it |
| 19:47:50 | <bwolfe> wluyima, each commit to your local repo shows up as a diff commit in github |
| 19:48:07 | <bwolfe> you shoudl commit often to local |
| 19:51:41 | <bwolfe> wluyima, I don't think your template is right. but suranga would be able to confirm |
| 19:51:50 | <bwolfe> you are working on the level above what he asked for |
| 19:52:12 | <bwolfe> you should only expect one encounter in the "Generic Patient Result" template. |
| 19:54:03 | <applecool> bwolfe: hi |
| 19:54:32 | <wluyima> bwolfe, that is what addressed and is what i ned to push before you pull |
| 19:54:50 | <applecool> bwolfe: can you tell me which application do you use for the screen recording on mac? |
| 19:55:05 | <wluyima> bwolfe, am editing the MD5SUM in the liquibase file |
| 19:56:12 | <mvorobey_> bwolfe, just verified your fix, it works well, going to attach a patch for that so you and djazayeri, please, review it and let me know that it's good to be committed and backported. |
| 19:59:03 | <applecool> dkayiwa: hi |
| 19:59:12 | <dkayiwa> applecool: hi |
| 19:59:44 | <applecool> can you please tell me which application do you use for the screen recording? |
| 19:59:50 | <applecool> on mac dkayiwa |
| 20:00:24 | <dkayiwa> applecool: do you mean screen capture? |
| 20:00:42 | <applecool> no no screen capture ! we can use Grab right |
| 20:00:49 | *** jkeiper__ has quit IRC |
| 20:00:56 | <applecool> for screen recording! for video i meant dkayiwa |
| 20:01:17 | *** jkeiper__ has joined #openmrs |
| 20:01:58 | <bwolfe> applecool, I don't use a mac. dkayiwa or djazayeri are the guys to question. :-) |
| 20:02:00 | <dkayiwa> applecool: you can use quicktime |
| 20:02:18 | <applecool> bwolfe: oh . okay :) |
| 20:02:40 | <applecool> dkayiwa: quicktime! seriously? i never knew that |
| 20:02:41 | <dkayiwa> applecool: http://www.wikihow.com/Record-Your-Screen-on-Mac |
| 20:02:45 | <OpenMRSBot> <http://ln-s.net/$a+G> (at www.wikihow.com) |
| 20:03:43 | <applecool> dkayiwa: oh wow! awesome! Thanks a lot :) |
| 20:04:24 | <mvorobey_> bwolfe, djazayeri: already created code review for TRUNK-3240 - https://source.openmrs.org/cru/CR-TRUNK-687, would appreciate if you provide me feedback on this |
| 20:05:59 | *** applecool has quit IRC |
| 20:07:15 | <bwolfe> wluyima, I don't follow. you are pushing the wrong thing intentionally? |
| 20:17:13 | <wluyima> bwolfe, which wrong thing |
| 20:17:41 | <wluyima> what i last pushed was just a merge after conflict resolution |
| 20:23:21 | *** maurya has quit IRC |
| 20:24:55 | <bwolfe> wluyima, so everything in this commit is just a merge from upstream? https://github.com/wluyima/openmrs-module-hl7query/commit/bb47d6c8ba890cb49de8daccbaa7f053c3589b6a |
| 20:24:59 | <OpenMRSBot> <http://ln-s.net/$a+t> (at github.com) |
| 20:26:47 | <bwolfe> wluyima, ok, nm, I'll just comment on your pull request. :-) |
| 20:28:44 | *** jkeiper has joined #openmrs |
| 20:30:29 | *** lh has joined #openmrs |
| 20:31:24 | *** jkeiper__ has quit IRC |
| 20:31:32 | <wluyima> bwolfe, and that is why i said that before you pull it i need to first push the fix i made |
| 20:31:46 | <wluyima> bwolfe, then i will let you know |
| 20:31:56 | <wluyima> bwolfe, give me about 5min |
| 20:32:52 | <bwolfe> wluyima, I think suranga has broken it up into too many sub-templates. the layout of htem is confusing. |
| 20:33:07 | <bwolfe> wluyima, can you send me the excel file he made for the hierarchy of hte templates? |
| 20:33:44 | <wluyima> bwolfe, sure |
| 20:35:18 | <bwolfe> (wluyima, or link me to a ticket if he attached it somewhere) |
| 20:35:42 | <wluyima> bwolfe, i have sent it to you |
| 20:36:05 | <wluyima> bwolfe, at ben@openmrs.org |
| 20:37:59 | <wluyima> bwolfe, now you can pull it |
| 20:38:37 | <bwolfe> wluyima, did you commit again? |
| 20:39:45 | <wluyima> bwolfe, yes |
| 20:40:21 | *** goutham has joined #openmrs |
| 20:53:21 | <goutham> hi dkayiwa |
| 20:53:32 | <dkayiwa> hi goutham |
| 20:54:40 | <goutham> dkayiwa: can you point me to a openmrs core controllerTest class which test a @controller annotated class |
| 21:04:55 | <wluyima> bwolfe, seen your comments, from what suranga, daniel and i discussed yesterday, the obs are to be taken care of by the template in HLQRY-38 |
| 21:05:22 | <bwolfe> wluyima, yes, but you have to call that template still... |
| 21:06:03 | <bwolfe> wluyima, look at that graphic that you sent me for the box labeled HLQRY-31 |
| 21:07:24 | <wluyima> bwolfe, and 'Generic Patient' template exists in the mock but has yet been inserted into the DB so the etsts still pass |
| 21:07:42 | <bwolfe> oh ok |
| 21:07:48 | <goutham> dkayiwa: did you get my question? |
| 21:08:58 | *** jkeiper__ has joined #openmrs |
| 21:09:25 | <wluyima> bwolfe, i think these tickets' taks are still mixed because as you said i actually not sure about which template prints the Obs |
| 21:10:19 | <bwolfe> wluyima, the obs one is in progress by daniel |
| 21:10:39 | <bwolfe> ideally we would have had this graphic from the beginning |
| 21:10:50 | <bwolfe> then its easy to see which template calls/depends on another |
| 21:10:58 | <wluyima> bwolfe, though i recall suranga saying the template daniel is working on should loop over each encounter's obs which seems wrong to me |
| 21:11:25 | <wluyima> bwolfe, i think i agree with you that the Patient Result template i worked on should actually print the obs |
| 21:11:54 | *** suranga has joined #openmrs |
| 21:12:34 | <wluyima> bwolfe, so from that diagram which tag represents an encounter? |
| 21:12:37 | *** jkeiper has quit IRC |
| 21:12:49 | <bwolfe> wluyima, the green box |
| 21:12:57 | <bwolfe> "OBR ENC" |
| 21:13:06 | <bwolfe> because suranga has the first OBR being the encounter |
| 21:13:20 | <suranga> wluyima, bwolfe um. no, the white one, right |
| 21:13:24 | <wluyima> bwolfe, so there will be multiple patient result tags |
| 21:13:38 | <suranga> bwolfe, the pv1 _ pid also repesent enounter centric data |
| 21:13:48 | <suranga> sorry guys, just woken up |
| 21:13:56 | <bwolfe> wluyima, yes, listen to suranga |
| 21:14:51 | <bwolfe> wluyima, multiple PATIENT_RESULT (as shown in the diagram)( |
| 21:16:49 | <wluyima> bwolfe, then i can see that the diagram and the tickets contradict |
| 21:17:42 | <suranga> wluyima, r u referring to ticket 31 ? |
| 21:17:59 | <wluyima> bwolfe, when it comes to the green box and the orange one |
| 21:18:03 | <bwolfe> wluyima, how do they contradict? |
| 21:18:08 | <wluyima> the light green one |
| 21:18:23 | <bwolfe> the light green one is done. and that is the OBR-ENC you are calling |
| 21:18:47 | <bwolfe> then you loop over obs and call the 38 one. (or just call the 38 one and it loops over obs, suranga can confirm) |
| 21:19:07 | <bwolfe> suranga, fyi: the ticket desc on https://tickets.openmrs.org/browse/HLQRY-38 is terrible. you might want to check in with daniel to make sure he is on track with what you expect |
| 21:20:07 | <suranga> bwolfe, the idea behind 38 was that it would know how to iterate over numerous ob groups |
| 21:20:12 | <rfriedman> bwolfe, any chance at all we could do the review Thu @ 11? |
| 21:20:39 | <bwolfe> rfriedman, only if it takes less than 10 mins. |
| 21:20:47 | <rfriedman> bwolfe, haha |
| 21:20:50 | <bwolfe> rfriedman, I'm happy to do the review asynch earlier or later |
| 21:21:01 | <suranga> bwolfe, wluyima for example wluyima would call the 38 (patient result) template per each enc, and that it, it would take care of the rest |
| 21:21:22 | <rfriedman> right, no problem, let's go with Fri 8 am |
| 21:21:27 | <bwolfe> so wyclif's template only makes three template calls? |
| 21:21:30 | <bwolfe> passing patient to the first |
| 21:21:34 | <bwolfe> then encounter to the OBR-ENC |
| 21:21:48 | <bwolfe> then the encounter again to the OBR 38 one that daniel is making? |
| 21:22:09 | <suranga> bwolfe, yes, thats right |
| 21:22:39 | <wluyima> so why does the light green and orange have the same tag name? |
| 21:23:17 | <wluyima> bwolfe, suranga am just being curious |
| 21:23:24 | <bwolfe> wluyima, because thats how suranga decided to do it. look at https://wiki.openmrs.org/display/projects/A+Developer's+Guide+to+the+ORUR01+Message |
| 21:23:36 | <suranga> bwolfe, wluyima wluyima 's ticket is responsible for iterating over the encounter list (one patient result + OBRENC + ORUR01.PAtient per) each encounter |
| 21:23:46 | <bwolfe> wluyima, suranga, see my comment on the bottom of htat page (that I made 15 mins ago) about whether we really need that OBR-ENC. |
| 21:24:13 | <wluyima> suranga, right HLQRY-32 loops over the encounters calling patienr result template |
| 21:24:22 | <bwolfe> suranga, I don't think wyclif iterates. he just receives one encounter. the main orur01 template should do the iterating |
| 21:24:42 | <bwolfe> suranga, in fact, I think you have too many templates |
| 21:24:44 | <wluyima> bwolfe, he means my ticket HLQRY-32 |
| 21:24:57 | <wluyima> bwolfe, i assume |
| 21:24:58 | <bwolfe> wyclif's ticket could be merged up to be the main orur01 one |
| 21:25:28 | <suranga> wluyima, bwolfe mm.. ticket 32 is the main OURUR01 temlate :) |
| 21:25:43 | <bwolfe> yes, 32 iterates |
| 21:25:49 | <bwolfe> 31 just uses the encounter |
| 21:25:54 | <wluyima> right |
| 21:26:09 | <bwolfe> but 31 doesn't have to exist. 32 could make those three template calls and still not be very complicated |
| 21:28:57 | <suranga> bwolfe, here i was thinking about anyone who might want to introduce another sub template into the same hierachy |
| 21:29:22 | <suranga> bwolfe, for example, if someone says, i want an ORC segment before the OBR-ENC |
| 21:29:53 | <suranga> then theyhave to edit only a small part to get by name. rather than a huge template section... |
| 21:29:59 | *** jordank has joined #openmrs |
| 21:34:49 | <bwolfe> suranga, its the same amount |
| 21:34:55 | <bwolfe> suranga, I see no change in complexity |
| 21:35:21 | <bwolfe> as you have it: 32 looks like this: call msh, call 31 |
| 21:35:51 | <suranga> and call 38, right ? |
| 21:36:00 | <bwolfe> I suggest: 32 looks like this: call msh. call pid. call OBR-ENC. call 38 |
| 21:36:54 | <suranga> bwolfe, umm.. pid is joined with pv1, right ? you still call those together ? |
| 21:41:05 | <wluyima> bwolfe, suranga we has said that when calling HLQRY-38 we pass in an encounter and not a list of obs right or vice versa? |
| 21:41:18 | *** suranga_ has joined #openmrs |
| 21:41:29 | <suranga_> bwolfe,you are in favour of removing ticket 31, mm ? :( |
| 21:42:16 | <suranga_> bwolfe, that ticket is already working fine, i think ... |
| 21:42:56 | *** mvorobey_ has quit IRC |
| 21:44:09 | <wluyima> suranga, bwolfe ? |
| 21:44:30 | *** suranga has quit IRC |
| 21:45:00 | *** snoppy has left #openmrs |
| 21:49:27 | *** lh has quit IRC |
| 21:49:40 | <suranga_> wluyima, um..ticket 31 is already wrapped up, right ? |
| 21:59:49 | <wluyima> suranga_, am commiting the call to ticket 38 |
| 22:00:14 | <suranga_> hi wluyima |
| 22:00:24 | <wluyima> suranga_, and the assumption is that 38 takes in an encounter and gets the collection os obs and loops over it, right |
| 22:00:25 | <suranga_> wluyima, sure... umm.. bwolfe seems to be away.. |
| 22:01:19 | <suranga_> wluyima, thats right :) |
| 22:01:59 | <suranga_> !lastseen pluasthi7 |
| 22:02:00 | <OpenMRSBot> suranga_: Error: "lastseen" is not a valid command. |
| 22:02:09 | <suranga_> !last seen pluasthi7 |
| 22:02:09 | <OpenMRSBot> suranga_: (last [--{from,in,on,with,without,regexp} <value>] [--nolimit]) -- Returns the last message matching the given criteria. --from requires a nick from whom the message came; --in requires a channel the message was sent to; --on requires a network the message was sent on; --with requires some string that had to be in the message; --regexp requires a regular expression the message must match; (1 more message) |
| 22:02:55 | <suranga_> wluyima, so your ticket, (31) does it work nicely now ? :) |
| 22:04:05 | <bwolfe> sorry guys, went to eat dinner with the fam |
| 22:04:17 | <bwolfe> yes, I am in favor of merging 31 up into 32. :-) |
| 22:04:22 | <bwolfe> luckily those are both wyclif's :_) |
| 22:04:28 | <suranga_> bwolfe, um.. dinner at this time ? ... |
| 22:05:24 | <suranga_> bwolfe, i would support your decision, but um... wont that take more time to change ? |
| 22:06:05 | <wluyima> bwolfe, am fine with that |
| 22:06:22 | <wluyima> suranga_, do u do agree we merge those 2 |
| 22:07:21 | <wluyima> so suranga_ can you pull https://github.com/OpenMRS/openmrs-module-hl7query/pull/39 |
| 22:07:22 | <OpenMRSBot> <http://ln-s.net/$a$:> (at github.com) |
| 22:07:43 | <wluyima> suranga_, so that i font have to copy the code from the branch to get it working with HLQRY-38 |
| 22:07:46 | <bwolfe> wluyima, I would rather we simplify things for the end user. merging 31 and 32 is not that hard. it hasn't been pulled to master yet, so wyclif cna easily change in his branch. :-) |
| 22:08:58 | <suranga_> bwolfe, wluyima would prefer that I merge it :) |
| 22:09:20 | <suranga_> sorry, *pull it |
| 22:10:06 | <suranga_> !lastsen pulasthi7 |
| 22:10:07 | <OpenMRSBot> suranga_: Error: "lastsen" is not a valid command. |
| 22:10:07 | <bwolfe> wluyima, pulling it seems like a bad decision |
| 22:10:15 | <suranga_> !lastseen pulasthi7 |
| 22:10:16 | <OpenMRSBot> suranga_: Error: "lastseen" is not a valid command. |
| 22:10:38 | <bwolfe> gotta run. discuss amoungts yourselves. :-) |
| 22:10:46 | <bwolfe> (you can do whatever suranga_ thinks is best) |
| 22:10:55 | <suranga_> wluyima, bwolfe ok.... |
| 22:11:27 | <suranga_> wluyima, since bwolfe says so, we should better not pull that change ... :-) |
| 22:11:44 | <wluyima> bwolfe, suranga_ pulling it so that i code against it for HLQRY-32 is way easier to me |
| 22:12:09 | <wluyima> bwolfe, if not i commit the code i have written for HLQRY-32 and commit it to the HLQRY-31 branch and mark HLQRY-32 as resolved by 31 |
| 22:12:19 | <suranga_> wluyima, how much longer will it take you to complete this, could you finish by EOD today ? |
| 22:13:34 | <wluyima> suranga_, the work to be done is not hard or much but if i have to merge the two ticket's work, it means you have to close ticket 32 and edit the description of 31 |
| 22:13:57 | <suranga_> wluyima, in intrests of getting this done soon, shall I pull your request ? |
| 22:14:15 | <wluyima> suranga_, that gets me going quicker |
| 22:14:45 | <wluyima> because it means i just update my working cpy to get the changes and then just complete 32 |
| 22:15:22 | <suranga_> wluyima, done.... but dont tell bwolfe i did it :( |
| 22:15:25 | *** jkeiper__ has quit IRC |
| 22:15:39 | <wluyima> suranga_, so let me udpate mine to get the pull |
| 22:15:49 | <wluyima> suranga_, and everything is solved |
| 22:16:11 | *** jkeiper has joined #openmrs |
| 22:19:09 | <suranga_> wluyima, its around 4 am in my time, so i need to sign off for a while |
| 22:19:20 | <wluyima> suranga_, thanks |
| 22:19:36 | *** scsibug has joined #openmrs |
| 22:19:53 | <suranga_> wluyima, could you please do me a favour ? could you comment on the ticket decription saying how much of it you have finished at EOD ? |
| 22:21:19 | <wluyima> i will be done by end of day |
| 22:21:24 | <wluyima> suranga_, i will be done by end of day |
| 22:22:27 | <suranga_> wluyima, that would be super cool. sorry for causing this mess up :( |
| 22:23:50 | <wluyima> suranga_, no problem |
| 22:24:57 | *** suranga_ has quit IRC |
| 22:34:59 | *** rfriedman has quit IRC |
| 22:42:53 | *** jkeiper_ has joined #openmrs |
| 22:46:25 | *** jkeiper has quit IRC |
| 23:11:38 | *** jordank has quit IRC |
| 23:30:00 | *** goutham has quit IRC |
| 23:35:48 | *** jkeiper has joined #openmrs |
| 23:38:34 | *** jkeiper_ has quit IRC |
| 23:51:59 | *** kreddy has quit IRC |
| 23:58:41 | *** dkayiwa has quit IRC |