IRC Chat : 2012-08-05 - OpenMRS

01:33:37 *** r0bby is now known as robbyoconnor
01:44:07 *** bwolfe has joined #openmrs
01:44:07 *** ChanServ sets mode: +o bwolfe
01:48:48 *** r0bby has joined #openmrs
01:48:48 *** ChanServ sets mode: +v r0bby
01:51:22 *** robbyoconnor has quit IRC
01:58:46 *** r0bby is now known as robbyoconnor
02:53:50 *** djazayeri has joined #openmrs
02:53:50 *** ChanServ sets mode: +o djazayeri
03:20:32 *** suranga has joined #openmrs
03:20:32 *** ChanServ sets mode: +v suranga
03:23:43 <suranga> hi bwolfe :)
03:23:55 <suranga> bwolfe, are you around, by any chance ?
03:24:42 <bwolfe> for about 30 seconds
03:25:06 <suranga> bwolfe, oh, sorry, no worries. just wanted to ask if you have any ideas for the sprint :)
03:25:16 <bwolfe> ideas?
03:25:21 <suranga> bwolfe, I hope you are not planning to cut my resources :)
03:25:32 <bwolfe> nothing aside from the date function in the hl7templatefunctions class
03:25:47 <bwolfe> suranga, they will be reduced,but that was known already
03:26:03 <suranga> bwolfe, cool, I've been doing some work over the weekend, i might add that myself
03:26:19 <suranga> bwolfe, mm.. what happens if we cant finish all tickets by friday ? ;(
03:26:36 <bwolfe> bad things happen
03:26:42 <bwolfe> gremlins will eat your shoes
03:27:42 <suranga> bwolfe, :(
03:29:48 <bwolfe> yep, buy a second pair of shoes as backup. :-)
03:29:58 <bwolfe> ok, gotta run. falling asleep at the keyboard here...
03:30:13 <suranga> bwolfe, oh, sorry... will catch you later :(
03:31:15 *** Jibesh has joined #openmrs
03:34:54 *** bwolfe has quit IRC
03:46:21 *** djazayeri has quit IRC
05:01:48 *** applecool has joined #openmrs
05:01:48 *** ChanServ sets mode: +v applecool
05:03:12 *** Jibesh has quit IRC
05:04:06 *** maurya has joined #openmrs
05:37:01 *** robbyoconnor has quit IRC
05:37:39 *** applecool has quit IRC
05:41:27 *** robbyoconnor has joined #openmrs
05:41:27 *** ChanServ sets mode: +v robbyoconnor
06:35:55 *** maurya has quit IRC
06:56:07 *** applecool has joined #openmrs
06:56:07 *** ChanServ sets mode: +v applecool
07:23:49 *** dkayiwa has joined #openmrs
07:33:55 *** dkayiwa has quit IRC
07:34:49 *** dkayiwa has joined #openmrs
07:48:38 *** applecool has quit IRC
07:51:20 *** maurya has joined #openmrs
07:57:05 *** ChanServ sets mode: +v maurya
08:02:57 *** dkayiwa has quit IRC
08:04:53 *** maurya has quit IRC
08:05:35 *** maurya has joined #openmrs
08:07:16 *** dkayiwa has joined #openmrs
08:08:53 *** maurya has quit IRC
08:09:11 *** maurya has joined #openmrs
08:10:54 *** maurya has quit IRC
08:11:21 *** maurya has joined #openmrs
08:14:53 *** maurya has quit IRC
08:15:11 *** maurya has joined #openmrs
08:19:20 *** goutham has joined #openmrs
08:19:20 *** maurya has quit IRC
08:19:51 *** maurya has joined #openmrs
08:21:04 *** pulasthi7 has joined #openmrs
08:21:33 <pulasthi7> hi suranga
08:22:54 *** maurya has quit IRC
08:23:25 *** maurya has joined #openmrs
08:28:53 *** maurya has quit IRC
08:29:15 *** maurya has joined #openmrs
08:30:33 <goutham> hi dkayiwa
08:30:41 <dkayiwa> goutham: hi
08:33:17 <goutham> dkayiwa: ru free? can we have review session on the code :)
08:33:55 <dkayiwa> goutham: can u give me like 30 mins?
08:38:11 <goutham> dkayiwa: Ok : )
08:49:24 *** dkayiwa_ has joined #openmrs
08:51:42 *** dkayiwa has quit IRC
08:51:42 *** dkayiwa_ is now known as dkayiwa
08:58:04 *** maurya has quit IRC
08:58:23 *** maurya has joined #openmrs
09:28:47 *** suranga_ has joined #openmrs
09:32:08 *** suranga has quit IRC
10:23:10 <dkayiwa> hi goutham
10:36:24 <goutham> dkayiwa: Hi
10:37:11 <dkayiwa> goutham: first comment, is your unit test method names does not follow that of openmrs for service interfaces
10:37:18 <dkayiwa> goutham: have you noticed that too?
10:37:44 <dkayiwa> goutham: as in your naming convetion
10:38:03 <goutham> dkayiwa: i dint observe.
10:38:22 *** suranga_ has quit IRC
10:38:22 <dkayiwa> goutham: can you observe it now?
10:41:54 <goutham> dkayiwa: Yes .. should i follow the same convention for the filter test case also
10:53:16 *** r0bby has joined #openmrs
10:53:16 *** ChanServ sets mode: +v r0bby
10:55:36 *** r0bby_ has joined #openmrs
10:55:36 *** ChanServ sets mode: +v r0bby_
10:56:13 *** robbyoconnor has quit IRC
10:58:05 *** r0bby has quit IRC
10:58:40 *** robbyoconnor has joined #openmrs
10:58:40 *** ChanServ sets mode: +v robbyoconnor
11:00:26 *** r0bby_ has quit IRC
11:09:54 *** maurya has quit IRC
11:10:18 *** maurya has joined #openmrs
11:12:37 *** maurya has quit IRC
11:13:07 *** maurya has joined #openmrs
11:15:53 *** maurya has quit IRC
11:16:18 *** maurya has joined #openmrs
11:22:53 *** maurya has quit IRC
11:23:12 *** maurya has joined #openmrs
11:25:54 *** maurya has quit IRC
11:26:12 *** maurya has joined #openmrs
11:28:53 *** maurya has quit IRC
11:29:12 *** maurya has joined #openmrs
11:30:25 *** goutham has quit IRC
11:31:37 *** maurya has quit IRC
11:32:01 *** maurya has joined #openmrs
11:34:39 *** maurya has quit IRC
11:35:33 *** maurya has joined #openmrs
11:39:07 *** maurya has quit IRC
11:39:29 *** maurya has joined #openmrs
11:42:54 *** maurya has quit IRC
11:44:49 *** maurya has joined #openmrs
11:46:54 *** maurya has quit IRC
11:47:54 *** applecool has joined #openmrs
11:47:54 *** ChanServ sets mode: +v applecool
11:49:35 *** maurya has joined #openmrs
11:53:48 *** rram_ has joined #openmrs
12:01:31 *** goutham has joined #openmrs
12:10:51 *** goutham_ has joined #openmrs
12:15:00 *** goutham_ has quit IRC
12:16:18 *** goutham has quit IRC
12:39:58 *** harshadura has joined #openmrs
12:43:02 *** djazayeri has joined #openmrs
12:43:02 *** ChanServ sets mode: +o djazayeri
12:44:03 *** djazayeri has quit IRC
12:50:58 *** djazayeri has joined #openmrs
12:50:58 *** ChanServ sets mode: +o djazayeri
13:11:05 *** harshadura has quit IRC
13:12:30 *** harshadura has joined #openmrs
13:12:40 *** maurya has quit IRC
13:12:58 *** maurya has joined #openmrs
13:18:26 *** pushkar has joined #openmrs
13:22:23 *** pushkar has quit IRC
13:22:23 *** maurya has quit IRC
13:22:48 *** pushkar has joined #openmrs
13:22:58 *** maurya has joined #openmrs
13:23:39 *** rram_ has quit IRC
13:52:17 *** mgielow has joined #openmrs
13:55:22 *** rram_ has joined #openmrs
14:15:52 *** applecool has quit IRC
14:35:22 *** pushkar has quit IRC
14:35:45 *** pushkar has joined #openmrs
14:41:24 *** dkayiwa has quit IRC
14:55:54 *** rram_ has quit IRC
14:57:29 *** harshadura has quit IRC
14:57:46 *** rram_ has joined #openmrs
14:59:54 *** pushkar_ has joined #openmrs
15:02:57 *** pushkar has quit IRC
15:14:14 *** maurya has quit IRC
15:14:35 *** maurya has joined #openmrs
15:17:37 *** sgithens has joined #openmrs
15:20:57 *** djazayeri has quit IRC
15:26:34 *** maurya has quit IRC
15:27:04 *** maurya has joined #openmrs
15:35:37 *** sgithens has quit IRC
15:47:17 *** maurya has quit IRC
15:47:36 *** maurya has joined #openmrs
15:48:30 *** pushkar_ has quit IRC
16:09:54 *** maurya has quit IRC
16:10:56 *** maurya has joined #openmrs
16:17:19 *** sandeep_ has joined #openmrs
16:33:01 *** applecool has joined #openmrs
16:33:01 *** ChanServ sets mode: +v applecool
17:01:40 *** sandeep_ has quit IRC
18:01:42 *** goutham has joined #openmrs
18:09:11 *** bwolfe has joined #openmrs
18:09:11 *** ChanServ sets mode: +o bwolfe
18:18:10 *** maurya has quit IRC
18:29:48 *** pulasthi7 has quit IRC
18:43:45 *** goutham has quit IRC
18:57:16 *** goutham has joined #openmrs
19:24:36 *** rram_ has quit IRC
19:32:11 *** applecool has quit IRC
19:52:41 *** suranga has joined #openmrs
19:52:44 *** ChanServ sets mode: +v suranga
19:55:04 <suranga> hi bwolfe !
19:55:24 <bwolfe> hi suranga
19:55:28 <suranga> bwolfe, so i googled gremlins, and did not like them too much...
19:55:36 <suranga> bwolfe, so I rooted through the tickets again
19:55:46 <suranga> I made a short list, (3) tickets
19:56:17 <suranga> bwolfe, I think, if we complete these three tickets, we can have a working version (albeit very weak) by friday :)
19:57:13 <suranga> bwolfe, In case you're intrested https://wiki.openmrs.org/download/attachments/36077722/ORUR01_Structure.xlsx?version=1&modificationDate=1344193915000 is a detailed example of who;s writing what segment, and what more needs to be done :)
19:58:16 <bwolfe> haha, nice excel sheet. :-)
19:58:24 <bwolfe> suranga, how far behind are you on pull requests?
19:58:41 <suranga> bwolfe, Im not behind any more :P
19:58:44 <bwolfe> do you need me to help out with that tomorrow? (I've been doing a terrible job at it, but luckily you've done great!)
19:58:47 <bwolfe> woohoo!
19:58:48 <bwolfe> suranga++
19:58:54 <bwolfe> so there are no open pull requests?
19:58:57 *** mgielow has quit IRC
19:59:22 <bwolfe> suranga, I had commented on some, did you make those changes or did you merge them and leave comments on the tickets?
19:59:25 <suranga> bwolfe, I went over everything today, and no, not to my best knowlege :)
19:59:50 <bwolfe> no what?
19:59:59 <suranga> bwolfe, no more pulls
20:00:19 <suranga> bwolfe, I had to commit everything, because some changes were holding up other work
20:00:24 <bwolfe> cool
20:00:38 <bwolfe> but you made sure to not close things if there were review comments, right?
20:00:40 <suranga> bwolfe, plus, holding back ment that other pulls got stale too :(
20:00:51 <suranga> bwolfe, oh yep, will do that
20:01:22 <suranga> bwolfe, in fact, I think I will do another iteration over tickets again (just in case)
20:24:38 *** rfriedman has joined #openmrs
20:24:59 <rfriedman> bwolfe, hi ben, u there?
20:26:27 <bwolfe> rfriedman, uh, no?
20:39:00 <rfriedman> bwolfe, guess you're not
20:40:21 <rfriedman> bwolfe, do you remember whether we made a decision about whether module-defined REST resources should have some prefix indicating the module, or that /module/resource would be enough?
20:41:15 <bwolfe> rfriedman, I don't think its necessary
20:41:45 <bwolfe> if its something that you are hoping is merged to core restws, you could use a standard /ws/rest/myobject. that way your client is future-proofed
20:42:02 <bwolfe> if it is somethign custom, you should probably do /ws/rest/themoduleid/myobject
20:42:15 <rfriedman> bwolfe, actually, i was expecting core to merge into my module
20:42:41 <rfriedman> bwolfe, hehe
20:45:32 <bwolfe> rfriedman, is that on backwards day?
20:57:06 *** bwolfe has quit IRC
21:18:14 *** rfriedman has quit IRC
21:25:40 *** suranga has quit IRC
22:04:34 *** goutham has quit IRC
23:57:16 *** rfriedman has joined #openmrs