IRC Chat : 2012-08-02 - OpenMRS

00:05:45 *** bwolfe has joined #openmrs
00:05:45 *** ChanServ sets mode: +o bwolfe
00:05:57 *** mccallumg has quit IRC
00:56:20 *** deepaganu has joined #openmrs
01:45:53 *** deepaganu has quit IRC
02:05:01 *** harshadura has joined #openmrs
02:28:51 *** upul` has joined #openmrs
02:28:51 *** ChanServ sets mode: +v upul`
02:34:18 *** Seguame has joined #openmrs
02:34:46 <Seguame> Hi everyone, I have a question about the REST module
02:36:00 <Seguame> I'm doing an Android APP using it, I need to a certain patient add an alergie or observation
02:37:01 <Seguame> but I can't figure out how to do that within the APP. I only can edit the name for example
02:41:30 <bwolfe> Seguame, use the patient dashboard to add an allergy in the webapp
02:41:49 <bwolfe> Seguame, the fastest way to add an observation is to first add an encounter using hte admin screen, then add an observation to that encounter
02:42:23 <bwolfe> Seguame, the long way to add an encounter+observations is to use a module like htmlformentry to design a form, then choose that form on the patient's dashboard and fill it out
02:48:00 <Seguame> bwolfe, But i'm requiring doing it without the dashboard, the idea is that a medic/nurse can make all the work in a Tablet with Android
02:48:39 <bwolfe> Seguame, oh, you said "within the app", so I thought you meant the webapp
02:49:00 <bwolfe> Seguame, are you wondering which rest api calls to make?
02:49:21 <Seguame> bwolfe, I was referring to the APP that i'm building :P
02:49:41 <Seguame> I already use GET to retrieve certaing info of a given patient
02:49:46 <Seguame> to work whit
02:50:32 <bwolfe> for observation, see the /obs or /encounter resources
02:50:45 <Seguame> and then do certain annotations like, lets say, weight and observations of that day
02:50:49 <bwolfe> for allergies...hmm, not sure if those are represented yet. are you looking at the restws docs?
02:50:50 <Seguame> ok
02:50:59 <Seguame> yes i'm on it
02:51:13 <bwolfe> Seguame, there are two rest modules, which one do you have loaded?
02:52:00 <Seguame> bwolfe, Rest Web Services 1.0.28039
02:52:43 <bwolfe> ok, sounds right
02:52:50 <Seguame> I just can't figure out how to relate a patient with an observation/allergi
02:53:32 <Seguame> bwolfe, this may sound silly but, do I need to use the OpenMRS-api or can be donn just perfeclty with the REST module
02:53:43 <Seguame> donne*
02:57:30 <bwolfe> Seguame, you can only use the api if the openmrs instance and your app are on the same machine. (aka if you are installing openmrs to the android phones)
02:57:38 <bwolfe> but I assume you will need rest
02:59:15 <Seguame> Then i'm not requiring it, a server will keep OpenMRS
03:08:10 <Seguame> bwolfe, thanks for your attention, I have to quit at the moment; have a nice day.
03:08:20 *** Seguame has quit IRC
03:12:26 *** seguame has joined #openmrs
03:12:36 <bwolfe> seguame, back so soon? :-)
03:13:00 <seguame> Yeah, it looks like I wasn't required yet :P
03:25:50 *** djazayeri has joined #openmrs
03:25:50 *** ChanServ sets mode: +o djazayeri
03:27:56 *** yanokwa has joined #openmrs
03:27:56 *** ChanServ sets mode: +v yanokwa
03:27:58 *** yanokwa has quit IRC
03:28:06 *** yanokwa has joined #openmrs
03:28:06 *** ChanServ sets mode: +v yanokwa
03:29:43 *** yanokwa has quit IRC
03:30:29 *** yanokwa has joined #openmrs
03:30:29 *** ChanServ sets mode: +v yanokwa
03:31:21 *** yanokwa has quit IRC
03:38:20 *** seguame has quit IRC
03:44:49 *** suranga has joined #openmrs
03:44:49 *** ChanServ sets mode: +v suranga
03:45:08 <suranga> mm.. hi bwolfe .. are you aronund, by any chance ?
03:45:28 <bwolfe> hi, yes
03:46:19 <suranga> bwolfe, hi, sorry , missed you last night, so wanted to ask 2 questions
04:15:00 *** djazayeri has quit IRC
04:33:16 *** harshadura has quit IRC
05:09:06 *** bwolfe has quit IRC
05:21:41 *** suranga has quit IRC
05:52:21 *** jordank has quit IRC
06:10:24 *** applecool has joined #openmrs
06:10:24 *** ChanServ sets mode: +v applecool
06:10:37 *** maurya has joined #openmrs
06:10:55 *** ChanServ sets mode: +v maurya
06:39:08 *** rafa has joined #openmrs
06:39:08 *** ChanServ sets mode: +v rafa
06:48:09 *** maurya has quit IRC
06:59:49 *** judygichoya has joined #openmrs
07:10:22 *** dawn_ has joined #openmrs
07:10:28 *** ChanServ sets mode: +v dawn_
07:40:19 *** suranga has joined #openmrs
07:40:19 *** ChanServ sets mode: +v suranga
07:40:31 <suranga> hi everyone !
07:40:33 <judygichoya> suranga hello
07:40:39 <judygichoya> got your message ...
07:40:40 <judygichoya> Thanks
07:40:43 <suranga> sorry for the delay, my other Jobs calls :)
07:41:07 <suranga> cool, Looks like you have made a lot of progress from where we stopped off... :)
07:41:16 <suranga> hi rafa
07:51:37 <suranga> judygichoya, hi, are u sure that we can have more than one preferred patient name ?
07:51:52 <suranga> judygichoya, Ben said so ?
07:51:57 <judygichoya> yes
07:52:21 <judygichoya> look up irc chat .. patientName in patient.getNames()
07:52:34 <judygichoya> and you may trace the conversation
07:52:38 <suranga> ah, cool, ben is to be belived in all things :)
07:52:54 <judygichoya> this may happen in a case where a woman gets married
07:52:57 <judygichoya> and gets a maiden name?
07:53:05 <judygichoya> maybe a question for design call
07:53:21 <suranga> judygichoya, let me check that...
07:53:30 <judygichoya> def identifiers can be multiple..
07:58:17 <rafa> hi suranga
07:59:03 <suranga> rafa, good morning ! sun is shining, birds are singing, and everyone is working on my tickets ! bwahhahahaaaaaaaa
07:59:13 <rafa> haha
07:59:18 <judygichoya> :)
07:59:20 <rafa> suranga: good morning
07:59:22 <suranga> rafa, I see you picked out the ORUR01 template ticket, thats nice
07:59:25 <judygichoya> :)
07:59:40 <rafa> suranga: yes
07:59:58 <rafa> suranga: may I ask a question Sir? :D
08:00:05 <suranga> rafa, nice... have I pulled all your stuff so far ?
08:00:09 <suranga> umm.. ok......
08:00:12 <rafa> suranga: yes
08:00:27 <rafa> suranga: QUESTION) Check if groovy is capable of identifying the constant directly, instead of us having to write a method to do just that.
08:00:31 <rafa> suranga: what does it mean?
08:00:43 <rafa> suranga: it's from the ticket description
08:00:45 <rafa> suranga: it
08:00:51 <rafa> suranga: it's not mine question
08:01:01 * suranga goes to look
08:01:04 <rafa> suranga: so I have a question abou a question :D
08:01:58 <rafa> !ticket HLQRY-32
08:01:59 <OpenMRSBot> rafa: [#HLQRY-32] Create ORUR01 template which produces the complete ORUR01 message - OpenMRS JIRA - https://tickets.openmrs.org/browse/HLQRY-32
08:02:01 <rafa> let me help you :)
08:02:44 <suranga> rafa, its like this..
08:02:52 <suranga> this tikcet joins together other segments
08:03:06 <suranga> but it also needs to add xml tags dont exist in some other templates
08:03:14 <rafa> suranga: yes, that's clear
08:03:23 <suranga> rafa, for example : the xml message needs to start with a namespace
08:03:25 <rafa> suranga: what is THE CONSTANT :)
08:03:31 <suranga> which the other segments
08:03:50 <suranga> rafa, so ideally, we will have these segments (namespace, etc) a s constants ?
08:04:04 <suranga> and you can call them, and set them in your template ?
08:04:30 <rafa> suranga: like public static final CONSTANT?
08:04:35 *** applecool has quit IRC
08:04:43 <suranga> rafa, umm... yes
08:05:03 <suranga> these are basically xml tags, whic hthe user should not be allowed to change
08:05:33 <suranga> rafa, actually, we probably shouldnt not even create constants for them. but just add them 'as is' into your template code....
08:05:39 <rafa> suranga: so I'll just add HL7QueryConstants.ORUR01_NAMESPACE = "<xml...." ?
08:05:39 *** pushkar has joined #openmrs
08:05:53 <suranga> rafa, exacrly
08:06:15 <rafa> suranga: ok
08:06:17 <suranga> you will need several other segments as you work on the completed OBR + OBX template
08:06:46 <rafa> suranga: so do I actually combine all templates in one template?
08:07:04 <suranga> rafa, yes... but not all-
08:07:23 <suranga> Daniles PID templated combines Judy's PID.3 templates and hand them over to you
08:07:42 <suranga> you combine these (major templates) which I've listed down on the ticket
08:08:12 <rafa> suranga: yes, clear, but the point is I do all that in a groovy template saved in a db and not in java?
08:08:48 <suranga> rafa, umm... yep, because we want to leet people edit it my swapping template names
08:09:04 <rafa> suranga: ok
08:09:06 <suranga> rafa, for example, someone deletes the template you are calling, and pastes in another
08:09:12 <rafa> yes, got it
08:09:34 <suranga> rafa, this is not a super ticket, I guess. SOrry to be the bringer of bad news :)
08:09:45 <rafa> suranga: I'd love to ask you more questions
08:09:56 <suranga> rafa, umm... ok......
08:10:02 <rafa> suranga: but I can't think of any :P
08:10:23 <rafa> suranga: I'm all set
08:10:25 <suranga> rafa, aaaah ! if you ran out of questions it means im doing a great job ! :)
08:10:27 <rafa> suranga: thanks
08:10:38 <rafa> suranga: yes, good job
08:11:55 <rafa> suranga: ok, have a nice day :) I'll ping you later
08:12:11 <suranga> rafa, you know where to find me :)
08:12:30 <rafa> suranga: yes, don't hide :P
08:15:22 <judygichoya> suranga have you tried to compile the module ...
08:15:38 <judygichoya> after addition of Mockbasetest
08:15:45 <suranga> judygichoya, umm yes, it was ok to me..
08:15:47 <judygichoya> what i this mockito?
08:15:57 <judygichoya> cos it has errors on my eclipse?
08:16:12 <suranga> judygichoya, its something we use to abstract layers.
08:16:35 <judygichoya> do i need to install anything?
08:16:39 <suranga> judygichoya, if I remmeber right, we use it to pretend that some classes return only valid data, and test the more importaint scanrios..
08:16:51 <judygichoya> it has errors at the import.mockito ...
08:17:00 <suranga> judygichoya, no.. mm.. maven should have taken care of that..
08:17:08 <suranga> did you try cleaning your project ?
08:19:04 <judygichoya> yes
08:19:06 <judygichoya> same error
08:19:08 <judygichoya> [ERROR] error: error reading /Users/judygichoya/.m2/repository/org/mockito/mockito-all/1.8.5/mockito-all-1.8.5.jar; cannot read zip file entry
08:19:47 <rafa> judygichoya: delete that file
08:20:00 <rafa> judygichoya: it will be downloaded again
08:20:11 <rafa> judygichoya: probably corrupted due to network problems
08:27:56 *** snoppy has joined #openmrs
08:35:27 <rafa> suranga: Needs Review For HL7 Query doesn't work
08:35:37 <rafa> suranga: on the jira dashboard
08:35:46 <rafa> suranga: it says no matching issues found
08:35:53 <suranga> rafa, ooops
08:35:56 <rafa> suranga: at all times
08:36:15 *** upul` has quit IRC
08:36:17 <suranga> rafa, let me check that :)
08:36:22 *** snoppy has left #openmrs
08:36:34 *** snoppy has joined #openmrs
08:36:46 <rafa> suranga: it should display at least one ticket I know of HLQRY-36 ;)
08:37:24 <rafa> suranga: any naming convention for segment templates?
08:37:41 *** pushkar has quit IRC
08:37:55 <suranga> rafa, not really, i think for daniel we agreed on soemthing. Let me dig that up for you...
08:38:08 <rafa> suranga: Generic PV1
08:38:20 <rafa> suranga: ?
08:38:20 <suranga> rafa, exactly :)
08:38:46 <suranga> rafa, you;re thinking of a name for your template
08:38:48 <suranga> ?
08:38:58 <rafa> suranga: nope
08:39:15 <rafa> suranga: will follow Daniel's convention
08:39:23 <rafa> suranga: Generic OBX
08:39:37 <rafa> suranga: it's for the previous ticket ;)
08:39:45 <rafa> suranga: for OBX segment
08:42:42 <rafa> suranga: I think Daniel's template has a bug
08:43:03 <rafa> suranga: see liquibase.xml and the template column it ends with "]]>
08:43:18 <rafa> suranga: I think " should not be there
08:44:26 <suranga> rafa, you mean the PV1 segment ? I thougnt u wrote the OBX code ?
08:44:38 <judygichoya> suranga
08:44:46 <judygichoya> i have a crappy internet connection...
08:44:53 <suranga> judygichoya, oooops :)
08:44:59 <judygichoya> check if the pull request is submitted correctly...
08:45:08 <judygichoya> what other tickets are remaining?
08:45:18 <rafa> suranga: yes I mean Daniel's segment PV1
08:46:02 <rafa> judygichoya: has deleting the jar resolved your problem?
08:46:08 <judygichoya> yes
08:46:19 <judygichoya> deleted the whole mockito folder
08:46:20 <rafa> judygichoya: ok, good to know
08:46:25 <judygichoya> and cleaned the project
08:46:30 <judygichoya> then maven install.. and it works
08:48:02 <suranga> rafa, it was supposed to end with the <Pv1> .. I thought the ]]> for for CDATA, and got removed before going into the DB :(
08:48:26 <suranga> hmmm Daniel is not around yet, i think :(
08:48:30 <rafa> suranga: ]]> is ok
08:48:38 <rafa> suranga: just " is extra
08:49:25 <suranga> rafa since daniel is away, what should we do for now ? can you think of a workaround ? :)
08:50:18 <rafa> suranga: changing a changeset is not polite for other devs who have already run it
08:50:33 <rafa> suranga: personally, I don't mind
08:51:03 <rafa> suranga: but others will have to remove the row from the table manually and also the changeset from liquibasechangelog
08:51:20 <suranga> rafa, could you do it on your local machine ( for your work) and we'll have Daniel look at it when he gets back ?
08:51:48 <rafa> suranga: yes
08:52:01 <rafa> suranga: have a look at <PV1.2>0</PV1.2> too
08:52:11 <rafa> suranga: what is that?
08:52:19 <judygichoya> suranga maybe you should review my tickets too
08:52:26 <judygichoya> cos they are related...
08:52:32 <judygichoya> so i can make any changes now… :)
08:52:45 <suranga> judygichoya, yep, thats right :)
08:52:58 <rafa> suranga: seems like it's an index and should be a variable
08:53:15 *** harshadura has joined #openmrs
08:53:17 <rafa> suranga: <PV1.2>${encounterIndex}</PV1.2>
08:53:27 <suranga> rafa, i think that was on his review // to do list, i'll check that...
08:53:50 <rafa> suranga: or rather <PV1.2>${visitIndex}</PV1.2>
09:15:33 *** suranga has quit IRC
09:15:34 *** Echidna has quit IRC
09:15:34 *** Mkop has quit IRC
09:17:00 *** suranga has joined #openmrs
09:17:00 *** Echidna has joined #openmrs
09:17:00 *** Mkop has joined #openmrs
09:17:00 *** zelazny.freenode.net sets mode: +vvv suranga Echidna Mkop
09:19:54 <suranga> hi judygichoya
09:20:01 <judygichoya> yes suranga
09:20:03 <suranga> judygichoya, I was looking at your code
09:20:30 <judygichoya> and
09:20:31 <suranga> judygichoya, mmm... one observation. for PID.3, u sem to have missed the second field, right ?
09:20:56 <judygichoya> thats what we have been chatting about in the github
09:21:02 <judygichoya> the patient identifier type?
09:21:15 <suranga> judygichoya, mm.. yep..
09:22:04 <suranga> judygichoya, sorry, didnt understand you, umm.. did we ? :(
09:22:26 <judygichoya> maybe on Skype...
09:22:28 <judygichoya> anyway
09:25:23 *** kishoreyekkanti has joined #openmrs
09:32:30 <judygichoya> adding it now.. :)
09:40:54 <suranga> judygichoya, sorry about that... :(
09:41:14 <suranga> multi tasking is rather complicated :P
09:41:33 <judygichoya> no worries
09:41:42 <judygichoya> I am pushing the new changes...
09:41:51 <judygichoya> i assume i don't need a new pull request..
09:42:24 <judygichoya> have to say i am on my way to loving git...
09:43:44 <suranga> judygichoya, i think you need to make a pull request, because otherwise I cant pull it onto the OpenMR module
09:44:22 <suranga> judygichoya, if you do a push, it goes only upto your github repo, doesnt it ? (im a newbie too )
09:44:26 *** applecool has joined #openmrs
09:44:26 *** ChanServ sets mode: +v applecool
09:45:58 <judygichoya> suranga i think it updates my pull request
09:46:01 <judygichoya> just check...
09:46:21 <judygichoya> so that if thats not working i can close the pull request and create a new one.. :)
09:47:05 <suranga> judygichoya, umm.. is it on your git repo dashboard ?
09:49:51 <suranga> judygichoya, is it listed under commits in your github page.. I cant seem to find it :(
09:50:39 <judygichoya> making a new pull
09:50:43 <judygichoya> just a sec
09:52:13 *** dkayiwa has joined #openmrs
09:54:51 <suranga> and here's dkayiwa ! yayaya !!!!!!
09:55:02 <suranga> *yayayYYYY !!!
09:55:10 <dkayiwa> suranga: :)
09:55:33 *** pushkar has joined #openmrs
09:56:17 <suranga> judygichoya, yay ! I see it :)
09:58:56 <suranga> judygichoya, i think this is perfect ! :)
09:59:05 <judygichoya> thanks
09:59:23 <judygichoya> i was looking thru unclaimed tickets...
09:59:28 <judygichoya> is there is a similar one?
09:59:35 <judygichoya> (short learning curve)
09:59:41 <suranga> judygichoya, a similar one... hmmm....
10:00:37 <suranga> judygichoya, maybe you can work on the tickets Wyclif completed halfway ? they have only small TO DO's remaining. wyclif got moved to the bug fixing swimlane, so he could not finish them :(
10:04:33 <judygichoya> let me look around..
10:06:06 *** pushkar has quit IRC
10:06:29 *** pushkar has joined #openmrs
10:07:21 *** dawn_ has quit IRC
10:08:58 *** dawn_ has joined #openmrs
10:08:58 *** ChanServ sets mode: +v dawn_
10:10:39 <harshadura> hi rafa
10:10:52 <rafa> harshadura: hi
10:10:53 *** dawn_ has quit IRC
10:13:29 <harshadura> rafa, I hv problem related to privileges for Module, my module is Feedback Module, thr are two privileges of it, 1. Add Feedback and 2. Admin Feedback .. Normal users shud be able to add feedbacks other one is for Admin to Add+Del+Modify.
10:13:39 *** pushkar has quit IRC
10:14:04 *** pushkar has joined #openmrs
10:15:35 <harshadura> I created normal user and gave it provider role using Admin account, Provider has the privilge to add Feedback, But when I log into that normal user account occurs an error
10:15:42 <harshadura> this is the stack trace >
10:16:23 <harshadura> rafa : http://pastebin.com/bmVvKqwX
10:17:00 <harshadura> rafa, pls can u help me on this, thx
10:20:08 <rafa> harshadura: show me the jsp
10:20:27 <rafa> harshadura: or rather module/feedback/portlets/submitFeedbackController.portlet
10:20:44 <harshadura> ok rafa
10:22:01 <harshadura> rafa : jsp > http://pastebin.com/uEq4iHje
10:22:26 <harshadura> rafa, its a portlet fyi
10:27:28 *** maurya has joined #openmrs
10:29:26 <harshadura> rafa, here is the controller > http://pastebin.com/YyHLYVSz
10:30:39 <rafa> harshadura: sorry don't see anything obvious
10:30:56 <rafa> harshadura: I would start from making submiFeedbackConroller.portlet an empty file
10:31:07 <rafa> harshadura: and adding lines until you see the error
10:31:35 <harshadura> ok rafa, i will try that, thx
10:36:09 <harshadura> rafa, thx lot, it worked, I tried clearing the particular function and built again.
10:36:31 <rafa> harshadura: np
10:51:12 <harshadura> rafa, if I need to giv both privileges how to invoke that instead of this > @Authorized({ "Admin Feedback" })
10:52:02 *** judygichoya has quit IRC
10:53:28 <harshadura> rafa, I predict is it like this > @Authorized({ "Admin Feedback" , "Add Feedback" })
11:04:21 *** pushkar_ has joined #openmrs
11:06:31 *** pushkar has quit IRC
11:07:01 <harshadura> rafa, 1 min ?
11:07:25 <rafa> harshadura: yes?
11:07:39 <harshadura> rafa, I got the exact line which cause the error >
11:07:40 <harshadura> model.put("allusers", Context.getUserService().getAllUsers());
11:08:14 <rafa> harshadura: what is the error?
11:08:27 <harshadura> I think to execute this line need more privileges than Add Feedback or Admin Feedbacl
11:08:33 <rafa> harshadura: yes
11:08:55 <harshadura> rafa, is thr alternative way to get done that ?
11:09:07 <rafa> harshadura: yes, wait a sec
11:09:10 <harshadura> I mean using only Add Feedback or Admin Feedbacl
11:09:36 *** dawn_ has joined #openmrs
11:09:36 *** ChanServ sets mode: +v dawn_
11:09:57 <rafa> harshadura: before calling Context.getUserService().getAllUsers() call Context.addProxyPrivilege("here privilege")
11:10:16 <rafa> harshadura: after that you need to call Context.removeProxyPrivilege
11:10:23 <harshadura> ok thx lot rafa
11:16:13 <harshadura> rafa: still it gives an error, u meant to edit like this ?
11:16:14 <harshadura> Context.addProxyPrivilege("Add Feedback");
11:16:14 <harshadura> model.put("allusers", Context.getUserService().getAllUsers());
11:16:15 <harshadura> Context.removeProxyPrivilege("Add Feedback");
11:17:08 <rafa> harshadura: no you need a different priv
11:17:11 <rafa> harshadura: for viewing users
11:17:29 <harshadura> whoops, ok got it , thx rafa
11:18:59 *** applecoo_ has joined #openmrs
11:21:27 <harshadura> issue got fixed, thx rafa
11:21:37 *** applecool has quit IRC
11:21:43 <rafa> harshadura: np
11:26:24 *** kavuri has joined #openmrs
11:36:45 *** pushkar_ has quit IRC
11:37:20 *** bwolfe has joined #openmrs
11:37:20 *** ChanServ sets mode: +o bwolfe
11:42:06 *** bwolfe has quit IRC
11:42:22 *** james_regen has joined #openmrs
11:42:22 *** ChanServ sets mode: +v james_regen
11:44:41 *** bwolfe_ has joined #openmrs
11:44:41 *** ChanServ sets mode: +o bwolfe_
11:44:43 *** bwolfe_ is now known as bwolfe
11:53:46 *** kavuri has quit IRC
12:03:10 *** pushkar has joined #openmrs
12:03:16 <pushkar> hi bwolfe
12:03:57 *** djazayeri has joined #openmrs
12:03:57 *** ChanServ sets mode: +o djazayeri
12:05:49 <bwolfe> hi pushkar
12:06:25 <pushkar> bwolfe, where do you think we should save the templates ?
12:06:50 <bwolfe> pushkar, a db table, ideally
12:09:10 *** kavuri has joined #openmrs
12:10:41 <pushkar> bwolfe, are we providing the custom templates feature (like the user can upload his own set of templates )?
12:12:37 <rafa> suranga: HLQRY-32 done
12:13:04 <rafa> suranga: can't do more without the rest of templates
12:13:47 <rafa> suranga: any particular ticket you want me to claim now?
12:13:57 <bwolfe> pushkar, yes, if you can get it done! :-)
12:14:44 *** robbyoconnor has quit IRC
12:15:29 <pushkar> bwolfe I was thinking is there any way we can avoid tables?
12:16:04 <bwolfe> pushkar, the only other option is in the "application data dir"...but the db is better. :-)
12:16:10 <bwolfe> pushkar, why do you want to avoid tables?
12:17:52 <pushkar> bwolfe, I feel maintaining the images in filesystem will be lot easier than maintaining them in table
12:18:59 <bwolfe> pushkar, maybe
12:19:17 <pushkar> bwolfe, (we can avoid the servicelayer too if tables are not required)
12:19:47 <bwolfe> but in the db its easier to migrate between servers, backup, etc
12:20:39 *** pushkar_ has joined #openmrs
12:21:20 <bwolfe> pushkar_, if you want to do filesystem, use OpenmrsUtil.getDirInApplicationDataDir("foldername") method
12:22:01 <djazayeri> pushkar_, bwolfe: we absolutely *should* store these in the database.
12:22:47 <bwolfe> djazayeri, these are the "default" images to store as the bg on potential drawings
12:23:02 <bwolfe> djazayeri, are you wanting them in the db just for sync'ing? (that was my first reasoning too)
12:23:42 *** pushkar has quit IRC
12:23:56 <djazayeri> pushkar_, bwolfe: oh, sorry, I thought you were talking about groovy templates for hl7. never mind!
12:24:16 <pushkar_> djazayeri, okay
12:24:34 <djazayeri> sorry
12:27:04 <pushkar_> bwolfe, but if we use the OpenmrsUtil.getDirInApplicationDataDir("foldername") how can we distribute the default templates ?
12:28:48 <pushkar_> bwolfe, my idea is keep them in module resources as soon as the module start move those default templates to OpenmrsUtil.getDirInApplicationDataDir("foldername")
12:30:09 <pushkar_> bwolfe, the custom templates can be directly saved in the OpenmrsUtil.getDirInApplicationDataDir("foldername")
12:32:14 <bwolfe> pushkar_, yes, you would put in your resources folder and copy them over if they don't exist in the appdir
12:33:01 <bwolfe> pushkar_, you should add an admin page that lets them manage the files in that folder. (as a second step, first get it working by just putting a file in your appdir/drawing/backgroundImages folder
12:33:29 *** wyclif has quit IRC
12:33:37 *** maurya has quit IRC
12:34:04 <pushkar_> bwolfe, Okay :-) and I finished the undo redo part
12:34:56 <bwolfe> pushkar++
12:34:58 <bwolfe> :-D
12:35:06 <bwolfe> pushkar++
12:35:14 <bwolfe> pushkar_, so now you can work on the backgroundImages stuff?
12:35:39 <pushkar_> bwolfe, Thank you and Yes !! :-D
12:43:18 <kavuri> bwolfe: I am trying to create a person object using REST and want to add special attributes (like email, phone). The format given is like value,attributeTypes. But I am unable to figure out how to provide these json attributes
12:43:23 <kavuri> Any examples on how to provide additional attributes?
12:43:54 <bwolfe> kavuri, the attributeTypes is just a uuid or name of the PersonAttributeType
12:45:08 <kavuri> bwolfe: I tried like: ..."attributes":[{"value":"abc","attributeTypes":{"uuid":"sdfl0k4..."}}]
12:45:16 <kavuri> bwolfe: but got an error
12:46:48 *** rafa has quit IRC
12:47:32 <bwolfe> kavuri, change to: "attributes":[{"value":"abc","attributeType":"sdfl0k4..."}]
12:47:38 <bwolfe> attributeType is singular
12:47:43 <kavuri> bwolfe: got disconnected temporarily..if you have responded, can you please repost?
12:47:43 <bwolfe> and the value for it is just the string uuid
12:48:00 <bwolfe> kavuri, change to: "attributes":[{"value":"abc","attributeType":"sdfl0k4..."}]
12:48:03 <bwolfe> attributeType is singular
12:48:07 <bwolfe> and the value for it is just the string uuid
12:49:03 <kavuri> bwolfe: thanks, will try
12:49:22 *** rafa has joined #openmrs
12:49:22 *** ChanServ sets mode: +v rafa
12:49:59 *** rafa has quit IRC
12:54:31 *** djazayeri has quit IRC
12:58:52 <kavuri> bwolfe: thanks. This works
12:59:20 <bwolfe> kavuri, can you add that as an example on the wiki somewhere? do we have a good page for "example" calls yet?
13:00:28 <kavuri> bwolfe: I can. Right now I see that all the information about webservices REST module is scattered. I can create an examples page, if none exists
13:01:24 <bwolfe> kavuri, hmm, ok
13:01:44 <bwolfe> kavuri, if you want to suggest a reorganization, consolidation, or removal of some pages please let me know!
13:01:53 <bwolfe> (or you can just add a comment on a page about it)
13:02:03 <kavuri> bwolfe: yeah, I can add a comment
13:02:05 <kavuri> for now
13:10:22 <suranga> dkayiwa, heloooo :)
13:10:41 <dkayiwa> suranga: hi
13:11:13 <suranga> dkayiwa, I was windering, are you working on hlry-8, or on the ticket comments for the previous one ?
13:12:07 *** pushkar_ has quit IRC
13:12:09 <dkayiwa> suranga: which previous one? :)
13:12:34 <suranga> dkayiwa, ;https://github.com/OpenMRS/openmrs-module-hl7query/pull/25
13:12:40 <OpenMRSBot> <http://ln-s.net/$Z$2> (at github.com)
13:14:43 <dkayiwa> suranga: am working on HLQRY-8 :)
13:15:06 <kavuri> bwolfe: which wiki does openmrs use? Want to post code block without formatting
13:15:55 <bwolfe> kavuri, confluence
13:16:15 <suranga> dkayiwa, once that ticket is place, I think we can finally start the test :)
13:16:17 *** djazayeri has joined #openmrs
13:16:17 *** ChanServ sets mode: +o djazayeri
13:16:18 <bwolfe> use the {code} yourcodehere {code} syntax (if using the non-wysiwyg editor)
13:16:24 <bwolfe> kavuri ^^
13:16:33 <dkayiwa> suranga: which ticket? HLQRY-8 ?
13:16:47 <suranga> dkayiwa, thats right
13:16:52 <dkayiwa> suranga: ok
13:17:06 <suranga> dkayiwa, since rafa wrote the parent ORUR01 template (under review :)
13:17:15 <dkayiwa> suranga: ok
13:21:14 <kavuri> bwolfe: posted. Also API definition is not provide for resource "user". Is it provided somewhere? I am able to retrieve the resource /user
13:21:24 *** wyclif has joined #openmrs
13:21:51 <suranga> hello bwolfe ! :)
13:22:33 <bwolfe> hi suranga
13:22:40 <bwolfe> kavuri, not posted? which page are you looking at?
13:23:02 <kavuri> bwolfe: https://wiki.openmrs.org/display/docs/REST+Web+Service+Resources
13:23:03 <OpenMRSBot> <http://ln-s.net/8z-a> (at wiki.openmrs.org)
13:23:20 <suranga> bwolfe, things are going ok, i guess. at the moment, there are a number of tickets awaiting amendments so that they can be closed
13:23:47 <suranga> bwolfe, we also got : https://github.com/OpenMRS/openmrs-module-hl7query/pull/23 from Judy. this is a patch for two tickets she was working on...
13:23:51 <OpenMRSBot> <http://ln-s.net/$Z$A> (at github.com)
13:24:01 <bwolfe> kavuri, very strange how that got dropped there. that page is mostly autogenerated by the app and then copied over. looks like rafal did it last. perhaps it stopped at "R" for some reason? :-(
13:24:26 <bwolfe> suranga, ok.
13:25:03 <suranga> bwolfe, i have a Q on that patch though. let me know when you are free :)
13:25:58 <suranga> dkayiwa, when Rafa was working on his ORUR01 template, he came across an errror on your pv1 segment. there seemed to be an extra double quote at the end of your changeset...
13:26:30 <dkayiwa> suranga: i saw, removed and committed it yesterday :)
13:27:24 <suranga> dkayiwa, i think this is also part of :https://github.com/OpenMRS/openmrs-module-hl7query/pull/25 ... its in the liquibase file there :)
13:27:25 <OpenMRSBot> <http://ln-s.net/$Z$2> (at github.com)
13:27:59 <bwolfe> suranga, if you have a comment on the patch, add it there. if you have another question about it, you can ask me whenever. :-)
13:28:11 <dkayiwa> suranga: not sure what you mean by that :)
13:28:50 <suranga> dkayiwa, in https://github.com/OpenMRS/openmrs-module-hl7query/pull/25 the liquibase.xml line number 99
13:28:51 <OpenMRSBot> <http://ln-s.net/$Z$2> (at github.com)
13:29:03 <suranga> dkayiwa, this is the double quote we're talking about, isnt it ? :)
13:29:26 <dkayiwa> suranga: i made a commit with them removed. maybe i did commit using another branch :)
13:29:34 <kavuri> bwolfe: any way the page could be generated again?
13:29:51 <dkayiwa> suranga: you know i have like 3 times committed tickets in other tickets branches :)
13:30:12 <dkayiwa> suranga: not yet used to this multi step git beast :)
13:30:36 <suranga> dkayiwa, ne neither, im afraid :)
13:30:49 <bwolfe> dkayiwa, switching between branches is very easy...
13:31:07 <dkayiwa> bwolfe: correct, i just forget :)
13:31:09 <bwolfe> dkayiwa, it should (and probalby will) become a habit as you look at different things to do a "git checkout" to the right branch
13:31:34 <dkayiwa> bwolfe: thats what i know am supposed to do. but of late, was forgetting 50% of the time :)
13:32:13 <dkayiwa> bwolfe: you know coming fresh from the svn worlds :)
13:32:28 <bwolfe> yes yes yes
13:32:51 <bwolfe> dkayiwa, it would be nice if egit plugin showed which files were modified and not committed and which ones weren't pushed yet
13:33:06 <suranga> bwolfe, ^^ exactly !
13:33:24 <dkayiwa> bwolfe: it shows the non committed ones
13:33:34 <suranga> bwolfe, i wonder if you saw the comments to : https://github.com/OpenMRS/openmrs-module-hl7query/pull/23
13:33:35 <OpenMRSBot> <http://ln-s.net/$Z$A> (at github.com)
13:34:24 *** kishoreyekkanti has quit IRC
13:35:42 <bwolfe> suranga, that pull request cannot be automatically merged because there have been changes to those files since she committed
13:36:18 <bwolfe> so if you want to cleanly merge, you ask judy to update from upstream to her branch, make sure things still work, then commit/push back to her branch
13:36:35 <suranga> bwolfe, :( she commented them just 2 hours back, i think.
13:36:45 <suranga> bwolfe, is there an alternative to that ? :)
13:36:57 <suranga> bwolfe, which we can do from our end ?
13:38:14 <bwolfe> suranga, looks like she last merged from upstream (openmrs/openmrs-module-hl7query) 5 hours ago
13:38:27 <bwolfe> suranga, however, you merged pull req #22 from rafa 4 hours ago
13:39:11 <bwolfe> so rafa's touched some of the files that judy is touching. therefore, judy must pull down rafa's changes to her branch, make sure htey work with her code, and then commit+push them back to github
13:39:24 <bwolfe> THEN you will see an automatic merge be possible
13:39:29 <suranga> bwolfe, , my bad. I'll ask her to do that then. hope it wont annoy her
13:42:04 *** dkayiwa has quit IRC
13:43:16 *** dkayiwa has joined #openmrs
13:57:09 *** jordank has joined #openmrs
13:59:15 <suranga> dkayiwa, hi, just saw your pull request
13:59:32 <suranga> dkayiwa, does ticket-8 include changes to the liquibase file ?
13:59:56 <suranga> there seem to be several mentioned in that pull...
14:00:11 <dkayiwa> suranga: that is a different ticket :)
14:05:01 <suranga> dkayiwa, hmm...if I merge this, everything (those changes included) will go in
14:05:21 <suranga> dkayiwa, is there a wat to select only the classes u want to add to the commit
14:05:22 *** djazayeri has quit IRC
14:05:23 *** djazayeri1 has joined #openmrs
14:05:40 <suranga> dkayiwa, I seem to have read something about git add classname.java etc.
14:06:05 <dkayiwa> suranga: i know nothing about git :)
14:06:18 <suranga> dkayiwa, me too :(
14:07:28 <suranga> dkayiwa, if you were to address the comments on PID and PV1 and make a fresh pull, maybe i could do one huge merge for those ? :)
14:07:48 <suranga> (im sure bwolfe wont like that when he hears about it :)
14:08:09 <dkayiwa> suranga: i thought they were different branches
14:09:02 <suranga> dkayiwa, umm.. different branches ? i mean everything goes into our github repo...
14:09:27 <dkayiwa> suranga: now am lost :)
14:09:55 <suranga> shall we hunt down bwolfe ? since rafa is missing ? :(
14:10:02 <suranga> dkayiwa, me a noob too :(
14:10:50 *** rfriedman has joined #openmrs
14:11:08 <bwolfe> suranga, you cannot create a pull request across branches
14:11:27 *** lh has joined #openmrs
14:11:27 *** lh has joined #openmrs
14:11:30 <bwolfe> suranga, dev call time, will respond slowly
14:11:42 <suranga> bwolfe, oh, I see
14:11:51 *** djazayeri1 has quit IRC
14:12:28 <suranga> bwolfe, our basic problem is that Daniel's pull request contains all the changes he made (includeing those for other pending tickets). If i merge it, those changes get added too
14:12:48 <bwolfe> suranga, if dkayiwa has committed wrong things to the wrong branch, he just needs to "undo" those by reverting and committing. the pull request will then be cleaned up for that specific task
14:12:49 <suranga> bwolfe, is there a way for us to add java classes to commit by name ? :)
14:15:04 <suranga> hmm.. bwolfe im pretty sure we're using just one branch (github)
14:16:57 *** mccallumg has joined #openmrs
14:16:57 *** ChanServ sets mode: +v mccallumg
14:21:58 *** pushkar_ has joined #openmrs
14:27:07 <suranga> dkayiwa, hi
14:27:13 <dkayiwa> suranga: hi
14:27:31 *** kishoreyekkanti has joined #openmrs
14:27:47 <suranga> dkayiwa, if I put the request with all the changes, could you update yor version to it, and than add the other fixes to that ? :)
14:27:59 <suranga> *if I pull
14:28:03 <dkayiwa> suranga: sure :)
14:28:59 <suranga> dkayiwa, so my pull will also include the OBR-ENc changes... here goes ---
14:29:09 <dkayiwa> suranga: ok
14:29:48 *** applecoo_ is now known as applecool
14:29:49 *** ChanServ sets mode: +v applecool
14:30:39 <suranga> dkayiwa, done ... :)
14:30:46 <dkayiwa> suranga: ok
14:33:30 <dkayiwa> suranga: so do i make new pull requests or commit to existing ones?
14:34:16 <suranga> dkayiwa, update your copy to the latest on github, and then address the changes on that code..
14:34:31 <dkayiwa> suranga: i did that
14:34:47 <suranga> dkayiwa, just now, after my pull request ?
14:34:55 <dkayiwa> suranga: yes
14:35:07 <suranga> dkayiwa, great :)
14:38:59 *** judygichoya has joined #openmrs
14:40:23 *** lh has quit IRC
14:40:48 *** lh has joined #openmrs
14:40:48 *** lh has joined #openmrs
14:45:07 *** kavuri has quit IRC
14:48:53 *** dawn_ has quit IRC
14:52:17 <judygichoya> suranga
14:52:23 <judygichoya> made the changes
14:52:26 <judygichoya> and a new commit
14:52:27 <judygichoya> :)
14:52:33 <judygichoya> and pull request
14:52:38 <suranga> how judygichoya
14:52:43 <suranga> judygichoya, I just saw it..
14:53:10 <suranga> judygichoya, mm.. it stilll has that problem, im afraid...
14:53:20 <judygichoya> which problem..
14:53:21 <suranga> did you see the pull request here ? :https://github.com/OpenMRS/openmrs-module-hl7query/pull/27
14:53:24 <judygichoya> I merged
14:53:27 <OpenMRSBot> <http://ln-s.net/$Z-F> (at github.com)
14:53:44 <suranga> im not sure why this happens... you have the very latest code in your setup ?
14:54:16 <suranga> judygichoya, for all the classes you are editing ?
14:54:33 <judygichoya> yes
14:54:39 <judygichoya> whats the problem now?
14:54:42 <judygichoya> The conflict?
14:57:52 *** kavuri has joined #openmrs
14:58:36 <suranga> judygichoya, im afraid so.. Iwas hoping maybe rafa or bwolfe could advise on that, but they're in the dev meeting :(
14:58:38 *** jriley has joined #openmrs
14:58:58 *** kishoreyekkanti has quit IRC
14:59:12 *** dkayiwa has quit IRC
14:59:26 *** dkayiwa has joined #openmrs
15:05:42 <dkayiwa> suranga: did you merge the template functions that bwolfe did?
15:05:56 <suranga> dkayiwa, let me check that...
15:06:32 <bwolfe> I think he did
15:07:39 <dkayiwa> bwolfe: is it the one supposed to have callTemplate() ?
15:07:51 <dkayiwa> bwolfe: HL7TemplateFunctions
15:08:01 <dkayiwa> i do not see that method
15:08:16 <dkayiwa> even after git pull upstream master
15:12:06 *** Jibesh has joined #openmrs
15:14:46 *** kavuri has quit IRC
15:17:33 <mccallumg> jordank: no questions on the call? Jon went quite deep, didn't he?
15:18:03 <jordank> mccallumg: yes!
15:18:48 <jordank> mccallumg: I was kind of curious about the subsets he was talking about… but that didn't seem important
15:19:03 <mccallumg> jordank: it is very important
15:19:16 *** suranga has quit IRC
15:19:18 <jordank> mccallumg: compared to metadata sharing I mean
15:19:42 <mccallumg> jordank: if subsets were better supported then it would make metadata sharing easier
15:23:26 <jordank> mccallumg: true. I could have asked if there are issues with supporting subsets. It didn't seem like it though.
15:24:32 <mccallumg> mccallumg: yeah there are. I think that is why the "all or nothing" adoption discussion was happening towards the end of the call.
15:26:07 <jordank> mccallumg: right - issues with mappings? That was kind of confusing too. I thought MDS already handled that
15:27:04 <mccallumg> jordank: I don't know the degree to which MDS supports all the mappings
15:27:56 <jordank> mccallumg: oh okay
15:29:21 <jordank> mccallumg: so possibly, better support for subsets would look like better support for mappings?
15:33:38 <mccallumg> jordank: those aren't necessarily linked
15:34:04 <mccallumg> jordank: I think subsets are a higher priority for now
15:35:52 *** mccallumg has quit IRC
15:37:07 *** harshadura has quit IRC
15:39:34 <dkayiwa> bwolfe: is the method callTemplate supposed to be in HL7TemplateFunctions ?
15:39:45 <bwolfe> yes
15:40:15 <dkayiwa> bwolfe: i do not seem to have it. so now am trying to locate it in your commits
15:41:52 *** jriley has quit IRC
15:43:39 *** mccallumg has joined #openmrs
15:43:39 *** ChanServ sets mode: +v mccallumg
15:44:14 <dkayiwa> bwolfe: am trying to locate it here but in vain: https://github.com/OpenMRS/openmrs-module-hl7query/pull/16
15:44:15 <OpenMRSBot> <http://ln-s.net/$Y$H> (at github.com)
15:44:22 *** judygichoya has left #openmrs
15:44:30 <dkayiwa> bwolfe: am i just looking in a wrong place?
16:03:26 *** mccallumg has quit IRC
16:07:41 *** Jibesh has left #openmrs
16:15:15 *** mccallumg has joined #openmrs
16:15:15 *** ChanServ sets mode: +v mccallumg
16:24:21 *** pushkar__ has joined #openmrs
16:24:25 <jordank> mccallumg: are you familiar with this error I'm getting on a query: "No data type for node: org.hibernate.hql.ast.tree.IdentNode"
16:24:42 <jordank> I think it's hql
16:25:03 <mccallumg> jordank: haven't seen that before. maybe wyclif has?
16:26:37 <jordank> it will work to get the obsCount, but when I call it again to get a list of obsIds to update ^that happens
16:26:41 *** lh has quit IRC
16:27:11 *** lh has joined #openmrs
16:27:47 *** pushkar_ has quit IRC
16:28:15 <jordank> actually it doesn't work for obsCount
16:33:58 *** mvorobey has joined #openmrs
16:34:04 <mvorobey> hi all
16:34:28 <applecool> hi mvorobey
16:34:35 <applecool> how is it going :)
16:37:40 <mvorobey> applecool, good, good, just came back to my house from beach, it's really very hot it Ukraine this days :) how about you ?
16:38:20 <applecool> great :) i got to know now that you are from Ukraine :)
16:38:35 <applecool> hmm! today we have a festival in INDIA ;)
16:38:54 <applecool> just started off with the dev call today ;)
16:39:48 *** harshadura has joined #openmrs
16:40:39 <mvorobey> applecool, that's great! What kind of festival do you have ?
16:41:21 <applecool> ah to describe that i guess i need to tell you the entire history :P you will raise many questions :D
16:42:09 <applecool> mvorobey: it would be easy if i provide you a link :)
16:42:20 <applecool> here it is! on wikipedia http://en.wikipedia.org/wiki/Raksha_Bandhan
16:42:50 <mvorobey> applecool, ah, np, that is awesome, festivals are very exciting events, I believe :)
16:43:11 <applecool> hmm! yes we get a holiday to school :D :P
16:43:29 <applecool> and get to meet our family friends and relatives ;)
16:45:54 <applecool> mvorobey: your module got released right! impressive :) will try it out soon :)
16:46:03 <applecool> mvorobey: congo :)
16:46:42 <mvorobey> applecool, you know, it's very interesting to read about that festival, it has some common things with some traditions in Ukraine, am talking about Rakhi. We are presenting very similar things to friends as sign of friendship.
16:47:22 <applecool> oh! :) Thats Friendship day i guess :D
16:47:56 <applecool> even that is followed here! it would be on the first sunday of August! so its on Aug 5th :P
16:47:58 *** kreddy has joined #openmrs
16:47:59 <mvorobey> applecool, :) thanks, will appreciate your feedback about module! Take into account that you need to use maintance version of OpenMRS
16:48:13 <applecool> oh!
16:48:16 <applecool> yea sure
16:48:20 <applecool> :)
16:50:07 <mvorobey> applecool, thanks for this chat, am really glad to meet you!
16:50:19 <applecool> same here :) mvorobey
16:50:31 <mvorobey> :D
16:55:10 <jordank> mccallumg: hql uses objects instead of columns, right? I think that's why it doesn't like my 'select obs_id'… Do you know what the alternative would be if obs_id is an int?
16:56:11 <mccallumg> jordank: (never used hsql so this is a wag) - you could try using object dot notation. e.g. obs.obs_id
16:57:01 *** goutham has joined #openmrs
16:57:14 <mccallumg> jordank: e.g. select cat.mate from Cat cat (http://docs.jboss.org/hibernate/orm/3.3/reference/en/html/queryhql.html#queryhql-select)
16:57:17 <OpenMRSBot> <http://ln-s.net/$ZBV> (at docs.jboss.org)
16:59:10 <jordank> mccallumg: ooh okay. would that translate to from Obs obs?
16:59:29 <mccallumg> jordank: I think so
16:59:48 <jordank> mccallumg: ok. thank you!
17:13:15 *** lh has quit IRC
17:13:30 *** lh has joined #openmrs
17:13:30 *** lh has joined #openmrs
17:18:53 *** kavuri has joined #openmrs
17:23:46 *** goutham has quit IRC
17:25:27 *** dkayiwa has quit IRC
17:25:54 *** dkayiwa has joined #openmrs
17:38:14 <mvorobey> dkayiwa, hi
17:42:26 <dkayiwa> mvorobey: hi
17:42:38 <mvorobey> dkayiwa, how it's going ?
17:42:46 <dkayiwa> mvorobey: not bad
17:42:52 <dkayiwa> mvorobey: and u?
17:43:57 <mvorobey> dkayiwa, am good, preparing to be on bug fixing lane next week, so just wanted to talk to you about it. Do you have couple of minutes ?
17:44:16 <dkayiwa> mvorobey: oh yes i do
17:44:46 <mvorobey> dkayiwa, From what I know you have participated in it couple of times, right ?
17:44:48 <dkayiwa> mvorobey: allow me to also thank you for the great work you are doing!!!! :)
17:44:58 <dkayiwa> mvorobey: yes
17:46:06 <mvorobey> dkayiwa, can you advice to me as newbie how to do things in best way being on that line ?
17:46:58 <dkayiwa> mvorobey: have you read this? https://wiki.openmrs.org/display/RES/Bug+Fixing+Swim+Lane
17:48:06 <mvorobey> dkayiwa, more times than I've read playboy I found in a dude's duffel :)
17:48:35 <dkayiwa> mvorobey: hahahaha. then you are ready to start. :)
17:49:34 *** pushkar__ has quit IRC
17:50:11 <dkayiwa> mvorobey: some thing else that i do not see mentioned there is , if a ticket is of lowcomplexity/intro, but critical (high priority) you should handle it too :)
17:50:49 <dkayiwa> mvorobey: for instance a blocker ticket, even if it may be intro, should be done :)
17:51:46 <mvorobey> dkayiwa, YFrom what I remember, there is already info about that :)
17:52:13 <dkayiwa> mvorobey: may be i did not read well. i only saw avoiding intro tickets :)
17:52:13 <mvorobey> dkayiwa, as I have noticed, most of blocking issues are related to possible memory leaks fixing, can you point me to the best practice of fiting against memory leaks with OpenMRS ?
17:52:44 <mvorobey> dkayiwa, ah, yes, did not really get what you meant, sorry :)
17:52:46 <dkayiwa> mvorobey: those are some of the most complicated tickets.
17:53:39 <mvorobey> fiting = fighting
17:53:57 <dkayiwa> mvorobey: you could use tools like http://www.yourkit.com/
17:54:06 <dkayiwa> mvorobey: for such memory issue tickets
17:54:27 <mvorobey> dkayiwa, as far as I know it is not free, right ?
17:54:33 <dkayiwa> mvorobey: but ofcourse complicated does not mean you cannot do it :)
17:55:01 <dkayiwa> mvorobey: i think you can get a free open source licence (or something like that)
17:55:59 <dkayiwa> mvorobey: but when dealing with such tickets, do not spend too much time on them
17:56:13 <dkayiwa> mvorobey: for instance, don't spend the whole day on just such a ticket :)
17:56:21 <mvorobey> dkayiwa, I will to my best an the best of someone better to deal those memory leaks
17:56:45 <mvorobey> dkayiwa, that is a good advice, will follow it
17:57:01 <dkayiwa> mvorobey: when you try and see not success, you can just put comments on the ticket about how far you have gone and then leave it for someone else to start form there :)
17:57:40 <mvorobey> dkayiwa, just noticed it from ticket comments :)
17:57:48 <dkayiwa> mvorobey: :)
17:58:43 <mvorobey> dkayiwa, what about open bugs ? was XForms moved to GitHub completely ?
17:59:02 <dkayiwa> mvorobey: yes it did
17:59:23 <mvorobey> dkayiwa, cool
17:59:31 <dkayiwa> mvorobey: also if you feel the ticket is not curated well enough for you to make sense out of it, do not fear to ask immediately :)
17:59:34 <mvorobey> dkayiwa, that's great
17:59:48 *** kavuri has quit IRC
18:00:46 <dkayiwa> mvorobey: during the bug fixing sprint, you can also apply some patches if you can find any you feel confident about
18:06:14 <mvorobey> dkayiwa, ok, if a patch was created off SVN trunk and now AFAIR we are moved to git, how to be in this case ?
18:08:52 <dkayiwa> mvorobey: haahahahah. i need to find out about that :)
18:09:58 *** jkeiper_ has joined #openmrs
18:10:28 <mvorobey> dkayiwa, :) maybe bwolfe can help us with this ?
18:11:02 <jkeiper_> is there a maven plugin for pushing a module to the nexus repo, like from a tag?
18:11:12 *** applecool has quit IRC
18:11:26 <jkeiper_> Household Module 1.0.1 was never published in nexus ... but I'd rather use a plugin than do it by hand
18:13:55 *** jordank has quit IRC
18:14:19 *** djazayeri has joined #openmrs
18:14:19 *** ChanServ sets mode: +o djazayeri
18:15:48 <mvorobey> dkayiwa, anyway, thanks for helping me, am rely on your support during next week!
18:16:13 <dkayiwa> mvorobey: oh sure :D
18:16:22 <mvorobey> djazayeri, hi
18:16:33 <mvorobey> dkayiwa, thanks!
18:16:33 <djazayeri> hi mvorobey, on a call
18:16:57 <mvorobey> djazayeri, ah, sorry :) will talk to you later.
18:16:59 <dkayiwa> mvorobey: thanks too for all the good work you are doing!!!! :D
18:18:29 *** jordank has joined #openmrs
18:19:15 <mvorobey> dkayiwa, do not mention it :) it's a big honor for me to work with our community and am happy to meet guys as you !
18:20:05 <dkayiwa> mvorobey: we are also very happy to have very active and bright young blood like you!!! :D
18:20:51 <mvorobey> dkayiwa, :D
18:22:16 <mvorobey> dkayiwa, thanks for this conversation, won't bother you because I know that you've lot of work beside chatting with me )
18:22:50 <dkayiwa> mvorobey: hahahah. not too much to chat with you. :)
18:26:47 *** maurya has joined #openmrs
18:36:19 *** james_regen has left #openmrs
18:57:07 *** lh has quit IRC
18:57:41 *** lh has joined #openmrs
18:57:41 *** lh has joined #openmrs
18:59:58 *** djazayeri has quit IRC
19:00:23 *** lakkarau has joined #openmrs
19:01:22 *** djazayeri has joined #openmrs
19:01:22 *** ChanServ sets mode: +o djazayeri
19:20:20 *** maurya has quit IRC
19:25:09 *** lh has quit IRC
19:25:27 *** lh has joined #openmrs
19:25:27 *** lh has joined #openmrs
19:26:10 *** lh has quit IRC
19:26:24 *** lh has joined #openmrs
19:26:24 *** lh has joined #openmrs
19:31:51 *** cpower has joined #openmrs
19:32:07 <cpower> hello, sorry I'm late, has the scrum happened?
19:33:13 <mvorobey> cpower, hi, no it hasn't yet
19:33:23 <cpower> Ok then, let's fix that!
19:33:33 <cpower> As best we can
19:33:38 <cpower> !scrumon cpower
19:33:38 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
19:34:22 <cpower> Order: wyclif, mvorobey, lakkarau, jkeiper, dkayiwa, djazayeri, and bwolfe
19:36:04 <djazayeri> wyclif: you there?
19:36:09 <cpower> I'm going to take it Wyclif isn't there
19:36:17 <wyclif> Wednesday:
19:36:18 <wyclif> Ticket design/discussion with Jer/ben via comments
19:36:18 <wyclif> design call
19:36:18 <wyclif> FORM-44 - FormEntry XSLTs should not be duplicated
19:36:18 <wyclif> error logging code review
19:36:18 <wyclif> Thursday:
19:36:20 <wyclif> dev call
19:36:21 *** lh has quit IRC
19:36:24 <wyclif> Revisit FORM-121 - Modify code and admin pages to support form resources
19:36:26 <wyclif> pick another bug ticket
19:36:27 <cpower> spoke too soon
19:36:28 <wyclif> Blockers: What needs to be done for FORM-121 is still unclear to me
19:36:38 <wyclif> sorry for the delay
19:36:40 <cpower> mvorobey
19:36:42 <mvorobey> * Released CSTM 1.3 - https://wiki.openmrs.org/x/BBEJAg
19:36:42 <mvorobey> * Prepared CSTM code-base for v1.4
19:36:42 <mvorobey> * Attended todays Devs Call
19:36:42 <mvorobey> * Doing preparation in order to take a part in Bug Fixing Swim Lane
19:36:42 <mvorobey> No blockers
19:36:52 <cpower> lakkarau
19:36:55 <lakkarau> wednesday:
19:36:55 <lakkarau> Attached patches for the TRUNK-3491 ans TRUNK-3589.
19:36:55 <lakkarau>
19:36:56 <lakkarau> thursday:
19:36:56 <lakkarau> Working on HLQRY-26
19:36:56 <lakkarau> Blocker getting security error from Github "for security reasons,framing is not allowed".
19:37:14 <cpower> jkeiper..
19:37:31 <jkeiper_> AMPATH project management blues (in D)
19:37:50 <jkeiper_> blockers: none
19:37:58 <dkayiwa> Committed: Create a groovy template to create the PID segment of an ORUR01 message - HLQRY-6
19:37:58 <dkayiwa> Committed remaining work on: Create a controller class to get encounters in orur01 hl7 format - HLQRY-8
19:37:59 <dkayiwa> Committed some responses to review comments on previous tickets
19:37:59 <dkayiwa> Dev Call
19:37:59 <dkayiwa> Now working on remaining work for: Add ability to select orur01 template to the Settings admin page - HLQRY-25
19:37:59 <dkayiwa> No Blockers
19:38:22 <djazayeri> PIH stuff, OpenMRS calls
19:38:23 <djazayeri> no blockers
19:38:39 <djazayeri> created an MDS bug ticket. :-)
19:38:49 <cpower> and bwolfe
19:39:06 *** lh has joined #openmrs
19:39:08 <dkayiwa> must also be calls, calls, and calls for bwolfe :)
19:39:58 <cpower> Ok anyone else?
19:40:19 <dkayiwa> cpower: you :)
19:40:50 <cpower> do you want just my openmrs stuff or everything....lol
19:41:03 <dkayiwa> cpower: anything :)
19:41:41 <cpower> Yesterday: Reviewed resumes for developers
19:42:38 <cpower> Worked on reaching out to Implementers and developers who were looking to have a sprint put together in the September/October time frame (Anyone have anything?)
19:42:55 <cpower> Updated status reports
19:43:01 <cpower> PM Call
19:43:06 <cpower> Scrum
19:43:11 <cpower> Today:
19:43:52 <cpower> Worked on trying to come up with a way to explain the voting process better to the community and how to get the community more involved on what we do next
19:44:21 <cpower> Did research on the project processes other Open Source groups use to get things done.
19:45:49 <cpower> Blockers: I need sprint topics, sprint leaders, entry level community members who would like to be a part of a bug fixing swimlane or betterly named support lane.
19:46:33 *** lh has quit IRC
19:46:35 <cpower> now back to everyone else.
19:46:38 <cpower> Blockers:
19:47:35 <cpower> Git hub security for lakkarau, Wyclfi needs help with Form-121
19:47:52 <cpower> Discussion points: none
19:47:56 <cpower> !scrumoff
19:47:56 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
19:57:34 <dkayiwa> !ticket Form-121
19:57:35 <OpenMRSBot> dkayiwa: [#FORM-121] Modify code and admin pages to support form resources - OpenMRS JIRA - https://tickets.openmrs.org/browse/Form-121
19:59:26 <dkayiwa> lakkarau: when do you get that error? while committing? pushing, pulling? or when?
20:01:03 <lakkarau> dkayiwa,when iam trying to log into github site
20:01:27 <dkayiwa> lakkarau: have you ever successfully logged there before?
20:01:54 *** deadpool_ is now known as deadpool
20:02:17 <lakkarau> dkayiwa:yes,i have also created a branch HLQRY-30
20:02:49 <dkayiwa> lakkarau: so you just started getting problems doing what you successfully did before? :)
20:04:09 <lakkarau> dkayiwa:every thing was going fine ,then for some reson i had to delete the branch and wanted to check if it is deleted form git.....blocker
20:04:22 <dkayiwa> lakkarau: ok
20:04:56 *** goutham has joined #openmrs
20:06:11 <dkayiwa> lakkarau: being a git newbie too, i think we shall wait for the git gurus to help :)
20:06:58 <lakkarau> dkayiwa:ok
20:07:30 <dkayiwa> wyclif: did you do something like Form-121 for xforms?
20:08:45 <wyclif> dkayiwa, yeah but i used reflection in xforms since it it doesnt depend on 1.9 and i didnt migrate the existing xslts, we should probably do dso
20:09:16 <dkayiwa> wyclif: ok
20:09:19 <wyclif> dkayiwa, though i dont recall if i return the default in case there is none
20:09:28 <dkayiwa> wyclif: ok
20:09:30 <wyclif> dkayiwa, you can review the code see XRM-34
20:09:37 <dkayiwa> wyclif: ok
20:09:45 <dkayiwa> wyclif: can we do the same for Form-121?
20:10:12 <wyclif> sure
20:10:25 <wyclif> do you want to upgrade?
20:10:36 <dkayiwa> wyclif: upgrade what?
20:11:21 <wyclif> dkayiwa, to require 1.9
20:11:31 <dkayiwa> wyclif: no way :)
20:11:54 <dkayiwa> wyclif: there are users still on 1.6 and can't let them down :)
20:12:02 <jkeiper_> don't you have to require 1.9 to use form resources?
20:12:14 <wyclif> then it will still use the reflection but we can copy the migation changeset to xfrms
20:12:14 <jkeiper_> s/require/depend on
20:13:16 <wyclif> and we can add test method to xfrms
20:13:21 <dkayiwa> jkeiper_: looks like wyclif used reflection in order not to force every one to use 1.9
20:13:42 <jkeiper_> dkayiwa, how about the rafal method?
20:13:43 <jkeiper_> ;-)
20:13:50 <wyclif> dkayiwa, i made some updates to that ticket yesterday
20:13:53 <dkayiwa> jkeiper_: hahahah :)
20:13:57 <wyclif> djazayeri, to xfrm-34
20:14:12 <dkayiwa> jkeiper_: i think Rafals
20:14:24 <dkayiwa> method should work too
20:14:31 <jkeiper_> i would like to start using it
20:14:34 <jkeiper_> need to test it out
20:14:54 <dkayiwa> jkeiper_: more so when you need to do more than just reflect on one, say method
20:15:09 <dkayiwa> wyclif: yes i saw the email
20:15:25 <jkeiper_> different topic: i ran "maven deploy" for household-1.0.1 and it deployed to nexus .. but when i depend on it with <type>pom</type>, i am getting errors saying certain packages do not exist ... what could i be doing wrong?
20:15:26 *** lakkarau has quit IRC
20:15:35 <dkayiwa> jkeiper_: he says we jumped onto it before he felt ready :)
20:15:40 <jkeiper_> haha true
20:16:23 <dkayiwa> jkeiper_: could you be using locally cached version different from the one you have uploaded?
20:16:54 <wyclif> jkeiper_, which is rafal's method?
20:16:54 <jkeiper_> dkayiwa, i wonder ... but even that should be correct i think
20:17:04 <jkeiper_> dkayiwa, do i have to specify in the other module's pom?
20:17:11 <dkayiwa> jkeiper_: can you actually browse the jar in the IDE and see if the package really exists?
20:17:17 <wyclif> jkeiper_, is that writing an extension moduke
20:18:02 <dkayiwa> jkeiper_: which other module
20:18:44 <jkeiper_> food distribution module, at https://github.com/AMPATH/openmrs-module-foodprescription
20:18:50 <OpenMRSBot> <http://ln-s.net/$ZHw> (at github.com)
20:18:52 <jkeiper_> the pom is here: https://github.com/AMPATH/openmrs-module-foodprescription/blob/master/pom.xml
20:18:54 <OpenMRSBot> <http://ln-s.net/$ZHx> (at github.com)
20:19:14 <jkeiper_> but as a "jar" there is nothing ...
20:19:19 <jkeiper_> er
20:19:42 *** rfriedman has quit IRC
20:19:48 <jkeiper_> if i set type to jar, it also does not compile
20:21:22 <jkeiper_> blargh ... yes, household:jar:1.0.1 is missing
20:21:44 <jkeiper_> perhaps i should just depend on household-api?
20:21:47 <wyclif> dkayiwa, i think there is some work to be done for that ticket
20:21:48 <jkeiper_> because i know there is a jar loaded there
20:22:34 <wyclif> dkayiwa, i think one needs to replace all reference to get/set xslt and get/set template to use the utility methods that use reflection to get via form resources
20:22:58 <jkeiper_> that did it
20:23:00 <jkeiper_> :-D
20:23:00 <dkayiwa> wyclif: ok
20:23:08 <dkayiwa> jkeiper_: :D
20:23:13 <wyclif> dkayiwa, i will comment on the ticket
20:23:20 <dkayiwa> wyclif: ok
20:26:15 *** goutham has quit IRC
20:33:28 *** lakkarau has joined #openmrs
20:39:12 *** jkeiper_ has quit IRC
20:45:07 *** mvorobey has quit IRC
20:56:37 *** djazayeri has quit IRC
21:03:42 *** bwolfe has quit IRC
21:19:55 *** snoppy has quit IRC
21:39:50 *** djazayeri has joined #openmrs
21:39:50 *** ChanServ sets mode: +o djazayeri
21:41:13 *** djazayeri has quit IRC
21:43:03 *** wyclif has quit IRC
21:52:17 *** djazayeri has joined #openmrs
21:52:17 *** ChanServ sets mode: +o djazayeri
21:53:56 *** dkayiwa has quit IRC
21:54:09 *** kreddy has quit IRC
22:08:37 *** djazayeri has quit IRC
22:34:25 *** lh has joined #openmrs
22:36:33 *** lakkarau has quit IRC
22:44:40 *** wyclif has joined #openmrs
22:50:24 *** bwolfe has joined #openmrs
22:50:24 *** ChanServ sets mode: +o bwolfe
22:51:21 *** downey has joined #openmrs
22:51:21 *** ChanServ sets mode: +o downey
22:51:21 *** OpenMRSBot sets mode: +o downey
23:11:22 *** jordank has quit IRC
23:12:29 *** jordank has joined #openmrs
23:12:33 *** lh has quit IRC
23:41:59 *** lh has joined #openmrs
23:48:28 *** takmad has joined #openmrs
23:48:36 <downey> Hi takmad and welcome to the #openmrs IRC channel.
23:49:57 *** takmad has quit IRC