| 00:31:45 | <wyclif> hi bwolfe |
| 00:50:46 | *** yanokwa has joined #openmrs |
| 00:50:46 | *** ChanServ sets mode: +v yanokwa |
| 00:51:03 | *** yanokwa has quit IRC |
| 00:51:20 | *** yanokwa has joined #openmrs |
| 00:51:20 | *** ChanServ sets mode: +v yanokwa |
| 00:51:28 | *** yanokwa has quit IRC |
| 01:27:35 | *** deepaganu has joined #openmrs |
| 01:42:56 | *** deepaganu has quit IRC |
| 01:54:18 | *** deepaganu has joined #openmrs |
| 02:25:49 | *** ABHISHEK__ has joined #openmrs |
| 02:25:49 | *** deepaganu has quit IRC |
| 03:03:04 | *** ABHISHEK__ has quit IRC |
| 03:10:58 | *** suranga has joined #openmrs |
| 03:10:58 | *** ChanServ sets mode: +v suranga |
| 03:22:53 | *** gede has quit IRC |
| 03:31:02 | *** jordank has joined #openmrs |
| 03:31:05 | *** lh has quit IRC |
| 03:40:20 | *** kishoreyekkanti has joined #openmrs |
| 03:54:46 | *** maurya has joined #openmrs |
| 03:55:43 | *** Maurya_ has joined #openmrs |
| 03:57:39 | *** kishoreyekkanti has quit IRC |
| 04:00:06 | *** maurya has quit IRC |
| 04:05:34 | *** Maurya_ has quit IRC |
| 04:11:32 | *** upul` has joined #openmrs |
| 04:11:32 | *** ChanServ sets mode: +v upul` |
| 04:12:39 | *** jordank has quit IRC |
| 04:14:05 | *** jordank has joined #openmrs |
| 04:15:42 | *** bwolfe has quit IRC |
| 04:43:49 | *** jordank has quit IRC |
| 04:46:59 | *** kishoreyekkanti has joined #openmrs |
| 04:47:32 | *** kishoreyekkanti has joined #openmrs |
| 04:52:00 | *** kishoreyekkanti_ has joined #openmrs |
| 04:55:09 | *** kishoreyekkanti_ has quit IRC |
| 04:55:30 | *** kishoreyekkanti_ has joined #openmrs |
| 04:56:19 | *** kishoreyekkanti has quit IRC |
| 05:24:12 | *** mgielow has joined #openmrs |
| 05:37:19 | *** shortend has joined #openmrs |
| 06:15:35 | *** dkayiwa has joined #openmrs |
| 06:16:07 | *** kishoreyekkanti has joined #openmrs |
| 06:18:14 | *** kishoreyekkanti has joined #openmrs |
| 06:20:04 | *** kishoreyekkanti_ has quit IRC |
| 06:40:11 | *** maurya has joined #openmrs |
| 06:46:38 | *** r0bby_ has joined #openmrs |
| 06:46:38 | *** ChanServ sets mode: +v r0bby_ |
| 06:48:17 | *** r0bby_ is now known as robbyoconnor |
| 06:49:57 | *** r0bby has quit IRC |
| 07:12:30 | *** judygichoya has joined #openmrs |
| 07:15:18 | *** gede has joined #openmrs |
| 07:22:29 | *** kishoreyekkanti has quit IRC |
| 07:22:39 | *** maurya has quit IRC |
| 07:41:30 | <judygichoya> hey dkayiwa |
| 07:41:40 | <dkayiwa> hey judygichoya :) |
| 07:41:49 | <judygichoya> i have an instance of openmrs which when i try to design xform |
| 07:41:58 | <judygichoya> it forces me to download the xml form... |
| 07:42:07 | <judygichoya> instead of loading the xform |
| 07:42:15 | <dkayiwa> judygichoya: oh yes that is a problem when you are running java 7 |
| 07:42:25 | <dkayiwa> judygichoya: there is already a ticket for that |
| 07:42:32 | <judygichoya> so..downgrade to java6? |
| 07:42:45 | <dkayiwa> judygichoya: yes until when the ticket is closed |
| 07:42:51 | <judygichoya> ok..thanks |
| 07:47:50 | <judygichoya> was anyone able to successfully add git remote add upstream https://github.com/OpenMRS/openmrs-module-hl7query.git |
| 07:47:56 | <OpenMRSBot> <http://ln-s.net/$Y2X> (at github.com) |
| 07:48:11 | <judygichoya> i seem to get an error fatal: Not a git repository (or any of the parent directories): .git |
| 07:51:52 | <judygichoya> corrected the error |
| 07:52:26 | <dkayiwa> judygichoya: did you cd into the project directory |
| 07:52:43 | <judygichoya> yes |
| 07:52:46 | <judygichoya> that solved it |
| 07:57:53 | <judygichoya> dkayiwa have you used the openmrs virtual appliance? |
| 07:58:03 | <judygichoya> know the login username and password? |
| 07:58:14 | <judygichoya> admin test doesn't work... |
| 08:00:55 | <shortend> I'm working on the UI Framework tutorial, and it doesn't appear that my fragment controller is being called. |
| 08:01:11 | <dkayiwa> judygichoya: no i have never used it |
| 08:01:26 | <dkayiwa> judygichoya: doesn't do what the standalone does? |
| 08:03:00 | *** maurya has joined #openmrs |
| 08:04:10 | <shortend> I have the appropriate class (EncountersTodayFragmentController) under omod in the org.openmrs.module.mymodule.fragment.controller package. |
| 08:04:57 | <shortend> The actual package is org.openmrs.module.openhmis.plm.fragment.controller... so I have another level. Would that cause problems? |
| 08:05:53 | <dkayiwa> shortend: you may want to send an email to the dev list since it appears that those of us on IRC now are not familiar with the UI Framework |
| 08:06:04 | <shortend> OK. |
| 08:10:35 | *** rafa has joined #openmrs |
| 08:10:35 | *** ChanServ sets mode: +v rafa |
| 08:13:25 | *** dkayiwa_ has joined #openmrs |
| 08:13:41 | *** dkayiwa has quit IRC |
| 08:13:42 | *** dkayiwa_ is now known as dkayiwa |
| 08:17:04 | <dkayiwa> hi suranga |
| 08:17:51 | <dkayiwa> suranga: am working on HLQRY-21 Is this simply saving the template at https://wiki.openmrs.org/display/projects/A+Developer%27s+Guide+to+the+ORUR01+Message ? |
| 08:18:08 | <maurya> !seen djazayeri |
| 08:18:08 | <OpenMRSBot> maurya: djazayeri was last seen in #openmrs 15 hours, 3 minutes, and 54 seconds ago: <djazayeri> wyclif: I assume so. You know as well as I. :-) |
| 08:18:31 | <dkayiwa> !seen maurya :) |
| 08:18:31 | <OpenMRSBot> dkayiwa: (seen [<channel>] <nick>) -- Returns the last time <nick> was seen and what <nick> was last seen saying. <channel> is only necessary if the message isn't sent on the channel itself. |
| 08:18:59 | <maurya> :-) |
| 08:19:00 | <judygichoya> suranga have you tried to run the module since last contributions? |
| 08:19:14 | <judygichoya> cos i on starting the module on a standalone i get the error.. |
| 08:19:15 | <judygichoya> Error while trying to start module |
| 08:19:16 | <judygichoya> Unable to load/find moduleActivator: 'org.openmrs.module.hl7query.HL7QueryModuleActivator' Module: HL7 Query |
| 08:19:17 | <judygichoya> ** org.openmrs.module.Module.getModuleActivator(Module.java:186) |
| 08:19:18 | <judygichoya> ** org.openmrs.module.ModuleFactory.startModuleInternal(ModuleFactory.java:558) |
| 08:19:19 | <judygichoya> ** org.openmrs.api.context.Daemon$1.run(Daemon.java:56) |
| 08:19:29 | <dkayiwa> judygichoya: we fixed that |
| 08:19:38 | <dkayiwa> judygichoya: just update your code and recompile |
| 08:19:46 | <judygichoya> mmhh |
| 08:19:47 | <judygichoya> I just cloned a new repo right now |
| 08:19:54 | <judygichoya> and updated to upstream ... |
| 08:19:56 | <suranga> hi dkayiwa judygichoya .. sorry guys, am a bit late in responding :( |
| 08:20:02 | <judygichoya> and still get the same error... |
| 08:20:08 | <dkayiwa> judygichoya: ohhh |
| 08:20:18 | <suranga> judygichoya, yep, Daniel discoverd and fixed that , right ? |
| 08:20:20 | <dkayiwa> suranga: are you still sleeping :) |
| 08:20:39 | <judygichoya> maybe dkayiwa can check it out ... |
| 08:20:39 | <suranga> dkayiwa, my other day-job is currently underway :P |
| 08:20:41 | <dkayiwa> suranga: rafa introduced another. but i think he fixed it :) |
| 08:20:58 | <dkayiwa> suranga: very busy man :) |
| 08:21:10 | <suranga> dkayiwa, judygichoya :-( :-( |
| 08:21:21 | <rafa> dkayiwa: is that a doubt? ;) |
| 08:21:21 | * suranga goes to look... |
| 08:21:22 | <dkayiwa> suranga: now waiting for an answer to my query :) |
| 08:21:37 | <dkayiwa> rafa: not at all :D |
| 08:21:51 | <suranga> dkayiwa, sorry... yep, thats right.. the idea is that you create an groovy template, that looks like the wiki page... |
| 08:22:10 | <suranga> the end result is a luquibase changeset to enter the segment into the database table |
| 08:22:14 | <dkayiwa> suranga: i thought it is simply copy and paste it??? |
| 08:22:20 | <suranga> judygichoya, is also working on a similar ticket... |
| 08:22:55 | <dkayiwa> suranga: why shouldn't i copy and paste the wiki one? does it have anything that is not right? |
| 08:23:18 | <suranga> dkayiwa, I wrote that script from memory, with 0 groovy knowlege |
| 08:23:25 | <judygichoya> yeah dkayiwa.. i was also confused ... |
| 08:23:31 | <suranga> im not sure if the method names are even valid :) |
| 08:23:42 | <judygichoya> didn't know whether i needed to use xmltemplate to generate a similar xml.. |
| 08:24:03 | <judygichoya> or all i needed was to copy that into the databaseâ¦. |
| 08:24:08 | <dkayiwa> suranga: so is our duty to simply ensure that what you wrote is valid and hence works? |
| 08:24:22 | <suranga> dkayiwa, judygichoya im kind of an groovy noob, so lets put it this way... if this template is persisted in the db like that |
| 08:24:23 | <judygichoya> anyone getting the same error on running the module? |
| 08:24:48 | <dkayiwa> suranga: judygichoya i have never even ever done a groovy hello world :) |
| 08:24:53 | <suranga> and someone extracts it, and passed it an encounter object, groovy knows how tio populate the fields ? |
| 08:25:07 | <suranga> dkayiwa, ooops :) |
| 08:25:09 | <judygichoya> :) |
| 08:25:20 | <judygichoya> i am second on this..i have done a groovy hello world |
| 08:25:32 | <judygichoya> you can use groovy direct to write into a sql table.... |
| 08:25:35 | <dkayiwa> judygichoya: hahaha. you beat me :D |
| 08:25:50 | <rafa> suranga: the dashboard looks much better now :D |
| 08:25:52 | <rafa> suranga: thanks! |
| 08:26:07 | <dkayiwa> rafa: suranga oh yes dashboard :) |
| 08:26:17 | <suranga> rafa, ben pointed me to another example, so yesterday I was learning JIRA programming language :P |
| 08:26:35 | <suranga> dkayiwa, rafa are you getting the error judy is facing ? |
| 08:26:36 | <judygichoya> and u can use groovy template to generate the xml... |
| 08:26:59 | *** applecool has joined #openmrs |
| 08:26:59 | *** ChanServ sets mode: +v applecool |
| 08:27:00 | <rafa> suranga: judygichoya what is the error? |
| 08:27:36 | <suranga> but not all templates are that easy. some templates involve calling other sub templates.... |
| 08:27:43 | <rafa> sorry I'm missing context, so much going on the channel ;) |
| 08:27:47 | <judygichoya> WARN - ModuleFactory.startModuleInternal(576) |2012-07-31 11:17:33,265| Error while trying to start module: hl7query |
| 08:27:48 | <judygichoya> org.openmrs.module.ModuleException: Unable to load/find moduleActivator: |
| 08:28:06 | <rafa> judygichoya: let me test |
| 08:28:19 | <rafa> judygichoya: I didn't try today yet |
| 08:28:24 | <judygichoya> ok |
| 08:28:32 | <judygichoya> just tried it out |
| 08:28:34 | <suranga> rafa, this is basically what we fixed yesterday, i think ... |
| 08:29:07 | <rafa> suranga: with the difference it worked yesterday ;) |
| 08:29:40 | *** kishoreyekkanti has joined #openmrs |
| 08:29:49 | <dkayiwa> suranga: why don't we simply use one template as it is at? https://wiki.openmrs.org/display/projects/A+Developer%27s+Guide+to+the+ORUR01+Message |
| 08:30:14 | <dkayiwa> suranga: please forgive my ignorance, am just trying to understand a bit more about these tickets :) |
| 08:30:50 | <suranga> dkayiwa, cool, |
| 08:31:01 | <suranga> dkayiwa, we're tyring to support flexibility |
| 08:31:17 | <suranga> if we had a single template, everyone would have to use the parameters that we enforce |
| 08:31:48 | <suranga> for example, the PID.3 segment judy is working on would always be the patients preferred name, or identifier |
| 08:32:00 | <dkayiwa> suranga: ok, so thats why we split that big template into sections |
| 08:32:07 | <suranga> by having multiple templates, we let people write their own , and configure them |
| 08:32:19 | <suranga> so in my PID template, I can call subtemplates of my choice |
| 08:32:21 | <dkayiwa> suranga: ok |
| 08:33:22 | <suranga> dkayiwa, this moment will go down in history as the first time I had to explain something to you :):) |
| 08:33:23 | <rafa> judygichoya: suranga the module started just fine for me |
| 08:33:29 | <rafa> judygichoya: what do you have in logs? |
| 08:33:51 | <dkayiwa> suranga: be sure, you have lots more to explain to me :D |
| 08:34:08 | <suranga> judygichoya, whats the name of your module activator class in the pom file ? |
| 08:34:12 | <dkayiwa> rafa: judygichoya i suspect she may not be using the latest |
| 08:34:39 | *** kishoreyekkanti_ has joined #openmrs |
| 08:36:15 | *** maurya has quit IRC |
| 08:37:35 | *** kishoreyekkanti has quit IRC |
| 08:37:47 | <judygichoya> here is my po file |
| 08:37:49 | <judygichoya> http://pastebin.com/k8dWzzdk |
| 08:38:11 | <judygichoya> I will refresh to upstream and build the module again |
| 08:38:16 | <dkayiwa> judygichoya: and config.xml? |
| 08:39:09 | *** deepaganu has joined #openmrs |
| 08:39:10 | <dkayiwa> suranga: is there any of those template tickets that is committed for us to look at? :) |
| 08:39:27 | <suranga> dkayiwa, im afraid not |
| 08:39:50 | <suranga> dkayiwa, i was hoping that you would take the plunge today :) |
| 08:40:01 | <dkayiwa> suranga: hahahahaha :) |
| 08:42:10 | <judygichoya> http://pastebin.com/c4Xec08Z |
| 08:42:19 | <judygichoya> for config.xml |
| 08:42:40 | <judygichoya> dkayiwa maybe we can take crack on one for both of us... |
| 08:42:53 | <judygichoya> i feel like i know what to do â¦but still don't know what to do :) |
| 08:42:57 | <judygichoya> = confusion |
| 08:46:42 | <dkayiwa> judygichoya: sure !!!! :) |
| 08:47:10 | *** snoppy has joined #openmrs |
| 08:50:05 | <dkayiwa> judygichoya: you are using an old version. HL7QueryModule.hbm.xml should not have module |
| 08:50:25 | <dkayiwa> should be HL7Query.hbm.xml |
| 08:50:44 | <dkayiwa> judygichoya: also HL7QueryModuleActivator should not have module |
| 08:50:50 | <dkayiwa> should be HL7QueryActivator |
| 08:51:19 | <judygichoya> arrrggHHHH |
| 08:52:33 | <judygichoya> got the problem |
| 08:52:43 | <judygichoya> main blocker is learning git... |
| 08:52:53 | <judygichoya> so i should pull; upstream master |
| 08:52:58 | <judygichoya> then it works |
| 08:53:17 | <dkayiwa> judygichoya: am on same boat with you on that :) |
| 08:55:12 | *** ABHISHEK__ has joined #openmrs |
| 08:57:48 | *** maurya has joined #openmrs |
| 08:57:48 | *** deepaganu has quit IRC |
| 08:59:33 | *** ABHISHEK__ has quit IRC |
| 08:59:49 | *** dkayiwa has quit IRC |
| 09:01:37 | *** dkayiwa has joined #openmrs |
| 09:02:38 | *** upul` has quit IRC |
| 09:05:54 | <applecool> hi rafa |
| 09:09:30 | <rafa> hi applecool |
| 09:09:53 | <applecool> i claimed the METAREPO-5 :) the deserialization one |
| 09:10:04 | <applecool> so did you check my previous commit rafa |
| 09:10:05 | <applecool> ? |
| 09:10:14 | <rafa> applecool: not yet |
| 09:10:14 | <applecool> please check it when you are free! |
| 09:10:39 | <applecool> i changed them according to your earlier comments ;) |
| 09:10:53 | <applecool> i told you yesterday night :) |
| 09:11:09 | <rafa> applecool: I told you not to tell me |
| 09:11:17 | <applecool> okay! |
| 09:11:22 | <rafa> applecool: I do get notifications from jira and github |
| 09:11:34 | <rafa> applecool: no need to get them from you |
| 09:11:47 | <applecool> okay |
| 09:12:13 | <rafa> applecool: if you wish you can send me an e-mail with a summary what you've managed to do in a day |
| 09:12:23 | <applecool> okay sure |
| 09:13:06 | <rafa> applecool: but no need to ping me every time you commit ;) |
| 09:15:07 | *** applecoo_ has joined #openmrs |
| 09:15:24 | <rafa> applecool: have in mind that the world is a busy place ;) |
| 09:15:36 | <applecoo_> sorry got disconnected rafa power cut due to rains |
| 09:15:43 | <applecoo_> ya okay rafa :) |
| 09:16:12 | *** deepaganu has joined #openmrs |
| 09:16:51 | *** applecool has quit IRC |
| 09:17:30 | *** applecoo_ is now known as applecool |
| 09:17:31 | *** deepaganu has quit IRC |
| 09:17:32 | *** ChanServ sets mode: +v applecool |
| 09:17:48 | *** deepaganu has joined #openmrs |
| 09:32:46 | *** kishoreyekkanti_ has quit IRC |
| 09:35:15 | *** suranga has quit IRC |
| 09:39:40 | *** deepaganu has quit IRC |
| 10:20:19 | *** sgithens has joined #openmrs |
| 10:25:25 | *** applecoo_ has joined #openmrs |
| 10:28:17 | *** applecool has quit IRC |
| 10:29:59 | *** applecoo_ has quit IRC |
| 10:41:07 | *** applecool has joined #openmrs |
| 10:41:33 | *** ChanServ sets mode: +v applecool |
| 10:43:39 | *** shortend has quit IRC |
| 10:49:22 | *** shortend has joined #openmrs |
| 10:55:36 | <judygichoya> dkayiwa what are your thoughts on the ticket |
| 10:55:44 | <judygichoya> ur ticket? |
| 10:56:04 | <judygichoya> looks like one may have to save the xml in the database.... |
| 10:56:12 | <judygichoya> under the template column.. |
| 10:56:20 | <dkayiwa> judygichoya: yes am saving the xml into the database |
| 10:56:29 | <dkayiwa> judygichoya: and also writing a unit test for it |
| 10:56:38 | <dkayiwa> judygichoya: that will be all i can think of :) |
| 10:56:47 | <dkayiwa> judygichoya: will show you my commit shortly :0 |
| 10:56:48 | <judygichoya> then when accessed from the browser read the xml using grooy to render it? |
| 10:56:52 | <judygichoya> okey .. |
| 10:57:00 | <judygichoya> let me get some lunch ... |
| 10:57:18 | <dkayiwa> judygichoya: ok. please reserve a soda for me from the other place :) |
| 10:57:31 | <judygichoya> of course |
| 10:57:40 | <dkayiwa> :D |
| 10:57:42 | <judygichoya> only if you are done with the code.. :) |
| 10:57:58 | <dkayiwa> judygichoya: i promise to be done by the time you are done with lunch |
| 10:58:00 | <dkayiwa> :) |
| 11:00:36 | *** shortend has quit IRC |
| 11:09:24 | *** james_regen has joined #openmrs |
| 11:09:25 | *** ChanServ sets mode: +v james_regen |
| 11:15:57 | *** shortend has joined #openmrs |
| 11:26:40 | *** dawn_ has joined #openmrs |
| 11:26:40 | *** ChanServ sets mode: +v dawn_ |
| 11:37:55 | *** applecool has quit IRC |
| 11:39:30 | <dkayiwa> hi rafa |
| 11:39:38 | <rafa> dkayiwa: hi |
| 11:40:02 | <dkayiwa> rafa: did you just forget to add the retired column? |
| 11:40:18 | <rafa> dkayiwa: yes |
| 11:40:24 | <dkayiwa> rafa: ok |
| 11:40:26 | <rafa> dkayiwa: but added it later |
| 11:40:38 | <dkayiwa> rafa: ok let me fetch |
| 11:40:50 | <rafa> dkayiwa: ohh bad news :( |
| 11:41:02 | <dkayiwa> rafa: aha???? |
| 11:41:14 | <rafa> dkayiwa: you'll have to remove changes from liquibasechangelog and the hl7query_template table |
| 11:41:25 | <dkayiwa> rafa: ok |
| 11:41:34 | <rafa> dkayiwa: I've modified the changeset |
| 11:41:40 | <dkayiwa> rafa: ok |
| 11:41:40 | <rafa> dkayiwa: instead of creating a new one |
| 11:41:43 | <rafa> dkayiwa: sorry for that |
| 11:41:46 | <dkayiwa> rafa: ok |
| 11:42:12 | <rafa> dkayiwa: I thought no one was that fast to run it ;) |
| 11:42:33 | <dkayiwa> rafa: did you just add it :) |
| 11:42:43 | <rafa> dkayiwa: no I added that yesterday |
| 11:42:50 | <dkayiwa> rafa: ok |
| 11:45:32 | *** dawn_ has quit IRC |
| 11:47:23 | <judygichoya> dkayiwa? |
| 11:47:26 | *** shortend has quit IRC |
| 11:47:27 | <judygichoya> working? |
| 11:47:41 | *** shortend has joined #openmrs |
| 11:47:50 | <dkayiwa> judygichoya: committin.... |
| 11:49:02 | *** dawn_ has joined #openmrs |
| 11:49:02 | *** ChanServ sets mode: +v dawn_ |
| 11:52:43 | *** suranga has joined #openmrs |
| 11:52:43 | *** ChanServ sets mode: +v suranga |
| 11:52:58 | <suranga> im back guys, had to go but travel insurance :P |
| 11:58:35 | *** maurya has quit IRC |
| 12:03:08 | *** jkeiper__ has joined #openmrs |
| 12:04:22 | *** dawn_ has quit IRC |
| 12:04:42 | *** shortend has quit IRC |
| 12:07:05 | *** bwolfe has joined #openmrs |
| 12:07:05 | *** ChanServ sets mode: +o bwolfe |
| 12:07:38 | *** shortend has joined #openmrs |
| 12:09:24 | *** dawn_ has joined #openmrs |
| 12:09:24 | *** ChanServ sets mode: +v dawn_ |
| 12:12:52 | *** robbyoconnor has quit IRC |
| 12:23:33 | *** magoo_ has joined #openmrs |
| 12:28:38 | <suranga> hi bwolfe , good morning |
| 12:28:43 | <bwolfe> hi |
| 12:29:20 | <suranga> bwolfe, today, two importaint things happend. 1) rafa picked up the ticket to build the final ultimate hl7 message |
| 12:29:43 | <suranga> 2) everyone realized that building groovy segments is rather easy... |
| 12:30:06 | *** djazayeri has joined #openmrs |
| 12:30:06 | <bwolfe> good |
| 12:30:13 | *** ChanServ sets mode: +o djazayeri |
| 12:30:44 | <bwolfe> I've yet to see any pull requests for them, so they can't be THAT easy. ;-) |
| 12:30:53 | <suranga> bwolfe, :( |
| 12:31:07 | *** shortend has quit IRC |
| 12:31:15 | <suranga> bwolfe, one more question. do you read all the mail alerts you get from jira ? |
| 12:31:25 | *** jkeiper__ has quit IRC |
| 12:31:27 | <suranga> I keep missing peoples comments no matter how hard I try :( |
| 12:31:43 | <bwolfe> yes |
| 12:31:48 | <suranga> bwolfe, you just got a pull on the pvi segment |
| 12:31:53 | <bwolfe> everything goes to my inbox |
| 12:32:00 | <bwolfe> yep |
| 12:32:04 | <bwolfe> dkayiwa++ |
| 12:32:08 | *** jkeiper__ has joined #openmrs |
| 12:32:16 | <dkayiwa> bwolfe: for??? |
| 12:34:28 | *** djazayeri has quit IRC |
| 12:34:39 | <suranga> dkayiwa, first ever template for our review :) |
| 12:34:52 | <suranga> dkayiwa, mm.. do we need to include comments in the template too ? |
| 12:34:54 | <dkayiwa> suranga: be sure it is a hack |
| 12:35:13 | <dkayiwa> suranga: i completely have no idea. you tell me what i should do :) |
| 12:36:06 | *** shortend has joined #openmrs |
| 12:36:38 | *** deepaganu has joined #openmrs |
| 12:37:14 | <suranga> dkayiwa, ++ for the unit tests :P |
| 12:37:34 | <dkayiwa> suranga: am not actually sure if that is how i should test it :) |
| 12:37:59 | <suranga> dkayiwa, its a start, and at least it shows that the groovy is working... |
| 12:38:14 | <suranga> dkayiwa, now we can all copy off you :D |
| 12:38:51 | <dkayiwa> suranga: hahaha. ofcourse groovy had to better work, else Burke/Darius would be in trouble for suggesting it :) |
| 12:43:35 | <dkayiwa> hi judygichoya |
| 12:45:38 | <suranga> dkayiwa, we have decimated your ticket with comments. maybe judygichoya would like to look at it too :) |
| 12:45:49 | <bwolfe> jira, soooo slow |
| 12:45:57 | <bwolfe> dawn_, what brings you to these parts? |
| 12:46:27 | <dawn_> bwolfe: the daily scrum, of course :P |
| 12:46:30 | <dawn_> just kidding |
| 12:46:38 | <dkayiwa> suranga: no more comments for improvement??? |
| 12:46:42 | <bwolfe> you're early |
| 12:47:14 | *** shortend has quit IRC |
| 12:47:14 | <dawn_> bwolfe: am lurking. showed the dev team here the IRC a couple of weeks ago. trying to encourage the team to use it as a resource if needed :) |
| 12:47:15 | <suranga> dkayiwa, not for now, but we reserve the right to comment :) |
| 12:47:29 | *** shortend has joined #openmrs |
| 12:47:30 | <suranga> dawn_, good idea |
| 12:47:34 | *** shortend has left #openmrs |
| 12:47:41 | <dkayiwa> suranga: hahahah. you surely reserve it :D |
| 12:47:48 | <dawn_> suranga: hi!!!! :) |
| 12:48:07 | <dawn_> Hi Everyone! |
| 12:48:11 | * dawn_ can't go through each name |
| 12:48:51 | <suranga> dawn_, where will you be bitween the 18th to 24th August ? |
| 12:49:09 | <suranga> dawn_, bwahahaha... i am comming to Rwandaaaaaaaaaaa |
| 12:49:20 | <dawn_> suranga: i'll be here in Kigali :) |
| 12:49:31 | <dawn_> suranga: YAAAAAAAAAAAAAAY!!!!!!!!!!!!!!!!!!!! :D |
| 12:49:38 | <dawn_> it will be so great to see you!!! |
| 12:49:43 | * dawn_ marks the dates on her calendar |
| 12:49:58 | <suranga> dawn_, Unfortunatly, i'll be rather busy with some training at the Jembi Rwanda, but i hope we get to meet up :P |
| 12:50:18 | <suranga> dawn_, imagine travelling 3000 km, and not finding time to meet up :D |
| 12:50:33 | <dawn_> suranga: i know. the training will be crazy, but I don't live to far from the Jembi office which means I will find you. :D :D |
| 12:50:41 | <dawn_> suranga: that would make me very sad |
| 12:50:43 | *** shortend has joined #openmrs |
| 12:52:03 | <dawn_> kayiwa was here a couple of weeks ago. it was so nice to see him. :) |
| 12:53:58 | *** sgithens has quit IRC |
| 12:54:37 | <suranga> dkayiwa, ooops, looks like I missed you by about a month |
| 12:54:50 | <suranga> dawn_, will you take part in Jembi training too ? i |
| 12:55:01 | <dkayiwa> suranga: was that for dawn_ or me? :) |
| 12:55:23 | <suranga> dkayiwa, for dawn_ , but im really sad that I missed you :( |
| 12:56:43 | <dawn_> suranga: is that the shared health record training? i am helping with a training right now, so i don't think i will be in that training with you |
| 12:56:55 | <dawn_> dkayiwa: how are you? |
| 12:57:03 | *** lakkarau has joined #openmrs |
| 12:57:07 | <dkayiwa> dawn_: am doing fine but missing you :) |
| 12:57:09 | <suranga> dawn_, exactlyyyyyyyy ! yayayy !!!!!!!!!!!!!! |
| 12:57:21 | <dawn_> dkayiwa: i have a picture from your presentation. just the one slide. ;) :D |
| 12:57:55 | <dkayiwa> dawn_: hahahahaha :D |
| 12:58:17 | <dkayiwa> dawn_: that was a presentation for the year!!! :D |
| 12:59:19 | <dawn_> suranga: is that training going to be at the clinics or somewhere in kigali? or do you know yet? |
| 12:59:41 | <dawn_> dkayiwa: it was the best presentation! |
| 12:59:49 | <suranga> dawn_, i think we are planning for the Jembi office, but im not very sure :) |
| 13:00:10 | <dkayiwa> dawn_: hahahahahahahahaha. i trust your judgement!!!! :D |
| 13:01:51 | *** maurya has joined #openmrs |
| 13:03:00 | <bwolfe> anyone used mockito in a module yet? |
| 13:03:01 | *** rfriedman has joined #openmrs |
| 13:03:05 | <bwolfe> rafa^^ |
| 13:03:44 | * rfriedman sings dawn_ go away i'm no good for you |
| 13:04:05 | <suranga> bwolfe, no one into mockito yet, im afraid... |
| 13:04:24 | <bwolfe> boo |
| 13:04:31 | <rafa> bwolfe: nope |
| 13:04:35 | <bwolfe> need a ticket for that I guess suranga. :-) |
| 13:04:52 | <suranga> bwolfe, hmm.... actually its included in other tickets |
| 13:05:07 | <suranga> I think the pv1 tickets had it too... /me goes to look |
| 13:05:33 | <rfriedman> bwolfe, got a minute? |
| 13:05:35 | <dkayiwa> suranga: no mockito |
| 13:05:38 | <bwolfe> sure |
| 13:05:58 | <suranga> dkayiwa, , hmmm... yeap, i think thats missing from your ticket. Its on the others ones though... |
| 13:06:03 | <rfriedman> bwolfe, i'm trying to build a head version of 1.8.4 and wsrest |
| 13:06:24 | <rfriedman> bwolfe, i have done a clean install of 1.8.4 and produced 1.8.4-SNAPSHOT |
| 13:06:40 | <rfriedman> I have changed the dependency in wsrest to 1.8.4-SNAPSHOT |
| 13:06:54 | <dawn_> rfriedman: hi!! |
| 13:06:57 | <rfriedman> bwolfe, but maven is complaining about not finding 1.8.4-SNAPSHOT in its repo |
| 13:07:27 | * rfriedman sings think what your old man will say, think what the future may bring |
| 13:08:05 | <bwolfe> rfriedman, are you doing both builds with the same user? e.g. both from command line while logged in as roger ? |
| 13:08:13 | <bwolfe> (or as root, or as mvnuser, etc) |
| 13:08:20 | <rfriedman> doing in eclipse |
| 13:09:00 | <bwolfe> both in eclipse? |
| 13:09:35 | <rfriedman> bwolfe, yes ... do i have to do something like change an adverb to "supplied" or something? |
| 13:10:37 | <bwolfe> dkayiwa, have you been running the unit tests? they're all failing for me. is the module set up correctly for unit tests to be in the api project rafa? |
| 13:10:57 | <dkayiwa> bwolfe: the all pass for me |
| 13:11:03 | <rafa> bwolfe: pass for me too |
| 13:11:07 | <dkayiwa> bwolfe: which ones are failing? |
| 13:11:12 | <bwolfe> all ones using the omod |
| 13:11:14 | <rafa> bwolfe: both in maven and in eclipse |
| 13:11:29 | <dkayiwa> bwolfe: i have none in the omod |
| 13:11:35 | <bwolfe> rfriedman, no, it should just be looking in your local repo...unless your local repo is screwed up. :-p |
| 13:11:44 | <rafa> bwolfe: yeah what's in omod? |
| 13:11:57 | <bwolfe> nothing. just that tests used to fail if in the api |
| 13:12:25 | <bwolfe> dkayiwa, give your pull requests a full title and full description |
| 13:12:37 | <bwolfe> dkayiwa, did you start a new pull request or add to the existing one? |
| 13:12:40 | <rfriedman> bwolfe, so should i check the repo in eclipse? do i need to do a maven step to put it there? |
| 13:12:44 | <dkayiwa> bwolfe: any conventions for that? |
| 13:12:55 | *** magoo_ has quit IRC |
| 13:13:01 | <dkayiwa> bwolfe: closed and reopened |
| 13:13:10 | <bwolfe> rfriedman, "mvn install" is supposed to put it into your local maven repo. as long as it compiles fine, it gets there |
| 13:13:21 | <bwolfe> dkayiwa, was that the only option? now my comments are lost :-/ |
| 13:13:49 | <dkayiwa> bwolfe: oh sorry i did not know that it would lead to loosing them. (I had read all of them though ) |
| 13:14:10 | <bwolfe> read + acted on though? :-p |
| 13:14:35 | <dkayiwa> bwolfe: yes about to commit. though not sure of how to do it right this time :) |
| 13:14:51 | <dkayiwa> bwolfe: as in how to add the commit to existing pull request |
| 13:15:10 | *** jkeiper__ has quit IRC |
| 13:15:16 | <bwolfe> dkayiwa, google |
| 13:15:17 | <dkayiwa> bwolfe: or do i need to create another branch for follow up commits |
| 13:15:23 | <dkayiwa> bwolfe: :D |
| 13:15:42 | <bwolfe> why did you recreate the pull request and not add more commits? |
| 13:15:59 | <bwolfe> no, not another new branch |
| 13:16:00 | <dkayiwa> bwolfe: ignorance :( |
| 13:16:20 | <bwolfe> dkayiwa, commit, push, create pull request |
| 13:16:24 | <bwolfe> thats your workflow now |
| 13:16:46 | <dkayiwa> bwolfe: let me google how to add commits to an existing pull request |
| 13:17:59 | *** deepaganu has quit IRC |
| 13:18:21 | *** djazayeri has joined #openmrs |
| 13:18:21 | *** ChanServ sets mode: +o djazayeri |
| 13:18:27 | *** djazayeri has quit IRC |
| 13:18:35 | *** djazayeri has joined #openmrs |
| 13:18:35 | *** ChanServ sets mode: +o djazayeri |
| 13:21:46 | <rfriedman> bwolfe, i see 1.8.4-SNAPSHOT in the nexus repo and in the project workspace but not in my local repo -- and it was the nexus repo that was in the error messages |
| 13:21:58 | <bwolfe> rafa, dkayiwa, ugh, nm about the tests, just me forgetting I had put some code in last night. :-( |
| 13:22:36 | <rafa> bwolfe: you put some tests in omod you mean? |
| 13:22:38 | <dkayiwa> bwolfe: it happens to all of us :) |
| 13:23:18 | <bwolfe> meaning I put code in the service...which was causing tests calling it to fail. :-( |
| 13:23:37 | <rfriedman> bwolfe, takes real expertise to break all tests with a single code snippet |
| 13:23:41 | <bwolfe> rfriedman, odd. you're doing "run as --> maven install" and its not getting into your local?? |
| 13:23:48 | <bwolfe> rfriedman, I'm good like that |
| 13:24:08 | <rafa> rfriedman: haha |
| 13:24:53 | <suranga> dkayiwa, the bad news is that I need to edit your ticket to include the mock testing :( |
| 13:25:42 | <rfriedman> bwolfe, just double-checked |
| 13:25:59 | <rfriedman> bwolfe, seems crazy to me |
| 13:29:45 | *** deepaganu has joined #openmrs |
| 13:29:52 | *** dkayiwa has quit IRC |
| 13:30:30 | <suranga> dkayiwa, ok, even worse news. !ticket hl7qry-7 already contans the part about mock testing .... |
| 13:31:31 | <bwolfe> rfriedman, can you run "mvn install" at the command line? |
| 13:32:04 | <bwolfe> rfriedman, and if 1.8.4 is in the nexus repo snapshots directory, why is it not finding it there. does your main pom.xml in restws reference the snapshots repo? |
| 13:32:13 | <maurya> djazayeri, hi darius,Consider this scenario I created a form with a obs having a number widget in the dynamic repeat so when the form is rendered an obssubmissionelement is generated and the form is sent to the user the user fil it with a number clicks add and says enter form .now the entire form is reconstructed at the server.now my question will the obssubmission elemt generated when the form is rendered persist ? |
| 13:32:19 | <rfriedman> bwolfe, rafa, ok, chased all the way back to initial problem, it is org.apache.poi.hssf.record.formula.functions does not exist |
| 13:33:02 | <bwolfe> where is that? restws? |
| 13:33:05 | <rafa> rfriedman: I'm missing context ;) |
| 13:33:07 | <bwolfe> or 1.8.4? |
| 13:33:19 | <bwolfe> looks like a bad control-shift-o on someones part... |
| 13:33:23 | <rfriedman> bwolfe, rafa, yes, it's in the user resource in ws |
| 13:33:49 | *** djazayeri has quit IRC |
| 13:34:04 | <bwolfe> rfriedman, by you or someone else? |
| 13:34:29 | <rfriedman> bwolfe, is this the error you were getting from Martin's patch? |
| 13:35:23 | <rfriedman> that's what I'm trying to do, install Martin's patch, but i guess i should get yours instead |
| 13:35:42 | <bwolfe> yes, use mine. |
| 13:35:52 | <bwolfe> I might have even taken that out already... |
| 13:36:03 | <bwolfe> I remember seeing one weird "T" import and removing it |
| 13:36:13 | <rfriedman> that's it |
| 13:37:12 | <rfriedman> bwolfe, tks |
| 13:47:08 | *** deepaganu has quit IRC |
| 13:49:49 | *** sthaiya has joined #openmrs |
| 13:50:01 | <sthaiya> hi |
| 13:50:24 | <sthaiya> quick question |
| 13:50:40 | *** skathol has joined #openmrs |
| 13:51:13 | <sthaiya> ant easy way to convert a List<Patient> to Cohort |
| 13:51:15 | <sthaiya> any easy way to convert a List<Patient> to Cohort |
| 13:52:13 | *** lakkarau has quit IRC |
| 13:55:09 | <bwolfe> sthaiya, isn't there a method on Cohort? |
| 13:58:24 | <sthaiya> none |
| 13:59:02 | <bwolfe> sthaiya, public Cohort(String name, String description, Collection patientsOrIds) { |
| 14:00:41 | <sthaiya> just done a cast from List to Collection and used that |
| 14:00:56 | <sthaiya> then i will let it stay as such |
| 14:00:59 | <bwolfe> sthaiya, you shouldn't even have to cast |
| 14:01:11 | <sthaiya> mhh |
| 14:01:54 | <sthaiya> ohh thats better |
| 14:01:58 | <sthaiya> testing out |
| 14:02:19 | <sthaiya> new Cohort(List<Patient>) |
| 14:02:54 | *** cpower_ has joined #openmrs |
| 14:03:04 | <bwolfe> if you don't need a name/desc, thats even better sthaiya. |
| 14:03:28 | *** djazayeri has joined #openmrs |
| 14:03:28 | *** ChanServ sets mode: +o djazayeri |
| 14:03:35 | <cpower_> Heeeelllooooo, and at least in Indiana happy Jimmy Buffett day |
| 14:04:07 | <dawn_> cpower_: hi!!! |
| 14:04:17 | <cpower_> whoa...she returns! |
| 14:04:28 | <bwolfe> dkayiwa disappeared just in time for scrum! |
| 14:04:56 | <rafa> hi! |
| 14:04:57 | *** lakkarau has joined #openmrs |
| 14:05:07 | <cpower_> bwolfe, about right |
| 14:05:11 | <dawn_> :D |
| 14:05:12 | <bwolfe> wyclif, try committing to your branch the fixes for this pull request and see if they show up in that same pull request: https://github.com/OpenMRS/openmrs-module-hl7query/pull/11 |
| 14:05:18 | <OpenMRSBot> <http://ln-s.net/$Y9g> (at github.com) |
| 14:05:55 | <cpower_> So Dawn's coming back to Indy and taking back her old job, it's been fun guys see you later ;-) |
| 14:06:24 | <bwolfe> yay! wait, I mean, oh. huh. this is awkward |
| 14:06:35 | <sthaiya> thanks @bwolfe |
| 14:06:35 | <dawn_> bahahahaha!!! There's no way you'll make me leave a place where it's 85 degrees and sunny every day |
| 14:06:41 | <dawn_> though i really do miss the teamâ¦a LOT |
| 14:06:59 | <cpower_> It's 85 and sunny...right now... |
| 14:07:29 | <dawn_> it won't be in December :D |
| 14:07:34 | <dawn_> 8) |
| 14:07:40 | <cpower_> sure it will be (inside) |
| 14:07:47 | <dawn_> lol!!!! |
| 14:07:54 | <dawn_> +1 there cpower_ |
| 14:08:18 | <dawn_> is the scrum starting or what? |
| 14:08:20 | <cpower_> okay, okay, unless Dawn's going to run the Scrum, it's time to get moving. |
| 14:08:54 | <dawn_> cpower_: you are scrum leader |
| 14:08:56 | <wyclif> bwolfe, ? i alredy have that in my folk and i have no branches in it |
| 14:09:01 | <cpower_> !scrum on dawn_ |
| 14:09:02 | <OpenMRSBot> cpower_: Error: "scrum" is not a valid command. |
| 14:09:05 | <cpower_> hehehhe |
| 14:09:06 | <wyclif> bwolfe, besides master |
| 14:09:08 | <cpower_> tricked you |
| 14:09:18 | <cpower_> !scrumon cpower |
| 14:09:18 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 14:09:18 | *** dkayiwa has joined #openmrs |
| 14:09:32 | <bwolfe> wyclif, that was on your master branch? |
| 14:09:43 | <wyclif> bwolfe, yes |
| 14:10:04 | <bwolfe> booooooo |
| 14:10:06 | <bwolfe> wyclif-- |
| 14:10:12 | <bwolfe> always work on branches |
| 14:10:23 | <cpower_> Order: Suranga, bwolfe, rafa, wyclif, lakkarau, djazayeri, judygichoya, skathol |
| 14:10:26 | <bwolfe> wyclif, commit to your master, I'll bet that change will show up in that pull request. |
| 14:11:32 | <cpower_> Suranga you are up! |
| 14:11:47 | <suranga> gi guys |
| 14:11:49 | <suranga> Hi, |
| 14:11:50 | <suranga> keeping an eye on the progress of the sprint |
| 14:11:50 | <suranga> trying to hand out the more importaint tickets first |
| 14:11:50 | <suranga> general answering questions, and worrying |
| 14:12:05 | <rafa> no worries suranga ;) |
| 14:12:11 | <suranga> QUestion) are you writing your mock tests for each template ? |
| 14:12:34 | *** sthaiya has quit IRC |
| 14:12:37 | <suranga> Question) how far away are we from making a trial request . what tickets need to be complated for that ? |
| 14:12:53 | <bwolfe> so those are your discussion points suranga? any blockers for you? |
| 14:13:14 | <suranga> bwolfe, no blockers, only those dicsussion points :) |
| 14:13:31 | <bwolfe> sawa |
| 14:13:34 | <cpower_> same thought bwolfe, It sounds like we need to have this discussion Suranga but let's hold it to the end. |
| 14:13:35 | <bwolfe> Monday |
| 14:13:35 | <bwolfe> review hl7 query sprint tickets |
| 14:13:35 | <bwolfe> emails |
| 14:13:35 | <bwolfe> review RESTWS-272, includeall in restws |
| 14:13:35 | <bwolfe> work on HLQRY-23, templatefunctions |
| 14:13:36 | <bwolfe> Tuesday |
| 14:13:38 | <bwolfe> reviewed hlqry tickets |
| 14:13:40 | <bwolfe> small amt of emailing |
| 14:13:42 | <bwolfe> review resumes |
| 14:13:44 | <bwolfe> hl7qry-23, templatefunctions |
| 14:13:50 | <bwolfe> created pull request |
| 14:13:51 | <bwolfe> no blockers |
| 14:13:57 | <rafa> Today: |
| 14:13:57 | <rafa> * Completed HLQRY-22: Create Template pojo class |
| 14:13:57 | <rafa> https://tickets.openmrs.org/browse/HLQRY-22 |
| 14:13:57 | <rafa> * Started with HLQRY-36: Create a groovy template to create the OBX segment of an ORUR01 message |
| 14:13:57 | <rafa> https://tickets.openmrs.org/browse/HLQRY-36 |
| 14:13:58 | <rafa> * Claimed HLQRY-32: Create ORUR01 template which produces the complete ORUR01 message |
| 14:13:58 | <rafa> https://tickets.openmrs.org/browse/HLQRY-32 (but it seems I need to wait for some segments) |
| 14:13:59 | <rafa> * Preparing tickets for the MDS sprint / setting up for a design call tomorrow. |
| 14:13:59 | <rafa> No blockers. |
| 14:14:22 | <wyclif> Monday: |
| 14:14:22 | <wyclif> HLQRY-11 - Create a 'Manage Templates' admin page for the hl7query table |
| 14:14:23 | <wyclif> Partially worked on HLQRY-25(was a blocker) - Add ability to select orur01 template on Manage Templates admin page |
| 14:14:23 | <wyclif> HLQRY-8 - Create a controller class to get encounters in orur01 hl7 format |
| 14:14:23 | <wyclif> Tuesday: |
| 14:14:24 | <wyclif> Review TODOs for HLQRY-11 |
| 14:14:26 | <wyclif> HLQRY-35 - Create a hl7 PATIENT segment which combines the PID and PV1 segments. |
| 14:14:28 | <wyclif> complete HLQRY-25 if the seetings page is done - Add ability to select orur01 template on Manage Templates admin page |
| 14:14:31 | <wyclif> Blockers: None |
| 14:14:42 | <lakkarau> monday: |
| 14:14:43 | <lakkarau> git installed and cloned the app hl7query. |
| 14:14:43 | <lakkarau> tuesday: |
| 14:14:43 | <lakkarau> still need to fix few things for the application to run. |
| 14:14:43 | <lakkarau> and work on the tickets. |
| 14:15:02 | <lakkarau> no blockers |
| 14:15:08 | <djazayeri> Yesterday |
| 14:15:08 | <djazayeri> * ITECH Kenya stuff |
| 14:15:08 | <djazayeri> * PIH stuff |
| 14:15:08 | <djazayeri> Today |
| 14:15:09 | <djazayeri> * PIH stuff |
| 14:15:09 | <djazayeri> * Prep for tomorrow's university call (How to Use the UI Framework) |
| 14:15:09 | <djazayeri> * Bug Mike to prep for tomorrow's design call (Order Extension module) |
| 14:15:10 | <djazayeri> Blockers: none |
| 14:15:21 | *** kishoreyekkanti has joined #openmrs |
| 14:15:23 | <djazayeri> Discussion point: who's the bugfixer? (Wyclif?) |
| 14:16:03 | <dkayiwa> yes |
| 14:16:07 | <djazayeri> judygichoya: your turn |
| 14:16:31 | <djazayeri> then skathol |
| 14:16:37 | <cpower_> Judaygichoya, Yesterday, today, Blockers, Discussion points in some format like this. |
| 14:16:39 | <skathol> done: |
| 14:16:41 | <skathol> * Claimed HLQRY-5 - MSH Groovy template |
| 14:16:42 | <skathol> * Started learning about Groovy templates |
| 14:16:44 | <skathol> will do: |
| 14:16:45 | <skathol> * Continue working on HLQRY-5 |
| 14:16:47 | <skathol> no blockers |
| 14:16:54 | <cpower_> thanks skathol |
| 14:17:05 | <kishoreyekkanti> bwolfe: hey ben you there |
| 14:17:10 | <dkayiwa> Committed: Create service method to convert xml to hapi - HLQRY-29 |
| 14:17:10 | <dkayiwa> Committed: Create a groovy sub template to create the PV1 segment of an ORUR01 message - HLQRY-7 |
| 14:17:10 | <dkayiwa> Now responding to review comments for the above two tickets |
| 14:17:10 | <cpower_> Miss anyone? |
| 14:17:10 | <dkayiwa> No Blockers |
| 14:17:14 | <bwolfe> kishoreyekkanti, yeah, scrumming, one sec |
| 14:17:18 | <kishoreyekkanti> bwolfe: sure |
| 14:18:22 | <bwolfe> wyclif, sorry we missed that you shoudl be bug fixer. please finish up tickets asap and switch over |
| 14:18:32 | <wyclif> bwolfe, ok |
| 14:18:36 | <bwolfe> wyclif, or leave as is and someone else can merge your commits to their branch and finsih them |
| 14:19:05 | <cpower_> Ok lots of discussion points: Suranga's discussion points, Wyclif bug fixing, missing dev's for this sprint |
| 14:19:10 | <cpower_> No blockers |
| 14:19:14 | <cpower_> !scrumoff |
| 14:19:14 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 14:19:19 | <bwolfe> cpower_, can you list them out one by one? |
| 14:19:20 | *** lakkarau has quit IRC |
| 14:20:38 | <suranga> bwolfe, mine were |
| 14:20:48 | <suranga> are you writing your mock tests for each template ? |
| 14:20:59 | <suranga> how far away are we from making a trial request . what tickets need to be complated for that ? |
| 14:21:46 | <bwolfe> suranga, only the controller ticket needs done for that |
| 14:22:15 | <suranga> bwolfe, once that's done, we can start really basic testingg... has anyone taken on that ticket ? |
| 14:22:27 | <suranga> I saw the templateengine ticket was done, wasnt it ? |
| 14:22:28 | <dkayiwa> does any one know an easy way of adding a commit to a pull request? |
| 14:24:06 | <bwolfe> suranga, there is not templateengine... |
| 14:24:10 | <bwolfe> *not=no |
| 14:24:10 | <rafa> dkayiwa: has the pull request been merged? |
| 14:24:24 | <bwolfe> dkayiwa, I read on github you just commit to your branch again |
| 14:24:27 | <dkayiwa> rafa: i do not think so |
| 14:24:32 | <judygichoya> sorry away from my desk... |
| 14:24:34 | <bwolfe> then check the pull request and it should show up |
| 14:24:52 | <suranga> bwolfe, sorry. i think i got the name wrong. let me look that up again. |
| 14:25:25 | <suranga> what I also ment to say was that even an partial message is adequate for us to beging testing, and improving upon it |
| 14:25:37 | <suranga> so i'm really looking forward to that ticket |
| 14:25:58 | <djazayeri> bwolfe, suranga: I implemented the processing of templates in the service, but I did not introduce a TemplateEngine class. |
| 14:26:15 | <rfriedman> suranga, are you aware of how webservices.rest does controller tests in junit? |
| 14:26:28 | <dkayiwa> bwolfe: i did that but you still asked me to add the commit to the pull request. that is where i got confused :) |
| 14:26:39 | <suranga> rfriedman, mmm..... not very sure. is it similar ? |
| 14:26:48 | <djazayeri> bwolfe, dkayiwa: I don't think that's right (about stuff automatically being added to pull requests). I think if you make a commit, and then you try to create another pull request in the github ui, it offers to add it for you, right? |
| 14:27:07 | <rfriedman> suranga, i think it would be similar, at least it would be a framework for constructing tests |
| 14:27:23 | <dkayiwa> djazayeri: it seem to allow only one pull request per branch |
| 14:27:36 | <djazayeri> dkayiwa: then delete the pull request and create a new one |
| 14:27:37 | <bwolfe> djazayeri, dkayiwa, lets find out. just make a commit and push to your branch. then lets check that pull request. :-) |
| 14:27:52 | <bwolfe> djazayeri, no, closing pull requests loses all comments |
| 14:28:02 | <bwolfe> I'd prefer we do it the right way |
| 14:28:12 | <dkayiwa> bwolfe: i did that already for both my tickets including the most recent about PV1 :) |
| 14:28:46 | <djazayeri> maurya: please show me some sample code |
| 14:28:46 | <dkayiwa> bwolfe: i still can see your comments even after i closed the request :) |
| 14:29:03 | <dkayiwa> bwolfe: here they are: https://github.com/OpenMRS/openmrs-module-hl7query/pull/14/files#r1272500 |
| 14:29:09 | <OpenMRSBot> <http://ln-s.net/$Y$E> (at github.com) |
| 14:29:20 | <djazayeri> maurya: e.g. include a link to the code in github, or paste a code snippet, or something |
| 14:29:43 | <djazayeri> maurya: also, really, can you show me the problem you're running into, phrased as a failing unit test? |
| 14:29:59 | <bwolfe> djazayeri, dkayiwa: yes, just commit to your branch with the changes. you will see the new commits show up |
| 14:29:59 | <bwolfe> https://github.com/OpenMRS/openmrs-module-hl7query/pull/16 |
| 14:30:05 | <OpenMRSBot> <http://ln-s.net/$Y$H> (at github.com) |
| 14:30:10 | <bwolfe> ...show up in the existing pull request |
| 14:30:13 | <dkayiwa> bwolfe: oh thats much easier and better :) |
| 14:30:22 | <maurya> djazayeri, it's the same code , i just added some sysouts to find out the problem...do you want to see the server log of them |
| 14:30:42 | <bwolfe> the "added comment" commit in my pull request was committed just now (after I created the pull request) |
| 14:30:47 | <maurya> djazayeri, the code you provided in the spike |
| 14:31:03 | <djazayeri> maurya: take this as a learning experience about Behavior-Driven Development and/or Test-Driven Development. :-) |
| 14:31:23 | <bwolfe> dkayiwa, rafa, wyclif: THIS is why you ALWAYS code in branches on your fork! you can have multiple pull requests open and changes committed to your branch show up in the pull request |
| 14:31:37 | <kishoreyekkanti> bwolfe: ++ |
| 14:31:39 | <djazayeri> maurya: I want you to write a unit test that expresses the behavior you are trying to make happen |
| 14:31:53 | <djazayeri> maurya: it will be failing, obviously |
| 14:32:01 | <dkayiwa> bwolfe: ok |
| 14:32:05 | <wyclif> ok |
| 14:32:17 | <djazayeri> maurya: after you have written that unit test, I can look at it, and the underlying code, and try to answer the question. |
| 14:32:18 | <maurya> djazayeri, okay:) |
| 14:33:59 | <bwolfe> dkayiwa, now, lets close your new pull request and reopen the other one to see the comments. :-) |
| 14:34:46 | <bwolfe> oh wait, I don't see your old one now... |
| 14:35:11 | <kishoreyekkanti> bwolfe: Hey Ben sorry to interrupt you again. I need to run away now. I just want to know the status on OpenMRS github push. Can you drop me a mail over your day today and i can take necessary action tomorrow. |
| 14:35:47 | <kishoreyekkanti> bwolfe: as far as i can see the latest mail thread on dev list, there are no issues in moving this to github. i can take care of the latest commits |
| 14:35:59 | <bwolfe> kishoreyekkanti, ok. I think we need to wait until next week. there are more wiki doc changes needed to happen alongside the push to github |
| 14:36:23 | <bwolfe> so next week we can dedicate a dev to making sure those are cleaned up |
| 14:36:33 | <kishoreyekkanti> bwolfe: Awesome! any thing else you wanted me to do apart from the push(from github perspective?) |
| 14:38:14 | <bwolfe> dkayiwa, found the old pull request. your new commits are in it: https://github.com/OpenMRS/openmrs-module-hl7query/pull/12/files |
| 14:38:22 | <OpenMRSBot> <http://ln-s.net/$Y$Q> (at github.com) |
| 14:38:24 | <dkayiwa> bwolfe: ok |
| 14:38:48 | <bwolfe> kishoreyekkanti, do you want to review/write up your "best practices" of how you use git? |
| 14:39:06 | <bwolfe> dkayiwa, but the comments are missing on the files you recommitted over the top of. :-) |
| 14:39:15 | <kishoreyekkanti> bwolfe: good that you still remember "best practices" ;) :-P |
| 14:39:26 | <kishoreyekkanti> bwolfe: Yep i'll do that tomorrow. |
| 14:39:50 | <dkayiwa> bwolfe: ohhhhhhh |
| 14:39:52 | <kishoreyekkanti> bwolfe: running out now! will catch you tomorrow. |
| 14:39:55 | <kishoreyekkanti> Have a great day! |
| 14:40:08 | <bwolfe> thanks kishoreyekkanti. cya! |
| 14:40:29 | *** kishoreyekkanti has quit IRC |
| 14:40:41 | <bwolfe> dkayiwa, thats good and bad I suppose. good because we know you committed to that file. but bad if you committed to that file and didn't address the comments. (but it looks like you did address the comments) |
| 14:40:55 | <dkayiwa> bwolfe: ok |
| 14:43:03 | <rfriedman> bwolfe, do you know where kishore is? |
| 14:43:31 | <bwolfe> rfriedman, kishore is based in india. is that what you mean? |
| 14:44:06 | <rfriedman> bwolfe, yes, I'm trying to figure out whether Sandeep can be working with the power failures there |
| 14:44:19 | <bwolfe> dkayiwa, can you either close your new one and reopen the old or update the new one to have a better name/desc ? |
| 14:44:26 | *** suranga has quit IRC |
| 14:44:29 | <dkayiwa> bwolfe: ok |
| 14:46:10 | *** snoppy has quit IRC |
| 14:46:46 | *** dawn__ has joined #openmrs |
| 14:46:46 | *** ChanServ sets mode: +v dawn__ |
| 14:46:54 | *** dkayiwa has quit IRC |
| 14:48:06 | *** dawn_ has quit IRC |
| 14:48:06 | *** dawn__ is now known as dawn_ |
| 14:48:24 | <dawn_> bye ya'll |
| 14:48:28 | *** dawn_ has quit IRC |
| 14:51:14 | *** snoppy has joined #openmrs |
| 14:51:36 | *** applecool has joined #openmrs |
| 14:51:43 | *** ChanServ sets mode: +v applecool |
| 14:56:53 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @RegenstriefGHI: Daniel Kayiwa presents the use of @OpenMRS in #Uganda at @UNICEF e/mHealth Workshop hosted in Kigali. #healthIT #EMR ... <http://twitter.com/OpenMRS/statuses/230308716984025088> |
| 14:59:23 | *** lh has joined #openmrs |
| 14:59:24 | *** lh has joined #openmrs |
| 15:02:57 | *** harshadura has joined #openmrs |
| 15:04:37 | <judygichoya> rafa ... |
| 15:04:52 | <judygichoya> do i just assign a unique UUID for the template? |
| 15:04:57 | <judygichoya> which is random? |
| 15:05:12 | <judygichoya> so as to save in the database? |
| 15:05:22 | <rafa> judygichoya: it should be assigned automatically |
| 15:05:35 | <rafa> judygichoya: by AOP around saveHL7Template |
| 15:05:41 | *** robbyoconnor has joined #openmrs |
| 15:05:41 | *** ChanServ sets mode: +v robbyoconnor |
| 15:05:50 | <rafa> judygichoya: so you don't have to do it |
| 15:05:55 | <judygichoya> when creating a liquibase xmlâ¦do i leave it blank? |
| 15:06:06 | <rafa> judygichoya: ohh no there you have to put some random UUID |
| 15:06:07 | <judygichoya> or just put in a random uuid... |
| 15:06:12 | <judygichoya> ok.. |
| 15:06:13 | <judygichoya> thanks |
| 15:06:30 | <rafa> np |
| 15:08:50 | *** jordank_ has joined #openmrs |
| 15:10:13 | *** robbyoconnor has quit IRC |
| 15:10:42 | *** robbyoconnor has joined #openmrs |
| 15:10:42 | *** ChanServ sets mode: +v robbyoconnor |
| 15:11:03 | *** djazayeri1 has joined #openmrs |
| 15:11:44 | *** skathol has quit IRC |
| 15:11:58 | *** djazayeri1 has joined #openmrs |
| 15:12:20 | *** djazayeri has quit IRC |
| 15:13:44 | <judygichoya> i am formatting my xml to be saved as |
| 15:13:48 | <judygichoya> <![CDATA[ |
| 15:13:49 | <judygichoya> <PID.5> <!-- PID.3 segments represent several names that a patient may have. They can be repeated --> |
| 15:13:50 | <judygichoya> <XPN.1> |
| 15:13:52 | <judygichoya> <FN.1>${patient.getFamilyName()}</FN.1> |
| 15:13:53 | <judygichoya> </XPN.1> |
| 15:13:55 | <judygichoya> <XPN.2>${patient.getGivenName()}</XPN.2> |
| 15:13:56 | <judygichoya> <XPN.3>${patient.getMiddleName()}</XPN.3> |
| 15:13:57 | <judygichoya> </PID.5> |
| 15:13:58 | <judygichoya> ]]> |
| 15:14:11 | <judygichoya> i added the getMiddleName portion (not sure if this was needed for this ticket..) |
| 15:14:34 | <bwolfe> judygichoya, might as well add all the name parts if they exist |
| 15:14:48 | <bwolfe> judygichoya, you don't need to put the comments in |
| 15:14:49 | <judygichoya> i wonder if we need to get the other prefix and suffix like Jr and Snr |
| 15:14:56 | <bwolfe> judygichoya, and you should loop over the patient names and put them all |
| 15:15:00 | <judygichoya> ok... |
| 15:15:17 | <judygichoya> thanks bwolfe |
| 15:15:21 | <maurya> djazayeri1, hi, can you jusst change your regressionTestHelper line:269 to SubmissionResults results = doSubmission(setupFormEntrySession(patient, getFormName()), request); |
| 15:16:19 | <judygichoya> bwolfe â¦if this is the template in the liquibase do i still need to loop? |
| 15:16:51 | <bwolfe> yeah, before PID.5, put a groovy for loop over the patient names |
| 15:18:54 | <judygichoya> so do you think the object passed in with the names will be a map? |
| 15:18:59 | *** harshadura has quit IRC |
| 15:19:17 | <judygichoya> then i can say def map = [:] |
| 15:19:36 | <judygichoya> x = 0 |
| 15:19:37 | <judygichoya> for ( e in map ) { |
| 15:19:38 | <judygichoya> x += e.value |
| 15:19:39 | <judygichoya> } |
| 15:19:39 | <judygichoya> ? |
| 15:21:04 | *** skathol has joined #openmrs |
| 15:24:01 | *** pushkar has joined #openmrs |
| 15:26:16 | *** rafa has quit IRC |
| 15:26:57 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @bawolfe: The more I use #git and @github with #openmrs, the more I love it! <http://twitter.com/OpenMRS/statuses/230310543586648065> |
| 15:27:05 | *** deepaganu has joined #openmrs |
| 15:27:09 | <bwolfe> judygichoya, isn't it just: for (patientname in patient.getNames()) { patientname.getFamilyName().... } |
| 15:27:24 | <judygichoya> ? |
| 15:27:48 | <judygichoya> for single segments like first name |
| 15:27:59 | <bwolfe> judygichoya, for the whole thing |
| 15:28:00 | <judygichoya> not the whole segment right? |
| 15:28:14 | <judygichoya> okay.. got it |
| 15:28:16 | <judygichoya> thanks |
| 15:28:24 | *** ChanServ sets mode: +v maurya |
| 15:28:46 | <judygichoya> @bawolfe: The more I use #git and @github with #openmrs, the more I love it! |
| 15:28:51 | <judygichoya> the more i hate it! |
| 15:31:31 | <bwolfe> judygichoya, what problems are you having? did you read up on it, or just start using it? |
| 15:31:48 | <judygichoya> after yesterday i read up on it ... |
| 15:31:53 | <judygichoya> but still run into problems... |
| 15:31:58 | <judygichoya> I am fine for now... |
| 15:32:05 | <judygichoya> just need to check on committing the code... |
| 15:32:38 | <judygichoya> <![CDATA[ |
| 15:32:39 | <judygichoya> |
| 15:32:40 | <judygichoya> <PID.5> |
| 15:32:42 | <judygichoya> for (patientname in patient.getNames()) { |
| 15:32:43 | <judygichoya> <XPN.1><FN.1>${patient.getFamilyName()}</FN.1></XPN.1> |
| 15:32:45 | <judygichoya> <XPN.2>${patient.getGivenName()}</XPN.2> |
| 15:32:46 | <judygichoya> <XPN.3>${patient.getMiddleName()}</XPN.3> |
| 15:32:47 | <judygichoya> } |
| 15:32:49 | <judygichoya> </PID.5> |
| 15:32:50 | <judygichoya> ]]> |
| 15:32:50 | <judygichoya> is what i have now bwolfe |
| 15:35:07 | *** sunbiz has joined #openmrs |
| 15:35:07 | *** ChanServ sets mode: +v sunbiz |
| 15:35:14 | *** sunbiz has left #openmrs |
| 15:35:37 | <djazayeri1> maurya: change that and do what? |
| 15:35:45 | *** djazayeri1 is now known as djazayeri |
| 15:35:45 | *** sunbiz has joined #openmrs |
| 15:35:45 | *** ChanServ sets mode: +v sunbiz |
| 15:35:46 | *** ChanServ sets mode: +o djazayeri |
| 15:36:53 | <maurya> djazayeri, change that and run your test of dynamicRepeat |
| 15:37:12 | <djazayeri> maurya: I need you to organize things so that what I have to do is: git clone github.com/maurya/... ; git checkout dynamicrepeat ; then run the test |
| 15:38:03 | <maurya> okay sure:) |
| 15:38:12 | <djazayeri> maurya: I can't easily access the code I wrote beforeâI switched it back since I have a couple of other projects that depend on standard HFE + some snapshot features |
| 15:46:37 | *** judygichoya has quit IRC |
| 16:02:12 | *** robbyoconnor has quit IRC |
| 16:04:37 | *** robbyoconnor has joined #openmrs |
| 16:04:37 | *** ChanServ sets mode: +v robbyoconnor |
| 16:06:52 | *** djazayeri1 has joined #openmrs |
| 16:07:26 | <maurya> djazayeri, here is the link: https://github.com/maurya/openmrs-module-htmlformentry/tree/dynamicSubmissionProblem |
| 16:07:33 | <OpenMRSBot> <http://ln-s.net/$Y:A> (at github.com) |
| 16:08:01 | <rfriedman> pushkar, hi |
| 16:08:18 | <pushkar> hi rfriedman !! |
| 16:08:27 | <rfriedman> are you in India? |
| 16:08:29 | *** robbyoconnor has quit IRC |
| 16:08:44 | <pushkar> rfriedman, Yess :-) |
| 16:08:51 | <rfriedman> pushkar, how is your power situation? |
| 16:09:04 | *** mccallumg has joined #openmrs |
| 16:09:04 | *** ChanServ sets mode: +v mccallumg |
| 16:09:06 | <applecool> haha! |
| 16:09:23 | <applecool> actually its always worst in india rfriedman |
| 16:09:24 | *** djazayeri has quit IRC |
| 16:09:37 | <pushkar> rfriedman, we re having daily powercuts for about 3 hrs |
| 16:10:16 | <rfriedman> applecool, pushkar, according to what i was reading, most of India had no power yesterday |
| 16:10:48 | <rfriedman> or today, it's always hard to figure out time in news stories :-) |
| 16:11:43 | <rfriedman> the only Indians I can see on skype are those who are in norway |
| 16:11:43 | <applecool> rfriedman: haha! if there is a rainfall ,the powercuts duration increases a lot |
| 16:12:58 | <rfriedman> applecool, but it's not so different than normal that people won't have their laptop batteries charged, cellphone towers won't have run out of emergency generator fuel, etc. |
| 16:13:36 | <pushkar> rfriedman, Its not as bad as you read maybe in villages but not in cities |
| 16:13:38 | <applecool> :D |
| 16:14:38 | <rfriedman> pushkar, applecool, in the stories I read, the ministers are blaming the grid company which is blaming the state authorities |
| 16:15:14 | <rfriedman> applecool, if the situation were normal, they wouldn't bother blaming anyone, they'd just muddle on, pushkar |
| 16:15:25 | <pushkar> rfriedman, usually in rural areas the powercuts span is around 6-12 hrs |
| 16:16:09 | <rfriedman> pushkar, i was reading about trains stopping in ?Bengal? |
| 16:16:23 | <applecool> rfriedman: to be frank indian government sucks to the core |
| 16:16:24 | <rfriedman> about the Metro not running ?Delhi? |
| 16:16:44 | <applecool> rfriedman: yes thats true |
| 16:17:10 | <rfriedman> applecool, government workers being sent home -- they might as well do nothing there |
| 16:17:41 | <applecool> hmm :) |
| 16:18:05 | *** djazayeri1 is now known as djazayeri |
| 16:18:06 | *** ChanServ sets mode: +o djazayeri |
| 16:18:11 | <deepaganu> applecool, you are forgetting that we are the ones who elect the government |
| 16:18:23 | <deepaganu> select the roght people applecool |
| 16:18:43 | <rfriedman> from what choices, deepaganu |
| 16:19:15 | *** maurya has quit IRC |
| 16:19:18 | <applecool> deepaganu: haa! :P |
| 16:19:21 | <rfriedman> it's getting like that here, anybody who's worth having doesn't want to get involved |
| 16:19:38 | <deepaganu> rfriedman, thats true |
| 16:21:53 | *** goutham has joined #openmrs |
| 16:24:16 | <pushkar> yes thats true thats in north and east india |
| 16:24:56 | <bwolfe> wyclif, which bugfixing ticket are you working on now? |
| 16:25:48 | <wyclif> bwolfe, not yet started |
| 16:25:53 | <bwolfe> wyclif, ok, start with https://tickets.openmrs.org/browse/FORM-121 |
| 16:25:55 | <wyclif> plan to start in the next 30min |
| 16:26:24 | <sunbiz> rfriedman: :) |
| 16:27:09 | *** ABHISHEK__ has joined #openmrs |
| 16:27:19 | <ABHISHEK__> can anyone suggest where would i get the MVL/CIEL concept dictionary |
| 16:27:27 | *** ABHISHEK__ is now known as deepa |
| 16:27:30 | <deepa> can anyone suggest where would i get the MVL/CIEL concept dictionary |
| 16:28:08 | <sunbiz> deepa: the dropbox needs to be shared by Andy kanter |
| 16:28:17 | <deepa> ok |
| 16:28:26 | <sunbiz> deepa: who I dont think lurks on the IRC :) |
| 16:28:53 | <sunbiz> !seen akanter |
| 16:28:53 | <OpenMRSBot> sunbiz: akanter was last seen in #openmrs 21 weeks, 6 days, 5 hours, 54 minutes, and 6 seconds ago: <akanter> dkayiwa: do you know which logfile it would be in under ubuntu? |
| 16:29:23 | *** kori has joined #openmrs |
| 16:29:37 | <deepa> well sunbiz just received a mail from him thanks |
| 16:29:39 | *** kori has quit IRC |
| 16:29:45 | *** djazayeri has quit IRC |
| 16:30:05 | *** djazayeri has joined #openmrs |
| 16:30:05 | *** ChanServ sets mode: +o djazayeri |
| 16:30:08 | <sunbiz> deepa: gr8!! akanter++ |
| 16:30:35 | *** deepaganu has quit IRC |
| 16:42:44 | *** deepa has quit IRC |
| 16:43:23 | <jordank_> hi mccallumg |
| 16:43:33 | <mccallumg> hey jordank_ |
| 16:44:51 | <jordank_> mccallumg: I made a new code review, but it would only let me add you as the "deleted user" |
| 16:45:29 | <jordank_> but I didn't have that problem adding Janet |
| 16:45:43 | <mccallumg> jordank_: ok. I'll get on Michael about that. |
| 16:46:00 | *** suranga has joined #openmrs |
| 16:46:00 | *** ChanServ sets mode: +v suranga |
| 16:46:06 | <jordank_> ok cool |
| 16:46:21 | <suranga> hi guys, im back :) |
| 16:47:20 | <suranga> wyclif, hi, did you commit the pull request for HLQRY-11 |
| 16:47:24 | <sunbiz> Hi Suranga Schwarzenegger!! |
| 16:47:51 | <suranga> sunbiz, umm... hi... have not terminated anyone yet :P |
| 16:47:58 | *** cpower_ has quit IRC |
| 16:48:02 | <wyclif> suranga, was waiting for you to do so |
| 16:48:43 | <sunbiz> suranga: that entry line... "Im back" |
| 16:48:47 | <sunbiz> :) |
| 16:49:00 | <suranga> wyclif, ah, I see. will you be working on the changes ben suggested ? maybe I should wait for those... |
| 16:49:19 | <suranga> sunbiz, ah, I just rememberd that :D:D:D |
| 16:51:02 | <wyclif> i think the comment to add javadocs to the class |
| 16:51:32 | <wyclif> suranga, that code is in my fork and not a branch off the fork |
| 16:54:21 | <suranga> wyclif, mm.. Bens last comment refers to UI changes, i think. He's pointing you to an example page on the demo server |
| 16:55:33 | <wyclif> suranga, i will be focusing on the bug ixing swim lane, i think anyone can fix that, it is a very simple one |
| 16:56:04 | <suranga> wyclif, sorry, I forgot Ben mentioning that earlier. No worries :) |
| 16:59:56 | *** djazayeri has quit IRC |
| 17:00:19 | *** sthaiya has joined #openmrs |
| 17:00:51 | *** sunbiz has quit IRC |
| 17:04:32 | *** sthaiya has quit IRC |
| 17:05:01 | *** deepaganu has joined #openmrs |
| 17:08:07 | *** djazayeri has joined #openmrs |
| 17:08:07 | *** ChanServ sets mode: +o djazayeri |
| 17:09:53 | <wyclif> suranga, can you unassign me from HLQRY-11? |
| 17:10:15 | * suranga goes to look |
| 17:11:06 | <suranga> wyclif, I suspect that only u have permission to do that |
| 17:11:19 | *** snoppy has quit IRC |
| 17:11:42 | <wyclif> suranga, i cant, i think ben can |
| 17:11:57 | <wyclif> suranga, i thought you a project admin for that project |
| 17:12:04 | *** kreddy has joined #openmrs |
| 17:12:16 | <suranga> wyclif, bwolfe is capable of many things that we cannot :) |
| 17:12:20 | <wyclif> bwolfe, can you unassign me from HLQRY011 |
| 17:12:32 | <wyclif> bwolfe, HLQRY-11 |
| 17:15:07 | <wyclif> suranga, can you pull my pull requests? |
| 17:15:11 | <wyclif> there are about 2 |
| 17:15:19 | <wyclif> suranga, there are about 2 |
| 17:15:35 | <suranga> wyclif, for thlquery-11 alone ? |
| 17:15:44 | <wyclif> see tickets 11 and 8 |
| 17:16:33 | <wyclif> suranga, HLQRY-25 and HLQRY-8 |
| 17:16:53 | *** lakkarau has joined #openmrs |
| 17:25:16 | *** djazayeri1 has joined #openmrs |
| 17:25:37 | <goutham> bwolfe: can i create dataset for the tables which are created in the same module ? |
| 17:26:12 | *** djazayeri has quit IRC |
| 17:29:26 | *** jkeiper has joined #openmrs |
| 17:29:41 | <jkeiper> is ConceptService.updateConceptWord(Concept) deprecated or what? |
| 17:30:03 | <jkeiper> the @deprecated hint points to the exact same method |
| 17:30:07 | <jkeiper> unless I'm missing something |
| 17:30:40 | <jkeiper> same with updateConceptWords() |
| 17:31:39 | <jkeiper> same for PrivilegeConstants.GET_CONCEPT_PROPOSALS |
| 17:31:42 | <jkeiper> something weird is up |
| 17:39:29 | *** deepaganu has quit IRC |
| 17:39:38 | *** maurya has joined #openmrs |
| 17:40:57 | <lakkarau> bwolfe:after the hltemplete save methd is called ,the cashe to be cleared is it the query level or session level. |
| 17:42:36 | *** applecool has quit IRC |
| 17:45:15 | *** sandeep_ has joined #openmrs |
| 17:46:36 | *** jkeiper__ has joined #openmrs |
| 17:49:48 | *** ChanServ sets mode: +v maurya |
| 17:50:24 | *** jkeiper has quit IRC |
| 17:51:44 | *** rbowen__ has joined #openmrs |
| 17:52:29 | <rfriedman> hey sandeep_ |
| 17:55:00 | *** DrBacchus has quit IRC |
| 17:59:10 | *** sandeep_ has quit IRC |
| 18:02:50 | <lakkarau> suranga:hi |
| 18:05:29 | *** rbowen__ has quit IRC |
| 18:06:32 | *** DrBacchus has joined #openmrs |
| 18:17:55 | *** goutham has quit IRC |
| 18:23:32 | *** pushkar has quit IRC |
| 18:24:20 | <jkeiper__> bwolfe, around? |
| 18:28:03 | <DrBacchus> bwolfe: ping |
| 18:28:12 | <DrBacchus> bwolfe: Oh, look, I need to get in line. :) |
| 18:29:25 | <DrBacchus> bwolfe: Reminder: we have a podcast/interview/chat recording schedules in about 2 minutes. But I'm here all afternoon, so, whenever it's convenient. |
| 18:43:49 | *** jkeiper__ is now known as jkeiper |
| 18:43:55 | *** ChanServ sets mode: +v jkeiper |
| 18:45:46 | <bwolfe> jkeiper, hey |
| 18:55:13 | *** emilyp has joined #openmrs |
| 18:56:14 | <jkeiper> bwolfe, hey ... wondering if you can take a quick look at TRUNK-3591 and linked (all about the same issues) |
| 18:56:37 | <jkeiper> just need to know expected behavior from a legacy perspective |
| 18:57:55 | *** emilyp has quit IRC |
| 18:58:01 | <jkeiper> i'd wait until tomorrow's design call but it's not a guarantee, and ada is leaving AMPATH tomorrow (i think) |
| 19:03:03 | *** lh has quit IRC |
| 19:06:43 | <rfriedman> wyclif, you really here? |
| 19:07:10 | <rfriedman> jkeiper, as is leaving forever? |
| 19:07:19 | <rfriedman> in |
| 19:08:23 | <rfriedman> suranga, u really here? |
| 19:11:13 | <bwolfe> rfriedman, ada is in kenya right now, she's starting her trek home soon |
| 19:11:19 | <bwolfe> !ticket TRUNK-3591 |
| 19:11:21 | <OpenMRSBot> bwolfe: [#TRUNK-3591] proposed concept queue - error when saving as synonym - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3591 |
| 19:12:40 | <rfriedman> bwolfe, tks, looks like u are backed up, could use a little ubuntu help if you've got time |
| 19:14:24 | <bwolfe> rfriedman, ask away, I'll answer as I cycle back |
| 19:14:28 | <bwolfe> *circle |
| 19:15:48 | <rfriedman> bwolfe, tks, here is the problem: |
| 19:16:53 | <DrBacchus> bwolfe: Thanks. There are two recordings in the hopper ahead of you, so I expect that I'll get an intial edit to you by the end of the week, and then the podcast itself will be pushed out in about 2 weeks. |
| 19:17:04 | *** dkayiwa has joined #openmrs |
| 19:17:37 | <bwolfe> DrBacchus, thats a pretty quick turnaround |
| 19:17:56 | <bwolfe> DrBacchus, I've done similar interviews that take months to get out. :-) |
| 19:18:33 | <DrBacchus> Oh, wait, I'm on vacation next week, so it might be a little longer than that. :) |
| 19:18:39 | <DrBacchus> But some time in August anyways. |
| 19:19:03 | *** james_regen has quit IRC |
| 19:20:05 | <rfriedman> bwolfe, i installed 1.9, it set up .OpenMRS in /root. Now I am trying to run 1.8 via jetty and it keeps saying that it can't find logic but then when I try to upload it, it says logic is already there. 1.8 seems to be using ~/.OpenMRS, but the message in the log is looking for a properties file in my workspace. I put an openmrs-webapp properties file in the workspace, have both in ~/.OpenMRS, but I think it is trying t |
| 19:20:05 | <rfriedman> o use /root because the screen never repaints, it can't find stylesheets. Here's the system log: http://pastebin.com/7BsSYGaC |
| 19:23:08 | <bwolfe> jkeiper, what do you mean 300 were created? 300 new concepts were created?! |
| 19:25:01 | <bwolfe> rfriedman, when you run via jetty, are you logged in as the root user? or logged in as roger? |
| 19:25:16 | <rfriedman> bwolfe, roger |
| 19:25:41 | <rfriedman> bwolfe, i'm not quite sure how omrs was able to work in /root at all |
| 19:26:02 | <bwolfe> rfriedman, means you ran it when you were the root user |
| 19:26:19 | <bwolfe> rfriedman, or you did a "sudo ./run_on_linux" in a standalone? |
| 19:26:21 | *** jkeiper__ has joined #openmrs |
| 19:26:33 | <bwolfe> jkeiper__, what do you mean 300 were created? 300 new concepts were created?! |
| 19:26:52 | <rfriedman> bwolfe, that's what I thought, but maybe it was the installer or something, i didn't do the standalone thing |
| 19:27:05 | <jkeiper__> bwolfe, 300 new concept names |
| 19:27:20 | <bwolfe> jkeiper__, for 300 diff concepts I hope... |
| 19:27:20 | <jkeiper__> bwolfe, looped in the controller |
| 19:27:28 | <jkeiper__> bwolfe, for 300 diff concept proposals |
| 19:27:31 | <jkeiper__> all for the same concept |
| 19:27:36 | <bwolfe> jkeiper__, but same concept? :-/ |
| 19:28:22 | <bwolfe> rfriedman, I wonder if it is finding a logic.omod that is too NEW. but then when you try to upload an older one the new omod is blocking you |
| 19:28:32 | <jkeiper__> bwolfe, yep |
| 19:28:43 | <bwolfe> rfriedman, find the .openmrs/modules and delete the logic omod in there |
| 19:28:50 | <jkeiper__> bwolfe: http://pastebin.com/9s1ZCYDA |
| 19:28:52 | <bwolfe> jkeiper__, ugh. thats a nasty bug. |
| 19:28:55 | <rfriedman> bwolfe, could be, it's asking for 0.5, i have 0.5.2 |
| 19:29:10 | <jkeiper__> (there were 304 similar concept proposals) |
| 19:29:38 | * rfriedman is trying out the suggestion by bwolfe |
| 19:30:09 | *** jkeiper has quit IRC |
| 19:30:18 | <bwolfe> jkeiper__, yeah, so 300 grouped ones. |
| 19:30:28 | <bwolfe> jkeiper__, it should only create one synonym, obviously |
| 19:30:39 | <jkeiper__> true |
| 19:31:51 | <jkeiper__> bwolfe, the logic looping over all similar concepts is in the controller |
| 19:32:08 | <jkeiper__> bwolfe, but the logic for creating the synonym (even though it is not tagged as such) is in the service |
| 19:32:50 | <jkeiper__> bwolfe, also ... "save as concept" does not create a concept or do anything with the text; it actually resets the text to "" and goes on to map the related observations. |
| 19:33:08 | <bwolfe> jkeiper__, heh |
| 19:33:25 | <bwolfe> it should create a new concept with its Fully Specified name with the given text |
| 19:33:27 | <jkeiper__> soooooo, i'm just wondering what the original purpose / expectation was for them |
| 19:33:30 | <jkeiper__> ah |
| 19:33:41 | <jkeiper__> hrm |
| 19:34:54 | <bwolfe> jkeiper__, that page needs some usability done on it... |
| 19:35:29 | <jkeiper__> bwolfe, definitely ... just trying to plow through literally thousands of proposals with _something_ for now |
| 19:35:33 | <rfriedman> bwolfe, so I deleted the logic module from ~/.OpenMRS/modules, then restarted. It asked for the logic module, I gave it 0.5 downloaded from the module repo. It announced success, please restart. On restart, I get the same message and this time the missing style sheet problem |
| 19:39:01 | <bwolfe> weird |
| 19:39:07 | <bwolfe> which version of 1.8 ? |
| 19:39:18 | <rfriedman> bwolfe, head (1.8.4) |
| 19:39:52 | *** lh has joined #openmrs |
| 19:40:18 | <rfriedman> bwolfe, there is a note at https://wiki.openmrs.org/display/docs/Overriding+OpenMRS+Default+Runtime+Properties that some linux need an env variable ... could it be that? |
| 19:40:19 | <OpenMRSBot> <http://ln-s.net/8c91> (at wiki.openmrs.org) |
| 19:40:50 | <wyclif> hi rfriedman |
| 19:40:53 | <bwolfe> rfriedman, if its finding your modules dir, then its ok |
| 19:41:14 | <rfriedman> wyclif, hi, tks for responding, i've started working with ben on this |
| 19:41:26 | <bwolfe> rfriedman, the logic omod might be messed up that you're uploading. you could try to use the one in 1.8.4. do an "svn revert" on the folder and get it back. and be sure to delete logic in the modules folder. then start up again |
| 19:41:59 | <rfriedman> bwolfe, on which folder? |
| 19:43:04 | <bwolfe> rfriedman, in the 1.8.x code checkout: webapp/src/main/webapp/WEB-INF/bundledModules I think |
| 19:43:06 | *** jriley has joined #openmrs |
| 19:43:14 | <rfriedman> bwolfe, i have an 0.5.2 that successfully worked with 1.9, how about that one? |
| 19:43:50 | <bwolfe> rfriedman, I don't remember if it will or not |
| 19:44:00 | * rfriedman is saying hi to jriley and running off to follow bwolfe 's advice |
| 19:44:10 | <jriley> hi/bye, rfriedman |
| 19:49:10 | *** jordank_ has left #openmrs |
| 19:54:39 | *** shortend has quit IRC |
| 19:55:21 | *** jordank_ has joined #openmrs |
| 19:55:53 | *** jordank_ has left #openmrs |
| 19:56:06 | *** jordank_ has joined #openmrs |
| 19:56:07 | <rfriedman> bwolfe, very similar results, log is below, but only got asked to install logic |
| 19:56:09 | <rfriedman> ERROR - ModuleFactory.startModules(280) |2012-07-31 15:51:27,507| Unable to start module 'Reporting'. All required modules are not available: org.openmrs.module.htmlwidgets 1.5.6.2, org.openmrs.module.serialization.xstream |
| 19:56:10 | <rfriedman> ERROR - Listener.contextInitialized(154) |2012-07-31 15:51:27,509| Got exception while starting up: |
| 19:56:10 | <rfriedman> org.openmrs.module.OpenmrsCoreModuleException: The following modules are marked as 'core' by OpenMRS but were unable to start: logic v0.5, |
| 19:57:25 | <bwolfe> rfriedman, you reverted the folder, got the omod back in bundled modules, rebuilt the webapp, ran with jetty:run, and you still got the error? |
| 19:57:33 | <bwolfe> (rebuilding is an important step) |
| 19:57:45 | <rfriedman> bwolfe, yep |
| 20:02:35 | <wyclif> bwolfe, |
| 20:02:43 | <wyclif> hi bwolfe |
| 20:03:28 | <bwolfe> rfriedman, hurumph |
| 20:03:43 | <wyclif> bwolfe, does form entry have to be upgraded to depend on 1.9 or should use reflection to manage handle resources |
| 20:03:55 | <bwolfe> rfriedman, check you logs. is there a reason that it couldn't start up that we aren't seeing? perhaps it has to do with creating its tables |
| 20:03:58 | <rfriedman> bwolfe, my sentiments exactly |
| 20:04:18 | <dkayiwa> hi suranga |
| 20:04:18 | <bwolfe> wyclif, ideally it uses reflection. doing compatibility releases for modules is a pain |
| 20:04:28 | <wyclif> bwolfe, ok |
| 20:04:35 | <bwolfe> rfriedman, direct the output to a file and then scan through that |
| 20:04:45 | <suranga> dkayiwa, helllo |
| 20:04:46 | <bwolfe> rfriedman, mvn jetty:run > output |
| 20:05:03 | <dkayiwa> suranga: am looking at HLQRY-6 |
| 20:05:07 | <dkayiwa> !ticket HLQRY-6 |
| 20:05:08 | <OpenMRSBot> dkayiwa: [#HLQRY-6] Create a groovy template to create the PID segment of an ORUR01 message - OpenMRS JIRA - https://tickets.openmrs.org/browse/HLQRY-6 |
| 20:05:34 | <suranga> dkayiwa, ahaa.. I see it |
| 20:05:39 | <dkayiwa> suranga: is that supposed to be a template? or simply code to call the two templates? |
| 20:07:03 | <suranga> dkayiwa, well, it is a template. at the moment, a major part of it s work is to call two sub templates |
| 20:07:14 | <suranga> but you do seed to set PID.1 |
| 20:07:33 | <suranga> and later on, someone may edit your template to add many more parameters |
| 20:07:46 | <dkayiwa> suranga: so what do i insert into the hl7query_template table? |
| 20:08:13 | <dkayiwa> suranga: a combination of templates defaultPatientidentifier and defaultPatientName ? |
| 20:08:54 | <suranga> dkayiwa, umm... an groovyscript that can set PID.1, and then call the other 2 sub templates by name |
| 20:09:08 | <dkayiwa> suranga: ok |
| 20:09:19 | <suranga> :) |
| 20:09:44 | <dkayiwa> suranga: looks like i need some groovy tutorial about calling sub templates :) |
| 20:10:37 | <suranga> dkayiwa, haa haa, lucky me. I get to use your commits as a tutorial :P |
| 20:11:07 | <dkayiwa> suranga: ohhhhhhhhhhhhhhhh :D |
| 20:17:49 | *** jkeiper has joined #openmrs |
| 20:19:08 | <rfriedman> bwolfe, i was using just the run as jetty rather than mvn jetty:run, that seems to have cleared things up |
| 20:20:30 | *** jkeiper__ has quit IRC |
| 20:21:08 | <bwolfe> rfriedman, thats an interesting find. there two ways to run jetty: mvn jetty:run and mvn jetty:runwar (only 90% sure on the second ones name). can you tell which one eclipse was doing ? |
| 20:31:34 | *** maurya has quit IRC |
| 20:35:28 | <suranga> hi dkayiwa ummm... so i've made one more comment on your beautiful Pv1 segment |
| 20:35:52 | <suranga> dkayiwa, HLQRY-7 :-) |
| 20:38:20 | <rfriedman> bwolfe, explored eclipse preferences and googled around but could not find out what run as jetty actually does, what worked was making a mvn run config for jetty:run |
| 20:38:53 | <bwolfe> rfriedman, hmm |
| 20:39:00 | <bwolfe> rfriedman, that sounds like somethign that should be noted somewhere... |
| 20:39:07 | <rfriedman> bwolfe, i think this came up in a dev forum |
| 20:39:15 | <bwolfe> or perhaps just an faq entry with your stack trace or something |
| 20:39:40 | <rfriedman> ok, will do |
| 20:44:16 | <suranga> hi bwolfe , regarding your comment to HL7QRY-7 |
| 20:44:41 | <suranga> I was thinking og global props.. mm.. you dont like it ? |
| 20:46:00 | <rfriedman> !ticket hlyqry-7 |
| 20:46:01 | <OpenMRSBot> rfriedman: Issue Does Not Exist - OpenMRS JIRA - https://tickets.openmrs.org/browse/hlyqry-7 |
| 20:46:06 | <rfriedman> !ticket hl7qry-7 |
| 20:46:07 | <OpenMRSBot> rfriedman: HTTP Error 404: Not Found - https://tickets.openmrs.org/browse/hl7qry-7 |
| 20:46:21 | <suranga> !ticket HL7QRY-7 |
| 20:46:22 | <OpenMRSBot> suranga: HTTP Error 404: Not Found - https://tickets.openmrs.org/browse/HL7QRY-7 |
| 20:47:16 | <suranga> !ticket HLQRY-7 |
| 20:47:17 | <OpenMRSBot> suranga: [#HLQRY-7] Create a groovy sub template to create the PV1 segment of an ORUR01 message - OpenMRS JIRA - https://tickets.openmrs.org/browse/HLQRY-7 |
| 20:48:55 | <rfriedman> suranga, i think the trick is to make the constants into templates themselves |
| 20:53:23 | <rfriedman> suranga, so if you need a constant for example for the PV1.3 PL4 facility, then you make a template called PV1.3-PL4 that is used in the PV1 script and which contains the constant for the HD |
| 21:08:33 | *** mccallumg has quit IRC |
| 21:34:57 | *** dkayiwa has quit IRC |
| 21:36:36 | *** jkeiper__ has joined #openmrs |
| 21:40:18 | *** jkeiper has quit IRC |
| 21:43:53 | *** mccallumg has joined #openmrs |
| 21:43:53 | *** ChanServ sets mode: +v mccallumg |
| 21:44:51 | *** mccallumg has quit IRC |
| 21:46:07 | *** djazayeri1 has quit IRC |
| 21:49:50 | *** djazayeri has joined #openmrs |
| 21:49:50 | *** ChanServ sets mode: +o djazayeri |
| 21:56:36 | *** jkeiper__ has quit IRC |
| 21:57:05 | *** jkeiper__ has joined #openmrs |
| 22:02:41 | *** lakkarau has quit IRC |
| 22:06:23 | *** rfriedman has quit IRC |
| 22:16:28 | *** jriley has quit IRC |
| 22:23:24 | *** djazayeri has quit IRC |
| 22:37:37 | *** lakkarau has joined #openmrs |
| 22:42:27 | *** lh has quit IRC |
| 22:46:25 | *** lh has joined #openmrs |
| 22:46:36 | *** DrBacchus has quit IRC |
| 22:48:07 | *** jkeiper__ has quit IRC |
| 22:48:37 | *** jkeiper__ has joined #openmrs |
| 22:50:04 | *** downey has joined #openmrs |
| 22:50:04 | *** ChanServ sets mode: +o downey |
| 22:50:04 | *** OpenMRSBot sets mode: +o downey |
| 22:55:47 | *** suranga has quit IRC |
| 22:55:55 | *** mccallumg has joined #openmrs |
| 22:55:55 | *** ChanServ sets mode: +v mccallumg |
| 22:57:55 | *** lh has quit IRC |
| 22:58:05 | *** jkeiper__ has quit IRC |
| 22:58:38 | *** jkeiper__ has joined #openmrs |
| 23:00:28 | <downey> fisheye is back online for anyone waiting to use it (except mccallumg) :) |
| 23:01:22 | <mccallumg> downey: why not me? |
| 23:01:36 | <downey> mccallumg: tonight was just hardware upgrades. software to come later in the week |
| 23:01:46 | <downey> (hopefully tomorrow) |
| 23:02:46 | *** lh has joined #openmrs |
| 23:02:51 | *** jkeiper has joined #openmrs |
| 23:05:59 | *** jkeiper__ has quit IRC |
| 23:13:40 | *** lakkarau has quit IRC |
| 23:27:53 | *** lh is now known as lh_afk |
| 23:28:22 | <jordank_> hi mccallumg |
| 23:30:21 | <jordank_> or anyone, if I want to call a my own service method in my controller, do I make a new DAO obj? |
| 23:41:33 | <mccallumg> one sec, jordank_ |
| 23:45:25 | <mccallumg> jordank_: Can you call context to get the single instance of your service? |
| 23:48:47 | <jordank_> mccallumg: Maybe⦠My MergeConceptsService is just an interface right now |
| 23:49:56 | <jordank_> when I type "Context." in Eclipse none of the suggestions are MergeConcepts related |
| 23:50:39 | <jordank_> the method I want to call is in HibernateMergeConceptsDAO |
| 23:50:55 | <jordank_> mccallumg^ |
| 23:51:08 | *** kreddy has quit IRC |
| 23:51:29 | <mccallumg> so that is your new DAO |
| 23:51:32 | <mccallumg> jordank_: |
| 23:51:56 | <mccallumg> jordank_: did you register the service in the module application context? |
| 23:52:25 | <jordank_> mccallumg: not yet⦠how do I do that? |
| 23:53:03 | <mccallumg> jordank_: https://wiki.openmrs.org/display/docs/Creating+Modules see "How can my module create its own service?" |
| 23:53:41 | *** jkeiper__ has joined #openmrs |
| 23:54:08 | <mccallumg> jordank_: also https://wiki.openmrs.org/display/docs/Module+Application+Context+File "In order to create your own module's service, the following bean must be used" |
| 23:54:59 | <mccallumg> jordank_: I have to step away from the computer. Read those and I'll be back online in an hour. |
| 23:55:10 | <jordank_> ok! thanks |
| 23:55:43 | *** mccallumg has quit IRC |
| 23:56:57 | *** jkeiper has quit IRC |
| 23:59:37 | *** lh_afk has quit IRC |