| 03:19:54 | *** bwolfe has quit IRC |
| 03:21:55 | *** suranga has joined #openmrs |
| 03:21:55 | *** ChanServ sets mode: +v suranga |
| 03:49:35 | *** applecool has joined #openmrs |
| 03:49:39 | *** ChanServ sets mode: +v applecool |
| 04:01:17 | *** applecool has quit IRC |
| 04:39:59 | *** kishoreyekkanti has joined #openmrs |
| 05:47:54 | *** Spencer has joined #openmrs |
| 05:48:35 | <Spencer> exit |
| 05:48:40 | *** Spencer has quit IRC |
| 05:52:55 | *** skathol has joined #openmrs |
| 05:54:35 | *** shortend has joined #openmrs |
| 05:57:23 | *** dawn_ has joined #openmrs |
| 05:57:23 | *** ChanServ sets mode: +v dawn_ |
| 06:04:01 | <skathol> suranga: I plan to pick up a few tickets for the HL7 query sprint. Will join the scrum tomorrow. |
| 06:04:35 | <suranga> skathol, that would be great ! |
| 06:05:22 | <suranga> skathol, are you a newcomer to OpenMRS ? I dont recollect the IRC nick... |
| 06:06:47 | <skathol> suranga: I have worked on a few tickets in the past - my participation is spotty |
| 06:07:31 | <suranga> skathol, no worries, always happy to have everyone on board :-) |
| 06:08:30 | <skathol> suranga: looking forward to it. chat with you in a few hours :) |
| 06:17:07 | *** dkayiwa has joined #openmrs |
| 06:21:45 | *** skathol has quit IRC |
| 06:39:42 | *** dkayiwa has quit IRC |
| 06:42:36 | *** dkayiwa has joined #openmrs |
| 06:45:18 | *** harshadura has joined #openmrs |
| 07:10:28 | *** judygichoya has joined #openmrs |
| 07:13:54 | *** harshadura has quit IRC |
| 07:15:58 | *** applecool has joined #openmrs |
| 07:15:58 | *** ChanServ sets mode: +v applecool |
| 07:21:09 | <dkayiwa> suranga: also the jira dashboard link is missing on sprint page :) |
| 07:21:32 | <suranga> dkayiwa, ooops :) |
| 07:21:36 | <suranga> dkayiwa, embaasing :) |
| 07:22:27 | <suranga> dkayiwa, just rememberd that you are working full time on my sprint ! yayyy ! |
| 07:23:26 | <dkayiwa> suranga: :D |
| 07:26:22 | <suranga> dkayiwa, I was wondering, what tiket do you want to start off with ? |
| 07:26:59 | <suranga> dkayiwa, I was thinking it would be good to have the database up, because other tickets create liquibase changesets to add data to them :-) |
| 07:29:52 | <dkayiwa> suranga: ok. thanks for the tip :) |
| 07:30:01 | <dkayiwa> suranga: which number is that |
| 07:30:48 | <suranga> dkayiwa, https://tickets.openmrs.org/browse/HLQRY-10 |
| 07:30:57 | *** dawn__ has joined #openmrs |
| 07:30:57 | *** ChanServ sets mode: +v dawn__ |
| 07:31:22 | <dkayiwa> suranga: ok thanks :) |
| 07:31:43 | *** dawn_ has quit IRC |
| 07:31:45 | *** dawn__ is now known as dawn_ |
| 07:31:52 | <suranga> dkayiwa, and also, it would be cool if you can put up a skeleton changeset file into the module for the others to add their liquibase changesets too :-) :-) ;-) |
| 07:32:10 | <dkayiwa> suranga: ok :D |
| 07:51:28 | *** harshadura has joined #openmrs |
| 08:13:38 | *** shortend has quit IRC |
| 08:15:42 | *** upul` has joined #openmrs |
| 08:15:42 | *** ChanServ sets mode: +v upul` |
| 08:28:00 | *** applecool has quit IRC |
| 08:34:01 | *** applecool has joined #openmrs |
| 08:34:01 | *** ChanServ sets mode: +v applecool |
| 08:43:37 | *** rafa has joined #openmrs |
| 08:43:37 | *** ChanServ sets mode: +v rafa |
| 08:45:35 | <rafa> applecool: paste what you added to security.xml |
| 08:45:54 | <applecool> <intercept-url pattern="/app/userform*" access="ROLE_ADMIN,ROLE_USER"/> |
| 08:46:09 | *** dawn__ has joined #openmrs |
| 08:46:09 | *** ChanServ sets mode: +v dawn__ |
| 08:46:34 | <rafa> applecool: looks ok |
| 08:46:49 | <rafa> applecool: have you changed successView? |
| 08:46:49 | <applecool> hmm! |
| 08:47:06 | <applecool> succesView to /userform ? |
| 08:47:26 | <rafa> applecool: when you click save it should show /userform |
| 08:48:11 | <applecool> yes it is showing /userform! but there i am getting the access denied |
| 08:48:11 | <rafa> applecool: for other actions it should still be /admin/users |
| 08:49:04 | <rafa> applecool: have you looked at the logs? |
| 08:49:08 | <rafa> DEBUG [qtp752158675-37] UserFormController.onSubmit(86) |
| 08:49:08 | <rafa> WARN [qtp752158675-37] UserSecurityAdvice.before(107) |
| 08:49:08 | <rafa> WARN [qtp752158675-37] UserFormController.onSubmit(116) |
| 08:49:08 | <rafa> DEBUG [qtp752158675-41] UserFormController.showForm(179) |
| 08:49:23 | <applecool> yes i saw! |
| 08:49:37 | *** dawn_ has quit IRC |
| 08:49:37 | *** dawn__ is now known as dawn_ |
| 08:51:15 | <rafa> applecool: the error comes from UserSecurityAdvice line 108 |
| 08:51:59 | <applecool> yes checking it! |
| 08:56:18 | <applecool> i guess role1.getAuthority().equals(Constants.ADMIN_ROLE) should be role1.getAuthority().equals(Constants.ADMIN_ROLE)&&role1.getAuthority().equals(Constants.USER_ROLE) |
| 08:56:31 | <applecool> in the if condition inside the before method! |
| 08:58:34 | <rafa> applecool: no |
| 08:58:38 | <rafa> applecool: that's correct |
| 08:58:46 | <applecool> hmm! ? |
| 08:58:50 | <applecool> ok |
| 08:59:08 | <rafa> the problem is userRoles in the sent form is empty |
| 09:06:21 | <applecool> oh |
| 09:07:27 | <rafa> applecool: the bug is in UserFormController line 99 |
| 09:07:54 | <rafa> applecool: it only sets userRoles if user has an admin role |
| 09:08:08 | *** sgithens has joined #openmrs |
| 09:08:28 | <applecool> i actually changed it to request.isUserInRole(Constants.ADMIN_ROLE)&& request.isUserInRole(Constants.USER_ROLE) |
| 09:08:31 | <applecool> but same error! |
| 09:08:59 | <applecool> rafa: did i do it correct by the way? |
| 09:09:15 | *** harshadura has quit IRC |
| 09:09:19 | <rafa> applecool: now you require the user to have an admin and a user role |
| 09:09:29 | <rafa> applecool: it's not correct |
| 09:09:33 | <applecool> ok |
| 09:09:44 | <rafa> applecool: it should be || instead of && |
| 09:09:56 | <applecool> oh crap |
| 09:10:28 | <applecool> what a disastrous mistake i did! |
| 09:11:00 | <rafa> applecool: you're exaggerating :P |
| 09:11:09 | <applecool> ;) |
| 09:11:32 | <applecool> it was a silly mistake :P |
| 09:16:58 | <applecool> done! fixed :D |
| 09:16:59 | <applecool> rafa: |
| 09:17:50 | <rafa> applecool: and? |
| 09:18:01 | <applecool> ? |
| 09:18:10 | <applecool> and ? |
| 09:19:36 | <rafa> applecool: you pinged me |
| 09:19:56 | <rafa> applecool: did you want to ask something? |
| 09:20:33 | <applecool> no! moving to the other bug! |
| 09:20:36 | <applecool> just a sec :) |
| 09:21:59 | <applecool> next with the features or bug! rafa |
| 09:22:14 | <applecool> oh! yo told me to follow the order right! |
| 09:22:20 | <applecool> you* |
| 09:22:36 | <applecool> so METAREPO-5 |
| 09:27:34 | *** magoo_ has joined #openmrs |
| 09:36:26 | *** applecool has quit IRC |
| 09:39:29 | *** applecool has joined #openmrs |
| 09:39:29 | *** ChanServ sets mode: +v applecool |
| 09:40:22 | <applecool> rafa: power cut! disconnected! |
| 09:40:39 | <rafa> applecool: I didn't write anything |
| 09:40:48 | <applecool> okay :) |
| 09:40:57 | <applecool> how do i proceed with METAREPO-5! |
| 09:41:18 | <applecool> i went through the metadata sharing! |
| 09:42:56 | <rafa> applecool: start with adding xstream library |
| 09:43:06 | <rafa> applecool: read about xstream |
| 09:43:32 | <applecool> okay! is that library present in metadata sharing module? |
| 09:43:54 | <rafa> applecool: you can easily add a library with right-click on the main project maven -> add depndency |
| 09:43:59 | <rafa> applecool: yes |
| 09:44:13 | <applecool> oh! didnt knew that! |
| 09:45:52 | <applecool> rafa: there are many versions here! |
| 09:46:07 | <applecool> it is xstream xstream 1.2.2 ? |
| 09:46:10 | <rafa> applecool: pick the newest |
| 09:47:30 | <rafa> applecool: actually you should first fix METAREPO-1 and METAREPO-2 |
| 09:47:51 | <rafa> applecool: I've just reviewed them |
| 09:47:55 | <applecool> oh! |
| 09:49:05 | <rafa> applecool: METAREPO-3 is approved |
| 09:49:12 | <applecool> okay |
| 09:53:35 | *** sgithens has quit IRC |
| 09:55:29 | *** snoppy has joined #openmrs |
| 09:57:42 | <applecool> i added tables in the UI to align them properly rafa |
| 09:58:07 | <applecool> if i dont put them in table they are getting dis aligned and its not looking good! |
| 09:58:19 | <applecool> hence to overcome that problem i did that! |
| 09:58:29 | <rafa> applecool: you use css for aliging items |
| 09:58:40 | <rafa> applecool: use spans, divs |
| 09:58:45 | <rafa> applecool: tables are old school |
| 09:59:21 | <applecool> i tried them already! but they are not getting adjusted properly :) that is y i had to use the old school technique |
| 09:59:22 | <applecool> :) |
| 10:00:53 | *** dawn_ has quit IRC |
| 10:01:09 | <applecool> so do you want them to be changed? because i already tried them to fix it with style sheets! |
| 10:01:34 | <applecool> ? |
| 10:02:56 | *** harshadura has joined #openmrs |
| 10:03:19 | <applecool> rafa: i will try it again then :) because you are not satisfied :) |
| 10:03:55 | <rafa> applecool: try for 10 minutes |
| 10:04:08 | <applecool> okay! |
| 10:04:13 | <rafa> applecool: if it takes you more leave it as it is |
| 10:04:26 | <applecool> okay! |
| 10:04:59 | *** dkayiwa has quit IRC |
| 10:09:16 | *** dkayiwa has joined #openmrs |
| 10:10:45 | <rafa> suranga: hi |
| 10:11:01 | <rafa> suranga: where to look for ready-for-work tickets on the dashboard? |
| 10:11:25 | <rafa> suranga: you used some new setup |
| 10:11:33 | <suranga> howdy rafa |
| 10:11:44 | * suranga goes to look |
| 10:12:10 | <rafa> suranga: seems like all boxes show the same tickets :) |
| 10:12:23 | <rafa> suranga: hl7query-filter |
| 10:13:09 | <suranga> rafa, oooops, sorry about that |
| 10:14:18 | <applecool> i will get back to you rafa cya |
| 10:14:21 | *** applecool has quit IRC |
| 10:14:40 | <suranga> rafa, they are all 'ready for work' actually, it seems I need to edit my filters :( |
| 10:15:10 | <suranga> rafa, could you pick one manually while I fix that ? :) |
| 10:15:33 | <rafa> suranga: sure |
| 10:15:48 | <rafa> suranga: let me point you to the easiest way to create a jira dashboard |
| 10:16:00 | <suranga> rafa, aha... |
| 10:18:29 | <rafa> suranga: https://wiki.openmrs.org/display/RES/Being+a+Sprint+Leader |
| 10:18:45 | <rafa> see: 4. Creating JIRA dahsboard (step-by-step draft) |
| 10:19:44 | <suranga> rafa, umm... I see... unfortunately, I started off with this, but Ben said it was time to move on from that. He pointed me to this format, but im not 100% sure where he got it from |
| 10:20:08 | <rafa> suranga: oh ok |
| 10:23:46 | *** shortend has joined #openmrs |
| 10:28:39 | <rafa> dkayiwa: hi, why don't you claim HLQRY-10? |
| 10:28:59 | <rafa> dkayiwa: and HLQRY-22 |
| 10:29:00 | <dkayiwa> !ticket HLQRY-10 |
| 10:29:01 | <OpenMRSBot> dkayiwa: [#HLQRY-10] Create a dabatase table to persist the groovy templates - OpenMRS JIRA - https://tickets.openmrs.org/browse/HLQRY-10 |
| 10:29:10 | <rafa> dkayiwa: seems like they're related |
| 10:29:14 | <dkayiwa> !ticket HLQRY-22 |
| 10:29:15 | <OpenMRSBot> dkayiwa: [#HLQRY-22] Create Template pojo class - OpenMRS JIRA - https://tickets.openmrs.org/browse/HLQRY-22 |
| 10:29:21 | <dkayiwa> rafa: on let me do so. :) |
| 10:29:43 | <rafa> dkayiwa: cool |
| 10:30:22 | <rafa> dkayiwa: seems like we need these to continue with next tickets :) |
| 10:30:49 | <dkayiwa> rafa: oh i see. so i need to finish them quickly. ok :) |
| 10:31:06 | <rafa> dkayiwa: would be great :) |
| 10:31:23 | <dkayiwa> rafa: ok :) |
| 10:38:08 | <rafa> suranga: are we allowed to merge pull requests or do you want to do it yourself? |
| 10:38:32 | <suranga> rafa, you are wellcome to do it... I hope you have permissions to do so... :) |
| 10:39:17 | <dkayiwa> suranga: rafa has any of you tried to install the module as it was on checkout? |
| 10:39:27 | <rafa> dkayiwa: not yet |
| 10:39:33 | <rafa> dkayiwa: I will do it in a moment |
| 10:39:37 | <dkayiwa> ok |
| 10:39:44 | <suranga> rafa, which tickets will you be working on ? I wanted Daniel to take on the database ticket since it might be a blocker... |
| 10:40:07 | <suranga> dkayiwa, umm... not since the original version was committed... umm.. is anything wrong ? |
| 10:40:10 | <rafa> suranga: yes, I don't think we can do any tickets without having the template class... |
| 10:41:11 | <rafa> suranga: ohh we do have the class |
| 10:41:18 | * suranga goes to tickets... |
| 10:41:23 | <dkayiwa> suranga: just wanted to make sure it was not failing only on my side :) |
| 10:41:23 | <rafa> suranga: it's just not yet persistable |
| 10:41:33 | <rafa> suranga: right? |
| 10:41:39 | <suranga> rafa, i think Darius made a mock classs, for testing purposes... |
| 10:41:48 | <rafa> suranga: I see |
| 10:42:10 | <rafa> suranga: that's good |
| 10:42:13 | <suranga> dkayiwa, rafa |
| 10:42:59 | <suranga> dkayiwa, rafa please excuse me if I sound a bit distant or off -track. im multi tasking on my day job :) |
| 10:43:32 | <dkayiwa> suranga: thats good for your health :) |
| 10:43:58 | <rafa> suranga: on which version of OMRS will the module be used? |
| 10:44:19 | <dkayiwa> rafa: suranga am testing on 1.9.0 |
| 10:44:20 | <suranga> rafa, 1.8.2 at least |
| 10:44:42 | <rafa> dkayiwa: I'll try with 1.8.x then :) |
| 10:44:43 | <suranga> dkayiwa, umm... are you getting an error ? :( |
| 10:44:54 | <dkayiwa> suranga: yes looking into it now |
| 10:45:19 | <suranga> dkayiwa, we would greatly appreciate it if it works for 1.9.0 tooo... |
| 10:45:29 | <dkayiwa> ok |
| 10:46:53 | <rafa> suranga: we can run on different versions to make sure all work :) |
| 10:47:11 | <rafa> suranga: dkayiwa likes 1.9 |
| 10:47:24 | <dkayiwa> :D |
| 10:47:32 | <rafa> suranga: I like 1.8 more ;) |
| 10:47:47 | <dkayiwa> rafa: why :) |
| 10:47:57 | <suranga> in the meanwhile, I get to sit here cracking my whip ! bwahahahahahhaaaaaaaaaaaaaaaaaaaaaaaa |
| 10:48:28 | <rafa> dkayiwa: haha it's because I spent a week fixing MDS for 1.9 :P |
| 10:48:36 | <dkayiwa> rafa: am sure you will love 1.10 more being the release manager :) |
| 10:49:35 | <rafa> dkayiwa: am I the release manager? I don't think it's been decided yet ;) |
| 10:50:02 | <dkayiwa> rafa: some things are too too obvious even before they get decided on :D |
| 10:50:37 | <rafa> dkayiwa: 1.10 will manage release itself :P |
| 10:50:39 | <dkayiwa> suranga: first cause of problem was in config.xml, we had HL7QueryModuleActivator instead of HL7QueryActivator. Fixed that, though now getting another problem :) |
| 10:51:07 | <suranga> dkayiwa, I remmeber we change the module activator name manually :( |
| 10:51:12 | <dkayiwa> rafa: i wonder what kind of magic that will be :) |
| 10:53:13 | <rafa> dkayiwa: some say it's continues integration ;) |
| 10:53:45 | <dkayiwa> rafa: not continuous releasion (ing) :) |
| 10:53:51 | <rafa> dkayiwa: every commit and build is a release |
| 10:54:22 | <dkayiwa> rafa: without tests? (not the unit ones) :) |
| 10:55:40 | <rafa> dkayiwa: not by humans |
| 10:56:03 | <dkayiwa> rafa: that would be sweet!!! :) |
| 10:56:42 | <rafa> dkayiwa: we're still far away from that :( |
| 10:57:07 | <dkayiwa> rafa: but making some progress towards :) |
| 10:57:42 | <rafa> dkayiwa: yes! |
| 10:58:51 | <dkayiwa> suranga: do you want it to be called HL7QueryModule.hbm.xml or HL7Query.hbm.xml ? |
| 10:59:15 | <rafa> dkayiwa: push your fix for the activator please ;)\ |
| 10:59:18 | <suranga> dkayiwa, option two gets my fullest encouragement :) |
| 11:00:02 | <dkayiwa> rafa: there is another one which also does not making it work. fixing it now :) |
| 11:00:15 | <rafa> dkayiwa: oh ok |
| 11:00:23 | <rafa> dkayiwa: we'll see who is first ;) |
| 11:00:32 | <dkayiwa> rafa: hahahaha :D |
| 11:01:04 | *** upul` has quit IRC |
| 11:02:41 | <rafa> dkayiwa: Module loaded and started successfully on my side ;) |
| 11:02:52 | <dkayiwa> rafa: you beat me :D |
| 11:03:49 | *** kishoreyekkanti_ has joined #openmrs |
| 11:03:51 | <dkayiwa> rafa: so do i commit. or i let you commit? :) |
| 11:04:05 | <rafa> dkayiwa: you push |
| 11:04:18 | <rafa> dkayiwa: I have some error when pushing ;) |
| 11:04:27 | <dkayiwa> rafa: ok :) |
| 11:05:27 | <rafa> dkayiwa: I don't see you forked it |
| 11:05:58 | <dkayiwa> rafa: do i have to? :) |
| 11:06:13 | <rafa> dkayiwa: I think so |
| 11:06:25 | *** kishoreyekkanti has quit IRC |
| 11:06:32 | <dkayiwa> rafa: what is the disadvantage of not doing so? :) |
| 11:07:07 | <rafa> dkayiwa: no pull requests... |
| 11:07:33 | <dkayiwa> rafa: am not sure i understand that :) |
| 11:07:59 | <rafa> dkayiwa: each ticket = one topic branch |
| 11:08:09 | <rafa> dkayiwa: one topic branc = multiple commits |
| 11:08:27 | <rafa> dkayiwa: one topic branch = one pull request |
| 11:08:48 | <dkayiwa> rafa: that proves am so so much a newbie in this kind of stuff. :) |
| 11:08:53 | <rafa> dkayiwa: one pull request = ease of reviewing |
| 11:09:27 | <dkayiwa> rafa: whats the problem of just cloning https://github.com/OpenMRS/openmrs-module-hl7query, and the just committing? |
| 11:10:48 | <dkayiwa> rafa: please forgive me, am just trying to understand the reason for all that extra work/steps compared to svn :) |
| 11:11:07 | *** gede has joined #openmrs |
| 11:11:35 | <rafa> dkayiwa: have you seen pull requests? |
| 11:11:47 | <dkayiwa> rafa: no |
| 11:12:05 | <rafa> dkayiwa: it's a bunch of commits |
| 11:12:41 | <dkayiwa> rafa: isn't committing to https://github.com/OpenMRS/openmrs-module-hl7query also a bunch of commits ? :) |
| 11:12:42 | <OpenMRSBot> <http://ln-s.net/$Wry> (at github.com) |
| 11:12:59 | <rafa> dkayiwa: but you see them as separate commits |
| 11:13:18 | <rafa> dkayiwa: when you have a pull requests you see them as a bunch of related commits :) |
| 11:13:23 | <rafa> dkayiwa: it's easier to review |
| 11:13:49 | <dkayiwa> rafa: so the advantage is simply to relate commits? :) |
| 11:14:23 | <rafa> dkayiwa: yes, and have them applied all or none |
| 11:14:47 | <dkayiwa> rafa: ok. any other advantage? :) |
| 11:15:12 | <rafa> dkayiwa: you can have as many branches as you wish in your own fork |
| 11:15:23 | <dkayiwa> rafa: ok |
| 11:15:31 | <rafa> dkayiwa: every ticket can/should be a branch |
| 11:15:47 | <rafa> dkayiwa: later you'll notice that you can switch between branches |
| 11:16:04 | <dkayiwa> rafa: can i suggest that you take my blocker tickets as i get myself farmiliar with that process? :) |
| 11:16:32 | <rafa> dkayiwa: for instance when you finished some ticket and you sent a pull request |
| 11:16:35 | <dkayiwa> rafa: it will take me some time absorb that and commit in time enough to let you move on :) |
| 11:16:40 | <dkayiwa> rafa: ok |
| 11:16:41 | <rafa> dkayiwa: you can switch to a different branch and work on some other ticket |
| 11:16:55 | <rafa> dkayiwa: and when someone says you need to correct your pull request |
| 11:17:02 | <dkayiwa> rafa: ok |
| 11:17:20 | <rafa> dkayiwa: you just switch back to that branch and do the correction and send another pull request |
| 11:17:27 | <rafa> dkayiwa: does that make sense? |
| 11:17:28 | <dkayiwa> rafa: oh i see!!! |
| 11:18:00 | <dkayiwa> rafa: atleast more than before. will get a deeper understanding after i practically try it out :) |
| 11:18:30 | <rafa> dkayiwa: you'll like it :D |
| 11:19:05 | <rafa> dkayiwa: sure let me take over those blockers |
| 11:20:12 | <dkayiwa> rafa: thanks alot for taking them :) |
| 11:20:16 | *** dawn_ has joined #openmrs |
| 11:20:18 | *** ChanServ sets mode: +v dawn_ |
| 11:20:35 | *** james_regen has joined #openmrs |
| 11:20:36 | *** ChanServ sets mode: +v james_regen |
| 11:26:01 | *** applecool has joined #openmrs |
| 11:26:01 | *** ChanServ sets mode: +v applecool |
| 11:26:56 | *** applecool has quit IRC |
| 11:32:30 | <dkayiwa> rafa: by the way, i had already committed the other stuff to the master branch |
| 11:32:43 | <dkayiwa> rafa: am assuming that am using the correct language :) |
| 11:32:55 | <rafa> dkayiwa: committed, but not pushed right? |
| 11:33:14 | <dkayiwa> rafa: sorry i did not do the ticket per brach, etc steps |
| 11:33:31 | <dkayiwa> rafa: i committed and then pushed upstream :) |
| 11:34:09 | <dkayiwa> rafa: but i promise that am going to start doing those steps and be a good citizen :) |
| 11:34:20 | <rafa> dkayiwa: haha |
| 11:34:40 | <rafa> dkayiwa: I pushed that too ;) |
| 11:35:25 | <rafa> dkayiwa: git was clever enough not to complain about a conflict :D |
| 11:53:13 | *** bwolfe has joined #openmrs |
| 11:53:13 | *** ChanServ sets mode: +o bwolfe |
| 11:54:42 | <dkayiwa> rafa: hahahah :) |
| 11:56:53 | <bwolfe> kishoreyekkanti_, you back connected to the world again? |
| 12:04:46 | *** sgithens has joined #openmrs |
| 12:06:01 | *** magoo_ has quit IRC |
| 12:07:25 | <bwolfe> dkayiwa, are you working off of a fork or just the main checkout? |
| 12:07:40 | <dkayiwa> bwolfe: was workin off the main checkout |
| 12:08:06 | <dkayiwa> bwolfe: rafa advised me to do the other. so now am reading about it :) |
| 12:08:12 | <bwolfe> dkayiwa, great! |
| 12:08:26 | <kishoreyekkanti_> bwolfe: Hey Ben Yes |
| 12:08:33 | <bwolfe> yes, we should fork + branch + pull request + switch to main for everything. |
| 12:08:39 | <bwolfe> best practices ftw |
| 12:08:48 | <kishoreyekkanti_> bwolfe: I'm connected with the world now! |
| 12:09:00 | <kishoreyekkanti_> bwolfe: have we decided the way to go for github OpenMRS? |
| 12:09:23 | <bwolfe> kishoreyekkanti_, no one has put up a stink on the mailing list thread :-p |
| 12:09:32 | <bwolfe> did you see the jarless version was half the size? |
| 12:09:42 | <dkayiwa> kishoreyekkanti_: bwolfe looks like lots of extra steps. but not complaining now. let me first go through it all, may be it is then that i will practically realize the benefits :) |
| 12:10:33 | <bwolfe> yes, its a few extra steps. but those steps are supposed to save us from future pain. :-) |
| 12:10:46 | <kishoreyekkanti_> dkayiwa: bwolfe :) I came to know the shrinkage only after looking at Burke's mail. I guess my local git version is not gc'ed properly. It was showing 130 MB for me |
| 12:12:29 | <bwolfe> kishoreyekkanti_, just reclone it |
| 12:13:06 | <kishoreyekkanti_> kishoreyekkanti_: I've did that but haven't found that. |
| 12:13:20 | <kishoreyekkanti_> kishoreyekkanti_: have you tried the reclone and the checked the size? |
| 12:13:43 | <kishoreyekkanti_> bwolfe: Sorry the above two messages ar supposed for you ;) |
| 12:14:44 | <bwolfe> kishoreyekkanti_, yes, when I cloned the nojars one I it said it only downloaded 100mb |
| 12:14:54 | <kishoreyekkanti_> bwolfe: awesome thats cool |
| 12:14:59 | <bwolfe> are you looking at the clone output or just getting the folder size? |
| 12:18:06 | <suranga> hi bwolfe ! |
| 12:18:21 | <suranga> bwolfe, so far, i've managed to give away three tickets :) |
| 12:18:32 | <bwolfe> hi suranga |
| 12:18:34 | <bwolfe> what do you mean? |
| 12:18:55 | <suranga> rafa, dkayiwa and judygichoya all claimed tickets :) |
| 12:19:19 | <bwolfe> oh |
| 12:19:23 | <bwolfe> suranga, plan to give them all away :-p |
| 12:19:24 | <bwolfe> :-) |
| 12:19:41 | <bwolfe> but kudos to judygichoya for getting back into coding! |
| 12:19:50 | <suranga> bwolfe, im not much of a salesman , but i'll try :P |
| 12:23:17 | *** kishoreyekkanti_ has quit IRC |
| 12:28:12 | *** sgithens has quit IRC |
| 12:28:45 | <suranga> bwolfe, hapi doesnt need all the segments in order to parse properly,so i was thinking it would be good if we can create templates for a few segments (msh + PID maybe) and get the end to end workflow working as soon as possible ::) |
| 12:30:42 | *** wyclif has quit IRC |
| 12:30:43 | <bwolfe> suranga, ok, as soon as the controller is done thats possible |
| 12:40:07 | <judygichoya> ouch bwolfe.. |
| 12:40:33 | <judygichoya> just being a bit selfish…i need to send similar messages to the PACS server for the am path radiology truck |
| 12:41:03 | <judygichoya> so i picked tickets that deal with patient id and patient demographics ..which is what i will use... |
| 12:43:56 | <bwolfe> judygichoya, ah, right. |
| 12:44:08 | <bwolfe> will you be pushing messages out or will the "truck" be requesting them? |
| 12:44:49 | <judygichoya> initially we thought of having a demographics server in the dcm4chee |
| 12:45:10 | <judygichoya> actually we will bering this discussion to the design call when its clear.. |
| 12:45:53 | <judygichoya> now we are working that if the truck has a local instance of AMRS, with the patient demographics, a suer can select a patient and select the order... |
| 12:46:08 | <judygichoya> which in this case is just a chest Xray |
| 12:46:09 | *** kishoreyekkanti has joined #openmrs |
| 12:46:43 | *** kishoreyekkanti has joined #openmrs |
| 12:46:46 | <judygichoya> so the module(not sure if its enough content for one) sends a hl7 message with patient demographics and the order |
| 12:47:11 | *** downey has joined #openmrs |
| 12:47:11 | *** ChanServ sets mode: +o downey |
| 12:47:11 | *** OpenMRSBot sets mode: +o downey |
| 12:47:13 | <judygichoya> of course there is the question of dealing with patients that are not in the system... |
| 12:47:26 | <judygichoya> or non Ampath patients... |
| 12:48:30 | <bwolfe> so the truck is connected over 3g at all times? |
| 12:58:45 | <judygichoya> no.. |
| 12:58:47 | <judygichoya> no need.. |
| 12:59:19 | <judygichoya> cos both applications will eb on the truck..and synchronization will occur when the truck is back in eldoret.. |
| 12:59:39 | <judygichoya> the aim of this is to avoid re entering patient data which is a huge source of errors... |
| 12:59:52 | <judygichoya> maybe you have a different suggestion? |
| 13:01:03 | <bwolfe> judygichoya, so you will have two installations of openmrs? One with only partial (as needed) data and one with full data? |
| 13:01:23 | <judygichoya> only one with patient demographics... |
| 13:01:30 | <judygichoya> the rest is the pacs system... |
| 13:02:21 | <bwolfe> is jira being slow for anyone else? |
| 13:03:54 | <downey> bwolfe: not particularly |
| 13:09:36 | *** srinath has joined #openmrs |
| 13:09:43 | <srinath> hi guys |
| 13:10:10 | <srinath> anyone here?? |
| 13:12:35 | *** r0bby has joined #openmrs |
| 13:12:35 | *** ChanServ sets mode: +v r0bby |
| 13:16:34 | *** robbyoconnor has quit IRC |
| 13:19:05 | *** wyclif has joined #openmrs |
| 13:19:54 | *** deepaganu has joined #openmrs |
| 13:20:00 | <deepaganu> hi bwolfe |
| 13:20:45 | <deepaganu> can we capture family history in openmrs |
| 13:21:11 | <dkayiwa> srinath: when here, just ask what you want :) |
| 13:21:57 | <bwolfe> hi deepaganu |
| 13:21:57 | <deepaganu> dkayiwa, can we capture family history inopenmrs |
| 13:22:05 | <deepaganu> can we capture family history in openmrs |
| 13:22:07 | <deepaganu> basic`, |
| 13:22:10 | <deepaganu> bwolfe, |
| 13:22:13 | <bwolfe> I think family history is stored in obs like other data elements |
| 13:22:39 | <deepaganu> but we need to link it with person from the relationship table isnt it |
| 13:23:32 | *** gede has quit IRC |
| 13:23:34 | <deepaganu> we can create a form which can link the obs and relation ship together |
| 13:25:01 | <deepaganu> but there is no direct way to capture the family history other than the form entry bwolfe |
| 13:25:09 | *** gede has joined #openmrs |
| 13:25:15 | <downey> Hi gede and welcome to the #openmrs IRC channel. |
| 13:25:31 | *** maurya has joined #openmrs |
| 13:25:57 | <bwolfe> deepaganu, maybe I'm not understanding "family history" |
| 13:26:09 | <bwolfe> do you want to capture the parents/children of patients? |
| 13:26:19 | <bwolfe> or do you want to capture data points that happened to those people? |
| 13:26:35 | <deepaganu> want to capture the diagnosis of the parents/children of the patient |
| 13:26:40 | <bwolfe> or do you just want a "history of: cancer, history of: high blood pressure", etc |
| 13:26:51 | <deepaganu> yes the second option |
| 13:27:11 | <deepaganu> history of bp in relationship of the patient |
| 13:27:37 | <deepaganu> is the family histroy termed as in most of the intake forms , isn'it |
| 13:27:39 | <deepaganu> bwolfe, |
| 13:28:29 | <deepaganu> maybe i can do patient.getRelationship() , pass this list to the observation service to get any obs |
| 13:28:31 | <deepaganu> bwolfe, |
| 13:28:52 | <bwolfe> hmm, ok, thats new. how are you going to use those? will you be doing reports on patients and querying all their relationships to get the history? |
| 13:28:52 | <bwolfe> most modeling I've seen uses a "history of" obs with answers of the diseases that their family has had in the past |
| 13:29:35 | <deepaganu> yes thats what i want bwolfe |
| 13:29:48 | <bwolfe> sorry, I don't follow, which is what you want? |
| 13:30:00 | <deepaganu> history of obs with answers of the diseases that their family had in the past |
| 13:30:49 | <deepaganu> bwolfe, |
| 13:32:25 | <deepaganu> history of obs with answers of the diseases that their family had in the past |
| 13:32:27 | <deepaganu> bwolfe, |
| 13:32:35 | <bwolfe> ok, then you don't need to create relationships. :-) |
| 13:32:35 | <bwolfe> its a simple question with 0-to-n answers |
| 13:32:36 | <bwolfe> deepaganu, standard disclaimer: I haven't done any kind of complex modeling. I just write hte code that others use to make complex modeling. If you want confirmation, you can write to the implementers mailing list with your idea and ask them to validate it. (if we don't have a wiki page about HistoryOf in the concept section, can you add it with your new-found knowledge?) |
| 13:32:37 | <bwolfe> deepaganu ^^ |
| 13:34:20 | <suranga> hi rafa |
| 13:34:26 | <rafa> suranga: yes? |
| 13:34:33 | <suranga> rafa, you are doing the pull requets too, isnt it ? |
| 13:34:36 | *** Maurya_ has joined #openmrs |
| 13:34:42 | <suranga> or are you waiting for me ? :) |
| 13:34:51 | <rafa> suranga: you mean merging pull requests? |
| 13:34:55 | <rafa> suranga: yes, I do merge them. |
| 13:35:03 | <suranga> rafa, cool.. :) |
| 13:35:18 | <rafa> suranga: but you need to review them ;) |
| 13:35:29 | <deepaganu> bwolfe, i need to export Family History (AKA History of family member diseases) section - problems of genetic relatives, so i would be using the patient service abd observation service together to get this data .Am i on the right track ?? |
| 13:35:55 | <rafa> suranga: not necessarily now, but at some point ;) |
| 13:36:10 | <suranga> rafa, sure, I understand :) |
| 13:37:42 | <deepaganu> bwolfe, i need to export Family History (AKA History of family member diseases) section - problems of genetic relatives, so i would be using the patient service abd observation service together to get this data .Am i on the right track ?? |
| 13:37:43 | *** maurya has quit IRC |
| 13:38:04 | <bwolfe> deepaganu, yeah. if you are going through the api, yes. are you not using formentry/htmlformentry/xforms? |
| 13:38:18 | <deepaganu> no i am not bwolfe |
| 13:38:30 | <deepaganu> Plan of Care (AKA Treatment plan) section - active, incomplete, or pending orders, appointments, referrals, procedures or services |
| 13:38:30 | <bwolfe> ok |
| 13:38:46 | <deepaganu> i need to even export the plan of care from openmrs |
| 13:38:59 | <deepaganu> does it mean the programs in openmrs bwolfe |
| 13:42:00 | <srinath> i am new and i want to help |
| 13:42:15 | <srinath> i have no idea where to begin |
| 13:42:36 | <deepaganu> Plan of Care (AKA Treatment plan) section - active, incomplete, or pending orders, appointments, referrals, procedures or services out of all these we support only orders , right |
| 13:42:58 | <deepaganu> how do we capture referrals , procedures or services ?? bwolfe |
| 13:43:33 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @hic_2012: OpenMRS (open source) got "antique" mobiles reporting real time TB data in Karachi. Traditional commercialism is a bottlen ... <http://twitter.com/OpenMRS/statuses/229929395140300802> |
| 13:45:13 | *** djazayeri has joined #openmrs |
| 13:45:13 | *** ChanServ sets mode: +o djazayeri |
| 13:45:53 | <dkayiwa> hi suranga |
| 13:45:57 | <djazayeri> Bwolfe you there? |
| 13:46:00 | <deepaganu> how do we capture referrals eg: Referral to: EYE CLINIC |
| 13:46:06 | <deepaganu> bwolfe, |
| 13:46:07 | <suranga> dkayiwa, helooo |
| 13:46:35 | <dkayiwa> suranga: the getXML() at HLQRY-29 Is that a method am supposed to create? :) |
| 13:46:42 | <deepaganu> dkayiwa, do you have any idea how do we capture referral madeby a user eg:Referral to: EYE CLINIC |
| 13:47:02 | <suranga> dkayiwa, hang on, need to refresh memory |
| 13:47:05 | <bwolfe> djazayeri, yep |
| 13:47:09 | <dkayiwa> suranga: ok :) |
| 13:47:18 | <djazayeri> Referrals are not currently handled in the data model. You have to represent them as observations in a custom made for each implementation. |
| 13:47:31 | <dkayiwa> deepaganu: how about creating it as an obs? |
| 13:47:53 | <deepaganu> ok djazayeri |
| 13:48:14 | <deepaganu> and can we schedule an appointment for a patient |
| 13:48:18 | <deepaganu> in openmr s |
| 13:48:20 | *** skathol has joined #openmrs |
| 13:48:21 | <djazayeri> Then, I will not be online for the scrum. Here's my report: |
| 13:48:25 | <srinath> sure |
| 13:48:27 | <djazayeri> Ben |
| 13:48:43 | <suranga> djazayeri, thats affermative, you will have to :) |
| 13:48:47 | <srinath> guys i'm new and i want to contribute |
| 13:48:55 | <srinath> where do i start |
| 13:49:05 | <djazayeri> Did hlqry9. |
| 13:49:09 | <deepaganu> and can we schedule an appointment for a patient using encounters djazayeri |
| 13:49:22 | <deepaganu> srinath, you can start with solving tickets |
| 13:49:29 | <bwolfe> srinath, great! |
| 13:49:31 | <djazayeri> Otherwise itech stuff |
| 13:49:46 | <srinath> i know hibernate |
| 13:49:51 | <bwolfe> srinath, I think I sent the getting started for developers link last week, was that helpful? |
| 13:49:58 | <srinath> any place i can help?? |
| 13:50:00 | <dkayiwa> https://wiki.openmrs.org/display/docs/Getting+Started+as+a+Developer |
| 13:50:01 | <OpenMRSBot> <http://ln-s.net/8bkO> (at wiki.openmrs.org) |
| 13:50:34 | <djazayeri> Appointments are also not handled directly in the data model. Typically people use an observation for the concept |
| 13:50:34 | <djazayeri> Next visit date |
| 13:50:40 | *** harshadura has quit IRC |
| 13:50:59 | <srinath> ya |
| 13:51:03 | <deepaganu> but visit would be a collection of encounters isnt'it djazayeri |
| 13:51:17 | <srinath> i forked the code and have deployed it in eclipse |
| 13:52:48 | <deepaganu> djazayeri, would the next visit date would always be the scheduled appointement |
| 13:53:40 | *** shortend has quit IRC |
| 13:54:05 | *** pushkar has joined #openmrs |
| 13:57:20 | *** deepaganu has quit IRC |
| 13:57:39 | <djazayeri> Deepaganu: typically people would create a concept with a name like return visit date, or scheduled visit date. However they want to model it. Point being that there is no standard way |
| 13:58:11 | <dkayiwa> srinath: do you see any ticket you can attempt to do? |
| 13:58:23 | *** lakkarau has joined #openmrs |
| 13:58:36 | <djazayeri> Deepaganu: it is not correct, and probably not allowed, to create an encounter in the future and use that to represent a scheduled appointment |
| 13:59:19 | <djazayeri> Doh, after typing all that on my phone, no longer online |
| 13:59:35 | *** cpower has joined #openmrs |
| 13:59:55 | <djazayeri> If Deepaganu shows up again, point out my messages please |
| 14:00:00 | <djazayeri> Gotta run |
| 14:00:30 | *** djazayeri has quit IRC |
| 14:01:31 | <cpower> Hello everyone! |
| 14:02:16 | *** jordank has joined #openmrs |
| 14:02:18 | *** pushkar_ has joined #openmrs |
| 14:02:21 | <cpower> I love the smell of a new sprint starting.. |
| 14:02:52 | <downey> is that what that was? i thought it was just bwolfe. |
| 14:03:01 | <cpower> Jira tickets getting commented on, questions abound, new names and skill sets.. |
| 14:03:08 | <cpower> hahahaha |
| 14:03:22 | <cpower> Let's Scrum and see if the air clears. |
| 14:03:31 | <cpower> Then we will know the truth |
| 14:03:35 | <suranga> cpower, heloo |
| 14:03:40 | <cpower> !scrumon cpower |
| 14:03:41 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 14:05:13 | <cpower> Order: judy Wawira (sorry don't know your nick), djazayeri, lakkarau, wyclif, rafa, bwolfe, dkayiwa, suranga |
| 14:05:27 | <bwolfe> downey, cpower, thats a nice sweet smell, so thank you. ;-) |
| 14:05:37 | <suranga> judygichoya, == judy |
| 14:05:37 | <cpower> We are missing jkeiper.... |
| 14:05:39 | <bwolfe> judy wawira == judygichoya |
| 14:05:42 | <skathol> cpower: I'd like to participate as well |
| 14:05:51 | *** pushkar has quit IRC |
| 14:06:01 | <cpower> no problem at all you can wrap up the end skathol |
| 14:06:11 | <bwolfe> skathol, add your name ot the wiki page this week. :-) |
| 14:06:16 | *** jkeiper_ has joined #openmrs |
| 14:06:26 | <jkeiper_> hi |
| 14:06:29 | <bwolfe> skathol, https://wiki.openmrs.org/display/RES/Export+of+HL7+Messages+Sprint |
| 14:06:32 | <cpower> there is is, our new last is Jkeiper |
| 14:06:42 | <skathol> bwolfe: thanks will do |
| 14:06:49 | <cpower> Judygichoya you are up! |
| 14:07:06 | <judygichoya> well not sure what to say... |
| 14:07:13 | <bwolfe> judygichoya, can you report on what you've done, what you will do, and any blockers |
| 14:07:21 | <judygichoya> but i am working on 2 related tickets |
| 14:07:25 | <judygichoya> 27 and 28.. |
| 14:07:41 | <judygichoya> which basically generate the PID subtemplates |
| 14:07:43 | <bwolfe> cpower, its better to put new sprinters/scrummers last! :-) |
| 14:07:49 | <judygichoya> yes... |
| 14:07:55 | <judygichoya> will go last... |
| 14:07:59 | <bwolfe> !ticket hlqry-27 |
| 14:08:00 | <OpenMRSBot> bwolfe: [#HLQRY-27] Create a DefaultPatientIdentifier template to be called via the PID message segment - OpenMRS JIRA - https://tickets.openmrs.org/browse/hlqry-27 |
| 14:08:04 | <bwolfe> !ticket hlqry-28 |
| 14:08:05 | <OpenMRSBot> bwolfe: [#HLQRY-28] Create a DefaultPatientName template to be called via the PID message segment - OpenMRS JIRA - https://tickets.openmrs.org/browse/hlqry-28 |
| 14:08:08 | <cpower> yeah, didn't know she was new...so let's do that judy now goes last. |
| 14:08:15 | <cpower> Next! |
| 14:08:16 | <judygichoya> ok |
| 14:08:28 | <cpower> djazayeri if you are there show us how it's done |
| 14:08:38 | <bwolfe> darius is out |
| 14:08:43 | <cpower> of course |
| 14:08:46 | <bwolfe> he gave his report already |
| 14:08:58 | <bwolfe> (wasn't much, mostly just itech) |
| 14:09:00 | <cpower> Lakkarau please tell me your there and can go |
| 14:09:07 | <lakkarau> Monday: |
| 14:09:07 | <lakkarau> HLQRY-30 |
| 14:09:07 | <lakkarau> HLQRY-26 |
| 14:09:07 | <lakkarau> should make some minor changes to the patch attached for the issue:Trunk-3491 |
| 14:09:07 | <lakkarau> Group meeting |
| 14:09:21 | <lakkarau> noblockers |
| 14:09:29 | <cpower> and that's how it's done |
| 14:09:32 | <cpower> Next! |
| 14:09:36 | <wyclif> Friday: |
| 14:09:36 | <wyclif> curate tickets |
| 14:09:36 | <wyclif> weekly skype call with Dmitry |
| 14:09:36 | <wyclif> Monday: |
| 14:09:36 | <wyclif> HLQRY-11 - Create a 'Manage Templates' admin page for the hl7query table |
| 14:09:36 | <wyclif> HLQRY-8 - Create a controller class to get encounters in orur01 hl7 format |
| 14:09:38 | <wyclif> pick another sprint ticket |
| 14:09:40 | <wyclif> Blockers: None |
| 14:09:50 | <cpower> Next! |
| 14:10:01 | <jkeiper_> (let me know when "Next" = me) |
| 14:10:05 | <cpower> Rafa...hi |
| 14:10:06 | <rafa> Today: |
| 14:10:06 | <rafa> * Reviewed TRUNK-3491: Write to independent log file |
| 14:10:07 | <rafa> https://tickets.openmrs.org/browse/TRUNK-3491 |
| 14:10:07 | <rafa> * Committed: |
| 14:10:07 | <rafa> + HLQRY-33: Module does not start |
| 14:10:07 | <rafa> https://tickets.openmrs.org/browse/HLQRY-33 |
| 14:10:07 | <rafa> + HLQRY-10: Create a dabatase table to persist the groovy templates |
| 14:10:07 | <cpower> go |
| 14:10:08 | <rafa> https://tickets.openmrs.org/browse/HLQRY-10 |
| 14:10:08 | <rafa> * Working on HLQRY-22: Create Template pojo class |
| 14:10:09 | <rafa> https://tickets.openmrs.org/browse/HLQRY-22 |
| 14:10:09 | <rafa> No blockers. |
| 14:10:21 | <cpower> Next! bwolfe |
| 14:10:43 | *** jriley has joined #openmrs |
| 14:11:16 | *** deepaganu has joined #openmrs |
| 14:11:28 | <bwolfe> (sorry was on phone) |
| 14:11:33 | <bwolfe> Friday |
| 14:11:34 | <bwolfe> update obs/value group wiki pages |
| 14:11:34 | <bwolfe> review tickets for hl7 query module sprint next week |
| 14:11:34 | <bwolfe> emails |
| 14:11:34 | <bwolfe> review curations |
| 14:11:34 | <bwolfe> investigate FORM-104 |
| 14:11:36 | <bwolfe> call with easycloud |
| 14:11:38 | <bwolfe> review wiki pages for next sprint |
| 14:11:40 | <bwolfe> Monday |
| 14:11:42 | <bwolfe> review hl7 query sprint tickets |
| 14:11:44 | <bwolfe> emails |
| 14:11:46 | <bwolfe> review RESTWS-272, includeall in restws |
| 14:12:03 | <bwolfe> no blockers |
| 14:12:11 | <cpower> Next! dkayiwa |
| 14:12:12 | <dkayiwa> Read design page for the module |
| 14:12:12 | <dkayiwa> Made a commit about making the module load and run when installed. |
| 14:12:12 | <dkayiwa> Spent sometime familiarizing myself with this new git stuff (fork, branch, pull, etc) |
| 14:12:13 | <dkayiwa> Blocked on: Create service method to convert xml to hapi - HLQRY-29 |
| 14:12:13 | <dkayiwa> Now switched to: Create a groovy template to create the OBR segment of an ORUR01 message - HLQRY-21 |
| 14:12:35 | <jkeiper_> dkayiwa: jealous! |
| 14:12:45 | <cpower> Next! suranga |
| 14:12:51 | <dkayiwa> jkeiper_: of???? :) |
| 14:12:55 | <suranga> hi all |
| 14:12:57 | <suranga> DID : |
| 14:12:58 | <suranga> general administration (fixing things I had overlooked earlier) |
| 14:12:58 | <suranga> pointing people to the best tickets to work on for now... |
| 14:12:58 | <suranga> To Do's today: |
| 14:12:58 | <suranga> Review pull requests |
| 14:12:58 | <suranga> To' Do's in the immidiate future : |
| 14:13:00 | <suranga> try to get a basic end to end request working |
| 14:13:02 | <suranga> Question : are you devs claiming one ticket at a time ? (claim -> finish -> commit, and then pick a new ticket ?) |
| 14:13:02 | <dkayiwa> jkeiper_: your ticket :) |
| 14:13:06 | <jkeiper_> ;-) |
| 14:13:34 | <cpower> Next! skathol |
| 14:13:47 | <skathol> done: |
| 14:13:49 | <skathol> * Brief review of sprint tickets |
| 14:13:51 | <skathol> * HLQRY-29 Create service method to convert xml to hapi |
| 14:13:52 | <skathol> - Sounds interesting, but I expect distractions and don't want to block other work |
| 14:13:53 | <skathol> * A Groovy Template ticket |
| 14:13:55 | <skathol> - Sounds more modular and unlikely to affect other work, but I'm new to Groovy |
| 14:13:56 | <skathol> will do: |
| 14:13:58 | <skathol> * Choose a ticket |
| 14:13:59 | <skathol> * Download and review module code |
| 14:14:01 | <skathol> blockers: Need guidance on appropriate ticket(s) to start with |
| 14:14:24 | <cpower> Next! jkeiper |
| 14:14:29 | <jkeiper_> Since last scrum: |
| 14:14:29 | <jkeiper_> - lots of AMPATH-related project management work |
| 14:14:29 | <jkeiper_> Until next scrum: |
| 14:14:29 | <jkeiper_> - more AMPATH-related project management |
| 14:14:29 | <jkeiper_> - concept proposal tickets |
| 14:14:30 | <jkeiper_> - TRUNK-3591 |
| 14:14:32 | <jkeiper_> - TRUNK-3592 |
| 14:14:34 | <jkeiper_> - TRUNK-3593 |
| 14:14:36 | <jkeiper_> Blockers: |
| 14:14:38 | <jkeiper_> - none |
| 14:14:41 | <cpower> Next! judygichoya |
| 14:14:52 | <judygichoya> working on 27 /28.. |
| 14:15:12 | <judygichoya> calling on rest using groovy to get the segments then writing an xml builder |
| 14:15:30 | <judygichoya> which will then be saved as a change set to the hl7query template |
| 14:15:52 | <judygichoya> i had a problem locating the git for the module ..and understanding where to save the xml.. |
| 14:16:04 | <judygichoya> but feel ok to work on these two..pretty related... |
| 14:16:12 | <judygichoya> tonight getting the rest calls working |
| 14:16:16 | <judygichoya> done! |
| 14:16:34 | <cpower> Anything you want help with (ie blockers) |
| 14:17:08 | <judygichoya> waiting on dkayiwa to give a sample on the change set to do the final write |
| 14:17:12 | <judygichoya> to the database |
| 14:17:27 | <cpower> Ok, I miss anyone? |
| 14:17:39 | <cpower> Dawn you wanna give an update? |
| 14:17:45 | <cpower> ;-) |
| 14:18:07 | <cpower> Lots of discussion points/Blockers |
| 14:18:14 | <suranga> :) |
| 14:18:55 | <jkeiper_> dkayiwa, liked your groovy ticket ... hope you enjoy it. |
| 14:20:08 | <suranga> discussion points are : 1) skathol , what can we find for you to start work on. 2) dkayiwa 's blocker, right ? :) |
| 14:20:52 | <skathol> Sounds like the xml->hapi service is taken... I could start on the PV1 Groovy template |
| 14:21:07 | <cpower> skathol: Add your name to the wiki, and help on what's a good ticket to start with (bwolfe) dkayiwa needs help on HLQRY-29, Suranga has a Question: dev's claiming one ticket at a time? |
| 14:21:47 | <cpower> and Judy is waiting on dkayiwa for a same on the change set. |
| 14:22:07 | <suranga> hi skathol , are you conformtable with groovy ? |
| 14:22:17 | <suranga> skathol, want to dive right in ?: ) |
| 14:22:27 | <cpower> and that's how we we play our game. |
| 14:22:30 | <cpower> !scrumoff |
| 14:22:30 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 14:22:37 | *** lakkarau has quit IRC |
| 14:23:00 | <suranga> skathol, you can add your name here :https://wiki.openmrs.org/display/RES/Export+of+HL7+Messages+Sprint |
| 14:23:01 | <skathol> not really comfortable with groovy, but this may be a good time to learn |
| 14:23:24 | <suranga> skathol, I see |
| 14:24:10 | <suranga> skathol, how about the MSH segment ticket ? that might be easier groovyscript coding in that |
| 14:24:58 | <skathol> just added my name to the wiki, i'd be happy to start with MSH |
| 14:25:52 | <downey> skathol++ |
| 14:26:14 | <suranga> bwolfe, downey look, we got another one. Now he's ours for life ! :) |
| 14:26:39 | <skathol> :) |
| 14:26:45 | <dkayiwa> jkeiper_: i can give it to you if they unblock me :) |
| 14:27:05 | <dkayiwa> on some other ticket |
| 14:28:35 | <jkeiper_> dkayiwa, haha ... i've got my hands full with concept proposals |
| 14:28:39 | <bwolfe> judygichoya, you said you were doing rest calls. what is htat about? |
| 14:28:42 | <jkeiper_> but i do love groovy |
| 14:28:57 | <dkayiwa> jkeiper_: more than her? :) |
| 14:29:11 | <rafa> suranga: we have an entity named Template in core |
| 14:29:32 | <rafa> suranga: it's problematic to use the same one in the module |
| 14:29:47 | <jriley> downeym , when I look at jordank 's project to do a code review, it shows my old reviews were done by jriley_old . I take it this part of the svn -> git migration, right? Should jordank just start a new crucible review and add mcallumg and me as reviewers? |
| 14:29:51 | <rafa> suranga: I need to declare entity-name="HL7QueryTemplate" |
| 14:30:29 | <suranga> rafa, sorry, are you refering to a model class named 'Template' ? |
| 14:30:48 | <rafa> suranga: and then use session.get("HL7QueryTemplate", id) instead session.get(Template.class, id) |
| 14:30:50 | <rafa> suranga: yes |
| 14:30:53 | <bwolfe> suranga, rafa, perhaps we should just rename it then? less technical hiccups that way |
| 14:31:05 | <jkeiper_> dkayiwa, hahaha it's a close call |
| 14:31:06 | *** Maurya_ has quit IRC |
| 14:31:13 | <suranga> bwolfe, rafa ORUR01Template ? |
| 14:31:18 | <dkayiwa> jkeiper_: :D |
| 14:31:24 | <jriley> downeym , the source page is at https://source.openmrs.org/browse/Modules/mergeconcepts if you'd like to see the fun |
| 14:31:25 | *** Maurya_ has joined #openmrs |
| 14:31:27 | <bwolfe> suranga, no! |
| 14:31:32 | <bwolfe> suranga, hl7template |
| 14:31:36 | <suranga> or maybe hl7template? |
| 14:31:40 | <bwolfe> or hl7querytemplate |
| 14:31:47 | <bwolfe> suranga, there you go. :-) |
| 14:31:56 | <suranga> bwolfe, I like the last choice best |
| 14:32:12 | <rafa> suranga: HL7QueryTemplate? |
| 14:32:41 | <suranga> bwolfe, if we call it orur01 template, we will have to create a new clas for every different message tipe :-D |
| 14:33:02 | <bwolfe> right |
| 14:33:03 | <suranga> rafa, i think that one is best. besides, it came from bwolfe :) |
| 14:33:05 | <bwolfe> that would be terrible |
| 14:33:31 | <bwolfe> suranga, up to you for choice between hl7template and hl7querytemplate. both are fine by me |
| 14:33:35 | <jordank> hi jriley, hi downey ^ |
| 14:34:04 | <suranga> rafa, does the template class contain any information thats related to a requeest ? |
| 14:34:15 | <jriley> Oops - downey , I directed my comments to downeym. Re-paste: when I look at jordank 's project to do a code review, it shows my old reviews were done by jriley_old . I take it this part of the svn -> git migration, right? Should jordank just start a new crucible review and add mcallumg and me as reviewers? |
| 14:34:21 | <rafa> suranga: request? |
| 14:34:26 | <rafa> suranga: you mean http request? |
| 14:34:41 | <judygichoya> bwolfe for the Patient name ticket |
| 14:34:54 | <suranga> rafa, yes, I dont think the template has any information related to who made the request at all, right ? |
| 14:35:01 | <judygichoya> do i just reference thedatabase.. for patient.getFamilyName() |
| 14:35:05 | <rafa> suranga: right |
| 14:35:13 | <judygichoya> versus going via RESTws? |
| 14:35:26 | <suranga> rafa, then lets go with hl7template. its also approved by ben |
| 14:35:40 | <rafa> suranga: fine |
| 14:36:03 | <bwolfe> judygichoya, yes. use groovy to access the api/database |
| 14:36:05 | <suranga> !ticket hlqry-27 |
| 14:36:06 | <OpenMRSBot> suranga: [#HLQRY-27] Create a DefaultPatientIdentifier template to be called via the PID message segment - OpenMRS JIRA - https://tickets.openmrs.org/browse/hlqry-27 |
| 14:36:28 | <judygichoya> ok.. that makes it even easier... |
| 14:36:29 | <bwolfe> the template groovy code can assume a "patient" object was passed in |
| 14:36:45 | *** kishoreyekkanti_ has joined #openmrs |
| 14:40:18 | *** kishoreyekkanti has quit IRC |
| 14:40:21 | *** djazayeri has joined #openmrs |
| 14:40:21 | *** ChanServ sets mode: +o djazayeri |
| 14:40:55 | *** skathol has quit IRC |
| 14:41:07 | *** Maurya_ is now known as maurya |
| 14:41:23 | *** ChanServ sets mode: +v maurya |
| 14:46:09 | *** deepaganu has quit IRC |
| 14:46:13 | <jordank> jriley: I can't start a new crucible review because when I go through the repository to "Add Content to Review" the folders seem empty |
| 14:46:38 | *** deepaganu has joined #openmrs |
| 14:50:20 | *** suranga has quit IRC |
| 14:51:47 | *** dawn_ has quit IRC |
| 14:53:39 | *** lhawthor_ has joined #openmrs |
| 14:54:02 | *** lhawthor_ is now known as lh |
| 14:54:12 | *** lh has joined #openmrs |
| 14:55:39 | <bwolfe> rafa, dkayiwa: make sure you are doing a git pull often to get the latest and merge it in |
| 14:55:47 | <bwolfe> do we have that step described somewhere? |
| 14:56:01 | <bwolfe> or what the proper way to get it is? |
| 14:56:15 | *** srinath has quit IRC |
| 14:56:15 | <bwolfe> oh, and wyclif^^ |
| 14:56:34 | <bwolfe> do you pull to your master clone, then somehow merge to your branches? |
| 14:58:01 | *** ABHISHEK__ has joined #openmrs |
| 14:59:19 | *** cpower has quit IRC |
| 14:59:56 | <dkayiwa> bwolfe: ok |
| 15:00:11 | *** deepaganu has quit IRC |
| 15:01:19 | <rafa> dkayiwa: like now is a good moment :) |
| 15:01:31 | <rafa> dkayiwa: I've just renamed Template to HL7Template |
| 15:01:50 | <rafa> wyclif: |
| 15:01:51 | <bwolfe> rafa, what are the proper steps? |
| 15:01:52 | <dkayiwa> :D |
| 15:01:52 | <bwolfe> can you list them? |
| 15:02:00 | <wyclif> hi rafa |
| 15:02:13 | <rafa> wyclif: hi |
| 15:02:28 | *** applecool has joined #openmrs |
| 15:02:39 | <wyclif> i was responding to you, rafa sorry i was away from my laptop |
| 15:02:40 | <rafa> wyclif: just notifying that you should pull now :) |
| 15:02:49 | *** ChanServ sets mode: +v applecool |
| 15:02:55 | <wyclif> from the hl7query module? |
| 15:03:05 | <rafa> wyclif: yes, if you're working on that |
| 15:03:07 | <wyclif> rafa, master |
| 15:03:20 | <wyclif> rafa, cool, thanks for the thumbs up |
| 15:03:21 | <rafa> wyclif: I've just pushed significant changes |
| 15:04:05 | <rafa> bwolfe: I just do pull before I pick up a new ticket and before I commit |
| 15:04:18 | <rafa> bwolfe: pull often :) |
| 15:04:48 | <rafa> bwolfe: some have a cron job doing that ;) |
| 15:04:49 | <bwolfe> rafa, but what if you have a branch you are working on? |
| 15:04:59 | <bwolfe> (assuming that everyone is doing the proper thing of working on a branch) |
| 15:05:10 | <bwolfe> a branch in git is super easy to create and switch to/from |
| 15:05:21 | <rafa> bwolfe: I just 'git pull upstream master' in a branch |
| 15:07:14 | <rafa> bwolfe: ohh and I don't merge back my branches to my master |
| 15:07:33 | <rafa> bwolfe: my master is always what is in upstream master |
| 15:07:40 | <bwolfe> rafa, so when you have your branch "checked out", you do the git pull there. interesting |
| 15:08:02 | <bwolfe> then you do a "pull request" on your branch |
| 15:08:22 | <bwolfe> if you do "git pull upstream master" in a branch, then do "git checkout master", do you have to do "git pull upstream master" again? |
| 15:08:22 | <rafa> bwolfe: yes pull request from my branch to upstream master |
| 15:08:26 | <bwolfe> (I assume yes) |
| 15:08:38 | <rafa> bwolfe: yes |
| 15:12:16 | <wyclif> rafa, dkayiwa djazayeri are we pushing to a branch or our folks and send pull requests for this sprint? |
| 15:13:46 | <rafa> wyclif: you are only allowed to push to your fork |
| 15:13:47 | *** maurya has quit IRC |
| 15:14:11 | <wyclif> rafa, ok |
| 15:14:18 | *** maurya has joined #openmrs |
| 15:14:52 | <rafa> wyclif: you push a branch to your fork and then send pull request to OpenMRS/openmrs-module-hl7query master |
| 15:15:28 | <rafa> wyclif: and you can merge your pull request without waiting for suranga to review |
| 15:16:05 | <wyclif> rafa, ok thanks |
| 15:20:40 | <bwolfe> dkayiwa ^^ |
| 15:23:08 | <dkayiwa> bwolfe: ??? |
| 15:23:24 | <bwolfe> dkayiwa, that means "read the above" |
| 15:23:31 | <bwolfe> gotta get food, bbl |
| 15:23:44 | <dkayiwa> bwolfe: ok |
| 15:25:57 | <rafa> bwolfe: wyclif dkayiwa djazayeri |
| 15:25:57 | <rafa> my workflow: |
| 15:25:57 | <rafa> pick up a ticket HLQRY-22 |
| 15:25:57 | <rafa> git checkout master |
| 15:25:57 | <rafa> git pull upstream master |
| 15:25:58 | <rafa> git branch HLQRY-22 //now branch is only on my pc |
| 15:25:58 | <rafa> git checkout HLQRY-22 |
| 15:25:59 | <rafa> git push origin HLQRY-22 //now branch is on github/rkorytkowski |
| 15:25:59 | <rafa> //do some work |
| 15:26:00 | <rafa> git add -A |
| 15:26:00 | <rafa> git commit -m "Some work: HLQRY-22" |
| 15:26:01 | <rafa> git push |
| 15:26:01 | <rafa> //do more work |
| 15:26:02 | <rafa> git pull upstream master //do often to work on the latest |
| 15:26:02 | <rafa> git add -A |
| 15:26:03 | <rafa> git commit -m "More work: HLQRY-22" |
| 15:26:03 | <rafa> git push |
| 15:26:04 | <rafa> //no more work, go to github send pull request from the HLQRY-22 branch to OpenMRS/master |
| 15:26:04 | <rafa> //merge pull request on github |
| 15:26:05 | <rafa> git checkout master |
| 15:26:05 | <rafa> git pull upstream master |
| 15:26:45 | <rafa> and so on... |
| 15:28:03 | <dkayiwa> rafa: i wish the steps were as few as in svn :) |
| 15:29:44 | <rafa> dkayiwa: well I could live without half of them, but it seems to be what we decided |
| 15:30:45 | <dkayiwa> rafa: if you were the sole decision maker, would you remove some of these steps? :) |
| 15:33:16 | <rafa> dkayiwa: hmm yes, I wouldn't fork |
| 15:33:27 | <dkayiwa> rafa: :D |
| 15:33:29 | <rafa> dkayiwa: it would look like: |
| 15:33:30 | *** deepaganu has joined #openmrs |
| 15:33:31 | <rafa> my workflow (without forking): |
| 15:33:32 | <rafa> pick up a ticket HLQRY-22 |
| 15:33:32 | <rafa> git checkout master |
| 15:33:32 | <rafa> git pull |
| 15:33:32 | <rafa> git branch HLQRY-22 //now branch is only on my pc and it stays here |
| 15:33:32 | <rafa> git checkout HLQRY-22 |
| 15:33:33 | <rafa> //do some work |
| 15:33:33 | <rafa> git add -A |
| 15:33:34 | <rafa> git commit -m "Some work: HLQRY-22" |
| 15:33:34 | <rafa> //do more work |
| 15:33:35 | <rafa> git pull //do often to work on the latest |
| 15:33:35 | <rafa> git add -A |
| 15:33:36 | <rafa> git commit -m "More work: HLQRY-22" |
| 15:33:36 | <rafa> //no more work, let's merge the branch |
| 15:33:37 | <rafa> git checkout master |
| 15:33:37 | <rafa> git merge HLQRY-22 |
| 15:33:38 | <rafa> git push |
| 15:33:53 | <dkayiwa> rafa: oh i see :) |
| 15:35:27 | <dkayiwa> rafa: git pull //do often to work on the latest (do it do this on my ticket branch?) |
| 15:35:36 | <dkayiwa> it = i |
| 15:35:46 | <rafa> dkayiwa: yes |
| 15:35:47 | *** ABHISHEK__ has quit IRC |
| 15:36:21 | <dkayiwa> rafa: in eclipse is that Team -> Pull ? |
| 15:36:39 | <rafa> dkayiwa: yes |
| 15:37:23 | <rafa> dkayiwa: but you can't use Team -> Pull if you work on a fork |
| 15:37:27 | *** ABHISHEK__ has joined #openmrs |
| 15:37:32 | <rafa> dkayiwa: it will only pull from your fork |
| 15:37:35 | <dkayiwa> rafa: The current branch is not configured for pull |
| 15:37:36 | <dkayiwa> No value for key branch.HLQRY-29.merge found in configuration |
| 15:37:36 | <rafa> dkayiwa: not from the upstream |
| 15:37:49 | <dkayiwa> rafa: i sensed that too |
| 15:37:51 | <rafa> dkayiwa: yeah that's why :) |
| 15:38:08 | <rafa> dkayiwa: it may be possible to configure, but I'm not sure how |
| 15:38:26 | <dkayiwa> rafa: so cant get those changes untill when i figure out how? :) |
| 15:38:44 | <rafa> dkayiwa: you can get them with the command line :) |
| 15:38:59 | <rafa> git pull upstream master |
| 15:39:15 | <dkayiwa> rafa: ok let me try that. thanks :) |
| 15:39:15 | <rafa> if you added upstream after cloning your fork |
| 15:39:25 | <dkayiwa> rafa: yes i did |
| 15:39:48 | *** deepaganu has quit IRC |
| 15:40:14 | <wyclif> rafa, does the module start for you? |
| 15:40:36 | <dkayiwa> wyclif: we fixed that. so yes it should |
| 15:40:56 | <rafa> dkayiwa: I haven't checked after my last commits though |
| 15:41:00 | *** maurya has quit IRC |
| 15:41:07 | <rafa> wyclif: what is the error? |
| 15:41:10 | <dkayiwa> rafa: :) |
| 15:41:18 | *** maurya has joined #openmrs |
| 15:42:02 | <wyclif> dkayiwa, it is still failing i need to start in tomcat to see the logs |
| 15:42:30 | *** judygichoya has quit IRC |
| 15:44:00 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @diptanu: Tell us when you would want to have the next #OpenMRS code jam http://t.co/VRVnOqZu #twuknorth #thoughtworks <http://twitter.com/OpenMRS/statuses/229960356942999553> |
| 15:45:11 | <rafa> wyclif: it fails |
| 15:45:14 | <rafa> wyclif: let me fix it |
| 15:47:04 | <rafa> wyclif: forgot to rename one thing |
| 15:47:41 | <wyclif> ok |
| 15:48:09 | <rafa> wyclif: should be fine now |
| 15:48:16 | <wyclif> thanks |
| 15:48:25 | *** ChanServ sets mode: +v maurya |
| 15:56:30 | *** kishoreyekkanti_ has quit IRC |
| 15:57:47 | <rafa> dkayiwa: if you want to do 'git pull upstream master' from your branch in egit you do: |
| 15:58:03 | <rafa> dkayiwa: team->remote-fetch from... |
| 15:58:16 | <dkayiwa> rafa: ok thanks for the tip!!! |
| 15:58:22 | <rafa> dkayiwa: choose upstream from the configured remote repository |
| 15:58:33 | <dkayiwa> rafa: ok |
| 15:59:57 | <rafa> dkayiwa: it will only fetch changes so you need to do team->merge from upstream/master I think |
| 16:00:11 | <dkayiwa> rafa: ok |
| 16:02:15 | <applecool> rafa: when do you want me to show the packag einformation page i mean the uploadDisplay page? |
| 16:02:39 | <rafa> applecool: we've discussed that already |
| 16:02:49 | <rafa> applecool: nowhere |
| 16:02:55 | <rafa> applecool: don't delete it |
| 16:02:59 | <rafa> applecool: but don't show it |
| 16:03:10 | <applecool> actually you confused me a little bit :P |
| 16:03:21 | <rafa> applecool: I'm sorry :P |
| 16:03:50 | <applecool> as you mentioned now in the comment! i made changes! |
| 16:03:58 | <applecool> let me tell you! :) |
| 16:05:10 | <applecool> when i browse the file and press on upload i am redirecting the page to the packageform.jsp by making SuccessView("/packageform") in the FileUploadController |
| 16:05:35 | <applecool> in this page i will display the message "package uploaded successfully" |
| 16:05:46 | <applecool> right? rafa so far? |
| 16:05:57 | <rafa> applecool: right |
| 16:06:09 | <applecool> and the heading would be "Edit Package" only |
| 16:06:11 | <applecool> right |
| 16:06:21 | <applecool> ? |
| 16:06:23 | <rafa> right |
| 16:06:28 | <applecool> great |
| 16:06:41 | <applecool> then i will fill in the form and then i will press save |
| 16:07:14 | <applecool> when i press save! everything from here is controlled in the "PAckageFormController" |
| 16:08:06 | <applecool> as you mentioned! you wanted me to show again the EditPackage page i.e., the packageform with all the filled details |
| 16:08:23 | <applecool> and the message "PAckage saved" |
| 16:08:25 | <applecool> right |
| 16:08:27 | <applecool> ? |
| 16:08:28 | <rafa> right |
| 16:09:07 | <applecool> so i am just making the SuccessView("/packageform") in the PAckageFormController too |
| 16:09:18 | <rafa> applecool: I have an impression that like to repeat my words, but continue ;) |
| 16:09:38 | <applecool> :P |
| 16:10:16 | <rafa> applecool: yes, that's what you're supposed to do |
| 16:10:23 | <rafa> applecool: something doesn't work? |
| 16:10:55 | <applecool> and at the bottom instead of just saying return success; i am doing return success + "?id=" + pkg.getId(); |
| 16:11:13 | <rafa> applecool: makes sense |
| 16:11:20 | <applecool> so this will show me the packageform page with the filled details and the message "Package saved" |
| 16:11:36 | <applecool> but the problem is where are we going next? |
| 16:11:37 | <rafa> applecool: fingers crossed ;) |
| 16:11:55 | <rafa> applecool: where do you want to go? |
| 16:12:02 | <rafa> applecool: I want to go eat dinner :D |
| 16:12:24 | <applecool> the page will show save, cancel and delete buttons as we are showing the same package form page |
| 16:12:32 | <applecool> haha! nice one rafa :D |
| 16:12:36 | <rafa> applecool: that's correct |
| 16:12:49 | <applecool> again when we press save it shows trhe same page |
| 16:12:55 | <rafa> applecool: that's correct |
| 16:12:57 | <rafa> :) |
| 16:13:06 | <applecool> but wpnt go to any other page ie the mainpage or so |
| 16:13:21 | <applecool> this is what bothering me :P |
| 16:13:21 | <rafa> applecool: then click Packages in the main menu ;) |
| 16:13:28 | <applecool> haha! :D |
| 16:13:58 | <applecool> then i will commit that :P |
| 16:14:07 | <applecool> so the ticket is resolved! |
| 16:14:09 | <rafa> applecool: very well |
| 16:14:11 | <applecool> right? |
| 16:14:29 | <rafa> applecool: right |
| 16:14:36 | <applecool> one more thing as you told to try the new school technique with the divs in css |
| 16:14:40 | <rafa> applecool: pending another review ;) |
| 16:15:00 | <applecool> i tried it for about 2 hours! but didnt work properly! |
| 16:15:13 | <rafa> applecool: I told you 10 minutes :P |
| 16:15:16 | <applecool> old school technique is more successful :D the tables |
| 16:15:27 | <applecool> but even though i tried it rafa :D |
| 16:15:45 | <applecool> so i left them as they are |
| 16:15:48 | <rafa> applecool: you're bad boy :P |
| 16:15:57 | <applecool> haha! :P :D |
| 16:16:14 | <rafa> applecool: that's fine |
| 16:16:28 | <applecool> at last it was like old is gold :D |
| 16:16:31 | <rafa> applecool: (as I told you ;) ) |
| 16:17:00 | <applecool> last thing is i re ordered the login,packages and upload package in the index page |
| 16:17:04 | <applecool> ie without login |
| 16:17:22 | <applecool> and highlghted the packages menu item |
| 16:17:28 | <rafa> applecool: login must go last |
| 16:17:34 | <applecool> yup |
| 16:17:37 | <applecool> did that |
| 16:17:46 | <rafa> applecool: and yes, the package must be highlighted when you show packages |
| 16:18:14 | <applecool> ah yes |
| 16:18:37 | <applecool> but the thing is when i click on login "login " is not getting highlighted :( |
| 16:18:42 | <applecool> there comes the problem |
| 16:18:51 | <applecool> that is the only glich which i am left with |
| 16:18:58 | <applecool> :| |
| 16:19:05 | <rafa> applecool: ok, move on |
| 16:19:14 | <applecool> this happens only without logging in |
| 16:19:26 | <applecool> but when you log in! there is no such problem |
| 16:19:35 | <rafa> applecool: ok, leave it as it is |
| 16:19:43 | <rafa> applecool: seriously I need to go eat dinner :D |
| 16:19:54 | <applecool> if you click on any menu item! it shows the respective data and gets highlighted |
| 16:19:59 | <applecool> have a hapy dinner :) |
| 16:20:03 | <applecool> even i am going to have |
| 16:20:14 | <applecool> catch you later ;) rafa |
| 16:20:15 | <rafa> applecool: good for you :D |
| 16:20:17 | <rafa> cya |
| 16:20:29 | <maurya> djazayeri, are you free? |
| 16:21:07 | *** applecool has quit IRC |
| 16:30:30 | *** djazayeri1 has joined #openmrs |
| 16:32:39 | *** djazayeri has quit IRC |
| 16:35:00 | *** ABHISHEK__ has quit IRC |
| 16:42:18 | <wyclif> hi dj |
| 16:43:05 | *** jriley has left #openmrs |
| 16:46:30 | *** DrBacchus has joined #openmrs |
| 16:46:38 | <downey> Hi DrBacchus and welcome to the #openmrs IRC channel. |
| 16:46:53 | <DrBacchus> Hi, bwolfe. Rich Bowen here from SourceForge, hoping to schedule a podcast for tomorrow some time. |
| 16:47:11 | <DrBacchus> Habari ya sabui? |
| 16:51:20 | *** maurya has quit IRC |
| 16:53:32 | *** djazayeri has joined #openmrs |
| 16:53:32 | *** ChanServ sets mode: +o djazayeri |
| 16:54:22 | <bwolfe> DrBacchus, nzuri, asante. :-) |
| 16:54:39 | <bwolfe> DrBacchus, isn't it asubuhi? :-) we need to work on your swahili. |
| 16:54:46 | <bwolfe> (mine isn't that good, don't ask me for lessons) |
| 16:55:04 | <DrBacchus> Ye, alas, my sawhili is 25 years dusty, and was never very great even when I lived there. |
| 16:55:19 | <bwolfe> DrBacchus, I'm available anytime after 2:30pm eastern time |
| 16:55:33 | <DrBacchus> ok. Well, let's say 2:30 eastern, then. |
| 16:55:34 | <bwolfe> 25 years of dust, eh? thats quite a layer |
| 16:55:59 | *** rafa has quit IRC |
| 16:56:31 | <DrBacchus> I'll send you a connect request on Skype. |
| 16:58:12 | *** suranga has joined #openmrs |
| 16:58:12 | *** ChanServ sets mode: +v suranga |
| 16:59:34 | *** kreddy has joined #openmrs |
| 17:01:44 | <wyclif> hi djazayeri |
| 17:01:50 | <djazayeri> hi wyclif |
| 17:02:07 | <wyclif> djazayeri, am looking at the snapshot at HLQRY-11 |
| 17:02:20 | <djazayeri> !hlqry-11 |
| 17:02:21 | <OpenMRSBot> djazayeri: Error: "hlqry-11" is not a valid command. |
| 17:02:24 | <djazayeri> !ticket hlqry-11 |
| 17:02:25 | <OpenMRSBot> djazayeri: [#HLQRY-11] Create a Manage Templates admin page for the hl7query table - OpenMRS JIRA - https://tickets.openmrs.org/browse/hlqry-11 |
| 17:02:40 | <djazayeri> wyclif: yes? |
| 17:02:40 | <wyclif> djazayeri, what is that drop down for? |
| 17:02:53 | <wyclif> is that a GP? |
| 17:03:19 | <djazayeri> wyclif: actually you should ignore that. That seems to be ticket HLQRY-25. |
| 17:03:43 | <djazayeri> wyclif: for HLQRY-11 just do the stuff from the Templates heading and below. |
| 17:05:11 | <djazayeri> wyclif: does that make sense? |
| 17:06:17 | *** deepaganu has joined #openmrs |
| 17:06:48 | <wyclif> djazayeri, yes thanks |
| 17:07:20 | <downey> swahili++ |
| 17:07:41 | <wyclif> djazayeri, looks i have to add the getTemplates() method to the api because i dont to see it |
| 17:07:48 | <wyclif> djazayeri, right? |
| 17:08:18 | <djazayeri> wyclif: maybe, look at HLQRY-22 and https://github.com/OpenMRS/openmrs-module-hl7query/pull/9 ? |
| 17:08:29 | <OpenMRSBot> <http://ln-s.net/$Xkd> (at github.com) |
| 17:08:51 | *** goutham has joined #openmrs |
| 17:10:06 | <wyclif> djazayeri, seems to be already merged and my working copy is up to date |
| 17:11:34 | <wyclif> djazayeri, even the privileges are missing, aren't certain privileges required to manage templates? |
| 17:12:10 | *** lakkarau has joined #openmrs |
| 17:14:13 | <djazayeri> wyclif: I assume so. You know as well as I. :-) |
| 17:24:17 | *** kreddy has quit IRC |
| 17:33:40 | *** deepaganu has quit IRC |
| 17:36:11 | <bwolfe> wyclif, yep, looks like the @authorized params are missing. https://github.com/OpenMRS/openmrs-module-hl7query/blob/master/api/src/main/java/org/openmrs/module/hl7query/api/HL7QueryService.java |
| 17:36:16 | <OpenMRSBot> <http://ln-s.net/$Xld> (at github.com) |
| 17:36:20 | <bwolfe> wyclif, can you create a ticket for that and/or do it? |
| 17:38:35 | <wyclif> bwolfe, i will |
| 17:38:39 | <suranga> hi bwolfe |
| 17:38:53 | <bwolfe> hi suranga |
| 17:38:58 | <suranga> bwolfe, you were right, the sprint it going pretty neatly, isnt it ? |
| 17:39:05 | <suranga> I was looking at the pull requests |
| 17:39:24 | <suranga> bwolfe, maybe we should extend our scope a bit ;-) |
| 17:40:11 | <bwolfe> suranga, how so? |
| 17:40:33 | <suranga> bwolfe, well, they seem to be making very good progress :) |
| 17:40:37 | <bwolfe> good |
| 17:40:41 | <bwolfe> lets aim to be done by next wed |
| 17:40:46 | <bwolfe> then we can test and maybe add more features |
| 17:43:02 | <suranga> bwolfe, that would be really great :) |
| 17:43:13 | <bwolfe> but lets let it ride for now |
| 17:43:35 | *** maurya has joined #openmrs |
| 17:43:40 | <suranga> bwolfe, i shall now look at the tickets, and try to find one where I shall be the least niusance :P |
| 17:44:08 | *** djazayeri has quit IRC |
| 17:45:25 | <bwolfe> suranga, ha |
| 17:45:28 | <bwolfe> you shoudl spend time reviewing |
| 17:45:35 | <bwolfe> and/or updating documentation as things change |
| 17:46:02 | <suranga> bwolfe, hmm.. I see... |
| 17:48:21 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @SPulim: Wow! @sanamobile @openMRS @kiwanja: "The developing world is now more mobile than the developed world". http://t.co/N9XBt9Ko ... <http://twitter.com/OpenMRS/statuses/229986883831201792> |
| 17:49:03 | *** djazayeri has joined #openmrs |
| 17:49:03 | *** ChanServ sets mode: +o djazayeri |
| 17:53:34 | <bwolfe> suranga, the role of the sprint leader is of "guiding the sheep" |
| 17:53:45 | <bwolfe> you must make sure everyone is going in the right direction |
| 17:53:49 | <bwolfe> so review things quickly |
| 17:53:52 | <bwolfe> comment on everything, etc |
| 17:53:57 | <bwolfe> lakkarau, what are you working on today? |
| 17:54:02 | <suranga> bwolfe, cool, Im on that... |
| 17:54:11 | <suranga> lakkarau, had taken on two tickets bwolfe |
| 17:54:14 | *** djazayeri has quit IRC |
| 17:54:32 | <suranga> the admin page is the more importaint of those |
| 17:54:46 | <lakkarau> Bwolfe:HLQRY-26 |
| 17:56:51 | *** dkayiwa_ has joined #openmrs |
| 17:57:13 | <bwolfe> !ticket hlqry-26 |
| 17:57:14 | <OpenMRSBot> bwolfe: [#HLQRY-26] Add Settings page for HL7 Query module - OpenMRS JIRA - https://tickets.openmrs.org/browse/hlqry-26 |
| 17:57:23 | <bwolfe> lakkarau, ok. did you find the taglib for that? |
| 17:57:41 | <lakkarau> bwolfe:no |
| 17:57:42 | *** dkayiwa has quit IRC |
| 17:57:42 | *** dkayiwa_ is now known as dkayiwa |
| 17:58:39 | <bwolfe> lakkarau, in the ticket it says "Use of the global property taglib is fine here." |
| 17:59:03 | <lakkarau> bwolfe:yes |
| 17:59:06 | <bwolfe> lakkarau, so in eclipse, type control-shift-t and type "globalpropertytag" and it shoudl come up |
| 18:01:17 | <lakkarau> bwolfe:yes,i am having a look at that class |
| 18:07:23 | *** pushkar__ has joined #openmrs |
| 18:08:59 | *** pushkar_ has quit IRC |
| 18:09:51 | *** pushkar has joined #openmrs |
| 18:11:52 | *** pushkar__ has quit IRC |
| 18:12:36 | <suranga> hi jkeiper_ |
| 18:12:58 | <suranga> jkeiper_, I just wanted to ask if you were working on !ticket PTM-40 |
| 18:13:04 | <jkeiper_> heyya suranga |
| 18:13:06 | <jkeiper_> was |
| 18:13:09 | <jkeiper_> !ticket PTM-40 |
| 18:13:10 | <OpenMRSBot> jkeiper_: [#PTM-40] Migrating the configuration matching file from xml to OpenMRS database - OpenMRS JIRA - https://tickets.openmrs.org/browse/PTM-40 |
| 18:13:26 | <suranga> jkeiper_, mm.. have you finished it ? :P |
| 18:19:48 | <jkeiper_> suranga, i had it half-done in code ... will have to look at it again |
| 18:20:08 | <jkeiper_> if you or the GSoC student would like to take it on, I am happy to provide my patch |
| 18:20:15 | <jkeiper_> as a starting point, perhaps |
| 18:20:24 | <suranga> jkeiper_, no worries, thats whY i buzzed you :) |
| 18:20:41 | <suranga> my student was anxious to know if you had done any work on that :P |
| 18:21:01 | <jkeiper_> suranga, I will look today and update the ticket :-) |
| 18:21:37 | *** kreddy has joined #openmrs |
| 18:26:03 | *** bwolfe has left #openmrs |
| 18:26:08 | *** bwolfe has joined #openmrs |
| 18:26:08 | *** ChanServ sets mode: +o bwolfe |
| 18:26:33 | <bwolfe> did anyone end up pointing srinath at anything in particular? |
| 18:39:30 | <suranga> jkeiper_, dont worry about finishing it or anything. Im sure my student is most willing to take it on ! |
| 18:39:46 | <jkeiper_> suranga, excellent :-) |
| 18:43:44 | <dkayiwa> bwolfe: i do not think so |
| 18:49:26 | <suranga> hi bwolfe .. mmm... I have come up with a problem scenario.... :) |
| 18:50:14 | <bwolfe> suranga, ok, whats up |
| 18:50:15 | *** maurya has quit IRC |
| 18:50:24 | <bwolfe> dkayiwa, ok, can you engage him if/when you see him next? |
| 18:50:38 | <bwolfe> dkayiwa, perhaps set an alert in your irc client. :-) |
| 18:50:40 | *** maurya has joined #openmrs |
| 18:50:42 | <dkayiwa> bwolfe: ok will do so |
| 18:50:53 | <suranga> bwolfe, when exporting concepts, we identify them by their mappings |
| 18:51:06 | <dkayiwa> bwolfe: will need to learn how to do that :) |
| 18:51:21 | <bwolfe> dkayiwa, yeah, not all clients can do it. |
| 18:51:35 | <bwolfe> dkayiwa, and its not a requirement, its just a suggestion |
| 18:51:41 | <dkayiwa> bwolfe: ok :) |
| 18:51:47 | <suranga> bwolfe, now assume that we turn up with a concept with no mappings.... |
| 18:52:00 | <suranga> in such a case, how can we identify the concept ? |
| 18:52:17 | <suranga> In the Jembi use case, there would be no un-mapped concepts |
| 18:53:13 | <suranga> bwolfe, maybe we can leave the mapping type and id blank, and send only the concept name ? then the receiver can try searcing byname ? |
| 18:54:33 | <bwolfe> suranga, if the concept has no mappings then we should use the "imiplementation id" and use the concept_id |
| 18:54:47 | <bwolfe> suranga, it is up to the sending org to make sure all their concpets have mappings |
| 18:55:01 | <bwolfe> suranga, and it is up to the receiving org to make sure that all the received concepts are mapped |
| 18:55:40 | <bwolfe> RG has a team of 5+ people that just deal with unmapped concepts all day! (but they receive thousands of hl7 messages per hour) |
| 18:55:40 | <suranga> bwolfe, sounds good. by implementation_id, do you refer to the 'sending_faculty' constant we use in the MSh segment ? :) |
| 18:55:52 | <bwolfe> maybe, is that what that is for? |
| 18:56:07 | <bwolfe> I am referring ot the "implemetnation id" that we store. See recent dev list discussion on it |
| 18:56:18 | <bwolfe> https://wiki.openmrs.org/display/docs/Implementation+Id |
| 18:56:28 | <bwolfe> and the "set implementation id" admin page |
| 18:58:19 | *** dkayiwa_ has joined #openmrs |
| 19:01:18 | *** dkayiwa has quit IRC |
| 19:01:18 | *** dkayiwa_ is now known as dkayiwa |
| 19:09:45 | *** james_regen has quit IRC |
| 19:10:16 | <suranga> bwolfe, hmm... the sending _facility is also impelmentation specific, ans supposed to be entierd (chosed) by the admin |
| 19:12:52 | <bwolfe> suranga, I think I asked on one of the wiki pages |
| 19:12:59 | <bwolfe> what is that generally supposed to be? an hl7 code? |
| 19:13:21 | <bwolfe> is it unique per machine or unique per implemetnation? |
| 19:13:50 | <suranga> bwolfe, its supposed to be unique per impelemtation |
| 19:14:20 | <suranga> basically, before senting a message, you need to set it : etc : "surangas_implementatin" |
| 19:14:32 | <suranga> its just a 'supposedly unique' string value |
| 19:16:10 | <bwolfe> but do we expect two machines within one org to send to each other? |
| 19:16:15 | <bwolfe> ampath has 15 different sites |
| 19:16:21 | <bwolfe> and they all have their own installation of openmrs |
| 19:16:32 | <bwolfe> they are "one org", but have many installs |
| 19:23:23 | <lakkarau> bwolfe:$ git clone https://github.com/OpenMRS/openmrs-module-hl7query id this the right command to get the repository. |
| 19:23:24 | <OpenMRSBot> <http://ln-s.net/$Wry> (at github.com) |
| 19:24:17 | <bwolfe> lakkarau, yeah, looks right |
| 19:25:02 | <lakkarau> bwolfe:error: Failed to connect to 207.97.227.239: Connection was aborted while accessi |
| 19:25:02 | <lakkarau> ng https://github.com/OpenMRS/openmrs-module-hl7query.git/info/refs |
| 19:25:02 | <lakkarau> fatal: HTTP request failed |
| 19:25:26 | <bwolfe> lakkarau, its yet another problem with your proxy server |
| 19:25:35 | <bwolfe> google for how to set the proxy settings in git |
| 19:25:49 | <lakkarau> bwolfe:ok |
| 19:27:06 | <suranga> bwolfe, sorry, I missed your messages. I see what you mean there... let me read up some more on the implementation_id |
| 19:27:46 | *** pushkar has quit IRC |
| 19:27:46 | *** maurya has quit IRC |
| 19:28:14 | *** maurya has joined #openmrs |
| 19:28:52 | *** applecool has joined #openmrs |
| 19:29:09 | *** ChanServ sets mode: +v applecool |
| 19:32:24 | *** maurya has quit IRC |
| 19:32:45 | *** maurya has joined #openmrs |
| 19:33:20 | *** applecool has quit IRC |
| 19:34:01 | *** applecool has joined #openmrs |
| 19:34:01 | *** ChanServ sets mode: +v applecool |
| 19:38:06 | *** jriley has joined #openmrs |
| 19:51:51 | <dkayiwa> hi suranga |
| 19:52:15 | <bwolfe> suranga, can I get you to modify the sprint dashboard? |
| 19:52:24 | <bwolfe> I'm looking at this one: https://tickets.openmrs.org/secure/Dashboard.jspa?selectPageId=12052 |
| 19:52:30 | <suranga> dkayiwa, bwolfe hi, sure |
| 19:52:44 | <dkayiwa> bwolfe: suranga do you know of any sample xml hl7 message that i can use in a unit test? |
| 19:53:11 | <suranga> dkayiwa, let me get you one...I'll email it to you... |
| 19:53:29 | <dkayiwa> suranga: will be very grateful!!! waiting ..... :) |
| 19:53:43 | <bwolfe> suranga, the upper left yellow box is usually a "my tickets" box. so edit your current saved filter, add "and assignee=currentUser() or (labels is empty or labels = currentUser())", then save as new, then use that new query in hte yellow box |
| 19:54:10 | <suranga> bwolfe, im on it :) |
| 19:54:24 | <dkayiwa> suranga: am also waiting for you :) |
| 19:54:31 | <bwolfe> dkayiwa, suranga, an example xml hl7 message sounds like a good thing for a wiki page (or an attachment and link) |
| 19:54:42 | <dkayiwa> bwolfe: sure |
| 19:59:00 | <bwolfe> downey, clicking "approve/close" on this ticket spins for a long time and then finally shows a "jira error occurred". https://tickets.openmrs.org/browse/HLQRY-9 |
| 19:59:07 | <bwolfe> downey, tried it twice with same result now |
| 20:00:01 | <downey> bwolfe: probably due to fisheye/crucible |
| 20:00:14 | <bwolfe> downey, or to the git linked tickets? |
| 20:00:22 | <downey> no |
| 20:02:14 | * downey checks in to it |
| 20:03:35 | <bwolfe> suranga, after you do that one, now you need to modify all the other boxes with their own filters |
| 20:04:14 | <downey> bwolfe: some connectivity issues from fecru-jira |
| 20:04:16 | <suranga> bwolfe, i was getting that file for daniel, i'm on it now :) |
| 20:04:35 | <bwolfe> suranga, np |
| 20:04:49 | <bwolfe> suranga, see this jira dashboard that dkayiwa set for the xforms sprint: https://tickets.openmrs.org/secure/Dashboard.jspa?selectPageId=11853 |
| 20:05:07 | <bwolfe> suranga, see the yellow box has a query like "my tickets for xforms". thats the one I described |
| 20:05:33 | <bwolfe> suranga, the other two boxes on the left use the same query: "available xform sprint". meaning it looks at only tickets that are not assigned |
| 20:05:54 | <bwolfe> suranga, the middle top and middle bottom use "in progress for xforms". meaning only tickets that DO have an assignee |
| 20:06:21 | <bwolfe> the middle middle only has tickets that are under review (look up that saved filter to see what to include in your query) |
| 20:06:35 | <bwolfe> and the right box includes all tickets that have been marked as closed |
| 20:06:52 | <bwolfe> so you typically need 5 DIFFERENT saved filters for a jira dashboard for a sprint |
| 20:10:20 | <downey> bwolfe: try closing https://tickets.openmrs.org/browse/HLQRY-9 again please? |
| 20:12:24 | <bwolfe> downey, spinning... |
| 20:13:02 | <downey> bwolfe: FWIW google is currently indexing jira |
| 20:14:29 | <bwolfe> good times |
| 20:14:40 | <bwolfe> is it accessing every url it can find as fast as it can? |
| 20:15:44 | <downey> it tries. :) |
| 20:17:58 | <bwolfe> lakkarau, hmm, I steered you wrong earlier. you should not "git clone" directly from the main "upstream". you should fork to your own github repo first |
| 20:18:12 | <bwolfe> lakkarau, see the "fork" button the github webpage at that url |
| 20:18:22 | <bwolfe> then do a git clone on the one you forked |
| 20:18:58 | <jkeiper_> suranga, as it turns out I do not have any new code for PTM-40 |
| 20:19:07 | <jkeiper_> strange, thought i had done some |
| 20:19:13 | <jkeiper_> but i cannot find it, if i did |
| 20:20:00 | <suranga> jkeiper_, no worries :) |
| 20:20:10 | <jkeiper_> good luck! |
| 20:20:12 | <jkeiper_> ;-) |
| 20:20:48 | <bwolfe> downey, form came up this time. now submitting form....spinning....spinning... |
| 20:21:20 | <wyclif> hi suranga |
| 20:21:49 | <suranga> wyclif, helllo ! hows it going ? |
| 20:21:56 | <wyclif> suranga, can you please set the links between tickets so that we know which tickets need to be done first |
| 20:22:22 | <suranga> wyclif, wooops :( |
| 20:22:26 | <bwolfe> wyclif, the "priority" does that mostly. so sort your ticket list by that |
| 20:22:32 | <wyclif> forinstance i have noticed HLQRY-25 has to be done before HLQRY-8 |
| 20:23:35 | <suranga> wyclif, sorry about that. I will have a look over them again.. :( |
| 20:24:21 | <wyclif> suranga, cool |
| 20:26:24 | *** applecool has quit IRC |
| 20:35:29 | *** downey has quit IRC |
| 20:39:18 | *** jkeiper__ has joined #openmrs |
| 20:39:18 | *** jkeiper_ has quit IRC |
| 20:41:31 | <bwolfe> lakkarau, did you read up on git? know how to proceed? |
| 20:41:42 | <bwolfe> dkayiwa, how is your git faring? I haven't see a pull request from you yet... :-) |
| 20:42:04 | <dkayiwa> bwolfe: about to do one in a few minutes :) |
| 20:42:18 | <lakkarau> bwolfe:the application is forked but still failing cloing the app |
| 20:43:22 | <bwolfe> lakkarau, because of the merck VPN! |
| 20:43:36 | <bwolfe> lakkarau, just assume that all internet problems you have are because of that merck vpn |
| 20:43:52 | <lakkarau> bwolfe: i will close the vpn and try |
| 20:43:53 | <bwolfe> if something isn't connecting, you either have to edit its settings to put the proxy in, or yo uhave to log off of the vpn |
| 20:44:13 | *** jkeiper__ has quit IRC |
| 20:46:16 | *** lakkarau has quit IRC |
| 20:48:11 | <wyclif> hi suranga |
| 20:48:57 | <wyclif> Did this ticket HLQRY-11 require adding the create/edit template form? |
| 20:52:27 | <wyclif> hi bwolfe |
| 20:52:36 | <bwolfe> hi wyclif |
| 20:52:50 | <bwolfe> wyclif, yes to your previous question. ...unless there is already a ticket fo rit |
| 20:52:58 | <wyclif> bwolfe, ok |
| 20:53:29 | <wyclif> and is the page in the snapshot for HLQRY-11 supposed to be a form or not? |
| 20:54:11 | <wyclif> HLQRY-25 suggeste that the GP should be set from that page though i dont think so |
| 20:54:26 | <wyclif> bwolfe, should't that be on the manage page |
| 20:54:51 | <bwolfe> wyclif, can be on the "settings" page, yes. I initially wanted it on the manage template page |
| 20:54:56 | <wyclif> bwolfe, which is technically the module's settings page |
| 20:54:58 | <bwolfe> but darius disagreed. :-) |
| 20:55:02 | <bwolfe> yes |
| 20:55:07 | <wyclif> bwolfe, i also diagree |
| 20:55:13 | <wyclif> disagree |
| 20:55:39 | <bwolfe> darius wants it on the manage templates page (notice the s) that you just created. |
| 20:55:49 | <bwolfe> I think its better on the same page that has the settings |
| 20:56:00 | <bwolfe> I think uma is working on the settings page |
| 20:59:34 | *** jordank has quit IRC |
| 21:02:27 | *** goutham has quit IRC |
| 21:03:15 | *** jordank has joined #openmrs |
| 21:15:06 | *** wyclif has quit IRC |
| 21:15:56 | *** maurya has quit IRC |
| 21:31:33 | *** snoppy has left #openmrs |
| 21:40:43 | *** jriley has quit IRC |
| 21:51:40 | *** dkayiwa has quit IRC |
| 21:54:32 | *** lakkarau has joined #openmrs |
| 22:23:13 | *** wyclif has joined #openmrs |
| 22:52:32 | *** jordank has quit IRC |
| 23:00:33 | *** suranga has quit IRC |
| 23:30:38 | *** kreddy has quit IRC |