IRC Chat : 2012-07-28 - OpenMRS

01:21:48 *** bwolfe has joined #openmrs
01:21:48 *** ChanServ sets mode: +o bwolfe
01:42:32 *** lh has quit IRC
02:28:06 *** lh has joined #openmrs
02:28:23 *** jordank has quit IRC
02:35:20 *** lh has quit IRC
02:57:49 *** jordank has joined #openmrs
03:23:30 *** djazayeri has quit IRC
03:29:22 *** djazayeri has joined #openmrs
03:29:22 *** ChanServ sets mode: +o djazayeri
03:29:51 *** djazayeri has quit IRC
04:46:18 *** bwolfe has quit IRC
04:46:22 *** gede has quit IRC
06:06:45 *** harshadura has joined #openmrs
07:05:44 *** pulasthi7 has joined #openmrs
08:17:15 *** rafa has joined #openmrs
08:17:15 *** ChanServ sets mode: +v rafa
08:23:10 *** harshadura has joined #openmrs
08:26:26 *** harshadura has quit IRC
09:03:25 *** rafa has quit IRC
10:14:37 *** goutham has joined #openmrs
10:45:52 *** maurya has joined #openmrs
10:46:18 *** ChanServ sets mode: +v maurya
10:54:26 *** suranga has joined #openmrs
10:54:26 *** ChanServ sets mode: +v suranga
10:55:09 *** bwolfe has joined #openmrs
10:55:09 *** ChanServ sets mode: +o bwolfe
11:04:53 <suranga> howdy bwolfe !
11:05:07 <bwolfe> hey
11:05:10 <suranga> bwolfe, saw your email..
11:05:17 <suranga> bwolfe, are well all set ? :)
11:07:13 <bwolfe> suranga, did you review darius' pull request?
11:07:31 <suranga> bwolfe, on my //to do list :(
11:09:04 <suranga> bwolfe, all the tickets that need to be fixed first get top priooty , and there onwards down...
11:09:17 <suranga> *top priority status
11:09:28 <bwolfe> did you ever look at the TemplateFunctions ticket?
11:10:38 <suranga> bwolfe, no :(
11:11:20 <suranga> !ticket HLQRY-23
11:11:21 <OpenMRSBot> suranga: [#HLQRY-23] Create TemplateFunctions class for use in templates - OpenMRS JIRA - https://tickets.openmrs.org/browse/HLQRY-23
11:12:04 <suranga> bwolfe, is this the one which created the ORUR01 template ?
11:12:39 <suranga> bwolfe, I thought that ORUR01 template was responsible for calling the stuff it needs :(
11:14:09 <bwolfe> it is. but it has to have some way to call things
11:14:48 <bwolfe> maybe groovy templates has a built-in way to call other templates...if so, can you list that out?
11:15:03 <bwolfe> but the functions will be needed for getting things like GP properties, etc
11:15:54 <suranga> bwolfe, umm.. only the MSH template needs GP's, a I belive
11:16:42 <suranga> bwolfe, darius said that one template can cll another by name, so i assumed that it was ok to leave it as such
11:18:34 <suranga> bwolfe, oh, wait, the controller class sends the template a bunch of bindings
11:19:06 <suranga> bwolfe, you want me to figure out how they fit into the template engine class
11:19:13 <suranga> bwolfe, cool, I can take that on
11:22:41 <bwolfe> suranga, looking at darius's pull request, I don't see any calls to other templates
11:23:03 <bwolfe> e.g. so we need to determine how the orur01 template will import/call the msh template
11:23:38 <bwolfe> it will be something like <% callTemplate("MSH", [patient=patient]) %>
11:24:09 <suranga> bwolfe, agree
11:24:13 <bwolfe> but I am 90% sure that won't work without some coding...groovytemplates doesn't know what "MSH" is or how to get the template out fo the database (or cache, as darius did it)
11:24:42 <bwolfe> but if the TemplateFunctions had a method like:
11:25:00 <bwolfe> String callTemplate(String templateName, Map bindings)
11:26:32 <suranga> bwolfe, this method gets the template by name("MSH") and passes it the patient object(from the bindings)
11:27:14 <bwolfe> the callTemplate method in the TemplateFunctions essentially just calls service.renderTemplate and returns what it returns
11:31:05 <suranga> bwolfe, I think I get this
11:31:19 <suranga> bwolfe, got time to review this ticket when I write it up ? :)
11:31:30 <bwolfe> sure
11:32:25 <suranga> bwolfe, you'll be back online by around ... ?
11:32:39 <bwolfe> I'll be off and on all day
11:35:32 <suranga> bwolfe, cool. I'll be on this as soon as I finish this other buggie... :(
11:38:43 *** pulasthi7 has quit IRC
11:40:05 *** rafa has joined #openmrs
11:40:05 *** ChanServ sets mode: +v rafa
12:13:11 *** rafa has quit IRC
12:24:46 *** harshadura has joined #openmrs
12:51:15 *** goutham has quit IRC
12:55:41 *** harshadura has quit IRC
13:10:09 <suranga> hi bwolfe , regarding !ticket HLQRY-29
13:10:33 <suranga> bwolfe, i think we need to support both xml output and string (pipe) output
13:10:55 <bwolfe> !ticket HLQRY-29
13:10:57 <OpenMRSBot> bwolfe: [#HLQRY-29] Create service method to convert xml to hapi - OpenMRS JIRA - https://tickets.openmrs.org/browse/HLQRY-29
13:11:36 <bwolfe> suranga, returning xml is trivial (just means not calling the parse to pipes method)
13:11:46 *** maurya has quit IRC
13:11:49 <suranga> bwolfe, for example, even though we already have a xml message (which we created) i'd rather we converted this into HAPI, and then back to xml from hapi. this will help validate that the message creation didnt cause any problems
13:11:52 <bwolfe> you can edit hte ticket or make a different one. means the method should have another param so the user can say what they want
13:12:39 <suranga> bwolfe, yep, i think we shoud add this extra step (our xml -> HAPI -> HAPI xml) for validation benifits
13:16:13 *** mgielow has joined #openmrs
13:16:47 <bwolfe> suranga, the validation is a different ticket
13:17:23 <bwolfe> so the xml is validated when the user saves it. I don't think we need to validate it every time they request it too
13:17:26 <suranga> bwolfe, isnt that template called only when we are creating the template ?
13:17:47 <suranga> ah, yep, i was thinking we should do this? mm... you think its unnessesary ?
13:18:03 <bwolfe> double validation? seems like a waste of cpu
13:18:37 <suranga> bwolfe, you are a better authority on this than me. Will re-edit :-)
13:26:16 <bwolfe> suranga, the decision of whether it is pipe delimited or not should not be in the method named "getPipeDelimited" :-)
13:26:32 <bwolfe> the method that is calling both getXml and then getPipes should have the method
13:27:49 <suranga> bwolfe, :-(
13:28:03 <suranga> bwolfe, umm... renderDelimitedMessage() ?
13:28:10 <bwolfe> no
13:28:19 <suranga> renderORUR01Message ?
13:28:26 <bwolfe> my point was, you modified the wrong ticket
13:28:41 <bwolfe> (although the getPipes method does need renamed)
13:29:11 <suranga> bwolfe, the 29 ticket is called only if the user wants a pipe delimited hl7 message, isnt it ?
13:29:54 <suranga> bwolfe, sorry, scratch the above ^^
13:34:19 *** mgielow has quit IRC
13:34:45 *** mgielow has joined #openmrs
13:49:29 *** pulasthi7 has joined #openmrs
13:51:15 <pulasthi7> hi suranga
13:51:31 <suranga> hi pulasthi7
13:51:49 <suranga> pulasthi7, hows everything going ?
13:52:11 <suranga> I ment to talk to you last night, but rememberd you usuallly travel home on friday
13:52:31 <pulasthi7> i'm done with the converting the report from flat file
13:52:54 <pulasthi7> and now doing the conversion of metadata
13:53:44 <pulasthi7> suranga, yes i was late when i came yesterday. saw your mail today morning :(
13:53:57 <suranga> pulasthi7, :)
13:54:21 <suranga> pulasthi7, nice, thats very fast
13:54:45 <suranga> pulasthi7, and also, could you please create a review of task -3 for us please ?
13:55:04 <pulasthi7> suranga, do you have an old configuration file that was stored in flat file?
13:55:26 <suranga> pulasthi7, Let me go look :)
13:56:21 <pulasthi7> suranga, by the time i had started, the stratergies had moved to databases
13:56:53 <suranga> pulasthi7, no worries, due to my policy of not erasing anything from my machine, I still have one with me :D
13:57:07 <suranga> you wanted the config.xml right ? with the strategies ?
13:57:19 <pulasthi7> suranga, yes
13:58:08 <suranga> pulasthi7, i've just emailed it over..
13:59:08 <pulasthi7> suranga, thanks. :-)
14:00:14 <suranga> pulasthi7, once moving metadata is completed, what more needs to be done for task -6 ?
14:01:49 <pulasthi7> suranga, converting the stratergies and add all of them to module startup
14:02:12 <suranga> pulasthi7, super nice :) :)
14:03:51 <pulasthi7> suranga, will you be online late night today?
14:04:12 <suranga> pulasthi7, oh yes late nights are my most productive times
14:05:39 <pulasthi7> suranga, i plan to finish task 6 by tonight (hopefully) and i don't have an understanding on how to do the task 4.
14:05:49 <pulasthi7> suranga, so i'll need your help
14:06:03 <suranga> pulasthi7, I see
14:06:38 <suranga> pulasthi7, it would be nice to start on task -4 soon. so i'll be around :)
14:07:39 <pulasthi7> suranga, ok, i'll be back in few hours :-)
14:07:55 <suranga> pulasthi7, sure, no problem :)
14:34:25 <suranga> hi bwolfe
14:34:44 <suranga> bwolfe, im really sorry about this, but i've mailed you a clarification :(
14:47:54 *** suranga has quit IRC
15:51:42 *** bwolfe has quit IRC
15:57:09 *** maurya has joined #openmrs
15:58:00 *** Maurya_ has joined #openmrs
15:58:18 *** applecool has joined #openmrs
15:58:18 *** ChanServ sets mode: +v applecool
15:59:08 *** ChanServ sets mode: +v Maurya_
15:59:27 *** Maurya_ has quit IRC
16:00:09 *** Maurya_ has joined #openmrs
16:01:32 *** maurya has quit IRC
16:03:53 *** Maurya_ is now known as maurya
16:04:12 *** ChanServ sets mode: +v maurya
16:08:32 *** applecool has quit IRC
16:15:14 *** applecool has joined #openmrs
16:15:14 *** ChanServ sets mode: +v applecool
16:31:23 *** srinath has joined #openmrs
16:31:28 <srinath> hi
16:31:58 <srinath> anyone here??
16:33:23 *** applecool has quit IRC
16:45:28 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Provider Management Module 1.0 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=providermanagement&ampversion=&amp1.0>
16:56:52 *** dkayiwa has joined #openmrs
17:03:19 <srinath> sure
17:05:24 <srinath> u here??
17:07:34 *** pulasthi7 has quit IRC
17:11:40 *** srinath has quit IRC
17:19:43 *** bwolfe has joined #openmrs
17:19:43 *** ChanServ sets mode: +o bwolfe
17:32:02 *** pushkar has joined #openmrs
17:32:08 <pushkar> bwolfe, Hi
17:34:00 *** suranga has joined #openmrs
17:34:00 *** ChanServ sets mode: +v suranga
17:34:08 <suranga> hi bwolfe
17:34:27 <suranga> bwolfe, now im (finally) gonna create the ticket for the ORURO1 template
17:47:47 *** pushkar has quit IRC
17:55:01 <bwolfe> suranga, isn't there one for it already?
17:55:15 <suranga> bwolfe, not really :)
17:56:19 <bwolfe> suranga ?
17:57:11 <suranga> bwolfe, we have tickets for all the other segments, but not for the ORUR01 template, which binds them all together, right ?
17:57:27 <bwolfe> suranga, remember to "Assess" the tickets by making htem "ready for work"
17:57:31 <bwolfe> yeah, I see that now.
17:58:26 *** djazayeri has joined #openmrs
17:58:26 *** ChanServ sets mode: +o djazayeri
17:59:53 <suranga> bwolfe, https://tickets.openmrs.org/browse/HLQRY-32 :-)
18:35:00 *** djazayeri has quit IRC
19:01:54 *** bwolfe has quit IRC
19:38:02 *** bwolfe has joined #openmrs
19:38:02 *** ChanServ sets mode: +o bwolfe
19:40:31 *** djazayeri has joined #openmrs
19:40:31 *** ChanServ sets mode: +o djazayeri
20:14:12 <maurya> djazayeri, hi
20:15:03 <maurya> djazayeri, got a minute?
20:21:09 <djazayeri> maurya: not really. if it's *very* fast, I can answer before leaving
20:21:19 <djazayeri> gotta run in 2 mins
20:21:38 <maurya> am getting a widget not registered error while submittin
20:21:45 <maurya> any ideas?
20:22:10 <maurya> djazayeri, ?
20:22:42 <djazayeri> maurya: did you actually register the widget when building the form?
20:23:03 <maurya> for our dynamic repeat
20:23:28 <djazayeri> maurya: you're not allowed to do this sort of this: "new XyzWidget().handleSubmission(httpRequest)"
20:23:58 <djazayeri> maurya: you have to have registered the widget building the form
20:24:36 <maurya> djazayeri, so we have to register the dynamicRepeat's template elements??
20:24:43 <djazayeri> maurya: yes
20:25:00 <maurya> djazayeri, okay:)
20:25:39 <djazayeri> maurya: (note that you shouldn't have to create new widgets on the fly when processing the submission. the idea is that you only need to register the template elements when we build the form, and then because of the "iteration" thing I added to FormEntryContext, it will automatically substitute in 0, 1, etc for -template.
20:25:44 <djazayeri> maurya: gotta ru
20:25:46 <djazayeri> gotta run
20:26:35 <maurya> djazayeri, okay :)thanks:)
20:32:03 *** maurya has quit IRC
20:33:23 *** djazayeri has quit IRC
20:33:54 *** djazayeri has joined #openmrs
20:33:54 *** ChanServ sets mode: +o djazayeri
20:35:04 *** dkayiwa has quit IRC
20:35:16 *** djazayeri has quit IRC
20:35:51 *** djazayeri has joined #openmrs
20:35:51 *** ChanServ sets mode: +o djazayeri
20:37:01 *** djazayeri has quit IRC
21:26:10 *** robbyoconnor has quit IRC
21:27:07 *** robbyoconnor has joined #openmrs
21:27:07 *** ChanServ sets mode: +v robbyoconnor
21:31:41 *** dkayiwa has joined #openmrs
21:46:19 *** djazayeri has joined #openmrs
21:46:19 *** ChanServ sets mode: +o djazayeri
22:04:46 *** djazayeri has quit IRC
22:19:40 *** dkayiwa has quit IRC
22:49:46 *** lakkarau has joined #openmrs
22:59:19 *** suranga has quit IRC
23:16:41 *** lakkarau has quit IRC