00:18:09
|
*** mccallumg has quit IRC
|
00:24:47
|
*** jordank has quit IRC
|
00:27:13
|
*** downey has joined #openmrs
|
00:27:13
|
*** ChanServ sets mode: +o downey
|
00:27:13
|
*** OpenMRSBot sets mode: +o downey
|
00:32:14
|
*** downey has quit IRC
|
00:42:43
|
*** downey has joined #openmrs
|
00:42:43
|
*** ChanServ sets mode: +o downey
|
00:42:43
|
*** OpenMRSBot sets mode: +o downey
|
00:51:48
|
*** harshadura has quit IRC
|
01:08:21
|
*** downey has quit IRC
|
01:26:38
|
*** downey has joined #openmrs
|
01:26:38
|
*** OpenMRSBot sets mode: +o downey
|
01:26:38
|
*** ChanServ sets mode: +o downey
|
01:39:10
|
*** harshadura has joined #openmrs
|
01:44:43
|
*** downey has quit IRC
|
02:13:44
|
*** bwolfe has joined #openmrs
|
02:13:44
|
*** ChanServ sets mode: +o bwolfe
|
02:27:24
|
*** jordank has joined #openmrs
|
02:43:45
|
*** jriley has left #openmrs
|
04:15:02
|
*** srinath has joined #openmrs
|
04:15:22
|
<srinath> hi
|
04:16:54
|
<bwolfe> hi srinath
|
04:19:55
|
*** harshadura has quit IRC
|
04:24:40
|
<srinath> anyone here??
|
04:25:15
|
<srinath> hi bwolfe
|
04:25:35
|
<srinath> i'm new here
|
04:25:36
|
<bwolfe> srinath, only awake for a few more minutes. got a quick question I can answer?
|
04:25:56
|
<srinath> i want to help where do i start
|
04:25:58
|
<srinath> ??
|
04:26:20
|
<bwolfe> thats a good question. :-)
|
04:26:39
|
<bwolfe> I assume you're a developer?
|
04:26:40
|
<bwolfe> https://wiki.openmrs.org/display/docs/Getting+Started+as+a+Developer
|
04:26:41
|
<OpenMRSBot> <http://ln-s.net/8bkO> (at wiki.openmrs.org)
|
04:34:54
|
*** bwolfe has quit IRC
|
04:42:05
|
*** harshadura has joined #openmrs
|
05:02:22
|
*** upul` has joined #openmrs
|
05:02:22
|
*** ChanServ sets mode: +v upul`
|
05:07:25
|
*** harshadura has quit IRC
|
05:13:04
|
*** suranga has joined #openmrs
|
05:13:04
|
*** ChanServ sets mode: +v suranga
|
05:15:28
|
*** djazayeri1 has joined #openmrs
|
05:17:08
|
*** djazayeri has quit IRC
|
05:19:35
|
*** srinath has quit IRC
|
05:38:37
|
*** applecool has joined #openmrs
|
05:38:55
|
*** ChanServ sets mode: +v applecool
|
05:39:16
|
*** suranga has quit IRC
|
05:39:55
|
*** suranga has joined #openmrs
|
05:39:57
|
*** srinath has joined #openmrs
|
05:43:05
|
*** jordank has quit IRC
|
05:43:37
|
<srinath> hi
|
05:43:42
|
<srinath> anyone here??
|
05:49:35
|
*** applecool has quit IRC
|
05:54:26
|
<srinath> guys anyone here i have a doubt regarding the setup
|
05:59:54
|
*** lh_afk is now known as lh
|
06:11:00
|
*** djazayeri1 has quit IRC
|
06:17:40
|
*** shortend has joined #openmrs
|
06:25:10
|
*** djazayeri has joined #openmrs
|
06:25:10
|
*** ChanServ sets mode: +o djazayeri
|
06:30:48
|
*** djazayeri has quit IRC
|
06:42:19
|
*** djazayeri has joined #openmrs
|
06:42:19
|
*** ChanServ sets mode: +o djazayeri
|
06:50:54
|
*** djazayeri has quit IRC
|
07:04:30
|
*** dkayiwa has joined #openmrs
|
07:08:00
|
*** harshadura has joined #openmrs
|
07:12:00
|
*** harshadura has quit IRC
|
07:12:20
|
*** harshadura has joined #openmrs
|
07:22:56
|
*** snoppy has joined #openmrs
|
08:05:26
|
*** rafa has joined #openmrs
|
08:05:26
|
*** ChanServ sets mode: +v rafa
|
09:00:00
|
*** srinath has quit IRC
|
10:15:18
|
*** applecool has joined #openmrs
|
10:15:18
|
*** ChanServ sets mode: +v applecool
|
10:21:02
|
<applecool> hey rafa
|
10:21:12
|
<rafa> applecool: hi
|
10:21:25
|
<applecool> i have a problem with that export options!
|
10:21:37
|
<applecool> any solution
|
10:22:19
|
<rafa> applecool: what is the problem?
|
10:22:33
|
<applecool> i am unable to remove that!
|
10:22:44
|
<applecool> displaytag.properties
|
10:22:59
|
<applecool> i tried adding export = false!
|
10:23:12
|
<applecool> export.pdf=false
|
10:23:12
|
<applecool> export.csv=false
|
10:23:13
|
<applecool> export.excel=false
|
10:23:15
|
<applecool> export.xml=false
|
10:24:19
|
<applecool> and i added these lines which removed the icons and the options! but the text "Export Options:" is still appearing!
|
10:30:06
|
*** suranga has quit IRC
|
10:32:28
|
*** applecool has quit IRC
|
10:45:29
|
*** applecool has joined #openmrs
|
10:45:29
|
*** ChanServ sets mode: +v applecool
|
10:45:35
|
<applecool> hey rafa
|
10:45:44
|
<applecool> sorry got disconnected!
|
10:45:46
|
<rafa> applecool: lost you
|
10:45:51
|
<applecool> yes
|
10:46:05
|
<rafa> applecool: did you set <display:tableexport="false"> ?
|
10:46:52
|
<rafa> applecool: <display:table..otherparamshere..export="false">
|
10:47:06
|
<applecool> understood! i missed that
|
10:47:26
|
<rafa> applecool: I mentioned that in a comment on a ticket...
|
10:49:48
|
<applecool> sorry i didnt get it that time! understood now
|
10:51:17
|
<rafa> applecool: np
|
10:55:10
|
*** upul` has quit IRC
|
11:09:58
|
<applecool> rafa: the border is not visible when width is 1 px
|
11:10:26
|
<rafa> applecool: it should be visible
|
11:10:29
|
<rafa> applecool: make it darker maybe
|
11:17:09
|
<applecool> that means can i change the color?
|
11:19:19
|
<applecool> the contrast between the border and the background color is too less; it is getting merged with it! so it is not visible! so does it mean can i change the color when you say make it "darker"
|
11:22:28
|
*** applecool has quit IRC
|
11:22:32
|
*** magoo_ has joined #openmrs
|
11:23:17
|
*** applecool has joined #openmrs
|
11:23:17
|
*** ChanServ sets mode: +v applecool
|
11:24:44
|
<applecool> rafa:
|
11:24:45
|
<applecool> there?
|
11:25:08
|
<rafa> applecool: haha yes, change the color
|
11:25:26
|
<applecool> should i put black? :P
|
11:25:38
|
<rafa> applecool: no, I didn't like black :P
|
11:26:31
|
<applecool> rafa: which shade? i mean yellowish , bluish , reddish :D
|
11:26:38
|
*** rfriedman has joined #openmrs
|
11:26:53
|
<rafa> applecool: yellowish but darker ;)
|
11:27:06
|
*** bwolfe has joined #openmrs
|
11:27:06
|
*** ChanServ sets mode: +o bwolfe
|
11:27:41
|
<rafa> see https://wiki.openmrs.org/display/docs/Liquibase
|
11:27:43
|
*** jportela has joined #openmrs
|
11:27:43
|
*** ChanServ sets mode: +v jportela
|
11:27:48
|
*** jportela has quit IRC
|
11:27:55
|
<rafa> applecool: make it the same as the yellow box on that page :D
|
11:29:18
|
<rafa> bwolfe: what was the html tag for same width letters and not wrapped lines?
|
11:29:24
|
<applecool> yellow box? which one rafa :P
|
11:29:33
|
<bwolfe> {code} ?
|
11:29:49
|
<bwolfe> or straight html is <pre>
|
11:30:00
|
<rafa> applecool: go to that page, there's only one saying "By default Liquibaserunner uses the liquibaserunner MySQL..."
|
11:30:06
|
<bwolfe> {code} something here {code} is for confluence
|
11:30:06
|
<rafa> bwolfe: <pre>!
|
11:30:18
|
<rafa> bwolfe: that is what I needed :D
|
11:30:24
|
<rafa> bwolfe: thx
|
11:31:21
|
<bwolfe> np
|
11:40:02
|
<applecool> rafa: i have sent you the screen shot
|
11:40:34
|
<applecool> i was unable to access the tickets.openmrs.org! so i sent you the screenshot by mail
|
11:40:38
|
<applecool> rafa:
|
11:40:51
|
<rafa> applecool: it's ok
|
11:40:55
|
<rafa> applecool: move on :D
|
11:41:00
|
<applecool> is it good?
|
11:41:05
|
<rafa> applecool: yes
|
11:41:07
|
<applecool> okay!
|
11:41:09
|
<applecool> :)
|
12:11:10
|
<applecool> rafa: wil be back!
|
12:11:13
|
<applecool> bye cya
|
12:11:16
|
*** applecool has quit IRC
|
12:16:05
|
*** wluyima has quit IRC
|
12:16:45
|
*** wyclif has quit IRC
|
12:23:02
|
<shortend> I'm trying to do the UI Framework tutorial and can't get my first page to load.
|
12:23:46
|
<shortend> Is there a way that I can tell if the -DuiFramework.development.yourmoduleid
|
12:23:50
|
<shortend> is actually working?
|
12:24:37
|
<shortend> I have my page in omod/web/module/pages/
|
12:36:08
|
<bwolfe> you only need that if you want to do instant reloading
|
12:36:26
|
<bwolfe> but you should be able to edit a jsp or groovy template and see it show up in the webapp by just refreshing the browser page
|
12:36:52
|
*** jkeiper_ has joined #openmrs
|
12:43:42
|
<shortend> bwolfe: Thanks. The tutorial indicates that if I place a myPage.gsp file under omod/src/main/webapp/pages that I can access them under http://.../openmrs/pages/myPage.page
|
12:44:24
|
<shortend> That's not working, so I'm just wondering what I'm doing wrong. Do I have to package up my omod and load it once before it can work?
|
12:45:15
|
<bwolfe> shortend, yes, you have to load it once
|
12:45:43
|
<shortend> bwolfe: Thanks.
|
12:50:34
|
<bwolfe> dkayiwa, you're killing my inbox with your tickets. :-)
|
12:50:48
|
<bwolfe> dkayiwa, are you adding me as a watcher to all of these, or am I just watching that many tickets?
|
12:51:02
|
<dkayiwa> bwolfe: do not worry. curation sprint ending today :)
|
12:51:23
|
<dkayiwa> bwolfe: am adding you for like 70% :)
|
12:52:33
|
<bwolfe> dkayiwa, like this one? https://tickets.openmrs.org/browse/RCM-32 or was I already a watcher there?
|
12:53:24
|
<dkayiwa> bwolfe: i think i just added you on that :)
|
12:53:27
|
<bwolfe> or like this one: https://tickets.openmrs.org/browse/REPORT-347
|
12:53:33
|
<bwolfe> I don't need to know about all of the tickets...
|
12:53:37
|
*** jkeiper has joined #openmrs
|
12:53:44
|
<rafa> dkayiwa: me too :D
|
12:53:51
|
<dkayiwa> rafa: :D
|
12:54:05
|
<bwolfe> we trust your judgement and any research you did on a ticket
|
12:54:15
|
<dkayiwa> bwolfe: rafa may be we can add that too on the curation wiki page :D
|
12:54:39
|
<bwolfe> if you cna't reproduce it, great! close it. if you curated it, perfect! if you close it as won't fix, you can add me as confirmation if you want.
|
12:54:53
|
<dkayiwa> bwolfe: ok
|
12:54:54
|
<bwolfe> dkayiwa, the curation wiki page doesn't say "add all devs as watchers" because you shouldn't... :-)
|
12:55:17
|
<bwolfe> I would say add me as a watcher for 1 out of 5 tickets. add rafa as 1 out of 15
|
12:55:37
|
<dkayiwa> bwolfe: i meant that it could add, "you do not need to add all devs as watchers" :)
|
12:55:46
|
<bwolfe> dkayiwa, you must have more confidence in yourself. you are able to answer questions, read comments, make decisions.
|
12:56:01
|
<bwolfe> if it seems like a decision was made, update the description and move on. the comments don't have to be the ones to do the final updates
|
12:56:14
|
<dkayiwa> bwolfe: ok :)
|
12:56:24
|
<bwolfe> if there seems to be a concensus (but no final) you can come to that conclusion and change the desc yourself
|
12:56:34
|
<dkayiwa> bwolfe: ok
|
12:57:14
|
<bwolfe> dkayiwa, why did you think we all want to be watchers? its better to pretend like openmrs has 25 employees instead of just 5. if we had 25, you wouldn't think to add rafa/wyclif/darius/me/mike to every ticket...
|
12:57:38
|
<dkayiwa> bwolfe: hahahaha :)
|
12:58:41
|
<dkayiwa> bwolfe: rafa the next curation sprint will be smoother for you guys :)
|
12:59:13
|
<rafa> dkayiwa: is there anything left or you did them all? ;)
|
12:59:48
|
<dkayiwa> rafa: never did even 20%, they are just too many!!! :)
|
13:02:30
|
<bwolfe> "needs assessment in core projects" is down to only 150
|
13:03:27
|
<bwolfe> and the second half of htem are all reporting tickets
|
13:03:53
|
<dkayiwa> more than half for reporting :)
|
13:04:37
|
<bwolfe> 105 reporting tickets!
|
13:04:41
|
<bwolfe> wow
|
13:04:45
|
<bwolfe> (in needs assessment)
|
13:05:15
|
*** wluyima has joined #openmrs
|
13:05:17
|
*** wyclif has joined #openmrs
|
13:05:24
|
<shortend> I've got my module loaded, as well as the uiframework module. I can see my helloWorld.gsp in my .omod under web/module/pages
|
13:05:46
|
<shortend> I'm getting "Could not find page view 'helloWorld' in any of the view providers"
|
13:05:56
|
*** lakkarau has joined #openmrs
|
13:05:56
|
<dkayiwa> bwolfe: and reporting module tickets are not that easy to curate :)
|
13:08:27
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Metadata Sharing 1.0.8 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=metadatasharing&version=&1.0.8>
|
13:11:15
|
<rafa> bwolfe: I'm creating a review and seeing you as Ben Wolfe (deleted user)
|
13:11:26
|
<rafa> bwolfe: do you know something about this?
|
13:12:35
|
<shortend> OK, it's working. Must have refreshed something.
|
13:12:43
|
<bwolfe> shortend, yay!
|
13:12:43
|
<rafa> bwolfe: same for darius
|
13:12:52
|
<bwolfe> rafa, there is "ben" and then "bwolfe". use the latter
|
13:13:23
|
<rafa> bwolfe: i see only bwolfe_old1
|
13:13:32
|
<rafa> bwolfe: and it's the one marked as deleted user
|
13:14:21
|
<bwolfe> strange
|
13:14:22
|
<bwolfe> link?
|
13:14:50
|
<rafa> https://source.openmrs.org/cru/CR-TRUNK-683
|
13:15:32
|
<rafa> bwolfe: ohh now I see internal server error too :D
|
13:16:14
|
*** downey has joined #openmrs
|
13:16:14
|
*** ChanServ sets mode: +o downey
|
13:16:14
|
*** OpenMRSBot sets mode: +o downey
|
13:16:15
|
<rafa> bwolfe: I think crucible needs a kick :D
|
13:16:21
|
<bwolfe> yes, https://source.openmrs.org/browse/~br=trunk/Modules/formentry/trunk/web/src/org/openmrs/module/formentry/web/FormDownloadServlet.java?r1=13581&r2=17177
|
13:16:32
|
<downey> hmm
|
13:19:35
|
*** magoo_ has quit IRC
|
13:20:31
|
<downey> rafa: looks like he struggled when adding the git indexing. i'm restarting for now and will try to increase the ulimit
|
13:21:28
|
<rafa> downey: ok, thanks
|
13:27:26
|
<downey> rafa: should be back now
|
13:28:11
|
<rafa> downey: yes, but I still can't add bwolfe to reviewers
|
13:28:20
|
<rafa> bwolfe: can you join https://source.openmrs.org/cru/CR-TRUNK-683?
|
13:28:46
|
<bwolfe> dkayiwa, https://tickets.openmrs.org/browse/RCM-14 == new feature. you can move that without commenting. :-) even mseaton mistypes a bug/feature every so often.
|
13:28:59
|
<bwolfe> am I still a deleted user rafa?
|
13:29:04
|
<dkayiwa> bwolfe: ok :)
|
13:29:04
|
<rafa> bwolfe: yes :)
|
13:29:41
|
<downey> interesting
|
13:38:52
|
*** shortend has left #openmrs
|
13:40:14
|
<downey> bwolfe: are you able to log in to fisheye
|
13:41:28
|
<bwolfe> yes, and I've joined https://source.openmrs.org/cru/CR-TRUNK-683
|
13:41:40
|
<bwolfe> downey, where did bwolfe_old1 come from?
|
13:41:59
|
<downey> bwolfe: i believe you were temporarily un-synced from the directory until you re-logged in
|
13:43:41
|
<bwolfe> rafa, downey, did one of you remove bwolfe_old1 from the review?
|
13:43:47
|
<downey> i just did
|
13:44:18
|
<bwolfe> oh ok
|
13:48:48
|
*** magoo_ has joined #openmrs
|
13:52:13
|
*** harshadura has quit IRC
|
13:56:22
|
*** cpower has joined #openmrs
|
14:00:58
|
*** jkeiper_ is now known as chopin
|
14:01:06
|
*** pushkar has joined #openmrs
|
14:01:07
|
*** chopin has quit IRC
|
14:01:07
|
*** jkeiper has quit IRC
|
14:03:20
|
*** magoo_ has quit IRC
|
14:03:22
|
<cpower> good morning everyone
|
14:03:30
|
<cpower> Scrum time?
|
14:04:00
|
<dkayiwa> morning cpower :)
|
14:05:38
|
<rafa> hi cpower
|
14:06:14
|
<cpower> let's scrum
|
14:06:21
|
<cpower> !scrumon cpower
|
14:06:21
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
14:07:12
|
<cpower> Order: Lakkarau, wyclif, dkayiwa, bwolfe, rafa
|
14:07:23
|
<lakkarau> thursday:
|
14:07:41
|
<lakkarau> trunk:3491--getting errors
|
14:07:48
|
<lakkarau> friday:
|
14:08:04
|
<rafa> !ticket TRUNK-3491
|
14:08:05
|
<OpenMRSBot> rafa: [#TRUNK-3491] Write to independent log file - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3491
|
14:08:15
|
<lakkarau> trying to recover my application and work on trunk-3491
|
14:08:33
|
<wluyima> Thursday:
|
14:08:34
|
<wluyima> curate tickets
|
14:08:34
|
<wluyima> dev call
|
14:08:34
|
<wluyima> more wiki documentation update
|
14:08:34
|
<wluyima> Error logging code review
|
14:08:34
|
<wluyima> Friday:
|
14:08:36
|
<wluyima> curate ticket
|
14:08:38
|
<wluyima> weekly skype call with Dmitry
|
14:08:40
|
<wluyima> Blockers: None
|
14:08:43
|
<dkayiwa> Curated tickets
|
14:08:44
|
<dkayiwa> Still Curating more tickets
|
14:08:44
|
<dkayiwa> No Blockers
|
14:08:53
|
*** wluyima has quit IRC
|
14:09:08
|
*** wluyima has joined #openmrs
|
14:09:08
|
<bwolfe> lakkarau, so 3491 is still a blocker for you. lets discuss after the scrum
|
14:09:25
|
*** wluyima has quit IRC
|
14:09:28
|
*** wyclif has quit IRC
|
14:09:42
|
*** wyclif has joined #openmrs
|
14:09:45
|
<lakkarau> bwolfe:yes
|
14:09:51
|
<bwolfe> Thursday
|
14:09:51
|
<bwolfe> triaged two ERR tickets
|
14:09:51
|
<bwolfe> triaged/curated a few trunk tickets
|
14:09:51
|
<bwolfe> reviewed TRUNK-3491 for Uma
|
14:09:51
|
<bwolfe> reviewed pushkar's module
|
14:09:51
|
<bwolfe> created/reviewed/modified tickets for next week's sprint
|
14:09:53
|
<bwolfe> dev call
|
14:09:55
|
<bwolfe> ldrship call
|
14:09:57
|
<bwolfe> Friday
|
14:09:59
|
<bwolfe> update obs/value group wiki pages
|
14:10:01
|
<bwolfe> review tickets for hl7 query module sprint next week
|
14:10:03
|
<bwolfe> emails
|
14:10:07
|
<bwolfe> review curations
|
14:10:09
|
<bwolfe> investigate FORM-104
|
14:10:11
|
<bwolfe> call with easycloud
|
14:10:13
|
<bwolfe> review wiki page for next sprint
|
14:11:25
|
<rafa> bwolfe: No blockers. are the key words I'm waiting for :D
|
14:11:44
|
<dkayiwa> :D
|
14:12:16
|
<lakkarau> bwolfe:can i ping you after i reach office.
|
14:12:27
|
<cpower> ok, so that's that.
|
14:12:30
|
<rafa> Today:
|
14:12:30
|
<rafa> * Back ported TRUNK-2767: Concept name searches uses the slower ilike
|
14:12:31
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-2767
|
14:12:31
|
<rafa> * Committed:
|
14:12:31
|
<rafa> + META-229: Provide a method like getMetadata(Class, String uuid)
|
14:12:31
|
<bwolfe> hapana kuacha
|
14:12:31
|
<rafa> https://tickets.openmrs.org/browse/META-229
|
14:12:31
|
<rafa> + META-237: More intuitive name for packages that you download from MDS
|
14:12:32
|
<rafa> https://tickets.openmrs.org/browse/META-237
|
14:12:32
|
<rafa> + META-215: Improve layout for error messages in export
|
14:12:33
|
<rafa> https://tickets.openmrs.org/browse/META-215
|
14:12:33
|
<rafa> + META-242: Fix release configuration
|
14:12:34
|
<rafa> https://tickets.openmrs.org/browse/META-242
|
14:12:34
|
<rafa> * Released MDS 1.0.8 with support for Concepts in 1.9
|
14:12:35
|
<rafa> * Back to TRUNK-3319: Person attribute autofill shows nothing if concept name doesn't exist in users' language
|
14:12:35
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-3319
|
14:12:36
|
<rafa> No blockers.
|
14:12:48
|
<bwolfe> lakkarau, yes, in 1 hours time?
|
14:12:49
|
<rafa> haha what?
|
14:13:14
|
<cpower> Discussion: nada.. Blockers 3941
|
14:13:18
|
<cpower> !scrumoff
|
14:13:18
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
14:13:52
|
*** wyclif has quit IRC
|
14:14:16
|
*** wyclif has joined #openmrs
|
14:18:16
|
*** magoo_ has joined #openmrs
|
14:19:06
|
<bwolfe> lakkarau, when will you be in the office approx?
|
14:21:20
|
<lakkarau> bwolfe:i will be there at 9:15 PST
|
14:22:37
|
<bwolfe> ok, so 2 hours
|
14:22:40
|
<bwolfe> ping me then
|
14:25:02
|
<downey> bwolfe (and anyone else): would you agree with this statement? "Code review wait times are, I think, one of the best and simplest metrics from a developers perspective… it probably says a lot about both the health of the community and quality of its management. There are some subtleties that I'd put into that, but think it would be a good start."
|
14:26:25
|
<bwolfe> from a volunteer dev's perspective?
|
14:26:42
|
<downey> any developer
|
14:28:41
|
<downey> the underlying statement being that the time between when someone shares some code/patch/etc and it's fully-reviewed/committed/ok'd indicates how well the wheels are turning on the open source machine :)
|
14:33:31
|
*** applecool has joined #openmrs
|
14:33:31
|
*** ChanServ sets mode: +v applecool
|
14:42:15
|
*** maurya has joined #openmrs
|
14:56:07
|
<bwolfe> downey, yes and no
|
14:56:12
|
<bwolfe> I think time to first review is
|
14:56:23
|
<bwolfe> the time to commit then depends on how fast the dev responds to the first review
|
14:57:41
|
<downey> good point
|
14:58:20
|
*** magoo_ has quit IRC
|
14:59:25
|
*** lakkarau has quit IRC
|
15:04:17
|
*** lh has quit IRC
|
15:04:57
|
*** lh has joined #openmrs
|
15:04:57
|
*** lh has joined #openmrs
|
15:09:07
|
*** dkayiwa has left #openmrs
|
15:10:39
|
*** rafa has quit IRC
|
15:10:44
|
*** maurya has quit IRC
|
15:24:33
|
*** jordank has joined #openmrs
|
15:29:36
|
*** harshadura has joined #openmrs
|
15:33:22
|
*** djazayeri has joined #openmrs
|
15:33:22
|
*** ChanServ sets mode: +o djazayeri
|
15:42:17
|
*** maurya has joined #openmrs
|
15:45:22
|
*** djazayeri1 has joined #openmrs
|
15:45:25
|
*** djazayeri has quit IRC
|
15:46:21
|
*** djazayeri1 has quit IRC
|
15:53:51
|
*** harshadura has quit IRC
|
15:54:03
|
*** harshadura has joined #openmrs
|
15:54:26
|
*** lhawthor_ has joined #openmrs
|
15:54:55
|
*** lh has quit IRC
|
15:55:05
|
*** lhawthor_ is now known as lh
|
15:55:23
|
*** lhawthor_ has joined #openmrs
|
15:55:25
|
*** lh has quit IRC
|
15:55:25
|
*** lh has joined #openmrs
|
16:04:02
|
*** kreddy has joined #openmrs
|
16:04:18
|
*** bwolfe has quit IRC
|
16:05:17
|
*** djazayeri has joined #openmrs
|
16:05:17
|
*** ChanServ sets mode: +o djazayeri
|
16:14:34
|
*** jordank has left #openmrs
|
16:14:42
|
*** jordank has joined #openmrs
|
16:14:42
|
*** jordank has left #openmrs
|
16:14:59
|
*** jordank has joined #openmrs
|
16:17:35
|
*** bwolfe has joined #openmrs
|
16:17:35
|
*** ChanServ sets mode: +o bwolfe
|
16:21:04
|
*** harshadura has quit IRC
|
16:31:02
|
*** applecoo_ has joined #openmrs
|
16:33:47
|
*** applecool has quit IRC
|
16:36:34
|
*** suranga has joined #openmrs
|
16:36:34
|
*** ChanServ sets mode: +v suranga
|
16:37:39
|
<suranga> bwolfe, hi
|
16:37:45
|
<suranga> bwolfe, sorry about this
|
16:37:54
|
<suranga> just tied up some Jembi stuff.. :(
|
16:40:17
|
<bwolfe> suranga, sorry about what?
|
16:41:23
|
<suranga> bwolfe, :)
|
16:41:58
|
<suranga> bwolfe, from your viewpoint, whats the most noteworthy limitation in our sprint plannin so far ?
|
16:42:40
|
<bwolfe> what do you mean?
|
16:43:30
|
<bwolfe> lhawthor_, bad news. your n got flattened
|
16:43:57
|
*** lh has quit IRC
|
16:43:59
|
*** lhawthor_ is now known as lh
|
16:44:07
|
*** lh has joined #openmrs
|
16:44:23
|
*** lhawthor_ has joined #openmrs
|
16:44:23
|
<lh> bwolfe, i know, how cruel. i like my n.
|
16:45:23
|
<suranga> bwolfe, I mean, our planning, writing sprint tickets, missing wiki pages etc. etc.
|
16:45:35
|
<djazayeri> suranga: do we have a concise basic overview of our sprint deliverable yet?
|
16:45:56
|
<suranga> bwolfe, djazayeri i keep getting the impression that we are not 100% prepared
|
16:46:01
|
<bwolfe> djazayeri, yeah, he wrote that, I haven't had a chance to look at it yet though
|
16:46:56
|
<suranga> bwolfe, djazayeri regarding the deliverables, I have one importaint question,
|
16:47:08
|
<bwolfe> suranga, whats missing now? I think we need to make sure there is a clear message to those people that havne't been following the design
|
16:47:15
|
<bwolfe> so we need to make sure the wiki pages are clear and not conflicting
|
16:47:28
|
<bwolfe> and that the tickets are separated completed and defined well so we don't have to answer a bunch of questions
|
16:48:03
|
*** snoppy has left #openmrs
|
16:48:11
|
<suranga> bwolfe, djazayeri oh, now I get it. when I said "sorry about this
|
16:48:12
|
<suranga> , just tied up some Jembi stuff.. " earlier, I meant that I could not come online because I was fixing a bug...
|
16:48:20
|
<suranga> bwolfe, let me go write up that question
|
16:49:04
|
*** lakkarau has joined #openmrs
|
16:49:44
|
*** applecoo_ is now known as applecool
|
16:49:45
|
*** ChanServ sets mode: +v applecool
|
16:51:23
|
<suranga> bwolfe, djazayeri
|
16:51:24
|
<suranga> One remaing (and more importaint) ticket is the ticket to create the actual ORURO1 template.
|
16:51:24
|
<suranga> this will be calling alll our other templates
|
16:51:24
|
<suranga> Im confident with OBR OBX layouts
|
16:51:24
|
<suranga> but according to Dr. brueks ideas of multiple PVI PID segments, Im rather clueless, because I didnt do it that way. So I cant write this part of the ticket until I write some similar code, and am familiar with how it actually looks
|
16:54:24
|
<djazayeri> suranga: shouldn't the ORUR01 template be trivial based on the other templates?
|
16:54:58
|
<suranga> djazayeri, it is, the problem is that the ORRr01 template is responsbile for the when + how many times question
|
16:55:28
|
<suranga> djazayeri, its responsible for saying "call this segment at this time, 5 times, etc.)
|
16:57:32
|
<djazayeri> suranga: yeah, it's something like
|
16:57:32
|
<djazayeri> includeTemplate("MSH")
|
16:57:33
|
<djazayeri> includeTemplate("...")
|
16:57:33
|
<djazayeri> encounter.each { e ->
|
16:57:33
|
<djazayeri> includeTemplate("PID", [ patient: patient ])
|
16:57:33
|
<djazayeri> includeTemplate("PV1", [ encounter: e ])
|
16:57:33
|
<djazayeri> e.obs.each {
|
16:57:34
|
<djazayeri> ...
|
16:57:34
|
<djazayeri> }
|
16:57:35
|
<djazayeri> }
|
16:57:56
|
<suranga> bwolfe, djazayeri I want to test by writing this code myself
|
16:58:26
|
<djazayeri> suranga: this is a great place for test-driven-development, as I said a while back. :-)
|
16:58:52
|
<djazayeri> suranga: I don't think you have time to actually write all the code first for test purposes (and that's not necessary either)
|
16:59:48
|
<suranga> bwolfe, djazayeri agreed, but i wont be able to direct the order of the segments unless I know where they go. that may be a problem for whoever ends up wrting the code ?
|
17:00:30
|
<djazayeri> suranga: I think you need to sketch out the ORUR01 as pseudocode, and continue to break that down into sub-templates, etc.
|
17:00:43
|
*** snoppy has joined #openmrs
|
17:00:45
|
*** cpower has quit IRC
|
17:00:51
|
<suranga> djazayeri, hmmm
|
17:00:53
|
<djazayeri> suranga: and make sure there are tickets for each
|
17:00:59
|
*** lh has quit IRC
|
17:01:02
|
*** lhawthor_ is now known as lh
|
17:01:05
|
<suranga> djazayeri, other than this, do you notice anything missing ? :)
|
17:01:10
|
*** lh has quit IRC
|
17:01:10
|
*** lh has joined #openmrs
|
17:01:17
|
<djazayeri> suranga: but I think you've actually already done this, although you don't seem to think you have. :-)
|
17:01:24
|
*** lhawthor_ has joined #openmrs
|
17:01:38
|
<djazayeri> suranga: I haven't looked that closely, but I'd echo bwolfe and say that you need:
|
17:01:55
|
*** lh has quit IRC
|
17:01:57
|
*** lhawthor_ is now known as lh
|
17:01:58
|
<suranga> djazayeri, i've done almost 80% of it :)
|
17:02:01
|
<djazayeri> * the overview wiki page, to give people an intro
|
17:02:05
|
*** lh has quit IRC
|
17:02:05
|
*** lh has joined #openmrs
|
17:02:13
|
<djazayeri> * there should be no _other_ confusing wiki pages
|
17:02:21
|
*** lhawthor_ has joined #openmrs
|
17:03:01
|
<djazayeri> * tickets for the "framework" things (data model, API, template processor, etc)
|
17:03:13
|
<djazayeri> * ticket for the controller
|
17:03:22
|
<djazayeri> * tickets for the actual message and segments
|
17:04:11
|
*** lh has quit IRC
|
17:04:12
|
<suranga> ahaaa...
|
17:04:14
|
*** lhawthor_ is now known as lh
|
17:04:21
|
*** lh has joined #openmrs
|
17:04:33
|
*** lhawthor_ has joined #openmrs
|
17:05:00
|
<djazayeri> suranga: I haven't looked closely, but I am a bit concerned about the tickets for templates for messages/segments, to ensure the tickets are well-written.
|
17:05:17
|
<djazayeri> suranga: I mean that they are understandable to someone new, and they're not totally overlapping
|
17:06:16
|
<suranga> hmm.... djazayeri, since i've attached an example message, they can just compare their output with my output. for example, does my PID segment match with suranga's version ?
|
17:07:26
|
<bwolfe> suranga, the TemplateFunctions ticket needs some focus.
|
17:07:50
|
<djazayeri> suranga: is there a sprint dashboard yet?
|
17:08:01
|
<suranga> bwolfe, is this the ticket responsible for building the entire ORUR01 message ?
|
17:08:09
|
<suranga> djazayeri, yes, let me get the link
|
17:08:36
|
<suranga> djazayeri, https://tickets.openmrs.org/browse/HLQRY
|
17:08:57
|
<bwolfe> suranga, no, the ticket that has the TemplateFunctions in the title. :-p
|
17:09:21
|
*** lhawthor_ has quit IRC
|
17:09:22
|
<bwolfe> suranga, no, not that one
|
17:09:26
|
*** lh has quit IRC
|
17:09:28
|
<suranga> bwolfe, sorry, /me goes to look
|
17:09:33
|
<bwolfe> it is not linked
|
17:09:41
|
*** lh has joined #openmrs
|
17:09:41
|
*** lh has joined #openmrs
|
17:09:42
|
<bwolfe> that was on my todo list today if kreddy hadn't done it yet
|
17:09:50
|
<bwolfe> lakkarau, are you in the office?
|
17:09:52
|
<lakkarau> bwolfe: i am trying to recover my appplication.at this point i have coded but the application failed.
|
17:10:20
|
<bwolfe> what do you mean by recover your application?
|
17:10:32
|
<lakkarau> bwolfe:trunk application
|
17:10:36
|
<djazayeri> suranga: you need to create a *sprint* dashboard
|
17:10:38
|
<bwolfe> ok...
|
17:10:44
|
<bwolfe> lakkarau, how did it fail? what is the issue? can we help?
|
17:10:49
|
<djazayeri> suranga: see https://wiki.openmrs.org/display/RES/Being+a+Sprint+Leader
|
17:11:00
|
<djazayeri> suranga: see also dashboards for recent sprints
|
17:12:42
|
<lakkarau> bwolfe:i am trying.giving it time to work
|
17:13:24
|
<lakkarau> bwolfe:Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.1:compile (default-compile) on project openmrs-api: Compilation failure
|
17:13:25
|
<lakkarau> [ERROR] \testWS\openmrs\api\src\main\java\org\openmrs\util\OpenmrsUtil.java:[2584,0] reached end of file while parsing
|
17:13:25
|
<lakkarau> [ERROR] -> [Help 1]
|
17:18:06
|
*** maurya has quit IRC
|
17:19:57
|
<pushkar> bwolfe, what's the difference between willRefreshContext() and contextRefreshed() in drawing Activator ?
|
17:20:23
|
<djazayeri> pushkar: the first is called before the context is refreshed, the second is called after
|
17:21:31
|
<bwolfe> lakkarau, if you are trying for more than a few hours, ask for help.
|
17:21:46
|
<bwolfe> lakkarau, that goes for any debugging, setting up, connecting, design, coding. everything
|
17:22:21
|
<bwolfe> because we all work separately, we don't know if someone is stuck. please feel free to start questions here about any issue sooner rather than later
|
17:22:35
|
<bwolfe> lakkarau, (You DON'T have to wait until the next days scrum)
|
17:23:14
|
<pushkar> bwolfe, what happens when the context gets refreshed ?
|
17:23:44
|
<bwolfe> lakkarau, have you made changes in your OpenmrsUtil class? If so, right click --> replace with --> base revision takes it back to what is in svn
|
17:23:50
|
<bwolfe> lakkarau, or just try to do a clean build
|
17:23:53
|
<bwolfe> or a clean in eclipse
|
17:23:59
|
<bwolfe> pushkar, thats the spring context
|
17:24:13
|
<bwolfe> every time a module is loaded, spring is "restarted" (aka the context is refreshed)
|
17:24:18
|
<lakkarau> bwolfe:i am trying the same.
|
17:24:30
|
<bwolfe> that means the spring xml files are re-read and take the new module spring files into account
|
17:25:13
|
<pushkar> bwolfe, is it something like existing modules get unloaded and reloaded ??
|
17:25:59
|
<bwolfe> yeah, all objects in openmrs are essentially destroyed when a new module is installed
|
17:26:17
|
<bwolfe> the OpenmrsClassloader is garbagecollected and recreated
|
17:26:53
|
<pushkar> I am asking this because If I say Context.getService(HtmlFormEntryService.class) in willRefreshContext I am getting the reference to service class if I am doing the same call in contextRefreshed() method I am getting null
|
17:29:35
|
<suranga> bwolfe, djazayeri : my dashboard : https://tickets.openmrs.org/secure/Dashboard.jspa?selectPageId=12051
|
17:29:44
|
<bwolfe> kreddy, did you create the sprint dashboard already for next week?
|
17:29:59
|
<bwolfe> (I don't want two fo them floating out there...)
|
17:30:27
|
<pushkar> bwolfe, Is it supposed to work like that I should get the reference to serviceeven if do the Context.getService(HtmlFormEntryService.class) in contextRefreshed() right ?
|
17:30:44
|
<bwolfe> suranga, which dashboard did you start from? there has been a common sprint dashboard layout we've used. are those not linked to?
|
17:31:25
|
<bwolfe> pushkar, yes, it is supposed to work
|
17:31:39
|
<bwolfe> pushkar, and it does work for me. I am able to load your 1.0 released omod on my 1.10 instance
|
17:32:09
|
<suranga> bwolfe, the 'sprint leader page points to two examples :
|
17:32:17
|
<pushkar> bwolfe, yes its loading but the html tag is not getting registered
|
17:32:28
|
<suranga> https://tickets.openmrs.org/secure/Dashboard.jspa?selectPageId=10132 and https://tickets.openmrs.org/secure/Dashboard.jspa?selectPageId=10140
|
17:32:29
|
<bwolfe> pushkar, ah
|
17:32:33
|
<OpenMRSBot> <http://ln-s.net/8qD3> (at tickets.openmrs.org)
|
17:33:00
|
<suranga> bwolfe, is this what u want ? https://tickets.openmrs.org/secure/Dashboard.jspa?selectPageId=11751
|
17:33:08
|
<bwolfe> suranga, those are older, we should change that to something newer..
|
17:33:16
|
<pushkar> bwolfe, the <drawing /> tag its not getting registered
|
17:33:24
|
<bwolfe> yes, suranga, like that restws one
|
17:33:40
|
<bwolfe> that restws one is a good one to copy for this module
|
17:34:36
|
<pushkar> bwolfe, As soon as you upload the module you will this message in the log "failed to register drawing tag""
|
17:34:44
|
<bwolfe> pushkar, that sounds like an issue with HFE. where were you registering before that it was working?
|
17:35:41
|
<pushkar> if I register that in contextRefreshed() its not working If I do it in willRefreshContext() its working
|
17:35:43
|
<pushkar> bwolfe,
|
17:37:08
|
<bwolfe> strange
|
17:37:34
|
<bwolfe> suranga, are you changing your sprint dashboard?
|
17:37:43
|
<suranga> bwolfe, oh yes :)
|
17:37:47
|
<bwolfe> if/when you get it done, make sure you link to it from here: https://wiki.openmrs.org/display/RES/Export+of+HL7+Messages+Sprint
|
17:38:03
|
<suranga> bwolfe, cool, will do that
|
17:39:31
|
<pushkar> bwolfe, soo strange
|
17:40:47
|
<bwolfe> suranga, djazayeri, I think the easiest solution to the debate of how to do the ORU_R01 is to just make two templates. the user can choose which one they like better. we can prioritize the one that is in suranga's message guide (ORU + OBRs I think)
|
17:41:10
|
<djazayeri> bwolfe, suranga: is there actually a debate about this?
|
17:41:33
|
<suranga> djazayeri, we debate everything :)
|
17:41:43
|
<bwolfe> seems to be last I looked at the thread...I was avoiding getting involved in it for lack of experience
|
17:41:56
|
<suranga> djazayeri, but seriously, other people may want to write their own templates to manage obr + obx
|
17:42:23
|
<suranga> bwolfe, for now, we can have one template, right ? or do you want us to write both ?
|
17:42:28
|
<djazayeri> suranga, bwolfe: for purposes of this sprint, we should build the thing that's the inverse of how our ORUR01 processor works
|
17:42:48
|
<djazayeri> others can obviously write their own templates later. That's the whole point of the sprint.
|
17:44:01
|
<suranga> djazayeri, bwolfe small problem. the OpenmRS oRur01 handler receives just one encounter at a time, while ours may receive many encounters in a single message. theefore, we cant emulate the openmre core class altogether...
|
17:44:24
|
<djazayeri> suranga: right, but in terms of what the OBR/OBX looks like, we can emulate
|
17:44:40
|
<suranga> djazayeri, sounds good :)
|
17:44:45
|
*** rfriedman has quit IRC
|
17:44:45
|
<djazayeri> suranga: we just repeat the PID + PV1 + (OBR + OBX)+ for each encounter
|
17:46:28
|
<suranga> djazayeri, (nod)
|
17:47:56
|
*** maurya has joined #openmrs
|
17:49:31
|
<bwolfe> suranga, are there any tests in the omod now?
|
17:49:45
|
<suranga> bwolfe, no :(
|
17:50:13
|
<bwolfe> suranga, ok, I think its important that we get that set up with the simplest of tests, then we can tell devs to add theirs there
|
17:50:27
|
<bwolfe> suranga, do you want to move the project to the openmrs org in github, or do you want it in your account?
|
17:50:28
|
<djazayeri> suranga, bwolfe: I'm planning to do HLQRY-9 (service method to render template) today, actually, for exactly that purpose
|
17:50:59
|
<djazayeri> i.e. I'll add in my well-known-(to-me) snippet of groovy TemplateEngine magic
|
17:51:05
|
<bwolfe> ok
|
17:51:13
|
<bwolfe> do your thing wizard
|
17:51:16
|
<suranga> bwolfe, djazayeri cool
|
17:51:20
|
<djazayeri> suranga: as soon as the code is where it's supposed to be, I'll fork it, and send you a pull request, so you can get practice with that.
|
17:51:40
|
<suranga> im happy with whatever you think the git code should be
|
17:51:52
|
<suranga> it currently lives in my github account...
|
17:53:20
|
<djazayeri> suranga: seems like something that belongs under /OpenMRS, unless you particularly want to keep it. (Also, I'm hoping you'll try out the "transfer ownership" github feature and tell me how it works, since I have ~4 projects to transfer from djazayeri to OpenMRS)
|
17:54:09
|
<suranga> djazayeri, i will try that
|
17:54:14
|
<bwolfe> suranga, djazayeri, lets get that transfered asap. before djazayeri checks it out
|
17:54:34
|
<djazayeri> yup, I'll wait for the transfer. Got to run for a sec, actually.
|
17:54:37
|
<djazayeri> so, back in 30 mins or so
|
17:54:40
|
<bwolfe> you already have clearance from code@openmrs for the name, so you can do it now
|
17:54:55
|
<suranga> bwolfe, im having some trouble creating the new dashboard, but first i'll look at transferring ownership first
|
17:55:01
|
<suranga> and then return to this problem
|
17:55:09
|
<bwolfe> suranga, ok.
|
17:55:20
|
<bwolfe> I agree, transfer first, dashboard second. :-)
|
18:01:06
|
*** lakkarau has quit IRC
|
18:16:40
|
*** applecool has quit IRC
|
18:24:00
|
*** lh has quit IRC
|
18:38:17
|
<maurya> djazayeri, got a minute?
|
18:38:25
|
<djazayeri> hi maurya, what's up?
|
18:39:36
|
<maurya> hi, i've been generating the ui and now am looking at the submission part of the code you've provided... i'm not getting the flow of it at some places..
|
18:40:15
|
<maurya> like..startRepeat(this) in the tag handler..
|
18:41:14
|
*** lakkarau has joined #openmrs
|
18:41:14
|
<djazayeri> maurya: the key point is that the server-side form definition only knows "there is a repeat", but it doesn't know how many times it will be repeated
|
18:41:36
|
<maurya> yes
|
18:41:48
|
<lakkarau> bwolfe:it worked.i am sending the patch.
|
18:42:01
|
<djazayeri> maurya: once the client makes a submission, the server-side knows "I have to repeat (something) X times"
|
18:42:46
|
<djazayeri> maurya: in order to let the server side know what the repeatable (something) is, I am using the startRepeat and endRepeat
|
18:43:13
|
<djazayeri> maurya: how well do you understand the flow of having the taghandler create controller submission actions?
|
18:43:15
|
<maurya> yes.. where is the place where we set the x times
|
18:44:00
|
<bwolfe> lakkarau, great!
|
18:44:12
|
*** rafa has joined #openmrs
|
18:44:12
|
*** ChanServ sets mode: +v rafa
|
18:44:35
|
<lakkarau> bwolfe:Thank you very much for the help.
|
18:44:46
|
<bwolfe> which one solved it?
|
18:44:53
|
<djazayeri> maurya: the handleSubmission method on the dynamic repeat's ControllerAction looks in the http request for a submitted parameter to decide how many times
|
18:46:55
|
<djazayeri> maurya: how well do you understand the framework around the controller submission actions?
|
18:47:49
|
<maurya> djazayeri, that the actions that are registered in the submission actions are checked and saved in the database..
|
18:48:25
|
<djazayeri> maurya: actually I misspoke slightly. I'm referring to the FormSubmissionController inside of FormEntrySession
|
18:48:45
|
<djazayeri> maurya: basically most tags will add something (usually themselves) to FormSubmissionController, so they can get a callback when the form is submitted.
|
18:48:56
|
<bwolfe> downey, I don't understand crucible. when I expect it to log me out, I am still logged in. when I need to stay logged in, it logs me out every 5 mins. :-(
|
18:49:42
|
<maurya> djazayeri, yes, so that they can save the value taken from the user
|
18:49:54
|
<djazayeri> maurya: yes
|
18:50:12
|
<djazayeri> maurya: so, normally, when you have an <obs> tag, it adds an ObsSubmissionElement to the FormSubmissionController
|
18:50:44
|
<djazayeri> maurya: however now, since that obs is going to submit a dynamic number of things, we don't want to call its handleSubmission just once
|
18:51:02
|
<djazayeri> maurya: rather we want to call it a number of times that is chosen by the dynamicRepeat's handleSubmission method
|
18:51:55
|
<maurya> djazayeri, yes..yes.. exactly...i was searching for dynamic repeat's handle submission
|
18:52:00
|
<djazayeri> maurya: so, instead of having that <obs> tag (which is _inside_ a <dynamicRepeat>) go directly in FormSubmissionController, I have it getting added to RepeatController.repeatingActions
|
18:52:50
|
<djazayeri> hold on, my code is switched back to trunk, let me look at the branch again
|
18:53:33
|
<djazayeri> maurya: have you checked out my spike code, and run the new unit test?
|
18:53:33
|
<maurya> djazayeri, okay:)
|
18:53:57
|
<maurya> i have checked out your spike but haven't run the test
|
18:54:28
|
<djazayeri> maurya: after this conversation you should run that test under the debugger, and put some breakpoints in the relevant methods in the tag handler
|
18:54:53
|
<djazayeri> maurya: so, look at DynamicRepeatTag
|
18:55:27
|
<maurya> djazayeri, oh.. i'm really sorry... i was trying to get it submit before checking out the test
|
18:55:57
|
<djazayeri> maurya: it will never submit successfully until you modify the server-side. :-)
|
18:56:08
|
<djazayeri> maurya: also, test-driven-development is your friend
|
18:56:45
|
<djazayeri> maurya: so, DynamicRepeatTagHandler has a hidden numberOfRepeats widget (and you need to figure out the javascript to set this)
|
18:57:11
|
<maurya> djazayeri, is the dynamicrepeat test necessary for your code to work??
|
18:57:26
|
<maurya> djazayeri, yes that part is done..
|
18:57:28
|
*** wyclif has quit IRC
|
18:57:49
|
<maurya> djazayeri, i've written the javascript after taking your code
|
18:57:51
|
<djazayeri> maurya: the test *shows* it working. If you don't understand the code, you should try running the test and stepping through to see how the code is called
|
18:58:25
|
<djazayeri> maurya: Okay, so what's the question exactly?
|
19:00:20
|
<djazayeri> maurya: the key change I made was that the FormSubmissionControllerActions (e.g. <obs>) that are inside a <dynamicRepeat> are now added to the DynamicRepeatTagHandler (since it extends RepeatController) instead of adding them directly to the FormSubmissionController
|
19:00:33
|
<maurya> so...i was setting the hidden field and sending it to the server, (to your code) but usually a handlesubmit of a specific element is called while submission, right? but there isn't any submissionelement for this widget
|
19:00:49
|
*** wyclif has joined #openmrs
|
19:01:14
|
<djazayeri> maurya: look at RepeatController.handleSubmission. (That's the abstract class that DynamicRepeatTagHandler extends, and that's where handleSubmission is defined.)
|
19:02:21
|
<maurya> djazayeri, right! got it..thanks!:)
|
19:03:10
|
<djazayeri> suranga: progress on transferring the code to github/openmrs?
|
19:03:17
|
<maurya> djazayeri, so it need not be a submission element to call it's handle submission??
|
19:04:04
|
<djazayeri> maurya: the interface that defines handleSubmission is FormSubmissionControllerAction
|
19:04:25
|
<djazayeri> maurya: DynamicRepeatTagHandler implements that (via its RepeatController superclass)
|
19:04:40
|
<djazayeri> maurya: and RepeatController defines List<FormSubmissionControllerAction> repeatingActions
|
19:04:55
|
<maurya> djazayeri, right, sorry...got it a little confused!
|
19:05:21
|
<maurya> djazayeri, thanks once again:-)
|
19:05:37
|
<djazayeri> maurya: the main interfaces are HtmlGeneratorElement and FormSubmissionControllerAction. I originally thought they would differ more, but in practice almost all tag handlers implement both.
|
19:07:00
|
<maurya> djazayeri, yes.
|
19:10:02
|
<djazayeri> bwolfe, downey: hey, I just moved openmrs-module-uiframework over to /OpenMRS, and I see I've lost the Admin button
|
19:10:27
|
<djazayeri> downey: I should be an admin for OpenMRS on github, right?
|
19:10:40
|
<downey> djazayeri: will check
|
19:10:56
|
<bwolfe> djazayeri, the admin button is right there --->
|
19:11:03
|
<djazayeri> downey: particularly it says "If you are transferring into an org, teams will not be set. An owner on the org will need to set teams for the repo."
|
19:11:15
|
<djazayeri> bwolfe: no fair, I don't see it!
|
19:11:41
|
<djazayeri> incidentally, bwolfe, one of us will need to handle this when suranga transfers hl7query in
|
19:12:01
|
<downey> djazayeri: I assume our "Full Committers" team should have access?
|
19:12:16
|
<djazayeri> downey: yes
|
19:12:22
|
<bwolfe> djazayeri, do you see it now?
|
19:12:33
|
<djazayeri> bwolfe: yes
|
19:12:33
|
<bwolfe> (I see admin TAB, not the button)
|
19:12:40
|
<downey> djazayeri: let me know if you see admin now
|
19:12:46
|
<djazayeri> downey: yes, I can
|
19:13:03
|
<downey> djazayeri: ok. i'm also going to add you to Owners globally
|
19:13:19
|
<downey> (just wanted to verify the other, first)
|
19:13:34
|
<djazayeri> downey: so, is this the standard practice for OpenMRS modules? That full committers get access? (Sounds right to me.)
|
19:13:59
|
<downey> djazayeri: that's a good question but i'm not sure i should be the one deciding. :) fwiw i agree
|
19:14:17
|
<bwolfe> I think so
|
19:14:29
|
<djazayeri> downey, bwolfe: what have we done for other modules, e.g. htmlformentry, that have a primary maintainer
|
19:15:02
|
<downey> unfortunately github really doesn't have a parallel to that other than free text :)
|
19:15:38
|
<djazayeri> downey: what I meant to say is "I want the same setup for uiframework as we have for htmlformentry"
|
19:16:12
|
<downey> djazayeri: see: https://github.com/OpenMRS/openmrs-module-htmlformentry/admin/collaboration
|
19:16:31
|
<djazayeri> downey: looking now. do most modules have an equivalent of the team "Module: HTML Form Entry"?
|
19:16:33
|
<djazayeri> bwolfe: ^^
|
19:16:35
|
<downey> no. :)
|
19:16:44
|
<downey> that said, it's pretty painless to create unique teams
|
19:16:57
|
<djazayeri> downey: for now I'm fine with it being just Full Committers
|
19:17:10
|
<djazayeri> downey: and now that I'm an owner I can manually set this for the other 3 things I move over
|
19:17:29
|
<downey> yup
|
19:17:46
|
<downey> i actually thought you had to be an owner in both orgs to do a transfer
|
19:18:34
|
<djazayeri> downey: nope (which makes sense, since typically if you're giving ownership to an org you probably aren't an org owner)
|
19:18:58
|
<bwolfe> they could set it up as a "push to org" request. :-)
|
19:22:23
|
<djazayeri> bwolfe: do you know where suranga went, and whether he finished transferring the git repo?
|
19:25:04
|
<bwolfe> djazayeri, I have not heard from him
|
19:25:13
|
<bwolfe> if you don't see it, I would guess he hasn't transferred it yet
|
19:26:13
|
<bwolfe> its 1am there, perhaps he is asleep?
|
19:30:24
|
<djazayeri> bwolfe: that would be sad, since I have a window of time to write the code today. :-)
|
19:30:27
|
*** snoppy has left #openmrs
|
19:30:39
|
<djazayeri> bwolfe: I can just do it against the repo in his own account if he's actually gone to sleep
|
19:31:04
|
<bwolfe> djazayeri, yes, do it against htat one
|
19:31:13
|
<bwolfe> you can always create a patch and apply to a fresh checkout
|
19:31:26
|
<bwolfe> (or do the rebase stuff to the new repo)
|
19:35:27
|
<djazayeri> bwolfe: yeah, it's trivial, I know
|
19:37:18
|
<suranga> bwolfe, sorry
|
19:37:36
|
<suranga> bwolfe, I seem to have fallen asleep there :(
|
19:38:08
|
<suranga> bwolfe, which openmrs repo user should I transfer control to ? :(
|
19:39:47
|
<bwolfe> suranga, there should only be one
|
19:39:56
|
<bwolfe> "OpenMRS"
|
19:42:06
|
<lakkarau> -groupcat-:i wish good luck to all who are paticipating in olympics .
|
19:42:45
|
<bwolfe> lakkarau, I don't think any of us here are in the olympics ;-)
|
19:43:53
|
<suranga> bwolfe, sorry, im trying to do this via the "transfer ownership" page. the transfer seems to die on me. I get the messagw "Transferring may be delayed until GitHub staff approve the transfer."
|
19:44:11
|
<bwolfe> djazayeri, did you see that?
|
19:44:12
|
<djazayeri> suranga: that's the confirmation dialog?
|
19:44:30
|
<djazayeri> I saw a confirmation dialog that mentioned that, and 4 other bullet points, and I had to type some stuff and click submit at the bottom
|
19:44:43
|
<djazayeri> but it didn't actually delay anything.
|
19:44:56
|
<suranga> djazayeri, thats it
|
19:45:00
|
*** maurya has quit IRC
|
19:45:18
|
<suranga> djazayeri, im doing the same, but m.. it;s freezing..
|
19:45:20
|
<djazayeri> suranga: you need to type "openmrs-module-hl7query" and "OpenMRS" in the two boxes at the bottom and click confirm
|
19:45:38
|
<djazayeri> suranga: make sure you type the name of the repo correctly, or the button is inactive
|
19:46:38
|
<suranga> djazayeri, I get "You don't have admin rights to OpenMRS"
|
19:46:59
|
<djazayeri> suranga: that's odd
|
19:47:15
|
<djazayeri> I didn't have *owner* rights, but maybe I did have admin rights
|
19:47:37
|
<djazayeri> actually, downey was right now that I think about it. It says you have to be an admin on the org you're transferring to.
|
19:47:56
|
<djazayeri> bwolfe: want to temporarily make suranga an admin, while he does this?
|
19:47:58
|
<downey> djazayeri: that's what i'd remembered reading, but it must not be true. :)
|
19:48:12
|
<suranga> djazayeri, bwolfe :)
|
19:48:13
|
<djazayeri> downey: well, I think I must have been in an odd state where I'm admin but not owner.
|
19:49:07
|
<bwolfe> suranga, you're an owner in OpenMRS now
|
19:49:15
|
<bwolfe> I will de-owner-ify you once you transfer
|
19:49:50
|
<downey> "15 minutes of fame"
|
19:50:39
|
<suranga> bwolfe, :)
|
19:50:44
|
<suranga> djazayeri, its done
|
19:50:48
|
<suranga> djazayeri, :https://github.com/OpenMRS/openmrs-module-hl7query
|
19:50:52
|
<OpenMRSBot> <http://ln-s.net/$Wry> (at github.com)
|
19:51:11
|
<suranga> bwolfe, please release me from that overwhelming responsibility :-)
|
19:51:20
|
*** lh has joined #openmrs
|
19:51:20
|
*** lh has joined #openmrs
|
19:52:15
|
*** rafa has quit IRC
|
19:53:20
|
<downey> suranga++
|
19:53:36
|
<downey> also pushkar++ for drawing module :)
|
19:54:07
|
<suranga> that should be 5 karma points for my nick by now !!:P
|
19:54:14
|
<pushkar> thanks downey
|
19:54:47
|
<suranga> djazayeri, the checkout may contain /target/* folders commited (due to my prior ignorance)
|
19:54:59
|
<suranga> djazayeri, you are probably tearning out your hair by now...
|
19:55:18
|
<downey> !karma suranga
|
19:55:18
|
<OpenMRSBot> downey: Karma for "suranga" has been increased 5 times and decreased 1 time for a total karma of 4.
|
19:55:37
|
<downey> suranga++ for knowing his karma score by heart
|
19:56:58
|
<bwolfe> now he is wrong
|
19:57:01
|
<bwolfe> suranga--
|
19:57:06
|
<bwolfe> now he is right :-)
|
19:59:31
|
<bwolfe> suranga, you are demoted as OpenMRS owner now. but you are owner of hl7 query
|
20:00:14
|
<suranga> bwolfe, thats a nessesary evil I guess. you dont want to wake up and find that i've crashed evrything :)
|
20:01:17
|
<djazayeri> suranga++ (for getting his "first time my module was forked" badge)
|
20:02:56
|
<downey> !botabuse
|
20:02:57
|
<OpenMRSBot> downey: Error: "botabuse" is not a valid command.
|
20:03:02
|
<downey> oh, wrong channel
|
20:07:39
|
<bwolfe> suranga, what is this extra folder? https://github.com/OpenMRS/openmrs-module-hl7query/tree/master/hl7query
|
20:07:45
|
<OpenMRSBot> <http://ln-s.net/$WsI> (at github.com)
|
20:09:25
|
<suranga> bwolfe, m.. I think master' was supposed to be my branch ? :(
|
20:10:00
|
<bwolfe> yes, it is
|
20:10:05
|
<bwolfe> "master" in git means "trunk"
|
20:10:07
|
<bwolfe> thats fine
|
20:10:16
|
<bwolfe> What I was linking to was the extra folder
|
20:10:16
|
<bwolfe> https://github.com/OpenMRS/openmrs-module-hl7query
|
20:10:17
|
<OpenMRSBot> <http://ln-s.net/$Wry> (at github.com)
|
20:10:33
|
<djazayeri> bwolfe, suranga: what's up with the subfolders being "hl7query-api" instead of just "api", etc?
|
20:10:40
|
<bwolfe> (that too)
|
20:11:24
|
<suranga> bwolfe, I was using the openmrs module generator... thats default behavior..
|
20:11:36
|
<djazayeri> suranga: did you create with the archetype? really that's the new default? Odd.
|
20:12:03
|
<bwolfe> that seems wrong...
|
20:12:06
|
<suranga> djazayeri, i was using the archetype, I just specified the name 'hl7query'
|
20:13:01
|
<djazayeri> suranga: odd, because it hasn't worked that way for me
|
20:13:49
|
<suranga> djazayeri, what should I do ? edit folder names manually ?
|
20:15:33
|
<djazayeri> suranga: dunno, on a call, bwolfe thoughts?
|
20:16:01
|
*** pushkar has quit IRC
|
20:16:45
|
<downey> lh++
|
20:17:24
|
<lh> downey, :)
|
20:22:30
|
<bwolfe> suranga, I would assume so. edit the folder names then push? might need to edit .gitignore for new names (or put .gitignore at each level?)
|
20:23:11
|
<suranga> bwolfe, I will try that
|
20:23:41
|
<suranga> djazayeri, can you continue with that ticket if you are free ?
|
20:24:17
|
<djazayeri> suranga: should I do a pull?
|
20:25:16
|
<suranga> djazayeri, no changes there yet, im afraid
|
20:29:56
|
<bwolfe> suranga, are you changing hte folders, or no?
|
20:30:15
|
<djazayeri> suranga: just let me know whether you prefer for me to write code now, or to wait an hour
|
20:30:28
|
<suranga> bwolfe, I certainly will be changing the folders
|
20:30:47
|
<suranga> djazayeri, maybe you can writ it now, and hang on to it until I make the changes ? :)
|
20:31:35
|
<djazayeri> suranga: renaming folders will surely cause some merge conflicts that I don't want to deal with. If you have an estimate for whether you're going to do that "now" or "tomorrow", I'll work around that.
|
20:32:08
|
<bwolfe> I can try to do it now, if you are doing something else suranga
|
20:32:46
|
<suranga> bwolfe, I was working on the dashboard, but I also need to look t the changes u are making to the tickets :(
|
20:33:45
|
<bwolfe> heh
|
20:33:54
|
<bwolfe> I cleaned up a lot of the wiki pages
|
20:34:01
|
<bwolfe> and the tickets too I supposed
|
20:34:07
|
<bwolfe> *suppose
|
20:38:11
|
<bwolfe> djazayeri, suranga: it is done
|
20:38:36
|
<djazayeri> bwolfe: okay, great
|
20:38:44
|
<djazayeri> bwolfe: did you fix the /target and gitignore stuff too?
|
20:38:55
|
<suranga> bwolfe, so far you have done more work than we on the sprint. actually, I had only finished checking it out again :-|
|
20:39:15
|
<bwolfe> FYI: had to manually add the renamed folders when doing "git commit". doing 'git commit -a -m"my message"' wasn't picking htem up. had ot do "git add *" first, then git commit, then git push
|
20:39:34
|
<bwolfe> djazayeri, yes, fixed those, and added a simple readme
|
20:39:43
|
<djazayeri> bwolfe: awesome
|
20:39:53
|
<bwolfe> suranga, not yet. maybe by next week. :-)
|
20:41:46
|
<suranga> bwolfe, i suspect you are right, because our other project continues next week too :)
|
20:41:58
|
<bwolfe> ok, gotta run. get me on email for questions
|
20:42:26
|
<djazayeri> tks bwolfe
|
20:42:36
|
<suranga> bwolfe, sure. thanks a lot for the help :)
|
20:43:25
|
<suranga> hi downey thanks for that grashopper thingy. but I seem to be facing a problem because the version is set to 'next release due (auto)"
|
20:43:40
|
<suranga> jira says "The version id specified is not a valid version id"
|
20:43:57
|
<downey> suranga: do you have any versions specified in the project yet?
|
20:44:10
|
<suranga> 01.-snapshot :)
|
20:44:15
|
<suranga> *0.1
|
20:46:34
|
<djazayeri> suranga: he means any versions in jira
|
20:46:46
|
<downey> sorry, yes, thats what i meant
|
20:46:54
|
*** bwolfe has quit IRC
|
20:46:59
|
<suranga> downey, um... not really
|
20:47:15
|
<downey> suranga: ok, you'll need to create one in the project admin pages first. :)
|
20:47:31
|
<suranga> :)
|
20:47:41
|
<djazayeri> suranga: create "1.0" to represent the sprint, and do a bulk-change to set all the tickets' fixVersions to 1.0
|
20:52:27
|
<suranga> downey, , hi, I creatd the new version as 1.0, am still looking for a way to set bulk change on the tickets though...
|
20:53:16
|
<djazayeri> suranga: do a query, e.g. by typing hlqry in the shortcut search box in the top right
|
20:53:24
|
<downey> djazayeri: https://tickets.openmrs.org/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+%22HL7+Query%22
|
20:53:27
|
<downey> err, suranga ^
|
20:53:46
|
<downey> then Tools -> all 22 issues
|
20:53:50
|
<djazayeri> suranga: Tools -> Bulk Change
|
20:53:50
|
<djazayeri> yeah
|
20:56:45
|
<suranga> downey, i only see tools -> configure columns
|
20:56:55
|
<suranga> downey, access restriction ?
|
20:56:57
|
<djazayeri> suranga: maybe it's an admin feature or something, let me do it.
|
20:58:29
|
<djazayeri> suranga: done. (you can bump any outside of 1.0 that shouldn't have been)
|
20:58:36
|
<downey> that's right, sorry. forgot that bulk change is only a global permission that exists across all projects.
|
20:58:49
|
<djazayeri> bwolfe--
|
20:59:10
|
<djazayeri> (for deleting the root pom.xml when modifying the hl7query module code)
|
20:59:14
|
<djazayeri> (I'll put it back...)
|
20:59:27
|
<suranga> djazayeri, poor bwolfe, his karma is about 128, as I remember
|
20:59:36
|
<suranga> !karma bwolfe
|
20:59:36
|
<OpenMRSBot> suranga: Karma for "bwolfe" has been increased 131 times and decreased 29 times for a total karma of 102.
|
20:59:56
|
<suranga> Daniel has 68, i think
|
21:00:03
|
<suranga> !karma dkayiwa
|
21:00:03
|
<OpenMRSBot> suranga: Karma for "dkayiwa" has been increased 53 times and decreased 6 times for a total karma of 47.
|
21:05:01
|
<djazayeri> suranga: I have sent you your first pull request
|
21:05:22
|
<djazayeri> suranga: the next one will have more content to it. :-)
|
21:07:12
|
*** lh has quit IRC
|
21:07:51
|
<suranga> djazayeri, just acepted my first pull :P
|
21:09:12
|
<djazayeri> suranga: will we have a Template class as a domain object?
|
21:09:33
|
<suranga> djazayeri, I dont think thats nessesary, isnt it ?
|
21:09:35
|
<djazayeri> suranga: actually, never mind, I don't care at the moment.
|
21:09:55
|
<suranga> djazayeri, umm... ok, but i'd say, its not wanted...
|
21:10:08
|
<djazayeri> suranga: well, what gets stored in the DB via hibernate?
|
21:10:40
|
<suranga> djazayeri, ah, sorry, I thought u were being ORUR01 specific
|
21:10:45
|
<suranga> there is gonna be a model class
|
21:10:56
|
<suranga> we have a ticket on that
|
21:11:04
|
<djazayeri> suranga: okay, yeah, that's what I was asking about (though I don't need to know for my current ticket)
|
21:41:24
|
*** jriley has joined #openmrs
|
21:51:25
|
*** wyclif has quit IRC
|
21:52:14
|
*** downey has quit IRC
|
22:05:40
|
*** jordank has quit IRC
|
22:08:09
|
*** jordank has joined #openmrs
|
22:26:39
|
<suranga> hi , the new sprint dashboard is up and linked to the wiki. I've been editing the tickets..
|
22:26:58
|
<suranga> tomorrow, will mail on progress of the other work :)
|
22:27:10
|
<suranga> its rather late over here, got to sign off....
|
22:27:30
|
*** jordank has left #openmrs
|
22:27:46
|
*** suranga has quit IRC
|
22:38:06
|
*** jriley has left #openmrs
|
22:41:43
|
*** kreddy has quit IRC
|
22:43:46
|
*** lakkarau has quit IRC
|
22:56:28
|
*** jordank has joined #openmrs
|
22:56:39
|
*** jordank has left #openmrs
|
23:06:21
|
*** jordank has joined #openmrs
|
23:08:42
|
*** jordank has joined #openmrs
|
23:09:06
|
*** jordank has joined #openmrs
|
23:37:37
|
*** wyclif has joined #openmrs
|
23:39:58
|
*** lh has joined #openmrs
|
23:39:58
|
*** lh has joined #openmrs
|