| 00:25:24 | *** jordank has joined #openmrs |
| 00:33:11 | <bwolfe> djazayeri, still need it? |
| 00:35:15 | <djazayeri> no |
| 00:35:59 | <djazayeri> bwolfe: no, but thanks |
| 00:36:14 | <djazayeri> bwolfe: oh, I see you sent it already. In that case I'll use it. |
| 01:17:11 | *** mccallumg has joined #openmrs |
| 01:17:11 | *** ChanServ sets mode: +v mccallumg |
| 01:24:55 | *** mccallumg has quit IRC |
| 02:10:07 | *** mccallumg has joined #openmrs |
| 02:10:07 | *** ChanServ sets mode: +v mccallumg |
| 02:20:37 | *** suranga has joined #openmrs |
| 02:20:37 | *** ChanServ sets mode: +v suranga |
| 02:20:46 | <suranga> hi bwolfe |
| 02:21:05 | <suranga> bwolfe, i seem to be making a practise out of messing up your evenings ;) |
| 02:28:12 | <bwolfe> suranga, ha |
| 02:28:12 | <bwolfe> np |
| 02:28:15 | <bwolfe> whats up? |
| 02:28:31 | <suranga> bwolfe, a few questions, as usual :) |
| 02:29:09 | <suranga> bwolfe, wonder if your saw rogers response. I have a few questions on that... |
| 02:30:45 | <suranga> bwolfe, roger has mentioned that we should write up sub templates for a lot of scenarios |
| 02:31:12 | <suranga> for example, he wants one for the ordinary patient name (preferred name) |
| 02:31:20 | <bwolfe> we can write a few, yes |
| 02:31:20 | <suranga> one for including all patient names |
| 02:31:27 | <suranga> and one for spanish names |
| 02:31:42 | <suranga> yeap, so that will be ordinary / ok work to do |
| 02:32:40 | <suranga> bwolfe, next, he has asked for validation |
| 02:33:13 | <suranga> that is, if someone tried to insert s string date as a person name, the template should throw an error... |
| 02:34:12 | <bwolfe> that one is harder |
| 02:34:33 | <bwolfe> and the first pass we can just validate the xml structure on save by passing it through hapi with a dummy patient |
| 02:34:50 | <bwolfe> and if hapi throws an error, tell the admin about it and tell them to rewrite their template |
| 02:35:29 | <suranga> bwolfe, what you mean is, when someone creates a new template, prior to saving it, we will try parsing it as HAPI to check if its ok ? |
| 02:35:44 | <suranga> that sounds good, because roger has a good point there |
| 02:36:10 | <suranga> people might create xml with BAAD formats - ex: multiple patient genders ,etc. |
| 02:36:28 | <bwolfe> right |
| 02:36:41 | <bwolfe> the harder one to verify that roger said is if someone puts a string in a number field |
| 02:37:06 | <bwolfe> thats a pretty complicated verification and would necessetate the dummy patient have data for EVERY possible field that is getting put into the template |
| 02:38:06 | <suranga> bwolfe, do you favour the idea of planning for openmrs 1.9, and not 1.8 ? |
| 02:38:22 | <bwolfe> I don't think it matters. we could create templates for both really |
| 02:38:58 | <suranga> bwolfe, the problem would be that the templates we create as part of this sprint would be obsolete against 1.9. |
| 02:39:27 | <suranga> bwolfe, new ones would have to be written :P |
| 02:39:27 | <bwolfe> suranga, thats why we create two templates: PID_1.8 and PID_1.9 |
| 02:39:31 | <bwolfe> (or something like that) |
| 02:39:54 | <suranga> bwolfe, hmmm... makes sense... |
| 02:40:15 | <suranga> bwolfe, one moe things regardiing validating the xml strcuture by passing into HAPI |
| 02:40:23 | <bwolfe> but I'd rather default to 1.9 and if we have time write it for 1.8 |
| 02:40:56 | <suranga> bwolfe, this should happen when the user is persisting a new template he created into the db, as well as someone has edited the template, right ? |
| 02:41:49 | <bwolfe> right |
| 02:42:48 | <suranga> bwolfe, so now we can more on to questions about the admin page... :P |
| 02:43:38 | <suranga> bwolfe, user goes to admin page, and from a drop down, selects "ORUR01" and "openmrs 1.9" |
| 02:43:58 | <suranga> then, we look at the DB, and extract the suitable message segments for him |
| 02:44:34 | <suranga> for example, if we have two templated for patient names, we display both, and specify a description as to what they look like |
| 02:44:54 | <suranga> user gets a radio buttons to pick the one he wants... |
| 02:44:54 | <bwolfe> what is the admin trying to do here? |
| 02:45:32 | <suranga> bwolfe, um... to ensure that his ORUR01 message has all the segments which it needs ? |
| 02:46:02 | <suranga> bwolfe, especilly, "does my message use my custom PID.5, instead of the PID.5 that came with the system ? |
| 02:46:35 | <bwolfe> why did the admin go to the page in the first place? is he creating a new template? editing one? validating one that someone else wrote? |
| 02:47:18 | <suranga> bwolfe, lets say that he is a first time user, who wants to configure the default message according to his whims |
| 02:47:32 | <bwolfe> ok, so its an admin creating a new template? |
| 02:47:33 | <suranga> bwolfe, "editing a default one" |
| 02:48:41 | <bwolfe> I think providing help and clues that a user can use is nice, but too much work for a 2 week sprint. |
| 02:49:06 | <bwolfe> the first pass admin page shoudl be a large textarea that has the xml/groovy template. |
| 02:49:18 | <bwolfe> the admin can change whatever the heck he wants. he can call any/all templates |
| 02:49:43 | <suranga> bwolfe, by "call" what do you mean exactly ? |
| 02:50:00 | <bwolfe> if we want to be fancy, we can turn on some sort of autocomplete/dropdown via jquery when it sees the admin trying to call <% callTemplate("PID.5") %> |
| 02:50:09 | <bwolfe> call == import |
| 02:50:31 | <bwolfe> suranga, have you re-looked at the groovy template code that darius wrote in the call? |
| 02:50:34 | * bwolfe looks for the link |
| 02:50:58 | <suranga> bwolfe, so the user goes to the admin screen and selects ORUR01 and openmrs 1.9, and gets a default message on his screen ? |
| 02:51:13 | <suranga> bwolfe, yep, I did, its on my wiki page too |
| 02:51:18 | * suranga goes to get it |
| 02:51:31 | <bwolfe> http://notes.openmrs.org/Design-Forum-2012-07-18 |
| 02:51:39 | <bwolfe> look at "pseudo-template for R01 message" section |
| 02:51:58 | <bwolfe> ${ callTemplate("PV1", encounter) } is the syntax darius used. but groovy templates might have something else |
| 02:52:48 | <bwolfe> the admin goes to Manage Templates. he chooses the one named "ORUR01". (and ignores the one named ORUR01-openmrs-1.8) |
| 02:52:57 | <suranga> bwolfe, so the admin only sees stuff like this ? and not the entire (full version) of the groovy template code ? |
| 02:53:29 | <bwolfe> the templates should not be autoexpanded, is that what you are asking? |
| 02:53:38 | <bwolfe> (not autoexpanded when editing) |
| 02:53:54 | <suranga> bwolfe, if we specify them by name (as above) can we also display them ? |
| 02:54:02 | <bwolfe> so if the admin wants to edit PV1 template, he has to go back to Manage Templates and click the PV1 link to edit that template |
| 02:54:19 | <bwolfe> what do you mean? |
| 02:54:25 | <suranga> bwolfe, aha, yes, I get it |
| 02:54:33 | <suranga> bwolfe, two admin links |
| 02:55:12 | <bwolfe> an edit vs preview link on the Manage Templates page? I suppose... |
| 02:55:18 | <suranga> bwolfe, but on the page where he creates the full template, he cannot see the full version of the groovy tmplates, right ? |
| 02:56:41 | <bwolfe> when editing ORUR01 he will see things like "callTemplate" in the textarea. if he clicks "preview", then he will see the whole template with all callTemplates expanded and PV1s, etc in there |
| 02:57:52 | <suranga> bwolfe, cool. I think I should create some gliffy for these ! |
| 02:59:05 | <bwolfe> gliffy on tickets would be nice, yes |
| 03:00:17 | *** upul` has joined #openmrs |
| 03:00:17 | *** ChanServ sets mode: +v upul` |
| 03:00:18 | <suranga> bwolfe, are you sure the team can manage all this in two weeks ? |
| 03:00:47 | <bwolfe> suranga, pretty sure |
| 03:01:02 | <bwolfe> the biggest questions will be groovy templates and hapi parsing |
| 03:01:48 | <suranga> bwolfe, the converations on the message structure still continue.. I hope to put a lid on this tomorrow |
| 03:01:57 | <suranga> bwolfe, (at our final design call!) |
| 03:02:21 | <bwolfe> the message structure guiding will be sparse |
| 03:02:40 | <bwolfe> in openmrs, we believe in letting the user shoot their own foot off ;-) |
| 03:03:30 | <suranga> bwolfe, :D |
| 03:04:48 | <suranga> bwolfe, mm... Roger also says : |
| 03:04:50 | <suranga> Here is a case which is more like the one you give in your example (in 1.9): assume that each encounter is going to become an OBR and that the encounter providers are going to become XCNs in OBR.16. This results in two standard templates as with the patient names (i.e., one to take a particular provider, convert it to XCN and add it to OBR.16, one to take a particular encounter, convert each of its providers to XCN and add them to OBR.16). However, we |
| 03:04:50 | <suranga> also want to include the patient's community health worker (CHW) as a provider so that the CHW is notified of the patient's visit. We find the patient's CHW as follows: each patient has a person_attribute "health zone"; each provider has attributes "provider type" and "health zone"; the provider whose provider type=CHW and health zone=patient's health zone is the patient's CHW. So we need a template to convert a patient to a provider, then convert that |
| 03:04:53 | <suranga> provider into XCN and add it to OBR.16 (of course, once we have the provider, the last 2 steps can be delegated to the standard template provider-XCN- OBR.16). |
| 03:05:56 | <suranga> bwolfe, do we need towrite up such a complicated template as part of our sprint ? |
| 03:07:15 | <bwolfe> if we have time, we can write an example of something complicated like that, sure |
| 03:08:17 | <suranga> bwolfe, cool, sounds good |
| 03:08:36 | <suranga> bwolfe, so far, you seems to have done more work on the sprint than me, actually :D |
| 03:09:51 | <bwolfe> ha |
| 03:10:51 | <suranga> bwolfe, tomorrow morning will be our final call. I'll work on cleaning up the tickets + the gliffy screeens prior to that... |
| 03:13:52 | <suranga> bwolfe, when an user creates a new template, it will be stored in a different table ? |
| 03:14:11 | <suranga> bwolfe, or will we re-build it using the sub templates in the groovy_table ? :) |
| 03:14:38 | <bwolfe> ?? |
| 03:14:48 | <bwolfe> there will be one hl7query_template table |
| 03:14:57 | <suranga> bwolfe, for example, lets say I create a custom ORUR01 |
| 03:15:19 | <suranga> when I want to retrive it, will I rebuild it using the message segments I used priviously ? |
| 03:15:25 | <bwolfe> if you create a custom one, you can choose ot overwrite the default one or just rename one to ORUR01-old |
| 03:15:59 | <bwolfe> you are still thinking too complicated |
| 03:16:04 | <bwolfe> the admin screen will be a textbox |
| 03:16:10 | <suranga> bwolfe, sorry :( |
| 03:16:13 | <bwolfe> the textbox is filled with whatever is in the database for hte chosen template |
| 03:16:25 | <bwolfe> if the user edits a default template, they overwrite what is stored |
| 03:16:37 | <bwolfe> the user can change the template to be "sdfkln2lfkn2lknlwkjdfljdsflsakjf" |
| 03:17:10 | <bwolfe> or they can change just one part of it from ......callTemplate("XCN")..... to callTemplate("myCustomXCN") |
| 03:17:43 | <suranga> bwolfe, when 'textbox is filled with whatever is in the database for hte chosen template"... does the table contain a full message with MSH + PID + PVI + OBR |
| 03:18:55 | <bwolfe> the template contains this: <msh> (hard coded for this template)...</msh> |
| 03:18:55 | <bwolfe> ${ callTemplate("PID", patient) } |
| 03:18:55 | <bwolfe> <% encounters.each { encounter -> %> |
| 03:18:55 | <bwolfe> ${ callTemplate("PV1", encounter) } |
| 03:18:55 | <bwolfe> <% encounter.getAllObs().filter({ /* ungrouped only */ }) { obs -> %> |
| 03:18:57 | <bwolfe> ${ callTemplate("OBX", obs) } |
| 03:18:59 | <bwolfe> <% } %> |
| 03:19:01 | <bwolfe> <% encounter.getAllObs().filter({ /* obs groups only */ }) { group -> %> |
| 03:19:03 | <bwolfe> ${ callTemplate("obs-group-as-OBR-and-OBX", group) } |
| 03:19:05 | <bwolfe> <% } %> |
| 03:19:07 | <bwolfe> <% } %> |
| 03:19:09 | <bwolfe> that is the text of the template |
| 03:19:12 | <bwolfe> that is what is stored int he db |
| 03:19:15 | <bwolfe> that is what the admin edits |
| 03:19:27 | <bwolfe> nothing more is needed for a 1.0. :-) |
| 03:19:40 | <bwolfe> its groovy code |
| 03:19:51 | <bwolfe> surrounded by xmlhl7 elements |
| 03:19:55 | <suranga> bwolfe, ok, I finally get it, I think |
| 03:20:09 | <suranga> bwolfe, thanks for explaining everything again :( |
| 03:20:14 | <bwolfe> hehe |
| 03:20:26 | <bwolfe> you explain it to me now, so I know you get it. :-) |
| 03:20:32 | <suranga> bwolfe, cool |
| 03:20:51 | <bwolfe> what does the admin do if he wants to add a new element to the PID section for the ORuR01 template ? |
| 03:21:47 | <suranga> to add a new one, he needs to create that segment as a groovy, save it in the db, and then edit the ORUR01 message to include that segment by name ? |
| 03:22:48 | <bwolfe> good. but what if he wants to change the PID for all messages that might call the PID template? |
| 03:22:49 | <suranga> 1) write new groovy semgnet 2) store it in db 3) call it in the template you pasted above ^ |
| 03:23:26 | <suranga> bwolfe, he needs to edit the exsisting PID template in the db ? |
| 03:23:35 | <bwolfe> htmlformentry is a good example of how this will look. go edit an HFE form. you just see a large textbox with the html in it |
| 03:23:44 | <bwolfe> suranga, good, right |
| 03:23:49 | <suranga> :) |
| 03:23:54 | <bwolfe> now you are giving me confidence |
| 03:25:22 | <suranga> bwolfe, he hee... so I was a cause of worry earlier ? BWAHAHAHAHAAAAAA |
| 03:26:35 | <bwolfe> only casual worry |
| 03:26:50 | <bwolfe> because I always thought you understood, but they you would reply slightly off. :-) |
| 03:26:59 | <bwolfe> so then I would doubt if you understood again |
| 03:27:21 | <suranga> bwolfe, I;ve notied that when we worry about something, it usually gets solved :P |
| 03:27:25 | <bwolfe> its very tough describing something without a whiteboard. if we were in the same room it would have been a 1 or 2 hour conversation and you could be off writing tickets |
| 03:27:38 | <suranga> bwolfe, :( |
| 03:33:43 | <bwolfe> oh well |
| 03:33:47 | <bwolfe> such is online life |
| 03:34:19 | <suranga> bwolfe, I have to keep track of three timezones -> home , cape town and Indy :P |
| 03:34:35 | <suranga> bwolfe, but you seem pretty used to it ? :) |
| 03:35:47 | <bwolfe> used to the timezones? no, I don't get used to it |
| 03:35:58 | <bwolfe> I just know the approx time when I usually see people |
| 03:36:15 | <suranga> bwolfe, did I mention that my student seems most active from 11-2 pm my time ? :) |
| 03:36:17 | <bwolfe> you: late at night. kenya: early in morn. darius: randomly |
| 03:36:32 | <suranga> bwolfe, :D |
| 03:37:14 | <suranga> bwolfe, darius seems most responsive early morning my time |
| 03:42:30 | <suranga> bwolfe, the problem with your plan is that you need to be awake both late at night, and early in the morning :D |
| 03:42:43 | <bwolfe> yep |
| 03:42:46 | <bwolfe> luckily I am |
| 03:42:47 | <bwolfe> :-) |
| 03:43:06 | <bwolfe> and there are all the other people in the middle of the day... |
| 03:45:36 | <suranga> bwolfe, my priority order is a) Jembi b) GSOC + Sprint c) personal sanitation |
| 03:45:59 | <bwolfe> haha |
| 03:46:05 | <suranga> bwolfe, it helps that you work from home, and dont have a girlfriend :-\ |
| 03:47:09 | <suranga> bwolfe, umm.. sorry, I ment 'personal grooming' as option c above :( |
| 03:47:37 | <bwolfe> thats better! |
| 03:49:21 | <mccallumg> suranga: :) |
| 03:49:26 | <suranga> bwolfe, ooh, one more, when storeing message segments in a db, the table should also persist which particular OpenMRS version the segment works with ? |
| 03:49:32 | <suranga> hi mccallumg ! |
| 03:49:48 | <suranga> mccallumg, I heard you were at OSCON ! cool |
| 03:50:07 | <mccallumg> suranga: Yes. OSCON was really good. |
| 03:50:38 | <suranga> mccallumg, back in Canada ? OSCOn must have been really expensive.... |
| 03:51:35 | <mccallumg> suranga: Yes. Back home now. OSCON wasn't that expensive - I did not get a full conference pass. Just paid $25 for the 'EXPO' pass. And I stayed with family. |
| 03:51:55 | <bwolfe> suranga, I suppose you could make that another column. that might be helpful. |
| 03:52:16 | <suranga> mccallumg, ah, that was a good plan... maybe I will do the same one day :) |
| 03:52:28 | <suranga> bwolfe, :) |
| 03:52:41 | <mccallumg> suranga: I'll see you there, then. |
| 03:52:49 | <bwolfe> ok, bedtime. g'night suranga |
| 03:55:32 | <suranga> bwolfe, good night... there may be more Q's tomorrow :P |
| 03:55:53 | <suranga> mccallumg, you've probably heard about this sprint im leading.... |
| 03:56:04 | <suranga> its for hl7 export from openmrs |
| 03:56:16 | <mccallumg> suranga: I'm following it yes. You're very busy. |
| 03:56:33 | <mccallumg> suranga: Big promotion. Congratulations. |
| 03:59:30 | *** bwolfe has quit IRC |
| 04:13:28 | *** robbyoconnor has joined #openmrs |
| 04:13:28 | *** ChanServ sets mode: +v robbyoconnor |
| 04:17:29 | *** robbyoconnor has quit IRC |
| 04:18:07 | *** robbyoconnor has joined #openmrs |
| 04:18:07 | *** ChanServ sets mode: +v robbyoconnor |
| 04:28:46 | *** kishoreyekkanti has joined #openmrs |
| 04:37:05 | *** jordank has quit IRC |
| 04:50:08 | *** mccallumg has quit IRC |
| 04:55:23 | *** jordank has joined #openmrs |
| 05:18:41 | *** jcope has joined #openmrs |
| 05:19:04 | *** jordank has quit IRC |
| 05:34:00 | *** jcope has quit IRC |
| 05:35:01 | *** Guest10497 has joined #openmrs |
| 05:37:46 | *** Guest10497 has quit IRC |
| 06:19:06 | *** suranga has quit IRC |
| 06:56:40 | *** magoo_ has joined #openmrs |
| 07:25:58 | *** dkayiwa has joined #openmrs |
| 07:36:15 | *** magoo_ has quit IRC |
| 07:36:16 | *** dkayiwa has quit IRC |
| 07:42:23 | *** dkayiwa has joined #openmrs |
| 07:42:47 | <dkayiwa> hi djazayeri |
| 07:49:29 | *** shortend has joined #openmrs |
| 07:57:35 | *** snoppy has joined #openmrs |
| 08:05:58 | <shortend> Could anyone give me a clue as to how to inject a proper SessionFactory when running a test class? |
| 08:06:21 | <shortend> I'm getting "No value for key [org.hibernate.impl.SessionFactoryImpl@78e785aa] bound to thread [main]" |
| 08:06:45 | <shortend> Which seems like I'm failing to specify something about the SessionFactory. |
| 08:18:30 | *** magoo_ has joined #openmrs |
| 08:33:45 | *** sunbiz has joined #openmrs |
| 08:33:45 | *** ChanServ sets mode: +v sunbiz |
| 08:37:54 | *** shortend has quit IRC |
| 08:38:45 | *** magoo_ has quit IRC |
| 09:17:14 | *** djazayeri1 has joined #openmrs |
| 09:17:50 | *** gede has joined #openmrs |
| 09:18:36 | *** djazayeri has quit IRC |
| 09:19:46 | <gede> please let the concept proposal module team at the TW office know I'm online and can answer queries regarding the stories |
| 09:23:50 | *** rafa has joined #openmrs |
| 09:23:50 | *** ChanServ sets mode: +v rafa |
| 09:55:15 | *** magoo_ has joined #openmrs |
| 09:59:35 | *** magoo_ has quit IRC |
| 10:10:05 | <dkayiwa> hi gede |
| 10:34:21 | *** sunbiz has quit IRC |
| 10:57:31 | *** sunbiz has joined #openmrs |
| 10:57:31 | *** ChanServ sets mode: +v sunbiz |
| 10:57:40 | *** sunbiz has quit IRC |
| 11:02:07 | *** magoo_ has joined #openmrs |
| 11:06:03 | *** applecool has joined #openmrs |
| 11:06:03 | *** ChanServ sets mode: +v applecool |
| 11:06:23 | <applecool> hi rafa |
| 11:06:30 | <rafa> applecool: hi |
| 11:06:33 | <applecool> good afternoon :) |
| 11:06:54 | <rafa> applecool: how are things going? |
| 11:07:08 | <applecool> fine ! didnt start with the next task! |
| 11:07:16 | <applecool> what would you say? which one would be better |
| 11:07:19 | <applecool> to start now? |
| 11:07:25 | <rafa> applecool: I would go in order |
| 11:07:41 | *** lakkarau has joined #openmrs |
| 11:07:52 | <applecool> okay! you mean the numbering order :) |
| 11:07:53 | <applecool> ? |
| 11:08:00 | <lakkarau> rafa:hi |
| 11:08:03 | <rafa> applecool: yes |
| 11:08:06 | <rafa> lakkarau: hi |
| 11:11:02 | <lakkarau> rafa:(TRUNK-3491)i have attached the patch and it worked ,actually the server was calling the old version code even when i was keep on coping the new generated war file .once i delete the application folder and the war from the tomcat server the log file got created . |
| 11:11:21 | <rafa> lakkarau: great |
| 11:11:40 | <rafa> lakkarau: I'll be sure to reivew your patch soon |
| 11:11:59 | <lakkarau> rafa:thanks |
| 11:17:09 | <applecool> so rafa next i need to solve this! https://tickets.openmrs.org/browse/METAREPO-2 |
| 11:17:09 | <applecool> :) |
| 11:17:24 | *** upul` has quit IRC |
| 11:19:01 | <rafa> applecool: sure, just get to work, no need to notify me I'm getting notifications from JIRA ;) |
| 11:19:22 | <applecool> oh cool! :) great! i will do :) |
| 11:21:22 | *** snoppy has left #openmrs |
| 11:23:15 | *** shortend has joined #openmrs |
| 11:25:28 | <lakkarau> rafa:Trunk-2941 is there a way to access the application folder of the openmrs-wiki site |
| 11:25:58 | <rafa> !ticket TRUNK-2941 |
| 11:25:59 | <OpenMRSBot> rafa: [#TRUNK-2941] Find+Move mediawiki archive pages in confluence - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2941 |
| 11:26:17 | <rafa> lakkarau: what do you mean? |
| 11:26:49 | <lakkarau> like direct access to the folder where the pages are residing |
| 11:27:14 | <rafa> lakkarau: I don't think so |
| 11:27:19 | <rafa> lakkarau: why would you need that? |
| 11:28:03 | <lakkarau> rafa:to make the things move fast.so that i can compare the files. |
| 11:30:24 | <rafa> lakkarau: hmm you mean you want to compare with some diff tool? |
| 11:30:56 | <lakkarau> rafa:yes. |
| 11:31:49 | <rafa> lakkarau: the only way I can see is to click tools -> view wiki markup for two pages and then compare |
| 11:32:33 | <lakkarau> rafa:ok |
| 11:33:45 | <rafa> lakkarau: many of the pages in archive are out dated |
| 11:33:54 | <rafa> lakkarau: so no need to move them |
| 11:34:29 | <lakkarau> rafa:outdated how will i know? |
| 11:34:30 | <rafa> lakkarau: go through them and try to decide if it's something useful and should be moved |
| 11:35:00 | <rafa> lakkarau: like installation of OpenMRS 1.5 is definitely out dated ;) |
| 11:35:16 | <dkayiwa> hi shortend |
| 11:35:17 | <lakkarau> rafa: :-) |
| 11:35:39 | <lakkarau> dkayiwa:hi |
| 11:35:42 | <rafa> lakkarau: if in doubt ask |
| 11:35:45 | <dkayiwa> lakkarau: hi |
| 11:35:47 | <shortend> dkayiwa: Hi there :) |
| 11:35:58 | <lakkarau> rafa:ok |
| 11:36:03 | <dkayiwa> shortend: did you have a question sometime earlier? :) |
| 11:36:43 | <shortend> Yeah. I'm having a tough time getting a service unit test to run. |
| 11:36:57 | <dkayiwa> shortend: can you ask it again? |
| 11:37:25 | *** bwolfe has joined #openmrs |
| 11:37:25 | *** ChanServ sets mode: +o bwolfe |
| 11:37:49 | <shortend> dkayiwa: It seems that I'm not injecting dependencies properly. I get this error message: |
| 11:37:54 | <applecool> rafa: are you satisfied with the metarepo -2 commit? |
| 11:37:57 | <shortend> No value for key [org.hibernate.impl.SessionFactoryImpl@24d3e83f] bound to thread [main] |
| 11:38:17 | <dkayiwa> shortend: can you pastebin your unit test? |
| 11:38:31 | <rafa> applecool: metarepo-2 is still in progress from what I see |
| 11:39:18 | <shortend> dkayiwa: http://pastebin.com/6GEeGvAR |
| 11:39:25 | <applecool> ? the export options is the only thing which should be removed rafa |
| 11:39:51 | <applecool> rafa: did you mean that? by the word in progress? or anything else is pending!? |
| 11:40:00 | <dkayiwa> shortend: any reason why you put the @Transactional attribute on your test? |
| 11:40:09 | <rafa> applecool: you mean metarepo-1? |
| 11:40:19 | <dkayiwa> shortend: i suspect removing it will make your test work :) |
| 11:40:41 | <applecool> oh crap ! yes yes! meta repo-1! |
| 11:40:49 | <applecool> rafa: typo error! :P |
| 11:40:51 | <rafa> applecool: I need to run the app to see how it looks |
| 11:41:28 | <applecool> i will send a screen shot for you :) in a minute! :) |
| 11:41:52 | <shortend> dkayiwa: I get the same message with out the annotation. |
| 11:41:57 | <rafa> applecool: ohh sure |
| 11:42:01 | <rafa> applecool: you can do it from jira |
| 11:42:04 | <dkayiwa> shortend: can you pastebin the error |
| 11:42:16 | <dkayiwa> shortend: all of it with stack trace |
| 11:42:44 | <applecool> rafa: ? |
| 11:42:46 | *** kishoreyekkanti has quit IRC |
| 11:43:00 | <shortend> dkayiwa: http://pastebin.com/8Qhv7Sf3 |
| 11:43:02 | <applecool> you want me to attach the screen shot to the jira? |
| 11:43:04 | <rafa> applecool: click more actions -> attach screenshot |
| 11:43:05 | *** kishoreyekkanti has joined #openmrs |
| 11:43:06 | <applecool> under that ticket? |
| 11:43:14 | <applecool> okay! :) |
| 11:43:56 | <dkayiwa> shortend: is your module committed somewhere i can checkout and look at? |
| 11:45:28 | <shortend> dkayiwa: Well, it's on github. I don't want to bother you too much. That exception isn't telling you anything too definite, I guess. |
| 11:45:46 | <dkayiwa> shortend: right |
| 11:46:43 | <rafa> lakkarau: can you please click log work on TRUNK-3491 and enter how much time you needed. |
| 11:46:47 | <magoo_> dkayiwa kindly send me the link to downdload openmrs with internet download manager |
| 11:47:09 | <shortend> dkayiwa: Is there any module that has hibernate/service tests that I could use as a reference? |
| 11:47:13 | <lakkarau> rafa:i have already loged in the time |
| 11:47:28 | <shortend> I assume I'm just missing something in my ApplicationContext.xml file or something. |
| 11:47:35 | <rafa> lakkarau: ohh sorry, I looked at the wrong bar |
| 11:47:48 | <dkayiwa> shortend: very many such modules. e.g htmlformentry module |
| 11:48:07 | <shortend> Maybe I should take a look at that one. |
| 11:50:36 | <shortend> dkayiwa: Thanks for the help :) |
| 11:50:48 | <dkayiwa> shortend: not much though :) |
| 11:51:06 | <shortend> I'll let you know if I figure it out. |
| 11:51:22 | <shortend> ... can't be that complicated... |
| 11:51:23 | <applecool> the format is not supported on the openmrs jira rafa |
| 11:51:34 | <applecool> its giving the wrong image! |
| 11:51:45 | <rafa> applecool: you just do print screen and paste |
| 11:51:48 | <applecool> ignore it! i will upload a fresh one! :) |
| 11:51:53 | <applecool> okay! |
| 11:52:40 | <magoo_> dkayiwa does openmrs have changelog file for different release |
| 11:53:04 | <dkayiwa> magoo_: have you looked at the release notes page? |
| 11:54:09 | <magoo_> dkayiwa no |
| 11:54:27 | <dkayiwa> magoo_: look at them and see if thats what you need |
| 11:54:40 | <magoo_> dkayiwa okay |
| 11:57:06 | *** applecool has quit IRC |
| 12:02:53 | <bwolfe> kishoreyekkanti, how goes it? |
| 12:03:03 | <kishoreyekkanti> bwolfe: just sent you a mail :-P |
| 12:03:13 | * bwolfe looks |
| 12:04:26 | <bwolfe> woohoo! |
| 12:04:35 | * bwolfe clones it |
| 12:04:46 | <bwolfe> kishoreyekkanti++ |
| 12:05:36 | <bwolfe> kishoreyekkanti, I was right in saying its easy to catch up on commits with gitsvn, right? so if someone commits to trunk OR a branch before we "shut down" svn, you can gitsvn that commit up to github? |
| 12:07:02 | <kishoreyekkanti> bwolfe: Hey ben right now in some call. Can i catch you up in another 30 mins from now? |
| 12:07:27 | <bwolfe> yep |
| 12:08:28 | *** dkayiwa has quit IRC |
| 12:08:52 | <bwolfe> 100+ MB checkout! |
| 12:08:55 | <bwolfe> oooo boy |
| 12:09:17 | <bwolfe> kishoreyekkanti, I'll put my questions here as I come across them, feel free to answer in 30+ minutes |
| 12:09:25 | *** kishoreyekkanti_ has joined #openmrs |
| 12:09:36 | <bwolfe> hmm |
| 12:09:45 | <bwolfe> kishoreyekkanti_, I'll put my questions here as I come across them, feel free to answer in 30+ minutes |
| 12:10:26 | <bwolfe> kishoreyekkanti_, 160+ MB. did you run the "purge past jar files"? https://wiki.openmrs.org/display/docs/Migrating+to+Git |
| 12:11:34 | <bwolfe> I love the branches view in github with the behind/ahead/activity graph! https://github.com/kishoreyekkanti/openmrs-clone/branches |
| 12:11:37 | <OpenMRSBot> <http://ln-s.net/$Vwy> (at github.com) |
| 12:12:06 | <rafa> bwolfe: I would expect much more given 7 years of history ;) git clone --depth 10 let's you clone only 10 last commits for each file which should limit the size if needed |
| 12:12:07 | *** applecool has joined #openmrs |
| 12:12:07 | *** ChanServ sets mode: +v applecool |
| 12:12:22 | <applecool> hey rafa got disconnected! |
| 12:12:23 | <bwolfe> just a hair shy of 200MB. phew! |
| 12:12:26 | <applecool> back now! :) |
| 12:13:10 | *** kishoreyekkanti has quit IRC |
| 12:14:04 | <applecool> rafa: now as i added a useless image on jira! how do i remove it? |
| 12:14:11 | <bwolfe> rafa, so when people clone linux, do they have to specify the --depth in order to not get a 10gb checkout? |
| 12:14:34 | <applecool> rafa: i got it! :) |
| 12:15:15 | <rafa> bwolfe: I don't believe it's 10gb ;) |
| 12:15:29 | <rafa> bwolfe: the problem with depth is that you can't push afaik |
| 12:15:36 | <rafa> bwolfe: just send patches |
| 12:16:07 | <applecool> rafa: added it! |
| 12:16:08 | <bwolfe> so they we're doing something wrong. the clone is 10-20x the size of the master branch. I would guess the jars or other executables are still in there somewhere |
| 12:19:10 | *** magoo_ has quit IRC |
| 12:19:48 | <bwolfe> *then we're doing |
| 12:23:30 | *** wyclif has quit IRC |
| 12:29:53 | *** nwilkie has joined #openmrs |
| 12:32:51 | *** nwilkie has quit IRC |
| 12:34:31 | <kishoreyekkanti_> bwolfe: ok back now |
| 12:35:19 | <kishoreyekkanti_> bwolfe: can we have a quick Skype chat. I need to jump in another call with in 15 minutes and i have bunch of another calls for next 4 hours and then i'll sleep ;) |
| 12:35:38 | <bwolfe> kishoreyekkanti_, are you still joining the univ call in 30 mins? |
| 12:35:57 | <kishoreyekkanti_> bwolfe: aargh! forgot about it. |
| 12:36:04 | <kishoreyekkanti_> bwolfe: Any ways i'll join that for 30 mins |
| 12:36:18 | <kishoreyekkanti_> bwolfe: I mean i'll be there for first half of the call |
| 12:36:24 | *** downey has joined #openmrs |
| 12:36:24 | *** ChanServ sets mode: +o downey |
| 12:36:24 | *** OpenMRSBot sets mode: +o downey |
| 12:36:25 | <bwolfe> ok |
| 12:36:36 | <kishoreyekkanti_> bwolfe: so wann catchup on Skype quickly now? |
| 12:36:53 | <bwolfe> sure |
| 12:44:29 | *** nwilkie has joined #openmrs |
| 12:46:17 | *** rfriedman has joined #openmrs |
| 12:46:25 | *** dkayiwa has joined #openmrs |
| 12:46:34 | <dkayiwa> hi bwolfe |
| 12:47:12 | <dkayiwa> bwolfe: can i get permission to make ready for work tickets like reporting, htmlformentry, htmlwidgets, formentry etc |
| 12:47:31 | <dkayiwa> downey: maybe you are the one i need to talk to :) |
| 12:50:44 | *** nwilkie has quit IRC |
| 12:55:30 | <rfriedman> bet downey has not downed his coffee |
| 12:57:13 | *** nadee has joined #openmrs |
| 12:57:15 | <rfriedman> or he is busy whistling music on hold for the univ call |
| 12:57:37 | *** djazayeri1 is now known as djazayeri |
| 12:57:37 | *** ChanServ sets mode: +o djazayeri |
| 13:01:54 | *** bwolfe has quit IRC |
| 13:06:26 | *** nadee has quit IRC |
| 13:07:57 | *** nwilkie has joined #openmrs |
| 13:12:19 | *** wyclif has joined #openmrs |
| 13:14:54 | *** bwolfe has joined #openmrs |
| 13:14:54 | *** ChanServ sets mode: +o bwolfe |
| 13:26:35 | <shortend> dkayiwa: Thanks for pointing me in the right direction. |
| 13:26:41 | <shortend> My test is running now. |
| 13:26:42 | *** jordank has joined #openmrs |
| 13:27:30 | <shortend> I think my problem may have been an underlying exception masked by that one about "No value for key" |
| 13:27:36 | <dkayiwa> shortend: oh great :D |
| 13:28:41 | <shortend> dkayiwa: Hey, maybe I should introduce myself. |
| 13:29:03 | <dkayiwa> shortend: surely yes because the short end may be a long end :) |
| 13:29:18 | <shortend> Haha |
| 13:29:28 | <shortend> My name's Daniel Shorten, and I'm working on a health manage information system in Kenya based on OpenMRS. |
| 13:29:42 | <shortend> We're calling it OpenHMIS. |
| 13:29:45 | <dkayiwa> shortend: oh great to have you onboard!!! |
| 13:30:02 | <dkayiwa> shortend: by the way on you on the OpenMRS university call which is happening right now? |
| 13:30:14 | <dkayiwa> shortend: very nice to listen in :) |
| 13:30:23 | <shortend> i |
| 13:30:58 | <shortend> dkayiwa: I should probably be in there, although the last time I tried my connection was just not good enough to understand much. |
| 13:31:19 | <dkayiwa> shortend: please do connect my namesake!!! :) |
| 13:33:18 | *** applecool has quit IRC |
| 13:39:10 | *** applecool has joined #openmrs |
| 13:39:10 | *** ChanServ sets mode: +v applecool |
| 13:44:27 | *** dkayiwa_ has joined #openmrs |
| 13:45:33 | *** jriley has joined #openmrs |
| 13:46:46 | *** dkayiwa has quit IRC |
| 13:46:46 | *** dkayiwa_ is now known as dkayiwa |
| 13:46:59 | *** kavuri has joined #openmrs |
| 13:50:36 | *** lh has quit IRC |
| 13:51:35 | *** lh has joined #openmrs |
| 13:51:35 | *** lh has joined #openmrs |
| 13:52:09 | *** kavuri has quit IRC |
| 13:53:14 | *** kavuri has joined #openmrs |
| 13:55:23 | *** suranga has joined #openmrs |
| 13:55:36 | *** jordank has quit IRC |
| 13:58:45 | <suranga> hi bwolfe, I , the prodigal has returned ! |
| 13:58:57 | <bwolfe> was I missing? |
| 13:59:15 | <suranga> bwolfe, I was referring to myself :P |
| 13:59:31 | <bwolfe> oh |
| 13:59:32 | <bwolfe> well |
| 13:59:34 | <bwolfe> welcome back! |
| 13:59:52 | <suranga> bwolfe, if you find yourself free at any time, could you please take a look at the mockups I managed to create so far ? :( |
| 14:00:14 | <suranga> https://tickets.openmrs.org/browse/HLQRY-12 |
| 14:00:16 | <suranga> https://tickets.openmrs.org/browse/HLQRY-11 |
| 14:00:31 | <suranga> bwolfe, ^^ thease are for the two admin pages... |
| 14:01:41 | <bwolfe> suranga, the Manage Templates and Manage Segments should be the same page |
| 14:01:46 | <bwolfe> I see no reason to separate the two |
| 14:01:48 | <suranga> bwolfe, and I also created a new wiki parent page "https://wiki.openmrs.org/display/projects/OpenMRS+hl7query+module+design+page" |
| 14:01:53 | <suranga> bwolfe, oops |
| 14:01:59 | <bwolfe> a segment is a template. it is just a smaller template |
| 14:02:20 | <suranga> bwolfe, wont that clutter up the pages ? |
| 14:02:22 | <bwolfe> the Manage Template page could have: |
| 14:02:35 | <bwolfe> 1) name box ("My ORUR01" or "Default ORUR01") |
| 14:02:38 | <suranga> I thought we wanted to have a clear seperation between both... mm... |
| 14:03:00 | <bwolfe> 2) compatible openmrs version box ("1.8.3+", "1.8.1-1.8.2") |
| 14:03:15 | *** maurya has joined #openmrs |
| 14:03:30 | <bwolfe> 3) hl7 message code ("ORU-R01"...or blank if its just a segment) |
| 14:03:37 | <bwolfe> 4) the large text area |
| 14:03:52 | <bwolfe> 5) the list of other templates that can be "called" from your current template |
| 14:03:58 | <bwolfe> 6) a save button |
| 14:04:47 | <suranga> bwolfe, assume that there are several types of message templates. as well as segments |
| 14:05:00 | <suranga> we'll be displaying both on the same text area |
| 14:05:09 | <suranga> wont that clutter up the process ? |
| 14:05:31 | <bwolfe> 7) a "save as new" button with a name box maybe too |
| 14:06:09 | <bwolfe> it simplifies the process. then you only have one Manage TEmplates admin page. and only have to code one Manage Template page. and only one table |
| 14:06:10 | <suranga> bwolfe, so the drop down list contains the template names (ORURo1 .1.9 or 1.8 etc |
| 14:06:11 | <bwolfe> and one controller |
| 14:06:28 | <bwolfe> yes, contains the names |
| 14:06:39 | <suranga> we use another list to display the segments ? |
| 14:06:46 | <suranga> (pid, pv1 etc) |
| 14:06:57 | <bwolfe> its just a "helper" that uses javascript to put in "<% callTemplate("ORURo1 1.9") %> for you |
| 14:07:14 | <bwolfe> segment == template |
| 14:07:16 | <bwolfe> one list! |
| 14:07:43 | *** jordank has joined #openmrs |
| 14:08:09 | <bwolfe> if the user puts in an hl7 code for 3) above, then the controller validates the template via hapi to make sure its valid xml |
| 14:11:40 | <bwolfe> ok. scrum time |
| 14:11:47 | <bwolfe> cpower is missing today, so I'll run it |
| 14:11:50 | <bwolfe> !scrumon |
| 14:11:50 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster - you may begin when ready. |
| 14:11:54 | <bwolfe> today's order: |
| 14:12:20 | <bwolfe> lakkarau, djazayeri, rafa, wyclif, kishoreyekkanti_, suranga, bwolfe |
| 14:12:23 | <bwolfe> anyone I miss? |
| 14:12:48 | <kishoreyekkanti_> bwolfe: I'm in another call. and i guess you know my updates :) |
| 14:12:52 | *** wyclif has quit IRC |
| 14:13:09 | *** wyclif has joined #openmrs |
| 14:13:11 | <bwolfe> np |
| 14:13:18 | <bwolfe> lakkarau, are you still around? |
| 14:13:41 | <djazayeri> I'll go first |
| 14:13:46 | <djazayeri> Yesterday |
| 14:13:46 | <djazayeri> * ITECH work |
| 14:13:47 | <djazayeri> * Recorded a screencast for OpenMRS University (that took most of the day…) |
| 14:13:47 | <djazayeri> * META-238 - UX Improvements to Choose Import Mode |
| 14:13:48 | <djazayeri> Today |
| 14:13:50 | <suranga> bwolfe, will get back to you, im on two other conversations :( |
| 14:13:51 | <djazayeri> * Lots of calls |
| 14:13:56 | <djazayeri> * more ITECH work |
| 14:14:03 | <djazayeri> no blockers |
| 14:14:48 | <bwolfe> ok, rafa? |
| 14:14:57 | <rafa> Today: |
| 14:14:57 | <rafa> * Reverted TRUNK-3627: ConceptReferenceTermValidator should not check if objects are saved |
| 14:14:57 | <rafa> https://tickets.openmrs.org/browse/TRUNK-3627 |
| 14:14:57 | <rafa> * Reviewed TRUNK-3491: Write to independent log file |
| 14:14:57 | <rafa> https://tickets.openmrs.org/browse/TRUNK-3491 |
| 14:14:57 | <rafa> * Committed TRUNK-3319: Person attribute autofill shows nothing if concept name doesn't exist in users' language |
| 14:14:57 | <rafa> https://tickets.openmrs.org/browse/TRUNK-3319 |
| 14:14:59 | <rafa> * Working on TRUNK-2767: Concept name searches uses the slower ilike |
| 14:14:59 | <rafa> https://tickets.openmrs.org/browse/TRUNK-2767 |
| 14:15:00 | <rafa> No blockers. |
| 14:15:02 | <bwolfe> djazayeri, screencast was nice. can you link to it from one or all of hte git wiki pages? |
| 14:15:10 | <djazayeri> bwolfe: sure |
| 14:15:16 | <wyclif> Tuesday: |
| 14:15:16 | <wyclif> Curate tickets |
| 14:15:17 | <wyclif> Wiki documentation in relation to git migration |
| 14:15:17 | <wyclif> Reviewed CALC-44, CALC-45 |
| 14:15:17 | <wyclif> Wednesday: |
| 14:15:17 | <wyclif> university call |
| 14:15:19 | <wyclif> curate tickets |
| 14:15:21 | <wyclif> design call |
| 14:15:23 | <wyclif> Blockers: None |
| 14:16:10 | <bwolfe> kishoreyekkanti_ said he has it up in his repo for testing. I'll send an email out to everyone with the url and comments |
| 14:16:20 | <bwolfe> it == openmrs trunk |
| 14:16:26 | <bwolfe> (thats his update) |
| 14:16:39 | <wyclif> cool |
| 14:16:50 | <bwolfe> suranga's update is that he is still working on tickets for the sprint. looking forward to the design call today |
| 14:17:06 | <suranga> :-) |
| 14:17:19 | <bwolfe> djazayeri, your quick opinion. any reason we should treat templates and segments differently? (to be discussed after spring) |
| 14:17:21 | <bwolfe> *sprint |
| 14:17:30 | <djazayeri> *scrum |
| 14:17:42 | <dkayiwa> :) |
| 14:18:00 | <bwolfe> my update: Tuesday |
| 14:18:00 | <bwolfe> (vacation day) |
| 14:18:00 | <bwolfe> help suranga with hl7query design |
| 14:18:01 | <bwolfe> Wenesday |
| 14:18:01 | <bwolfe> trunk githubbing review |
| 14:18:01 | <bwolfe> univ call |
| 14:18:03 | <bwolfe> design call |
| 14:18:05 | <bwolfe> pm call |
| 14:18:07 | <bwolfe> no blockers |
| 14:18:14 | <bwolfe> dkayiwa, you're up. I left you out of the list above. :-( |
| 14:18:25 | <dkayiwa> Did some review for my gsoc student's work |
| 14:18:25 | <dkayiwa> Curated tickets |
| 14:18:26 | <dkayiwa> University Call |
| 14:18:26 | <dkayiwa> Still Curating more tickets (Need permissions to make reporting/htmlformentry/htmlwidgets, etc module tickets ready for work) |
| 14:18:26 | <dkayiwa> No Blockers |
| 14:19:40 | <djazayeri> dkayiwa: do you have examples of tickets in those modules that you'd like to make ready-for-work? |
| 14:20:34 | <bwolfe> any other scrum activity? |
| 14:20:37 | <dkayiwa> djazayeri: i did just opened random ticket and realized that i did not have ready for work available. so i gave up on even trying them out |
| 14:21:07 | <dkayiwa> djazayeri: but to give an example HTML-321 |
| 14:21:11 | <dkayiwa> !ticket HTML-321 |
| 14:21:13 | <OpenMRSBot> dkayiwa: [#HTML-321] workflowState tag changing state start dates when re-submitting a form - OpenMRS JIRA - https://tickets.openmrs.org/browse/HTML-321 |
| 14:21:16 | <bwolfe> !scrumoff |
| 14:21:16 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 14:21:28 | <bwolfe> first discussion is going on: daniel making tickets ready for work |
| 14:21:35 | <dkayiwa> djazayeri: hahaha, looks like some one has now given me permisions :) |
| 14:21:47 | <djazayeri> dkayiwa: hold on though, don't do it yet! |
| 14:21:47 | <bwolfe> (I just did) |
| 14:21:47 | <djazayeri> :-) |
| 14:21:53 | <djazayeri> I want to have the discussion first actually |
| 14:21:56 | <dkayiwa> bwolfe: :D |
| 14:22:00 | <dkayiwa> thanks |
| 14:22:22 | <bwolfe> discussion about that specific one, or about him being able to do it? |
| 14:22:25 | <djazayeri> I just asked Mark G to join, as module owner |
| 14:22:37 | <djazayeri> about anyone besides Mark being able to do it |
| 14:22:47 | <djazayeri> and what guidelines should be for that. |
| 14:23:03 | *** MarkG has joined #openmrs |
| 14:23:15 | <djazayeri> ah, MarkG is here |
| 14:23:53 | <djazayeri> So, MarkG is the owner of the HTML Form Entry module. And he's been pretty actively managing the module's roadmap so far. |
| 14:24:11 | <djazayeri> We haven't actually ever told him or other module owners much about the "curation" we're doing. |
| 14:24:31 | <djazayeri> So I guess the question is: do module owners decide whether their module tickets get curated? Can they set some guidelines on it? |
| 14:24:53 | <MarkG> can we define curation? |
| 14:24:55 | <djazayeri> E.g. if dkayiwa or wyclif or bwolfe is going to mark a ticket ready-for-work, what fix version would they set, etc? |
| 14:25:04 | <bwolfe> I think if we're labeling it as a "core project", then we have curation power too... |
| 14:25:06 | <djazayeri> what if MarkG disagrees with the design, or the request. etc |
| 14:25:49 | <dkayiwa> djazayeri: what i have been doing is that i ensure the stake holder are watcher before i change anything :) |
| 14:25:50 | <djazayeri> MarkG: our wiki page says: |
| 14:25:52 | <djazayeri> A well curated ticket should have/be: |
| 14:25:52 | <djazayeri> 1. Ticket should not be duplicate in the repository |
| 14:25:52 | <djazayeri> 2. Must have short/accurate summary. |
| 14:25:52 | <djazayeri> 3. Description should give background information and a proposed solution/outcome such that a newcomer know where to start |
| 14:25:52 | <djazayeri> 4. Description (or a comment) should have the expected files to edit |
| 14:25:52 | <djazayeri> 5. The Severity, Complexity, and Expected Time fields should be filled out |
| 14:25:52 | <djazayeri> 6. Add a label of "curated" to the ticket |
| 14:25:53 | <djazayeri> 7. If the ticket is simple enough for someone brand new to openmrs, set complexity=low add a label of "intro" |
| 14:26:09 | <bwolfe> https://wiki.openmrs.org/display/RES/Tickets+Curation+Swim+Lane |
| 14:26:43 | <MarkG> so curated is like a more-defined "ready for work"? |
| 14:27:07 | <MarkG> ie, what does it mean if a ticket is labeled as curated? |
| 14:27:09 | <bwolfe> yeah, means "cleaned up" |
| 14:27:22 | <djazayeri> MarkG: Yes. In general, we have decided that we want to devote more core dev time to ensuring that tickets are ready-for-work, with better descriptions, and proposed solutions, to make it easier for people coming along to pick them up. |
| 14:27:24 | <bwolfe> "polished" |
| 14:28:04 | <djazayeri> So…as a module owner, and one who's been managing the module's roadmap quite actively…is that cool? e.g. as long as you're a watcher on all tickets, and you're the one who actually sets fixVersions? |
| 14:28:48 | <djazayeri> Do you have any guidelines, restrictions, etc, that you might want to put in place? |
| 14:29:05 | <MarkG> yeah, that's fine... now that i undernstand what curated means, i will keep an eye on any hfe tickets that are marked as curated, and if i think that is wrong for some reason i will remove "curated" tag (and comment on the issue) |
| 14:29:27 | <djazayeri> Okay, sounds good. |
| 14:29:38 | <djazayeri> bwolfe, dkayiwa, have you been setting fixVersions on tickets as you curate them? |
| 14:29:49 | <dkayiwa> djazayeri: yes |
| 14:30:02 | <MarkG> djazayeri: i don't see any specific restrictions... if i notice something happening a lot, i will raise is on the dev list |
| 14:30:07 | <djazayeri> okay |
| 14:30:12 | <djazayeri> MarkG: what about fixVersions? |
| 14:30:13 | <MarkG> dkayiwa: how are you determinig fix version? |
| 14:30:17 | <bwolfe> I don't think setting a fixVersion is necessary for curation |
| 14:30:42 | <dkayiwa> MarkG: not done it for those modules because i did not haver permissions :) |
| 14:30:55 | <dkayiwa> MarkG: but now that i have, aha ..... |
| 14:31:24 | <MarkG> MarkG: i was using fixVersion as a very loose way to priotize tickets into buckets... i'm guessing that is not the best practice for fixVersion, but... |
| 14:31:42 | <djazayeri> dkayiwa: in the example ticket you mentioned |
| 14:31:43 | <djazayeri> !ticket HTML-321 |
| 14:31:44 | <OpenMRSBot> djazayeri: [#HTML-321] workflowState tag changing state start dates when re-submitting a form - OpenMRS JIRA - https://tickets.openmrs.org/browse/HTML-321 |
| 14:31:45 | <MarkG> i wouldn't worry too much about setting fixVersion |
| 14:31:54 | <djazayeri> dkayiwa: how would you have chosen a fixVersion? |
| 14:32:58 | <dkayiwa> djazayeri: for simple changes, would chose the very next version |
| 14:33:03 | <bwolfe> nah |
| 14:33:07 | <MarkG> why is this an example ticket? this ticket certainly isn't "curated" |
| 14:33:08 | <bwolfe> just leave it blank |
| 14:33:14 | <bwolfe> once we have a patch we can add a fixVersion |
| 14:33:27 | <MarkG> what bwolfe says sounds like best practice |
| 14:33:27 | <djazayeri> MarkG: it's an example of a ticket that dkayiwa _would have_ curated, but didn't have privileges |
| 14:33:28 | <bwolfe> or if it is important, add a fixVersion (and backport versions) |
| 14:33:36 | <djazayeri> I agree |
| 14:34:35 | <MarkG> djazayeri: i meant, in particular HTML-321 should be "Needs Designs", "Will Not Fix", or stay in "Needs Assessment" |
| 14:34:42 | <djazayeri> bwolfe, dkayiwa, wyclif, rafa: so the person doing curation should not set fixVersions on module tickets. They may do so on core tickets, but they don't have to do it there either. Maybe just for bugfixes that seem really important. |
| 14:34:51 | *** pushkar has joined #openmrs |
| 14:35:03 | <dkayiwa> djazayeri: ok |
| 14:35:22 | <djazayeri> dkayiwa: seeing what MarkG just said, assuming you hadn't seen that yet, how would you have curated HTML-321? |
| 14:35:22 | <dkayiwa> djazayeri: makes our work easier :) |
| 14:35:26 | <wyclif> ok |
| 14:35:28 | <bwolfe> ok. sounds like a good sentence ot put on that curation swim lane wiki page |
| 14:35:45 | <djazayeri> I'm currently editing another wiki page. Can someone else do it? |
| 14:35:55 | <bwolfe> you can't edit two? ;-0 |
| 14:36:10 | <dkayiwa> djazayeri: i did not even ready anything on that ticket. i just noticed missing ready for work button and simply closed it. so there was a possibility that i would not even have curated it |
| 14:36:22 | <dkayiwa> ready = read :) |
| 14:36:27 | <djazayeri> okay |
| 14:36:36 | <bwolfe> I can add it to the page |
| 14:37:06 | <djazayeri> So the main takeaway there is that it's okay to *not* mark something as ready-for-work, especially in a module you're not super familiar with. |
| 14:37:17 | <dkayiwa> ok |
| 14:37:18 | <djazayeri> Would we want a way to mark those? |
| 14:40:48 | <pushkar> bwolfe, HI |
| 14:41:21 | *** bwolfe_ has joined #openmrs |
| 14:41:21 | *** ChanServ sets mode: +o bwolfe_ |
| 14:42:38 | <djazayeri> Okay, also during the scrum, bwolfe asked: djazayeri, your quick opinion.  any reason we should treat templates and segments differently?  (to be discussed after spring) |
| 14:43:01 | <djazayeri> bwolfe_: you there? |
| 14:43:06 | <suranga> djazayeri, yep, good question |
| 14:43:25 | *** bwolfe has quit IRC |
| 14:43:26 | *** bwolfe_ is now known as bwolfe |
| 14:43:27 | <bwolfe> yes |
| 14:43:32 | <suranga> maybe rfriedman is also here ? |
| 14:44:05 | <djazayeri> My answer is that from a technical perspective, no, there should be no difference, they're all just templates, and those templates may include other templates. |
| 14:44:20 | <suranga> bwolfe, djazayeri if we dont differentiate between the two, how will we know which are eligible to create ORU messages out of ? |
| 14:44:51 | <suranga> djazayeri, for example, I have a list of templates and segments, what if someone tries to create an hl7 message using an segment only... ? |
| 14:44:54 | <djazayeri> Conceptually there are 3 broad levels of granularity of templates, and when creating tickets I think it's helpful to say in the ticket description: "Create a Message/Segment/Field-level template ..." |
| 14:45:37 | <djazayeri> suranga: when does the user ever create an hl7 message currently? |
| 14:46:34 | <suranga> he has an admin page, where he will get a default message |
| 14:46:39 | <djazayeri> suranga: we'll have a controller that handles requests for oru-r01s. I'm assuming that in the first pass that's hardcoded to look for a template called "ORU-R01" |
| 14:46:46 | <suranga> he can either edit it, or create a new one from scratch... |
| 14:47:22 | <suranga> djazayeri, so we cant actually have several templates for the first pass ? |
| 14:47:54 | <djazayeri> suranga: it's up to you. But are you envisioning a UI where we ask "what template do you want to use?" and they pick a template from a list? |
| 14:47:58 | <bwolfe> suranga, its all about the name. the name column must be unique |
| 14:48:00 | <rfriedman> i don't even put segments and templates in the same category |
| 14:48:13 | <bwolfe> whatever the admin names the ORU-R01 template will be used for the controller encounter methods |
| 14:48:28 | <djazayeri> does the admin even get to choose the name? |
| 14:48:59 | *** MarkG has left #openmrs |
| 14:49:11 | <bwolfe> that is why I suggested adding the "hl7 message code" column to the templates table. if the admin enters a ORUR01 there, then that can be used to validate the message. that way the controller knows it is a full message and not just a segment or field |
| 14:49:36 | <suranga> bwolfe, that sounds good... |
| 14:49:49 | <suranga> so for now, we'll have just one ORUR01 |
| 14:50:03 | <rfriedman> why is validating getting mixed up with transforming? |
| 14:50:37 | <rfriedman> i really don't understand this conversation, seems like you are on another planet |
| 14:50:49 | <djazayeri> bwolfe, suranga: are there any mockups showing the workflow you're envisioning here? |
| 14:51:08 | <bwolfe> surange made mockups on two tickets tha tseparated templates and segments |
| 14:51:16 | <suranga> (nod) |
| 14:51:20 | <bwolfe> !ticket HLQRY-11 |
| 14:51:21 | <OpenMRSBot> bwolfe: [#HLQRY-11] Create a Manage Templates admin page for the hl7query table - OpenMRS JIRA - https://tickets.openmrs.org/browse/HLQRY-11 |
| 14:51:24 | <bwolfe> !ticket HLQRY-12 |
| 14:51:25 | <OpenMRSBot> bwolfe: [#HLQRY-12] Create a Manage Message Segments admin page - OpenMRS JIRA - https://tickets.openmrs.org/browse/HLQRY-12 |
| 14:51:28 | <suranga> but those treat segments and templates as two things.. |
| 14:51:37 | <bwolfe> but I think those should be combined into one admin screen |
| 14:52:05 | <djazayeri> bwolfe, suranga, rfriedman: All I'm saying is that there should only be one table and domain object to hold all the templates (for messages, segments, elements). It's okay to have a column that distinguishes between messages, and lower-level ones, but that doesn't seem strictly necessary for release 1. |
| 14:52:37 | <rfriedman> but take my spanish example |
| 14:53:01 | <rfriedman> we need to change the template used for transforming a person to an XPN |
| 14:53:24 | <rfriedman> we need to make sure that the new version of the template is used for the PID segment |
| 14:53:38 | <djazayeri> suranga: for one, I suggest that we use that standard OpenMRS UI approach of showing a list of all the items, then you click on one, and you get its edit scren. |
| 14:53:42 | <rfriedman> we need to make sure that the new version of the template is used for the message implicated |
| 14:55:12 | <bwolfe> rfriedman, simple enough. you just change the PID template to refer to your new XCN template (or you just change the XCN template) |
| 14:55:12 | <djazayeri> suranga: I think we should be making a distinction between "editing a groovy template" as a low-level administrative task, and configuring the way some of those tempaltes are used for messages |
| 14:55:53 | <djazayeri> suranga: I agree with bwolfe that there should be just a single administrative screen with a big textarea for editing a groovy template |
| 14:56:08 | <suranga> hmm.. sounds good :) |
| 14:56:09 | <rfriedman> bwolfe, i think we need to have a versioning capability, or a rename capability, or both |
| 14:56:42 | <djazayeri> suranga: I can imagine a *different* administrative screen, that's not so low-level, which lets you choose which saved template you want to use to respond to ORU-R01s |
| 14:57:01 | <bwolfe> letting the admin decide how to do that seems simple enough. they can just "save as new" and/or rename the old to something else |
| 14:57:39 | <bwolfe> djazayeri, thats interesting. I don't think its necessary to have a separate page |
| 14:57:46 | <bwolfe> its a 1 to 1 |
| 14:57:55 | <rfriedman> i certainly do, it's not 1 to 1 |
| 14:58:10 | <bwolfe> how can you have multiple templates respond to ORUR01 ?! |
| 14:58:32 | <rfriedman> because you end up with different versions of ORUR01 |
| 14:58:54 | <rfriedman> let's suppose we're sending things to insurance companies |
| 14:59:01 | <bwolfe> but the "current truth" is always only one |
| 14:59:21 | <bwolfe> but then you need other distinguishing characteristics |
| 14:59:53 | <rfriedman> yes |
| 14:59:54 | <bwolfe> I envision a way to pull out hl7 by specifying hte template name. so if you are doing a query for a specific insurance company, then you say ?template=ORUR01-insurance-company-X |
| 15:00:14 | <rfriedman> yes |
| 15:00:18 | <djazayeri> bwolfe: if it were me, my version 1 would include an admin page for managing the groovy templates, and I'd have a controller that listens for ORU-R01 requests, and the fetches the groovy template with the hardcoded name of "ORU-R01" |
| 15:00:31 | <bwolfe> yes |
| 15:00:46 | <bwolfe> thats also my vision |
| 15:00:58 | <djazayeri> bwolfe: next step would be to let the administrator choose "which template for this specific ORU-R01 endpoint" |
| 15:00:59 | <bwolfe> (with a few extras in there) |
| 15:01:22 | <rfriedman> i guess i don't see what's so special about ORUR01 |
| 15:01:44 | <rfriedman> if you have the ability to have different ORUR01s, you have the ability to create different messages |
| 15:02:20 | <rfriedman> the things that are fixed are the fields in the segments, their cardinality and their datatype |
| 15:02:38 | <rfriedman> i think you can get this info from HAPI |
| 15:03:34 | <suranga> (im listening, but keeping quiet) |
| 15:03:35 | <rfriedman> the messages have to be more flexible, as do the templates |
| 15:04:11 | <rfriedman> that's what i originally wanted to chat with you about, suranga, your idea of validation |
| 15:04:26 | <rfriedman> i don't think it's right |
| 15:04:50 | <suranga> mm.... we could validate by trying to convert the segment into an hl7 object, right ? |
| 15:05:08 | <rfriedman> you can validate a segment or a field of a segment based on position, type, and cardinality |
| 15:05:16 | <pushkar> bwolfe, how can we send the return page url to the portlet ? |
| 15:05:47 | <rfriedman> (not position of a segment, just of a field or subfield) |
| 15:05:50 | <pushkar> bwolfe, do we have to write a custom portlet controller for that ?? |
| 15:06:39 | <rfriedman> suranga, have you looked at the full ORUR01 message definition, at the site i cited or elsewhere? |
| 15:07:11 | <bwolfe> rfriedman, I think only full templates shoudl be validated. and the admin needs to say what type of message to validate as |
| 15:07:29 | <suranga> rfriedman, I did look at yours, but it seemed quite complex for my brain cell :-( |
| 15:07:43 | <rfriedman> bwolfe, i think you are elevating message type too much |
| 15:07:48 | <djazayeri> bwolfe, suranga, rfriedman: the point is that in the first version, we will have a specific endpoint like hostname/openmrs/module/hl7query/orur01 |
| 15:07:52 | <bwolfe> pushkar, you could pass it in as a "parameter". your porlet can then see that value via ${model.paramname} |
| 15:08:21 | <djazayeri> rfriedman: what's special about ORU-R01 is that we're going to focus on it for a first version of the module |
| 15:08:48 | <djazayeri> rfriedman: we're not limiting ourselves to it, but we haven't designed a more generic mechanism (yet) |
| 15:08:50 | <rfriedman> people do many different things and call them ORUR01 |
| 15:08:59 | <pushkar> bwolfe, okay Thank you ! |
| 15:09:17 | <bwolfe> rfriedman, but they should all validate |
| 15:09:20 | <bwolfe> (as orur01) |
| 15:09:38 | <bwolfe> they can leave out a lot of things and it still validates |
| 15:09:47 | <rfriedman> bwolfe, yes |
| 15:10:05 | <rfriedman> but it doesn't necessarily validate to their use of ORUR01 |
| 15:10:37 | <rfriedman> in other words, some fields in the segments may be optional, but due to the message guide, they are not optional for a particular communication |
| 15:11:39 | <rfriedman> HL7 is under-specified, that's why message guides are necessary |
| 15:12:01 | <bwolfe> rfriedman, it is a MUCH harder job for us to add in a way for custom validation |
| 15:12:03 | <bwolfe> that can be version 3 |
| 15:12:21 | <bwolfe> (unless hapi can accept some standard message guide out there) |
| 15:12:49 | <rfriedman> djazayeri, so if I do a get on your URL, what parameter do i send? a patient or an encounter or a cohort of either or what? |
| 15:13:21 | <rfriedman> bwolfe, you validate by construction |
| 15:13:56 | <bwolfe> rfriedman, please explain that, I don't know hwat you're meaning |
| 15:14:19 | <bwolfe> rfriedman, the url takes in a patient identifier or an encounter uuid. |
| 15:14:21 | <rfriedman> so in the template, if the field is required and the provided object is empty, you throw an error |
| 15:14:57 | <djazayeri> rfriedman: it's up to suranga to define how that page works |
| 15:15:07 | <rfriedman> what page? |
| 15:15:28 | <djazayeri> rfriedman: the URL for ORUR01. he can define how that will work in v1 for this sprint |
| 15:16:09 | <rfriedman> suranga, looks like he passed the buck to you |
| 15:17:01 | <djazayeri> rfriedman: at some point we'll add a more sophisticated mechanism for requesting arbitrary message types, not just the few hardcoded ones |
| 15:17:46 | <rfriedman> ok suranga, have you at least checked your message guide and made sure that it is using ORUR01 rather than what you referred to in your correspondence? |
| 15:18:22 | *** lakkarau has quit IRC |
| 15:19:13 | *** applecool has quit IRC |
| 15:19:30 | *** kavuri has quit IRC |
| 15:20:01 | <rfriedman> djazayeri, my point is that there is no such thing as a uniform ORUR01 message and it doesn't do any good to hardcode it |
| 15:20:14 | <djazayeri> rfriedman: on call, hold on |
| 15:20:48 | <bwolfe> rfriedman, we're not hard coding it. we will provide a default template for it. the admin can change anything/everything about it if they want |
| 15:21:01 | <bwolfe> rfriedman, the admin decides what orur01 means to them |
| 15:21:23 | <rfriedman> bwolfe, can it mean 2 things? |
| 15:21:43 | <rfriedman> can they do the edit/save as as your discussed? |
| 15:22:22 | <bwolfe> rfriedman, no. there will be one orur01 per implementation. they can create one named orur01-customized if they want. but until we do that custom url that lets you call any template name, it won't be callable |
| 15:22:34 | <kishoreyekkanti_> downey: Hey mike |
| 15:22:36 | <bwolfe> (I htink the custom url is easy to do and should be in version 1) |
| 15:23:35 | <downey> hi kishoreyekkanti_ |
| 15:23:37 | <kishoreyekkanti_> downey: i'm sure you might have guessed why i pinged you now :). Yes, Its for the downgrading of firefox in CI box ;) |
| 15:23:54 | <djazayeri> rfriedman: what bwolfe said. We will create a default ORUR01. This will be editable. Initially you'll only be allowed a single ORUR01, but eventually that will be added. |
| 15:24:33 | <rfriedman> bwolfe, and the ORUR01 looks sort of like the XML that suranga posted? |
| 15:24:36 | * downey is really disappointed that our test platform keeps breaking as browser updates :) |
| 15:25:09 | *** applecool has joined #openmrs |
| 15:25:09 | *** ChanServ sets mode: +v applecool |
| 15:25:16 | <djazayeri> rfriedman: I mean: eventually we'll support having multiple variants of messages, but this is not part of the MVP. |
| 15:25:22 | *** shortend has quit IRC |
| 15:25:42 | <rfriedman> djazayeri, so that is what i am trying to determine, whether the MVP message really is an ORUR01 message |
| 15:25:48 | <rfriedman> in Mead's other work, it has not been |
| 15:25:57 | <rfriedman> ORUR01 has been Burke's fixation |
| 15:26:10 | <bwolfe> rfriedman, the template creates xml like what he posted. the xml is magically turned into pipes by HAPI |
| 15:26:27 | <djazayeri> rfriedman: I'm counting on suranga to decide what the useful first message is, given his knowledge of Jembi use cases. Personally I don't care if it's an ORUR01 |
| 15:26:45 | <rfriedman> suranga, are you still here? |
| 15:26:52 | <kishoreyekkanti_> downey: Not sure what would be the best way to deal with that. Nevertheless i would do some exploration on that front. In the mean time can you please downgrade the same |
| 15:27:26 | <kishoreyekkanti_> downey: I don't want people to see that red always and going forward it would not even be taken as an alarm for a possible real build failure |
| 15:28:41 | <rfriedman> djazayeri, bwolfe i think suranga is gone and don't see much profit in this discussion without him |
| 15:29:32 | *** nwilkie has quit IRC |
| 15:29:51 | *** nwilkie has joined #openmrs |
| 15:31:04 | <djazayeri> rfriedman: fair enough. the main point is that suranga (and Jembi) should define the first message, but the technical underpinnings aren't going to be tied specifically to that. |
| 15:31:31 | <rfriedman> djazayeri, i haven't seen what the db tables are going to be |
| 15:31:53 | <bwolfe> db tables are super simple |
| 15:32:02 | <bwolfe> the power is in the template |
| 15:32:05 | <rfriedman> i think we have one table of templates |
| 15:32:12 | <rfriedman> and one table of structures |
| 15:32:20 | <suranga> bwolfe, agree |
| 15:32:40 | *** kavuri has joined #openmrs |
| 15:32:42 | <suranga> bwolfe, typing with one finder , @dinner |
| 15:33:13 | <bwolfe> rfriedman, define "structures" |
| 15:33:57 | <suranga> i think he means structures == segments (similar to what I specified earlier...) |
| 15:34:10 | <rfriedman> structures is a hierarchical decomposition of the message with the corresponding template at those levels which have templates |
| 15:34:12 | <djazayeri> I actually think he means structes == messages |
| 15:34:49 | <djazayeri> rfriedman: the first release will not have those. the message structure is "just another template" |
| 15:35:18 | <rfriedman> so that would be a single entry in the structure table with a single template name |
| 15:35:46 | <djazayeri> rfriedman: a single entry in the templates table. there's only one table, for templates. |
| 15:35:47 | <rfriedman> the name of the structure will be ORUR01 and the level will be message and the template will do all the work |
| 15:36:16 | <djazayeri> rfriedman: a future version should add something like what you mentioned, e.g. a better DSL for defining the structures, but I imagine this will also be stored in the template table too, just with a different "language" or "type" column value. (i.e. not "groovy") |
| 15:36:20 | <djazayeri> I have to run for a bit |
| 15:36:42 | <rfriedman> the only validation would be at the message level |
| 15:39:24 | <rfriedman> suranga, could you answer one question, when you look at the MVP message guide, is it actually an ORUR01 message or is it a message like you described in the correspondence? |
| 15:40:05 | *** mccallumg has joined #openmrs |
| 15:40:05 | *** ChanServ sets mode: +v mccallumg |
| 15:40:17 | <rfriedman> bwolfe, suranga, MVP is the client, right? |
| 15:41:31 | <bwolfe> this use-case is rwanda moh and jembi more-so than MVP |
| 15:42:04 | <rfriedman> darius said mvp, that's why i used mvp at 11:39, but i thought it was rwanda |
| 15:42:27 | *** kavuri has quit IRC |
| 15:44:11 | *** applecool has quit IRC |
| 15:45:23 | *** rfriedman has quit IRC |
| 15:46:52 | <bwolfe> djazayeri, doesn't know what he is talking about half the time |
| 15:46:54 | <bwolfe> ;-) |
| 15:47:06 | <bwolfe> ok, maybe its only 5% of the time he doesn't know... |
| 15:49:32 | *** suranga has quit IRC |
| 15:50:07 | *** mccallumg has quit IRC |
| 15:50:22 | *** applecool has joined #openmrs |
| 15:50:22 | *** ChanServ sets mode: +v applecool |
| 15:55:32 | *** lh has quit IRC |
| 15:57:04 | *** kishoreyekkanti_ has quit IRC |
| 16:15:33 | *** ChanServ sets mode: +v maurya |
| 16:21:38 | *** applecool has quit IRC |
| 16:27:22 | *** applecool has joined #openmrs |
| 16:27:22 | *** ChanServ sets mode: +v applecool |
| 16:35:04 | *** lh has joined #openmrs |
| 16:35:04 | *** lh has joined #openmrs |
| 16:47:23 | *** rafa has quit IRC |
| 16:49:16 | *** lakkarau has joined #openmrs |
| 16:53:53 | <lakkarau> bwolfe:sorry ,i missed the Scrum meeting |
| 16:54:02 | *** wyclif has quit IRC |
| 16:54:21 | *** wyclif has joined #openmrs |
| 16:54:22 | *** suranga has joined #openmrs |
| 16:54:22 | *** ChanServ sets mode: +v suranga |
| 16:54:57 | <suranga> bwolfe, hi, im back ! now to read your entire conversation again ! |
| 16:57:20 | *** kreddy has joined #openmrs |
| 17:05:20 | <pushkar> bwolfe, I have updated the documentation at https://wiki.openmrs.org/display/docs/DRAWING+MODULE |
| 17:05:29 | *** rfriedman has joined #openmrs |
| 17:05:46 | <rfriedman> dkayiwa, you there? |
| 17:05:48 | <pushkar> bwolfe, please have a look at it and let me know if I have to make any other changes |
| 17:09:59 | <rfriedman> wyclif, you there? |
| 17:13:45 | <dkayiwa> rfriedman: yes iam |
| 17:15:25 | <rfriedman> dkayiwa, hi, can you tell me how to look at the liquibase change sets moving from 1.8 to 1.9? |
| 17:16:04 | *** kishoreyekkanti has joined #openmrs |
| 17:16:12 | <rfriedman> dkayiwa, i have both 1.8 and 1.9 liquibase-update-to-latest open |
| 17:16:44 | <rfriedman> i thought they were cumulative, so I would find the last of 1.8 in 1.9 and the rest would be what I'm after |
| 17:16:44 | <dkayiwa> rfriedman: are you simply look for the database changes between 1.8 and 1.9? |
| 17:17:17 | <rfriedman> dkayiwa, not just that, how the old source table was mapped to the new concept mapping paradigm |
| 17:18:04 | <dkayiwa> rfriedman: do you mean at what openmrs version that was done? |
| 17:18:15 | *** jriley has quit IRC |
| 17:18:17 | <rfriedman> no, i know that was done moving from 1.8 to 1.9 |
| 17:19:33 | <rfriedman> dkayiwa, first am i right that the update-to-latest files are cumulative? |
| 17:20:05 | <dkayiwa> rfriedman: what exactly do you mean by cumulative in this respect? :) |
| 17:20:10 | *** kavuri has joined #openmrs |
| 17:20:29 | <rfriedman> that the 1.9 file contains all the changes from the 1.8 file which contains all the changes from the 1.7 file etc. |
| 17:20:50 | <dkayiwa> rfriedman: yes it has all |
| 17:21:15 | <rfriedman> so as far as I can tell, the first new changeset in the 1.9 file is "10-insert-new-app-privileges" by you |
| 17:22:03 | <dkayiwa> rfriedman: they are not necessarily in order |
| 17:22:05 | <wyclif> , it would be good if we could add comments to show the start of changesets for a major version and when are we dumping that file clearing it, it's getting too long |
| 17:22:36 | <wyclif> djazayeri, rfriedman, bwolfe, dkayiwa , it would be good if we could add comments to show the start of changesets for a major version and when are we dumping that file clearing it, it's getting too long |
| 17:23:16 | <dkayiwa> wyclif: actually i would prefer the liquibase recommended way for changeset files between software release versions :) |
| 17:23:34 | <rfriedman> i think liquibase supports something like "include", we could separate the changes out int oseparate files |
| 17:23:49 | <dkayiwa> rfriedman: yes |
| 17:23:50 | <wyclif> djazayeri, thatis even better if possible |
| 17:25:35 | <dkayiwa> wyclif: bwolfe rfriedman djazayeri am referring to this: http://www.liquibase.org/bestpractices |
| 17:25:39 | <wyclif> All we need is to create the ticket for this to be done |
| 17:27:07 | <djazayeri> I agree that it would make sense to have a new file for each release. |
| 17:28:23 | *** mvorobey has joined #openmrs |
| 17:29:00 | <rfriedman> dkayiwa, could you create the ticket? |
| 17:29:01 | <mvorobey> hi all |
| 17:29:07 | <djazayeri> hi |
| 17:29:25 | <rfriedman> hi mvorobey , what have you done for us lately? :) |
| 17:29:55 | <dkayiwa> rfriedman: i thought you were volunteering to do it :) |
| 17:30:02 | <mvorobey> rfriedman, heh :) introduced my OpenMRS demo site ! |
| 17:30:41 | <mvorobey> rfriedman, an what's up ? |
| 17:30:45 | <mvorobey> an = and |
| 17:31:22 | <mvorobey> rfriedman, but it's a secret, only few people know about it :D |
| 17:31:37 | <rfriedman> dkayiwa, maybe i'll do the ticket, but you have to write it, curate it, get it thru design, get it marked ready to work |
| 17:31:48 | <rfriedman> or maybe i'll have mvorobey do it |
| 17:32:03 | <dkayiwa> rfriedman: i will curate :) |
| 17:32:24 | <mvorobey> rfriedman, am going to publicity announce it when Custom Messages v1.3 will be ready to go! :) |
| 17:32:43 | <rfriedman> mvorobey, burke says the move to git will let there be thousands of openmrses, we'll have to fight to be the definitive one -- it could be you |
| 17:32:51 | <rfriedman> think of the glory and fame that will be yours |
| 17:34:17 | <rfriedman> all you have to do is handle this very creative ticket we'll be writing about liquibase |
| 17:34:57 | <wyclif> hi dkayiwa |
| 17:35:07 | <dkayiwa> hi wyclif |
| 17:35:13 | <mvorobey> rfriedman, oh, I would not mind about glory but I'd rather give free way fo others, I am myself moved couple of modules to GitHub and I think that am done with this :) |
| 17:35:28 | <mvorobey> rfriedman, what's the ticket about liquibase ? |
| 17:35:42 | <mvorobey> fo = for |
| 17:36:29 | <wyclif> dkayiwa, i think provider in xfrms are handled wrongly when editing an encounter, it assumes that is a person id and calls setProvider which takes in a person object yet it is a provider id |
| 17:36:57 | <rfriedman> you just have to take the liquibase file containing all the changes since 1.4 and break it up into 6 separate files containing one version change each |
| 17:37:08 | <dkayiwa> wyclif: oh i see!!! |
| 17:37:26 | <wyclif> dkayiwa, try editing one, you will get an error, am not sure this happens when creating a new encounter |
| 17:37:37 | <dkayiwa> wyclif: ok |
| 17:38:12 | *** kishoreyekkanti has quit IRC |
| 17:39:42 | *** nwilkie has quit IRC |
| 17:40:35 | *** applecool has quit IRC |
| 17:40:46 | <mvorobey> rfriedman, very tough business to break into :) am with OpenMRS only starting from 1.9 so it would be definitely sorrowful for me to distinguish between changesets for older versions of OpenMRS .. and why from 1.4 ?? 1.6 is even in EOL ? |
| 17:42:36 | <rfriedman> mvorobey, changesets are cumulative |
| 17:42:36 | <mvorobey> even in EOL = even at EOL |
| 17:42:52 | <rfriedman> every since we went from ant to liquibase |
| 17:43:40 | <rfriedman> probably not so hard, just run diffs from the latest back |
| 17:43:47 | <rfriedman> incredibly tedious |
| 17:43:55 | <rfriedman> that's why i volunteered you :) |
| 17:43:59 | <mvorobey> rfriedman, from what I see the best way just to take final changeset and compare with last changesets for each version, |
| 17:44:24 | <rfriedman> spanner in the works is that order may have changed between versions |
| 17:44:31 | <rfriedman> don't ask me why or how |
| 17:44:47 | <mvorobey> rfriedman, :) |
| 17:45:09 | <mvorobey> rfriedman, definitely won't do it |
| 17:45:33 | <rfriedman> mvorobey, you have to recruit a newbie to do it for you :) |
| 17:45:45 | <mvorobey> rfriedman, BTW, do we already have a ticket for this ? |
| 17:46:09 | <rfriedman> mvorobey, left off writing it to banter with you |
| 17:46:29 | <rfriedman> oh wait, i got all the way thru, TRUNK-3638 |
| 17:46:36 | <rfriedman> !ticket TRUNK-3638 |
| 17:46:37 | <OpenMRSBot> rfriedman: [#TRUNK-3638] Separate liquibase file into separate files per version - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3638 |
| 17:47:34 | <mvorobey> rfriedman, Complexity : Low -- LOL :) |
| 17:48:14 | <rfriedman> mvorobey, u think we need "lower than low" |
| 17:48:31 | <rfriedman> or just another dimension for tediousness? |
| 17:49:40 | <rfriedman> mvorobey, maybe we can say it can be done with groovy and burke would do it |
| 17:50:04 | <mvorobey> rfriedman, lowest of love :) |
| 17:51:19 | <rfriedman> mvorobey, are you familiar with the term "go low" |
| 17:52:50 | <mvorobey> rfriedman, yes, and ? |
| 17:53:16 | <rfriedman> so maybe that's the category |
| 17:54:02 | <mvorobey> rfriedman, ah, because I thought about some other meaning :) and became a bit worried ... |
| 17:54:34 | <rfriedman> ah, it's the some other meaning to which i refer |
| 17:54:52 | *** downey has quit IRC |
| 17:56:49 | <mvorobey> rfriedman, it is not necessary to reveal this meaning for others, I got it |
| 17:57:20 | <mvorobey> rfriedman, meanwhile, I do believe that burke would be happy to take that and shred it using Groovy :) |
| 17:57:53 | <djazayeri> tsk tsk, this is a high-class channel we run here people |
| 17:58:02 | <rfriedman> mvorobey, good, we will keep it a secret like your demo site |
| 18:00:13 | <rfriedman> djazayeri, yeah, you doing the treibol yet? |
| 18:01:55 | <djazayeri> rfriedman: you're apparently more up on reggaeton bands than me |
| 18:02:48 | <rfriedman> rfriedman, it's all about sacudir la culita con mano arriba |
| 18:03:24 | <djazayeri> um, _class_ chat room :-) |
| 18:03:44 | *** wyclif has quit IRC |
| 18:04:52 | *** rfriedman has quit IRC |
| 18:11:30 | *** bwolfe has quit IRC |
| 18:12:32 | <kreddy> rafa, u there |
| 18:12:51 | <dkayiwa> unless he has a different nick :) |
| 18:21:40 | *** wyclif has joined #openmrs |
| 18:26:52 | *** bwolfe has joined #openmrs |
| 18:26:52 | *** ChanServ sets mode: +o bwolfe |
| 18:29:55 | *** kavuri has quit IRC |
| 18:33:57 | *** dkayiwa has quit IRC |
| 18:35:29 | *** dkayiwa has joined #openmrs |
| 18:44:11 | <suranga> bwolfe, djazayeri jembi really wanted ORUR01 export, but due to time constraints, we went ahead at top speed and implemented it :-\ |
| 18:44:54 | <suranga> bwolfe, djazayeri so to clarify, we might not be too worried about the ORUR01 export until we get a similar use case again :-( |
| 18:45:24 | <bwolfe> because you will continue to use your module? |
| 18:53:19 | *** zen has joined #openmrs |
| 18:53:43 | *** zen is now known as Guest76711 |
| 18:54:26 | *** Guest76711 is now known as zen1234 |
| 18:57:50 | <zen1234> Hi, I was wondering if someone could help me set up OpenMRS (as a developer). I am having trouble during the initialization. |
| 19:02:24 | <bwolfe> zen1234, sure, most of us can help. :-) can you explain your problem? or what you're seeing + what you have tried? |
| 19:02:40 | <zen1234> It fails at the "2-role-assign-new-api-privileges-to-renamed-ones" changeset in "liquibase-update-to-latest.xml" |
| 19:03:04 | <bwolfe> zen1234, are you runnign trunk? |
| 19:03:15 | *** maurya has quit IRC |
| 19:03:17 | <bwolfe> and which option did you choose when installing? demo data? |
| 19:03:19 | <zen1234> yes, I just downloaded it yesterday |
| 19:03:47 | <zen1234> I clicked no on demo data. |
| 19:04:04 | <bwolfe> interesting. if you choose yes on demo data, does it work? |
| 19:04:18 | <bwolfe> and what is the sql error ? you can see it in your console where you are running jetty:run |
| 19:04:23 | <zen1234> 1 problem is see in the database created so far. In the privileges table, some of the privileges have too many spaces in between |
| 19:05:24 | <zen1234> I mean the privilege name. Ex. "Get Identifiers Type". There are a lot of spaces after the Get |
| 19:06:33 | <zen1234> I think choosing yes on demo data gave me another error. Let me retry it that way. |
| 19:08:14 | *** shortend has joined #openmrs |
| 19:09:32 | <zen1234> Has anyone ever experienced somethign like that? Having a bunch of extra spaces in a name? |
| 19:10:13 | *** robbyoconnor has quit IRC |
| 19:10:35 | <bwolfe> zen1234, are you trying a new db each time? |
| 19:11:12 | <zen1234> bwolfe, yes. I delete the database my mysql. And I also delete the OpenMRS folder from AppData/Roaming |
| 19:11:20 | <bwolfe> cool |
| 19:12:16 | <bwolfe> zen1234, what is the actual sql error you see? |
| 19:13:58 | <pushkar> bwolfe, what about release ? |
| 19:14:06 | <pushkar> are we going to do it now ? |
| 19:14:09 | <bwolfe> are you ready for it? |
| 19:14:13 | <bwolfe> let me look at docs again |
| 19:14:15 | <zen1234> bwolfe, just tried with demo data. Similar error on a different change set. I am getting a liquibase.exception.DatabaseException |
| 19:14:40 | <bwolfe> https://wiki.openmrs.org/display/docs/Drawing+Module is the final? |
| 19:14:52 | <bwolfe> zen1234, look in the console to see the sql exception |
| 19:14:55 | <bwolfe> (if its not shown) |
| 19:15:20 | <bwolfe> pushkar, your link to download is missing |
| 19:15:45 | <pushkar> Yes thats becouse I didnt upload it in module repositary |
| 19:15:52 | <bwolfe> and the screenshot is too large. and make the screenshot do something. add a pic and some annotations to it (arrow? text?) |
| 19:16:25 | <pushkar> okay |
| 19:16:54 | <zen1234> bwolfe, this is the exception I'm getting: com.mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException: Cannot add or update a child row: a foreign key constraint fails (`openmrs`.`role_privilege`, CONSTRAINT `privilege_definitons` FOREIGN KEY (`privilege`) REFERENCES `privilege` (`privilege`)) |
| 19:17:20 | <bwolfe> zen1234, hmm, probably because of those weird spaces |
| 19:18:38 | <zen1234> bwolfe, That's what I thought. Any idea what is causing those or how to fix it? I am working on Eclipse Juno. |
| 19:19:07 | <bwolfe> zen1234, you compiled and ran via mvn jetty:run ? |
| 19:19:45 | <zen1234> bwolfe, yes. |
| 19:20:22 | <bwolfe> zen1234, use control-shift-r to find the liquibase-update-to-latest file and the changeset you listed above "2-..." |
| 19:23:27 | <zen1234> bwolfe, Okay. I found it. |
| 19:23:39 | <bwolfe> zen1234, does it look funny? |
| 19:23:42 | <bwolfe> any extra spaces? |
| 19:24:05 | <bwolfe> (or copy/paste those and see if its a funny whitespace char) |
| 19:25:00 | <zen1234> bwolfe, I dont see any extra spaces, but I do see odd line breaks. |
| 19:25:14 | <bwolfe> zen1234, and liquibase-core-data.xml. Look for privileges with "View " . (this was changed to "Get " in recent changeset) |
| 19:25:26 | <bwolfe> zen1234, line breaks within the xml? |
| 19:25:37 | <zen1234> rp.privilege = 'View Patient |
| 19:25:44 | <zen1234> Identifiers' |
| 19:26:02 | <zen1234> Yes, that is in the xml file. |
| 19:26:36 | <bwolfe> that could be the problem. |
| 19:26:46 | <bwolfe> which file and line number is that? |
| 19:28:19 | <bwolfe> zen1234, might have been an accidental file formatting by someone. ^^ |
| 19:28:38 | <zen1234> bwolfe, file: liquibase-update-to-latest.xml line: 9236 |
| 19:29:20 | <bwolfe> 9286? perhaps its only formatted on your machine. because I only go up to 7356 in my machine |
| 19:29:32 | <bwolfe> zen1234, did eclipse do an autoformat on you? |
| 19:29:43 | <bwolfe> you can do an svn revert on that file |
| 19:29:50 | <bwolfe> then rebuild and rerun openmrs |
| 19:29:57 | *** shortend has quit IRC |
| 19:30:07 | <zen1234> bwolfe, that's off. I dont think eclipse did an auto format. |
| 19:31:29 | <zen1234> bwolfe, maybe it'd be best if I just redownload the whole repository and start from scratch |
| 19:31:33 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @akollegger: anyone @UCSF doing work with #OpenMRS? I'm interested in organizing a hackathon in the bay area <http://twitter.com/OpenMRS/statuses/228206236531847168> |
| 19:32:00 | <bwolfe> zen1234, easier to just revert. did you check out through eclipse? |
| 19:33:41 | <zen1234> bwolfe, revert is not changing anything. Yes I downloaded the code base through eclipse |
| 19:34:02 | <bwolfe> zen1234, does it show the little black dot on the icon for the file (saying that it has changes) |
| 19:34:15 | <pushkar> bwolfe, Uploaded the new image can you please have a look |
| 19:34:57 | <bwolfe> pushkar, oooo, very nice |
| 19:35:04 | <bwolfe> gruesome! but looks great! |
| 19:35:24 | <zen1234> bwolfe, yet |
| 19:36:29 | <zen1234> bwolfe, yes*. It does show updates. But even after I do an update, it still shows that icon. |
| 19:36:57 | <bwolfe> zen1234, what if you choose "team-->revert"? |
| 19:37:07 | <bwolfe> or "replace with --> base revision" ? |
| 19:37:34 | <bwolfe> zen1234, do you use a custom eclipse formatter per chance? |
| 19:37:46 | <pushkar> bwolfe, Thanks :-) |
| 19:38:29 | <zen1234> bwolfe, right now I am doing a revert on the whole project. I'll see if that does anything. No I dont have custom eclipse formatter. Just download it as is from the website and added the plugins for OpenMRS. |
| 19:39:31 | <zen1234> bwolfe, Reverting the whole project made a difference. Now that liquibase-update-to-latest.xml file only has 7356 lines. |
| 19:39:46 | <bwolfe> pushkar, some formatting issues on your user docs page |
| 19:41:00 | <bwolfe> zen1234, ok, so clean install of latest eclipse? |
| 19:41:12 | <bwolfe> zen1234, thats what I have too |
| 19:41:26 | <bwolfe> so now do a clean install |
| 19:41:28 | <bwolfe> mvn clean install |
| 19:41:35 | <bwolfe> and then in the webapp dir, do mvn jetty:run again |
| 19:41:50 | <zen1234> bwolfe. OK. I'll do that. 1 min. |
| 19:42:22 | <pushkar> bwolfe, in How To Use Drawing Module ? |
| 19:43:26 | <bwolfe> yeah |
| 19:44:28 | <pushkar> while editing it looks perfect but I dont know why its just leaving tha space |
| 19:49:07 | <bwolfe> pushkar, use the "wiki markup" view to edit |
| 19:49:19 | <pushkar> okay |
| 19:49:33 | <bwolfe> I see lots of 's ! |
| 19:52:00 | *** downey has joined #openmrs |
| 19:52:00 | *** ChanServ sets mode: +o downey |
| 19:52:00 | *** OpenMRSBot sets mode: +o downey |
| 19:54:20 | <pushkar> bwolfe, done ! |
| 19:57:07 | <zen1234> bwolfe, Has there been any security updates in OpenMRS? Like a patient can view her own patient record, but not the records of other patients? |
| 19:58:01 | *** lh has quit IRC |
| 19:58:47 | *** lh has joined #openmrs |
| 19:58:47 | *** lh has joined #openmrs |
| 19:59:17 | *** wyclif has quit IRC |
| 20:00:29 | <suranga> hi downey |
| 20:00:29 | <suranga> downey, mmm... I was creating tickets on hl7query, but all of a sudden im getting an error when trying to save them.. |
| 20:01:32 | <downey> suranga: your last update was 29 min ago |
| 20:04:50 | *** rafa has joined #openmrs |
| 20:04:50 | *** ChanServ sets mode: +v rafa |
| 20:05:01 | *** jordank has quit IRC |
| 20:05:22 | <zen1234> bwolfe, it worked. Thank you for all your help. |
| 20:07:08 | <pushkar> bwolfe, I uploaded the module too |
| 20:07:54 | *** bwolfe has quit IRC |
| 20:10:33 | *** wyclif has joined #openmrs |
| 20:13:03 | *** pushkar has quit IRC |
| 20:14:42 | <djazayeri> downey: every time I click something on JIRA it gives me an error |
| 20:15:24 | <downey> suranga / djazayeri - detail of said error would be helpful :) |
| 20:15:43 | <djazayeri> downey: in this case it has been voting, and it gives me an error message, but when I reload the page I see that the vote actually went through |
| 20:15:57 | <downey> just "error"? |
| 20:16:12 | <djazayeri> downey: javascript popup with "The JIRA server was contacted but has returned an error response. We are unsure of the result of this operation." |
| 20:16:20 | <downey> atlassian-- |
| 20:17:40 | <djazayeri> downey: via chrome dev tools, the ajax response is {"status-code":500,"message":"com/atlassian/jira/issue/customfields/persistence/PersistenceFieldType"} |
| 20:18:04 | <downey> interesting. and nothing in server logs |
| 20:18:25 | <downey> stand by |
| 20:18:29 | <djazayeri> downey: I got the same thing trying to link a ticket during the design call, then tried again and it worked |
| 20:27:34 | <downey> djazayeri suranga - error should be resolved |
| 20:31:50 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Drawing Module 1.0-SNAPSHOT uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=drawing&version=&1.0-SNAPSHOT> |
| 20:32:24 | <djazayeri> Why is there a SNAPSHOT version in the module repository? |
| 20:32:47 | <djazayeri> downey, bwolfe: ^^ |
| 20:36:58 | <downey> that's a better question for pushkar, i guess :) |
| 20:46:17 | *** rafa has quit IRC |
| 20:47:59 | <zen1234> exit |
| 20:48:09 | *** zen1234 has quit IRC |
| 21:00:33 | *** mvorobey has quit IRC |
| 21:05:40 | *** dkayiwa has quit IRC |
| 21:15:35 | *** wyclif has quit IRC |
| 21:31:13 | *** lh has quit IRC |
| 21:40:23 | *** lh has joined #openmrs |
| 22:07:11 | *** suranga has quit IRC |
| 22:29:09 | *** lh has quit IRC |
| 22:29:47 | *** lh has joined #openmrs |
| 22:29:47 | *** lh has joined #openmrs |
| 22:33:09 | *** lh has quit IRC |
| 22:50:28 | *** wyclif has joined #openmrs |
| 22:50:50 | *** lh has joined #openmrs |
| 22:55:09 | *** lh has quit IRC |
| 22:55:35 | *** lh has joined #openmrs |
| 22:55:35 | *** lh has joined #openmrs |
| 23:01:53 | *** lh has quit IRC |
| 23:19:03 | *** lakkarau has quit IRC |
| 23:24:07 | *** downey has quit IRC |
| 23:34:32 | *** kreddy has quit IRC |