IRC Chat : 2012-07-24 - OpenMRS

00:41:29 *** djazayeri has quit IRC
00:52:43 *** harshadura has joined #openmrs
00:53:44 *** harshadura has joined #openmrs
00:57:23 *** jordank has quit IRC
01:42:38 <harshadura> hi bwolfe
01:51:52 <bwolfe> hi
01:51:56 <bwolfe> hi harshadura
01:53:06 *** suranga has joined #openmrs
01:53:06 *** ChanServ sets mode: +v suranga
01:53:16 <suranga> hi bwolfe
01:53:52 <suranga> bwolfe, good evening, i was trying to move my tickets from oTHER into my new jira project... it looks like I cant do that ?
01:54:17 <harshadura> bwolfe, I need to access the Feeback table by the userID of another Table (in that table feedbackID is a foreign key), how can I access that Row using hibernate DAO ?
01:54:48 <harshadura> can i do this using criteria class
02:01:45 <bwolfe> userId of another table? what do you mean?
02:02:04 <bwolfe> harshadura, explain your situation in sql or in longer words. :-)
02:02:14 <bwolfe> suranga, ok, one sec
02:03:18 <harshadura> bwolfe : pls chk this image for ref: http://imagebin.org/221742
02:03:52 <harshadura> I need to list down all the feedbacks assigned to a user in a separate jsp view.
02:04:57 <harshadura> so for doing that i am taking the current authenticated userID and passing it to hibernateDAO, in thr I need to check the userAccess Table and get all the Feedback ID assigned to
02:06:32 <harshadura> Criteria criteria = sessionFactory.getCurrentSession().createCriteria(FeedbackUser.class);
02:06:32 <harshadura> criteria.add(Restrictions.eq("userId", assignedUser.getUserId()));
02:06:35 <harshadura> bwolfe, how to fetch those values using criteria class in hibernate ?
02:07:18 *** bwolfe has quit IRC
02:07:42 *** bwolfe has joined #openmrs
02:07:42 *** ChanServ sets mode: +o bwolfe
02:10:11 <bwolfe> so the sql query would be: select * from RIGHT, LEFT where right.fid = left.fid and left.uid = X;
02:10:23 <bwolfe> the better question is, why is uid not in the righthand table?
02:10:31 <bwolfe> the criteria would be:
02:11:05 <bwolfe> harshadura, what are your objects?
02:11:21 <bwolfe> can you link me to the liquibase file and to the java classes in svn.openmrs.org ?
02:11:25 <bwolfe> (or source.openmrs.org)
02:12:00 <harshadura> ok bwolfe, pls wait
02:14:22 <suranga> hi bwolfe , sorry to disrupt your evening :P is this something I should talk to michael about ?
02:14:58 <bwolfe> suranga, did it not work?
02:18:20 <harshadura> bwolfe, here is my liquibase file > https://source.openmrs.org/browse/Modules/feedback/branches/feedback.besp/omod/src/main/resources/liquibase.xml?hb=true#to175
02:18:28 <suranga> bwolfe, afraid not, i still seem to be getting the same options
02:18:38 <harshadura> feedback_userAccess is the Table
02:19:53 <harshadura> hbm xml file for FeedbackUser > https://source.openmrs.org/browse/Modules/feedback/branches/feedback.besp/omod/src/main/resources/FeedbackUser.hbm.xml?r=28645
02:20:04 <bwolfe> suranga, how about now?
02:22:31 *** jordank has joined #openmrs
02:23:59 <harshadura> bwolfe, this is the place currently im struggling to fetch Assigned FeedbackList for a particular user> https://source.openmrs.org/browse/Modules/feedback/branches/feedback.besp/api/src/main/java/org/openmrs/module/feedback/db/hibernate/HibernateFeedbackDAO.java?r=28645#to158
02:26:13 <bwolfe> harshadura, where is the other object? you link to FeedbackUser, what is the object for the other table?
02:31:16 <harshadura> bwolfe
02:31:17 <harshadura> <set name="feedbackId" cascade="save-update,delete-orphan" >
02:31:18 <harshadura> <key>
02:31:18 <harshadura> <column name="feedback_id"> </column>
02:31:18 <harshadura> </key>
02:31:18 <harshadura> <one-to-many class="org.openmrs.module.feedback.Feedback" />
02:31:19 <harshadura> </set>
02:31:28 <harshadura> its "feedbackId""
02:47:09 <bwolfe> harshadura, why is this a separate table?? why not put user_id on the feedback table?
02:47:37 <bwolfe> or is it not 1 to 1 ?
02:47:43 <bwolfe> whats the point of this table?
02:47:45 <harshadura> bwolfe, Gaurav told me to do like this
02:48:25 <bwolfe> you make it harder on yourself when you don't use objects
02:48:44 <bwolfe> so the FeedbackUser class should have properties of: Integer id, Feedback feedback, User user
02:48:46 <harshadura> bwolfe, pls can u tell me whats i hv done wrong
02:49:28 <harshadura> ok you want me to create Integer id, Feedback feedback, User user, rather userId, fid ?
02:54:54 <bwolfe> harshadura, it would be 10x better. but you'd have to change your mappings and criteria calls too
02:55:39 <bwolfe> so it looks like its many to one. thats why the extra table..
02:55:58 <bwolfe> if you had a feedback object, this would be your sql:
02:56:01 <bwolfe> (raw sql)
02:56:14 <bwolfe> select feedback from feedback_user where user_id = X;
02:56:25 <bwolfe> and hibernate would magically get that feedback object
02:56:28 <bwolfe> in criteria it is:
02:57:40 <bwolfe> return (List<Feedback>) currentSession.createCriteria(FeedbackUser.class).setProjections(Projections.property("feedback")).add(Restricitions.eq("user", userObject)).list();
03:00:40 *** djazayeri has joined #openmrs
03:00:40 *** ChanServ sets mode: +o djazayeri
03:03:46 <harshadura> ok thanks lot bwolfe, I will do like that
03:23:22 *** jordank_ has joined #openmrs
03:25:01 *** jordank_ has quit IRC
03:30:09 <harshadura> bwolfe, u thr
03:30:45 <bwolfe> yup
03:32:01 <harshadura> bwolfe, pls can u chk the modified FeedbackUser class > http://pastebin.com/uM4eyspm
03:32:37 <bwolfe> change property names to just "feedback" and "user"
03:32:44 <harshadura> ok
03:32:55 <bwolfe> (and all getter/setters)
03:33:13 <harshadura> bwole, I dont need to change the liquibase ryt ?
03:34:01 <harshadura> cz I need to save in the db is id, fid, and userid nah
03:37:46 *** jordank has quit IRC
03:40:13 <bwolfe> harshadura, right. only change the object and the mapping
03:49:34 <harshadura> bwolfe, pls can u chk my hbm file >
03:49:53 <harshadura> http://pastebin.com/5YR3M0FJ
03:53:30 *** bwolfe has quit IRC
04:44:41 *** harshadura has quit IRC
05:04:18 *** jordank has joined #openmrs
05:50:15 *** shortend has joined #openmrs
05:50:15 *** suranga has quit IRC
06:02:29 *** SKP has joined #openmrs
06:04:14 <SKP> Can anybody let me know the licensing model of the OpenMRS system.
06:06:08 <SKP> Here at India we are taking an initiative in implementig a system to record PAN India data on cancer
06:06:20 <SKP> so just wanted to find out the licensing model
06:33:30 *** shortend has quit IRC
06:38:29 *** goutham has joined #openmrs
06:39:47 *** dkayiwa has joined #openmrs
06:43:49 *** snoppy has joined #openmrs
06:46:11 *** harshadura has joined #openmrs
07:00:23 *** harshadura has quit IRC
07:01:57 *** jordank has quit IRC
07:02:20 *** shortend has joined #openmrs
07:02:30 *** SKP has quit IRC
07:15:09 <goutham> Hi dkayiwa
07:15:16 <dkayiwa> hi goutham
07:15:19 <goutham> dkayiwa, good morning
07:15:36 <dkayiwa> goutham: good morning
07:19:53 <goutham> dkayiwa, any suggestions or comments ?
07:19:53 *** shortend has quit IRC
07:20:05 <dkayiwa> goutham: under form filter page, can we make the form name outstanding?
07:20:14 <dkayiwa> addformproperty.form
07:21:27 *** harshadura has joined #openmrs
07:22:19 <goutham> dkayiwa , Outstanding means bold ?
07:22:27 <dkayiwa> goutham: yes something like that
07:22:48 <dkayiwa> goutham: do we also want to prompt user before deleting filter? or do you think it may not be necessary?
07:26:07 *** harshadura has quit IRC
07:26:39 <dkayiwa> goutham: can you create a filter that has Gender = Male, Minimum Age = 10 and Maximum Age = 20 and tell me if it works for you?
07:27:15 <goutham> dkayiwa, a confirmation message would be good...will add it.
07:30:31 <goutham> dkayiwa, my development environment is not ready...but i tested it before presentation...it worked good
07:30:47 <dkayiwa> goutham: i mean testing it now
07:31:26 <dkayiwa> goutham: that is a form having two filters mentioned above
07:32:09 <goutham> dkayiwa, ok...will test it on my system and let you know
07:32:43 <dkayiwa> goutham: ok
07:32:55 <goutham> dkayiwa, any other changes?
07:33:09 *** shortend has joined #openmrs
07:33:23 <dkayiwa> goutham: javadoc missing in some classes like FormFilterProperty, FormFilter, etc
07:34:38 <dkayiwa> goutham: also when i go under manage form filtering and search for a form, none gets listed
07:35:30 <dkayiwa> goutham: i think i will proceed when you have your openmrs running. because most of my feedback require it to have running and you tell me what happens on your side
07:35:38 <dkayiwa> goutham: just tell me whenever you are ready
07:36:01 <goutham> Dkayiwa,ok
07:36:27 *** goutham has left #openmrs
07:57:23 *** rafa has joined #openmrs
07:57:23 *** ChanServ sets mode: +v rafa
08:40:32 *** magoo_ has joined #openmrs
08:51:20 <magoo_> dkayiwa is it possible for the patient identifier to be in this format MA001-2407-2012
08:52:21 <dkayiwa> magoo_: yes
08:52:49 <magoo_> okay
08:56:58 <magoo_> dkayiwa do i need to choose the option update database when carrying out the first installation of openmrs
08:59:41 <magoo_> ??
08:59:51 <dkayiwa> magoo_: no
09:49:06 *** applecool has joined #openmrs
09:49:06 *** ChanServ sets mode: +v applecool
09:52:32 <applecool> hi rafa :)
09:52:39 <rafa> applecool: hi
09:53:08 *** harshadura has joined #openmrs
09:56:13 <applecool> rafa: the getter of the modules should be transient right?
09:56:29 <applecool> or should persist the db?
09:56:59 <rafa> applecool: persist in the db
09:58:04 <applecool> okay
10:02:14 <rafa> applecool: you won't be able to persist Map<String, String>
10:02:28 <applecool> yes! i got errors!
10:02:34 <applecool> i tried it yesterday
10:03:17 <rafa> applecool: you need to make it List<Module>
10:03:20 <applecool> so i tried making it transient and kept it aside! and working on UI
10:03:32 <applecool> oh okay!
10:04:15 <applecool> List<String, String> module?
10:04:32 <rafa> applecool: class Module will have an id of type Long, a module of type String, and a version of type String
10:04:55 <rafa> applecool: List<String, String> what is that? :P
10:05:40 <applecool> regarding the variable! :D
10:05:51 <rafa> applecool: ?
10:06:24 <applecool> nothing ! ignore it :)
10:06:57 <rafa> applecool: the key in map is module and the value is version
10:07:21 <rafa> applecool: actually you can get rid of id from class Module
10:07:34 <rafa> applecool: and make a composite id of module and version fields
10:10:07 <applecool> didnt get it properly rafa :(
10:10:14 <rafa> applecool: well I take it back it's not that easy so it's better you have an id in class Module
10:10:35 <rafa> applecool: is it clear with id?
10:11:04 <applecool> module ID?
10:11:11 <rafa> applecool: no
10:11:22 <applecool> id of the package?
10:11:31 <rafa> applecool: no :)
10:11:51 <rafa> applecool: well let's forget about it
10:12:06 <rafa> applecool: it's not that crucial to have modules in the db right now
10:12:29 <rafa> applecool: remove the modules field from MetadataPackage
10:12:35 <applecool> oh
10:13:32 <rafa> applecool: sorry I don't have time to explain it right now
10:14:07 <applecool> okay! i will get back to you on it other time when you are free
10:14:12 <applecool> :)
10:14:23 <rafa> applecool: for now just remove the modules field
10:14:30 <applecool> okay
10:14:47 <rafa> applecool: if we don't persist it, we don't need it at all
10:14:58 <applecool> okay!
10:15:10 <rafa> applecool: work on the UI
10:15:38 <applecool> okay! its almost done! will commit it soon
10:18:42 <applecool> rafa: as shown in the image uploaded in the METAREPO-1 you want to remove the tag line of OpenMRS!
10:18:46 <applecool> should i remove it
10:18:47 <applecool> ?
10:19:03 <rafa> applecool: the tag line?
10:19:06 <harshadura> dkayiwa, can i get a min ?
10:19:18 <applecool> Open Source Health IT for the planet
10:19:23 <rafa> applecool: yes, remove it
10:19:26 <applecool> okay
10:19:44 <applecool> even the welcome!
10:21:11 <applecool> ? rafa
10:21:34 <rafa> applecool: yes, all like in the image
10:21:43 <applecool> okay! :) Thanks!
10:21:48 <applecool> carry on rafa :)
10:29:46 <dkayiwa> harshadura: oh yes :)
10:44:49 <harshadura> dkayiwa, I hv mapped one of classes foriegn key like below, but it gives a null in its value in the table
10:44:55 <harshadura> pls can u help me on this
10:45:12 <harshadura> here is the hbm file > http://pastebin.com/mRQRXLVr
10:45:20 <dkayiwa> harshadura: can i see the error stack trace too
10:45:23 <harshadura> class > http://pastebin.com/eheL2g7M
10:45:30 <applecool> rafa: cya
10:45:35 <applecool> wil be back with the commit
10:45:51 <rafa> cya applecool
10:45:57 <harshadura> log > http://pastebin.com/r1XaNKeb
10:46:00 *** applecool has quit IRC
10:46:09 <harshadura> dkayia, here is the info
10:46:26 <dkayiwa> harshadura: have you got a chance to read about our table column naming conventions?
10:47:09 <dkayiwa> harshadura: am referring to your primary key column name :)
10:48:44 <harshadura> no dkayiwa, sorry
10:50:03 <dkayiwa> harshadura: http://archive.openmrs.org/wiki/OpenMRS_Conventions
10:50:33 <dkayiwa> harshadura: you can also look at other openmrs tables and see how their primary keys are named :)
10:51:00 <harshadura> ok dkayiwa, I will do that, pls can u chk whats wrong on this jz for nw
10:51:14 <dkayiwa> harshadura: ok
10:51:26 <harshadura> thx\
10:51:55 <dkayiwa> harshadura: do you have a unit test reproducing this error?
10:53:49 <dkayiwa> harshadura: can you change to <generator class="native">
10:54:20 <harshadura> ok dkayiwa,
10:54:38 <dkayiwa> harshadura: but would be better also if you also change the column name at the same time :)
10:55:35 *** snoppy has left #openmrs
11:02:50 <harshadura> ok dkayiwa
11:39:51 *** djazayeri has quit IRC
11:54:53 *** jkeiper has joined #openmrs
12:10:19 *** robbyoconnor has quit IRC
12:17:24 *** pushkar has joined #openmrs
12:31:09 *** nwilkie has joined #openmrs
12:33:45 *** maurya has joined #openmrs
12:35:23 *** ChanServ sets mode: +v maurya
12:35:35 *** djazayeri has joined #openmrs
12:35:35 *** ChanServ sets mode: +o djazayeri
12:42:25 *** rubailly has joined #openmrs
12:42:55 *** jkeiper__ has joined #openmrs
12:45:09 *** jkeiper has quit IRC
12:48:03 *** jkeiper__ has quit IRC
13:10:25 *** magoo_ has quit IRC
13:13:59 *** robbyoconnor has joined #openmrs
13:14:03 *** ChanServ sets mode: +v robbyoconnor
13:19:05 *** harshadura has quit IRC
13:19:33 *** Ulrich_ has joined #openmrs
13:21:19 <Ulrich_> Hi Folks, I have a general question concerning the development of module
13:23:17 <Ulrich_> Anyone online?
13:23:44 *** downey|tablet has joined #openmrs
13:23:44 *** ChanServ sets mode: +o downey|tablet
13:23:59 *** downey|tablet has quit IRC
13:35:29 <Ulrich_> Is it possible to intercept a mthod, that was already interpected by another module?
13:37:41 <dkayiwa> Ulrich_: how do you plan to intercept it?
13:38:38 *** shortend has left #openmrs
13:39:08 <Ulrich_> The concrete problem is the following: <advice> <point>org.openmrs.api.FormService</point> <class>org.openmrs.module.inpatientcare.advice.FormServiceAroundAdvice</class> </advice>
13:39:31 <Ulrich_> the FormService is already intercepted by the formentry module.
13:39:34 *** kishoreyekkanti has joined #openmrs
13:39:45 <Ulrich_> so I am unable to start both modules.
13:41:14 <dkayiwa> Ulrich_: what error do you get when trying to start both modules?
13:41:31 <dkayiwa> Ulrich_: can you pastebin the log/stack trace?
13:41:32 <Ulrich_> Unable to refresh the WebApplicationContext null ** org.openmrs.api.context.ServiceContext.addAdvice(ServiceContext.java:539)
13:41:41 *** rfriedman has joined #openmrs
13:41:51 <dkayiwa> Ulrich_: oh am farmiliar with that error
13:41:53 *** robbyoconnor has quit IRC
13:41:58 <dkayiwa> Ulrich_: which version of openmrs are you using
13:42:00 <dkayiwa> ?
13:42:40 <Ulrich_> 1.6.5
13:43:15 <dkayiwa> Ulrich_: yes that i why. i got the same problem with the xforms module also trying to advice a form service that the formentery module already was
13:43:26 <dkayiwa> Ulrich_: can you upgrade your openmrs?
13:43:48 <Ulrich_> yes, exactly. I probably found that on google.
13:44:11 <Ulrich_> no unfortunaltey not at the moment, there are many other things bounded with that version.
13:44:24 <dkayiwa> Ulrich_: oh i see
13:44:38 <dkayiwa> Ulrich_: and you need the formentry module?
13:45:33 <Ulrich_> yes exactly. at least I hope. lets me clarify what I am trying to achieve. I am fairly new in the area, and I guess there might be other solutions.
13:46:05 <dkayiwa> Ulrich_: are using ms infopath to enter your forms?
13:46:55 <Ulrich_> I have to display some forms only to certains users. and I though the easeas way was to intercept the "GetAllForms" and so one and then filterd what should be given out
13:47:23 <Ulrich_> yes infopath and the html form entry
13:47:37 <dkayiwa> Ulrich_: have you tried out the formfilter module?
13:47:50 <dkayiwa> Ulrich_: one that a gsoc student called goutham is doing?
13:48:10 *** suranga has joined #openmrs
13:48:10 *** ChanServ sets mode: +v suranga
13:49:49 *** lakkarau has joined #openmrs
13:51:26 <Ulrich_> No, I havent tried that one. hearing from it for the first time
13:51:47 <Ulrich_> going to install right now
13:51:49 <dkayiwa> Ulrich_: it could already be doing what you need :)
13:52:37 <Ulrich_> it would be more than just perfect.
13:52:48 <dkayiwa> Ulrich_: :D
13:52:54 <Ulrich_> so upgrade my version of openmrs could be another option.
13:53:03 <dkayiwa> Ulrich_: yes
13:53:48 *** lakkarau has quit IRC
13:57:39 <Ulrich_> Ok. thanks a lot. I will try to install. hopefully I can run it on openmrs 1.6.x
13:57:57 <rfriedman> dkayiwa, got a minute?
13:58:14 <dkayiwa> rfriedman: yes
13:58:43 <rfriedman> dkayiwa, could you check the wiki and see if you have an "add gliffy" action?
13:58:58 <dkayiwa> rfriedman: any page?
13:59:15 <rfriedman> any page
13:59:37 <dkayiwa> rfriedman: is it a button?
13:59:47 <rfriedman> it's under add if at all
14:00:01 *** lakkarau has joined #openmrs
14:00:11 <dkayiwa> rfriedman: it is not there on mine
14:00:31 <rfriedman> ok, could you go to the page Human Resource Module Web Services Implementation?
14:00:33 *** cpower has joined #openmrs
14:00:39 <cpower> Heeeelllloooo!
14:00:43 <dkayiwa> rfriedman: url
14:01:06 <rfriedman> wiki.openmrs.org/display/projects/<that separated by +>
14:01:39 <cpower> Let's do that Scrum thing
14:01:44 <rfriedman> 30 secs pls
14:02:32 <dkayiwa> rfriedman: do you have the exact url
14:03:13 <rfriedman> dkayiwa, wiki.openmrs.org/display/projects/Human+Resource+Module+Web+Services+Implementation
14:03:40 <rfriedman> dkayiwa, see if at the bottom you are getting a macro error on a gliffy macro
14:03:53 <dkayiwa> rfriedman: page not found
14:03:59 <dkayiwa> https://wiki.openmrs.org/display/projects/Human+Resource+Module+Web+Services+Implementation
14:04:13 <rfriedman> ok, it's Resources not Resource
14:04:22 <dkayiwa> rfriedman: url
14:04:37 <rfriedman> https://wiki.openmrs.org/display/projects/Human+Resources+Module+Web+Services+Implementation
14:04:50 <dkayiwa> rfriedman: ok am there
14:05:04 <rfriedman> dkayiwa, see at the bottom if you are getting a macro error about gliffy
14:05:07 <dkayiwa> Unknown macro: {gliffy}
14:05:16 <rfriedman> ok, i will ticket it
14:05:20 <rfriedman> tks, cpower
14:05:23 <dkayiwa> rfriedman: ok
14:05:43 <cpower> Ok let's get this thing going!
14:05:49 <cpower> !scrumon cpower
14:05:49 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
14:05:53 <dkayiwa> sure :)]
14:06:35 <cpower> Order: djazayeri, rafa, suranga, dkayiwa, kishoreyekkanti, lakkarau, Wyclif
14:06:45 <rafa> hi everyone!
14:06:55 <lakkarau> rafa:hi
14:07:34 <cpower> Djazayeri..
14:08:41 <cpower> aaaaand skip
14:08:51 <cpower> rafa..hi...go!
14:08:58 <rafa> Today:
14:08:59 <rafa> * Committed TRUNK-3627: ConceptReferenceTermValidator should not check if objects are saved
14:08:59 <rafa> https://tickets.openmrs.org/browse/TRUNK-3627
14:08:59 <rafa> * Back ported & closed TRUNK-3626: UpdateConceptWord throws com.mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException: Column 'concept_name_id' cannot be null
14:08:59 <rafa> https://tickets.openmrs.org/browse/TRUNK-3626
14:08:59 <rafa> * Another commit for META-228: Cannot import a concept containing a mapping in OpenMRS 1.9
14:08:59 <rafa> https://tickets.openmrs.org/browse/META-228
14:09:00 <rafa> * Looked into TRUNK-2767: Concept name searches uses the slower ilike
14:09:00 <rafa> https://tickets.openmrs.org/browse/TRUNK-2767
14:09:01 <rafa> * Now working on TRUNK-3319: Person attribute autofill shows nothing if concept name doesn't exist in users' language
14:09:01 <rafa> https://tickets.openmrs.org/browse/TRUNK-3319
14:09:02 <rafa> No blockers.
14:09:42 <dkayiwa> Did some review for my gsoc student's work
14:09:43 <cpower> next up suranga
14:09:43 <dkayiwa> Curated tickets
14:09:43 <dkayiwa> Still Curating more tickets (Need permissions to make reporting module tickets ready for work)
14:09:43 <dkayiwa> No Blockers
14:09:57 <cpower> ok dkayiwa...
14:10:01 <dkayiwa> :)
14:10:01 <cpower> ;-)
14:10:17 <cpower> Kishore you have something to add?
14:10:54 <cpower> I'll take that as a no
14:11:02 <cpower> Lakkarau, your up
14:11:07 <lakkarau> monday:
14:11:07 <lakkarau> worked on trunk-3491,the application was not able to create the log file..
14:11:07 <lakkarau> worked on trunk-2941.
14:11:07 <lakkarau> tuesday:
14:11:07 <lakkarau> will fix trunk-3491 and attach the patch.
14:11:08 <lakkarau> work on trunk-2941
14:11:09 <lakkarau> Blocker:
14:11:11 <lakkarau> log file is not getting created.
14:11:28 <cpower> make it happen Wyclif
14:11:38 <wyclif> Monday:
14:11:38 <wyclif> Migrated interceptorexample module
14:11:38 <wyclif> Curated tickets
14:11:38 <wyclif> RG town hall meeting
14:11:38 <wyclif> Meeting with Paul and Burke
14:11:39 <wyclif> Updated some wiki pages
14:11:41 <wyclif> Tuesday:
14:11:43 <wyclif> Curate tickets
14:11:45 <wyclif> Wiki documentation update for
14:11:47 <wyclif> Blockers: None
14:12:03 <kishoreyekkanti> was not available momenterily
14:12:05 <kishoreyekkanti> just now saw that the release-test build is failed. I guess thats because of the update of firefox to 12. Need to discuss about this with michael.
14:12:05 <kishoreyekkanti> Failed to convert the entire openmrs code base to git-svn (my mistake, i failed to add the authors) currently running it again and at the revision 16574. Should be done in another hour from now.
14:12:35 <wyclif> cool
14:12:39 <cpower> ok then.
14:13:03 <cpower> Blockers: Lakkarau needs help with the log file not being created, could one of you help?
14:13:34 <wyclif> lakkarau, which log file?
14:13:51 <cpower> Discussion points: Possibly with Kishore and some affirmation that it's related to Firefox.
14:14:06 <rafa> lakkarau: can you attach a patch how you are trying to do it to the ticket?
14:14:21 <lakkarau> wyclif:i have writen code to programatically log into a file .
14:14:53 <lakkarau> rafa:yes ,i will once i reach my office
14:15:10 <cpower> !scrumoff
14:15:10 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
14:15:11 <rafa> lakkarau: great, I'll look into that.
14:15:33 <lakkarau> rafa:ok .
14:16:00 *** lakkarau has quit IRC
14:17:19 <kishoreyekkanti> cpower: I can't see downey here. Any one who could look at our CI box and see if there are any firefox updates done recently
14:17:51 <cpower> no problem, I've got Downey on another IM>
14:21:23 <cpower> He agrees that the updates broke the tests.
14:24:36 <kishoreyekkanti> cpower: ok i guess he would downgrade firefox to 10 or 11
14:24:55 *** snoppy has joined #openmrs
14:25:45 *** dkayiwa has quit IRC
14:25:51 <cpower> Yes, until Firefox stabilizes for a bit, Downey's response was "We will be playing cat and mouse with these quick updates"
14:32:53 *** lh has quit IRC
14:34:01 <kishoreyekkanti> cpower: cool thank you
14:35:06 *** dkayiwa has joined #openmrs
14:36:43 *** cpower has quit IRC
14:38:23 *** emilyp has joined #openmrs
14:39:29 *** emilyp has left #openmrs
14:39:35 *** rubailly has quit IRC
14:46:33 <dkayiwa> hi wyclif
14:48:41 <dkayiwa> hi djazayeri
14:51:17 <pushkar> dkayiwa, Hi
14:51:24 <dkayiwa> pushkar: hi
14:51:44 <pushkar> dkayiwa, where can I find the constants that hold the uuid of concept data types
14:52:15 <dkayiwa> pushkar: i do not think we have it :)
14:52:44 <pushkar> dkayiwa, Thanksss :)
14:53:03 <dkayiwa> pushkar: oh sorry we have it :)
14:53:22 <pushkar> dkayiwa, oh where ??
14:53:57 <dkayiwa> pushkar: hahaha sorry again was looking at the metadatasharing module code which has them in ConceptDatatype.java :)
14:54:11 *** harshadura has joined #openmrs
14:54:37 <dkayiwa> pushkar: now look in openmrs core
14:54:44 <pushkar> dkayiwa, haha :-D
14:54:50 <dkayiwa> pushkar: you will see what you need at org.openmrs.ConceptDatatype
14:55:11 <dkayiwa> pushkar: eg ConceptDatatype.NUMERIC_UUID
14:55:23 <dkayiwa> pushkar: is that what you need?
14:55:36 <pushkar> dkayiwa, yes Thanks:-)
14:55:48 <dkayiwa> pushkar: ok
14:55:58 *** lh has joined #openmrs
14:56:09 *** dkayiwa has quit IRC
14:57:09 *** harshadura has quit IRC
14:57:24 *** harshadura has joined #openmrs
14:58:23 <wyclif> hi dk
15:00:01 *** suranga has quit IRC
15:04:04 *** rafa has quit IRC
15:13:55 *** mccallumg has joined #openmrs
15:13:55 *** ChanServ sets mode: +v mccallumg
15:13:57 *** jordank has joined #openmrs
15:38:28 <djazayeri> Hi all, sorry for missing the scrum
15:38:30 <djazayeri> here's my update
15:38:45 <djazayeri> Monday 23-Jul-2012
15:38:45 <djazayeri> * ITECH work
15:38:45 <djazayeri> * Created TRUNK-3630 (VisitService.getVisits method which takes lots of arguments doesn't handle minEndDatetime correctly)
15:38:45 <djazayeri> * Created and committed CALC-44 (ListResults should have a getValues() method)
15:38:45 <djazayeri> * Continued discussion on CALC-43 (ResultUtil.convert and CalculationUtil.cast do not correctly convert things to Boolean) and CALC-42 (CalculationResult should have a "boolean isTrue()" method instead of isEmpty())
15:38:45 <djazayeri> * Created TRUNK-3629 (Rewrite the Manage Program, Workflow, and State admin pages)
15:38:46 <djazayeri> Today
15:38:46 <djazayeri> * Continue ITECH work
15:38:47 <djazayeri> * Incidental work on other tickets
15:38:47 <djazayeri> no blockers
16:01:07 *** kreddy has joined #openmrs
16:10:53 *** pushkar_ has joined #openmrs
16:14:23 *** pushkar has quit IRC
16:15:11 *** kishoreyekkanti has quit IRC
16:17:07 *** harshadura has quit IRC
16:34:44 *** pulasthi7 has joined #openmrs
16:37:44 *** suranga has joined #openmrs
16:37:44 *** ChanServ sets mode: +v suranga
16:37:51 <suranga> hi pulasthi7
16:38:09 *** lakkarau has joined #openmrs
16:38:15 <pulasthi7> hi suranga
16:38:37 <pulasthi7> suranga, saw your reply to mail
16:39:03 <suranga> pulasthi7, sorry that i did not think of this problem earlier.. it only hit me this evening
16:39:48 <suranga> pulasthi7, what do you think about it ? my concern is that if this happens at module load up time, we will have no way of displaying any meaningful information regarding what actually happend ...
16:40:40 <pulasthi7> suranga, i also like that idea
16:41:18 <pulasthi7> suranga, but the implementation may be bit hard
16:41:45 <suranga> pulasthi7, I thought that it might be easier than doing it at the module start up time, wont it ?
16:42:02 <suranga> pulasthi7, for example, I was thinking of somethink like this -
16:42:14 <suranga> 1. when loading , it detects if there is an xml file
16:42:40 <suranga> 2. if so, it displayes an extra link on the admin page
16:43:19 <suranga> 3. if the user decides not to use that link, it will ignore the flat file data, and use only data that the user creates from there onwards...
16:44:43 <pulasthi7> suranga, so that link will be active only the first time?
16:45:07 <suranga> pulasthi7, it wil be active only until the user clickes on it, and does the merge
16:45:21 <suranga> pulasthi7, after that, we will hide it..
16:45:43 <suranga> pulasthi7, wont this be easier than messing around in the Spring module startup code ?
16:45:52 <pulasthi7> suranga, what if someone ignore it and later think of viewing those old reports?
16:46:37 <suranga> pulasthi7, since we wont be supporting both flat files AND databases, he wont be able to
16:46:52 <suranga> at least, not until he migrates the xml file into the db..
16:48:54 *** goutham has joined #openmrs
16:50:26 <pulasthi7> suranga, but, will it be ok not to give a second chance? i mean in case of some accident.
16:51:20 <pulasthi7> suranga, may be we can move the reports whether user like or not at the first time
16:53:05 <suranga> pulasthi7, do you mean that we should make it mandatory to move the reports before they do anything else ?
16:53:32 <suranga> pulasthi7, maybe we could disable all the other links until they use the 'migrate' link ?
16:54:26 <pulasthi7> suranga, yes, at the first time he click the link, migration happens and then the rest
16:54:44 <pulasthi7> suranga, just an idea
16:54:47 <suranga> so, if I got you correctly -
16:54:52 <suranga> 1) user loads new module
16:55:05 <suranga> 2) module looks for and finds the xml file
16:55:34 <suranga> 3) if creates a new link, and disables all others on the page
16:55:55 <suranga> 4) user cannot use any ofthe links until he merges the xml files into the db first
16:56:11 <suranga> pulasthi7, is that what you had in mind ?
16:57:24 <pulasthi7> suranga, as the module checks for xml files at start up,can't we do the migration also there?
16:57:54 <suranga> pulasthi7, I dont like it for several reasons.
16:58:56 <suranga> 1) this will occur in the module list page, with a lot of other modules listed. so, we wont get to specify any proper errors such as "error while parsing the xml file" or "out of bounds etc"
16:59:34 <suranga> 2) the modulelist page is to specify when uploading or startup related problems happen, I m not too happy with putting this data on that page
17:00:15 <suranga> 3) we need to show the user a report of what got merged, and how. not sure if the modulelist page will let us do that...
17:00:28 *** pulasthi7 has quit IRC
17:00:28 *** jordank has quit IRC
17:02:36 *** pulasthi7 has joined #openmrs
17:02:36 *** jordank has joined #openmrs
17:03:28 <suranga> pulasthi7, my other worry is, we're planning to do something rather radical here. I dont think anyone has done something like this in OpenMRS before
17:13:44 *** jordank_ has joined #openmrs
17:14:12 *** jordank has quit IRC
17:14:13 *** jordank_ is now known as jordank
17:19:03 *** mvorobey has joined #openmrs
17:19:08 <mvorobey> hi all
17:19:35 <lakkarau> wyclif:hi
17:19:53 <wyclif> hi lakkarau
17:20:35 <lakkarau> wyclif: i am working on the issue that is for creating a file appender.
17:21:25 <lakkarau> wyclif:pastebin on my system it is not working.
17:22:03 <lakkarau> wyclif: how can i show you the code so that you can have a look at it and correect me.
17:23:11 <lakkarau> wyclif:can i have your mail id so that i can past it there.
17:24:35 <wyclif> wyclif@openmrs.org
17:25:05 *** lakkarau has quit IRC
17:25:10 <wyclif> youu mean pastebin is down?
17:25:28 *** lakkarau has joined #openmrs
17:25:49 <lakkarau> wyclif:thanks.
17:28:15 <wyclif> lakkarau, Have you looked at MemoryAppender
17:28:35 <wyclif> lakkarau, the difference will be that you are logging to a file
17:30:55 <lakkarau> wyclif:yes i have seen the memory appender.i will check once again.
17:31:03 <wyclif> lakkarau, that is used by the InitializationWizard, it calls getLogLines() and that writes that to the filter's outputstream
17:31:58 <wyclif> it maintains a small buffer where the logs are actually appended in append() method, you can implement yours to actually write the log file instead
17:33:32 <lakkarau> wyclif:thats a great help wyclif .let me try it out.
17:34:55 <lakkarau> wyclif:thank you.
17:35:09 <wyclif> lakkarau, would personally extends WriterAppender instead
17:35:28 <wyclif> lakkarau, or even FileAppender
17:35:56 <lakkarau> wyclif:ok
17:36:19 <wyclif> lakkarau, actually you dont have to write your own appender, you just need ti register the FileAppender from apache and configure it well to write you cuatom file
17:37:25 <lakkarau> wyclif:yes,but the point is, we chould not use the configureation files .we have to implement it programatically.
17:39:35 *** applecool has joined #openmrs
17:39:35 *** ChanServ sets mode: +v applecool
17:44:12 <wyclif> lakkarau, what ticket are you working on?
17:45:13 <lakkarau> wyclif:TRUNK-3491
17:52:30 *** jordank has quit IRC
17:54:54 *** jordank has joined #openmrs
18:00:00 <wyclif> lakkarau, ok
18:00:25 *** Ulrich_ has quit IRC
18:01:05 <lakkarau> wyclif:
18:03:11 *** rafa has joined #openmrs
18:03:11 *** ChanServ sets mode: +v rafa
18:06:15 <wyclif> what's up lakkarau
18:07:16 <lakkarau> wyclif: can give me high level steps.
18:07:29 <lakkarau> sorry can you please
18:07:54 <lakkarau> give me high level steps.
18:08:11 <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @pbiondich: My friend @roysingham from @twthoughts preaching truth on BBC re: growing software devel industry in Africa: http://t.co/ ... <http://twitter.com/OpenMRS/statuses/227820636368691200>
18:13:23 <lakkarau> wyclif: i think you already gave me the steps.
18:13:31 *** jriley has joined #openmrs
18:16:59 <wyclif> lakkarau, cool
18:17:32 <wyclif> lakkarau, so you have figure it out? Right?
18:18:01 <lakkarau> wyclif:yes sir.
18:18:49 <wyclif> cool
18:25:31 *** jordank has quit IRC
18:33:26 *** applecool has quit IRC
18:39:37 *** sunbiz has joined #openmrs
18:39:37 *** ChanServ sets mode: +v sunbiz
18:46:02 *** mvorobey has quit IRC
18:57:42 *** jriley has quit IRC
18:57:48 *** mvorobey has joined #openmrs
19:01:43 *** Albertjv has joined #openmrs
19:02:07 <Albertjv> Hi. I just donwloaded the OpenMRS for my private practice, and would like some help
19:02:34 <Albertjv> Anybody willing & able here?
19:07:30 *** Albertjv has quit IRC
19:13:05 *** jordank has joined #openmrs
19:21:12 *** sunbiz has left #openmrs
19:21:23 *** dkayiwa has joined #openmrs
19:28:27 <djazayeri> rafa: you there?
19:29:13 <djazayeri> rafa: I want to record a screencast around how to use git, and I was going to use META-238 as an example ticket.
19:29:45 <djazayeri> rafa: Just giving you the heads-up in case you have any reservations about it before I make it ready-for-work
19:36:00 *** mvorobey has quit IRC
19:37:03 <goutham> dkayiwa: Hi
19:37:10 <dkayiwa> goutham: hi
19:38:01 <goutham> dkayiwa: Just sent a mail.. Have a look at it
19:38:23 <rafa> djazayeri: Thanks. It sounds good. I've made it ready for work.
19:38:23 <dkayiwa> goutham: ok
19:38:33 <djazayeri> rafa: thanks
19:39:49 *** bwolfe has joined #openmrs
19:39:49 *** ChanServ sets mode: +o bwolfe
19:40:24 <lakkarau> bwolfe:hi
19:41:30 *** lakkarau has quit IRC
19:43:16 <goutham> dkayiwa: how long you will be online?
19:43:53 <dkayiwa> goutham: am going to get offline, then come back after 30 mins and stay on for not less than an hour
19:45:12 <goutham> dkayiwa: can we have a quick discussion on morinings chat ?
19:45:29 <dkayiwa> goutham: sure no problem!!!
19:46:09 <goutham> dkayiwa: no i have openmrs running and i assigned age and gender based filter to a form
19:46:41 <dkayiwa> goutham: how many filters has your test form?
19:46:45 <goutham> dkayiwa: i works good for me.. did u find any issue in it
19:46:57 <goutham> dkayiwa: 2filters
19:47:36 <dkayiwa> goutham: let me get your update and test again
19:47:51 <goutham> dkayiwa: ok
19:50:07 *** mccallumg has quit IRC
19:50:42 *** mccallumg has joined #openmrs
19:50:42 *** ChanServ sets mode: +v mccallumg
19:51:59 <dkayiwa> goutham: under manage forms, when i type form name, nothing shows up
19:52:57 <dkayiwa> goutham: that is manage form filtering
19:53:30 <goutham> dkayiwa: you have any forms in your db?
19:53:43 <dkayiwa> goutham: yes
19:53:57 <djazayeri> rafa, bwolfe: any opinion on how we should name topic branches when contributing to a module?
19:54:11 <bwolfe> by the ticket number?
19:54:13 <rafa> djazayeri: ticket id?
19:54:15 <djazayeri> e.g. should I create a "META-238" branch?
19:54:15 <dkayiwa> i can see them from the admin - > manage forms. but not under manage form filtering
19:54:36 <djazayeri> bwolfe, rafa: since you both instantly said the same thing, I'll go with that.
19:54:48 <bwolfe> heh
19:54:54 <bwolfe> number > id
19:54:55 <bwolfe> ;-)
19:55:04 <goutham> dkayiwa: can you open any patient dashboard and let me know if there are any forms listed there
19:55:13 <bwolfe> actually, "id" is the better way to say it. you win rafa
19:55:21 <goutham> djazayeri: under patient form entry tab
19:55:43 <goutham> dkayiwa: under patient form entry tab
19:57:11 <dkayiwa> goutham: oh i see, htmlformentry, xforms, formentry, had not yet taken any form
19:57:25 <dkayiwa> goutham: thats why i never got one. so ignore that :)
19:57:43 <goutham> goutham: :)
19:59:31 <dkayiwa> goutham: will be back after 30 mins
19:59:31 *** rfriedman has quit IRC
19:59:33 *** dkayiwa has quit IRC
20:02:28 *** mccallumg has quit IRC
20:04:00 *** mvorobey has joined #openmrs
20:07:41 <pushkar_> bwolfe, Hi
20:08:05 <bwolfe> hi pushkar_
20:08:07 <djazayeri> rafa: I'm going to send you a pull request, but please ignore it. I'm just prepping to record the screencast
20:08:18 <rafa> djazayeri: ok
20:08:30 <pushkar_> bwolfe, did you get a chance to look at the documentation ?
20:08:57 <bwolfe> pushkar_, not yet. I've been traveling around all day
20:13:24 <pushkar_> bwolfe, okay
20:13:39 <mvorobey> hi bwolfe
20:15:03 <mvorobey> bwolfe, have a minute ?
20:15:29 <bwolfe> sure
20:17:25 *** pulasthi7 has quit IRC
20:17:46 *** pulasthi7 has joined #openmrs
20:20:39 <mvorobey> is there a way to define inner class as spring bean ?
20:20:44 <mvorobey> bwolfe, is there a way to define inner class as spring bean ?
20:28:39 <bwolfe> mvorobey, hmm
20:28:49 <bwolfe> mvorobey, probably. you have to figure out how java thinks of hte class
20:28:56 <bwolfe> and as long as the classloader can find it, yes
20:29:09 <bwolfe> but why do that?
20:29:17 <bwolfe> you could annotate it, for sure
20:32:37 <mvorobey> bwolfe, ok, thanks, will try that
20:37:21 *** dkayiwa has joined #openmrs
20:37:51 *** pushkar_ has quit IRC
20:38:45 <goutham> dkayiwa: ready for next round?
20:38:51 <goutham> :)
20:38:59 <dkayiwa> goutham: oh ya :)
20:39:09 <dkayiwa> goutham: thought would find you asleep:)
20:39:59 <goutham> dkayiwa: i slept after noon so im good :)
20:41:01 <dkayiwa> goutham: when i try delete a filter and click the cancel button, it still deletes it
20:42:03 *** maurya has quit IRC
20:42:30 <goutham> dkayiwa: ok
20:42:54 <dkayiwa> goutham: the message does not also look like it is asking me to confirm
20:43:42 *** snoppy has left #openmrs
20:44:13 <goutham> dkayiwa: i framed that sentence because it has Ok and Cancel buttons
20:45:18 <dkayiwa> goutham: can you be the massage ask me to confirm?
20:45:59 <kreddy> rafa, u there?
20:46:16 <rafa> kreddy: yes
20:46:29 <goutham> dkayiwa: ok will add it with ajax tomorrow .. Message will be "Are you sure want to delete ?" options "Yes " or "No"
20:46:36 <kreddy> ! META-228
20:46:37 <OpenMRSBot> kreddy: Error: "META-228" is not a valid command.
20:46:47 <goutham> dkayiwa: not ajax...jquery
20:46:54 <kreddy> !META-228
20:46:55 <OpenMRSBot> kreddy: Error: "META-228" is not a valid command.
20:47:00 <rafa> !ticket META-228
20:47:01 <OpenMRSBot> rafa: [#META-228] Cannot import a concept containing a mapping in OpenMRS 1.9 - OpenMRS JIRA - https://tickets.openmrs.org/browse/META-228
20:47:05 <dkayiwa> goutham: ok
20:47:39 <kreddy> thanks rafa, I see that there is no time estimate for that but 1w 2h is logged for that ticket
20:48:27 <rafa> kreddy: I estimated 1w
20:48:37 <rafa> kreddy: let me enter that
20:48:48 <kreddy> ok, thanks rafa
20:49:04 *** djazayeri has quit IRC
20:49:17 <dkayiwa> goutham: did you intentionally leave the formfilter.get/setid empty?
20:49:24 <rafa> kreddy: hmm actually not sure how to do that now...
20:49:29 <dkayiwa> goutham: you could copy from other openmrs objects
20:49:51 <rafa> kreddy: I see only remaing estimate
20:50:01 <rafa> kreddy: when I go to edit
20:51:05 *** lakkarau has joined #openmrs
20:51:55 <goutham> dkayiwa: yes i left them intentionally... those should be implemented if object extends from baseopenmrs object and i have no use of them
20:52:52 <dkayiwa> goutham: can you deal with them in the same way like the core openmrs objects?
20:52:58 <rafa> kreddy: sorry I can't see a way to set estimated right now, just remaining
20:53:43 <kreddy> rafa, ok. even i faced a similar problem when editing the time estimate.
20:53:43 *** djazayeri has joined #openmrs
20:53:43 *** ChanServ sets mode: +o djazayeri
20:53:51 <goutham> dkayiwa: will have a look at it
20:54:28 <dkayiwa> goutham: can you also remove the // TODO Auto-generated method stub where you have put code?
20:54:40 <goutham> dkayiwa: ok
20:55:30 <kreddy> dkayiwa, can you provide time estimate for !ticket XFRM-16
20:55:36 <dkayiwa> goutham: did you put the @should annotations for the methods you test?
20:55:45 <dkayiwa> !ticket xform-16
20:55:46 <OpenMRSBot> dkayiwa: Issue Does Not Exist - OpenMRS JIRA - https://tickets.openmrs.org/browse/xform-16
20:56:07 <dkayiwa> !ticket xfrm-16
20:56:08 <OpenMRSBot> dkayiwa: [#XFRM-16] Include Relationship Widget in XForms Designer - OpenMRS JIRA - https://tickets.openmrs.org/browse/xfrm-16
20:56:42 <goutham> dkayiwa: yes i added them
20:56:54 <dkayiwa> goutham: where?
20:57:39 <goutham> dkayiwa: example- http://svn.openmrs.org/openmrs-modules/formfilter/trunk/api/src/main/java/org/openmrs/module/formfilter/impl/AgeFormFilter.java above shouldDisplayForm method
20:59:24 <lakkarau> rafa:hi
20:59:37 <dkayiwa> goutham: ok good!!! :)
20:59:48 <dkayiwa> goutham: can we also have unit tests for FormFilterService ?
21:00:07 <goutham> dkayiwa: yes
21:00:15 <rafa> lakkarau: hi, sorry going offline in a minute
21:00:29 <rafa> lakkarau: something quick?
21:01:00 <lakkarau> rafa:for the Trunk-2941 ,what is the login details for the old wiki
21:01:19 <lakkarau> bcause it is not allowing new users
21:02:02 <rafa> lakkarau: have you tried with your openmrs id?
21:02:17 <lakkarau> yes
21:02:55 <dkayiwa> goutham: did you intend to add all the @see on FormFilterDAO.saveFormFilter?
21:03:13 <rafa> lakkarau: for that ticket all you need to to is move things from https://wiki.openmrs.org/display/archive/Archive to the proper places in Documentation, Projects, Resources
21:03:31 <rafa> lakkarau: you don't need acces to old wiki, all is in the archive
21:03:57 <lakkarau> rafa:ok i am now clear about what i have to do
21:04:08 <lakkarau> rafa:thanks
21:04:20 <rafa> lakkarau: you're welcome
21:04:24 <goutham> dkayiwa: those three services were using it so thought would be good adding them
21:04:39 <dkayiwa> goutham: ok
21:04:45 <rafa> lakkarau: don't forget to upload a patch for TRUNK-3491
21:05:02 <rafa> lakkarau: I'll look in the morning why it doesn't work for you
21:05:33 <lakkarau> rafa:the folder and the file is created but it is empty.
21:06:08 <rafa> lakkarau: please attach a patch I need to see code
21:06:25 <rafa> lakkarau: okay I need to go now
21:06:31 <dkayiwa> goutham: for DateFormFilter, any reason why you declared class member variables between methods?
21:06:31 <rafa> lakkarau: see you tomorrow
21:06:49 <lakkarau> rafa:my system ,pastebin is not working .
21:07:04 <lakkarau> rafa:ok bye.
21:08:21 <goutham> dkayiwa: you meant date and show variables ?
21:08:29 <dkayiwa> goutham: looks like you did the same for even other filters. yes
21:08:38 <dkayiwa> goutham: any reason?
21:09:56 <goutham> dkayiwa: nope...as constructor is called first in object i feel like keeping it starting
21:10:26 <goutham> dkayiwa: any way i will change it ...i think its not good programming standard
21:10:28 <dkayiwa> goutham: do you mind using the same pattern as for other openmrs classes?
21:10:31 *** rafa has quit IRC
21:10:48 <goutham> dkayiwa: will change it
21:11:07 <dkayiwa> goutham: and they also do not seem to have javadoc.
21:11:38 <dkayiwa> goutham: some variable names will also need to be made more meaningful. for instance what does the show variable name mean?
21:12:23 <goutham> dkayiwa: show = when to show form " before/after"
21:12:57 <dkayiwa> goutham: i think we need to change to a name that carries more info :)
21:13:15 <goutham> dkayiwa: like?
21:13:42 <dkayiwa> goutham: what does it mean when show = true and when show = false?
21:14:40 <goutham> dkayiwa: no no show values will be after / before.
21:15:25 <dkayiwa> goutham: before and after what?
21:16:21 <goutham> dkayiwa: " date "- show form "Before" date "12/12/2012"
21:17:50 <dkayiwa> goutham: ok. can you include javadoc for these class member variables?
21:18:01 <goutham> dkayiwa: yes
21:19:48 *** pulasthi7 has quit IRC
21:20:08 <dkayiwa> goutham: am very sleepy. how about continuing tomorrow morning?
21:20:22 <goutham> dkayiwa: Ok good night :)
21:20:47 <dkayiwa> goutham: good night too and thanks for the great work!!! :D
21:24:35 *** goutham has quit IRC
21:34:32 *** lh has quit IRC
21:35:56 <lakkarau> bwolfe:hi
21:39:04 *** nwilkie has quit IRC
21:42:49 *** dkayiwa has quit IRC
21:51:48 *** suranga has quit IRC
21:53:57 *** mccallumg has joined #openmrs
21:54:03 *** ChanServ sets mode: +v mccallumg
22:07:26 *** jordank has quit IRC
22:21:47 *** lh has joined #openmrs
22:21:47 *** lh has joined #openmrs
22:49:41 *** mvorobey has quit IRC
23:11:36 *** lakkarau has quit IRC
23:31:02 <djazayeri> bwolfe: yo
23:31:10 <djazayeri> can you create me a slashtmp?
23:38:02 *** mccallumg has quit IRC
23:44:37 <djazayeri> bwolfe: actually, never mind, I emailed downey
23:51:07 *** kreddy has quit IRC