00:43:15
|
*** nwilkie has quit IRC
|
01:03:26
|
*** bwolfe has joined #openmrs
|
01:03:26
|
*** ChanServ sets mode: +o bwolfe
|
01:07:56
|
*** Jibesh has joined #openmrs
|
01:30:23
|
*** emilyp has joined #openmrs
|
01:30:48
|
*** emilyp has left #openmrs
|
02:49:39
|
*** harshadura has joined #openmrs
|
03:41:08
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @pbiondich: #OSCON was one of the most fulfilling things I've done in some time. Inspired, humbled, & rejuvenated. Go @OpenMRS! <http://twitter.com/OpenMRS/statuses/226494356511674368> || OpenMRS Modules: UI Library Module 1.4 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=uilibrary&version=&1.4> || OpenMRS Modules: OpenMRS UI Framework 1.7 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=uiframework&version=&1.7> || OpenMRS Modules: App Framework Module 1.3 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=appframework&version=&1.3>
|
03:41:32
|
*** upul` has joined #openmrs
|
03:41:32
|
*** ChanServ sets mode: +v upul`
|
03:42:06
|
*** bwolfe has quit IRC
|
04:07:24
|
*** djazayeri1 has joined #openmrs
|
04:08:05
|
*** Jibesh has quit IRC
|
04:08:31
|
*** suranga has joined #openmrs
|
04:08:31
|
*** ChanServ sets mode: +v suranga
|
04:09:02
|
*** djazayeri has quit IRC
|
05:16:53
|
*** djazayeri1 has quit IRC
|
05:48:34
|
*** harshadura has quit IRC
|
06:08:03
|
*** suranga has quit IRC
|
06:13:55
|
*** harshadura has joined #openmrs
|
06:16:41
|
*** shortend has joined #openmrs
|
06:20:32
|
*** snoppy has joined #openmrs
|
06:22:11
|
*** mgielow has joined #openmrs
|
06:42:11
|
*** magoo_ has joined #openmrs
|
06:55:50
|
*** magoo_ has quit IRC
|
07:03:02
|
*** magoo_ has joined #openmrs
|
07:16:18
|
*** harshadura has quit IRC
|
07:39:16
|
*** mgielow has quit IRC
|
07:57:05
|
*** magoo_ has quit IRC
|
08:03:06
|
*** magoo_ has joined #openmrs
|
08:05:06
|
*** dkayiwa has joined #openmrs
|
08:07:30
|
*** magoo_ has quit IRC
|
09:03:27
|
*** harshadura has joined #openmrs
|
09:16:06
|
*** shortend has quit IRC
|
09:22:00
|
*** kavuri has joined #openmrs
|
09:31:35
|
*** kavuri has quit IRC
|
09:53:12
|
<harshadura> dkayiwa can i get a min ?
|
09:53:21
|
<dkayiwa> harshadura: sure
|
09:54:43
|
*** mgielow has joined #openmrs
|
09:54:57
|
<harshadura> dkayiwa, here I hv written liquibase file for the question i asked frm u yesterday
|
09:55:02
|
<harshadura> pls can u chk it
|
09:55:03
|
<harshadura> http://pastebin.com/jCKmx3sm
|
09:55:45
|
<harshadura> the mapping for your ref : http://imagebin.org/221742
|
09:55:51
|
<dkayiwa> harshadura: does it fail?
|
09:56:05
|
<harshadura> no dkayiwa that works
|
09:56:11
|
<dkayiwa> harshadura: ok
|
09:57:33
|
*** rafa has joined #openmrs
|
09:57:33
|
*** ChanServ sets mode: +v rafa
|
10:00:30
|
<dkayiwa> hi rafa
|
10:00:36
|
<rafa> hi dkayiwa
|
10:00:39
|
<dkayiwa> rafa: is the sprint still going on? :)
|
10:00:47
|
<rafa> dkayiwa: yes
|
10:00:53
|
<dkayiwa> rafa: ok thanks!!!
|
10:20:08
|
<harshadura> dkayiwa, When I am saving a Feedback into the Feedback Table I also need to save its FeedbackID and UserID into the UserAccess Table. previously it worked without foreign keys, but aftr the foreign key implementation for UserAccess Table now its not working properly, It saves to Feedback table only, pls can u chk whether my hibernate xml is correct ?
|
10:20:25
|
<harshadura> here is my hbm file > http://pastebin.com/0xtmQRDt
|
10:20:34
|
<dkayiwa> harshadura: do you get any errors?
|
10:20:41
|
<harshadura> yes dkayiwa
|
10:20:53
|
<dkayiwa> harshadura: how does the stack trace look like?
|
10:22:28
|
<harshadura> dkayiwa, here is the log > http://pastebin.com/MxMLq8yj
|
10:22:54
|
*** snoppy has left #openmrs
|
10:23:27
|
*** Guest7169 has joined #openmrs
|
10:23:31
|
<dkayiwa> harshadura: can you write a unit test showing this problem?
|
10:23:52
|
*** shortend has joined #openmrs
|
10:24:28
|
<harshadura> ok dkayiwa I will try but can u jz chk my hbm xml file > http://pastebin.com/0xtmQRDt
|
10:25:35
|
<dkayiwa> harshadura: is user_id a foreign key?
|
10:26:01
|
<harshadura> no dkayiwa, feedback_id is the foreign key
|
10:26:34
|
<dkayiwa> harshadura: is it also the primary key?
|
10:26:59
|
<harshadura> yes dkayiwa feedback_id is also the primary key
|
10:27:29
|
<dkayiwa> harshadura: how about having a separate primary key?
|
10:28:00
|
<harshadura> dkayiwa, is this way bad? then I will do like that
|
10:30:01
|
<dkayiwa> harshadura: according to your hibernate mapping file, that field is automatically generated. so that is definitely not referencing a value in another table :)
|
10:31:28
|
<harshadura> dkayiwa, what i need to do prvent that problem ?
|
10:32:04
|
<dkayiwa> harshadura: how many columns do you have in that table?
|
10:32:21
|
<harshadura> 2 columns only dkayiwa
|
10:32:29
|
<harshadura> userid, feedbackid
|
10:32:59
|
<dkayiwa> harshadura: is userid a foreign key?
|
10:33:23
|
<harshadura> no dkayiwa
|
10:33:41
|
<harshadura> only feedbackId is Foreign
|
10:33:43
|
<dkayiwa> harshadura: i thought it references the users table?
|
10:34:03
|
<harshadura> no dkayiwa we dont need it i think
|
10:34:23
|
<dkayiwa> harshadura: you do not need the column?
|
10:35:13
|
<harshadura> no i meant reference is not essential for now for userID column
|
10:35:55
|
<dkayiwa> harshadura: ok. so is this table simply linking a user and feedback table?
|
10:36:48
|
<harshadura> yes dakyiwa, userID and a corresponding feedbackID
|
10:37:51
|
<dkayiwa> harshadura: in that case, one of the simpler ways is create a third auto generated column to serve as the primary key
|
10:37:54
|
*** Guest7169 has quit IRC
|
10:38:11
|
<harshadura> dkayiwa jz fyi (in here the user means not the person who creates the feedback its the person who is assigned to reply this feedback)
|
10:38:23
|
<dkayiwa> harshadura: ok
|
10:39:01
|
<harshadura> thanks dkayiwa, I will make it like that
|
10:39:09
|
<dkayiwa> harshadura: ok
|
10:57:15
|
*** suranga has joined #openmrs
|
10:57:15
|
*** ChanServ sets mode: +v suranga
|
11:25:17
|
*** upul` has quit IRC
|
11:32:34
|
*** applecool has joined #openmrs
|
11:32:34
|
*** ChanServ sets mode: +v applecool
|
11:32:40
|
<applecool> Hi rafa
|
11:32:50
|
<rafa> applecool: hi
|
11:32:59
|
<applecool> i am back :) rafa
|
11:33:09
|
<rafa> applecool: yes, got your e-mail
|
11:33:20
|
<applecool> ;)
|
11:33:31
|
<rafa> applecool: so any progress today?
|
11:33:44
|
<applecool> i guess i need to go through your comments on my commits!
|
11:33:59
|
<rafa> applecool: ok
|
11:34:10
|
<applecool> no not yet ! i need to go home and then start!
|
11:34:21
|
<applecool> i had classes till now!
|
11:35:03
|
<rafa> applecool: good
|
11:35:35
|
<rafa> applecool: so you'll finish with METAREPO-4 today
|
11:35:43
|
<rafa> applecool: and start METAREPO-1?
|
11:35:48
|
<applecool> yup
|
11:36:01
|
<applecool> i need to add a getter for the module right
|
11:36:09
|
<rafa> applecool: is METAREPO-1 clear?
|
11:36:10
|
<applecool> and i am done with METAREPO-4
|
11:36:31
|
<applecool> just a sec!
|
11:36:55
|
<rafa> applecool: it's just UI changes
|
11:37:49
|
<applecool> yes :)
|
11:38:03
|
<applecool> align the icon and changing the color to olive!
|
11:38:13
|
<applecool> should i change the color of the tag line into olive?
|
11:38:23
|
<rafa> tag line?
|
11:39:46
|
<rafa> applecool: the point is to remove "OpenMRS" from the logo file and make it simply a text "OpenMRS Metadata Repository"
|
11:40:26
|
<rafa> applecool: and put a css on it to look as the "Welcome!" text
|
11:42:15
|
<applecool> so its simply i need to crop the image [remove OpenMRS from the logo] and replace it with "OpenMRS Metadata Repository" which should be in the same color [olive] as Welcome
|
11:42:27
|
<applecool> right? or did i goof up?
|
11:42:36
|
<rafa> applecool: right
|
11:42:43
|
<applecool> great :)
|
11:44:54
|
<applecool> so rafa first i need to claim the issue and then you want me to add a patch there and then commit it?
|
11:45:04
|
<rafa> applecool: not you just commit
|
11:45:16
|
<rafa> applecool: claim, then commit
|
11:45:22
|
<rafa> applecool: no need for patches
|
11:45:28
|
<applecool> okay :)
|
11:45:54
|
<rafa> applecool: I've written down the workflow in one of the previous e-mails...
|
11:46:30
|
<applecool> You must include the ticket id in all your commits. ! ?
|
11:46:35
|
<applecool> i dint understand this!
|
11:47:06
|
<applecool> you want me to mention the ticket id in the commit message?
|
11:47:14
|
<rafa> applecool: yes
|
11:47:20
|
<rafa> applecool: METAREPO-4 is a ticket id
|
11:47:25
|
<applecool> yup :)
|
11:47:48
|
*** jkeiper has joined #openmrs
|
11:52:11
|
<applecool> rafa: so first i would be concentrating on the tickets marked as 1.0
|
11:52:17
|
<rafa> applecool: yes
|
11:52:34
|
<applecool> 8 are there! and 2 will be done today :)
|
11:53:24
|
*** bwolfe has joined #openmrs
|
11:53:24
|
*** ChanServ sets mode: +o bwolfe
|
11:57:51
|
<applecool> rafa: leaving!
|
11:58:07
|
<applecool> how many hours will you be there? rafa
|
11:58:27
|
<rafa> applecool: 5-6
|
11:58:37
|
<applecool> oh cool :)
|
11:58:47
|
<applecool> i will be back then! cya rafa
|
11:59:07
|
<rafa> applecool: cya
|
11:59:13
|
*** applecool has quit IRC
|
11:59:22
|
<dkayiwa> bwolfe: do you have an idea why i do not have permissions to make EMMA-??? tickets ready for work?
|
12:01:20
|
<bwolfe> dunno, let me look
|
12:01:52
|
<bwolfe> dkayiwa, how about now?>
|
12:02:37
|
<dkayiwa> bwolfe: thanks!!!
|
12:09:38
|
*** shortend has quit IRC
|
12:09:38
|
*** rafa has quit IRC
|
12:09:38
|
*** harshadura has quit IRC
|
12:09:56
|
*** shortend has joined #openmrs
|
12:10:07
|
*** harshadura has joined #openmrs
|
12:11:52
|
*** rafa has joined #openmrs
|
12:11:52
|
*** ChanServ sets mode: +v rafa
|
12:19:10
|
*** wyclif has quit IRC
|
12:21:35
|
*** harshadura has quit IRC
|
12:22:27
|
*** harshadura has joined #openmrs
|
12:25:37
|
*** harshadura has quit IRC
|
12:54:28
|
*** nwilkie has joined #openmrs
|
12:55:41
|
*** dkayiwa has quit IRC
|
12:56:26
|
<suranga> hi bwolfe
|
12:56:31
|
<suranga> bwolfe, happy monday !
|
12:56:32
|
<bwolfe> hi
|
12:56:39
|
<bwolfe> mondays are never happy :-p
|
12:57:07
|
<suranga> bwolfe, it is, to us unmarried and u-attached folks :D
|
12:57:44
|
<suranga> bwolfe, I see you have been following my changes to the hl7query tickets...
|
12:57:54
|
<bwolfe> yeah
|
12:58:02
|
<bwolfe> did you add more that I'm not a watcher on?
|
12:58:23
|
<suranga> bwolfe, oops, let me go check...
|
12:58:26
|
* suranga leaves
|
13:03:13
|
<suranga> mm.. hi bwolfe , it seems that I cant add anyone else as a watcher... I assume you have looked at all the tickets from Other-24 to other 32 ?
|
13:04:15
|
*** wyclif has joined #openmrs
|
13:04:30
|
<bwolfe> suranga, doubtful
|
13:04:34
|
* bwolfe goes to look
|
13:20:00
|
*** harshadura has joined #openmrs
|
13:20:35
|
*** dkayiwa has joined #openmrs
|
13:22:53
|
<bwolfe> suranga, your wiki page has duplicate content about "converting the xml version of the hl7 message..." https://wiki.openmrs.org/display/projects/Groovy+templates+for+mapping+hl7+data
|
13:23:14
|
<bwolfe> suranga, and the code example about processMessage is converting from pipe hl7 to a hapi object
|
13:23:35
|
<bwolfe> but the example needs to be xml string-->hapi object-->hl7 pipe string
|
13:26:15
|
*** pushkar has joined #openmrs
|
13:26:54
|
<pushkar> bwolfe,
|
13:26:56
|
<pushkar> HI
|
13:27:09
|
<bwolfe> hi pushkar
|
13:28:01
|
<pushkar> bwolfe, I am facing some problems saving the complexobs from hfe module
|
13:29:13
|
<bwolfe> pushkar, I thought you had that solved...
|
13:29:16
|
<bwolfe> whats going on ?
|
13:30:24
|
<pushkar> bwolfe, yes but its coming again in a different manner If I am updating an observation from hfe module using htmlform the encouter save handler is getting called twice
|
13:32:07
|
<bwolfe> the core encsavehandler?
|
13:32:13
|
<suranga> hi bwolfe sorry about the duplication, I just fixed it...
|
13:32:35
|
<suranga> bwolfe, im afraid I dont get the part about "code example about processMessage is converting from pipe hl7 to a hapi object"
|
13:32:52
|
<suranga> bwolfe, you are looking at the very last code snippet on the page, right ?
|
13:34:09
|
<pushkar> yes but I dont think there is any problem with that . I guess the problem is in hfe. the way it saves the encounters
|
13:34:19
|
<suranga> bwolfe, thats what it does, it takes an java Stirng object (which is a xml) and converts it into the pipe delimited hl7 object using HAPI api...
|
13:36:26
|
<bwolfe> pushkar, can you look at the stack trace of each to see when/why its called twice?
|
13:37:11
|
<bwolfe> suranga, the processMessage(String hl7, String enterpriseId) method??
|
13:37:39
|
<bwolfe> that processMessage is for input. it takes in a string hl7 pipe message and converts to hapi object (and then to openmrs rows/columns)
|
13:38:26
|
<pushkar> sure just a small question when will the encountersavehandler get called before saving encounter or after saving the encounter ?
|
13:38:28
|
<bwolfe> the 1,2,3 just above that processMessage method is talking about output (what we are doing in this module). saying openmrs object --> xml template --> hapi object --> hl7 pipes
|
13:38:37
|
<bwolfe> pushkar, before
|
13:40:21
|
<suranga> bwolfe, gimmie a few minutes, I'll get back to you... my boss has returned on the other window :-)
|
13:41:57
|
*** davidng has joined #openmrs
|
13:48:41
|
*** kavuri has joined #openmrs
|
13:49:09
|
<dkayiwa> suranga: call your boss to the main window :)
|
13:49:39
|
<suranga> dkayiwa, we dont use IRC any more. now we use this client called hipchat :-)
|
13:50:18
|
<bwolfe> irc > hipchat
|
13:50:38
|
<suranga> bwolfe, I am begining to suspect the very same :P
|
13:51:13
|
<davidng> hi, i am about to mavenize a module which depends on reportingcapability 1.5.2.0 and xforms 3.9.8
|
13:51:17
|
<dkayiwa> suranga: hahahahha
|
13:51:19
|
<dkayiwa> :)
|
13:51:29
|
<davidng> however, they are not in OpenMRS nexus
|
13:51:41
|
<bwolfe> suranga, we tested out hipchat for a day or so
|
13:51:56
|
<bwolfe> davidng, what version of reportingcompat is in there?
|
13:52:29
|
<suranga> bwolfe, this was before my time. was it ? hipchat does not seem to like weaker internet connections :(
|
13:52:30
|
<davidng> the version i saw in the existing code is 1.5.2.0
|
13:54:00
|
<bwolfe> suranga, it was only a few months ago. downey installed it and invited a number of us in the office. didn't have all the "features" of irc
|
13:54:02
|
<davidng> generally, if a module is not found on http://mavenrepo.openmrs.org/nexus/content/repositories/public/org/openmrs/module/, should i run my own Nexus?
|
13:54:30
|
<davidng> and what's the policy to retain old versions in openmrs repo?
|
13:54:57
|
<bwolfe> davidng, the mavenrepo can retain all old versions. someone just needs to upload them. :-)
|
13:55:09
|
<bwolfe> davidng, running your own nexus seems like overkill :-)
|
13:55:25
|
<davidng> can anyone upload the omod?
|
13:55:33
|
<davidng> to openmrs repo?
|
13:55:52
|
<bwolfe> davidng, no
|
13:56:08
|
<bwolfe> davidng, is the 1.5.2.0 version of reportcompat mavenized?
|
13:56:16
|
*** kavuri has quit IRC
|
13:56:31
|
<davidng> i don't think so
|
13:56:43
|
<davidng> the module I try to mavenize is callscheduler (from Joaquin)
|
13:57:06
|
<davidng> in its config file, it states that it depends on reportcompat 1.5.2.0
|
13:58:36
|
<bwolfe> davidng, ha, wow, looks like that version was uploaded in late 2010
|
13:58:59
|
<bwolfe> davidng, is it possible to depend one of the latest reportcompat?
|
13:59:11
|
<davidng> i think so, i will try that
|
13:59:13
|
<bwolfe> 1.5.8 of reportcompat depends on 1.7.0 openmrs though
|
13:59:17
|
<bwolfe> https://modules.openmrs.org/modules/view.jsp?module=reportingcompatibility
|
14:00:05
|
<davidng> thank you very much, ben
|
14:00:26
|
<bwolfe> davidng, I only ask because that latest one will be 10x easier to put into nexus :-)
|
14:00:33
|
<bwolfe> (and it probably has bug fixes anyway)
|
14:01:09
|
<davidng> yeah, i agree, i'm just afraid of incompatibility issue, but i think it won't matter. If there're issues, i'll fix them
|
14:01:19
|
*** downey has joined #openmrs
|
14:01:19
|
*** ChanServ sets mode: +o downey
|
14:01:19
|
*** OpenMRSBot sets mode: +o downey
|
14:02:24
|
*** cpower has joined #openmrs
|
14:02:37
|
<davidng> however, i don't see any reportingcompatibility on http://mavenrepo.openmrs.org/nexus/content/repositories/public/org/openmrs/module/
|
14:02:57
|
<cpower> Hello saviors of the free medical open source world.. how are you?
|
14:04:28
|
<pushkar> bwolfe, I guess the reason is when we say modify obs the existing obs is marked as obstovoid and new obs is added to the obstocreate list
|
14:05:02
|
<cpower> Are we ready for our daily Scrum?
|
14:05:37
|
<pushkar> but while saving first the encounter is being saved and after that the marked obs are getting voided
|
14:06:08
|
<pushkar> thats the reason for the encounter save handler getting called twice
|
14:07:10
|
*** djazayeri has joined #openmrs
|
14:07:10
|
*** ChanServ sets mode: +o djazayeri
|
14:07:31
|
<cpower> ok, well without further ado let's start
|
14:07:38
|
<cpower> !scrumon cpower
|
14:07:38
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
14:07:54
|
*** bwolfe has quit IRC
|
14:08:25
|
*** kavuri has joined #openmrs
|
14:08:32
|
<cpower> Order: Wyclif, jkeiper, dkayiwa, suranga, rafa, djazayeri, bwolfe
|
14:09:43
|
<wyclif> Friday:
|
14:09:43
|
<wyclif> TRUNK-3607 - Migrate devexample modules from svn to github (Except one)
|
14:09:43
|
<wyclif> weekly skype call with Dmitry
|
14:09:43
|
<wyclif> more git migration documentation
|
14:09:43
|
<wyclif> Monday:
|
14:09:44
|
<wyclif> Migrate the remaining devexample module where that i had no access
|
14:09:46
|
<wyclif> Git documentation
|
14:09:48
|
<wyclif> CUrating tickets
|
14:09:50
|
<wyclif> Blockers: None
|
14:10:51
|
*** bwolfe has joined #openmrs
|
14:10:51
|
*** ChanServ sets mode: +o bwolfe
|
14:11:00
|
<djazayeri> jkeiper: you there?
|
14:11:04
|
<cpower> jkeiper...
|
14:11:08
|
<jkeiper> jkeiper...
|
14:11:12
|
<cpower> aaaaaand skip
|
14:11:22
|
<jkeiper> sorry, on a call
|
14:11:24
|
<cpower> dkayiwa
|
14:11:30
|
<dkayiwa> Curated tickets
|
14:11:31
|
<dkayiwa> Still Curating more tickets
|
14:11:31
|
<dkayiwa> No Blockers
|
14:12:08
|
<djazayeri> suranga: ?
|
14:12:10
|
<cpower> Suranga, if you have anything to let the group know, this is a good time.
|
14:12:19
|
<suranga> Hi
|
14:12:24
|
<suranga> working on plans for the hl7query module. Creating + updating tickets, mailing a lot of people :)
|
14:12:31
|
<suranga> and updating wiki documents...
|
14:12:41
|
<cpower> fair enough, rafa your up
|
14:12:43
|
<suranga> all looks well to start the sprint on the 30th
|
14:12:47
|
<rafa> Today:
|
14:12:48
|
<rafa> * Started later today (have 2 more hours)
|
14:12:48
|
<rafa> * Investigated META-230: Import fails with Column 'concept_name_id' cannot be null
|
14:12:48
|
<rafa> * Committed TRUNK-3626: UpdateConceptWord throws com.mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException: Column 'concept_name_id' cannot be null,
|
14:12:48
|
<rafa> which fixes META-230
|
14:12:48
|
<rafa> * Will work on ConceptReferenceTermValidator
|
14:12:48
|
<rafa> * Other sprint tickets
|
14:12:49
|
<rafa> No blockers.
|
14:13:12
|
<djazayeri> Ongoing
|
14:13:12
|
<djazayeri> * ITECH Kenya work
|
14:13:12
|
<djazayeri> * Started discussion around CALC-42 - CalculationResult.toBoolean()
|
14:13:12
|
<djazayeri> * Noted that Rafal's recent fixes seem to have resolved my MDS bugs
|
14:13:14
|
<djazayeri> No blockers
|
14:13:17
|
<cpower> good to hear suranga, let Kiran, Ben or I know if you need any help
|
14:13:37
|
<cpower> and bwolfe has returned so you sir are up.
|
14:13:40
|
<bwolfe> sorry folks, had the power flicker flash here and the router didn't want to reboot. (visions of kenya!)
|
14:13:51
|
<bwolfe> Thursday
|
14:13:52
|
<bwolfe> applied IDGEN-11
|
14:13:52
|
<bwolfe> created trunk ticket for conv method
|
14:13:52
|
<bwolfe> triaged ERR tickets
|
14:13:52
|
<bwolfe> hit inbox0 /again/
|
14:13:52
|
<bwolfe> reviewed TRUNK-3589 for uma
|
14:13:54
|
<bwolfe> dev call
|
14:13:56
|
<bwolfe> curate tickets
|
14:13:58
|
<bwolfe> githubbing with kishore?
|
14:14:00
|
<bwolfe> created curation dashboard
|
14:14:02
|
<bwolfe> reviewed the reviewed tickets
|
14:14:04
|
<bwolfe> Friday
|
14:14:06
|
<bwolfe> reviewed ticket for uma
|
14:14:08
|
<bwolfe> reviewed curated tickets by daniel/wyclif
|
14:14:10
|
<bwolfe> reviewed tickets/wiki page for suranga
|
14:14:12
|
<bwolfe> no blockers, still going through the mass of emails from daniel's curating. :-)
|
14:14:17
|
*** jriley has joined #openmrs
|
14:14:28
|
<bwolfe> inbox0 seems so far away...
|
14:14:36
|
<dkayiwa> :D
|
14:14:38
|
<cpower> tell me about it.
|
14:14:49
|
*** nwilkie has quit IRC
|
14:15:26
|
<cpower> ok no blockers, gitthubbing with Kishore had a "?" by it which feels like a discussion point, but I'll let them take that off line.
|
14:15:29
|
<cpower> !scrumoff
|
14:15:29
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
14:16:03
|
<bwolfe> yes, it is a discussion point, one that needs kishore :-p
|
14:16:09
|
<bwolfe> I'll email him since he's not here
|
14:16:29
|
<dkayiwa> bwolfe: i have a "non essential" question for you. why should we label tickets with "curated"? :)
|
14:16:41
|
<dkayiwa> bwolfe: for statistics? :)
|
14:17:35
|
<bwolfe> dkayiwa, so that you don't circle back to it to try and curate again
|
14:17:44
|
<dkayiwa> bwolfe: ok
|
14:17:57
|
<bwolfe> the tickets labeled with "curated" are ignored from those queries on the "curating tickets" dashboard
|
14:18:08
|
<dkayiwa> bwolfe: oh i see!!!
|
14:18:41
|
<dkayiwa> bwolfe: do you plan to remove the right handside table from that dashboard? :)
|
14:19:04
|
<dkayiwa> bwolfe: the one which has 715 tickets
|
14:20:13
|
<bwolfe> no! thats the backlog. as you can tell from how I labeled that search, its all tickets that are NOT in the "needs assessment" stage that are not curated yet.
|
14:20:36
|
<bwolfe> so it means that its an older ticket that may or may not have a good enough description on it to help out new developers
|
14:21:01
|
<bwolfe> dkayiwa, the top 10 tickets in the left box are xforms...any reason for that?
|
14:21:13
|
<bwolfe> top 14, actually. :-)
|
14:21:33
|
<dkayiwa> bwolfe: need curation. i had started with trunk tickets before going to modules :)
|
14:21:40
|
*** davidng has quit IRC
|
14:21:57
|
<bwolfe> whoa, 70-80 of them are reporting tickets! where is mseaton...
|
14:22:08
|
<dkayiwa> bwolfe: i noticed that too :)
|
14:22:30
|
<djazayeri> got an url for the curation dashboard?
|
14:22:42
|
<dkayiwa> https://tickets.openmrs.org/secure/Dashboard.jspa?selectPageId=11950
|
14:24:33
|
<djazayeri> bwolfe: did you create the curation dashboard?
|
14:24:46
|
<bwolfe> yes
|
14:24:54
|
<bwolfe> one might say I curated it
|
14:24:55
|
<djazayeri> bwolfe: I propose you modify the filter for the left side by adding "ORDER BY updated desc"
|
14:25:27
|
<djazayeri> bwolfe: (though if you prefer you could make that "ORDER BY created desc"
|
14:25:44
|
*** suranga has quit IRC
|
14:26:18
|
<djazayeri> dkayiwa: In the past, we used to treat TRUNK as being more important than modules. But going forwards we do not want to behave this way anymore.
|
14:26:44
|
<dkayiwa> djazayeri: oh i see!!!
|
14:26:45
|
<bwolfe> so newest ones first?
|
14:26:55
|
<bwolfe> FIFO queue? :-)
|
14:27:02
|
<bwolfe> err, LIFO
|
14:27:05
|
<djazayeri> dkayiwa: issues is bundled and/or strategic modules should be treated as being just as high priority as trunk. Yes, exactly.
|
14:27:23
|
<dkayiwa> djazayeri: oh i get it now :)
|
14:27:31
|
<djazayeri> bwolfe: I think so. That would mean that at least prospectively, things get curated quickly.
|
14:28:49
|
<djazayeri> bwolfe: certainly better than having that list sorted by "key desc". I could see the argument for created or updated, asc or desc. And as I said, I prefer updated desc.
|
14:29:47
|
<bwolfe> djazayeri, dkayiwa, updated to be order by created desc
|
14:29:50
|
*** nwilkie has joined #openmrs
|
14:29:57
|
<dkayiwa> bwolfe: ok thanks!!!
|
14:30:17
|
<bwolfe> djazayeri, updated desc just means last commented, right?
|
14:30:23
|
<djazayeri> bwolfe: yeah.
|
14:30:31
|
<bwolfe> or is updated date only changed when the description is changed?
|
14:30:50
|
<djazayeri> bwolfe: It includes comments. Basically it lets people "bump" tickets (though we won't tell them that.)
|
14:31:31
|
<bwolfe> hmm
|
14:31:52
|
<djazayeri> bwolfe: your call, I can see the argument for either including that, or ignoring it.
|
14:32:07
|
<djazayeri> bwolfe: but I'm thinking that "active discussion" should bump something to the top of the list.
|
14:32:12
|
<bwolfe> right
|
14:32:43
|
<bwolfe> updated date is set to created date intially, so new tickets will still be near the top.
|
14:33:20
|
<djazayeri> yup
|
14:34:11
|
<bwolfe> ok, change
|
14:34:36
|
<bwolfe> dkayiwa, wyclif, just go from top-down on the dashboard for curation. although you need to decide somehow who does what so you don't step on each others toes. :-)
|
14:34:51
|
<dkayiwa> bwolfe: hahahah :)
|
14:35:54
|
*** kavuri has quit IRC
|
14:36:10
|
<wyclif> we need to figure out how to avoid going over the same tickets'
|
14:38:25
|
<bwolfe> dkayiwa, can you review the tickets you've edited recently and make sure you are adding in all the things necessary?
|
14:38:36
|
<bwolfe> I am looking at https://tickets.openmrs.org/browse/TRUNK-3123, where you just marked it as ready for work without any new info
|
14:38:46
|
<dkayiwa> bwolfe: oh!!!!
|
14:38:56
|
<bwolfe> the points on this page say what you ened to add: https://wiki.openmrs.org/display/RES/Tickets+Curation+Swim+Lane
|
14:39:20
|
<dkayiwa> bwolfe: yes i read that. must have forgotten on only one or two tickets :)
|
14:39:20
|
<bwolfe> wyclif, how about you work on odd numbered tickets and dkayiwa works on even numbered ones? each of you start from the top of the list on the curation dashboard. :-)
|
14:39:49
|
<dkayiwa> bwolfe: how about dealing with module specific tickets? :)
|
14:39:52
|
<bwolfe> dkayiwa, ok, only one or two are fine. if I continue seeing more I will return here and complain. ;-)
|
14:40:05
|
<dkayiwa> bwolfe: hahahaha:)
|
14:40:22
|
<bwolfe> dkayiwa, that curation dashboard contains a list of all "core projects". there are 10 or 12 modules in that group, so yes, take care of those if you can
|
14:41:26
|
<dkayiwa> bwolfe: so for instance wyclif can deal with reporting module while i deal with metadatasharing/xforms, something like that :)
|
14:43:19
|
<wyclif> dkayiwa, curating module tickets i think might be trickier given that some modules we are not that familiar to them
|
14:44:19
|
<djazayeri> wyclif, dkayiwa, bwolfe: I agree with what wyclif just said. If there's a module ticket that you don't feel confident Assessing or Curating, it is better to leave it for the module owner than to do it wrong.
|
14:44:34
|
<dkayiwa> wyclif: you are very very correct!!!
|
14:46:43
|
<bwolfe> yes, skipping curating a ticket (whether its trunk, module, etc) is fine.
|
14:47:02
|
<bwolfe> wyclif, dkayiwa, I still prefer the "odd/even" splitting better than splitting on project. :-)
|
14:47:19
|
<djazayeri> does odd/even work, as tickets get removed from the list?
|
14:48:04
|
*** kavuri has joined #openmrs
|
14:48:24
|
<bwolfe> djazayeri, I meant the ticket id number. so XFRM-11 would be wyclif and TRUNK-3434 would be dkayiwa
|
14:48:30
|
<wyclif> dkayiwa, i think am fine with odd/even
|
14:48:32
|
<djazayeri> oh, I see.
|
14:48:34
|
<djazayeri> good idea
|
14:48:37
|
<wyclif> bwolfe, dkayiwa, i think am fine with odd/even
|
14:48:52
|
<dkayiwa> wyclif: ok
|
14:49:41
|
<bwolfe> seems about fair. the list right now is even, even, odd, odd, even, odd, even, even, odd
|
14:51:03
|
*** djazayeri has quit IRC
|
14:51:55
|
*** djazayeri has joined #openmrs
|
14:51:55
|
*** ChanServ sets mode: +o djazayeri
|
14:53:11
|
<wyclif> dkayiwa, so you are curating the even ones and i will curate the odd ones
|
14:53:29
|
*** nwilkie has quit IRC
|
14:53:30
|
<dkayiwa> wyclif: cool
|
14:55:57
|
*** nwilkie has joined #openmrs
|
14:57:00
|
*** jkeiper has quit IRC
|
15:02:22
|
*** lh has joined #openmrs
|
15:04:49
|
*** shortend has left #openmrs
|
15:05:11
|
*** maurya has joined #openmrs
|
15:10:18
|
*** nwilkie has quit IRC
|
15:18:02
|
*** nwilkie has joined #openmrs
|
15:19:10
|
*** nwilkie has quit IRC
|
15:19:11
|
*** maurya has quit IRC
|
15:19:35
|
*** maurya has joined #openmrs
|
15:22:50
|
<bwolfe> for https://tickets.openmrs.org/browse/TRUNK-3123, its helpful to copy things from comments to the ticket description. that way the dev doesn't need to read through all the comments to figure out what the decision was
|
15:22:55
|
<bwolfe> dkayiwa ^^
|
15:22:55
|
*** maurya has quit IRC
|
15:23:08
|
<bwolfe> dkayiwa, in this case, just copy my last comment up there
|
15:23:21
|
<dkayiwa> bwolfe: oh i see!!! Thanks for the tip :)
|
15:23:36
|
*** maurya has joined #openmrs
|
15:24:37
|
*** harshadura has quit IRC
|
15:31:15
|
*** nwilkie has joined #openmrs
|
15:31:53
|
*** jordank has joined #openmrs
|
15:37:18
|
*** wyclif has quit IRC
|
15:40:05
|
*** kavuri has quit IRC
|
15:40:36
|
*** wyclif has joined #openmrs
|
15:41:03
|
*** wyclif has quit IRC
|
15:41:16
|
*** wyclif has joined #openmrs
|
15:53:31
|
*** kavuri has joined #openmrs
|
16:08:48
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @lanyrdalert: Slides from "The OpenMRS experience" by @pbiondich @ekrub http://t.co/ElaJf7IJ #oscon <http://twitter.com/OpenMRS/statuses/227429695489208320> || On Twitter: OpenMRS: RT @ramaduro: Government of Dominica seeks OpenMRS consultant for national HIS rollout-see http://t.co/Qw3IQM0K <http://twitter.com/OpenMRS/statuses/227429054968631296> || On Twitter: OpenMRS: RT @Jelastic: Be healthy with #OpenMRS and Jelastic http://t.co/zYtadPhM #HealthIT ^MS <http://twitter.com/OpenMRS/statuses/227428769869217793>
|
16:10:17
|
*** pushkar_ has joined #openmrs
|
16:13:54
|
*** pushkar has quit IRC
|
16:15:56
|
*** mseaton has joined #openmrs
|
16:15:56
|
*** ChanServ sets mode: +v mseaton
|
16:28:39
|
*** cpower has quit IRC
|
16:32:01
|
*** cpower has joined #openmrs
|
16:40:41
|
*** jriley has left #openmrs
|
16:40:48
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @tonymi2: #openMRS is built as a API from the ground up. The possibilities for derivation are high. Outside of direct medical care ... <http://twitter.com/OpenMRS/statuses/227439728394399745>
|
16:41:00
|
*** rafa has quit IRC
|
17:07:49
|
*** cpower has quit IRC
|
17:10:55
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: @akollegger We're eager to talk more about ways to work together. Let us know when you want to talk in more detail. <http://twitter.com/OpenMRS/statuses/227441078838652928>
|
17:11:31
|
*** downey|tablet has joined #openmrs
|
17:11:38
|
<downey> Hi downey|tablet and welcome to the #openmrs IRC channel.
|
17:11:45
|
<dkayiwa> :D
|
17:11:56
|
<downey|tablet> Hey. :)
|
17:13:57
|
*** mccallumg has joined #openmrs
|
17:14:01
|
*** ChanServ sets mode: +v mccallumg
|
17:17:47
|
*** djazayeri1 has joined #openmrs
|
17:19:58
|
*** djazayeri has quit IRC
|
17:25:35
|
*** djazayeri has joined #openmrs
|
17:25:35
|
*** ChanServ sets mode: +o djazayeri
|
17:27:06
|
*** djazayeri1 has quit IRC
|
17:27:36
|
<jordank> does anyone know how I can tell by looking at the database how many obs there are for a concept_id?
|
17:30:34
|
<jordank> mccallumg^
|
17:31:00
|
<mccallumg> select count(*) from observations;
|
17:31:04
|
<mccallumg> jordank: ^
|
17:31:21
|
<mccallumg> jordank: where concept_id = 'xx'
|
17:31:22
|
<jordank> in the command line?
|
17:31:43
|
<mccallumg> jordank: or in your mysql client query pane
|
17:31:55
|
<mccallumg> jordank: connect directly to the database
|
17:34:41
|
<jordank> okay. it's still being kind of slow... how does the concept id fit into that sql command?
|
17:34:49
|
<jordank> mccallumg: ^
|
17:40:02
|
<mccallumg> select count(*) from obs where value_coded=1234;
|
17:40:06
|
<mccallumg> jordank: ^
|
17:40:51
|
<jordank> got it! thanks :)
|
17:41:10
|
*** jordank has quit IRC
|
17:41:38
|
*** jordank has joined #openmrs
|
17:47:22
|
*** jordank_ has joined #openmrs
|
17:49:41
|
*** jordank has quit IRC
|
17:49:42
|
*** jordank_ is now known as jordank
|
17:49:52
|
*** lakkarau has joined #openmrs
|
17:52:29
|
*** jriley has joined #openmrs
|
17:55:08
|
<lakkarau> bwolfe:hi
|
17:55:29
|
<lakkarau> bwolfe:sorry i missed the scrum meeting today.
|
17:57:08
|
<bwolfe> hi lakkarau
|
17:57:14
|
<bwolfe> lakkarau, can you give your update now?
|
17:58:25
|
<lakkarau> i have programatically added the file appender.but when i check for the log folder i dont find it.
|
17:59:24
|
<lakkarau> bwolfe:trying to figure out why ?
|
18:00:08
|
<bwolfe> lakkarau, remind me the ticket number?
|
18:00:14
|
*** mseaton has left #openmrs
|
18:00:46
|
<lakkarau> !TRUNK-3491
|
18:00:47
|
<OpenMRSBot> lakkarau: Error: "TRUNK-3491" is not a valid command.
|
18:01:10
|
<lakkarau> bwolfe:trunk-3491
|
18:01:17
|
<bwolfe> !ticket TRUNK-3491
|
18:01:18
|
<OpenMRSBot> bwolfe: [#TRUNK-3491] Write to independent log file - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3491
|
18:01:46
|
<bwolfe> lakkarau, are you "refreshing" the log4j somehow so it picks up the new appended?
|
18:01:49
|
<bwolfe> *appender?
|
18:02:02
|
<bwolfe> have you tried debugging and stepping through the code to see if/where/when it was added?
|
18:02:19
|
<bwolfe> surely there is some log4j documentation that would tell you a step by step of how to do it programatically
|
18:02:45
|
*** goutham has joined #openmrs
|
18:03:49
|
<lakkarau> bwolfe:yes,followed few docs.
|
18:04:31
|
<lakkarau> bwolfe:try {
|
18:04:31
|
<lakkarau> String logfile ="c:/logs/openmrs.log";
|
18:04:31
|
<lakkarau> PatternLayout layout = new PatternLayout("%p - %C{1}.%M(%L) |%d{ISO8601}| %m%n");
|
18:04:31
|
<lakkarau> FileAppender fileAppender = new FileAppender(layout, logfile);
|
18:04:31
|
<lakkarau> logger.addAppender(fileAppender);
|
18:04:32
|
<lakkarau> fileAppender.activateOptions();
|
18:04:34
|
<lakkarau>
|
18:04:36
|
<lakkarau> }
|
18:04:38
|
<lakkarau> catch (RuntimeException e) {
|
18:04:40
|
<lakkarau> log.error(e);
|
18:04:42
|
<lakkarau> }
|
18:04:44
|
<lakkarau> catch (IOException e) {
|
18:04:46
|
<lakkarau> log.error(e);
|
18:04:48
|
<lakkarau> }
|
18:05:07
|
<bwolfe> lakkarau, use pastebin.com for code snippets or any other large text displays
|
18:05:16
|
<lakkarau> bwolfe: sorry!
|
18:05:57
|
<lakkarau> bwolfe:i have hard soded the filename to check if that works
|
18:06:04
|
<bwolfe> where are you getting the logger?
|
18:06:09
|
<lakkarau> soded=coded
|
18:07:00
|
<lakkarau> bwolfe: trying to run the application again.(5-mins)
|
18:10:00
|
*** downey|tablet has quit IRC
|
18:12:30
|
<lakkarau> bwolfe:got it.i get the log file in the specified location.i think i forgor to refresh.
|
18:13:23
|
<lakkarau> bwolfe:but the size is zero.
|
18:13:38
|
<bwolfe> lakkarau, you have to do something to cause it ot log!
|
18:13:43
|
<bwolfe> go browse around the app
|
18:14:01
|
<bwolfe> and/or you didn't actually tell anything to log there.
|
18:19:26
|
*** djazayeri has quit IRC
|
18:19:44
|
*** djazayeri has joined #openmrs
|
18:19:44
|
*** ChanServ sets mode: +o djazayeri
|
18:20:33
|
<lakkarau> bwolfe :ok
|
18:20:37
|
*** lakkarau has quit IRC
|
18:22:06
|
*** jordank has quit IRC
|
18:24:40
|
*** jordank has joined #openmrs
|
18:24:42
|
*** djazayeri has quit IRC
|
18:34:15
|
*** jordank has quit IRC
|
18:36:06
|
*** djazayeri1 has joined #openmrs
|
18:53:14
|
*** mseaton has joined #openmrs
|
18:53:14
|
*** ChanServ sets mode: +v mseaton
|
18:54:57
|
*** mgielow has quit IRC
|
19:05:07
|
<kavuri> Anyone, what does this message mean?
|
19:05:08
|
<kavuri> WARN - AbstractReportsTask.authenticate(59) |2012-07-24 00:34:00,139| Not authenticating to avoid locking account. Please ensure you scheduler username and password are configured correctly in your global properties
|
19:05:30
|
<kavuri> I get this whenever I try to authenticate using REST call to /session resource
|
19:06:30
|
<djazayeri1> kavuri: that warning is not related to REST, it probably pops up every 5 minutes or so
|
19:06:35
|
<djazayeri1> or maybe more often
|
19:06:53
|
<kavuri> djazayeri1: ok, maybe just coincidence then
|
19:07:40
|
<djazayeri1> kavuri: if you want to stop that warning from happening, you need to set the global properties for scheduler.username and scheduler.password, to point to a user with pretty high authority
|
19:07:56
|
<kavuri> djazayeri1: ok
|
19:08:36
|
<kavuri> djazayeri1: do you know if there is any scenario that authentication fails (as in I get a json response for "authenticated":false, but I do not see a log message in catalina.out?
|
19:09:01
|
<djazayeri1> kavuri: on a call
|
19:09:28
|
<kavuri> djazayeri1: ok
|
19:16:11
|
*** dkayiwa has quit IRC
|
19:19:58
|
*** lakkarau has joined #openmrs
|
19:20:29
|
*** pushkar_ has quit IRC
|
19:24:21
|
<lakkarau> bwolfe:trunk-3671 what should i do at the lines specified.
|
19:27:13
|
<bwolfe> !ticket TRUNK-3671
|
19:27:16
|
<OpenMRSBot> bwolfe: Issue Does Not Exist - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3671
|
19:27:26
|
<bwolfe> lakkarau, ?
|
19:28:13
|
<lakkarau> bwolfe:Trunk-3617
|
19:28:45
|
<bwolfe> !ticket TRUNK-3617
|
19:28:46
|
<OpenMRSBot> bwolfe: [#TRUNK-3617] need to implement HibernateLocationDAO methods getLocationsByAttribute(Object searchLocation, LocationAttributeType lat) & getLocationByAttribute(Object searchLocation, LocationAttributeType lat) - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3617
|
19:29:06
|
<bwolfe> I was simply answering daniel's question right before my comment
|
19:29:36
|
<lakkarau> bwolfe:ok
|
19:31:36
|
*** jriley has quit IRC
|
19:49:17
|
*** goutham has quit IRC
|
19:50:40
|
*** dkayiwa has joined #openmrs
|
19:51:43
|
*** jordank has joined #openmrs
|
20:05:54
|
*** djazayeri1 has quit IRC
|
20:10:25
|
<dkayiwa> hi bwolfe
|
20:10:32
|
<bwolfe> hi
|
20:10:52
|
<dkayiwa> bwolfe: is the code you are referring to for TRUNK-3617 in svn ?
|
20:11:04
|
<dkayiwa> !ticket TRUNK-3617
|
20:11:05
|
<OpenMRSBot> dkayiwa: [#TRUNK-3617] need to implement HibernateLocationDAO methods getLocationsByAttribute(Object searchLocation, LocationAttributeType lat) & getLocationByAttribute(Object searchLocation, LocationAttributeType lat) - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3617
|
20:11:14
|
*** kavuri has quit IRC
|
20:12:37
|
<bwolfe> dkayiwa, yes. I am on rev:28641 control-shift-t. HibernateLocationDAO. scroll to bottom
|
20:12:41
|
<bwolfe> (latest trunk)
|
20:14:06
|
*** mseaton has left #openmrs
|
20:14:24
|
<dkayiwa> bwolfe: something could be wrong with my subclipse for am on rev:24899 for HibernateLocationDAO
|
20:15:41
|
<bwolfe> right click and update on it?
|
20:15:53
|
<bwolfe> do svn status on root, which repo are you pointing at?
|
20:15:55
|
<dkayiwa> bwolfe: i tried that and still same thing
|
20:16:07
|
*** maurya has quit IRC
|
20:16:08
|
<dkayiwa> ok
|
20:17:07
|
<dkayiwa> bwolfe: http://svn.openmrs.org/openmrs/trunk
|
20:17:19
|
*** jordank has quit IRC
|
20:18:14
|
<bwolfe> dkayiwa, strange
|
20:18:20
|
<dkayiwa> indeed
|
20:18:22
|
<bwolfe> why are you not able to update?
|
20:20:10
|
<dkayiwa> update /Users/danielkayiwa/Documents/openmrs/openmrs/api/src/main/java/org/openmrs/api/db/hibernate/HibernateLocationDAO.java -r HEAD --force
|
20:20:10
|
<dkayiwa> At revision 28641.
|
20:21:33
|
<bwolfe> ok
|
20:21:39
|
<bwolfe> right,
|
20:21:45
|
<bwolfe> pastebin your file
|
20:22:16
|
<dkayiwa> bwolfe: but show history on the file ends with: rev:24899
|
20:22:19
|
<dkayiwa> bwolfe: ok
|
20:23:11
|
<bwolfe> yes, same with mine
|
20:23:23
|
<bwolfe> but you don't see the TODO comments in the last two methods !?
|
20:23:58
|
<dkayiwa> bwolfe: no
|
20:24:08
|
<bwolfe> pastebin your HibernateLocationDAO file
|
20:24:18
|
<dkayiwa> bwolfe: ok
|
20:24:50
|
<bwolfe> dkayiwa, oh wait. looks like I have a change on that file. must have been in a patch file that lakkarau gave me at some point
|
20:24:53
|
<bwolfe> my fault
|
20:25:07
|
<bwolfe> I will update the ticket comments
|
20:25:09
|
<dkayiwa> bwolfe: oh i see
|
20:39:54
|
<lakkarau> bwolfe:dkayiwa:is there any corrections i have to make to the ticket Trunk -3617.
|
20:41:54
|
<dkayiwa> lakkarau: i guess bwolfe is going to make a comment on it :)
|
20:42:01
|
<bwolfe> already commented
|
20:42:08
|
<dkayiwa> hahahah
|
20:43:22
|
<lakkarau> dkayiwa:first ticket i created ,may be there is some mistake.please ignore.
|
20:48:47
|
*** rafa has joined #openmrs
|
20:48:47
|
*** ChanServ sets mode: +v rafa
|
20:58:49
|
<bwolfe> dkayiwa, TRUNK-2062
|
20:58:52
|
<bwolfe> https://tickets.openmrs.org/browse/TRUNK-2062
|
20:59:59
|
<dkayiwa> :O
|
21:02:04
|
<bwolfe> and https://tickets.openmrs.org/browse/TRUNK-3256, you marked curated before making a full description of what needs to happen
|
21:02:14
|
<dkayiwa> ok
|
21:02:25
|
<bwolfe> I will do that now, since you stated that you werne't sure how to
|
21:02:34
|
<dkayiwa> ok
|
21:02:35
|
<bwolfe> but if you don't know how to, don't mark it as ready for work and curated. :-)
|
21:02:48
|
<dkayiwa> bwolfe: ok :)
|
21:03:16
|
<bwolfe> actually, I'm going to close in in favor of using something else entirely
|
21:03:31
|
<dkayiwa> :O
|
21:12:25
|
*** rafa has quit IRC
|
21:13:07
|
*** jordank has joined #openmrs
|
21:13:24
|
*** mccallumg has quit IRC
|
21:13:37
|
*** wyclif has quit IRC
|
21:15:58
|
*** djazayeri has joined #openmrs
|
21:15:58
|
*** ChanServ sets mode: +o djazayeri
|
21:16:20
|
*** lakkarau has quit IRC
|
21:26:53
|
<djazayeri> bwolfe: btw, who is doing the "how to use git properly" university session this week?
|
21:27:35
|
<bwolfe> djazayeri, I hope its Mark. or someone that has actually used git for more than 5 mins. :-)
|
21:27:47
|
<bwolfe> if you can get someone outside the main players, all the better
|
21:27:53
|
<bwolfe> (see if kishore can recommend someone)
|
21:28:20
|
<djazayeri> bwolfe: Is the specifically around module development, trunk development, or what?
|
21:28:27
|
<djazayeri> bwolfe: will we have wiki pages documenting this?
|
21:28:36
|
<djazayeri> bwolfe: will trunk be changed over by then?
|
21:31:32
|
<bwolfe> I turned conversion of trunk over to kishore last week because he had some magic skills ot do it. then he started hitting the same issues I had. I asked today and he said within a few days, so yes, hopefully it is done by then.
|
21:31:47
|
<bwolfe> let me reply to him cc'ing you saying we'd prefer its done by wednesday...
|
21:33:42
|
<bwolfe> bbl
|
21:39:44
|
*** lakkarau has joined #openmrs
|
21:43:13
|
*** dkayiwa has quit IRC
|
21:56:02
|
*** downey has quit IRC
|
22:22:02
|
*** jordank has quit IRC
|
22:33:31
|
*** jordank has joined #openmrs
|
22:39:34
|
*** nwilkie has quit IRC
|
23:06:31
|
*** lakkarau has quit IRC
|
23:39:00
|
*** wyclif has joined #openmrs
|