IRC Chat : 2012-07-22 - OpenMRS

01:59:21 *** harshadura has joined #openmrs
02:04:12 *** harshadura has quit IRC
02:48:16 *** rfriedman has joined #openmrs
03:03:57 *** r0bby is now known as robbyoconnor
04:25:45 *** Echidna has quit IRC
05:03:38 *** mgielow has joined #openmrs
05:33:24 *** djazayeri has quit IRC
05:33:25 *** wyclif has quit IRC
05:33:27 *** Mkop has quit IRC
05:36:56 *** robbyoconnor has quit IRC
05:38:07 *** robbyoconnor has joined #openmrs
05:38:07 *** ChanServ sets mode: +v robbyoconnor
05:41:04 *** Mkop has joined #openmrs
05:41:04 *** zelazny.freenode.net sets mode: +v Mkop
05:41:20 *** djazayeri has joined #openmrs
05:41:20 *** zelazny.freenode.net sets mode: +o djazayeri
05:42:30 *** wyclif has joined #openmrs
05:45:32 *** robbyoconnor has quit IRC
05:49:44 *** robbyoconnor has joined #openmrs
05:49:44 *** ChanServ sets mode: +v robbyoconnor
06:05:08 *** kavuri has joined #openmrs
06:25:39 *** kavuri has quit IRC
06:39:06 *** kavuri has joined #openmrs
07:41:05 *** dkayiwa has joined #openmrs
07:48:43 *** robbyoconnor has quit IRC
07:56:02 *** robbyoconnor has joined #openmrs
07:56:02 *** ChanServ sets mode: +v robbyoconnor
08:15:15 *** maurya has joined #openmrs
09:28:53 *** dkayiwa has quit IRC
09:30:37 *** harshadura has joined #openmrs
10:57:05 *** harshadura has quit IRC
11:06:03 *** harshadura has joined #openmrs
13:29:09 *** kavuri has quit IRC
13:34:44 <harshadura> hi rfriedman
13:55:02 *** pushkar has joined #openmrs
13:56:56 *** harshadura has quit IRC
14:22:16 *** harshadura has joined #openmrs
14:37:37 *** harshadura has quit IRC
14:50:49 *** pushkar has quit IRC
15:18:14 *** mgielow has quit IRC
15:26:38 *** mgielow has joined #openmrs
15:54:21 *** emilyp has joined #openmrs
15:54:31 *** emilyp has left #openmrs
16:01:52 *** pulasthi7 has joined #openmrs
16:10:03 *** pushkar has joined #openmrs
17:10:08 *** suranga has joined #openmrs
17:10:08 *** ChanServ sets mode: +v suranga
17:22:17 *** dkayiwa has joined #openmrs
17:49:05 *** goutham has joined #openmrs
17:52:24 *** kavuri has joined #openmrs
18:03:07 *** ponjey has joined #openmrs
18:16:18 *** harshadura has joined #openmrs
18:17:17 <harshadura> hi suranga ayya
18:17:49 <harshadura> hi dkayiwa
18:18:18 <dkayiwa> hi harshadura
18:18:45 <harshadura> dkayiwa, sorry for bothering, can i get a min to ask some programming question ?
18:19:47 <harshadura> dkayiwa, can you guide me how to map forein key involving table with liquibase and hibernate ?
18:21:40 <dkayiwa> harshadura: have you looked at the existing liquibase files for the core openmrs?
18:21:53 <harshadura> yes dkayiwa
18:22:21 *** harshadura_ has joined #openmrs
18:23:11 <dkayiwa> harshadura: did you see anything like that
18:25:29 *** kavuri has quit IRC
18:25:34 <harshadura> dkayiwa, I didn found exact one like that
18:26:16 <dkayiwa> harshadura: can you pastebin your liquibase file for me to look at and advise you?
18:26:29 <harshadura> ok dkayiwa, thanks
18:33:41 <harshadura> dkayiwa, here is the thing i want to map > http://imagebin.org/221742
18:34:19 <harshadura> the code currently I hv written in liquibase (its not correct i guess) > http://pastebin.com/yD9s46r7
18:34:50 <harshadura> current hibernate code : http://pastebin.com/dGuuujbV
18:34:54 <dkayiwa> harshadura: ok
18:39:09 <harshadura> dkayiwa, can u tell me how to do this ..
18:53:55 *** rafa has joined #openmrs
18:54:03 *** ChanServ sets mode: +v rafa
18:54:20 <dkayiwa> harshadura: sorry was on phone
18:54:22 <dkayiwa> now on it :)
18:54:55 <harshadura> thanks dkayiwa
19:04:16 <goutham> hi dkayiwa
19:06:53 <dkayiwa> hi goutham
19:07:17 <dkayiwa> so harshadura which column is the foreign key and for which table
19:07:33 <goutham> dkayiwa: Howz every thing ?
19:07:53 <dkayiwa> goutham: not bad and yours?
19:08:23 <goutham> dkayiwa: very good :)
19:08:30 <goutham> dkayiwa: i prepared documentation for form filter module https://wiki.openmrs.org/display/projects/FormFilter+Module-Documentation
19:08:42 <dkayiwa> goutham: looking at it.....
19:08:47 <harshadura> dkayiwa, feedback_id is the foreign key for Feedback_UserAccess Table, and Feedback_id is the primary key for Feedback_Feedback Table
19:10:09 <dkayiwa> harshadura: have you ever seen a file named: liquibase-update-to-latest.xml
19:10:51 <dkayiwa> harshadura: and seen something like: addForeignKeyConstraint
19:10:53 <harshadura> yes dkayiwa
19:11:30 <dkayiwa> harshadura: have you tried to just copy any of that and simply replace with your table and column names?
19:12:14 <dkayiwa> goutham: can we separate user and developer documentation? :)
19:12:34 <dkayiwa> goutham: like we do it for other modules?
19:12:50 <goutham> dkayiwa: https://wiki.openmrs.org/display/projects/Using+Form+Filter+Module is user documentation
19:13:13 <goutham> dkayiwa: https://wiki.openmrs.org/display/projects/FormFilter+Module-Documentation is developer documentation
19:13:40 <dkayiwa> goutham: in the first link, i see user interface screenshots and code
19:15:06 <goutham> dkayiwa: In FormFilter+Module-Documentation ?
19:15:57 <dkayiwa> goutham: looking....
19:16:10 *** harshadura_ has joined #openmrs
19:17:21 <dkayiwa> let me be back shortly
19:17:40 <goutham> dkayiwa: ok
19:24:10 *** ponjey has quit IRC
19:24:19 *** nwilkie has joined #openmrs
19:34:05 *** rafa has quit IRC
19:51:35 *** dkayiwa has quit IRC
20:02:32 *** dkayiwa has joined #openmrs
20:03:41 <dkayiwa> hi goutham
20:04:20 <goutham> dkayiwa: Hi :)
20:04:47 * goutham thinks where were we
20:05:27 <goutham> dkayiwa: Aah FormFilter Module documentation has Interface code and screen shots.
20:06:01 <dkayiwa> goutham: oh yeah :0
20:06:03 <dkayiwa> :)
20:07:12 <goutham> dkayiwa: FormFilter Module Documentation is developer documentation
20:07:22 <dkayiwa> goutham: ok
20:07:52 <goutham> dkayiwa: Using Form Filter Module is user documentation :)
20:08:15 <dkayiwa> goutham: I do not seem to see unit tests for all filter types
20:08:42 <dkayiwa> goutham: oh sorry
20:08:49 *** harshadura__ has joined #openmrs
20:08:53 *** harshadura has quit IRC
20:08:55 <dkayiwa> goutham: eclipse was slow at loading files :)
20:09:32 *** harshadura_ has quit IRC
20:09:41 <goutham> dkayiwa: for a minute my mind got slowed down :)
20:09:48 *** harshadura__ is now known as harshadura
20:09:53 <dkayiwa> goutham: :D
20:10:42 <dkayiwa> goutham: can you rename in CohortFormFilterTest?
20:10:52 <dkayiwa> goutham: rename from genderFormFilter
20:11:04 <dkayiwa> goutham: can you also apply the openmrs formatter to all the code
20:12:06 <dkayiwa> goutham: can you also add the @should on the methods being tested?
20:14:18 <goutham> dkayiwa: how do i apply openmrs formatter to code.. will ctrl+shift+f do the work?
20:14:39 <dkayiwa> goutham: try it out
20:15:22 <goutham> dkayiwa: Noted all the points :)
20:16:14 <dkayiwa> goutham: you can get the openmrs code formatter from: https://wiki.openmrs.org/display/docs/Developer+How-To+Use+Eclipse+Guide
20:16:27 <dkayiwa> goutham: at the bottom of that link
20:18:40 <goutham> dkayiwa: thanks :)
20:18:44 <dkayiwa> goutham: after that, you commit and then i continue with the review
20:19:22 *** pushkar has quit IRC
20:19:50 <dkayiwa> goutham: am feeling sleep. we can continue from here tomorrow :)
20:20:11 <goutham> dkayiwa: Ok good night :)
20:20:18 <dkayiwa> goutham: thanks :)
20:20:51 *** dkayiwa has quit IRC
20:26:07 *** maurya has quit IRC
20:58:20 *** goutham has quit IRC
21:03:17 *** pulasthi7 has quit IRC
21:24:25 *** nwilkie has quit IRC
21:30:14 *** nwilkie has joined #openmrs
21:32:46 *** nwilkie has quit IRC
21:48:13 *** harshadura has quit IRC
21:56:41 *** nwilkie has joined #openmrs
22:17:13 *** mgielow has quit IRC
22:19:47 *** suranga has quit IRC
23:54:57 *** rfriedman has quit IRC