| 00:59:24 | *** mseaton has joined #openmrs |
| 00:59:24 | *** ChanServ sets mode: +v mseaton |
| 00:59:31 | *** mseaton has left #openmrs |
| 01:11:47 | *** dkayiwa has joined #openmrs |
| 01:13:24 | *** jordank has joined #openmrs |
| 02:02:18 | *** djazayeri has joined #openmrs |
| 02:02:18 | *** ChanServ sets mode: +o djazayeri |
| 02:43:12 | *** suranga has joined #openmrs |
| 02:43:13 | *** ChanServ sets mode: +v suranga |
| 02:47:27 | <suranga> howdy bwolfe |
| 02:47:37 | <suranga> bwolfe, sorry, I seem to have fallen asleep last night :P |
| 02:48:37 | *** Guest64331 has joined #openmrs |
| 02:48:49 | *** jordank has quit IRC |
| 02:49:35 | *** Guest64331 has quit IRC |
| 02:49:47 | *** Guest64331 has joined #openmrs |
| 03:01:54 | *** mseaton has joined #openmrs |
| 03:01:54 | *** ChanServ sets mode: +v mseaton |
| 03:01:59 | *** mseaton has left #openmrs |
| 03:06:32 | *** upul` has joined #openmrs |
| 03:06:32 | *** ChanServ sets mode: +v upul` |
| 03:10:55 | *** dkayiwa has quit IRC |
| 03:14:49 | *** wyclif has quit IRC |
| 04:11:36 | *** jordank has joined #openmrs |
| 04:53:54 | *** kishoreyekkanti has joined #openmrs |
| 04:54:35 | *** kishoreyekkanti has joined #openmrs |
| 04:55:23 | *** kreddy has quit IRC |
| 05:08:54 | *** jordank has quit IRC |
| 05:16:30 | *** kishoreyekkanti has quit IRC |
| 05:17:06 | *** kishoreyekkanti has joined #openmrs |
| 05:53:37 | *** wyclif has joined #openmrs |
| 05:56:57 | *** djazayeri has quit IRC |
| 05:59:55 | *** downey has joined #openmrs |
| 05:59:55 | *** ChanServ sets mode: +o downey |
| 05:59:55 | *** OpenMRSBot sets mode: +o downey |
| 06:09:41 | *** dkayiwa has joined #openmrs |
| 06:10:15 | *** downey has quit IRC |
| 06:21:43 | *** upul` has quit IRC |
| 06:28:43 | *** maro has joined #openmrs |
| 06:30:39 | *** dkayiwa has quit IRC |
| 07:02:17 | *** shortend has joined #openmrs |
| 07:47:59 | *** snoppy has joined #openmrs |
| 08:24:21 | *** snoppy has left #openmrs |
| 08:24:38 | *** rafa has joined #openmrs |
| 08:24:38 | *** ChanServ sets mode: +v rafa |
| 08:33:05 | *** dkayiwa has joined #openmrs |
| 08:59:14 | *** kishoreyekkanti has quit IRC |
| 09:02:26 | *** kishoreyekkanti has joined #openmrs |
| 09:05:01 | <dkayiwa> hi bwolfe |
| 09:27:18 | *** shortend has quit IRC |
| 09:48:39 | *** snoppy has joined #openmrs |
| 09:50:13 | <suranga> dkayiwa, i think its too early for bwolfe , isnt it ? :) |
| 09:50:20 | <dkayiwa> :D |
| 10:14:27 | *** maurya has joined #openmrs |
| 10:14:58 | <maurya> /msg NickServ identify harshamybro |
| 10:15:15 | <dkayiwa> :D |
| 10:15:53 | *** ChanServ sets mode: +v maurya |
| 11:00:19 | *** pushkar has joined #openmrs |
| 11:05:21 | *** shortend has joined #openmrs |
| 11:08:35 | *** maurya has quit IRC |
| 11:15:19 | *** shortend has left #openmrs |
| 11:17:14 | *** shortend has joined #openmrs |
| 11:20:22 | *** mseaton has joined #openmrs |
| 11:20:22 | *** ChanServ sets mode: +v mseaton |
| 11:20:27 | *** mseaton has left #openmrs |
| 11:33:05 | *** pushkar_ has joined #openmrs |
| 11:35:03 | *** mseaton has joined #openmrs |
| 11:35:03 | *** ChanServ sets mode: +v mseaton |
| 11:35:13 | *** mseaton has left #openmrs |
| 11:35:53 | *** pushkar has quit IRC |
| 11:49:01 | *** dkayiwa has quit IRC |
| 11:49:53 | *** dkayiwa has joined #openmrs |
| 12:08:15 | *** kishoreyekkanti_ has joined #openmrs |
| 12:10:20 | *** kishoreyekkanti has quit IRC |
| 12:12:42 | <bwolfe> dkayiwa, good work going through tickets. |
| 12:13:15 | <bwolfe> dkayiwa, but don't put the "curated" label on there until all the criteria are met and its really totally "done" and fully setup. See https://wiki.openmrs.org/display/RES/Tickets+Curation+Swim+Lane |
| 12:14:02 | <dkayiwa> bwolfe: oh i though if i make a ticket ready for work then i should put curated? :) |
| 12:14:18 | <bwolfe> as long as you also answer all the other things on the ticket |
| 12:14:28 | <bwolfe> hours, etc |
| 12:14:55 | <dkayiwa> bwolfe: yes that is what i though i was doing. do you have any ticket you know that i put curated without all of it done? :) |
| 12:15:23 | <bwolfe> the one I just commented on didn't have any hours estimate on it. and it wasn't even ready for work yet. |
| 12:15:26 | <bwolfe> but it was "curated" |
| 12:15:39 | <bwolfe> !ticket TRUNK-3294 |
| 12:15:40 | <OpenMRSBot> bwolfe: [#TRUNK-3294] Add additional error checking when adding a regimen on the patient dashboard - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3294 |
| 12:15:50 | <dkayiwa> bwolfe: then it was not me who curated it :) |
| 12:15:58 | <bwolfe> ok |
| 12:16:03 | <bwolfe> well, carry on then! :-) |
| 12:16:10 | <dkayiwa> JIRA says it is you :D |
| 12:16:45 | <bwolfe> yes, I don't see it in the history. but the label was there when I started editing. maybe I put it there and forgot. :-/ |
| 12:16:54 | <bwolfe> *sigh* it will be a looong day if I'm already forgetting things... |
| 12:16:59 | <dkayiwa> bwolfe: probably :) |
| 12:17:24 | *** mseaton has joined #openmrs |
| 12:17:24 | *** ChanServ sets mode: +v mseaton |
| 12:17:25 | *** mseaton has left #openmrs |
| 12:17:52 | *** shortend has quit IRC |
| 12:23:02 | <bwolfe> kishoreyekkanti_, do I remember right? did you import openmrs to github? |
| 12:30:17 | <dkayiwa> bwolfe: there are some tickets for which i also have no solution. Or for which looking for one would take me as long as doing the ticket myself. :) Does curating require only those tickets where i can propose a solution? I guess no :) |
| 12:31:02 | <bwolfe> you don't have to propose the solution, just point the developer in that direction |
| 12:31:39 | <bwolfe> dkayiwa, can you update the desc of https://tickets.openmrs.org/browse/TRUNK-3280 to be explictly what GP and what page should be fixed? |
| 12:31:46 | <dkayiwa> bwolfe: is proposing a solution different from pointing a developer in that dirrection? :) |
| 12:31:53 | <bwolfe> also, the title is a little be long on that one |
| 12:31:59 | <dkayiwa> bwolfe: ok |
| 12:32:19 | <bwolfe> dkayiwa, yes, you can say: "Look in class X for the methods" or "this starts on page __.jsp" |
| 12:32:50 | <dkayiwa> bwolfe: ok |
| 12:52:13 | <suranga> hi bwolfe |
| 12:52:24 | <suranga> bwolfe, I seem to have fallen asleep yesterday :( |
| 12:52:59 | *** bwolfe has quit IRC |
| 12:53:03 | <suranga> bwolfe, i filled in an online form for Michael (to create the new project on JIRA), I guess he is too busy at OSCON :-) |
| 12:53:10 | *** bwolfe has joined #openmrs |
| 12:53:10 | *** ChanServ sets mode: +o bwolfe |
| 12:56:13 | <suranga> hi bwolfe |
| 12:56:24 | <suranga> bwolfe, (re posting in case u missed it...) |
| 12:56:28 | <suranga> <suranga> hi bwolfe |
| 12:56:28 | <suranga> <suranga> bwolfe, I seem to have fallen asleep yesterday :( |
| 12:56:36 | <suranga> bwolfe, i filled in an online form for Michael (to create the new project on JIRA), I guess he is too busy at OSCON :-) |
| 12:56:39 | <bwolfe> sleep is allowed |
| 12:57:40 | <suranga> bwolfe, not when its over your laptop, and your parents discover you at 4 am with all the lights on and cold tea everywhere :P |
| 12:58:01 | <suranga> bwolfe, luckly my laptop is safe :D |
| 12:59:42 | <bwolfe> haha, perhaps you should go to bed sooner tonight. :-) |
| 13:00:15 | <suranga> bwolfe, im mildly insomniac myself |
| 13:02:10 | *** chopin has joined #openmrs |
| 13:06:25 | <kishoreyekkanti_> bwolfe: Hey ben, you were asking whether the codebase of openmrs is there in github some where |
| 13:06:56 | *** chopin has quit IRC |
| 13:07:18 | <bwolfe> kishoreyekkanti_, I know its in github in a few placs |
| 13:07:56 | <bwolfe> but I am asking because I'm using svn2git on trunk now and getting "error: Untracked working tree file '.settings/org.eclipse.jdt.core.prefs' would be overwritten by merge. |
| 13:07:57 | <bwolfe> read-tree -m -u -v HEAD HEAD: command returned error: 128 |
| 13:07:57 | <bwolfe> command failed: |
| 13:07:57 | <bwolfe> 2>&1 git svn fetch" |
| 13:12:04 | *** robbyoconnor has quit IRC |
| 13:12:48 | *** robbyoconnor has joined #openmrs |
| 13:12:48 | *** ChanServ sets mode: +v robbyoconnor |
| 13:14:56 | <bwolfe> kishoreyekkanti ^^ |
| 13:15:38 | *** mseaton has joined #openmrs |
| 13:15:38 | *** ChanServ sets mode: +v mseaton |
| 13:17:01 | *** robbyoconnor has quit IRC |
| 13:20:05 | *** kishoreyekkanti_ has quit IRC |
| 13:21:05 | *** kishoreyekkanti has joined #openmrs |
| 13:21:45 | *** kishoreyekkanti has joined #openmrs |
| 13:22:44 | <kishoreyekkanti> bwolfe: hey sorry was in a call! You mean you are trying to port svn openmrs trunk to some other place using git? |
| 13:25:01 | *** nimanthab has joined #openmrs |
| 13:25:01 | <bwolfe> kishoreyekkanti, we are migrating to using github instead of svn |
| 13:25:14 | *** jkeiper has joined #openmrs |
| 13:25:16 | <bwolfe> kishoreyekkanti, and I am using svn2git to prep and then upload it |
| 13:25:28 | *** mseaton has quit IRC |
| 13:26:03 | *** jkeiper has quit IRC |
| 13:26:08 | <kishoreyekkanti> bwolfe: do we really need to have .settings to be there in github? |
| 13:26:28 | *** jkeiper has joined #openmrs |
| 13:26:42 | *** ChanServ sets mode: +v jkeiper |
| 13:26:43 | *** mseaton has joined #openmrs |
| 13:26:43 | *** ChanServ sets mode: +v mseaton |
| 13:26:51 | *** jkeiper has quit IRC |
| 13:27:19 | *** jkeiper has joined #openmrs |
| 13:27:21 | <kishoreyekkanti> bwolfe: And can you ping me the exact command you are using. |
| 13:28:16 | <jkeiper> hi nimanthab (again) |
| 13:28:29 | <nimanthab> hi jkeiper |
| 13:32:14 | *** jkeiper_ has joined #openmrs |
| 13:32:34 | *** jkeiper has quit IRC |
| 13:35:16 | <bwolfe> kishoreyekkanti, I put the authors.txt in my global settings, then just used svn2git https://svn.openmrs.org/openmrs/trunk |
| 13:35:30 | <bwolfe> kishoreyekkanti, no, we don't need .settings. how can I ignore that? |
| 13:35:46 | *** djazayeri has joined #openmrs |
| 13:35:46 | *** ChanServ sets mode: +o djazayeri |
| 13:36:25 | *** jkeiper_ has quit IRC |
| 13:36:48 | <kishoreyekkanti> bwolfe: use --exclude flag and the file name. I guess you might have already looked at the docs here https://github.com/nirvdrum/svn2git |
| 13:37:57 | <kishoreyekkanti> bwolfe: One thing we need to be aware of is the standard layout of svn. Normaly svn standard layout consists of trunk and tags at the same level |
| 13:39:33 | <bwolfe> kishoreyekkanti, it does exist at the same level in the latest... |
| 13:39:54 | <kishoreyekkanti> bwolfe: Ok then i think that should work |
| 13:40:38 | <bwolfe> kishoreyekkanti, yes, have seen the svn2git doc, but didn't know if there was another way around the error. if I just exclude, hopefully there are not a ton of them! |
| 13:40:54 | <bwolfe> kishoreyekkanti, any reason I shouldn't just exclude all jars too ? |
| 13:41:34 | <kishoreyekkanti> bwolfe: Unless all of those dependencies are already established by maven. I don't have any reason why we need to upload the jar files |
| 13:42:33 | <bwolfe> kishoreyekkanti, we've deleted all jar files in trunk (or should have) so its just the history. no problems leaving it out of the history? |
| 13:43:10 | <kishoreyekkanti> bwolfe: yes, that should not be a problem |
| 13:43:18 | *** maro has joined #openmrs |
| 13:44:38 | * bwolfe tries again |
| 13:45:14 | *** jkeiper_ has joined #openmrs |
| 13:45:39 | <kishoreyekkanti> bwolfe: You know why the error TimerSchedulerServiceImpl.getTaskByName(379) |2012-07-17 03:12:20,176| getTaskByName(Initialize Logic Rule Providers) failed comes when ever openers restarts? |
| 13:47:17 | <kishoreyekkanti> bwolfe: I'm basically looking out for all the stack traces in the log and here's https://ci.openmrs.org/download/FUNC-APPTEST-JOB1/build_logs/FUNC-APPTEST-JOB1-84.log the error which i can see which throws the stack trace for one of those tasks |
| 13:49:37 | <bwolfe> kishoreyekkanti, dunno, perhaps its shutting down out of order? |
| 13:49:47 | <bwolfe> would be nice to know which task is causing that |
| 13:50:03 | <kishoreyekkanti> bwolfe: Initialize Logic Rule Providers |
| 13:50:45 | <jkeiper_> bwolfe, nimanthab and i are wondering how best to wrap a patient dashboard extension so that we can call the controller as needed to render that tab ... would it be best to customize the patient dashboard tab extension point controller and keep it all in java (with DWR access to generate it like nimanthab already has for our core tabs)? |
| 13:51:58 | *** shortend has joined #openmrs |
| 13:52:13 | *** jriley has joined #openmrs |
| 13:53:22 | <dkayiwa> hi jriley |
| 13:53:29 | <jriley> Good morning |
| 13:53:42 | <dkayiwa> jriley: Good morning to you :) |
| 13:53:47 | *** lakkarau has joined #openmrs |
| 13:53:49 | <dkayiwa> jriley: how have you been of late? |
| 13:54:05 | *** jkeiper_ is now known as jkeiper |
| 13:54:10 | *** ChanServ sets mode: +v jkeiper |
| 13:54:18 | <jriley> dkayiwa, are you the official greeter while mdowney is at OSCON? |
| 13:54:36 | <bwolfe> jkeiper, nimanthab, I don't understand the question. what is he end goal here? |
| 13:54:50 | <dkayiwa> jriley: hahahahha. And if you notice, i mostly greet ladies. Since you seem to be the only lady in the room now :D |
| 13:55:10 | <jkeiper> bwolfe, dynamic (AJAX) loading of patient dashboard tabs (including those injected by extension point) |
| 13:55:16 | <jriley> dkayiwa, pretty good. I'm visiting my parents for a few days. They're near the ocean, so it's cooler down here. |
| 13:55:36 | <dkayiwa> jriley: oh that must be lots of fun!!! :) |
| 13:55:50 | <nimanthab> its like this bwolfe. I have successfully implemented ajax loading capabilities for the core tabs in the dashboard. Now we are wondering how we can extend the dynamic loading capabilities for the tabs added by modules using the extension point in the dashboard... |
| 13:56:34 | <jriley> dkayiwa, yes, but some work too. I've already scrubbed the moss and lichen off the shed roof this morning. GOOD TIMES! |
| 13:56:54 | <jriley> But I suppose that's a fair trade for mom not strangling me when I was a kid. She's very patient, and I was very trying. |
| 13:56:56 | <dkayiwa> jriley: hahahaha :D I wish i was there to help :) |
| 13:56:59 | <nimanthab> The core tab content can be now loaded in the background or else loaded on demand when the user clicks the tab header. We would like to give the same features to the tabs which some modules add to the dashboard |
| 13:57:33 | <bwolfe> nimanthab, ok. is it not possible to just wrap that ext point with html on the dashboard? you can change what is in and around the ext point tag on the dashboard |
| 13:57:36 | <dkayiwa> jriley: oh i see!!! fair enough. :) |
| 13:58:01 | <jkeiper> bwolfe, the point is that the extension point would still be rendered ... defeating the purpose |
| 13:58:13 | *** cpower has joined #openmrs |
| 13:58:25 | <cpower> Hello! |
| 13:58:31 | *** shortend has quit IRC |
| 13:58:33 | <jkeiper> HIHOWAREYOU |
| 13:58:34 | <jriley> Good morning, cpower! |
| 13:58:44 | <bwolfe> yo |
| 13:59:11 | <bwolfe> kishoreyekkanti, something to ponder while we scrum: openmrs/trunk/lib/neal-reporting/reports.jar was not found in commit 41d1491fe4ce88ebfeaf0c5e187905a8bac0114e (r1769) |
| 13:59:11 | <bwolfe> command failed: |
| 13:59:11 | <bwolfe> 2>&1 git svn fetch '--ignore-paths=^(?:trunk[/]|tags[/][^/]+[/]|branches[/][^/]+[/])(?:.settings|.*.jar) |
| 13:59:28 | <bwolfe> kishoreyekkanti, why is it failing on reports.jar when I told it to skip .*.jar ?? :-( |
| 14:01:00 | <cpower> I'm great, I ran 2 miles this morning, had some sugar filled donut holes with rasberry filling, drinking a "healthy" energy drink so I'm a bit wired and patiently waiting for Thursday night to see the new batman movie |
| 14:01:25 | <kishoreyekkanti> bwolfe: hmm.. looks wierd |
| 14:01:41 | <cpower> and it's my favorite time of day, the Daily Scrum |
| 14:01:56 | <cpower> So let's get to it |
| 14:02:05 | <cpower> !scrumon cpower |
| 14:02:05 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 14:03:01 | <cpower> Order: bwolfe, wyclif, djazayeri, lakkarau, dkayiwa, rafa, suranga, jkeiper...did I miss anyone? |
| 14:03:38 | *** wyclif has quit IRC |
| 14:03:50 | <bwolfe> ok, back, sorry, doorbell rang |
| 14:03:59 | *** wyclif has joined #openmrs |
| 14:04:09 | <cpower> Good timing your up Wolfe |
| 14:04:21 | <jkeiper> bwolfe, sorry that was me |
| 14:04:26 | <bwolfe> Monday |
| 14:04:27 | <bwolfe> emails |
| 14:04:27 | <bwolfe> discuss sprint with suranga |
| 14:04:27 | <bwolfe> help kishore with func testing |
| 14:04:27 | <bwolfe> triaged 1 ticket |
| 14:04:27 | <bwolfe> reviewed permissions module for Ashley |
| 14:04:29 | <bwolfe> curate some tickets |
| 14:04:31 | <bwolfe> set up github migration tickets |
| 14:04:33 | <bwolfe> Tuesday |
| 14:04:35 | <bwolfe> trunk github migration work |
| 14:04:37 | <bwolfe> emails |
| 14:04:37 | *** pushkar__ has joined #openmrs |
| 14:04:39 | <bwolfe> curated a handful of tickets |
| 14:04:41 | <bwolfe> more curation |
| 14:04:43 | <bwolfe> more githubbing |
| 14:05:01 | <bwolfe> wyclif, you're up |
| 14:05:02 | <cpower> don't just try B "the" Wolfe |
| 14:05:13 | <cpower> I take it no blockers |
| 14:05:40 | <wyclif> Monday: |
| 14:05:40 | <wyclif> Curating tickets |
| 14:05:40 | <wyclif> worked on TRUNK-3604 - Migrate basicmodule to github |
| 14:05:40 | <wyclif> Tuesday: |
| 14:05:40 | <wyclif> Curating tickets |
| 14:05:41 | <wyclif> complete TRUNK-3604 - Migrate basicmodule to github |
| 14:05:42 | <wyclif> pick another migration ticket |
| 14:05:45 | <wyclif> Blockers: I keep getting this error when converting "2>&1 git svn fetch", looks like a version issue |
| 14:06:27 | <cpower> djazayeri..speak now if you are here... |
| 14:06:36 | <djazayeri> Hi |
| 14:06:42 | <djazayeri> Working on ITECH kenya project |
| 14:06:48 | <djazayeri> Planning for PIH Haiti project |
| 14:06:50 | <djazayeri> tired. |
| 14:06:53 | <djazayeri> no blockers |
| 14:07:07 | <cpower> lakkarau, your up! |
| 14:07:07 | <lakkarau> Monday: |
| 14:07:07 | <lakkarau> Trunk-3589 attached the patch. |
| 14:07:07 | <lakkarau> Trunk-3491 |
| 14:07:07 | <lakkarau> tuesday: |
| 14:07:07 | <lakkarau> will be working on trunk-3491 |
| 14:07:07 | <lakkarau> wednessday: |
| 14:07:10 | <lakkarau> Trunk-3491 |
| 14:07:11 | <lakkarau> No Blockers. |
| 14:07:16 | <lakkarau> |
| 14:07:48 | <cpower> I'll take it, dkayiwa anything from you good sir? |
| 14:08:02 | <dkayiwa> Curated patches |
| 14:08:09 | <dkayiwa> Continuing |
| 14:08:13 | <dkayiwa> No Blockers :) |
| 14:08:15 | <cpower> excellent |
| 14:08:23 | <cpower> Rafa...hi |
| 14:08:26 | <dkayiwa> patches = tickets :) |
| 14:08:28 | *** pushkar_ has quit IRC |
| 14:08:30 | <rafa> cpower: hi! |
| 14:08:33 | <rafa> Today: |
| 14:08:33 | <rafa> * Reviewed TRUNK-3319: Person attribute autofill shows nothing if concept name doesn't exist in users' language |
| 14:08:33 | <rafa> https://tickets.openmrs.org/browse/TRUNK-3319 |
| 14:08:33 | <rafa> * Reviewed some GSoC code, tested the app and entered tickets for the rest of summer |
| 14:08:33 | <rafa> * Still fixing tests in MDS |
| 14:08:33 | <rafa> No blockers. |
| 14:08:58 | <cpower> Suranga you have anything to add? |
| 14:09:38 | <cpower> aaaaaaand next jkeiper |
| 14:10:03 | <bwolfe> rafa, is MDS stuff in this sprint? the ones mseaton asked for? |
| 14:10:04 | <jkeiper> Monday: |
| 14:10:04 | <jkeiper> - AMPATH JIRA cleanup |
| 14:10:04 | <jkeiper> - proposed concept stuff |
| 14:10:04 | <jkeiper> Tuesday: |
| 14:10:04 | <jkeiper> - TRUNK-3591 and TRUNK-3592 |
| 14:10:04 | <jkeiper> - follow up on several watched AMPATH-related OpenMRS tickets |
| 14:10:11 | <rafa> bwolfe: yes |
| 14:11:31 | <kishoreyekkanti> Guess i can go next. Still stuck up with integrating automation suite with CI. Currently its failing as bamboo by default scans the log and if it finds any stack trace bamboo fails irrespective of the Jbehave reports(though all of them passed). I'm currently trying to remove all those stack traces on the log. |
| 14:11:38 | <kishoreyekkanti> There's an error in the log which goes like this "TimerSchedulerServiceImpl.getTaskByName(379) |2012-07-17 03:12:20,176| getTaskByName(Initialize Logic Rule Providers) failed comes when ever openers restarts?" If any one can find why the stack trace comes in this log "https://ci.openmrs.org/download/FUNC-APPTEST-JOB1/build_logs/FUNC-APPTEST-JOB1-84.log " please let me know |
| 14:12:31 | <cpower> Good job team! Blockers: Wyclif and his versions, Discussion points Kishoreyekkanti I believe is the only one |
| 14:12:35 | <cpower> !scrumoff |
| 14:12:35 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 14:12:50 | <bwolfe> wyclif, run it with the -v flag to see the bigger error |
| 14:13:05 | <bwolfe> kishoreyekkanti, I am worried that you are chasing something that doesn't need to be solved |
| 14:13:14 | <bwolfe> kishoreyekkanti, although I agree that it would be nice to have that cleaned up! :-) |
| 14:13:33 | <bwolfe> kishoreyekkanti, if you can replicate it at normal openmrs start/stop, it might be easier to debug |
| 14:13:35 | <nimanthab> bwolfe, so the problem is the content in the extention point will still be loaded with the page even though we wrap it in html |
| 14:13:52 | *** lakkarau has quit IRC |
| 14:13:52 | <kishoreyekkanti> bwolfe: :) hmm. But, i don't know any other way we can make the build green for now. |
| 14:14:01 | <bwolfe> lakkarau, you don't need to report on wednesday. wednesday AFTER the next scrum. you only report on what you did since the last scrum and will do up to the next one. |
| 14:14:08 | <wyclif> bwolfe, the error message is that it found possible barcn point |
| 14:14:10 | <kishoreyekkanti> bwolfe: Ok. I'll try this in my local instane |
| 14:14:15 | <bwolfe> arg, missed lakkarau :-( |
| 14:14:34 | <bwolfe> kishoreyekkanti, well, can you just supress the errors and prove it goes green? |
| 14:15:04 | <rafa> kishoreyekkanti: does it look for any stack trace or logged as error? |
| 14:15:09 | <kishoreyekkanti> bwolfe: You mean don't throw back any errors from the trunk code just for testing this? |
| 14:16:08 | <kishoreyekkanti> rafa: bamboo by default( if you don't have maven tasks which can return 1 or 0) will scan through the log to decide if the build is red or green |
| 14:16:51 | <bwolfe> nimanthab, you have the portlet url. you create a new jsp page for loading portlets of a given url. then in the dashboard you ajax load that url |
| 14:16:53 | <kishoreyekkanti> rafa: All the tasks currently for this particular build are command tasks. Even the maven commands are being executed as inline shell script using command tasks. |
| 14:17:25 | <bwolfe> kishoreyekkanti, why don't you create a script at the end that returns a 1 or 0 ? :-) |
| 14:17:27 | <nimanthab> bwolfe: for the core tabs we created a set of new controllers and jsp pages which has the tab content. If ajax is enabled, that content is requested via the relevant url through ajax. If not the content is rendered as it was in the first place. |
| 14:17:50 | <nimanthab> bwolfe: so basically we should create a generic page which accepts the url of a portlet and loads it? |
| 14:18:22 | <kishoreyekkanti> bwolfe: That would act independent of the tests ran or i need to keep some intelligence in the script to understand whether the build is pass or fail ;) |
| 14:18:57 | <bwolfe> nimanthab, yes. and you could even use that for the other tabs so you don't have to create new pages for each of them |
| 14:19:37 | <rafa> kishoreyekkanti: as a quick test you could change log4j configuration in openmrs.war\WEB-INF\classes\log4j.xml not to log anything |
| 14:19:54 | <nimanthab> okay.. got it. so do all the modules which add tabs dynamically do so via a portlet? |
| 14:20:33 | <wyclif> bwolfe, djazayeri this is what i get http://pastebin.com/j7Twjb4G |
| 14:22:19 | <kishoreyekkanti> rafa: I can try that, but i'm not sure if it works, because if i look at the log now, most of the exceptions have a tag name [build], and i'm not sure if all those errors are being logged through log4j |
| 14:22:51 | <bwolfe> wyclif, why mention darius? he's not even awake...and as far as I know hasn't done any github migration before :-p |
| 14:23:03 | <wyclif> ok |
| 14:23:16 | <bwolfe> wyclif, are you doing this in a checked out version of the basicmodule? |
| 14:23:35 | <wyclif> bwolfe no, thought i wanted to do that |
| 14:24:00 | <wyclif> bwolfe, though i wanted to do that |
| 14:24:08 | *** dkayiwa has quit IRC |
| 14:24:49 | <jkeiper> bwolfe, wyclif -- czakian and i put openmrs into github before and copied over svn history ... is that what you are working on? |
| 14:24:58 | <bwolfe> wyclif, I think you have to run it in a basicmodule that is chekced out. and you have to have the authors file perfect. and you have to use hte same url as you checked out the module (http vs https) |
| 14:25:11 | <bwolfe> jkeiper, yeah, remember how to get past the errors? or have the log from that? |
| 14:25:30 | <jkeiper> hrm ... nope, need to look at the errors ... iirc it was easy breezy |
| 14:25:52 | <wyclif> bwolfe, let try it with a check out repo |
| 14:26:25 | *** jkeiper has quit IRC |
| 14:26:28 | <bwolfe> jkeiper, yeah, other modules I've done have been |
| 14:26:54 | *** jkeiper has joined #openmrs |
| 14:27:20 | <wyclif> bwolfe, it means i have to check out the entire repo and not just trunk of the module , right? |
| 14:28:02 | <wyclif> bwolfe, i.e the module including branches and tags |
| 14:31:18 | <bwolfe> wyclif, just trunk of basicmodlue |
| 14:31:28 | <bwolfe> because you will eventually have to commit that |
| 14:32:29 | <jkeiper> bwolfe, wyclif: left a note for dkayiwa months ago on this ticket ... should it be backported? TRUNK-3288 |
| 14:32:33 | <jkeiper> !ticket TRUNK-3288 |
| 14:32:36 | <OpenMRSBot> jkeiper: [#TRUNK-3288] Handle form UUIDs in HL7 processing - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3288 |
| 14:33:26 | <bwolfe> jkeiper, new feature == not backported |
| 14:33:44 | <jkeiper> boo ... /me writes a custom orur01 processor for ampath ... again. |
| 14:34:11 | <bwolfe> a module can provide a processor |
| 14:34:22 | <bwolfe> theres a wiki page on how to do it |
| 14:34:35 | <wyclif> i know this doesnt matter for the basicmodule, but i thought we want to preserve tags and branches |
| 14:34:45 | <wyclif> bwolfe, i know this doesnt matter for the basicmodule, but i thought we want to preserve tags and branches |
| 14:35:02 | <bwolfe> wyclif, they are preserved. the migration looks them up |
| 14:35:17 | <bwolfe> the diff is that with git, all brances are stored within trunk (of sorts) |
| 14:35:28 | <bwolfe> brancehs/tags are separate folders in git |
| 14:36:41 | <wyclif> bwolfe, but if a do the conversion agianst a checkedout module trunk, how does it get to know about the branches and tags |
| 14:37:15 | <bwolfe> wyclif, watch what happens as it goes by. you will see it checks out the branches |
| 14:37:38 | <wyclif> bwolfe, ok, let me try that |
| 14:38:54 | <bwolfe> !ticket TRUNK-3491 |
| 14:38:55 | <OpenMRSBot> bwolfe: [#TRUNK-3491] Write to independent log file - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3491 |
| 14:40:27 | <jkeiper> bwolfe, does the Flowsheet Module no longer add a tab to the dashboard? |
| 14:40:39 | <bwolfe> jkeiper, dunno |
| 14:40:57 | <jkeiper> bwolfe, the one in the module repo has your name on it, says it's a "basic flowsheet module" |
| 14:41:24 | *** harshadura has joined #openmrs |
| 14:41:31 | <jkeiper> bwolfe, is that the one developed by thoughtwerks? |
| 14:41:44 | <bwolfe> I think they rewrote theirs |
| 14:41:46 | <jkeiper> s/we/wo |
| 14:41:59 | <bwolfe> ...a lot of things in the repo have my name on it. doesn't mean I did it...or that I remember I did it |
| 14:42:09 | <jkeiper> hrm |
| 14:42:36 | <jkeiper> ok ... i'll go with this; https://wiki.openmrs.org/display/docs/Flowsheet+Module |
| 14:43:12 | <bwolfe> I don't see a link to code or the omod there though |
| 14:43:24 | <jkeiper> nope |
| 14:43:26 | <jkeiper> blarghy |
| 14:43:53 | *** kishoreyekkanti_ has joined #openmrs |
| 14:44:24 | <jkeiper> bwolfe, wyclif, rafa ... anyone ... can you think of modules that add patient dashboard tabs? |
| 14:44:29 | *** kishoreyekkanti_ has quit IRC |
| 14:44:34 | *** ChanServ sets mode: +v jkeiper |
| 14:44:46 | *** kishoreyekkanti_ has joined #openmrs |
| 14:44:46 | *** kishoreyekkanti has quit IRC |
| 14:45:52 | *** jordank has joined #openmrs |
| 14:47:47 | <wyclif> jkeiper, i thought formentry does that |
| 14:47:57 | <wyclif> jkeiper, smart container does |
| 14:48:05 | <jkeiper> wyclif, thanks! |
| 14:48:33 | *** suranga has quit IRC |
| 14:57:07 | <bwolfe> I feel sorry for the svn server. its getting hammered today... |
| 14:57:50 | <bwolfe> kishoreyekkanti_, how long did the conversion take you to run? |
| 15:07:12 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @pbiondich: Interested in supporting OpenMRS & know Python/Django? Contact paul@openmrs.org for a cool project opportunity! <http://twitter.com/OpenMRS/statuses/225243217455616001> |
| 15:10:00 | *** nimanthab has quit IRC |
| 15:20:14 | *** jriley has quit IRC |
| 15:27:39 | <pushkar__> bwolfe, Hi |
| 15:28:19 | <bwolfe> hey |
| 15:30:13 | <wyclif> bwolfe, i made some tweaks and got somewhere, what happens to authors committed in the past but nolonger exist? |
| 15:30:38 | <bwolfe> authors always exist |
| 15:30:46 | <bwolfe> if those authors aren't in the authors file, add them |
| 15:31:00 | <bwolfe> see the migrating to git page about how to figure out which authors are on the basic module |
| 15:31:09 | <bwolfe> then make sure htat person is in the authors txt in the wiki page and hte one you are use |
| 15:31:11 | <bwolfe> *using |
| 15:32:09 | <wyclif> bwolfe, seen that, thanks |
| 15:32:28 | *** jriley has joined #openmrs |
| 15:32:28 | *** mseaton has quit IRC |
| 15:36:08 | <wyclif> bwolfe, that seems not generate all authors, i have just tested and it left out some devs that i can see that committed to the project |
| 15:36:29 | <wyclif> bwolfe, only returned 5 |
| 15:37:18 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: We're at OSCON this week!! Check out OpenMRS at these events: http://t.co/Ha0V27mQ Let us know you're there and connect with us! <http://twitter.com/OpenMRS/statuses/225250844239605760> |
| 15:37:59 | <jriley> bwolfe or djazayeri, I have a question about mavenizing the devexamples/jspexample module. I've done the mavenization. The patch file will be huge. Would it be better to check in the changes and request a post-facto code review? I'd like to get back to my real task, writing some example unit tests. That should be in a separate change set. |
| 15:38:56 | <pushkar__> bwolfe, I completed the annotations part just have to integrate to htmlformentry what should we do next ? |
| 15:39:30 | *** mseaton has joined #openmrs |
| 15:39:30 | *** ChanServ sets mode: +v mseaton |
| 15:39:31 | *** mseaton has quit IRC |
| 15:41:09 | *** jkeiper has quit IRC |
| 15:48:56 | *** rafa has quit IRC |
| 15:49:40 | *** mseaton has joined #openmrs |
| 15:49:40 | *** ChanServ sets mode: +v mseaton |
| 15:49:41 | *** mseaton has quit IRC |
| 15:52:15 | *** mseaton has joined #openmrs |
| 15:52:15 | *** ChanServ sets mode: +v mseaton |
| 15:53:40 | *** mseaton has quit IRC |
| 15:54:45 | *** mseaton has joined #openmrs |
| 15:54:45 | *** ChanServ sets mode: +v mseaton |
| 15:54:45 | *** mseaton has quit IRC |
| 15:55:26 | *** kishoreyekkanti_ has quit IRC |
| 15:57:31 | *** mseaton has joined #openmrs |
| 15:57:31 | *** ChanServ sets mode: +v mseaton |
| 15:58:59 | *** jkeiper_ has joined #openmrs |
| 16:03:22 | *** jriley has quit IRC |
| 16:06:55 | *** mseaton has quit IRC |
| 16:08:38 | <bwolfe> pushkar__, after you fix in htmlformentry? I think you should update/create the module wiki page, then post a 1.0 release. got to look good like mykola have a release of your project before end of summer. :-) |
| 16:08:43 | <bwolfe> then we can work on adding more features. |
| 16:10:34 | *** mseaton has joined #openmrs |
| 16:10:34 | *** ChanServ sets mode: +v mseaton |
| 16:11:21 | <pushkar__> okay bwolfe :-) and I am facing problem with jstl cant figure out why its happening are you free now? |
| 16:11:28 | <bwolfe> sure |
| 16:13:44 | *** jordank has quit IRC |
| 16:14:06 | <pushkar__> bwolfe, http://pastebin.com/kMnAH4AU |
| 16:14:31 | <bwolfe> error is on line 101 character 37. |
| 16:14:41 | <bwolfe> (thats my random guess, now lets see how close I am) |
| 16:14:41 | *** mseaton has quit IRC |
| 16:15:10 | <bwolfe> hmm, not close. ok pushkar__ what error are you getting? |
| 16:15:11 | <pushkar__> line 35 returns true but its not passing line 38 |
| 16:16:21 | <bwolfe> strange |
| 16:16:35 | <pushkar__> yes very |
| 16:16:59 | <pushkar__> any ideas why ? |
| 16:18:34 | *** jkeiper__ has joined #openmrs |
| 16:19:34 | *** jkeiper__ has joined #openmrs |
| 16:22:44 | *** jkeiper_ has quit IRC |
| 16:24:21 | <bwolfe> pushkar__, I have no ideas. does it fail if you do a c:if too? |
| 16:24:54 | *** mseaton has joined #openmrs |
| 16:24:54 | *** ChanServ sets mode: +v mseaton |
| 16:24:54 | *** mseaton has quit IRC |
| 16:25:18 | <pushkar__> bwolfe, yes |
| 16:26:00 | <bwolfe> where are you defining obsId ? |
| 16:26:59 | <pushkar__> bwolfe, in the controller and line 18 is working too |
| 16:27:29 | *** mseaton has joined #openmrs |
| 16:27:29 | *** ChanServ sets mode: +v mseaton |
| 16:28:53 | *** mseaton has quit IRC |
| 16:31:52 | <bwolfe> pushkar__, very strange |
| 16:32:10 | <bwolfe> if you just output "--${obsId}--", what do you see between the -- |
| 16:32:13 | <bwolfe> (might have to check source) |
| 16:37:09 | *** pushkar__ has quit IRC |
| 16:37:34 | *** pushkar__ has joined #openmrs |
| 16:38:51 | <bwolfe> if you just output "--${obsId}--", what do you see between the -- |
| 16:38:52 | <bwolfe> (might have to check source |
| 16:38:55 | <bwolfe> pushkar__ ^^ |
| 16:39:30 | *** harshadura has quit IRC |
| 16:39:31 | *** basic` has quit IRC |
| 16:40:15 | <pushkar__> bwolfe nothing i am getting "----" |
| 16:40:32 | <bwolfe> pushkar__, so is obsId an empty string or is it null ? |
| 16:43:03 | <pushkar__> bwolfe, its null |
| 16:44:46 | <bwolfe> pushkar__, pastebin your controller |
| 16:45:15 | *** kreddy has joined #openmrs |
| 16:46:11 | <pushkar__> bwolfe, http://pastebin.com/aNf6Px93 |
| 16:50:55 | <bwolfe> pushkar__, if you are doing obs.getId() for it, it should never be null, right? |
| 16:51:24 | <bwolfe> pushkar__, if you want the obsId from the parameters in your jsp, you need to do ${param.obsId} |
| 16:52:21 | <pushkar__> bwolfe, the use case is if I supply a obs id it should load the existing complex obs onto the editor |
| 16:53:21 | <pushkar__> if I dont supply obs it will it will show the form where the the user should supply patient id question concept and date so that a new obs can be created |
| 16:55:57 | <bwolfe> pushkar__, perhaps you need to put the obsId into the attribute if the user doesn't specify obs. |
| 16:56:06 | <bwolfe> (put it in as null) |
| 16:57:20 | *** harshadura has joined #openmrs |
| 16:57:20 | *** basic` has joined #openmrs |
| 16:59:02 | <pushkar__> then It should show the form containing fields for taking patientId and question concept |
| 16:59:05 | <pushkar__> bwolfe, |
| 17:00:15 | <pushkar__> attribute of what I didnt get you? |
| 17:00:36 | <bwolfe> pushkar__, on line 62, insert else { model.addAttribute("obsId", null); }; |
| 17:02:41 | *** suranga has joined #openmrs |
| 17:02:41 | *** ChanServ sets mode: +v suranga |
| 17:03:34 | *** jkeiper_ has joined #openmrs |
| 17:05:25 | *** lakkarau has joined #openmrs |
| 17:05:36 | <pushkar__> bwolfe, its not working |
| 17:06:34 | <bwolfe> pushkar__, same error? |
| 17:06:47 | <pushkar__> bwolfe, yes |
| 17:06:55 | <bwolfe> pastebin your new controller and jsp |
| 17:07:41 | *** jkeiper__ has quit IRC |
| 17:09:41 | *** jordank has joined #openmrs |
| 17:09:42 | <pushkar__> bwolfe, http://pastebin.com/dPm8u9re |
| 17:10:40 | <pushkar__> http://pastebin.com/5T2tPs6f |
| 17:10:45 | <bwolfe> pushkar__, so you see ----truetrue ? |
| 17:10:55 | <pushkar__> yes |
| 17:11:01 | <bwolfe> weeeeeiird |
| 17:11:41 | <bwolfe> and putting in this: <c:iftest="${obsId==null}">obs id is null</c:if> will output the text? |
| 17:11:45 | <bwolfe> or it won't? |
| 17:12:16 | <bwolfe> pushkar__, are you in a portlet? |
| 17:12:19 | <bwolfe> or normal page? |
| 17:12:25 | <pushkar__> portlet |
| 17:12:26 | *** djazayeri has quit IRC |
| 17:13:14 | <bwolfe> pushkar__, if the you put in a obs parameter, does obsId get filled? can you do ${obsId} and se esomething? |
| 17:13:39 | <pushkar__> bwolfe, yes I can see the obs |
| 17:14:00 | <pushkar__> do you want see my screen ? |
| 17:15:36 | <bwolfe> sure |
| 17:15:54 | <pushkar__> skype? |
| 17:16:21 | *** lh has joined #openmrs |
| 17:16:21 | *** lh has joined #openmrs |
| 17:18:14 | *** djazayeri has joined #openmrs |
| 17:18:14 | *** ChanServ sets mode: +o djazayeri |
| 17:19:40 | *** djazayeri has quit IRC |
| 17:20:35 | *** djazayeri has joined #openmrs |
| 17:20:35 | *** ChanServ sets mode: +o djazayeri |
| 17:24:48 | *** jkeiper_ has quit IRC |
| 17:25:25 | *** jkeiper_ has joined #openmrs |
| 17:25:25 | *** mvorobey has joined #openmrs |
| 17:25:31 | <mvorobey> hi all |
| 17:25:43 | <mvorobey> bwolfe, hi |
| 17:28:41 | <bwolfe> hey |
| 17:30:05 | <mvorobey> bwolfe, can you help me with DWR issue ? |
| 17:32:05 | <mvorobey> bwolfe, I'm receiving "Failed to load resource - openmrs/dwr/call/plaincall/DWRCustomMessageService.toggleTranslateMode.dwr" when trying to run my module in Safari. In Chrome and Firefox am not getting this error either. |
| 17:35:14 | *** jriley has joined #openmrs |
| 17:36:56 | <bwolfe> mvorobey, do you have a duplicate method name? (even if diff params, js doesn't like it) |
| 17:37:07 | <bwolfe> mvorobey, you can look at source of page and see what is the js file that is being imported |
| 17:37:13 | <bwolfe> open that import file and see what is in it |
| 17:38:18 | <mvorobey> bwolfe, no, I do not have duplicate method names toggleTranslateMode() is single |
| 17:38:36 | *** jkeiper_ has quit IRC |
| 17:39:02 | *** jkeiper_ has joined #openmrs |
| 17:39:59 | <bwolfe> mvorobey, pastebin your dwr file |
| 17:41:20 | <mvorobey> bwolfe, strangely but DWRCustomMessageService.js is usual - http://pastebin.com/ZpnGihp1 |
| 17:44:20 | *** lh has quit IRC |
| 17:45:59 | <bwolfe> mvorobey, pastebin the dwr file |
| 17:46:36 | <mvorobey> bwolfe, DWR java file ? |
| 17:46:55 | <bwolfe> mvorobey, or your config. wherever you're defining these |
| 17:46:59 | <bwolfe> or is it in trunk? |
| 17:47:51 | <bwolfe> mvorobey, the xml file |
| 17:48:19 | <mvorobey> bwolfe, https://github.com/OpenMRS/openmrs-module-custommessage/blob/v1.3/omod/src/main/resources/config.xml |
| 17:48:24 | <OpenMRSBot> <http://ln-s.net/$TPf> (at github.com) |
| 17:49:20 | <jordank> hi jriley |
| 17:49:34 | <jriley> How's it going, jordank? |
| 17:51:12 | <jordank> It's going well :) |
| 17:52:47 | <jordank> jriley: I was just had a quick question about one of the code review comments - if I delete executeMerge.jsp, I should change the choose concepts page to submit to the results page instead too, right? |
| 17:53:34 | <jriley> yes. let me pull it up to be sure... |
| 17:54:13 | <jriley> jordank, you mean in the controller, right? |
| 17:54:18 | <jordank> right |
| 17:54:39 | <jriley> executeMerge should redirect to results on success, yes |
| 17:55:01 | <mvorobey> bwolfe, https://github.com/OpenMRS/openmrs-module-custommessage/blob/v1.3/omod/src/main/java/org/openmrs/module/custommessage/web/dwr/DWRCustomMessageService.java |
| 17:55:01 | <bwolfe> mvorobey, add your new method tot he "signatures" section ? |
| 17:55:05 | <OpenMRSBot> <http://ln-s.net/$TQ2> (at github.com) |
| 17:55:16 | <bwolfe> mvorobey, I only see it in the "allow" section |
| 17:55:20 | <mvorobey> bwolfe, tried, did not work |
| 17:55:20 | <bwolfe> you need both, iirc |
| 17:55:32 | <mvorobey> bwolfe, no needed in both |
| 17:55:42 | <jriley> Oh, you were on to something with those ModelAttribute classes. I told you the conceptId should be string to match the request param. There's a thing that will make a Concept for you. I need to find the example page - I saw it on the My Favorite Patients page |
| 17:55:53 | *** lakkarau has quit IRC |
| 17:56:18 | *** lakkarau has joined #openmrs |
| 17:56:48 | <mvorobey> bwolfe, in signatures section is used to enable resolution of the types stored in Collections when specific generic types are not being used, so it is not necessary to declare methods without args in that section |
| 17:57:12 | <mvorobey> in signatures section = signatures section |
| 17:58:00 | <jriley> jordank, https://wiki.openmrs.org/display/docs/My+Favorite+Patients+MVC+Example - do a ^F find on InitBuilder. Read the paragraph before the code. You'd need to register a ConceptEditor. I haven't double-checked that there IS a conceptEditor class, but I bet there is . Then you won't have to look up the concept with the ConceptService. It'll be magically reconstituted for you. |
| 17:58:03 | <mvorobey> bwolfe, any other ideas ? |
| 17:58:42 | <jordank> jriley: should I have request mapping on the controller executeMerge() be to results.jsp instead of executeMerge.jsp, since I'm deleting that page? |
| 17:59:18 | *** jkeiper_ has quit IRC |
| 17:59:44 | *** jkeiper_ has joined #openmrs |
| 18:00:27 | <jordank> jriley: cool! I'll look it up |
| 18:01:16 | <jriley> jordank, I'll look at the controller again in a second. I'm fighting with eclipse. Pay no attention to the scuffling noises. |
| 18:01:55 | <jordank> jriley: ok :) |
| 18:02:54 | <jordank> I found the ConceptEditor class! |
| 18:05:08 | <bwolfe> mvorobey, what do you see if you go to that .dwr url? |
| 18:05:14 | <bwolfe> (in both ff and in safari?) |
| 18:07:36 | <mvorobey> bwolfe, I see the same things - http://pastebin.com/UtBgR6ht |
| 18:09:30 | *** jkeiper__ has joined #openmrs |
| 18:10:37 | <bwolfe> mvorobey, which url is that? |
| 18:11:26 | <mvorobey> bwolfe, http://localhost:8080/openmrs/dwr/call/plaincall/DWRCustomMessageService.toggleTranslateMode.dw |
| 18:13:02 | <mvorobey> r |
| 18:13:25 | *** jkeiper_ has quit IRC |
| 18:13:56 | <jriley> jordank, the RequestMapping tells the controller to direct the incoming request with that URL to this method. When the controller is done, it has to say what view to show the user. By default, if you don't specify a view to show, it'll show a view with the same name. |
| 18:15:08 | <jriley> Two things I don't know the answer to: 1) whether it shows a view with the same name as the URL or the same name as the controller method, and 2) whether you should redirect to results.form or results.jsp . This is the part where I'd look at the wiki, ask someone, or try some things out. |
| 18:16:04 | <jordank> jriley: I think I remember trying results.jsp and getting an error |
| 18:16:17 | <jriley> So in executeMerge, where it says return "redirect:results.form" , I don't know if it goes to MergeConceptsManagerController.results() or if it goes to the JSP page to render it |
| 18:16:38 | <bwolfe> mvorobey, I have no more ideas |
| 18:16:50 | <bwolfe> mvorobey, do other dwr calls work in safari? |
| 18:17:33 | <mvorobey> bwolfe, trying to test in right now |
| 18:17:45 | <mvorobey> bwolfe, thanks for helping me |
| 18:18:23 | <jkeiper__> djazayeri, know if we can create mock requests in java code with openmrs 1.8.x core libs available, or would I have to use a custom lib to do that in my module? |
| 18:19:18 | <djazayeri> jkeiper__: I think you need to include mockito yourself, but it's a trivial dependency in the pom. |
| 18:19:33 | <jkeiper__> djazayeri, kthx |
| 18:20:47 | <mvorobey> bwolfe, you know, other dwr calls work fine |
| 18:20:53 | <mvorobey> ... |
| 18:20:57 | <jriley> jordank, this is a great time for a log message! Add a log.info message that says "now in the results method" -- if it writes it to the log, you'll know |
| 18:22:13 | <bwolfe> djazayeri, jkeiper__, mockito is included in 1.9+ I think. https://tickets.openmrs.org/browse/TRUNK-2586 |
| 18:22:23 | <jkeiper__> djazayeri, i am in a position where i need to use a mock request as part of a normal service call ... is it bad to use mockito for this, since it is really designed just for testing? |
| 18:22:38 | <bwolfe> mvorobey, strange. whats different about it then? no params? or no return value? |
| 18:22:47 | *** djazayeri1 has joined #openmrs |
| 18:23:25 | <jordank> jriley: ohh okay! I think based on the wiki page about spring annotation it goes to the JSP page, and then the controller goes to the results method because of the request mapping |
| 18:23:57 | <mvorobey> bwolfe, both, no params and no return value, now trying to detect which one |
| 18:23:57 | *** djazayeri1 has quit IRC |
| 18:24:09 | <mvorobey> bwolfe, added dummy parameter |
| 18:24:33 | <jordank> jriley: where is the log saved? |
| 18:25:07 | *** djazayeri1 has joined #openmrs |
| 18:25:07 | *** jkeiper__ has quit IRC |
| 18:25:24 | *** mseaton has joined #openmrs |
| 18:25:24 | *** ChanServ sets mode: +v mseaton |
| 18:25:34 | *** jkeiper__ has joined #openmrs |
| 18:26:14 | <jriley> jordank, it should pop out in your Tomcat logs. On my mac, that's /Library/Tomcat/logs . Or you can go the easy way -- from the OpenMRS admin page, look for a link to server logs. You'll need to change the logging level in the global properties page first - change it to info or debug, whichever you use for your message. |
| 18:26:28 | *** djazayeri has quit IRC |
| 18:26:30 | <jriley> jordank, that log manager module looked like it would make things easier. I haven't installed it yet, but it sounded good |
| 18:27:20 | *** maurya has joined #openmrs |
| 18:27:50 | *** mseaton1 has joined #openmrs |
| 18:28:07 | <jordank> jriley: oh right! I almost forgot about that.. |
| 18:28:19 | <jriley> AH, the Annotation-driven Spring MVC page is where the idea for examples of web controller unit tests came from |
| 18:28:19 | *** mseaton1 has quit IRC |
| 18:28:19 | *** djazayeri1 has quit IRC |
| 18:29:18 | *** ChanServ sets mode: +v maurya |
| 18:29:28 | *** jkeiper__ has quit IRC |
| 18:29:46 | *** mseaton has quit IRC |
| 18:30:04 | *** jkeiper__ has joined #openmrs |
| 18:31:12 | <mvorobey> bwolfe, the key is asynchronous calling, I do not need it, only synchronous |
| 18:31:45 | *** djazayeri has joined #openmrs |
| 18:31:45 | *** ChanServ sets mode: +o djazayeri |
| 18:31:46 | <mvorobey> bwolfe, when am calling toggleTranslateMode in synchronous manner it works perfectly |
| 18:32:49 | <bwolfe> mvorobey, ok |
| 18:33:25 | <mvorobey> bwolfe, :) |
| 18:34:21 | *** wyclif has quit IRC |
| 18:34:25 | *** wluyima has joined #openmrs |
| 18:34:47 | *** dkayiwa has joined #openmrs |
| 18:37:54 | *** lh has joined #openmrs |
| 18:37:54 | *** lh has joined #openmrs |
| 18:40:07 | *** wluyima has quit IRC |
| 18:40:25 | *** wyclif has joined #openmrs |
| 18:40:44 | *** jkeiper_ has joined #openmrs |
| 18:42:51 | *** lh has quit IRC |
| 18:44:21 | *** jkeiper__ has quit IRC |
| 18:46:51 | *** mseaton has joined #openmrs |
| 18:46:51 | *** ChanServ sets mode: +v mseaton |
| 18:47:28 | *** jordank has quit IRC |
| 18:48:11 | *** mseaton1 has joined #openmrs |
| 18:48:36 | *** jkeiper__ has joined #openmrs |
| 18:51:36 | *** mseaton has quit IRC |
| 18:52:12 | *** jkeiper_ has quit IRC |
| 18:55:06 | *** mseaton1 has quit IRC |
| 18:57:23 | *** jkeiper__ has quit IRC |
| 18:58:16 | *** jkeiper has joined #openmrs |
| 19:03:16 | *** jkeiper has quit IRC |
| 19:03:46 | *** jkeiper has joined #openmrs |
| 19:05:37 | *** lakkarau has quit IRC |
| 19:08:05 | <mvorobey> bwolfe, have a time for one more html+js question ? |
| 19:08:52 | <bwolfe> sure |
| 19:09:47 | <mvorobey> bwolfe, question is long, are you ready ? |
| 19:11:16 | <bwolfe> sure |
| 19:11:18 | <mvorobey> let's assume that we have the next html code: |
| 19:11:19 | <mvorobey> <button><span class="translate">Click me</span></button> |
| 19:11:19 | <mvorobey> and there is onclick handler for elements with selector ".translate", i.e. inner span has own click handler to be called when user clicks on text 'Click me'. This handler is called in Chrome and Safari, but it do not work in FF. In Firefox surrounding button handler is called, span's handler is ignored. |
| 19:11:19 | <mvorobey> Any thoughts on how to get it working in mozilla ? |
| 19:11:23 | <bwolfe> I'm always ready |
| 19:15:49 | <mvorobey> bwolfe, have you read my question? |
| 19:16:20 | <bwolfe> no |
| 19:16:21 | <bwolfe> :-p |
| 19:17:56 | <bwolfe> mvorobey, what is a <button> tag? |
| 19:18:18 | <mvorobey> bwolfe, html button element :) |
| 19:18:25 | <bwolfe> <input type="button" ? |
| 19:19:11 | <mvorobey> bwolfe, no, simple button |
| 19:19:15 | <mvorobey> bwolfe, http://www.quackit.com/html_5/tags/html_button_tag.cfm |
| 19:19:18 | <OpenMRSBot> <http://ln-s.net/$TS6> (at www.quackit.com) |
| 19:19:58 | <mvorobey> bwolfe, http://www.w3schools.com/tags/tag_button.asp |
| 19:20:14 | <bwolfe> button is html5 only |
| 19:20:33 | <bwolfe> in the normal world it is only <input type="button" value="what is in the button" />. :-) |
| 19:20:58 | <mvorobey> bwolfe, ignore my previous link |
| 19:21:17 | *** jordank has joined #openmrs |
| 19:21:19 | <mvorobey> bwolfe, button is not only in html 5 |
| 19:21:25 | <bwolfe> ok |
| 19:21:26 | <bwolfe> http://www.quackit.com/html/tags/html_button_tag.cfm |
| 19:21:31 | <OpenMRSBot> <http://ln-s.net/$TS-> (at www.quackit.com) |
| 19:21:33 | <bwolfe> new to me |
| 19:21:34 | <bwolfe> :-) |
| 19:21:55 | <bwolfe> I assume the button tag has an onclick on it that is firing instead of your span ? |
| 19:22:13 | <mvorobey> bwolfe, right |
| 19:22:53 | <mvorobey> bwolfe, but in Chrome and Safari span handler is called, and in FF button's handler is called |
| 19:23:42 | <bwolfe> no ideas on that one. |
| 19:24:09 | <bwolfe> I vaguely remember seeing something about some way to trigger your calls over the whole dom. I can't remember if that was a jquery thing, or a form thing, or something in js |
| 19:24:09 | <mvorobey> bwolfe, do you no if djazayeri can help me with this ? |
| 19:24:23 | <bwolfe> djazayeri has done some js work. I don't know how complicated it is though |
| 19:24:37 | <mvorobey> no = know |
| 19:24:37 | <djazayeri> hi |
| 19:24:43 | <djazayeri> what's your issue? |
| 19:25:01 | <mvorobey> djazayeri, let's assume that we have the next html code: |
| 19:25:01 | <mvorobey> <button><span class="translate">Click me</span></button> |
| 19:25:01 | <mvorobey> and there is onclick handler for elements with selector ".translate", i.e. inner span has own click handler to be called when user clicks on text 'Click me'. This handler is called in Chrome and Safari, but it do not work in FF. In Firefox surrounding button handler is called, span's handler is ignored. |
| 19:25:01 | <mvorobey> Any thoughts on how to get it working in mozilla ? |
| 19:27:08 | <suranga> hi bwolfe i've created a grand total of four tickets (and added you as watcher on all of these) |
| 19:27:27 | <suranga> bwolfe, now im going to the dev list to finalize some more design discussions :-) |
| 19:27:58 | *** james_regen has quit IRC |
| 19:29:02 | <bwolfe> suranga, I don't see any emails about the tickets. can you link me to one of htem? |
| 19:30:06 | <suranga> bwolfe, https://tickets.openmrs.org/browse/OTHER-27 |
| 19:30:13 | <suranga> OTHER 23-27 |
| 19:34:44 | *** cpower has quit IRC |
| 19:35:29 | <djazayeri> mvorobey: I'm sure you can do this with jquery⦠:-) |
| 19:35:56 | <mvorobey> djazayeri, how ? |
| 19:36:46 | <djazayeri> mvorobey: the span handler is ignored completely in FF? |
| 19:36:57 | <djazayeri> mvorobey: are you sure it's not just that both get called? |
| 19:37:20 | <jriley> if you give button class=".translate" ..? |
| 19:38:01 | <mvorobey> djazayeri, completely ignored - http://jsfiddle.net/mvorobey/BHYQx/12/ try this in firefox |
| 19:38:04 | <djazayeri> mvorobey: is the <button> part of your code? |
| 19:38:15 | <djazayeri> mvorobey: i.e. can you modify the button? |
| 19:38:30 | <mvorobey> djazayeri, no, i can not |
| 19:38:58 | <jkeiper> dkayiwa, are you available? |
| 19:39:07 | *** ChanServ sets mode: +v jkeiper |
| 19:39:11 | <dkayiwa> jkeiper: yes |
| 19:39:44 | <mvorobey> djazayeri, button is a workaround that helps me to deal with inputs having type button |
| 19:40:47 | <jkeiper> dkayiwa, i'm working on rendering just the <form/> element from the xform document that comes out of the XformBuilder process ... long story short, I have it running but I want to just print (to string) the <form/> element. I am doing so by using formNode.write(serializer), but it is inserting xmlns:nX attributes and changing nil attribute to nX:nil on every element. |
| 19:40:51 | <mvorobey> jriley: interesting idea, did not tried, will see which I can get from this, thanks! |
| 19:41:10 | <jkeiper> dkayiwa, in your experience with XML ... can i keep the same document but set the root node to the form element somehow? |
| 19:41:31 | <jkeiper> so that i can bring it to the root, or should i start a new document and copy the form node as the new root element? |
| 19:42:46 | <suranga> jkeiper, from my own feeble knowlege, I think option 2. Not sure if option 1 is possible :-) |
| 19:42:55 | <jkeiper> dkayiwa, thanks ... :-D i will try! |
| 19:43:06 | <dkayiwa> jkeiper: was that for suranga ? :) |
| 19:43:27 | <jkeiper> dkayiwa, hahaha didn't see it was suranga |
| 19:43:28 | <jkeiper> :-D |
| 19:43:35 | <jkeiper> dkayiwa, but yes ... unless you have other ideas |
| 19:43:36 | <suranga> jkeiper, dkayiwa :D |
| 19:43:49 | <dkayiwa> jkeiper: he just happens to be faster than iam :) |
| 19:44:04 | <jkeiper> dkayiwa, i am essentially trying to render a filled-out xform from an existing encounter so that i can export it from one server for processing on another |
| 19:44:16 | <jkeiper> dkayiwa, and it is working ... just seems like it should be cleaned up a bit |
| 19:44:25 | <dkayiwa> jkeiper: ok |
| 19:44:31 | <djazayeri> mvorobey: sorry, I don't know the answer here |
| 19:44:36 | <djazayeri> http://stackoverflow.com/questions/8187854/jquery-event-bubbling-on-button-not-working-as-expected-in-firefox |
| 19:44:39 | <OpenMRSBot> <http://ln-s.net/$TSi> (at stackoverflow.com) |
| 19:44:45 | <djazayeri> you're not the only one to experience this |
| 19:45:27 | <mvorobey> djazayeri, thanks for this link! |
| 19:45:30 | <djazayeri> mvorobey: if it's particularly "button" that causes trouble, you could try some hackiness where you dynamically replace the <button> with an <input type="button"> |
| 19:45:46 | <jkeiper> suranga, how can i create a new doc with a given Element as the root node? |
| 19:45:50 | * jkeiper googles it |
| 19:46:37 | <djazayeri> mvorobey: gotta run, sorry I couldn't help more. |
| 19:46:51 | <suranga> jkeiper, as I remember, we can take the element, and create the new document with a setRoot(element) or something similar.... |
| 19:46:51 | <mvorobey> djazayeri, thanks anyway!!! |
| 19:47:00 | * suranga goes to look |
| 19:47:14 | <jkeiper> suranga, perhaps the doc is empty until you addChild() and that's the root ... |
| 19:47:16 | <jkeiper> i'll try it |
| 19:47:29 | <jkeiper> hopefully can clone the element to avoid errors |
| 19:49:55 | <wyclif> bwolfe, jkeiper have you seen this before during migration to svn error: Untracked working tree file '.settings/org.eclipse.jdt.core.prefs' would be overwritten by merge. |
| 19:49:55 | <wyclif> read-tree -m -u -v HEAD HEAD: command returned error: 128 |
| 19:50:06 | <wyclif> to git |
| 19:50:38 | <jkeiper> wyclif, idk but that particular file should be ignored right? |
| 19:50:51 | <jkeiper> since it's IDE settings |
| 19:50:54 | <wyclif> jkeiper, bwolfe i have constantly run into issues, i get past one only to run into another |
| 19:51:11 | <wyclif> jkeiper, but it exists in the repo |
| 19:51:37 | <wyclif> jkeiper, the option is to delete it from the repo before importing the project\ |
| 19:52:00 | <bwolfe> wyclif, yes, I keep seeing that |
| 19:52:15 | <bwolfe> I'm trying to ignore those one by one, then delete .git folder and run it again |
| 19:58:25 | *** jkeiper has quit IRC |
| 19:58:53 | *** jkeiper has joined #openmrs |
| 20:00:56 | <wyclif> bwolfe, me too |
| 20:01:19 | <wyclif> bwolfe, you set svn ignore on them? |
| 20:02:58 | <bwolfe> wyclif, no, --exclude in the svn2git call |
| 20:03:37 | <jkeiper> dkayiwa, looking at the <form /> element ... the xsi namespace is never defined ... is that on purpose, or is this happening behind the scenes? |
| 20:03:44 | *** lakkarau has joined #openmrs |
| 20:04:26 | <wyclif> bwolfe, i did that too but it doesnt seem to wortk |
| 20:04:40 | <jkeiper> dkayiwa, i see it set on the <xf:xforms/> element (root of the actual xform) |
| 20:04:40 | <wyclif> bwolfe, are setting on the indiv file or folder |
| 20:04:57 | <lakkarau> bwolfe:hi |
| 20:04:59 | <wyclif> bwolfe, because i tried have been setting it on .settings and its contents |
| 20:05:09 | <wyclif> using an expression |
| 20:05:18 | <jkeiper> dkayiwa, so ... perhaps the submission process just sends the <form/> element without any effort to inject the xsi namespace ...? |
| 20:05:19 | *** lakkarau has quit IRC |
| 20:05:43 | <pushkar__> mvorobey, is there a scenario where the spans handler gets called and the buttons wont ? |
| 20:06:57 | <dkayiwa> jkeiper: you are correct |
| 20:07:09 | <bwolfe> the svn2git seems to be adding something before the --exclude, so I'm not sure its working right |
| 20:07:15 | <mvorobey> pushkar__, am afraid that not, looks like in FF button children handlers are ignored |
| 20:07:41 | <jkeiper> dkayiwa, i'll try adding the namespace as an attribute to the <form/> element and see if it cleans things up |
| 20:07:55 | <dkayiwa> jkeiper: ok |
| 20:08:20 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: #OSCON - learn how the global open source EMR platform #OpenMRS helps save lives around the world. Wednesday at 5pm - http://t.co/ZUQBo7VN <http://twitter.com/OpenMRS/statuses/225311582870188032> |
| 20:08:39 | <pushkar__> mvorobey, why not trigger the handler manually by using .trigger()? |
| 20:09:16 | <pushkar__> whenever the button gets called you can maually trigger the spans event handler |
| 20:09:22 | <mvorobey> pushkar__, that is exactly what am doing now but this solution is still not perfect :) |
| 20:10:35 | <pushkar__> mvorobey, is it not giving expected output ? |
| 20:10:56 | <jkeiper> dkayiwa, haha ... kdom is weird, don't think this messy doc is going to matter. i'll just try processing it and see what happens. ;-D |
| 20:11:28 | <dkayiwa> jkeiper: hhehehehe :D |
| 20:11:38 | <mvorobey> pushkar__, it gives, but it causes a further problems :( |
| 20:12:09 | <pushkar__> mvorobey, and the problems are? |
| 20:12:37 | <mvorobey> pushkar__, https://tickets.openmrs.org/browse/CSTM-17 |
| 20:12:52 | <mvorobey> pushkar__, read ticket description please |
| 20:13:45 | <mvorobey> pushkar__, seems like jriley's assumption is working! |
| 20:14:04 | <pushkar__> okay :-) |
| 20:14:21 | <jriley> woohoo! |
| 20:14:50 | <bwolfe> what was her suggestion? |
| 20:17:28 | <mvorobey> bwolfe, make button with class .translate |
| 20:19:17 | *** pushkar__ has quit IRC |
| 20:19:50 | <mvorobey> jriley, bwolfe ah, proposed solution is still not perfect |
| 20:23:40 | *** jkeiper has quit IRC |
| 20:24:24 | *** jkeiper has joined #openmrs |
| 20:26:34 | *** lakkarau has joined #openmrs |
| 20:27:12 | <jriley> mvorobey, did you catch my typo? It should be class="translate" -- no dot in the markup. |
| 20:28:10 | <mvorobey> jriley, of course I did :) |
| 20:29:22 | <mvorobey> jriley, with your proposed solution button gets in-line editable wonderfully, but it does not get normal button when am pressing enter to submit in-line translation :( |
| 20:29:31 | <jriley> Drat |
| 20:30:37 | <mvorobey> jriley, :) yeah, it is a bit pity |
| 20:37:06 | <jordank> jriley: I think I just learned something about Crucible that had been confusing me... It looks like it's showing code from multiple versions/ commits |
| 20:39:28 | *** snoppy has left #openmrs |
| 20:43:36 | *** rafa has joined #openmrs |
| 20:43:36 | *** ChanServ sets mode: +v rafa |
| 20:51:37 | <lakkarau> bwolfe:hi |
| 20:52:10 | <lakkarau> djazayeri:hi |
| 20:52:15 | <djazayeri> hi |
| 20:53:30 | <lakkarau> djazayeri: in the LocationService method when the new methods are added LocationService.getLocationsByAttribute(Object searchString, LocationAttributeType lat); |
| 20:55:09 | <lakkarau> djazayeri:what is the annotation@Authorized({ PrivilegeConstants.?) |
| 20:56:55 | <lakkarau> djazayeri:i can see that PrivilegeConstants.VIEW_LOCATIONS id deprecated |
| 20:57:07 | *** maurya has quit IRC |
| 20:58:13 | <djazayeri> lakkarau: see the @Authorized annotation at https://wiki.openmrs.org/x/WAA3AQ |
| 20:58:38 | <djazayeri> lakkarau: basically it means that the framework will check that the authenticated user has the specified privilege before allowing the method invocation to happen |
| 20:58:58 | <djazayeri> lakkarau: in 1.10 we're renaming all the VIEW_XYZ privileges to GET_XYZ (I think) |
| 20:59:22 | <djazayeri> lakkarau: does the @deprecated javadoc on PrivilegeConstants.VIEW_LOCATIONS not say this? |
| 20:59:23 | <lakkarau> djazayeri:there is GET_LOCATIONS |
| 21:00:46 | *** rafa has quit IRC |
| 21:00:57 | <lakkarau> djazayeri:yes i missed it some how. |
| 21:01:00 | <jriley> jordank, I found crucible easier to read when I changed the View to Full Context. The View drop down is at about 2:30 on the screen |
| 21:01:39 | <lakkarau> djazayeri: you clarified my doubt,thanks. |
| 21:02:33 | <lakkarau> djazayeri:thank you . |
| 21:03:01 | <djazayeri> lakkarau: np |
| 21:03:06 | <jordank> jriley: ohh that is way better. I was confused by the red/green highlighted parts |
| 21:04:36 | <jriley> jordank if I could figure out how to make the code go to fullscreen mode, I'd be even happier. |
| 21:04:41 | *** jordank_ has joined #openmrs |
| 21:06:00 | <jordank_> jriley: I think the red is what I deleted from an earlier commit, which is why it looks like I had the @ModelAttribute methods and later the model.addAttribute(...) |
| 21:06:34 | <jriley> jordank_ -- my bad too, I didn't pick up on that. |
| 21:06:39 | <jordank_> I don't know why I got disconnected, but that's cool there are two of me now... |
| 21:06:55 | <jordank_> jriley: not sure which way is better |
| 21:07:54 | *** jordank has quit IRC |
| 21:07:54 | *** jordank_ is now known as jordank |
| 21:09:59 | <jriley> jordank_, if you're going to load those up in more than one method, you should either use @ModelAttribute or make a separate method. @ModelAttribute code will always be run and save the concepts to attributes for you. I assume it handles things correctly if the request parameter isn't set ( e.g. you haven't picked your concepts yet). That's easy to test. |
| 21:10:54 | <jriley> jordank_, looking up two concepts seems like low overhead. I wouldn't find matching obs in a ModelAttribute, because it could be a big list and you only need it in the executeMerge method. |
| 21:10:56 | <jriley> my two cents |
| 21:12:10 | *** lakkarau has quit IRC |
| 21:15:16 | <jordank> jriley: I would need the matching obs in the preview method too right? |
| 21:16:19 | <jriley> jordank - yes. You'd mentioned maybe showing a count of matching obs in case there were thousands of them, right? There might be a nice ObsService method for that |
| 21:17:23 | <jordank> jriley: It handles things if the request parameter isn't set as long as it's not required, and yes, right obsConverter had code for getting a count of obs |
| 21:18:49 | <jriley> When I think about how controllers and JSPs interact, I think of a mom packing a lunchbox. If it isn't in the lunchbox, the kid doesn't get it. Anything you want the JSP to have, the controller has to set as an attribute. ( Although I think there are some special OpenMRS JSP tags that let you access more things.) No attribute == no cupcake in the lunchbox == sad JSP. |
| 21:19:31 | *** jkeiper has quit IRC |
| 21:19:57 | *** jkeiper has joined #openmrs |
| 21:21:32 | <jordank> jriley: haha that's great! So, I just need to decide if the scope of an attribute is one method or the whole controller |
| 21:22:41 | <jordank> or if I add an attribute to the model in a method does the rest of the controller get to know about it? |
| 21:23:56 | <jriley> Yes, if you're doing the same work over and over it's a signal to break it out into its own method. If it only happens in one spot, better to keep it to the relevant spot |
| 21:24:20 | <jordank> got it |
| 21:25:33 | *** dkayiwa has quit IRC |
| 21:25:47 | <jordank> jriley: one more question... I noticed the ConceptEditor class uses ConceptService, so is the reason that it's nicer to use the editor instead of the service that the editor handles the exceptions for you? |
| 21:31:32 | *** jkeiper has quit IRC |
| 21:31:34 | <jriley> jordank, yes, once you set an attribute it's available to the controller. I'm not sure what it sets the attribute on - request? model? If you look at https://wiki.openmrs.org/display/archive/Annotation+MVC+Example+for+Cape+Town there's an example of the ModelAttribute. It's clear that it sets favorites where the JSP can see it, and there's an example of setting a request attribute. I'd search for "ModelAttribute" in the codebase to f |
| 21:31:34 | <jriley> another example, or try it out and see what works |
| 21:32:00 | *** jkeiper has joined #openmrs |
| 21:33:14 | <jriley> jordank, I've never used the ConceptEditor, but having something retrieve those concepts for you sounds convenient. I'd expect it does some nice null checking for you, and maybe |
| 21:33:52 | <jriley> ⦠something nice with exceptions too. You can check it in the code, or feed it some bad parameters and see what happens |
| 21:34:08 | <jriley> like "abc" for a conceptId |
| 21:34:39 | <jriley> It's also nicer to use a component that works and has been tested. |
| 21:34:58 | <jriley> You've inspired me. I'm going to browse through the code sometime this week |
| 21:35:06 | <jordank> jriley: :) |
| 21:35:20 | <jordank> it's been fun |
| 21:36:03 | <jriley> Ok, time for me to wrap up for the day |
| 21:36:20 | <jriley> My code compiled, my fixes are checked in -- time to ride into the sunset while everything is still working |
| 21:36:57 | <jordank> thanks! sounds like a good plan |
| 21:37:06 | <jriley> Catch up with you later |
| 21:37:22 | *** suranga has quit IRC |
| 21:37:22 | *** jriley has quit IRC |
| 21:44:16 | *** mvorobey has quit IRC |
| 21:44:49 | *** jkeiper has quit IRC |
| 21:45:29 | *** jkeiper has joined #openmrs |
| 21:51:10 | <wyclif> bwolfe, i just noticed some of those error messages can be ignores |
| 21:51:18 | <wyclif> bwolfe, ignored |
| 21:52:34 | *** jkeiper__ has joined #openmrs |
| 21:56:14 | *** jkeiper has quit IRC |
| 21:58:43 | *** maro has quit IRC |
| 22:13:33 | *** jkeiper has joined #openmrs |
| 22:16:32 | *** jkeiper__ has quit IRC |
| 22:58:22 | *** kreddy has quit IRC |
| 23:10:34 | *** jkeiper__ has joined #openmrs |
| 23:13:33 | *** djazayeri has quit IRC |
| 23:14:32 | *** jkeiper has quit IRC |
| 23:17:33 | *** djazayeri has joined #openmrs |
| 23:17:33 | *** ChanServ sets mode: +o djazayeri |
| 23:36:53 | *** jordank has quit IRC |
| 23:53:45 | *** djazayeri has quit IRC |