| 00:02:49 | *** jordank has quit IRC |
| 01:05:16 | *** lh has joined #openmrs |
| 01:05:16 | *** lh has joined #openmrs |
| 01:19:40 | *** dkayiwa has quit IRC |
| 01:23:23 | *** harshadura has joined #openmrs |
| 01:25:08 | *** lh has quit IRC |
| 01:31:48 | *** wyclif has joined #openmrs |
| 01:35:33 | *** jkeiper has joined #openmrs |
| 01:37:16 | *** lakkarau has joined #openmrs |
| 01:42:05 | *** venkaban has quit IRC |
| 01:43:38 | *** jkeiper has quit IRC |
| 01:52:04 | *** harshadura has quit IRC |
| 01:52:15 | *** harshadura has joined #openmrs |
| 01:56:30 | *** orien has quit IRC |
| 02:01:37 | *** harshadura has quit IRC |
| 02:01:38 | *** wyclif has quit IRC |
| 02:19:37 | *** suranga has joined #openmrs |
| 03:31:41 | *** robbyoconnor has quit IRC |
| 03:32:15 | *** robbyoconnor has joined #openmrs |
| 03:32:15 | *** ChanServ sets mode: +v robbyoconnor |
| 03:38:16 | *** robbyoconnor has quit IRC |
| 03:42:34 | *** robbyoconnor has joined #openmrs |
| 03:42:34 | *** ChanServ sets mode: +v robbyoconnor |
| 03:46:38 | *** robbyoconnor has quit IRC |
| 03:47:04 | *** robbyoconnor has joined #openmrs |
| 03:47:04 | *** ChanServ sets mode: +v robbyoconnor |
| 03:50:11 | *** robbyoconnor has quit IRC |
| 04:19:08 | *** kishoreyekkanti has joined #openmrs |
| 04:25:28 | *** wyclif has joined #openmrs |
| 04:28:30 | *** lakkarau has quit IRC |
| 04:41:51 | *** harshadura has joined #openmrs |
| 04:44:40 | *** djazayeri1 has joined #openmrs |
| 04:44:50 | *** djazayeri1 is now known as djazayeri |
| 04:44:50 | *** ChanServ sets mode: +o djazayeri |
| 05:04:34 | *** kishoreyekkanti has quit IRC |
| 05:09:11 | *** kishoreyekkanti has joined #openmrs |
| 05:15:28 | *** jordank has joined #openmrs |
| 05:16:52 | *** kishoreyekkanti has quit IRC |
| 05:30:13 | *** goutham has joined #openmrs |
| 05:51:37 | *** harshadura has quit IRC |
| 05:52:24 | *** jordank has quit IRC |
| 06:04:30 | *** kishoreyekkanti has joined #openmrs |
| 06:35:02 | *** dkayiwa has joined #openmrs |
| 06:38:02 | <goutham> Hi dkayiwa Good Morning :) |
| 06:40:35 | <dkayiwa> goutham: oh yes, and you? :) |
| 06:50:09 | *** dkayiwa has quit IRC |
| 06:50:31 | *** maurya has joined #openmrs |
| 06:50:35 | *** goutham has quit IRC |
| 07:07:23 | *** dkayiwa has joined #openmrs |
| 07:17:14 | *** dkayiwa has quit IRC |
| 07:35:42 | *** Maurya_ has joined #openmrs |
| 07:39:38 | *** maurya has quit IRC |
| 07:42:15 | *** harshadura has joined #openmrs |
| 07:47:52 | *** dkayiwa has joined #openmrs |
| 07:52:37 | *** Maurya_ has quit IRC |
| 08:16:48 | *** harshadura has quit IRC |
| 08:28:07 | *** dkayiwa has quit IRC |
| 08:28:19 | *** dkayiwa has joined #openmrs |
| 09:11:22 | *** dkayiwa has quit IRC |
| 09:17:24 | *** suranga_ has joined #openmrs |
| 09:17:36 | *** suranga has quit IRC |
| 09:19:44 | *** kishoreyekkanti has quit IRC |
| 09:20:03 | *** kishoreyekkanti has joined #openmrs |
| 09:22:18 | *** suranga_ has quit IRC |
| 09:25:57 | *** goutham has joined #openmrs |
| 09:39:46 | *** dkayiwa has joined #openmrs |
| 09:43:08 | <goutham> dkayiwa: Hi |
| 09:43:15 | <dkayiwa> hi goutham |
| 09:43:59 | <goutham> dkayiwa: i made a commit against the role and privilege filters also.. Can you have a look at it , i have a trouble with them? |
| 09:44:15 | <dkayiwa> goutham: ok |
| 09:48:17 | <goutham> dkayiwa: trouble iam facing is... http://pastebin.com/kVmnrErk line 73 always return true :| |
| 09:49:50 | <dkayiwa> goutham: ok |
| 09:57:57 | <dkayiwa> goutham: is everything committed? |
| 09:58:21 | <goutham> dkayiwa: Yes |
| 09:58:35 | <dkayiwa> goutham: ok looking at it now |
| 09:58:54 | <goutham> dkayiwa: Ok :) |
| 10:02:10 | <dkayiwa> goutham: do you have a unit test for it? |
| 10:02:42 | <goutham> dkayiwa: no |
| 10:02:58 | <dkayiwa> goutham: can you create one and then i have a look at it? |
| 10:03:47 | <goutham> dkayiwa: i think there is openmrs auto test case generator plugin ! |
| 10:04:44 | <dkayiwa> goutham: you are free to use that if you want. but it only creates empty test methods for you |
| 10:04:59 | *** harshadura has joined #openmrs |
| 10:05:06 | <dkayiwa> goutham: can you create a test for it, then commit, and tell me to look at it after the commit? |
| 10:05:23 | *** applecool has joined #openmrs |
| 10:05:23 | *** ChanServ sets mode: +v applecool |
| 10:06:07 | <goutham> dkayiwa: Ok i will buzz you after the commit :D |
| 10:06:20 | <dkayiwa> goutham: cant wait :) |
| 10:07:18 | *** rafa has joined #openmrs |
| 10:07:18 | *** ChanServ sets mode: +v rafa |
| 10:19:23 | <dkayiwa> hi rafa |
| 10:19:35 | <applecool> hi rafa |
| 10:19:38 | <applecool> hi dkayiwa :) |
| 10:19:47 | <dkayiwa> rafa: for the rest webservices module, did you drop the hl7 resource? :) |
| 10:19:52 | <dkayiwa> hi applecool :) |
| 10:20:09 | <dkayiwa> rafa: i do not see it on the webservice resources wiki page |
| 10:20:24 | *** harshadura has quit IRC |
| 10:24:07 | <rafa> dkayiwa: no |
| 10:24:29 | <dkayiwa> rafa: do you know why it is not listed on the wiki's web service resouces? |
| 10:24:39 | <rafa> dkayiwa: no |
| 10:24:42 | <rafa> dkayiwa: it should be |
| 10:25:28 | <dkayiwa> rafa: ok |
| 10:25:43 | <dkayiwa> rafa: do you have your maven, git and eclipse intergrated? |
| 10:25:53 | <rafa> dkayiwa: but it's not there :( |
| 10:25:55 | <rafa> dkayiwa: yes |
| 10:26:17 | <dkayiwa> rafa: am checking out the xforms module but it shows in eclipse as not shared |
| 10:26:30 | <dkayiwa> rafa: do you have an idea as to what i could be doing wrong? |
| 10:26:43 | <dkayiwa> rafa: i did a git clone at command line |
| 10:26:48 | <rafa> dkayiwa: you should click team -> share project |
| 10:27:02 | <dkayiwa> rafa: and then maven imported existing project |
| 10:27:03 | <rafa> dkayiwa: repeat it for 3 projects |
| 10:27:26 | <dkayiwa> rafa: ok |
| 10:29:05 | <rafa> dkayiwa: there should be an option to use an existing repository when you do team -> share project |
| 10:30:07 | <dkayiwa> rafa: ok |
| 10:35:12 | <rafa> dkayiwa: why can I not see Desing XForm while editing a form on omrs 1.6? |
| 10:35:25 | <rafa> dkayiwa: is there a gp to enable the link? |
| 10:35:33 | <dkayiwa> rafa: are you on the form schema screen? |
| 10:35:39 | <rafa> dkayiwa: yes |
| 10:35:55 | <dkayiwa> rafa: can you cross check if the xforms module is started and running? |
| 10:36:16 | <rafa> dkayiwa: it is, I see xforms links on the administration page |
| 10:36:38 | <dkayiwa> rafa: i think i know why. it is should be an openmrs bug where any form with formId=1 is treated as a demo readonly form :) |
| 10:36:48 | <dkayiwa> rafa: so just create another form and you will see the link |
| 10:36:59 | <dkayiwa> rafa: or simply change that formId from 1 to something else |
| 10:37:02 | <rafa> dkayiwa: I did that I created a duplicate from the demo form |
| 10:37:18 | <dkayiwa> rafa: and what is the formid? |
| 10:37:35 | <rafa> dkayiwa: let me check |
| 10:42:10 | <rafa> dkayiwa: hmm strange, I started the server again and see the link now, but it doesn't open a desiner rather gives me an xml to download |
| 10:42:24 | <dkayiwa> rafa: are you using java 7? |
| 10:42:34 | <rafa> dkayiwa: very likely |
| 10:42:42 | <dkayiwa> rafa: can you upgrade it? |
| 10:42:52 | <rafa> dkayiwa: ok |
| 10:43:09 | <dkayiwa> rafa: to a newer java 7 update |
| 10:43:27 | <rafa> dkayiwa: for the record currently I have jdk1.7.0_03 |
| 10:44:35 | <dkayiwa> rafa: use not less than jdk1.7.0_05 |
| 10:44:47 | <rafa> dkayiwa: 05 is the latest :) |
| 10:44:57 | <dkayiwa> rafa: :D |
| 10:59:55 | *** gauravpaliwal has joined #openmrs |
| 10:59:55 | *** ChanServ sets mode: +v gauravpaliwal |
| 11:01:00 | *** rafa has quit IRC |
| 11:05:57 | *** rafa has joined #openmrs |
| 11:05:57 | *** ChanServ sets mode: +v rafa |
| 11:06:53 | <dkayiwa> rafa: do i have permissions to push to the github xforms repo? |
| 11:07:05 | <rafa> dkayiwa: you should |
| 11:07:14 | <rafa> dkayiwa: problems? |
| 11:07:24 | <dkayiwa> rafa: tried and got some problems with a not permitted message |
| 11:07:36 | <rafa> dkayiwa: let me check |
| 11:07:40 | <dkayiwa> rafa: ok |
| 11:08:25 | <rafa> dkayiwa: ohh you're not added to full committers... strange |
| 11:08:43 | <dkayiwa> rafa: ok. have you added me now? :) |
| 11:09:12 | <rafa> dkayiwa: I don't think I have rights to do that |
| 11:09:26 | <dkayiwa> rafa: who has? Michael? |
| 11:09:42 | <rafa> dkayiwa: but I added you as a committer to the module |
| 11:09:48 | <rafa> dkayiwa: yes, Michael |
| 11:09:56 | <dkayiwa> rafa: ok will send him an email |
| 11:10:05 | <rafa> dkayiwa: ohh wait |
| 11:10:10 | <dkayiwa> rafa: aha :) |
| 11:10:11 | <rafa> dkayiwa: I've just added you :) |
| 11:10:17 | <dkayiwa> rafa: hahaha :) |
| 11:11:06 | <applecool> rafa: hi |
| 11:11:10 | <rafa> applecool: hi |
| 11:11:41 | <applecool> hmm! i sent you the mail! you said you dint understand |
| 11:11:45 | <applecool> shall i explain it! |
| 11:11:50 | <rafa> applecool: yes |
| 11:11:55 | *** dkayiwa has left #openmrs |
| 11:12:09 | <applecool> actually you told me to modify the search right! with Long page and Long pageSize |
| 11:12:42 | <rafa> applecool: yes, you need to say a range of packages to display |
| 11:14:08 | <applecool> search(searchTerm, MetadataPackage.class,3L,25L) instead of this search(searchTerm, MetadataPackage.class) . but how would i know dynamically fix the Long Page? |
| 11:14:45 | <rafa> applecool: what do you mean by dynamically fix? |
| 11:15:00 | <applecool> as you said i am anyways hardcoding the 25L ie the PageSize |
| 11:15:08 | <applecool> but what about the long page! |
| 11:15:31 | <rafa> applecool: it says which page to display... |
| 11:15:51 | <rafa> applecool: you should start with 1 and when a user request another page you give a number |
| 11:16:26 | <rafa> applecool: 1 page displays serach results from 0-25, 2 page displays search results from 25-50 and so on |
| 11:16:37 | <applecool> okay! so i need to pass 1L instead of the 3L |
| 11:16:39 | <applecool> ? |
| 11:16:51 | <rafa> applecool: no you need to pass whatever user requests |
| 11:17:03 | <rafa> applecool: if user doesn't request a specific page you display the first one |
| 11:17:32 | <rafa> applecool: there should be a param in the request like ?page=2 |
| 11:18:29 | <rafa> applecool: what happens if you change a page in a table now? |
| 11:18:44 | <applecool> i am getting the results of the second page |
| 11:18:55 | <applecool> i mean i gave 5 right previously |
| 11:19:06 | <applecool> so in the first page it is showing me 0-5 |
| 11:19:28 | <applecool> and then if there are more packages for example 8 . it is showing me 6-8 in the page 2 |
| 11:19:47 | *** james_regen has joined #openmrs |
| 11:19:47 | *** ChanServ sets mode: +v james_regen |
| 11:19:58 | <applecool> i sent you a screen shot in the evening yesterday! it showed it :) |
| 11:20:20 | <rafa> applecool: I saw the screenshot, but I can't tell how it works looking at your code |
| 11:20:33 | <rafa> applecool: to me the code doesn't make sense |
| 11:20:44 | <rafa> applecool: why are you passing 3 anyways? |
| 11:21:09 | <rafa> applecool: I need to test it |
| 11:21:09 | <applecool> just a sec |
| 11:21:26 | <rafa> applecool: make sure it works correctly and not only seems to work |
| 11:21:31 | <rafa> applecool: and let me know |
| 11:21:34 | <applecool> i feel this is making the magic Page pages = compassResults.getPages()[i]; |
| 11:21:38 | <rafa> applecool: I'll be testing it over the weekend |
| 11:21:55 | <rafa> applecool: what is i? |
| 11:22:00 | <applecool> actually i feel the Long page which we are passing in the method is not needed |
| 11:22:16 | <applecool> i starts from 0 |
| 11:22:23 | <rafa> applecool: okay do it right |
| 11:22:23 | <applecool> for (int i = 0; i < compassResults.getPages().length; i++) |
| 11:22:30 | <rafa> applecool: as you think it should be |
| 11:22:35 | <rafa> applecool: I'll test it over the weekend |
| 11:23:18 | <applecool> are you sure? :) |
| 11:23:30 | <applecool> okay i will try it rafa the either ways |
| 11:23:32 | <applecool> and tell you |
| 11:23:38 | <rafa> applecool: you must be sure not me :P |
| 11:23:43 | <applecool> hehe! |
| 11:23:46 | <applecool> :) |
| 11:24:32 | <applecool> by the way at last the FileUploadControllerTest is done |
| 11:24:37 | <applecool> committed and pushed! |
| 11:25:10 | <applecool> rafa: |
| 11:25:22 | <rafa> applecool: finally :P |
| 11:25:35 | <rafa> applecool: I'll look at it |
| 11:25:37 | <applecool> yeah! |
| 11:25:39 | <applecool> okay :) |
| 11:53:23 | *** gauravpaliwal has left #openmrs |
| 11:58:37 | <applecool> rafa: leaving school! i will be back :) |
| 11:58:46 | <applecool> rafa: till when you will be there? |
| 11:59:12 | <rafa> applecool: maybe 3-4 hours more |
| 11:59:43 | <applecool> its 2:00 right for you ? |
| 11:59:50 | <rafa> applecool: right |
| 11:59:54 | <applecool> so you would be till 6:00 |
| 12:00:00 | <applecool> then cycling? |
| 12:00:02 | <rafa> applecool: good math :D |
| 12:00:03 | <applecool> :P |
| 12:00:10 | <applecool> :D |
| 12:00:13 | <rafa> applecool: actually going to a concert |
| 12:00:39 | <applecool> oh looks great |
| 12:00:40 | <applecool> wow! |
| 12:00:46 | <applecool> sounds* |
| 12:01:27 | <applecool> okay i will catch you before it self then! |
| 12:01:52 | <rafa> applecool: ok, cya |
| 12:01:57 | <applecool> bye :) |
| 12:03:55 | *** applecool has quit IRC |
| 12:15:42 | *** wyclif has quit IRC |
| 12:31:09 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Reporting Compatibility 1.5.8 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=reportingcompatibility&version=&1.5.8> |
| 12:37:01 | *** kishoreyekkanti has quit IRC |
| 12:40:27 | *** jriley has joined #openmrs |
| 12:42:27 | <jriley> Can someone tell me the markup to make a JIRA ticket point to the commit with the fix? |
| 12:43:12 | <jriley> If it's a regular html link, how do I deduce the link? |
| 12:56:38 | <rafa> jriley: If you commit to svn then just say rev:21423 in a ticket comment. Don't forget to put a ticket number in a commit message. |
| 12:58:13 | <rafa> jriley: btw to deduce any link you can say [OpenMRS|http://openmrs.org] |
| 12:58:30 | <rafa> jriley: it's the same as in wiki |
| 12:58:54 | <jriley> Thanks, Rafa! I know the markup for a link, just not what to link it to. I found it on source. openmrs.org - my commit was near the top |
| 12:59:14 | <jriley> markup == least favorite thing about Atlassian |
| 12:59:30 | <jriley> Oh sweet, that worked. Thanks |
| 13:01:07 | *** applecool has joined #openmrs |
| 13:01:09 | *** ChanServ sets mode: +v applecool |
| 13:01:12 | <applecool> hey rafa |
| 13:01:17 | *** dkayiwa has joined #openmrs |
| 13:01:27 | <rafa> applecool: hey |
| 13:02:33 | <applecool> i tried that rafa pkg.getId() |
| 13:02:37 | <applecool> its failing |
| 13:02:42 | <applecool> its null |
| 13:02:50 | <applecool> i need to set the pkg right |
| 13:02:54 | <applecool> in the test now! |
| 13:03:08 | <applecool> to be frank i even tried that!but no luck! |
| 13:04:24 | <rafa> applecool: ok leave it |
| 13:05:12 | <applecool> http://pastebin.com/u92YMCa6 |
| 13:05:20 | <applecool> stack trace for it! |
| 13:05:52 | <applecool> ah nevermind :)! i dont think it makes sense now because i already explained :) :) |
| 13:06:17 | <applecool> rafa: so do you want me to leave it as assetNotnull? |
| 13:06:29 | <applecool> oops assert* |
| 13:06:36 | <rafa> applecool: yes |
| 13:06:45 | <applecool> okay |
| 13:06:56 | <applecool> free now? busy with code!? |
| 13:07:42 | <rafa> applecool: need help? |
| 13:08:18 | <applecool> na na! just asked! :) will ping you if needed! :) |
| 13:09:50 | *** jkeiper has joined #openmrs |
| 13:25:02 | * goutham ping dkayiwa |
| 13:25:29 | <dkayiwa> goutham: |
| 13:25:54 | <goutham> dkayiwa: u have time ? or getting ready for scrum ? |
| 13:26:15 | <dkayiwa> goutham: am at the airport, but can talk |
| 13:27:11 | <goutham> dkayiwa: Oh , just added the test cases thought you will look at the filters |
| 13:27:17 | <goutham> dkayiwa: so flying to ? |
| 13:27:30 | <dkayiwa> goutham: yes. i can update and look at it now |
| 13:27:37 | <dkayiwa> goutham: do you have it committed? |
| 13:27:56 | <goutham> dkayiwa: ya its commited :) |
| 13:28:06 | <dkayiwa> goutham: ok let me update now |
| 13:28:27 | *** kishoreyekkanti has joined #openmrs |
| 13:31:24 | *** applecool has quit IRC |
| 13:37:13 | *** dkayiwa has quit IRC |
| 13:38:28 | *** dkayiwa has joined #openmrs |
| 13:38:28 | *** kishoreyekkanti has quit IRC |
| 13:40:50 | *** diptanuc has joined #openmrs |
| 13:52:06 | *** mvorobey has joined #openmrs |
| 13:52:11 | <mvorobey> hi all |
| 13:52:58 | *** harshadura has joined #openmrs |
| 13:55:28 | <dkayiwa> hi goutham |
| 13:55:38 | *** grahameg has joined #openmrs |
| 13:58:36 | <goutham> dkayiwa: hey seen it? |
| 13:59:55 | <dkayiwa> goutham: can you also put the negative tests? |
| 14:00:20 | <dkayiwa> goutham: like for shouldNotDisplayForm |
| 14:00:56 | *** cpower has joined #openmrs |
| 14:00:59 | <goutham> dkayiwa: shouldNotDisplayForm will have? |
| 14:01:12 | <dkayiwa> goutham: meaning??? |
| 14:01:38 | *** bwolfe__ has joined #openmrs |
| 14:01:49 | *** bwolfe__ is now known as bwolfe |
| 14:01:50 | *** lakkarau has joined #openmrs |
| 14:01:54 | *** ChanServ sets mode: +o bwolfe |
| 14:02:02 | <goutham> dkayiwa: what is the functionality of shouldNotDisplayForm ? |
| 14:02:03 | *** venkaban has joined #openmrs |
| 14:02:15 | <cpower> Good morning, afternoon, and evening everyone! |
| 14:02:18 | <cpower> ready to Scrum! |
| 14:02:23 | <dkayiwa> goutham: to have the test return false for a form it is not supposed to display |
| 14:02:38 | <lakkarau> cpower:good morning |
| 14:03:02 | <cpower> Are we ready to begin? |
| 14:03:13 | <rafa> hey |
| 14:03:17 | <cpower> !scrumon cpower |
| 14:03:17 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 14:03:35 | *** jordank has joined #openmrs |
| 14:04:32 | <cpower> Order: bwolfe, djazayeri, rafa, dkayiwa, lakkarau, mvorobey (if any), venkaban |
| 14:04:57 | <bwolfe> Thursday |
| 14:04:57 | <bwolfe> triaged TRUNK-3565 |
| 14:04:57 | <bwolfe> triaged RCM-88 |
| 14:04:57 | <bwolfe> triaged REST-8 |
| 14:04:57 | <bwolfe> triaged RESTWS-267 |
| 14:04:57 | <bwolfe> readded log4j.xml to HFE |
| 14:04:59 | <bwolfe> triaged TRUNK-3564 |
| 14:05:01 | <bwolfe> reviewed TRUNK-239, tribe module error display |
| 14:05:03 | <bwolfe> reviewed/approved/closed several blocker backlog tickets |
| 14:05:05 | <bwolfe> looked into performance war on buea |
| 14:05:07 | <bwolfe> Friday |
| 14:05:09 | <bwolfe> fixed rcm to release nicely |
| 14:05:11 | <bwolfe> released version of rcm |
| 14:05:13 | <bwolfe> chat with Patrick/Paul |
| 14:05:15 | <bwolfe> more bug fixes and reviews |
| 14:05:17 | <bwolfe> triaged a crap ton of tickets |
| 14:05:19 | <bwolfe> applied |
| 14:05:21 | <bwolfe> worked on performace testing upgrade |
| 14:05:23 | <bwolfe> no blockers |
| 14:05:27 | <bwolfe> whoops, not sure what that "applied" one was supposed to be... |
| 14:06:41 | <cpower> djazayeri..you are up |
| 14:07:37 | <cpower> next..rafa |
| 14:07:42 | <rafa> Wednesday (US holiday): |
| 14:07:42 | <rafa> * Trying to reproduce XFRM-71: XForms sometimes doesn't save changes done in Form Designer |
| 14:07:42 | <rafa> https://tickets.openmrs.org/browse/XFRM-71 |
| 14:07:42 | <rafa> * Trying XFRM-68: Integrate patient UUID in forms and XFRM-30: Fill relationship widget with existing relationships doing form entry, |
| 14:07:42 | <rafa> but no progress without Daniel |
| 14:07:42 | <rafa> Blockers: it's unfortunate that Daniel is busy with other things during the xforms sprint |
| 14:07:42 | <rafa> Thursday (missed the scrum): |
| 14:07:43 | <rafa> * Committed XFRM-33: Send email notification when error in uploading xform |
| 14:07:43 | <rafa> https://tickets.openmrs.org/browse/XFRM-33 |
| 14:07:44 | <rafa> No blockers. |
| 14:07:44 | <rafa> Today: |
| 14:07:45 | <rafa> * Working on XFRM-30: Fill relationship widget with existing relationships doing form entry. |
| 14:07:45 | <rafa> https://tickets.openmrs.org/browse/XFRM-30 |
| 14:07:46 | <rafa> * Will try to do XFRM-68: Integrate patient UUID in forms |
| 14:07:46 | <rafa> https://tickets.openmrs.org/browse/XFRM-68 |
| 14:07:47 | <rafa> No blockers. |
| 14:08:21 | <dkayiwa> Had some discussions with Ryan (Jembi) about the HL7 support we have in the REST webservice module |
| 14:08:23 | <dkayiwa> Looked at a few xforms tickets and made some comments |
| 14:08:23 | <dkayiwa> Reviewed Goutham's code |
| 14:08:23 | <dkayiwa> About to board for Entebbe |
| 14:08:23 | <dkayiwa> No Blockers |
| 14:08:26 | *** grahameg has quit IRC |
| 14:08:36 | <lakkarau> Thursday: |
| 14:08:36 | <lakkarau> #trunk 3399 attached the patch. |
| 14:08:36 | <lakkarau> added comments on ticket #XFRM-79 |
| 14:08:36 | <lakkarau> Today: |
| 14:08:37 | <lakkarau> working on #XFRM-79 |
| 14:08:37 | <lakkarau> #xFRM-62 |
| 14:08:43 | <lakkarau> no blockers |
| 14:08:45 | <mvorobey> * Preparing v1.2 release of CSTM module |
| 14:08:45 | <mvorobey> * Committed a bunch of CSTM tickets for v1.3 |
| 14:08:45 | <mvorobey> No blockers |
| 14:09:45 | <cpower> venkaban you are up.. |
| 14:10:29 | <venkaban> tested XFRM-80 in FF successfully |
| 14:10:37 | <venkaban> check the issue in chrome |
| 14:10:55 | <venkaban> blockers, checking in chrome |
| 14:11:39 | <cpower> Any one else have something to contribute? |
| 14:12:37 | <cpower> No Discussion points |
| 14:13:11 | <cpower> Blockers: Daniel's time, Chrome |
| 14:13:18 | <cpower> !scrumoff |
| 14:13:18 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 14:14:04 | <bwolfe> dkayiwa, are you delayed getting home? shouldn't you already be there by now?? |
| 14:14:23 | <bwolfe> dkayiwa, look forward to a full report about what you learned/taught/discovered/ate while in rwanda. :-) |
| 14:14:25 | <dkayiwa> bwolfe: the flight is at 4:45 |
| 14:14:33 | <dkayiwa> bwolfe: hahaha :) |
| 14:14:36 | <bwolfe> !ticket XFRM-62 |
| 14:14:37 | <OpenMRSBot> bwolfe: [#XFRM-62] Automated Error Report: java.lang.NumberFormatException: For input string: "" - OpenMRS JIRA - https://tickets.openmrs.org/browse/XFRM-62 |
| 14:14:50 | <goutham> dkayiwa: i had written it in the same method Assert.assertFalse("Filter role matches even user has no roles",roleFormFilter.shouldDisplayForm(new Patient(), new User())); |
| 14:15:02 | <bwolfe> !ticket XFRM-79 |
| 14:15:03 | <OpenMRSBot> bwolfe: [#XFRM-79] Need to include obs_datetime on xform designer - OpenMRS JIRA - https://tickets.openmrs.org/browse/XFRM-79 |
| 14:15:19 | <dkayiwa> goutham: write it as a different method |
| 14:15:26 | <lakkarau> bwolfe :yes |
| 14:16:19 | <lakkarau> bwolfe:There was a fix in the purcforms widget which the xforms module uses. |
| 14:16:41 | <bwolfe> lakkarau, for which one? |
| 14:16:48 | <bwolfe> *which ticket |
| 14:17:03 | <lakkarau> #XFRM-79 |
| 14:19:19 | <lakkarau> bwolfe:it is fixed and now i can work on #XFRM-79 |
| 14:20:16 | *** venkaban_ has joined #openmrs |
| 14:21:05 | <bwolfe> lakkarau, ok, try to keep the ticket updated. Seems Lauren/Ada would like status updates. :-) |
| 14:21:21 | <lakkarau> bwolfe:yes sir |
| 14:22:30 | *** venkaban has quit IRC |
| 14:23:16 | <jkeiper> ugh ... i hate timed tests |
| 14:23:29 | <goutham> dkayiwa: changes made ! shall i commit the code? |
| 14:23:32 | * jkeiper stops all other apps so openmrs can compile |
| 14:23:38 | <dkayiwa> goutham: yes |
| 14:28:32 | *** lakkarau has quit IRC |
| 14:30:00 | <goutham> dkayiwa: commited :) |
| 14:30:09 | <dkayiwa> goutham: thanks. let me look at it |
| 14:39:50 | *** lh has joined #openmrs |
| 14:40:37 | *** lh has joined #openmrs |
| 14:40:44 | *** lh has joined #openmrs |
| 14:43:03 | <goutham> dkayiwa: are the filters working? |
| 14:43:17 | <dkayiwa> goutham: checking.... |
| 14:44:09 | * goutham tensed @_@ |
| 14:44:53 | *** rafa has quit IRC |
| 14:47:14 | *** diptanuc has quit IRC |
| 14:50:33 | *** dkayiwa has quit IRC |
| 14:51:07 | *** dkayiwa has joined #openmrs |
| 15:01:37 | <goutham> dkayiwa: :) |
| 15:01:57 | <dkayiwa> goutham: by for now. boarding time :) |
| 15:02:10 | <dkayiwa> goutham: see you later. will respond via email |
| 15:03:31 | <goutham> dkayiwa: Happy Journey : ) |
| 15:05:31 | *** mvorobey has quit IRC |
| 15:06:23 | *** dkayiwa has quit IRC |
| 15:10:00 | *** goutham has quit IRC |
| 15:39:47 | *** suranga has joined #openmrs |
| 15:39:47 | *** ChanServ sets mode: +v suranga |
| 15:40:04 | <suranga> good morning james_regen |
| 15:40:20 | <suranga> james_regen, are you here ? any chance of asking a quick question ? :) |
| 15:41:22 | *** lh has quit IRC |
| 15:49:55 | <james_regen> suranga: hi |
| 15:50:17 | <suranga> james_regen, sorry to bug you, but we have a tiny problem in our hands... |
| 15:50:26 | <suranga> james_regen, let me write it up for you... |
| 15:50:43 | <james_regen> ok |
| 15:54:04 | *** jriley has quit IRC |
| 15:55:00 | <suranga> james_regen, here goes------------------------------ |
| 15:55:00 | <suranga> for task 3, we are moving the patient reports into the database. |
| 15:55:01 | <suranga> we have finished this code. |
| 15:55:01 | <suranga> to test if this works, we need to run a patientmatching report which identifies one or more record pairs |
| 15:55:01 | <suranga> the problem is, we always used link.regenstrief for finding pairs because its rich in data. |
| 15:55:01 | <suranga> Since that server is down, we doint have a way to test successful report storage |
| 15:55:03 | <suranga> We tried this with demo databases, but our local machines are not powerful enough to run a big matching report that will return results |
| 15:55:05 | <suranga> do you have any idea of a worksaround we can use for testing ? somewhere we can hard code for now ? |
| 15:55:07 | <suranga> ----------------------- |
| 15:56:10 | <james_regen> can you create a strategy that results in few pairs? |
| 15:58:39 | <suranga> james_regen, umm.. we tried. but everything falls short... |
| 15:59:10 | <suranga> james_regen, the only way to get good results is to use a very wide query, but our machines are not powerful enough :( |
| 15:59:16 | *** bwolfe has quit IRC |
| 16:00:09 | <suranga> james_regen, for example, I created a report with 400K estimated result pairs. this should have returned results, but failed because of the high processing needs :( |
| 16:00:24 | <james_regen> suranga: was there an error message with it? |
| 16:01:02 | *** lh has joined #openmrs |
| 16:01:02 | *** lh has joined #openmrs |
| 16:01:08 | *** cpower has quit IRC |
| 16:01:54 | <suranga> james_regen, afraid not, it just failed to go beyond the scratch table phase |
| 16:02:55 | <suranga> james_regen, this is basically the same problem ada had, not being able to retrive matching fields because she used only a few must + should fields... |
| 16:04:30 | <james_regen> suranga: i can't remember how that problem was resolved. did she just have to choose different fields that worked better? |
| 16:04:41 | <suranga> james_regen, yep, afraid so |
| 16:05:09 | <suranga> james_regen, task 4 ( suggesting better matching fields) is aimed at solving this :) |
| 16:05:32 | <james_regen> suranga: are there any other fields in the demo data we can choose to get something working? |
| 16:06:17 | <suranga> james_regen, we both tried yesterday, but failed to get anything up.... which is why we were hoping for a quick fix for testing now.... :( |
| 16:06:33 | <suranga> james_regen, then when link.regenstfief goes up again, we will be ready :) |
| 16:08:03 | *** mccallumg has joined #openmrs |
| 16:08:03 | *** ChanServ sets mode: +v mccallumg |
| 16:08:19 | <james_regen> suranga: i guess if you want to hard code values you can comment out the steps to import the data to the scratch table, and then update the values in the table however you want them to be |
| 16:09:05 | <suranga> james_regen, aha, thanks, but wont it be easier to alter public MatchResult scorePair(Record rec1, Record rec2) ? |
| 16:09:13 | <suranga> james_regen, (just wondering...) |
| 16:10:45 | <james_regen> suranga: depends where the problem is. if you're not getting any pairs, then you can alter the table to get pairs to score and to store. if you are getting pairs, then you're getting MatchResult objects to store |
| 16:12:55 | *** bwolfe has joined #openmrs |
| 16:12:55 | *** ChanServ sets mode: +o bwolfe |
| 16:20:58 | *** rfilippi has joined #openmrs |
| 16:22:39 | <rfilippi> bwolfe: taking another look at the $() to jQuery() story TRUNK-3408 - I've gone through things with a little more care and I've got another patch for you - is there a way to remove the previously added patches to the ticket or how should I proceed ? |
| 16:25:25 | *** venkaban_ has quit IRC |
| 16:27:16 | *** pushkar has joined #openmrs |
| 16:35:23 | <bwolfe> rfilippi, just upload another one. I look at dates to know which one to apply |
| 16:35:25 | *** rfilippi has quit IRC |
| 16:37:06 | *** sthaiya has joined #openmrs |
| 16:44:57 | <suranga> hi james_regen .. by editing the config.xml files (stored on local machine) I was able to produce a non null repot... |
| 16:52:28 | *** venkaban has joined #openmrs |
| 16:52:53 | *** jordank has quit IRC |
| 16:59:15 | *** jordank has joined #openmrs |
| 17:05:00 | <suranga> james_regen, hi.. mmm... could you maybe suggest a way for us to 'hard code' record pairs as matches ? |
| 17:12:24 | *** goutham has joined #openmrs |
| 17:14:50 | <james_regen> suranga: so you're getting enough pairs to store, you just need to set some as matches so that they are stored in the report? |
| 17:15:09 | <suranga> james_regen, exactly ! :-) |
| 17:15:28 | <suranga> james_regen, this will be really helpful for our testing :) |
| 17:16:45 | <james_regen> suranga: in the scorePairs class, you can change mv.setMatch(comparison_demographic, match); to mv.setMatch(comparison_demographic, true); |
| 17:17:33 | <james_regen> that will have every pair match on every field. that'll give it the highest score, and it'll be in the output as true matches, even if the results won't make sense. and hopefully there aren't too many pairs, or you'll end up with a very large report |
| 17:18:08 | <suranga> james_regen, cool ! this will do just fine :-) |
| 17:18:43 | <james_regen> suranga: no problem, good luck with the testing |
| 17:29:55 | *** bwolfe has quit IRC |
| 17:40:49 | <suranga> james_regen, umm.. hi... i tried that.. but im afraid it doesnt seem to work :( |
| 17:42:12 | <james_regen> suranga: that's surprising. the results weren't being changed at all? |
| 17:43:10 | *** bwolfe has joined #openmrs |
| 17:43:10 | *** ChanServ sets mode: +o bwolfe |
| 17:43:23 | <suranga> james_regen, um... u are refering to ScorePair.java, and NOT ScorePairs.java, right ? |
| 17:45:12 | <james_regen> suranga: yeah, i think we are both talking about the same one. in the util package |
| 17:45:58 | <suranga> james_regen, im getting (log console) |
| 17:45:59 | <suranga> Blocking columns: |
| 17:46:00 | <suranga> org.openmrs.PersonName.familyName |
| 17:46:00 | <suranga> P: 0.45 |
| 17:46:00 | <suranga> Total pairs processed: 5222 |
| 17:46:00 | <suranga> Estimated true matches: 2349.9 |
| 17:46:00 | <suranga> Estimated non matches: 2872.1000000000004 |
| 17:46:02 | <suranga> previous score threshold: 0.0 |
| 17:46:04 | <suranga> new score threshold: 0.0 |
| 17:46:12 | <suranga> but identified pairs = 0 |
| 17:46:15 | <suranga> hmmmmmmm |
| 17:47:17 | <james_regen> suranga: i'd guess that looks reasonable with test data. and it's finding pairs that should be scored as matches ,and should end up in the report |
| 17:47:42 | *** jblaya has joined #openmrs |
| 17:47:56 | <suranga> james_regen, :-( hmmmmmm\ |
| 17:58:16 | *** sthaiya has quit IRC |
| 18:21:29 | *** kreddy has joined #openmrs |
| 18:22:46 | *** lakkarau has joined #openmrs |
| 18:31:11 | *** jblaya has quit IRC |
| 18:32:26 | <pushkar> bwolfe, Hi |
| 18:33:10 | <bwolfe> hey |
| 18:33:45 | *** robbyoconnor has joined #openmrs |
| 18:33:45 | *** ChanServ sets mode: +v robbyoconnor |
| 18:34:28 | <pushkar> bwolfe, I was thinking of using gmapimageviewers annotation saving to save annotations in my module what do you think about it ? |
| 18:35:58 | <bwolfe> I'm not familiar with out they do it |
| 18:36:06 | <bwolfe> are you copying code, or depending on that module? |
| 18:36:11 | *** james_regen has quit IRC |
| 18:38:34 | <pushkar> bwolfe, depending instead of using image handler I was thinking of using AnnotatedImageHandler |
| 18:49:00 | <pushkar> bwolfe, Most of the code for managing annotations is already written I just have to find a way to use it in my module |
| 18:49:36 | <bwolfe> cool, reusing (or copying) code is always good :-) |
| 18:49:41 | <bwolfe> reuse >> rewrite |
| 18:49:42 | <bwolfe> :-) |
| 18:52:14 | <kreddy> hey suranga, you there? |
| 18:57:25 | <pushkar> :-) |
| 19:00:07 | *** pushkar has quit IRC |
| 19:26:47 | <jkeiper> bwolfe, djazayeri, whoever ... if my checkout is from https://svn.... will "maven release:prepare" not work? |
| 19:27:23 | <bwolfe> it will. you just have to match the repo element in the pom.xml |
| 19:27:32 | <jkeiper> zoinks |
| 19:27:45 | <jkeiper> after you run it once, will it not work anymore? |
| 19:27:51 | <jkeiper> looks like i have to start over again .. |
| 19:28:12 | <jkeiper> it's half-committed, looks like |
| 19:29:08 | <bwolfe> do a release:prepare again and it starts where you left off |
| 19:29:21 | <bwolfe> or if are done with that step, do the release:perform step |
| 19:29:23 | <jordank> hi mccallumg |
| 19:29:28 | <mccallumg> hi jordank |
| 19:30:27 | <jordank> mccallumg: quick question... my jsp files except for chooseConcepts.jsp in eclipse have the little question mark next to them |
| 19:30:41 | <jkeiper> bwolfe, it ain't |
| 19:30:46 | <mccallumg> that might have to do with version control. does it? |
| 19:30:50 | * jkeiper just starts over again one step back |
| 19:31:17 | <bwolfe> jkeiper, theres a release:rollback or something htat does that for you |
| 19:31:33 | <jordank> mccallumg: not sure |
| 19:31:41 | <jkeiper> ahha |
| 19:31:46 | <jkeiper> next time i'll try that :-D |
| 19:31:54 | <mccallumg> jordank: try adding them to your svn repository |
| 19:32:56 | <jordank> mccallumg: "add to version control" or "team -> commit"? |
| 19:35:42 | <mccallumg> jordank: the normal workflow is to add to subversion then commit (I'm not the best eclipse person around) |
| 19:36:40 | <jordank> mccallumg: ok I'll find out :) |
| 19:36:47 | <jordank> thanks |
| 19:37:00 | <jkeiper> release:rollback ftw |
| 19:37:04 | *** lakkarau has quit IRC |
| 20:08:28 | *** lh has quit IRC |
| 20:09:52 | *** jkeiper has quit IRC |
| 20:15:28 | *** bwolfe has quit IRC |
| 20:18:07 | *** lakkarau has joined #openmrs |
| 20:18:08 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Data Integrity 2.0 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=dataintegrity&version=&2.0> |
| 20:18:25 | *** mccallumg has quit IRC |
| 20:18:46 | *** mccallumg has joined #openmrs |
| 20:18:46 | *** ChanServ sets mode: +v mccallumg |
| 20:23:13 | *** suranga has quit IRC |
| 20:35:25 | *** goutham has quit IRC |
| 20:38:08 | *** mccallumg_ has joined #openmrs |
| 20:38:09 | *** ChanServ sets mode: +v mccallumg_ |
| 20:38:09 | *** mccallumg has quit IRC |
| 20:38:09 | *** mccallumg_ is now known as mccallumg |
| 20:48:20 | *** venkaban has quit IRC |
| 21:05:34 | *** lh has joined #openmrs |
| 21:05:34 | *** lh has joined #openmrs |
| 21:08:07 | *** lakkarau has quit IRC |
| 21:23:28 | *** robbyoconnor has quit IRC |
| 21:24:32 | *** robbyoconnor has joined #openmrs |
| 21:24:32 | *** ChanServ sets mode: +v robbyoconnor |
| 21:30:18 | *** rfilippi has joined #openmrs |
| 21:34:46 | *** mccallumg has quit IRC |
| 21:40:50 | *** rfilippi has quit IRC |
| 22:02:52 | *** kreddy has quit IRC |
| 22:07:15 | *** jordank has quit IRC |
| 22:13:10 | *** wyclif has joined #openmrs |
| 22:56:16 | *** lh has quit IRC |
| 23:44:34 | *** robbyoconnor has quit IRC |
| 23:45:10 | *** robbyoconnor has joined #openmrs |
| 23:45:10 | *** ChanServ sets mode: +v robbyoconnor |