00:02:40
|
*** r0bby has joined #openmrs
|
00:02:40
|
*** ChanServ sets mode: +v r0bby
|
00:03:07
|
*** robbyoconnor has quit IRC
|
00:03:12
|
*** r0bby is now known as robbyoconnor
|
00:41:24
|
*** jordank has joined #openmrs
|
00:53:34
|
*** deadpool has quit IRC
|
01:29:14
|
*** jordank has quit IRC
|
01:44:30
|
*** bwolfe has joined #openmrs
|
01:44:30
|
*** ChanServ sets mode: +o bwolfe
|
02:53:57
|
*** bwolfe has quit IRC
|
02:54:03
|
*** bwolfe_ has joined #openmrs
|
02:54:03
|
*** ChanServ sets mode: +o bwolfe_
|
04:16:41
|
*** upul` has joined #openmrs
|
04:16:41
|
*** ChanServ sets mode: +v upul`
|
04:17:16
|
*** bwolfe_ has quit IRC
|
04:53:48
|
*** kishoreyekkanti has joined #openmrs
|
05:35:42
|
<kishoreyekkanti> wyclif: Hey Wyclif, any idea if i can start OpenMRS from maven with the default log level of "warn"?
|
06:14:05
|
*** deepaganu has joined #openmrs
|
06:17:45
|
<deepaganu> hi upul`
|
06:18:09
|
<deepaganu> hi robbyoconnor
|
06:19:08
|
*** dkayiwa has joined #openmrs
|
06:19:12
|
<deepaganu> hidk
|
06:19:16
|
<deepaganu> hi dkayiwa
|
06:19:22
|
<dkayiwa> hi deepaganu
|
06:19:38
|
<deepaganu> i need to display the error from the controller to the jsp
|
06:19:41
|
<deepaganu> request.setAttribute(WebConstants.OPENMRS_ERROR_ATTR, Context.getMessageSourceService().getMessage(
|
06:19:41
|
<deepaganu> "ExportCCD.concept.not.saved"), WebRequest.SCOPE_SESSION);
|
06:19:46
|
<deepaganu> is this corrent
|
06:20:09
|
<dkayiwa> deepaganu: did you try it out and see what happens? :)
|
06:20:31
|
<deepaganu> ya i am doign that now
|
06:20:40
|
<dkayiwa> deepaganu: ok
|
06:23:31
|
*** harshadura has joined #openmrs
|
06:25:05
|
*** dkayiwa has quit IRC
|
06:27:51
|
*** deepaganu has quit IRC
|
06:29:10
|
*** deepaganu has joined #openmrs
|
06:32:35
|
<robbyoconnor> hey deepaganu
|
06:32:35
|
*** mgielow has joined #openmrs
|
06:32:46
|
<deepaganu> hey robbyoconnor
|
06:32:51
|
<robbyoconnor> what's up?
|
06:32:56
|
<deepaganu> i got it what i wanted to ask
|
06:32:56
|
<robbyoconnor> I'm heading to bed
|
06:33:01
|
<deepaganu> going good thanks
|
06:33:04
|
<deepaganu> thats ok
|
06:33:24
|
<robbyoconnor> what'd you need?
|
06:38:16
|
<robbyoconnor> How's GSoC going for you?
|
06:42:28
|
*** dkayiwa has joined #openmrs
|
06:49:31
|
*** mgielow has quit IRC
|
07:05:40
|
*** deepaganu has quit IRC
|
07:07:27
|
*** mgielow has joined #openmrs
|
07:12:21
|
*** magoo_ has joined #openmrs
|
07:24:08
|
*** magoo_ has quit IRC
|
07:34:16
|
*** orien has quit IRC
|
07:38:00
|
*** deepaganu has joined #openmrs
|
07:42:36
|
*** dkayiwa has quit IRC
|
07:55:46
|
<deepaganu> hi upul`
|
07:55:49
|
<deepaganu> are you there
|
07:55:56
|
<deepaganu> hi kishoreyekkanti
|
08:07:54
|
*** deepaganu has quit IRC
|
08:13:03
|
*** harshadura has quit IRC
|
08:13:48
|
*** dkayiwa has joined #openmrs
|
08:17:56
|
*** rafa has joined #openmrs
|
08:17:56
|
*** ChanServ sets mode: +v rafa
|
08:46:45
|
*** deepaganu has joined #openmrs
|
08:49:53
|
<deepaganu> Hi rafa
|
08:50:06
|
<deepaganu> i hope i am not disturbing you
|
08:55:45
|
*** goutham has joined #openmrs
|
09:00:34
|
*** kishoreyekkanti_ has joined #openmrs
|
09:03:56
|
*** kishoreyekkanti has quit IRC
|
09:04:20
|
*** deepaganu has quit IRC
|
09:07:05
|
*** upul` has quit IRC
|
09:42:44
|
*** kishoreyekkanti_ has quit IRC
|
09:48:04
|
*** kishoreyekkanti has joined #openmrs
|
09:51:54
|
*** dkayiwa_ has joined #openmrs
|
09:53:59
|
*** dkayiwa has quit IRC
|
09:53:59
|
*** dkayiwa_ is now known as dkayiwa
|
10:04:59
|
*** kishoreyekkanti has quit IRC
|
10:05:16
|
*** kishoreyekkanti has joined #openmrs
|
10:12:22
|
*** deepaganu has joined #openmrs
|
10:12:31
|
<deepaganu> hi all
|
10:12:40
|
*** mgielow has quit IRC
|
10:13:08
|
*** orien has joined #openmrs
|
10:13:28
|
<deepaganu> hi dkayiwa
|
10:14:10
|
<dkayiwa> hi deepaganu
|
10:33:36
|
<deepaganu> dkayiwa: i have a sqldiff file in which i have defined the create table statement but when i deploy my module the table does not get created
|
10:33:58
|
<dkayiwa> deepaganu: do you get any tomcat errors?
|
10:35:32
|
<deepaganu> no
|
10:42:33
|
*** kishoreyekkanti_ has joined #openmrs
|
10:43:37
|
*** kishoreyekkanti_ has quit IRC
|
10:43:54
|
*** kishoreyekkanti_ has joined #openmrs
|
10:44:35
|
*** kishoreyekkanti has quit IRC
|
10:57:55
|
*** dkayiwa has quit IRC
|
11:00:50
|
*** deepaganu has quit IRC
|
11:03:11
|
*** applecool has joined #openmrs
|
11:03:11
|
*** ChanServ sets mode: +v applecool
|
11:04:47
|
<applecool> hi rafa
|
11:05:01
|
<rafa> applecool: hi
|
11:05:22
|
<applecool> checking your comments! i think i made some cruel mistakes!
|
11:07:54
|
<rafa> applecool: well I don't know why you hardcoded page number
|
11:08:06
|
<applecool> actually i was testing it rafa
|
11:08:12
|
<rafa> applecool: ahh ok
|
11:08:31
|
<applecool> i made a comment on the commit too that i hardcoded it for testing :)
|
11:08:33
|
<rafa> applecool: does the table widget display page numbers?
|
11:08:38
|
<applecool> yes
|
11:08:42
|
<applecool> it is!
|
11:08:45
|
<rafa> applecool: nice
|
11:09:03
|
<applecool> just a second! i will just grab a screenshot and send you!
|
11:11:45
|
<applecool> rafa: i sent it
|
11:12:06
|
*** orien has quit IRC
|
11:12:18
|
<rafa> applecool: looks good
|
11:12:37
|
<rafa> applecool: I really like appfuse :)
|
11:12:51
|
<applecool> even i fell in love with it :D
|
11:13:04
|
<applecool> thanks for introducing it to me rafa :)
|
11:13:08
|
<rafa> applecool: does jetty work for you now?
|
11:13:27
|
<applecool> you mean the auto build?
|
11:13:29
|
<rafa> applecool: I mean reloading
|
11:13:33
|
<rafa> applecool: yes
|
11:13:43
|
<applecool> RAM speed!
|
11:13:49
|
<applecool> taking little time though
|
11:13:58
|
<rafa> applecool: I see
|
11:14:09
|
<rafa> applecool: RAM is cheap you should add some :)
|
11:15:01
|
<rafa> applecool: so will you be done with pagination by tomorrow?
|
11:16:01
|
<applecool> i will try to complete it by today it self
|
11:16:08
|
<applecool> i am doing so late
|
11:16:11
|
<applecool> my bad!
|
11:16:17
|
<applecool> but will complete it
|
11:16:46
|
<rafa> applecool: you will need new tasks after that right?
|
11:16:52
|
<applecool> yes
|
11:17:18
|
<applecool> would you like to give them right now?
|
11:17:22
|
<applecool> or later?
|
11:17:32
|
<rafa> applecool: I will need to sit down and click through the whole app
|
11:17:56
|
<applecool> oh!
|
11:18:11
|
<rafa> applecool: I expect to find bugs and enter tickets for you
|
11:18:13
|
<applecool> for that then i need to make the present things working very fine!
|
11:18:20
|
<applecool> oh k :)
|
11:18:34
|
<rafa> applecool: yes, you have time till Saturday
|
11:18:41
|
<applecool> okay :)
|
11:18:48
|
<applecool> will do it :)
|
11:18:57
|
<rafa> applecool: we'll start working with tickets
|
11:19:03
|
<applecool> and we can have a hacking session too if you are free :)
|
11:19:18
|
<applecool> in the next week
|
11:19:18
|
<rafa> applecool: let's use github for that
|
11:19:20
|
*** james_regen has joined #openmrs
|
11:19:20
|
*** ChanServ sets mode: +v james_regen
|
11:19:24
|
<rafa> applecool: cool
|
11:19:32
|
<applecool> github for?
|
11:19:36
|
<applecool> i dint get that line
|
11:19:39
|
<rafa> applecool: github ticekts
|
11:19:46
|
<applecool> oh! okay :)
|
11:20:13
|
<applecool>
|
11:20:26
|
<applecool> actually i am commuting :)
|
11:20:35
|
<applecool> i am almost alone in the entire bus :)
|
11:22:55
|
<applecool> rafa: is this line correct? request = newPost("/packageupload.html");
|
11:23:14
|
<applecool> or it should be newGet() ?
|
11:24:06
|
<rafa> applecool: it's post
|
11:24:17
|
<rafa> applecool: you post data to the server
|
11:24:34
|
<applecool> hmm! yes! but i am getting an eclipse error!
|
11:24:48
|
<rafa> applecool: what error?
|
11:25:27
|
<applecool> a quickfix for newGet() and if i change it to newGet() its showing me a quick fix for newPost()
|
11:25:48
|
<applecool> The method newGet(String) is undefined for the type FileUploadControllerTest
|
11:25:53
|
*** diptanuc has joined #openmrs
|
11:26:13
|
<rafa> applecool: clean the project
|
11:26:22
|
<applecool> okay :)
|
11:32:07
|
<applecool> i will get back rafa need to get down
|
11:32:08
|
<applecool> cya
|
11:32:15
|
*** applecool has quit IRC
|
11:38:16
|
*** diptanuc has quit IRC
|
11:41:28
|
*** deepaganu has joined #openmrs
|
11:41:36
|
<deepaganu> hi rafa
|
11:41:43
|
<rafa> deepaganu: hi
|
11:41:52
|
<deepaganu> do you know how to use detached queries in hibernate
|
11:41:59
|
<deepaganu> i have a query like this Select * from concept where concept_id in (Select concept_id from export_ccd_section_concept_map where category="VitalSigns");
|
11:42:42
|
<rafa> deepaganu: yes
|
11:43:07
|
<rafa> deepaganu: where is the problem?
|
11:43:47
|
<deepaganu> i dont want to use a direct sql query
|
11:44:05
|
<deepaganu> but want the hql to do it in terms of detached query
|
11:44:25
|
<deepaganu> coz i guess OpenMRS doesnt approve direct sql queries
|
11:44:28
|
<deepaganu> isn'it
|
11:44:31
|
<deepaganu> rafa:
|
11:45:18
|
<rafa> deepaganu: yes
|
11:45:28
|
<rafa> deepaganu: why do you need it to be a detached query?
|
11:45:29
|
*** bwolfe_ has joined #openmrs
|
11:45:30
|
*** ChanServ sets mode: +o bwolfe_
|
11:46:02
|
<deepaganu> i have nested sql queries
|
11:46:22
|
<deepaganu> how do i convert them into criteria
|
11:46:34
|
<deepaganu> i am quite new to hibernate
|
11:46:44
|
<rafa> deepaganu: actually it'll be more efficient if you first execute Select concept_id from export_ccd_section_concept_map where category="VitalSigns"
|
11:47:02
|
<rafa> deepaganu: and take results and execute Select * from concept where concept_id in (results)
|
11:47:27
|
<rafa> deepaganu: no need for a nested query here
|
11:48:38
|
<deepaganu> is it a good design
|
11:48:52
|
<rafa> deepaganu: and you can simply use sessionFactory.getCurrentSession().createQuery()
|
11:49:02
|
<deepaganu> i mean i was thinking at oneshot we would get the list of concepts
|
11:49:49
|
<rafa> deepaganu: putting a query in where clause is very inefficient
|
11:50:09
|
<rafa> deepaganu: becasue it's calculated for each row
|
11:50:18
|
<rafa> deepaganu: you're better off with a join in this case
|
11:50:55
|
<deepaganu> ok
|
11:51:26
|
<deepaganu> so by using join i candirectly execute the query
|
11:52:44
|
<deepaganu> hey rafa where r u from
|
11:53:17
|
<rafa> deepaganu: Poland
|
12:00:30
|
<deepaganu> so should i execute the inner join then using createQuery()
|
12:03:43
|
<rafa> deepaganu: http://docs.jboss.org/hibernate/orm/3.3/reference/en/html/queryhql.html
|
12:03:47
|
<OpenMRSBot> <http://ln-s.net/$5qg> (at docs.jboss.org)
|
12:05:00
|
*** deepaganu has quit IRC
|
12:17:07
|
<rafa> wyclif: hi, do you know how to get the design xform link to be displayed when editing a form?
|
12:17:36
|
<rafa> wyclif: I had it in 1.10.x, but now trying 1.6.x and there's no sign of xforms :/
|
12:21:39
|
<rafa> bwolfe_: there?
|
12:21:58
|
*** bwolfe_ is now known as bwolfe
|
12:21:59
|
<bwolfe> hi rafa
|
12:22:06
|
<rafa> bwolfe: hi
|
12:22:15
|
<rafa> bwolfe: do you know an answer to the above?
|
12:22:20
|
<bwolfe> rafa, did the module load correctly?
|
12:22:26
|
<rafa> bwolfe: yes
|
12:22:37
|
<rafa> bwolfe: I see links on the administration page
|
12:22:44
|
<bwolfe> 1.6 has both a Edit Form and an Edit Form Schema, right?
|
12:23:25
|
<rafa> bwolfe: I got to Manage Forms, click a form and it opens edit metadata
|
12:23:33
|
<rafa> bwolfe: there's schema design
|
12:23:45
|
<rafa> but no xform designer :(
|
12:24:22
|
<bwolfe> why are you worrying about 1.6.x?
|
12:24:29
|
<bwolfe> rafa, did the extension point change names??
|
12:24:51
|
<rafa> bwolfe: I just wanted to reproduce https://tickets.openmrs.org/browse/XFRM-71
|
12:25:24
|
<rafa> bwolfe: it works on 1.10 so I wanted to try 1.6
|
12:25:31
|
*** kishoreyekkanti_ has quit IRC
|
12:26:26
|
<bwolfe> rafa, are you using that version of xforms?
|
12:26:55
|
<rafa> bwolfe: Joaquin see the problem in the latest version of xforms as well
|
12:28:10
|
*** applecool has joined #openmrs
|
12:28:10
|
*** ChanServ sets mode: +v applecool
|
12:30:00
|
<bwolfe> rafa, perhaps its something in the concept that he is using? whitespace in the name? extra character? no description? etc
|
12:31:21
|
<rafa> bwolfe: hmmmm
|
12:35:12
|
*** kishoreyekkanti has joined #openmrs
|
12:35:51
|
*** kishoreyekkanti has joined #openmrs
|
12:39:12
|
*** kishoreyekkanti has quit IRC
|
12:39:54
|
*** dkayiwa has joined #openmrs
|
13:02:14
|
<dkayiwa> hi bwolfe
|
13:02:21
|
<bwolfe> hi dkayiwa
|
13:02:47
|
<dkayiwa> bwolfe: did we ever fix the problem where a scheduled reporting task locks a user out of openmrs?
|
13:03:02
|
<dkayiwa> bwolfe: as in login attempts exceed and account gets locked
|
13:03:05
|
<bwolfe> dkayiwa, yeah
|
13:03:06
|
*** 31NABOOB2 has joined #openmrs
|
13:03:16
|
<dkayiwa> bwolfe: but it is still happening
|
13:03:20
|
<bwolfe> dkayiwa, there is a fix in the reporting module that only tries to reauth once every 30 mins
|
13:03:57
|
*** 31NABOOB2 is now known as jkeiper
|
13:03:57
|
<dkayiwa> bwolfe: so after that, the account can still be locked? right?
|
13:04:13
|
*** ChanServ sets mode: +v jkeiper
|
13:04:19
|
<jkeiper> hi dkayiwa
|
13:04:21
|
<bwolfe> dkayiwa, if another task is authenticating repeatedly, it could happen too
|
13:04:34
|
<dkayiwa> bwolfe: i have just been locked out
|
13:04:51
|
<bwolfe> dkayiwa, ok, what tasks do you have running?
|
13:04:51
|
<dkayiwa> bwolfe: and looking at the log, it is the AbstractReportsTask
|
13:05:09
|
<bwolfe> dkayiwa, I see. check the ticket for that. it might not be released yet
|
13:05:27
|
<dkayiwa> bwolfe: the only started task i have is: org.openmrs.logic.task.InitializeLogicRuleProvidersTask
|
13:05:30
|
<dkayiwa> hi jkeiper :)
|
13:05:52
|
<jkeiper> :-D
|
13:05:59
|
<bwolfe> dkayiwa, but does reporting do its tasks differently now?
|
13:06:00
|
<jkeiper> dkayiwa, i plan on taking XFRM-50 and another one
|
13:06:37
|
<dkayiwa> bwolfe: i have been locked out before (actually two times on 1.9) and i just ignored and simply reinstalled. But this time i decided to investigate it because i think a remember a user who got the same problem
|
13:07:32
|
<dkayiwa> bwolfe: am not sure if the reporting tasks now does things differently, but even the 30 mins window you mentioned means it is no fix :)
|
13:07:52
|
<dkayiwa> bwolfe: because after all after a few hours i will still get locked out
|
13:08:04
|
<dkayiwa> jkeiper: aha :)
|
13:08:14
|
<dkayiwa> !ticket FRM-50
|
13:08:15
|
<OpenMRSBot> dkayiwa: Issue Does Not Exist - OpenMRS JIRA - https://tickets.openmrs.org/browse/FRM-50
|
13:08:25
|
<dkayiwa> !ticket XFRM-50
|
13:08:26
|
<OpenMRSBot> dkayiwa: [#XFRM-50] Need proposed concept feature - OpenMRS JIRA - https://tickets.openmrs.org/browse/XFRM-50
|
13:08:38
|
<jkeiper> dkayiwa, i asked ada for some more information
|
13:08:43
|
<jkeiper> dkayiwa, also the one about ordered schema
|
13:08:55
|
<dkayiwa> jkeiper: oh yes i saw the JIRA comment :)
|
13:08:58
|
<jkeiper> dkayiwa, i think i found code related to that ... found a class that builds the schema
|
13:09:17
|
<dkayiwa> jkeiper: ok
|
13:09:22
|
<jkeiper> dkayiwa, thought i would leave it as not mine until i had more info ;-)
|
13:09:38
|
<dkayiwa> jkeiper: hahaha :)
|
13:12:03
|
*** maurya has joined #openmrs
|
13:12:30
|
*** ChanServ sets mode: +v maurya
|
13:14:31
|
*** wyclif has quit IRC
|
13:17:47
|
<dkayiwa> bwolfe: here is the ticket REPORT-368
|
13:17:50
|
<dkayiwa> !ticket REPORT-368
|
13:17:53
|
<OpenMRSBot> dkayiwa: [#REPORT-368] If scheduler.password is wrong, then the reporting module will quickly lock your admin account - OpenMRS JIRA - https://tickets.openmrs.org/browse/REPORT-368
|
13:18:11
|
<dkayiwa> bwolfe: it uses a fine minutes window
|
13:18:23
|
<dkayiwa> bwolfe: but is that really a fix???? :)
|
13:18:58
|
<dkayiwa> bwolfe: am going to reopen it. any objections???
|
13:19:23
|
<bwolfe> dkayiwa, are you using that version of reporting?
|
13:19:47
|
<dkayiwa> bwolfe: am using version 0.7.1.1
|
13:19:58
|
<bwolfe> dkayiwa, were you seeing a lot of unauth errors under 5 mins?
|
13:20:50
|
<dkayiwa> bwolfe: every after five minutes, i get this: INFO - HibernateContextDAO.authenticate(181) |2012-07-05 16:43:59,397| Failed login attempt (login=admin) - Invalid username and/or password: admin
|
13:21:24
|
<dkayiwa> bwolfe: and between those 5 mins, i keep getting so many of: WARN - AbstractReportsTask.authenticate(59) |2012-07-05 16:42:59,856| Not authenticating to avoid locking account. Please ensure you scheduler username and password are configured correctly in your global properties
|
13:22:02
|
<dkayiwa> bwolfe: the supposed fix simply postpones the lockout to like 5*7=35 minutes :)
|
13:22:14
|
<dkayiwa> bwolfe: so to me that is not seem like a real fix :)
|
13:23:14
|
<dkayiwa> bwolfe: i manually deleted the lockout info from the user_property table, and now every after 5 mins, the login attempts gets incremented by 1
|
13:23:15
|
<bwolfe> dkayiwa, so the 7 attempts are not time-bound?
|
13:23:22
|
<bwolfe> I thought after 30 mins you got to try again.
|
13:23:41
|
<dkayiwa> bwolfe: so am now at 6 attempts. so one to go and i get locked out :)
|
13:24:06
|
<applecool> rafa: there?
|
13:24:12
|
<dkayiwa> bwolfe: it attempts to authenticate every after 5mins
|
13:24:50
|
<dkayiwa> bwolfe: so by the 5 * 7 = 35th minute, it locks me out again. and am confortably reproducing it
|
13:24:52
|
*** applecool has quit IRC
|
13:25:27
|
<bwolfe> dkayiwa, but I mean our locking out system. If I mstype my password once a day for a week, I'm still locked out?
|
13:25:45
|
<dkayiwa> bwolfe: i have not tested that
|
13:27:55
|
<bwolfe> dkayiwa, looking at HibernateContextDAO, the user is supposed to be locked out for 5 mins only.
|
13:28:20
|
<bwolfe> so perhaps the fix in reporting is to test for 5.1 minutes instead of 5 mins? Perhaps its reauthing right at the end of the time window
|
13:28:33
|
<bwolfe> dkayiwa, either way, open a new ticket since that version of reporting has been released
|
13:28:54
|
<dkayiwa> bwolfe: ok
|
13:29:02
|
<bwolfe> dkayiwa, oh, looks like darius is using 305000, so it /should/ be ok...
|
13:29:38
|
<dkayiwa> bwolfe: i also see 305000 in the code
|
13:30:43
|
<dkayiwa> bwolfe: there is something wrong somewhere
|
13:30:51
|
<bwolfe> agreed
|
13:31:36
|
<dkayiwa> bwolfe: because after the 7th attempt, i immediately logged out and then logged in. it let me in and reset the login attempts to 0 :)
|
13:32:07
|
<dkayiwa> bwolfe: but if i do not login immediately, like leave my laptop and go somewhere, coming back, i cant login
|
13:38:06
|
*** pushkar has joined #openmrs
|
13:38:14
|
<pushkar> bwolfe, hi
|
13:38:22
|
<bwolfe> hey
|
13:38:40
|
<pushkar> I sumitted a patch for TRUNK-2582
|
13:38:59
|
<pushkar> can you please have a look at it bwolfe
|
13:41:14
|
*** rafa has quit IRC
|
13:45:34
|
<bwolfe> yep
|
13:54:17
|
*** harshadura has joined #openmrs
|
13:57:13
|
<bwolfe> pushkar, ticket looks pretty good. I'll ask for one small change, then have you commit it. :-)
|
13:58:21
|
*** wyclif has joined #openmrs
|
13:58:22
|
<pushkar> okay whats that change ?
|
13:58:47
|
*** lakkarau has joined #openmrs
|
14:00:31
|
<wyclif> hi dkayiwa
|
14:00:43
|
<dkayiwa> hi wyclif
|
14:01:16
|
<wyclif> dkayiwa, does xform use any other form resource besides the one for xform to hl7
|
14:01:53
|
<dkayiwa> wyclif: no
|
14:01:54
|
<wyclif> was working on xfrm-34
|
14:02:31
|
<wyclif> dkayiwa, so what is the point of xfrm-34, what xslt should i be storing as a form resource?
|
14:02:34
|
<pushkar> bwolfe, okay whats that change ?
|
14:02:51
|
<bwolfe> pushkar, I'll put it in the ticket
|
14:02:55
|
<dkayiwa> !ticket xfrm-34
|
14:02:56
|
<OpenMRSBot> dkayiwa: [#XFRM-34] Handle XSLT Form Resource - OpenMRS JIRA - https://tickets.openmrs.org/browse/xfrm-34
|
14:03:12
|
<pushkar> okay :-)
|
14:04:11
|
<dkayiwa> wyclif: xforms should be storing its xslt as a form resource
|
14:04:19
|
*** jkeiper_ has joined #openmrs
|
14:04:22
|
*** jkeiper has quit IRC
|
14:04:30
|
<wyclif> dkayiwa, which xslt?
|
14:04:34
|
<dkayiwa> wyclif: it used to use the one in form.xslt which was deprecated
|
14:05:16
|
<wyclif> dkayiwa, does it mean i should add a changeset to migrate the current form.xslt to form resource?
|
14:05:19
|
<dkayiwa> wyclif: the one in the source in a file named: form_xslt.xml
|
14:06:26
|
<dkayiwa> wyclif: am not farmiliar with the new form resource architecture that jkeiper_ created. but all i know is that we need an xslt resource which was originally stored in form.xslt property
|
14:07:02
|
<wyclif> dkayiwa, i thought that is the one for converting to hl7 and is the same for all forms
|
14:07:40
|
<dkayiwa> wyclif: what is in the source is the default. but each form can have its own which could be different
|
14:07:48
|
<wyclif> dkayiwa, ok
|
14:08:19
|
*** venkaban has joined #openmrs
|
14:08:27
|
<wyclif> so you agree i should add a changeset to do the conversion?
|
14:09:09
|
<wyclif> dkayiwa, just in case there were any xforms that had a unique xslts
|
14:09:19
|
<dkayiwa> wyclif: if you cross check with jkeiper_ and he agrees that that is how we are supposed to fit in the new form resource architecture, then i agree :)
|
14:09:32
|
<wyclif> dkayiwa, one more question?
|
14:09:37
|
<dkayiwa> wyclif: ok
|
14:10:19
|
<wyclif> dkayiwa, so who sets the xslt, the designer or it is auto generated beceause i trying to look ion the code and trying to figure out when to set and store the xslt\
|
14:12:07
|
<dkayiwa> wyclif: BasicFormBuilder.getFormXslt
|
14:13:18
|
<dkayiwa> wyclif: which is used in FormEntryQueueProcessor.transformFormEntryQueue
|
14:15:14
|
*** dkayiwa has quit IRC
|
14:15:54
|
*** goutham has quit IRC
|
14:16:45
|
<wyclif> dkbut that always returns the same xslt that comes with xforms, i guess my question was how can you set a different one?
|
14:30:17
|
*** dkayiwa has joined #openmrs
|
14:30:51
|
*** mccallumg has joined #openmrs
|
14:30:51
|
*** ChanServ sets mode: +v mccallumg
|
14:31:51
|
<jkeiper_> wyclif, dkayiwa: form resources are pretty straightforward ... FormService methods are the only access
|
14:32:03
|
<dkayiwa> jkeiper_: ok
|
14:34:47
|
<wyclif> jkeiper_, cool
|
14:35:30
|
<wyclif> dkayiwa, so daniel seems to me like all xforms use the same xslt, i was just curious if there was a way you can set it to something else
|
14:35:35
|
<jkeiper_> wyclif, dkayiwa: essentially any kind of data (like a file, XSLT, etc) can be attached to a form
|
14:36:21
|
<dkayiwa> jkeiper_: ok
|
14:36:27
|
*** jordank has joined #openmrs
|
14:36:32
|
<jkeiper_> wyclif, dkayiwa: formentry plans to do that ... allow to override the default XSLT, just have not worked on it
|
14:36:45
|
<dkayiwa> jkeiper_: ok
|
14:36:51
|
<jkeiper_> :-D
|
14:37:01
|
<dkayiwa> jkeiper_: ;)
|
14:37:04
|
<jkeiper_> dkayiwa, enjoy eldoret ... hope you brought a thick jacket!
|
14:37:28
|
<dkayiwa> jkeiper_: assuming eldoret = kigali :)
|
14:37:47
|
<jkeiper_> dkayiwa, going to eldoret next week?
|
14:38:04
|
<dkayiwa> jkeiper_: hopefully :)
|
14:38:19
|
<wyclif> jkeiper_, dkayiwa does it mean the assumption is that a module come along and set a different xslt or it is something a user can set?
|
14:38:19
|
<jkeiper_> it's wet and cold ... especially compared to our heat here in indy
|
14:38:34
|
<dkayiwa> jkeiper_: oh i see!!!
|
14:38:57
|
<dkayiwa> jkeiper_: knows the answer :)
|
14:39:01
|
<jkeiper_> dkayiwa, hitting 39C today
|
14:39:13
|
<dkayiwa> jkeiper_: ohhhhhhhhhhhhh
|
14:39:21
|
<jkeiper_> wyclif, the resources are named but anyone can set them
|
14:39:28
|
<jkeiper_> and get them
|
14:39:33
|
<wyclif> jkeiper_, dkayiwa through the UI?
|
14:39:35
|
<jkeiper_> s/anyone/any module
|
14:39:41
|
<jkeiper_> yes
|
14:39:44
|
<wyclif> ok
|
14:39:46
|
<jkeiper_> and API
|
14:40:54
|
<wyclif> jkeiper_, does core set a form resource?
|
14:41:04
|
<wyclif> jkeiper_, in relation to xslt
|
14:41:22
|
<jkeiper_> wyclif, no ... the data is left behind for migration purposes by formentry
|
14:41:32
|
<jkeiper_> wyclif, think it's still in the form table, or possibly in some other table
|
14:41:33
|
<jkeiper_> :-D
|
14:41:57
|
<jkeiper_> wyclif, but the idea is that formentry will have a default too and allow specific forms to override if needed
|
14:42:23
|
<jkeiper_> wyclif, formentry also keeps a "template" on forms ... but i think that can be rendered as-needed perhaps
|
14:42:36
|
<wyclif> jkeiper_, does that mean i have to first check for the xslt set by formentry too ?
|
14:42:48
|
<jkeiper_> wyclif, let xforms do what xforms wants ...
|
14:42:49
|
<jkeiper_> ;-)
|
14:42:54
|
<dkayiwa> :)
|
14:42:56
|
<wyclif> jkeiper_, ok
|
14:43:02
|
<jkeiper_> although ... dkayiwa, don't you use formentry to do the processing?
|
14:43:27
|
<dkayiwa> jkeiper_: i copied the code over :)
|
14:43:28
|
<jkeiper_> dkayiwa, or do you just put into the formentry error queue if there is a problem?
|
14:43:32
|
<jkeiper_> dkayiwa, hahaha ok
|
14:43:52
|
<jkeiper_> so wyclif, you can just use xforms' default XSLT and keep an xforms-specific XSLT if needed
|
14:43:55
|
<dkayiwa> jkeiper_: i did not want to depend on formentry module :)
|
14:44:01
|
<wyclif> jkeiper_, sure
|
14:44:03
|
<jkeiper_> dkayiwa, good call ;-)
|
14:44:06
|
<dkayiwa> jkeiper_: correct
|
14:44:18
|
<dkayiwa> jkeiper_: after all formentry is not yet 1.9 ready :)
|
14:44:35
|
<jkeiper_> btw guys, nelson bore (AMPATH) wrote a nifty JSON-based form entry system ... hope to make it a solid offering so we can really confuse everyone
|
14:44:36
|
<jkeiper_> :-D
|
14:44:59
|
*** jkeiper_ is now known as jkeiper
|
14:44:59
|
<dkayiwa> jkeiper_: :D must be beautiful
|
14:45:04
|
<jkeiper> 'tis
|
14:45:10
|
<dkayiwa> jkeiper: cant wait to try it out
|
14:45:21
|
<dkayiwa> jkeiper: is it in the module repository yet?
|
14:45:26
|
<jkeiper> dkayiwa, one reason is for it to be easily rendered on both screen and tablets
|
14:45:28
|
* jkeiper looks
|
14:45:56
|
<dkayiwa> jkeiper: what is the rendering engine on tablets?
|
14:46:23
|
<dkayiwa> jkeiper: so the form definitions are stored as json?
|
14:47:20
|
<jkeiper> jkeiper, a custom app that reads the json form def and displays it
|
14:47:21
|
<jkeiper> yep
|
14:47:22
|
<jkeiper> :-D
|
14:47:38
|
<jkeiper> dkayiwa, has an interactive form builder
|
14:47:45
|
<dkayiwa> jkeiper: is it javascript/jquery? :)
|
14:47:51
|
<jkeiper> dkayiwa, probably just needs a little advice from form module ppl
|
14:47:54
|
<jkeiper> dkayiwa, yep
|
14:48:04
|
<dkayiwa> jkeiper: must be cool :)
|
14:48:30
|
<jkeiper> there was a demo on last week's university i think
|
14:48:42
|
<dkayiwa> jkeiper: yes i saw something like that :)
|
14:48:58
|
<dkayiwa> jkeiper: is it yet in the module repository?
|
14:49:14
|
<jkeiper> i think it might have ended up in code.google.com ... still looking :-/
|
14:49:43
|
<dkayiwa> jkeiper: how is it different from htmlformentry?
|
14:50:06
|
<dkayiwa> jkeiper: is it for people who love json more than html? :)
|
14:50:10
|
<jkeiper> dkayiwa, not sure ... htmlformentry seems to do a lot behind the scenes
|
14:50:52
|
<jkeiper> dkayiwa, i think it was for the purpose of creating random forms on pages in his pharmacy module
|
14:51:06
|
<dkayiwa> jkeiper: may be i should have asked differently, "what would lead one to chose it over htmlformentry"?
|
14:51:21
|
<jkeiper> dkayiwa, but i don't think he realizes the form framework and how to connect the dots with encounters, etc
|
14:51:30
|
<jkeiper> dkayiwa, probably ease of use or portability
|
14:51:50
|
<dkayiwa> jkeiper: i think what he misses (is the easier to do) :)
|
14:52:05
|
<dkayiwa> jkeiper: he already did the more complicated part :)
|
14:52:07
|
<jkeiper> dkayiwa, the form def is simple (like htmlformentry) but the processing is less heavy compared to htmlformentry
|
14:52:12
|
<jkeiper> dkayiwa, exactly
|
14:52:13
|
<jkeiper> :-D
|
14:52:46
|
<dkayiwa> jkeiper: we finally now have 4 formentry alternatives :)
|
14:53:35
|
<jkeiper> dkayiwa, 3 if we finally destroy infopath
|
14:53:36
|
<jkeiper> :-D
|
14:54:01
|
<dkayiwa> jkeiper: i do not see infopath going anytime soon :)
|
14:54:29
|
<jkeiper> hah, sadly
|
14:54:30
|
<dkayiwa> jkeiper: i have tried to make it dissapear but man!!!! Its form designer is hard to beat!!! :)
|
14:55:12
|
*** goutham has joined #openmrs
|
14:55:27
|
<dkayiwa> jkeiper: Ada never stops asking me something cool they do in infopath!!! :D
|
14:55:50
|
<jkeiper> dkayiwa, heheh, we can change that ...
|
14:56:04
|
<jkeiper> dkayiwa, just need a xforms champion at ampath to get rolling
|
14:56:34
|
<dkayiwa> jkeiper: hahahahaha!!! :D
|
15:02:35
|
*** orien has joined #openmrs
|
15:03:41
|
<jkeiper> dkayiwa, well ... https://svn.openmrs.org/openmrs-modules/amrspharmacy/trunk/ uses it ... just not sure where the code is for the actual Json Forms Module
|
15:03:57
|
<dkayiwa> jkeiper: ok thanks
|
15:04:16
|
*** goutham has quit IRC
|
15:04:23
|
*** goutham has joined #openmrs
|
15:10:02
|
*** jkeiper has quit IRC
|
15:14:32
|
*** jkeiper has joined #openmrs
|
15:16:30
|
*** wyclif has quit IRC
|
15:17:57
|
*** lakkarau has quit IRC
|
15:19:48
|
*** goutham has quit IRC
|
15:20:28
|
*** goutham has joined #openmrs
|
15:21:20
|
*** mccallumg has quit IRC
|
15:21:36
|
*** mccallumg has joined #openmrs
|
15:21:36
|
*** ChanServ sets mode: +v mccallumg
|
15:30:17
|
*** goutham has quit IRC
|
15:31:07
|
*** harshadura has quit IRC
|
15:31:25
|
*** harshadura has joined #openmrs
|
15:34:59
|
*** raj_ has joined #openmrs
|
15:36:23
|
*** maurya has quit IRC
|
15:36:34
|
<raj_> we are having a major issue in 1.9.. not sure if this is intended or not.. we want to use the encounter and as such disabled visit but we don't see any edit button in encounter
|
15:37:45
|
*** goutham has joined #openmrs
|
15:38:29
|
<bwolfe> raj_, you have disabled visits?
|
15:38:34
|
<raj_> yes..
|
15:38:44
|
<bwolfe> raj_, and where is the button not appearing?
|
15:38:51
|
<raj_> and i checked in openmrs demo also
|
15:38:58
|
<raj_> same thing
|
15:39:10
|
<raj_> the edit is not showing up in the "encounter" tab
|
15:40:09
|
*** mvorobey has joined #openmrs
|
15:40:22
|
<raj_> it shows the view only.. but we (and i believe several implementations does ) multiple edits
|
15:40:28
|
<raj_> on the same encounter
|
15:41:39
|
<raj_> basically i am trying to edit a already created encounter..
|
15:41:54
|
<raj_> in 1.8 there was an edit button in the encounter tag..
|
15:42:00
|
*** goutham has left #openmrs
|
15:42:05
|
*** gauravpaliwal has joined #openmrs
|
15:42:05
|
*** ChanServ sets mode: +v gauravpaliwal
|
15:45:00
|
*** pushkar_ has joined #openmrs
|
15:47:16
|
<raj_> we are really scared now.. as we just gone live and already entered the first batch of patient..
|
15:47:31
|
<raj_> in 1.9 .. but don't know how to go back and edit ..
|
15:48:05
|
<dkayiwa> raj_: did you enter the forms using htmlformentry?
|
15:48:12
|
<raj_> yes..
|
15:48:30
|
<dkayiwa> raj_: do you see the view button for the encounter?
|
15:48:44
|
<raj_> so we entered using "Form Entry"
|
15:48:49
|
<raj_> yes we see the view button
|
15:48:53
|
*** pushkar has quit IRC
|
15:49:02
|
<dkayiwa> raj_: click it and then you will see the edit
|
15:49:17
|
<raj_> ohh you are a life saver
|
15:49:35
|
<raj_> i don't know in 1.8 we had the edit button in the first page itself
|
15:49:41
|
<raj_> so got totally psyched out
|
15:49:59
|
<raj_> so sorry for raising a commotion
|
15:50:03
|
<dkayiwa> raj_: oh sorry. we should document that well to avoid the confusion :(
|
15:50:12
|
<dkayiwa> raj_: no problem, it is out problem
|
15:50:18
|
<dkayiwa> out = our
|
15:50:26
|
*** pulasthi7 has joined #openmrs
|
15:50:32
|
*** rfriedman has joined #openmrs
|
15:50:35
|
<raj_> but i think we had (missionarogya) is testing the 1.9 at it's max :-)
|
15:50:47
|
<raj_> you will see more tickets form us ..
|
15:50:50
|
<dkayiwa> raj_: oh thats so cool!!! :)
|
15:51:03
|
<dkayiwa> raj_: can't wait to see them!!! :D
|
15:51:09
|
<raj_> and darius had given us a free hand to log ticket without considering the backlash..
|
15:51:15
|
<raj_> from dev community
|
15:51:23
|
<rfriedman> jkeiper, hi jeremy, you've used REST, right?
|
15:51:37
|
<raj_> we created few already.. none of them are blocker though..
|
15:51:51
|
<dkayiwa> raj_: ok
|
15:51:57
|
<raj_> one question daniel - is it at-all possible to bring back the edit in the first page
|
15:52:05
|
<raj_> instead of the view and edit
|
15:52:09
|
*** suranga has joined #openmrs
|
15:52:09
|
*** ChanServ sets mode: +v suranga
|
15:52:14
|
<dkayiwa> raj_: hahaha good question :)
|
15:52:16
|
<suranga> hi pulasthi7
|
15:52:30
|
<raj_> i think we are late right :-)
|
15:52:50
|
<pulasthi7> hi suranga
|
15:53:03
|
<dkayiwa> raj_: you can bring the discussion on the implementers list. you never know it could come with 1.9.1 :)
|
15:53:13
|
<suranga> pulasthi7, hows it going ? :)
|
15:53:15
|
<raj_> basically all my users are so accustomed with the first page edit.. i tried the visit for first few days and now just gone back to encounter
|
15:53:29
|
<raj_> we will revisit "visit" later..
|
15:53:34
|
<dkayiwa> raj_: ok
|
15:53:43
|
<rfriedman> hi bwolfe , got a minute?
|
15:53:58
|
<suranga> pulasthi7, I did not actually check out your code yet, only looked at the changesets
|
15:54:02
|
<raj_> is it any magic globel property to bring back the edit in the first page? if not i understand
|
15:54:18
|
<dkayiwa> raj_: unfortunately not
|
15:54:19
|
<pulasthi7> suranga: yesterday i did't got much time to work on it,
|
15:54:23
|
<raj_> okay
|
15:54:38
|
<pulasthi7> suranga: may be today i can finish it
|
15:54:40
|
<dkayiwa> raj_: but you can start a conversation about it on the implementers list.
|
15:54:41
|
<bwolfe> raj_, that move was supposed to make it cleaner. :-)
|
15:54:44
|
<raj_> hmm.. :-( i was hoping for thos magic globel property trick
|
15:54:46
|
<bwolfe> rfriedman, sure
|
15:55:00
|
<rfriedman> bwolfe, i'm having a problem with wsrest
|
15:55:10
|
<raj_> yes.. but confuses uses who are already using and for implementation which doesn't have too much fund to retrain ...
|
15:55:15
|
<suranga> pulasthi7, I did notice that you logged off rather early yesterday... I guess that was because you got back to COlombo after a looong weekend :)
|
15:55:36
|
<rfriedman> the same link, copied into firefox address line, wsrest test box, and curl command, works in the first but not the last two
|
15:55:37
|
<dkayiwa> raj_: i agree!!! :(
|
15:56:10
|
<bwolfe> rfriedman, define "works"
|
15:56:17
|
<raj_> that's okay .. no issue.. it is the non PIH /MVP implementars voice :-)
|
15:56:37
|
<rfriedman> works = produces well structured output containing correct values
|
15:56:39
|
<raj_> thanks all though...
|
15:56:40
|
<dkayiwa> raj_: hahahahah :)
|
15:56:48
|
<rfriedman> not works = returns empty string
|
15:56:56
|
<dkayiwa> raj_: your voice counts too and equally!!! :)
|
15:57:06
|
<raj_> i am just joking ,..
|
15:57:35
|
<raj_> we should have caught it during testing.. we actually tested using the visit
|
15:57:48
|
<dkayiwa> raj_: if you had reported it during beta, alpha testing, etc, may be the 1.9 release could have it changed :)
|
15:58:08
|
<raj_> and also the users were not engaged.. it was actually only me who tested it..
|
15:58:20
|
<dkayiwa> raj_: hahahah :)
|
15:58:41
|
<bwolfe> raj_, you're allowed to have a voice. :-) if you and others want a link back there, a discussion should be had
|
15:58:42
|
<raj_> so .. that was my fault true .. now they want to use the encounter only ..
|
15:58:54
|
<bwolfe> rfriedman, is it because firefox is setting the accepts header to xml instead of json?
|
15:58:57
|
<raj_> not now.. i don't think it is very important
|
15:59:08
|
<dkayiwa> raj_: ok
|
15:59:13
|
<rfriedman> could be
|
15:59:14
|
<raj_> but i will watch the users workflow and will let you guys know
|
15:59:23
|
<rfriedman> do you know how to set that in curl?
|
15:59:25
|
<dkayiwa> raj_: ok thanks!!!
|
15:59:43
|
<raj_> thanks again
|
15:59:51
|
<bwolfe> rfriedman, not offhand. I'd have to google it. you might be lucky and see it on darius' curl examples in the restws wiki pages
|
15:59:58
|
<dkayiwa> raj_: you are welcome. thank you too!!!
|
16:00:17
|
<rfriedman> ok, i will hunt for it
|
16:00:24
|
<rfriedman> bwolfe, tks
|
16:04:37
|
*** dkayiwa has quit IRC
|
16:07:41
|
*** kishoreyekkanti has joined #openmrs
|
16:09:22
|
<rfriedman> bwolfe, i found it, but that's apparently not the problem, curl -i <url> shows a 302 error
|
16:10:12
|
*** gauravpaliwal has left #openmrs
|
16:16:41
|
*** jordank has quit IRC
|
16:17:47
|
*** lakkarau has joined #openmrs
|
16:18:53
|
*** kreddy has joined #openmrs
|
16:19:40
|
*** sgithens has quit IRC
|
16:23:00
|
*** orien has quit IRC
|
16:25:01
|
*** jriley has joined #openmrs
|
16:33:23
|
*** cpower has quit IRC
|
16:34:11
|
*** cpower has joined #openmrs
|
16:37:34
|
*** dkayiwa has joined #openmrs
|
16:40:56
|
<pushkar_> bwolfe, what are our goals for mid term evaluation
|
16:43:58
|
*** lakkarau has quit IRC
|
16:44:43
|
*** lh has joined #openmrs
|
16:45:05
|
*** lakkarau has joined #openmrs
|
16:45:36
|
*** lakkarau_ has joined #openmrs
|
16:47:18
|
*** lakkarau_ has quit IRC
|
16:54:45
|
*** jordank has joined #openmrs
|
17:03:59
|
*** goutham has joined #openmrs
|
17:04:07
|
*** lh has quit IRC
|
17:04:48
|
*** raj_ has quit IRC
|
17:05:47
|
<rfriedman> pushkar, isn't it supposed to be 100% complete? :)
|
17:06:43
|
<rfriedman> pushkar_, isn't it supposed to be 100% complete? :)
|
17:07:11
|
*** lakkarau has quit IRC
|
17:07:28
|
*** lakkarau has joined #openmrs
|
17:11:08
|
<pushkar_> rfriedman, :-) :-)
|
17:12:02
|
<pushkar_> Last thursday darius suggested something new
|
17:12:19
|
<rfriedman> pushkar_, in seriousness, i think a lot of the value of this lies in having a good selection of canvases
|
17:13:06
|
<rfriedman> the doctor isn't going to draw freehand, he's going to annotate a drawing for the most part
|
17:13:08
|
<suranga> hi pulasthi7
|
17:13:30
|
<pulasthi7> hi suranga
|
17:13:39
|
<pushkar_> rfriedman, now he can write the text on the canvas
|
17:13:59
|
<suranga> pulasthi7, I just wanted to remind you not to forget about putting up agreed requirments on our wiki :)
|
17:14:04
|
<pushkar_> which will be printed on the image
|
17:14:13
|
<suranga> pulasthi7, we're rather late, but better late than never :)
|
17:14:23
|
<rfriedman> pushkar_, both draw and write on the canvas,
|
17:14:33
|
<pushkar_> yes,he can do both
|
17:14:50
|
<pulasthi7> suranga, about task 3?
|
17:14:57
|
<rfriedman> pushkar_, what's darius' idea?
|
17:14:57
|
<pulasthi7> suranga, i'll do that
|
17:15:11
|
<suranga> pulasthi7, very nice..
|
17:15:35
|
<pushkar_> he wants the annotations on the top of the canvas rather than printing them on the image
|
17:16:02
|
<rfriedman> what does he mean by "on top" -- on another layer? or above?
|
17:16:10
|
<pushkar_> yes
|
17:16:14
|
<suranga> pulasthi7, when you do, dont forget to mail us the link...
|
17:16:16
|
<pushkar_> another layer
|
17:16:45
|
<rfriedman> pushkar_, that's a good idea, how badly does that mess you up?
|
17:17:16
|
<pulasthi7> suranga, ok. i'll mail it when i'm done.
|
17:18:16
|
<pushkar_> I can leave the current feature to allow the user to print text on the canvas and add darius idea as a new feature to the existing module
|
17:19:03
|
<pushkar_> I just have to find a feasible way to implement this new idea
|
17:22:20
|
<rfriedman> pushkar_, so the widget you chose already uses layers?
|
17:25:22
|
*** venkaban has quit IRC
|
17:26:05
|
*** cpower has quit IRC
|
17:26:59
|
<pushkar_> rfriedman, No it doesnt but I was looking at gmapimageviewer module . I can annotate images .I was thinking of ways to reuse it taht code
|
17:27:16
|
*** lh has joined #openmrs
|
17:27:16
|
*** lh has joined #openmrs
|
17:27:38
|
<pushkar_> rfriedman, *It can annotate images
|
17:28:02
|
*** venkaban has joined #openmrs
|
17:29:20
|
<venkaban> bwolfe, hi
|
17:29:24
|
<bwolfe> hey
|
17:30:09
|
<venkaban> bwolfe, looks like the browser issue for XFRM-80. So in this case what would be the next step to verify, is that javascript commands or to start from?
|
17:30:57
|
<bwolfe> venkaban, you figure out where/why its failing for those browsers. how are your javascript skills?
|
17:31:45
|
<venkaban> bwolfe, i know script in a moderate level
|
17:32:14
|
<venkaban> bwolfe, i have most of the experience on the backend side comapred to front end
|
17:32:22
|
<bwolfe> venkaban, do you know enough to debug it?
|
17:32:36
|
<venkaban> bwolfe, using firebug?
|
17:32:37
|
<bwolfe> use firebug? use web developer? or just alert statements?
|
17:32:59
|
<venkaban> bwolfe, can firebug be installed on chrome, i doubt it?
|
17:33:10
|
<venkaban> bwolfe, i know firebug can be used in FF
|
17:33:48
|
<jriley> jordank, you were asking about controllers and asp pages
|
17:33:57
|
<bwolfe> venkaban, I think there are other extensions like firebug for chrome
|
17:34:08
|
<bwolfe> in fact, chrome might have have good enough built in features
|
17:34:41
|
<venkaban> bwolfe, ok will check for chrome and see
|
17:34:46
|
<jordank> yes! I'm working on a module with back/ submit buttons for each JSP and wondering if anyone knows whether I need multiple controllers - one for each page?
|
17:38:15
|
<jriley> The alternative is one controller with some kind of step=… that shows which step of the process you're on? Is that right?
|
17:43:58
|
<suranga> james_regen, helooo, are you here ?
|
17:44:01
|
<rfriedman> bwolfe, don't know if you saw my previous message, when I ran curl -i I was able to see that I was getting a 302 error. We didn't use 302 for anything in the REST module did we?
|
17:45:08
|
<bwolfe> a "found" response code? sounds odd
|
17:45:40
|
<rfriedman> bwolfe, "moved temporarily"
|
17:46:15
|
<rfriedman> bwolfe, what do we do for authentication failures?
|
17:46:25
|
<bwolfe> 301
|
17:46:28
|
<james_regen> suranga: hi
|
17:46:29
|
<bwolfe> err, 401
|
17:46:45
|
<bwolfe> 302 is SC_FOUND constant. I don't see that used anywhere
|
17:46:52
|
<suranga> james_regen, helooo... pulasthi7 and I were trying to access link.regensteif server
|
17:46:58
|
<suranga> james_regen, it seems down
|
17:47:03
|
<bwolfe> 401 is SC_UNAUTHORIZED, thats in the code
|
17:47:04
|
<jriley> jordank, an aside - have you found the My Favorite Patients MVC example page? https://wiki.openmrs.org/display/docs/My+Favorite+Patients+MVC+Example
|
17:47:08
|
<bwolfe> rfriedman, what is the url you're using?
|
17:47:21
|
<james_regen> suranga: yeah, it needs some work before it's put back on the internet
|
17:47:27
|
<suranga> james_regen, I hope the good folks at regenstrief have not decided to shut it down :-(
|
17:47:39
|
<suranga> james_regen, oooh, i see
|
17:47:41
|
<rfriedman> https://184.172.42.253/openmrs/ws/rest/v1/location bwolfe
|
17:47:44
|
*** harshadura has quit IRC
|
17:47:50
|
<suranga> james_regen, do you think it'll be up soon ? :)
|
17:48:13
|
<suranga> james_regen, we ask because it has a lot of data, and is easy to find good matching pairs for testing...
|
17:48:16
|
<rfriedman> bwolfe, actually, I used http, curl reported https
|
17:48:45
|
<james_regen> suranga: probably not. it will probably get switched to a different distro and folded into existing IT support system. the module and database should be fine, i think
|
17:48:55
|
<rfriedman> bwolfe, -u demo:deMo.rt3v
|
17:49:33
|
<bwolfe> rfriedman, so maybe its your tomcat install that is doing the 302 from http to https ?
|
17:49:59
|
<jordank> jriley, no I hadn't! That's cool... bwolfe said yesterday that I could give the buttons a value and have the controller that accepts the post look for the name+value of the button then if it exists, redirect instead of continuing... is that the same idea as step=...?
|
17:50:49
|
<suranga> james_regen, hmm... I see... I guess we will have to use some demo data for now :(
|
17:50:59
|
<suranga> james_regen, thanks for letting us know..
|
17:52:09
|
<rfriedman> yeah, that's what I was thinking. I don't know how much this guy knows about tomcat, bwolfe , where should he look?
|
17:52:51
|
<jriley> jordank, I think so . I like breaking things up into small pieces with explicit calls. … looking for an example, hang on...
|
17:53:20
|
<bwolfe> rfriedman, somewhere in the config. his server is set up for https, so I would guess all http calls get a 302 and the browser just follows that. curl does nto follow that
|
17:54:43
|
<rfriedman> bwolfe, doing curl with https gives: curl: (35) error:14077438:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert internal error
|
17:56:24
|
<bwolfe> rfriedman, same. I assume curl doesn't work with ssl or at least that versoin of their ssl certificate
|
17:56:25
|
<jriley> jordank, still looking … ok, forging ahead. I like to break things into small methods and separate calls. I like to name my URLs with things like "select", or "preview", or "execute".
|
17:56:54
|
<jriley> So I would make one Controller file, but have separate methods and separate @RequestMappings that say what I want to do.
|
17:56:58
|
<rfriedman> bwolfe, yes, i think i had to skip over a certificate error when logging in
|
17:57:57
|
<jriley> The other way, which I think bwolfe may have been suggesting, is you can have a long method that checks every step. When it finds something that isn't complete ( you haven't selected concepts, you haven't said YES REALLY DO IT from the preview screen, etc) it directs you to page that makes you finish that step.
|
17:58:16
|
<jriley> This is easier to explain with handwaving and a whiteboard… is it making sense?
|
17:58:30
|
<jriley> The things I thought about when I decided "lots of smaller methods" were:
|
17:58:48
|
<jordank> jriley, I had trouble finding an example too... and haha ya I think so
|
17:59:08
|
*** kishoreyekkanti_ has joined #openmrs
|
17:59:08
|
<jriley> 1- making intentions explicit. If you see a URL that says PREVIEW, you know what to expect. If you had to maintain my code later, you'd have a good idea what I was trying to do
|
17:59:29
|
*** maurya has joined #openmrs
|
17:59:41
|
*** kishoreyekkanti has quit IRC
|
18:00:01
|
<jriley> 2- it's easier to test small chunks . You don't have to jump through the first five hoops just to test number six.
|
18:00:21
|
*** ChanServ sets mode: +v maurya
|
18:00:32
|
<jordank> by URL, you mean something like module/mergeconcepts/previewPage?
|
18:00:41
|
<jordank> but not previewPage
|
18:00:48
|
<jriley> 3- The steps are pretty different… it's not like I'm doing exactly the same thing except for one teensy thing . So having it all in one method doesn't really buy me anything
|
18:01:07
|
<jordank> yes that makes sense
|
18:01:27
|
<jriley> like module/mergeconcepts/previewPage and module/mergeconcepts/selectConcepts and module/mergeconcepts/executeMerge
|
18:02:00
|
<jriley> jordank - I think being a picky eater was great training for encapsulating objects. I like things to be separate, like in a TV dinner tray. :)
|
18:02:21
|
<jordank> got it! :)
|
18:02:48
|
<jriley> With the @RequestMapping annotation, you can put all these methods in one .java file. In some other frameworks you'd have to make a separate controller .java file for each
|
18:03:51
|
<jriley> And for the simple skeleton version of the module, you can create the RequestMapping and methods for all the steps, and have their action be to show you the next page in the sequence. Then fill in the brains for each step in a later iteration
|
18:04:51
|
<jriley> I see in the ObsConverter module they're using the HTTP method to derive the right action. "GET" - you must want to see the page, here it is. "POST" - you must have submitted a form, I'll do the conversion
|
18:05:17
|
<jriley> I like using explicit words
|
18:05:30
|
*** kishoreyekkanti_ has quit IRC
|
18:05:49
|
*** kishoreyekkanti has joined #openmrs
|
18:06:41
|
<jordank> got it. so with two submit buttons redirecting to different places in one URL, are the actions in the .jsp two different form action=otherPage kind of things or would I still want a value to look for in the the method in the controller
|
18:06:42
|
<jriley> jordank, we should do some pair programming when you get to writing tests .
|
18:07:06
|
<jordank> sounds fun!
|
18:08:56
|
<jriley> the form on the select(.jsp) page would submit to mergeconcepts/preview (maybe previewChanges is a better URL?), and preview(.jsp) would submit to executeMerge
|
18:09:35
|
<jriley> The last page, where you report the results, doesn't have a form, just some <a hrefs> to do another or go back to admin
|
18:10:39
|
<jriley> I have to research how to do remote sharing on a Mac. It would be crazy making on skype
|
18:11:23
|
<jordank> ya! I'll investigate too I think I have some friends who would know
|
18:11:47
|
<jriley> Did that answer the question?
|
18:12:29
|
<jordank> so, one button per page? plus some links at the top to navigate back to concept management or admin page?
|
18:22:14
|
<pushkar_> bwolfe, I have made the changes .How do I commit the code ?
|
18:22:29
|
<bwolfe> pushkar_, svn commit. :-)
|
18:22:31
|
<bwolfe> or svn co
|
18:22:36
|
<bwolfe> or team-->commit
|
18:22:51
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: HTML Form Entry 1.10.0 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=htmlformentry&version=&1.10.0>
|
18:23:06
|
<pushkar_> do I have the rights ?
|
18:25:30
|
*** mvorobey has quit IRC
|
18:26:08
|
<bwolfe> pushkar_, you should. we grant access to everywhere when we grant access to one place. and if you want ot start committing in a new place you ask the "owner" of that and they say yes/no
|
18:28:54
|
*** jordank_ has joined #openmrs
|
18:28:55
|
*** jordank has quit IRC
|
18:28:55
|
*** jordank_ is now known as jordank
|
18:30:11
|
<pushkar_> oh cool :-) and I should commit this code for trunk and what other versions ?
|
18:31:25
|
<pushkar_> bwolfe, oh cool :-) and I should commit this code for trunk and what other versions ?
|
18:31:48
|
<bwolfe> check out branches/1.9.x and commit there too
|
18:33:36
|
*** diptanuc has joined #openmrs
|
18:33:52
|
<diptanuc> Hi guys we are doing a codejam right now
|
18:34:06
|
<bwolfe> diptanuc, nice. how many people?
|
18:34:12
|
<diptanuc> Working on TRUNK-439
|
18:34:17
|
<pushkar_> okay bwolfe and can you please brief me how the mid term evaluation goes ?
|
18:34:28
|
<diptanuc> bwolfe: 8 people
|
18:34:35
|
<bwolfe> pushkar_, you mean how does it work?
|
18:34:50
|
<diptanuc> bwolfe: Can you tell me how can i navigate to the page Most Recent Observations?
|
18:34:52
|
<pushkar_> yes
|
18:35:05
|
<diptanuc> bwolfe: my memory has become a little rusty!
|
18:35:26
|
*** james_regen has quit IRC
|
18:36:18
|
<bwolfe> diptanuc, not sure what you mean. the admin page Manage Observations? or the patient dashboard? to get to the dashboard, first find a patient and hten click on them
|
18:36:39
|
<diptanuc> Right i did that bwolfe
|
18:37:07
|
<diptanuc> But on the patient overview page i dont see the Manage Recent Observations
|
18:37:07
|
<bwolfe> diptanuc, which ticket? I think I know what you're asking, but not sure
|
18:37:14
|
<diptanuc> 439
|
18:37:18
|
<jriley> is there a pastebin for images?
|
18:37:41
|
<bwolfe> diptanuc, ah, I think you have to set a global property to say which concepts (questions) you want. it will then look for obs with those questions and display the most recent
|
18:37:52
|
<bwolfe> https://wiki.openmrs.org/display/docs/Global+Properties+Descriptions
|
18:38:37
|
<bwolfe> !refer jriley [google pastebin+for+images]
|
18:38:37
|
* OpenMRSBot refers jriley to http://www.google.com/search?q=pastebin+for+images
|
18:38:42
|
<bwolfe> jriley, ;-)
|
18:38:59
|
<bwolfe> (I don't know of one)
|
18:39:08
|
<jriley> bwolfe, did that and didn't see any good ones. Saw some .. er… INTERESTING results, though
|
18:39:50
|
<diptanuc> bwolfe: I think i need to know how to see that page first in the app!
|
18:40:08
|
<bwolfe> pushkar_, the gsoc midterm process: you fill out a survey for google. I fill out a survery for google. IFF I answer one of the questions on my survey "does pushkar pass?" with a "yes", you will get the midterm money deposited.
|
18:40:32
|
<bwolfe> pushkar_, I'm not allowed to tell you if I will pass or fail you.
|
18:41:21
|
<bwolfe> jriley, that first hit seems to be ok. http://inky.ws
|
18:41:26
|
*** pushkar_ is now known as pushkar
|
18:41:39
|
<bwolfe> diptanuc, what do you mean?
|
18:42:04
|
<pushkar> bwolfe, okay i'll keep my fingers crossed :-D
|
18:42:14
|
<jriley> bwolfe - result #3 I got was "Nude girls, Image share - Pastebin.com"
|
18:42:48
|
<jriley> Jordan found Scriblink.com , which looks good.
|
18:43:36
|
<bwolfe> jriley, that was probably a spam pasted text into pastebin.com!
|
18:45:49
|
<diptanuc> bwolfe: I mean, which is the page where i need to put up that information? Is it the page where i land when i search for a patient and click on it?
|
18:46:28
|
<diptanuc> bwolfe: I dont see the string Most Recent Observations at all in any of the app!
|
18:47:01
|
<diptanuc> i mean, in the app.
|
18:48:54
|
<bwolfe> diptanuc, you have to "turn it on" by changing/setting a Global Property (a Setting). on that Global Properties Descriptions wiki page I linked to, I think its the "dashboard.overview.showConcepts" property
|
18:49:07
|
<bwolfe> if it is, cna you update that wiki page to have that wording in there so someone can find it?
|
18:50:52
|
*** cpower has joined #openmrs
|
18:53:28
|
<diptanuc> bwolfe: dashboard.overview.showConcepts Comma separated list of concept ids to show on the patient dashboard 'overview' tab
|
18:53:28
|
<diptanuc>
|
18:54:49
|
<diptanuc> bwolfe: Dont understand how to turn it on?
|
18:55:27
|
<bwolfe> diptanuc, what is the concept/question you want to show there? do you have any obs in your database?
|
18:56:02
|
<bwolfe> diptanuc, just put the question concept in there. e.g. the question for an obs is the obs.concept_id column
|
18:56:09
|
<bwolfe> which is an FK to concept.concept_id
|
18:58:06
|
<diptanuc> bwolfe: Added the id of the concept pulse in the column property for that setting in the database
|
18:58:14
|
<cpower> Hello everybody
|
18:58:55
|
<diptanuc> bwolfe: Now where i am i supposed to see that information?
|
19:00:38
|
<cpower> Are we ready to Scrum?
|
19:00:40
|
<bwolfe> diptanuc, you mean how to see if you have observations? either just look in your obs table. or look in the admin section at the Manage Observations page
|
19:01:34
|
<cpower> Let's do it
|
19:01:41
|
<cpower> !scrumon cpower
|
19:01:41
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
19:02:49
|
<cpower> Order: Venkaban, lakkarau, dkayiwa, bwolfe, anyone else I may be missing or shows up mid way through
|
19:03:09
|
<bwolfe> rafa? kishoreyekkanti? darius?
|
19:03:22
|
<kishoreyekkanti> kishoreyekkanti: I'm here
|
19:03:25
|
<venkaban> XFRM-80, tested in IE successfully, working on the issue with chrome and FF
|
19:03:30
|
<venkaban> no Blockers
|
19:03:55
|
<lakkarau> bwolfe:
|
19:03:55
|
<lakkarau> was working XFRM-79 ,but have to stop working as it would cause more issues
|
19:04:14
|
<lakkarau> picking up other ticket
|
19:04:29
|
<cpower> I don't see rafa on, kishoreyekkanti I missed, and I don't see darius
|
19:04:56
|
<cpower> lakkarau, blockers or discussion points
|
19:05:13
|
<kishoreyekkanti> bwolfe: cpower I'm here
|
19:05:14
|
<cpower> I'm guessing xfrm-79 should be a discussion
|
19:05:52
|
<bwolfe> dkayiwa, are you around?
|
19:06:06
|
<bwolfe> cpower, yes, put XFRM-79 on your discussion list
|
19:06:37
|
<cpower> ok skipping dkayiwa, bwolfe your up
|
19:06:50
|
<diptanuc> bwolfe: We added an encounter with observation of pulse
|
19:07:23
|
<bwolfe> Wednesday
|
19:07:23
|
<bwolfe> July 4th holiday
|
19:07:23
|
<bwolfe> Thursday
|
19:07:23
|
<bwolfe> triaged TRUNK-3565
|
19:07:23
|
<bwolfe> triaged RCM-88
|
19:07:23
|
<bwolfe> triaged REST-8
|
19:07:24
|
<diptanuc> bwolfe: Now when i go to patient dashboard for that patient, i still dont see any Most Recent Observations.
|
19:07:25
|
<bwolfe> triaged RESTWS-267
|
19:07:27
|
<bwolfe> readded log4j.xml to HFE
|
19:07:29
|
<bwolfe> triaged TRUNK-3564
|
19:07:31
|
<bwolfe> reviewed TRUNK-239, tribe module error display
|
19:07:33
|
<bwolfe> reviewed/approved/closed several blocker backlog tickets
|
19:07:35
|
<bwolfe> no blockers
|
19:07:39
|
<bwolfe> diptanuc, hold on a sec. lets discuss after the scrum. (reask me when we do a !scrumoff)
|
19:07:50
|
<cpower> thanks
|
19:08:08
|
<cpower> kishoreyekkanti your up
|
19:08:36
|
*** wyclif has joined #openmrs
|
19:09:04
|
<wyclif> dkayiwa, have you scrummed?
|
19:09:18
|
<bwolfe> wyclif, in the middle of it. wait a sec for your turn
|
19:09:20
|
<cpower> he's MIA,
|
19:09:34
|
<cpower> kishoreyekkanti...your turn
|
19:10:01
|
*** kishoreyekkanti has left #openmrs
|
19:10:06
|
<cpower> oook
|
19:10:11
|
<cpower> Wyclif, your turn
|
19:10:43
|
<wyclif> Tuesday:
|
19:10:43
|
<wyclif> XFRM-34 - Handle XSLT Form Resource
|
19:10:44
|
<wyclif> Addressed TODOs for HTML-121 and HTML-176 so that they could release the module probably today
|
19:10:44
|
<wyclif> Started on XFRM-31 - Editing relationships when editing form observations
|
19:10:44
|
<wyclif> Thursday:
|
19:10:44
|
<wyclif> Complete XFRM-31 - Editing relationships when editing form observations
|
19:10:46
|
<wyclif> dev call
|
19:10:48
|
<wyclif> XFRM-29 - XForms add a "pick relationship type from db" ajax search
|
19:10:50
|
<wyclif> Blockers: None
|
19:11:04
|
<cpower> ok, anyone I miss?
|
19:11:47
|
<cpower> I'll take that as a no.
|
19:12:11
|
*** jriley has quit IRC
|
19:12:47
|
<cpower> Disscussion points: XFRM-79
|
19:12:48
|
<bwolfe> looks like there is one MUST ticket still unclaimed. I assume you are claiming that one now wyclif?
|
19:12:53
|
<cpower> No Blockers
|
19:13:08
|
<cpower> !scrumoff
|
19:13:08
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
19:13:26
|
<bwolfe> !ticket XFRM-79
|
19:13:27
|
<OpenMRSBot> bwolfe: [#XFRM-79] Need to include obs_datetime on xform designer - OpenMRS JIRA - https://tickets.openmrs.org/browse/XFRM-79
|
19:13:28
|
<wyclif> yeah
|
19:13:54
|
<bwolfe> lakkarau, did the ticket just prove to be too complex for you?
|
19:14:15
|
<bwolfe> lakkarau, if you are not working on it anymore, please click the "unassign" button.
|
19:14:25
|
<bwolfe> lakkarau, why do you say "it would effect other things" ?
|
19:14:32
|
<lakkarau> bwolfe:yes
|
19:15:24
|
<lakkarau> bwolfe: Daniel told me about this .
|
19:15:43
|
<bwolfe> told you about what? can you copy any discussions you had privately into a comment on the ticket?
|
19:16:34
|
<bwolfe> diptanuc, fyi, scrum over. you can ask general questions now.
|
19:16:49
|
<lakkarau> bwolfe:he said he discovered that there is another bug which will make it even harder for me to do that ticket.
|
19:17:14
|
<bwolfe> lakkarau, mmk, so where is that bug? we should link to it and/or put it in the sprint
|
19:17:43
|
<lakkarau> bwolfe: yes i am checking.
|
19:22:41
|
<diptanuc> bwolfe: I added an encounter with observations.
|
19:23:17
|
<diptanuc> bwolfe: And when i go to the patient dashboard for that guy, i still dont see the Most Recent Observations in the UI
|
19:23:18
|
<bwolfe> diptanuc, ok, so whatever question concept you used for those obs is what you need in your GP so that it shows on the dashboard
|
19:23:47
|
<diptanuc> bwolfe: Added pulse in GP
|
19:24:07
|
<diptanuc> bwolfe: Added an observation with pulse for an encounter for that patient
|
19:25:02
|
<diptanuc> bwolfe: I think we will be able to submit 3 patches!
|
19:25:25
|
<bwolfe> nice
|
19:26:41
|
<diptanuc> bwolfe: Surprisingly the only person who hasn't made any progress on a ticket is me! Lol
|
19:26:41
|
<bwolfe> diptanuc, so I did it on the demo server for you. see the "overview" tab for this patient on his dashboard: http://demo.openmrs.org/openmrs/patientDashboard.form?patientId=7280&phrase=john%20mamwa
|
19:26:54
|
<diptanuc> bwolfe: Let me check
|
19:27:15
|
<bwolfe> and search for "john mamwa" on this page to see the pulse: http://demo.openmrs.org/openmrs/admin/observations/index.htm
|
19:27:37
|
<bwolfe> and see the "**.showConcepts" property on this page: http://demo.openmrs.org/openmrs/admin/maintenance/globalProps.form
|
19:27:51
|
<bwolfe> diptanuc, you better pick up the pace then! :-)
|
19:28:09
|
<bwolfe> diptanuc, are your fellow hackers in here? did you tell me how many are hacking already?
|
19:31:02
|
<diptanuc> bwolfe: three pairs
|
19:32:19
|
<diptanuc> bwolfe: i see Most Recent Observations in your demo server
|
19:32:32
|
<bwolfe> diptanuc, TRUNK-2448 is hte first to get a patch submitted. :-)
|
19:32:33
|
<diptanuc> bwolfe: Dont see it on mine :( Not even an empty box!
|
19:33:03
|
<bwolfe> diptanuc, he even used mykola's new openmrs:message tag that was just submitted this morning. very well done by Andy Yates and team! :-)
|
19:33:32
|
<bwolfe> diptanuc, so your GP is not set right then. or your obs doesn't exist for that patient
|
19:35:46
|
*** pulasthi7 has quit IRC
|
19:35:52
|
*** rfriedman has quit IRC
|
19:37:31
|
*** mvorobey has joined #openmrs
|
19:38:52
|
<diptanuc> bwolfe: Now i have it too! We have another patch submitted now
|
19:40:18
|
<lakkarau> bwolfe :i will be working on #XFRM-63 and #XFRM-62.
|
19:40:50
|
<bwolfe> which one? only claim both if you're actively working on both right now
|
19:40:55
|
<bwolfe> !ticket XFRM-63
|
19:40:58
|
<OpenMRSBot> bwolfe: [#XFRM-63] Automated Error Reportjava.lang.NumberFormatException: For input string: - OpenMRS JIRA - https://tickets.openmrs.org/browse/XFRM-63
|
19:41:28
|
<bwolfe> !ticket XFRM-62
|
19:41:30
|
<OpenMRSBot> bwolfe: [#XFRM-62] Automated Error Report: java.lang.NumberFormatException: For input string: "" - OpenMRS JIRA - https://tickets.openmrs.org/browse/XFRM-62
|
19:42:31
|
<bwolfe> lakkarau, oh, looks like they're duplicates. I'll close one of them
|
19:42:51
|
<lakkarau> bwolfe:ok,which one?
|
19:43:08
|
<bwolfe> closed 63
|
19:43:17
|
*** downey has joined #openmrs
|
19:43:17
|
*** OpenMRSBot sets mode: +o downey
|
19:43:17
|
*** ChanServ sets mode: +o downey
|
19:43:21
|
<lakkarau> bwolfe:ok
|
19:43:23
|
<bwolfe> lakkarau, FYI: neither of these are listed as in the sprint.
|
19:43:34
|
*** rfilippi has joined #openmrs
|
19:43:42
|
<downey> Hi rfilippi and welcome to the #openmrs IRC channel.
|
19:44:10
|
<diptanuc> bwolfe: I am logging out, will submit a patch tonight
|
19:44:21
|
<rfilippi> bwolfe: re ticket 3408 if you would like to go the jQuery() route consistently can I also rename existing $j() references ?
|
19:44:38
|
<bwolfe> rfilippi, go for it
|
19:44:53
|
<diptanuc> bwolfe: rfilippi is my colleague and he is one of our participents!
|
19:45:00
|
<rfilippi> bwolfe: thanks, will submit corrected patch later tonight - need to travel home now
|
19:45:04
|
*** diptanuc has quit IRC
|
19:46:07
|
*** pushkar has quit IRC
|
19:46:17
|
<bwolfe> rfilippi, sounds good. good work today!
|
19:47:35
|
*** ChanServ sets mode: +v jkeiper
|
19:49:10
|
*** rfilippi has quit IRC
|
20:12:11
|
*** venkaban has quit IRC
|
20:12:41
|
*** venkaban has joined #openmrs
|
20:18:13
|
*** mccallumg has quit IRC
|
20:18:46
|
*** jkeiper has quit IRC
|
20:33:04
|
*** bwolfe has quit IRC
|
20:35:40
|
<lakkarau> bwolfe:i have added the comment to the #XFRM-79,regarding the discussion with Daniel.
|
20:35:55
|
*** rfilippi has joined #openmrs
|
20:39:56
|
*** bwolfe has joined #openmrs
|
20:39:56
|
*** ChanServ sets mode: +o bwolfe
|
20:45:47
|
*** bwolfe has quit IRC
|
20:50:25
|
*** rfilippi has quit IRC
|
21:07:13
|
*** lh has quit IRC
|
21:11:44
|
*** jordank has quit IRC
|
21:12:59
|
*** jordank has joined #openmrs
|
21:14:15
|
*** wyclif has quit IRC
|
21:19:15
|
*** robbyoconnor has quit IRC
|
21:19:51
|
*** robbyoconnor has joined #openmrs
|
21:19:51
|
*** ChanServ sets mode: +v robbyoconnor
|
21:20:15
|
*** cpower has quit IRC
|
21:21:02
|
*** jordank has quit IRC
|
21:23:59
|
*** robbyoconnor has quit IRC
|
21:24:26
|
*** robbyoconnor has joined #openmrs
|
21:24:26
|
*** ChanServ sets mode: +v robbyoconnor
|
21:32:28
|
*** robbyoconnor has quit IRC
|
21:32:51
|
*** robbyoconnor has joined #openmrs
|
21:32:51
|
*** ChanServ sets mode: +v robbyoconnor
|
21:35:21
|
*** robbyoconnor has quit IRC
|
21:36:01
|
*** robbyoconnor has joined #openmrs
|
21:36:01
|
*** ChanServ sets mode: +v robbyoconnor
|
21:53:17
|
*** lh has joined #openmrs
|
21:53:17
|
*** lh has joined #openmrs
|
21:54:50
|
*** mvorobey has quit IRC
|
21:55:50
|
*** goutham has quit IRC
|
21:58:04
|
*** jordank has joined #openmrs
|
22:14:37
|
*** orien has joined #openmrs
|
22:36:17
|
*** orien has quit IRC
|
22:57:07
|
*** kreddy has quit IRC
|
22:57:41
|
*** jordank has quit IRC
|
22:58:11
|
*** suranga has quit IRC
|
22:58:15
|
*** mseaton has joined #openmrs
|
22:58:15
|
*** ChanServ sets mode: +v mseaton
|
22:58:44
|
*** mseaton has left #openmrs
|
23:03:03
|
*** maurya has quit IRC
|
23:03:24
|
*** mseaton has joined #openmrs
|
23:03:24
|
*** ChanServ sets mode: +v mseaton
|
23:03:38
|
*** downey has quit IRC
|
23:04:26
|
*** mseaton has left #openmrs
|
23:24:28
|
*** lh has quit IRC
|
23:31:54
|
*** orien has joined #openmrs
|
23:42:30
|
*** lakkarau has quit IRC
|
23:43:23
|
*** jordank has joined #openmrs
|