00:51:13
|
*** andrewlkho has quit IRC
|
00:51:20
|
*** andrewlkho has joined #openmrs
|
02:10:39
|
*** harshadura has joined #openmrs
|
02:22:48
|
*** harshadura has quit IRC
|
02:30:04
|
*** sgithens has quit IRC
|
02:34:07
|
*** harshadura has joined #openmrs
|
03:29:32
|
*** pulasthi7 has joined #openmrs
|
03:49:58
|
*** harshadura has quit IRC
|
04:23:59
|
*** djazayeri has quit IRC
|
05:03:30
|
*** djazayeri has joined #openmrs
|
05:03:30
|
*** ChanServ sets mode: +o djazayeri
|
05:17:35
|
*** dkayiwa has joined #openmrs
|
05:58:46
|
*** djazayeri has quit IRC
|
06:29:54
|
*** djazayeri has joined #openmrs
|
06:29:54
|
*** ChanServ sets mode: +o djazayeri
|
06:31:51
|
*** djazayeri has quit IRC
|
07:42:43
|
*** dkayiwa has quit IRC
|
07:44:47
|
*** applecool has joined #openmrs
|
07:44:47
|
*** ChanServ sets mode: +v applecool
|
07:48:37
|
*** magoo_ has joined #openmrs
|
07:50:17
|
*** snoppy has joined #openmrs
|
07:51:03
|
*** applecoo_ has joined #openmrs
|
07:51:39
|
*** applecoo_ has quit IRC
|
07:53:54
|
*** applecool has quit IRC
|
08:00:18
|
*** rafa has joined #openmrs
|
08:00:18
|
*** ChanServ sets mode: +v rafa
|
08:01:41
|
*** magoo_ has quit IRC
|
08:18:11
|
*** magoo_ has joined #openmrs
|
08:28:37
|
*** upul` has joined #openmrs
|
08:28:37
|
*** ChanServ sets mode: +v upul`
|
08:29:41
|
*** rafa has quit IRC
|
08:32:55
|
*** rafa has joined #openmrs
|
08:32:55
|
*** ChanServ sets mode: +v rafa
|
08:41:16
|
*** magoo_ has quit IRC
|
08:42:28
|
*** applecool has joined #openmrs
|
08:42:28
|
*** ChanServ sets mode: +v applecool
|
09:06:54
|
*** magoo_ has joined #openmrs
|
09:21:44
|
<applecool> Hi rafa
|
09:21:55
|
<rafa> applecool: hi
|
09:27:40
|
*** magoo_ has quit IRC
|
09:32:51
|
*** magoo_ has joined #openmrs
|
09:41:24
|
*** applecool has quit IRC
|
09:41:53
|
*** applecool has joined #openmrs
|
09:41:53
|
*** ChanServ sets mode: +v applecool
|
09:45:12
|
*** goutham has joined #openmrs
|
09:52:32
|
*** applecoo_ has joined #openmrs
|
09:56:06
|
*** applecool has quit IRC
|
10:01:14
|
*** applecoo_ is now known as applecool
|
10:01:15
|
*** ChanServ sets mode: +v applecool
|
10:01:24
|
*** dkayiwa has joined #openmrs
|
10:08:52
|
*** applecoo_ has joined #openmrs
|
10:09:59
|
*** jeed has joined #openmrs
|
10:12:34
|
*** applecool has quit IRC
|
10:14:11
|
*** magoo_ has quit IRC
|
10:14:37
|
*** applecoo_ is now known as applecool
|
10:14:38
|
*** ChanServ sets mode: +v applecool
|
10:22:09
|
<rafa> dkayiwa: hey
|
10:22:14
|
<rafa> dkayiwa: do you know who is SNsubuga?
|
10:22:17
|
<dkayiwa> rafa: hey
|
10:22:30
|
<dkayiwa> rafa: i know a number of people with that name :)
|
10:22:42
|
<rafa> dkayiwa: he/she committed to xforms
|
10:22:58
|
<dkayiwa> rafa: yes i know him :)
|
10:23:19
|
<rafa> dkayiwa: do you know if he has a github account?
|
10:23:29
|
<dkayiwa> rafa: he does not
|
10:23:50
|
<rafa> dkayiwa: how can I reach him?
|
10:24:04
|
<dkayiwa> rafa: i have his email address
|
10:24:21
|
<rafa> dkayiwa: great
|
10:24:59
|
*** applecool has quit IRC
|
10:27:28
|
*** applecool has joined #openmrs
|
10:27:28
|
*** ChanServ sets mode: +v applecool
|
10:32:56
|
*** suranga has joined #openmrs
|
10:37:17
|
*** applecoo_ has joined #openmrs
|
10:38:29
|
*** applecool has quit IRC
|
10:39:29
|
<suranga> hi pulasthi7
|
10:39:34
|
<suranga> pulasthi7, are you here ? :)
|
10:41:45
|
*** applecoo_ is now known as applecool
|
10:41:45
|
*** ChanServ sets mode: +v applecool
|
10:44:01
|
<applecool> hi rafa
|
10:57:51
|
*** james_regen has joined #openmrs
|
10:57:51
|
*** ChanServ sets mode: +v james_regen
|
11:00:26
|
*** magoo_ has joined #openmrs
|
11:01:25
|
*** applecoo_ has joined #openmrs
|
11:04:19
|
*** applecool has quit IRC
|
11:06:09
|
*** applecoo_ is now known as applecool
|
11:06:12
|
*** ChanServ sets mode: +v applecool
|
11:08:01
|
*** snoppy has quit IRC
|
11:08:09
|
<rafa> applecool: hi
|
11:08:15
|
<applecool> hi rafa
|
11:08:40
|
<rafa> applecool: can we chat?
|
11:08:45
|
<applecool> yes sure
|
11:09:08
|
<applecool> i am stuck rafa donno how to proceed
|
11:09:09
|
<rafa> dkayiwa: do you know yanokwa? :)
|
11:09:14
|
<applecool> i am unable to complete the tasks
|
11:09:26
|
<applecool> i mean the filtering stuff
|
11:09:26
|
<rafa> applecool: how long are you stuck?
|
11:09:35
|
<applecool> yesterday i tried
|
11:09:43
|
<rafa> applecool: why haven't you e-mailed me?
|
11:10:00
|
<applecool> ah! i was trying in the morning
|
11:10:01
|
*** snoppy has joined #openmrs
|
11:10:07
|
<applecool> was checking how can i solve the problem
|
11:10:15
|
<applecool> but was unsuccessful
|
11:10:51
|
<applecool> i just wrote the search test and made it pass
|
11:10:52
|
<dkayiwa> rafa: i do
|
11:11:01
|
<rafa> applecool: I asked you to e-mail me whenever you're blocked for more than an hour
|
11:11:04
|
<applecool> and i commited it
|
11:11:16
|
<applecool> yes yyou did
|
11:11:18
|
<rafa> dkayiwa: e-mail? :)
|
11:12:10
|
<rafa> applecool: I really don't like that you're stuck and you don't e-mail me
|
11:12:10
|
<dkayiwa> rafa: sent :)
|
11:12:22
|
<applecool> my bad
|
11:12:41
|
<rafa> applecool: what are you stuck on?
|
11:12:45
|
<rafa> dkayiwa: thx!
|
11:13:03
|
<applecool> the filtering of the packages in the mypackages
|
11:13:33
|
<rafa> applecool: ok and what exactly?
|
11:13:41
|
<applecool> first thing is
|
11:13:56
|
<applecool> i added an empty method in the packageform controller
|
11:14:11
|
<rafa> applecool: don't tell me what you did only what is the problem :)
|
11:14:19
|
<applecool> so that i can do the request mapping for that mypackages place
|
11:14:34
|
<applecool> but its still showing me the page not found error
|
11:14:41
|
<rafa> applecool: committed?
|
11:14:43
|
<applecool> commited it can you see it?
|
11:14:45
|
<applecool> yes
|
11:14:52
|
<rafa> applecool: let me look
|
11:14:56
|
<applecool> okay
|
11:15:41
|
<rafa> @RequestMapping(value = "/mypackages")
|
11:15:58
|
<rafa> applecool: it says the url is localhost:8080/mypackages
|
11:16:03
|
<applecool> yes
|
11:16:26
|
<rafa> applecool: <Menu name="MyPackages" title="menu.mypackages" page="/packageform/mypackages" roles="ROLE_USER,ROLE_ADMIN"/>
|
11:16:38
|
<rafa> applecool: why did you put here a wrong path?
|
11:17:15
|
<applecool> rafa: : @RequestMapping(value = "/mypackages") means its localhost:8080/packageform/mypackages right?
|
11:17:50
|
<rafa> applecool: wait I need to see the whole class...
|
11:17:52
|
<applecool> if we say : @RequestMapping("/mypackages") means then it is localhost:8080/mypackages
|
11:18:49
|
<applecool> because at the starting of the class after @Controller we have put : @RequestMapping("/packageform")
|
11:19:05
|
<rafa> applecool: right the class is annotated with @RequestMapping("/packageform*")
|
11:19:12
|
<applecool> yes
|
11:19:21
|
<rafa> applecool: your method is annotated with @RequestMapping(value = "/mypackages")
|
11:19:27
|
<applecool> yes
|
11:19:36
|
<applecool> i did it correct right?
|
11:19:38
|
<rafa> applecool: so the URL is localhost:8080/packageform/mypackages.form
|
11:19:43
|
<applecool> yes
|
11:20:01
|
<rafa> applecool: if you don't put * at the end then you have to put .form in the URL
|
11:20:17
|
<applecool> oh
|
11:20:21
|
<applecool> i dint knew that
|
11:20:37
|
<applecool> you mean in the : @RequestMapping(value = "/mypackages.form") ?
|
11:20:42
|
<applecool> like this?
|
11:20:47
|
<rafa> applecool: no
|
11:20:51
|
<rafa> applecool: @RequestMapping(value = "/mypackages")
|
11:21:06
|
<rafa> applecool: it means that the URL is /mypackages.form
|
11:21:17
|
<applecool> oh
|
11:21:31
|
<rafa> applecool: anyway it's not the right place for this method
|
11:21:41
|
<applecool> hmm.
|
11:21:44
|
<rafa> applecool: we don't want the url to be /packageform/mypackages
|
11:21:52
|
<rafa> applecool: only /mypackages
|
11:22:09
|
<rafa> applecool: so what you need to do is put that method in PackageController
|
11:22:35
|
<applecool> Okay will do that
|
11:22:38
|
<rafa> applecool: move @RequestMapping("/mainMenu*") to the handleRequest method
|
11:23:09
|
<rafa> applecool: then PackageController will server both /mainMenu and /mypackages
|
11:23:21
|
<rafa> applecool: is that clear?
|
11:24:33
|
<applecool> i dint get the line!
|
11:24:52
|
<rafa> applecool: what you didn't get?
|
11:25:11
|
<applecool> move @RequestMapping("/mainMenu*")
|
11:25:22
|
<rafa> applecool: it's on the class right now
|
11:25:27
|
<applecool> yes
|
11:26:03
|
<rafa> applecool: it means it will be attached to all methods withing the class
|
11:26:14
|
<rafa> applecool: you want to remove it from the class
|
11:26:22
|
<rafa> applecool: and put directly on the handleRequest method
|
11:26:55
|
<applecool> okay
|
11:27:01
|
<rafa> applecool: so you will have @RequestMapping(value="/mainMenu*", method = RequestMethod.GET)
|
11:27:25
|
<rafa> applecool: you can rename the method as well to mainMenu to make it more meaningful
|
11:28:00
|
*** upul` has quit IRC
|
11:28:17
|
<applecool> okay
|
11:28:17
|
<rafa> applecool: then you add mypackages method annotated with @RequestMapping(value="/mypackages*", method = RequestMethod.GET)
|
11:28:43
|
<rafa> applecool: this way the URL will be localhost:8080/mypackages
|
11:29:07
|
<applecool> yes!
|
11:29:21
|
<rafa> applecool: and it'll display WEB-INF/pages/mypackages.jsp
|
11:29:38
|
<applecool> yes knew it :)
|
11:29:58
|
<applecool> as you said to put it in the packageFormController i was trying that! apologies
|
11:30:19
|
<rafa> applecool: it would work in PackageFormController
|
11:30:34
|
<rafa> applecool: but the URL wouldn't be nice
|
11:30:38
|
<applecool> yes
|
11:31:18
|
<rafa> applecool: and you'd have to put jsp in WEB-INF/pages/packageform/mypackages.jsp
|
11:31:51
|
<applecool> oh!
|
11:32:18
|
<applecool> that would be if the method is in the packageformcontroller right?
|
11:32:19
|
<rafa> applecool: anyway you also have to implement the method, you need to put packageList in the model
|
11:32:26
|
<rafa> applecool: right
|
11:32:36
|
<rafa> same as in handleRequest
|
11:32:58
|
<rafa> applecool: but you need to filter it out and display only packages of the currently logged in user
|
11:33:30
|
<rafa> applecool: I'd modify magr.search to take query and user
|
11:34:07
|
<rafa> applecool: you can get user same as in PackageFormController.onSubmit
|
11:34:11
|
*** magoo_ has quit IRC
|
11:34:15
|
<rafa> applecool: clear?
|
11:34:24
|
<applecool> oh! yes very clear
|
11:34:44
|
<rafa> applecool: ok let me know how it goes
|
11:34:51
|
<applecool> okay!
|
11:35:03
|
<rafa> applecool: please remember that you have to present this week
|
11:35:15
|
<applecool> yes! i remember rafa
|
11:35:24
|
<rafa> applecool: prepare a presentation by tomorrow
|
11:35:42
|
<applecool> okay! so how you want it to be?
|
11:35:50
|
<applecool> explaining the features right?
|
11:35:53
|
<rafa> applecool: it needs to say what is the project about, what you did and what else needs to be done
|
11:36:21
|
<rafa> applecool: you'll also need to show a demo
|
11:36:22
|
<applecool> okay!
|
11:36:32
|
<applecool> i will show it you
|
11:36:55
|
<rafa> applecool: ideally it would be a pre-recorded screencast
|
11:37:07
|
<rafa> applecool: but you can also make some screenshots
|
11:37:12
|
<applecool> oh
|
11:37:19
|
<applecool> recording is not possible i guess rafa
|
11:37:48
|
<rafa> applecool: ok so include some screenshots in your presentation
|
11:37:59
|
<applecool> okay will do
|
11:39:20
|
<rafa> applecool: good any more questions?
|
11:39:42
|
<applecool> no will do the work and let you know!
|
11:46:08
|
*** lh has quit IRC
|
12:07:55
|
*** applecool has quit IRC
|
12:11:31
|
*** pulasthi7 has quit IRC
|
12:11:42
|
*** bwolfe has joined #openmrs
|
12:11:42
|
*** ChanServ sets mode: +o bwolfe
|
12:15:45
|
*** wyclif has quit IRC
|
12:24:26
|
*** snoppy1 has joined #openmrs
|
12:24:43
|
*** snoppy has quit IRC
|
12:29:11
|
*** dkayiwa has quit IRC
|
12:35:42
|
*** downey has joined #openmrs
|
12:35:42
|
*** ChanServ sets mode: +o downey
|
12:35:42
|
*** OpenMRSBot sets mode: +o downey
|
12:46:15
|
*** lh has joined #openmrs
|
12:46:15
|
*** lh has joined #openmrs
|
13:01:01
|
*** wyclif has joined #openmrs
|
13:08:41
|
*** mvorobey has joined #openmrs
|
13:08:46
|
<mvorobey> hi all
|
13:08:53
|
*** mvorobey has quit IRC
|
13:13:15
|
*** maurya has joined #openmrs
|
13:13:44
|
*** pushkar has joined #openmrs
|
13:18:23
|
*** suranga has quit IRC
|
13:21:48
|
*** dkayiwa has joined #openmrs
|
13:24:54
|
*** ibewes has joined #openmrs
|
13:26:46
|
<ibewes> howdy all!
|
13:26:54
|
*** sgithens has joined #openmrs
|
13:28:20
|
<ibewes> I've got a question about unit tests... is it possible to have a test applicationContext.xml file that is loaded as part of a BaseModuleContextSensitiveTest test? If so, how?
|
13:32:53
|
<rafa> ibewes: you can create TestingApplicationContext.xml and it'll be loaded by BaseModuleContextSensitiveTest
|
13:33:55
|
<ibewes> rafa: I did that, though it appears that case matters and it must be 'testingApplicationContext.xml' which simply brings me to another error
|
13:34:35
|
<rafa> ibewes: hmm yes case matters, but it must be TestingApplicationContext.xml
|
13:34:57
|
<rafa> ibewes: see @ContextConfiguration in BaseModuleContextSensitiveTest
|
13:35:08
|
<ibewes> rafa: ok, I'll check that out
|
13:35:29
|
<rafa> ibewes: be sure to put the file on the classpath
|
13:35:58
|
<rafa> ibewes: if your module is mavenized that would be in src/test/resources
|
13:38:47
|
<ibewes> rafa: strange, that is where I have the file... looks like cleaning the project fixed it
|
13:42:18
|
<ibewes> rafa: though now I'm getting an error when it tries to load the ApplicationContext. Can you take a look at http://pastebin.com/RC373ZtV
|
13:43:01
|
<pushkar> bwolfe, Hi Good Morning
|
13:43:12
|
<bwolfe> hey
|
13:43:14
|
<rafa> ibewes: I've fixed that in core today
|
13:43:31
|
<ibewes> rafa: Ha! you've got good timing :)
|
13:43:50
|
<pushkar> bwolfe, How's your weekend ?
|
13:43:50
|
<rafa> ibewes: just update and build the core :)
|
13:44:00
|
<ibewes> rafa: is that in 1.9.x?
|
13:44:10
|
<rafa> ibewes: yes
|
13:44:19
|
*** dkayiwa has quit IRC
|
13:44:34
|
<ibewes> rafa: awesome, thanks!
|
13:44:47
|
<rafa> ibewes: does your module depend on 1.9.1-SNAPSHOT?
|
13:51:11
|
*** harshadura has joined #openmrs
|
13:52:30
|
<bwolfe> pushkar, weekend was too short, as always. lots of driving. 6 hours each way over to see some family
|
13:52:37
|
*** diptanuc has joined #openmrs
|
13:52:39
|
<bwolfe> 6 hours in a car with 3 kids is more like 18 hours. :-)
|
13:55:40
|
<pushkar> Haha...:-D you people drive a lot!!!!
|
13:57:37
|
<ibewes> rafa: no, it depends on 1.9.0-SNAPSHOT, I take it I should change that
|
13:58:48
|
<rafa> bwolfe: are we still creating 1.9.0-SNAPSHOT instead of 1.9.1-SNAPSHOT?
|
13:59:01
|
<bwolfe> rafa, no, I fixed that on friday
|
13:59:20
|
<rafa> ibewes: ahh you need to depend on 1.9.1-SNAPSHOT :)
|
13:59:22
|
*** cpower has joined #openmrs
|
13:59:30
|
<ibewes> rafa: is there a version that points to the most recent 1.9 build, regardless of the minor version?
|
13:59:34
|
*** magoo_ has joined #openmrs
|
13:59:48
|
<cpower> *poof* I have returned!
|
13:59:50
|
<rafa> ibewes: nope
|
14:00:44
|
<cpower> Good morning Developers, are we ready to have our Daily dose of Scrum?
|
14:00:55
|
<ibewes> rafa: ok, just checking
|
14:01:13
|
<ibewes> cpower: morning?! the day is almost over here :)
|
14:01:42
|
<cpower> ibewes...good point we really need to find a time neutral greeting
|
14:01:53
|
<cpower> anycase let's get this party started.
|
14:01:59
|
<cpower> !scrumon cpower
|
14:01:59
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
14:02:38
|
<cpower> Order: bwolfe, downey (optional), rafa, wyclif, and who ever sneaks in that I didn't catch.
|
14:03:34
|
* bwolfe looks at empty scrum page
|
14:04:00
|
<cpower> whaaa?
|
14:04:27
|
<bwolfe> Friday
|
14:04:27
|
<bwolfe> emails
|
14:04:27
|
<bwolfe> review daniel's sxs code
|
14:04:27
|
<bwolfe> fix github authors
|
14:04:27
|
<bwolfe> fix htmlformentry compiling
|
14:04:28
|
<bwolfe> (half day)
|
14:04:30
|
<bwolfe> Monday
|
14:04:32
|
<bwolfe> commented on triaged tickets
|
14:04:34
|
<bwolfe> emails
|
14:04:38
|
<bwolfe> set up ci for other modules version testing
|
14:04:40
|
<bwolfe> mavenize xforms?
|
14:04:42
|
<bwolfe> review sprint tickets?
|
14:04:44
|
<bwolfe> no blockers
|
14:04:46
|
<bwolfe> (empty because I've been ignoring my popup to put in what I've been working on today)
|
14:05:22
|
<rafa> bwolfe: I'm taking care of xforms :P
|
14:05:23
|
<cpower> oh, here I thought Kiran and I may have missed somethign
|
14:05:46
|
<cpower> downey you have anything you want to share with the class?
|
14:06:33
|
<rafa> timeout I'll go :)
|
14:06:35
|
<rafa> Today:
|
14:06:35
|
<rafa> * In Progress XFRM-85 Multiple version testing in XForm module
|
14:06:35
|
<rafa> * In Progress XFRM-84 Verify unit tests are working in XForm module after mavenization
|
14:06:35
|
<rafa> * In Progress XFRM-83 Mavenize the XForm module
|
14:06:35
|
<rafa> No blockers.
|
14:06:50
|
*** harshadura_ has joined #openmrs
|
14:06:52
|
<bwolfe> rafa++
|
14:07:08
|
<cpower> 2 min limit with rafa ...check
|
14:07:09
|
*** diptanuc has quit IRC
|
14:07:12
|
<wyclif> Friday:
|
14:07:12
|
<wyclif> Fixing compilation errors in reporting module
|
14:07:13
|
<wyclif> Weekly gsoc chat/discussion with Dmitry
|
14:07:13
|
<wyclif> Review TODOs for HTML-176 - includeIf velocityTest: evaluate the $patient.age as a number doesn't work.
|
14:07:13
|
<wyclif> revisisted REPORT-383 - On run / schedule report page, allow for expressions to be specified in addition to fixed values
|
14:07:14
|
<bwolfe> rafa, pushing to github as well? :-)
|
14:07:14
|
<wyclif> REPORT-399 - Support "groups of things" in UI that are not patient cohorts
|
14:07:16
|
<wyclif> Monday:
|
14:07:18
|
<wyclif> Curating tickets
|
14:07:20
|
<wyclif> complete REPORT-399 - Support "groups of things" in UI that are not patient cohorts
|
14:07:22
|
<wyclif> Pick another bug ticket
|
14:07:22
|
<rafa> bwolfe: yes
|
14:07:24
|
<wyclif>
|
14:07:26
|
<wyclif> Blockers: None
|
14:07:49
|
<cpower> anybody else have something to share?
|
14:08:18
|
*** harshadura has quit IRC
|
14:08:28
|
<cpower> Summary: No blockers, see above for discussion points
|
14:08:35
|
<bwolfe> wyclif, you aren't bug fixing this week again, are you?
|
14:08:42
|
*** harshadura_ has quit IRC
|
14:08:52
|
*** harshadura has joined #openmrs
|
14:08:56
|
<cpower> !scrumoff
|
14:08:56
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
14:09:00
|
<bwolfe> cpower, you're supposed to keep track of those discussion points and then paste them after the scrumoff
|
14:09:03
|
<bwolfe> rafa, ok, if you're pushing to github, then documentation is 100% paramount to get done this week. need to make sure its easy for newbies to develop next week with xforms.
|
14:09:58
|
<rafa> bwolfe: I think I've seen a ticket for that
|
14:10:13
|
<bwolfe> yes, there is
|
14:11:23
|
<ibewes> are there any tickets that I could help out with? I'm looking to get more involved if possible
|
14:12:16
|
<rafa> bwolfe: is git gc --aggressive --prune=now supposed to take very looooooooong?
|
14:12:57
|
<bwolfe> ibewes, there are always sprint tickets. :-). go to sprint schedule page, follow links to jira dashboard for this sprint. https://wiki.openmrs.org/display/RES/Sprint+Schedule
|
14:13:04
|
<bwolfe> rafa, what is gc ?
|
14:13:14
|
<rafa> bwolfe: it's from https://wiki.openmrs.org/display/docs/Migrating+to+Git
|
14:13:22
|
<rafa> bwolfe: last step of getting rid of jars
|
14:14:06
|
<ibewes> bwolfe: ah, ok thanks!
|
14:14:27
|
* bwolfe looks at jira dashboard to make sure, now that he told ibewes to look there!
|
14:14:43
|
*** maurya has quit IRC
|
14:14:44
|
*** deepaganu has joined #openmrs
|
14:14:44
|
<bwolfe> rafa, only took seconds when I did it on htmlwidgets
|
14:14:57
|
<bwolfe> rafa, but xforms is very large, so perhaps its longer?
|
14:14:57
|
<deepaganu> Hi bwolfe
|
14:15:04
|
<rafa> bwolfe: hmmm it's more than 30 minutes now on xforms
|
14:15:13
|
<rafa> bwolfe: and I've just read it's not really needed
|
14:15:33
|
<rafa> bwolfe: I can achieve the same if I delete and clone from github
|
14:16:19
|
<deepaganu> bwolfe, do we need to have a nexus account to put the third party jars in the OpenMRS maven repo
|
14:16:47
|
<rafa> bwolfe: I'll wait a little longer...
|
14:17:29
|
<bwolfe> deepaganu, yes
|
14:17:40
|
<bwolfe> deepaganu, you can ask for an account on nexus by opening an ITSM ticket in jira
|
14:17:48
|
<deepaganu> ok
|
14:17:53
|
<deepaganu> thank bwolfe
|
14:28:12
|
*** deepaganu has quit IRC
|
14:28:33
|
*** maurya has joined #openmrs
|
14:33:20
|
*** diptanuc has joined #openmrs
|
14:37:33
|
*** diptanuc has quit IRC
|
14:37:54
|
*** diptanuc has joined #openmrs
|
14:41:05
|
<ibewes> is there an easy way to get more information about an 'Unable to set module service' error when trying to run a unit test?
|
14:41:07
|
*** deepaganu has joined #openmrs
|
14:42:03
|
<ibewes> I assume that this means something about my applicationContext.xml file is wrong, but without any further details I'm kinda lost
|
14:46:52
|
<rafa> ibewes: run it mvn clean install and then go to target/surefire-reports, open one of the files and see the full error
|
14:48:00
|
*** diptanuc has quit IRC
|
14:49:01
|
<sgithens> If I get this from a module, I'm guessing the fix is just to checkout and build that version on my machine? [WARNING] The requested profile "openrms-1.9" could not be activated because it does not exist.
|
14:49:13
|
<sgithens> this is from mvn
|
14:49:34
|
<sgithens> or can I add an online mvn repo for it to read from
|
14:49:56
|
<ibewes> rafa: my tests don't currently get run by mvn (sorry, maven noob here)
|
14:50:30
|
<rafa> ibewes: it's enough to put them in src/test/java and they'll be run by maven
|
14:51:18
|
<bwolfe> sgithens, you just have to spell "openmrs" right. :-)
|
14:51:30
|
<sgithens> bwolfe: hahahahaha
|
14:51:40
|
<bwolfe> "open mrs" versus "open richard m stallman"
|
14:51:43
|
<sgithens> thanks, I actually copy and pasted the whole command from an email sent to me
|
14:51:56
|
<sgithens> err, jira comment
|
14:52:26
|
<ibewes> rafa: is that true for tests in the api project as well?
|
14:52:26
|
<sgithens> I can't imagine what a more Open RMS would be like
|
14:53:20
|
*** rfriedman has joined #openmrs
|
14:53:56
|
<rfriedman> bwolfe, hi ben, got a minute?
|
14:54:05
|
<bwolfe> sure
|
14:54:41
|
<rfriedman> bwolfe, what is the meaning of "required version" in config.xml? Does it have to be exactly that version or can it be greater?
|
14:55:25
|
<rfriedman> require_version
|
14:55:42
|
<bwolfe> rfriedman, can be greater.
|
14:55:43
|
<bwolfe> https://wiki.openmrs.org/display/docs/Module+Config+File
|
14:55:44
|
<OpenMRSBot> <http://ln-s.net/8c42> (at wiki.openmrs.org)
|
14:56:31
|
<ibewes> rafa: I ask because my tests are in \api\src\test\java\ but they are not getting executed when I run 'mvn clean install'
|
14:56:55
|
<rfriedman> bwolfe, what if a greater version breaks the module, is there a way to prevent it from loading?
|
14:57:10
|
<bwolfe> rfriedman, see that wiki page. you can put in a range
|
14:57:27
|
<rafa> ibewes: they should be run by default
|
14:57:49
|
<rafa> ibewes: it's hard to tell what's wrong without seeing the code
|
14:57:59
|
<rfriedman> bwolfe, oh duh, sorry, read the first sentence only
|
14:58:41
|
<bwolfe> ibewes, perhaps give some background of what you're trying to do? or what you've tried?
|
14:59:26
|
*** deepaganu has quit IRC
|
15:00:33
|
<ibewes> bwolfe: I'm just trying to run the unit tests for a module I'm working on; part of these tests involves getting the module from the Context and making sure it was loaded correctly
|
15:01:16
|
<bwolfe> ibewes, ah ok. do we have a wiki page for "unit tests in modules" ?
|
15:02:19
|
<ibewes> bwolfe: according to the docs I've read I should make my test type inherit from BaseModuleContextSensitiveTest, which seems to do what I expect (ie, load my TestApplicationContext.xml), but now I'm having trouble diagnosing the errors I'm getting when attempting to run the tests
|
15:03:56
|
<bwolfe> ibewes, can you run "mvn clean test" in the base directory and pastebin your full logs? that might help us out
|
15:04:33
|
*** jordank has joined #openmrs
|
15:06:08
|
<ibewes> bwolfe: sure: http://pastebin.com/SvMqX31V
|
15:06:26
|
*** harshadura has quit IRC
|
15:07:18
|
<ibewes> bwolfe: there are no tests in the omod project (yet), I am not sure if that is the cause of that error
|
15:07:39
|
<bwolfe> ibewes, what if you do "mvn clean install" instead ?
|
15:07:48
|
*** maurya has quit IRC
|
15:08:14
|
<bwolfe> I've seen that "The source must not be a directory." error in htmlformentry when doing "mvn test" instead of "mvn install"
|
15:08:36
|
*** pushkar has quit IRC
|
15:08:54
|
<ibewes> bwolfe: mvn clean install runs fine, but won't run the tests: http://pastebin.com/3i99uq2C
|
15:09:33
|
*** harshadura has joined #openmrs
|
15:10:20
|
<bwolfe> ibewes, do you have @Test annotation on any methods?
|
15:11:22
|
<rafa> ibewes: also your tests need to be named SomethingTest.java
|
15:11:30
|
<rafa> ibewes: needs to end with Test.java
|
15:12:25
|
<ibewes> rafa: ahhhh, I use *Tests.java... let me change that and try
|
15:13:49
|
*** mvorobey has joined #openmrs
|
15:14:26
|
<ibewes> rafa: yup, that was the issue. I assume that is a well-known convention that I just didn't know from .Net
|
15:15:02
|
<rafa> ibewes: yes, it's how the maven junit plugin finds files with tests
|
15:15:22
|
<rafa> ibewes: it can be configured, but Test.java is a default
|
15:15:39
|
*** diptanuc has joined #openmrs
|
15:15:45
|
<ibewes> rafa: understood, well thanks for mentioning it!
|
15:16:46
|
*** harshadura has quit IRC
|
15:18:43
|
<rafa> bwolfe: we're not moving tags to github right?
|
15:18:46
|
*** deepaganu has joined #openmrs
|
15:18:55
|
<bwolfe> rafa, right
|
15:19:03
|
<rafa> bwolfe: ok
|
15:19:11
|
<bwolfe> well, you can copy them over if you want, but don't delete them from scn
|
15:19:32
|
<rafa> bwolfe: well, I did that, but I can't remove jars from them
|
15:19:45
|
<bwolfe> oh
|
15:19:48
|
<bwolfe> then leave them out. :-)
|
15:19:54
|
<bwolfe> smaller download == better
|
15:19:54
|
<rafa> bwolfe: yes
|
15:20:00
|
<ibewes> rafa/bwolfe: sorry to continue to bug you guys with questions... do you have time for one more?
|
15:20:16
|
<bwolfe> ibewes, only time enough for half
|
15:20:26
|
<ibewes> bwolfe: :P
|
15:20:40
|
*** diptanuc has quit IRC
|
15:21:37
|
*** thompcha has joined #openmrs
|
15:21:47
|
<downey> Hi thompcha and welcome to the #openmrs IRC channel.
|
15:21:58
|
<thompcha> Thanks
|
15:22:21
|
<thompcha> I'm a Peace Corps volunteer in the Dominican Republic
|
15:22:21
|
<ibewes> the files that rafa mentioned in surefire-reports give me the same information I was seeing before; the lowest level stack trace for the error is simply: http://pastebin.com/JBsHV9Qn
|
15:22:47
|
<thompcha> There's a chance I may be helping to deploy OpenMRS at a clinic in the La Romana
|
15:23:23
|
<ibewes> bwolfe: so I'm still not sure why it's 'unable to set the module service'
|
15:24:30
|
*** harshadura has joined #openmrs
|
15:28:39
|
*** diptanuc has joined #openmrs
|
15:28:42
|
*** deepaganu has quit IRC
|
15:29:43
|
<bwolfe> thompcha, the DR?
|
15:30:09
|
<bwolfe> thompcha, jmiranda was in the DR for a long while. I think PIH might have a presence there.
|
15:30:19
|
<bwolfe> ibewes, whats the full log output?
|
15:30:32
|
<bwolfe> ibewes, and can you paste your moduleAppContext.xml file?
|
15:32:11
|
<ibewes> bwolfe: here is both http://pastebin.com/KjQux8g6
|
15:33:18
|
<bwolfe> ibewes, is "org.openmrs.module.openhmis.plm.impl.PersistentListService" the right path?
|
15:33:27
|
<bwolfe> (looking at the "impl" in there)
|
15:33:45
|
<thompcha> How exciting! What's PIH?
|
15:34:19
|
<bwolfe> thompcha, Partner's in Health. one of the larger orgs that uses openmrs in a bunch of different places
|
15:34:44
|
<ibewes> bwolfe: Well that's embarrassing. You're totally right, and with that change it's working
|
15:34:54
|
<ibewes> bwolfe/rafa: thank you both very much!
|
15:35:31
|
<bwolfe> ibewes, :-)
|
15:35:55
|
<bwolfe> ibewes, I am only able to help with things like that so quickly because I have done the same thing myself. ;-)
|
15:36:09
|
<thompcha> Oh, that's great news. I know an RPCV (Peace Corps alum) who works for PIH
|
15:36:14
|
<bwolfe> ibewes, its what makes mvorobey think I am a genius .
|
15:36:21
|
<ibewes> bwolfe: hehe
|
15:37:26
|
<ibewes> thanks again for the help. Evening here so I'm out
|
15:37:45
|
*** ibewes has quit IRC
|
15:38:27
|
*** deepaganu has joined #openmrs
|
15:45:10
|
*** diptanuc has quit IRC
|
15:48:37
|
*** thompcha has quit IRC
|
15:48:38
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Log Manager 1.3.5 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=logmanager&version=&1.3.5>
|
15:51:14
|
<mvorobey> bwolfe, hi, I always had to say that you are genius, because you ... are :)
|
15:52:02
|
*** diptanuc has joined #openmrs
|
15:52:06
|
<mvorobey> bwolfe, very slow moving in direction of getting reporting to be tested against all these versions of openmsr
|
15:52:14
|
<mvorobey> openmsr = openmrs :)
|
15:52:57
|
<bwolfe> mvorobey, yeah, I'm not surprised. thats why I suggested you put in github, then do that. :-)
|
15:53:11
|
<bwolfe> mvorobey, that way the other things that wyclif and rafa are working on can be committed
|
15:56:24
|
<mvorobey> bwolfe, I'd do it right now, nut actually, on very slow and limited connection, so need to wait until tomorrow morning, when I'll be on better connection :(
|
15:56:33
|
<mvorobey> nut = but
|
15:56:35
|
*** snoppy1 has quit IRC
|
15:58:04
|
*** snoppy has joined #openmrs
|
15:59:32
|
*** lh has quit IRC
|
16:01:39
|
*** magoo_ has quit IRC
|
16:01:40
|
<mvorobey> bwolfe, can you answer to such smallest question ?
|
16:02:10
|
<bwolfe> gotta run for a few minutes.
|
16:02:25
|
<mvorobey> bwolfe, :(
|
16:06:20
|
*** rafa has quit IRC
|
16:08:28
|
*** djazayeri has joined #openmrs
|
16:08:28
|
*** ChanServ sets mode: +o djazayeri
|
16:12:24
|
<mvorobey> djazayeri, hi
|
16:12:30
|
<djazayeri> hi mvorobey
|
16:12:47
|
<mvorobey> djazayeri, have a minute or two ?
|
16:13:01
|
<djazayeri> what's up?
|
16:13:04
|
<mvorobey> djazayeri, great :)
|
16:13:08
|
<mvorobey> djazayeri, How can I determine whether certain request was received from core or module jsp page ?
|
16:14:16
|
<djazayeri> mvorobey: typically the request URI would have .../modules/(moduleid)/... in it if it's from a module
|
16:14:20
|
<djazayeri> this isn't guaranteed though
|
16:14:36
|
<djazayeri> because a module can override any url it chooses.
|
16:14:49
|
<mvorobey> djazayeri, it is a bit pity :(
|
16:15:08
|
<mvorobey> djazayeri, is there a way that 100% guarantees it ?
|
16:15:23
|
<djazayeri> mvorobey: from within the jsp page?
|
16:15:35
|
<djazayeri> mvorobey: is this about the in-app-translation?
|
16:15:38
|
*** pulasthi7 has joined #openmrs
|
16:15:54
|
<djazayeri> mvorobey: all module messages should start with "moduleid." also
|
16:16:53
|
<mvorobey> djazayeri, How did you guess? :)
|
16:17:45
|
<mvorobey> djazayeri, yes, but not everyone may follow to this convention ...
|
16:18:06
|
<djazayeri> mvorobey: starting a call now. but I'm pretty sure that is enforced by the module framework
|
16:19:09
|
<mvorobey> djazayeri, sorry, did you mean that message prefix is enforced?
|
16:19:16
|
<djazayeri> mvorobey: yes, i think so
|
16:19:34
|
<mvorobey> djazayeri, awesome :) thanks !
|
16:24:02
|
*** suranga has joined #openmrs
|
16:24:02
|
*** ChanServ sets mode: +v suranga
|
16:24:48
|
<suranga> hi pulasthi7
|
16:24:53
|
<suranga> pulasthi7, are you here ? :)
|
16:25:00
|
<pulasthi7> hi suranga,
|
16:25:11
|
<suranga> pulasthi7, are you back in colombo ?
|
16:25:30
|
<pulasthi7> suranga, yes. I came today.
|
16:25:44
|
<suranga> pulasthi7, ah, I seee
|
16:26:06
|
<suranga> pulasthi7, mm... so the alms giving is over, or will you be heading back ?
|
16:26:55
|
<pulasthi7> suranga, they are all finished. now back to the project.
|
16:27:55
|
<suranga> pulasthi7, what are you working on at the moment ?
|
16:28:54
|
<pulasthi7> suranga, i was having a look at the comments on the task 3 schema.
|
16:29:22
|
<suranga> pulasthi7, umm.. task 3 schema ? afraid that I didnt get you there ...
|
16:29:35
|
<pulasthi7> suranga, and i was planning to prepare the presentation today.
|
16:29:48
|
<suranga> pulasthi7, nice. I was about to remind you about that
|
16:30:02
|
<suranga> pulasthi7, we DONT want to mess up on presentation day
|
16:30:39
|
<suranga> pulasthi7, based on our last attempt, we have a pretty good idea of what things may go wrong, so lets try to avoid them :)
|
16:32:01
|
<pulasthi7> suranga, yes. I think the presentation can be prepared before hand and uploaded. isn't it?
|
16:32:30
|
<suranga> pulasthi7, hmm.... did you get an email from Michael on that ? Im not very sure...
|
16:32:46
|
<pulasthi7> suranga, and the network connection at wso2 is not bad. :-)
|
16:33:04
|
*** lh has joined #openmrs
|
16:33:04
|
*** lh has joined #openmrs
|
16:33:15
|
<suranga> pulasthi7, you being at wso2 reduces my worries by about 50% :P
|
16:33:21
|
*** rafa has joined #openmrs
|
16:33:21
|
*** ChanServ sets mode: +v rafa
|
16:33:30
|
<suranga> pulasthi7, its a lucky thing we can use their net
|
16:34:01
|
*** diptanuc has quit IRC
|
16:36:27
|
*** cpower has quit IRC
|
16:36:56
|
<suranga> pulasthi7, so my inbox says that the 10 minutes alloted to you includes time for Q and A too
|
16:37:05
|
<deepaganu> Hi All
|
16:37:24
|
*** cpower has joined #openmrs
|
16:37:24
|
<pulasthi7> suranga, hope the presentations will last more than 1.5 hours. in that case it might cause a problem.
|
16:37:45
|
<pulasthi7> suranga, yes that's what i also got.
|
16:38:16
|
<suranga> pulasthi7, do you mean hope that the presentations WONT* last for more than 1.5 hours ? :)
|
16:39:08
|
<suranga> pulasthi7, I see that you;re fifth on the list of speakers
|
16:39:18
|
<deepaganu> hi all , i want to to include third party jars in my project and i have manually added them in local maven repository
|
16:39:31
|
<pulasthi7> suranga, the people close the place at about 9-9.30
|
16:39:48
|
<deepaganu> but still when i run the pom.xml , i am getting this error http://pastebin.com/4jkC7Z1T
|
16:41:01
|
<suranga> pulasthi7, if you're fifth on the list , that means you should be done by... 7.30 pm + 10 * 5 = 8.20 or so (hopefuly)
|
16:41:04
|
<pulasthi7> suranga, for some days it's open all day. as i'm early in the list it won't be a problem for me. but i will miss few of the last presentations
|
16:41:10
|
<deepaganu> bwolfe , can you suggest something
|
16:41:18
|
<suranga> pulasthi7, we try to be very puntual, so I dont think you have to worry too much...
|
16:42:17
|
<bwolfe> deepaganu, what does your pom look like?
|
16:42:41
|
<deepaganu> i only added this <repository>
|
16:42:42
|
<deepaganu> <id>openmrs-ccd-repo</id>
|
16:42:42
|
<deepaganu> <url>file://C:/Users/ABHISHEK/Downloads/org.openhealthtools.mdht.uml.cda.runtime.I20110912-I201109121753/runtime</url>
|
16:42:42
|
<deepaganu> </repository>
|
16:42:52
|
*** mseaton has joined #openmrs
|
16:42:52
|
*** ChanServ sets mode: +v mseaton
|
16:43:46
|
<bwolfe> deepaganu, I don't know what that will do. did you add to the "dependency" section?
|
16:44:08
|
<suranga> deepaganu, try something like : <dependency>
|
16:44:09
|
<suranga> <groupId>sample.ProjectD</groupId>
|
16:44:09
|
<suranga> <artifactId>ProjectD</artifactId>
|
16:44:09
|
<suranga> <version>1.0-SNAPSHOT</version>
|
16:44:09
|
<suranga> <optional>true</optional>
|
16:44:09
|
<suranga> </dependency>
|
16:44:10
|
<deepaganu> no i didnt add anything in the dependency section
|
16:44:17
|
<bwolfe> deepaganu, you don't need to add a repository. add to the dependency, then follow instructions in the mvn error message on how to install to your local repository
|
16:44:34
|
*** harshadura has quit IRC
|
16:44:38
|
<deepaganu> what should i add in the dependncy
|
16:46:12
|
<bwolfe> deepaganu, is the jar you're using mavenized?
|
16:46:20
|
<deepaganu> no
|
16:46:25
|
<deepaganu> i dont think so
|
16:46:30
|
<deepaganu> bwolfe,
|
16:47:32
|
<deepaganu> the thing is , we have a UML model and using the eclipse EMF the jars were created
|
16:47:45
|
<deepaganu> bw
|
16:47:48
|
<deepaganu> bwolfe,
|
16:48:15
|
<deepaganu> the jars are not mavenized
|
16:48:49
|
<bwolfe> deepaganu, ok, I don't know how you put it in the dependencies then. google might know.
|
16:49:16
|
<deepaganu> ok i will google it bwolfe
|
16:49:53
|
<deepaganu> how do you convert a jar a mavenised jar
|
16:55:07
|
<deepaganu> bwolfe, can i use build.xml instead of using pom.xml
|
16:55:44
|
<bwolfe> deepaganu, build.xml uses ant. so if your module could build using that, then yes
|
16:55:56
|
<deepaganu> ok
|
16:56:06
|
<deepaganu> i would try using build.xml
|
16:56:21
|
<deepaganu> coz i am using dependecy tag but it is not working
|
16:57:01
|
*** mseaton has left #openmrs
|
16:58:17
|
<bwolfe> deepaganu, you can install the jar locally to your maven repo. when you do, you can make up your own group id and artifact id. you use those in your dependency
|
16:58:18
|
<bwolfe> http://www.mkyong.com/maven/how-to-include-library-manully-into-maven-local-repository/
|
16:58:18
|
<OpenMRSBot> <http://ln-s.net/$KN:> (at www.mkyong.com)
|
16:58:47
|
<bwolfe> deepaganu, or, if you just put it in as a dependency, then maven's error message will include the exact cal you make to instlal to your local repo
|
16:58:54
|
<deepaganu> i have used the above link to install the jar locally in the maven repo
|
17:02:56
|
<deepaganu> my pom.xml http://pastebin.com/index/V3JTMFTt bwolfe
|
17:04:05
|
<bwolfe> ok, and whats your error?
|
17:04:19
|
<bwolfe> artifactId is usually just one word
|
17:05:11
|
*** snoppy has quit IRC
|
17:05:22
|
*** lakkarau has joined #openmrs
|
17:06:15
|
<sgithens> djazayeri: We need to run htmlform entry tests against 1.6, 1.7, 1.8, 1.9, and default (master/trunk) profiles correct?
|
17:06:41
|
<deepaganu> i am getting this error http://pastebin.com/4jkC7Z1T
|
17:08:37
|
<bwolfe> sgithens, it doesn't run correctly against all yet.
|
17:08:59
|
<bwolfe> sgithens, but before you submit patches, devs are only expected to run against the default with "maven clean install"
|
17:09:26
|
*** pushkar has joined #openmrs
|
17:09:53
|
<sgithens> bwolfe: I had one of my html form entry tickets reopened because it's failing against the openmrs-1.9 profile. But Mark said it worked on 1.6 and 1.8. He'sa bout to roll a release, so I think he's running hte full gamut
|
17:10:42
|
<bwolfe> sgithens, there is only test failing against 1.9 right now, correct.
|
17:10:44
|
<bwolfe> sgithens, yes, makes sense
|
17:11:00
|
<sgithens> bwolfe, yeah it's from HTML-347
|
17:11:06
|
<sgithens> I'm looking at it now
|
17:11:24
|
<bwolfe> sgithens, yep. https://ci.openmrs.org/download/BUNDLED-HTML-LATEST/build_logs/BUNDLED-HTML-LATEST-38.log
|
17:11:45
|
<sgithens> bwolfe: What versions is it expected to not run against though?
|
17:11:50
|
*** lakkarau has quit IRC
|
17:11:51
|
<sgithens> It sounds like they all work
|
17:12:25
|
<bwolfe> sgithens, 1.7 fails. 1.8 passes. trunk passes
|
17:12:37
|
<sgithens> ah, 1.7 then...
|
17:12:39
|
<bwolfe> but 1.7 fails for some other unknown reason
|
17:12:40
|
<sgithens> wierd
|
17:12:44
|
<bwolfe> 1.9 it SHOULD pass though
|
17:12:51
|
<bwolfe> (1.7 has never worked)
|
17:13:01
|
<sgithens> (that's ominous)
|
17:13:20
|
*** lakkarau has joined #openmrs
|
17:13:42
|
<sgithens> Is it just HFE, or does 1.7 have other oddities with modules?
|
17:16:33
|
*** deepaganu has quit IRC
|
17:18:00
|
<bwolfe> sgithens, just HFE, AFAIK
|
17:18:36
|
<mvorobey> djazayeri, are you on a call ?
|
17:18:55
|
<djazayeri> mvorobey: yes
|
17:19:01
|
<mvorobey> djazayeri, sorry
|
17:20:59
|
*** every0ne has joined #openmrs
|
17:25:44
|
*** venkaban has joined #openmrs
|
17:27:09
|
*** cpower has quit IRC
|
17:30:43
|
*** venkaban_ has joined #openmrs
|
17:30:47
|
<venkaban_> bwolfe, Hi
|
17:30:59
|
<venkaban_> bwolfe, sorry I missed the scrum meeting today
|
17:31:28
|
<djazayeri> mvorobey: done with my call
|
17:31:29
|
*** mseaton1 has joined #openmrs
|
17:31:43
|
<venkaban_> bwolfe, currently I am working on HTML 357 and I am having some problem in executing the unit tests in different versions
|
17:32:32
|
<bwolfe> venkaban_, you are using the 19ext one, right?
|
17:32:51
|
<mvorobey> djazayeri, ok, I faced to some problems with reporting to be tested agains 1.9+ because of invalid javacode
|
17:32:51
|
*** cpower has joined #openmrs
|
17:33:04
|
<bwolfe> venkaban_, and did you mean https://tickets.openmrs.org/browse/HTML-358 ?
|
17:33:15
|
<venkaban_> HTML 357, bwolfe
|
17:33:45
|
<bwolfe> 357 is just running unit tests. 358 is about multiple versions
|
17:34:21
|
<mvorobey> djazayeri, actually, org.openmrs.module.reporting.cohort.query.db.hibernate.HibernateCohortQueryDAO.getPatientsHavingEncounters(Date, Date, TimeQualifier, List<Location>, List<Person>, List<EncounterType>, List<Form>, Integer, Integer, User, Date, Date) uses provider_id column for query which is missing in 1.9 model
|
17:34:36
|
*** venkaban has quit IRC
|
17:34:36
|
<mvorobey> djazayeri, what am supposed to do in this case ?
|
17:35:05
|
<djazayeri> mvorobey: hmmâ¦that's trickyâ¦is there a unit test that calls this?
|
17:35:30
|
<mvorobey> djazayeri, yes, there is one
|
17:36:31
|
<djazayeri> mvorobey: can you do a search in eclipse and see whether that DAO method gets called from many places?
|
17:36:49
|
<djazayeri> Or rather, whether the service method(s) which call it get called from many different cohort definitions?
|
17:37:09
|
<venkaban_> bwolfe, it is not the 19ext one I have tested?
|
17:37:43
|
<mvorobey> djazayeri, actually, that method is called only by corresponding service impl once
|
17:38:18
|
<djazayeri> mvorobey: okay, so how often is that service method called?
|
17:38:20
|
<bwolfe> venkaban_, is that a question?
|
17:38:26
|
<mvorobey> djazayeri, org.openmrs.module.reporting.cohort.definition.evaluator.EncounterCohortDefinitionEvaluator.evaluate(CohortDefinition, EvaluationContext)
|
17:38:28
|
<venkaban_> bwolfe, sorry no
|
17:38:36
|
<mvorobey> djazayeri, only this one call
|
17:38:45
|
<venkaban_> bwolfe, one sec lemme check
|
17:39:17
|
*** cpower has quit IRC
|
17:39:43
|
<djazayeri> mvorobey: to take a step back, what is the actual task you're working on now? I.e. this is a legitimately failing unit test, because reporting doesn't fully work in OpenMRS 1.9.
|
17:40:23
|
<djazayeri> mvorobey: so, if your current task is to mavenize, and set up multiple version testing, it's okay to just say "they don't all pass"
|
17:40:32
|
<djazayeri> mvorobey: if the task is to fix that, we need to get mike seaton in the conversation
|
17:40:47
|
<mvorobey> djazayeri, no, I do not need to fix it
|
17:40:54
|
<sgithens> If you actually use Eclipse to run the Junit tests for your project, can you use the debugger in the running tests?
|
17:41:22
|
<mvorobey> djazayeri, I can @Ignore that test and mention it in comment on ticket
|
17:41:22
|
*** docpaul has joined #openmrs
|
17:41:31
|
<djazayeri> mvorobey: I don't think you should @Ignore it.
|
17:41:31
|
*** ChanServ sets mode: +o docpaul
|
17:41:43
|
<docpaul> hola. :)
|
17:42:05
|
<djazayeri> mvorobey: I'd prefer that you just comment on the ticket that unit tests don't pass against 1.9.x or trunk
|
17:42:10
|
<suranga> hi docpaul !
|
17:42:33
|
<suranga> docpaul, its been a long time ! :)
|
17:43:11
|
<mvorobey> djazayeri, thanks, will be done!
|
17:44:20
|
<docpaul> is anyone involved with the feedback module on the channel?
|
17:44:28
|
<docpaul> ben, aren't you a backup mentor or something? :)
|
17:44:31
|
<docpaul> hey suranga!
|
17:45:28
|
<docpaul> i saw a youtube video for the feedback module, then it was made private. :)
|
17:45:33
|
<docpaul> i wanted to share it with someone else
|
17:45:33
|
<downey> Hi docpaul and welcome to the #openmrs IRC channel.
|
17:45:57
|
*** lakkarau has quit IRC
|
17:46:01
|
<docpaul> hah, is that automated? I created this channel. :)
|
17:46:01
|
<downey> docpaul: this one? http://www.youtube.com/watch?v=-o-tamGnsCE
|
17:46:17
|
<docpaul> heh, no there was another one:
|
17:46:33
|
<downey> Or maybe http://www.youtube.com/watch?v=LYs5aNuo3PU
|
17:46:49
|
<bwolfe> docpaul, I am, yes.
|
17:46:55
|
<docpaul> http://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=5&ved=0CFwQFjAE&url=http%3A%2F%2Fwww.youtube.com%2Fwatch%3Fv%3DmfEldTQoZ74&ei=r4foT636AYvU2QWykO3ZCQ&usg=AFQjCNHIMzIAjf5AadgBHz0PhAZlVRKbaA&sig2=PLSsqdYdKvomCefSm_CKKw\
|
17:46:57
|
<OpenMRSBot> <http://ln-s.net/$M+O> (at www.google.com)
|
17:47:19
|
<docpaul> sweet, that's the one michael
|
17:47:20
|
<docpaul> thanks!
|
17:47:59
|
<downey> sure thing
|
17:51:59
|
<docpaul> btw. the new work on the feedback module is awesome
|
17:53:28
|
*** applecool has joined #openmrs
|
17:53:28
|
*** ChanServ sets mode: +v applecool
|
17:55:34
|
<suranga> docpaul, unfortunately, the student who did that work is missing on IRC today. He would have been really really pleased to hear that :)
|
17:56:20
|
<docpaul> well, pass that feedback on. :)
|
17:56:35
|
<docpaul> where does the feedback "land" once it's done, btw? On local system?
|
17:56:47
|
<docpaul> it might be nice to trickle that up to core team as well
|
17:56:50
|
<bwolfe> local table on local system, yes
|
17:57:10
|
<bwolfe> there is a button for the admin when managing the local feedback to 'escalate to openmrs jira'
|
17:57:18
|
<docpaul> what happens then?
|
17:57:21
|
<docpaul> autogenerate ticket?
|
17:57:26
|
<bwolfe> I think so
|
17:57:34
|
<docpaul> dude, that's pretty nice.
|
17:57:39
|
<downey> -1 for naming the issue tracker by brand
|
17:57:40
|
<bwolfe> I'm not sure though, I haven't clicked it before. :-)
|
17:57:51
|
<bwolfe> downey, noted
|
17:58:17
|
<docpaul> looks like there's a live demo⦠let me go see
|
17:58:36
|
<docpaul> http://goo.gl/KjKuO
|
17:59:02
|
<applecool> rafa: ther?
|
18:00:50
|
<docpaul> looks like it's down
|
18:00:52
|
<docpaul> oh well
|
18:01:42
|
<docpaul> michael: we should take a look at hosting/getting an ubuntu apt-get repository
|
18:02:42
|
*** venkaban_ has quit IRC
|
18:02:53
|
<bwolfe> docpaul, downey, yes, a ppa kind of thing would be easier than getting into ubuntu repos
|
18:03:06
|
<bwolfe> (although standalone isn't that difficult either)
|
18:03:26
|
<docpaul> how does standalone work for ubuntu⦠is it nice?
|
18:03:32
|
*** venkaban has joined #openmrs
|
18:03:34
|
<docpaul> do you have to be in a GUI?
|
18:03:37
|
<downey> no
|
18:04:12
|
<docpaul> sudo apt-get openmrs
|
18:04:29
|
<bwolfe> *install openmrs
|
18:04:35
|
<docpaul> whoops
|
18:04:36
|
<docpaul> yep
|
18:04:41
|
<bwolfe> but yes, it would be that after also making one ppa install call
|
18:04:52
|
<docpaul> right
|
18:05:01
|
<docpaul> we'd have to specify another repo
|
18:05:14
|
<docpaul> unless we could get ubuntu to point to ours out of the box
|
18:05:43
|
<every0ne> bbl
|
18:05:46
|
<downey> it's cool, but still more painful than a wget / unzip
|
18:05:48
|
*** every0ne has quit IRC
|
18:05:56
|
<downey> also, there is no clear upgrade path for the standalone app
|
18:06:06
|
<docpaul> huh? painful to apt-get?
|
18:06:15
|
<docpaul> apt-get is the opposite of painful
|
18:06:18
|
<downey> adding the repo to sources list
|
18:08:07
|
<docpaul> looks like launchpad has it's own ppa stuff included ⦠2 gigs
|
18:09:35
|
<docpaul> didn't realize how simple it was to host something like that
|
18:10:37
|
<docpaul> http://askubuntu.com/questions/71510/how-do-i-create-a-ppa
|
18:10:40
|
<OpenMRSBot> <http://ln-s.net/$M-1> (at askubuntu.com)
|
18:10:50
|
*** r0bby has joined #openmrs
|
18:10:50
|
*** ChanServ sets mode: +v r0bby
|
18:12:05
|
<bwolfe> downey, everywhere I've see has one-line call to add to the ppa. then one line to install. yes, using gui to add sources is painful, but ppas were supposed to do away with that
|
18:12:18
|
<downey> again, the standalone can't be upgraded in its current state
|
18:12:47
|
<docpaul> right, but the ppa's provide a potent alternative approach to that that is upgradable
|
18:12:47
|
<bwolfe> downey, sure it can. drop the new war in and restart it
|
18:13:04
|
<downey> standalone != openmrs
|
18:13:29
|
<bwolfe> downey, who and which comment was that directed at?
|
18:13:34
|
<downey> you :P
|
18:13:55
|
*** robbyoconnor has quit IRC
|
18:14:38
|
<bwolfe> ok. I know that they are not equal. an unzipped standalone contains 3 folders. drop the openmrs.war file into tomcat/webapps and stop/start the "standalone". on startup the upgrade screen is shown just like everyone else.
|
18:15:04
|
<bwolfe> upgrading the openmrs within the standalone is the same as upgrading openmrs.
|
18:15:17
|
<bwolfe> upgrading the ACTUAL standalone (tomcat version and mysql version) is harder, but still doable
|
18:15:28
|
<downey> yes, and the standalone is what we distribute :)
|
18:15:42
|
<downey> openmrs is downstream from the standalone app
|
18:15:46
|
<bwolfe> we also distribute a war file.
|
18:16:07
|
<bwolfe> aren't there instructions telling people how ot update openmrs if they are using the standalone "distribution"
|
18:17:20
|
<downey> bwolfe: no
|
18:19:30
|
<docpaul> pretty soon OpenMRS will be so big, that we'll need a PPA equivalent for organizations to host their own "module repository"
|
18:19:31
|
<docpaul> hehe
|
18:21:14
|
<rfriedman> hehe yourself, docpaul
|
18:21:31
|
<docpaul> hi roger dodger
|
18:21:38
|
<rfriedman> now it's time to go through the mess of steaming code, and refactor it to half the size and twice the speed
|
18:22:57
|
<downey> rfriedman++ :)
|
18:23:54
|
<rfriedman> instead we go to git and get the same code in 8 times the space
|
18:24:22
|
*** james_regen has left #openmrs
|
18:24:51
|
<rfriedman> nice to see you docpaul, downey ... have a great day
|
18:24:58
|
<docpaul> likewise
|
18:25:02
|
<docpaul> have fun hacking roger
|
18:25:37
|
*** rfriedman has quit IRC
|
18:25:41
|
*** maurya has joined #openmrs
|
18:26:42
|
*** dkayiwa has joined #openmrs
|
18:27:52
|
*** downey has quit IRC
|
18:28:06
|
*** downey has joined #openmrs
|
18:28:06
|
*** OpenMRSBot sets mode: +o downey
|
18:28:06
|
*** ChanServ sets mode: +o downey
|
18:28:10
|
<bwolfe> downey, https://wiki.openmrs.org/display/docs/Upgrading+OpenMRS
|
18:28:11
|
<OpenMRSBot> <http://ln-s.net/9Gya> (at wiki.openmrs.org)
|
18:29:53
|
*** pulasthi7 has quit IRC
|
18:31:21
|
<downey> bwolfe: is there a reason the data files need to reside inside the application directory?
|
18:31:56
|
<bwolfe> downey, you mean database inside the unzipped standalone?
|
18:32:17
|
<downey> bwolfe: basically. peer to the standalone app dir rather than child
|
18:33:54
|
<bwolfe> we want one folder after unzipping. so whether its openmrs-->db/tomcat/modules or if its openmrs-->db/other-->tomcat/modules, wouldn't matter too much, would it?
|
18:33:58
|
<bwolfe> what would that gain us?
|
18:34:05
|
*** goutham has joined #openmrs
|
18:34:09
|
<bwolfe> (I'm not sure which problem you're trying to solve)
|
18:34:24
|
<downey> problem: upgrading the app requires futzing with the DB
|
18:34:33
|
<downey> solution: move the DB outside of the application path
|
18:35:40
|
<downey> essentially, honoring the intuitive meaning behind application_data_directory GP, perhaps
|
18:37:56
|
<bwolfe> location of db folder means nothing to openmrs. you could put that anywhere and just set some property so that mysql knows where to find it. (is that in the RP file? dkayiwa would know)
|
18:38:40
|
<wyclif> bwolfe, are the release testing tests run against an embedded server?
|
18:39:13
|
<bwolfe> downey, you would need futzing on upgrade either way. and telling someone to copy db from within old standalone seems easy to me.
|
18:39:24
|
<bwolfe> alternative is:
|
18:40:36
|
<bwolfe> 1) install/start new standalone. 2) at stanalone "3-button" install screen one of the startup options is "Upgrade of previous openmrs" 3) ask use for the file location of their previous standalone instance 4) the standalone copies over the db, and starts up for them
|
18:40:42
|
<bwolfe> wyclif, no, against a real db
|
18:40:43
|
<dkayiwa> bwolfe: downey correct it does not matter, you can point to whichever folder you want in the connection string with this param: &server.datadir=....
|
18:41:10
|
<downey> bwolfe: https://source.openmrs.org/browse/contrib/standalone/trunk/src/main/config/openmrs-standalone-runtime.properties?hb=true#to12
|
18:41:22
|
<wyclif> bwolfe, i meant application server
|
18:42:29
|
* downey pretends he's burke and points at atlassian's self-contained/standalone app upgrade process :)
|
18:43:11
|
<downey> step 1 is always ask the user where their external data directory lives (or will live, for new installs). then it reads the config incl. database config and runs any necessary upgrades to those data files and/or the db
|
18:43:55
|
<bwolfe> dkayiwa, is https://wiki.openmrs.org/display/docs/Upgrading+OpenMRS correct, or should that be the "database/data" folder instead of "database" folder? (does database contain the mysql bin files as well?)
|
18:43:56
|
<OpenMRSBot> <http://ln-s.net/9Gya> (at wiki.openmrs.org)
|
18:45:53
|
<dkayiwa> bwolfe: the database folder should contain the mysql bin. that is why we point to it in the connection string with: &server.basedir=database
|
18:48:24
|
<bwolfe> downey, but default to current directory? thats fine. although thats one more step in the process. so under the unzipped folder there would be: database (mysql bins), data, tomcat, .openmrs folder, runtime props file
|
18:51:57
|
<downey> bwolfe: s/.openmrs/appdata/
|
18:52:07
|
<bwolfe> ok
|
18:53:01
|
<downey> so my question is (a) why 2 separate directories for data (appdata & database) and (b) can't these live outside of the standalone application root, so you can simply drop in a replacement standalone independently of your data?
|
18:53:22
|
<downey> (and preserve your configuration/data)
|
18:59:53
|
<bwolfe> downey, moving db data from database/data to appdata/data would be easily doable. changing to have appdata outside everything else is also doable, but would require user input at setup like you described before, which makes "install" process more difficult
|
19:00:55
|
<downey> bwolfe: maybe, but we already have the setup screen. it could be a pre-populated ("suggested") default text field.
|
19:04:13
|
<bwolfe> yeah, but really, if it defaults to the same folder, its exactly how it is now. and most people will do that. and then they have the same "pain" when upgrading. (pain in quotes because its only copying one file)
|
19:04:32
|
<bwolfe> and if we default it to something else, then it takes away from the magic of the standalone being one folder. we lose the simplicity there
|
19:04:45
|
<bwolfe> its nice to have one unzipped folder that you can move anywhere and not have to worry about dependencies
|
19:04:50
|
<bwolfe> and to delete when you're done testing
|
19:05:05
|
<bwolfe> and you can unzip multiple of them and have multiple openmrs' running
|
19:05:24
|
<downey> bwolfe: implicit in that idea would be a default outside of the app path :)
|
19:05:43
|
<bwolfe> (I argue against that in my later points above)
|
19:06:09
|
<downey> renaming/moving the app wouldn't break any dependencies, the .properties would still be pointing to the full path to the data dir
|
19:06:45
|
*** kavuri has joined #openmrs
|
19:07:00
|
<bwolfe> downey, moving to another server would
|
19:07:14
|
<bwolfe> and unzipping/installing a second version of the standalone would create havoc
|
19:07:22
|
<downey> agreed
|
19:07:54
|
<kavuri> djazayeri: are the values dose, equivalent daily dose, units, frequency in 'drug_order' table the default values for a particular drug id (drug_inventory_id) ?
|
19:18:16
|
<kavuri> what is the difference between the tables 'drug' and 'drug_order' as both seem to have similar information (like dosage, units etc.)
|
19:24:19
|
*** lh has quit IRC
|
19:24:51
|
<rafa> dkayiwa: hi, what are files like: openmrs-modules/xforms/trunk/web/module/resources/formrunner/6B2D62A10FCFA545C1774EDCE359F8CB.cache.html ?
|
19:25:00
|
<rafa> dkayiwa: I see tons of them in xforms history
|
19:25:15
|
<djazayeri> kavuri: hi
|
19:25:26
|
<djazayeri> kavuri: drug is the metadata table that defines the formulary
|
19:25:31
|
<dkayiwa> rafa: those are gwt compiler output files
|
19:25:47
|
<djazayeri> kavuri: drug_order is *date*, it extends the order table, and it stores actual prescriptions on patients
|
19:26:10
|
<rafa> dkayiwa: are they needed in the repo?
|
19:26:18
|
<dkayiwa> rafa: yes
|
19:26:31
|
<rafa> dkayiwa: ok, thx
|
19:28:02
|
<kavuri> djazayeri: there is also a drug_ingredient table. I thought that would have the actual formula of the drug. Is it not?
|
19:28:30
|
*** suranga has quit IRC
|
19:28:47
|
<djazayeri> kavuri: drug_ingredient is used with combination drugs, to define what individual components are in drugs in the drug table.
|
19:28:49
|
*** lh has joined #openmrs
|
19:29:03
|
<djazayeri> kavuri: currently there is no place in the data model to define complex prescription templates
|
19:29:21
|
<djazayeri> kavuri: that is going to be "order sets"
|
19:29:38
|
<djazayeri> kavuri: mike seaton has done some work on this, and we'll be discussing it on a call in a few weeks
|
19:29:44
|
<venkaban> bwolfe, Hi
|
19:30:00
|
<kavuri> djazayeri: great, would that be in one of the univ calls or the design calls?
|
19:31:11
|
<djazayeri> kavuri: design calls. kiran should know about the timing of that call
|
19:31:16
|
<djazayeri> i.e. which week it will be
|
19:34:38
|
<bwolfe> hi venkaban
|
19:35:02
|
<venkaban> bwolfe, The repo location you mentioned for 19ext, i think I dint check out that branch
|
19:35:08
|
<kavuri> djazayeri: ok. Sometime back you mentioned that the drug chemical compound is part of the concept dictionary, and the product name is part of 'drug' table. But now you mentioned that the drug table also has the drug formula. Can you clarify this a bit?
|
19:35:13
|
<venkaban> bwolfe, This is for HTML 357
|
19:36:14
|
<venkaban> bwolfe, for 357 do I have to check out the code and perform unit testing on https://github.com/OpenMRS/openmrs-module-htmlformentry19ext?
|
19:36:19
|
<OpenMRSBot> <http://ln-s.net/$MAD> (at github.com)
|
19:36:23
|
<djazayeri> kavuri: drug table does not have the drug formula. The drug table is generally analogous to a clinic's drug *formulary*, i.e. the list of drugs that can be ordered.
|
19:36:28
|
<bwolfe> venkaban, yes
|
19:36:37
|
<venkaban> bwolfe, ok thanks
|
19:39:36
|
<kavuri> djazayeri: typically when a doctor prescribes drug's to a patient, he/she will also specify food intake instructions. Do you think it is a good idea to have a table to has some default food restrictions/intake's?
|
19:39:58
|
<djazayeri> kavuri: you mean things like "take this drug with food"?
|
19:40:18
|
<djazayeri> kavuri: this is one of the things that supposed to be handled by order sets, once those get implemented.
|
19:40:18
|
<kavuri> djazayeri: yes, like while taking this drug, do not take it along with milk
|
19:41:14
|
<kavuri> djazayeri: ok, will look forward for the order sets discussion
|
19:46:40
|
*** kavuri has quit IRC
|
19:49:48
|
*** downey has quit IRC
|
19:50:07
|
*** downey has joined #openmrs
|
19:50:07
|
*** ChanServ sets mode: +o downey
|
19:50:19
|
*** downey has left #openmrs
|
19:53:20
|
*** downey has joined #openmrs
|
19:53:20
|
*** OpenMRSBot sets mode: +o downey
|
19:53:20
|
*** ChanServ sets mode: +o downey
|
20:01:06
|
<mvorobey> bwolfe, committed reporting tests against multiple versions of openmrs
|
20:03:37
|
<bwolfe> mvorobey, all pass now?
|
20:04:38
|
<mvorobey> bwolfe, no, 1.8/1.9/trunks has failures
|
20:04:41
|
*** diptanuc has joined #openmrs
|
20:04:52
|
<diptanuc> bwolfe: Hi Ben, are you around?
|
20:04:58
|
<bwolfe> mvorobey, ok
|
20:05:05
|
<bwolfe> diptanuc, no. ;-)
|
20:05:09
|
<mvorobey> bwolfe, we need mseaton to look on them
|
20:05:13
|
<djazayeri> mvorobey: reporting does work with 1.8, so I'm surprised about those failures
|
20:05:28
|
<djazayeri> mvorobey: but probably the unit tests just need to be refactored
|
20:05:36
|
<bwolfe> djazayeri, mvorobey, but testing against it alongside 1.7/1.6 is the hard part.
|
20:05:45
|
<mvorobey> djazayeri, strangely, but failures for 1.8 and 1.9 are the same
|
20:05:57
|
<bwolfe> mvorobey, so you've committed to svn? now what about migrating to github?
|
20:06:10
|
<bwolfe> diptanuc, yes, you assigning that ticket to yourself is fine
|
20:06:25
|
<bwolfe> diptanuc, *tickets
|
20:06:37
|
<mvorobey> bwolfe, happily, but not quite yet, my connectivity is not reliable and limited
|
20:06:48
|
<diptanuc> bwolfe: Thanks Ben, one of the tickets is already fixed :-(
|
20:07:00
|
<diptanuc> #3330
|
20:07:00
|
<mvorobey> bwolfe, will do it tomorrow morning
|
20:07:06
|
<bwolfe> !ticket TRUNK-3330
|
20:07:07
|
<OpenMRSBot> bwolfe: [#TRUNK-3330] Unable to unretire a visit type - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3330
|
20:07:46
|
<bwolfe> diptanuc, ?? its "ready for work". did you put in the wrong id?
|
20:07:58
|
<bwolfe> mvorobey, oh right, you said that
|
20:08:10
|
<mvorobey> bwolfe, np
|
20:08:27
|
<diptanuc> bwolfe: Yeah looks like that. Oops. Sorry
|
20:09:31
|
<diptanuc> bwolfe: I am actually working on the tickets myself, so that i can make it quicker for the particents :)
|
20:14:38
|
*** venkaban has quit IRC
|
20:15:56
|
*** mvorobey has quit IRC
|
20:16:17
|
*** venkaban has joined #openmrs
|
20:16:45
|
<diptanuc> bwolfe: Alright, me and another colleague of mine have claimed all the four tickets. We might need a few more, so on that day we might claim a few more if all goes well!
|
20:17:09
|
<bwolfe> diptanuc, sounds good
|
20:17:23
|
<bwolfe> diptanuc, feel free to comment on those tickets as you figure things out to clarify for the devs coming after
|
20:19:10
|
*** maurya has quit IRC
|
20:19:57
|
<docpaul> diptanuc: ++
|
20:20:42
|
<diptanuc> docpaul: :)
|
20:20:57
|
<docpaul> diptanuc: are you doing this with your manchester team?
|
20:21:05
|
<docpaul> or am i confusing teams?
|
20:21:16
|
<bwolfe> !karma diptanuc
|
20:21:16
|
<OpenMRSBot> bwolfe: diptanuc has neutral karma.
|
20:21:22
|
<bwolfe> diptanuc++
|
20:21:25
|
<bwolfe> !karma diptanuc
|
20:21:25
|
<OpenMRSBot> bwolfe: Karma for "diptanuc" has been increased 1 time and decreased 0 times for a total karma of 1.
|
20:21:32
|
<docpaul> yes
|
20:21:35
|
<diptanuc> docpaul: Yes
|
20:22:01
|
<diptanuc> docpaul: We have 8 people who are coming for the first code jam. Its going to be internal.
|
20:22:13
|
<docpaul> diptanuc: before you know it, you'll have keen insight into what core team is working on every time you want to get your team together to jam
|
20:22:22
|
<diptanuc> docpaul: For the next one which is in July, i am inviting Manchester University CS students
|
20:22:48
|
<diptanuc> docpaul: And some folks from NHS and some folks from a hospital in Leeds to check out OpenMRS
|
20:22:53
|
<docpaul> diptanuc: will you all be able to commit to seeing tickets that you all check out through to code review, even if the jam timing isn't sufficient?
|
20:23:23
|
<docpaul> i think that is going to be a key aspect of working with jam volunteers
|
20:24:03
|
<diptanuc> docpaul: Yes, me and one of my colleagues are going to go through each of the tickets before we start the Jam, thats why we have just 4 tickets and 8 participents.
|
20:24:54
|
<diptanuc> Once we have 8 people comfortable with the codebase, we will have all of them work on new tickets for the next one so that we can support more people in the coming codejams
|
20:24:55
|
<docpaul> perfect⦠assume you and your colleague will also keep track of the tickets until they are closed (which will likely happen following your jams)
|
20:25:30
|
<diptanuc> docpaul: Yes. Thats why i didnt want to pick up more than we can finish on our own.
|
20:26:23
|
<docpaul> perfect
|
20:26:29
|
<docpaul> diptanuc++
|
20:26:36
|
<docpaul> thanks!!!
|
20:26:54
|
<docpaul> bwolfe: have the two merck developers integrated into this sprint?
|
20:27:05
|
<diptanuc> docpaul: Thanks to you and all the senior OpenMRS devs for helping us!
|
20:27:19
|
<bwolfe> docpaul, they've been integrated since hte last one. venkaban and lakkarau (although second isn't here)
|
20:27:32
|
<docpaul> diptanuc: helping you is fundamental to our long term success, so thank you
|
20:27:34
|
<downey> diptanuc++
|
20:27:45
|
<docpaul> we see a future in where all of the core development work is done by groups like yours
|
20:27:51
|
<docpaul> instead of internally hired devs
|
20:28:07
|
<docpaul> current devs = planners of future devs
|
20:28:15
|
*** maurya has joined #openmrs
|
20:35:33
|
*** applecool has quit IRC
|
20:36:16
|
<diptanuc> docpaul: I am little worried that we might not be able to answer to all the questions that folks from Clinics might ask us when we show OpenMRS to them. But i think it would still be good if they come and talk about the challenges they face in information management in health care. I think that would generate a lot of interest about the project among my colleagues.
|
20:36:32
|
<docpaul> sure
|
20:36:33
|
*** rfriedman has joined #openmrs
|
20:36:46
|
<docpaul> remember, openers is a platform for building something they need, not an out of the box experience
|
20:36:54
|
<goutham> hi dkayiwa
|
20:36:55
|
<docpaul> we presume that clinics all behave differently from the outset
|
20:37:05
|
<dkayiwa> hi goutham
|
20:37:11
|
<docpaul> heya daniel. :)
|
20:37:22
|
<dkayiwa> docpaul: hey :D
|
20:37:31
|
<goutham> how did your week end go?
|
20:37:45
|
<dkayiwa> goutham: was a nice one. and yours? :)
|
20:38:16
|
<goutham> dkayiwa: good :)
|
20:38:46
|
<diptanuc> docpaul: Yeah, i am thinking to show them the Flowsheet Module to explain how OpenMRS can be extended.
|
20:39:11
|
<diptanuc> docpaul: And also may be MoTeCH :-)
|
20:39:52
|
* downey wonders if it would be good to schedule periodic "clinical training days" for OpenMRS university so non-medical geeks can learn a bit
|
20:40:18
|
<dkayiwa> downey++ :)
|
20:40:23
|
<goutham> dkayiwa: i made the edit option working for a filter , AgeFormFilter and GenderFormFilter are also ready to go
|
20:40:29
|
<goutham> :)
|
20:40:36
|
<djazayeri> diptanuc: when are you doing these showings, btw?
|
20:40:37
|
<downey> dkayiwa: we just need to find some medical geeks to join us :D
|
20:40:56
|
<dkayiwa> downey: we can start with docpaul :)
|
20:41:17
|
<docpaul> :)
|
20:41:23
|
<dkayiwa> goutham: that is beautiful!!! Is it committed yet? :)
|
20:41:29
|
<diptanuc> djazayeri: 5th of July
|
20:41:31
|
<docpaul> if i can help with something, let me know
|
20:41:45
|
<goutham> dkayiwa: commited and prime for your testing :)
|
20:42:26
|
<djazayeri> diptanuc: by then there should be a good demo of another packaging of OpenMRS for clinics in Kenya.
|
20:42:30
|
<dkayiwa> goutham: perfect. let me go through it and will give you feedback by tomorrow morning :)
|
20:43:03
|
<goutham> dkayiwa: Kool and thanks :)
|
20:43:05
|
<djazayeri> diptanuc: if you watch http://openmrskenya.blogspot.com/ I'll post about that sometime this week.
|
20:43:21
|
<diptanuc> djazayeri: Oh cool! That would be very useful for us.
|
20:43:42
|
<docpaul> djazayeri: if you want to catch up about relatedness between cello and kenyadistro this week, i could talk tomorrow on way home
|
20:43:47
|
<dkayiwa> goutham: thanks too for the good work and keep it going! :)
|
20:44:02
|
<djazayeri> docpaul: you back in Indy?
|
20:44:04
|
<docpaul> just got back from kenya last night
|
20:44:08
|
<docpaul> yes
|
20:44:20
|
<djazayeri> docpaul: sure, sounds good.
|
20:45:59
|
*** lh has quit IRC
|
20:46:04
|
<djazayeri> docpaul: I'll add it to the calendar
|
20:46:19
|
<docpaul> yeah, just call me around 2pm your time
|
20:46:24
|
<docpaul> should be driving home
|
20:46:25
|
<goutham> dkayiwa: its all because of your teaching :) and i will make sure to keep it up B)
|
20:46:30
|
<djazayeri> rafa, dkayiwa: hey, did the TW Australia hack nighters ever contact you on IRC last week?
|
20:46:49
|
<docpaul> djazayeri: a little concerned about the small amount of guidance that steve w is getting in nairobi
|
20:47:03
|
<docpaul> clinical folks should have done the basic encounter forms for him
|
20:47:13
|
<dkayiwa> djazayeri: not sure of what their irc names are. :)
|
20:47:13
|
<docpaul> now he's getting all this feedback in the 11th hour
|
20:47:18
|
<docpaul> and doesn't know how to sort it
|
20:47:39
|
<djazayeri> docpaul: I generally agree...
|
20:47:41
|
<docpaul> he needs an initial and return encounter form ...
|
20:48:39
|
<djazayeri> docpaul: he's been discussing that with Patrick, but perhaps not to enough specificity
|
20:49:00
|
<docpaul> i gave him a trajectory to follow.. i hope he does so
|
20:49:09
|
<docpaul> because as you know, i've been through this a number of times personally
|
20:49:14
|
<dkayiwa> goutham: my teaching would not be enough without your input. Besides, i also learn somethings from you. :)
|
20:49:18
|
<docpaul> and i know the problems when you don't do things in a certain order
|
20:49:58
|
<docpaul> he has these registers to start with, but he needs to turn the registers into a collection of questions and answer sets
|
20:50:01
|
<goutham> dkayiwa: im happy to hear that :)
|
20:50:21
|
<djazayeri> docpaul: Indeed
|
20:50:33
|
<docpaul> for example: the tuberculosis screening needs to be exploded into the risk questionnaire (4 or 7 questions depending on the level of sophistication you want)
|
20:50:52
|
<docpaul> then those questions can be grouped into sub-forms
|
20:51:04
|
<rafa> djazayeri: no one I spoke with said to be TW
|
20:51:17
|
<docpaul> and then once that dictionary is done, people can work to infer the register view and the indicator definitiions
|
20:51:18
|
<djazayeri> rafa: did anyone mention australia? ;_0
|
20:51:27
|
<rafa> djazayeri: nope
|
20:51:42
|
<djazayeri> rafa: okay, hopefully this week they will ask questions
|
20:51:51
|
<djazayeri> apparently people are stuck getting their dev environments set up
|
20:52:07
|
<rafa> djazayeri: we could help with that too... :)
|
20:52:13
|
<djazayeri> rafa: exactly
|
20:52:17
|
<dkayiwa> :D
|
20:52:34
|
<docpaul> ok, have to run
|
20:52:34
|
<djazayeri> docpaul: yes, defining the actual clinical forms is important
|
20:52:42
|
*** lh has joined #openmrs
|
20:52:44
|
<djazayeri> docpaul: and yes, should be driven in kenya
|
20:52:46
|
<djazayeri> docpaul: ttyl
|
20:52:51
|
<docpaul> djazayeri: can you reiterate this to steve please?
|
20:52:54
|
<downey> hey lh :)
|
20:53:06
|
<docpaul> he should be able to get to a physical, paper printable form
|
20:53:16
|
<docpaul> that would be important to show to kenyan leadership IMO
|
20:54:06
|
<djazayeri> docpaul: I think that since you two spoke, he and Patrick have met about defining the forms like that
|
20:54:26
|
<docpaul> good⦠just please continue to reiterate that
|
20:54:28
|
<djazayeri> docpaul: but yes, I'll reiterate that
|
20:54:32
|
<docpaul> se ya
|
20:54:39
|
*** docpaul has quit IRC
|
20:54:41
|
<djazayeri> ciao
|
20:56:01
|
*** maurya has quit IRC
|
20:56:04
|
*** dkayiwa_ has joined #openmrs
|
20:56:52
|
*** dkayiwa has quit IRC
|
20:56:52
|
*** dkayiwa_ is now known as dkayiwa
|
20:57:08
|
*** lh has quit IRC
|
20:58:46
|
*** goutham has quit IRC
|
21:00:11
|
<bwolfe> downey, you chased off lh. :-(
|
21:00:21
|
<downey> bwolfe: that happens frequently
|
21:00:24
|
<dkayiwa> :D
|
21:00:46
|
<dkayiwa> downey: so you are a frequent chaser :)
|
21:01:40
|
<downey> hey now
|
21:03:46
|
*** dkayiwa_ has joined #openmrs
|
21:03:47
|
*** dkayiwa has quit IRC
|
21:03:47
|
*** dkayiwa_ is now known as dkayiwa
|
21:11:09
|
*** diptanuc has quit IRC
|
21:14:36
|
*** venkaban has quit IRC
|
21:15:31
|
*** wyclif has quit IRC
|
21:17:59
|
*** venkaban has joined #openmrs
|
21:21:24
|
*** pushkar has quit IRC
|
21:24:05
|
*** sgithens has quit IRC
|
21:29:00
|
<venkaban> bwolfe, Hi
|
21:31:48
|
*** dkayiwa has quit IRC
|
21:39:06
|
*** lakkarau has joined #openmrs
|
21:39:42
|
<lakkarau> bwolfe:hi
|
21:45:46
|
<lakkarau> bwolfe: i compared the files for the getConcept() and getCountOfConcepts() in the conceptServiceImpl class in the trunk with the once in the branches 1.8.x and 1.9.x.
|
21:46:07
|
<lakkarau> the trunk reflects the 1.9.x
|
21:47:58
|
*** rafa has quit IRC
|
21:50:08
|
*** downey has quit IRC
|
21:50:23
|
*** lakkarau has quit IRC
|
23:23:46
|
*** venkaban has quit IRC
|
23:41:41
|
*** rfriedman has quit IRC
|
23:42:04
|
*** rfriedman has joined #openmrs
|
23:42:39
|
*** jordank has quit IRC
|
23:49:54
|
*** deadpool has joined #openmrs
|