| 00:24:12 | *** mccallumg has quit IRC |
| 00:30:56 | *** lh has joined #openmrs |
| 00:30:56 | *** lh has joined #openmrs |
| 00:55:17 | *** bwolfe has joined #openmrs |
| 00:55:20 | *** ChanServ sets mode: +o bwolfe |
| 00:56:29 | <GDG> hi bwolfe. you asked "are you more on the coding of hl7 side or coding of java side?" |
| 00:57:33 | <GDG> well, I chair several HL7 committees (know several people at regenstrief), and am busy writing standards. But I also lead the eclipse open healthcare framwork project, for instance, and wrote reams of HL7 related code there. |
| 00:57:38 | <bwolfe> hi GDG |
| 00:57:56 | <bwolfe> ah, ok |
| 00:57:59 | <bwolfe> so a little of both? |
| 00:58:06 | <djazayeri> or a lot of both... |
| 00:58:16 | <bwolfe> true(r) |
| 00:58:29 | <bwolfe> GDG, are you on the developer's mailing list? are you following the thread that suranga started about hl7 output? |
| 00:58:50 | <GDG> no, I'm not |
| 00:58:54 | <GDG> guess I'll have to be |
| 00:59:59 | <bwolfe> GDG, you can follow in the google group if you want |
| 01:00:21 | <bwolfe> https://groups.google.com/a/openmrs.org/forum/#!forum/dev |
| 01:00:24 | <OpenMRSBot> <http://ln-s.net/$Kdi> (at groups.google.com) |
| 01:00:51 | <GDG> k ta |
| 01:04:07 | *** elliott_w has quit IRC |
| 01:24:42 | *** suranga has joined #openmrs |
| 01:24:42 | *** ChanServ sets mode: +v suranga |
| 01:38:37 | *** lh has quit IRC |
| 01:47:42 | *** lh has joined #openmrs |
| 01:47:42 | *** lh has joined #openmrs |
| 01:50:56 | *** elliott_w has joined #openmrs |
| 01:50:56 | *** ChanServ sets mode: +o elliott_w |
| 02:11:17 | *** r_friedman_away has quit IRC |
| 02:13:09 | <suranga> djazayeri, thanks for keeping the mail thread running |
| 02:13:28 | <djazayeri> suranga: I'm asking the questions because I'm curious. :-) |
| 02:13:29 | <suranga> djazayeri, im rather stuck with some jembi work right now, but will get back to writing a good response soon :) |
| 02:13:43 | <suranga> djazayeri, either way, it serves my cause :P |
| 02:23:34 | *** elliott_w has quit IRC |
| 02:28:14 | <GDG> how do I get openMRS to generate this restws sample? can you point in the general direction? |
| 02:29:00 | <bwolfe> GDG, https://wiki.openmrs.org/display/docs/Webservices.rest+Module |
| 02:29:01 | <OpenMRSBot> <http://ln-s.net/92SZ> (at wiki.openmrs.org) |
| 02:29:47 | <bwolfe> GDG, install that module. make http rest calls according to this page |
| 02:29:50 | <bwolfe> https://wiki.openmrs.org/display/docs/REST+Web+Services+API |
| 02:29:51 | <OpenMRSBot> <http://ln-s.net/8zTB> (at wiki.openmrs.org) |
| 02:30:19 | <bwolfe> although thats more of the "pull data" use case |
| 02:31:08 | <bwolfe> djazayeri, is there an easy API call to /send/ from restws? if, say, an hl7output module wanted to trigger something to be sent to mirth whenever a new patient was created? |
| 02:35:22 | *** elliott_w has joined #openmrs |
| 02:35:22 | *** ChanServ sets mode: +o elliott_w |
| 02:36:17 | *** lh has quit IRC |
| 02:47:52 | <GDG> thanks. I'll look |
| 02:51:04 | *** elliott_w has quit IRC |
| 02:55:52 | *** elliott_w has joined #openmrs |
| 02:55:52 | *** ChanServ sets mode: +o elliott_w |
| 03:06:39 | *** elliott_w has quit IRC |
| 03:43:15 | *** robbyoconnor has joined #openmrs |
| 03:43:15 | *** ChanServ sets mode: +v robbyoconnor |
| 03:53:44 | <djazayeri> bwolfe: we want to *send* a resource? |
| 03:54:32 | <djazayeri> I guess it's straightforwardâbasically get back the SimpleObject version of the resource, and then manually use jackson to convert it to json (which is what spring is doing anyway) |
| 03:54:46 | <bwolfe> djazayeri, yes, if we wanted to get data to a mirth box for it send somewhere |
| 03:55:13 | <djazayeri> surely one could write a module that requires webservices.rest and eventbus, and does this |
| 03:55:21 | <djazayeri> it should require very little code |
| 03:56:54 | <bwolfe> yes, but not already written in restws per se |
| 03:56:56 | <bwolfe> and its just "event" module (at your suggestion). :-) |
| 03:57:14 | <djazayeri> I realized that after I sent it. :-) |
| 03:57:56 | <djazayeri> anyway, no it's not written yet, but it seems like it'd be less than 100 lines of code |
| 03:58:07 | <bwolfe> GDG, if you want to look into using restws to send json to mirth, there is a pathway |
| 04:21:09 | *** bwolfe has quit IRC |
| 04:33:58 | *** deepaganu has joined #openmrs |
| 04:43:43 | *** lakkarau has joined #openmrs |
| 05:00:30 | *** lakkarau has quit IRC |
| 05:06:14 | *** lakkarau has joined #openmrs |
| 05:32:25 | *** applecool has joined #openmrs |
| 05:32:25 | *** ChanServ sets mode: +v applecool |
| 05:55:44 | *** applecool has quit IRC |
| 06:41:32 | *** dkayiwa has joined #openmrs |
| 07:22:23 | *** goutham has joined #openmrs |
| 07:22:33 | <goutham> dkayiwa: Good morining :) |
| 07:22:43 | <dkayiwa> goutham: good morning :) |
| 07:23:31 | <goutham> dkayiwa: i have committed code against worked on goals. You can test the functioanlity :) |
| 07:23:43 | <dkayiwa> goutham: ok thanks :) |
| 07:23:59 | <goutham> dkayiwa: Had breakfast? |
| 07:24:14 | <dkayiwa> goutham: about to :) |
| 07:24:17 | <dkayiwa> and you? |
| 07:25:19 | <goutham> dkayiwa: Ya had ....its " Upma " our Andhra Pradesh state special break fast :) |
| 07:25:30 | <dkayiwa> goutham: :D |
| 07:25:53 | <goutham> dkayiwa: :) |
| 07:26:48 | <goutham> dkayiwa: whats your place special break fast ? |
| 07:30:45 | <dkayiwa> goutham: mago juice, rice, beans, and eggs :) |
| 07:34:08 | <goutham> dkayiwa: so whats going to be on ur plate today :) |
| 07:34:38 | <dkayiwa> goutham: i have no idea yet :) |
| 07:36:47 | <goutham> dkayiwa: : ) |
| 07:37:19 | <goutham> dkayiwa: its lunch time for me..Will have and come :) |
| 07:40:07 | *** applecool has joined #openmrs |
| 07:40:07 | *** ChanServ sets mode: +v applecool |
| 07:41:02 | <dkayiwa> goutham: ok :) |
| 07:45:02 | *** deepaganu has quit IRC |
| 08:00:53 | *** applecool has quit IRC |
| 08:08:30 | *** suranga has quit IRC |
| 08:09:03 | *** dkayiwa has quit IRC |
| 08:13:02 | *** harshadura has joined #openmrs |
| 08:16:57 | *** rafa_ has joined #openmrs |
| 08:16:57 | *** ChanServ sets mode: +v rafa_ |
| 08:20:54 | *** lakkarau has quit IRC |
| 08:25:25 | *** lakkarau has joined #openmrs |
| 08:42:22 | *** lakkarau has quit IRC |
| 08:48:36 | *** lakkarau has joined #openmrs |
| 08:57:30 | *** lakkarau has quit IRC |
| 09:01:30 | *** lakkarau has joined #openmrs |
| 09:07:30 | *** lakkarau has quit IRC |
| 09:07:57 | *** lakkarau has joined #openmrs |
| 09:12:30 | *** lakkarau has quit IRC |
| 09:13:07 | *** lakkarau has joined #openmrs |
| 09:17:30 | *** lakkarau has quit IRC |
| 09:17:47 | *** lakkarau has joined #openmrs |
| 09:41:02 | *** upul` has joined #openmrs |
| 09:41:02 | *** ChanServ sets mode: +v upul` |
| 10:03:54 | *** lakkarau has quit IRC |
| 10:06:52 | *** lakkarau has joined #openmrs |
| 10:10:43 | *** snoppy has joined #openmrs |
| 10:41:12 | *** applecool has joined #openmrs |
| 10:41:12 | *** ChanServ sets mode: +v applecool |
| 10:41:21 | <applecool> hi rafa_ |
| 10:41:31 | <rafa_> applecool: hi |
| 10:41:36 | *** rafa_ is now known as rafa |
| 10:41:59 | <rafa> applecool: how is the recovery? :) |
| 10:42:06 | <applecool> its done! |
| 10:42:11 | <applecool> it was a great pain |
| 10:42:30 | <applecool> i configured the eclipse and mysql maven and all the other stuff |
| 10:42:47 | <applecool> rafa: my apologies |
| 10:42:56 | *** upul` has quit IRC |
| 10:43:01 | <rafa> applecool: no need to apologize |
| 10:43:03 | <applecool> i have a lot of pending work to do now! rafa |
| 10:43:08 | <rafa> applecool: it happens |
| 10:43:40 | <applecool> rafa: we discussed about it just day before and it happend! damn! :| |
| 10:43:56 | <applecool> rafa: now everything is working like as before :) |
| 10:44:03 | <rafa> applecool: good |
| 10:44:28 | <rafa> applecool: so remind me, are the tasks from the last week completed? |
| 10:44:34 | <applecool> i need to first put an end to the last weeks last tasks |
| 10:44:42 | <rafa> applecool: ohh okay |
| 10:44:46 | <applecool> no rafa not completed |
| 10:44:58 | <applecool> rafa: i have some doubts! can i go on? |
| 10:45:03 | <rafa> applecool: yes |
| 10:45:51 | <applecool> first one is we have the getter and the setter for the User in the MetadataPAckage and i got the foriegn key and everything is good! and i got the instance of the User too |
| 10:46:39 | <applecool> i need to set the Username on the package right? to display it on the mainPage while package listing |
| 10:47:17 | <rafa> applecool: you can call package.getUser().getUsername() right? |
| 10:47:24 | <rafa> applecool: why do you want to set it? |
| 10:47:54 | <applecool> but i am unable to call it rafa i tried it before! no fruitful results |
| 10:48:08 | <rafa> applecool: what do you get? |
| 10:48:39 | <applecool> just a sec! i will do it and tell you! i dont remember to be frank ! |
| 10:48:50 | <applecool> i guess i was getting the null pointer exception |
| 10:50:41 | <applecool> rafa: i actually didnt want to miss the scrum today as i missed it yesterday! |
| 10:50:59 | <applecool> i am commuting now! i am in bus :) using my netcard :P |
| 10:51:15 | <rafa> applecool: ohh |
| 10:51:28 | <rafa> applecool: we can talk later... |
| 10:51:52 | <rafa> applecool: I'll be online for the next 4 hours |
| 10:51:59 | <applecool> ah no problem! my home is still 3 miles away :) |
| 10:52:07 | <rafa> applecool: ok |
| 10:52:25 | <applecool> but i wil let you know when i will be getting down :) |
| 10:55:10 | *** venkaban has quit IRC |
| 10:55:50 | <applecool> rafa: i am getting the same error which led to deletion of file! |
| 10:56:00 | <applecool> which folder should be deletd exactly? |
| 10:56:29 | <rafa> applecool: I don't remember |
| 10:56:38 | <applecool> http://pastebin.com/ScBzei82 |
| 10:56:39 | <rafa> applecool: it was in the error message |
| 10:56:44 | <applecool> yes! |
| 10:57:06 | *** venksbsn has quit IRC |
| 10:57:24 | <applecool> just it worked fine! i am not understanding y that error mesage is coming! |
| 10:57:31 | <applecool> just now* |
| 10:58:13 | <rafa> applecool: have you simply tried again and it worked? |
| 10:58:23 | <applecool> no |
| 10:59:26 | <applecool> in the morning! it worked fine and now too ! but after i changed the file and ran it! it started giving me this error |
| 11:00:11 | <applecool> rafa: i will get you back in 20 minutes! i need to get out of the bus! :) will be back asap |
| 11:00:15 | <applecool> bye cya rafa |
| 11:00:21 | <rafa> applecool: ok cya |
| 11:04:53 | *** applecool has quit IRC |
| 11:05:23 | *** magoo_ has joined #openmrs |
| 11:07:27 | *** james_regen has joined #openmrs |
| 11:07:27 | *** ChanServ sets mode: +v james_regen |
| 11:22:36 | *** bwolfe has joined #openmrs |
| 11:22:36 | *** ChanServ sets mode: +o bwolfe |
| 11:32:31 | *** magoo_ has quit IRC |
| 11:38:36 | *** applecool has joined #openmrs |
| 11:38:36 | *** ChanServ sets mode: +v applecool |
| 11:38:41 | <applecool> hi rafa |
| 11:38:48 | <rafa> applecool: hi |
| 11:38:58 | <applecool> just came back home! |
| 11:38:59 | <rafa> applecool: any success? |
| 11:39:04 | <applecool> ah trying |
| 11:39:08 | <applecool> just a sec |
| 11:40:58 | <applecool> same error rafa |
| 11:41:14 | <rafa> applecool: have you tried googling it? |
| 11:41:16 | *** goutham has quit IRC |
| 11:41:39 | <applecool> i tried it but no luck |
| 11:42:04 | <rafa> applecool: do you run mvn clean install? |
| 11:42:09 | <applecool> yes |
| 11:43:35 | <rafa> applecool: code committed? |
| 11:43:48 | <applecool> you mean the previous? |
| 11:43:54 | <rafa> applecool: the current |
| 11:43:58 | <rafa> applecool: what you try to run |
| 11:44:06 | <rafa> applecool: I'll try it myself |
| 11:44:08 | <applecool> yes! till the search part everything is committed! |
| 11:44:24 | <applecool> and with your extra comments |
| 11:44:46 | <applecool> okay i will just comit the code again |
| 11:48:35 | <applecool> just now committed the code |
| 11:48:37 | <applecool> again |
| 11:48:49 | <applecool> i dont think there is nothin much in the commit |
| 11:49:01 | <applecool> i mean just the formatting and some small chages |
| 11:49:03 | <applecool> changes |
| 11:52:02 | *** GrahameG has joined #openmrs |
| 11:52:40 | <applecool> i think that .DStore is making some mess i guesS! |
| 11:53:01 | <applecool> do you think that makes any sense? |
| 11:53:03 | <rafa> applecool: what is dstore? |
| 11:53:26 | <applecool> its just a small binary file and it is actually a hidden file |
| 11:53:29 | *** GDG has quit IRC |
| 11:53:37 | <applecool> it generates for every folder and everywhere |
| 11:53:48 | <applecool> i mean it wil be everywhere |
| 11:54:16 | <applecool> actually .m2 and var folders are hidden in mac |
| 11:54:37 | <rafa> applecool: is it something you recently installed? |
| 11:54:47 | <rafa> applecool: why it stopped working right now? |
| 11:55:01 | <applecool> i dont know rafa i dint install anything new |
| 11:55:19 | <applecool> i will remove them and again i will import them and see |
| 11:55:36 | <applecool> is it working for you |
| 11:55:39 | <applecool> i guess it will be |
| 11:56:11 | <rafa> applecool: just pulled |
| 11:56:14 | <rafa> applecool: running right now |
| 11:56:19 | <applecool> day before even darius told me that such type of error was not seen before |
| 11:56:46 | <applecool> he meant our app is entirely seperate one |
| 11:57:20 | <rafa> applecool: testSave fails for me |
| 11:57:44 | <rafa> applecool: ohh I know wahy |
| 11:57:51 | <rafa> applecool: I need to set the upload path |
| 11:58:05 | <applecool> yes! just now i changed that line! just make it as it is! i mean pkg.setUser(uname); for now |
| 11:58:09 | <applecool> to make it pass |
| 12:01:57 | *** wyclif has quit IRC |
| 12:01:58 | <rafa> applecool: it works the container started |
| 12:02:11 | <rafa> applecool: can you run without skipping tests? |
| 12:02:21 | <applecool> no! |
| 12:02:26 | <applecool> i m importing them again |
| 12:02:39 | <rafa> applecool: what are you importing again? |
| 12:02:55 | <applecool> i mean i deleted the project from eclipse |
| 12:03:06 | <applecool> and i am again importing them and making it a fresh build |
| 12:03:13 | <rafa> applecool: ok |
| 12:06:27 | *** magoo_ has joined #openmrs |
| 12:07:51 | *** mvorobey has joined #openmrs |
| 12:07:55 | <mvorobey> hi all |
| 12:09:46 | <mvorobey> hi bwolfe |
| 12:09:59 | <bwolfe> hey |
| 12:10:31 | <mvorobey> bwolfe, ready to answer to couple of my questions ? :) |
| 12:11:04 | <bwolfe> no, let me prepare |
| 12:11:05 | <mvorobey> bwolfe, am testing against 1.9 and now there is only one error left on the way to get it worked |
| 12:11:12 | <mvorobey> bwolfe, :) |
| 12:11:17 | <bwolfe> ok, now I'm ready |
| 12:11:27 | <mvorobey> bwolfe, so, this is an error |
| 12:11:33 | <mvorobey> Caused by: org.h2.jdbc.JdbcSQLException: Column "E.PROVIDER_ID" not found; SQL statement: |
| 12:11:33 | <mvorobey> select e.patient_id from encounter e inner join patient p on e.patient_id = p.patient_id where e.voided = false and e.provider_id in (?) and p.voided = false group by e.patient_id [42122-135] |
| 12:12:10 | <mvorobey> bwolfe, it occurs when org.openmrs.module.reporting.cohort.definition.evaluator.EncounterCohortDefinitionEvaluatorTest.evaluate_shouldReturnCorrectPatientsWhenProviderParametersAreSet() is running |
| 12:12:46 | <mvorobey> bwolfe, and I'm not sure how to get rid of such error basically |
| 12:12:48 | <bwolfe> encounter.provider_id is new in 1.9. are you sure you're running against 1.9 with the right hbm files? |
| 12:13:03 | <bwolfe> mvorobey, the unit tests look for all hbm files and create the in memory h2 db from them |
| 12:13:15 | <bwolfe> so if its finding the wrong hbm files, it would be creating a wrong encounter table |
| 12:13:49 | <mvorobey> bwolfe, huh, am so un-attentive, sorry, for trouble |
| 12:14:15 | <bwolfe> find the issue already? |
| 12:14:38 | <mvorobey> bwolfe, in-progress |
| 12:17:06 | <mvorobey> bwolfe, do not know why it uses older hbm.xmls, may ne it actually do not ... |
| 12:17:21 | <applecool> rafa: not working :( :'( |
| 12:17:28 | <mvorobey> actually do not = actually does not |
| 12:17:35 | <rafa> applecool: delete .m2 directory |
| 12:17:45 | <rafa> applecool: run mvn clean install without skipTests |
| 12:17:56 | <applecool> .m2 ! |
| 12:18:06 | <applecool> okay |
| 12:18:13 | <rafa> applecool: maybe the zip got corrupted |
| 12:18:35 | <rafa> applecool: and it's still in the .m2 directory |
| 12:18:36 | <applecool> oh it always gets downloaded right with the clean build |
| 12:18:50 | <rafa> applecool: no, it's only downloaded once |
| 12:18:57 | <applecool> ok |
| 12:19:00 | <rafa> applecool: and it's stored in .m2 dict I think |
| 12:20:30 | <bwolfe> mvorobey, are you doing a clean each time? |
| 12:20:40 | <mvorobey> bwolfe, nope |
| 12:20:41 | <bwolfe> perhaps the hbms are getting copied into some build folder |
| 12:21:43 | <applecool> rafa: the entire .m2 folder? |
| 12:21:49 | <applecool> delete? |
| 12:22:15 | <rafa> applecool: hmmm do you have any download limits? |
| 12:22:24 | <applecool> meaning? |
| 12:22:29 | <applecool> the broadband stuff? |
| 12:22:46 | <rafa> applecool: do you have to pay for MBs? |
| 12:22:55 | <applecool> aah! na |
| 12:22:57 | <applecool> not much |
| 12:23:05 | <applecool> but the speed is not too high |
| 12:23:21 | <rafa> applecool: ok let me try to find which file to delete |
| 12:23:21 | *** magoo_ has quit IRC |
| 12:24:00 | *** kishoreyekkanti has joined #openmrs |
| 12:24:41 | <kishoreyekkanti> bwolfe: Hey ben you there? |
| 12:25:10 | <bwolfe> if you are offering gifts of money, then yes |
| 12:25:17 | <rafa> applecool: try deleting \.m2\repository\org\codehaus\ |
| 12:25:34 | <applecool> you mean codehaus folder |
| 12:25:37 | <applecool> right? |
| 12:25:37 | <rafa> yes |
| 12:28:10 | <bwolfe> mvorobey, and then there was one! |
| 12:28:41 | <bwolfe> kishoreyekkanti, you can send monetary gifts to my Grand Caymans offshore account #13247348u34981324 |
| 12:29:32 | <kishoreyekkanti> bwolfe: ha haa. Not sure where you are! Are you in Kenya? |
| 12:29:40 | <mvorobey> bwolfe, sorry, did not get |
| 12:30:02 | <bwolfe> back in the US for a long while now |
| 12:30:36 | <applecool> i deleted it! |
| 12:30:43 | <applecool> next |
| 12:30:44 | <bwolfe> mvorobey, Rita signed up on github. now we only have Lu remaining. |
| 12:30:50 | <applecool> building it right? rafa |
| 12:31:00 | <mvorobey> bwolfe, horray, party !!! |
| 12:31:42 | <rafa> applecool: right |
| 12:31:44 | <kishoreyekkanti> bwolfe: oh ok! |
| 12:31:54 | <applecool> ok rafa in process |
| 12:32:18 | <bwolfe> mvorobey, what would happen if you put his username in the authors file with his email, but then his email didn't have a github account on the other side? |
| 12:32:27 | <bwolfe> would github push fail? |
| 12:32:43 | <bwolfe> or would his account just be matched if/when he ever signed up on github? |
| 12:32:49 | <kishoreyekkanti> bwolfe: Fresh installation of OpenMRS was throwing some database update exception. So wanted to know if it is a known problem or if i |
| 12:33:04 | <kishoreyekkanti> bwolfe: I'm missing any thing. Any ways i've sent the mail to dev list |
| 12:33:11 | <bwolfe> I saw your mail |
| 12:33:15 | <bwolfe> trunk? |
| 12:33:21 | <kishoreyekkanti> bwolfe: yep |
| 12:33:27 | <mvorobey> bwolfe, dunno, may be something very sad, but it's not tested yet |
| 12:34:10 | <bwolfe> kishoreyekkanti, rafa just upgraded liquibase yesterday, perhaps this is an issue? |
| 12:34:20 | <bwolfe> in liq 2.0.5 that line is if (changeSet.getFilePath().equalsIgnoreCase(path) |
| 12:34:27 | <bwolfe> so our changesets might not all have a filepath? |
| 12:36:04 | <kishoreyekkanti> bwolfe: you mean we've bumped the liquibase version to 2.0.5 and the way we access the scripts is changed in the latest versions? |
| 12:37:00 | <kishoreyekkanti> bwolfe: Any ways i'm running for a meeting now. Will catch you back in some time |
| 12:37:34 | <bwolfe> kishoreyekkanti, a quick fix is to revert that latest change in the core pom.xml for the liquibase |
| 12:37:54 | <bwolfe> the better fix is for rafa to confirm and fix the NPE. :-) |
| 12:38:02 | <applecool> http://pastebin.com/FFG05X60 rafa |
| 12:38:58 | <rafa> bwolfe: yeah, I'll look into that, I'm about to test installation on postgresql |
| 12:39:07 | *** kishoreyekkanti_ has joined #openmrs |
| 12:39:58 | *** kishoreyekkanti has quit IRC |
| 12:40:16 | *** kishoreyekkanti has joined #openmrs |
| 12:41:07 | *** magoo_ has joined #openmrs |
| 12:41:12 | <applecool> rafa: i guess i should have deleted the apache-tomcat 6.0.29 in the installs folder too i guess |
| 12:46:31 | <rafa> applecool: I temoprarily disabled integration tests |
| 12:46:41 | <rafa> applecool: pull from github |
| 12:46:52 | <rafa> applecool: continue to work on your tasks |
| 12:47:03 | <applecool> oh! just a second rafa trying it once again! |
| 12:47:07 | <applecool> and then i will pull it |
| 12:47:13 | <applecool> okay i will start working |
| 12:47:26 | <applecool> what do you mean by the integration tests rafa? |
| 12:47:44 | <rafa> applecool: it's the integration tests that fail |
| 12:47:55 | <rafa> applecool: tomcat is started for the integration tests |
| 12:48:09 | <applecool> oh! okay :) |
| 12:48:37 | *** wyclif has joined #openmrs |
| 12:49:16 | <magoo_> hi +rafa |
| 12:49:26 | <rafa> hi magoo_ |
| 12:50:55 | <magoo_> +rafa i have some few questions to ask let me hope you not busy |
| 12:51:14 | <mvorobey> bwolfe, question |
| 12:51:45 | <mvorobey> bwolfe, I committed code yesterday, when it will be in jars within maven repo ? |
| 12:52:12 | *** harshadura has quit IRC |
| 12:52:46 | <mvorobey> bwolfe, and which versions of jar do I need to use, accordingly to commit, ain't it? |
| 12:53:20 | <magoo_> +rafa ever since i downgraded from jdk 1.7.x to jdk 1.6.x my apache tomcat keeps of failing it does not start |
| 12:53:53 | <bwolfe> mvorobey, let me rephrase for you: "you committed something to trunk yesterday. when will those changes be in the nightly builds of hte openmrs jars on nexus maven repo?" |
| 12:54:03 | <bwolfe> the answer is: after 1am EST |
| 12:54:28 | <bwolfe> so they should be there for trunk already. I don't think the other branches are building automatically yet. (I opened an ITSM ticket for it though) |
| 12:56:15 | <mvorobey> bwolfe, thanks, you are reading my mind |
| 12:56:42 | <mvorobey> of my mind |
| 12:56:43 | <mvorobey> :) |
| 12:57:12 | <bwolfe> mvorobey, I have added lu's name/email to the github authors list on the wiki. I vote you go ahead and push to github when you get a chance. if lu ever creates an account on github, it should merge/match, but I am not sure. I couldn't find anything abou tit |
| 12:57:32 | <bwolfe> mvorobey, but since he hasn't resonded in a week, I assume he either doesn't care or is out of touch for some reason |
| 12:58:57 | <applecool> rafa: http://pastebin.com/zznjGv9V |
| 12:59:02 | <applecool> build success :) |
| 12:59:29 | <applecool> i removed that apache zip too in the Tmp folder |
| 12:59:43 | <applecool> and then deleted the codehaus folder and builded it! |
| 12:59:48 | <applecool> it worked |
| 12:59:50 | <mvorobey> bwolfe, do I need to do conversion to GitHub ASAP or it can wait until I'll done with multiple version testing ? |
| 13:01:19 | *** dkayiwa has joined #openmrs |
| 13:02:24 | <bwolfe> mvorobey, it can wait |
| 13:02:38 | <applecool> rafa: will be back in an hour :) |
| 13:02:39 | <bwolfe> where are you commiting your multiple version stuff? |
| 13:03:02 | <bwolfe> it might be better to push to github then push/pullrequest your changes on github |
| 13:03:20 | *** applecool has quit IRC |
| 13:03:44 | <mvorobey> bwolfe, am in svn yet |
| 13:04:10 | <bwolfe> mvorobey, so you are commiting to a mavenized reporting in svn.openmrs.org? |
| 13:05:44 | <mvorobey> bwolfe, actually, am not committing yet, working locally, on my laptop |
| 13:06:09 | <bwolfe> ok, I'd hate for you to lose that, so make sure its committed somewhere befor eyou start messing with converting |
| 13:07:34 | <mvorobey> bwolfe, I committed it to my flash card, it is safe :) |
| 13:08:13 | <mvorobey> bwolfe, and do commit then, before messy converting |
| 13:08:45 | *** dkayiwa_ has joined #openmrs |
| 13:09:47 | *** dkayiwa has quit IRC |
| 13:09:48 | *** dkayiwa_ is now known as dkayiwa |
| 13:10:40 | <wyclif> hi djazayeri |
| 13:16:11 | <magoo_> +rafa??? |
| 13:18:11 | *** downey has joined #openmrs |
| 13:18:11 | *** ChanServ sets mode: +o downey |
| 13:18:11 | *** OpenMRSBot sets mode: +o downey |
| 13:22:13 | <dkayiwa> hi rafa |
| 13:22:46 | <rafa> hi dkayiwa |
| 13:23:25 | <dkayiwa> rafa: do you have any suggestions for the strange behavior am getting on: SXS-1 ? |
| 13:23:34 | <dkayiwa> rafa: the second last comment |
| 13:23:39 | <rafa> !ticket SXS-1 |
| 13:23:42 | <OpenMRSBot> rafa: [#SXS-1] Fix unit tests in serialization module - OpenMRS JIRA - https://tickets.openmrs.org/browse/SXS-1 |
| 13:24:39 | <rafa> dkayiwa: well what is the error? |
| 13:24:57 | <dkayiwa> rafa: problem is the assertion which fails |
| 13:25:02 | <rafa> dkayiwa: ohh ok |
| 13:26:07 | <downey> kishoreyekkanti: hey, i think your twitter account got compromised |
| 13:26:38 | <kishoreyekkanti> downey: Hey Yep. Just found it and revoked all the apps and changed my password :( |
| 13:26:42 | <kishoreyekkanti> downey: Sorry for the spam |
| 13:26:43 | <rafa> dkayiwa: seems like a problem with XStreamSerializer |
| 13:26:48 | <downey> kishoreyekkanti: it happens :) |
| 13:26:50 | <dkayiwa> rafa: ok |
| 13:26:51 | <rafa> dkayiwa: maybe it looks in a DB |
| 13:27:04 | <kishoreyekkanti> downey: let me know if you get any further messages! |
| 13:27:08 | <rafa> dkayiwa: can you put Context.flushSession() after cohort.getMemberIds().clear(); |
| 13:27:21 | <dkayiwa> rafa: ok let me try that. thanks! |
| 13:27:38 | <rafa> dkayiwa: maybe save first |
| 13:27:45 | <dkayiwa> rafa: ok |
| 13:27:50 | *** lakkarau has quit IRC |
| 13:29:32 | <rafa> dkayiwa: Hibernate typically stores original collection and dirty one |
| 13:29:42 | <dkayiwa> rafa: oh i see!!! |
| 13:29:51 | <rafa> dkayiwa: maybe XStreamSerializer serializes the original one |
| 13:29:58 | <dkayiwa> rafa: ok |
| 13:31:10 | *** mvorobey has quit IRC |
| 13:32:09 | <dkayiwa> rafa: thanks man!!! Only adding Context.flushSession(), even without saving, did the trick :) |
| 13:32:39 | <rafa> dkayiwa: yeah, but I think it acutally needs to be fixed in XStramSerializer :P |
| 13:32:53 | <dkayiwa> rafa: ok |
| 13:33:28 | <rafa> dkayiwa: in some CollectionConverter or something |
| 13:33:45 | <dkayiwa> rafa: ok. thanks for the pointer :) |
| 13:35:13 | <rafa> dkayiwa: HibernateCollectionConverter does: col.getStoredSnapshot() |
| 13:35:23 | <rafa> dkayiwa: it's wrong |
| 13:35:24 | <dkayiwa> rafa: oh i see!!! |
| 13:36:03 | *** pushkar has joined #openmrs |
| 13:36:16 | <rafa> dkayiwa: see how it's done in the MDS module :) |
| 13:36:17 | <pushkar> bwolfe, Hi |
| 13:36:36 | <dkayiwa> rafa: ok thanks for making my life easier! :) |
| 13:37:04 | <rafa> dkayiwa: happy to help :) |
| 13:37:28 | <dkayiwa> rafa: you do not know how long i had battled with it! :D |
| 13:38:30 | <rafa> dkayiwa: I had many battles with Hibernate too ;) |
| 13:38:51 | <dkayiwa> rafa: hahahaha . you battles saved mine :D |
| 13:48:18 | <dkayiwa> rafa: do you have an off the head name of the class i should check in the MDS module? :) |
| 13:48:54 | <rafa> dkayiwa: HibernatePersistentCollectionConverter? |
| 13:49:02 | <dkayiwa> rafa: ok thanks |
| 13:49:55 | <bwolfe> rafa++ |
| 13:50:15 | <dkayiwa> rafa++ :) |
| 13:50:38 | *** kishoreyekkanti_ has joined #openmrs |
| 13:51:14 | <rafa> ohh I scored today more than ever :D |
| 13:51:34 | *** kishoreyekkanti_ has quit IRC |
| 13:51:41 | *** lakkarau has joined #openmrs |
| 13:51:41 | *** magoo_ has quit IRC |
| 13:51:51 | *** kishoreyekkanti_ has joined #openmrs |
| 13:52:27 | *** kishoreyekkanti has quit IRC |
| 13:56:26 | *** sgithens has joined #openmrs |
| 13:57:45 | *** jriley has joined #openmrs |
| 14:04:29 | <bwolfe> scrum time, but no cpower... |
| 14:06:07 | <bwolfe> lets get started without him. |
| 14:06:13 | <bwolfe> !scrumon |
| 14:06:13 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster - you may begin when ready. |
| 14:06:55 | <bwolfe> today's order: dkayiwa, rafa, lakkarau, wyclif, bwolfe, djazayeri (and mvorobey if he shows up again) |
| 14:07:07 | <bwolfe> (and venkaban last if he shows up again as well) |
| 14:08:29 | <dkayiwa> Wasted the entire day in town working with my bank to correct problem where one was signing cheques on my behalf |
| 14:08:30 | <dkayiwa> Working on: Fix unit tests in serialization module - SXS-1 |
| 14:08:30 | <dkayiwa> No Blockers |
| 14:08:45 | <rafa> Today: |
| 14:08:45 | <rafa> Experimented with maven |
| 14:08:45 | <rafa> Reviewed TRUNK-3245 Limit concept mappings on concept drugs to concepts with Drug class |
| 14:08:45 | <rafa> In Progress TRUNK-3469 Incompatibility with postgresql -- data type double should be "double precision" for postgresql |
| 14:08:53 | <lakkarau> bwolfe:Thursday: |
| 14:08:54 | <lakkarau> -worked on the ticket-#trunk-3328. |
| 14:08:54 | <lakkarau> -refactored the code and find that still geting NPE. |
| 14:08:54 | <lakkarau> Today : |
| 14:08:54 | <lakkarau> -work on the ticket #trunk-3328. |
| 14:08:54 | <lakkarau> Monday: |
| 14:08:59 | <lakkarau> will check-in the code if the code works fine.. |
| 14:09:54 | <wyclif> Thursday: |
| 14:09:54 | <wyclif> dev call |
| 14:09:54 | <wyclif> REPORT-383 - On run / schedule report page, allow for expressions to be specified in addition to fixed values |
| 14:09:54 | <wyclif> Spent some time on REPORT-374, then mike commented he had covered it in another task - UI pages for creating and managing report processor configurations |
| 14:09:56 | <wyclif> GSoc project code review |
| 14:09:58 | <wyclif> Friday: |
| 14:10:00 | <wyclif> REPORT-399 - Support "groups of things" in UI that are not patient cohorts |
| 14:10:02 | <wyclif> Weekly gsoc chat with Dmitry |
| 14:10:04 | <wyclif> pick up a bug ticket |
| 14:10:06 | <wyclif> |
| 14:10:08 | <wyclif> Blockers: None |
| 14:11:18 | <bwolfe> Thursday |
| 14:11:18 | <bwolfe> reviewed rafal's role ticket |
| 14:11:18 | <bwolfe> get htmlformentry testing in ci |
| 14:11:18 | <bwolfe> dev call |
| 14:11:18 | <bwolfe> leaderhsip call |
| 14:11:19 | <bwolfe> review daniel's sprint tickets |
| 14:11:21 | <bwolfe> fixed HTML-362 for relationships |
| 14:11:23 | <bwolfe> fixed TRUNK-3473 concurrent trunk testing |
| 14:11:25 | <bwolfe> Friday |
| 14:11:27 | <bwolfe> emails |
| 14:11:29 | <bwolfe> review daniel's sxs code |
| 14:11:31 | <bwolfe> fix github authors |
| 14:11:33 | <bwolfe> fix htmlformentry compiling |
| 14:11:35 | <bwolfe> no blockers |
| 14:11:37 | <bwolfe> (I'm leaving after lunch today, so get your questions in early) |
| 14:11:47 | <bwolfe> djazayeri, you awake yet? |
| 14:13:05 | <bwolfe> guess not, lets scrum off |
| 14:13:13 | <bwolfe> !scrumoff |
| 14:13:13 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 14:13:19 | <bwolfe> discussion points: |
| 14:13:20 | <bwolfe> dkayiwa: get all your money back? :-( |
| 14:13:20 | <bwolfe> rafa: experimented with what in maven? |
| 14:13:20 | <bwolfe> lakkarau: perhaps you're over thinking your ticket, lets discuss the approach |
| 14:13:35 | <rafa> bwolfe: dependencies |
| 14:13:36 | <dkayiwa> bwolfe: fortunately the money was not mine :) |
| 14:13:36 | <bwolfe> lakkarau, are you home now? or are you working already? |
| 14:13:38 | <lakkarau> bwolfe:ok |
| 14:13:48 | <dkayiwa> bwolfe: i was just a signatory |
| 14:13:48 | <downey> bwolfe: http://mavenrepo.openmrs.org/nexus/content/repositories/snapshots/org/openmrs/openmrs/1.9.0-SNAPSHOT/ |
| 14:13:50 | <lakkarau> bwolfe:yes |
| 14:13:56 | <rafa> bwolfe: for the question you asked on the dev list |
| 14:13:56 | <bwolfe> downey++ |
| 14:14:31 | <lakkarau> bwolfe i am home and will be going to office . |
| 14:14:44 | <dkayiwa> bwolfe: and good enough i responded quickly enough when the first cheque had just been cashed :) |
| 14:15:14 | <bwolfe> lakkarau, ok, ping me as soon as you get in? 1 hour? |
| 14:15:36 | <lakkarau> bwolfe:sure |
| 14:15:38 | <bwolfe> rafa, ok, I'm also looking into it, so no need to duplicate. you fix your NPE problem for now. ;-) |
| 14:15:49 | <jriley> bwolfe and djazayeri, Neal Lesh sends his regards. He told me about the Neal Reports. |
| 14:16:08 | <bwolfe> jriley, :-) |
| 14:16:14 | <rafa> bwolfe: yeah that was in the morning, now I'm working on NPE :) |
| 14:16:23 | <jriley> It was a cautionary tale about "temporary" code |
| 14:16:28 | <dkayiwa> rafa: your HibernatePersistentCollectionConverter fixed the unit test. am tempted to overwrite the entire HibernateCollectionConverter.marshal with yours. do you advise me to do that? |
| 14:16:37 | <bwolfe> nearlreports was intentionally named hackily so that we were sure to pull it out someday. its just that it took 4 years to do it. :-( |
| 14:18:27 | <rafa> dkayiwa: If it works then I don't see a reason why not to do it |
| 14:18:37 | *** pushkar has quit IRC |
| 14:18:39 | <bwolfe> downey, both 1.8.x and 1.9.x building nightly. :-) are you pushing the war to a server somewhere? |
| 14:18:42 | * bwolfe crosses fingers |
| 14:18:45 | <downey> bwolfe: not yet |
| 14:19:01 | <bwolfe> downey, you can probably skip 1.7.x, it might be a pain to push to nexus because its not mavenized |
| 14:19:15 | <downey> bwolfe: that's what i did |
| 14:19:42 | *** sgithens has quit IRC |
| 14:19:59 | <downey> bwolfe: i need to work out a new file structure for sourceforge first |
| 14:20:32 | <dkayiwa> rafa: ok |
| 14:30:55 | *** lakkarau_ has joined #openmrs |
| 14:30:56 | *** lakkarau has quit IRC |
| 14:31:40 | <wyclif> hi djazayeri |
| 14:34:59 | *** pushkar has joined #openmrs |
| 14:35:23 | *** sgithens has joined #openmrs |
| 14:35:48 | *** lakkarau_ has quit IRC |
| 14:36:46 | *** lh has joined #openmrs |
| 14:40:06 | <pushkar> bwolfe, Hi |
| 14:41:00 | <pushkar> other than the js variable are there any other java variable which provides the contextpath ? |
| 14:43:23 | <bwolfe> wyclif, fork. |
| 14:43:34 | <bwolfe> wyclif, the r is important. |
| 14:43:38 | <bwolfe> :-) |
| 14:43:57 | <bwolfe> pushkar, a java variable? sure, theres a WebConstants one |
| 14:44:11 | <bwolfe> WebConstants.WEBAPP_URL or something |
| 14:47:24 | <wyclif> bwolfe, i dont know why i type folk, i need to get the l off my keyboard and out of my head |
| 14:48:14 | *** harshadura has joined #openmrs |
| 14:49:00 | *** dkayiwa has quit IRC |
| 14:50:22 | *** venkaban has joined #openmrs |
| 14:50:34 | <venkaban> bwolfe, Hi |
| 14:50:44 | <venkaban> bwolfe, Sorry I missed today's Scrum |
| 14:50:54 | <venkaban> bwolfe, Here are my updates |
| 14:51:08 | <venkaban> bwolfe, completed HTML 357 and currently workig on 357 |
| 14:51:12 | <venkaban> No Blockers |
| 14:51:21 | *** dkayiwa has joined #openmrs |
| 14:53:23 | <bwolfe> !ticket TRUNK-357 |
| 14:53:24 | <OpenMRSBot> bwolfe: [#TRUNK-357] ajax search widget for adding a drug to regimen - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-357 |
| 14:53:33 | <bwolfe> venkaban, aren't those the same number you put in? |
| 14:53:41 | <bwolfe> oops |
| 14:53:45 | <bwolfe> !ticket HTML-357 |
| 14:53:46 | <OpenMRSBot> bwolfe: [#HTML-357] Verify unit tests are working in HTML Form Entry Extensions module after mavenization - OpenMRS JIRA - https://tickets.openmrs.org/browse/HTML-357 |
| 14:54:20 | <pushkar> bwolfe, theres a WEBAPP_NAME but it just provides the name of the webapp |
| 14:55:04 | <bwolfe> pushkar, right, so you do "/" + WEBAPP_NAME + "/moduleResources/drawing/..." |
| 14:55:54 | <pushkar> Oh yes Didnt think of that ! Thank you ben :-) |
| 14:56:56 | <dkayiwa> bwolfe: do you have an idea why serialization.stream bamboo fails yet all tests pass locally on my computer? |
| 14:58:53 | <bwolfe> dkayiwa, here are the full build logs |
| 14:58:53 | <bwolfe> https://ci.openmrs.org/download/BUNDLED-SXS-JOB1/build_logs/BUNDLED-SXS-JOB1-4.log |
| 14:58:58 | *** mvorobey has joined #openmrs |
| 14:59:06 | <bwolfe> build 22-Jun-2012 10:53:47 Running org.openmrs.module.xstream.TestUtil |
| 14:59:06 | <bwolfe> build 22-Jun-2012 10:53:47 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.004 sec <<< FAILURE! |
| 14:59:24 | <bwolfe> dkayiwa, its because the new TestUtil you put in there needs an @Ignore on it. |
| 14:59:33 | <dkayiwa> bwolfe: ok thanks :) |
| 14:59:35 | <bwolfe> junit sees its named "Test*" and tries to execute it as a junit test |
| 14:59:47 | <bwolfe> dkayiwa, if you run "mvn clean test" at command line you would probably get this same error |
| 14:59:56 | <dkayiwa> bwolfe: ok |
| 15:00:06 | <bwolfe> thats what ci runs, and thats probably what you should run on every project before committing |
| 15:00:14 | <dkayiwa> bwolfe: ok |
| 15:01:33 | <mvorobey> bwolfe, how about my prev question ? do you have any ideas on this ? (p.s.: I've cleaned project, tried from scratch but it did not help ... ) |
| 15:02:22 | <dkayiwa> bwolfe: surprisingly mvn clean test passes!!! |
| 15:02:44 | <mvorobey> dkayiwa, it is not possible :) |
| 15:02:55 | <dkayiwa> mvorobey: but it does :) |
| 15:03:02 | <mvorobey> :D |
| 15:03:50 | <mvorobey> dkayiwa, I've faced in the same issue in reporting, so I tried to do clean, ran test again, but nothing helped until I ignored the testutil class |
| 15:04:05 | <mvorobey> faced in = faced to |
| 15:04:19 | <dkayiwa> mvorobey: ok :) |
| 15:05:00 | <pushkar> The enter part of htmlformentry is done bwolfe ! |
| 15:09:11 | <bwolfe> pushkar, wow, awesome! so you can draw on an image and have it persisted when you save a form? |
| 15:09:55 | <pushkar> yes |
| 15:10:26 | <pushkar> I've not yet finished the view and edit part |
| 15:10:37 | *** kishoreyekkanti_ has quit IRC |
| 15:10:49 | <bwolfe> pushkar, but the hard part is done. :-) |
| 15:11:04 | <bwolfe> pushkar, you really need to talk to jibesh asap to make sure there is no duplicate there |
| 15:11:12 | <bwolfe> you might have something to help him with |
| 15:11:15 | <bwolfe> or he can help you |
| 15:11:40 | <pushkar> okay |
| 15:13:20 | <mvorobey> bwolfe, seems like provider_id colunmn is missing for encounter in 1.9.x but in used in org.openmrs.module.reporting.cohort.query.db.hibernate.HibernateCohortQueryDAO.getPatientsHavingEncounters(Date, Date, TimeQualifier, List<Location>, List<Person>, List<EncounterType>, List<Form>, Integer, Integer, User, Date, Date) |
| 15:13:29 | *** jriley has quit IRC |
| 15:14:39 | <bwolfe> mvorobey, oooo |
| 15:15:05 | <bwolfe> mvorobey, in 1.9 encounter.provider_id was removed in place of a many-to-1 table I think. sorry for leading you astray. :-( |
| 15:15:17 | <bwolfe> mvorobey, in 1.8 and below encounter.provider_id pointed to users.user_id |
| 15:16:00 | <mvorobey> bwolfe, so, what is a workaround to get that test working ? |
| 15:16:45 | <bwolfe> mvorobey, its just in the dbunit xml file, right? |
| 15:17:00 | <mvorobey> bwolfe, nope, javacode |
| 15:17:07 | <bwolfe> mvorobey, oh, hmm, |
| 15:17:34 | <mvorobey> bwolfe, here is that failing method - org.openmrs.module.reporting.cohort.definition.evaluator.EncounterCohortDefinitionEvaluatorTest.evaluate_shouldReturnAllPatientsWithEncountersIfAllArgumentsToCohortDefinitionAreEmpty() |
| 15:19:09 | *** harshadura has quit IRC |
| 15:20:10 | *** dkayiwa has left #openmrs |
| 15:20:24 | *** harshadura has joined #openmrs |
| 15:20:42 | <mvorobey> bwolfe, will be AFK for couple of hours will ping you later |
| 15:21:05 | <bwolfe> mvorobey, ok |
| 15:21:37 | <bwolfe> mvorobey, I'm not sure how to handle java compilation problems. |
| 15:21:55 | <bwolfe> mvorobey, you might have to get fancy with how the evaluators are defined (are they in xml files?) |
| 15:24:41 | *** mccallumg has joined #openmrs |
| 15:24:41 | *** ChanServ sets mode: +v mccallumg |
| 15:24:53 | *** mvorobey has quit IRC |
| 15:27:37 | *** mvorobey has joined #openmrs |
| 15:27:56 | <mvorobey> bwolfe, am back, will be available for 15 minute - 20 minutes while am far from the base station |
| 15:28:26 | <bwolfe> mvorobey, mmk, don't really get you |
| 15:28:33 | <bwolfe> mvorobey, ok |
| 15:28:33 | <bwolfe> mvorobey, I'm not sure how to handle java compilation problems. |
| 15:28:33 | <bwolfe> mvorobey, you might have to get fancy with how the evaluators are defined (are they in xml files?) |
| 15:29:26 | <mvorobey> bwolfe, am on way to home, using 3g modem, connectivity will be lost in 15 minutes |
| 15:29:31 | *** magoo_ has joined #openmrs |
| 15:29:41 | <mvorobey> bwolfe, bwolfe it's not a compilation problem |
| 15:29:57 | <mvorobey> bwolfe, it's sql query evaluation problem |
| 15:30:10 | <bwolfe> ok, so you need to get a diff sql query in there for 1.9+ |
| 15:30:26 | *** venkaban has quit IRC |
| 15:31:09 | <downey> bwolfe: https://sourceforge.net/projects/openmrs/files/nightly/2012-06-22/ |
| 15:31:14 | <OpenMRSBot> <http://ln-s.net/$Kw6> (at sourceforge.net) |
| 15:32:05 | <mvorobey> bwolfe, yeah, agreed, but how to do it if sql query is created dynamically using hibernate utils ? |
| 15:32:41 | <bwolfe> dynamically off of the db? or what? |
| 15:32:59 | <mvorobey> bwolfe, wait a minute, doing a paste |
| 15:34:05 | *** djazayeri has quit IRC |
| 15:35:27 | <mvorobey> bwolfe, here is a paste - http://pastebin.com/nZU3CiGU, see the line with comment // I THINK THAT THIS IS A SOURCE OF THE PAIN :) |
| 15:35:51 | *** magoo_ has quit IRC |
| 15:37:15 | <bwolfe> mvorobey, is that in code, or in a test? |
| 15:38:00 | <mvorobey> bwolfe, in code - org.openmrs.module.reporting.cohort.query.db.hibernate.HibernateCohortQueryDAO |
| 15:42:29 | <mvorobey> bwolfe, I'd change it not asking you if it would be in test |
| 15:43:10 | *** Jibesh has joined #openmrs |
| 15:44:49 | *** magoo_ has joined #openmrs |
| 15:46:41 | <pushkar> bwolfe, |
| 15:47:29 | <pushkar> rather than having a seprate drawing tag I think we should create a drawing widget which can be set to the existing obs tag |
| 15:47:49 | <pushkar> like <obs .... style='drawing'/> |
| 15:47:57 | <pushkar> what do you think ? |
| 15:49:08 | <wyclif> hi dj |
| 15:50:46 | <bwolfe> pushkar, if that is possible, yes. then you don't have to duplicate some of the attributes |
| 15:51:00 | <bwolfe> pushkar, only investigate that if there are some clear advantages |
| 15:51:13 | <bwolfe> otherwise its just cleanup for the sake of cleanup |
| 15:52:06 | <pushkar> obs tag provides all the ways for creating an obs |
| 15:54:49 | <pushkar> providing different tag for creating an observation (complexobservation) dosent look userfriendly to me |
| 15:55:45 | <pushkar> But I have to further investigate on the complexity of the above idea |
| 15:57:02 | <Jibesh> pushkar I second you on your idea |
| 15:57:29 | <Jibesh> I have implemented something similar to that |
| 15:57:56 | <pushkar> Jibesh, :-) |
| 16:04:08 | *** wyclif has quit IRC |
| 16:04:08 | *** wluyima has joined #openmrs |
| 16:06:04 | *** sthaiya has joined #openmrs |
| 16:06:16 | <downey> Hi sthaiya and welcome to the #openmrs IRC channel. |
| 16:06:32 | <sthaiya> :) Hi Downey |
| 16:07:10 | *** mvorobey has quit IRC |
| 16:07:45 | *** magoo_ has quit IRC |
| 16:09:45 | <pushkar> bwolfe, can I change the dependency of htmlformentry to 1.9 ? |
| 16:10:09 | <pushkar> *openmrs dependency |
| 16:12:12 | <sthaiya> is there script to mavenize a mercurial hosted module? |
| 16:20:32 | *** lakkarau has joined #openmrs |
| 16:26:14 | <sthaiya> rafa |
| 16:27:36 | *** applecool has joined #openmrs |
| 16:27:36 | *** ChanServ sets mode: +v applecool |
| 16:32:33 | *** elliott_w has joined #openmrs |
| 16:32:33 | *** ChanServ sets mode: +o elliott_w |
| 16:33:58 | *** mccallumg has quit IRC |
| 16:34:19 | *** mccallumg has joined #openmrs |
| 16:34:19 | *** ChanServ sets mode: +v mccallumg |
| 16:36:33 | *** kreddy has joined #openmrs |
| 16:37:07 | <bwolfe> pushkar, no, I don't think you should. that is up to mark goodrich to decide (he's the module owner) |
| 16:37:34 | *** wyclif has joined #openmrs |
| 16:38:07 | <bwolfe> sthaiya, if the layout is like our old modules, the mavenize script should work fine on it |
| 16:38:27 | <bwolfe> sthaiya, can you paste your stack trace and problem here? rafa might be away for now |
| 16:39:19 | <bwolfe> Jibesh, pushkar: but can a module modify an existing tag? how would the drawing module do its thing if it was an attribute? |
| 16:40:09 | *** sthaiya has quit IRC |
| 16:40:38 | *** sthaiya has joined #openmrs |
| 16:40:43 | *** venkaban has joined #openmrs |
| 16:41:30 | <pushkar> bwolfe, oops I just commited it ! |
| 16:41:49 | <bwolfe> committed to your fork of htmlformentry? |
| 16:42:03 | <Jibesh> bwolfe What I have implemented is <obs conceptId="6100">.....Now this concept id is of type complex ....On wrting this in Html form a custom widget will get rendered |
| 16:42:36 | <bwolfe> Jibesh, yeah, you are coding directly against htmlformentry though. pushkar's drawing element is in a module and won't be in htmlformentry core module |
| 16:42:54 | <Jibesh> Ok...got it |
| 16:45:30 | <sthaiya> bwolfe, just sorted out the issue with metadata module |
| 16:45:39 | <bwolfe> sthaiya, what was the problem? |
| 16:45:48 | <sthaiya> problem was due to form export import module |
| 16:46:07 | *** djazayeri has joined #openmrs |
| 16:46:07 | *** ChanServ sets mode: +o djazayeri |
| 16:46:10 | <sthaiya> there is a ticket for it |
| 16:47:25 | <bwolfe> sthaiya, problem with MDS or importexport? which one did you file the ticket in? |
| 16:47:56 | <pushkar> bwolfe, yes |
| 16:48:06 | <sthaiya> i did not file the ticket |
| 16:48:22 | <sthaiya> the ticket was already filed by Judy |
| 16:48:48 | *** jordank has joined #openmrs |
| 16:49:09 | <sthaiya> on MDS but rafa closed it and opened one under FIE module |
| 16:50:25 | <bwolfe> oh, sorry, misread you the first time sthaiya |
| 16:50:37 | <bwolfe> I would guess FIE won't be updated. its ooold |
| 16:50:49 | <bwolfe> so if you see the problem and/or can supply a patch, all hte better |
| 16:50:51 | <sthaiya> :) |
| 16:50:52 | <applecool> rafa: there? busy? |
| 16:52:37 | *** suranga has joined #openmrs |
| 16:52:37 | *** ChanServ sets mode: +v suranga |
| 16:53:40 | <bwolfe> lakkarau, at work yet? |
| 16:53:59 | <lakkarau> bwolfe:yes i am at work |
| 16:54:21 | <bwolfe> ok, ready to talk? I leave very soon. I was expecting you to ping me as soon as you got there... |
| 16:54:40 | <lakkarau> bwolfe:i am ready |
| 16:57:49 | <lakkarau> bwolfe: i added tht statement "new ConceptServiceImpl().getConcepts("trust", Collections.singletonList(Locale.ENGLISH), false, null, null, null,null, null, null, null);" for testing and it throws NPE after running. |
| 16:58:11 | <bwolfe> lakkarau, good, so now you have created the failing unit test. now you make that test NOT throw an error |
| 16:58:32 | <lakkarau> bwolfe: yes i am trying to do that |
| 16:58:33 | <bwolfe> lakkarau, just change ConcpetServiceImpl to assign an empty list to variable if a null one is passed in |
| 16:58:41 | *** suranga_ has joined #openmrs |
| 17:00:52 | <lakkarau> bwolfe:i can see that already that check is done for the datatypes and classees like----excludeDatatypes = new Vector<ConceptDatatype>(); |
| 17:01:27 | *** suranga has quit IRC |
| 17:02:09 | *** kishoreyekkanti has joined #openmrs |
| 17:02:28 | <bwolfe> lakkarau, ok...so copy that for the parameter mentioned in the ticket |
| 17:03:18 | *** pushkar has quit IRC |
| 17:06:08 | <lakkarau> bwolfe: means for datatypes and classes |
| 17:06:35 | *** kishoreyekkanti has quit IRC |
| 17:07:31 | <lakkarau> bwolfe: i did not understand the above statement |
| 17:07:37 | *** kishoreyekkanti has joined #openmrs |
| 17:07:51 | <bwolfe> lakkarau, which ticket? |
| 17:08:33 | <lakkarau> bwolfe:#Trunk-3328 |
| 17:09:49 | <suranga_> good morning james_regen |
| 17:10:01 | <suranga_> james_regen, any chance for a quick question or two today ?:) |
| 17:11:54 | <james_regen> suranga_: hi |
| 17:12:07 | <suranga_> james_regen, howdy ! |
| 17:12:22 | <bwolfe> lakkarau, hmm, yes, it seems to be doing what he wants already. perhaps he was using an earlier version that didn't have htat already? |
| 17:12:31 | <suranga_> james_regen, I was trying to test if the estimated number of pairs which pulasthi is calculating are correct or not |
| 17:13:13 | <bwolfe> 1) check the svn history of the files ConceptServiceImpl and/or HibernateConceptDAO to see if changes have been committed |
| 17:13:24 | <bwolfe> 2) check out the 1.9.x branch and the 1.8.x branch to see if you can get the test to fail |
| 17:13:31 | <bwolfe> 3) what line is the NPE on ? |
| 17:13:35 | <bwolfe> lakkarau ^^ |
| 17:14:18 | <lakkarau> bwolfe:bwolfe i think the NPE now i am getting is because of the last three parameters i have passed as nulls that is the Concept ,size and the Start. |
| 17:14:29 | <james_regen> suranga_: do you know how to do that? |
| 17:14:38 | <suranga_> james_regen, I have an idea |
| 17:14:44 | *** applecool has quit IRC |
| 17:14:46 | <bwolfe> lakkarau, if the javadoc says those are nullable, then thats a different problem to fix. (and needs it) |
| 17:14:55 | <suranga_> james_regen, its too detailed for IRC, im putting it into a email |
| 17:15:01 | <suranga_> james_regen, :) |
| 17:15:02 | <bwolfe> if the javadoc says they're required, then leave them as they are |
| 17:15:38 | <james_regen> suranga_: ok. i also have an idea that should fit on IRC, though i'm still curious what your idea is |
| 17:16:58 | <lakkarau> bwolfe: okay i will do the steps you gave. |
| 17:20:08 | *** mvorobey has joined #openmrs |
| 17:20:36 | *** applecool has joined #openmrs |
| 17:20:36 | *** ChanServ sets mode: +v applecool |
| 17:21:58 | *** djazayeri has quit IRC |
| 17:22:29 | *** bwolfe has quit IRC |
| 17:24:31 | *** kreddy has quit IRC |
| 17:24:59 | *** kreddy has joined #openmrs |
| 17:25:12 | <suranga_> james_regen, hi, just emailed you |
| 17:25:34 | <suranga_> james_regen, im also very open to your suggestion on how to test this :) |
| 17:27:33 | <james_regen> suranga_: when we run the process to create a strategy, there's a step where we analyze the data using EM to calculate some values for the fields. this analysis should be printed in the log file. one of the lines printed, for each block or strategy, si the number of pairs in the block |
| 17:28:51 | <suranga_> james_regen, um... you mean when we create a strategy, or a report :) |
| 17:29:29 | <james_regen> suranga_: oops, when we create a report |
| 17:29:59 | <suranga_> james_regen, um.. you mean that somewhere in the log output, this is being calculated already ? |
| 17:30:06 | <suranga_> james_regen, neat |
| 17:30:32 | *** rafa has quit IRC |
| 17:30:34 | <james_regen> suranga_: yeah, in catalina.out you shoould be able to search for "pairs processed" or something like that. i'd have to check to see what it is exactly |
| 17:31:35 | <james_regen> suranga_: looks like the line is "Total pairs processed:" |
| 17:32:00 | <suranga_> james_regen, I just found it :-) |
| 17:32:25 | <james_regen> suranga_: and some logging output of what the blocking columns were should be 10 or so lines above it, so you can match up the strategy to pair count |
| 17:32:57 | <james_regen> suranga_: how is the HQL performance? does the query take a long time to run? |
| 17:33:16 | <suranga_> james_regen, its on link.regenstrifef, you can check it out |
| 17:33:21 | <suranga_> james_regen, the timing is not tooo bad |
| 17:33:40 | <suranga_> but we may need to do something to tell the user to 'wait' until the calculation is done |
| 17:33:54 | <suranga_> james_regen, it takes about 10-15 seconds max, as I remeber |
| 17:34:20 | <james_regen> suranga_: that's not too bad considering creating the scratch database and creating the report could take hours |
| 17:34:44 | *** applecool has quit IRC |
| 17:34:47 | <suranga_> james_regen, I tried the report for a column that has only two matching values |
| 17:35:02 | <suranga_> james_regen, pretend out data is a,b,x,c,1,1 |
| 17:35:22 | <suranga_> james_regen, this (as expected) returns the number of estimated pairs as '1' |
| 17:35:48 | *** sthaiya has quit IRC |
| 17:35:50 | <suranga_> james_regen, BUT |
| 17:36:05 | <suranga_> james_regen, consider the column values A,A,A,B,B,B |
| 17:36:12 | <suranga_> james_regen, this seems to return 6 |
| 17:36:28 | *** djazayeri has joined #openmrs |
| 17:36:28 | *** ChanServ sets mode: +o djazayeri |
| 17:36:39 | <suranga_> james_regen, oh, thats correct, I see |
| 17:36:43 | <suranga_> james_regen, :) |
| 17:39:03 | *** venkaban_ has joined #openmrs |
| 17:40:03 | *** venkaban has quit IRC |
| 17:40:37 | *** applecool has joined #openmrs |
| 17:40:37 | *** ChanServ sets mode: +v applecool |
| 17:41:10 | <suranga_> james_regen, so the good news is that the values returnd from my test == your results |
| 17:41:25 | <suranga_> james_regen, the bad news is that they dont match pulasthi's |
| 17:41:53 | <suranga_> james_regen, pulasthi needs to divide his result by two to match ours :-) |
| 17:42:19 | <james_regen> suranga_: is there a clause in the HQL to add "where a.ID > b.ID" ? |
| 17:42:43 | *** harshadura has quit IRC |
| 17:42:44 | <james_regen> suranga_: that might be the problem. it might be counting pair {1,2} and {2,1} |
| 17:43:13 | <suranga_> james_regen, I think you are right (as usual :-) |
| 17:43:56 | <james_regen> suranga_: i remember talking about that a few weeks ago when we started this. compared to the work done, this is a pretty minor detail. i'm really impressed and glad that we're this close |
| 17:45:16 | <suranga_> james_regen, he he.. thanks. needless to say that if not for you, pulasthi and myself would have probably commited joint suicide by now :P |
| 17:46:42 | <suranga_> james_regen, and also, something I just noticed... |
| 17:46:58 | <suranga_> for patientmatching, identifiers can also be added as fields for matching |
| 17:47:14 | *** elliott_w has quit IRC |
| 17:47:20 | <suranga_> james_regen, but, since identifieirs are unique, then can never be duplicates, right ? |
| 17:47:49 | <suranga_> james_regen, therfore, every identifier should result in zero estimated pairs |
| 17:49:22 | <james_regen> suranga_: this probably gets into usage details of OpenMRS i'm not familiar with, since i don't really use it. identifiers are like attributes, right? extensible and user defined? i'm not sure what types of data is normally placed in there. i'm also not sure if the system enforcese uniquness for identifiers. if not, then it is likely that the quality of the data will degrade over time, and there will be duplicates |
| 17:51:21 | <suranga_> james_regen, not really, im afraid, OpenMRS identifiers dont allow duplicates :) |
| 17:51:51 | <suranga_> james_regen, if we try to create a duplicate identifier, it will give you an error :) |
| 17:52:44 | <james_regen> suranga_: that's good to know. it might be worth it to remove it from the module, then, since it won't be useful for matching in either type of field, and can be ignored when importing and when displaying the fields to the user. it'd make the page where the user selects fields smaller, at least |
| 17:53:05 | <suranga_> james_regen, ooops, I seee |
| 17:54:04 | <james_regen> suranga_: i'd email people asking if anyone sees a problem in doing this. |
| 17:54:20 | <suranga_> james_regen, aha.. mm... u mean to the dev list ? |
| 17:54:49 | <james_regen> i'd email the module people, judy, shaun, pulasthi |
| 17:55:00 | <james_regen> and ada |
| 17:55:05 | <suranga_> james_regen, cool, Iwill do that... |
| 18:02:23 | <snoppy> wyclif:hi, wyclif! |
| 18:02:25 | <wyclif> hi djazayeri |
| 18:02:28 | <wyclif> hi snoppy |
| 18:02:40 | <wyclif> snoppy, how old |
| 18:02:49 | <wyclif> snoppy, can you wait for about 20min |
| 18:03:03 | <snoppy> wyclif: yes, i can |
| 18:03:30 | <wyclif> snoppy, cool thanks |
| 18:03:54 | <snoppy> no problem) |
| 18:08:41 | *** lh has quit IRC |
| 18:11:45 | <djazayeri> wyclif: in a meeting |
| 18:11:56 | <wyclif> djazayeri, ok |
| 18:19:28 | *** maurya has joined #openmrs |
| 18:19:53 | *** ChanServ sets mode: +v maurya |
| 18:33:26 | *** Jibesh has quit IRC |
| 18:36:49 | *** applecool has quit IRC |
| 18:38:20 | *** applecool has joined #openmrs |
| 18:38:20 | *** ChanServ sets mode: +v applecool |
| 18:41:08 | <wyclif> hi snoppy |
| 18:41:28 | <snoppy> wyclif: hi |
| 18:41:51 | <wyclif> i think am ready snoppy |
| 18:42:30 | <snoppy> wyclif: ok, i'm waiting for you in skype |
| 18:43:06 | <snoppy> wyclif: or you want to speak in irc chat? |
| 18:52:08 | *** rafa has joined #openmrs |
| 18:52:08 | *** ChanServ sets mode: +v rafa |
| 18:55:58 | *** rafa has quit IRC |
| 19:00:08 | *** applecool has quit IRC |
| 19:04:21 | *** james_regen has quit IRC |
| 19:05:19 | *** djazayeri has quit IRC |
| 19:08:40 | *** mvorobey has quit IRC |
| 19:15:16 | *** djazayeri has joined #openmrs |
| 19:15:16 | *** ChanServ sets mode: +o djazayeri |
| 19:16:45 | <djazayeri> wyclif: hey, what's up? |
| 19:21:52 | <wyclif> djazayeri, hold on |
| 19:21:57 | <djazayeri> np |
| 19:32:47 | <wyclif> djazayeri, reporting has so many blockers |
| 19:33:16 | <wyclif> djazayeri, probably not so many a couple |
| 19:33:17 | <djazayeri> wyclif: what do you mean? that there are lots of things blocking you about the reporting tickets? |
| 19:34:28 | *** sgithens has quit IRC |
| 19:34:38 | <wyclif> djazayeri, cant run single unit tests, the module versions it seems to depend on seem to be none existent, i can fetch report design |
| 19:35:06 | <wyclif> djazayeri, i think there is something wrong in the mapping file |
| 19:35:41 | <djazayeri> wyclif: the module versions of htmlwidgets and serialization.xstream? |
| 19:36:07 | <djazayeri> wyclif: it was working before mavenization, so it's possible that mavenization has broken things |
| 19:36:20 | <djazayeri> what error do unit test failures report? |
| 19:39:18 | *** djazayeri has quit IRC |
| 19:42:23 | <wyclif> i think the slf4j lib id old |
| 19:42:28 | <wyclif> is old |
| 20:20:15 | *** lh has joined #openmrs |
| 20:22:41 | *** jordank has quit IRC |
| 20:30:05 | *** snoppy has left #openmrs |
| 20:31:33 | *** diptanuc has joined #openmrs |
| 20:39:15 | *** rafa has joined #openmrs |
| 20:39:15 | *** ChanServ sets mode: +v rafa |
| 20:39:25 | *** djazayeri has joined #openmrs |
| 20:39:25 | *** ChanServ sets mode: +o djazayeri |
| 20:43:50 | *** elliott_w has joined #openmrs |
| 20:43:50 | *** ChanServ sets mode: +o elliott_w |
| 20:44:22 | *** lakkarau has quit IRC |
| 20:46:29 | *** elliott_w has quit IRC |
| 20:47:01 | <venkaban_> djazayeri, Hi |
| 20:47:25 | <venkaban_> djazayeri, Can you please send me the link for the list of openmrs versions? |
| 20:47:56 | *** rafa has quit IRC |
| 20:52:19 | *** rafa has joined #openmrs |
| 20:52:19 | *** ChanServ sets mode: +v rafa |
| 20:54:17 | *** maurya has quit IRC |
| 20:58:01 | <djazayeri> venkaban_: it should be pretty a pretty obvious wiki search, or look at the irc logs from the other day when I pasted it |
| 20:58:20 | *** lakkarau has joined #openmrs |
| 20:58:31 | *** rafa has quit IRC |
| 21:04:05 | *** rafa has joined #openmrs |
| 21:04:05 | *** ChanServ sets mode: +v rafa |
| 21:05:57 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Our #OpenMRS #GSoC students are hard at work on their projects. Some advice from student-turned-mentor @suranga_kas: http://t.co/6ZJzFNaZ <http://twitter.com/OpenMRS/statuses/216269142578302978> |
| 21:07:29 | *** rafa has quit IRC |
| 21:09:31 | *** venkaban_ has quit IRC |
| 21:19:09 | *** diptanuc has quit IRC |
| 21:19:21 | *** diptanuc has joined #openmrs |
| 21:21:10 | *** venkaban has joined #openmrs |
| 21:36:42 | *** wyclif has quit IRC |
| 21:36:54 | *** goutham has joined #openmrs |
| 21:41:16 | *** goutham has quit IRC |
| 21:48:44 | *** jordank has joined #openmrs |
| 22:02:29 | *** kreddy has quit IRC |
| 22:03:58 | *** suranga_ has quit IRC |
| 22:15:23 | *** mccallumg has quit IRC |
| 22:15:36 | *** mccallumg has joined #openmrs |
| 22:15:36 | *** ChanServ sets mode: +v mccallumg |
| 22:25:43 | *** r0bby has joined #openmrs |
| 22:25:43 | *** ChanServ sets mode: +v r0bby |
| 22:29:50 | *** robbyoconnor has quit IRC |
| 22:54:01 | *** downey has quit IRC |
| 22:58:45 | *** lh has quit IRC |
| 23:01:27 | *** wyclif has joined #openmrs |
| 23:11:21 | *** diptanuc has quit IRC |
| 23:29:04 | *** jordank_ has joined #openmrs |
| 23:29:08 | *** jordank has quit IRC |
| 23:29:08 | *** jordank_ is now known as jordank |
| 23:40:27 | *** lakkarau has quit IRC |
| 23:53:21 | *** venkaban has quit IRC |