00:30:47
|
*** wyclif has joined #openmrs
|
00:42:08
|
<wyclif> hi djazayeri
|
01:09:28
|
*** bwolfe has joined #openmrs
|
01:09:28
|
*** ChanServ sets mode: +o bwolfe
|
01:13:03
|
<GDG> bwolfe = follow up on the HL7 issue
|
01:14:22
|
<bwolfe> yessir?
|
01:22:27
|
<GDG> I'm an HL7 insider, and have contributed to java opensource projects in the past
|
01:23:02
|
<GDG> I'm interested in contributing to the integration part of openMRS
|
01:24:00
|
<GDG> also, I've been a tech lead for clinical systems vendors for a many years
|
01:30:06
|
<GDG> so, I'm trying to get a sense of where things are at
|
01:30:18
|
<GDG> https://wiki.openmrs.org/display/projects/HL7+Output+%28Design+Page%29
|
01:30:30
|
<djazayeri> hi wyclif
|
01:30:32
|
<GDG> the code for that doesn't seem to be present in the trunk
|
01:30:36
|
<GDG> the code for that doesn't seem to be present in the trunk?
|
01:31:39
|
<GDG> [sigh, this not skype, where I can correct the last...]
|
01:42:06
|
<bwolfe> GDG, nope, no correct. :-)
|
01:42:22
|
<bwolfe> we like to use vim syntax:
|
01:42:30
|
<bwolfe> s/\n/?
|
01:42:32
|
<bwolfe> :-)
|
01:56:23
|
<bwolfe> GDG, contributions are definitely welcome.
|
01:56:41
|
<bwolfe> the project is not committed, its only in patch form. you can see the code in the code review linked
|
01:57:14
|
<GDG> ok ta
|
01:57:31
|
<bwolfe> if you wanted to take that on, update to apply against trunk, then do the review comments, that'd be very helpful
|
01:57:44
|
<bwolfe> I can't remember how complete it is now
|
01:58:09
|
<bwolfe> GDG, are you more on the coding of hl7 side or coding of java side?
|
02:03:32
|
*** suranga has joined #openmrs
|
02:03:32
|
*** ChanServ sets mode: +v suranga
|
02:29:08
|
*** jordank has quit IRC
|
02:45:17
|
<suranga> grretings bwolfe :)
|
02:45:30
|
<suranga> bwolfe, I checked out the hl7 output page
|
02:45:37
|
<suranga> bwolfe, even updated it a bit...
|
02:45:53
|
<bwolfe> ok
|
02:49:37
|
<suranga> bwolfe, may have a few questions for later...
|
02:49:48
|
<bwolfe> I'll probably be asleep later ;-)
|
02:49:49
|
<suranga> bwolfe, I should probably mail the dev list, I guess
|
02:50:00
|
<bwolfe> suranga, GDG is still very interested in the project
|
02:50:24
|
<suranga> bwolfe, you go to sleep this early ? he hee... i hope this is not a sign of ageing :D
|
02:50:43
|
<bwolfe> its almost 11pm...
|
02:50:53
|
<bwolfe> I only get 5ish hours of sleep most nights
|
02:51:18
|
<bwolfe> then my brain starts slowing down and I have to give it a bit extra a few nights
|
02:51:48
|
<suranga> bwolfe, oooops. Ah, i forgot that you have a new 'alarm clock' at home. baby keeps you awake ?
|
02:52:10
|
<bwolfe> no, I don't hear her. :-) meghan gets up with her at night
|
02:52:32
|
<bwolfe> its just that I have tons of stuff to do in the few shorts hours where I can be on my computer (after 9pm when there are no kids awake)
|
02:52:43
|
<bwolfe> so I get to bed at 1230ish. then I'm up by 6am to get to work
|
02:53:54
|
<suranga> bwolfe, me opposite... I sleep from 3 am to 7.30 or so... luckly, I have NOOOO commuting time :P
|
02:54:04
|
<bwolfe> ha
|
02:54:17
|
<bwolfe> yeah, I'd save myself 2 hours a day wed/thurs/fri if I didn't have to commute
|
03:10:49
|
*** jordank has joined #openmrs
|
03:14:28
|
*** suranga has quit IRC
|
03:16:05
|
*** bwolfe has quit IRC
|
03:28:15
|
*** jordank has quit IRC
|
04:25:11
|
<wyclif> hi djazayeri
|
04:43:04
|
*** lh has quit IRC
|
05:06:54
|
*** r0bby_ is now known as robbyoconnor
|
05:09:40
|
*** mathiaslin has joined #openmrs
|
05:44:07
|
*** mathiaslin has quit IRC
|
05:55:46
|
*** kishoreyekkanti has joined #openmrs
|
06:00:49
|
*** goutham has joined #openmrs
|
06:02:29
|
*** magoo_ has joined #openmrs
|
06:05:56
|
*** maurya has joined #openmrs
|
06:06:19
|
*** ChanServ sets mode: +v maurya
|
06:17:06
|
*** magoo_ has quit IRC
|
06:30:39
|
*** magoo_ has joined #openmrs
|
06:36:16
|
*** goutham has quit IRC
|
06:41:16
|
*** magoo_ has quit IRC
|
06:42:04
|
*** goutham has joined #openmrs
|
06:46:21
|
*** dkayiwa has joined #openmrs
|
07:17:20
|
*** snoppy has joined #openmrs
|
07:36:21
|
*** harshadura has joined #openmrs
|
07:41:16
|
*** goutham has quit IRC
|
07:54:24
|
*** dkayiwa has quit IRC
|
07:57:12
|
*** snoppy has quit IRC
|
08:02:34
|
*** goutham has joined #openmrs
|
08:36:15
|
*** snoppy has joined #openmrs
|
08:40:02
|
*** rafa has joined #openmrs
|
08:40:02
|
*** ChanServ sets mode: +v rafa
|
08:42:51
|
*** dkayiwa has joined #openmrs
|
08:44:10
|
*** rafa has quit IRC
|
08:47:14
|
*** snoppy has left #openmrs
|
08:47:20
|
*** rafa has joined #openmrs
|
08:47:20
|
*** ChanServ sets mode: +v rafa
|
08:58:45
|
*** harshadura has quit IRC
|
09:00:30
|
*** harshadura has joined #openmrs
|
09:01:13
|
*** suranga has joined #openmrs
|
09:01:13
|
*** ChanServ sets mode: +v suranga
|
09:03:15
|
*** snoppy1 has joined #openmrs
|
09:04:00
|
*** magoo_ has joined #openmrs
|
09:14:06
|
<suranga> mm.. good morning dkayiwa
|
09:14:21
|
<suranga> dkayiwa, do you know how I can group obs via the openmrs UI ? :)
|
09:34:58
|
<dkayiwa> hi suranga
|
09:35:06
|
<dkayiwa> suranga: not sure if i get u :)
|
09:35:13
|
<suranga> hi dkayiwa :)
|
09:35:50
|
<suranga> dkayiwa, its like this... umm.. when I create an obs, can I define that if belongs to a particular obs group via the jsp page itself ?
|
09:36:02
|
<suranga> dkayiwa, I dont think we can do this in 1.8.3 :)
|
09:37:06
|
*** magoo_ has quit IRC
|
09:50:37
|
*** magoo_ has joined #openmrs
|
09:55:39
|
*** snoppy1 has left #openmrs
|
10:00:52
|
*** snoppy has joined #openmrs
|
10:08:30
|
*** jeedo has joined #openmrs
|
10:10:19
|
*** suranga has quit IRC
|
10:28:41
|
*** snoppy1 has joined #openmrs
|
10:29:36
|
*** sgithens has quit IRC
|
10:29:45
|
*** snoppy has quit IRC
|
10:30:51
|
*** goutham has quit IRC
|
10:35:11
|
*** kishoreyekkanti_ has joined #openmrs
|
10:36:34
|
*** kishoreyekkanti_ has joined #openmrs
|
10:36:39
|
*** kishoreyekkanti has quit IRC
|
10:42:31
|
*** magoo_ has quit IRC
|
10:44:11
|
*** deepaganu has joined #openmrs
|
10:46:31
|
*** snoppy1 has left #openmrs
|
10:47:15
|
*** snoppy has joined #openmrs
|
11:09:25
|
*** maurya has quit IRC
|
11:14:33
|
*** deepaganu has quit IRC
|
11:18:32
|
*** magoo_ has joined #openmrs
|
11:19:30
|
*** maurya has joined #openmrs
|
11:20:13
|
*** james_regen has joined #openmrs
|
11:20:20
|
*** ChanServ sets mode: +v james_regen
|
11:26:44
|
*** kishoreyekkanti_ has quit IRC
|
11:30:31
|
*** dkayiwa has quit IRC
|
11:33:43
|
*** dkayiwa has joined #openmrs
|
11:36:05
|
*** deepaganu has joined #openmrs
|
11:36:25
|
<deepaganu> hi all
|
11:36:50
|
*** Orien has joined #openmrs
|
11:39:53
|
*** maurya has quit IRC
|
11:40:41
|
*** Orien has quit IRC
|
11:41:03
|
*** Orien has joined #openmrs
|
11:41:51
|
<deepaganu> how can i include third party jars in pom.xml
|
11:42:10
|
<deepaganu> should i manually install them in my repo
|
11:42:13
|
*** orien has joined #openmrs
|
11:43:46
|
<deepaganu> hi rafa
|
11:44:04
|
*** orien has left #openmrs
|
11:44:32
|
*** orien has joined #openmrs
|
11:44:43
|
*** orien has left #openmrs
|
11:49:39
|
*** goutham has joined #openmrs
|
11:50:29
|
<rafa> deepaganu: yes, it's one option
|
11:51:06
|
<rafa> deepaganu: aren't they available in the maven repo?
|
11:51:08
|
<deepaganu> rafa my module uses some third party jars , how should i include them
|
11:51:15
|
<deepaganu> no they arent
|
11:51:23
|
<deepaganu> avaialble in the repo
|
11:52:41
|
<deepaganu> i added this node in my pom.xml rafa
|
11:52:42
|
<deepaganu> http://pastebin.com/5amWBcCk
|
11:53:10
|
*** Orien has joined #openmrs
|
11:55:01
|
<rafa> deepaganu: see http://www.mkyong.com/maven/how-to-include-library-manully-into-maven-local-repository/
|
11:55:05
|
<OpenMRSBot> <http://ln-s.net/$KN:> (at www.mkyong.com)
|
11:59:49
|
*** jeedo has quit IRC
|
12:00:01
|
*** magoo_ has quit IRC
|
12:04:25
|
*** goutham_ has joined #openmrs
|
12:06:01
|
*** magoo_ has joined #openmrs
|
12:07:01
|
*** goutham has quit IRC
|
12:07:16
|
*** goutham_ is now known as goutham
|
12:08:03
|
*** wyclif has quit IRC
|
12:34:35
|
<deepaganu> rafa i am using somewhere around twenty jars
|
12:35:00
|
<deepaganu> should i add all of them to the local repo
|
12:35:28
|
*** mvorobey has joined #openmrs
|
12:35:32
|
<mvorobey> hi all
|
12:35:40
|
<rafa> deepaganu: hmm are you the only dev?
|
12:35:48
|
<deepaganu> yes
|
12:36:11
|
<deepaganu> i mean i do have a mentor
|
12:36:16
|
<deepaganu> james and jan
|
12:36:21
|
<deepaganu> i would ask them then
|
12:36:51
|
<rafa> deepaganu: ohh I see. Actually it's better if you define a repository within your project
|
12:36:54
|
<deepaganu> i was just wondering how to include the third party jars so that the pom.xml should give us compilation errors
|
12:36:58
|
<rafa> deepaganu: create a lib folder
|
12:37:06
|
<deepaganu> oh ok
|
12:37:13
|
<rafa> deepaganu: put there jars you want
|
12:37:18
|
<rafa> deepaganu: execute:
|
12:37:23
|
<deepaganu> is that allowed
|
12:37:30
|
<deepaganu> execute ???
|
12:37:31
|
<rafa> mvn install:install-file -Dfile=mysql-connector-mxj-gpl-5-0-12.jar -DgroupId=mysql -DartifactId=mysql-connector-mxj -Dversion=5.0.12 -Dpackaging=jar -DlocalRepositoryPath=. -DcreateChecksum=true -DgeneratePom=true
|
12:37:35
|
<deepaganu> didnt get that
|
12:38:10
|
<deepaganu> rafa do i do that for each and every lib
|
12:38:11
|
<rafa> deepaganu: and add <repository><url>lib</url></repository> to your pom
|
12:38:16
|
<rafa> deepaganu: yes
|
12:38:23
|
<deepaganu> oh :(
|
12:38:32
|
<rafa> deepaganu: but only once
|
12:38:35
|
<deepaganu> got it
|
12:38:38
|
<deepaganu> i know
|
12:38:40
|
<deepaganu> thanks
|
12:38:41
|
<deepaganu> :)
|
12:38:43
|
<rafa> np
|
12:39:07
|
<rafa> deepaganu: it's hard to believe you need 20 jars that are not in the maven repo...
|
12:39:32
|
<rafa> deepaganu: did you search here: http://mvnrepository.com/ ?
|
12:43:30
|
*** deepaganu has quit IRC
|
12:47:57
|
*** ABHISHEK__ has joined #openmrs
|
12:48:39
|
*** ABHISHEK__ is now known as deepaganu
|
12:59:26
|
*** ABHISHEK__ has joined #openmrs
|
13:00:33
|
*** deepaganu has quit IRC
|
13:01:14
|
*** wyclif has joined #openmrs
|
13:05:05
|
*** robbyoconnor has quit IRC
|
13:07:25
|
*** downey has joined #openmrs
|
13:07:25
|
*** ChanServ sets mode: +o downey
|
13:07:25
|
*** OpenMRSBot sets mode: +o downey
|
13:07:38
|
*** Orien has quit IRC
|
13:09:54
|
*** ABHISHEK__ is now known as deepaganu
|
13:14:14
|
*** kishoreyekkanti has joined #openmrs
|
13:14:30
|
<kishoreyekkanti> downey: Hi Mike. Good morning!
|
13:14:36
|
<downey> hey kishoreyekkanti
|
13:14:59
|
<kishoreyekkanti> downey: let me know if you are free now. We'll look into the CI issue
|
13:15:06
|
<downey> i have about 15 minutes :(
|
13:15:30
|
<downey> kishoreyekkanti: forgot i have some items to get done before our developer forum
|
13:15:44
|
<kishoreyekkanti> downey: Oh okk. I've found some thing like this today http://lj4newbies.blogspot.in/2007/04/too-many-open-files.html
|
13:15:46
|
<OpenMRSBot> <http://ln-s.net/$KOm> (at lj4newbies.blogspot.in)
|
13:16:04
|
<kishoreyekkanti> downey: it said about setting the fd's for the shell session.
|
13:16:23
|
<downey> kishoreyekkanti: yeah we've done that
|
13:16:38
|
<kishoreyekkanti> downey: ohh :) i thought we did only for the entire user.
|
13:17:27
|
<kishoreyekkanti> downey: i mean enabled it to the entire user. Any ways i'm unable to think any other ways we can solve this.
|
13:17:28
|
<downey> kishoreyekkanti: changing to * users is what i did yesterday unforutnately
|
13:18:14
|
<downey> mjdowney@santa:~$ ulimit -n
|
13:18:15
|
<downey> 65535
|
13:18:43
|
*** sgithens has joined #openmrs
|
13:19:01
|
<downey> kishoreyekkanti: the real interesting question is what/why so many files are getting opened by the test
|
13:19:40
|
<kishoreyekkanti> downey: yep. I'm sure JBheave will create all the test reporting files for each scenario ran.
|
13:20:07
|
<kishoreyekkanti> downey: But not sure why its drastically increasing the limit
|
13:20:49
|
<downey> kishoreyekkanti: have you seen https://github.com/jbehave/jbehave-core/pull/22
|
13:20:54
|
<kishoreyekkanti> downey: One thing i was not sure about is if JVM itself have any constraints around number of fd's or do we need to do any aggressive GC.
|
13:21:22
|
<kishoreyekkanti> downey: nope i haven't seen it. Let me look at it
|
13:21:55
|
<downey> kishoreyekkanti: looks like fixed in 3.5.4 and 3.6
|
13:24:05
|
<kishoreyekkanti> downey: we are using Jbehave 3.5.3 :) I'll change the version and try it once.
|
13:24:14
|
<kishoreyekkanti> downey: Where did you found that its fixed in 3.5.4
|
13:24:30
|
<downey> kishoreyekkanti: http://jira.codehaus.org/browse/JBEHAVE-641
|
13:25:28
|
<kishoreyekkanti> downey: Awesome. Let me try the older versions. You might be probably moving for the meeting before i come back. I'll change the version and run the build in bamboo.
|
13:25:36
|
<kishoreyekkanti> downey: will drop you a note bout the result
|
13:25:48
|
<downey> kishoreyekkanti: ok keep me posted :)
|
13:25:56
|
<kishoreyekkanti> downey: typo* let me try the newer version*
|
13:31:35
|
*** lakkarau has joined #openmrs
|
13:36:17
|
*** snoppy has left #openmrs
|
13:45:36
|
*** bwolfe has joined #openmrs
|
13:45:36
|
*** ChanServ sets mode: +o bwolfe
|
13:45:57
|
<mvorobey> bwolfe, hi
|
13:46:03
|
<bwolfe> hey
|
13:46:06
|
<mvorobey> bwolfe, have a minute ?
|
13:46:18
|
<bwolfe> approx
|
13:46:43
|
<mvorobey> bwolfe, so, here is a pastebin of recursive test - http://pastebin.com/pEjJdHHV
|
13:46:50
|
<mvorobey> bwolfe, on reporting
|
13:48:05
|
<bwolfe> so calling getAllowedLocales is forcing a flush? which means one of our hibernate listeners is then calling getAllowedLocales again
|
13:48:37
|
<mvorobey> bwolfe, may be
|
13:49:49
|
<wyclif> hi djazayeri
|
13:49:56
|
<deepaganu> downey, do we need to login in adobe connect with our openmrs username and password
|
13:50:10
|
<downey> deepaganu: no, you can just sign in as gues
|
13:50:12
|
<downey> *guest
|
13:50:32
|
<deepaganu> can we share screens downey if logged in as guest
|
13:50:45
|
<downey> yes
|
13:52:10
|
<deepaganu> downey, it gives me this message The meeting was opened in the Adobe® Connect™ Add-in.
|
13:52:39
|
<deepaganu> its a blank window , i am using this for the first time
|
13:52:53
|
<mvorobey> bwolfe, do I need to avoid calling of some listener ?
|
13:53:20
|
<bwolfe> mvorobey, the listener needs to make sure it doesn't call things that might flush
|
13:53:21
|
*** magoo_ has quit IRC
|
13:53:24
|
<bwolfe> but I don't see where it is
|
13:53:30
|
<lakkarau> bwolfe:hi
|
13:53:31
|
<bwolfe> which version are you testing against mvorobey?
|
13:54:02
|
<bwolfe> good morning lakkarau
|
13:54:08
|
<downey> deepaganu: that's why we asked you to practice in advance :)
|
13:54:16
|
<bwolfe> !devmtg
|
13:54:16
|
<OpenMRSBot> bwolfe: "devmtg" --- Reminder: Developer Forum Thursday at 10:00 AM Eastern Time - https://wiki.openmrs.org/display/RES/Developers+Forum
|
13:54:23
|
<lakkarau> bwolfe:good morning.
|
13:54:52
|
<deepaganu> i did that earlier
|
13:54:53
|
<bwolfe> deepaganu, it might be loading slowly. or it might be an error. try in another browser?
|
13:54:59
|
<deepaganu> it was fine then
|
13:55:08
|
<mvorobey> bwolfe, this error occurs agains 1.7 and 1.8
|
13:55:13
|
*** suranga has joined #openmrs
|
13:55:17
|
<deepaganu> coz it even asked me to show my screen and all the other options
|
13:55:20
|
<mvorobey> agains = against
|
13:55:21
|
<bwolfe> deepaganu, also make sure all other conenct windows are closed. (perhaps restart browser to be sure)
|
13:56:06
|
<bwolfe> mvorobey, was that stack trace against 1.8?
|
13:57:14
|
*** kishoreyekkanti_ has joined #openmrs
|
13:57:48
|
<mvorobey> bwolfe, do not remember, most likely that it was against 1.7
|
13:59:24
|
<bwolfe> mvorobey, like 62 in AuditableInterceptor is in 1.7 and 1.8 is "log.debug("Setting changed by fields on " + entity);"
|
13:59:25
|
*** kishoreyekkanti has quit IRC
|
13:59:38
|
<bwolfe> so perhaps the .toString call on some object is causing a GP lookup?
|
13:59:54
|
<bwolfe> that line needs to be changed to log.debug("Setting changed by fields on " + entity.getClass());
|
14:00:44
|
<mvorobey> bwolfe, who would do it ?
|
14:01:05
|
*** kishoreyekkanti has joined #openmrs
|
14:01:29
|
<bwolfe> mvorobey, you. first test to see if its the fix
|
14:01:32
|
<bwolfe> then create a ticket
|
14:01:34
|
<bwolfe> then create a patch
|
14:01:42
|
<bwolfe> somewhere in there try to make a unit test. :-)
|
14:02:09
|
<mvorobey> bwolfe, heh, it would be a long story but I'll do it
|
14:02:31
|
*** kishoreyekkanti_ has quit IRC
|
14:03:12
|
*** kreddy has joined #openmrs
|
14:03:21
|
*** bwolfe_ has joined #openmrs
|
14:03:21
|
*** ChanServ sets mode: +o bwolfe_
|
14:03:33
|
*** MarkG has joined #openmrs
|
14:04:19
|
*** mccallumg has joined #openmrs
|
14:04:19
|
*** ChanServ sets mode: +v mccallumg
|
14:06:13
|
*** bwolfe has quit IRC
|
14:06:22
|
<mvorobey> bwolfe, once more question, I'm trying to do magic with testing against 1.9+ (exactly with hibernate versions), but can not handle it properly
|
14:10:20
|
<mvorobey> bwolfe_, basically made reporting to be compiled with 1.9+ but my tests are failing in this case with output : Could not determine type for: materialized_clob, for columns: [org.hibernate.mapping.Column(value)]
|
14:10:27
|
<bwolfe_> mvorobey, sorry, switched connections and I missed anything you said before 10:06
|
14:10:44
|
<mvorobey> bwolfe_, once more question, I'm trying to do magic with testing against 1.9+ (exactly with hibernate versions), but can not handle it properly
|
14:10:49
|
<mvorobey> bwolfe_, basically made reporting to be compiled with 1.9+ but my tests are failing in this case with output : Could not determine type for: materialized_clob, for columns: [org.hibernate.mapping.Column(value)]
|
14:12:28
|
<deepaganu> hey can you hear me downey
|
14:12:36
|
<downey> deepaganu: Not any more
|
14:12:41
|
*** bwolfe_ is now known as bwolfe
|
14:12:56
|
*** kishoreyekkanti_ has joined #openmrs
|
14:12:58
|
<deepaganu> gimme a moment
|
14:13:08
|
*** dkayiwa has quit IRC
|
14:13:11
|
<bwolfe> mvorobey, I vaguely remember clob being a problem in hibernate version
|
14:13:23
|
<bwolfe> deepaganu, upload your presentation somewhere and we'll try to circle back around today if we have time
|
14:13:57
|
<deepaganu> which means i wont be giving my presentation today bwolfe
|
14:14:03
|
*** kishoreyekkanti_ has quit IRC
|
14:14:26
|
*** kishoreyekkanti_ has joined #openmrs
|
14:14:38
|
<djazayeri> deepaganu: do you have a ppt or pdf presentation or something that you can upload to a wiki page, and michael can show it?
|
14:14:47
|
<deepaganu> ok
|
14:14:53
|
<deepaganu> i have the ppt only
|
14:14:58
|
<djazayeri> that's fine
|
14:14:59
|
<deepaganu> i will upload it
|
14:15:19
|
<downey> deepaganu: You could email it to me
|
14:15:22
|
<downey> michael @ o.o
|
14:16:34
|
<mvorobey> bwolfe, so, tell me please, if you know, which steps need to be done to fix it in this case ?
|
14:16:52
|
*** kishoreyekkanti has quit IRC
|
14:17:18
|
<bwolfe> mvorobey, just add a .getClass() to the end of that entity call
|
14:17:31
|
<bwolfe> I assume there is a reporting object that has a .toString() that makes a call to a GP.
|
14:17:42
|
<bwolfe> the listener should never call .toString on methods for this possibl error
|
14:17:43
|
<mvorobey> bwolfe, I meant about hibernate clob issue
|
14:17:51
|
<bwolfe> your other solution is to turn off DEBUG logging
|
14:17:52
|
<deepaganu> downey, just mailed you
|
14:17:54
|
<bwolfe> oh
|
14:17:57
|
<bwolfe> that one
|
14:17:59
|
<bwolfe> sorry
|
14:18:02
|
<bwolfe> no idea. :-(
|
14:18:09
|
<mvorobey> bwolfe, awesome :)
|
14:18:54
|
<downey> deepaganu: ok, got it. will try again after the other presentations
|
14:19:27
|
*** ABHISHEK__ has joined #openmrs
|
14:19:32
|
<downey> Hi ABHISHEK__ and welcome to the #openmrs IRC channel.
|
14:19:58
|
*** reddykir_ has joined #openmrs
|
14:19:59
|
*** kreddy has quit IRC
|
14:20:39
|
*** kreddy has joined #openmrs
|
14:20:51
|
*** goutham has quit IRC
|
14:21:11
|
*** ABHISHEK__ has quit IRC
|
14:22:20
|
*** deepaganu has quit IRC
|
14:24:56
|
*** Jibesh has joined #openmrs
|
14:25:57
|
*** suranga has quit IRC
|
14:26:12
|
*** magoo_ has joined #openmrs
|
14:28:48
|
*** kishoreyekkanti has joined #openmrs
|
14:30:30
|
*** kishoreyekkanti_ has quit IRC
|
14:31:30
|
<mvorobey> bwolfe, making the call entity.getClass() solved the problem
|
14:31:41
|
*** goutham has joined #openmrs
|
14:32:39
|
<goutham> Downey: when i started the audio plugin got crashed a minute please
|
14:33:03
|
*** kavuri has joined #openmrs
|
14:34:38
|
<kavuri> djazayeri, bwolfe: all the drugs are part of concept database along with symptoms, diseases and everything else. Would it not be a good idea to create a drugs database, so that searching would be faster and drug operations (adding/voiding/modifying) would be easier?
|
14:34:54
|
<mvorobey> bwolfe, but still dunno what to do with clob hibernate issue, may be djazayeri knows an answer ?
|
14:35:03
|
<djazayeri> kavuri: generic drugs are represented by concepts
|
14:35:17
|
<djazayeri> kavuri: actual drug formulations (e.g. the formular) are stored as Drug in the drug table.
|
14:36:20
|
<kavuri> djazayeri: so something like paracetamol is stored as concept and the actual product name is in Drug table?
|
14:36:30
|
*** goutham_ has joined #openmrs
|
14:37:11
|
<djazayeri> kavuri: yes
|
14:37:15
|
*** dkayiwa has joined #openmrs
|
14:37:36
|
<djazayeri> mvorobey: what's the issue? (I don't know the answer, so you might have to give me lots of context)
|
14:37:46
|
<goutham_> bwolfe , djazayeri i am not able to connect to adobe connect.. will be there in 5min
|
14:38:04
|
*** goutham has quit IRC
|
14:39:35
|
<mvorobey> djazayeri, am working on making reporting to be tested against multiple versions of openmrrs, and I have already made reporting to be compiled with all versions, but my tests are failing in this of 1.9+ with output : Could not determine type for: materialized_clob, for columns: [org.hibernate.mapping.Column(value)]
|
14:40:06
|
<mvorobey> this of = case of
|
14:42:52
|
*** deepaganu has joined #openmrs
|
14:43:23
|
<deepaganu> Hi downey
|
14:43:38
|
<deepaganu> this is weird but i am not even getting to load the page
|
14:44:46
|
<goutham_> downey: yes me too... :(
|
14:45:32
|
<deepaganu> what do we do downey
|
14:46:07
|
<deepaganu> goutham_, is the link http://connect.iu.edu/omrsdf not working for you too
|
14:46:15
|
<mvorobey> bwolfe, please, look at https://tickets.openmrs.org/browse/TRUNK-3472
|
14:46:31
|
<bwolfe> deepaganu, shift reload?
|
14:46:36
|
<bwolfe> (to clear cache)
|
14:46:37
|
<goutham_> deepaganu: yes not working
|
14:47:39
|
<goutham_> bwolfe: http://na1cps.adobeconnect.com/common/help/en/support/meeting_test.htm results are also good but still unable to connect
|
14:47:43
|
<OpenMRSBot> <http://ln-s.net/$KQm> (at na1cps.adobeconnect.com)
|
14:47:52
|
<djazayeri> mvorobey: does some of the code's hbm.xml say materialized_clob in it?
|
14:48:05
|
<bwolfe> goutham_, even with shift reload?
|
14:48:09
|
<bwolfe> or browser restart?
|
14:48:17
|
<bwolfe> or waiting for it to load fully?
|
14:48:43
|
<djazayeri> mvorobey: or is materialized_clob getting added by hibernate automatically?
|
14:48:46
|
<goutham_> bwolfe: nothing works ...all done
|
14:48:49
|
<mvorobey> djazayeri, no one
|
14:49:34
|
<djazayeri> mvorobey: can you pastebin the whole stack trace of a failure?
|
14:49:39
|
<mvorobey> djazayeri, probably that automatically, because there is no hbm.xml with materialized_clob
|
14:50:01
|
<mvorobey> djazayeri, yes, I can, give me couple of minute
|
14:55:04
|
<deepaganu> downey, apparently myself and goutham_ are unable to log in the room
|
14:55:23
|
<deepaganu> what do we do now downey
|
14:55:37
|
<downey> deepaganu: Are you signing in as a guest?
|
14:55:48
|
<deepaganu> only that site and also openmrs wiki is not opening up
|
14:55:58
|
<deepaganu> rest internet is working
|
14:56:11
|
<deepaganu> i dont get the welcome page only to sign in
|
14:56:41
|
*** goutham has joined #openmrs
|
14:57:41
|
<djazayeri> deepaganu: what happens after you sign in?
|
14:57:44
|
<djazayeri> (as guest)
|
14:58:10
|
<deepaganu> i am not even getting response from http://connect.iu.edu/omrsdf
|
14:58:22
|
<deepaganu> The connection was reset
|
14:58:33
|
<deepaganu> this is what browser says
|
14:58:42
|
<djazayeri> deepaganu: can you clear your browser cache for connect.iu.edu?
|
14:58:52
|
<deepaganu> i am doing that
|
14:58:54
|
<djazayeri> and make sure any process for the connect plugin is killed?
|
15:00:01
|
*** goutham_ has quit IRC
|
15:00:05
|
<deepaganu> ok
|
15:01:20
|
*** Goutham_vasiredd has joined #openmrs
|
15:01:31
|
<downey> Hi Goutham_vasiredd and welcome to the #openmrs IRC channel.
|
15:01:32
|
<mvorobey> bwolfe, I do not have enough privileges to commit to trunk yet :(
|
15:01:38
|
<deepaganu> i killed a plugin process , cleared the cache and trying to load the page
|
15:02:03
|
<bwolfe> mvorobey, you do. I just "gave" it to you when I asked you to commit it. :-)
|
15:02:03
|
<deepaganu> but still no progress , i wonder what happen i had joined the meeting
|
15:02:14
|
<deepaganu> goutham, are you able to join the meeting
|
15:02:42
|
<bwolfe> deepaganu, I was able to log in here after you started having problems. so its not a connect problem
|
15:03:15
|
<dkayiwa> deepaganu: he just restarted his computer to try again :)
|
15:03:27
|
<mvorobey> bwolfe, I remember, few months ago you said that I will be able to commit to trunk after some time, and now it happened :)
|
15:04:12
|
*** goutham_ has joined #openmrs
|
15:04:19
|
<dkayiwa> mvorobey: bwolfe never tells lies :)
|
15:04:28
|
<mvorobey> dkayiwa, :)
|
15:05:09
|
*** goutham has quit IRC
|
15:05:17
|
<mvorobey> djazayeri, here is a paste http://pastebin.com/b22Ux7Zs
|
15:06:14
|
*** cpower has joined #openmrs
|
15:06:29
|
<dkayiwa> goutham_: are you now able to connect?
|
15:06:38
|
<mvorobey> bwolfe, you said that it would be awesome to add unit test for that, any suggestion of what to do it that test :) ?
|
15:06:44
|
<goutham_> dkayiwa: no :(
|
15:07:03
|
<dkayiwa> goutham_: have you ever done it successfully before?
|
15:07:24
|
<goutham_> dkayiwa: yes last year
|
15:08:06
|
<djazayeri> mvorobey: this is something that works in 1.6 and 1.8, but fails in 1.9?
|
15:08:07
|
<bwolfe> mvorobey, you could create an inner class on the test class that extends an Auditable type of object (EncounterType). only method to voerride is the toString(). call the getGlobalPropertyObject method from that toString. then create/save that enctype using the encounterservice
|
15:08:09
|
<deepaganu> this is weird i am unable to even open up openmrs wiki
|
15:08:25
|
<bwolfe> deepaganu, well, perhaps you've found the problem!
|
15:08:28
|
<mvorobey> djazayeri, yes, exactly
|
15:08:32
|
<deepaganu> goutham_, try openning up openmrs wiki page
|
15:08:40
|
<deepaganu> which is
|
15:08:42
|
*** kishoreyekkanti has quit IRC
|
15:08:43
|
<deepaganu> bwolfe,
|
15:09:11
|
<mvorobey> bwolfe, thanks, need to note that
|
15:09:28
|
<deepaganu> bwolfe, i didnt get you
|
15:09:28
|
<djazayeri> mvorobey: I vaguely recall that starting in 1.9 we (via hibernate) may be converting mediumtext to materialized_clob
|
15:10:26
|
<mvorobey> djazayeri, so ?
|
15:10:27
|
<deepaganu> ok lemme restart my computer
|
15:11:26
|
*** elliott_w has joined #openmrs
|
15:11:26
|
*** reddykir_ has quit IRC
|
15:11:40
|
<djazayeri> mvorobey: I don't know...
|
15:11:51
|
*** Goutham_vasiredd has left #openmrs
|
15:11:55
|
*** ChanServ sets mode: +o elliott_w
|
15:12:07
|
<mvorobey> djazayeri, awesome :)
|
15:12:10
|
<djazayeri> mvorobey: I ran into something similar before… https://groups.google.com/a/openmrs.org/d/msg/dev/qLO58PbHWMk/zjBCgERpYTAJ
|
15:12:13
|
<djazayeri> mvorobey: thinking...
|
15:12:14
|
<OpenMRSBot> <http://ln-s.net/$KRS> (at groups.google.com)
|
15:12:21
|
<mvorobey> djazayeri, saw it
|
15:14:39
|
*** deepaganu has quit IRC
|
15:14:39
|
<mvorobey> djazayeri, could it be because tests are compiled against to old hibernate, but openmrs app context in 1.9+ is compiled against new hibernate ?
|
15:15:17
|
<djazayeri> mvorobey: looking at the comments on SEARCH-10, it suggests that modules might need to change their datatypes in hbm.xmls
|
15:16:12
|
<djazayeri> but that isn't introduced until hibernate 3.5
|
15:16:24
|
<djazayeri> so it would break reporting pre-1.9...
|
15:16:42
|
<djazayeri> actually, serialized_data…that's in core, isn't it?
|
15:16:42
|
*** deepaganu has joined #openmrs
|
15:16:59
|
<deepaganu> goutham_, any luck
|
15:17:18
|
<goutham_> deepaganu: nope not at all
|
15:17:28
|
<dkayiwa> bwolfe: do you have any advice for me concerning: RCM-85
|
15:17:32
|
<dkayiwa> !ticket RCM-85
|
15:17:33
|
<OpenMRSBot> dkayiwa: [#RCM-85] Multiple version testing in reporting compatibility module - OpenMRS JIRA - https://tickets.openmrs.org/browse/RCM-85
|
15:18:19
|
<djazayeri> mvorobey: hmm, serialized_data is coming from the serialized_object table, which is in core
|
15:18:21
|
<deepaganu> goutham_, what do we do now
|
15:18:45
|
<deepaganu> downey, we attempted many a times but are unable to login what do we do now
|
15:19:15
|
<djazayeri> mvorobey: so, I don't actually know how the multiple-versions testing runs, but I was assuming it would actually run against the specified openmrs version with its dependencies
|
15:19:31
|
<djazayeri> mvorobey: can you modify a test to somehow print out what hibernate version is available?
|
15:20:38
|
<mvorobey> djazayeri, I'm sure that 3.2.5.ga-mod
|
15:20:50
|
<djazayeri> mvorobey: that would be why it fails...
|
15:21:06
|
<djazayeri> but 1.9.x has a maven dependency on 3.6 (or something)
|
15:21:34
|
<mvorobey> djazayeri, ok, but how to make maven to use 3.2.5 for compile and 3.6.5 for test, a ?
|
15:22:10
|
<djazayeri> mvorobey: well, in particular we need to use 3.6.5 only for testing against 1.9.x
|
15:22:11
|
<mvorobey> djazayeri, I tried using compile+runtime for tests, but it did not work for me
|
15:22:29
|
<djazayeri> sorry, my eclipse crashed. restarting that so I can peek at the pom.xml
|
15:22:50
|
<mvorobey> djazayeri, I meant 3.2.5 - compile, 3.6.5 - runtime (tests including)
|
15:23:25
|
*** rfriedman has joined #openmrs
|
15:23:29
|
<deepaganu> goutham_, did you have to give your presentation today
|
15:23:43
|
<mvorobey> djazayeri, but maven still used 3.6.5 for both compile and tests and, thus, build failed
|
15:23:54
|
<rfriedman> mccallumg, hi glen
|
15:23:59
|
<mccallumg> hi rfriedman
|
15:24:07
|
<goutham_> deepaganu: yes, but guess iam out of luck
|
15:24:21
|
<rfriedman> glen, I was thinking that if you made the concept a synonym rather than deleting it
|
15:24:25
|
<deepaganu> me too goutham_
|
15:24:38
|
<rfriedman> then if you tried to get it by id, you would get the name from the preferred concept
|
15:26:07
|
<mccallumg> rfriedman: that's an interesting suggestion. We'll consider that. Thanks.
|
15:26:51
|
<rfriedman> mccallumg, i think Jordon did a great job given her experience level, you must be doing a good job
|
15:27:27
|
<djazayeri> mvorobey: actually, is the latest mavenized reporting with these multiple version tests in github somehwere?
|
15:27:34
|
<djazayeri> can I just look at the pom.xml there?
|
15:28:15
|
<mvorobey> djazayeri, no, there is not
|
15:28:21
|
*** goutham_ has quit IRC
|
15:28:24
|
*** MarkG has left #openmrs
|
15:28:29
|
<mccallumg> thanks rfriedman.
|
15:28:34
|
<mvorobey> djazayeri, am still waiting for some folks to create github accounts :(
|
15:28:38
|
<djazayeri> mvorobey: would it be easy for you to commit it to your github repo?
|
15:28:38
|
*** lakkarau has quit IRC
|
15:28:41
|
<djazayeri> oh, I see.
|
15:28:43
|
<djazayeri> doh!
|
15:28:56
|
<mccallumg> rfriedman: gotta run to a meeting. talk to you soon.
|
15:29:01
|
*** mccallumg has quit IRC
|
15:30:00
|
<djazayeri> mvorobey: I'm looking at the htmlformentry pom.xml where it does multiple version testing
|
15:30:25
|
<djazayeri> mvorobey: http://pastebin.com/KiLAcEZM
|
15:30:52
|
<djazayeri> mvorobey: are you doing something similar, e.g. with an openmrs-1.9 profile, and that sets a different openMRSVersion?
|
15:32:37
|
<mvorobey> djazayeri, exactly similar
|
15:32:57
|
<djazayeri> mvorobey: does reporting explicitly declare a dependency on hibernate?
|
15:33:22
|
<rfriedman> djazayeri, why do people have to create github accounts? To save authors?
|
15:33:29
|
<djazayeri> rfriedman: yeah
|
15:34:01
|
<djazayeri> mvorobey: because if (in profile 1.9) you're depending on openmrs-api version 1.9.0, you *should* be getting the new hiberante
|
15:34:06
|
*** deepagan has joined #openmrs
|
15:34:14
|
<rfriedman> djazayeri, does the account have to have the same name as the author name in svn?
|
15:34:16
|
<downey> Hi deepagan and welcome to the #openmrs IRC channel.
|
15:34:30
|
<rfriedman> djazayeri, or are we talking about authors in the POM?
|
15:34:34
|
<mvorobey> bwolfe, I was trying to do it
|
15:35:23
|
<mvorobey> djazayeri, but came with no success, even when I got new hibernate for tests I got it for compile together
|
15:35:26
|
<djazayeri> rfriedman: authors is only related to this conversation in that that's the reason mvorobey hasn't converted the reporting module from svn to git yet
|
15:35:41
|
<djazayeri> mvorobey: is this committed as a svn branch?
|
15:35:50
|
<mvorobey> djazayeri, no
|
15:35:58
|
<mvorobey> djazayeri, only in my local machine
|
15:36:13
|
<rfriedman> right, I'm just trying to find out how the conversion works. When I said "authors" in svn, I mean committers.
|
15:36:36
|
<djazayeri> mvorobey: if you could commit it somewhere, that would help. :-)
|
15:36:45
|
<djazayeri> mvorobey: or pastebin your whole pom.xml
|
15:36:55
|
<mvorobey> djazayeri, whole poms
|
15:36:55
|
*** deepaganu has quit IRC
|
15:37:03
|
<djazayeri> mvorobey: just the root one, I think
|
15:37:07
|
<mvorobey> nope
|
15:37:13
|
<mvorobey> djazayeri, also api's one
|
15:37:37
|
<djazayeri> rfriedman: I don't know exactly how svn2git works, but I know that if don't provide an author mapping for someone who has committed, it will create a random meaningless hash to represent them.
|
15:37:46
|
<djazayeri> mvorobey: okay
|
15:37:47
|
<mvorobey> djazayeri, but I still can create a patch
|
15:37:50
|
*** lh has joined #openmrs
|
15:37:50
|
*** lh has joined #openmrs
|
15:37:57
|
<mvorobey> djazayeri, is it good ?
|
15:38:17
|
<djazayeri> mvorobey: sure, patch via pastebin would be fine
|
15:38:44
|
<rfriedman> djazayeri, so i have committed as r.friedman, my git account is r-friedman, does that mean I'm destined to become meaningless hash?
|
15:39:13
|
<djazayeri> rfriedman: did you give your git account name on the wiki page or etherpad ben emailed about a few days ago?
|
15:39:23
|
<rfriedman> yeah, i put it on the wiki page
|
15:40:15
|
<rfriedman> actually, I don't think it asked for the git account, it just asked for the e-mail
|
15:40:29
|
<bwolfe> yeah, its all email with github for some reason
|
15:41:06
|
<rfriedman> so r.friedman lives at rdf4@cdc.gov while r-friedman lives at r.friedman@mindspring.com, am i destined for hash?
|
15:41:08
|
<mvorobey> djazayeri, here you go - http://pastebin.com/J6puYv7e
|
15:41:36
|
*** kavuri has quit IRC
|
15:42:12
|
<mvorobey> djazayeri, will be AFK for an hour, thanks for helping me :)
|
15:42:26
|
<deepagan> bwolfe,
|
15:42:27
|
<bwolfe> if that authors page shows all of your svn usernames next to at least one of your github emails, then it will work fine. no hash for you.
|
15:42:49
|
<deepagan> if there any way out in Openmrs to get All Medications
|
15:43:08
|
<rfriedman> bwolfe, think i will add an e-mail to git account
|
15:43:13
|
*** elliott_w has quit IRC
|
15:43:33
|
<rfriedman> bwolfe, but POM author is not an issue?
|
15:43:36
|
<bwolfe> deepagan, all meds in the db? probably something in the ConceptService ?
|
15:43:45
|
<bwolfe> getConceptByClass("Medication") ?
|
15:43:45
|
*** sgithens has quit IRC
|
15:43:50
|
<bwolfe> rfriedman, no
|
15:43:53
|
<deepagan> oh great !!
|
15:43:56
|
<bwolfe> git knows nothing of maven
|
15:44:06
|
<rfriedman> it's all one big blob to git
|
15:44:09
|
<deepagan> so does the same exists for lab too
|
15:44:35
|
<bwolfe> probably
|
15:44:51
|
<bwolfe> its just a "concept class"
|
15:44:51
|
<deepagan> Also is there any way to group the concepts and say all these belong to social history category
|
15:44:53
|
<rfriedman> deepagan, but not as well organized, probably
|
15:45:09
|
<djazayeri> deepagan: what project is this?
|
15:45:17
|
<bwolfe> you set the concept's class to Lab or you set it to Medication when you define it. then you can just get Context.getConceptService().getConceptByClass
|
15:45:18
|
<deepagan> my problem is i need to export all the data in the form CCD
|
15:45:32
|
<bwolfe> bbl
|
15:45:45
|
<djazayeri> deepagan: for something like a social history category, you'd presumably use a concept set.
|
15:46:26
|
<deepagan> ok , so anyone who adds a new field in the social history would have to group it together
|
15:47:04
|
*** robbyoconnor has joined #openmrs
|
15:47:04
|
*** ChanServ sets mode: +v robbyoconnor
|
15:47:39
|
*** mvorobey has quit IRC
|
15:49:41
|
*** bwolfe has quit IRC
|
15:50:22
|
<deepagan> but the concept set would change from one implementation to another , isntit bw
|
15:50:36
|
<deepagan> djazayeri,
|
15:53:37
|
<djazayeri> deepagan: yeah, you'd have to have a configuration setting that indicates _which_ set it is
|
15:54:31
|
*** jordank has joined #openmrs
|
16:00:51
|
<rfriedman> jordank, very nice presentation and work so far
|
16:01:47
|
<jordank> hi rfriedman, thank you!
|
16:03:13
|
*** bwolfe has joined #openmrs
|
16:03:13
|
*** ChanServ sets mode: +o bwolfe
|
16:03:28
|
*** suranga has joined #openmrs
|
16:03:28
|
*** ChanServ sets mode: +v suranga
|
16:03:50
|
<suranga> bwolfe, he heee
|
16:04:03
|
<suranga> bwolfe, seee, now we are tying to move on with hl7 output (hopefully)
|
16:04:34
|
<kreddy> Hi suranga,
|
16:04:41
|
<suranga> hi kreddy
|
16:05:41
|
<kreddy> suranga, was going through your email about HL7 output
|
16:06:02
|
<suranga> kreddy, cool. am hoping to get some intrest going in this :)
|
16:07:14
|
*** cpower has quit IRC
|
16:07:17
|
<kreddy> suranga, I reached out to you last week to talk about this and after that i got tied to other things
|
16:07:27
|
*** magoo_ has quit IRC
|
16:07:58
|
<kreddy> suranga, i was thinking of having a design discussion on this next week's design call
|
16:08:00
|
<suranga> kreddy, yep, I saw you had buzzed me a while back...
|
16:08:11
|
<suranga> kreddy, any plans on helping us out ? :)
|
16:08:23
|
<kreddy> suranga, yeah sure
|
16:08:33
|
<suranga> kreddy, oohoo... let me see... on wednesday, right ?
|
16:08:41
|
<kreddy> suranga, yes
|
16:08:52
|
<kreddy> 2-4PM EST
|
16:09:59
|
*** goutham has joined #openmrs
|
16:10:22
|
<suranga> kreddy, oooops
|
16:10:27
|
<kreddy> suranga, If people are interested in this topic and decide to have a sprint on this topic, would you be willing to lead this sprint?
|
16:10:55
|
<kreddy> Its not that we have to do it next week, we can schedule it later too, suranga
|
16:11:06
|
<suranga> kreddy, umm.. me lead a sprint ?
|
16:11:16
|
<kreddy> suranga, yes
|
16:11:36
|
<suranga> kreddy, mm.... i'd love to do that... but this will be my very first time with such a big responsibility :)
|
16:11:58
|
<suranga> kreddy, about the call...
|
16:11:59
|
<kreddy> suranga, great
|
16:12:38
|
<suranga> kreddy, its like this, so I live in a very rural area, with terrible network connectivity... i have trouble making it to calls because of this problem...
|
16:13:04
|
*** deepagan has quit IRC
|
16:13:04
|
<suranga> kreddy, I usually make it to some calls via an internet cafe... but 2 PM EST is rather late, im afraid ....
|
16:13:28
|
<kreddy> suranga, ok
|
16:15:44
|
<kreddy> suranga, lets see how the discussion goes on the mailing lists and then we can decide about the design call
|
16:16:15
|
<suranga> kreddy, naturally, I would like to have a design call as soon as possible :)
|
16:17:09
|
<kreddy> suranga, who all are the key persons that needs to be involved in this design discussion?
|
16:17:28
|
<suranga> kreddy, aha...
|
16:17:31
|
<suranga> kreddy, kreddy, of course, I have very little to bring to a discussion table... so we should make sure that djazayeri , bwolfe
|
16:17:39
|
<suranga> Dr. Burke, Dr. Paul
|
16:17:54
|
<suranga> kreddy, its also great if we can have Dr. Shaun on the call too
|
16:18:19
|
<suranga> kreddy, and also, maybe Bill Lober ? I see that he has experiance doing this ?
|
16:18:27
|
<kreddy> anyone from jembi?
|
16:18:38
|
<suranga> kreddy, I was thinking of that
|
16:18:51
|
<suranga> kreddy, I will talk to my people, to see who will turn up
|
16:19:19
|
<kreddy> ok, Thanks. suranga
|
16:19:57
|
<suranga> kreddy, what have you got on your mind ? will you be trying to set up a meeting ?
|
16:21:04
|
<kreddy> suranga, yes. First have a discussion on the topic and then decide to schedule a sprint sometime in early august
|
16:21:54
|
<suranga> kreddy, very nice. but its great if we can have all the above mentioned people at the discussion table, because their input will be really really useful ! :)
|
16:22:36
|
<kreddy> suranga, sure i will try to coordinate them
|
16:23:17
|
<suranga> kreddy, thanks for helping out. this would be very cool
|
16:23:54
|
<kreddy> suranga, thanks for the input
|
16:25:41
|
*** jordank has quit IRC
|
16:26:25
|
*** cpower has joined #openmrs
|
16:26:51
|
*** mvorobey has joined #openmrs
|
16:33:54
|
*** mvorobey has quit IRC
|
16:41:31
|
*** djazayeri1 has joined #openmrs
|
16:42:14
|
*** mac___ has joined #openmrs
|
16:42:17
|
<mac___> hi
|
16:42:20
|
<downey> Hi mac___ and welcome to the #openmrs IRC channel.
|
16:42:51
|
*** mac___ has quit IRC
|
16:43:49
|
*** djazayeri has quit IRC
|
16:44:57
|
<rfriedman> bwolfe, who is on bug fix swim lane this week?
|
16:46:38
|
*** djazayeri1 has quit IRC
|
16:46:44
|
<rfriedman> rafa, heard you went to a concert last night, your mind is probably still all electronic, but if you can talk, could you answer my prev q to bw
|
16:46:49
|
*** djazayeri has joined #openmrs
|
16:46:49
|
*** ChanServ sets mode: +o djazayeri
|
16:47:19
|
<rafa> rfriedman: I'm bug fixing
|
16:47:20
|
*** dkayiwa has quit IRC
|
16:47:21
|
*** mvorobey has joined #openmrs
|
16:47:45
|
<rafa> rfriedman: it was Gallagher's concert ;)
|
16:47:55
|
<rafa> rfriedman: not electronic at all ;)
|
16:48:10
|
<rfriedman> rafa, great, could you please look at trunk-3409, sandeep has been trying to get a code review for a while on it
|
16:48:22
|
<rafa> !ticket TRUNK-3409
|
16:48:25
|
<OpenMRSBot> rafa: [#TRUNK-3409] Problem with junit and authorization testing - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3409
|
16:48:48
|
<rfriedman> rafa, he has tried to create one in crucible but an error gets thrown when he tries to link to the jira issue
|
16:51:23
|
<rafa> rfriedman: crucible code review is not really needed ;) it's a one-liner
|
16:51:40
|
<rfriedman> ah, but what a line!!
|
16:52:25
|
*** venkaban has joined #openmrs
|
16:52:27
|
<rafa> rfriedman: haha true :)
|
16:52:32
|
<venkaban> bwolfe, Hi
|
16:52:44
|
<rafa> rfriedman: I'll take care of that, thx
|
16:52:49
|
<venkaban> bwolfe, I have ran unit tests for html form entry module successfully yesterday
|
16:52:52
|
<rfriedman> rafa, tks
|
16:53:11
|
<venkaban> bwolfe, but when i try to run for multiple versions then I am facing some problem
|
16:53:23
|
*** rfriedman is now known as r_friedman_away
|
16:53:53
|
<venkaban> bwolfe, Can you please tell me where find the list of all version of OpenMRS to test against like 1.6 and so on?
|
16:55:49
|
*** djazayeri has quit IRC
|
16:56:02
|
<r_friedman_away> venkaban, b wolfe may not actually be here now, said he was going away for a while
|
16:56:23
|
<venkaban> r_friedman_away, thank you
|
16:57:31
|
<venkaban> r_friedman_away , Do you know about the list of all versions in OpenMRS, like where to find it?
|
16:58:05
|
<r_friedman_away> i know there is a wiki page/pages with release notes for each version, so search for "release notes"
|
17:00:10
|
*** djazayeri has joined #openmrs
|
17:00:10
|
*** ChanServ sets mode: +o djazayeri
|
17:00:50
|
<venkaban> ok
|
17:04:36
|
*** goutham has quit IRC
|
17:07:45
|
<r_friedman_away> rafa, 1.8 head fails testing: Tests in error:
|
17:07:45
|
<r_friedman_away> shouldSaveLastExecutionTime(org.openmrs.scheduler.SchedulerServiceTest)
|
17:07:59
|
<r_friedman_away> have you seen a report on this?
|
17:08:06
|
<rafa> r_friedman_away: it's a random failure :)
|
17:08:13
|
<rafa> r_friedman_away: try running again
|
17:08:23
|
<rafa> r_friedman_away: actually let's ticket that
|
17:08:28
|
<r_friedman_away> ok will do
|
17:08:38
|
<r_friedman_away> but right now must must go
|
17:09:20
|
<rafa> r_friedman_away: acutally it may have been resolved
|
17:09:22
|
<rafa> r_friedman_away: https://tickets.openmrs.org/browse/TRUNK-1964
|
17:09:27
|
<rafa> r_friedman_away: just needs back porting
|
17:10:37
|
<mvorobey> djazayeri, hey, any good news ?
|
17:11:02
|
<djazayeri> mvorobey: no
|
17:11:13
|
<djazayeri> mvorobey: why are you explicitly including hibernate in the reporting pom?
|
17:11:25
|
<djazayeri> it should just get that from openmrs-api
|
17:11:39
|
<mvorobey> djazayeri, to override it in 1.9
|
17:12:01
|
<djazayeri> mvorobey: the idea is that when you run with the openmrs-1.9 profile, that should *automatically* happen
|
17:12:17
|
<djazayeri> because it changes the value of the openmrsVersion, thus including OpenMRS 1.9
|
17:13:04
|
*** harshadura has quit IRC
|
17:13:06
|
<rafa> djazayeri: are we first moving things to git and then mavenizing?
|
17:13:12
|
<mvorobey> djazayeri, but how ? Openmrs1.9 has hibernate 3.6.5, which is bad for compilation
|
17:13:17
|
<djazayeri> rafa: mavenized already
|
17:13:36
|
<djazayeri> mvorobey: ah, okay, I get it
|
17:13:43
|
<mvorobey> djazayeri, :)
|
17:13:43
|
<rafa> djazayeri: hmmm not good git is better at recognizing moving files around :(
|
17:14:03
|
<djazayeri> rafa: talk to bwolfe about that decision. :-)
|
17:14:05
|
<mvorobey> djazayeri, the main problem is how to use one version for build and another for tests
|
17:14:12
|
<djazayeri> mvorobey: I understand now.
|
17:14:24
|
<mvorobey> djazayeri, :)
|
17:14:25
|
<djazayeri> mvorobey: I don't know if that's possible
|
17:14:29
|
<djazayeri> mvorobey: it probably is not.
|
17:15:08
|
<djazayeri> mvorobey: what are the compile failures against 1.9 (and hibernate 3.6)?
|
17:15:16
|
<mvorobey> djazayeri, I tried to set compile for 3.2.5 and runtime for 3.6.5
|
17:15:31
|
<djazayeri> mvorobey: I know what you tried to do, but I don't think maven will make that possible.
|
17:15:41
|
<mvorobey> djazayeri, that isbasic method on TypeFactory
|
17:15:54
|
<mvorobey> isbasic = is basic
|
17:16:09
|
<djazayeri> mvorobey: can you pastebin the snippet of code?
|
17:16:11
|
<mvorobey> TypeFactory.basic()
|
17:16:18
|
<djazayeri> mvorobey: IIRC the code is set up so that it does:
|
17:16:21
|
<djazayeri> try {
|
17:16:25
|
<djazayeri> do something against 3.3
|
17:16:29
|
<djazayeri> } catch (Exception) {
|
17:16:36
|
<djazayeri> do something against 3.6 via reflection
|
17:16:36
|
<djazayeri> }
|
17:16:37
|
<djazayeri> right?
|
17:16:50
|
<djazayeri> if so, maybe the 3.3 case can also be done by reflection, so it doesn't need to compile?
|
17:17:25
|
<mvorobey> djazayeri, yes, right
|
17:17:40
|
<mvorobey> djazayeri, may be
|
17:17:53
|
<mvorobey> djazayeri, need to test it
|
17:18:40
|
<venkaban> djazayeri, Hey do we have any info about the list of versions in OpenMRS anywhere in wiki?
|
17:18:53
|
<mvorobey> djazayeri, testing it know
|
17:19:42
|
<djazayeri> venkaban: https://wiki.openmrs.org/x/SAEr
|
17:19:57
|
<djazayeri> venkaban: see also the page for EOL or End Of Life
|
17:20:02
|
*** dkayiwa has joined #openmrs
|
17:20:27
|
<venkaban> djazayeri, thank you
|
17:21:43
|
<rafa> downey: how to trigger a CI build manually?
|
17:22:30
|
<downey> rafa: you should be able to log in and click the "play" button
|
17:22:39
|
<downey> rafa: trunk unit tests?
|
17:22:45
|
<rafa> downey: yes
|
17:22:50
|
<rafa> downey: I'm logged in
|
17:22:56
|
<rafa> downey: I don't see any play button
|
17:23:43
|
<rafa> downey: sorry 1.9.x unit tests
|
17:24:19
|
<downey> rafa: reload page
|
17:24:42
|
<rafa> downey: there it is, thanks!
|
17:25:07
|
*** elliott_w has joined #openmrs
|
17:25:07
|
*** ChanServ sets mode: +o elliott_w
|
17:25:56
|
<mvorobey> djazayeri, I got Caused by: java.lang.ClassNotFoundException: org.hibernate.type.TypeResolver, reflection did not work with 1.6
|
17:26:23
|
<djazayeri> mvorobey: code snippet please
|
17:27:18
|
<mvorobey> djazayeri, http://pastebin.com/4hXXx2bt
|
17:30:51
|
<djazayeri> mvorobey: remind me where this lives in reporting?
|
17:31:50
|
<mvorobey> djazayeri, org.openmrs.module.reporting.common.HibernateUtil.getBasicType(String, Properties)
|
17:32:13
|
<djazayeri> mvorobey: typeresolver is in hibernate 3.6, right?
|
17:32:37
|
*** robbyoconnor has quit IRC
|
17:32:39
|
<djazayeri> mvorobey: did you try to run this code snippet for the normal build against openmrs 1.6?
|
17:32:41
|
<djazayeri> that will fail
|
17:32:46
|
<mvorobey> djazayeri, if you wanted to know the project, then it's a api, and yes typeresolver is 3.6
|
17:33:36
|
<djazayeri> mvorobey: the point is that we still need to have two branches, the first where we try TypeFactory, the next where we try TypeResolver
|
17:34:23
|
<djazayeri> mvorobey: but since we want to be able to compile against both hibernate 3.3 and 3.6, both of those branches of code need to use reflection instead of referring to the classes directly
|
17:35:03
|
<mvorobey> djazayeri, did I say that you are genius ? :)
|
17:35:59
|
*** jordank has joined #openmrs
|
17:36:19
|
<wyclif> hi djazayeri
|
17:36:50
|
<djazayeri> mvorobey: new version of pastebin here: http://pastebin.com/cuXBdDYQ
|
17:36:59
|
<djazayeri> mvorobey: obviously replace "something" with the right package
|
17:37:03
|
<djazayeri> I assume this should work
|
17:37:05
|
<djazayeri> wyclif: hi
|
17:38:16
|
<wyclif> djazayeri, when writing a test for editing an obs in hfe, how set the mode to edit? also how do i specify the existing obs being edited
|
17:39:05
|
<djazayeri> wyclif: off the top of my head I don't remember, and my eclipse seems dead
|
17:39:14
|
<djazayeri> wyclif: look at the RegressionTests class
|
17:39:38
|
<djazayeri> wyclif: but the idea is that you have to do it via html, not by specifying an actual obs to edit in code
|
17:40:08
|
<mvorobey> djazayeri, thanks, but I think it's better to catch Exception in first branch instead of NoSuchMethodError
|
17:40:30
|
<djazayeri> mvorobey: clean it up as necessary :-)
|
17:40:39
|
<djazayeri> I agree. Exception in first branch
|
17:43:14
|
<mvorobey> djazayeri, thanks, it was really big pleasure to work with you :_
|
17:43:21
|
<mvorobey> :_ = :)
|
17:44:32
|
<djazayeri> mvorobey: happy to help
|
17:47:23
|
*** james_regen has left #openmrs
|
17:49:00
|
<mvorobey> djazayeri, it would be as is if I'd be only one who asks you for help at the moment, but there are lot of such guys as me, who needs help from Darius Jazayeri, and it can be difficult for him to provide a help for all us :) so am appreciate that he happy to help me :)
|
17:57:22
|
<Jibesh> hi suranga
|
17:59:00
|
<mvorobey> djazayeri, I have to change code you've pasted in order to call static method basic, just a little FYI
|
18:00:53
|
*** bwolfe has quit IRC
|
18:02:59
|
<mvorobey> have to = had to
|
18:08:33
|
*** mvorobey has quit IRC
|
18:10:01
|
*** mvorobey has joined #openmrs
|
18:12:28
|
<mvorobey> djazayeri, hey, you there ?
|
18:15:46
|
<djazayeri> mvorobey: on a call
|
18:16:02
|
*** lakkarau has joined #openmrs
|
18:16:15
|
*** kavuri has joined #openmrs
|
18:16:20
|
*** bwolfe has joined #openmrs
|
18:16:20
|
*** ChanServ sets mode: +o bwolfe
|
18:16:30
|
<mvorobey> djazayeri, sorry
|
18:16:39
|
<djazayeri> you can ask, i just might not answer
|
18:17:00
|
<mvorobey> djazayeri, later
|
18:17:21
|
<mvorobey> bwolfe, hey
|
18:17:50
|
<bwolfe> yessir?
|
18:17:53
|
<mvorobey> bwolfe, I did everything as you said - wrote inner mock that extends EncounterType and overrides toString() with call of getGlobalPropertyObject(), wrote a test that saves mock auditable using encounter service, but did not reproduce and error with recursion, even did not enter into failing method on AuditableInterceptor ...
|
18:19:46
|
<mvorobey> and overrides = that overrides
|
18:20:14
|
<bwolfe> mvorobey, did you take out your fix?
|
18:20:21
|
<bwolfe> and did you turn up debugging?
|
18:20:58
|
*** kishoreyekkanti has joined #openmrs
|
18:21:39
|
*** Jibesh has left #openmrs
|
18:21:47
|
<mvorobey> bwolfe, nope, debug was turned on but thread did not stopped at break point
|
18:22:06
|
<bwolfe> well then debugging wasn't really on. :-p
|
18:22:14
|
<mvorobey> did not stopped = did not stop
|
18:22:45
|
*** kishoreyekkanti_ has joined #openmrs
|
18:23:03
|
<mvorobey> bwolfe, no, it was, I even got no mapping for class MockEncounter type found
|
18:23:13
|
<mvorobey> exception
|
18:23:31
|
<bwolfe> I mean the log level set to DEBUG, sorry. mixing of terms
|
18:23:47
|
<bwolfe> you can set the log level with a call in OpenmrsUtil I think
|
18:24:30
|
*** venkaban has quit IRC
|
18:25:13
|
<mvorobey> bwolfe, by the way, here is a snippet of test: http://pastebin.com/XgrT5s6x
|
18:25:19
|
*** kishoreyekkanti has quit IRC
|
18:26:45
|
<bwolfe> mvorobey, maybe you have to have something to flush to the db as well? maybe hibernate is smart enough to not try to flush if there is nothing to flush
|
18:26:46
|
<mvorobey> bwolfe, considering with javadoc on onFlushDirty() method of AuditableInterceptor it even should not have to be called in my test
|
18:27:07
|
<bwolfe> so you have to get your object from the db as well, that will be harder to mock
|
18:27:08
|
<mvorobey> bwolfe, figures
|
18:27:55
|
<mvorobey> bwolfe, so, may be we do not need such a hard test for such a simple fix, do we ?
|
18:29:13
|
<bwolfe> yeah, you can skip for now
|
18:29:36
|
<bwolfe> but I will ask you to backport. do you have 1.9.x/1.8.x/1.7.x branches checked out?
|
18:30:34
|
<mvorobey> bwolfe, ok, just wanted to ask you to give me guidelines on backporting, and, yes I have those branches
|
18:31:50
|
<bwolfe> mvorobey, backporting is the same. just make the same change in those and commit
|
18:32:31
|
<mvorobey> bwolfe, I just thought that there is something special in openmrs with this :)
|
18:33:22
|
<bwolfe> nope
|
18:33:25
|
<bwolfe> easy peasy
|
18:33:56
|
<mvorobey> :D
|
18:38:53
|
<mvorobey> bwolfe, I added @should in order not to forget to right that painful test in future :)
|
18:39:06
|
<bwolfe> :-)
|
18:39:06
|
<mvorobey> right = wright
|
18:39:18
|
*** kishoreyekkanti_ has quit IRC
|
18:39:33
|
<bwolfe> *write
|
18:40:49
|
*** Venkaban has joined #openmrs
|
18:41:13
|
<mvorobey> bwolfe, ah, a lot of consonant words :)
|
18:49:41
|
*** jordank has quit IRC
|
18:50:04
|
<Venkaban> bwolfe, is there a way to download the jar for openmrs 1.7.1 version manually?
|
18:50:25
|
<Venkaban> bwolfe, for openmrs-api 1.7.1
|
18:51:32
|
*** bwolfe has quit IRC
|
18:51:39
|
*** bwolfe has joined #openmrs
|
18:51:39
|
*** ChanServ sets mode: +o bwolfe
|
18:51:59
|
<bwolfe> Venkaban, you could download from nexus.openmrs.org or from sourceforge.
|
18:52:08
|
<Venkaban> ok
|
18:52:37
|
<djazayeri> interestingly, 1.7.1 isn't there
|
18:52:40
|
<djazayeri> but 1.7.2 is at http://mavenrepo.openmrs.org/nexus/content/repositories/public/org/openmrs/api/openmrs-api/1.7.2/
|
18:52:54
|
<Venkaban> ohhhhhh
|
18:53:12
|
<Venkaban> djazayeri, so what could be the next step then for 1.7.1?
|
18:53:14
|
*** jordank has joined #openmrs
|
18:53:24
|
<djazayeri> what does 1.7.1 have to do with anything?
|
18:53:28
|
<downey> dkayiwa++
|
18:53:48
|
<djazayeri> you want to test against every individual version?
|
18:53:48
|
<dkayiwa> downey: about??? :)
|
18:53:53
|
<downey> dkayiwa: dev list
|
18:53:56
|
<bwolfe> djazayeri, its trying to get htmlformentry to compile/test against 1.7.1
|
18:54:01
|
<dkayiwa> downey: hahahaha :)
|
18:54:03
|
<djazayeri> hmm, I was assuming you'd test against the _latest_ of each supported line
|
18:54:07
|
<djazayeri> bwolfe: what's the actual goal?
|
18:54:25
|
<bwolfe> Venkaban, maven will download it for you magically when you try to compile with the -Popenmrs-1.7 parameter
|
18:54:36
|
<bwolfe> yes, should be latest
|
18:54:39
|
<Venkaban> bwolfe, let me try that now
|
18:55:07
|
*** kavuri has quit IRC
|
18:55:26
|
*** jordank has quit IRC
|
18:58:29
|
*** mvorobey has quit IRC
|
19:00:39
|
*** mvorobey has joined #openmrs
|
19:02:48
|
<Venkaban> bwolfe, scrum time?
|
19:03:51
|
<bwolfe> scrum time
|
19:04:00
|
<bwolfe> is cpower around?
|
19:05:01
|
<bwolfe> I take that as a no...
|
19:05:39
|
<bwolfe> ok, I'll run it
|
19:05:49
|
<bwolfe> !scrumon
|
19:05:49
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster - you may begin when ready.
|
19:06:18
|
<bwolfe> todays order: dkayiwa, wyclif, djazayeri, Venkaban, lakkarau, bwolfe, wyclif
|
19:06:33
|
<bwolfe> and mvorobey last. (sorry mykola)
|
19:06:38
|
<mvorobey> :)
|
19:07:00
|
*** kavuri has joined #openmrs
|
19:07:05
|
<rafa> bwolfe: I'm around too :)
|
19:07:18
|
<bwolfe> ok, now rafa is last.
|
19:07:33
|
<bwolfe> any other sprinters here? perhaps kreddy?
|
19:08:01
|
<bwolfe> dkayiwa, are you ready?
|
19:08:15
|
<dkayiwa> Edited some xforms tickets and assigned them hours
|
19:08:15
|
<dkayiwa> Done some commits and blocked on a question for: Multiple version testing in reporting compatibility module - RCM-85
|
19:08:16
|
<dkayiwa> Design Call
|
19:08:16
|
<dkayiwa> Dev Call
|
19:08:16
|
<dkayiwa> Still fighting with RCM-85 (Multiple version testing in reporting compatibility module) & SXS-11 (Multiple version testing in serialization xstream module) for some openmrs versions
|
19:08:16
|
<dkayiwa> No Blockers
|
19:08:48
|
<wyclif> Wednesday:
|
19:08:48
|
<wyclif> Spent a couple of hours trying to figure out/blocked by git fork workflows
|
19:08:48
|
<wyclif> Re apply fixes to HFE tckets to my fork
|
19:08:48
|
<wyclif> complete HTML-176 - includeIf velocityTest: evaluate the $patient.age as a number doesn't work.
|
19:08:48
|
<wyclif> design call
|
19:08:49
|
<wyclif> Thursday:
|
19:08:51
|
<wyclif> dev call
|
19:08:53
|
<wyclif> REPORT-383 - On run / schedule report page, allow for expressions to be specified in addition to fixed values
|
19:08:56
|
<wyclif> REPORT-374 - UI pages for creating and managing report processor configurations
|
19:08:58
|
<wyclif>
|
19:09:00
|
<wyclif> Blockers: None
|
19:09:02
|
<mvorobey> * Work-In-Progress - REPORT-404
|
19:09:02
|
<mvorobey> * Committed to trunk TRUNK-3472, need to backport to 1.9x/1.8.x/1.7x branches
|
19:09:02
|
<mvorobey> * No blockers, already
|
19:09:23
|
<djazayeri> Wednesday 20-Jun-2012
|
19:09:23
|
<djazayeri> * University call
|
19:09:23
|
<djazayeri> * TW Catchup call
|
19:09:23
|
<djazayeri> * I-TECH Kenya call
|
19:09:23
|
<djazayeri> * Design call
|
19:09:23
|
<djazayeri> * Another TW catchup call (too many TWers out there)
|
19:09:23
|
<djazayeri> * emailed people about when we’ve scheduled them for University calls
|
19:09:24
|
<djazayeri> Thursday 21-Jun-2012
|
19:09:25
|
<djazayeri> * Dev Forum
|
19:09:26
|
<djazayeri> * Leadership call
|
19:09:26
|
<djazayeri> * Call with PIH about UX for Mirebalais Hospital project
|
19:09:26
|
<djazayeri> * I-TECH work (finish off with idgen, work more with calculation)
|
19:09:27
|
<djazayeri> no blockers
|
19:09:50
|
<Venkaban> Resolved Git and completed HTML 357
|
19:09:57
|
<Venkaban> Design call and Dev Call
|
19:10:04
|
<Venkaban> Working on HTML 355
|
19:10:09
|
<Venkaban> No Blockers
|
19:10:34
|
*** cpower has quit IRC
|
19:10:40
|
<bwolfe> !ticket HTML-357
|
19:10:42
|
<OpenMRSBot> bwolfe: [#HTML-357] Verify unit tests are working in HTML Form Entry Extensions module after mavenization - OpenMRS JIRA - https://tickets.openmrs.org/browse/HTML-357
|
19:10:45
|
<rafa> anyone following the order? :D
|
19:10:51
|
<lakkarau> working on the trunk-3328
|
19:11:09
|
<bwolfe> rafa, wyclif was in there twice, sorry
|
19:11:18
|
<bwolfe> lakkarau, any blockers?
|
19:11:38
|
<bwolfe> by definition, since you've been working on that same ticke tsince yesterday, there must be a blocker
|
19:11:49
|
<bwolfe> anything that stumps you for more than a few hours should be a blocker
|
19:12:57
|
<lakkarau> checking the code looks fine and the test fails.
|
19:13:10
|
<lakkarau> figuring out where the error is
|
19:13:13
|
<bwolfe> !ticket TRUNK-3328
|
19:13:14
|
<OpenMRSBot> bwolfe: [#TRUNK-3328] Searching for concepts by name throws an NPE - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3328
|
19:13:38
|
<bwolfe> so you have created a unit test, and now you just need to modify ConceptServiceImpl?
|
19:13:47
|
<lakkarau> yes
|
19:13:50
|
<bwolfe> control-shift-t in eclipse is your friend
|
19:14:14
|
<bwolfe> my update:
|
19:14:22
|
<bwolfe> Wednesday
|
19:14:22
|
<bwolfe> reviewed sprint tickets by daniel
|
19:14:22
|
<bwolfe> htmlformentry in ci
|
19:14:22
|
<bwolfe> univ call
|
19:14:22
|
<bwolfe> started mavenizing xforms, on pause for now
|
19:14:23
|
<bwolfe> design call
|
19:14:25
|
<bwolfe> pm call?
|
19:14:27
|
<bwolfe> triaged a couple of tickets
|
19:14:28
|
<lakkarau> java assest is not working in my system
|
19:14:29
|
<bwolfe> unassigned intro tickets
|
19:14:31
|
<bwolfe> Thursday
|
19:14:33
|
<bwolfe> reviewed rafal's role ticket
|
19:14:35
|
<bwolfe> get htmlformentry testing in ci
|
19:14:37
|
<bwolfe> dev call
|
19:14:39
|
<bwolfe> leaderhsip call
|
19:14:41
|
<bwolfe> review daniel's sprint tickets
|
19:14:43
|
<bwolfe> blocker is 1.8.x testing in ci for main htmlformentry module. not playing nicely. :-(
|
19:14:54
|
<bwolfe> lakkarau, ok, lets discuss htat after
|
19:15:07
|
<bwolfe> thats a good valid blocker. :-)
|
19:15:13
|
<lakkarau> ok
|
19:15:30
|
<bwolfe> mvorobey already went...so rafa?
|
19:15:40
|
<rafa> right
|
19:15:43
|
<rafa> Today:
|
19:15:43
|
<rafa> * In Progress TRUNK-3448 Locale with country does not work
|
19:15:43
|
<rafa> * Closed TRUNK-3409 Problem with junit and authorization testing
|
19:15:43
|
<rafa> * In Progress TRUNK-3469 Incompatibility with postgresql -- data type double should be "double precision" for postgresql
|
19:15:43
|
<rafa> * Closed TRUNK-3470 Facilitate testing controllers
|
19:15:44
|
<rafa> * Code Review (Post-Commit) TRUNK-3443 Remove sessionForm=true from spring definition file
|
19:15:44
|
<rafa> * Closed TRUNK-3437 Cannot edit a role
|
19:15:45
|
<rafa> No blockers.
|
19:16:37
|
<mvorobey> bwolfe, sorry, you said I'll be last, I saw that it is after wyclif, but you put him twice :)
|
19:17:01
|
<bwolfe> rafa, remember as the bug fixer this week you should review current patches and post-commit things. the 2nd two columns on the bgu fixing swim lane dashboard
|
19:17:41
|
*** sgithens has joined #openmrs
|
19:17:44
|
<bwolfe> djazayeri, are we doing discussion before or after scrumoff?
|
19:17:55
|
<djazayeri> we have been doing it after
|
19:18:05
|
<djazayeri> (sorry, on phone now)
|
19:18:38
|
<rafa> bwolfe: yes, I know, did it for TRUNK-3443 and TRUNK-3409 ;)
|
19:18:47
|
<bwolfe> rafa++
|
19:18:51
|
<bwolfe> !scrumoff
|
19:18:51
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
19:18:56
|
<bwolfe> discussion points:
|
19:18:56
|
<bwolfe> dkayiwa: RCM-85 and SXS-11
|
19:18:56
|
<bwolfe> wyclif: remember that reporting will be githubbed soon. ddi you not want to work
|
19:18:56
|
<bwolfe> on HTML first?
|
19:18:56
|
<bwolfe> lakkarau: java assist not working?
|
19:18:57
|
<bwolfe> ~
|
19:19:34
|
<bwolfe> dkayiwa, RCM-85, we don't support 1.6 anymore technically. so you COULD just make RCM have a min of 1.7
|
19:19:44
|
<bwolfe> dkayiwa, or just don't test on 1.6 with the "multiple version" stuff
|
19:19:45
|
<dkayiwa> bwolfe: ok
|
19:20:02
|
<wyclif> bwolfe, i though i have to wait to commit?
|
19:20:09
|
<lakkarau> yes bwolfe
|
19:20:16
|
<bwolfe> SXS-11, iterate over the object's methods.
|
19:20:22
|
<wyclif> bwolfe, i will just have to copy over the files like i did for hfe
|
19:20:35
|
<bwolfe> wyclif, correct. but you won't really be able to commit. since it will be on github you will not be able to apply the patch the same way
|
19:20:47
|
<bwolfe> wyclif, you will need to redo whatever you've fixed. not too much of an issue I suppose
|
19:20:49
|
<dkayiwa> bwolfe: and then???
|
19:21:07
|
<dkayiwa> SXS-11
|
19:21:15
|
<bwolfe> dkayiwa, err, wait
|
19:21:26
|
<wyclif> bwolfe, i will have to copy the files over to the new projec checkeout from git
|
19:21:44
|
<wyclif> bwolfe, and then commit to my reporting fork
|
19:22:02
|
<bwolfe> dkayiwa, serialize the object, then deserialize the resulting output string and make sure all values are the same by iterating over the methods/attrs on the object. I think thats what mseaton suggested
|
19:22:10
|
<bwolfe> wyclif, correct. :-)
|
19:22:18
|
<lakkarau> bwolfe:java assist is not working on my system
|
19:22:29
|
<bwolfe> we just need to get Lu and Rita usernames on github
|
19:22:29
|
<dkayiwa> bwolfe: ok
|
19:22:44
|
<bwolfe> then mvorobey can push to the reporting master
|
19:22:50
|
<dkayiwa> bwolfe: does that mean i need to redo all the tests? :)
|
19:23:12
|
<mvorobey> bwolfe, yes, I can
|
19:23:13
|
<bwolfe> mvorobey, I think I will just create Rita's account. I'm not sure what to do about Lu. There is a small chance he already has an account, but I don't see it via searching, so I might just make his too. :-)
|
19:23:34
|
<bwolfe> dkayiwa, it would mean make one generic test, then you can remove all those hard coded ones
|
19:23:47
|
<dkayiwa> bwolfe: ok
|
19:23:47
|
<mvorobey> bwolfe, good, let me know then
|
19:24:31
|
*** rafa has quit IRC
|
19:26:16
|
<bwolfe> brb, getting low on battery power
|
19:26:17
|
*** sgithens has quit IRC
|
19:27:09
|
*** kavuri has quit IRC
|
19:29:11
|
*** mvorobey has quit IRC
|
19:31:02
|
*** bwolfe has quit IRC
|
19:35:09
|
*** bwolfe has joined #openmrs
|
19:35:09
|
*** ChanServ sets mode: +o bwolfe
|
19:36:39
|
*** mvorobey has joined #openmrs
|
19:39:33
|
*** bwolfe has quit IRC
|
19:40:42
|
*** bwolfe has joined #openmrs
|
19:40:42
|
*** ChanServ sets mode: +o bwolfe
|
20:05:22
|
*** robbyoconnor has joined #openmrs
|
20:05:22
|
*** ChanServ sets mode: +v robbyoconnor
|
20:16:06
|
<Venkaban> bwolfe, when i run this command mvn -DopenMRSVersion=1.7.1 test, it said the profile for 1.7.1 is not recognized and the test execution failed when it tried to unpack
|
20:17:06
|
<bwolfe> try "install" instead of "test"
|
20:17:10
|
<Venkaban> ok
|
20:17:16
|
<bwolfe> and just use -Popenmrs-1.7
|
20:17:16
|
*** mccallumg has joined #openmrs
|
20:17:16
|
*** ChanServ sets mode: +v mccallumg
|
20:17:20
|
<bwolfe> mvn install -Popenmrs-1.7
|
20:17:36
|
<Venkaban> ok
|
20:21:50
|
<Venkaban> it should be -PopenMRSVersion-1.7.1 in the above command right?
|
20:22:01
|
<Venkaban> bwolfe, it should be -PopenMRSVersion-1.7.1 in the above command right?
|
20:22:27
|
<djazayeri> Venkaban: I'm pretty sure just 1.7. (It's the id of the profile in pom.xml)
|
20:22:42
|
<Venkaban> djazayeri, oh ok
|
20:25:13
|
<bwolfe> Venkaban, reread the wiki page for the multiple versions
|
20:25:24
|
<bwolfe> there is a difference between -P and -D
|
20:25:29
|
<bwolfe> and used for diff things
|
20:25:35
|
<bwolfe> (and sometimes together)
|
20:25:47
|
<wyclif> hi djazayeri
|
20:25:54
|
<djazayeri> hi wyclif
|
20:26:23
|
*** suranga_ has joined #openmrs
|
20:26:28
|
<wyclif> djazayeri, in HFE, is there a tag handler for velocity tags or it is handled by the velocity engine?
|
20:26:45
|
<djazayeri> wyclif: there's the <lookup> tag
|
20:27:01
|
<djazayeri> within velocity itself, things are handled by the velocity engine
|
20:27:06
|
<djazayeri> #if# etc
|
20:28:12
|
*** suranga has quit IRC
|
20:33:01
|
*** mccallumg has quit IRC
|
20:33:21
|
*** mccallumg has joined #openmrs
|
20:33:21
|
*** ChanServ sets mode: +v mccallumg
|
20:37:50
|
<wyclif> djazayeri, ok
|
20:38:27
|
<wyclif> djazayeri, so the problem is that the form is rejected or the expression doesnt get evaluated as expected?
|
20:39:08
|
<djazayeri> wyclif: the patient.age thing?
|
20:39:30
|
<djazayeri> wyclif: I believe the problem is that the age is being treated as a string
|
20:39:33
|
<djazayeri> not as a number
|
20:39:41
|
<djazayeri> so < and > tests aren't working right
|
20:39:52
|
<djazayeri> wyclif: but it was a very long time ago that I looked at this, so I don't remember exactly
|
20:42:12
|
<Venkaban> djazayeri, when i did "mvn install -PopenMRSVersion-1.7" it says that the profile with id has not been activated
|
20:42:57
|
<djazayeri> Venkaban: that's not right
|
20:42:58
|
<djazayeri> it's:
|
20:43:07
|
<djazayeri> mvn install -Popenmrs-1.7
|
20:43:15
|
<djazayeri> -P gives the name of a *profile*
|
20:43:22
|
<wyclif> djazayeri, ok thanks
|
20:43:25
|
<Venkaban> ok
|
20:43:25
|
<djazayeri> look at line 223 of pom.xml in html form entry
|
20:43:56
|
<djazayeri> it's the profile called "openmrs-1.7", and it has the effect of setting openMRSVersion=1.7.3
|
20:44:58
|
<Venkaban> djazayeri, yeah there are profiles defined
|
20:45:39
|
<Venkaban> djazayeri, to perform the tests it should be only against these profiles right?
|
20:46:13
|
<djazayeri> Venkaban: you want to test HTML Form Entry against the profiles it defines, yes.
|
20:46:13
|
*** suranga_ has quit IRC
|
20:46:56
|
<djazayeri> Venkaban: in the code I have checked out I see it also defines 1.6.3, 1.6.4, etc.
|
20:47:02
|
<djazayeri> bwolfe: what's the goal?
|
20:51:01
|
*** bwolfe has quit IRC
|
20:51:38
|
<wyclif> djazayeri, am realizing that OpenmrsConstants.OPENMRS_VERSION_SHORT is null when running hfe
|
20:56:45
|
*** mvorobey has quit IRC
|
20:57:13
|
<djazayeri> wyclif: when _running_ the module?
|
20:57:24
|
<djazayeri> wyclif: you mean when running with the module installed?
|
20:57:27
|
*** elliott_w has quit IRC
|
20:57:30
|
<djazayeri> wyclif: or do you mean in unit tests?
|
21:00:10
|
<wyclif> djazayeri, running he module in the web app
|
21:00:21
|
<djazayeri> wyclif: that's odd
|
21:00:50
|
<djazayeri> wyclif: I searched the code (at least the version I have checked out) and it never writes to OpenmrsConstants.OPENMRS_VERSION_SHORT
|
21:01:03
|
<Venkaban> djazayeri, Yes they have different profiles setup
|
21:01:53
|
<djazayeri> wyclif: in fact it's final, so it can't be overridden
|
21:02:01
|
<djazayeri> wyclif: I don't see how a module could affect that...
|
21:02:05
|
<djazayeri> wyclif: gotta run and get lunch
|
21:02:56
|
<wyclif> djazayeri, ok thanks
|
21:03:05
|
*** mvorobey has joined #openmrs
|
21:13:56
|
*** dkayiwa_ has joined #openmrs
|
21:16:21
|
*** dkayiwa has quit IRC
|
21:16:21
|
*** dkayiwa_ is now known as dkayiwa
|
21:19:54
|
*** downey has quit IRC
|
21:30:19
|
*** lakkarau has quit IRC
|
21:42:28
|
<Venkaban> djazayeri, Hey when i do mvn clean I am getting an error saying "cant delete ../surefirebooter......jar"
|
21:42:38
|
<Venkaban> djazayeri, any idea on this
|
21:42:45
|
<djazayeri> nope
|
21:43:06
|
<djazayeri> can you manually delete everything from the /target folder?
|
21:44:58
|
*** lakkarau has joined #openmrs
|
21:49:04
|
<Venkaban> yeah
|
21:49:12
|
*** robbyoconnor has quit IRC
|
21:50:23
|
<Venkaban> well no
|
21:50:33
|
<Venkaban> I am going to close all he apps
|
21:50:35
|
<Venkaban> and see
|
21:51:03
|
*** dkayiwa has quit IRC
|
21:52:02
|
*** goutham has joined #openmrs
|
21:53:21
|
*** mvorobey has quit IRC
|
21:55:01
|
*** Venkaban has quit IRC
|
21:56:16
|
*** goutham has quit IRC
|
22:06:26
|
*** wyclif has quit IRC
|
22:27:21
|
*** elliott_w has joined #openmrs
|
22:27:21
|
*** ChanServ sets mode: +o elliott_w
|
22:29:57
|
*** venkaban has joined #openmrs
|
22:38:21
|
*** venkaban has quit IRC
|
22:41:42
|
*** lh has quit IRC
|
22:42:10
|
*** lh has joined #openmrs
|
22:47:16
|
*** venksbsn has joined #openmrs
|
22:48:24
|
*** venkaban has joined #openmrs
|
23:01:52
|
*** wyclif has joined #openmrs
|
23:06:59
|
*** lakkarau has quit IRC
|
23:28:05
|
<mccallumg> anyone on here good with mirth? (djazayeri?) I need to use it to send a file to a restful web service using http post method.
|
23:28:18
|
<djazayeri> mccallumg: I've never used it actually
|
23:28:42
|
<mccallumg> thanks djazayeri
|
23:29:18
|
<mccallumg> djazayeri: I found this old forum post: http://forum.openmrs.org/viewtopic.php?f=24&t=681
|
23:29:24
|
<mccallumg> djazayeri: made me laugh
|
23:30:49
|
<djazayeri> wow, that's a good one
|
23:31:13
|
<djazayeri> I bet he's figured it out by now, though, so if you can track him down, maybe you should ask him. :-)
|
23:32:22
|
<mccallumg> "how can i write the third module???"
|
23:32:26
|
<GDG> wouldn't it just be easier to send the file directly? using mirth sounds like a bulldozer approach?
|
23:33:11
|
<mccallumg> hi GDG: send the file directly from where?
|
23:33:14
|
<djazayeri> Not sure if this is an ongoing discussion, but send the files where?
|
23:33:20
|
<djazayeri> :-)
|
23:33:36
|
<mccallumg> files are going to hQuery gateway
|
23:33:55
|
<mccallumg> http://projecthquery.org/
|
23:34:25
|
<mccallumg> mirth actually does a database read and constructs a CDA document.
|
23:35:17
|
<GDG> uh, you do need a bulldozer then
|
23:36:07
|
<mccallumg> but the mirth http sender "destination" isn't playing nicely with the rails restful web service that hQuery provides. works fine from a browser rest client - just not from mirth.
|
23:40:08
|
<venkaban> wyclif, hi
|
23:40:50
|
<venkaban> wyclif, are you able to run tests for HFE in 1.7?
|
23:41:07
|
<djazayeri> I'm pretty sure Mark said that they were not working in 1.7...
|
23:42:02
|
<wyclif> venkaban, havent tried before
|
23:44:39
|
<venkaban> ok
|
23:44:51
|
*** kreddy has quit IRC
|
23:59:22
|
*** lh has quit IRC
|