01:03:30
|
*** wyclif has joined #openmrs
|
01:03:53
|
*** bwolfe has joined #openmrs
|
01:03:53
|
*** ChanServ sets mode: +o bwolfe
|
01:07:56
|
*** wyclif has quit IRC
|
01:36:00
|
*** rfriedman has quit IRC
|
02:23:23
|
*** mgielow has joined #openmrs
|
03:29:59
|
*** mgielow has quit IRC
|
03:45:25
|
*** bwolfe has quit IRC
|
04:02:13
|
*** maurya has joined #openmrs
|
04:06:27
|
*** ChanServ sets mode: +v maurya
|
04:23:40
|
*** upul` has joined #openmrs
|
04:23:40
|
*** ChanServ sets mode: +v upul`
|
04:33:46
|
*** venkaban has joined #openmrs
|
05:15:16
|
*** applecool has joined #openmrs
|
05:15:16
|
*** ChanServ sets mode: +v applecool
|
05:50:03
|
*** harshadura has joined #openmrs
|
06:00:10
|
*** magoo_ has joined #openmrs
|
06:08:38
|
*** applecool has quit IRC
|
06:17:35
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Kenya Project: First-time Setup <http://openmrskenya.blogspot.com/2012/06/first-time-setup.html>
|
06:21:16
|
*** magoo_ has quit IRC
|
06:26:35
|
*** magoo_ has joined #openmrs
|
06:50:55
|
*** goutham has joined #openmrs
|
06:54:45
|
*** dkayiwa has joined #openmrs
|
06:59:41
|
<goutham> dkayiwa: Good morning :)
|
07:00:15
|
<dkayiwa> good morning goutham :)
|
07:01:10
|
<goutham> dkayiwa: Had a strong break fast ?
|
07:05:47
|
<dkayiwa> goutham: hahaha, just woken up
|
07:06:01
|
<dkayiwa> goutham: it almost 10am, woke up late today :)
|
07:07:30
|
*** harshadura has quit IRC
|
07:09:14
|
<dkayiwa> goutham: in your gmail picture, was that a dancing stroke? :)
|
07:09:50
|
<goutham> dkayiwa: yes =)
|
07:10:20
|
<dkayiwa> goutham: hahaha, i like it. it was a nice one :D
|
07:11:29
|
*** harshadura has joined #openmrs
|
07:11:35
|
<goutham> dkayiwa: Thank you B )
|
07:11:44
|
<dkayiwa> d:)
|
07:12:17
|
<goutham> dkayiwa: u like dancing ?
|
07:12:40
|
<goutham> dkayiwa: what style you do you prefer?
|
07:12:42
|
<dkayiwa> goutham: no. but i liked your stroke. :)
|
07:13:01
|
<dkayiwa> goutham: i do not even know how to dance :)
|
07:14:26
|
<goutham> dkayiwa: i am not a great dancer :P i just loose up in parties :D
|
07:14:49
|
<dkayiwa> goutham: hahahahahahahah :D
|
07:15:20
|
<goutham> dkayiwa: :) i have a bundle of questions , have a strong break fast and come ;)
|
07:16:58
|
<dkayiwa> goutham: ok :)
|
07:20:04
|
*** mgielow has joined #openmrs
|
07:43:54
|
*** maurya has quit IRC
|
08:02:06
|
*** magoo_ has quit IRC
|
08:24:48
|
*** magoo_ has joined #openmrs
|
08:27:55
|
*** applecool has joined #openmrs
|
08:27:55
|
*** ChanServ sets mode: +v applecool
|
08:31:59
|
*** dkayiwa has quit IRC
|
08:46:24
|
*** mgielow has quit IRC
|
09:17:56
|
*** magoo_ has quit IRC
|
09:20:19
|
*** snoppy has joined #openmrs
|
09:21:16
|
*** mgielow has joined #openmrs
|
09:41:28
|
*** magoo_ has joined #openmrs
|
09:53:46
|
*** goutham has quit IRC
|
09:55:09
|
*** goutham has joined #openmrs
|
09:57:06
|
*** magoo_ has quit IRC
|
10:17:42
|
*** magoo_ has joined #openmrs
|
10:19:58
|
*** applecool has quit IRC
|
10:32:31
|
*** applecool has joined #openmrs
|
10:32:31
|
*** ChanServ sets mode: +v applecool
|
10:35:51
|
*** magoo_ has quit IRC
|
10:45:05
|
*** applecoo_ has joined #openmrs
|
10:49:10
|
*** applecool has quit IRC
|
10:51:17
|
*** applecool has joined #openmrs
|
10:51:17
|
*** ChanServ sets mode: +v applecool
|
10:52:24
|
*** rafa has joined #openmrs
|
10:52:24
|
*** ChanServ sets mode: +v rafa
|
10:54:52
|
*** applecoo_ has quit IRC
|
10:55:58
|
<rafa> applecool: hi
|
10:56:20
|
<rafa> applecool: ready for a short scrum?
|
10:56:31
|
<applecool> hi rafa :) yes
|
10:56:40
|
*** pulasthi7 has joined #openmrs
|
10:56:41
|
*** mgielow has quit IRC
|
10:56:58
|
<rafa> applecool: so where are we with tasks from the last week?
|
10:58:12
|
<applecool> hmm. download is done and the search is done! the adding of the user to the package listing and the mypackages button hiding the edit and delete button are remaining
|
10:58:29
|
<applecool> will complete them by today
|
10:58:46
|
<applecool> i hope all the last weeks tasks will be completed by today
|
10:59:14
|
<applecool> as i told you on friday
|
10:59:40
|
<rafa> applecool: so I should look at your commit now, right?
|
10:59:59
|
<rafa> applecool: with the search and the download functionality
|
11:00:06
|
<applecool> yes
|
11:00:33
|
<applecool> i am testing the edit one! i mean as you suggested to add them under a single column
|
11:00:49
|
<applecool> the comment on the previous commit
|
11:01:20
|
<applecool> actually i had a tiring day at my school ! so didnt work from morning
|
11:03:03
|
<rafa> applecool: ok, the search seems to look good, I've just left one comment
|
11:03:11
|
<rafa> applecool: good work
|
11:03:13
|
<applecool> okay :)
|
11:03:19
|
<applecool> thanks rafa :)
|
11:03:20
|
<rafa> applecool: I haven't tested it though
|
11:03:28
|
<applecool> okay! i tested it thrice :)
|
11:03:29
|
<rafa> applecool: and you haven't written any tests
|
11:03:48
|
<applecool> ah yes i dint think about writing a test! but will do!
|
11:04:01
|
<applecool> rafa: what would be this weeks task?
|
11:04:04
|
<rafa> applecool: yes, please do
|
11:04:37
|
<applecool> as we thought the major functionalities will be done if i complete the left out last weeks tasks
|
11:04:39
|
<applecool> right?
|
11:04:40
|
*** magoo_ has joined #openmrs
|
11:04:56
|
<rafa> applecool: you still need to do pagination of the table
|
11:05:16
|
<applecool> oh yes!
|
11:06:14
|
<rafa> applecool: I'll want you to add a download counter as well
|
11:06:36
|
<rafa> applecool: and display most downloaded packages on the main page
|
11:06:54
|
<applecool> like the modulerepository :) right?
|
11:06:57
|
<rafa> applecool: that should be enough for this week
|
11:07:00
|
<rafa> applecool: right
|
11:07:11
|
<applecool> okay :)
|
11:07:15
|
<rafa> applecool: you're presenting next week, correct?
|
11:07:27
|
<applecool> next week yes not this week
|
11:08:12
|
<rafa> applecool: ok, we need to make sure we have these features by then
|
11:08:23
|
<applecool> okay!
|
11:09:05
|
<rafa> applecool: if you complete the tasks from the last week today, it'll be easy
|
11:09:22
|
<applecool> hmm yes
|
11:09:56
|
<rafa> applecool: please e-mail me and Glen the goals for this week
|
11:10:08
|
<applecool> okay :)
|
11:10:12
|
<applecool> will do it :)
|
11:10:21
|
<rafa> applecool: great
|
11:10:29
|
<rafa> applecool: any problems to resolve?
|
11:10:37
|
<applecool> not yet
|
11:10:47
|
<applecool> i will ask you if i need any help
|
11:10:49
|
<applecool> :)
|
11:10:57
|
<rafa> applecool: good, I'll be around for the next 4 hours or so
|
11:11:07
|
<applecool> cool :) Thanks rafa
|
11:11:23
|
<rafa> applecool: thank you for a nice chat
|
11:11:34
|
<rafa> applecool: I like hearing things are done :D
|
11:11:39
|
<applecool> you too rafa :)
|
11:11:43
|
<applecool> hehe! :)
|
11:11:51
|
<applecool> i need to complete the rest! :)
|
11:12:01
|
<applecool> i am getting my laptop charged to fullest
|
11:12:17
|
<applecool> because it started raining heavily here
|
11:12:37
|
<rafa> applecool: I start to like the weather here in Poland :D
|
11:13:07
|
<applecool> yesterday i tricked my system by using a netcard and later on, it tricked me by getting shut down!
|
11:13:16
|
<applecool> haha! you should be liking :D
|
11:13:16
|
<rafa> applecool: haha
|
11:13:31
|
<applecool> :)
|
11:13:50
|
<rafa> applecool: ok ttyl
|
11:13:57
|
<applecool> yup :) cya
|
11:15:02
|
*** suranga has joined #openmrs
|
11:15:02
|
*** ChanServ sets mode: +v suranga
|
11:18:39
|
*** james_regen has joined #openmrs
|
11:18:39
|
*** ChanServ sets mode: +v james_regen
|
11:19:57
|
<applecool> rafa: the two functionalities under a single column is not working
|
11:20:21
|
<applecool> it is taking the url which is set in the display column
|
11:20:30
|
<applecool> itself
|
11:21:16
|
<applecool> rafa: but i will play with it for sometime and check again! and will let you know
|
11:24:35
|
*** upul` has quit IRC
|
11:28:55
|
<suranga> hi james_regen
|
11:29:03
|
<suranga> james_regen, good morning :)
|
11:29:12
|
<james_regen> suranga: hi
|
11:29:26
|
<suranga> james_regen, we were hopingfor some advice from you today, if possible :)
|
11:30:13
|
<james_regen> sure
|
11:33:25
|
*** bwolfe has joined #openmrs
|
11:33:25
|
*** ChanServ sets mode: +o bwolfe
|
11:38:44
|
<suranga> james_regen, sorry for the delay, im writing down our problem in an orderly fashion...
|
11:39:01
|
<james_regen> ok
|
11:48:17
|
<suranga> james_regen, im back !
|
11:48:25
|
<suranga> james_regen, here goes ~
|
11:48:30
|
<suranga> james_regen, -------------
|
11:48:33
|
<suranga> our problem is as follows -
|
11:48:33
|
<suranga> as you remember, for task number 2, we need to create hql queries, which basically look like
|
11:48:34
|
<suranga> x.<field> not null and x.<field> !="" and x.<field>=y.<field>;
|
11:48:34
|
<suranga> now as you know, our 'fields' may include patient identifiers or person attributes.
|
11:48:34
|
<suranga> person attributes and patient identifiers live in seperate tables, so we cant generate HQL for these in the same way that we do for the other fields.
|
11:48:34
|
<suranga> When Pulasthi came to me with this problem, I suggested that he do something as follows -
|
11:48:36
|
<suranga> x.<field> not null and x.<field> !="" and x.<field>=y.<field> and x.attributeID=5;
|
11:48:38
|
<suranga> Here, the attribute id represents the person attribute that the field represents.
|
11:48:40
|
<suranga> Pulasthi worked on this, and managed to get it up and running. He ran a sample query with the patient identifiers 'Old Identification Number', 'OpenMRS Identification Number' and the field date of birth.
|
11:48:45
|
<suranga> (three 'must match' columns.)
|
11:48:47
|
<suranga> The hql query generated for this was -
|
11:48:49
|
<suranga> select count(distinct p1) from org.openmrs.Patient p1, org.openmrs.Patient p2, org.openmrs.Person person1, org.openmrs.Person person2, org.openmrs.PatientIdentifier pi1, org.openmrs.PatientIdentifier pi2, org.openmrs.PatientIdentifierType pit1, org.openmrs.PatientIdentifierType pit2 where p1 <> p2 and p1.patientId = person1.personId and p2.patientId = person2.personId and person1.birthdate = person2.birthdate and p1 = pi1.patient and p2 = pi2.patient and
|
11:48:54
|
<suranga> pit1 = pi1.identifierType and pit2 = pi2.identifierType and pi1.identifier = pi2.identifier and pit1.format=pit2.format and ( pit1.format = 'Old Identification Number' or pit1.format = 'OpenMRS Identification Number') order by person1.birthdate
|
11:48:58
|
<suranga> pulasthi asked me to check if this is ok.
|
11:49:00
|
<suranga> I've been looking at it this morning, and it seems fine and what we want.
|
11:49:02
|
<suranga> I just wanted to show this to you, to see if you agree with me that this is correct
|
11:52:45
|
<james_regen> suranga: it might be. is this his hand written query to make sure he understands how he'll need to write the HQL, or is this the output of code that generates the queries?
|
11:53:29
|
<suranga> james_regen, its the generated hql for the three fields I mentioned above :)
|
11:53:36
|
<suranga> james_regen, yep, its the output of the code :)
|
11:54:13
|
<james_regen> suranga: great. does the output of the query match the number of pairs in the report? i think the easiest way to see if it's correct is run the query and compare the results
|
11:55:02
|
<suranga> james_regen, aha, yes, unforutunately, I dont think the data in our databases are adequate to return any results :)
|
11:56:22
|
<james_regen> suranga: what system is thisi being tested on? there's link.regenstrief.org, which should have enough test records to form some pairs, i think
|
11:56:44
|
<suranga> james_regen, I was actually about to recomend that
|
11:57:05
|
<suranga> james_regen, would it be ok to deploy our module on link.regenstrief ? :)
|
11:57:20
|
<suranga> james_regen, is anyone depending on it at the moment ?
|
11:58:10
|
<james_regen> suranga: yup, that's what it's for. i'd be more comfortable knowing we've done some testing ourselves before giving it to anyone, to hopefully avoid any simple problems. link.regenstrief.org is just for our module development, mostly GSoC, so it wouldn't be a problem to break things as you try to get it working
|
11:58:46
|
<suranga> james_regen, cool. I will have pulasthi try that out today
|
11:59:03
|
<suranga> james_regen, but as far as you can see to the naked eye, the query looks ok, does it ? :)
|
12:00:01
|
*** magoo_ has quit IRC
|
12:00:25
|
<james_regen> suranga: i don't know if we need anything like order by in the query, since it's counting and just returning a number. the other stuff is pretty complicated . . . i'd have to spend more time with it to give an answer with any certainty. it looks reasonable
|
12:00:59
|
<suranga> james_regen, no worries. I understand
|
12:01:27
|
<suranga> james_regen, cool, we will try it out on the regenstrief server
|
12:08:39
|
*** downey has joined #openmrs
|
12:08:39
|
*** ChanServ sets mode: +o downey
|
12:08:39
|
*** OpenMRSBot sets mode: +o downey
|
12:14:45
|
*** pulasthi7 has quit IRC
|
12:24:35
|
*** applecool has quit IRC
|
12:52:18
|
<suranga> hi james_regen
|
12:52:27
|
<suranga> james_regen, terribly sorry, me again :)
|
12:53:00
|
<james_regen> suranga: no problem
|
12:53:52
|
<suranga> james_regen, pulasthi sent an email titled "Finalizing task 2" over the weekend. in this, he raised a clarification which he needed addressed
|
12:54:10
|
<suranga> james_regen, I was hoping you could clarify for us when you are free :)
|
12:55:06
|
<james_regen> suranga: yeah, i read that email, then got on IRC and forgot about that issue. you mean adding the number of pairs and times for the two reports to get one time?
|
12:55:40
|
<suranga> james_regen, yes, as well as the estimated pairs :)
|
12:58:01
|
*** dkayiwa has joined #openmrs
|
12:58:38
|
<james_regen> the total number of pairs processed wen multiple strategies is correct. if the first report evaluates 1000 pairs, and the second one has 700 pairs, then 1700 is the total pairs processed. there's no feedback between reports that could affect total pairs
|
12:59:17
|
<james_regen> suranga: what was the exact question about estimated pairs?
|
12:59:50
|
<suranga> james_regen, assuming that strategy A resulted in 200 pairs
|
13:00:00
|
<suranga> james_regen, and strategy B resulted in 200 pairs
|
13:00:24
|
<suranga> a report which consists of strategies A and B results in (?) number of pairs ?
|
13:02:34
|
<suranga> james_regen, we did some debugging, and it seems that these pairs are calculated seperately (not in relation to each other)
|
13:03:00
|
<suranga> james_regen, oh sorry, I see you have answered our question above
|
13:03:06
|
<james_regen> suranga: right, all of the pairs created for each report is evaluated
|
13:03:20
|
<suranga> james_regen, cool, thanks a lot for helping out !
|
13:04:39
|
*** jriley has joined #openmrs
|
13:05:36
|
*** dkayiwa has quit IRC
|
13:11:49
|
*** dkayiwa has joined #openmrs
|
13:16:53
|
* rafa wonders if random failures of SchedulerServiceTest can be used to tell the winners of euro 2012 :D
|
13:21:55
|
*** wyclif has joined #openmrs
|
13:25:34
|
*** pushkar has joined #openmrs
|
13:25:48
|
<pushkar> bwolfe, Good Morning
|
13:26:57
|
<bwolfe> hey pushkar
|
13:28:09
|
*** sgithens has joined #openmrs
|
13:34:19
|
<pushkar> bwolfe, EncounterSaveHandler isn not working in trunk but its working in 1.9.x
|
13:35:30
|
<bwolfe> pushkar, thats very strange
|
13:35:45
|
<bwolfe> are any of the save handlers working in trunk?
|
13:36:06
|
<pushkar> yes the concept save handler is working!!
|
13:40:46
|
*** suranga has quit IRC
|
13:57:19
|
*** kreddy has joined #openmrs
|
14:02:22
|
*** djazayeri has joined #openmrs
|
14:02:22
|
*** ChanServ sets mode: +o djazayeri
|
14:02:30
|
*** cpower has joined #openmrs
|
14:02:39
|
<cpower> Good morning channel
|
14:03:21
|
<cpower> are we ready to sprint?
|
14:03:40
|
<djazayeri> sprint?
|
14:03:42
|
<djazayeri> or scrum?
|
14:03:49
|
<cpower> I can say I needed to get more exercise than I did this weekend.
|
14:04:06
|
<cpower> djazayeri, It's the first day of this sprint too.
|
14:04:27
|
<bwolfe> hopefully we're all ready to both sprint and scrum
|
14:04:34
|
<djazayeri> true
|
14:04:38
|
*** harshadura has quit IRC
|
14:04:41
|
<bwolfe> although some of us have been sprinting for a while
|
14:04:57
|
<cpower> someday I want to play rugby so I say I actually was in a scrum too.
|
14:05:19
|
<cpower> bwolfe, Is it becoming a marathon?
|
14:06:00
|
<cpower> anyway, let's get moving I've got a busy meeting schedule today
|
14:06:07
|
<cpower> !scrumon cpower
|
14:06:07
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
14:06:55
|
<cpower> Order: Bwolfe, dkayiwa, wyclif, venkaban, let me know if I'm missing anyone else
|
14:07:16
|
<rafa> cpower: me
|
14:07:20
|
<rafa> hi
|
14:07:24
|
<djazayeri> me
|
14:07:46
|
<bwolfe> me?
|
14:07:55
|
<bwolfe> oh, no, there I am at the front
|
14:08:03
|
<cpower> oh, sorry rafa, you go last
|
14:08:03
|
<bwolfe> missing kreddy
|
14:08:12
|
<bwolfe> and uma, but I don't see her on
|
14:08:38
|
<cpower> whoa! Kreddy is up at this hour...crazy stuff
|
14:09:00
|
<cpower> ok bwolfe...let's go
|
14:09:16
|
<kreddy> cpower, i am not in sfo yet! :-)
|
14:09:51
|
<bwolfe> Friday
|
14:09:51
|
<bwolfe> emails
|
14:09:51
|
<bwolfe> call with tw australia
|
14:09:51
|
<bwolfe> time out tickets for sprint next week
|
14:09:51
|
<bwolfe> more chats with Kiran
|
14:09:52
|
<bwolfe> conf call to plan our conf calls *sigh*
|
14:09:54
|
<bwolfe> Monday
|
14:09:56
|
<bwolfe> emails
|
14:09:58
|
<bwolfe> triaged 2 tickets
|
14:10:00
|
<bwolfe> sprint ticket comments / setup
|
14:10:02
|
<bwolfe> reviewed a bunch of tickets on trunk
|
14:10:04
|
<bwolfe> backported one patch to 1.9.x for scheduler tests
|
14:10:06
|
<bwolfe> no blockers
|
14:10:08
|
<bwolfe> kreddy, stuck in chicago?
|
14:10:20
|
<dkayiwa> Committed response to review comments for: Revisit OrderValidator - TRUNK-3322
|
14:10:20
|
<dkayiwa> Now working on: Verify unit tests are working in logic module after mavenization - LOGIC-106
|
14:10:20
|
<dkayiwa> No Blockers
|
14:11:24
|
<kreddy> bwolfe, going back tonight
|
14:11:43
|
<djazayeri> dkayiwa: that's friday & today?
|
14:11:57
|
<dkayiwa> djazayeri: only today :)
|
14:12:45
|
<djazayeri> okay, I was a bit worries. :-)
|
14:12:48
|
<djazayeri> wyclif: your turn
|
14:12:53
|
<dkayiwa> djazayeri: OK
|
14:13:00
|
<dkayiwa> :)
|
14:14:05
|
<cpower> wyclif...
|
14:14:35
|
<cpower> okay skip...Venkaban
|
14:15:02
|
<bwolfe> wyclif and venkaban are both asleep perhaps
|
14:15:08
|
<bwolfe> venkaban, has more of an excuse ;-)
|
14:15:09
|
<venkaban> Friday, Completed Coding
|
14:15:10
|
<wyclif> sorry
|
14:15:26
|
<wyclif> my machine was running out of memory so it had hang
|
14:15:35
|
<venkaban> Friday Completed coding for TRUNK 3308 and test cases.
|
14:15:53
|
<venkaban> Today have to llok at the tockets for the curent sprint. No Blockers
|
14:16:21
|
<bwolfe> !ticket TRUNK-3308
|
14:16:22
|
<OpenMRSBot> bwolfe: [#TRUNK-3308] Add methods to OrderService for fetching patient Orders given an order class and other arguments - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3308
|
14:16:57
|
<bwolfe> ok, wyclif?
|
14:16:58
|
<cpower> ok wyclife
|
14:17:00
|
<rafa> venkaban: I don't see a new patch...
|
14:17:13
|
<wyclif> Friday:
|
14:17:13
|
<wyclif> Merging order entry branch to trunk(Was a pain, managed to commit the merge this morning)
|
14:17:13
|
<wyclif> Worked on TRUNK-3443 and tested affected forms - Remove sessionForm=true from spring definition file
|
14:17:13
|
<wyclif> Address review comments for HTML-121 - View schema is broken for html previewer
|
14:17:13
|
<wyclif> Weekly skype call with Dmitry
|
14:17:14
|
<wyclif> Monday:
|
14:17:16
|
<wyclif> HTML-88 - Add ability to specify the Encounter Type from a specified list of Encounter Types while filling out an HTML Form
|
14:17:19
|
<wyclif> Other HFE and Reporting tickets assigned to me
|
14:17:19
|
<venkaban> rafa, I have to attach it
|
14:17:21
|
<wyclif> Blockers: None
|
14:17:28
|
<venkaban> will do it now rafa
|
14:17:41
|
<rafa> venkaban: ok, I thought you forgot :)
|
14:18:30
|
<venkaban> rafa, haha no
|
14:18:38
|
<bwolfe> rafa, you're up. then djazayeri
|
14:18:38
|
*** sgithens has quit IRC
|
14:18:49
|
<rafa> cpower: said I'm last :P
|
14:18:59
|
<djazayeri> Friday 15-Jun-2012 (& weekend)
|
14:19:00
|
<djazayeri> * TW Australia call
|
14:19:00
|
<djazayeri> * I-TECH call
|
14:19:00
|
<djazayeri> * I-TECH work
|
14:19:00
|
<djazayeri> * fixed CALC-39 - Rename CohortResult to CalculationResultMap
|
14:19:00
|
<djazayeri> * created CALC-40 - Allow calculations to be evaluated in a streaming fashion
|
14:19:00
|
<djazayeri> * Updated wiki pages for Concept Proposal module project for TW Australia
|
14:19:01
|
<djazayeri> Monday 18-Jun-2012
|
14:19:02
|
<djazayeri> * Call with TW Australia BA about Concept Proposal module project
|
14:19:02
|
<djazayeri> * Create HTML Form Entry tickets that let you access a defaultLocation GP
|
14:19:03
|
<djazayeri> * email people about when we’ve scheduled them for University calls
|
14:19:03
|
<djazayeri> * I-TECH work
|
14:19:04
|
<djazayeri> no blockers
|
14:19:13
|
<cpower> Kreddy you have anything you want to share ;-)
|
14:19:18
|
<rafa> Yesterday/Today:
|
14:19:18
|
<rafa> * Released RESTWS 1.0
|
14:19:18
|
<rafa> * Closed the sprint
|
14:19:18
|
<rafa> * Resolved META-221: writeReplace method conflicts with javassist writeReplace when running Openmrs 1.9
|
14:19:18
|
<rafa> https://tickets.openmrs.org/browse/META-221
|
14:19:19
|
<rafa> * Created TRUNK-3448: Locale with country does not work
|
14:19:19
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-3448
|
14:19:19
|
<rafa> * Looked into REPORT-398: Possible memory leak with reporting scheduled tasks
|
14:19:19
|
<rafa> https://tickets.openmrs.org/browse/REPORT-398 (not yet reproduced)
|
14:19:20
|
<rafa> * Resolved STAND-40: Cannot start OpenMRS standalone under Ubuntu and Windows 7
|
14:19:21
|
<rafa> https://tickets.openmrs.org/browse/STAND-40
|
14:19:22
|
<rafa> * Working on TRUNK-2696: UI improvements for Visits
|
14:19:22
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-2696
|
14:19:22
|
<rafa> No blockers.
|
14:19:53
|
<kreddy> Just that Daniel will be in Kenya from June 9th to 13th
|
14:19:54
|
*** mathiaslin has joined #openmrs
|
14:20:06
|
<kreddy> Sorry July9-13
|
14:20:07
|
*** mathiaslin has quit IRC
|
14:20:38
|
<kreddy> We have the XForm sprint scheduled during that time
|
14:20:42
|
<cpower> Summary: No blockers, no discussion points.
|
14:20:48
|
<cpower> !scrumoff
|
14:20:48
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
14:21:01
|
*** lh has joined #openmrs
|
14:21:01
|
*** lh has joined #openmrs
|
14:21:26
|
<djazayeri> rafa: is trunk-2696 the right ticket number? what's the to-do there?
|
14:22:03
|
<rafa> djazayeri: your last comment
|
14:22:23
|
*** pushkar has quit IRC
|
14:22:31
|
<djazayeri> Oh, that doesn't open a popup?
|
14:22:46
|
<djazayeri> fine
|
14:22:51
|
<rafa> yes
|
14:23:17
|
<djazayeri> odd that that ticket is still open—I guess we missed giving it a 1.9 fixVersion
|
14:23:47
|
<rafa> djazayeri: I was surprised to see it too :)
|
14:23:49
|
*** mathiaslin has joined #openmrs
|
14:23:51
|
<rafa> djazayeri: I lost track of it
|
14:26:44
|
<dkayiwa> hi wyclif
|
14:26:57
|
<bwolfe> cpower, one "blocker" from kreddy. more of a "question" than a blocker, but we don't categorize them. :-)
|
14:27:12
|
*** pushkar has joined #openmrs
|
14:27:34
|
<bwolfe> dkayiwa what are you doing in eldoret? training 8 hrs each day the whole week?
|
14:27:55
|
<dkayiwa> bwolfe: not sure of the time table now. Ada knows :)
|
14:28:19
|
* bwolfe pings ada
|
14:29:00
|
<bwolfe> dkayiwa, hmm, well, either way you're technically off of openmrs service for that week. :-/
|
14:30:55
|
<bwolfe> good news dkayiwa, cpower, and kreddy!
|
14:31:19
|
<bwolfe> one of paul's goals for daniel is to get the ampath devs involved in a sprint. another goal is to get them familiar with the xforms module.
|
14:31:28
|
<bwolfe> dkayiwa will only be training for 3 days that week
|
14:31:48
|
<bwolfe> so the other 2 days he can be helping the ampath devs work on xforms sprint tickets
|
14:31:56
|
<kreddy> that means he will be available for the sprint then
|
14:31:59
|
<bwolfe> he can look over their shoulders, answer questions quicly, etc
|
14:32:06
|
<bwolfe> kreddy, right
|
14:32:12
|
<kreddy> great
|
14:32:15
|
<dkayiwa> :)
|
14:32:48
|
<kreddy> Thanks bwolfe for the information
|
14:45:43
|
<venkaban> bwolfe, Hi
|
14:45:53
|
<cpower> Kreddy, can you confirm Patrick wants to have the call today?
|
14:45:53
|
<bwolfe> hey venkaban
|
14:46:51
|
<venkaban> bwolfe, Can you please tell me how did to setup for individual test runs in eclipse, I mean the run configurations ?
|
14:47:12
|
<bwolfe> venkaban, can you not just right click on a test and do runas-->junit test?
|
14:47:16
|
<bwolfe> what fails.
|
14:47:19
|
<bwolfe> ?
|
14:47:26
|
<venkaban> bwolfe, i tried that
|
14:47:49
|
<venkaban> bwolfe, but there is no run as option showing up
|
14:48:25
|
<venkaban> bwolfe, i think i need to add a run configuration for JUnit Test
|
14:48:26
|
<bwolfe> venkaban, so that means the project is not recognized as a java project in eclipse
|
14:48:38
|
<bwolfe> did you do a "checkout through maven" ?
|
14:48:40
|
*** kavuri has joined #openmrs
|
14:48:44
|
<venkaban> bwolfe, Yes
|
14:48:45
|
<bwolfe> and do you have 6 projects in your eclipse?
|
14:49:27
|
<venkaban> bwolfe, for order-entry I have only one project folder in project explorer
|
14:50:27
|
<bwolfe> venkaban, try to 'package explorer' view instead
|
14:50:50
|
<kavuri> bwolfe: is there a REST API for "Visits" ?
|
14:50:53
|
<venkaban> bwolfe, Yeah i am in that view
|
14:50:58
|
<bwolfe> actually, nm, even with project explorer I see all 6 projects
|
14:51:23
|
<bwolfe> kavuri, I think its in a separate add-on module.
|
14:51:35
|
<bwolfe> venkaban, so you need to check out the project through maven
|
14:51:39
|
<venkaban> bwolfe, I have 6 folders inside my order-entry package
|
14:51:58
|
<bwolfe> venkaban, no, not under, next to
|
14:52:07
|
<venkaban> bwolfe, I dint install maven but I have maven plugins installed which helped in checking out the projects
|
14:52:23
|
<bwolfe> each "maven module" within openmrs is a separate project.
|
14:52:44
|
<bwolfe> venkaban, you should see separate projects
|
14:52:53
|
*** rafa has quit IRC
|
14:53:01
|
<bwolfe> and when you get those separate projects you must run the tests in the api project (not the openmrs/api project)
|
14:53:30
|
<venkaban> bwolfe, for order-entry branch you have 6 projects?
|
14:54:25
|
<bwolfe> venkaban, the reason is that maven will set up the eclipse files (.project and .classpath). those files are not there by default because they are eclipse specific. so the maven plugins in eclipse look at the pom.xml and generate the .classpath file for you so that you can build, package, run tests, etc
|
14:54:40
|
<bwolfe> venkaban, yes, 6 projects
|
14:55:38
|
<venkaban> bwolfe, will my elcipse plugins create any problem if I download maven and download project using maven
|
14:56:02
|
<venkaban> bwolfe, can you provide me the link for the steos that describe these steps?
|
14:56:23
|
<snoppy> wyclif: hi, wyclif!
|
14:56:35
|
<dkayiwa> hi ra
|
14:56:42
|
<bwolfe> venkaban, did you follow this process? https://wiki.openmrs.org/display/docs/Using+the+M2Eclipse+Maven+Plugin+In+Eclipse
|
14:56:42
|
<dkayiwa> hi wyclif
|
14:56:42
|
<OpenMRSBot> <http://ln-s.net/8c8D> (at wiki.openmrs.org)
|
14:57:28
|
<bwolfe> venkaban, you can check out the file with maven on your filesystem, but then you have to "file-->import-->maven project from existing"
|
14:57:41
|
<bwolfe> or you can check out in eclipse, and choose "check maven project"
|
14:58:11
|
<venkaban> bwolfe, like checking out in eclipse workspace folder?
|
14:58:39
|
<bwolfe> not sure what you're asking
|
14:58:41
|
<bwolfe> what I usually do:
|
14:58:59
|
<bwolfe> svn co http://svn.openmrs.org...... workspace/newprojectname
|
14:59:02
|
<bwolfe> then in eclipse:
|
14:59:26
|
<bwolfe> file-->import--> existing maven projects. choose the workspace folder
|
14:59:34
|
<bwolfe> when you do that import, ti creates 6 projects for you in eclipse
|
14:59:48
|
*** harshadura has joined #openmrs
|
15:02:15
|
*** snoppy has left #openmrs
|
15:03:16
|
<venkaban> bwolfe, yes when you import from maven projects, you make sure that code is checked out in workspace folder right?
|
15:03:39
|
<bwolfe> mine is
|
15:03:42
|
<bwolfe> I don't think it has to be
|
15:05:40
|
*** cpower has quit IRC
|
15:07:18
|
<venkaban> bwolfe, Having maven 3.0.4 is better or 2.2.1?
|
15:07:27
|
*** applecool has joined #openmrs
|
15:07:27
|
*** ChanServ sets mode: +v applecool
|
15:07:31
|
<bwolfe> venkaban, dunno
|
15:11:29
|
*** venkaban has quit IRC
|
15:28:29
|
*** applecool has quit IRC
|
15:30:39
|
*** mvorobey has joined #openmrs
|
15:30:45
|
<mvorobey> hi all
|
15:35:06
|
<mvorobey> hi bwolfe
|
15:35:28
|
<mvorobey> bwolfe, I'd like to work on testing spring
|
15:41:17
|
*** applecool has joined #openmrs
|
15:41:17
|
*** ChanServ sets mode: +v applecool
|
15:46:34
|
*** kavuri has quit IRC
|
15:46:41
|
*** cpower has joined #openmrs
|
15:46:55
|
<cpower> Is uma here?
|
15:47:53
|
*** maurya has joined #openmrs
|
15:48:21
|
*** Maurya_ has joined #openmrs
|
15:48:49
|
*** goutham has quit IRC
|
15:52:01
|
*** Maurya_ has quit IRC
|
15:52:34
|
*** maurya has quit IRC
|
15:52:49
|
*** pulasthi7 has joined #openmrs
|
15:58:16
|
*** venkaban has joined #openmrs
|
15:59:25
|
*** kavuri has joined #openmrs
|
15:59:56
|
*** dkayiwa has quit IRC
|
16:01:04
|
*** dkayiwa has joined #openmrs
|
16:12:26
|
*** mccallumg has joined #openmrs
|
16:12:26
|
*** ChanServ sets mode: +v mccallumg
|
16:16:47
|
<kavuri> bwolfe: this link: http://booki.flossmanuals.net/openmrs-guide/_draft/_v/1.0/configuring-visits/ does not list REST API...is there any other page with the documentation?
|
16:16:52
|
<OpenMRSBot> <http://ln-s.net/$JL2> (at booki.flossmanuals.net)
|
16:21:49
|
*** mathiasl_ has joined #openmrs
|
16:21:55
|
<downey> Hi mathiasl_ and welcome to the #openmrs IRC channel.
|
16:22:02
|
*** mathiasl_ has quit IRC
|
16:23:54
|
*** mathiaslin has quit IRC
|
16:26:47
|
*** suranga has joined #openmrs
|
16:26:47
|
*** ChanServ sets mode: +v suranga
|
16:28:57
|
<suranga> hi pulasthi7
|
16:29:01
|
<suranga> pulasthi7, good evening
|
16:29:37
|
<pulasthi7> hi suranga, good evening!
|
16:29:56
|
<suranga> pulasthi7, im afraid I sent you very many emails today :p
|
16:30:04
|
<suranga> pulasthi7, hope they were helpful :)
|
16:30:48
|
<pulasthi7> suranga, yes,seems they are very helpful. i was reading them,
|
16:33:11
|
<bwolfe> kavuri, let me find the ticket for it, it might point to docs they created
|
16:33:23
|
<kavuri> bwolfe: thanks
|
16:33:46
|
<bwolfe> kavuri, but hte openmrs book won't explain the api or even the rest api for that matter. the openmrs book is for implementers using openmrs through the webapp
|
16:34:16
|
<bwolfe> kavuri, sad news, the visits portion hasn't been written. :-( https://tickets.openmrs.org/browse/RESTWS-247
|
16:34:27
|
<pulasthi7> suranga, i also thought that the order by phrase is not of use there. It was a code openmrs trunk which i changed a bit. so i just left it as it. i'll remove that part.
|
16:34:44
|
<suranga> pulasthi7, great
|
16:34:55
|
*** cpower has quit IRC
|
16:35:00
|
<bwolfe> kavuri, I was thinking of the provider work that is 1.9+ in a webservices.rest19ext module: https://tickets.openmrs.org/browse/RESTWS-196
|
16:35:26
|
<suranga> pulasthi7, i think we are definitely moving toward the end of task 2 :)
|
16:37:13
|
<pulasthi7> suranga, :-)
|
16:38:06
|
<suranga> pulasthi7, getting the job done right is more importaint than getting it done quick.. so we're headed at the right direction...
|
16:40:55
|
*** GuestQ679906 has joined #openmrs
|
16:42:47
|
<mvorobey> bwolfe, have you seen my messages ?
|
16:44:16
|
<bwolfe> mvorobey, no. but I have now.
|
16:44:26
|
<bwolfe> mvorobey, you're more than welcome to join, of course!
|
16:44:30
|
<bwolfe> everyone is always welcome
|
16:44:51
|
*** GuestQ679906 has left #openmrs
|
16:45:10
|
<mvorobey> bwolfe, thanks, am actually already joined :)
|
16:45:44
|
<mvorobey> bwolfe, I just started mavenization of reporting module
|
16:48:18
|
<mvorobey> bwolfe, and, after running mavenizator.sh script and resolving maven dependency, I encountered a problem with htmlwidgets module. Reporting actually uses 1.6.1 version, but in OpenMRS maven repo we have only 1.6.0. Can you help me with this ?
|
16:51:19
|
<bwolfe> so 1.6.1 of htmlwidgets needs to be be put in the maven repo? htmlwidgets is not mavenized (yet), so it would be good to have that done as well.
|
16:51:35
|
<bwolfe> mvorobey, did you use the 1.6 version of the mavenization script? I think reporting depends on pre 1.8...
|
16:53:44
|
*** mccallumg has quit IRC
|
16:55:56
|
*** mccallumg has joined #openmrs
|
16:55:56
|
*** ChanServ sets mode: +v mccallumg
|
16:58:04
|
<mvorobey> bwolfe, I used 1.6.4 version in script, actually reporting depends on 1.6.3
|
16:59:28
|
*** venkaban has quit IRC
|
17:00:10
|
<bwolfe> shouldn't be a problem, but you can also change it back manualy
|
17:01:27
|
<mvorobey> bwolfe, so, who would mavenize htmlwifgets? may be me ?
|
17:01:46
|
<djazayeri> mvorobey, bwolfe: I think as a first pass you can just make reporting depend on the latest version of htmlwidgets
|
17:01:47
|
<bwolfe> mvorobey, maybe. or wyclif or rafa or dkayiwa. :-)
|
17:03:09
|
<mvorobey> djazayeri, is it good that in this case reporting won't be built
|
17:03:12
|
<mvorobey> ?
|
17:04:40
|
<djazayeri> mvorobey: I mean that it's okay to make it such that the *next* version of reporting (i.e. the one that will be built from the mavenized code) will depend on the most recent version of htmlwidgets.
|
17:04:55
|
<djazayeri> i.e. you don't have to work on uploading old versions of htmlwidgets to maven, just the most recent released one.
|
17:07:28
|
<mvorobey> djazayeri, ok, got it, will put 1.6.1, by the way, when will we have that version released ? by the end of this sprint ?
|
17:10:39
|
*** djazayeri1 has joined #openmrs
|
17:11:34
|
*** djazayeri has quit IRC
|
17:18:10
|
<mvorobey> bwolfe, need to talk
|
17:18:13
|
<bwolfe> ok
|
17:18:45
|
<mvorobey> bwolfe, I just faced NoRunnableMethods exception in reporting tests
|
17:19:13
|
*** djazayeri1 is now known as djazayeri
|
17:19:14
|
*** ChanServ sets mode: +o djazayeri
|
17:19:16
|
<bwolfe> mvorobey, getting tests working is a separate ticket
|
17:19:31
|
<bwolfe> mvorobey, get it converted, compile it, and test it in a browser, then commit and work on tests
|
17:19:32
|
<mvorobey> bwolfe, only 1 test fails
|
17:19:39
|
<bwolfe> 1, or all?
|
17:19:43
|
<mvorobey> 1
|
17:19:57
|
<mvorobey> Tests in error:
|
17:19:57
|
<mvorobey> initializationError0(org.openmrs.module.reporting.report.service.TestReportProcessor)
|
17:19:57
|
<mvorobey> Tests run: 290, Failures: 0, Errors: 1, Skipped: 8
|
17:20:47
|
<wyclif> hi djazayeri
|
17:21:09
|
<djazayeri> hi wyclif
|
17:21:36
|
<wyclif> am working on HTML-88 and i need to ask you something
|
17:21:44
|
<djazayeri> !ticket html-88
|
17:21:45
|
<OpenMRSBot> djazayeri: [#HTML-88] Add ability to specify the Encounter Type from a specified list of Encounter Types while filling out an HTML Form - OpenMRS JIRA - https://tickets.openmrs.org/browse/html-88
|
17:22:06
|
<bwolfe> not sure what that means
|
17:22:21
|
<djazayeri> wyclif: what's the question?
|
17:24:18
|
<wyclif> djazayeri, am trying to interprete this 'We should create a new EncounterTypeHandler class that creates an EncounterDetailsSubmissionElement.'
|
17:24:19
|
<mvorobey> bwolfe, this means that class does not have methods annotated with @test
|
17:24:47
|
<bwolfe> ok, is it supposed to? or were the tests not supposed to run? check the history of the file
|
17:24:47
|
<mvorobey> bwolfe, may be djazayeri knows how to workaround that ?
|
17:25:03
|
<wyclif> djazayeri, it is a comment that mark added, is that meant to do something similar to how encounter provider and encounter location are
|
17:25:24
|
<djazayeri> mvorobey: feel free to put an @Ignore on the top of the test to get things running
|
17:25:29
|
<djazayeri> then we'll figure out how to restore the test.
|
17:25:41
|
<mvorobey> bwolfe, no test to run with that class
|
17:26:26
|
<djazayeri> wyclif: the idea is that we need a new tag handler (like the one for encounterLocation) that will handle the encounterType tag
|
17:26:29
|
<mvorobey> bwolfe, that class is a test implementation of ReportProcessor interface, so it is used in tests but it is not a test
|
17:26:33
|
<mvorobey> itself
|
17:26:38
|
<djazayeri> wyclif: and this tag handler is going to need a "choose encounter type" widget
|
17:27:19
|
<wyclif> djazayeri, ok
|
17:27:32
|
<djazayeri> wyclif: but since we already have EncounterDetailsSubmissionElement that handles encounter location, datetime, and provider, just add type to that. Do _not_ create EncounterTypeSubmissionElement.
|
17:28:23
|
<wyclif> djazayeri, got you
|
17:28:45
|
<wyclif> just techncal question, what is the key difference between a SubstitutionTagHandler and a regular TagHandler
|
17:29:29
|
<wyclif> djazayeri, just a technical question, what is the key difference between a SubstitutionTagHandler and a regular TagHandler, i can see that one prints out html and the other?
|
17:29:43
|
*** venkaban has joined #openmrs
|
17:30:20
|
<mvorobey> bwolfe, putting of @Ignore solves everything :) have to ask you this -
|
17:30:40
|
<djazayeri> wyclif: is the javadoc on SubstitutionTagHandler not clear?
|
17:30:58
|
<mvorobey> bwolfe, do I need create a tag in svn for current version of reporting and what name shall I use for that tag ?
|
17:31:09
|
<djazayeri> wyclif: basically, 95% of tags should be SubstitutionTagHandler, i.e. they substitute generated html for <someHtmlFormEntryTag/>
|
17:31:58
|
<djazayeri> wyclif: as opposed to doing something at tag start, and something else at tag end
|
17:32:29
|
<wyclif> djazayeri, i guessed so from the javadocs for SubstitutionTagHandler but i just wanted to be sure that for the regular one is not always the case
|
17:32:58
|
<wyclif> djazayeri, thanks
|
17:33:02
|
<djazayeri> wyclif: maybe you can add a line to the documentation saying that most tags should use this
|
17:33:06
|
<djazayeri> and include it in your commit
|
17:33:20
|
*** maurya has joined #openmrs
|
17:33:58
|
<bwolfe> mvorobey, sure, thats a good idea. tag current version of reporting as "pre-maven"
|
17:34:12
|
*** ChanServ sets mode: +v maurya
|
17:34:34
|
<mvorobey> bwolfe, what is about GitHub ?
|
17:34:52
|
<bwolfe> mvorobey, lets do that after the mavenization
|
17:34:55
|
<djazayeri> bwolfe: can you please add that bit about tagging pre-maven to the ticket descriptions for the other modules?
|
17:35:15
|
*** kreddy has quit IRC
|
17:36:45
|
<bwolfe> fun fact: htmlwidgets was first created in revision 11111 !!
|
17:36:47
|
*** harshadura has quit IRC
|
17:38:05
|
<wyclif> djazayeri, ok
|
17:39:02
|
<bwolfe> djazayeri, good point
|
17:39:15
|
<bwolfe> djazayeri, although xforms is the only other one really
|
17:39:57
|
<bwolfe> venkaban, what are you working on now?
|
17:40:13
|
<bwolfe> venkaban, and have you gotten uma up to speed, or would she like a call with me?
|
17:40:37
|
<venkaban> bwolfe, Hi. Uma has got her setup done i think
|
17:40:43
|
<venkaban> bwolfe, I have nothing in my plate as of now
|
17:41:14
|
<venkaban> bwolfe, I think I have to choose the sprint tickets for this week right? do you have the link?
|
17:41:23
|
*** harshadura has joined #openmrs
|
17:41:33
|
*** lakkarau has joined #openmrs
|
17:41:39
|
<bwolfe> venkaban, always start from lakkarau
|
17:41:53
|
<lakkarau> Bwolfe,hi
|
17:42:01
|
<bwolfe> venkaban, how long have you had an empty plate? :-(
|
17:42:06
|
<bwolfe> hi lakkarau
|
17:42:15
|
<venkaban> bwolfe, This morning
|
17:42:33
|
<bwolfe> venkaban, sorry, for sprints, always start from https://wiki.openmrs.org/display/RES/Sprint+Schedule
|
17:43:01
|
*** mansi has joined #openmrs
|
17:43:17
|
*** mansi has left #openmrs
|
17:44:26
|
<bwolfe> venkaban, lakkarau: I REALLY need you guys to be self-starters out there. with no one else in your office, it is impossible to know if/when/what you are working on. therefore, if you are stuck on something, ask here in IRC, or ask on the mailing list (or email me directly if you need to). if you don't know what to work on, ask, please. I don't like wasting your time just waiting for me to assign something to you. I expect all devs to find the current sp
|
17:44:26
|
<bwolfe> rint and find units of work that they choose.
|
17:45:00
|
<bwolfe> venkaban, lakkarau: its always valid to work on the current sprint tickets or bug fixing tickets: https://wiki.openmrs.org/display/RES/Bug+Fixing+Swim+Lane
|
17:45:18
|
<venkaban> bwolfe, Ok
|
17:45:56
|
<bwolfe> lakkarau, are you ready to code? I can assign you a few very small non-sprint tickets so you can get around the code base a little bit.
|
17:46:13
|
<bwolfe> venkaban, were those small tickets helpful at all? or were they too small? too large? unnecessary?
|
17:46:39
|
<venkaban> bwolfe, they are helpful to get some overview intially
|
17:46:49
|
<lakkarau> bwolfe, yes
|
17:48:14
|
<bwolfe> venkaban, lakkarau: its also very important to join the daily scrums. I know its 7am out there, but you're in the same (unfortunate) boat as djazayeri. :-/ it can be on your phone, bed with a laptop, etc.
|
17:48:29
|
<bwolfe> https://wiki.openmrs.org/display/RES/Daily+Scrum+Meeting
|
17:48:54
|
<bwolfe> (see the pro tip there: keep a log of what you do throughout the day so you don't have to think back and slow the scrum down. we like to keep the scrums very fast)
|
17:49:44
|
<venkaban> bwolfe, its only through IRC right? not by phone?
|
17:50:04
|
*** kreddy has joined #openmrs
|
17:51:17
|
<djazayeri> It's by IRC, correct.
|
17:51:26
|
<djazayeri> Some of the participants don't have reliable phone/voip access
|
17:54:42
|
*** pushkar has quit IRC
|
18:05:50
|
<bwolfe> venkaban, we tried through google hangout, but that is also a problem with low-bandwidth environments!
|
18:08:41
|
*** venkaban has quit IRC
|
18:11:58
|
*** venkaban has joined #openmrs
|
18:12:23
|
<kreddy> bwolfe, djazayeri , dkayiwa wyclif mvorobey , Please report out the number of hours (actual time)it took for each individual ticket you worked on the current testing sprint. I am going to derive reports based on the time coding to strealine the sprinting process. Sprint leaders please make sure you estimate the time for each ticket and rest please code the time it took for you to complete that ticket
|
18:12:53
|
<kreddy> bwolfe, did i forget anyone?
|
18:13:03
|
<bwolfe> kreddy, venkaban and lakkarau
|
18:13:18
|
<bwolfe> and rafal, but he doesn't appear to be online
|
18:13:24
|
<kreddy> yes, :-)
|
18:13:31
|
<lakkarau> Bwolfe,yes
|
18:13:55
|
<bwolfe> lakkarau, was answering kreddy. :-) see his comment above
|
18:14:01
|
<kreddy> Please report out the number of hours (actual time)it took for each individual ticket you worked on the current testing sprint. I am going to derive reports based on the time coding to strealine the sprinting process. Sprint leaders please make sure you estimate the time for each ticket and rest please code the time it took for you to complete that ticket--venkaban, lakkarau
|
18:14:34
|
<kreddy> lakkarau, venkaban i forgot to include you in the developers chain
|
18:14:36
|
<kreddy> :-)
|
18:14:48
|
<venkaban> kreddy, hehe
|
18:18:54
|
<mvorobey> bwolfe, am actually tested reporting in browser, created new subversion tag and ready to commit, give me a green light please :)
|
18:19:08
|
<mvorobey> am - I
|
18:20:17
|
<bwolfe> green means go
|
18:20:33
|
<mvorobey> bwolfe, yes :)
|
18:25:25
|
<bwolfe> yes, yes it does
|
18:30:18
|
<bwolfe> mvorobey, note: you need to change the 1.5 in the root pom.xml to 1.6
|
18:30:23
|
<bwolfe> (for java version)
|
18:30:32
|
<mvorobey> bwolfe, did
|
18:30:40
|
<mvorobey> bwolfe, done :)
|
18:31:29
|
<bwolfe> mvorobey, good, now delete what you have, check it out as new maven project, and make sure you didn't miss anything.
|
18:31:30
|
<bwolfe> :-)
|
18:32:09
|
<mvorobey> bwolfe, I meant that I'm done with java version :)
|
18:32:20
|
<bwolfe> mvorobey, oh.
|
18:32:23
|
<mvorobey> bwolfe, not committed yet, svn issues
|
18:37:44
|
*** mgielow has joined #openmrs
|
18:37:47
|
<bwolfe> kreddy, downey: when I click "close/approve" or "committed code" for a ticket, I see a "time remaining on this ticket until its resolved" box.
|
18:37:48
|
*** mgielow has quit IRC
|
18:37:59
|
<bwolfe> shouldn't that be a "how many hours have you spent on this" box ?
|
18:39:06
|
<kreddy> downey, can you please answer this?
|
18:39:38
|
*** goutham has joined #openmrs
|
18:41:22
|
<goutham> dkayiwa: there?
|
18:41:35
|
<dkayiwa> goutham: yes
|
18:42:13
|
<downey> bwolfe kreddy: no
|
18:42:35
|
<goutham> dkayiwa: need suggestion in retrieving property data ,
|
18:42:42
|
<dkayiwa> ok
|
18:42:44
|
<downey> bwolfe: that's a re-estimate opportunity. work logged goes from the "Log Work" option in the button panel
|
18:43:18
|
<bwolfe> so now before I click 'committed code' I have to first click "log work" ?? :-/
|
18:43:21
|
<downey> bwolfe: (please do not interpret my explanation as an approval of atlassian's design decisions) :)
|
18:43:39
|
<goutham> dkayiwa: http://svn.openmrs.org/openmrs-modules/formfilter/trunk/omod/src/main/java/org/openmrs/module/formfilter/web/controller/AddFormFilterPropertyController.java as you can see in the post method... i am hard coding the values to set into property column
|
18:43:57
|
<goutham> dkayiwa: is there any work around?
|
18:44:51
|
<djazayeri> dkayiwa, goutham: btw, is the filtering forms project using the calculation module at all? Or building its own implementations of filters?
|
18:45:28
|
*** james_regen has left #openmrs
|
18:45:42
|
<downey> bwolfe: let me try to hack something up real quick
|
18:45:59
|
<dkayiwa> djazayeri: we have so far not used the calculation module. but could take advantage of it where you can advise
|
18:46:48
|
<djazayeri> dkayiwa: I'd just suggest that before you write _lots_ of different types of filters, you might want one that just says the form is included or excluded based on a patient calculation.
|
18:47:04
|
<dkayiwa> djazayeri: ok]
|
18:52:08
|
<goutham> dkayiwa:
|
18:52:26
|
<dkayiwa> goutham: like which value?
|
18:53:12
|
<downey> bwolfe: ok, i think i have added a way to do both log work and re-estimate on the workflow transitions
|
18:53:27
|
<goutham> dkayiwa : formFilterProperty.setProperties();
|
18:54:33
|
<bwolfe> downey, cool
|
18:54:49
|
<downey> bwolfe: hopefully the language won't be too confusing
|
18:54:53
|
<bwolfe> I think you can take off the "original estimate" though
|
18:55:06
|
<bwolfe> the "log work" section lets you update the original estimate
|
18:55:13
|
<dkayiwa> goutham: am not sure i understand
|
18:58:06
|
<goutham> dkayiwa: design page last mockup , property values of AgeFormFilterType
|
18:58:59
|
<dkayiwa> aha
|
18:59:38
|
<goutham> dkayiwa: i dont know which filter user chooses so iam manually checking by request.getParameter() and setting value as formFilterProperty.setProperties("minimumAge="+request.getParameter("minimumAge")+"&maximumAge="+request.getParameter("maximumAge"));
|
19:00:25
|
<dkayiwa> goutham: i though that the user selects a filter type before they can submit?
|
19:01:52
|
<goutham> dkayiwa: yes he will choose.. thats what for drop down is for !
|
19:02:19
|
<dkayiwa> goutham: so on submission you also send the type they have chosen
|
19:02:32
|
<goutham> dkayiwa: Yes
|
19:05:31
|
*** kavuri has quit IRC
|
19:08:29
|
*** applecool has quit IRC
|
19:08:58
|
*** jriley has quit IRC
|
19:12:19
|
<bwolfe> svn2git sucks
|
19:17:06
|
*** goutham has quit IRC
|
19:37:36
|
<lakkarau> lakkaraju has quit
|
19:37:48
|
*** lakkarau has quit IRC
|
19:39:32
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: #Melbourne: Write code & save lives at another #OpenMRS Hack Night this Wednesday. Free food! More info: http://t.co/A9HNeIkB <http://twitter.com/OpenMRS/statuses/214795446005145600>
|
19:40:58
|
*** venkaban_ has joined #openmrs
|
19:41:41
|
*** venkaban has quit IRC
|
19:43:19
|
*** suranga has quit IRC
|
19:43:27
|
*** diptanuc has joined #openmrs
|
19:45:05
|
*** lakkarau has joined #openmrs
|
19:48:20
|
*** jordank has joined #openmrs
|
19:53:26
|
<bwolfe> downey, why are the ci plans not running? https://ci.openmrs.org I clicked the "stop" button on the demo site earlier. is that not the right way to pass on that?
|
19:54:07
|
<downey> bwolfe: hm, that's not running either
|
19:54:29
|
*** mvorobey_ has joined #openmrs
|
19:55:27
|
*** mvorobey has quit IRC
|
19:55:46
|
*** mvorobey_ is now known as mvorobey
|
20:00:28
|
<bwolfe> mvorobey, did you log any hours when you did the 'committed code' on the reporting ticket?
|
20:02:48
|
<mvorobey> bwolfe, actually I left one hour as it was initially estimated
|
20:03:41
|
<bwolfe> see downey? the button that was there previously is not needed.
|
20:04:01
|
<bwolfe> mvorobey, click the "log work" button under "more actions" and add how many hours you have worked on it already
|
20:04:08
|
<downey> bwolfe: they were all in a queued state but nothing was running for some reason, no messages
|
20:04:20
|
<bwolfe> there is a 100% chance that all of my original estimates are wrong. :-)
|
20:04:34
|
<bwolfe> downey, how do you trigger it to start again? a restart?
|
20:04:40
|
<downey> bwolfe: sadly yes
|
20:04:45
|
*** lakkarau has quit IRC
|
20:04:47
|
*** lakkarau_ has joined #openmrs
|
20:04:54
|
<downey> Hi lakkarau_ and welcome to the #openmrs IRC channel.
|
20:05:16
|
<mvorobey> bwolfe, done
|
20:05:16
|
<lakkarau_> downey:hi
|
20:05:39
|
<bwolfe> venkaban_, I don't see a sprint ticket assigned to you on the sprint dashboard. (https://tickets.openmrs.org/secure/Dashboard.jspa?selectPageId=11852)
|
20:05:46
|
<bwolfe> venkaban_, which one are you working on?
|
20:06:12
|
*** maurya has quit IRC
|
20:07:03
|
<mvorobey> bwolfe, do I need to announce on dev that reporting module is already mavenized ?
|
20:09:47
|
* downey figures we should do something more productive with https://groups.google.com/a/openmrs.org/forum/?fromgroups#!forum/modules
|
20:09:50
|
<OpenMRSBot> <http://ln-s.net/$JQN> (at groups.google.com)
|
20:11:23
|
*** kreddy has quit IRC
|
20:13:08
|
*** mccallumg_ has joined #openmrs
|
20:13:08
|
*** ChanServ sets mode: +v mccallumg_
|
20:16:07
|
*** mccallumg has quit IRC
|
20:16:07
|
*** mccallumg_ is now known as mccallumg
|
20:16:08
|
<mvorobey> bwolfe, so ?
|
20:17:10
|
*** jriley has joined #openmrs
|
20:24:23
|
<bwolfe> mvorobey, yes, you can send an email reply to my previous one saying that both htmlwidgets and reporting have been mavenized. link to the "converting old code to maven" page for a way to convert old ant-style patches to maven-style patches
|
20:25:36
|
<mvorobey> bwolfe, ... :) but htmlwidgets not mavenized yet :)
|
20:25:59
|
<bwolfe> mvorobey, are you sure? ;-)
|
20:26:15
|
* bwolfe waves hand. ....look again....
|
20:26:59
|
<mvorobey> bwolfe, huh, you got me :)
|
20:32:27
|
<mvorobey> bwolfe, just to be sure, did you mean your mail on Moving Newly Mavenized Bundled Modules to Git topic ?
|
20:34:02
|
<bwolfe> yeah. the actual moving to git is proving troublesome for me
|
20:36:39
|
<mvorobey> bwolfe, already sent an announcing mail
|
20:37:07
|
<bwolfe> saw it, thanks!
|
20:38:01
|
<mvorobey> bwolfe, you are always welcome :)
|
20:38:09
|
*** goutham has joined #openmrs
|
20:38:35
|
<goutham> dkayiwa: i m getting error with uuid.. im unable to autogenerate it
|
20:39:10
|
*** jordank has quit IRC
|
20:40:39
|
<goutham> harshadura , pulasthi7 u worked with database column uuid ?
|
20:44:53
|
<goutham> bwolfe: der?
|
20:45:51
|
*** rafa has joined #openmrs
|
20:45:51
|
*** ChanServ sets mode: +v rafa
|
20:46:21
|
<bwolfe> goutham, I am here for a little bit longer yes
|
20:47:48
|
<goutham> bwolfe: can you help me with uuid column... trouble iam facing is.. the uuid are not getting auto-update even though my bean extends from baseopenmrsobject...
|
20:48:51
|
<goutham> bwolfe: should extending from baseopenmrsobject is alone sufficient or should i need to write some thing else?
|
20:50:04
|
<bwolfe> goutham, your service needs to have the right listener on it.
|
20:50:22
|
<bwolfe> goutham, do you have the "listeners" list on your service in your spring moduleAppContext.xml file?
|
20:52:20
|
<goutham> bwolfe: moduleAppContext.xml http://pastebin.com/UvppcgDc
|
20:52:46
|
<bwolfe> goutham, ah yes, I meant "serviceInterceptors"
|
20:53:01
|
<bwolfe> goutham, is the uuid column is your hibernate mapping xml file?
|
20:53:11
|
<bwolfe> errr, *column in
|
20:54:37
|
<goutham> bwolfe: yes http://pastebin.com/eV7kjf9p
|
20:55:10
|
<bwolfe> goutham, and you have a uuid column on your table? :-)
|
20:56:21
|
*** jordank has joined #openmrs
|
20:56:22
|
<goutham> bwolfe: Yes :( http://pastebin.com/qjiPKzHd
|
20:56:53
|
<bwolfe> goutham, double check your database.
|
20:57:06
|
<bwolfe> goutham, can you send me your FormFilter pojo class too?
|
20:59:21
|
<goutham> bwolfe: i checked in db its there.. here goes formfilter pojo http://pastebin.com/b59kpDKf :)
|
21:03:17
|
<mvorobey> djazayeri, hi
|
21:03:26
|
<djazayeri> hi
|
21:04:16
|
<mvorobey> djazayeri, I did not get about a slow connection from your previous reply on my mail :) What did you mean ?
|
21:05:00
|
<djazayeri> I mean that if someone is on a slow network connection, especially one where they pay by the megabyte, they might not want to download the mavenized reporting module yet, if it's about to _also_ move to git
|
21:05:00
|
<mvorobey> on = to
|
21:05:14
|
<goutham> bwolfe: what else i could be missing ?
|
21:06:17
|
<mvorobey> djazayeri, i'd move it to git ASAP if I'd have a project to move onto :)
|
21:06:59
|
<djazayeri> mvorobey: really it's a question for bwolfe: are we planning to move reporting to git during this sprint? If so, mvorobey should also announce that via email
|
21:08:28
|
<bwolfe> goutham, I don't know why its not doing it. :-/
|
21:09:05
|
<bwolfe> djazayeri, mvorobey: might as well. mike gave the go ahead. and I think there are some reporting tickets that wyclif is supposed to work on. so now is the time
|
21:10:23
|
<goutham> bwolfe: I will Investigate it and try to find solution ..thanks for the support :)
|
21:10:35
|
<bwolfe> goutham, try a clean install of your openmrs
|
21:10:39
|
<mvorobey> bwolfe, Houston, can I start migration process ?
|
21:10:57
|
<djazayeri> okay, so mvorobey, you should reply to my email and say something like: Yes, we will also be moving these modules to git within the next week or two, so if you have limited internet connectivity, you might want to wait before re-downloading.
|
21:11:13
|
<bwolfe> mvorobey, yeah, go for it. whats your username on github?
|
21:11:27
|
<mvorobey> bwolfe, mvorobey
|
21:11:35
|
<bwolfe> mvorobey, oh, you're there already. do you have permissions to create a repo, or do you want me to do it?
|
21:12:01
|
<mvorobey> bwolfe, please, do it for me :)
|
21:12:11
|
<bwolfe> done. https://github.com/bwolfe/openmrs-module-reporting
|
21:12:12
|
<goutham> bwolfe: Ok
|
21:12:16
|
<bwolfe> mvorobey, follow this wiki page:
|
21:12:17
|
<OpenMRSBot> <http://ln-s.net/$JRj> (at github.com)
|
21:12:21
|
<bwolfe> https://wiki.openmrs.org/display/docs/Migrating+to+Git#MigratingtoGit-Authors
|
21:12:24
|
<bwolfe> err
|
21:12:33
|
<bwolfe> (minus the authors hash)
|
21:12:33
|
<bwolfe> https://wiki.openmrs.org/display/docs/Migrating+to+Git
|
21:12:53
|
<bwolfe> the bit from rowan about "slow connections" and removing jars are in there somewhere
|
21:13:29
|
<bwolfe> I can't get the svn2git to work on the htmlwidgets. so let me know what you do and if you figure out hte trick!
|
21:13:43
|
<mvorobey> bwolfe, do I need retire old modules on svn too ?
|
21:13:47
|
*** rafa has quit IRC
|
21:13:49
|
<bwolfe> I have to run for a few hours, I'll try to check back in here, but best bet is to email me if you have questions
|
21:13:57
|
<bwolfe> mvorobey, yeah, we can do that after the migration to git
|
21:14:02
|
<bwolfe> (see that wiki page about htat too)
|
21:14:24
|
<mvorobey> bwolfe, ok, good luck :)
|
21:14:40
|
<bwolfe> bbl
|
21:16:31
|
*** pulasthi7 has quit IRC
|
21:20:21
|
*** jordank has quit IRC
|
21:22:03
|
<mvorobey> djazayeri, by the way, do you have a shared author.txt file where svn account mapped to Git ones ?
|
21:22:44
|
<djazayeri> mvorobey: *I* don't, but I assume that Rowan and Mark created one when they mavenized HFE.
|
21:22:48
|
<djazayeri> sorry, git-ized HFE
|
21:23:09
|
<djazayeri> Is there none mentioned in the instructions for git-izing?
|
21:23:31
|
<mvorobey> djazayeri, no, ungort
|
21:23:41
|
<mvorobey> unfortunately
|
21:24:46
|
<djazayeri> mvorobey: I suggest emailing the dev list, and specifically calling out Rowan, Mark, and Rafal, to see if anyone already has this.
|
21:24:57
|
<djazayeri> mvorobey: and then make sure it gets up on the wiki, along with any edits you may make.
|
21:26:13
|
<mvorobey> djazayeri, thanks, one more question, how do you think, how many megabytes of Internet traffic the conversion will take ?
|
21:27:03
|
<djazayeri> mvorobey: no idea. Actually, come to think of it, since you've already switched this to maven, downloading once with svn and once with git won't cost much
|
21:27:22
|
<djazayeri> are there any jars left over that weren't available via maven?
|
21:27:38
|
<djazayeri> I forgot about that: this might not be worth worrying about. :-)
|
21:27:39
|
<mvorobey> no jars
|
21:27:43
|
<wyclif> hi djazayeri
|
21:28:26
|
*** wyclif__ has joined #openmrs
|
21:28:40
|
<downey> Hi wyclif__ and welcome to the #openmrs IRC channel.
|
21:29:28
|
<djazayeri> mvorobey: Okay, then instead you should reply to my email and say that one of the benefits mavenizing is that if you check it out in svn and then again from git, it won't be much additional download, since you'll already have the dependencies in your local maven repo. (But still, some might not want to reconfigure this in their eclipse workspace twice in 2 weeks if they aren't planning to do any development in the meantime.
|
21:29:29
|
<djazayeri> wyclif: hi
|
21:29:52
|
<djazayeri> and wyclif__: hi
|
21:30:33
|
<mvorobey> djazayeri, but I mean about svn2git, AFAIR, it converts tags, branches, revs, so, for reporting module with all its libs it may take more than you suggested, do not it ?
|
21:31:01
|
<djazayeri> mvorobey: oh, well, as long as the jars aren't there, that's the main thing
|
21:31:14
|
<wyclif__> djazayeri, if i create a new hfe tag, which other change needs to be made to have it displayed on the form
|
21:31:40
|
<mvorobey> djazayeri, am talking only about myself because I have very limited connection at home :)
|
21:31:50
|
<djazayeri> mvorobey: oh, I don't know. :-)
|
21:32:33
|
<djazayeri> mvorobey: if svn2git is going to download the lib/jars for you, that is going to be many megabytes. I don't know how svn2git works though
|
21:32:47
|
<djazayeri> wyclif: look at the others. I don't remember if you need to register it in the moduleApplicationContext or what.
|
21:33:51
|
<mvorobey> djazayeri, last time, when I was git-izing CSTM, it was almost like we are suggesting right now
|
21:33:53
|
<djazayeri> mvorobey: btw, the page https://wiki.openmrs.org/display/docs/Migrating+to+Git#MigratingtoGit-Authors
|
21:34:07
|
<djazayeri> this suggests how to generate the list of svn accounts
|
21:34:10
|
<djazayeri> is that not enough?
|
21:34:51
|
<mvorobey> djazayeri, but we need to map that account to GitHub ones, do not we ?
|
21:34:59
|
<djazayeri> mvorobey: hmm, yeah.
|
21:35:07
|
<djazayeri> mvorobey: okay, so email rowan, mark, and rafal.
|
21:36:09
|
<mvorobey> so, starting this moment am already looking for those mappings on mail, thanks
|
21:40:33
|
<venkaban_> bwolfe, I went out for lunch
|
21:41:15
|
<venkaban_> bwolfe, Sorry I had missed your message, I will assign a tcket to myself and work on it
|
21:43:39
|
*** goutham has quit IRC
|
21:49:22
|
<lakkarau_> downey:hi
|
21:50:16
|
*** dkayiwa has quit IRC
|
21:52:16
|
*** wyclif__ has quit IRC
|
21:52:16
|
*** wyclif has quit IRC
|
21:52:21
|
<downey> lakkarau_: hi
|
21:52:38
|
<lakkarau_> downey: i am assigned ticket but it is send to my "ulakkaraju@gmail.com" account .how can i change the email address to "uma.lakkaraju@merck.com".any link is available.
|
21:53:16
|
<downey> lakkarau_: You can change your primary e-mail address at https://id.openmrs.org/
|
21:53:51
|
<lakkarau_> downey :thats great, i will try.
|
21:54:20
|
<downey> lakkarau_: if you have any problems with that, just open a ticket at http://go.openmrs.org/helpdesk and it can be manually updated
|
21:54:49
|
<lakkarau_> downey:ok
|
22:02:07
|
<lakkarau_> downey:Thanks
|
22:12:39
|
*** mvorobey has quit IRC
|
22:14:38
|
*** diptanuc has quit IRC
|
22:27:06
|
*** lh has quit IRC
|
22:50:18
|
*** wyclif has joined #openmrs
|
22:50:37
|
*** wyclif__ has joined #openmrs
|
22:55:18
|
*** downey has quit IRC
|
23:08:43
|
*** mccallumg has quit IRC
|
23:13:58
|
*** lakkarau_ has quit IRC
|
23:53:25
|
<venkaban_> djazayeri, Hi
|
23:53:41
|
<djazayeri> hi venkaban_
|
23:54:10
|
<venkaban_> djazayeri, I have some questions in the criteria while joining two tables
|
23:54:53
|
*** lh has joined #openmrs
|
23:54:53
|
*** lh has joined #openmrs
|
23:55:04
|
<djazayeri> okay
|
23:56:14
|
<venkaban_> djazayeri, when we use two tables, how do we combine them using criteria. I have experience writting HQLs in a different way.
|
23:57:02
|
<venkaban_> djazayeri, http://pastebin.com/2wkRedFp is the link for the code that is giving me trouble
|
23:57:32
|
<djazayeri> venkaban_: what's the quick summary of what you're trying to query for?
|
23:57:57
|
<venkaban_> djazayeri, trying to get conceptClass based on the concept id present in order table
|
23:58:35
|
<djazayeri> venkaban_: and you need to do this in bulk? (I.e. you can't just do o.getConcept().getConceptClass() ?)
|
23:59:12
|
<djazayeri> meaning this is the criteria equivalent of "from Order where concept.conceptClass in :conceptClasses" ?
|