| 00:01:54 | <venkaban_> wyclif, hi |
| 00:07:48 | <wyclif> hi venkaban_ |
| 00:08:22 | <venkaban_> wyclif, there are a lot of files that need to be changed.....are you sure that all the files need to be changed |
| 00:14:20 | <wyclif> venkaban_, the only change you have to make is to add the extra argument to the service, its impl and any corresponding/necessary method in the DAO |
| 00:15:27 | *** jordank has quit IRC |
| 00:15:29 | *** elliott_w has joined #openmrs |
| 00:15:29 | *** ChanServ sets mode: +o elliott_w |
| 00:16:41 | <wyclif> venkaban_, if you use eclipse tool for editing a method signature, this should cake |
| 00:17:17 | <wyclif> venkaban_, because that will make any changes to references to the method |
| 00:21:33 | <venkaban_> I have made the changes to all the required files and did maven install and it is successfull now |
| 00:21:44 | <wyclif> venkaban_, cool |
| 00:21:44 | <venkaban_> I think this should be good right wyclif? |
| 00:21:48 | <wyclif> venkaban_, and the unit tests? |
| 00:22:16 | <venkaban_> updated the methods in unit tests with the extra parameter wyclif |
| 00:22:42 | <venkaban_> wyclif, when we run maven install it will automatically execute the tests right? |
| 00:29:56 | <venkaban_> wyclif, you there? |
| 00:32:01 | <venkaban_> bwolfe, Hi |
| 00:32:18 | <wyclif> venkaban_, i hope u included a control test that ensures that if the argument is null things still work as expected |
| 00:33:00 | <venkaban_> wyclif, I dint create a new test. I just updated the existing tests with the extra argument. |
| 00:33:15 | <venkaban_> wyclif, Should be there be a new one to be added for validation? |
| 00:34:13 | <wyclif> venkaban_, i always good to test a change with a test sepcific to it, i have a feeling the existing tests didint enforce the argument since it was none existent |
| 00:34:56 | <venkaban_> wyclif, the extra argument for concept classes what does it exactly mean, so that I will add tests to it |
| 00:35:21 | <wyclif> venkaban_, what am trying to say is that, ensure there is a test or tests that ensure when the argument is null you get back different results and vice versa |
| 00:36:16 | <venkaban_> wyclif, Ok |
| 00:54:47 | *** venkaban_ has quit IRC |
| 00:54:55 | *** elliott_w has quit IRC |
| 01:22:56 | *** lh has quit IRC |
| 02:29:19 | <djazayeri> Getting a 5xx on modules.openmrs.org |
| 02:43:08 | *** yanokwa has quit IRC |
| 02:58:32 | *** harshadura has quit IRC |
| 03:01:05 | *** robbyoconnor has joined #openmrs |
| 03:01:05 | *** ChanServ sets mode: +v robbyoconnor |
| 03:15:01 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: UI Library Module 1.3 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=uilibrary&version=&1.3> || OpenMRS Modules: OpenMRS UI Framework 1.5 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=uiframework&version=&1.5> |
| 03:22:37 | *** harshadura has joined #openmrs |
| 03:25:16 | *** ChanServ sets mode: +v harshadura |
| 03:26:11 | *** r0bby has joined #openmrs |
| 03:26:11 | *** ChanServ sets mode: +v r0bby |
| 03:28:04 | *** wyclif has quit IRC |
| 03:28:28 | *** wyclif has joined #openmrs |
| 03:29:58 | *** robbyoconnor has quit IRC |
| 03:31:36 | *** harshadura has quit IRC |
| 03:31:48 | *** harshadura has joined #openmrs |
| 03:32:42 | *** jordank has joined #openmrs |
| 03:36:50 | *** ChanServ sets mode: +v harshadura |
| 03:52:57 | *** bwolfe has quit IRC |
| 03:56:17 | *** harshadura has quit IRC |
| 03:56:31 | *** harshadura has joined #openmrs |
| 04:38:56 | *** harshadura has quit IRC |
| 04:41:09 | *** upul` has joined #openmrs |
| 04:41:09 | *** ChanServ sets mode: +v upul` |
| 05:04:51 | *** Mkop has quit IRC |
| 05:07:48 | *** mgielow has joined #openmrs |
| 05:08:30 | *** jordank has quit IRC |
| 05:17:09 | *** harshadura has joined #openmrs |
| 05:22:47 | *** deepaganu has joined #openmrs |
| 05:24:43 | <deepaganu> hi all |
| 05:28:57 | *** r0bby has quit IRC |
| 05:29:39 | *** lakkarau has joined #openmrs |
| 05:32:10 | *** harshadura has quit IRC |
| 05:36:24 | *** robbyoconnor has joined #openmrs |
| 05:36:24 | *** ChanServ sets mode: +v robbyoconnor |
| 05:43:01 | *** harshadura has joined #openmrs |
| 05:44:23 | *** suranga has joined #openmrs |
| 05:44:23 | *** ChanServ sets mode: +v suranga |
| 05:50:09 | *** dkayiwa has joined #openmrs |
| 06:05:02 | *** finbrein has joined #openmrs |
| 06:11:53 | *** mgielow has quit IRC |
| 06:15:08 | *** sunbiz has joined #openmrs |
| 06:15:09 | *** ChanServ sets mode: +v sunbiz |
| 06:18:16 | *** goutham has joined #openmrs |
| 06:20:56 | *** sunbiz has quit IRC |
| 06:29:29 | *** deepaganu has quit IRC |
| 07:13:10 | *** magoo_ has joined #openmrs |
| 07:13:59 | *** sansa has joined #openmrs |
| 07:52:10 | *** harshadura has quit IRC |
| 07:57:25 | <sansa> hello, i am trying to run the standalone edition ..and i keep getting these erroes : |
| 07:57:26 | <sansa> http://pastebin.com/MnNHcUsE |
| 07:57:33 | <sansa> please someone help me |
| 07:57:38 | *** suranga has quit IRC |
| 08:08:11 | <sansa> djazayeri : can you help me? |
| 08:18:46 | *** magoo_ has quit IRC |
| 08:24:30 | <sansa> hi! could anybody please help me? why am i getting sql errors .should i try a lower version? |
| 08:32:52 | <goutham> dkayiwa: i sent a mail to you ,can you see if covers all points and gives idea to reader. If its good i will mail to developers |
| 08:33:06 | <dkayiwa> goutham: ok |
| 08:33:18 | <dkayiwa> not yet got it though |
| 08:33:59 | <dkayiwa> oh seen it |
| 08:34:35 | *** snoppy has joined #openmrs |
| 08:35:30 | *** suranga has joined #openmrs |
| 08:35:43 | <dkayiwa> goutham: what does ex mean? |
| 08:36:06 | <goutham> dkayiwa: EXample :/ |
| 08:36:26 | <dkayiwa> goutham: can you expand instead of abbreviating it? |
| 08:36:53 | <dkayiwa> goutham: also what does this mean? **Note: For each category of filter admin can create only one filter against form (ex: for a Xform only one gender category filter can be created either with male or female as property ) |
| 08:38:00 | *** rafa has joined #openmrs |
| 08:38:00 | *** ChanServ sets mode: +v rafa |
| 08:38:24 | <goutham> dkayiwa: Against a form , admin can only create single AgeFormFilter |
| 08:38:49 | <dkayiwa> goutham: why would you want him to be restricted to just one? |
| 08:39:59 | <goutham> dkayiwa: because he cannot choose two filters with one Male property and other one with female as property |
| 08:40:22 | <goutham> dkayiwa: it would conflict and form will never be shown |
| 08:41:12 | <dkayiwa> goutham: how about if he wants one filter where gender is equal to M, and OR where gender is UNKNOWN (2 gender filters)? |
| 08:43:54 | <goutham> dkayiwa: Errr...my bad...dint think of UNKNOWN |
| 08:44:27 | <dkayiwa> goutham: would even be easier for you to implement if you do not restrict :) |
| 08:46:12 | *** magoo_ has joined #openmrs |
| 08:48:25 | <goutham> dkayiwa: To define a filter , will there be a seperate input form for each category or by combining all parameters of patient single input form? |
| 08:49:25 | *** snoppy has quit IRC |
| 08:51:32 | <dkayiwa> goutham: when defining a filter, one starts by choosing a category |
| 08:51:50 | <dkayiwa> goutham: then you know which parameters to display because they depend on category |
| 08:51:54 | <dkayiwa> goutham: not so? |
| 08:52:39 | *** suranga has quit IRC |
| 08:54:36 | *** magoo_ has quit IRC |
| 08:55:05 | <goutham> dkayiwa: no it is same as you said ... thanks :) |
| 08:56:42 | <dkayiwa> goutham: let me be back in a couple of hours :) |
| 08:57:33 | <goutham> dkayiwa: Ok its lunch time for you i guess : ) |
| 08:57:42 | <dkayiwa> :) |
| 08:57:52 | *** snoppy has joined #openmrs |
| 08:58:05 | *** dkayiwa has quit IRC |
| 09:01:27 | <goutham> \quit |
| 09:01:30 | *** goutham has quit IRC |
| 09:03:15 | *** sansa has quit IRC |
| 09:14:34 | *** harshadura has joined #openmrs |
| 09:24:23 | *** applecool has joined #openmrs |
| 09:24:23 | *** ChanServ sets mode: +v applecool |
| 09:30:57 | <applecool> hi rafa |
| 09:31:05 | <rafa> hi applecool |
| 09:31:32 | <applecool> i dint fix the test yet! but i wil do it later! but i want to complete the actual tasks! |
| 09:31:34 | <applecool> is it oksy? |
| 09:31:44 | <applecool> okay* |
| 09:32:02 | <applecool> i mean the 4th weeks tasks |
| 09:32:12 | <rafa> applecool: what do you mean later? |
| 09:32:35 | <applecool> after this 4th week tasks! |
| 09:32:58 | <rafa> applecool: hmmm I don't like that approach |
| 09:33:08 | <rafa> applecool: failing tests are a bad sign |
| 09:33:15 | <applecool> okay |
| 09:33:38 | <rafa> applecool: I can agree if you promise not to introduce more failing tests? :) |
| 09:34:00 | <rafa> applecool: which tests fail? |
| 09:34:21 | <applecool> only one! PackageFormControllerTest |
| 09:34:52 | <rafa> applecool: only? |
| 09:34:56 | <rafa> applecool: why don't we fix that? |
| 09:35:30 | <applecool> i am unable to fix it! do you want to see the stack trace! i understood the problem but .. |
| 09:35:52 | <rafa> applecool: okay, what is your approach when you try to fix the test? |
| 09:36:05 | <rafa> applecool: first you look at the stack trace right? |
| 09:36:10 | <applecool> yes! |
| 09:36:19 | <applecool> and the reason how it caused! |
| 09:36:25 | <rafa> applecool: and you see which line fails |
| 09:36:29 | <applecool> yes |
| 09:36:43 | <rafa> applecool: so which line fails for us? |
| 09:37:15 | <applecool> 2 lines! one is when we are calling the form.onSubmit |
| 09:37:29 | <applecool> in the testSave and in testRemove |
| 09:38:03 | <applecool> the parameter which i am passing is a MetadataPackage object |
| 09:38:04 | <rafa> applecool: ok, but what fails in form.onSubmit? |
| 09:39:20 | <rafa> applecool: which line fails inside PackageFormController? |
| 09:40:32 | <rafa> applecool: you can find that in the stack trace too |
| 09:40:49 | <applecool> yes i know! i m running it!..so took some time |
| 09:41:05 | <applecool> its on 86 line! |
| 09:41:50 | <rafa> applecool: so is id null |
| 09:41:51 | <rafa> ? |
| 09:42:06 | <applecool> yes |
| 09:42:46 | <rafa> applecool: ok, so let's see how we get the id |
| 09:42:59 | <rafa> applecool: line 84: String id = (String) request.getSession().getAttribute("id"); |
| 09:43:24 | <rafa> applecool: we get it out of a session |
| 09:43:25 | <applecool> yes |
| 09:43:32 | <rafa> applecool: apparently it's not there |
| 09:43:42 | <rafa> applecool: let's see again testSave |
| 09:43:48 | <applecool> okay |
| 09:43:58 | <rafa> applecool: line 54: request.addParameter("id", "1"); |
| 09:44:18 | <rafa> applecool: we set an id, but have you noticed a difference? |
| 09:44:18 | <applecool> yes |
| 09:44:38 | <rafa> applecool: that is? |
| 09:45:17 | <applecool> we are not setting any context parameter to get the attribute |
| 09:45:25 | <applecool> is that right? |
| 09:45:34 | <rafa> applecool: context parameter? |
| 09:46:29 | <rafa> applecool: again: |
| 09:46:32 | <rafa> applecool: request.getSession().getAttribute |
| 09:46:41 | <rafa> applecool: request.addParameter |
| 09:46:47 | <rafa> applecool: see the difference? |
| 09:47:18 | <applecool> we are getting it from the session and in the other we are directly adding the parameter |
| 09:47:26 | <rafa> applecool: correct |
| 09:48:04 | <rafa> applecool: you can either pass a parameter in a request that is if you say something like index.form?id=2 |
| 09:48:26 | *** magoo_ has joined #openmrs |
| 09:48:32 | <rafa> applecool: or store it in a session on the server side so that you won't see it in a URL |
| 09:48:43 | <rafa> applecool: or in the post data |
| 09:49:12 | <rafa> applecool: so what you actually did wrong is that you're trying to get the attribute out of a session |
| 09:49:57 | <rafa> applecool: is that clear? |
| 09:50:13 | <applecool> yes |
| 09:50:24 | <rafa> applecool: so let's take a step further |
| 09:50:32 | <rafa> applecool: back in onSubmit method |
| 09:50:32 | <applecool> okay |
| 09:50:54 | <rafa> applecool: lines 67, 72, 80 |
| 09:51:09 | <rafa> applecool: you see that you can get an id from pkg |
| 09:51:19 | <applecool> yes |
| 09:51:21 | <rafa> applecool: which is MetadataPackage |
| 09:51:35 | <rafa> applecool: it's passed as a parameter to the onSubmit method |
| 09:51:40 | <applecool> yes |
| 09:52:10 | <rafa> applecool: how does the might Spring know what to pass there? |
| 09:52:38 | <rafa> applecool: it's specified in the showForm method |
| 09:53:00 | <rafa> applecool: this method is annotated with @ModelAttribute |
| 09:53:10 | *** harshadura has quit IRC |
| 09:53:16 | <rafa> applecool: it means it's capable of creating MetadataPackage |
| 09:53:29 | <rafa> applecool: because it returns one |
| 09:53:39 | <rafa> applecool: and see the argument id |
| 09:53:40 | *** harshadura has joined #openmrs |
| 09:53:58 | <rafa> applecool: it's @RequestParam |
| 09:54:14 | <rafa> applecool: so Spring looks for an id in a request |
| 09:55:31 | <applecool> okay |
| 09:55:32 | <rafa> applecool: and the MetadataPackage is either created or retrieved from a db depending on if the id was in a request or not |
| 09:55:48 | <applecool> yes |
| 09:57:47 | <rafa> applecool: one more thing is that when you do http request, Spring creates MetadataPackage (using showForm) and then is clever enough to set all fields that were found in the post data |
| 09:58:20 | <rafa> applecool: so if it sees name in the http request, then it calls pkg.setName(name) |
| 09:59:30 | <rafa> applecool: so back to the onSubmit method |
| 09:59:39 | <applecool> ok |
| 09:59:41 | <rafa> applecool: what we don't need? |
| 09:59:52 | <rafa> applecool: what does Spring do for us? |
| 10:00:49 | <rafa> applecool: you need to tell me :) |
| 10:02:13 | <rafa> applecool: are you there? |
| 10:05:56 | <applecool> we we do onSubmit() with the @RequestParam the spring sets the id and which we can access it through the getId and store it on session |
| 10:06:26 | <rafa> applecool: forget about the session |
| 10:06:35 | <rafa> applecool: id is just a plain number |
| 10:06:46 | <applecool> yes it is |
| 10:06:58 | <rafa> applecool: we can pass it as long as we want in the URL |
| 10:07:35 | <rafa> applecool: session is for things that you want to hide from a user |
| 10:08:05 | <rafa> applecool: either are too big to put them in a URL or you don't want a user to see them |
| 10:08:06 | <applecool> yes |
| 10:08:14 | <rafa> applecool: do we need line 84? |
| 10:08:46 | <rafa> applecool: String id = (String) request.getSession().getAttribute("id"); |
| 10:09:33 | <rafa> applecool: quick answer |
| 10:10:14 | <applecool> we require it right? |
| 10:10:26 | <rafa> applecool: no! |
| 10:10:35 | <rafa> applecool: we can get an id from pkg.getId()! |
| 10:10:45 | <applecool> oh whoops |
| 10:10:51 | <rafa> applecool: do we need line 86? |
| 10:11:46 | <applecool> no |
| 10:11:54 | <rafa> applecool: correct it's nonsense |
| 10:12:01 | <rafa> applecool: metadataPackage == pkg |
| 10:12:12 | <applecool> yes |
| 10:12:25 | <rafa> applecool: what about lines 87-89? |
| 10:12:58 | <applecool> no need at all! |
| 10:13:31 | <rafa> applecool: yes, Spring does all that for us |
| 10:13:49 | <applecool> hmm |
| 10:13:51 | <rafa> applecool: what about line 90? |
| 10:14:59 | <applecool> metadataPackage can be replaced with pkg |
| 10:15:09 | <rafa> applecool: yes |
| 10:15:39 | <rafa> applecool: get rid of that debug, it doesn't print anything useful |
| 10:16:00 | <applecool> okay :) |
| 10:16:02 | <rafa> applecool: what are lines 93-95 for? |
| 10:16:31 | <applecool> to show the values on the uploadDisplay page |
| 10:16:52 | <rafa> applecool: what is uploadDisplay page? |
| 10:17:06 | <rafa> applecool: what jsp is that? |
| 10:17:13 | <applecool> the page which comes after the uploadDisplay |
| 10:18:29 | <rafa> applecool: ok, I see now |
| 10:18:35 | <rafa> applecool: that is correct |
| 10:18:59 | <rafa> applecool: so have you made changes we just discussed? |
| 10:19:10 | <rafa> applecool: how do you run the test now? |
| 10:19:13 | <applecool> changing them! |
| 10:20:40 | <applecool> test! |
| 10:20:51 | <rafa> applecool: how do you run the test? |
| 10:21:07 | <rafa> applecool: just run that single test |
| 10:21:19 | <applecool> okay |
| 10:21:25 | <rafa> applecool: can you do that? |
| 10:21:53 | <applecool> yes |
| 10:22:00 | <rafa> applecool: how? |
| 10:23:16 | <rafa> applecool: how do you run a single test in eclipse? |
| 10:23:19 | <applecool> i dint get you rafa |
| 10:23:26 | <applecool> run as jUnitTest |
| 10:23:41 | <rafa> applecool: ok |
| 10:23:46 | <rafa> applecool: did it pass? |
| 10:25:07 | <applecool> its running! just a sec |
| 10:26:12 | <rafa> applecool: how long does it take for you? |
| 10:26:17 | <applecool> it passed |
| 10:26:48 | <rafa> applecool: cool |
| 10:27:11 | <rafa> applecool: now run the full build with tests and see if everything passes |
| 10:27:31 | <rafa> applecool: you need to learn more about Spring MVC |
| 10:27:38 | <rafa> applecool: read: http://static.springsource.org/spring/docs/current/spring-framework-reference/html/mvc.html |
| 10:27:42 | <OpenMRSBot> <http://ln-s.net/$Hky> (at static.springsource.org) |
| 10:27:54 | <applecool> yes true |
| 10:28:24 | <rafa> applecool: I wonder if I should exam you :D |
| 10:28:33 | <applecool> :P |
| 10:29:13 | <rafa> applecool: I'll do if you make such mistakes again |
| 10:29:13 | <applecool> not needed i hope! :P because i know Spring but i m not a master in it! :D |
| 10:29:27 | <applecool> okay sure |
| 10:30:29 | <rafa> applecool: ok are you all set for next tasks? |
| 10:30:32 | <rafa> applecool: any questions? |
| 10:30:53 | <applecool> i m running it! will tell you in two minutes |
| 10:31:17 | <rafa> applecool: also one more thing is that I want you to use code formatting before you commit |
| 10:31:30 | <rafa> applecool: I forget to mention it before |
| 10:31:40 | <applecool> okay |
| 10:31:56 | <rafa> applecool: eclipse has a shortcut ctrl + shift + f |
| 10:32:18 | <rafa> applecool: make it a habit and do that before you save a file |
| 10:32:26 | <applecool> okay |
| 10:33:09 | *** magoo_ has quit IRC |
| 10:47:57 | *** dkayiwa has joined #openmrs |
| 11:03:08 | *** dkayiwa has quit IRC |
| 11:15:03 | *** james_regen has joined #openmrs |
| 11:15:03 | *** ChanServ sets mode: +v james_regen |
| 11:26:07 | <applecool> okay everything is fine now rafa i will start with the fourth week goals |
| 11:26:29 | <applecool> i committed the changes and made pushed it |
| 11:26:36 | *** upul` has quit IRC |
| 11:26:43 | <applecool> with the code formatting too rafa |
| 11:40:48 | *** magoo_ has joined #openmrs |
| 11:42:24 | <magoo_> hi +rafa |
| 11:45:36 | *** robbyoconnor has quit IRC |
| 11:46:00 | <magoo_> +rafa i have downgraded svn to 1.7.1 do i need to delete all the maven projects in workspace before checking out the project |
| 11:47:31 | *** applecool has quit IRC |
| 11:48:47 | *** bwolfe has joined #openmrs |
| 11:48:47 | *** ChanServ sets mode: +o bwolfe |
| 11:50:22 | *** wyclif has quit IRC |
| 11:52:56 | *** bwolfe has quit IRC |
| 11:56:14 | *** sansa_g has joined #openmrs |
| 11:59:55 | <sansa_g> hi ,i am sansa .after an unsuccessful trial with standalone version . i am now trying the enterprise edition |
| 12:00:02 | <rafa> magoo_: you mean yo downgraded svn to 1.6.x? |
| 12:00:26 | <sansa_g> but i get this error when i try to deploy the .war file |
| 12:00:28 | <sansa_g> http://pastebin.com/u9jYFsxp |
| 12:00:39 | <sansa_g> please help me community!! |
| 12:01:46 | <rafa> sansa_g: are you deploying with Tomcat Manager? put the war in tomcat/webapp instead |
| 12:01:51 | <sansa_g> yes |
| 12:02:02 | <sansa_g> ok,i will try that |
| 12:02:02 | <magoo_> +rafa previously i had svn 1.7.5 and downgraded to svn 1.7.1 |
| 12:02:31 | <rafa> magoo_: I don't think it makes a difference. You should downgrade to 1.6.x |
| 12:02:38 | *** suranga has joined #openmrs |
| 12:02:38 | *** ChanServ sets mode: +v suranga |
| 12:04:00 | <magoo_> +rafa okay |
| 12:05:26 | <sansa_g> +rafa i cp it .what next? |
| 12:05:47 | <rafa> sansa_g: it should get deployed after a while |
| 12:05:55 | <sansa_g> ? |
| 12:05:57 | <sansa_g> on it's own |
| 12:06:12 | <rafa> sansa_g: yes, do you have tomcat running? |
| 12:06:16 | <sansa_g> yes |
| 12:06:29 | <sansa_g> where do i point my browser to? |
| 12:06:38 | <rafa> sansa_g: localhost:8080/openmrs |
| 12:06:43 | <sansa_g> ok |
| 12:07:19 | <sansa_g> big thanks rafa !:D |
| 12:07:33 | <rafa> sansa_g: you're welcome |
| 12:11:25 | *** goutham has joined #openmrs |
| 12:16:02 | *** pushkar has joined #openmrs |
| 12:17:56 | *** sansa_g has quit IRC |
| 12:20:51 | *** magoo_ has quit IRC |
| 12:28:49 | *** magoo_ has joined #openmrs |
| 12:29:23 | <magoo_> +rafa i'm downloading vanilla Subversion 1.6.18 |
| 12:39:41 | *** bwolfe has joined #openmrs |
| 12:39:41 | *** ChanServ sets mode: +o bwolfe |
| 12:39:57 | *** wyclif has joined #openmrs |
| 12:40:20 | <pushkar> bwolfe, Hi |
| 12:40:24 | <bwolfe> hey |
| 12:40:54 | <pushkar> I think we should make some changes in htmlformentry |
| 12:42:24 | <pushkar> the current openmrs api incuded in htmlform entry dosent support isomplex() method in conceptdatatype class |
| 12:43:54 | <pushkar> and the HtmlFormEntryUtil.createObs() method is not checking for concepts with comlex datatypes bwolfe |
| 12:44:30 | *** suranga_ has joined #openmrs |
| 12:45:39 | *** sgithens has joined #openmrs |
| 12:46:33 | *** jordank has joined #openmrs |
| 12:46:34 | *** suranga has quit IRC |
| 12:49:39 | <bwolfe> pushkar, HFE supports all the way back to openmrs 1.6, so yes, it is old. can you code around that isComplex() method missing? |
| 12:50:02 | <bwolfe> if there are updates to HFE that will help you, definitely propose them as new tickets and submit a pull request! :-) |
| 12:52:29 | <pushkar> Okay :-) |
| 13:03:17 | *** dkayiwa has joined #openmrs |
| 13:06:30 | *** downey has joined #openmrs |
| 13:06:30 | *** ChanServ sets mode: +o downey |
| 13:06:30 | *** OpenMRSBot sets mode: +o downey |
| 13:07:56 | *** magoo_ has quit IRC |
| 13:24:56 | *** dkayiwa has quit IRC |
| 13:28:50 | *** magoo_ has joined #openmrs |
| 13:33:44 | *** suranga_ has quit IRC |
| 13:43:09 | *** isharap has joined #openmrs |
| 13:44:02 | <wyclif> djazayeri, rafa looks like calc tickets are done, @Darius, waiting on your your feed back when you try out the module in your kenya project |
| 13:44:29 | <wyclif> djazayeri, then we actually release 1.0 after that |
| 13:45:35 | <wyclif> rafa, by the way i merged trunk to order-entry branch, i hope you have no more blockers |
| 13:46:14 | *** jriley has joined #openmrs |
| 13:48:35 | <rafa> wyclif: great! thanks a lot! |
| 13:49:07 | <rafa> wyclif: I think restws is pretty much ready for 1.0 too |
| 13:50:21 | <wyclif> rafa, cool |
| 13:57:59 | *** venkaban has joined #openmrs |
| 14:00:08 | *** kreddy has joined #openmrs |
| 14:01:15 | <jriley> downeym, can you remind me of the edit URL for the FOSS OpenMRS User Guide? |
| 14:02:44 | *** lh has joined #openmrs |
| 14:02:44 | *** lh has joined #openmrs |
| 14:06:21 | <rafa> jriley: http://www.flossmanuals.net/openmrs-guide/ |
| 14:07:53 | <bwolfe> the edit one is booki something, isn't i? |
| 14:08:53 | <rafa> bwolfe: right http://booki.flossmanuals.net/openmrs-guide/_full/ |
| 14:08:58 | <OpenMRSBot> <http://ln-s.net/$Ho_> (at booki.flossmanuals.net) |
| 14:09:06 | <djazayeri> Isn't it scrum time? |
| 14:09:07 | <bwolfe> !seen cpower |
| 14:09:07 | <OpenMRSBot> bwolfe: cpower was last seen in #openmrs 23 hours, 51 minutes, and 14 seconds ago: <cpower> !scrumoff |
| 14:09:15 | <djazayeri> !scrumon bwolfe |
| 14:09:15 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster bwolfe- you may begin when ready. |
| 14:09:23 | <bwolfe> ahaha, perfect last message from chris! |
| 14:09:39 | <djazayeri> take it away bwolfe! |
| 14:09:40 | <bwolfe> yes, I can lead it while he is away |
| 14:09:45 | <bwolfe> one sec... |
| 14:10:37 | <bwolfe> today's order: rafa, djazayeri, kreddy, venkaban, bwolfe, wyclif, lakkarau, and finally dkayiwa if he reappears |
| 14:10:46 | <rafa> Today: |
| 14:10:46 | <rafa> * Reviewed code |
| 14:10:46 | <rafa> * Updated the wiki https://wiki.openmrs.org/display/docs/Calculation+Module |
| 14:10:46 | <rafa> * Testing RESTWS before the release (tomorrow?) |
| 14:10:46 | <rafa> No blockers, but a discussion point: Ben or Darius can you skim quickly restws tickets and see if anything is a blocker for 1.0 in case I've overlooked something? |
| 14:10:47 | <rafa> https://tickets.openmrs.org/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+RESTWS+AND+status+%3D+%22Ready+for+Work%22+ORDER+BY+priority+DESC&mode=hide |
| 14:10:47 | <rafa> https://tickets.openmrs.org/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+RESTWS+AND+status+%3D+%22Needs+Assessment%22+ORDER+BY+priority+DESC&mode=hide |
| 14:11:11 | <djazayeri> Yes, I can do that |
| 14:11:18 | <rafa> djazayeri: thanks! |
| 14:11:22 | <djazayeri> Tuesday 12-Jun-2012 |
| 14:11:22 | <djazayeri> * Work on I-TECH project |
| 14:11:22 | <djazayeri> * Created and committed CALC-38 (PatientCalculation.evaluate method should take a Collection<Integer> instead of a Cohort) |
| 14:11:22 | <djazayeri> Wednesday 13-Jun-2012 |
| 14:11:23 | <djazayeri> * University call |
| 14:11:23 | <djazayeri> * Design call |
| 14:11:24 | <djazayeri> * Project Management call |
| 14:11:24 | <djazayeri> * I-TECH call |
| 14:11:25 | <djazayeri> * Work on I-TECH project |
| 14:11:25 | <djazayeri> * Maybe try incorporating Calculation module |
| 14:11:26 | <djazayeri> no blockers |
| 14:12:33 | <djazayeri> kreddy? |
| 14:12:56 | *** kreddy has quit IRC |
| 14:13:03 | <bwolfe> ha |
| 14:13:03 | <djazayeri> venkaban? |
| 14:13:16 | *** kreddy has joined #openmrs |
| 14:13:18 | <bwolfe> djazayeri, just one more call for wednesday? didn't have enough already? |
| 14:13:28 | <venkaban> Completed TRUNK 3308, need to review the test cases once again |
| 14:13:39 | <djazayeri> !ticket trunk-3308 |
| 14:13:40 | <OpenMRSBot> djazayeri: [#TRUNK-3308] Add methods to OrderService for fetching patient Orders given an order class and other arguments - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-3308 |
| 14:13:45 | <venkaban> Today, Design call |
| 14:13:50 | <venkaban> No Blockers |
| 14:14:13 | <djazayeri> bwolfe: your turn |
| 14:14:29 | <bwolfe> Tuesday |
| 14:14:29 | <bwolfe> emails |
| 14:14:29 | <bwolfe> wiki docs cleanup |
| 14:14:29 | <bwolfe> triage some more tickets |
| 14:14:29 | <bwolfe> Wednesday |
| 14:14:31 | <bwolfe> design call setup |
| 14:14:33 | <bwolfe> emails |
| 14:14:35 | <bwolfe> triaged one ticket |
| 14:14:37 | <bwolfe> univ call |
| 14:14:39 | <bwolfe> design call |
| 14:14:41 | <bwolfe> pm call |
| 14:14:43 | <bwolfe> no blockers |
| 14:14:45 | <bwolfe> (how is it that you are doing the prodding...) |
| 14:14:51 | <bwolfe> in a rush today djazayeri? |
| 14:15:05 | <djazayeri> just trying to keep things mooooving |
| 14:15:05 | <bwolfe> wyclif, you're up |
| 14:15:05 | <wyclif> Tuesday:(Apparently i had to work on order entry to unblock sprinters): |
| 14:15:06 | <wyclif> * Merge trunk to order entry branch |
| 14:15:06 | <wyclif> * Removed incompartible changes/fix unit tests in the branch in relation to TRUNK-3324, TRUNK-3311 and TRUNK-3309 |
| 14:15:06 | <wyclif> * TRUNK-2591 - can't load demo data into a 1.8.2 install |
| 14:15:06 | <wyclif> * Reviewed CALC-38 - PatientCalculation.evaluate method should take a Collection<Integer> instead of a Cohort |
| 14:15:10 | <wyclif> Wednesday: |
| 14:15:12 | <wyclif> * Addressed pending TODOs for CALC-32 - Add support for caching of token registrations |
| 14:15:14 | <wyclif> * TRUNK-3400 - the provider identifier requirement in the 1.9 UI is nonsensical |
| 14:15:16 | <wyclif> * design call |
| 14:15:18 | <wyclif> * pick another swimlane ticket |
| 14:15:20 | <wyclif> Blockers: None |
| 14:15:42 | <djazayeri> !ticket trunk-3324 |
| 14:15:43 | <OpenMRSBot> djazayeri: [#TRUNK-3324] Revisit DrugOrderValidator - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-3324 |
| 14:15:48 | <djazayeri> !ticket trunk-3311 |
| 14:15:49 | <OpenMRSBot> djazayeri: [#TRUNK-3311] Add methods to OrderService for fetching patient Orders - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-3311 |
| 14:15:56 | <djazayeri> !ticket trunk-3309 |
| 14:15:57 | <OpenMRSBot> djazayeri: [#TRUNK-3309] Add methods for voiding, unvoiding orders - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-3309 |
| 14:16:02 | *** reddykir_ has joined #openmrs |
| 14:16:15 | *** kreddy has quit IRC |
| 14:16:51 | <bwolfe> reddykir_, have a steady connection yet? |
| 14:17:08 | <bwolfe> lakkarau, are you around? can you give an update on what you did yesterday and what you plan on doing today? |
| 14:17:18 | <bwolfe> (https://wiki.openmrs.org/display/RES/Daily+Scrum+Meeting) |
| 14:18:34 | <bwolfe> and no dkayiwa yet |
| 14:18:47 | <bwolfe> venkaban, is uma sitting there by you? or are you not in the office yet? |
| 14:19:16 | <venkaban> i am not in the office yet |
| 14:19:23 | <venkaban> it is 7 am PST here |
| 14:19:41 | <djazayeri> we scrum in our pjs here on the west coast |
| 14:20:24 | <bwolfe> yeah, figured. sorry we scrum so early for you guys. :-( |
| 14:20:42 | <bwolfe> ok, scrum offing: |
| 14:20:54 | <bwolfe> oh wait, lets see discussion points first before we scrumoff |
| 14:21:21 | *** isharap has left #openmrs |
| 14:21:23 | <bwolfe> djazayeri said he would help rafa look at restws tickets. I had skimmed them all before choosing ones for this sprint, so unless I missed one... |
| 14:21:59 | <bwolfe> no other discussion points, so: |
| 14:22:01 | <bwolfe> !scrumoff |
| 14:22:01 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 14:22:23 | *** reddykir_ has quit IRC |
| 14:22:49 | *** cpower has joined #openmrs |
| 14:23:06 | <djazayeri> yeah, I just went through those lists, and rafa, I don't think any of those need to be in 1.0 |
| 14:23:08 | <cpower> hello all did you go on with the scrum without me? |
| 14:23:11 | <djazayeri> are there any in-progress tickets? |
| 14:23:20 | <bwolfe> yes cpower |
| 14:23:34 | <bwolfe> rafa, yeah, make sure all tickets that have commits are all reviewed |
| 14:23:41 | <bwolfe> so no unclosed 1.0 tickets |
| 14:23:48 | <djazayeri> rafa: I see two in-progress tickets assigned to you |
| 14:23:50 | <djazayeri> about documentation |
| 14:24:04 | <cpower> bwolfe good deal, had a all hands G3 moment and got delayed...sorry to the group. |
| 14:24:10 | <rafa> djazayeri: correct |
| 14:24:26 | *** jordank has quit IRC |
| 14:24:42 | <rafa> djazayeri: I hope to put more docs while testing |
| 14:25:04 | <djazayeri> rafa: so, you have my permission to release when ready |
| 14:25:26 | *** jordank has joined #openmrs |
| 14:25:43 | <rafa> djazayeri: great let's get it out at last :D |
| 14:26:41 | *** pushkar_ has joined #openmrs |
| 14:27:24 | *** kreddy has joined #openmrs |
| 14:28:10 | <kreddy> bwolfe, still facing the connection issues :-( |
| 14:28:27 | *** pushkar has quit IRC |
| 14:30:43 | *** harshadura has quit IRC |
| 14:36:07 | *** pushkar__ has joined #openmrs |
| 14:39:49 | *** pushkar_ has quit IRC |
| 14:43:26 | *** kreddy has quit IRC |
| 14:43:46 | *** magoo_ has quit IRC |
| 14:49:08 | *** kreddy has joined #openmrs |
| 14:49:45 | *** goutham has quit IRC |
| 14:51:42 | <wyclif> djazayeri, bwolfe |
| 14:52:25 | <wyclif> djazayeri, bwolfe if identifier is nullable then isn't name supposed to be required if provider is not associated a person |
| 14:53:13 | <djazayeri> wyclif: we've decided that we're going to move towards having person be required |
| 14:53:25 | <djazayeri> and getting rid of name |
| 14:53:25 | <jriley> downey, are you the gatekeeper for the OpenMRS Guide on flossmanuals? Now that 1.9 is out, the latest guide should go out too |
| 14:53:43 | <wyclif> djazayeri, ok |
| 14:54:00 | <jriley> the big "PUBLISH" button is scary |
| 14:55:28 | *** rafa has quit IRC |
| 14:56:15 | *** lh has quit IRC |
| 14:56:17 | <downey> jriley: AFAIK anyone can "publish" :) |
| 14:56:26 | <bwolfe> are we backporting that notion djazayeri? |
| 14:56:28 | <jriley> anyone CAN publish, but SHOULD they? |
| 14:56:43 | <jriley> Ok. I'm going to click it. Hang on to your hats. |
| 14:56:55 | <djazayeri> wyclif: I believe we'll port that to 1.9.x, yes |
| 14:57:21 | <djazayeri> bwolfe: do you agree? (that we'll backport the "provider *must* be a person" to 1.9.x?) |
| 14:57:28 | <downey> jriley: i trust you :) |
| 14:57:31 | <bwolfe> jriley, WAIT! |
| 14:57:36 | <bwolfe> jriley, ok, now do it. |
| 14:57:37 | <jriley> ooooooooooo! |
| 14:57:40 | <bwolfe> ;-) |
| 14:57:43 | <jriley> noooooooooo! |
| 14:57:53 | <jriley> Now's the part where Ironman and the Hulk show up, right? |
| 14:58:19 | <jriley> knocking that PDF right out of the air. POW! |
| 14:58:27 | <wyclif> djazayeri, ok |
| 14:59:02 | * downey recalls needing a beer to be brave enough to publish the first version of the book |
| 14:59:56 | <jriley> I have a hot chocolate. It's before noon. |
| 15:00:06 | <downey> next best thing :) |
| 15:01:58 | *** kavuri has joined #openmrs |
| 15:02:01 | <jriley> So I added an appendix for document versions, and called this "2.0" , since the last one was 1.0 . Should the guides be named with the OpenMRS version they describe? Or titled "OpenMRS 1.9 guide", but the books versioned sequentially? |
| 15:02:36 | <downey> +1 for independent versioning |
| 15:03:04 | <downey> but maybe we can start listing the "current version as of time of publishing" |
| 15:03:21 | <jriley> How do I get the new version up to http://www.flossmanuals.net/ ? |
| 15:05:26 | *** deepaganu has joined #openmrs |
| 15:09:04 | *** harshadura has joined #openmrs |
| 15:11:55 | *** lakkarau has quit IRC |
| 15:12:47 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: http://t.co/RGsksA0i - @OPSWAT Helps @SFSU Contribute to Healthcare System for Developing Countries #ICT4D #eHealth #HealthIT <http://twitter.com/OpenMRS/statuses/212916806795530240> |
| 15:13:50 | *** rafa has joined #openmrs |
| 15:13:50 | *** ChanServ sets mode: +v rafa |
| 15:15:40 | <downey> jriley: last i heard that was a somewhat manual process, i need to check on it :) |
| 15:16:24 | <jriley> Ok. I don't think I have privileges to do it, and I can't update the Version thing on booki . I did attach the updated pdf to the wiki page. |
| 15:17:50 | <downey> jriley: did you try the versions tab at http://booki.flossmanuals.net/openmrs-guide/_edit/ ? |
| 15:17:55 | <OpenMRSBot> <http://ln-s.net/$Hpz> (at booki.flossmanuals.net) |
| 15:18:40 | <jriley> I couldn't do anything. When I messed with the dropdown it went to a broken URL. There are no options for adding a new version. |
| 15:19:13 | <downey> jriley: try it again, i just made you an editor |
| 15:20:57 | <jriley> With great power comes great responsibility. |
| 15:21:05 | <downey> :) |
| 15:26:56 | *** jordank_ has joined #openmrs |
| 15:27:06 | <downey> Hi jordank_ and welcome to the #openmrs IRC channel. |
| 15:28:09 | *** applecool has joined #openmrs |
| 15:28:09 | *** ChanServ sets mode: +v applecool |
| 15:35:43 | *** deepaganu has quit IRC |
| 15:38:58 | *** applecool has quit IRC |
| 15:39:12 | <downey> jriley: i created version 2.0 and broke booki :) |
| 15:39:39 | <jriley> Whoah! |
| 15:40:22 | <jriley> Well, I see version 2.0 in the Version tab. Clicking on the Version 2.0 link is equally broken as clicking on Version 1.0 |
| 15:40:39 | <downey> hehe |
| 15:40:46 | *** lh has joined #openmrs |
| 15:40:46 | *** lh has joined #openmrs |
| 15:41:10 | <downey> jriley: i'm still not sure how to get it up on their home page but i'll poke around some more |
| 15:41:28 | <jriley> Ok, thanks. |
| 15:42:54 | *** jordank_ has quit IRC |
| 15:43:25 | *** cpower has quit IRC |
| 15:49:47 | *** deepaganu has joined #openmrs |
| 16:03:51 | <pushkar__> bwolfe, can we have a save button at the end of the editor ? |
| 16:05:42 | <pushkar__> to put the encodedstring into the hidden field |
| 16:06:04 | *** harshadura has quit IRC |
| 16:06:09 | *** pushkar__ is now known as pushkar |
| 16:11:34 | *** suranga has joined #openmrs |
| 16:11:34 | *** ChanServ sets mode: +v suranga |
| 16:16:00 | *** rafa has quit IRC |
| 16:18:54 | *** venkaban has quit IRC |
| 16:21:08 | *** kavuri has quit IRC |
| 16:28:01 | *** rafa has joined #openmrs |
| 16:28:01 | *** ChanServ sets mode: +v rafa |
| 16:31:50 | *** applecool has joined #openmrs |
| 16:31:50 | *** ChanServ sets mode: +v applecool |
| 16:34:04 | *** kavuri has joined #openmrs |
| 16:39:04 | *** applecool has quit IRC |
| 16:39:31 | *** jordank_ has joined #openmrs |
| 16:39:39 | *** lakkarau has joined #openmrs |
| 16:39:44 | <downey> Hi lakkarau and welcome to the #openmrs IRC channel. |
| 16:40:11 | <lakkarau> downey,Hi |
| 16:40:24 | *** venkaban has joined #openmrs |
| 16:48:23 | *** rafa has quit IRC |
| 16:50:15 | *** jordank_ has quit IRC |
| 16:52:11 | <venkaban> wyclif, Hi |
| 16:52:30 | <venkaban> wyclif, Did you merge trunk with branch? |
| 16:53:54 | <wyclif> venkaban, yeah |
| 16:54:20 | *** lakkarau has quit IRC |
| 16:54:27 | *** lakkarau has joined #openmrs |
| 16:54:28 | <venkaban> wyclif, so now i have to update my order-entry branch? |
| 16:56:15 | <wyclif> yes |
| 16:56:48 | *** jriley has left #openmrs |
| 16:58:03 | <venkaban> wyclif, so I have remake the changes i did yesterday:-( |
| 16:58:35 | <wyclif> what were you coding against? |
| 16:58:48 | <venkaban> wyclif, order-entry |
| 16:58:58 | <wyclif> just do svn update and you are good to go |
| 16:59:26 | <wyclif> unless there are conflicts that you need to resolve |
| 17:05:55 | *** sgithens has quit IRC |
| 17:07:48 | *** mccallumg has joined #openmrs |
| 17:07:48 | *** ChanServ sets mode: +v mccallumg |
| 17:12:30 | <venkaban> wyclif, looks like there are conflicts |
| 17:13:50 | <wyclif> then you need to resolve them |
| 17:13:55 | <wyclif> venkaban, then you need to resolve them |
| 17:16:05 | <bwolfe> pushkar, in HFE, it should be a "done" button. or even "done editing image". something that they won't confuse with the "save" or "submit" at the bottom of the form! |
| 17:16:44 | <pushkar> bwolfe, I just trien something new can I overload the javascript submit function?? |
| 17:16:52 | <pushkar> tried* |
| 17:16:58 | <pushkar> and its working |
| 17:17:46 | <bwolfe> pushkar, you mean when the user pushes "submit" then it saves your drawing to the string before the actual html form is sent? |
| 17:17:52 | <bwolfe> yes, thats a good way to do it too! |
| 17:17:55 | <pushkar> I overloaded the submitHtmlForm() method which will be called when we click the submit button |
| 17:18:12 | <pushkar> yes ! :-) |
| 17:22:13 | *** kavuri has quit IRC |
| 17:24:12 | *** jordank has quit IRC |
| 17:25:22 | *** deepaganu has quit IRC |
| 17:27:22 | *** mvorobey has joined #openmrs |
| 17:27:49 | *** jordank has joined #openmrs |
| 17:28:52 | *** jordank has joined #openmrs |
| 17:29:37 | *** applecool has joined #openmrs |
| 17:29:37 | *** ChanServ sets mode: +v applecool |
| 17:29:58 | *** applecool has quit IRC |
| 17:35:40 | *** kavuri has joined #openmrs |
| 17:39:08 | *** venkaban has quit IRC |
| 17:51:28 | *** sansa has joined #openmrs |
| 17:51:35 | <downey> Hi sansa and welcome to the #openmrs IRC channel. |
| 17:53:02 | <sansa> hello ,i am trying to install the openmrs enterprise edition,but when i have got past the step of using the tomcat manager to install the .war file |
| 17:53:26 | <sansa> but when ii try to open it on local host it gives me a 404 error |
| 17:54:06 | <sansa> http://pastebin.com/KenbayYn |
| 17:57:10 | <sansa> i'm running tomcat 7.0.2 ..what is the solution .please help |
| 17:58:39 | *** dkayiwa has joined #openmrs |
| 18:00:12 | *** jordank has quit IRC |
| 18:04:20 | *** goutham has joined #openmrs |
| 18:04:21 | *** maurya has joined #openmrs |
| 18:04:52 | *** ChanServ sets mode: +v maurya |
| 18:04:57 | *** bwolfe has quit IRC |
| 18:05:23 | *** rose has joined #openmrs |
| 18:05:49 | *** rose is now known as Guest20680 |
| 18:05:52 | *** wyclif has quit IRC |
| 18:05:55 | *** Guest20680 has quit IRC |
| 18:10:25 | <goutham> dkayiwa: Ready for some brain exercise :D |
| 18:10:36 | <dkayiwa> goutham: oh yeah :) |
| 18:10:58 | <goutham> dkayiwa: Kool ... seen my mail |
| 18:11:15 | <dkayiwa> goutham: looking at it now |
| 18:11:46 | *** robbyoconnor has joined #openmrs |
| 18:11:46 | *** ChanServ sets mode: +v robbyoconnor |
| 18:12:13 | *** bwolfe has joined #openmrs |
| 18:12:13 | *** ChanServ sets mode: +o bwolfe |
| 18:12:18 | <bwolfe> sansa, so you gave up on the standalone? |
| 18:12:25 | <sansa> yes |
| 18:12:41 | <bwolfe> sansa, did you get this solved yet? (I lost connection for 10 mins) |
| 18:13:08 | <sansa> no,i haven't been able to get it solved :< |
| 18:14:40 | <bwolfe> sansa, what version of openmrs? |
| 18:14:46 | <bwolfe> sansa, and what url are you trying to use? |
| 18:15:29 | <sansa> 1.9 and url :http://localhost:8080/openmrs |
| 18:20:38 | *** wyclif has joined #openmrs |
| 18:24:13 | <goutham> dkayiwa: what say? |
| 18:24:18 | <goutham> :) |
| 18:24:58 | <bwolfe> sansa, hmm |
| 18:25:20 | <bwolfe> sansa: http://localhost:8080 return anything? |
| 18:25:44 | <sansa> yes it returns 404 error http://pastebin.com/KenbayYn |
| 18:26:33 | <dkayiwa> goutham: a form filter can have more than one property. correct? |
| 18:27:40 | <goutham> dkayiwa: Yes |
| 18:28:07 | *** venkaban has joined #openmrs |
| 18:28:07 | <dkayiwa> goutham: can you give an example for a form filter and its properties? :) |
| 18:29:46 | <goutham> dkayiwa: gender form filter => gender |
| 18:30:02 | <goutham> age form filter => range of age |
| 18:30:41 | <dkayiwa> that looks like a one to one mapping |
| 18:30:47 | <dkayiwa> goutham: |
| 18:33:10 | <bwolfe> sansa, so that means either you have the wrong port number |
| 18:33:15 | <bwolfe> or tomcat is not running |
| 18:33:19 | <goutham> dkayiwa: i will make mockup showing example values , it would be easy that way |
| 18:33:33 | <dkayiwa> goutham: that will be nice :) |
| 18:33:55 | <sansa> bwolfe tomcat is running , i got this https://wiki.openmrs.org/display/docs/Troubleshooting+Installation |
| 18:34:08 | <sansa> can you give me the instructions for ubuntu |
| 18:34:42 | <bwolfe> sansa, you got what there? |
| 18:35:21 | <sansa> check under header War file deploys in Tomcat but it won't start OpenMRS ,it's like my situation ,right? |
| 18:35:34 | <bwolfe> I usually download the tarball. extract to /opt. start-stop tomcat with /opt/apache-tomcat/bin/startup.sh |
| 18:36:02 | <bwolfe> sansa, if localhost:8080 doens't show you anything in a browser, then tomcat is not running |
| 18:36:22 | <finbrein> djazayeri: could you help with the pdi plugin, i need more info please (https://github.com/djazayeri/openmrs-contrib-reportingpdiplugin) |
| 18:36:26 | <OpenMRSBot> <http://ln-s.net/$Htg> (at github.com) |
| 18:37:09 | <sansa> bwolfe,i did it to usr/local..tomcat is running as it shows me the apache tomcat page on localhost/8080 |
| 18:37:15 | <finbrein> djazayeri: what other components are needed to make it work? thanks |
| 18:37:26 | <djazayeri> finbrein: on a call now... |
| 18:37:46 | *** pulasthi7 has joined #openmrs |
| 18:37:55 | <finbrein> djazayeri: ok, waiting... |
| 18:38:05 | <djazayeri> On calls for the next 2h20m |
| 18:38:14 | <sansa> bwolfe ,but localhost:8080/openmrs gives me a 404 error |
| 18:38:34 | <finbrein> djazayeri: catch you later |
| 18:39:06 | <bwolfe> sansa, ok, gotcha now. so you are right, openmrs is not deploying correctly. did you put the openmrs.war file into the webapps folder somewhere? |
| 18:39:28 | <sansa> yes,i did it using the tomcat/manager |
| 18:39:32 | <bwolfe> hmm |
| 18:39:41 | <bwolfe> ok, so now you need to check your logs to see why it is not starting |
| 18:39:45 | <bwolfe> sansa, did you isntall mysql? |
| 18:41:01 | <sansa> bwolfe yes ,i did |
| 18:44:33 | <pushkar> bwolfe, the observation is not getting saved if I say session.getSubmissionActions().createObs() . Any ideas why?? |
| 18:45:07 | <bwolfe> pushkar, which method is that in? |
| 18:46:13 | <sansa> bwolfe,i can't understand the log files,should i paste the logs in case you can? |
| 18:46:23 | <bwolfe> sansa, sure, paste them to pastebin |
| 18:46:40 | <pushkar> bwolfe, its in FormSubmissionActions |
| 18:47:02 | <bwolfe> pushkar, ? |
| 18:47:16 | <bwolfe> link to github? |
| 18:47:26 | <pushkar> okay |
| 18:48:11 | <sansa> bwolfe,http://pastebin.com/EyLsVALa |
| 18:51:23 | *** lakkarau has quit IRC |
| 18:51:37 | * bwolfe looks |
| 18:52:19 | <bwolfe> sansa, java.lang.IllegalArgumentException: Invalid or unreadable WAR file : error in opening zip file |
| 18:52:24 | <bwolfe> that means you have a bad download |
| 18:52:33 | <pushkar> bwolfe, https://github.com/ravipatipushkar/drawing |
| 18:52:45 | <bwolfe> sansa, try getting it again. I think the md5sums are on sourceforge somewhere too |
| 18:52:49 | <sansa> ok..i will dwnld again |
| 18:52:51 | <sansa> ok |
| 18:52:58 | <bwolfe> pushkar, which file? is the code you are mentioning? |
| 18:53:45 | <pushkar> DrawingSubmissionElement |
| 18:54:07 | <pushkar> handleSubmission() |
| 18:58:08 | <bwolfe> pushkar, c'mon, I don't have control-shift-t in github. link me to the file please! :-) |
| 18:59:04 | <pushkar> bwolfe, https://github.com/ravipatipushkar/drawing/blob/master/api/src/main/java/org/openmrs/module/drawing/elements/DrawingSubmissionElement.java |
| 18:59:08 | <pushkar> :-) |
| 18:59:10 | <OpenMRSBot> <http://ln-s.net/$HuD> (at github.com) |
| 19:00:22 | <pushkar> bwolfe, the code at 62 line is creating an observation but some how the observation is not getting saved |
| 19:08:52 | <goutham> dkayiwa: https://wiki.openmrs.org/display/projects/Filtering+Forms+on+Dashboard+%28Design+Page%29 last one |
| 19:09:36 | *** sansa has quit IRC |
| 19:10:05 | <dkayiwa> goutham: thanks |
| 19:14:23 | <dkayiwa> goutham: would it be easy for you to include the table names? |
| 19:19:05 | <goutham> dkayiwa:sorry...i added them now :) |
| 19:19:18 | <dkayiwa> goutham: ok thanks |
| 19:20:36 | <pushkar> bwolfe, |
| 19:21:15 | <dkayiwa> goutham: i thought the name and description are on the form filter instead of property??? |
| 19:21:35 | *** kavuri has quit IRC |
| 19:24:19 | <goutham> dkayiwa: i thought name and description is for particular filter.... if its in form filter ,it will describe all the set of forms under it |
| 19:25:14 | <goutham> dkayiwa: is it not that way? |
| 19:25:34 | *** mccallumg has quit IRC |
| 19:26:14 | <bwolfe> pushkar, sorry, on a call here. do you need to put it onto the encounter object manually? I don't know what the code in "createObs" does. session.getEncounter().addObs(obs) |
| 19:27:29 | *** mccallumg has joined #openmrs |
| 19:27:30 | *** ChanServ sets mode: +v mccallumg |
| 19:28:29 | <dkayiwa> goutham: which table just lists filters? |
| 19:28:54 | <goutham> dkayiwa: formfilter_filter_property |
| 19:28:57 | <dkayiwa> goutham: meaning just a list of filters without their attachment to any form |
| 19:29:05 | <goutham> dkayiwa: formfilter_filter_property |
| 19:29:30 | *** kreddy has quit IRC |
| 19:29:41 | <dkayiwa> goutham: then which table links filters and forms? |
| 19:29:52 | *** kreddy has joined #openmrs |
| 19:29:59 | <goutham> dkayiwa: formfilter_join |
| 19:30:56 | <dkayiwa> goutham: we shall change the name for that to match the openmrs convention. but lets leave the name for now |
| 19:31:10 | <dkayiwa> goutham: and so what then does the third table do? |
| 19:31:58 | <goutham> dkayiwa: Can you have the mock side by u ? i will refer that |
| 19:32:13 | *** maurya has quit IRC |
| 19:32:14 | <dkayiwa> goutham: meaning??? |
| 19:33:14 | <goutham> dkayiwa: i just want to explain showing examples in it ..thats it |
| 19:33:44 | <dkayiwa> goutham: and so what then does the third table do? |
| 19:34:20 | <goutham> dkayiwa: 3rd table mean formfilter_filter ? |
| 19:34:43 | <dkayiwa> goutham: you have explained two tables so far, so the remaining one :) |
| 19:34:50 | *** pushkar has quit IRC |
| 19:36:06 | <goutham> dkayiwa: no i am getting tensed and in order to avoid confusion ... i asked it |
| 19:36:13 | <goutham> so.. |
| 19:36:17 | *** mccallumg has quit IRC |
| 19:36:43 | <dkayiwa> goutham: since you created it, i want to see what you wanted it to store |
| 19:37:08 | <dkayiwa> goutham: do not worry, i will not get confused :) |
| 19:37:42 | <dkayiwa> goutham: i just want to ensure that you have a full understanding of what you have done :) |
| 19:37:56 | <goutham> dkayiwa: ok |
| 19:38:04 | <goutham> dkayiwa: formfilter_filter stores form related data as, form_id ,its creator, date_changed recently |
| 19:38:50 | <dkayiwa> goutham: isnt form related data store in the openmrs form table? |
| 19:42:45 | *** bwolfe_ has joined #openmrs |
| 19:42:45 | *** ChanServ sets mode: +o bwolfe_ |
| 19:43:38 | *** suranga has quit IRC |
| 19:43:44 | <goutham> dkayiwa: Yes, but i took code into consideration and added it, have a look at this bean http://pastebin.com/qSWgtzJf |
| 19:44:14 | <goutham> so that with single formfilter bean i will have form data with its related assigned filters |
| 19:44:56 | *** sansa has joined #openmrs |
| 19:45:41 | *** bwolfe has quit IRC |
| 19:45:44 | <dkayiwa> goutham: ah, so the date created, creator, etc are for the filter instead of form? |
| 19:46:05 | <goutham> dkayiwa: more over formfilter_filter table will have data related to when was forms first filter created against it , when was it modified lately |
| 19:46:14 | <goutham> dkayiwa: yes :) |
| 19:47:36 | <dkayiwa> goutham: so when one selects a form, do you then display a list for filters or properties (to choose from and attach to the selected form) ? |
| 19:48:21 | <goutham> dkayiwa: just list of filters |
| 19:48:31 | <goutham> name and description |
| 19:48:48 | <goutham> dkayiwa: 3 parameters * |
| 19:49:23 | <dkayiwa> goutham: goutham and from which table will you get that name and description? |
| 19:49:39 | <goutham> formfilter_filter_property |
| 19:50:34 | *** kdeeq has joined #openmrs |
| 19:50:57 | <dkayiwa> goutham: so the list of filters to display after form selection comes from formfilter_filter_property? |
| 19:51:20 | <goutham> dkayiwa: Yes ;) |
| 19:51:24 | <goutham> :) |
| 19:52:12 | <dkayiwa> goutham: so if i have a filter that has 10 properties, can you tell me how i would display it? |
| 19:53:26 | *** james_regen has quit IRC |
| 19:53:40 | *** kdeeq has quit IRC |
| 19:54:33 | <dkayiwa> goutham: or to give an example, suppose i have a form for pregnant mothers |
| 19:55:00 | <dkayiwa> goutham: so i want to create a filter with name: Adult Females |
| 19:55:21 | <dkayiwa> goutham: whose properties will be{ Age > 18 and Gender = Female) |
| 19:55:39 | <dkayiwa> can you represent that in the tables you have designed? |
| 19:56:57 | <goutham> dkayiwa: then there will be to filters one for age >18 and other gender=female , i should check these two filters against form |
| 19:57:13 | <dkayiwa> goutham: the filter is one |
| 19:57:16 | <goutham> dkayiwa: to=two* filters.. |
| 19:57:23 | <dkayiwa> goutham: it just has two properties :) |
| 19:57:31 | *** sansa has quit IRC |
| 20:00:52 | <goutham> dkayiwa: so how does a user gets only these two properties in his form while defining a form? |
| 20:01:37 | <dkayiwa> goutham: the properties will be assigned to the filter when it is created |
| 20:02:07 | <dkayiwa> goutham: so when the user selects a form, he or she selects the filter |
| 20:04:51 | <goutham> dkayiwa: how these properties will be assigned to the filter while creation , meaning check boxes/text filed |
| 20:05:46 | <dkayiwa> goutham: when creating a new filter, user click add new property/paramter for each property they want to add to the filter |
| 20:06:21 | *** bwolfe_ has quit IRC |
| 20:06:43 | <dkayiwa> goutham: and for each property, the type/class will determine what widget to display |
| 20:07:07 | <dkayiwa> goutham: for instance age will use numeric textbox, while gender has radio buttons, etc |
| 20:07:23 | *** wyclif has quit IRC |
| 20:09:00 | <goutham> dkayiwa: Ok |
| 20:10:13 | <goutham> dkayiwa: so there will be a add property button from which i need to list only limited set of properties such as age, gender,role,date |
| 20:10:36 | <goutham> and assign them to filter |
| 20:11:03 | <dkayiwa> goutham: after one selecting which type of property, you get to know what widgets to display |
| 20:11:36 | <venkaban> wyclif, Hi. If needed for ticket 3308 do we need to update the DAO objects too as per the change made in OrderService and OrderServiceImpl |
| 20:13:35 | <goutham> dkayiwa: Ok |
| 20:15:43 | <goutham> goutham: how about the formfilter interface which is mentioned in design page |
| 20:15:58 | <dkayiwa> goutham: :) |
| 20:16:00 | <goutham> dkayiwa: how about the formfilter interface which is mentioned in design page |
| 20:16:06 | <goutham> :) |
| 20:18:11 | *** rafa has joined #openmrs |
| 20:18:11 | *** ChanServ sets mode: +v rafa |
| 20:18:19 | <goutham> dkayiwa: can you also explain me role of formfilter interface mentioned in design page |
| 20:18:54 | *** pulasthi7 has quit IRC |
| 20:19:20 | <dkayiwa> goutham: it has the public boolean shouldDisplayForm(Patient p, User u) method |
| 20:21:03 | <goutham> dkayiwa: " The admin page should look for all implementations of FormFilter and allow the admin to choose one" this mean? also can you give example of a implementation of formfilter interface |
| 20:21:53 | <dkayiwa> goutham: AgeFormFilter |
| 20:23:00 | <dkayiwa> goutham: i think you could be right :) |
| 20:23:47 | <goutham> dkayiwa: about what ? |
| 20:24:08 | <dkayiwa> goutham: about why you are confused :) |
| 20:25:18 | * goutham :| |
| 20:28:09 | <goutham> dkayiwa: should i need to worry about this interface and implementations and all |
| 20:28:30 | <dkayiwa> goutham: you can forget about it for now :) |
| 20:28:40 | <dkayiwa> goutham: we shall dive into it later on |
| 20:29:10 | <dkayiwa> goutham: if we can first mock up the user interface flow and get implementers to comment |
| 20:29:26 | <dkayiwa> goutham: then we can later on refine the design basing on user feedback |
| 20:29:31 | <dkayiwa> goutham: what do you think? |
| 20:30:00 | <goutham> dkayiwa: yes but next week i have presentation and code demo |
| 20:30:19 | <dkayiwa> goutham: that means you do it faster |
| 20:30:53 | <dkayiwa> goutham: after the user interface mockup, then we can dig deeper |
| 20:31:09 | <goutham> dkayiwa: so quick points |
| 20:31:25 | <dkayiwa> goutham: so yes you can make it by next week |
| 20:31:40 | <goutham> dkayiwa: there are no predefined filters |
| 20:32:01 | <goutham> user can add properties while defining a filter |
| 20:32:05 | <dkayiwa> goutham: correct |
| 20:32:26 | <goutham> properties can be age , gender, role ,date |
| 20:32:35 | <dkayiwa> goutham: correct |
| 20:33:41 | <goutham> these properties will go under formfilter_filter_property table |
| 20:33:50 | <dkayiwa> goutham: correct |
| 20:34:17 | <goutham> if i add all the properties at once , pro |
| 20:34:30 | <dkayiwa> ??? |
| 20:36:22 | <goutham> property column will be age>20&gender=F&role=admin&date>'2012-1-1'&date<"2012-12-12" |
| 20:36:24 | <dkayiwa> goutham: and in that case you do not need name and description :) |
| 20:36:57 | <dkayiwa> goutham: yes |
| 20:37:43 | <goutham> dkayiwa: what goes under class_name ? |
| 20:38:05 | <goutham> dkayiwa: class_name column* |
| 20:38:34 | <dkayiwa> goutham: RoleFormFilter, GenderFormFilter, DateFormFilter, CohortFormFilter, etc |
| 20:38:39 | <dkayiwa> with full package name |
| 20:40:20 | <goutham> dkayiwa: if i have all the age , gender, role ,date properties under a filter , which className comes under this column |
| 20:40:39 | *** snoppy has left #openmrs |
| 20:40:45 | <dkayiwa> goutham: each one is different property |
| 20:41:46 | <dkayiwa> goutham: each one is a different row in the property table |
| 20:41:55 | <dkayiwa> goutham: each one = each type |
| 20:42:58 | <goutham> dkayiwa: Oh so there will be 4 columns now |
| 20:43:04 | <goutham> rows* |
| 20:43:12 | <dkayiwa> goutham: yes 4 rows |
| 20:43:23 | <dkayiwa> goutham: each with a different class name |
| 20:43:53 | <dkayiwa> goutham: we drop the name and description columns in the properties table :) |
| 20:44:11 | <dkayiwa> goutham: that will make life much easier for you :) |
| 20:44:27 | <goutham> dkayiwa: hurrey less columns less work |
| 20:44:40 | <goutham> :) |
| 20:45:05 | <goutham> dkayiwa: then data model which i sent you today make no sense at all |
| 20:45:46 | <dkayiwa> goutham: it does make sense :) |
| 20:45:56 | <dkayiwa> goutham: we just refine it a bit :) |
| 20:46:30 | <dkayiwa> goutham: first by dropping the name and description columns in the properties table |
| 20:47:08 | <dkayiwa> goutham: then drop the third table and stay with two tables only |
| 20:47:34 | <goutham> dkayiwa: join table will be removed ? |
| 20:47:56 | <dkayiwa> goutham: it stays but renamed |
| 20:48:30 | <dkayiwa> goutham: it is the table which tells us which form has which filter (as defined in the properties table) |
| 20:50:35 | <goutham> dkayiwa: a request can you create the data model and put it in the design page |
| 20:52:00 | <goutham> dkayiwa: please |
| 20:52:37 | *** rafa has quit IRC |
| 20:52:49 | <dkayiwa> goutham: in that case i would not be a good teacher :) |
| 20:53:20 | <dkayiwa> goutham: can you do those changes/refinements? :) |
| 20:53:44 | <dkayiwa> goutham: you can as well drop the retired fields from the properties table |
| 20:53:59 | <goutham> dkayiwa: i will not let that happen.. :) i will create that data model again and update as good student |
| 20:54:18 | <dkayiwa> goutham: practice makes perfect |
| 20:54:41 | <dkayiwa> goutham: when you do it yourself, you learn better and you also feel much more in control :) |
| 20:55:25 | <goutham> dkayiwa: Yes , i feel good about myself and more professional now |
| 20:55:40 | <goutham> dkayiwa: how long you will be online now? |
| 20:56:25 | <dkayiwa> goutham: oh you should. you have already done alot!!! :) |
| 20:56:36 | <dkayiwa> goutham: may be like 30mins |
| 20:56:46 | <goutham> dkayiwa: i will update with new model , u can have final look and say yes |
| 20:56:55 | <dkayiwa> goutham: sure |
| 20:57:06 | <goutham> dkayiwa: just give me 10mins :) |
| 20:57:16 | <dkayiwa> goutham: sure :D |
| 21:17:29 | <goutham> dkayiwa: https://wiki.openmrs.org/display/projects/Filtering+Forms+on+Dashboard+%28Design+Page%29 Bottom |
| 21:20:13 | <dkayiwa> goutham: ok |
| 21:21:27 | <goutham> dkayiwa: No questions ? |
| 21:21:48 | <dkayiwa> goutham: can we add a primary key to formfilter? |
| 21:22:24 | <goutham> dkayiwa: yes ofc :) any other |
| 21:27:19 | <dkayiwa> goutham: the column name formfilterfilterproperty_id looks ugly |
| 21:28:35 | <goutham> dkayiwa: aa its just that mockup editor wont allow me to keep _ between those words, its actually formfilter_filter_property_id |
| 21:29:12 | <dkayiwa> goutham: why don't you use the actual column names? |
| 21:29:39 | <dkayiwa> goutham: oh i see!!! |
| 21:29:52 | <dkayiwa> goutham: how did you do class_name? |
| 21:30:33 | <goutham> dkayiwa: when two _ comes , it does not listen to me |
| 21:30:48 | <dkayiwa> goutham: ok |
| 21:33:32 | <dkayiwa> goutham: what is the formfilterfilterid column for in the property table? |
| 21:34:18 | <dkayiwa> goutham: or may be we continue from here tomorrow??? :) |
| 21:34:23 | <goutham> dkayiwa: its not there ,not there |
| 21:34:39 | <dkayiwa> goutham: am looking at it now |
| 21:35:38 | <goutham> goutham: not any more.. removed it :) |
| 21:35:46 | <dkayiwa> goutham: ok |
| 21:37:14 | <goutham> dkayiwa: Its late for you i guess, Gn :) |
| 21:37:47 | *** dkayiwa_ has joined #openmrs |
| 21:39:15 | <dkayiwa_> goutham: can we also change the column name to simply filter_property_id? |
| 21:40:15 | <goutham> dkayiwa_: Done |
| 21:40:17 | *** dkayiwa has quit IRC |
| 21:40:17 | *** dkayiwa_ is now known as dkayiwa |
| 21:40:53 | <dkayiwa> goutham: how about simply filter_id? :) |
| 21:41:00 | <dkayiwa> goutham: any comments on that? |
| 21:42:46 | <goutham> dkayiwa: nope |
| 21:42:46 | <dkayiwa> goutham: i think lets continue from here tomorrow morning |
| 21:42:55 | <dkayiwa> goutham: am falling asleep :) |
| 21:43:27 | <goutham> dkayiwa: Ok Good Night :) |
| 21:43:42 | <dkayiwa> goutham: thanks. have a good night too |
| 21:44:03 | *** dkayiwa has quit IRC |
| 21:45:02 | *** mvorobey has quit IRC |
| 21:49:58 | *** kreddy has quit IRC |
| 21:52:06 | *** goutham has quit IRC |
| 22:08:43 | *** wyclif has joined #openmrs |
| 22:20:40 | <venkaban> wyclif, Hi |
| 22:21:09 | <venkaban> I have synced the branch order-entry and made changes to all the files that use the methods listed in the ticket |
| 22:21:34 | <venkaban> wyclif, The files include controller and DAOs too |
| 22:27:10 | <venkaban> djazayeri, Hi |
| 22:27:14 | <wyclif> venkaban, if the code doesn't compile, you ahave to update all references to any methods whose signatures you change |
| 22:27:48 | <venkaban> I made all the changes to the references and ran maven install, it went successfully |
| 22:28:28 | <venkaban> wyclif, I made all the changes to the references and ran maven install, it went successfully |
| 22:30:20 | <wyclif> venkaban, cool |
| 22:30:50 | <venkaban> I will update the ticjet and submit the patch wyclif |
| 22:32:00 | <venkaban> djazayeri, Hi |
| 22:32:43 | <venkaban> djazayeri, Can you please assign me a ticket to work on now? |
| 22:32:58 | <djazayeri> venkaban: are any available from the sprint? |
| 22:33:10 | <venkaban> djazayeri, not sure |
| 22:33:22 | <venkaban> djazayeri, I will ask ben |
| 22:33:24 | <djazayeri> have you been working on sprint tickets so far? |
| 22:33:47 | <venkaban> djazayeri, Yeah I worked on TRUNK-3308 that was assigned by ben |
| 22:34:20 | <djazayeri> venkaban: I see 5 available sprint tickets at https://tickets.openmrs.org/secure/Dashboard.jspa?selectPageId=11851 |
| 22:34:34 | <djazayeri> !ticket trunk-3308 |
| 22:34:35 | <OpenMRSBot> djazayeri: [#TRUNK-3308] Add methods to OrderService for fetching patient Orders given an order class and other arguments - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-3308 |
| 22:35:49 | <venkaban> djazayeri, I can pick any of them right? |
| 22:35:59 | <djazayeri> yes. |
| 22:36:12 | <venkaban> djazayeri, OK |
| 22:37:39 | <wyclif> thanks venkaban |
| 22:37:49 | <venkaban> wyclif np |
| 22:41:13 | *** lh has quit IRC |
| 22:46:44 | <venkaban> wyclif, the description for Trunk 3307 has OrderEntryService instead of OrderService. Isnt it? |
| 22:48:46 | <wyclif> i will fix it |
| 22:49:10 | <wyclif> venkaban, these tickets have gone through many changes due to design changes |
| 22:59:31 | <venkaban> wyclif, so are you going to take care of the cleanup sprint tickets? |
| 23:00:38 | <wyclif> am the one in the bug fixing swim lane this week |
| 23:02:01 | <venkaban> wyclif, ok |
| 23:20:53 | <venkaban> wyclif, besides the cleanup sprint tickets, are there any that I can look at righ tnow? |
| 23:29:34 | *** jordank has joined #openmrs |
| 23:29:59 | *** jordank has left #openmrs |