| 00:02:50 | <djazayeri> sunbiz: sorry, have to buy a plane ticket now, will be back with you in 15 |
| 00:03:33 | <sunbiz> djazayeri: thanks in advance |
| 00:03:35 | <sunbiz> for looking |
| 00:04:30 | *** jordank has quit IRC |
| 00:28:02 | *** sunbiz has quit IRC |
| 00:57:05 | *** lh has quit IRC |
| 01:13:29 | *** harshadura has joined #openmrs |
| 01:14:10 | <harshadura> hi mccallumg |
| 01:23:30 | *** harshadura has quit IRC |
| 01:34:33 | *** Jibesh has joined #openmrs |
| 01:44:17 | *** suranga has joined #openmrs |
| 01:44:17 | *** ChanServ sets mode: +v suranga |
| 02:27:18 | *** mccallumg has quit IRC |
| 02:51:14 | *** venkaban has joined #openmrs |
| 03:09:33 | <venkaban> djazayeri, Hi |
| 03:09:49 | <venkaban> djazayeri, sorry If I ping you in the wrong time |
| 03:10:58 | <venkaban> djazayeri, but I have a small question which I need answer for.....do we have the java class files for org.openmrs.Order.OrderAction |
| 03:10:59 | <venkaban> org.openmrs.Orderable? |
| 03:11:11 | <venkaban> wyclif, Hi |
| 03:11:59 | <venkaban> do we have the following java files wyclif, djazayeri, org.openmrs.Order.OrderAction |
| 03:11:59 | <venkaban> org.openmrs.Orderable? |
| 03:12:54 | <wyclif> hi |
| 03:13:12 | <wyclif> venkaban, i think there is a ticket for adding those |
| 03:13:20 | <wyclif> or thery are already there |
| 03:14:12 | <wyclif> are you working from trunk or branch? |
| 03:16:21 | <venkaban> wyclif, I am working from trunk |
| 03:16:32 | <venkaban> wyclif, i couldnt see those two files in trunk |
| 03:16:38 | <venkaban> wyclif, i just checke dit now |
| 03:22:44 | <wyclif> you should be using the order-entry branch |
| 03:23:41 | <venkaban> wyclif, so the two files OrderAction and Orderable should be created in trunk from order-entry branch? |
| 03:23:45 | <wyclif> venkaban, we will merge the code into trunk |
| 03:24:02 | <wyclif> venkaban, agianst the branch |
| 03:24:36 | <venkaban> wyclif, so what is the exact path in which the new file should be created? |
| 03:24:43 | <wyclif> venkaban, i added them to the branch but i had never merged the changes to trunk |
| 03:25:02 | <venkaban> wyclif, I have http://svn.openmrs.org/openmrs/trunk in my eclipse |
| 03:25:07 | <wyclif> venkaban, yes |
| 03:26:44 | <venkaban> wyclif, So the version we fix is the one in trunk right? |
| 03:27:06 | <venkaban> wyclif, If yes then I cant proceed until the 2 files are present in the trunk |
| 03:27:32 | <wyclif> venkaban, i meant they are in the branch |
| 03:27:40 | <wyclif> so you have to code agianst the branch |
| 03:28:08 | <venkaban> you mean the version in eclipse we should have while developing is ? |
| 03:28:37 | <venkaban> can you please give me the path for svn repository that we develop wyclif? |
| 03:28:54 | <wyclif> venkaban, you have the option of coding against the branch order-entry in svn |
| 03:29:31 | <venkaban> wyclif, I cant access the brach in svn |
| 03:29:43 | <wyclif> http://svn.openmrs.org/openmrs/branches/order-entry |
| 03:34:45 | <wyclif> venkaban, what is your email address? |
| 03:36:49 | *** venkaban has quit IRC |
| 03:48:04 | *** venkaban has joined #openmrs |
| 03:48:46 | <venkaban> wyclif, Did you create projects agiant branches folder in you eclipse? |
| 04:07:50 | *** Jibesh has quit IRC |
| 05:21:40 | *** suranga has quit IRC |
| 05:43:03 | *** upul` has joined #openmrs |
| 05:43:03 | *** ChanServ sets mode: +v upul` |
| 05:44:44 | *** harshadura has joined #openmrs |
| 05:55:59 | *** harshadura has quit IRC |
| 05:56:09 | *** harshadura has joined #openmrs |
| 05:58:59 | *** ChanServ sets mode: +v harshadura |
| 05:59:52 | *** goutham has joined #openmrs |
| 06:05:03 | *** harshadura has quit IRC |
| 06:05:14 | *** harshadura has joined #openmrs |
| 06:05:50 | *** harshadura has quit IRC |
| 06:05:59 | *** harshadura has joined #openmrs |
| 06:15:01 | *** harshadura has quit IRC |
| 06:15:14 | *** harshadura has joined #openmrs |
| 06:15:38 | *** harshadura has joined #openmrs |
| 06:27:38 | *** harshadura has quit IRC |
| 06:27:48 | *** harshadura has joined #openmrs |
| 06:29:10 | *** harshadura has joined #openmrs |
| 06:35:43 | *** suranga has joined #openmrs |
| 06:35:43 | *** ChanServ sets mode: +v suranga |
| 06:46:07 | *** harshadura has quit IRC |
| 06:49:33 | *** dkayiwa has joined #openmrs |
| 06:49:58 | *** harshadura has joined #openmrs |
| 06:50:07 | *** ChanServ sets mode: +v harshadura |
| 07:00:36 | <dkayiwa> anyone able to access JIRA? |
| 07:09:06 | <goutham> dkayiwa: yes :) |
| 07:09:17 | <dkayiwa> goutham: ok thanks :) |
| 07:09:49 | <harshadura> yes dkayiwa :) |
| 07:09:57 | <dkayiwa> thanks harshadura |
| 07:09:58 | <dkayiwa> :) |
| 07:10:58 | <goutham> dkayiwa: did you run the application ? Is it running smoothly :) |
| 07:11:15 | <goutham> dkayiwa: Module* |
| 07:11:54 | <dkayiwa> goutham: i went to sleep too :) |
| 07:12:03 | <dkayiwa> goutham: but going to test it now :) |
| 07:12:13 | *** deepa_ has joined #openmrs |
| 07:12:58 | <deepa_> hi all |
| 07:13:09 | <deepa_> i have some doubt about concepts |
| 07:13:19 | <deepa_> can anybody help me |
| 07:18:40 | <dkayiwa> deepa_: copying the implementers list too would give your more responses :) |
| 07:21:42 | <deepa_> thanks dkayiwa |
| 07:21:51 | <deepa_> did you get my mail |
| 07:30:26 | *** deepa_ has quit IRC |
| 07:46:08 | *** harshadura has quit IRC |
| 07:55:06 | *** sunbiz has joined #openmrs |
| 07:55:06 | *** ChanServ sets mode: +v sunbiz |
| 08:09:14 | *** pushkar has joined #openmrs |
| 08:17:29 | *** venkaban has quit IRC |
| 08:17:31 | *** pushkar has quit IRC |
| 08:17:56 | *** goutham has quit IRC |
| 08:17:56 | *** upul` has quit IRC |
| 08:40:43 | *** applecool has joined #openmrs |
| 08:40:43 | *** ChanServ sets mode: +v applecool |
| 08:52:42 | *** rafa has joined #openmrs |
| 08:52:43 | *** ChanServ sets mode: +v rafa |
| 08:59:12 | *** sunbiz has quit IRC |
| 09:19:16 | *** deepa_ has joined #openmrs |
| 09:33:45 | <applecool> hi rafa |
| 09:33:55 | <rafa> applecool: hi |
| 09:34:04 | <applecool> i am sorry i dissapointed you ! :( my bad |
| 09:34:29 | <rafa> applecool: have you improved? :) |
| 09:35:08 | <applecool> yes quite a lot! |
| 09:35:18 | <rafa> applecool: good |
| 09:35:28 | <rafa> applecool: though not committed yet... |
| 09:36:22 | <rafa> applecool: when will you commit? |
| 09:36:45 | <applecool> i will do it in half an hour for sure! |
| 09:36:50 | <applecool> without any mistakes! |
| 09:37:30 | <rafa> applecool: ok, let me know |
| 09:37:34 | <applecool> yes |
| 09:37:35 | <applecool> sure |
| 09:42:06 | *** deepa_ has quit IRC |
| 09:50:21 | *** suranga has quit IRC |
| 10:17:12 | *** goutham has joined #openmrs |
| 10:18:55 | *** deepaganu has joined #openmrs |
| 10:31:38 | *** suranga has joined #openmrs |
| 10:31:38 | *** ChanServ sets mode: +v suranga |
| 10:31:46 | <suranga> hi dkayiwa |
| 10:31:55 | <suranga> mmm.. dkayiwa are you reeeeely here ? :) |
| 10:35:23 | *** mgielow has joined #openmrs |
| 10:57:58 | <applecool> rafa: there? |
| 10:58:07 | <rafa> applecool: yes |
| 10:58:35 | <applecool> i committed the code and pushed it! but the only problem is with the test case! |
| 10:58:44 | <applecool> PackageFormControllerTest is failing |
| 10:59:17 | <rafa> applecool: let me see |
| 11:00:00 | <applecool> but the rest everything is working fine! it is saving the package details to the database and saving the file to the disk ! |
| 11:00:25 | <applecool> hope everything went good! fingers crossed! |
| 11:00:33 | * applecool tensed :( |
| 11:03:08 | <dkayiwa> suranga: sorry i had stepped out :) |
| 11:03:46 | <suranga> dkayiwa, no problem... actuallly, it was good that you were away, because I wanted to ask you a question... :-) |
| 11:03:59 | <dkayiwa> suranga: lollll :) |
| 11:04:09 | <suranga> dkayiwa, while you were away, i was able to solve some of my problem... so let me see if I can solve the rest of it too :P |
| 11:04:34 | <dkayiwa> suranga: :D |
| 11:04:37 | <suranga> dkayiwa, how are things with you ? I ask because I couldnt talk to you in a while |
| 11:04:45 | <suranga> dkayiwa, hope all is fine and well ! |
| 11:05:15 | <dkayiwa> suranga: yes all is well :) |
| 11:12:07 | *** magoo_ has joined #openmrs |
| 11:12:31 | <rafa> applecool: see my comments |
| 11:12:39 | <applecool> yes seeing them |
| 11:12:42 | <rafa> applecool: more corrections needed |
| 11:13:22 | <applecool> i have realized by seeing them ! |
| 11:22:11 | <magoo_> dkayiwa if my maven repository is corrupt can i re-download maven |
| 11:28:06 | *** suranga has quit IRC |
| 11:31:54 | *** suranga has joined #openmrs |
| 11:44:58 | <deepaganu> how do i start jetty with openmrs trunk |
| 11:45:11 | <deepaganu> i have tried using jetty:run |
| 11:45:40 | <deepaganu> it gives me an error No plugin found for prefix 'jetty' in the current project and in the plugin groups |
| 11:46:31 | <deepaganu> rafa can you suggest something |
| 11:46:48 | <rafa> deepaganu: sure |
| 11:47:00 | <deepaganu> i am on windows |
| 11:47:39 | <rafa> deepaganu: you need to start it from the webapp directory |
| 11:47:42 | <deepaganu> [ERROR] No plugin found for prefix 'jetty' in the current project and in the plugin groups [org.openmrs.maven.plugins, org.apache.maven.plugins, org.codehaus.mojo] available from the repositories [local (C:\Users\ABHISHEK\.m2\repository), openmrs-repo (http://mavenrepo.openmrs.org/nexus/content/repositories/public), central (http://repo.maven.apache.org/maven2)] -> [Help 1] |
| 11:47:44 | <OpenMRSBot> <http://ln-s.net/8-2X> (at mavenrepo.openmrs.org) |
| 11:47:48 | <deepaganu> tried doing that |
| 11:47:50 | <magoo_> +rafa hi |
| 11:48:49 | <magoo_> +rafa am getting the same problem with jetty |
| 11:49:08 | <deepaganu> same pinch magoo_ |
| 11:49:21 | <rafa> were you able to build the project? |
| 11:49:40 | <magoo_> deepgaganu yes |
| 11:50:19 | <rafa> deepaganu: pastebin the full log from your console |
| 11:50:26 | <rafa> deepaganu: together with the command you give |
| 11:50:54 | <magoo_> +rafa when i build the project with maven clean install i get errors |
| 11:51:04 | <rafa> magoo_: what errors? |
| 11:51:32 | <magoo_> +rafa let me pastebin |
| 11:51:33 | <rafa> magoo_: put the full log in pastebin.com |
| 11:52:08 | <deepaganu> thanks rafa i am getting it now :) |
| 11:52:50 | <dkayiwa> hi goutham |
| 11:54:09 | <magoo_> +rafa okay |
| 11:55:05 | <goutham> dkayiwa: Hi :) |
| 11:55:46 | <dkayiwa> goutham: was able to run the module and the form listing screen looks nice :) |
| 11:56:02 | <dkayiwa> goutham: can you look into why the font for header becomes bigger? |
| 11:57:03 | <magoo_> +rafa url http://pastebin.com/LBu6jeSm |
| 11:58:10 | *** elliott_w has joined #openmrs |
| 11:58:10 | *** ChanServ sets mode: +o elliott_w |
| 11:59:11 | <goutham> dkayiwa: will look at it and have to move that retired check box to bit right also |
| 11:59:31 | <dkayiwa> goutham: ok |
| 11:59:38 | *** deepaganu has quit IRC |
| 11:59:53 | *** deepaganu has joined #openmrs |
| 12:01:13 | <rafa> magoo_: which version of svn do you use? |
| 12:03:39 | <magoo_> +rafa 3.0.4 maven |
| 12:04:01 | <rafa> magoo_: but svn? |
| 12:11:35 | *** suranga has quit IRC |
| 12:17:06 | *** suranga has joined #openmrs |
| 12:17:10 | *** dkayiwa_ has joined #openmrs |
| 12:19:34 | *** dkayiwa has quit IRC |
| 12:19:34 | *** dkayiwa_ is now known as dkayiwa |
| 12:19:47 | <applecool> rafa: i committed the changes! |
| 12:20:03 | <applecool> can you please check if there are still any mistakes? |
| 12:20:47 | <applecool> rafa: there? |
| 12:21:04 | *** bwolfe has joined #openmrs |
| 12:21:04 | *** ChanServ sets mode: +o bwolfe |
| 12:24:08 | <rafa> applecool: still fixes needed |
| 12:24:17 | <applecool> whoops wherE? |
| 12:24:23 | <rafa> applecool: see comments |
| 12:26:51 | <rafa> applecool: don't you now finally? |
| 12:27:13 | <applecool> i know it! :) |
| 12:27:19 | <rafa> applecool: it's try { } catch (Exception e) { } finally { } |
| 12:27:26 | <rafa> applecool: so why are you confused? |
| 12:27:35 | <applecool> i know it rafa |
| 12:32:19 | <rafa> applecool: http://docs.oracle.com/javase/tutorial/essential/io/fileOps.html |
| 12:33:07 | <applecool> i changed it! i know it rafa :) |
| 12:33:38 | <applecool> i dint eat my food so ate that away :P |
| 12:34:16 | <rafa> applecool: haha |
| 12:37:11 | <applecool> committed again! |
| 12:37:45 | <applecool> i am sure i dont have them! if there are errors please kick me! i need it |
| 12:38:05 | * applecool making a mess! damn |
| 12:39:09 | *** wyclif has quit IRC |
| 12:41:09 | <applecool> rafa: ? |
| 12:42:38 | *** james_regen has joined #openmrs |
| 12:42:38 | *** ChanServ sets mode: +v james_regen |
| 12:43:23 | *** wyclif has joined #openmrs |
| 12:55:38 | *** deepaganu has quit IRC |
| 12:57:42 | <applecool> rafa: |
| 12:57:45 | <applecool> there? |
| 12:57:48 | <rafa> applecool: yes |
| 12:59:39 | <applecool> i dint understand the comment rafa |
| 12:59:46 | <applecool> :( |
| 12:59:46 | <rafa> applecool: which one? |
| 12:59:56 | <applecool> the overriding one' |
| 13:00:06 | <rafa> applecool: just do it, it will work |
| 13:00:14 | <rafa> applecool: and read more about inheritance in java |
| 13:02:02 | <rafa> applecool: http://docs.oracle.com/javase/tutorial/java/IandI/super.html |
| 13:07:39 | <magoo_> +rafa sorry something came up how do i check for the svn it seems am confusing maven with svn |
| 13:08:18 | <rafa> magoo_: svn --version in the command line |
| 13:09:35 | <applecool> its not working rafa |
| 13:09:46 | *** harshadura has joined #openmrs |
| 13:09:50 | <rafa> applecool: commit what you did |
| 13:10:02 | <applecool> MetadataPackage metadatapackage =super.save(metadataPackage); |
| 13:10:04 | <applecool> i did this |
| 13:10:34 | <applecool> and added @Override to the save method! |
| 13:11:43 | <rafa> applecool: why you say it's not working? |
| 13:14:26 | <applecool> rafa: its saving the package details but it is not saving the file to the disk |
| 13:15:29 | <applecool> i already tried that but it didnt work! so i tried it in other way by adding a method ! it worked |
| 13:15:43 | <applecool> so i removed the @Override |
| 13:15:51 | <applecool> in the previous commits |
| 13:16:28 | <magoo_> +rafa it seems there is a problem with my svn because when i run the command nothing is displayed |
| 13:17:55 | <magoo_> +rafa do i need to setup the path to svn in the environmental variables like i did for maven and jdk |
| 13:19:05 | <suranga> magoo_, I think its optional, but preferred |
| 13:19:11 | <suranga> magoo_, I always do so... |
| 13:20:22 | <rafa> applecool: okay leave that alone |
| 13:20:30 | <rafa> applecool: I'll play with it myself later |
| 13:21:08 | <applecool> okay! |
| 13:21:29 | <magoo_> suranga i dont seem to see the svn folder on my local directory |
| 13:22:47 | <suranga> magoo_, mm... it should be somewhere in your program files, correct ? |
| 13:23:04 | <applecool> so should i let it be a normal method for now? rafa |
| 13:23:11 | <rafa> applecool: yes |
| 13:23:25 | <suranga> magoo_, if its not there, and you cant find using --version, maybe you should re-install ? |
| 13:23:34 | <magoo_> suranga i see something like SlikSvn is that the folder? |
| 13:23:43 | <applecool> okay! and as you told the change with the API exception i changed it and i commiting it |
| 13:23:57 | <suranga> magoo_, oh, you have silk svn installed ! |
| 13:24:07 | <rafa> applecool: good |
| 13:24:12 | <suranga> magoo_, aha, in that case, you need to set the environment variable, C:\Program Files\SlikSvn\bin |
| 13:24:12 | <rafa> applecool: then make sure tests pass :) |
| 13:24:17 | <suranga> magoo_, something like that ? |
| 13:24:38 | <applecool> okay :) |
| 13:24:40 | <magoo_> suranga okay |
| 13:25:15 | <magoo_> suranga what should i put for the Path? |
| 13:25:37 | <suranga> magoo_, hmm.. you should just append it to the path variable, i guess |
| 13:26:02 | <applecool> committed and pushed it rafa |
| 13:26:07 | <magoo_> suranga okay |
| 13:26:41 | <applecool> i will work on the tests! and will start with this weeks goals! |
| 13:27:29 | <applecool> rafa: ? |
| 13:27:47 | <rafa> applecool: ok |
| 13:28:33 | <applecool> i am leaving my school! will be travelling ! and i wil be back as soon as i reach home rafa :) |
| 13:29:30 | <rafa> applecool: see you! |
| 13:29:48 | <applecool> bye see you too rafa :) |
| 13:29:59 | *** applecool has quit IRC |
| 13:30:00 | <magoo_> +rafa the svn version is 1.7.5 |
| 13:30:17 | *** sgithens has joined #openmrs |
| 13:30:55 | <rafa> magoo_: I'm using < 1.7 and heard 1.7 may cause problems |
| 13:31:16 | <rafa> magoo_: any chance you can downgrade? |
| 13:31:38 | <magoo_> +rafa let me downgrade |
| 13:32:00 | <magoo_> +rafa thanks |
| 13:32:19 | <rafa> magoo_: unfortunately you'll need to check out the project again :( |
| 13:32:29 | <rafa> magoo_: 1.6 and 1.7 are not compatible |
| 13:32:49 | <magoo_> +rafa okay i will do that |
| 13:35:50 | *** jordank has joined #openmrs |
| 13:36:26 | <sgithens> /join #fluid-tec |
| 13:37:00 | *** kreddy has joined #openmrs |
| 13:37:14 | *** magoo_ has quit IRC |
| 13:43:27 | *** suranga has quit IRC |
| 13:49:03 | <harshadura> hi all, is there a way to close down a portlet inside OpenMRS web app using a piece of Javascript code ? |
| 13:49:52 | <harshadura> I need to call the script inside of the portlet jsp |
| 13:53:28 | <wyclif> hi dkayiwa |
| 13:53:36 | <dkayiwa> hi wyclif |
| 13:54:15 | <wyclif> i need a little info about https://tickets.openmrs.org/browse/XFRM-80 |
| 13:54:24 | <dkayiwa> wyclif: ok |
| 13:55:04 | <wyclif> dkayiwa, what does it mean to work off line, diconnected from openmrs server or no internet connection? |
| 13:56:21 | *** harshadura_ has joined #openmrs |
| 13:56:40 | <dkayiwa> wyclif: got to the resources folder of the xforms module's source on the file system |
| 13:57:09 | *** harshadura has quit IRC |
| 13:57:14 | <dkayiwa> wyclif: then in the formdesigner folder under it, open the FormDesigner.html file |
| 13:57:26 | <wyclif> dkayiwa, what does it mean to work offline? |
| 13:57:29 | <dkayiwa> wyclif: does it launce the form designer? |
| 13:57:30 | *** harshadura_ has quit IRC |
| 13:57:37 | <dkayiwa> wyclif: when not connected to the server |
| 13:57:52 | <dkayiwa> wyclif: but being able to design a form |
| 13:57:52 | <wyclif> dkayiwa, ok |
| 13:57:57 | <wyclif> ok |
| 13:58:00 | <dkayiwa> wyclif: just like in infopath |
| 13:58:11 | *** harshadura has joined #openmrs |
| 13:58:30 | <wyclif> any pointer to what needs to be done? |
| 13:58:47 | <dkayiwa> wyclif: are you first of all able to reproduce it? |
| 13:58:47 | <wyclif> dkayiwa, any pointer to what needs to be done? |
| 13:58:51 | <dkayiwa> wyclif: i failed to |
| 13:59:01 | <dkayiwa> wyclif: does your offline form designer show up? |
| 13:59:16 | <wyclif> dkayiwa, i will look at it shortly, i hadn't tested yet |
| 13:59:23 | <dkayiwa> wyclif: ok |
| 14:00:42 | <wyclif> thanks dkayiwa |
| 14:01:52 | *** cpower has joined #openmrs |
| 14:02:03 | <cpower> testing 1...2...3.. |
| 14:02:12 | <cpower> is this thing on? |
| 14:02:18 | <cpower> Hello! |
| 14:02:44 | <cpower> It's time for the OpenMRS scrum of the day |
| 14:03:24 | <bwolfe> cpower, way to keep it lively |
| 14:03:33 | <bwolfe> power to the cpower, if you will |
| 14:03:50 | <cpower> indeed..I try |
| 14:03:54 | <cpower> Let's go |
| 14:03:58 | <cpower> !scrumon cpower |
| 14:03:58 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 14:04:27 | <cpower> Order: Bwolfe, djazayeri, rafa, dkayiwa, wyclif |
| 14:04:35 | <rafa> hi! |
| 14:04:52 | *** kreddy has quit IRC |
| 14:04:54 | <bwolfe> Monday |
| 14:04:55 | <bwolfe> triage 1 ticket in ERR |
| 14:04:55 | <bwolfe> triage a bunch of trunk tickets (to make paul happy(ier)) |
| 14:04:55 | <bwolfe> review sprint tickets, or rafa is taking over those? |
| 14:04:55 | <bwolfe> chat with kiran |
| 14:04:55 | <bwolfe> Tuesday |
| 14:04:57 | <bwolfe> emails |
| 14:05:01 | <bwolfe> wiki docs cleanup |
| 14:05:03 | <bwolfe> triage some more tickets |
| 14:05:08 | <bwolfe> no venkaban? no kiranreddy? no uma? sad day |
| 14:05:16 | <bwolfe> oh, no blockers |
| 14:05:56 | *** kreddy has joined #openmrs |
| 14:05:58 | <cpower> Kreddy is in the house..somewhere |
| 14:06:03 | <cpower> there he is.. |
| 14:06:13 | <djazayeri> My report |
| 14:06:17 | <djazayeri> Monday 11-Jun-2012 |
| 14:06:17 | <djazayeri> * Work on I-TECH project. (Time to go into heads-down mode.) |
| 14:06:17 | <djazayeri> * Fixed UIFR-51 (Fragment actions with @RequestParam on collection properties don't handle empty submissions right) |
| 14:06:17 | <djazayeri> Tuesday 12-Jun-2012 |
| 14:06:17 | <djazayeri> * Work on I-TECH project |
| 14:06:18 | <djazayeri> * Assess HTML Form Entry tickets for next week’s sprint |
| 14:06:18 | <djazayeri> * Maybe try incorporating Calculation module |
| 14:06:35 | <djazayeri> no blockers, except the bad cold I must have picked up on an airplane |
| 14:07:01 | <rafa> Today: |
| 14:07:01 | <rafa> * Reviewed sprint tickets |
| 14:07:01 | <rafa> * Applied patches to |
| 14:07:01 | <rafa> TRUNK-3309 - Add methods for voiding, unvoiding orders |
| 14:07:01 | <rafa> https://tickets.openmrs.org/browse/TRUNK-3309 |
| 14:07:01 | <rafa> TRUNK-3324 - Revisit DrugOrderValidator |
| 14:07:01 | <rafa> https://tickets.openmrs.org/browse/TRUNK-3324 |
| 14:07:02 | <rafa> * Recreated https://wiki.openmrs.org/display/docs/REST+Web+Service+Resources |
| 14:07:02 | <rafa> * GSoC code reviews |
| 14:07:03 | <OpenMRSBot> <http://ln-s.net/8z-a> (at wiki.openmrs.org) |
| 14:07:03 | <rafa> * Maybe will try to update the order-entry branch... |
| 14:07:03 | <rafa> Blockers: Can someone break a tie between me and wyclif on https://tickets.openmrs.org/browse/CALC-32? :) |
| 14:07:30 | <dkayiwa> Committed response to review comments for: Add methods to OrderService for fetching patient Orders - TRUNK-3311 |
| 14:07:31 | <dkayiwa> IRC |
| 14:07:31 | <dkayiwa> Reviewed and tested my GSOC student's code |
| 14:07:31 | <dkayiwa> Finishing up: Add methods to OrderService for creating, retrieving and purging an Order - TRUNK-3314 |
| 14:07:32 | <dkayiwa> No Blockers |
| 14:07:32 | <wyclif> rafa, i siwtched to concurrentHashMap |
| 14:07:59 | <rafa> wyclif: yes, but the question is if we need it at all :) |
| 14:08:12 | <wyclif> rafa, hmmm... |
| 14:08:50 | <djazayeri> hold that discussion till the end |
| 14:08:59 | <wyclif> ok |
| 14:09:38 | <bwolfe> rafa, update the order entry branch? we should discuss that too. |
| 14:09:47 | <djazayeri> wyclif: your report? |
| 14:09:57 | <cpower> chop...chop |
| 14:09:59 | <wyclif> https://tickets.openmrs.org/browse/CALC-32? |
| 14:10:11 | <wyclif> Monday: |
| 14:10:11 | <wyclif> * TRUNK-3320 - Calling parse method of DateFormat |
| 14:10:11 | <wyclif> * Discussion with daniel about XFRM-79 - Need to include obs_datetime on xform designer |
| 14:10:11 | <wyclif> * Spent some time on XFRM-79 (Not yet there) |
| 14:10:11 | <wyclif> * TRUNK-3423 - Snapshot versions are replaced by lower releases of bundled modules |
| 14:10:12 | <wyclif> Today: |
| 14:10:15 | <wyclif> * See if i can have a complete working solution to - XFRM-79 (Not yet there) |
| 14:10:17 | <wyclif> * XFRM-80 - Offline XForms Designer doesn't work - open with blank html page |
| 14:10:19 | <wyclif> * Pick another swim lane ticket |
| 14:10:21 | <wyclif> Blockers: None |
| 14:11:21 | <cpower> Ok anyone else.. |
| 14:11:33 | *** kreddy has quit IRC |
| 14:11:59 | <bwolfe> wyclif, we have an xforms sprint coming up, try not to work on those as Daniel has picked out the set already |
| 14:12:16 | <bwolfe> (you can work on xofrms ticket that he /hasn't/ put in the sprint list though) |
| 14:12:30 | *** lh has joined #openmrs |
| 14:12:30 | *** lh has joined #openmrs |
| 14:12:35 | <cpower> Summary: Discussion topic's: Where's are missing developers!, update for the OE branch, |
| 14:12:48 | <djazayeri> can we talk about the CALC ticket first? |
| 14:13:02 | <djazayeri> I need to go back and sleep more... |
| 14:13:04 | <djazayeri> :-) |
| 14:13:05 | <wyclif> bwolfe, ok |
| 14:13:10 | <cpower> Blockers: !ticket CALC-32 break the tie |
| 14:13:34 | <cpower> darn got the command wrong.. |
| 14:13:37 | <djazayeri> So, broadly speaking, *yes*, we do believe this is a significant performance issue for anyone who tries to use calculations at scale. |
| 14:14:07 | <djazayeri> So, yes, we want to avoid hitting the DB for token lookups. |
| 14:14:41 | <djazayeri> I suppose that one option would be to refactor things and make the String token be the primary key, and then user hibernate's caching for this. |
| 14:15:06 | <djazayeri> But I really think it should be fine to just use an in-memory map. |
| 14:15:10 | <djazayeri> wyclif: what's the bug? |
| 14:16:31 | <bwolfe> thread safety is the issue |
| 14:16:38 | <wyclif> djazayeri, no bug really |
| 14:17:25 | <djazayeri> So, I am not at all worried about the case where someone reads _while_ a write is going on, and get the old value (which was valid, but is milliseconds old) |
| 14:17:52 | <cpower> !scrumoff |
| 14:17:52 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 14:17:54 | <wyclif> it is just if multiple threads are calling getCalculation, i would like that if a threas enters the saveMethod then other threads should wait until it returns from the method so that they don't get a stale copy from the cache |
| 14:18:54 | <djazayeri> wyclif: I don't care about that situation |
| 14:19:05 | <wyclif> djazayeri, but i recall stating that this is ingorable since editing calculation will be a very rare operation |
| 14:19:55 | <djazayeri> actually, though, I was assuming the cache would be built up by *reads*, though still invalidated on writes. |
| 14:21:30 | <wyclif> djazayeri, actually i was only replacing the edited calculation on save if already cached and not invalidating the entire cache |
| 14:21:44 | *** mgielow has quit IRC |
| 14:22:07 | <djazayeri> Is it possible to delete registrations, or to rename them? |
| 14:24:04 | <djazayeri> wyclif: e.g. if I had registered something as "token1" and then I come back and _change_ that to "token2", we need to clear "token1" out of the cache. |
| 14:24:56 | <wyclif> djazayeri, yes |
| 14:25:22 | <djazayeri> wyclif: I don't think the current code handles this. |
| 14:25:39 | <wyclif> djazayeri, if you look at the save methods it does |
| 14:25:50 | <wyclif> djazayeri, we need to fix delete too |
| 14:26:04 | <djazayeri> wyclif: I don't think the save method would handle a rename (assuming that's allowed) |
| 14:26:12 | <wyclif> djazayeri, have you done an svn update |
| 14:26:12 | <djazayeri> wyclif: the save method wouldn't know the old token name |
| 14:26:21 | <djazayeri> wyclif: no, I'm just looking at the code review |
| 14:26:37 | <djazayeri> let me do an svn update |
| 14:27:05 | <wyclif> djazayeri, if you rename, then it wouldn't find it in the cache\ |
| 14:28:02 | <wyclif> meaning it would have the same calculation twice in the cache but with different keys which probably we need to get around |
| 14:28:23 | <wyclif> djazayeri, i will arite a unit test for renaming a token |
| 14:28:55 | <rafa> wyclif: if save is a rare operation do clear() on the cache and we're good |
| 14:29:04 | <djazayeri> yeah, let's do that |
| 14:29:18 | <wyclif> cool |
| 14:29:21 | <djazayeri> just make it such that save and delete clear the cache |
| 14:29:24 | *** kreddy has joined #openmrs |
| 14:29:28 | <wyclif> ok |
| 14:29:47 | <djazayeri> The main concern is that in the steady-state, you don't have to hit the DB every time you try to run a calculation by name |
| 14:29:52 | *** sunbiz has joined #openmrs |
| 14:29:52 | *** ChanServ sets mode: +v sunbiz |
| 14:29:57 | <wyclif> correct |
| 14:30:31 | <rafa> okay, cleared :) |
| 14:30:57 | <rafa> moving on to upgrading the order-entry branch |
| 14:31:11 | <rafa> seems like it wasn't merged into the trunk and we should be actually committing to that one |
| 14:31:35 | <rafa> bwolfe: you asked about it |
| 14:32:13 | <bwolfe> right. I thougth we were moving things over piece meal. that the order-entry branch had a lot more than we were implementing |
| 14:32:18 | <bwolfe> or am I remembering wrong? |
| 14:33:21 | <rafa> bwolfe: I'm not sure |
| 14:33:34 | <rafa> wyclif: why aren't we moving to trunk? |
| 14:34:15 | <djazayeri> I also thought that the orderentry branch had more stuff than we wanted to deal with right now, and we were going to move over things piece-by-piece |
| 14:35:08 | <wyclif> i cleaned up the branch and got rid of the unneccessary stuff |
| 14:35:58 | <wyclif> all the liquibase changes domain object and HBM file changes are in the branch |
| 14:36:24 | <djazayeri> got rid of the unnecessary stuff, i.e. reverted/deleted it? |
| 14:36:28 | <sunbiz> Im getting an org.hibernate.MappingException: Unknown entity: when trying to save an Object... the unit tests work fine, but when deploying to OpenMRS and calling the service it fails... |
| 14:36:33 | <sunbiz> any1 seen this before?? |
| 14:37:03 | <wyclif> djazayeri, i reworked the liquibase changesets domain objects |
| 14:37:35 | <wyclif> djazayeri, there was alot of code daniel had done that we kept in the branch |
| 14:37:39 | <bwolfe> havne't all the order entry tickets been commiting to trunk? |
| 14:38:00 | *** pushkar has joined #openmrs |
| 14:38:21 | <bwolfe> sunbiz, is the hbm file no there? |
| 14:38:22 | <bwolfe> *not |
| 14:38:31 | <bwolfe> or the package definition in the hbm file ? |
| 14:38:51 | *** jordank has quit IRC |
| 14:39:12 | <sunbiz> bwolfe: it is there |
| 14:41:27 | <sunbiz> bwolfe: is it a problem if I have both webModuleApplicationContext and moduleApplicationContext ?? |
| 14:42:09 | *** kreddy has quit IRC |
| 14:43:27 | <bwolfe> sunbiz, no, both are fine. |
| 14:44:56 | <pushkar> bwolfe, Hi |
| 14:46:08 | *** kreddy has joined #openmrs |
| 14:47:12 | *** kreddy has quit IRC |
| 14:47:19 | <bwolfe> hi pushkar |
| 14:47:31 | *** kreddy has joined #openmrs |
| 14:48:54 | <pushkar> bwolfe, I created the tag and its able to get the editor in the htmlform |
| 14:50:26 | <bwolfe> very cool. now how ot get it to save when the user clicks save... :-) |
| 14:50:35 | <pushkar> I didnt use the <aware_of_modules> |
| 14:50:51 | <pushkar> I user the require_module in config .xml |
| 14:52:26 | <pushkar> bwolfe, thats what I wanted ti discuss,the thing is whenerver the tag appears I am putting a iframe and point the iframe to the page having the drawing editor |
| 14:53:14 | <pushkar> since the drawingeditor itself has a save button the button will work |
| 15:04:43 | <pushkar> is that the correct way bwolfe ? |
| 15:11:22 | <bwolfe> pushkar, thats not ideal |
| 15:11:42 | <bwolfe> the user should be able to just hit save at the bottom. or hit "cancel" and nothing has happened to the user |
| 15:11:45 | <bwolfe> err to the patient |
| 15:12:28 | <goutham> dkayiwa: Finally solved :P easy one but tricky to solve |
| 15:14:32 | *** kreddy has quit IRC |
| 15:15:01 | <pushkar> okay bwolfe so when the we say <drawing/> what all the things should I show there ? only the editor or the textboxes for concept patient encounter along with the editor? |
| 15:15:20 | <dkayiwa> goutham: great!!! :) |
| 15:15:42 | <bwolfe> pushkar, only the editor. the patient is the patient that the form is being filled out for. and the encounter is the one that will be created when the user clicks "save" at the bottom of the form. |
| 15:16:23 | <bwolfe> pushkar, can you show the editor in the normal page with normal input boxes? then is there a callback that you get with the values + the patient + the encounter when the user clicks "save" ? |
| 15:17:47 | *** kreddy has joined #openmrs |
| 15:17:56 | <pushkar> I didn't get you bwolfe |
| 15:20:12 | <goutham> dkayiwa: Have a look at it , brb :) |
| 15:20:15 | *** goutham has quit IRC |
| 15:21:39 | <bwolfe> pushkar, let me open the htmlformentry and check something out |
| 15:22:14 | *** reddykir_ has joined #openmrs |
| 15:22:16 | <bwolfe> djazayeri, you still awake? |
| 15:22:20 | *** kreddy has quit IRC |
| 15:22:23 | <pushkar> bwolfe, okay |
| 15:24:28 | <bwolfe> pushkar, I see "Also adds any necessary FormSubmissionControllerActions to the FormSubmissionController associated with the session." on the "TagHandler.doEndTag" method |
| 15:24:50 | <bwolfe> so your doEndTag should register an action that happens when the form is submitted |
| 15:26:53 | *** reddykir_ has quit IRC |
| 15:28:05 | <pushkar> okay bwolfe what about the question concept ?? |
| 15:29:47 | <bwolfe> oh, hmm, that should be passed in by the form creator. e.g. <drawing conceptId="123" /> when designing the form |
| 15:31:37 | <pushkar> and can we have multiple drawing tags in the same form ?? |
| 15:31:55 | <pushkar> bwolfe, |
| 15:33:28 | <bwolfe> yes, ideally you could |
| 15:34:18 | *** sunbiz has quit IRC |
| 15:35:32 | *** jordank has joined #openmrs |
| 15:39:12 | <bwolfe> pushkar, does that help you? |
| 15:40:08 | <pushkar> bwolfe, so now the portlet should take parameter called onlyeditor which says weather I should show the textboxes and save button in portlet or not ? |
| 15:41:01 | <bwolfe> pushkar, that sounds like a good option. or you just make two portlets. or you do something separate for HFE. :-) |
| 15:41:10 | <bwolfe> you could have 2 portlets |
| 15:41:29 | <bwolfe> one main one that has the textboxes and save box. then another portlet that the first one can call that only has the editor |
| 15:41:38 | <bwolfe> the second portlet is what you call from HFE |
| 15:41:55 | <bwolfe> but you shouldn't use an iframe. I don't think those values can be submitted with the form |
| 15:44:03 | <pushkar> yes.. Is there any other way to put the portlet into html form ?? |
| 15:46:32 | *** suranga has joined #openmrs |
| 15:46:32 | *** ChanServ sets mode: +v suranga |
| 15:47:30 | <pushkar> bwolfe, do you know of anyways to put portlet into htmlform ? |
| 15:52:09 | *** kreddy has joined #openmrs |
| 15:52:44 | <bwolfe> no |
| 15:52:54 | <bwolfe> you might have to copy/paste |
| 15:52:59 | <bwolfe> (from your portlet into the taghandler) |
| 15:56:14 | <pushkar> okay bwolfe thanks for the help!! :-) |
| 16:01:02 | *** harshadura has quit IRC |
| 16:08:04 | <bwolfe> pushkar, we'll need to document all of this once you're done. |
| 16:08:06 | <bwolfe> :-) |
| 16:08:26 | <bwolfe> pushkar, perhaps start small? get something into the form and get that data back into an action handler that you can act on |
| 16:08:54 | <bwolfe> then worry about getting the whole portlet there with its data. is the data in an html element or is it all javascript that was getting sent via ajax onsave? |
| 16:09:15 | *** pulasthi7 has joined #openmrs |
| 16:09:36 | *** venkaban has joined #openmrs |
| 16:09:48 | <pushkar> bwolfe, we get a sting of data if we say canvas.save() |
| 16:10:01 | <venkaban> bwolfe, Hi |
| 16:10:29 | <venkaban> bwolfe, Sorry I missed today's scrum.....To whom shall I list the updates from my side? |
| 16:10:47 | <venkaban> wyclif, Hi |
| 16:11:02 | <pushkar> bwolfe, we should send that back to the server to convert it into bytearray |
| 16:11:12 | <wyclif> hi venkaban |
| 16:11:58 | <pushkar> bwolfe, sure (about documentation) :-) |
| 16:12:01 | <venkaban> wyclif, for development are you using the branch? or trunk? |
| 16:12:27 | <venkaban> wyclif, and also to whom do we list the updates if we miss the scrum? |
| 16:13:49 | <wyclif> venkaban, am not working on the sprint tickets, am in the swimlabe this week |
| 16:14:06 | <wyclif> though i have work i had done in the past in that branch\ |
| 16:14:35 | <wyclif> venkaban, i plan to merge trunk and the branch today |
| 16:16:06 | <venkaban> wyclif, Ok. Do you know when that will be done so that I will plan to test my changes done to OrderService.java in trunk? |
| 16:18:24 | <venkaban> wyclif, I just checked your email. I will need to setup my trunk in eclipse now |
| 16:20:15 | <pushkar> bwolfe, its actually canvas.toDataUrl() |
| 16:22:24 | *** kreddy has quit IRC |
| 16:23:26 | *** harshadura has joined #openmrs |
| 16:25:15 | *** reddykir_ has joined #openmrs |
| 16:30:09 | <bwolfe> pushkar, what does that do? |
| 16:30:48 | <pushkar> bwolfe, it gives me a bse64 encoded string of the image |
| 16:31:28 | <bwolfe> ooo, perfect! so put that into the html element on the page. and your FormSubmissionControllerAction class will get that string passed to it |
| 16:31:53 | <pushkar> I am putting that in a hiddenfield and posting it back to the server |
| 16:32:00 | <bwolfe> actually, the method is handleSubmission(FormEntrySession session, HttpServletRequest submission). looks like you get every tag in the form! |
| 16:32:55 | <pushkar> bwolfe, yes I as long as i knowthe id of my element I can get it |
| 16:33:19 | <bwolfe> pushkar, for the htmlformentry tag. your TagHandler.doStartTag will add your canvas and js to the page with the PrintWriter. the doEntTag method will instantiate a new DrawingFormSubmissionControllerAction and add it to the session.FormSubmissionController |
| 16:33:57 | <bwolfe> then the DrawingFormSubmissionControllerAction.handleSubmission will look in the session object (or the submission object?) and get the parameter for your hidden html element |
| 16:35:02 | <bwolfe> also creates a new obs and adds it to the session.encounter in the handleSubmission method |
| 16:36:12 | <venkaban> bwolfe, Hi |
| 16:36:22 | <bwolfe> good morning venkaban. how does it? |
| 16:36:31 | <pushkar> great!!!! now it looks very simple thanks for explaining bwolfe :-) |
| 16:37:12 | *** mvorobey has joined #openmrs |
| 16:37:32 | <bwolfe> pushkar, please add "updating the HFE wiki page" with info like this to your TODO list. :-) at least we need a bare bones paragraph. and make some very small examples. and then links to your code probably once its all committed and working. |
| 16:37:34 | <venkaban> bwolfe, I missed the scrum meeting today, The update is I have merged the code to OrderService.java in trunk but the whole trunk is not synced with the code in branch. So I am trying to get the changes to branches first as of now |
| 16:38:03 | <pushkar> bwolfe, do we need a different portlet? anyway we are hardcoding the portlet |
| 16:38:10 | <bwolfe> venkaban, right, you only need the small changes though |
| 16:38:11 | <pushkar> in the do start taf |
| 16:38:20 | <pushkar> *tag |
| 16:38:32 | <bwolfe> pushkar, I don't think you can call the portlet from the doStartTag. I think you will have to manually put the html into the printwriter. |
| 16:38:52 | <venkaban> bwolfe, Ok. Moving forward do we develop against Trunk or Branch? |
| 16:39:16 | <venkaban> bwolfe, In this case I was asked to do against branch. |
| 16:39:35 | <bwolfe> pushkar, look at other TagHandlers in HFE to see how it puts the html into the form/printwriter |
| 16:40:07 | <bwolfe> I asked earlier, I missed the answer. cpower, wyclif, djazayeri, rafa, dkayiwa: are we doing order entry stuff against trunk or branch ?! |
| 16:40:26 | <djazayeri> wyclif, dkayiwa, rafa might know the answer |
| 16:40:27 | <dkayiwa> bwolfe: branch |
| 16:40:42 | <bwolfe> is anything in trunk for new order service? |
| 16:40:59 | <dkayiwa> bwolfe: yes some of use first committed to trunk |
| 16:41:00 | <pushkar> yes ,you asked me to create two potlets one for only editor and one for the textboxes and editor. I guess now creation of the only editor portlet is not required right? |
| 16:41:01 | <wyclif> i think they have been wprking against trunk |
| 16:41:13 | <dkayiwa> bwolfe: then wyclif said he will merge from trunk to branch |
| 16:41:14 | <wyclif> i need to merge the branch to trunk |
| 16:41:22 | <bwolfe> pushkar, right |
| 16:41:37 | <bwolfe> WTF is going on. |
| 16:41:47 | <bwolfe> what is in trunk? |
| 16:42:17 | <wyclif> i will have to merge from trunk so that they can work against the branch |
| 16:42:29 | <wyclif> i dont want to merge the code to trunk now |
| 16:42:29 | <rafa> bwolfe: there were only 3 tickets committed to trunk |
| 16:42:47 | <wyclif> there was some confusion and i sent the sprinters an email about this |
| 16:42:47 | <rafa> bwolfe: nothing big |
| 16:43:07 | <wyclif> so i suggested they code against the branch |
| 16:44:11 | <rafa> wyclif: bwolfe: tickets which need to be moved to the branch: TRUNK-3324, TRUNK-3311 and TRUNK-3309 |
| 16:44:17 | *** venkaban has quit IRC |
| 16:44:59 | *** venkaban has joined #openmrs |
| 16:45:23 | <rafa> it's fine if they stay in trunk |
| 16:45:30 | <rafa> no need to revert them |
| 16:45:51 | <venkaban> bwolfe, Sorry I got disconnected in the middle |
| 16:46:03 | <bwolfe> wyclif, sent what sprinters an email? I didn't see it. why was it not announced here or on the mailing list or the tickets updated? |
| 16:46:19 | <venkaban> bwolfe, SO we code against branch? |
| 16:46:19 | <bwolfe> !ticket TRUNK-3324 |
| 16:46:20 | <OpenMRSBot> bwolfe: [#TRUNK-3324] Revisit DrugOrderValidator - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3324 |
| 16:48:20 | <wyclif> this was all my mess not to tell people to code against the branch since i hadnt yet merged evrythin gin it to trunk |
| 16:50:04 | <rafa> wyclif: not really a mess. It's good you spotted that before we actually started reimplemeting things that are already implemented in the branch :) |
| 16:50:36 | <venkaban> wyclif, dont worry about it now, once we have the merge done then everything should be fine |
| 16:52:25 | <rafa> wyclif: do we need an actual merge or is it enough to commit the three tickets to the branch as well? |
| 16:55:17 | <wyclif> rafa, that is an option |
| 16:55:26 | <suranga> hi dkayiwa |
| 16:55:33 | <suranga> dkayiwa, are you here ? :) |
| 16:55:34 | <dkayiwa> hi suranga |
| 16:55:38 | <dkayiwa> :) |
| 16:55:51 | <wyclif> rafa, actually an easier one |
| 16:56:04 | <suranga> dkayiwa, he hee... you may regret answering me :P |
| 16:56:06 | <rafa> wyclif: okay, let me do that |
| 16:56:15 | <suranga> dkayiwa, We're facing a teeny weeny problem.... |
| 16:56:16 | <dkayiwa> suranga: [:) |
| 16:56:31 | <wyclif> cool, thanks rafa |
| 16:56:33 | <rafa> wyclif: I'll see if the branch is in a good shape first |
| 16:56:35 | <dkayiwa> suranga: with xforms? :) |
| 16:56:38 | <rafa> wyclif: run all tests... |
| 16:56:47 | <suranga> dkayiwa not reallly |
| 16:57:06 | <suranga> dkayiwa, in my jsp, I have something like <spring:bind |
| 16:57:07 | <suranga> path="patientMatchingConfiguration.configurationEntries[${entriesIndex.count - 1}].flag"> |
| 16:57:15 | *** mgielow has joined #openmrs |
| 16:57:24 | <suranga> dkayiwa, how may I access this list of objects via javascript ? :) |
| 16:58:12 | <dkayiwa> suranga: i do not know off the head. would need to first look at existing jsps. maybe others have an off the shelf answer :) |
| 16:59:10 | <suranga> dkayiwa, http://pastebin.com/p8nz1Tfe |
| 16:59:26 | <suranga> dkayiwa, I told you might regret answering :P |
| 16:59:38 | <dkayiwa> suranga: :( |
| 17:00:07 | <suranga> dkayiwa, dont worry about it.. lets see if anyone has a quick answer :) |
| 17:00:39 | <dkayiwa> suranga: they may do so if you put them on the sport by ircying their names :) |
| 17:10:29 | *** goutham has joined #openmrs |
| 17:16:00 | <goutham> dkayiwa: Im back B ) |
| 17:16:20 | <dkayiwa> goutham: ok :) |
| 17:16:39 | <goutham> dkayiwa: so u seen it? |
| 17:16:48 | <dkayiwa> goutham: yes |
| 17:17:01 | <goutham> dkayiwa: Is it fine ? |
| 17:17:10 | <dkayiwa> goutham: perfect :) |
| 17:17:23 | <goutham> dkayiwa: Kool :) |
| 17:17:53 | <goutham> dkayiwa: Coming to the next step , how should be the page when i click on a form |
| 17:18:32 | <suranga> hi james_regen |
| 17:18:39 | *** mccallumg has joined #openmrs |
| 17:18:39 | <dkayiwa> goutham: i would love to give you the first chance such that we take advantage of your creativity :) |
| 17:18:44 | <suranga> james_regen, we have a small question again, unfortunately :-) |
| 17:18:48 | *** ChanServ sets mode: +v mccallumg |
| 17:18:59 | <mccallumg> hey jordank |
| 17:19:12 | <jordank> hello |
| 17:19:54 | <mccallumg> jordank: I'm here if you need me for anything ... |
| 17:20:05 | <goutham> dkayiwa: i am thinking of list of filters with check box side to it |
| 17:20:05 | <bwolfe> suranga, lists are hard to do in jsp |
| 17:20:13 | <bwolfe> but you might be able to make a js list out of them. |
| 17:20:18 | <suranga> bwolfe, hi !!!! |
| 17:20:23 | <dkayiwa> goutham: ok |
| 17:20:26 | <james_regen> suranga: hi |
| 17:20:37 | <suranga> bwolfe, I hope you understood out question clearly... |
| 17:20:49 | <bwolfe> does taking out the ${} work ? : <spring:bindpath="patientMatchingConfiguration.configurationEntries[entriesIndex.count-1].flag"> |
| 17:21:19 | <goutham> dkayiwa: on checking it, a pop up type window should come asking parameters :) |
| 17:21:57 | <dkayiwa> goutham: how about first defining and saving the filters separately from the forms |
| 17:21:58 | <dkayiwa> ? |
| 17:22:00 | *** elliott_w has quit IRC |
| 17:22:09 | <suranga> bwolfe, basically, we have a form which contains a table. Each table row consists of a single configuratiionEntry. when submitting this list, we are passing it into a javascript method via (this) |
| 17:22:29 | <suranga> bwolfe, our problem is, how to access this list via javascript :-) |
| 17:22:35 | <jordank> mccallumg: thanks! can I send you a the new mockups over skype? they're in ppt |
| 17:22:58 | *** elliott_w has joined #openmrs |
| 17:23:24 | *** elliott_w has joined #openmrs |
| 17:23:24 | *** ChanServ sets mode: +o elliott_w |
| 17:23:32 | <goutham> dkayiwa: so on checking the check box i should redirect to respective filter asking parameters and submit them |
| 17:23:53 | <suranga> bwolfe, basically, we need to take this <spring:bindpath="patientMatchingConfiguration.configurationEntries[${entriesIndex.count-1}].inclusion"> and access the list entries via javascript |
| 17:24:08 | <bwolfe> suranga, the javascript <--> jsp integration is a tricky one to figure out. |
| 17:24:22 | <dkayiwa> goutham: no need for redirecting. simply saving the selected filters whose parameters were already defined on some other separate page and saved earlier on |
| 17:24:41 | <suranga> bwolfe, eeek... mm.. anywhere there is a good sample we can try out ? |
| 17:24:47 | *** lakkarau has joined #openmrs |
| 17:24:54 | <djazayeri> suranga |
| 17:25:00 | <djazayeri> presumably you're doing something like: |
| 17:25:09 | <venkaban> bwolfe, Hi |
| 17:25:14 | <bwolfe> so you do: var mylist = new Object(); <spring:bindpath="patientMatchingConfiguration.configurationEntries[${entriesIndex.count-1}].inclusion">mylist[0] = "${status.value}"; </spring:bind> |
| 17:25:28 | <bwolfe> hi venkata |
| 17:25:54 | *** sansa has joined #openmrs |
| 17:26:00 | <venkaban> bwolfe, for the previous tickets TRUNK - 3363 and TRUNK - 3378, I have submitted the patches right? Shall I make a commit to the code or are you going to apply the patches to the svn repo? |
| 17:26:34 | <venkaban> I am now thinking to replace my local eclipse with branch instead of having trunk.....plase advise? |
| 17:26:40 | <suranga> bwolfe, hmmm.... I see... umm... djazayeri Love to hear your advice too :-) |
| 17:26:49 | <sansa> hello, i am trying to install openmrs standalone edition but i am getting this error |
| 17:26:52 | <sansa> com.mysql.management.util.SQLRuntimeException: User initialization error. Can not connect as openmrs with password. Can not connect as root without password. URL: jdbc:mysql://127.0.0.1:3316/mysql |
| 17:27:08 | <sansa> please advise me what to do? |
| 17:27:14 | <bwolfe> venkaban, why not have both? but for now, yes, apparnetly code order entry service tickets against the order-entry branch |
| 17:27:32 | <djazayeri> suranga: presumably you're doing something like: <c:forEach…> <spring:bind…> <input … name="${ status.expression }" …> ... |
| 17:27:48 | *** elliott_w has quit IRC |
| 17:27:52 | <venkaban> bwolfe, Ok. You want me to have both the projects in my local dev station? |
| 17:27:54 | <djazayeri> suranga: if you want to access something via javascript, you either need to put it in a javascript variable, or else put it in the DOM |
| 17:28:01 | <goutham> dkayiwa: some other page means ? |
| 17:28:24 | <venkaban> bwolfe, what about the patches? Do I have to commit them from my local dev or are you going to apply the patches to svn repo? |
| 17:28:31 | <dkayiwa> goutham: one which you will create for simply defining filters and their parameters |
| 17:28:50 | <suranga> djazayeri, in our case, we have this data inside a form, and are passing it into the javascript method |
| 17:28:54 | <lakkarau> bwolfe, Hi |
| 17:29:40 | <djazayeri> suranga: you can access the data from the form via javascript, but js is run client-side *after* the page load, so you have no access to the contents of spring:bind unless you wrote those to a javascript variable, or to the DOM |
| 17:29:50 | <lakkarau> bwolfe, i am uma |
| 17:30:11 | <sansa> hello chat.could someone please tell me how to get around the problem..do install any msql server |
| 17:30:11 | <lakkarau> joined merck yesturday |
| 17:31:00 | <suranga> djazayeri, umm... I see... |
| 17:31:05 | <sansa> i am following instructions from http://en.flossmanuals.net/command-line/ch005_beginning-syntax/ |
| 17:31:08 | <OpenMRSBot> <http://ln-s.net/$HV+> (at en.flossmanuals.net) |
| 17:32:25 | <pulasthi7> djazayeri, there is a problem with the DOM access |
| 17:32:49 | <lakkarau> bwolfe,ok. |
| 17:33:54 | <goutham> dkayiwa: for different forms , there will be same parameter values ? I mean for GenderFilter , when we need to restrict form for female patient then |
| 17:34:03 | <pulasthi7> djazayeri, the <input> tags does not have the name as the entry. |
| 17:34:33 | <goutham> dkayiwa: so we say property value as female |
| 17:34:33 | <dkayiwa> goutham: the filter could be identified by name |
| 17:34:41 | <sansa> hello openmrscommunity ,could ou please help me ..i am having problems installing the standalone version |
| 17:34:57 | <pulasthi7> djazayeri, it has a common name as configurationEntries[x] like an array |
| 17:34:59 | <dkayiwa> goutham: for instance you could have two genderfilters where one is for males while the other is for females |
| 17:35:01 | <djazayeri> pulasthi7: via js you'll have to access things using the name on the input tag, or else give the tag an id. |
| 17:35:20 | <djazayeri> sansa: what's your problem, if you describe it maybe someone can help you |
| 17:35:21 | <goutham> dkayiwa: ok |
| 17:35:23 | <dkayiwa> goutham: then after selecting the form, you chose the appropriate filter from the list of filter names |
| 17:36:33 | <suranga> sana what steps of the setup process did you complete so far ? |
| 17:36:39 | <sansa> i am getting this error: Exception in thread "main" com.mysql.jdbc.exceptions.jdbc4.MySQLNonTransientConnectionException: Could not create connection to database server. Attempted reconnect 3 times. Giving up. |
| 17:37:01 | <djazayeri> sansa: on the standalone? that's odd |
| 17:37:08 | <sansa> i just ran run-on-linux.sh |
| 17:37:10 | <sansa> yes |
| 17:37:12 | <djazayeri> have you tried deleting everything, unzipping it again, and restarting? |
| 17:37:41 | <sansa> no |
| 17:37:58 | <sansa> should i delete the entire folder and unzip again? |
| 17:38:01 | <suranga> sansa, also delete the app data / openmrs folder |
| 17:38:17 | <sansa> where is this folder :: app-data? |
| 17:38:35 | <pulasthi7> djazayeri, the configuration name is somewhere else with a <td> tag. so it is bit hard to get the entry name from <td> tag and the value of it with the <input> tag. |
| 17:38:49 | <bwolfe> suranga, sansa, the appdata is just in the same folder you unzipped. |
| 17:38:59 | <bwolfe> you can start afresh by just deleting whole folder and re-unzipping |
| 17:39:02 | <bwolfe> its like magic! |
| 17:39:03 | <bwolfe> :-) |
| 17:39:15 | <sansa> ok ..will try again |
| 17:39:27 | <bwolfe> hi lakkarau! welcome! |
| 17:39:32 | <pulasthi7> djazayeri, but seems your second solution, assigning js variables will do the work :) |
| 17:39:44 | <djazayeri> pulasthi7: can you do something like: <td>${ c.label }</td><td><input id="config-${ c.id }" .../></td> |
| 17:39:49 | <bwolfe> can you email me from your new address? ben@openmrs dot org |
| 17:39:51 | <suranga> bwolfe, thanks, one hangs around IRC, and one learns :-) |
| 17:40:08 | <djazayeri> pulasthi7: then reference it by id, rather than name? |
| 17:41:32 | <lakkarau> bwolfe,Thank you.currently setting my environment. |
| 17:41:33 | <sansa> bewolfe i am unable to delete the folder i get this error |
| 17:41:34 | <sansa> rm: cannot remove `openmrs-standalone-1.9.0/database/bin': Directory not empty |
| 17:42:31 | <pulasthi7> djazayeri, thanks, I'll try that code and call you back if needed :-) |
| 17:42:45 | <goutham> dkayiwa: so i will have seperate form for each filter category(gender,age etc) by which i will can create N number of seperate Filter scenario's which i have to list against a form to apply to it |
| 17:42:54 | <bwolfe> lakkarau, has venkaban been helping you? |
| 17:43:01 | <bwolfe> speaking of venkaban, what are you working on now? |
| 17:43:26 | <dkayiwa> goutham: for each form, one can choose any number of filters they want |
| 17:44:16 | <goutham> goutham: yes |
| 17:46:08 | <sansa> @bwolfe ,i am unable to delete the databse folder |
| 17:46:55 | <bwolfe> sansa, a process might be attached to it. is mysqld running in the background? |
| 17:46:58 | <suranga> sansa, have you another console open which is pointing to that folder ? |
| 17:47:07 | <bwolfe> did you click "stop" on the program dialog? |
| 17:47:24 | <bwolfe> "ps aux |
| 17:47:35 | <bwolfe> yes, or a console as suranga says |
| 17:47:58 | <bwolfe> sansa, or "rm -rf *" |
| 17:48:04 | <bwolfe> (in the standalone foler) |
| 17:48:23 | <bwolfe> -rf will delete empty directories (and recurse down) |
| 17:48:50 | <sansa> rm -rf does not work |
| 17:49:10 | <sansa> but grep to ps throws on a lot of data about mysql |
| 17:49:16 | <sansa> how should i close this? |
| 17:51:34 | *** rafa has quit IRC |
| 17:52:40 | <sansa> ok.killed it ..starting again :) |
| 17:56:05 | <goutham> dkayiwa: can you give me brief picture of the UI for both chosing filters against a form and defining properties of a filter please ... |
| 17:56:44 | <dkayiwa> goutham: would always love to start with your creativity (what you think) :) |
| 17:57:46 | <sansa> hello,bwolfe i tried what you said and it is giving me this error: |
| 17:57:48 | <sansa> SQL: null ErrorCode: 1130 com.mysql.management.util.SQLRuntimeException: User initialization error. Can not connect as openmrs with password. Can not connect as root without password. URL: jdbc:mysql://127.0.0.1:3316/mysql |
| 17:58:18 | <sansa> which password do i need? |
| 17:58:20 | <bwolfe> goutham / dkayiwa: using a balsamiq mockup in the wiki or on a ticket? |
| 17:58:31 | <bwolfe> sansa, this is with a fresh unzip ? |
| 17:58:36 | <sansa> yes |
| 17:58:45 | <dkayiwa> bwolfe: thanks for the tip :) |
| 17:58:51 | <bwolfe> dkayiwa, any ideas on that? whats the usual error there for sansa? |
| 17:59:02 | <bwolfe> goutham, balsamiq is awesome. try it out! |
| 17:59:10 | <bwolfe> its tools-->add diagram in the wiki |
| 17:59:14 | <djazayeri> sansa, is mysql already running on your box? i.e. before installing the standalone? |
| 17:59:26 | *** sunbiz has joined #openmrs |
| 17:59:26 | *** ChanServ sets mode: +v sunbiz |
| 17:59:30 | <sansa> no |
| 17:59:54 | <goutham> bwolfe: yah |
| 18:00:07 | <goutham> on it :) thanks bwolfe |
| 18:02:01 | <dkayiwa> bwolfe: sansa i would stop the standalone, delete the expanded folder, unzip and try again (assuming he has no data to fear losing) |
| 18:02:20 | <suranga> sansa, I guess you better try logging into mysql first. if that works, it should also work for the standalone with the same credentials |
| 18:02:39 | <bwolfe> dkayiwa, he already did that |
| 18:03:46 | *** sansa has quit IRC |
| 18:03:50 | <dkayiwa> bwolfe: sansa did he ensure that there was no mysql process running? |
| 18:04:36 | <goutham> dkayiwa: will be back with design |
| 18:04:41 | <dkayiwa> goutham: you see what i was telling you? the beauty of the public vs private chat? bwolfe has just given us a tip which me and you had not thought of :D |
| 18:04:59 | *** mvorobey has quit IRC |
| 18:06:54 | <goutham> dkayiwa: yes ....you are awesome :) |
| 18:11:00 | *** reddykir_ has quit IRC |
| 18:11:32 | *** sansa has joined #openmrs |
| 18:12:16 | <sansa> @bewolfe i keep getting the same error even though i have killed all myswl processes before installing it again |
| 18:14:00 | <sansa> here is the whole error log :http://pastebin.com/xqqGcYsA |
| 18:14:12 | *** r_friedman has joined #openmrs |
| 18:14:34 | <r_friedman> @bwolfe |
| 18:14:53 | <r_friedman> ben, can we chat about RESTWS-262? |
| 18:16:41 | <bwolfe> sure |
| 18:17:04 | <r_friedman> so suppose I want to find all patients whose tribe attribute = Zulu |
| 18:17:19 | <r_friedman> I'd have to first find concept by name to get the concept id for Zulu |
| 18:18:00 | <sansa> bwolfe can you please help me with what is wrong? |
| 18:18:26 | <r_friedman> then I'd have to do the person search for attribute=tribe and value=zulu concept uuid |
| 18:18:53 | <r_friedman> if i was really desperate, i'd have to first find the tribe attribute id in person_attribute_type |
| 18:19:27 | <r_friedman> is that how you see it, bwolfe? |
| 18:20:09 | <bwolfe> sansa, do you have the window open that pops up when you start it? what port does it say mysql is running on? |
| 18:20:39 | <sansa> bwolfe it says 3316 |
| 18:20:49 | <bwolfe> r_friedman, there is a .search() function on the attributable I think. |
| 18:21:04 | <bwolfe> r_friedman, so its up to the Tribe object to search. the restws would just be delegating to that |
| 18:22:59 | <r_friedman> bwolfe: but it sounds like you agree with me; (1) find the uuid for the attribute_type; (2) find the uuid for the value; (3) find the list of persons with that attribute and value |
| 18:25:04 | <bwolfe> on the client search end? no, its: 1) find attribute type uuid 2) call getPersons(query=zulu, attrtype=uuidofattrtype) |
| 18:25:19 | <bwolfe> restws would look up attrtype and call attrypte.search(zulu). |
| 18:25:35 | <bwolfe> the attrtype looks at tribe table in the name column for the zulu string |
| 18:25:58 | <bwolfe> and the attrtype returns a list of persons matching that. |
| 18:26:05 | <bwolfe> but all that should be done. not 100% sure, but shoudl be |
| 18:27:03 | <r_friedman> bwolfe: so we have a search on attrtype producing a list of persons? that's why i added attrtype.persons, so it could just return an attrtype as usual |
| 18:30:24 | <r_friedman> bwolfe: i don't have a working dev computer right now, so it's hard for me to check. If I have an attributetype whose value is a concept and whose set of potential values is in a concept set, what of that information is kept in an old paradigm <x>_attribute_type and <x>_attribute? |
| 18:31:12 | <sansa> bwolfe : any ideas to what could be the problem? |
| 18:31:33 | <bwolfe> r_friedman, I'm not sure what you're asking. person_attribute_type and person_attribute is the old paradigm. everything else is the new stuff (location attributes, order attributes?, anything else?) |
| 18:32:11 | <bwolfe> r_friedman, Attributable has a List<T> getPossibleValues(String) method. so in restws it will be easy to add a search of attributes given an attributetypeuuid |
| 18:35:02 | <r_friedman> bwolfe: Attributable is the annotation for <x>_attribute_type? |
| 18:35:30 | <bwolfe> r_friedman, its the old one. I don't remember hte new one |
| 18:36:20 | <r_friedman> bwolfe: so <T> is a list of person_attribute_types? |
| 18:36:30 | <bwolfe> no, list of persons |
| 18:36:31 | <bwolfe> or concepts |
| 18:36:33 | <bwolfe> or tribes |
| 18:36:37 | <bwolfe> whatever the attributable is on |
| 18:37:35 | *** mvorobey has joined #openmrs |
| 18:37:41 | <r_friedman> bwolfe: ok, but look at it from the REST side |
| 18:38:20 | <r_friedman> bwolfe: normally, when we make a query on a resource, we get back a resource of that type or a list of them |
| 18:38:24 | <bwolfe> r_friedman, from the client side? I did above. its just getPerson?q="zulu"&attrtypeuuid=23232 |
| 18:39:55 | <sansa> i'm sorry for spamming the openmrs chat , but can anyone here help me please? |
| 18:40:13 | <bwolfe> sansa, sorry, too many chatters today. :-) |
| 18:40:24 | <bwolfe> sansa, I'm not sure what else is wrong. make sure port 3316 is actually free |
| 18:40:28 | <bwolfe> try using a diff port? |
| 18:40:39 | <r_friedman> bwolfe: i guess i'll just have to look at it when I can look at the code |
| 18:40:50 | <bwolfe> try connecting to the mysql instance now while it is running? (see standalone page for how to do that) |
| 18:41:09 | <bwolfe> sansa, which version did you download? |
| 18:41:33 | <bwolfe> I need to step out. bb in 20 mins. sansa, feel free to keep bugging people! :-) |
| 18:44:11 | *** sansa has quit IRC |
| 18:46:17 | *** sansa has joined #openmrs |
| 18:46:52 | <sansa> hello, can someone please help me getting the standalone edition working? |
| 18:48:17 | <r_friedman> sansa, how can i help? |
| 18:48:50 | <sansa> i am getting this error: http://pastebin.com/xqqGcYsA |
| 18:50:02 | <r_friedman> did you set up a root password when you set up MySQL? |
| 18:50:43 | <sansa> no , i am following instructions from :http://en.flossmanuals.net/openmrs-guide/installation-and-initial-setup/ |
| 18:50:46 | <OpenMRSBot> <http://ln-s.net/$HX$> (at en.flossmanuals.net) |
| 18:50:59 | <sansa> and it said nothing of that sort |
| 18:52:21 | *** mvorobey has quit IRC |
| 18:52:26 | <r_friedman> ok, it's sort of mystifying why you are getting mysql errors, bcs standalone uses H2 |
| 18:53:13 | <sansa> ok,what should i do? |
| 18:54:04 | <r_friedman> sansa, however, the notes do sound like it is trying to install mysql |
| 18:54:25 | <r_friedman> what OS are you using? |
| 18:56:32 | <r_friedman> sansa? |
| 18:57:26 | <sansa> :[ |
| 18:58:17 | <r_friedman> sansa, what os are you using? |
| 19:00:17 | *** kreddy has joined #openmrs |
| 19:01:35 | *** sansa has quit IRC |
| 19:02:31 | *** r_friedman has quit IRC |
| 19:05:51 | *** goutham has quit IRC |
| 19:10:05 | <sunbiz> I recently remember a discussion on @Transactional.... shouldn't it be on the service layer?? |
| 19:17:10 | <lakkarau> bwolfe,Yes venkat is helping. |
| 19:25:43 | *** goutham has joined #openmrs |
| 19:26:12 | <goutham> dkayiwa: i have added mockup in design page , https://wiki.openmrs.org/display/projects/Filtering+Forms+on+Dashboard+%28Design+Page%29 |
| 19:30:07 | *** cpower has quit IRC |
| 19:31:32 | <goutham> dkayiwa: der? |
| 19:33:56 | <dkayiwa> goutham: ok thanks :) |
| 19:34:17 | <dkayiwa> goutham: that was fast! :D |
| 19:34:36 | <goutham> dkayiwa: :) |
| 19:37:57 | <dkayiwa> goutham: can you send an email to the implementers and developers lists directing them to the mockups for feedback? :) |
| 19:38:30 | *** suranga has quit IRC |
| 19:38:39 | <goutham> dkayiwa: so then i should even describe |
| 19:38:59 | <goutham> dkayiwa : the situation , |
| 19:39:06 | <dkayiwa> goutham: yes |
| 19:39:44 | <dkayiwa> goutham: you know me and you are developers and hence it would be nice to have some end user input :) |
| 19:45:36 | <sunbiz> bwolfe: are u back?? |
| 19:47:34 | *** pushkar has quit IRC |
| 19:48:38 | <sunbiz> still getting the error |
| 19:48:39 | <sunbiz> org.codehaus.jackson.map.JsonMappingException: Conflicting getter definitions for property "retired": org.openmrs.BaseOpenmrsMetadata#isRetired(0 params) vs org.openmrs.BaseOpenmrsMetadata#getRetired(0 params) (through reference chain: org.openmrs.module.webservices.rest.SimpleObject["results"]->java.util.ArrayList[0]) |
| 19:57:16 | *** mvorobey has joined #openmrs |
| 19:58:13 | *** yanokwa has joined #openmrs |
| 19:58:13 | *** ChanServ sets mode: +v yanokwa |
| 20:00:38 | *** james_regen has quit IRC |
| 20:00:54 | <bwolfe> sunbiz, that means some object that is in the chain doesn't have a resource on it |
| 20:01:39 | <sunbiz> bwolfe: I cant seem to find that object |
| 20:01:49 | <sunbiz> results is part of NeedsPaging |
| 20:03:13 | <sunbiz> bwolfe: https://github.com/sunbiz/raxacore/blob/master/omod/src/main/java/org/raxa/module/raxacore/web/v1_0/resource/PatientListResource.java |
| 20:03:14 | <OpenMRSBot> <http://ln-s.net/$HDA> (at github.com) |
| 20:03:19 | <sunbiz> this is the Resource |
| 20:03:26 | <sunbiz> doesnt seem to have any object |
| 20:03:34 | *** dkayiwa has quit IRC |
| 20:04:12 | <bwolfe> strange |
| 20:04:37 | <venkaban> bwolfe, Hi |
| 20:05:28 | <sunbiz> bwolfe: yes... strange :'( |
| 20:05:31 | <venkaban> I got an error when i try to add a new project for order-entry in eclipse . I closed the trunk project in eclipse and renamed the new one as order-entry, bwolfe |
| 20:06:42 | *** jordank has quit IRC |
| 20:07:28 | <venkaban> bwolfe, Here is the link for the error http://pastebin.com/7w7JmFQd |
| 20:08:19 | *** reddykir_ has joined #openmrs |
| 20:09:25 | <bwolfe> venkaban, perhaps because we did the branching wrong in order-entry? try an "mvn clean install" on the root of the project |
| 20:09:36 | <venkaban> bwolfe, ok |
| 20:10:06 | *** kreddy has quit IRC |
| 20:10:21 | *** kreddy has joined #openmrs |
| 20:10:29 | *** reddykir_ has quit IRC |
| 20:11:21 | <venkaban> bwolfe, got the following error http://pastebin.com/D6SYv1mm |
| 20:11:45 | <bwolfe> sunbiz, yes, @Transactional /should/ be on impls. but we have just left them for now and will make the move when we (ever) rewrite |
| 20:12:52 | <sunbiz> bwolfe: thanks!! |
| 20:12:55 | <bwolfe> venkaban, run it with the "-X" flag or the "-e" flag as it says in the error output to see the big error |
| 20:12:58 | <sunbiz> bwolfe: any hints |
| 20:13:09 | <sunbiz> for the JsonMappingException |
| 20:13:50 | <bwolfe> sunbiz, are the results always and only PatientList objects ? |
| 20:14:20 | <sunbiz> yes... |
| 20:14:58 | <sunbiz> I tried doing a toString on those... and its like this results={xxxcxcPatientList1, xcxzcxPatientList2} |
| 20:16:03 | *** jordank has joined #openmrs |
| 20:21:23 | *** mvorobey has quit IRC |
| 20:21:29 | <venkaban> bwolfe, which version of maven is installed on your dev? |
| 20:21:53 | <venkaban> bwolfe, I have the plugins configured in eclipse for maven, not the whole maven |
| 20:23:10 | <bwolfe> I have 2.2 on my machine. (not sure what is in eclipse) |
| 20:24:00 | <venkaban> 2.2.1, bwolfe? |
| 20:24:14 | <bwolfe> ben@thinkben:~$ mvn -version |
| 20:24:14 | <bwolfe> Apache Maven 2.2.1 (rdebian-6) |
| 20:24:14 | <bwolfe> Java version: 1.6.0_25 |
| 20:24:14 | <bwolfe> Java home: /usr/lib/jvm/jdk1.6.0_25/jre |
| 20:24:14 | <bwolfe> Default locale: en_US, platform encoding: UTF-8 |
| 20:24:15 | <bwolfe> OS name: "linux" version: "3.0.0-20-generic" arch: "amd64" Family: "unix" |
| 20:24:17 | <bwolfe> ben@thinkben:~$ |
| 20:24:19 | <bwolfe> yes |
| 20:24:29 | <bwolfe> venkaban, try compiling at command line |
| 20:24:50 | <venkaban> bwolfe, Yeah I am planning to do it on command line side |
| 20:25:08 | <bwolfe> venkaban, get a note about the error somewhere on the wiki |
| 20:25:16 | <bwolfe> either as a comment with some helpful error message or something |
| 20:25:21 | <venkaban> Hey, I am late for lunchbwolfe, will resume work after lunch, will you be available till 5 or 6 EST? |
| 20:25:29 | <bwolfe> venkaban, is it not a download problem? connection is ok through eclipse? no proxies? |
| 20:25:34 | <venkaban> bwolfe, or even after 6 EST ;-) |
| 20:25:45 | <bwolfe> I will be available after, maybe later tonight |
| 20:26:00 | <bwolfe> but you can ask anyone here for asisstance, advice, or a suggestion on a new ticket |
| 20:26:02 | <venkaban> bwolfe, Yeah I will have to check by getting out of VPN but I lose the Xchat |
| 20:26:09 | *** pulasthi7 has quit IRC |
| 20:26:18 | <venkaban> bwolfe I will update with this one sec |
| 20:26:24 | <bwolfe> ok |
| 20:26:28 | <bwolfe> probably connection problem |
| 20:26:41 | <bwolfe> you can get eclipse to go through it, but you have to set it up. thats ont he wiki somewher etoo. perhaps the eclipse wiki page? |
| 20:28:18 | *** mgielow has quit IRC |
| 20:29:31 | *** lh has quit IRC |
| 20:30:40 | *** venkaban has quit IRC |
| 20:44:18 | *** rose has joined #openmrs |
| 20:44:44 | *** rose is now known as Guest52509 |
| 20:47:13 | *** lakkarau has quit IRC |
| 20:55:04 | *** kreddy has quit IRC |
| 20:55:06 | *** reddykir_ has joined #openmrs |
| 20:59:08 | *** reddykir_ has quit IRC |
| 21:04:43 | *** sgithens has quit IRC |
| 21:10:06 | *** mccallumg has quit IRC |
| 21:17:06 | *** goutham has quit IRC |
| 21:17:27 | *** venkaban has joined #openmrs |
| 21:18:16 | *** lh has joined #openmrs |
| 21:18:16 | *** lh has joined #openmrs |
| 21:26:15 | <venkaban> bwolfe, I actually checked with connection and when i tried mvn clean install out of VPN, build process completed successfully |
| 21:32:37 | <venkaban> wyclif, Hi |
| 21:33:16 | <wyclif> hi venkaban |
| 21:33:36 | <venkaban> I have created a changed copy for the ticket TRUNK - 3308 in branch and when I run Manven Install to test , I got the class symbol not found error for Class OrderType |
| 21:34:28 | <venkaban> wyclif, Could you please suggesst |
| 21:36:00 | <wyclif> venkaban, have you done mvn clean install |
| 21:36:31 | <wyclif> venkaban, actually we got rid of OrderType, so remove it from any method you are working on |
| 21:37:10 | <wyclif> venkaban, there is another order type we plan add but with a different meaning |
| 21:38:02 | <venkaban> wyclif, so you want me to remove methods that use order type as parameers? |
| 21:43:27 | <wyclif> venkaban, remove the arguments that have OrderType |
| 21:44:00 | <venkaban> wyclif, just the arguments but not the whole method right? |
| 21:46:20 | <venkaban> wyclif, what about the methods that have ordertype as its only argument? |
| 21:48:01 | <wyclif> venkaban, what ticket are you working on, there is no method in the branch using OrderType |
| 21:48:20 | <venkaban> wyclif, TRUNK 3308 |
| 21:49:08 | <wyclif> venkaban, TRUNK-3308 isn't using OrderType anywhere |
| 21:50:13 | <wyclif> venkaban, that is orderClassType that is a class object which could DrugOrder.class, TestOrder.class etc |
| 21:50:26 | <wyclif> be |
| 21:50:45 | <wyclif> venkaban, does that make sense? |
| 21:55:34 | *** venkaban has quit IRC |
| 21:59:10 | *** elliott_w has joined #openmrs |
| 21:59:10 | *** ChanServ sets mode: +o elliott_w |
| 22:01:06 | *** sunbiz1 has joined #openmrs |
| 22:01:07 | *** sunbiz has quit IRC |
| 22:02:51 | *** sunbiz1 has quit IRC |
| 22:17:20 | *** venkaban has joined #openmrs |
| 22:20:12 | <venkaban> wyclif, Hi |
| 22:20:28 | <wyclif> venkaban, hu |
| 22:20:38 | <wyclif> venkaban, did you see my last message |
| 22:20:42 | <venkaban> wyclif, sorry i got disconnected |
| 22:20:51 | <venkaban> wyclif, can you please resend it? |
| 22:20:52 | <wyclif> venkaban, that is orderClassType and not OrderType |
| 22:21:00 | <wyclif> it is s class object |
| 22:21:31 | <venkaban> wyclif, well the ordertype is not presern in order-entry branch but is present in trunk |
| 22:22:49 | <wyclif> venkaban, forget what you see in trunk, you are working against the branch |
| 22:22:57 | <wyclif> venkaban, so that should not be a problem |
| 22:23:04 | <venkaban> wyclif, yeah |
| 22:23:14 | <wyclif> venkaban, the branch has many differences with trunk |
| 22:23:16 | <venkaban> wyclif, but what in branch should be modified to now? |
| 22:24:30 | <venkaban> wyclif, I am a little confused as which file in which location should be modified |
| 22:24:38 | <venkaban> wyclif, can you please advise? |
| 22:24:43 | <wyclif> venkaban, those ticket descriptions say that check if what code is already in the branch, if it already there then comment on the ticket and change its status |
| 22:25:01 | <wyclif> venkaban, not every ticket might need coding |
| 22:25:07 | <wyclif> venkaban, let me look at the ticket |
| 22:25:10 | <venkaban> wyclif, Ok |
| 22:26:34 | <wyclif> if a method exists with the exact signature, just make sure uni tests exist, if not add them otherwise ticket require no work |
| 22:26:38 | <wyclif> venkaban, if a method exists with the exact signature, just make sure uni tests exist, if not add them otherwise ticket require no work |
| 22:27:16 | <wyclif> venkaban, sorry about the mess, normally not all work is like this |
| 22:27:43 | <venkaban> wyclif, so the method in order-entry branch is compared to which one (to check the signature)? |
| 22:28:02 | <wyclif> venkaban, why things with orders are the way they are is because we did some work in the past on it, changed the design so we need to make sure things conform with the new design |
| 22:28:33 | <wyclif> venkaban, the ticket description has the methods you need to check listed out |
| 22:28:51 | <venkaban> wyclif, only those two methods right? |
| 22:29:16 | <venkaban> wyclif, getOrder and getOrders? |
| 22:29:20 | <wyclif> there different tickets for that ticket just focus on those 2 |
| 22:29:53 | <wyclif> venkaban, the etask is to make sure we have methods we those exact signatures and have unit tests |
| 22:30:23 | <venkaban> wyclif, Ok. I will see whether the two methods getOrder and getOrders are present in the branch order-entry for two java files OrderService.java and OrderServiceImpl.java |
| 22:30:25 | <wyclif> venkaban, if everything including tests exist, that is all |
| 22:30:38 | <venkaban> Wyclif, Ok |
| 22:30:55 | <wyclif> venkaban, just change the ticket status from in progress to mean you are done |
| 22:31:04 | <wyclif> venkaban, in case there is nothing to code |
| 22:31:22 | <venkaban> Wyclif, got it. Thanks buddy |
| 22:31:39 | <venkaban> Wyclif, Moving forward all the coding should be done in branch or trunk? |
| 22:33:52 | <wyclif> venkaban, branch |
| 22:34:18 | <venkaban> Wyclif, 1.9.x? |
| 22:34:47 | <wyclif> am going to make a huge commit to the branch in the next 30min, so please remember to do svn update soon |
| 22:35:17 | <wyclif> venkaban, order-entry branch |
| 22:35:26 | <venkaban> Wyclif, ok |
| 22:35:51 | <wyclif> venkaban, branches ending with '.x' are maintenance branches |
| 22:36:02 | <venkaban> wyclif, ok |
| 22:36:25 | <venkaban> wyclif, update for branch or trunk? |
| 22:36:41 | <wyclif> venkaban, that is when we released 1.9.0, we created a 1.9.x branch where we back port and cut the minor releases like 1.9.1 |
| 22:36:51 | <wyclif> venkaban, branch |
| 22:37:07 | <wyclif> venkaban, anything to do with orders, just use the branch |
| 22:37:08 | <venkaban> wyclif, ok. Please let me know so that I will update |
| 22:37:16 | <wyclif> venkaban, sure i will |
| 22:37:19 | <venkaban> wyclif, for others? |
| 22:37:30 | <venkaban> wyclif, I mean for other modules? |
| 22:37:37 | <wyclif> venkaban, modules? |
| 22:37:55 | <wyclif> venkaban, i don't get you question well |
| 22:38:40 | <venkaban> wyclif, you said that for order we use branch for coding? what if the ticket needs to be worked on different module? |
| 22:40:39 | <wyclif> venkaban, everything in the sprint is in core and not module, module tickets don't start with TRUNK |
| 22:41:02 | <wyclif> venkaban, i.e everything to do with orders is in core |
| 22:41:26 | <venkaban> wyclif, ok |
| 22:41:59 | <venkaban> wyclif, currently i have the following method in OrderService.java in branch |
| 22:42:03 | <venkaban> wyclif, public <Ord extends Order> List<Ord> getOrders(Class<Ord> orderClassType, List<Patient> patients, |
| 22:42:03 | <venkaban> List<Concept> concepts, List<User> orderers, List<Encounter> encounters, Date asOfDate, |
| 22:42:04 | <venkaban> List<OrderAction> actionsToInclude, List<OrderAction> actionsToExclude); |
| 22:42:43 | <venkaban> wyclif, the ticket says add the method List<T extends Order> getOrders(Class<T extends Order> orderClassType, List<Patient> patients, List<Concept> concepts, |
| 22:42:43 | <venkaban> OrderAction action, List<User> orderers, List<Encounter> encounters, List<ConceptClass> conceptClasses); |
| 22:43:19 | <venkaban> wyclif, which has only few common paramters, shall I add the later one to fix the ticket ? |
| 22:45:04 | <wyclif> venkaban, let me look |
| 22:47:42 | <wyclif> venkaban, i think you need to add a new one but in the service layer it should delegate to the existing |
| 22:48:04 | <wyclif> venkaban, in the OrderServiceImpl |
| 22:48:10 | *** lakkarau has joined #openmrs |
| 22:48:46 | <venkaban> wyclif, so the OrderServiceImpl should also be added with the new method when we add it in OrderService right? |
| 22:48:54 | <wyclif> venkaban, wait a sec |
| 22:49:01 | <venkaban> wyclif, ok |
| 22:49:42 | <wyclif> venkaban, actually its better you add the extra arguments on the new one to the old one and make the necessary changes in the DAO to search on those extra arguments, including unit tests |
| 22:50:44 | <venkaban> wyclif, the current one in the branch is having the extra arguments which means the coding is already done |
| 22:50:47 | <wyclif> venkaban, am saying makes change to the existing method to accept the extra arguments, from what i see the extra argument is conceptClasses |
| 22:51:43 | <wyclif> venkaban, conceptClasses is the extra argument you have to add from what i see |
| 22:51:47 | <venkaban> wyclif, oh i see the extra argument that is present in the ticket but not in the code is conceptClasses.....got it |
| 22:52:09 | <djazayeri> wyclif: hey, what's that status of the calculation module |
| 22:52:15 | <djazayeri> so, you released 0.9 |
| 22:52:26 | <djazayeri> And we discussed something this morning |
| 22:52:47 | <djazayeri> That doesn't affect the API, right? I.e. it's just caching, for performance... |
| 22:53:23 | <wyclif> djazayeri, i will make that change, iw ant us to agree on calculate(Collection<Integer>...) during the design call |
| 22:53:30 | <venkaban> wyclif, also the OrderAction is made to a list in the current one.....which should be goog right? |
| 22:53:46 | <wyclif> djazayeri, it caching doesn't |
| 22:54:05 | <wyclif> djazayeri, but the change to batch processing might |
| 22:54:38 | <wyclif> djazayeri, after those changes, i think 1.0 should be fine to be out |
| 22:54:56 | <wyclif> venkaban, correct |
| 22:55:28 | <venkaban> wyclif, cool |
| 23:00:15 | *** elliott_w has quit IRC |
| 23:03:09 | *** lakkarau has quit IRC |
| 23:03:56 | *** lakkarau has joined #openmrs |
| 23:04:26 | *** lakkarau has joined #openmrs |
| 23:13:17 | *** lakkarau has quit IRC |
| 23:33:29 | <djazayeri> wyclif: I have a few spare minutes, I might make the Collection<Integer> change now |
| 23:34:34 | <wyclif> djazayeri, that would be awesome |
| 23:35:53 | <djazayeri> wyclif: we don't have a ticket aside from the one we were discussing things on, right? |
| 23:35:56 | <venkaban> wyclif, |
| 23:37:00 | <wyclif> djazayeri, i think so |
| 23:37:25 | <wyclif> all the unclosed calc tickets are on the current sprint dashboard |
| 23:37:57 | <venkaban> wyclif, if we add parameter to the existing getOrders method then the implementation for the getOrders method in different places like orderDAo, hibernateDAO and also in OrderServiceImpl |
| 23:41:42 | <wyclif> venkaban, yeah |
| 23:42:17 | <wyclif> venkaban, and have to add test to ensure that the new argument is getting matched against |
| 23:44:19 | *** venkaban has quit IRC |
| 23:48:40 | *** venkaban has joined #openmrs |
| 23:50:15 | *** venkaban_ has joined #openmrs |
| 23:50:16 | *** venkaban has quit IRC |