03:05:44
|
*** mgielow has joined #openmrs
|
03:14:45
|
*** dmexs has joined #openmrs
|
03:16:57
|
*** bwolfe has quit IRC
|
03:44:45
|
*** mgielow has quit IRC
|
05:07:22
|
*** pulasthi7 has joined #openmrs
|
05:22:41
|
*** goutham has joined #openmrs
|
05:37:53
|
*** maurya has joined #openmrs
|
05:38:47
|
*** ChanServ sets mode: +v maurya
|
05:52:24
|
*** magoo_ has joined #openmrs
|
06:39:22
|
*** dkayiwa has joined #openmrs
|
06:58:11
|
<magoo_> hi members
|
06:58:46
|
<magoo_> dkayiwa am getting this error message Can not find the tag library descriptor for http://java.sun.com/jsp/jstl/fmt schedulerList.jsp/openmrs-webapp-TRUNK/src/main/webapp/WEB-INF/view/admin/scheduler JSP Problem
|
06:59:21
|
<dkayiwa> magoo_: when?
|
07:00:55
|
<magoo_> dkayiwa am seeing it right now
|
07:01:16
|
<dkayiwa> magoo_: how do i reproduce it?
|
07:01:51
|
<magoo_> dkayiwa am not getting what you trying to mean
|
07:02:51
|
<dkayiwa> magoo_: if i wanted to get the same error, what should i do?
|
07:07:02
|
*** Goutham_vasiredd has joined #openmrs
|
07:07:09
|
<magoo_> dkayiwa sorry still i dont understand your question? for me what i thought mybe am missing tag library plugin
|
07:07:10
|
*** goutham has quit IRC
|
07:07:32
|
<dkayiwa> magoo_: have you tried to google it
|
07:08:08
|
<magoo_> yes
|
07:08:21
|
<magoo_> dkayiwa yes
|
07:08:41
|
<dkayiwa> magoo_: where is that error displayed
|
07:20:01
|
<magoo_> dkayiwa in the eclipse helios project explorer
|
07:21:11
|
<dkayiwa> can you do an: mvn clean install
|
07:22:25
|
<magoo_> okay
|
07:27:17
|
*** maurya has quit IRC
|
07:31:51
|
*** applecool has joined #openmrs
|
07:31:51
|
*** ChanServ sets mode: +v applecool
|
07:33:42
|
<magoo_> dkayiwa am getting the following errors url http://pastebin.com/ixSJfFMf
|
07:34:15
|
*** maurya has joined #openmrs
|
07:34:32
|
<dkayiwa> magoo_: have you tried to google it?
|
07:35:50
|
<magoo_> dkayiwa yes let try to apply some of the solutions am being provided with on the web
|
07:36:03
|
<dkayiwa> magoo_: ok :)
|
07:45:00
|
*** dkayiwa has quit IRC
|
07:48:50
|
*** wyclif has joined #openmrs
|
07:51:18
|
*** dkayiwa has joined #openmrs
|
07:53:58
|
<magoo_> dkayiwa the version of jdk matters?
|
07:54:08
|
<dkayiwa> magoo_: maybe
|
07:55:21
|
<magoo_> dkayiwa cause am using jdk1.7.0_04
|
07:55:40
|
<dkayiwa> magoo_: most of us use 1.6
|
08:01:27
|
<magoo_> dkayiwa its better i use 1.6
|
08:02:18
|
<dkayiwa> magoo_: safer for now :)
|
08:05:26
|
<magoo_> dkayiwa how abt tomacat 7.0
|
08:07:33
|
<dkayiwa> magoo_: i use 6
|
08:43:43
|
*** snoppy has joined #openmrs
|
08:47:11
|
*** harshadura has joined #openmrs
|
08:51:58
|
*** harshadura has quit IRC
|
08:58:23
|
*** rafa has joined #openmrs
|
08:58:23
|
*** ChanServ sets mode: +v rafa
|
09:23:21
|
*** magoo_ has quit IRC
|
09:23:23
|
*** Goutham_vasiredd has quit IRC
|
09:24:51
|
*** goutham has joined #openmrs
|
09:28:46
|
*** goutham has quit IRC
|
09:28:54
|
*** goutham has joined #openmrs
|
09:29:00
|
*** Goutham_vasiredd has joined #openmrs
|
09:32:40
|
<applecool> hi rafa
|
09:33:02
|
<rafa> hi applecool
|
09:35:06
|
<applecool> i have got a problem! now as you said we will autogenerate the filename later! until i get the filename i cant save it to the disk right? so first do i need to save it to the database itself and then save it on disk
|
09:35:52
|
<rafa> applecool: yes
|
09:36:03
|
<rafa> just change the order
|
09:36:40
|
<rafa> applecool: probably add filename parameter to saveFile
|
09:37:04
|
<rafa> applecool: you'll pass there id
|
09:37:26
|
<applecool> didnt get you
|
09:37:44
|
<rafa> applecool: ok do as you want :)
|
09:38:33
|
<applecool> if i take the filename from the user it can even have duplicates
|
09:38:47
|
<rafa> applecool: not from user
|
09:39:16
|
<rafa> applecool: it is an auto generated it set when you save a package to the db
|
09:39:49
|
<rafa> applecool: after you save a package package.getId() will return you a unique database key
|
09:40:05
|
<applecool> yes understood :)
|
09:40:07
|
<rafa> applecool: you can use it as a filename instead of UUID
|
09:40:25
|
<applecool> got it
|
09:40:38
|
<applecool> do you want me to change the view order too?
|
09:40:48
|
<rafa> applecool: the view order?
|
09:41:01
|
<applecool> means the package form wil come before the packageupload screen
|
09:41:12
|
<applecool> should i change that too?
|
09:41:13
|
<rafa> applecool: no that stays the same
|
09:41:47
|
*** Goutham_vasiredd has quit IRC
|
09:41:47
|
*** goutham has quit IRC
|
09:41:55
|
*** Goutham_vasiredd has joined #openmrs
|
09:41:55
|
*** goutham has joined #openmrs
|
09:42:47
|
<rafa> applecool: just change the PackageManager.save method
|
09:43:14
|
<rafa> applecool: to first call super.save() and then saveFile(filename, bytes)
|
09:44:06
|
<applecool> first we will have to save the package info and then the file to the disk right?
|
09:44:16
|
<rafa> applecool: yes
|
09:44:51
|
<rafa> applecool: the package info will be empty, but that's fine
|
09:45:17
|
<rafa> applecool: we're interested in getting an id from the db
|
09:46:59
|
<applecool> just i want to confirm whether i am thinking correct or not! i will just tell you how it works! please tell me whether it is correct or not!?
|
09:47:06
|
<applecool> shall i go ahead?
|
09:47:26
|
<applecool> rafa:
|
09:47:48
|
<rafa> applecool: yeah
|
09:48:26
|
<applecool> okay i am starting
|
09:48:40
|
<applecool> when we click on the upload, FileUploadController is called!
|
09:48:54
|
<applecool> which will have the contents of the file
|
09:49:20
|
<applecool> then it is redirected to the packageFormController with the file contents into HTTPSession
|
09:49:44
|
<rafa> applecool: no
|
09:50:08
|
<rafa> applecool: FileUploadController does save the file to disk
|
09:50:26
|
<rafa> applecool: no need to store it in the session
|
09:50:29
|
<applecool> but now it doesnt have a filename how will it save it to the disk
|
09:52:54
|
*** rafa_ has joined #openmrs
|
09:52:54
|
*** ChanServ sets mode: +v rafa_
|
09:53:02
|
<rafa_> applecool: sorry got disconnected
|
09:53:16
|
<applecool> no problem :)
|
09:53:23
|
<applecool> but now it doesnt have a filename how will it save it to the disk
|
09:53:42
|
<applecool> i mean the FileUploadController
|
09:54:51
|
*** rkorytkowski has joined #openmrs
|
09:54:51
|
*** ChanServ sets mode: +v rkorytkowski
|
09:54:55
|
*** rafa has quit IRC
|
09:55:59
|
<rkorytkowski> applecool: again :/
|
09:56:13
|
<applecool> but now it doesnt have a filename how will it save it to the disk
|
09:56:28
|
<applecool> i mean the FileUploadController
|
09:57:12
|
<rkorytkowski> When you save an empty package to the DB you'll get an Id
|
09:57:32
|
<rkorytkowski> Use that id as a filename
|
09:57:43
|
*** rafa_ has quit IRC
|
09:58:25
|
<rkorytkowski> Then you only need to pass the id to packageformcontroller
|
09:58:25
|
<applecool> okay :) got it
|
09:58:36
|
<applecool> okay :)
|
09:58:41
|
*** rafa has joined #openmrs
|
09:58:47
|
*** ChanServ sets mode: +v rafa
|
09:59:11
|
<rkorytkowski> And fill out the rest of package details and save again.
|
09:59:17
|
*** rkorytkowski has quit IRC
|
09:59:29
|
<applecool> okay :)
|
09:59:33
|
<rafa> back on broadband :)
|
09:59:39
|
<applecool> cool :)
|
10:21:02
|
*** pascal` has joined #openmrs
|
10:21:07
|
*** ChanServ sets mode: +v pascal`
|
10:23:51
|
*** mago_ has joined #openmrs
|
10:52:31
|
*** suranga has joined #openmrs
|
10:52:31
|
*** ChanServ sets mode: +v suranga
|
10:56:07
|
<suranga> hi pulasthi7
|
10:56:18
|
<suranga> pulasthi7, any luck with DWR ?
|
10:56:39
|
<rafa> applecool: hi
|
10:56:50
|
<applecool> hi rafa :)
|
10:56:59
|
<rafa> applecool: What are you working on right now?
|
10:57:35
|
<applecool> rafa: if the extension is .zip we generally use the ZipOutputStream right ? so now what will be the data inside it?
|
10:58:01
|
<rafa> applecool: No. You just use that if you want to manipulate a zip file.
|
10:58:15
|
<rafa> applecool: like unzipping
|
10:58:24
|
<rafa> applecool: and adding files
|
10:58:24
|
<applecool> okay!
|
10:58:43
|
<rafa> applecool: You haven't fixed your last commit, have you?
|
10:58:44
|
<applecool> so are we uploading a .zip file?
|
10:58:48
|
<rafa> applecool: yes
|
10:59:29
|
<applecool> i did i guess!
|
10:59:41
|
<applecool> no i dint !
|
10:59:44
|
<rafa> applecool: so you haven't pushed
|
11:00:42
|
<rafa> applecool: Why is it taking you so long?
|
11:01:00
|
<applecool> i was not feling well! so could not do that!
|
11:01:07
|
<applecool> i will commit it now
|
11:01:23
|
<rafa> applecool: I understand, but that was yesterday right?
|
11:01:53
|
<rafa> applecool: are you working today?
|
11:02:06
|
<applecool> yes i am working
|
11:02:13
|
<applecool> i will commit it in half an hour
|
11:02:21
|
<rafa> applecool: ok
|
11:02:53
|
<rafa> applecool: and have you started with the next task?
|
11:03:18
|
<applecool> yes
|
11:03:36
|
<rafa> applecool: when do you think it will be ready?
|
11:03:54
|
<applecool> by today evening
|
11:04:10
|
<rafa> applecool: and you have no more tasks right?
|
11:04:17
|
<applecool> no
|
11:04:21
|
<rafa> applecool: since 4th is not needed anymore
|
11:04:28
|
<applecool> yes
|
11:04:30
|
<suranga> mm.. hi dkayiwa or rafa have you ever encountered a scenario where Spring wont identify more than one request parameter for a POST request :-)
|
11:04:50
|
<applecool> so what will be the next tasks? searching and downloading right?
|
11:05:46
|
<rafa> applecool: first downloading then searching
|
11:05:57
|
<applecool> okay
|
11:06:54
|
<rafa> suranga: you mean you have two methods annotated with the same @RequestMapping(value = "/someUrl", method = RequestMethod.POST)?
|
11:07:08
|
*** Maurya_ has joined #openmrs
|
11:07:18
|
*** maurya has quit IRC
|
11:07:31
|
<suranga> hi rafa
|
11:07:38
|
<suranga> rafa actually its
|
11:07:39
|
<suranga> @RequestMapping(value = "/encounters", method = RequestMethod.POST)
|
11:07:40
|
<suranga> @ResponseBody
|
11:07:40
|
<suranga> public Object createEncounters(@RequestBody String hl7,
|
11:07:40
|
<suranga> @RequestParam(value = "enterpriseId", required = true) String enterpriseId,
|
11:07:40
|
<suranga> @RequestParam(value = "idType", required = true) String idType,
|
11:08:17
|
<suranga> for some reason, Spring fails to identify the second, third or fourth reuest param... mmm.. wierd.. is there some sort of limitation ? :-(
|
11:08:48
|
<rafa> what do you mean by fails to identify?
|
11:08:52
|
<rafa> what error do you get?
|
11:10:35
|
<rafa> suranga:
|
11:11:07
|
<suranga> oh, sorry rafa... i enter a call such as /encounter?id=123&idtype=anything
|
11:11:47
|
<suranga> and I get a missing servletrequestparameter exception
|
11:12:22
|
<rafa> suranga: you didn't give enterpriseId?
|
11:12:33
|
<suranga> rafa sorry , I did
|
11:12:59
|
<suranga> that gets identified, but anything after the first request parameter gets ignored, for some reason....
|
11:13:33
|
<suranga> rafa, my real curl call : C:\Users\HP\Downloads\curl-7.23.1-win64-ssl-sspi>curl -i -u admin:Password1 -H "Content-Type: text/plain" --data @test11.txt http://localhost:8080/ope
|
11:13:34
|
<suranga> nmrs/ws/rest/RHEA/patient/encounters?enterpriseId=1234&idType=ECID
|
11:14:09
|
<suranga> rafa, the ugly error :
|
11:14:10
|
<suranga> {"error":{"message":"Required String parameter 'idType' is not present","code":"org.springframework.web.servlet.mvc.annotation.AnnotationMethodHandler
|
11:14:10
|
<suranga> Adapter$ServletHandlerMethodInvoker:717","detail":"org.springframework.web.bind.MissingServletRequestParameterException: Required String parameter 'id
|
11:14:10
|
<suranga> Type' is not present\r\n\tat org.springframework.web.servlet.mvc.annotation.AnnotationMethodHandlerAdapter$ServletHandlerMethodInvoker.raiseMissingPar
|
11:14:11
|
<suranga> ameterException(AnnotationMethodHandlerAdapter.java:717)\r\n\tat org.springframework.web.bind.annotation.support.HandlerMethodInvoker.resolveRequestPa
|
11:14:14
|
<suranga> ram(HandlerMethodInvoker.java:501)\r\n\tat org.springframework.web.bind.annotation.support.HandlerMethodInvoker.resolveHandlerArguments(HandlerMethodI
|
11:14:19
|
<suranga> nvoker.java:340)\r\n\tat org.springframework.web.bind.annotation.support.HandlerMethodInvoker.invokeHandlerMethod(HandlerMethodInvoker.java:171)\r\n\t
|
11:14:22
|
<suranga> at org.springframework.web.servlet.mvc.annotation.AnnotationMethodHandlerAdapter.invokeHandlerMethod(AnnotationMethodHandlerAdapter.java:426)\r\n\tat
|
11:14:25
|
<suranga> org.springframework.web.servlet.mvc.annotation.AnnotationMethodHandlerAdapter.handle(AnnotationMethodHandlerAdapter.java:414)\r\n\tat org.springframew
|
11:14:28
|
<suranga> ork.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:790)\r\n\tat org.springframework.web.servlet.DispatcherServlet.doService(Dispatche
|
11:14:31
|
<suranga> rServlet.java:719)\r\n\tat org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:644)\r\n\tat org.springframework.web.
|
11:14:34
|
<suranga> servlet.FrameworkServlet.doPost(FrameworkServlet.java:560)\r\n\tat javax.servlet.http.HttpServlet.service(HttpServlet.java:727)\r\n\tat javax.servlet.
|
11:14:37
|
<suranga> http.HttpServlet.service(HttpServlet.java:820)\r\n\tat org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:487)\r\n\tat org.mortbay.jett
|
11:14:40
|
<suranga> y.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1093)\r\n\tat org.openmrs.module.web.filter.ForcePasswordChangeFilter.doFilter(Force
|
11:14:43
|
<suranga> PasswordChangeFilter.java:65)\r\n\tat org.mortbay.jetty.servlet.ServletHandler$CachedC
|
11:15:00
|
<rafa> suranga: use pastebin in the future :P
|
11:15:11
|
<suranga> rafa, sorry, my bad :-)
|
11:15:33
|
<applecool> please check the order of request too
|
11:15:43
|
<applecool> where is the hl7 string
|
11:17:32
|
*** james_regen has joined #openmrs
|
11:17:32
|
*** ChanServ sets mode: +v james_regen
|
11:21:11
|
<rafa> suranga: no clue
|
11:21:44
|
<suranga> rafa, hmm.. so I guess you guys have never faced this ? in that case, its probably "my- bad " :P
|
11:21:48
|
<rafa> suranga: what happens if you change the order of request?
|
11:21:57
|
<rafa> suranga: I mean the order of request params?
|
11:22:06
|
<suranga> then too it says it cant identify whatever comes last :-)
|
11:22:12
|
<suranga> rafa, ^^
|
11:22:28
|
<rafa> suranga: can you try with & ?
|
11:22:34
|
<rafa> suranga: instead of just &
|
11:22:51
|
<suranga> rafa, I seee... will try :-)
|
11:25:48
|
*** harshadura has joined #openmrs
|
11:31:41
|
*** mago_ has quit IRC
|
11:40:46
|
*** bwolfe has joined #openmrs
|
11:40:46
|
*** ChanServ sets mode: +o bwolfe
|
11:43:17
|
*** bwolfe has quit IRC
|
11:50:18
|
*** goutham has quit IRC
|
11:50:34
|
*** Goutham_vasiredd has quit IRC
|
11:51:53
|
*** Goutham_vasiredd has joined #openmrs
|
11:51:53
|
*** goutham has joined #openmrs
|
11:55:14
|
*** applecoo_ has joined #openmrs
|
11:57:19
|
*** bwolfe has joined #openmrs
|
11:57:19
|
*** ChanServ sets mode: +o bwolfe
|
11:58:15
|
*** applecool has quit IRC
|
11:59:08
|
*** Echidna has quit IRC
|
11:59:19
|
*** Echidna has joined #openmrs
|
11:59:19
|
*** ChanServ sets mode: +v Echidna
|
12:02:57
|
*** Goutham_vasiredd has quit IRC
|
12:02:59
|
*** goutham has quit IRC
|
12:08:16
|
*** harshadura has quit IRC
|
12:09:53
|
*** snoppy has quit IRC
|
12:10:01
|
*** pulasthi7 has quit IRC
|
12:13:38
|
*** applecoo_ has quit IRC
|
12:32:40
|
*** magoo_ has joined #openmrs
|
12:37:16
|
*** suranga has quit IRC
|
12:37:25
|
*** suranga_ has joined #openmrs
|
12:38:30
|
*** wyclif has quit IRC
|
12:43:05
|
*** 65MAAM0R2 has joined #openmrs
|
12:43:05
|
*** 31NABH9FT has joined #openmrs
|
12:45:12
|
<suranga_> good morning bwolfe !
|
12:45:32
|
<suranga_> bwolfe, we jembi people were wondering if you had finished my review :-)
|
12:45:33
|
<bwolfe> hey suranga_
|
12:45:46
|
<bwolfe> didn't I click complete?
|
12:45:59
|
* bwolfe doesn't remember
|
12:45:59
|
<suranga_> bwolfe, I dont think so :-)
|
12:46:11
|
<bwolfe> link me again...I'll click complete.
|
12:46:13
|
<bwolfe> :-)
|
12:46:23
|
<bwolfe> (unless you've add more files)
|
12:47:07
|
<suranga_> bwolfe, great, you can see it here http://jira.jembi.org/source/cru/CR-SHRADAP-2
|
12:47:47
|
<suranga_> bwolfe, and um... Wayne was also wondering if you could do another review of it once I fixed all your review comments ....
|
12:47:55
|
<suranga_> bwolfe, :-) :-) :P
|
12:48:58
|
*** Jibesh has joined #openmrs
|
12:49:47
|
<bwolfe> suranga_, yep, no problem. I can do another one later
|
12:50:26
|
<bwolfe> suranga_, you should add some more unit tests too. It will make you sleep better at night. (make them as small as possible)
|
12:50:49
|
<suranga_> bwolfe, cool, im sure that they really appreciate it. We're having specilist openMRS consulting for RHEA :-)
|
12:51:05
|
<suranga_> bwolfe, there were some unit tests, but nothing too awesome, im afraid :-)
|
12:52:56
|
*** goutham has joined #openmrs
|
12:53:51
|
<suranga_> bwolfe, I almost forgot. the solution you pointed out last friday was perfect. it solved aaaaaaalll problems...
|
12:53:54
|
*** rafa has quit IRC
|
12:54:00
|
<bwolfe> which solution?
|
12:55:29
|
<suranga_> bwolfe, remember, the one about how to set up HQL ?
|
12:55:53
|
<bwolfe> ah, about using the dao?
|
12:56:52
|
<suranga_> bwolfe, yeah. actually that was a silly question on my part. for some reason, my mind never went on to the logical solution :-)
|
12:57:13
|
<suranga_> bwolfe, I was like "oooh, I have to create a sessionfactory !!!! "
|
12:59:41
|
*** Jibesh has quit IRC
|
12:59:47
|
<suranga_> gotta sign out for a while.... see you guys soon :-)
|
13:00:15
|
*** suranga_ has quit IRC
|
13:04:21
|
*** pushkar has joined #openmrs
|
13:14:45
|
*** downey has joined #openmrs
|
13:14:45
|
*** ChanServ sets mode: +o downey
|
13:14:45
|
*** OpenMRSBot sets mode: +o downey
|
13:21:08
|
<pushkar> bwolfe, Hi
|
13:22:02
|
*** elliott_w has joined #openmrs
|
13:22:18
|
*** ChanServ sets mode: +o elliott_w
|
13:22:25
|
*** elliott_w has left #openmrs
|
13:25:45
|
*** magoo_ has quit IRC
|
13:25:54
|
<downey> wiki.openmrs.org will be unavailable for a few moments while it's restarted
|
13:26:31
|
<bwolfe> hey pushkar
|
13:27:39
|
<pushkar> bwolfe, do I need to add htmlformentry jar to access its service or can i do it directly ??
|
13:28:31
|
*** wyclif has joined #openmrs
|
13:29:49
|
<bwolfe> pushkar, in your code, you get the service from the context. Context.getService(HFES.class)
|
13:29:56
|
<bwolfe> (expand HFES of course)
|
13:30:07
|
<bwolfe> pushkar, your project will need 2 things:
|
13:30:31
|
<bwolfe> 1) to have the HFE jar in your classpath. eclipse will need this to be able to compile. see https://wiki.openmrs.org/display/docs/Requiring+another+module+in+your+module
|
13:30:32
|
<OpenMRSBot> <http://ln-s.net/9-5b> (at wiki.openmrs.org)
|
13:31:21
|
<bwolfe> 2) add the HFE to your list of 'required modules' in your config.xml (if you are requiring OpenMRS 1.8+ with your module you should use dkayiwa's 'soft requirement' in the config.xml)
|
13:31:32
|
<bwolfe> dkayiwa, when did you add that, do you remember which version?
|
13:31:59
|
<bwolfe> downey, thanks for the wiki warning. saved an angry complaint from me. :-)
|
13:32:17
|
<dkayiwa> bwolfe: when did i add what? :)
|
13:32:45
|
<dkayiwa> bwolfe: the 58 global properties? :)
|
13:36:24
|
<bwolfe> dkayiwa, see comment right before that
|
13:36:38
|
<pushkar> bwolfe, soft requirement = aware_of_modules ?
|
13:36:39
|
<bwolfe> the 'soft requirement' of another module in a module's config file
|
13:36:43
|
<bwolfe> yes, that
|
13:37:26
|
<dkayiwa> bwolfe: 1.9
|
13:37:30
|
<dkayiwa> bwolfe: TRUNK-1587
|
13:37:33
|
<dkayiwa> !ticket TRUNK-1587
|
13:37:34
|
<OpenMRSBot> dkayiwa: [#TRUNK-1587] Allow modules to be aware of other modules without requiring them - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-1587
|
13:38:09
|
<dkayiwa> bwolfe: you have such a wowwww memory!!! You know who added what :D
|
13:40:24
|
<pushkar> bwolfe, it says its for only for openmrs 1.9 +
|
13:41:07
|
* bwolfe remembers everything
|
13:41:14
|
<dkayiwa> bwolfe: pushkar but can be easy to back port to 1.8. Oh it is a new feature :(
|
13:41:28
|
<bwolfe> (although the definition of "everything" is getting smaller and smaller as I age :-D)
|
13:41:45
|
*** Mkop1 has joined #openmrs
|
13:41:45
|
*** ChanServ sets mode: +v Mkop1
|
13:41:45
|
<dkayiwa> bwolfe: hahaahhaha!!! :)
|
13:42:40
|
<bwolfe> downey, is 1.9 still misbehaving on the demo server?
|
13:42:49
|
<downey> bwolfe: still leaky, yes
|
13:44:20
|
<pushkar> oh thanks dkayiwa bwolfe
|
13:44:56
|
<downey> bwolfe: if you have any ideas, i could (temporarily) increase logging probably
|
13:45:01
|
<downey> or anything else. :)
|
13:46:15
|
<bwolfe> downey, leaking constantly? or only when undeployed?
|
13:46:32
|
<bwolfe> because james arbaugh opened this ticket already: https://tickets.openmrs.org/browse/TRUNK-3056
|
13:46:47
|
<downey> bwolfe: no, leaking during "normal" use
|
13:47:33
|
<downey> bwolfe: i.e., clean start up of tomcat, run for X hours, leak, crash
|
13:49:49
|
<bwolfe> hmm, ok
|
13:54:24
|
*** kreddy has joined #openmrs
|
13:54:25
|
*** 65MAAM0R2 has quit IRC
|
13:54:25
|
*** 31NABH9FT has quit IRC
|
13:54:37
|
<downey> hey kreddy, long time no see ;-)
|
13:57:59
|
*** jordank has joined #openmrs
|
13:59:47
|
*** cpower has joined #openmrs
|
13:59:48
|
*** Mkop1 is now known as Mkop
|
14:00:04
|
*** rafa has joined #openmrs
|
14:00:04
|
*** ChanServ sets mode: +v rafa
|
14:00:11
|
<cpower> And how's the channel today?
|
14:00:39
|
<kreddy> Hey downey, I know ;-)
|
14:00:59
|
*** venkaban has joined #openmrs
|
14:02:15
|
<cpower> I'll take the silence as a sign that it's Monday and we are all still catching up from the weekend!
|
14:02:19
|
<cpower> :-)
|
14:02:29
|
<rafa> cpower: hi
|
14:02:36
|
<cpower> Let's play our game...It's called Scrum
|
14:02:42
|
<cpower> !scrumon cpower
|
14:02:42
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
14:03:32
|
<cpower> Order: Rafa, bwolfe, wyclif, dkayiwa, venkaban
|
14:03:47
|
<rafa> Yesterday:
|
14:03:48
|
<rafa> * Helped Rajib with upgrading the MVP dict in the standalone
|
14:03:48
|
<rafa> Today:
|
14:03:48
|
<rafa> * Committed RESTWS-246: Resource documentation needs to describe "types" (i.e. subclass handlers)
|
14:03:48
|
<rafa> https://tickets.openmrs.org/browse/RESTWS-246, I'm confused with a missing controller for the DrugOrder subresource, isn't it required?
|
14:03:48
|
<rafa> * Started with RESTWS-260: Add getResourceVersion property
|
14:03:48
|
<rafa> https://tickets.openmrs.org/browse/RESTWS-260, see my doubt on the ticket
|
14:03:49
|
<rafa> No blockers.
|
14:04:39
|
<bwolfe> Friday
|
14:04:39
|
<bwolfe> email
|
14:04:39
|
<bwolfe> ticket triage
|
14:04:39
|
<bwolfe> restws-257
|
14:04:39
|
<bwolfe> created restws-261
|
14:04:40
|
<bwolfe> reviewed restws-260
|
14:04:42
|
<bwolfe> created trunk-3415 css file project
|
14:04:44
|
<bwolfe> Monday
|
14:04:46
|
<bwolfe> triage 1 ticket in ERR
|
14:04:48
|
<bwolfe> triage a bunch of trunk tickets (to make paul happy(ier))
|
14:04:52
|
<bwolfe> review sprint tickets, or rafa is taking over those?
|
14:04:54
|
<bwolfe> chat with kiran about everything under the sun
|
14:04:56
|
<bwolfe> no blockers
|
14:05:07
|
<bwolfe> rafa, anything come out of that assistance? better docs? reply back to impl list?
|
14:05:17
|
<wyclif> Friday:
|
14:05:18
|
<wyclif> * Finishing up Calculation tickets still in progress and updating the wiki where necessary and Cleaning up code
|
14:05:18
|
<wyclif> * Updated CalculationUtil to convert strings to Enum, Date, Class, Locale
|
14:05:18
|
<wyclif> * Weekly Skype call with Dmitry
|
14:05:18
|
<wyclif> * Released calc 0.9
|
14:05:19
|
<wyclif> Monday:
|
14:05:21
|
<wyclif> * FORM-121 - Modify code and admin pages to support form resources
|
14:05:25
|
<wyclif> * TRUNK-3320 - Calling parse method of DateFormat
|
14:05:25
|
<rafa> bwolfe: yeah improved the wiki page :)
|
14:05:27
|
<wyclif> * TRUNK-2867 - Fix WebSphere incompatibilities
|
14:05:29
|
<wyclif> Blockers: None
|
14:05:53
|
<bwolfe> rafa++
|
14:06:52
|
<djazayeri> I'll go
|
14:06:58
|
<djazayeri> Today
|
14:06:59
|
<djazayeri> * Assess HTML Form Entry tickets for next week’s sprint
|
14:06:59
|
<djazayeri> * Work on I-TECH project. (Time to go into heads-down mode.)
|
14:06:59
|
<djazayeri> * Maybe try incorporating Calculation module
|
14:07:06
|
<djazayeri> no blockers
|
14:07:38
|
<venkaban> Hi, Update from my side
|
14:07:58
|
<venkaban> Completed TRUNK - 3363
|
14:08:10
|
<venkaban> Working on TRUNK - 3308
|
14:08:14
|
<venkaban> No Blockers
|
14:08:28
|
<djazayeri> !ticket trunk-3363
|
14:08:29
|
<OpenMRSBot> djazayeri: [#TRUNK-3363] Synchronizing on Boolean - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-3363
|
14:08:33
|
<djazayeri> !ticket trunk-3308
|
14:08:35
|
<OpenMRSBot> djazayeri: [#TRUNK-3308] Add methods to OrderService for fetching patient Orders given an order class and other arguments - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-3308
|
14:08:40
|
<bwolfe> dkayiwa, you're up
|
14:10:19
|
<dkayiwa> Committed: Add methods to OrderService for fetching patient Orders - TRUNK-3311
|
14:10:19
|
<dkayiwa> Now working on: Add methods to OrderService for creating, retrieving and purging an Order - TRUNK-3314
|
14:10:19
|
<dkayiwa> No Blockers
|
14:10:44
|
<cpower> Any others?
|
14:11:03
|
<cpower> Summary: No Discussion points, No blockers
|
14:11:13
|
<bwolfe> venkaban, will you see Uma today?
|
14:11:14
|
<cpower> !scrumoff
|
14:11:14
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
14:11:17
|
<djazayeri> rafal acutally mentioned a couple of discussion points
|
14:11:26
|
<venkaban> bwolfe, Yes
|
14:11:27
|
<djazayeri> but he wasn't explicit about it.
|
14:11:50
|
<rafa> djazayeri: yes, sorry
|
14:11:53
|
*** lh has joined #openmrs
|
14:11:53
|
*** lh has joined #openmrs
|
14:12:00
|
<djazayeri> rafa mentioned doubts on RESTWS-246 and RESTWS-260
|
14:12:03
|
<cpower> djazayeri, yes rafal sorry your right there was some
|
14:12:07
|
<bwolfe> venkaban, great! have her jump on IRC asap. (assuming she isn't doing Merck stuff 100% of the time this week)
|
14:12:12
|
<djazayeri> !ticket RESTWS-246
|
14:12:13
|
<OpenMRSBot> djazayeri: [#RESTWS-246] Resource documentation needs to describe "types" (i.e. subclass handlers) - OpenMRS JIRA - https://tickets.openmrs.org/browse/RESTWS-246
|
14:12:25
|
<rafa> djazayeri: so why don't we have a controller for DrugOrder?
|
14:12:28
|
<djazayeri> !ticket RESTWS-260
|
14:12:29
|
<venkaban> bwolfe, Ok
|
14:12:29
|
<OpenMRSBot> djazayeri: [#RESTWS-260] Add getResourceVersion property - OpenMRS JIRA - https://tickets.openmrs.org/browse/RESTWS-260
|
14:13:48
|
<djazayeri> rafa: we only need a controller for DrugOrder if we want to support requests specific to DrugOrder
|
14:14:12
|
<djazayeri> rafa: e.g. just doing GET order/abc123 will be handled by OrderController, and delegated to the DrugOrderSubclassHandler
|
14:14:26
|
<rafa> djazayeri: ok, clear
|
14:14:47
|
<djazayeri> rafa: if we wanted to support (silly example) GET order?doseUnits=mg
|
14:14:52
|
<djazayeri> we'd need a DrugOrderController
|
14:15:10
|
<djazayeri> rafa: what's the doubt about RESTWS-260?
|
14:15:39
|
<rafa> djazayeri: my understanding is that we want to add resourceVersion to the http header right?
|
14:16:02
|
<rafa> djazayeri: to allow a client to request a specific version
|
14:16:34
|
<djazayeri> rafa: Yes, we do want to support something like that, but my understanding was that we would *NOT* do this in 1.0.
|
14:16:37
|
<bwolfe> rafa, I thought we were using an http parameter, not header.
|
14:16:40
|
<djazayeri> because it needs more design discussion
|
14:16:55
|
<djazayeri> and yeah, it's still an open question whether it's a header or regular param
|
14:17:11
|
<rafa> bwolfe: hmmmm
|
14:17:38
|
<rafa> djazayeri: so I actually shouldn't be working on that right now...
|
14:17:45
|
<djazayeri> rafa: when we do this I assume we're going to want to do something like allow (multiple versions of) resources to register themselves with the controller
|
14:18:01
|
<bwolfe> djazayeri, I was thinking we needed it in 1.0, but I suppose we could modify the restws1.9ext modules to obey it if the core restws module didn't
|
14:18:04
|
<djazayeri> rafa: I don't think so, but bwolfe set fixVersion=1.0
|
14:18:44
|
*** suranga has joined #openmrs
|
14:18:47
|
*** ChanServ sets mode: +v suranga
|
14:18:59
|
<djazayeri> bwolfe: I had been thinking that for now we just don't support multiple versions, and restws19ext just overrides the existing controllers if it wants to
|
14:19:04
|
<djazayeri> (which I assume it will want to)
|
14:20:37
|
*** goutham has quit IRC
|
14:20:59
|
<rafa> djazayeri: should I try if it is possible to override?
|
14:21:44
|
<djazayeri> rafa: yeah, sure. Though actually, there may be no need to override the controller, if you can just make the resource and @Handler with a higher priority (lower number, I think)
|
14:22:19
|
<bwolfe> yeah, its up to the modules at this point. so we can drop it from 1.0. if we were including the 1.9 stuff in the restws we'd need it asap. but since its a module, thats easily updatable. (although so is restws)
|
14:22:47
|
*** jkeiper has joined #openmrs
|
14:23:04
|
*** ChanServ sets mode: +v jkeiper
|
14:23:11
|
<jkeiper> dkayiwa, hi
|
14:23:12
|
<jkeiper> :-)
|
14:23:12
|
<rafa> djazayeri: ok
|
14:23:22
|
*** sgithens has joined #openmrs
|
14:24:09
|
<dkayiwa> jkeiper: hi :)
|
14:30:48
|
<bwolfe> who is bug fixing this week?
|
14:32:01
|
<djazayeri> who was it last week?
|
14:32:08
|
<djazayeri> and who was it the week before?
|
14:34:03
|
*** kreddy has quit IRC
|
14:38:18
|
<bwolfe> dkayiwa was last week. week before was...wyclif?
|
14:39:21
|
<wyclif> bwolfe, djazayeri, i'm in the swim lane again
|
14:39:56
|
<wyclif> probably it was supposed to be rafa
|
14:41:24
|
*** suranga has quit IRC
|
14:41:32
|
<bwolfe> wyclif, but rafa is sprint lead this week
|
14:41:35
|
<rafa> wyclif: I'm taking care of the sprint this week. I can do bug fixing next week
|
14:41:46
|
<jkeiper> dkayiwa, i am trying to use the XML library from xforms to add an element to a new doc from an old doc ...
|
14:41:49
|
<wyclif> rafa, ok
|
14:42:02
|
<jkeiper> i would like to get an element as an Element, but they come up as Nodes
|
14:42:11
|
<jkeiper> how do you find an element and get it as an Element?
|
14:42:14
|
<wyclif> it's fine, i'm doing bug fixing
|
14:42:45
|
<wyclif> jkeiper, XFORMS uses a different little xml library
|
14:43:08
|
*** harshadura has joined #openmrs
|
14:43:22
|
<wyclif> jkeiper, if you look at XformsBuilder
|
14:43:46
|
<wyclif> jkeiper, there is a couple of methods that you copy from code
|
14:44:27
|
<jkeiper> wyclif, ok
|
14:44:54
|
<dkayiwa> thanks wyclif
|
14:45:32
|
<bwolfe> dkayiwa, before releasing any version, you should make sure all tickets are closed: https://tickets.openmrs.org/secure/IssueNavigator.jspa?reset=true&mode=hide&pid=10000&fixfor=12563&resolution=-1
|
14:45:45
|
<dkayiwa> bwolfe: ok
|
14:45:52
|
<bwolfe> wyclif, ok, you're on bugfixing. are you using the bug fixing swim lane dashboard?
|
14:45:59
|
<bwolfe> (linked from here) https://wiki.openmrs.org/display/RES/Bug+Fixing+Swim+Lane
|
14:46:17
|
<wyclif> jkeiper, it think you call getElement
|
14:48:27
|
<wyclif> bwolfe, yeah but i had to filter it a bit because those xforms tickets at the top are in Needs Assessment state
|
14:49:27
|
<wyclif> jkeiper, sorry! xFormsBuilder -> XFormBuilder
|
14:51:24
|
<wyclif> dkayiwa, can you look at the tickets that Need Assessment on the swimlane dashboard
|
14:53:50
|
*** kreddy has joined #openmrs
|
14:55:07
|
<dkayiwa> wyclif: ok
|
15:02:24
|
<bwolfe> wyclif, so assess them! :-)
|
15:06:17
|
*** pascal` has quit IRC
|
15:06:59
|
<bwolfe> wyclif, also be sure to both apply patches and review commits. the big-fixer has multiple duties. :-)
|
15:08:35
|
<wyclif> ok
|
15:09:35
|
<wyclif> bwolfe, we said applying patches and commits can be done for tickets not on the dashboard too, right?
|
15:10:46
|
*** lh has quit IRC
|
15:11:44
|
<bwolfe> wyclif, right, you can do any. there isn't really a "priority" queue for those as there are for bug fix writing. but ideally you would apply/review patches/commits that are older first
|
15:20:42
|
*** kreddy has quit IRC
|
15:23:43
|
*** kreddy has joined #openmrs
|
15:25:58
|
<wyclif> dkayiwa, , apparently i dont have the privileges to change the status of xforms tickets
|
15:26:29
|
*** dkayiwa has quit IRC
|
15:40:53
|
*** lh has joined #openmrs
|
15:50:42
|
*** harshadura has quit IRC
|
15:55:04
|
*** jordank has left #openmrs
|
16:01:29
|
*** mvorobey has joined #openmrs
|
16:01:36
|
<mvorobey> hi all
|
16:03:13
|
<mvorobey> rafa, hi :)
|
16:05:09
|
*** jordank has joined #openmrs
|
16:10:47
|
*** applecool has joined #openmrs
|
16:10:47
|
*** ChanServ sets mode: +v applecool
|
16:12:16
|
*** isharapremadasa has joined #openmrs
|
16:16:41
|
*** isharapremadasa has quit IRC
|
16:24:31
|
<applecool> hey rafa :)
|
16:24:36
|
<applecool> there?
|
16:26:43
|
*** suranga has joined #openmrs
|
16:26:43
|
*** ChanServ sets mode: +v suranga
|
16:28:59
|
*** rafa has quit IRC
|
16:34:57
|
*** cpower has quit IRC
|
16:35:27
|
*** bwolfe has quit IRC
|
16:41:25
|
*** venkaban has quit IRC
|
16:43:19
|
*** jkeiper has quit IRC
|
16:43:36
|
*** jkeiper has joined #openmrs
|
16:46:28
|
<applecool> hi downey
|
16:47:57
|
*** elliott_w has joined #openmrs
|
16:47:57
|
*** ChanServ sets mode: +o elliott_w
|
16:48:26
|
<applecool> downey: i didnt get the every weeks 30 seconds student report! is it only for me or there is no report for this week?
|
16:48:30
|
*** bwolfe has joined #openmrs
|
16:48:47
|
*** ChanServ sets mode: +o bwolfe
|
16:52:28
|
<suranga> hmm,.. hi guys, have you ever faced a situation where your controller is supposed to intercept two or more request params, but for some reasons fails to identify which ever request param which omes last ?
|
16:53:28
|
<suranga> i keep getting a 'idType' is not recognized as an internal or external command " message each time I try ....
|
16:53:56
|
<bwolfe> suranga, pastebin the controller method
|
16:54:08
|
<suranga> bwolfe, :-) :-)
|
16:57:04
|
<downey> applecool: you don't get it, you give it :D
|
16:57:22
|
<suranga> bwolfe, http://pastebin.com/JTM8U5Cj :-)
|
16:57:37
|
<suranga> applecool, the link to the report is probably in your inbox ...
|
16:58:08
|
<bwolfe> suranga, whats on line 286?
|
16:58:13
|
*** pulasthi7 has joined #openmrs
|
16:58:19
|
<bwolfe> theres an NPE there
|
16:58:19
|
<applecool> okay :) downey suranga :)
|
16:59:45
|
<suranga> bwolfe, yep, thats right, but the problem is also that it does not identify the very last request param I enter via url...
|
17:00:01
|
<suranga> bwolfe, for example, rhe very very last like of the error trace says -
|
17:00:19
|
<suranga> idType' is not recognized as an internal or external command,
|
17:01:10
|
<bwolfe> suranga, what is the url?
|
17:01:59
|
<suranga> bwolfe, I give it curl -i -u admin:Password1 -H "Content-Type: text/plain" --data @test11.txt http://localhost:8080/ope
|
17:02:00
|
<suranga> nmrs/ws/rest/RHEA/patient/encounters?enterpriseId=1234&idType=ECID via curl...
|
17:03:23
|
<bwolfe> suranga, the error you are seeing is on your machine. the curl url is getting setn and then it thinks you are doing another command via the ampersand (&)
|
17:03:24
|
*** venkaban has joined #openmrs
|
17:04:00
|
<bwolfe> suranga, perhaps a backslash?
|
17:04:19
|
<suranga> bwolfe, ooops.. I did try using &
|
17:04:38
|
<bwolfe> but that still has an & in it :-)
|
17:05:07
|
* suranga ahaaaaaa. thats suspicious !
|
17:05:12
|
* suranga goes to look :-)
|
17:07:23
|
<suranga> bwolfe, but mm.. this same kind of url works perfectly fine on an ordinary GEt request
|
17:18:05
|
*** goutham has joined #openmrs
|
17:21:30
|
<suranga> bwolfe, bingo.
|
17:21:45
|
<bwolfe> suranga, what fixed it?
|
17:21:56
|
<suranga> bwolfe, it needed to be surrounded by double quotes. bwolfe how do you do it ? do you use a crystal ball ? :-)
|
17:22:15
|
<suranga> bwolfe, I surrounded by url with double quotes
|
17:22:33
|
<suranga> I see on wiki that this is caused exactly because of the reason you gave ;-)
|
17:22:41
|
<bwolfe> suranga, cool, good work. can you put that example on the wiki page that has curl examples?
|
17:23:01
|
<suranga> bwolfe, I'll o that now :-)
|
17:23:08
|
<bwolfe> suranga, I "do it" by having "done it" for many years. I just remember how the error messages look and hte general places to fix them
|
17:23:22
|
<bwolfe> I have a perverse love of debugging and figuring things out. :-)
|
17:23:47
|
<suranga> bwolfe, if you keep teaching me all you seccrets, i'd be pretty awesome one day :-)
|
17:23:54
|
<suranga> *your secrets
|
17:26:28
|
*** nadee has joined #openmrs
|
17:26:41
|
*** goutham has quit IRC
|
17:30:03
|
<nadee> hi devs,
|
17:30:11
|
<nadee> Wanna know if any module starts with the version 1.0-SNAPSHOT please?
|
17:30:32
|
*** ChanServ sets mode: +v Maurya_
|
17:30:41
|
<nadee> although it depends on 1.9.0 openmrs code currently
|
17:30:58
|
<djazayeri> nadee: you're free to start your module with whatever versioning scheme you want.
|
17:31:15
|
<djazayeri> nadee: e.g. you can be like google, and start with 0.1, and not call it 1.0 until it's been used for years
|
17:31:25
|
<nadee> :)
|
17:31:27
|
<djazayeri> nadee: I used to do that, but these days I just go 1.0, 1.1, etc.
|
17:31:39
|
<djazayeri> nadee: the point is that it's the version of *your module*, not the OpenMRS version.
|
17:31:58
|
<nadee> got it! thanks, needed to be precise
|
17:32:02
|
<nadee> thanks darius
|
17:32:25
|
*** Maurya_ is now known as maurya
|
17:55:07
|
*** dkayiwa has joined #openmrs
|
17:57:30
|
<wyclif> hi dkayiwa
|
17:57:36
|
<dkayiwa> hi wyclif
|
17:58:12
|
<wyclif> i think XFRM-79 needs some design
|
17:59:18
|
<dkayiwa> !ticket xfrm-79
|
17:59:19
|
<OpenMRSBot> dkayiwa: [#XFRM-79] Need to include obs_datetime on xform designer - OpenMRS JIRA - https://tickets.openmrs.org/browse/xfrm-79
|
17:59:54
|
<wyclif> dkayiwa, because it seems we need to include a date field and find a way of linking it to the obs
|
18:00:08
|
<dkayiwa> wyclif: i completely agree
|
18:00:29
|
<wyclif> dkayiwa, and what does that date element under obs in the xform xml mean?
|
18:01:07
|
<suranga> hi pulasthi7
|
18:01:12
|
<dkayiwa> wyclif: are you asking about the encounter date time?
|
18:01:37
|
*** mccallumg has joined #openmrs
|
18:01:37
|
*** ChanServ sets mode: +v mccallumg
|
18:02:05
|
<wyclif> dkayiwa, am looking at the snapshot on this page https://wiki.openmrs.org/display/docs/XForms+Module+Form+Designer
|
18:02:06
|
<OpenMRSBot> <http://ln-s.net/90$F> (at wiki.openmrs.org)
|
18:02:50
|
<wyclif> dkayiwa, and how do i set the id of a field from the designer?
|
18:03:07
|
<dkayiwa> wyclif: oh i see, you must be right
|
18:04:10
|
<dkayiwa> wyclif: do you mean how you bind it to that date element?
|
18:04:25
|
*** robbyoconnor has quit IRC
|
18:05:13
|
<wyclif> dkayiwa, my first question was what does that element mean?
|
18:05:25
|
<wyclif> dkayiwa, or represent
|
18:05:39
|
<dkayiwa> wyclif: the date when the obs was recorded
|
18:06:53
|
<wyclif> dj`that means it hasn't been set up to now
|
18:06:59
|
<wyclif> dkayiwa, that means it hasn't been set up to now
|
18:08:41
|
*** jkeiper has quit IRC
|
18:09:01
|
<dkayiwa> wyclif: correct
|
18:11:32
|
<wyclif> dkayiwa, another qn, how do i set the id of a field from the designer?
|
18:12:10
|
<dkayiwa> wyclif: using the widget properties pane
|
18:12:44
|
<dkayiwa> wyclif: select the widget on the design surface, and then you will see the ID property at the bottom of the list for widget properties
|
18:13:59
|
<wyclif> dkayiwa, see that thanks
|
18:15:07
|
<wyclif> dkayiwa, that means <xf:bind id="patient.birthdate" nodeset="/form/patient/patient.birthdate"
|
18:15:12
|
<wyclif> dkayiwa, means
|
18:15:27
|
<dkayiwa> wyclif: on that bind id is different
|
18:15:41
|
<dkayiwa> wyclif: on = oh
|
18:16:07
|
*** kavuri has joined #openmrs
|
18:16:20
|
<dkayiwa> wyclif: the xf:bind id is automatically set and there is not way for the user to set one for themselves
|
18:17:37
|
<kavuri> bwolfe, djazayeri: I checked in openmrs mysql database that the concept_id is not unique and is assigned to multiple concepts. Is this expected?
|
18:18:34
|
<djazayeri> kavuri: this is not expected. concept_id should be the pk of the concept table
|
18:18:43
|
<bwolfe> kavuri, I answered this after you were gone over the weekend. you are referring to the concept_name table, right?
|
18:18:49
|
<kavuri> bwolfe: yes
|
18:19:02
|
<kavuri> djazayeri: its in the concept_name table
|
18:19:05
|
<kavuri> I see duplicates
|
18:19:17
|
<djazayeri> kavuri: that's because a concept is expected to have multiple *names*
|
18:19:35
|
<djazayeri> kavuri: in the concept_name table, yes, concept_id is expected to have duplicates
|
18:20:01
|
*** goutham has joined #openmrs
|
18:20:12
|
<kavuri> djazayeri: how can I then uniquely identify a drug name?
|
18:20:36
|
<djazayeri> kavuri: perhaps through the Drug table, as drug.name ?
|
18:20:47
|
<djazayeri> kavuri: depends what you're trying to do.
|
18:21:19
|
<djazayeri> kavuri: with concepts you may assume that fully-specified and/or locale-preferred names are unique, but synonyms are not guaranteed to be unique
|
18:21:59
|
<kavuri> djazayeri: and I assume that over a period of time, there could be duplicate concepts created (human errors?)
|
18:22:51
|
<djazayeri> kavuri: starting in 1.7 we should be doing strong validation of concept names, so that fully-specified and/or locale-preferred name are unique (in a locale)
|
18:22:56
|
<goutham> dkayiwa: I am facing a error.. http://pastebin.com/vkhM6BJF
|
18:23:25
|
*** jkeiper has joined #openmrs
|
18:23:50
|
<kavuri> djazayeri: that sounds good. What I am trying to do is to create a concept list that I could link with patient 'Obs' object
|
18:24:03
|
*** applecool has quit IRC
|
18:24:08
|
<kavuri> djazayeri: I want to do this by linking the concept_id to an encounter
|
18:24:27
|
<dkayiwa> goutham: can you pastebin your config.xml?
|
18:25:19
|
<djazayeri> kavuri: I don't understand
|
18:25:35
|
<djazayeri> kavuri: you want to do something different than just make an Observation about a Patient in an Encounter?
|
18:26:37
|
<goutham> dkayiwa: http://pastebin.com/JSH6HrT3 =>config.xml
|
18:28:14
|
<pulasthi7> hi suranga,
|
18:28:20
|
<pulasthi7> hi james_regen
|
18:28:27
|
<kavuri> djazayeri: what I want to do is something like: say a patient complains about 'backache'. The doctor would create an observation that the probably causes of 'backache' are 'improper posture', 'spondilitis' or something else. The elements 'improper posture', 'spondilitis' are concepts that I want add as observations
|
18:28:42
|
<kavuri> *probable
|
18:29:25
|
<djazayeri> kavuri: okay, what does this have to do with unique drug names?
|
18:29:46
|
*** applecool has joined #openmrs
|
18:29:46
|
*** ChanServ sets mode: +v applecool
|
18:29:54
|
<kavuri> djazayeri: not necessarily drug names (I just took an example of drug names earlier), but any concept in general
|
18:30:13
|
<dkayiwa> goutham: and then your hibernate mapping file?
|
18:30:54
|
<kavuri> djazayeri: so if the concept_id is not unique, then there could be multiple unrelated concepts attached to an encounter
|
18:31:17
|
<goutham> dkayiwa: http://pastebin.com/vkhM6BJF scroll down a bit
|
18:31:20
|
<djazayeri> kavuri: obs are defined by obs.concept_id, FK to concept.concept_id
|
18:31:38
|
<dkayiwa> by the way goutham where did you copy this from? <mapping resource under mappingFiles
|
18:31:57
|
<djazayeri> kavuri: this is unique
|
18:32:11
|
<kavuri> djazayeri: how is concept.concept_id related to concept_name.concept_id ?
|
18:32:28
|
<djazayeri> kavuri: concept_name is many-to-one to concept, and its joined on concept_id
|
18:32:51
|
<djazayeri> kavuri: look at the data model image, the hbm.xml, the java class, etc
|
18:33:06
|
<djazayeri> kavuri: a concept *has* multiple names. concept_name fks back to concept via concept_id
|
18:33:19
|
<kavuri> djazayeri: right. What is the real-world usecase scenario for concept_name?
|
18:33:58
|
<djazayeri> kavuri: for example a concept could have the names: "CD4 COUNT, BY FACS", "CD4 COUNT", and "CD4"
|
18:34:15
|
<djazayeri> the first is the fully-specified name, the second is preferred, the third is "short"
|
18:34:42
|
<goutham> dkayiwa: previous openmrs module structure has ${omodHbmConfig} which automatically lists out all hbm files
|
18:35:50
|
<dkayiwa> goutham: does that expansion include? <mapping resource
|
18:35:52
|
<kavuri> djazayeri: ok..more like extra information, if the "short" form is not so useful?
|
18:36:45
|
<djazayeri> kavuri: we're just modeling the real world where people sometimes use synonyms to refer to the same idea.
|
18:36:59
|
<kavuri> djazayeri: got it
|
18:37:03
|
<goutham> dkayiwa: no..sorry i went on few online examples and kept it. Can you tell me correct tag for it
|
18:37:10
|
<djazayeri> kavuri: also, you might use the short name as a heading in a table, and you might have a doctor-friendly concept name and a patient-friendly one
|
18:37:46
|
<dkayiwa> goutham: i would start by copying how other modules include their mapping files :)
|
18:38:55
|
<wyclif> dkayiwa, am trying to add a field to capture an obs and i dont seem to get it right
|
18:39:59
|
<goutham> dkayiwa: i see only ${omodHbmConfig} in most of the config.xml (for example formentry) :(
|
18:41:09
|
<dkayiwa> goutham: try check the xforms module :)
|
18:41:47
|
<dkayiwa> wyclif: did you start by adding it to the openmrs form schema?
|
18:42:55
|
*** mvorobey has quit IRC
|
18:43:18
|
<wyclif> dkayiwa, no
|
18:44:00
|
<dkayiwa> wyclif: if you added it there first, would it fit in what you are trying to do?
|
18:48:59
|
<goutham> dkayiwa: Yupee that worked :)
|
18:49:28
|
<dkayiwa> goutham: next time, when you get blocked for an hour, ask immediately. :)
|
18:50:11
|
<goutham> dkayiwa: ok :)
|
18:50:25
|
<wyclif> dkayiwa, so i see this in the xml
|
18:50:26
|
<wyclif> <datexsi:nil="true"></date>
|
18:50:26
|
<wyclif> <timexsi:nil="true"></time>
|
18:50:26
|
<wyclif> <valuexsi:nil="true"></value>
|
18:50:48
|
<wyclif> why ic date and time split up, our date pickers dont that
|
18:51:08
|
<dkayiwa> wyclif: correct
|
18:51:14
|
<dkayiwa> wyclif: are you trying to work on xfrm-79?
|
18:51:36
|
<wyclif> dkayiwa, yeah
|
18:51:52
|
<wyclif> dkayiwa, looks like we can use that then
|
18:52:47
|
<dkayiwa> wyclif: if you tried adding a new question on the form, then bind it to the date field, does the form submission save the obs date properly?
|
18:53:24
|
<dkayiwa> wyclif: by adding a new question, i mean right in the form designer using the add new toolbar button or popup menu item
|
18:54:13
|
<dkayiwa> wyclif: the binding properly would be like for the parent question/field, but only ending with date instead of value
|
18:54:14
|
<wyclif> dkayiwa, i added a field but am trying to understand how things work so that i can bind the value to the date tag
|
18:54:39
|
<wyclif> ok
|
18:54:39
|
<dkayiwa> wyclif: oh i see
|
18:55:17
|
*** elliott_w has quit IRC
|
18:55:23
|
<goutham> dkayiwa: i want to your view about the ui , i created search for forms similar to the one under formentry tab of patient dash board
|
18:56:22
|
<dkayiwa> goutham: are you checking in the code. i could checkout and try it out
|
18:56:43
|
<dkayiwa> goutham: but if it is like the one under formentry, that is perfect. :)
|
18:56:55
|
*** elliott_w has joined #openmrs
|
18:56:55
|
*** ChanServ sets mode: +o elliott_w
|
18:57:14
|
<goutham> dkayiwa: give me 15min i will commit it
|
18:57:29
|
<dkayiwa> goutham: ok
|
19:06:47
|
<pushkar> bwolfe, I created the drawing tag
|
19:09:03
|
<pushkar> bwolfe, but the module is giving unable to start as daemon error when trying to upload the module with out uploading htmlformentry module
|
19:09:55
|
*** kavuri has quit IRC
|
19:11:59
|
*** jkeiper has quit IRC
|
19:13:00
|
<bwolfe> pushkar, did you put HFE in your module's config for requiredModules ?
|
19:14:21
|
<pushkar> yes,worknig if I upload HFE module
|
19:14:59
|
<pushkar> bwolfe, but its otherwise its not working
|
19:15:13
|
<pushkar> but otherwise its not working
|
19:16:07
|
<pushkar> bwolfe, I added this in my config file
|
19:16:10
|
<pushkar> <aware_of_modules>
|
19:16:10
|
<pushkar> <aware_of_module version="1.9.4">org.openmrs.module.htmlformentry</aware_of_module>
|
19:16:10
|
<pushkar> </aware_of_modules>
|
19:18:07
|
*** venkaban has quit IRC
|
19:18:35
|
<goutham> dkayiwa: i made the commit.. Have a look at it
|
19:18:44
|
<dkayiwa> goutham: ok
|
19:18:50
|
* goutham fingers crossed
|
19:18:51
|
<dkayiwa> goutham: url?
|
19:19:22
|
<bwolfe> pushkar, which version of openmrs are you using?
|
19:19:39
|
<pushkar> 1.9.0
|
19:19:47
|
<goutham> dkayiwa: http://svn.openmrs.org/openmrs-modules/formfilter/trunk/ , and i am working against openmrs 1.8.2
|
19:21:33
|
*** pulasthi7 has quit IRC
|
19:22:02
|
*** suranga has quit IRC
|
19:22:24
|
*** suranga has joined #openmrs
|
19:24:14
|
<dkayiwa> goutham: can you change to using liquibase instead of sqldiff?
|
19:24:52
|
*** sunbiz has joined #openmrs
|
19:24:52
|
*** ChanServ sets mode: +v sunbiz
|
19:27:41
|
<goutham> dkayiwa: Will change by next commit
|
19:28:01
|
*** maurya has quit IRC
|
19:28:06
|
<dkayiwa> goutham: ok just tell me when you are done with it such that i can test :)
|
19:28:09
|
<wyclif> dkayiwa, can you change the state of xforms tickets on the swimlane hashboard to reay for work, otherwise the claim button is not visible to me
|
19:28:57
|
<dkayiwa> wyclif: ok
|
19:28:59
|
<goutham> dkayiwa: you seen form search ?
|
19:29:31
|
<dkayiwa> goutham: i want to run it after you have committed the liquibase changeset
|
19:29:42
|
<dkayiwa> goutham: :)
|
19:30:05
|
<goutham> dkayiwa: Ok :)
|
19:33:53
|
*** pushkar has quit IRC
|
19:35:35
|
<djazayeri> Does anybody know if there's a best-practice way to determine if a given User is the daemon user?
|
19:36:36
|
<dkayiwa> djazayeri: WHERE system_id = 'daemon'
|
19:36:52
|
<dkayiwa> djazayeri: or even username
|
19:36:56
|
<djazayeri> dkayiwa: okay, but do you know if there's a way to check against a constant somewhere?
|
19:37:19
|
<djazayeri> dkayiwa: or is that 'daemon' hardcoded? (Daemon.DAEMON_USER_UUID is not public)
|
19:38:50
|
<dkayiwa> djazayeri: hard coded as of now
|
19:38:57
|
<djazayeri> dkayiwa: thx
|
19:39:05
|
<djazayeri> dkayiwa: created https://tickets.openmrs.org/browse/TRUNK-3424
|
19:40:08
|
<dkayiwa> djazayeri: sure
|
19:41:40
|
<sunbiz> Any idea how to solve this: http://pastebin.com/WQHaH3xX
|
19:41:52
|
<sunbiz> getting this in a test... JsonMappingException
|
19:45:26
|
*** nadee has quit IRC
|
19:46:12
|
<dkayiwa> sunbiz: is that related to? https://tickets.openmrs.org/browse/RESTWS-155
|
19:47:05
|
<djazayeri> sunbiz: I looked at that a while back
|
19:47:05
|
<sunbiz> bwolfe, djazayeri: I know I've seen this before... do u remember why its trying to directly convert the BaseOpenmrsObject??
|
19:47:23
|
<sunbiz> dkayiwa: that was because something didnt have a representation
|
19:47:30
|
<sunbiz> but here its on results
|
19:47:40
|
<sunbiz> which is supposed to part of a getAll or search
|
19:48:01
|
<djazayeri> sunbiz: I think you'll need to use the debugger to check why this is happening on results
|
19:48:43
|
<dkayiwa> http://www.mail-archive.com/dev@openmrs.org/msg00384.html
|
19:48:46
|
<OpenMRSBot> <http://ln-s.net/$H-d> (at www.mail-archive.com)
|
19:49:32
|
<djazayeri> dkayiwa: thanks for finding that.
|
19:49:50
|
<djazayeri> maybe we need a ticket so someone actually ever tests that solution
|
19:50:06
|
<dkayiwa> sure
|
19:50:44
|
*** james_regen has left #openmrs
|
19:59:05
|
*** venkaban has joined #openmrs
|
20:08:44
|
<dkayiwa> sunbiz: this seems to be in line with Darius's suggestion: http://stackoverflow.com/questions/6346018/deserializing-json-into-object-with-overloaded-methods-using-jackson
|
20:08:48
|
<OpenMRSBot> <http://ln-s.net/$H:8> (at stackoverflow.com)
|
20:09:57
|
<sunbiz> dkayiwa: sorry didnt understand??
|
20:10:13
|
<sunbiz> dkayiwa: do u mean using the debugger??
|
20:10:18
|
<dkayiwa> sunbiz: no
|
20:10:21
|
<sunbiz> :)
|
20:10:26
|
<sunbiz> then?
|
20:10:44
|
<dkayiwa> sunbiz: as per his response for: http://www.mail-archive.com/dev@openmrs.org/msg00384.html :)
|
20:10:45
|
<OpenMRSBot> <http://ln-s.net/$H-d> (at www.mail-archive.com)
|
20:11:26
|
<sunbiz> dkayiwa: ohhh... sadly it doesn't happen on other resources
|
20:11:38
|
<sunbiz> so... Im thinking I've defined my resources incorrectly
|
20:11:45
|
<dkayiwa> sunbiz: oh i see!!!
|
20:13:04
|
*** applecool has quit IRC
|
20:19:26
|
*** venkaban has quit IRC
|
20:22:04
|
*** venkaban has joined #openmrs
|
20:23:40
|
*** venkaban_ has joined #openmrs
|
20:24:07
|
*** venkaban has quit IRC
|
20:33:06
|
*** elliott_w has quit IRC
|
20:48:55
|
*** mgielow has joined #openmrs
|
21:01:29
|
*** suranga has quit IRC
|
21:02:49
|
*** bwolfe has quit IRC
|
21:05:11
|
*** joaquin has joined #openmrs
|
21:05:28
|
<joaquin> hi dkayiwa
|
21:05:35
|
*** kreddy has quit IRC
|
21:05:37
|
<dkayiwa> joaquin: hey
|
21:05:49
|
<joaquin> dkayiwa: how are you?
|
21:05:52
|
<dkayiwa> joaquin: just sent an email to the implementers list :0
|
21:06:01
|
<dkayiwa> joaquin: am doing fine and you?
|
21:06:29
|
*** mvorobey has joined #openmrs
|
21:06:34
|
<joaquin> dkayiwa: good, with a cold, but we just got a contract to implement OpenMRS in 15 health centers in Bolivia
|
21:06:38
|
<joaquin> so good
|
21:06:44
|
<joaquin> dkayiwa: :-)
|
21:06:52
|
<dkayiwa> joaquin: oh thats so so cool :D
|
21:06:53
|
<joaquin> dkayiwa: and yeah, I came online because of your email
|
21:07:03
|
<joaquin> dkayiwa: yeah, things are slowly moving here
|
21:07:25
|
<dkayiwa> joaquin: i sent another one with some steps. thinking you may not be IRC friendly :)
|
21:07:37
|
<joaquin> dkayiwa: :-D
|
21:07:44
|
<joaquin> dkayiwa: ok, let me check those
|
21:07:56
|
<joaquin> dkayiwa: one thing I found was that this wasn't the only form where this was happening
|
21:08:04
|
<dkayiwa> joaquin: ok just tell me how it turn out and then i can sleep :)
|
21:08:22
|
*** sgithens has quit IRC
|
21:08:32
|
<dkayiwa> joaquin: ok. if we fix it for one form, then we can for the others
|
21:08:38
|
<joaquin> dkayiwa: are you in Uganda?
|
21:08:41
|
<joaquin> dkayiwa: yes, agreed
|
21:08:44
|
<dkayiwa> joaquin: yes
|
21:09:09
|
<joaquin> dkayiwa: ok, give me a few minutes to do it and I will let you know
|
21:09:21
|
<dkayiwa> joaquin: no problem :)
|
21:15:12
|
<goutham> dkayiwa: Changed to liquibase
|
21:15:28
|
<joaquin> dkayiwa: ok, I set the language to es and nothing happened
|
21:15:40
|
<dkayiwa> goutham: and checked in?
|
21:15:50
|
<goutham> dkayiwa: yup
|
21:16:03
|
<joaquin> dkayiwa: then I set it to es_CL and if I select the es_CL locale for my user, the same thing happens
|
21:16:21
|
<joaquin> dkayiwa: however, if I select en_UK or en_US, then the correct choices are displayed
|
21:16:42
|
<dkayiwa> joaquin: so it corrects it for en_UK and en_US?
|
21:16:51
|
<joaquin> dkayiwa: yes
|
21:16:54
|
<dkayiwa> goutham: let me update
|
21:17:12
|
<dkayiwa> joaquin: what is in your allowed locales list global property?
|
21:17:35
|
<joaquin> dkayiwa: es, en
|
21:18:15
|
<dkayiwa> joaquin: can you pastebin the contents of your xforms xml tab?
|
21:18:26
|
<dkayiwa> joaquin: that is after saving
|
21:19:35
|
<joaquin> dkayiwa: so just to make sure, select the new es_CL language from the xform designer, save, then copy the xml, right?
|
21:19:55
|
<dkayiwa> joaquin: correct
|
21:20:59
|
<dkayiwa> goutham: can you now get rid of the sqldiff.xml file and commit again?
|
21:21:03
|
<joaquin> dkayiwa: http://pastebin.com/LW3JnKnx
|
21:21:42
|
<goutham> dkayiwa: ya 2min
|
21:23:13
|
<goutham> dkayiwa: done :)
|
21:23:34
|
<venkaban_> wyclif, Hi
|
21:23:48
|
<wyclif> hi venkaban_
|
21:25:51
|
<venkaban_> As per the ticket 3308 wyclif, the methods that are present in the old version and missing in the current version only needs to be added right?
|
21:26:26
|
<venkaban_> wyclif, I am asking this because there are some methods in current version that are nlot present in the old version
|
21:26:39
|
<wyclif> venkaban_, yes
|
21:26:49
|
<wyclif> venkaban_, is that order entry?
|
21:27:44
|
<venkaban_> wyclif, http://svn.openmrs.org/openmrs/branches/order-entry/api/src/main/java/org/openmrs/api/OrderService.java
|
21:28:03
|
<venkaban_> wyclif, this is the path of the file in old version.....correct me if I am wrong
|
21:28:07
|
<wyclif> venkaban_, if the method doesn't, then add it
|
21:28:15
|
<wyclif> doesn't exist
|
21:32:26
|
<dkayiwa> joaquin: by randomly checking on a few drop downs. do they all have undefined? or just some of them?
|
21:32:36
|
*** downey has quit IRC
|
21:33:46
|
*** joaquin has quit IRC
|
21:33:46
|
*** goutham has quit IRC
|
21:36:17
|
<venkaban_> wyclif, like if the method is not present in old file then add it to the old one?
|
21:36:24
|
*** mgielow has quit IRC
|
21:36:38
|
<wyclif> yes
|
21:37:12
|
*** joaquin2 has joined #openmrs
|
21:37:24
|
<joaquin2> dkayiwa: sorry, got bumped off for some reason
|
21:37:35
|
<joaquin2> dkayiwa: I was going to say that most of the questions have undefined
|
21:37:35
|
<dkayiwa> member:joaquin2: by randomly checking on a few drop downs. do they all have undefined? or just some of them?
|
21:37:36
|
*** goutham has joined #openmrs
|
21:37:51
|
<dkayiwa> joaquin2: ok
|
21:37:59
|
<joaquin2> dkayiwa: but some of them have the answers correctly on all of the options
|
21:38:14
|
<joaquin2> dkayiwa: and some have them correct for a few and then the others are undefined
|
21:38:19
|
<dkayiwa> joaquin2: ok
|
21:38:21
|
<venkaban_> wyclif, we are just trying to add to the new version right not for the older one?
|
21:38:34
|
<joaquin2> dkayiwa: this is if I pick the local es or es_CL, they all work if I pikc the locale en_US
|
21:38:55
|
<dkayiwa> joaquin2: ok
|
21:39:43
|
<dkayiwa> joaquin2: look at the xforms xml tab
|
21:40:01
|
<joaquin2> ok
|
21:40:06
|
<dkayiwa> joaquin2: and then delete this node which starts with: <translation lang="es_CL" lang-name="Espanol Chile">
|
21:40:16
|
<dkayiwa> joaquin2: up to its end which looks like:
|
21:40:28
|
<dkayiwa> </translation>
|
21:40:52
|
<wyclif> venkaban_, if a method exists already in trunk, check that there are tests and the method signature is the same, if it doesn't edit or if it is none existent, add the method
|
21:41:24
|
<dkayiwa> joaquin2: do the same for the node which starts with: <translation lang="es" lang-name="Espanol">
|
21:42:06
|
<goutham> Dkayiwa , shall we continue discussion tomorrow..I'm sleepy @_@
|
21:42:18
|
<dkayiwa> goutham: no problem :)
|
21:42:57
|
<goutham> Dkayiwa, good night :-)
|
21:43:07
|
<joaquin2> dkayiwa: ok, deleted both
|
21:43:10
|
<dkayiwa> goutham: have a good night too :)
|
21:43:43
|
*** goutham has quit IRC
|
21:43:54
|
<dkayiwa> joaquin2: now while still having the xforms xml tab selected, select Open from the File menu
|
21:45:02
|
*** lakkarau has joined #openmrs
|
21:45:19
|
<joaquin2> dkayiwa: done
|
21:45:39
|
*** jordank has left #openmrs
|
21:45:49
|
<dkayiwa> joaquin2: now select Save from the File menu
|
21:46:23
|
<joaquin2> dkayiwa: don
|
21:46:25
|
<joaquin2> e
|
21:47:00
|
<dkayiwa> joaquin2: how many languages do you now see in the top right hand most language drop down list?
|
21:47:25
|
*** wyclif has quit IRC
|
21:47:53
|
<joaquin2> dkayiwa: just english
|
21:48:01
|
<dkayiwa> joaquin2: ok
|
21:48:38
|
<dkayiwa> joaquin2: now using the tools -> languags menu, add one new language (the one that has key as: es)
|
21:49:05
|
*** jblaya has joined #openmrs
|
21:49:43
|
<joaquin2> dkayiwa: done
|
21:50:23
|
<dkayiwa> joaquin2: now select the new language from the top right hand most language drop down
|
21:50:37
|
<joaquin2> dkayiwa: done
|
21:51:19
|
<dkayiwa> joaquin2: now select save from the file menu
|
21:51:33
|
*** jblaya has quit IRC
|
21:51:51
|
*** lh has quit IRC
|
21:51:54
|
<joaquin2> dkayiwa: done
|
21:52:17
|
<dkayiwa> joaquin2: can you now pastebin for me the contents of the xforms xml tab?
|
21:53:33
|
<joaquin2> dkayiwa: http://pastebin.com/y7ptDce1
|
21:54:48
|
<dkayiwa> joaquin2: can you now try fill a form for a patient and tell me if you still see undefined?
|
21:55:40
|
<joaquin2> dkayiwa: it worked!
|
21:55:49
|
<dkayiwa> joaquin2: ok good
|
21:56:16
|
<joaquin2> dkayiwa: great, I'll put this on the email, so that it get's recorded for next time
|
21:56:16
|
<dkayiwa> joaquin2: so for the other also messed up forms, you will only be adding one language with key as: es
|
21:56:24
|
<dkayiwa> joaquin2: ok
|
21:56:49
|
*** robbyoconnor has joined #openmrs
|
21:56:49
|
*** ChanServ sets mode: +v robbyoconnor
|
21:57:05
|
<joaquin2> dkayiwa: so I should delete the existing es key, delete the translation in the xml tab, then readd the es key, right?
|
21:57:24
|
*** robbyoconnor has quit IRC
|
21:57:46
|
<dkayiwa> joaquin2: for the other forms, i guess you will not even have the es key in the xform. do you?
|
21:58:04
|
*** jblaya has joined #openmrs
|
21:58:17
|
<joaquin2> dkayiwa: yes, I probably will
|
21:58:58
|
<dkayiwa> joaquin2: if you find it, and it still displays undefined, then you need to remove it
|
21:59:08
|
<joaquin2> dkayiwa: ok, perfect
|
22:00:19
|
<joaquin2> dkayiwa: thanks daniel
|
22:00:31
|
<dkayiwa> joaquin2: yo welcome :)
|
22:00:37
|
*** sunbiz has quit IRC
|
22:01:03
|
*** sunbiz has joined #openmrs
|
22:01:03
|
*** ChanServ sets mode: +v sunbiz
|
22:02:05
|
*** elliott_w has joined #openmrs
|
22:02:06
|
*** ChanServ sets mode: +o elliott_w
|
22:03:52
|
*** elliott_w has quit IRC
|
22:05:17
|
*** joaquin2 has quit IRC
|
22:10:30
|
*** dkayiwa has quit IRC
|
22:10:36
|
*** lakkarau has quit IRC
|
22:11:30
|
*** mvorobey has quit IRC
|
22:15:53
|
*** lakkarau has joined #openmrs
|
22:22:24
|
*** sunbiz1 has joined #openmrs
|
22:23:12
|
*** lh has joined #openmrs
|
22:23:12
|
*** lh has joined #openmrs
|
22:27:17
|
*** jblaya has quit IRC
|
22:29:20
|
*** Echidna_ has joined #openmrs
|
22:29:20
|
*** Echidna has quit IRC
|
22:29:36
|
*** sunbiz has quit IRC
|
22:31:01
|
*** lakkarau has quit IRC
|
22:31:01
|
*** venkaban_ has quit IRC
|
22:34:23
|
*** lakkarau has joined #openmrs
|
22:34:23
|
*** venkaban has joined #openmrs
|
22:35:59
|
*** sunbiz1 has left #openmrs
|
22:36:02
|
*** sunbiz1 has joined #openmrs
|
22:36:15
|
*** sunbiz1 has left #openmrs
|
22:36:48
|
*** sunbiz has joined #openmrs
|
22:36:48
|
*** ChanServ sets mode: +v sunbiz
|
22:37:31
|
<sunbiz> djazayeri: still stuck
|
22:37:46
|
<djazayeri> sunbiz: the json response thing?
|
22:37:54
|
<sunbiz> yes
|
22:38:02
|
<sunbiz> if I add @JsonIgnore to the overridden getRetired
|
22:38:42
|
<sunbiz> then it gives error on something else
|
22:38:43
|
<djazayeri> sunbiz: if you add @JsonIgnore in a custom build of core, that doesn't fix things?
|
22:38:47
|
<djazayeri> hmm
|
22:39:12
|
<djazayeri> sunbiz: did you use the debugger and figure out why it's using one of the base resources in this case?
|
22:39:28
|
<sunbiz> it gives error on User.isRetired
|
22:39:38
|
<sunbiz> and this is from the creator property
|
22:39:40
|
<djazayeri> sunbiz: e.g. I'm assuming there's a reason you can't just use a @PropertyGetter?
|
22:39:50
|
<sunbiz> for retired??
|
22:40:00
|
<djazayeri> yeah
|
22:40:15
|
<sunbiz> hmmm... I can use it
|
22:40:24
|
<sunbiz> Im wondering though how the other resources are working
|
22:40:28
|
<sunbiz> and this resource doesnt
|
22:40:54
|
<djazayeri> sunbiz: Perhaps because User vs UserAndPassword are funky?
|
22:41:43
|
<sunbiz> djazayeri: hmm.. even then
|
22:41:58
|
<sunbiz> so the problem is only on shouldGetAll
|
22:42:24
|
<djazayeri> sunbiz: can it be replicated in a unit test?
|
22:42:43
|
<sunbiz> it works fine with shouldGetDefaultByUuid and shouldGetFullByUuid
|
22:43:11
|
<sunbiz> in those tests there is no error
|
22:46:21
|
<sunbiz> also djazayeri do u use JDK 7 ?? or only JDK6
|
22:46:36
|
<djazayeri> sunbiz: I use JDK6
|
22:46:43
|
<sunbiz> there is a compilation problem with JDK7 for the webservices.rest module
|
22:46:46
|
<djazayeri> sunbiz: is this failing in the unit test?
|
22:46:47
|
<sunbiz> or so I hear
|
22:46:49
|
<sunbiz> name clash: setProperty(UserAndPassword,String,Object) in UserResource overrides a method whose erasure is the same as another method, yet neither overrides the other
|
22:46:50
|
<sunbiz> first method: setProperty(Object,String,Object) in BaseDelegatingResource
|
22:46:50
|
<sunbiz> second method: setProperty(T,String,Object) in Converter
|
22:46:50
|
<sunbiz> where T is a type-variable:
|
22:46:50
|
<sunbiz> T extends Object declared in interface Converter
|
22:47:00
|
<sunbiz> oops... sorry... this error
|
22:47:46
|
<sunbiz> this is a different problem... that the module doesn't build because of this change
|
23:03:38
|
*** lakkarau has quit IRC
|
23:05:01
|
*** wyclif has joined #openmrs
|
23:25:07
|
<sunbiz> djazayeri: now I get this: org.codehaus.jackson.map.JsonMappingException: No serializer found for class org.hibernate.proxy.pojo.javassist.JavassistLazyInitializer and no properties discovered to create BeanSerializer (to avoid exception, disable SerializationConfig.Feature.FAIL_ON_EMPTY_BEANS) ) (through reference chain: org.openmrs.module.webservices.rest.SimpleObject["results"]->java.util.ArrayList[0]->org.raxa.module.raxacore.PatientList["creator"]->o
|
23:25:30
|
<djazayeri> sunbiz: is this happening in unit tests in the RESTWS module?
|
23:25:35
|
<djazayeri> or only with raxa stuff added?
|
23:25:41
|
<sunbiz> nope... only on raxa stuff
|
23:25:56
|
<sunbiz> I've created another object and implemented a Resource and in those
|
23:26:29
|
<sunbiz> Im getting the errors in serialization
|
23:28:07
|
<djazayeri> sunbiz: so, the problem is that we can't serialize to json anything that has hibernate proxies
|
23:28:15
|
<djazayeri> sunbiz: that's where the whole SimpleObject thing comes in
|
23:28:51
|
<djazayeri> sunbiz: is it possible that your resource is returning a "normal" openmrs object when it should be returning a SimpleObject?
|
23:29:13
|
<djazayeri> sunbiz: is the code somewhere that I can peek at it without taking too much time?
|
23:29:57
|
<sunbiz> https://github.com/Raxa/raxacore
|
23:30:14
|
<djazayeri> sunbiz: tell me where to look more specifically. :-)
|
23:30:31
|
<sunbiz> sorry...
|
23:30:43
|
<sunbiz> doGetAll returns NeedsPaging<PatientList>
|
23:30:55
|
<sunbiz> that should make it return SimpleObject... right??
|
23:31:33
|
<djazayeri> sunbiz: probably
|
23:31:46
|
<djazayeri> if PatientList actually has a Patient or something in it, that's probably bad
|
23:32:58
|
<sunbiz> why??
|
23:35:24
|
<sunbiz> djazayeri: https://github.com/sunbiz/raxacore/blob/master/omod/src/main/java/org/raxa/module/raxacore/web/v1_0/resource/PatientListResource.java
|
23:35:29
|
<sunbiz> this is probably more specific
|
23:35:37
|
<OpenMRSBot> <http://ln-s.net/$HDA> (at github.com)
|
23:42:38
|
*** lakkarau has joined #openmrs
|
23:52:46
|
*** venkaban has quit IRC
|
23:55:42
|
*** lakkarau has quit IRC
|
23:55:59
|
<sunbiz> djazayeri: help please... do u see anything missed out??
|
23:56:15
|
<djazayeri> sunbiz: sorry, got interrupted, let me peek at code
|
23:57:45
|
<sunbiz> the PatientList class is here: https://github.com/sunbiz/raxacore/blob/master/api/src/main/java/org/raxa/module/raxacore/PatientList.java
|
23:57:49
|
<OpenMRSBot> <http://ln-s.net/$HDd> (at github.com)
|
23:57:52
|
*** jordank has joined #openmrs
|