IRC Chat : 2012-06-08 - OpenMRS

00:16:27 *** mseaton has joined #openmrs
00:16:27 *** ChanServ sets mode: +v mseaton
00:16:45 *** mseaton has left #openmrs
00:46:33 *** kavuri has joined #openmrs
02:24:08 *** kavuri has quit IRC
03:02:28 *** bwolfe has quit IRC
03:18:06 *** r0bby has joined #openmrs
03:18:06 *** ChanServ sets mode: +v r0bby
03:21:24 *** robbyoconnor has quit IRC
03:32:39 *** r0bby is now known as robbyoconnor
03:50:07 *** jordank has joined #openmrs
03:58:46 *** djazayeri has joined #openmrs
03:58:51 *** ChanServ sets mode: +o djazayeri
04:03:36 *** ShellZero has joined #openmrs
04:04:48 *** ShellZero is now known as applecool
04:11:57 *** mgielow has joined #openmrs
04:30:42 *** lh has quit IRC
05:02:47 *** applecool has quit IRC
05:42:36 *** mgielow has quit IRC
05:52:48 *** magoo_ has joined #openmrs
05:57:18 *** goutham has joined #openmrs
05:58:46 *** djazayeri has quit IRC
06:02:35 *** djazayeri has joined #openmrs
06:02:35 *** ChanServ sets mode: +o djazayeri
06:12:24 *** jordank has joined #openmrs
06:28:19 *** ShellZero has joined #openmrs
06:29:32 *** ShellZero is now known as applecool
06:29:48 *** pulasthi7 has joined #openmrs
06:54:52 *** dkayiwa has joined #openmrs
07:20:29 *** djazayeri has quit IRC
07:22:20 *** pushkar has joined #openmrs
07:25:53 *** dkayiwa has quit IRC
07:26:46 *** dkayiwa has joined #openmrs
07:36:25 *** dkayiwa_ has joined #openmrs
07:37:25 *** dkayiwa has quit IRC
07:37:25 *** dkayiwa_ is now known as dkayiwa
07:47:11 <magoo_> hi everyone
07:47:59 <magoo_> yesterday i was building my project and i encountered the following errors url http://pastebin.com/EJeUEj9k can someone kindly help
07:53:54 *** applecoo_ has joined #openmrs
07:57:40 *** appleco__ has joined #openmrs
07:57:49 *** applecool has quit IRC
07:57:57 *** appleco__ is now known as applecool
08:01:06 *** applecoo_ has quit IRC
08:03:41 <magoo_> dkayiwa if i have an existing openmrs database on my test pc can i add the demo-1.9.0.sql into it
08:05:17 <dkayiwa> magoo_: yes just run the script against the database
08:05:36 *** bryq has joined #openmrs
08:05:37 *** ChanServ sets mode: +v bryq
08:10:40 <magoo_> dkayiwa okay
08:15:23 <magoo_> dkayiwa if i downlaod the settings.xml file should i add it into this directory \.m2\repository
08:15:35 <dkayiwa> magoo_: yes
08:17:43 *** rafa has joined #openmrs
08:17:43 *** ChanServ sets mode: +v rafa
08:19:36 *** magoo_ has quit IRC
08:33:05 *** harshadura has joined #openmrs
08:35:16 *** applecoo_ has joined #openmrs
08:35:25 *** applecool has quit IRC
08:35:31 *** applecoo_ is now known as applecool
08:35:46 <applecool> hi rafa good morning :)
08:35:54 <rafa> applecool: hi
08:38:44 *** applecoo_ has joined #openmrs
08:42:40 *** applecool has quit IRC
08:43:04 *** kdeeq has joined #openmrs
09:02:13 *** kdeeq has quit IRC
09:07:22 *** harshadura has quit IRC
09:10:50 *** bryq has quit IRC
09:15:21 *** suranga has joined #openmrs
09:15:21 *** ChanServ sets mode: +v suranga
09:15:58 *** applecoo_ is now known as applecool
09:22:28 <applecool> rafa: the file column is taking the TINYBLOB datatype and i want to set it to the LONGBLOB or MEDIUMBLOB how can i do that ? i googled and tried all the ways but its still taking the datatype as TINYBLOB
09:22:39 <applecool> http://pastebin.com/rQrT9i0d
09:22:53 <rafa> applecool: why are you doing that?
09:23:14 <rafa> applecool: we save a file to a disk not a db
09:23:26 <applecool> okay
09:23:31 <rafa> applecool: we marked file as @Transient
09:23:37 <applecool> yes we did
09:24:15 *** kdeeq has joined #openmrs
09:24:16 <applecool> ok got confused!
09:24:46 <rafa> applecool: which task are you doing?
09:25:01 <applecool> the same one ! 3rd
09:25:06 <applecool> didnt complete it yet
09:25:12 <applecool> i need to speed up
09:25:52 <rafa> applecool: ok
09:26:45 <applecool> in PackageManagerImpl i have overidden the save method which in turn is calling the saveFile()
09:27:23 <rafa> applecool: so what else is left?
09:28:39 <applecool> just i need to test it
09:28:42 <applecool> would be back soon
09:28:53 <rafa> applecool: good
09:37:41 *** applecool has quit IRC
09:38:12 *** applecool has joined #openmrs
09:39:05 *** magoo_ has joined #openmrs
09:40:29 <magoo_> i kindly need help about thsese error http://pastebin.com/Szq2eG1S i have done all the configurations
09:41:42 *** applecoo_ has joined #openmrs
09:45:34 *** applecool has quit IRC
09:52:43 *** suranga has quit IRC
09:56:14 *** finbrein has joined #openmrs
09:58:48 *** applecoo_ has quit IRC
09:59:50 *** dkayiwa has quit IRC
10:07:33 *** applecool has joined #openmrs
10:12:39 <applecool> rafa: eventhough the file is marked transient! when i am running the test i am getting an error data too long for column "file"
10:14:45 <rafa> applecool: is your annotation on a field or method?
10:14:53 <applecool> field
10:15:00 <rafa> applecool: can you try on a method?
10:15:07 <applecool> okay i will try it
10:15:20 <rafa> applecool: @Trasient may be special case
10:15:38 <rafa> applecool: and you may need to apply it same as id
10:16:33 <applecool> only setter should be marked as transient or getter too?
10:16:57 <rafa> applecool: setter should be enough
10:17:02 <applecool> okay
10:21:23 *** suranga has joined #openmrs
10:21:23 *** ChanServ sets mode: +v suranga
10:24:45 <applecool> rafa: its not working!
10:24:55 <applecool> i am getting the same error
10:25:02 <suranga> hi pulasthi7
10:25:06 <rafa> applecool: strange
10:25:10 <rafa> applecool: commit and push
10:25:12 <suranga> pulasthi7, are you here, by any chance ?
10:25:14 <rafa> applecool: I'll see
10:25:21 <applecool> okay! i will do it
10:25:24 <applecool> give me a minute
10:32:14 <applecool> rafa: did it
10:36:04 <rafa> applecool: put it on a getter and it works
10:36:41 *** applecoo_ has joined #openmrs
10:36:46 <rafa> applecoo_: it must be same as @Id
10:37:08 *** appleco__ has joined #openmrs
10:37:16 <appleco__> ok i will try! :)
10:39:47 *** applecool has quit IRC
10:40:45 *** applecoo_ has quit IRC
10:48:21 *** appleco__ has quit IRC
11:04:45 *** dkayiwa has joined #openmrs
11:17:14 *** kdeeq has quit IRC
11:17:32 *** suranga has quit IRC
11:17:41 *** suranga has joined #openmrs
11:22:47 *** james_regen has joined #openmrs
11:22:47 *** ChanServ sets mode: +v james_regen
11:24:22 *** dkayiwa has quit IRC
11:24:32 *** applecool has joined #openmrs
11:24:43 <applecool> rafa: it worked!
11:24:50 <applecool> i committed and pushed it!
11:24:52 <rafa> applecool: good
11:25:04 <rafa> applecool: moving to the next task?
11:25:18 <applecool> sorry i had a problem with my internet so was keep on getting disconnected!
11:25:20 <applecool> yes i am
11:25:31 <rafa> applecool: no problem
11:25:55 <applecool> so the task is i need to give a package.location = some source in the ApplicationResources.properties right?
11:26:43 <applecool> and then accessing it!
11:26:56 <rafa> applecool: I'd rather we use a different file
11:27:09 <rafa> applecool: this one is for translations
11:27:15 <applecool> okay!
11:27:39 <rafa> applecool: create application.properties
11:28:22 <rafa> applecool: and the property is packages.location
11:29:01 <rafa> applecool: see applicationContext-resources.xml how you can easily add new configuration file
11:29:15 <rafa> applecool: same like jdbc.properties or mail.properties
11:29:23 <applecool> okay :)
11:30:56 <rafa> applecool: you can inject that bean in your PackageManagerImpl and get whatever property you want
11:31:26 *** bryq has joined #openmrs
11:31:26 *** ChanServ sets mode: +v bryq
11:38:26 *** dkayiwa has joined #openmrs
11:42:39 *** dkayiwa has quit IRC
11:46:17 *** pulasthi7 has quit IRC
11:49:11 *** magoo_ has quit IRC
11:58:32 *** maurya has joined #openmrs
11:58:36 *** kdeeq has joined #openmrs
12:07:04 <applecool> rafa: i m having a problem with applicationContext-service.xml
12:07:43 <applecool> i am paste bin the bean can you please tell me whether its correct?
12:07:58 <rafa> applecool: ok
12:08:43 <applecool> http://pastebin.com/Kg6qGLus
12:08:49 <applecool> the last lines!
12:11:47 *** wyclif has quit IRC
12:13:49 <applecool> this is the line which i added in the application.properties! packages.location=src/main/webapp/resources
12:14:30 <rafa> applecool: I don't think you should add: <bean id="applicationProperties" class="org.springframework.beans.factory.config.PropertyPlaceholderConfigurer">
12:14:30 <rafa> <property name="location" value="classpath:application.properties"/>
12:14:30 <rafa> </bean>
12:14:40 <rafa> get rid of that
12:14:59 <rafa> modify applicationContext-resources.xml instead
12:14:59 <applecool> should i use propertyutils?
12:16:02 <rafa> applecool: and also you didn't specify the class correctly in packageManager bean
12:16:28 <applecool> yes i corrected it but still the same error
12:16:50 <rafa> applecool: and did you add setPackagesLocation(String packagesLocation) to the PackageManagerImpl?
12:17:13 <rafa> applecool: what is the error?
12:17:38 <applecool> application.properties cannot be opened!
12:18:42 <rafa> applecool: you need to put it in api/src/test/resources as well as in web/src/main/resources
12:19:00 <applecool> okay
12:19:04 <rafa> same as mail.properties...
12:19:11 <applecool> okay :)
12:19:37 *** kdeeq has quit IRC
12:39:54 *** downey has joined #openmrs
12:39:54 *** ChanServ sets mode: +o downey
12:39:54 *** OpenMRSBot sets mode: +o downey
12:41:21 <applecool> rafa i did it! but i am geting an error in the saveFile
12:45:31 <applecool> rafa i am leaving from school! will be back after reaching home! :)
12:45:50 *** applecool has quit IRC
12:46:37 *** dkayiwa has joined #openmrs
12:48:59 *** harshadura has joined #openmrs
12:54:01 *** wyclif has joined #openmrs
12:59:55 *** suranga has quit IRC
13:06:45 <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @TPAKTOP: http://t.co/BJNX8gQs @OpenMRS can be the thing that Australia needs to achieve the "smart" country goal. <http://twitter.com/OpenMRS/statuses/211076984581787648>
13:15:51 *** dkayiwa has quit IRC
13:17:34 *** dkayiwa has joined #openmrs
13:49:46 *** bwolfe has joined #openmrs
13:49:46 *** ChanServ sets mode: +o bwolfe
13:53:01 *** venkaban has joined #openmrs
13:59:06 *** cpower has joined #openmrs
13:59:13 <cpower> Good morning channel
13:59:46 <venkaban> cpower, Hi
14:00:19 <downey> Hi cpower and welcome to the #openmrs IRC channel.
14:01:31 <cpower> Are we ready to play our home game?
14:01:58 *** jordank has joined #openmrs
14:02:21 <bwolfe> home game?
14:02:29 *** bwolfe sets mode: +v venkaban
14:02:32 *** bwolfe sets mode: +v wyclif
14:03:06 <cpower> well yeah, we are all in front of our computers where we spend most of our time right...and home is where you spend most of your time.
14:03:18 <downey> home is where the keyboard is
14:03:38 <bwolfe> hmm
14:03:39 <cpower> See Downey gets it.
14:03:43 <bwolfe> ok, I might buy that
14:03:50 <venkaban> bwolfe, I need some more information on ticket TRUNK-3363
14:04:05 <cpower> Ok, let's get this thing going
14:04:06 <venkaban> bwolfe, are yo on vacation today?
14:04:12 <cpower> !scrumon cpower
14:04:12 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
14:04:25 <bwolfe> venkaban, no. lets discuss after scrum
14:04:39 <venkaban> Working on TRUNK-3363
14:04:52 <cpower> Order: Bwolfe, rafa, venkaban, wyclif, dkayiwa aaaand go
14:04:53 <venkaban> attended developer forum meetings
14:05:26 <rafa> venkaban: you need to wait for your turn :)
14:05:44 <bwolfe> venkaban, we go in a specific order just to keep it nice and clear
14:05:44 <venkaban> rafa, Yeah :)
14:05:57 <venkaban> Sorry Folks my bad :)
14:06:06 <cpower> no worries
14:06:15 <cpower> Wolfe...show them how it's done
14:06:21 <bwolfe> you can go after rafa. just give 1) what you worked on yesterday 2) what you are going to work on today 3) anything that is 'blocking' you right now that you have worked on for more than 1 or 2 hours.
14:07:14 <bwolfe> (also seen on https://wiki.openmrs.org/display/RES/Daily+Scrum+Meeting)
14:07:27 <bwolfe> hmm, well, my update is puny cpower. :-)
14:07:32 <bwolfe> Thursday
14:07:32 <bwolfe> went to court this morning for guardianship (again) for Eden
14:07:32 <bwolfe> dev call
14:07:32 <bwolfe> ldrship call
14:07:32 <bwolfe> (vacation day)
14:07:33 <bwolfe> Friday
14:07:35 <bwolfe> email
14:07:37 <bwolfe> ticket triage
14:07:39 <bwolfe> restws-257
14:07:41 <bwolfe> no blockers
14:08:20 <rafa> Today:
14:08:20 <rafa> * Reviewed sprint tickets.
14:08:20 <rafa> * Started to test ws to prepare for the release.
14:08:20 <rafa> * Worked on RESTWS-246: Resource documentation needs to describe "types" (i.e. subclass handlers)
14:08:20 <rafa> https://tickets.openmrs.org/browse/RESTWS-246 (I'm blind. I didn't get it right yet.)
14:08:21 <rafa> No blockers.
14:08:58 <venkaban> Thusday : Worked on TRUNK - 3363, Dev Call
14:09:19 <venkaban> Today : Work on TRUNK 3363
14:09:47 <venkaban> Blockers : Have few questions on the thread safe functionality imposed in service context
14:10:19 <wyclif> Thursday:
14:10:19 <wyclif> * Dev call
14:10:19 <wyclif> * various dev list and CALC ticket comment discusions
14:10:19 <wyclif> * Added a first pass implemetation of CALC-35 - Calculations should be performed at no more than 1000 patients at a time
14:10:19 <wyclif> * Added unit test for CALC-34 - Maintain state when evaluating calculations
14:10:21 <wyclif> Friday:
14:10:23 <wyclif> * Finishing uCalculation tickets still in progress
14:10:25 <wyclif> * Weekly Skype call with Dmitry
14:10:27 <wyclif> * Order entry tickets if not releasing Calc 1.0
14:10:29 <wyclif> Blockers: None
14:10:33 *** magoo_ has joined #openmrs
14:10:46 <dkayiwa> Closed: TRUNK-3249, STAND-42, STAND-47 & STAND-20
14:10:47 <dkayiwa> Reviewed and closed: Backport liquibase support in module to 1.6.x line - TRUNK-3163
14:10:47 <dkayiwa> Reviewed: OpenMRS 1.9 automatically assign UUIDs at object instantiation time, which breaks our serializers - SXS-5
14:10:47 <dkayiwa> Reviewed, back ported and closed: Schema created with invalid default datetimes - TRUNK-3329
14:10:48 <dkayiwa> Reviewed, back ported and closed: HibernateConceptDAO.getConcepts() will return Concepts that have voided names that match the passed name - TRUNK-3352
14:10:48 <dkayiwa> Back ported to 1.9.x: Person attributes do not display on patient search results - TRUNK-2442
14:10:48 <dkayiwa> Had Q & A session with the AMPATH forms team about the xforms module
14:10:48 <dkayiwa> Now reviewing: Manage Providers includes users that are retired - TRUNK-3334
14:10:49 <dkayiwa> No Blockers
14:11:31 <bwolfe> thats a nice update. no split between yesterday today though?
14:12:26 <rafa> bwolfe: should we repeat things from yesterday?
14:12:36 <rafa> bwolfe: I haven't done it for a long time...
14:12:54 *** snoppy has joined #openmrs
14:13:04 <bwolfe> hmm, well, I suppose its different for you guys since hte scrum is alway sat the end of the day
14:13:45 <rafa> bwolfe: yeah that's why I've stopped repeating myself...
14:13:56 <bwolfe> ok, carry on! :-)
14:14:01 <cpower> at this point I call it last 24hrs, next 24hrs and blockers
14:14:28 <cpower> wyclif.
14:14:34 <bwolfe> "since the previous scrum", "until the next scrum", and blockers. :-)
14:14:43 <cpower> sorry he already went
14:15:01 <wyclif> cpower, hi
14:15:14 <cpower> ok that's more wordy, but sure
14:15:30 <bwolfe> they're synonyms. use them interchangably
14:15:33 <cpower> Anything else for today's scrum, misss anyone?
14:15:51 <bwolfe> nooo, you didn't
14:16:30 <cpower> Summary: No discussion points 1 blocker: thread safe functionality
14:16:40 <bwolfe> blockers: venkaban on the synchronization. lets discuss how you can read up on that.
14:16:41 <cpower> !scrumoff
14:16:41 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
14:17:28 <bwolfe> !ticket trunk-3363
14:17:30 <OpenMRSBot> bwolfe: [#TRUNK-3363] Synchronizing on Boolean - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-3363
14:17:40 <bwolfe> venkaban, have you worked with synchronization before?
14:18:27 <venkaban> yeah
14:18:33 <venkaban> bwolfe, Hi Yeah
14:19:36 <venkaban> bwolfe, I have seen lot of synchronization concept implemented in serviceContext.java
14:20:10 <venkaban> bwolfe, In the summary for the ticket I dint understand what is the other object lock that is proposed
14:20:38 <bwolfe> venkaban, don't overthink the ticket too much. :-)
14:20:40 <venkaban> bwolfe, Can you please give me some eads up on what exactly is done to have this level of thread safe nature?
14:21:04 <bwolfe> I think it is simply to not use the Boolean object to synch on. Boolean is treated differnetly in java and more like a singleton.
14:21:11 <bwolfe> just create a new object and sync on that instead
14:22:07 <venkaban> bwolfe, ok
14:26:03 <rafa> venkaban: don't forget to make the lock final just in case ;)
14:27:03 <venkaban> rafa, ok
14:28:15 *** goutham has quit IRC
14:39:02 *** jordank has quit IRC
14:39:32 *** sgithens has joined #openmrs
14:41:50 *** burke has joined #openmrs
14:41:50 *** ChanServ sets mode: +o burke
14:42:16 <burke> bwolfe: do we have an agenda planning mtg today (now)?
14:42:47 <bwolfe> yes. I just sent you an email about it
14:57:48 *** snoppy has left #openmrs
15:02:29 *** rafa has quit IRC
15:05:51 *** magoo_ has quit IRC
15:06:50 *** dkayiwa has quit IRC
15:11:55 *** djazayeri has joined #openmrs
15:11:55 *** ChanServ sets mode: +o djazayeri
15:19:29 *** djazayeri has quit IRC
15:20:48 *** djazayeri has joined #openmrs
15:20:48 *** ChanServ sets mode: +o djazayeri
15:21:02 *** djazayeri has quit IRC
15:43:02 <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @gethappenic: OpenMRS Hack Night http://t.co/FNGk7Qx5 at Melbourne, #Melbourne <http://twitter.com/OpenMRS/statuses/211115129109102593>
15:44:34 <wyclif> hi rafa
15:44:56 <wyclif> hi ben
15:45:00 <wyclif> hi bwolfe
15:45:23 <bwolfe> hi wyclif
15:45:52 <wyclif> i just want to get your view on somehing
15:47:58 <wyclif> if i have a map which for sure over 98% of the operations are gets , is worth it to use a synchronized one vs regular hashmap
15:48:06 <wyclif> bwolfe, ?
15:48:18 <wyclif> hi burke
15:49:50 *** applecool has joined #openmrs
15:50:02 *** burke is now known as burke_away
15:50:20 <applecool> !seen rafa
15:50:20 <OpenMRSBot> applecool: rafa was last seen in #openmrs 1 hour, 24 minutes, and 16 seconds ago: <rafa> venkaban: don't forget to make the lock final just in case ;)
15:50:48 <bwolfe> that rafa, such a slacker
15:50:58 <bwolfe> wyclif, depends what you're doing with that map
15:51:05 <bwolfe> are you passing it around to multiple threads?
15:51:37 <applecool> bwolfe: ?
15:51:38 <wyclif> bwolfe, yeah but none of them iterates over it
15:51:51 <applecool> bwolfe: he is very good :)
15:52:20 <bwolfe> wyclif, I'm not following you
15:52:24 <wyclif> bwolfe, and the map is rarely ever updated
15:52:33 <bwolfe> even if 2% of the calls are modifying hte map, you should probalby synch it
15:52:43 <bwolfe> wyclif: rarely != never
15:52:54 <bwolfe> you should always plan for hte worst case scenario
15:53:17 <wyclif> bwolfe, ok
15:53:28 <wyclif> bwolfe, thanks
16:05:10 *** elliott_w has joined #openmrs
16:05:10 *** maurya has quit IRC
16:05:40 *** downey sets mode: +o elliott_w
16:05:40 *** ChanServ sets mode: -o elliott_w
16:05:42 *** maurya has joined #openmrs
16:09:41 *** ChanServ sets mode: +v applecool
16:10:16 *** ChanServ sets mode: +o elliott_w
16:20:48 *** suranga has joined #openmrs
16:20:48 *** ChanServ sets mode: +v suranga
16:24:55 *** maurya has quit IRC
16:25:29 *** maurya has joined #openmrs
16:26:41 *** pulasthi7 has joined #openmrs
16:29:15 <pulasthi7> hi suranga
16:29:31 <suranga> pulasthi7, howdy ! good evening
16:29:36 <suranga> pulasthi7, how are things ?
16:29:57 *** pushkar has joined #openmrs
16:30:37 *** jordank has joined #openmrs
16:30:43 *** applecool has quit IRC
16:31:22 *** maurya has quit IRC
16:31:31 <pulasthi7> suranga: i had some problems with the connection, after trying for a long time got connected.
16:31:53 <pulasthi7> i had also sent you a message,
16:32:01 <suranga> pulasthi7, ooops, I see. what are you using to connect to IRC ?
16:32:17 <suranga> pulasthi7, hmmm... afraid i did not receive any...
16:32:37 *** androidcooler has joined #openmrs
16:32:45 <downey> Hi androidcooler and welcome to the #openmrs IRC channel.
16:32:55 *** androidcooler is now known as applecool
16:32:56 *** ChanServ sets mode: +v applecool
16:33:03 <pulasthi7> suranga, that's with the internet connection, not IRC alone
16:33:13 <applecool> Hi downey :) sorry for the other nick :)
16:33:21 <downey> applecool: no problem :)
16:33:26 <applecool> :)
16:34:07 <suranga> pulasthi7, I see
16:34:34 <suranga> pulasthi7, how are things going ? I did not see your message, so afraid you will have to re-send :-)
16:36:11 <pulasthi7> suranga, no it was a sms mentioning that i'm having trouble with the connection and will be late a bit.
16:37:09 <pulasthi7> suranga, in OpenMRSFormPairsClass how is the sessionfactory initialized?
16:37:10 <suranga> pulasthi7, um.. he he...so I just checked my phone, and saw your message... sorry about that...
16:37:35 <pulasthi7> is it with the superclass?
16:37:46 <suranga> pulasthi7, hmm... lets see...
16:39:38 <pushkar> bwolfe, Hi
16:39:54 <suranga> pulasthi7, cant be the super class, I think... hmmm...
16:40:55 <pulasthi7> suranga, ah yes, it's a private field
16:41:08 *** jordank has quit IRC
16:44:08 <suranga> pulasthi7, i was looking at OpenMRSReader class for a solution
16:44:57 <suranga> pulasthi7, OpenMRSFormPairs rather a suprise to me to.... maybe we need to create the sessionfactory programatically as done in the OpenMRSReader ?
16:46:45 <suranga> pulasthi7, we could also try clarifying from the master too...
16:46:58 <suranga> hi james_regen ... sorry., any chance for a quick question ?
16:47:24 <james_regen> suranga: hi, sure i can try to answer a question
16:47:43 *** jordank has joined #openmrs
16:48:39 <suranga> james_regen, thanks, very cool. We were looking at OpenMRSFormPairs.java. this have a SesionFactory, and we're calling getCurrentSession() on it, but we cant find anywhere its actually being instantiated...
16:49:09 <suranga> james_regen, theres just private SessionFactory sessionFactory; , and thats alll, its not getting set in the parent class either...
16:49:34 <suranga> james_regen, I was wondering if we need to create that programatically, as done in OpenMRSReader ?
16:51:57 <james_regen> suranga: that's a good question . . . .
16:53:57 *** pulasthi7 has quit IRC
16:55:01 *** kreddy has joined #openmrs
16:55:06 <james_regen> suranga: there's some hibernate code in OpenMRSReader that might help, though it's private. i'm not sure how i tested the code, since it seems like it should have worked
16:55:23 *** pulasthi7 has joined #openmrs
16:56:03 *** venkaban has quit IRC
16:56:10 <bwolfe> hi pushkar
16:56:35 <pulasthi7> suranga, didn't notice that i had got disconnected.
16:57:17 <pulasthi7> suranga, were you able find that?
16:57:54 <suranga> pulasthi7, hi.. whats the very last message you saw from me ?
16:58:16 *** jordank has quit IRC
16:58:46 <pulasthi7> <suranga> pulasthi7, we could also try clarifying from the master too...
16:59:06 <suranga> pulasthi7, i will pm the rest...
16:59:18 <pulasthi7> suranga, thanks,
17:00:38 <suranga> james_regen, I see..
17:01:06 <suranga> james_regen, I also noticed that MatchingReportUtils.java has a good sample on how to do this---
17:01:56 <james_regen> suranga: oh, so you can look at that to get an example of how to setup your objects?
17:02:28 <suranga> james_regen,
17:02:30 <suranga> HibernateSessionFactoryBean bean = new HibernateSessionFactoryBean();
17:02:30 <suranga> Configuration cfg = bean.newConfiguration();
17:02:30 <suranga> Properties c = cfg.getProperties();
17:02:31 <suranga> String url = c.getProperty("hibernate.connection.url");
17:02:33 <suranga> String user = c.getProperty("hibernate.connection.username");
17:02:35 <suranga> String passwd = c.getProperty("hibernate.connection.password");
17:02:37 <suranga> String driver = c.getProperty("hibernate.connection.driver_class");
17:02:39 <suranga> log.info("URL: " + url);
17:02:41 <suranga> Connection databaseConnection = null;
17:02:43 <suranga> try {
17:02:45 <suranga> Class.forName(driver);
17:02:47 <suranga> ConnectionFactory connectionFactory = new DriverManagerConnectionFactory(
17:02:49 <suranga> url, user, passwd);
17:02:51 <suranga> databaseConnection = connectionFactory.createConnection();
17:02:53 <suranga> } catch (ClassNotFoundException e) {
17:02:55 <suranga> log.warn("patientmatching: error loading database driver to use when matching");
17:02:57 <suranga> } catch (SQLException e) {
17:03:01 <suranga> log.warn("patientmatching: error connectiong to database to do matching - \n" + e.getMessage());
17:03:03 <suranga> }
17:03:05 <suranga>
17:06:06 <james_regen> suranga: ok. seems like we can use that if there's no core API way of getting a hibernate session
17:07:13 <suranga> james_regen, I guess we can use this for now, and them look around for a better solution ...
17:07:35 <suranga> james_regen, pulasthi7 as someone said "Make It Work, Make It Right, Make It Fast" :-)
17:08:16 <suranga> pulasthi7, you can find this on line 456 down on the matchingreportutils.java class
17:09:59 <pulasthi7> suranga, ok i got it
17:10:07 <pushkar> bwolfe, I am struck with htmlrmflowsheet.I cant figure out why its unable to find the taghandler class . Do you have time to look at it ?
17:10:10 *** burke_away has quit IRC
17:10:38 <pushkar> *htmlformflowsheet
17:12:05 <suranga> pulasthi7, cool, let us know how it goes...
17:12:13 <suranga> james_regen, thanks for helping out ! :-)
17:12:39 <james_regen> okay, i hope it's easy to get working
17:13:52 *** pushkar_ has joined #openmrs
17:13:57 <pulasthi7> james_regen, suranga thanks both of you :)
17:14:12 *** harshadura has quit IRC
17:15:39 <bwolfe> pushkar_, sure, I can try
17:17:20 *** pushkar has quit IRC
17:18:28 <pushkar_> thanks bwolfe :-)
17:22:13 *** venkaban has joined #openmrs
17:24:58 <bwolfe> pushkar_, which page are you on when you see that error?
17:27:09 *** applecool has quit IRC
17:27:12 <pushkar_> bwolfe, I am going through rolebasedhomepage module its trying to access htmlformflowsheetFindPatient.jsp
17:27:59 <pushkar_> and that page is throwing the error
17:29:30 <bwolfe> hmm
17:29:36 <bwolfe> I don't know if something strnage is going on there
17:29:45 <bwolfe> but you don't need to do that to test
17:30:07 <bwolfe> I created 2 html forms. used the custom tag on the second to import the first
17:30:12 <bwolfe> that is all you need to see
17:30:48 <bwolfe> but really, you don't even need to see it! Just find that part of the code in htmlformflowsheet that creates a custom tag and copy/paste/modify it in your module for the picture uploader/editor
17:30:58 *** elliott_w has quit IRC
17:31:06 *** herooftime has joined #openmrs
17:31:06 *** ChanServ sets mode: +o herooftime
17:31:20 <downey> Hi herooftime and welcome to the #openmrs IRC channel.
17:31:23 *** djazayeri has joined #openmrs
17:31:23 *** ChanServ sets mode: +o djazayeri
17:31:35 *** herooftime has quit IRC
17:32:00 *** elliott_w has joined #openmrs
17:32:06 *** ChanServ sets mode: +o elliott_w
17:38:13 <pushkar_> okay bwolfe ,I just wanted to try it out so as to understand which part of code doing what
17:39:04 <bwolfe> but thats the part of the module that doesn't relate to you :-)
17:39:56 <pushkar_> but here I should include my portlet and the css and javascript right?
17:40:36 <pushkar_> so I was checking the inclusion of portlet part which is shown in the documentation
17:41:09 <bwolfe> thats totally separate though
17:41:20 <bwolfe> thats for the other use-case of HFFS module
17:41:57 <bwolfe> use-case 1) is adding new tag to HtmlFormEntry module so you can have multiple HFE forms and one HFE form calls another
17:42:17 <bwolfe> use-case 2) is allowing for a custom jsp page that groups together HFE forms.
17:42:28 <bwolfe> you only care about #1. but you are trying to look at #2. :-)
17:42:43 *** jordank has joined #openmrs
17:43:16 <pushkar_> now I am totally confused!
17:43:42 <bwolfe> pushkar_, you need to add a new tag that an admin can add into their html forms
17:44:23 <bwolfe> pushkar_, have you looked at the "custom tag for htmlformentry" section on HFFS module homepage? https://wiki.openmrs.org/display/docs/HtmlFormFlowsheet+Module
17:45:29 <bwolfe> eclipse--
17:45:36 <suranga> pulasthi7, how did it go ? any luck ?
17:46:43 *** cpower has quit IRC
17:46:44 <pulasthi7> suranga, going on, i'll let you know once i'm done.
17:47:02 <suranga> pulasthi7, cool !
17:47:06 *** djazayeri has quit IRC
17:47:54 <pushkar_> bwolfe, yes it allows the user to embed html forms inside of html forms
17:54:37 *** pushkar_ is now known as pushkar
17:55:21 *** kavuri has joined #openmrs
18:02:37 *** jordank has quit IRC
18:04:55 <bwolfe> pushkar, thats what you want to emulate. or at least just the tag. find the code that A) is behind the rendering of that "<htmlformflowsheet formId="39"/>" tag. B) find where/if/how it registers that tag to htmlformentry
18:05:17 <bwolfe> you can probably figure that out on your own without needing the htmlformflowsheet module example... :-)
18:11:01 <pushkar> bwolfe, what should the tag exactly do ?
18:11:43 *** mvorobey has joined #openmrs
18:11:51 <mvorobey> hi all
18:12:05 <pushkar> tag= the tag I supposed to do
18:23:49 <venkaban> bwolfe, Hi
18:24:26 <venkaban> bwolfe, We will not make any changes to the synchronization currently implemented in the system right?
18:24:55 <venkaban> bwolfe, just create another object and then replace the boolean object with this current one right?
18:26:42 <bwolfe> yeah
18:27:29 <bwolfe> venkaban, again, don't overthink these tickets. I only assigned these as super small tickets so you could get used to checking out, making patches, and running unit tests
18:27:43 <bwolfe> they aren't meant to be something that takes multiple days! :-)
18:28:30 *** jordank has joined #openmrs
18:28:32 <bwolfe> venkaban, I assigned you a ticket in this sprint to do when you are done with this one. let me know when you're ready for htat and I'll give you some bg on that topic. (multiple sprints on it, some old code that was never used, etc)
18:29:05 <venkaban> bwolfe, ok
18:29:11 <venkaban> bwolfe, will let you know
18:29:44 *** downey has quit IRC
18:35:41 *** james_regen has left #openmrs
18:37:17 <bwolfe> if I could punch a piece of software in the face, eclipse would have several black eyes today
18:44:05 *** kavuri has quit IRC
18:44:46 <pushkar> bwolfe, what happened? :-)
18:46:14 <bwolfe> it crashed on me earlier
18:46:20 <bwolfe> and now its hanging while rebuilding everything
18:53:08 <pushkar> it happens ofter to me when i try to find files using open type
18:53:17 <pushkar> *often
18:54:29 <pushkar> bwolfe, I have to create a tag which should show the editor after it is rendered. how does this and putting html form inside another form relate ??
18:54:49 *** p_m has joined #openmrs
18:54:54 <bwolfe> pushkar, the htmlformflowsheet module also adds in a custom tag.
18:55:08 <bwolfe> and you are adding a custom tag
18:55:26 <bwolfe> the ability to include another html form IS the tag. thats how it relates
18:56:49 <pushkar> oh okay bwolfe thanks :-)
18:57:00 *** pm__ has joined #openmrs
18:57:16 *** p_m has quit IRC
19:02:47 *** pm__ has quit IRC
19:06:22 *** pm__ has joined #openmrs
19:10:38 <venkaban> bwolfe, I have finished the changes to TRUNK-3363 and heading out to lunch now.
19:11:01 <venkaban> bwolfe, Can we have the discussion after the lunch
19:11:58 <bwolfe> in an hour? yes. I leave in under 2 hours to drive home, so will have to be by phone if you get back from lunch late. :-)
19:14:43 <venkaban> bwolfe, I will be back before one hour from now :)
19:17:02 *** jordank has quit IRC
19:20:07 *** pushkar has quit IRC
19:21:02 *** every0ne has joined #openmrs
19:24:12 *** jordank has joined #openmrs
19:37:11 *** jordank has quit IRC
19:40:58 *** jordank has joined #openmrs
19:43:03 <suranga> mm.. hi bwolfe ... bwolfe a small query... we're connecting to a database via a JDBC driver. Does this affect the ability to make hql queries using this connection ?
19:43:41 <bwolfe> hibernate connects via a jdbc driver under the hood. is that what you're asking?
19:44:49 <suranga> bwolfe, we're using -
19:44:51 <suranga> HibernateSessionFactoryBean bean = new HibernateSessionFactoryBean();
19:44:51 <suranga> <suranga> Configuration cfg = bean.newConfiguration();
19:44:51 <suranga> <suranga> Properties c = cfg.getProperties();
19:44:51 <suranga> <suranga> String url = c.getProperty("hibernate.connection.url");
19:44:51 <suranga> <suranga> String user = c.getProperty("hibernate.connection.username");
19:44:52 <suranga> <suranga> String passwd = c.getProperty("hibernate.connection.password");
19:44:54 <suranga> <suranga> String driver = c.getProperty("hibernate.connection.driver_class");
19:44:56 <suranga> <suranga> log.info("URL: " + url);
19:45:00 <suranga> <suranga> Connection databaseConnection = null;
19:45:02 <suranga> <suranga> try {
19:45:04 <suranga> <suranga> Class.forName(driver);
19:45:06 <suranga> <suranga> ConnectionFactory connectionFactory = new DriverManagerConnectionFactory(
19:45:08 <suranga> <suranga> url, user, passwd);
19:45:10 <suranga> <suranga> databaseConnection = connectionFactory.createConnection();
19:45:12 <suranga> <suranga> } catch (ClassNotFoundException e) {
19:45:14 <suranga> <suranga> log.warn("patientmatching: error loading database driver to use when matching");
19:45:16 <suranga> <suranga> } catch (SQLException e) {
19:45:18 <suranga> <suranga> log.warn("patientmatching: error connectiong to database to do matching - \n" + e.getMessage());
19:45:21 <suranga> <suranga> }
19:46:33 <suranga> bwolfe, we;re connecting to the db via JDBC driver... will this affect our ability to make HQL calls ? I should have researched this more (i know) ut want to ask you now before you log off for the weekend :-(
19:50:38 <pulasthi7> bwolfe, suranga , with the connectionFactory created from HibernateSessionFactory 's configuration properties.
19:57:16 *** goutham has joined #openmrs
20:02:40 *** mvorobey has quit IRC
20:03:55 *** elliott_w has quit IRC
20:06:34 <venkaban> bwolfe, Hi I am ready now
20:07:48 *** pulasthi7 has quit IRC
20:13:46 <venkaban> bwolfe, you there?
20:15:38 *** elliott_w has joined #openmrs
20:15:38 *** ChanServ sets mode: +o elliott_w
20:17:40 *** elliott_w has quit IRC
20:20:08 *** sgithens has quit IRC
20:20:24 <bwolfe> venkaban, I am here, yes
20:20:55 <bwolfe> venkaban, so I assigned you a ticket in the current sprint. https://tickets.openmrs.org/browse/TRUNK-3308
20:21:14 <venkaban> bwolfe, Hi I am looking at it now. Couldnt find description for it
20:21:41 *** pm__ has quit IRC
20:22:48 <bwolfe> venkaban, so history of "order entry" in openmrs:
20:26:29 <venkaban> bwolfe, are you pasting the content for "order entry" description?
20:27:20 <bwolfe> yeah, one sec
20:27:39 <bwolfe> 1) orders were always present from the beginning, but we didn't like it. that was in the orders* tables, OrderService, etc
20:31:26 <bwolfe> 2) Daniel Kayiwa was tasked with rewriting the API behind orders. see https://wiki.openmrs.org/display/projects/API+Support+for+Order+Entry+%28Design+Page%29
20:31:49 <bwolfe> daniel's work was all before we started the agile sprinting model (more than 14 months ago)
20:32:09 <bwolfe> the work was never merged with trunk. you can see it here: http://svn.openmrs.org/openmrs/branches/order-entry/
20:32:27 <bwolfe> you can check out that code to your work space to see/get/copy the code he has written.
20:32:52 <bwolfe> 3) we decided that the project was waaaay too large and started afresh on doing an orders rewrite except with less features
20:33:19 <bwolfe> The new rewrite has been done in several sprints already. so trunk has some changes in it for orders
20:33:47 <bwolfe> your ticket in this case is adding a few methods ot the OrderService.java class
20:33:49 <venkaban> bwolfe, Ok
20:34:15 <bwolfe> the work for that might have been done in daniel's branch already. find that code he wrote and see. (thats what wyclif was referring to in the ticket)
20:34:57 <bwolfe> venkaban, oh wait. Daniel's initial wiki page (from the 2011 attempt) is here: https://wiki.openmrs.org/display/projects/2011+Initial+attempt+at+API+Support+for+Order+Entry. the new one is hte one I linked to above (with less features)
20:36:37 <venkaban> bwolfe, So the old trunk code needs to be checked and should be replicated in the current trunk and check whether all unit test pass or not? correct me if iam wrong
20:39:06 <bwolfe> if by "old trunk code" you mean the code in 'branches/order-entry', then yes. look for that method in the order-entry branch. if its there, copy it and any methods related.
20:39:18 <bwolfe> wyclif, can you add anything more to that ticket for venkaban?
20:39:19 <bwolfe> https://tickets.openmrs.org/browse/TRUNK-3308
20:42:05 *** bryq has quit IRC
20:42:40 <wyclif> bwolfe, what ticket number?
20:42:48 <wyclif> bwolfe, seen it
20:43:31 <wyclif> venkaban, what don't you understand and i explain?
20:44:56 <venkaban> Wyclif, Currently as per bwolfe said, the current OrderService.java class needs to have few methods to be added as per the work done by dkayiwa in the past
20:45:13 <wyclif> venkaban, correct
20:45:35 <venkaban> wyclif, after adding the methods I have to ensure that the current Junits do not fail as per this change?
20:45:55 <wyclif> venkaban, that is one thing you have to ensure
20:46:27 <venkaban> wyclif, cool
20:46:45 <wyclif> venkaban, and also ensure there is a test for every scenario
20:47:01 <wyclif> venkaban, let me comment on the ticket what tests need to exist
20:47:20 <venkaban> wyclif, Yeah for each method added a new Junit should also be added and tested individually
20:47:35 <venkaban> wyclif, Ok
20:56:03 <wyclif> venkaban, i have commented on the ticket
20:58:41 <venkaban> wyclif, I got it
20:59:40 <venkaban> wyclif, bwolfe, thanks
21:00:20 *** finbrein has quit IRC
21:02:48 <suranga> hi bwolfe , so bwolfe , ive made some progress since I asked that last (quite stupid) question ^ could i please make one clarification before the wekend, please ? :-)
21:03:39 <bwolfe> sure
21:03:44 <bwolfe> ask quickly though... :-0
21:03:46 <bwolfe> :-)
21:04:21 <wyclif> venkaban, cool
21:06:53 <bwolfe> suranga?
21:07:17 <suranga> bwolfe, sorry, its like this, Im making a jdbc connection to the db
21:07:21 *** venkaban has quit IRC
21:07:37 *** venkaban has joined #openmrs
21:07:41 <suranga> bwolfe, using this , can I execute hql such as ResultSet rs = stmt.executeQuery( "FROM org.openmrs.patient" ) ;
21:08:04 <suranga> bwolfe, or do I specifically need to create a sessionfactory to execute hql ?
21:08:11 <venkaban> bwolfe, are you able to check out the code from http://svn.openmrs.org/openmrs/branches/order-entry/?
21:08:33 <bwolfe> yes.
21:08:36 <bwolfe> whats your error venkaban?
21:09:14 <venkaban> bwolfe, unable to connect to the repository
21:09:15 <bwolfe> suranga, yes, you need a session factory if you want hql. hql == hibernate query language. hibernate interprets the hql and makes the jdbc calls for you
21:09:21 <bwolfe> venkaban, try https maybe?
21:09:26 <venkaban> ok
21:09:40 <bwolfe> suranga, if you want to write pure sql, use your jdbc connection
21:09:56 <bwolfe> if you want to do hql, you go through hibernate.
21:10:11 <suranga> bwolfe, sigh :-) bwolfe cant I create a sessionfactory from scratch ? I ask because my attempts to get it up are failing :(
21:10:14 <venkaban> bwolfe, No luck even after trying with https
21:10:16 <bwolfe> suranga, your module's service should get you a sessionfactory injected into it.
21:10:26 <suranga> bwolfe, yep, thats right...
21:10:45 <bwolfe> venkaban, hmm, proxy problem?
21:10:50 <suranga> bwolfe, how can I call that from a POJO ? I cant , right ?
21:10:54 <bwolfe> venkaban, double confirmed, I can check it out
21:11:05 <venkaban> bwolfe, hmmmmmm
21:11:14 <bwolfe> suranga, pojos call service methods
21:11:16 <venkaban> I can view it in web browser
21:11:17 <bwolfe> service methods call dao methods
21:11:27 <venkaban> bwolfe, its strange
21:11:31 <bwolfe> dao methods know about sessionfactories and/or jdbc connections
21:11:46 <suranga> bwolfe, oooooooooooooooooh....
21:11:55 <suranga> bwolfe, sorry, not feeling super well today !
21:12:09 <suranga> bwolfe, you make plenty sense :)
21:12:12 <venkaban> bwolfe, what proxy problem?
21:12:15 * suranga goes to look
21:12:18 <suranga> thanks bwolfe
21:12:52 <bwolfe> suranga, so do all calls like that from a dao method. your dao has a sessionFactory object that is "magically" available to you thanks to springs Dependency Injection. (and because you told spring how ot do it from your moduleApplicatioNContext file)
21:13:03 <bwolfe> venkaban, are you using a proxy at the office?
21:13:12 <bwolfe> venkaban, or is there some other network problem?
21:13:46 <venkaban> bwolfe, I have checked out the code before for regular development
21:14:03 <venkaban> bwolfe, for this url I am not able to not sur, I tried out of VPN too
21:14:17 <bwolfe> are you doing "svn co http://svn.openmrs.org/openmrs/branches/order-entry" ?
21:14:28 <venkaban> bwolfe, Yes
21:14:40 <bwolfe> works for me. :-/
21:14:41 <venkaban> bwolfe : from the repo browser
21:14:53 <bwolfe> are you checking out as a maven project?
21:14:57 <venkaban> bwolfe, I will figure this out
21:15:55 <bwolfe> ok, try on kiran's machine to see if its just you
21:16:11 <bwolfe> perhaps an svn problem? try restarting, I know you're using htat inferior OS, that usually helps it. ;-)
21:16:19 <venkaban> I will ask Kiran
21:16:34 <venkaban> but for now I can copy the code from the web browser
21:16:53 <bwolfe> true
21:17:00 <bwolfe> just harder to find. no control-shift-t in the web. :-)
21:17:25 <venkaban> I can do that on my current trunk code right ;)
21:17:35 <venkaban> and then look at the path and find the correct one
21:20:29 <bwolfe> true
21:21:19 <bwolfe> ok, out for a while. I'll try to get back on this evening. otherwise email me with questions. (or better yet, ask here and get answers from wyclif, suranga, or jordank) :-)
21:21:45 <suranga> suranga, will try to answer querstions :-)
21:21:57 <venkaban> thanks bwolfe
21:22:05 <venkaban> Have a great weekend bwolfe
21:23:05 *** bwolfe has quit IRC
21:24:00 <wyclif> venkaban, am only here for the next 5min but will be back later
21:24:25 <venkaban> wyclif, ok
21:34:20 *** finbrein has joined #openmrs
21:40:00 *** jordank has quit IRC
21:50:58 *** wyclif has quit IRC
22:21:06 <suranga> venkaban, im afraid i'll be signing out very soon too. its 4 am in the morning over here :P
22:22:16 <venkaban> suranga, haha
22:22:34 <venkaban> suranga, yeah it is too early to leave wat say ;)
22:23:10 *** goutham has quit IRC
22:31:42 *** every0ne has quit IRC
22:38:05 *** venkaban has quit IRC
22:58:08 *** suranga has quit IRC
23:06:58 *** wyclif has joined #openmrs
23:37:27 *** kreddy has quit IRC