| 00:09:18 | *** scsibug has joined #openmrs |
| 00:11:07 | <scsibug> Hello, was wondering if anyone could help me with a nagging little issue when I run 'mvn test' for OpenMRS? |
| 00:13:25 | <scsibug> every time I run mvn test, it seems that some of the test java files are touched by maven. This triggers my editor to alert me that the file I'm editing (the test) has been modified on disk. |
| 00:26:38 | *** jordank has quit IRC |
| 00:26:54 | *** venkaban has joined #openmrs |
| 00:27:15 | <venkaban> wyclif, Hi |
| 00:29:56 | <wyclif> hi venkaban |
| 00:30:40 | <venkaban> wyclif, you are a developer right? |
| 00:32:12 | <wyclif> venkaban, yes |
| 00:34:00 | <venkaban> wyclif, I have some question on the following ticket descrption |
| 00:34:05 | <venkaban> wyclif : ServiceContext class has methods which synchronize on refreshContext boolean variable. Java typically creates only two objects of boolean type. So its better to synchronize on a different object lock. I've tested this behavior on a test code, and indeed it seemed that java just had two objects for boolean type. |
| 00:34:06 | <venkaban> Since the ServiceContext is used quite frequently, the synchronization policy selected will impact performance. |
| 00:34:35 | <venkaban> wyclif, do we have our own api for refreshContext boolean variable? |
| 00:35:48 | <wyclif> hold on |
| 00:39:01 | <wyclif> Most of the services in ServiceContext are singletons |
| 00:45:28 | <venkaban> ok |
| 00:46:24 | <wyclif> actually all since they are spring managed beans |
| 00:48:24 | <venkaban> ok |
| 00:48:25 | <scsibug> found the reason... maven-java-formatter-plugin is updating the stat on files, even when it makes no modification. |
| 00:48:31 | <venkaban> thanks wyclif |
| 00:48:46 | <wyclif> no problem |
| 00:48:52 | <wyclif> by the way which ticket is that? |
| 00:51:17 | <venkaban> 3378 |
| 00:51:25 | <venkaban> sry 3363 |
| 01:42:26 | *** djazayeri has joined #openmrs |
| 01:42:26 | *** ChanServ sets mode: +o djazayeri |
| 01:52:56 | *** Jibesh has joined #openmrs |
| 01:58:11 | *** scsibug has quit IRC |
| 02:08:31 | *** suranga has joined #openmrs |
| 02:08:39 | *** ChanServ sets mode: +v suranga |
| 02:54:59 | *** ShellZero has joined #openmrs |
| 02:55:19 | *** ShellZero is now known as applecool |
| 02:57:20 | <applecool> !seen rafa |
| 02:57:20 | <OpenMRSBot> applecool: rafa was last seen in #openmrs 5 hours, 26 minutes, and 21 seconds ago: <rafa> suranga: maybe it has a method you need |
| 03:04:22 | *** scsibug has joined #openmrs |
| 03:04:44 | *** scsibug has quit IRC |
| 03:16:17 | *** suranga has quit IRC |
| 03:18:32 | *** robbyoconnor has quit IRC |
| 03:28:35 | *** applecool has quit IRC |
| 03:43:12 | *** robbyoconnor has joined #openmrs |
| 03:43:12 | *** ChanServ sets mode: +v robbyoconnor |
| 04:53:01 | *** ShellZero has joined #openmrs |
| 04:53:23 | *** ShellZero is now known as applecool |
| 06:16:15 | *** magoo_ has joined #openmrs |
| 06:22:40 | *** djazayeri has quit IRC |
| 06:23:24 | *** djazayeri has joined #openmrs |
| 06:23:24 | *** ChanServ sets mode: +o djazayeri |
| 06:24:07 | *** dkayiwa has joined #openmrs |
| 06:25:29 | *** djazayeri has quit IRC |
| 06:37:19 | *** p_m has joined #openmrs |
| 06:46:56 | *** harshadura has joined #openmrs |
| 06:54:23 | *** bryq has joined #openmrs |
| 06:54:23 | *** ChanServ sets mode: +v bryq |
| 07:12:00 | *** bryq has quit IRC |
| 07:20:56 | *** pushkar has joined #openmrs |
| 07:22:29 | *** applecool has quit IRC |
| 07:46:45 | *** dkayiwa has quit IRC |
| 07:46:49 | *** snoppy has joined #openmrs |
| 07:50:11 | <pushkar> wyclif, hi |
| 07:58:05 | *** Jibesh has left #openmrs |
| 08:03:42 | *** suranga has joined #openmrs |
| 08:03:52 | *** ChanServ sets mode: +v suranga |
| 08:14:56 | *** suranga has quit IRC |
| 08:22:02 | <snoppy> pushkar: I think he is sleeping now:) |
| 08:26:03 | *** rafa has joined #openmrs |
| 08:26:03 | *** ChanServ sets mode: +v rafa |
| 08:32:20 | *** kdeeq has joined #openmrs |
| 08:32:23 | <pushkar> snoppy, yes got it |
| 08:32:27 | *** pushkar has quit IRC |
| 08:39:38 | *** snoppy has quit IRC |
| 09:03:50 | *** dkayiwa has joined #openmrs |
| 09:19:10 | *** dkayiwa_ has joined #openmrs |
| 09:19:11 | *** dkayiwa has quit IRC |
| 09:19:12 | *** dkayiwa_ is now known as dkayiwa |
| 09:27:56 | *** snoppy has joined #openmrs |
| 09:33:41 | *** goutham has joined #openmrs |
| 09:49:24 | *** suranga has joined #openmrs |
| 09:49:24 | *** ChanServ sets mode: +v suranga |
| 09:57:12 | *** ShellZero has joined #openmrs |
| 09:57:47 | *** ShellZero is now known as applecool |
| 09:57:52 | <applecool> hey rafa |
| 09:58:02 | <applecool> good morning :) |
| 09:59:04 | <applecool> whoops good afternoon :) |
| 10:04:38 | <magoo_> hi everyone i have openmrs 1.8.3 running on my pc but since i have seen the release 1.9 and am downloading it right now is there wiki on how to upgrade from a lower version to a higher version |
| 10:05:44 | <magoo_> and if am to upgrade do i need to first backup mysql database |
| 10:06:54 | <dkayiwa> magoo_: https://wiki.openmrs.org/display/docs/Upgrading+OpenMRS |
| 10:06:55 | <OpenMRSBot> <http://ln-s.net/9Gya> (at wiki.openmrs.org) |
| 10:08:59 | <dkayiwa> magoo_: also the readme.txt file has the upgrading instructions as you can see it here: https://sourceforge.net/projects/openmrs/files/releases/OpenMRS_1.9.0/ |
| 10:09:03 | <OpenMRSBot> <http://ln-s.net/$Fx9> (at sourceforge.net) |
| 10:13:58 | *** suranga has quit IRC |
| 10:18:07 | <applecool> rafa: are you at lunch ? :) |
| 10:23:16 | *** applecool has quit IRC |
| 10:26:55 | *** maurya has joined #openmrs |
| 10:29:36 | *** magoo_ has quit IRC |
| 10:31:01 | *** harshadura has joined #openmrs |
| 10:37:23 | *** p_m has quit IRC |
| 10:43:54 | *** suranga has joined #openmrs |
| 10:43:54 | *** ChanServ sets mode: +v suranga |
| 10:50:29 | *** p_m has joined #openmrs |
| 10:54:17 | *** ShellZero has joined #openmrs |
| 10:54:41 | *** ShellZero is now known as applecool |
| 10:54:47 | <applecool> rafa: there? |
| 10:54:55 | <rafa> applecool: hi |
| 10:55:03 | <applecool> hi rafa :) |
| 10:55:12 | <applecool> very good afternoon :) |
| 10:55:21 | <rafa> applecool: how was your day? |
| 10:55:41 | <applecool> hmm!! not soo bad and ot so good too :) |
| 10:55:55 | <applecool> i changed the fileupload to packageupload |
| 10:55:55 | <rafa> applecool: let's make it better :D |
| 10:56:01 | <applecool> did you see :) |
| 10:56:06 | <applecool> yeah thanks :) |
| 10:56:09 | <rafa> applecool: no |
| 10:56:32 | <applecool> okay! i committed and pushed it in the morning :) |
| 10:56:34 | <rafa> applecool: I wonder if I can setup notifications about commits in github... |
| 10:56:52 | <applecool> we will write an app for that :D |
| 10:57:11 | <applecool> soon after our project is done :D |
| 10:57:17 | <rafa> applecool: probably if you want me to look at some commit you just need to comment on that |
| 10:57:23 | <rafa> applecool: and I will be notified |
| 10:57:27 | <rafa> applecool: can we try that? |
| 10:57:39 | <applecool> okay ;) |
| 10:57:45 | <applecool> which one? the app? |
| 10:58:06 | <rafa> applecool: no just go to github, browse one of your commits and add a comment |
| 10:58:18 | <rafa> applecool: one of your new commits I haven't seen yet |
| 10:58:18 | <applecool> okay just a sec! ;) |
| 11:02:05 | <applecool> rafa: give me a minute! i donno y my broadband speed got decreased! i will fix it |
| 11:02:40 | <rafa> applecool: at least IRC doesn't need much broadband :D |
| 11:03:05 | <applecool> yes! that is y i am speaking to u without any interruption! :D |
| 11:03:12 | <applecool> just a minute! :) |
| 11:03:15 | <rafa> applecool: ok |
| 11:05:04 | *** applecoo_ has joined #openmrs |
| 11:05:34 | *** applecoo_ is now known as applecool_ |
| 11:06:11 | *** pushkar has joined #openmrs |
| 11:06:59 | *** james_regen has joined #openmrs |
| 11:06:59 | *** ChanServ sets mode: +v james_regen |
| 11:07:40 | *** applecool has quit IRC |
| 11:08:14 | <suranga> hi james_regen a quick message... DONT read the email i just sent, I want to re-phrase it :-) |
| 11:08:34 | <suranga> james_regen, this is in regard to the email I sent last night |
| 11:08:46 | *** applecool_ is now known as applecool |
| 11:08:59 | <applecool> rafa: did you get any notification now? |
| 11:09:08 | <rafa> yes! |
| 11:09:12 | <applecool> cool |
| 11:09:20 | <applecool> coming to the third task! |
| 11:09:34 | <rafa> applecool: ok, any questions? |
| 11:09:55 | <applecool> PackageManagerImpl.saveFile(byte[] file) |
| 11:10:22 | <applecool> this line means i need to create a saveFile method in the PAckageManagerImpl.java file |
| 11:10:27 | <applecool> right? or am i wrong |
| 11:10:55 | <rafa> applecool: that's right |
| 11:11:10 | <rafa> applecool: and you don't want to put it in the PackageManager interface |
| 11:11:20 | <rafa> applecool: it is only for use in PackageManagerImpl |
| 11:11:20 | <james_regen> suranga: ok |
| 11:11:25 | <james_regen> suranga: i'll unread it |
| 11:11:28 | <applecool> yes! |
| 11:11:57 | <suranga> james_regen, sorry :) it seems i got clearer ideas after I re-read your emails again ... |
| 11:11:58 | <applecool> but getServletcontext is from the BaseFormController |
| 11:12:16 | <applecool> this is giving me a problem! |
| 11:12:32 | <rafa> applecool: you don't want to use getServletContext |
| 11:12:43 | <applecool> then? |
| 11:12:48 | <rafa> applecool: isn't it to determine where to store a file? |
| 11:13:19 | <applecool> yes it is |
| 11:13:43 | <rafa> applecool: so we want the path to be read from a properties file |
| 11:13:51 | <rafa> applecool: did I put it in the same task? |
| 11:13:59 | <applecool> no |
| 11:14:05 | <applecool> it is on the other number |
| 11:14:25 | <rafa> applecool: ok so in this task just use a fixed path instead of getServletContext |
| 11:14:54 | <rafa> applecool: just say "/temp" or something |
| 11:15:37 | <rafa> applecool: point to a path that you have rights to write :) |
| 11:15:47 | *** dkayiwa has quit IRC |
| 11:16:04 | <applecool> okay! |
| 11:18:26 | *** maurya has quit IRC |
| 11:20:50 | *** suranga_ has joined #openmrs |
| 11:21:06 | *** suranga has quit IRC |
| 11:21:37 | <suranga_> hi james_regen mm.. im afraid that today is not your lucky day .. |
| 11:21:58 | <suranga_> james_regen, we would love to clarify some points with you if you dont mind :-) |
| 11:22:14 | <james_regen> suranga_: sure |
| 11:23:09 | <suranga_> james_regen, thanks ! let me cover the basics, and build up on them... |
| 11:23:26 | <suranga_> james_regen, Statement 1: When creating a patient matching report, we will be converting from org.openmrs.etc.etc to (Date) date of birth, and using that |
| 11:23:44 | <suranga_> james_regen, But for task no. 2, we dont have anything saved in the database at the time the checking needs to be done, so we need to convert from (Date) date of birth to org.opemrs.etc.etc. |
| 11:23:50 | <suranga_> thats right, isnt it ? |
| 11:24:17 | <james_regen> suranga_: yes, i think that's true |
| 11:24:46 | <suranga_> james_regen, so We can fix this mapping by modifying the patientToRecord method (as mentioned in your email) |
| 11:25:01 | <pushkar> hi i am trying to install htmlflowsheet module but getting the error Unable to load tag handler class "org.openmrs.module.htmlformflowsheet.web.taglibs.HtmlIncludeTag" for tag "htmlformflowsheet:htmlInclude" |
| 11:25:08 | <suranga_> james_regen, now, based on what i've looked up today-- You have created the class OpenMRSFormPairs, which already makes use of hql queries. |
| 11:25:22 | <suranga_> james_regen, We can create a class similar to OpenMRSFormPairs. Now, this class will create a scratch table on its own, so we can simply do a mc.getBlockingColumns(); call, and make use of the mappings we created in the patientToRecord method to identify how to map to tables correctly. |
| 11:25:39 | <pushkar> can anyone tell where the taghandlers are placed? |
| 11:25:46 | <james_regen> suranga_: oh, i also thought of another way we can keep track of how we changed things |
| 11:25:59 | <suranga_> james_regen, aha.... |
| 11:26:28 | <suranga_> james_regen, what do you think of doing so via configuration entry objects ? : |
| 11:27:13 | <james_regen> we can keep a static mapping class in the module, and when patientToRecord is called, update one object in the module that stores how things are being translated into matching module land |
| 11:27:47 | <james_regen> suranga_: i got lost when you said we can create a class similar to OpenMRSFormPairs. how will that use a scratch table? |
| 11:28:31 | <suranga_> james_regen, umm.. but since that uses hql queries, i assumed that it created one |
| 11:28:56 | <suranga_> james_regen, oh sorry, I guess OpenMRS FORM pairs works directly with the database, is it ? |
| 11:29:53 | <james_regen> suranga_: yeah, it's like working with SQL. we issue queries, and we get results |
| 11:30:16 | <suranga_> james_regen, we dont really need to create a scratch table for task 2, do we ? |
| 11:31:29 | <james_regen> suranga_: no, i t hink the best solution would be us not creating a scratch table. that takes a while, and it reads in everything about a patient, which takes time |
| 11:31:50 | <suranga_> james_regen, I see |
| 11:32:25 | <james_regen> suranga_: if we use queries that just look at must match fields, then hopefully that's quicker. hopefully the database indexes and aggregation functions and the fact that we're ignoring much of each patient will speed it up |
| 11:33:06 | <suranga_> james_regen, if I were to add that change to the patientToRecordClass, and implement something like OpenMRSformpairs class, we can do it like that, cant we ? |
| 11:35:02 | <james_regen> suranga_: i think so, if i'm understanding you. if we add changes to patientToRecord to keep track of the mapping between OpenMRS fields and matching fields, then we'll know how to go back to OpenMRS from the strategies. and the new class would be like OpenMRSFormPairs in that it uses HQL, but it wouldn't be a FormPairs object, it'll be simpler |
| 11:35:59 | <applecool> rafa: there? |
| 11:36:03 | <suranga_> james_regen, my plan is to call this new class we create immidiately when we click 'save configuration'. I hope that makes sense... :-) |
| 11:36:14 | <rafa> applecool: yes |
| 11:36:22 | <applecool> need some help! |
| 11:36:37 | <suranga_> james_regen, but my worry is, if we do it using the patientToRecord method, this comparason happens to every single record pair we have, correct ? |
| 11:36:38 | <applecool> i actually changed some code of the saveFile! |
| 11:36:47 | <applecool> and i am in little bit of trouble! |
| 11:37:07 | <suranga_> james_regen, I've noted that we may be able to do the same via the configuration entry object |
| 11:37:52 | <suranga_> the configuration entrry already has org.openmrs.etc.etc. stored, so what if we create a new string variable to store '(Date) patient date of birth' |
| 11:37:56 | <suranga_> as well ? :) |
| 11:38:58 | <james_regen> suranga_: it adds some work to patientToRecord, but i don't know if it will matter. making some java objects in memory should matter much if it's part of the same process that is waiting on queries from the database to access patient information. it's already not a fast operation, adding a bit of overhead will make it still not fast |
| 11:39:08 | <applecool> rafa: InputStream stream =new ByteArrayInputStream(file); instead of file.getInputStream(); |
| 11:39:20 | <james_regen> suranga_: i can't remember what the configuration entry object represents |
| 11:40:11 | <suranga_> james_regen, I introduced that for the database ticket, actually. Each configuration is made up of n many configuration entries |
| 11:40:32 | <suranga_> a configuration entry is a single attribute displayed on the create strategies page.. |
| 11:41:33 | <applecool> because its giving me an error "Cannot invoke getInputStream() on the array type byte[]" rafa |
| 11:41:46 | <rafa> applecool: I won't be a compiler for you. |
| 11:41:52 | <rafa> applecool: read javadocs |
| 11:42:00 | <rafa> applecool: learn how to use a class |
| 11:42:02 | <applecool> okay :) |
| 11:42:18 | <rafa> applecool: these are too basic things to explain |
| 11:42:20 | <suranga_> james_regen, when someone wants to create a new patient matching configuration, the createconfiguration() method of the MatchingConfigurationUtils class will create blank entries |
| 11:42:37 | <suranga_> the configurationEntry will contain org.openmrs.etc.etc. |
| 11:42:56 | <james_regen> suranga_: that seems like an okay place to put it from what you've said |
| 11:43:08 | <suranga_> james_regen, it occures to me that we can introduce a new variable to this, which can also store the display name (Date) date of birth |
| 11:43:20 | <rafa> applecool: I can help you with exceptions not with compile errors |
| 11:43:39 | <suranga_> james_regen, its in MatchingConfigurationUtils.java maybe you can take a look ? (if you are free, that is :-) |
| 11:43:49 | <applecool> rafa: okay :) |
| 11:48:02 | <james_regen> suranga_: yeah, that looks like a good place for it |
| 11:48:27 | <suranga_> james_regen, thanks for helping us out with this. without you, we are pretty sunk :P |
| 11:51:37 | <james_regen> suranga_: no problem, i feel like i have the easy part |
| 11:51:48 | <suranga_> james_regen, one more 'very small' question, im afraid. Need to clarify something about the hql queries... |
| 11:53:03 | <suranga_> james_regen, pulasthi says that he will execute something like x.<field> not null and x.<field> !="" and x.<field>=y.<field>" for each blocking configuration. is that correct ? my impression was that he needs to execute this for each and every record precord pair ? |
| 11:54:01 | <suranga_> james_regen, for example, patient1.<field> not null and patient1.<field> !="" and patient1.<field>=patient2.<field>" |
| 11:56:04 | <james_regen> suranga_: i'm not sure where it's being executed for every record pair. the number of expressions in the where clause will depend on the must match fields, right? |
| 11:56:40 | <suranga_> james_regen, corrrect, it depends on the must matches only... |
| 11:57:27 | <suranga_> james_regen, I assumed that we would be doing this for each and every patient pair, and summing the total number of matches... but something tells me I was wrong :-) |
| 11:58:50 | <james_regen> HQL can do the counting. we don't care what the pairs are or what the non-null values are, we just need to know how many pairs there are |
| 12:00:44 | *** applecoo_ has joined #openmrs |
| 12:01:09 | <suranga_> james_regen, I see.. so assuming that 'date of birth' is a blocking column, we need to compare if the blocking column field of both records in a record pair contain the same value, correct ? |
| 12:02:44 | *** magoo_ has joined #openmrs |
| 12:02:44 | <james_regen> suranga_: i think we won't need to compare because we'll structure our hql query to only form pairs (and then count) where the values are the same |
| 12:03:08 | *** applecool has quit IRC |
| 12:03:43 | <suranga_> james_regen, hmm... so x.<field> not null and x.<field> !="" and x.<field>=y.<field>" is correct, isnt it ? |
| 12:05:22 | <james_regen> suranga_: i think so. i'm not familiar enough with hql to fill in the rest of the query with correct syntax, but thinking about sql that seems right |
| 12:05:48 | <suranga_> james_regen, I see... this should be definitely enough to start us on our way :-) |
| 12:06:10 | *** applecoo_ is now known as applecool |
| 12:06:24 | <james_regen> suranga_: okay :) |
| 12:28:06 | *** goutham has quit IRC |
| 12:37:46 | <magoo_> hi suranga_ |
| 12:38:12 | <suranga_> hi magoo_ |
| 12:38:48 | <magoo_> suranga_ i need some help |
| 12:39:00 | *** applecoo_ has joined #openmrs |
| 12:39:18 | <suranga_> magoo_, whats up ? hopefully, I , or someone can help... |
| 12:40:05 | <magoo_> suranga_ how do i bind slf4j-api-1.6.5.jar into jdk path |
| 12:40:30 | <suranga_> magoo_, u are not using maven ? |
| 12:40:49 | <suranga_> magoo_, is so, you can add it to build path via eclipse, right ? |
| 12:40:56 | *** applecool has quit IRC |
| 12:41:51 | <magoo_> suranga_ i have maven installed |
| 12:42:47 | <suranga_> magoo_, if so, cant you add the dependency to the pom file ? if not, is there a reason you want to add it to the build path seperately ? |
| 12:44:05 | <suranga_> magoo_, afraid that I dont understand what you need to do... :) |
| 12:44:06 | <magoo_> suranga_ let me pastebin you what is happening when i build the project |
| 12:44:14 | <suranga_> magoo_, sure |
| 12:45:38 | *** downey has joined #openmrs |
| 12:45:38 | *** ChanServ sets mode: +o downey |
| 12:45:38 | *** OpenMRSBot sets mode: +o downey |
| 12:45:58 | *** kdeeq has quit IRC |
| 12:46:05 | <magoo_> suranga_ http://pastebin.com/6inGXiSi |
| 12:47:33 | <magoo_> suranga_ according to me it seems am missing slf4j-api-1.6.5.jar |
| 12:48:46 | <suranga_> magoo_, umm.. I cant seem to find areference to that jar in the pastie... |
| 12:48:50 | <suranga_> lets see... |
| 13:01:20 | <magoo_> suranga_ after checking on http://www.slf4j.org/manual.html i thought i was missing the slf4j-api-1.6.5.jar api |
| 13:04:10 | *** applecool has joined #openmrs |
| 13:05:13 | *** suranga_ has quit IRC |
| 13:06:24 | *** applecoo_ has quit IRC |
| 13:10:08 | *** p_m has quit IRC |
| 13:10:38 | *** harshadura has quit IRC |
| 13:13:30 | *** wyclif has quit IRC |
| 13:14:47 | <applecool> rafa: there? |
| 13:15:01 | <rafa> applecool: yes |
| 13:15:44 | <applecool> we need to invoke the saveFile() right |
| 13:16:58 | <rafa> applecool: right |
| 13:18:08 | <rafa> applecool: but as part of saving a package |
| 13:19:40 | <rafa> applecool: override save method in teh PackageManagerImpl |
| 13:20:37 | <applecool> okay i will do that! i actually changed the code! i wrote a simple code!! do you want to see that once! i dont want to commit that! please let me know is it good or not? |
| 13:20:56 | <applecool> i wil pastebin the saveFile! check it and let me know! |
| 13:21:45 | <applecool> http://pastebin.com/3Xj48ccw |
| 13:23:53 | <rafa> applecool: don't catch FileNotFoundException |
| 13:24:28 | <rafa> applecool: you actually made that exception to disappear |
| 13:24:37 | <rafa> applecool: user won't know that something went wrong |
| 13:25:14 | *** applecoo_ has joined #openmrs |
| 13:25:18 | <rafa> applecool: also don't use e.printStackTrace() |
| 13:25:29 | <downey> Hi applecoo_ and welcome to the #openmrs IRC channel. |
| 13:25:37 | <applecoo_> rafa: i got disconnected! |
| 13:25:39 | <rafa> applecool: the right way is to log it with a logger |
| 13:25:54 | <rafa> applecoo_: ok let me repeat |
| 13:25:58 | <applecoo_> yes! |
| 13:26:07 | <applecoo_> downey: hi :) |
| 13:26:12 | <rafa> ~-+101498904+-~7[15:22] rafa: applecool: don't catch FileNotFoundException |
| 13:26:12 | <rafa> ~-+101499120+-~7[15:22] rafa: applecool: you actually made that exception to disappear |
| 13:26:12 | <rafa> ~-+101499192+-~7[15:23] rafa: applecool: user won't know that something went wrong |
| 13:26:12 | <rafa> ~-+101501712+-~4[15:23] applecoo_ has joined |
| 13:26:12 | <rafa> ~-+101501856+-~7[15:23] rafa: applecool: also don't use e.printStackTrace() |
| 13:26:24 | *** applecool has quit IRC |
| 13:26:30 | *** applecoo_ is now known as applecool |
| 13:26:35 | <downey> hi applecool |
| 13:26:40 | <applecool> hi |
| 13:26:43 | <applecool> rafa: okay! |
| 13:26:50 | <applecool> so is the code fine actualy? |
| 13:26:53 | <applecool> in general? |
| 13:27:29 | <rafa> applecool: yes |
| 13:28:19 | <applecool> okay so i need to remove that try catch! |
| 13:29:50 | <applecool> rafa: i need to invoke saveFile() in the onSubmit in the FileUploadController ? |
| 13:31:12 | <rafa> applecool: no you want to call PackageManager.save there |
| 13:31:18 | *** maurya has joined #openmrs |
| 13:31:27 | <applecool> where? |
| 13:31:38 | <rafa> applecool: and you'll call saveFile in PackageManagerImpl.save before you persist it in the db |
| 13:32:03 | <rafa> applecool: call PackageManager.save in FileUploadController |
| 13:32:28 | <applecool> oh |
| 13:34:23 | <rafa> applecool: the point is we'll hide how the package is saved :) So that we can change it any time later without touching the controller. |
| 13:34:52 | *** harshadura has joined #openmrs |
| 13:34:54 | <applecool> okay :) |
| 13:51:00 | *** applecool has quit IRC |
| 13:56:55 | *** mvorobey has joined #openmrs |
| 13:57:02 | <mvorobey> hi all |
| 13:59:22 | *** wyclif has joined #openmrs |
| 14:00:02 | *** bryq has joined #openmrs |
| 14:00:02 | *** ChanServ sets mode: +v bryq |
| 14:02:06 | *** lh has joined #openmrs |
| 14:02:06 | *** lh has joined #openmrs |
| 14:02:14 | *** jmiranda has joined #openmrs |
| 14:02:22 | *** ChanServ sets mode: +o jmiranda |
| 14:03:27 | *** snoppy has quit IRC |
| 14:05:50 | <venkaban> are we having a scrum meeting now |
| 14:11:35 | <downey> Hi venkaban - doing the weekly developer forum now |
| 14:11:37 | <downey> !devmtg |
| 14:11:37 | <OpenMRSBot> downey: "devmtg" --- Reminder: Developer Forum Thursday at 10:00 AM Eastern Time - https://wiki.openmrs.org/display/RES/Developers+Forum |
| 14:12:17 | <venkaban> downey: Thank You , I am in the meeting now :) |
| 14:14:20 | <downey> venkaban: cool :) |
| 14:15:20 | *** jordank has joined #openmrs |
| 14:16:16 | *** mccallumg has joined #openmrs |
| 14:16:16 | *** ChanServ sets mode: +v mccallumg |
| 14:19:05 | *** bwolfe has joined #openmrs |
| 14:19:05 | *** ChanServ sets mode: +o bwolfe |
| 14:23:32 | *** maurya has quit IRC |
| 14:23:51 | *** maurya has joined #openmrs |
| 14:33:44 | *** snoppy has joined #openmrs |
| 14:33:44 | *** maurya has quit IRC |
| 14:34:42 | *** maurya has joined #openmrs |
| 14:38:03 | *** maurya has quit IRC |
| 14:38:22 | *** maurya has joined #openmrs |
| 14:40:13 | <pushkar> bwolfe, Hi |
| 14:41:38 | <bwolfe> hi |
| 14:42:03 | *** maurya has quit IRC |
| 14:42:21 | *** maurya has joined #openmrs |
| 14:44:29 | <pushkar> bwolfe, the htmlformflowsheet is throwing an exception when I am trying to run it |
| 14:44:56 | <pushkar> Unable to load tag handler class "org.openmrs.module.htmlformflowsheet.web.taglibs.ProgramName" for tag "htmlformflowsheet:programName" |
| 14:45:15 | <bwolfe> hmm |
| 14:45:23 | <pushkar> the taglib has been included in the jsp file |
| 14:47:09 | *** maurya has quit IRC |
| 14:47:34 | *** kdeeq has joined #openmrs |
| 14:48:11 | *** magoo_ has quit IRC |
| 14:48:42 | *** maurya has joined #openmrs |
| 14:53:48 | *** nribeka has joined #openmrs |
| 14:53:48 | *** maurya has quit IRC |
| 14:53:52 | *** ChanServ sets mode: +v nribeka |
| 14:54:20 | *** maurya has joined #openmrs |
| 14:56:11 | *** nribeka has quit IRC |
| 14:58:33 | *** maurya has quit IRC |
| 14:58:54 | *** maurya has joined #openmrs |
| 14:59:06 | *** lh has quit IRC |
| 15:02:10 | *** lh has joined #openmrs |
| 15:02:10 | *** lh has joined #openmrs |
| 15:17:21 | *** mccallumg has quit IRC |
| 15:17:21 | *** maurya has quit IRC |
| 15:18:49 | *** maurya has joined #openmrs |
| 15:19:36 | *** djazayeri has joined #openmrs |
| 15:19:36 | *** ChanServ sets mode: +o djazayeri |
| 15:20:03 | <bwolfe> pushkar, not sure why that would be failing. anything in the mailing list history about it? (or google) |
| 15:20:16 | *** suranga has joined #openmrs |
| 15:21:07 | *** bryq has quit IRC |
| 15:21:21 | *** venkaban has quit IRC |
| 15:26:19 | *** djazayeri has quit IRC |
| 15:26:20 | *** maurya has quit IRC |
| 15:26:52 | *** maurya has joined #openmrs |
| 15:27:28 | *** harshadura has quit IRC |
| 15:27:34 | *** venkaban has joined #openmrs |
| 15:29:37 | *** mvorobey has quit IRC |
| 15:33:40 | *** maurya has quit IRC |
| 15:33:58 | *** maurya has joined #openmrs |
| 15:37:35 | *** finbrein has joined #openmrs |
| 15:37:40 | *** jordank has quit IRC |
| 15:40:40 | *** maurya has quit IRC |
| 15:41:01 | *** maurya has joined #openmrs |
| 15:46:29 | *** lh has quit IRC |
| 15:46:30 | *** maurya has quit IRC |
| 15:46:51 | *** maurya has joined #openmrs |
| 15:54:35 | *** maurya has quit IRC |
| 15:54:57 | *** maurya has joined #openmrs |
| 15:56:18 | *** kavuri has joined #openmrs |
| 15:58:42 | *** venkaban has quit IRC |
| 16:00:48 | *** mseaton has joined #openmrs |
| 16:00:48 | *** ChanServ sets mode: +v mseaton |
| 16:00:48 | *** maurya has quit IRC |
| 16:02:51 | *** maurya has joined #openmrs |
| 16:03:30 | *** applecool has joined #openmrs |
| 16:05:26 | *** pulasthi7 has joined #openmrs |
| 16:05:26 | *** maurya has quit IRC |
| 16:05:32 | <pushkar> bwolfe, yes,but didnt find anything related to error |
| 16:05:59 | *** maurya has joined #openmrs |
| 16:10:00 | <suranga> heloo pulasthi7 :) |
| 16:10:25 | <pulasthi7> hi suranga, |
| 16:10:37 | <suranga> pulasthi7, ha haa...sorry if it looks like im stalking you :-) |
| 16:10:54 | <suranga> pulasthi7, did u see the second email I sent, at about 5 pm today ? |
| 16:11:09 | <pulasthi7> suranga, i just logged in |
| 16:11:56 | *** lh has joined #openmrs |
| 16:11:56 | *** lh has joined #openmrs |
| 16:12:10 | <pulasthi7> suranga, i'm checking the mail now, can you give me 2 mins |
| 16:12:49 | <suranga> pulasthi7, sure. and maybe we will walk through the code after that |
| 16:12:49 | *** maurya has quit IRC |
| 16:13:21 | *** maurya has joined #openmrs |
| 16:21:04 | *** maurya has quit IRC |
| 16:21:32 | *** maurya has joined #openmrs |
| 16:23:30 | *** bryq has joined #openmrs |
| 16:23:52 | *** ChanServ sets mode: +v bryq |
| 16:24:20 | *** snoppy has quit IRC |
| 16:25:37 | <pulasthi7> suranga, i had a look at the mail |
| 16:25:40 | *** maurya has quit IRC |
| 16:25:46 | <suranga> pulasthi7, how does it look to you ? |
| 16:25:55 | <suranga> pulasthi7, does that make sense ? |
| 16:26:38 | <pulasthi7> suranga, yes,to some extent, need to go through the relevent code |
| 16:27:21 | <suranga> pulasthi7, shall we walk through it now ? |
| 16:27:35 | *** maurya has joined #openmrs |
| 16:27:44 | <suranga> that way we can be sure we're not misunderstanding each other :) |
| 16:28:03 | <pulasthi7> suranga, ok, i was going to go through that classes |
| 16:28:58 | <suranga> pulasthi7, cool.... |
| 16:29:12 | <suranga> pulasthi7, lets start off from the begining... |
| 16:29:36 | <suranga> so assume ive creatated a new patientmatchingconfiguration, and clicked on the save button... |
| 16:30:07 | <suranga> pulasthi7, that takes us into the controller.... |
| 16:30:28 | <suranga> now our plan is to implement something similar to the OpenMRSFormPair class |
| 16:30:39 | *** maurya has quit IRC |
| 16:30:42 | <suranga> and have the controller call that class |
| 16:31:14 | <suranga> Ths new class will be responsible for connecting to the db, creating the form pairs and doing the HQL |
| 16:31:18 | *** venkaban has joined #openmrs |
| 16:31:24 | *** maurya has joined #openmrs |
| 16:31:35 | <suranga> pulasthi7, if you look at the OPENMRSFORMPAIR class, you'll see that it works with HQL |
| 16:32:51 | <pulasthi7> suranga, ok. clear up to now. I see the hql code there |
| 16:33:00 | <suranga> pulasthi7, if you look inside the OpenMRSFormPairs class, you'll see that it has a call to the RecordTOPair() method... |
| 16:33:34 | <suranga> one of our options on how to solve the mapping problem is to modify this method according to what James said in his earlier email... |
| 16:36:17 | <pulasthi7> suranga, that is adding the verbose method right? |
| 16:36:17 | *** maurya has quit IRC |
| 16:36:51 | *** maurya has joined #openmrs |
| 16:36:53 | <suranga> pulasthi7, we dont specifically need to use something just like the OpenMRSFormpairs class. anything that extends the Formpairs class will do |
| 16:37:04 | <suranga> pulasthi7, yes, we will need to add this... |
| 16:37:45 | <suranga> pulasthi7, this is one possible solution, it requires changes to the recordToPatient method and the creation of a new class |
| 16:38:40 | <suranga> pulasthi7, there is another alternative that james and I were looking at tooo... I've described it in my email |
| 16:39:13 | <suranga> instead of modifying the recordsTopatients methodyou can do it via configurationEntry objects too |
| 16:40:41 | <suranga> pulasthi7, hope that what I said so far is clear.... :) |
| 16:41:17 | <pulasthi7> suranga, yes :) |
| 16:41:39 | *** maurya has quit IRC |
| 16:41:57 | *** maurya has joined #openmrs |
| 16:42:10 | <suranga> pulasthi7, great ! |
| 16:42:26 | <suranga> pulasthi7, do you want to clarify the other two options for mapping too ? |
| 16:46:16 | <pulasthi7> suranga, what did you mean by other two options? |
| 16:46:59 | <pulasthi7> suranga, is it the options mentioned in th email? |
| 16:46:59 | *** maurya has quit IRC |
| 16:47:24 | *** maurya has joined #openmrs |
| 16:47:52 | <suranga> mm... pulasthi7 .. are you still here ? :P |
| 16:48:46 | <pulasthi7> suranga, yes, i had scrolled the log up and didn't see your last one. |
| 16:50:35 | <suranga> aha, pulasthi7 I see |
| 16:50:45 | <suranga> pulasthi7, option no.2 on ho to do the mapping |
| 16:51:02 | <suranga> pulasthi7, each patientmatchingconfiguration object is made up of many configurationentry objects |
| 16:51:03 | *** maurya has quit IRC |
| 16:51:24 | *** maurya has joined #openmrs |
| 16:51:35 | <suranga> pulasthi7, when a user tries to create a newpatientmatching configuration, the configurationentry objects are filled out with the matching data |
| 16:52:19 | <pulasthi7> suranga, I'm clear on the configurationEntry objects, I had gone through that before |
| 16:52:38 | <suranga> pulasthi7, if you look at the createPatientMatchingConfig method of the MatchingConfigurationUtils page, you will see that the configurationentry objects are filled via reflection |
| 16:53:06 | *** dkayiwa has joined #openmrs |
| 16:54:33 | <suranga> pulasthi7, if you look at how this calls MatchingUtils.generateProperties |
| 16:54:57 | <suranga> you'll see how they are converting the org.openmrs.etc.etc. into (Date) patient date of birth etc. |
| 16:55:53 | <suranga> pulasthi7, so if we add a new string field to the configurationentry class, and also record the displayabloe valued (Date) patient date of birth. etc. we can do the mapping easily... |
| 16:55:53 | *** maurya has quit IRC |
| 16:56:25 | *** maurya has joined #openmrs |
| 16:56:39 | *** harshadura has joined #openmrs |
| 16:57:40 | <suranga> pulasthi7, on last and very bad option. If you have trouble with the mapping, dont forget that they have been included correctly in the spring properties file. so if you want to access the data in the properties file, you can just read in the file, and treat it like any old data file, and copy in any values of your choice.... |
| 16:57:56 | <suranga> pulasthi7, thats it, i guess... what do you think ? :) |
| 16:59:09 | <pulasthi7> i'd try the one before last one |
| 16:59:51 | <pulasthi7> suranga, seems i got what needs to be done there. |
| 17:00:06 | <pulasthi7> suranga, last option may keep as a backup |
| 17:00:25 | <suranga> pulasthi7, the very last option will definitely work, but its terrible terrible design :-) |
| 17:00:37 | <suranga> pulasthi7, you want to try option 2 - with configurationEntry ? |
| 17:00:59 | <pulasthi7> suranga, yes, i'll try on that. |
| 17:00:59 | *** maurya has quit IRC |
| 17:01:25 | *** maurya has joined #openmrs |
| 17:01:53 | <suranga> pulasthi7, the new variable you are introducing into the configurationentry, doesnt need to be persisted into the database, I think |
| 17:02:02 | <suranga> pulasthi7, can you think of a reason it should be stored ? |
| 17:02:46 | *** pulasthim has joined #openmrs |
| 17:02:57 | <downey> Hi pulasthim and welcome to the #openmrs IRC channel. |
| 17:03:38 | <pulasthim> hi suranga, got disconnected :( |
| 17:03:48 | <pulasthim> anything I missed? |
| 17:03:56 | <suranga> pulasthi7, ooops :P |
| 17:04:07 | <suranga> pulasthi7, lets see.. .. I said... |
| 17:04:15 | <suranga> <pulasthi7> suranga, yes, i'll try on that. |
| 17:04:15 | <suranga> * maurya has quit (Read error: Connection reset by peer) |
| 17:04:16 | <suranga> * maurya (~Maurya@122.175.4.34) has joined #openmrs |
| 17:04:16 | <suranga> <suranga> pulasthi7, the new variable you are introducing into the configurationentry, doesnt need to be persisted into the database, I think |
| 17:04:16 | <suranga> <suranga> pulasthi7, can you think of a reason it should be stored ? |
| 17:05:50 | *** pulasthi7 has quit IRC |
| 17:06:45 | <suranga> pulasthim, one more concern I have is regarding the use of the OpenMRSFormpair class. Im not sure if it works with a database connection... |
| 17:07:20 | <suranga> pulasthim, for example, to create a new OpenMRSFormpair instance, we need to pass in a MatchingConfig object... |
| 17:07:21 | *** maurya has quit IRC |
| 17:07:55 | *** maurya has joined #openmrs |
| 17:10:00 | <suranga> james_regen, sorry, one more question im afraid. Is it possible to create a openMRSFormPair object using a database connection (as opposed to two flat files) or does pulasthim need to use a DedupOrderedDataSourceFormPairs object ? |
| 17:10:37 | <suranga> james_regen, DedupOrderedDataSourceFormPairs is supposed to "returns pairs from a single |
| 17:10:37 | <suranga> * OrderedDataSourceReader" |
| 17:10:38 | *** maurya has quit IRC |
| 17:10:58 | *** maurya has joined #openmrs |
| 17:11:05 | *** kdeeq has quit IRC |
| 17:11:24 | *** pulasthi7 has joined #openmrs |
| 17:12:09 | <suranga> pulasthi7, bad connection, huhh ? you keep getting disconnected :P |
| 17:12:16 | <james_regen> suranga: i don't think we need to create an OpenMRSFormPairs object, do we? |
| 17:12:20 | <pulasthi7> suranga, having some problem with the connection. got disconnected again :( |
| 17:13:22 | <suranga> james_regen, not nessesarily a OpenMRSFormPair object, but something that will let us create recordPairs is needed, isnt it ? |
| 17:13:46 | *** pushkar_ has joined #openmrs |
| 17:14:08 | <james_regen> i don't think we need record pairs, either. HQL should be able to do it directly. i'll try to make an anology |
| 17:14:23 | *** pulasthim has quit IRC |
| 17:14:23 | *** maurya has quit IRC |
| 17:15:31 | <james_regen> we can find out how many pairs are formed by making an SQL query like "select a.uid, b.uid from patient a, patient b where a.dob = b.dob and a.uid < b.uid;" that should craate a result set where all the pairs of IDs are from patients that match on date of birth. we could then call next() enough times and count how many times that returns |
| 17:15:53 | *** Jibesh has joined #openmrs |
| 17:15:56 | *** Jibesh has left #openmrs |
| 17:15:59 | *** maurya has joined #openmrs |
| 17:16:00 | <james_regen> or we can just issue "select count(*) from patient a, patient b where a.dob = b.dob and a.uid < b.uid;" and get the answer we need directly |
| 17:16:55 | *** harshadura has quit IRC |
| 17:16:59 | <james_regen> the where clause defines that we're only counting what we're interested in, and we let the database take advantage of any shortcuts it can find |
| 17:17:09 | *** pushkar has quit IRC |
| 17:18:01 | <suranga> james_regen, I seee... that makes a lot of sense ! james_regen however, if so, and if we are not making use of form pairs, are we connecting to the database via that class itself ? |
| 17:18:23 | <suranga> james_regen, that is, code to connect to the datbse are stored inside the class itsel ? |
| 17:18:24 | *** maurya has quit IRC |
| 17:18:56 | *** maurya has joined #openmrs |
| 17:19:14 | <james_regen> suranga: yeah, the new class will connect to the database. as to how, the OpenMRSFormPaiirs has an example of how to get a HibernateSessionFactory and issue HQL queries, or there might be a better way through the API to get the objects we need |
| 17:19:50 | <suranga> james_regen, very very cool.. ha haa.. you have solved all our problems for us in advance :-) |
| 17:19:57 | <suranga> james_regen, thanks a lot for helping out :) |
| 17:20:11 | <suranga> pulasthi7, that answers all our questions, I guess |
| 17:20:18 | <james_regen> suranga: no problem. i'm really curious how the performance will be |
| 17:20:39 | <suranga> james_regen, ha ha.. I hope it wont be too embarassing :P |
| 17:21:02 | <pulasthi7> suranga, yes i'm following this :) |
| 17:21:25 | <suranga> pulasthi7, great ! hope you did not miss anything because of your connectivity problems :) |
| 17:22:25 | <pulasthi7> not after the last join, :) seems connection is alright, at least for now |
| 17:24:23 | <suranga> pulasthi7, does this make sense to you ? it sounds good ? |
| 17:24:23 | *** maurya has quit IRC |
| 17:24:56 | *** maurya has joined #openmrs |
| 17:26:07 | <pulasthi7> suranga, yes, sounds good. |
| 17:26:59 | <suranga> pulasthi7, now that we have this, the best approach would be to go ahead and get a 'working' prototype ready as soon as possible |
| 17:27:23 | <suranga> pulasthi7, if the prototype works fine, then we know that this method is suitable, and we dont have any problems... |
| 17:28:45 | <pulasthi7> suranga, ok, i'll work on that, and check whether it works |
| 17:29:07 | *** maurya has quit IRC |
| 17:29:13 | <suranga> pulasthi7, great ! looks good ! |
| 17:29:28 | <suranga> pulasthi7, and also, based on this, will we be meeting tomorrow ? |
| 17:29:39 | *** maurya has joined #openmrs |
| 17:30:40 | <pulasthi7> suranga, i was about to tell you about that. i have to go bit early tomorrow too. |
| 17:31:02 | <suranga> pulasthi7, eek... another workshop ? |
| 17:33:38 | *** rafa has quit IRC |
| 17:34:38 | *** maurya has quit IRC |
| 17:35:18 | *** maurya has joined #openmrs |
| 17:39:37 | *** maurya has quit IRC |
| 17:39:56 | *** maurya has joined #openmrs |
| 17:52:08 | *** maurya has quit IRC |
| 17:52:27 | *** maurya has joined #openmrs |
| 17:56:38 | *** maurya has quit IRC |
| 17:56:57 | *** maurya has joined #openmrs |
| 17:57:09 | *** kavuri has quit IRC |
| 17:58:21 | *** applecool has quit IRC |
| 17:59:08 | *** maurya has quit IRC |
| 17:59:30 | *** maurya has joined #openmrs |
| 18:00:08 | *** mseaton has quit IRC |
| 18:05:40 | *** maurya has quit IRC |
| 18:06:26 | *** maurya has joined #openmrs |
| 18:09:40 | *** maurya has quit IRC |
| 18:09:47 | *** pulasthi7 has quit IRC |
| 18:11:27 | *** maurya has joined #openmrs |
| 18:13:40 | *** maurya has quit IRC |
| 18:13:44 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Today in the #OpenMRS dev forum: Consensus reached to move to Git & @GitHub. http://t.co/CBeqnfIN <http://twitter.com/OpenMRS/statuses/210789680797593602> |
| 18:13:59 | *** maurya has joined #openmrs |
| 18:18:42 | *** mseaton has joined #openmrs |
| 18:18:42 | *** ChanServ sets mode: +v mseaton |
| 18:20:26 | *** anna has joined #openmrs |
| 18:20:27 | *** maurya has quit IRC |
| 18:20:31 | <downey> Hi anna and welcome to the #openmrs IRC channel. |
| 18:20:56 | *** maurya has joined #openmrs |
| 18:21:15 | *** anna is now known as annaparsons |
| 18:22:38 | *** annaparsons has quit IRC |
| 18:27:18 | *** pulasthi7 has joined #openmrs |
| 18:27:19 | *** maurya has quit IRC |
| 18:27:42 | *** james_regen has left #openmrs |
| 18:27:55 | *** maurya has joined #openmrs |
| 18:36:40 | *** maurya has quit IRC |
| 18:37:25 | *** maurya has joined #openmrs |
| 18:37:28 | *** mseaton has left #openmrs |
| 18:39:39 | *** maurya has quit IRC |
| 18:39:58 | *** maurya has joined #openmrs |
| 18:41:56 | *** rafa has joined #openmrs |
| 18:41:56 | *** ChanServ sets mode: +v rafa |
| 18:42:40 | *** maurya has quit IRC |
| 18:43:27 | *** maurya has joined #openmrs |
| 18:47:08 | *** maurya has quit IRC |
| 18:47:29 | *** maurya has joined #openmrs |
| 18:48:56 | *** sgithens has joined #openmrs |
| 18:54:08 | *** maurya has quit IRC |
| 18:54:28 | *** maurya has joined #openmrs |
| 18:55:34 | *** pulasthi7 has quit IRC |
| 18:58:22 | *** kreddy has joined #openmrs |
| 18:59:12 | *** mseaton has joined #openmrs |
| 18:59:12 | *** ChanServ sets mode: +v mseaton |
| 19:00:51 | <mseaton> bwolfe / rafa / dkayiwa: i am consistently seeing reams of error messages in the log file having to do with logic unable to startup with daemon correctly. this happens when i reload modules, etc. are you guys seeing this? |
| 19:00:52 | *** maurya has quit IRC |
| 19:01:24 | <dkayiwa> mseaton: which openmrs version? |
| 19:01:27 | *** maurya has joined #openmrs |
| 19:01:31 | *** mgielow has joined #openmrs |
| 19:01:36 | <mseaton> dkayiwa: 1.9 |
| 19:01:42 | *** mgielow has left #openmrs |
| 19:02:33 | <dkayiwa> mseaton: what sort of error messages? |
| 19:03:04 | <dkayiwa> mseaton: meaning, the underlying cause of this failure |
| 19:03:20 | <mseaton> basically, i think what is happening is that the scheduler is trying to run before openmrs has fully started up and is failing |
| 19:03:38 | <mseaton> eg |
| 19:03:40 | <mseaton> ERROR - TokenServiceImpl.startupProviderWithoutDaemon(114) |2012-06-07 14:48:58,134| Error starting class org.openmrs.logic.datasource.PatientDataSource |
| 19:03:40 | <mseaton> org.openmrs.api.APIException: Service not found: interface org.openmrs.logic.token.TokenService |
| 19:03:40 | <mseaton> at org.openmrs.api.context.ServiceContext.getService(ServiceContext.java:717) |
| 19:03:40 | <mseaton> at org.openmrs.api.context.Context.getService(Context.java:914) |
| 19:03:40 | <mseaton> at org.openmrs.logic.rule.provider.DataSourceRuleProvider.registerCompleteTokens(DataSourceRuleProvider.java:53) |
| 19:03:41 | <mseaton> at org.openmrs.logic.rule.provider.RegisterAtStartupDataSourceRuleProvider.afterStartup(RegisterAtStartupDataSourceRuleProvider.java:38) |
| 19:03:41 | <mseaton> at org.openmrs.logic.token.impl.TokenServiceImpl.startupProviderWithoutDaemon(TokenServiceImpl.java:112) |
| 19:03:42 | <mseaton> at org.openmrs.logic.token.impl.TokenServiceImpl.startupProviderAsDaemon(TokenServiceImpl.java:99) |
| 19:03:42 | <mseaton> at org.openmrs.logic.token.impl.TokenServiceImpl.initialize(TokenServiceImpl.java:72) |
| 19:03:43 | <mseaton> at org.openmrs.logic.token.impl.TokenServiceImpl.onStartup(TokenServiceImpl.java:64) |
| 19:03:43 | <mseaton> at sun.reflect.GeneratedMethodAccessor207.invoke(Unknown Source) |
| 19:03:44 | <mseaton> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) |
| 19:03:44 | <mseaton> at java.lang.reflect.Method.invoke(Method.java:597) |
| 19:03:45 | <mseaton> at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:309) |
| 19:03:45 | <mseaton> at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) |
| 19:03:46 | <mseaton> at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) |
| 19:03:46 | <mseaton> at org.openmrs.aop.LoggingAdvice.invoke(LoggingAdvice.java:122) |
| 19:03:47 | <mseaton> at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) |
| 19:03:47 | <mseaton> at org.springframework.aop.framework.adapter.MethodBeforeAdviceInterceptor.invoke(MethodBeforeAdviceInterceptor.java:50) |
| 19:03:48 | <mseaton> at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) |
| 19:03:48 | <mseaton> at org.springframework.aop.framework.adapter.MethodBeforeAdviceInterceptor.invoke(MethodBeforeAdviceInterceptor.java:50) |
| 19:03:49 | <mseaton> at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) |
| 19:03:49 | <mseaton> at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:202) |
| 19:03:50 | <mseaton> at $Proxy1390.onStartup(Unknown Source) |
| 19:03:50 | <mseaton> at org.openmrs.api.context.Daemon$4.run(Daemon.java:207) |
| 19:03:51 | <mseaton> (sorry) |
| 19:04:40 | *** maurya has quit IRC |
| 19:04:47 | <dkayiwa> mseaton: does the application start at all? or it fails to start? |
| 19:05:11 | <mseaton> dkayiwa: yes, it starts. i have no idea if logic is hosed or not. but the errors are annoying |
| 19:05:58 | <dkayiwa> mseaton: i think i have ever got that too. we may need to create a ticket for it |
| 19:06:20 | *** cpower has joined #openmrs |
| 19:06:30 | <cpower> hello everyone! |
| 19:06:50 | <cpower> Have I missed the scrum or are you ready to start? |
| 19:07:23 | <rafa> cpower: we haven't started yet |
| 19:07:30 | <rafa> cpower: hi |
| 19:07:31 | <cpower> ok then...let's do it! |
| 19:07:37 | <cpower> !scrumon cpower |
| 19:07:37 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 19:07:45 | *** maurya has joined #openmrs |
| 19:08:06 | <cpower> wyclif, venkaban, rafa, mseaton, bwolfe |
| 19:08:49 | <wyclif> Wednesday: |
| 19:08:49 | <wyclif> * listened in to the openmrs university via connect |
| 19:08:49 | <wyclif> * design call |
| 19:08:49 | <wyclif> * CALC-32 - Add support for caching of token registrations |
| 19:08:49 | <wyclif> * Updated module wiki in relation to CALC-35 - Calculations should be performed at no more than 1000 patients at a time |
| 19:08:50 | <wyclif> * Reviewed patch for CALC-35 - Calculations should be performed at no more than 1000 patients at a time |
| 19:08:52 | <wyclif> * error logging code review |
| 19:08:54 | <wyclif> Thursday: |
| 19:08:56 | <wyclif> * Dev call |
| 19:08:58 | <wyclif> * CALC ticket discussions through comments |
| 19:09:00 | <wyclif> * Try to pant out the calculation tickets |
| 19:09:02 | <wyclif> Blockers: None |
| 19:10:18 | <cpower> venkaban... |
| 19:10:37 | * cpower slaps venkaban with a rainbow trout |
| 19:10:38 | *** maurya has quit IRC |
| 19:10:41 | <wyclif> sorry, the review was for TRUNK-3324 - Revisit DrugOrderValidator |
| 19:10:56 | *** maurya has joined #openmrs |
| 19:11:03 | <cpower> ok rafa.. |
| 19:11:07 | <rafa> Today: |
| 19:11:07 | <rafa> * Reviewed sprint tickets |
| 19:11:07 | <rafa> * Corrected RESTWS-260: Add getResourceVersion property |
| 19:11:07 | <rafa> https://tickets.openmrs.org/browse/RESTWS-260 |
| 19:11:07 | <rafa> * Worked on RESTWS-246: Resource documentation needs to describe "types" (i.e. subclass handlers) |
| 19:11:08 | <rafa> https://tickets.openmrs.org/browse/RESTWS-246 |
| 19:11:08 | <rafa> No blockers. |
| 19:11:32 | <cpower> mseaton isn't on this sprint actually, so skip |
| 19:11:34 | <rafa> Ohh and updated https://wiki.openmrs.org/display/docs/Liquibase |
| 19:11:37 | <cpower> to bwolfe |
| 19:11:49 | <bwolfe> one sec |
| 19:11:50 | <rafa> to be more non-dev friendly per request |
| 19:12:17 | <cpower> rafa you want to be more friendly to non-dev's? |
| 19:12:28 | <rafa> cpower: I hope I am now :D |
| 19:12:43 | <bwolfe> Wednesday |
| 19:12:43 | <bwolfe> review code for suranga |
| 19:12:43 | <bwolfe> email catchup |
| 19:12:43 | <bwolfe> univ call |
| 19:12:43 | <bwolfe> docs for restws |
| 19:12:43 | *** maurya has quit IRC |
| 19:12:44 | <bwolfe> last minute setup for design call |
| 19:12:46 | <bwolfe> design call |
| 19:12:48 | <bwolfe> pm call |
| 19:12:50 | <bwolfe> Thursday |
| 19:12:52 | <bwolfe> went to court this morning for guardianship (again) for Eden |
| 19:12:54 | <bwolfe> dev call |
| 19:12:56 | <bwolfe> ldrship call |
| 19:12:58 | <bwolfe> (vacation day) |
| 19:13:25 | *** maurya has joined #openmrs |
| 19:13:35 | <dkayiwa> Design Call |
| 19:13:35 | <dkayiwa> Went through xforms tickets and labeled those which should be in the upcoming xforms sprint |
| 19:13:36 | <dkayiwa> Got blocked on: BaseContextSensitiveTest does not create Core Global Properties - TRUNK-3028 |
| 19:13:36 | <dkayiwa> Now working on: ComplexObsHandler should throw UnsupportedViewException if invoked with unsupported view - TRUNK-2135 |
| 19:14:00 | <rafa> !ticket TRUNK-3028 |
| 19:14:01 | <OpenMRSBot> rafa: [#TRUNK-3028] BaseContextSensitiveTest does not create Core Global Properties - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3028 |
| 19:14:39 | <venkaban> Currently working on TRUNK-3363 |
| 19:14:56 | <venkaban> Submitted Patch for TRUNK-3378 |
| 19:16:04 | <cpower> venkaban...anything else? |
| 19:16:22 | <venkaban> cpower, thats it from my side |
| 19:16:44 | <maurya> quit |
| 19:16:50 | *** maurya has quit IRC |
| 19:16:58 | <cpower> okay |
| 19:17:02 | <cpower> anyone else? |
| 19:18:13 | <cpower> okay summary: No Discussion points, blockers: BaseContextSensitiveTest does not create core properties |
| 19:18:17 | <cpower> !scrumoff |
| 19:18:17 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 19:21:50 | <rafa> dkayiwa: I commented on the ticket |
| 19:22:17 | <dkayiwa> rafa: yes just seen it. thanks! :) |
| 19:22:52 | <rafa> dkayiwa: that method shouldn't take that long... |
| 19:23:27 | <rafa> dkayiwa: what was your normal build time? |
| 19:23:44 | <bwolfe> dkayiwa, just curious, how did that ticket get to your TODO list? I don't see any votes or a fixVersion on it... |
| 19:23:55 | <dkayiwa> rafa: i thought it should take long in total by the fact that it is called before each unit test method |
| 19:24:04 | <bwolfe> https://wiki.openmrs.org/display/RES/Bug+Fixing+Swim+Lane |
| 19:25:06 | <dkayiwa> bwolfe: can you paste the whole query i should use? |
| 19:26:29 | <bwolfe> query for which tickets to work on? |
| 19:26:59 | <dkayiwa> bwolfe: just a moment. looking at the dashboard on that wiki page :) |
| 19:27:27 | <bwolfe> yes, thats what I was going to say. :-) |
| 19:27:36 | <dkayiwa> :) |
| 19:27:41 | *** bryq has quit IRC |
| 19:28:13 | <dkayiwa> bwolfe: shame upon me that i had not seen this page :) |
| 19:28:36 | <bwolfe> no worries. I think you were off the week that I made that |
| 19:28:49 | <dkayiwa> oh i see!!! |
| 19:35:14 | <dkayiwa> bwolfe: is it ok for me to modify the queries for the tickets on that dashboard to exclude intro tickets? |
| 19:35:40 | <bwolfe> dkayiwa, I don't think you can modify the queries because they're my queries |
| 19:35:49 | <bwolfe> but I can do that, thats a good idea |
| 19:36:00 | <dkayiwa> bwolfe: d:) |
| 19:38:30 | <bwolfe> dkayiwa, hmm, that drops it down from 316 tickets to 80 tickets! |
| 19:39:10 | <dkayiwa> bwolfe: yes i noticed that too when you told me not to work on intro tickets, my search query results became too too small :) |
| 19:39:33 | <bwolfe> but why are there only 34 tickets in the "intro tickets" query? |
| 19:39:58 | <dkayiwa> bwolfe: oh thats strange!!!! |
| 19:40:26 | <bwolfe> something strange is going on in that query |
| 19:40:59 | <dkayiwa> bwolfe: that must be so :( |
| 19:41:35 | <bwolfe> figured it out |
| 19:41:44 | <dkayiwa> bwolfe: aha. what was it? |
| 19:41:50 | <bwolfe> now there are only 286 in the list |
| 19:41:58 | <bwolfe> had to do: and (labels is empty or labels != intro) |
| 19:42:07 | <bwolfe> instead of just: and labels != intro |
| 19:42:10 | <dkayiwa> bwolfe: oh i see!!!! :) |
| 19:42:18 | <dkayiwa> makes perfect sense |
| 19:42:41 | <bwolfe> ok, I have to run. meghan doens't like me working on my day off. :-) |
| 19:42:54 | <bwolfe> (bbl) |
| 19:43:04 | <dkayiwa> bwolfe: hahahah. send her my regards!!! :D |
| 19:55:25 | *** mvorobey has joined #openmrs |
| 20:08:23 | *** cpower has quit IRC |
| 20:13:09 | *** dkayiwa has quit IRC |
| 20:14:09 | *** yansuck has joined #openmrs |
| 20:14:11 | <yansuck> Hello |
| 20:15:26 | <yansuck> When I try to build openmrs-api on maven in eclipse, it returns me an error initiatelly that " failed to load class "org.slf4j.impl.StaticLoggerBiner". Does anybody know how to solve this? I would really appreciate some helps. " |
| 20:20:18 | *** mvorobey has quit IRC |
| 20:21:03 | <yansuck> Hello? |
| 20:21:35 | *** suranga has quit IRC |
| 20:21:39 | <rafa> yansuck: hi |
| 20:22:11 | <rafa> yansuck: was it you who posted to the dev list? |
| 20:23:59 | <yansuck> Hi yes is it me! |
| 20:24:05 | <yansuck> It is* |
| 20:24:40 | <yansuck> I am still trying to build this...but it just wont work... |
| 20:25:01 | <yansuck> I have followed instructions carefully but these errors are just giving me a headache X.X |
| 20:29:22 | <rafa> yansuck: ok |
| 20:29:35 | <rafa> yansuck: look in the api/target/surfire-reports directory |
| 20:30:55 | *** dkayiwa has joined #openmrs |
| 20:33:26 | <yansuck> yes |
| 20:34:00 | <yansuck> There are a bunch of files |
| 20:43:21 | <rafa> yansuck: open a random one and put the content on pastebin.com |
| 20:47:16 | *** lh has quit IRC |
| 20:48:46 | *** yansuck has quit IRC |
| 20:49:38 | *** Sravanthi has joined #openmrs |
| 20:49:48 | *** Sravanthi has left #openmrs |
| 20:53:00 | *** mseaton has left #openmrs |
| 21:35:48 | *** lh has joined #openmrs |
| 21:44:03 | *** venkaban has quit IRC |
| 21:48:25 | *** venkaban has joined #openmrs |
| 21:48:45 | *** lh has quit IRC |
| 21:49:04 | <venkaban> bwolfe, Hi |
| 21:49:20 | *** lh has joined #openmrs |
| 21:49:20 | *** lh has joined #openmrs |
| 21:49:24 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Join our #OpenMRS session at #OSCON & learn how we build global #HealthIT platforms. Use code OS12FOS & save 20% at http://t.co/mCjcXRHf. <http://twitter.com/OpenMRS/statuses/210839699978334208> |
| 21:49:38 | *** sgithens has quit IRC |
| 21:50:35 | *** pushkar_ has quit IRC |
| 21:57:46 | *** downey has quit IRC |
| 22:02:46 | *** lh has quit IRC |
| 22:03:13 | *** lh has joined #openmrs |
| 22:04:21 | *** lh has joined #openmrs |
| 22:04:21 | *** lh has joined #openmrs |
| 22:04:30 | *** wyclif has quit IRC |
| 22:14:49 | <venkaban> dkayiwa, Hi |
| 22:14:49 | *** mgielow_ has joined #openmrs |
| 22:15:48 | <dkayiwa> hi venkaban |
| 22:16:05 | <venkaban> dkayiwa, I have some slight confusion with the ticket 3378 |
| 22:16:22 | <venkaban> TRUNK-3363 sorry dkayiwa |
| 22:16:25 | <dkayiwa> !ticket TRUNK_ 3378 |
| 22:16:26 | <OpenMRSBot> dkayiwa: HTTP Error 404: Not Found - https://tickets.openmrs.org/browse/TRUNK_ 3378 |
| 22:16:42 | <dkayiwa> !ticket TRUNK_ 3363 |
| 22:16:43 | <OpenMRSBot> dkayiwa: HTTP Error 404: Not Found - https://tickets.openmrs.org/browse/TRUNK_ 3363 |
| 22:16:53 | <dkayiwa> !ticket TRUNK_3363 |
| 22:16:54 | <OpenMRSBot> dkayiwa: HTTP Error 404: Not Found - https://tickets.openmrs.org/browse/TRUNK_3363 |
| 22:17:04 | <venkaban> dkayiwa, here is the description |
| 22:17:07 | <venkaban> dkayiwa : ServiceContext class has methods which synchronize on refreshContext boolean variable. Java typically creates only two objects of boolean type. So its better to synchronize on a different object lock. I've tested this behavior on a test code, and indeed it seemed that java just had two objects for boolean type. |
| 22:17:08 | <venkaban> Since the ServiceContext is used quite frequently, the synchronization policy selected will impact performance. |
| 22:17:13 | <dkayiwa> !ticket !ticket TRUNK-3363 |
| 22:17:14 | <OpenMRSBot> dkayiwa: HTTP Error 404: Not Found - https://tickets.openmrs.org/browse/!ticket TRUNK-3363 |
| 22:17:31 | <dkayiwa> venkaban: give me the correct ticket number |
| 22:17:47 | <venkaban> dkayiwa : https://tickets.openmrs.org/browse/TRUNK-3363 |
| 22:18:02 | <venkaban> dkayiwa, are you able to get in there> |
| 22:18:27 | <dkayiwa> venkaban: yes |
| 22:19:05 | <venkaban> dkayiwa, if you understand, can you please explain what object lock it is referred to in the summary |
| 22:21:04 | <dkayiwa> venkaban: not very clear to me too |
| 22:22:51 | *** dkayiwa has quit IRC |
| 22:27:24 | *** applecool has joined #openmrs |
| 22:27:33 | <applecool> rafa: there? |
| 22:37:56 | *** applecool has quit IRC |
| 22:52:27 | *** jmiranda has quit IRC |
| 23:03:11 | *** rafa has quit IRC |
| 23:03:14 | *** mgielow_ has quit IRC |
| 23:11:43 | *** wyclif has joined #openmrs |
| 23:11:48 | *** finbrein has quit IRC |
| 23:15:35 | *** Mkop has quit IRC |
| 23:28:56 | *** kreddy has quit IRC |
| 23:31:55 | *** venkaban has quit IRC |