00:09:07
|
*** venkaban has quit IRC
|
00:28:02
|
*** jordank has quit IRC
|
01:00:15
|
*** suranga has joined #openmrs
|
01:50:07
|
*** sgithens has joined #openmrs
|
02:10:25
|
*** nwilkie has joined #openmrs
|
02:22:25
|
*** nwilkie_ has joined #openmrs
|
02:22:25
|
*** nwilkie has quit IRC
|
02:22:25
|
*** nwilkie_ is now known as nwilkie
|
02:23:37
|
*** nwilkie_ has joined #openmrs
|
02:23:37
|
*** nwilkie has quit IRC
|
02:23:37
|
*** nwilkie_ is now known as nwilkie
|
02:44:59
|
*** suranga has quit IRC
|
03:05:07
|
*** nwilkie_ has joined #openmrs
|
03:05:46
|
*** nwilkie has quit IRC
|
03:05:46
|
*** nwilkie_ is now known as nwilkie
|
03:14:40
|
*** nwilkie has quit IRC
|
03:17:04
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Another #OpenMRS Information Night in Melbourne Australia tonight. Details: http://t.co/M4I3mLqL #ICT4D #HealthIT #eHealth <http://twitter.com/OpenMRS/statuses/210200750612168705> || On Twitter: OpenMRS: Join #OpenMRS Information Night, tonight in #Sydney #Australia. More info: http://t.co/ehe1KDbc #HealthIT #eHealth #ICT4D <http://twitter.com/OpenMRS/statuses/210198409636888576>
|
03:19:50
|
*** jordank has joined #openmrs
|
03:28:52
|
*** upul` has joined #openmrs
|
03:28:52
|
*** ChanServ sets mode: +v upul`
|
03:34:10
|
*** bwolfe has quit IRC
|
03:48:24
|
*** maurya has joined #openmrs
|
04:04:38
|
*** djazayeri has joined #openmrs
|
04:04:38
|
*** ChanServ sets mode: +o djazayeri
|
04:26:02
|
<maurya> djazayeri, the httprequest that we send from HtmlFromEntryController to the formSubmissionController does it contain all the html of the final page or only the one's that are there in the original instance of htmlform
|
04:26:42
|
<djazayeri> maurya: can you point me to a line of code in a file that you're talking about?
|
04:28:42
|
<maurya> djazayeri, 201 in htmlformentrycontoller and 67 in formSubmissionController
|
04:30:04
|
<djazayeri> maurya: the HttpServletRequest is the HTTP POST that was submitted by the user.
|
04:30:10
|
<djazayeri> It doesn't control html
|
04:30:20
|
<djazayeri> I mean: it doesn't contain html
|
04:31:32
|
<maurya> i meant the elements in that page
|
04:33:15
|
<djazayeri> maurya: are you asking what it *does* or what it is supposed to do?
|
04:33:29
|
<djazayeri> (in the context of dynamicRepeat)?
|
04:33:59
|
<djazayeri> maurya: that request will contain exactly what the user's browser submits. We can't change that.
|
04:34:13
|
<maurya> what id does..
|
04:34:31
|
<maurya> yes so it must be containing the dynamic elements right?
|
04:35:02
|
<djazayeri> maurya: if you used javascript to create additional inputs in the form, they would be submitted also. yes
|
04:35:15
|
*** suranga has joined #openmrs
|
04:35:15
|
*** ChanServ sets mode: +v suranga
|
04:37:46
|
<maurya> so, in the formSubmissionController it parses through only the actions that belong to the original instance of the htmlform right?
|
04:37:55
|
<djazayeri> maurya: correct.
|
04:40:49
|
<maurya> okay so what i wanted to ask was, which one is better?trying to add the dynamic elemnts in the actions before making it parse or write logic to add the elements seperately
|
04:41:16
|
<djazayeri> maurya: you're talking about the true dynamic repeat?
|
04:41:26
|
<djazayeri> (I don't quite understand those options...)
|
04:41:43
|
<maurya> i am presently trying the selectMulti part
|
04:42:05
|
<maurya> but the dynamicrepeat would be the similar i guess
|
04:42:46
|
<maurya> okay so the change i must make must be in the formsubmissioncontroller right?
|
04:43:53
|
<djazayeri> maurya: for select-multi?
|
04:44:06
|
<djazayeri> I don't think you should need to change anything in the _framework_.
|
04:44:19
|
<djazayeri> I was assuming you could handle that completely within the ObsSubmissionElement class.
|
04:44:19
|
<maurya> yes, for the submission part
|
04:44:22
|
<djazayeri> Is that not the case?
|
04:46:16
|
*** goutham has joined #openmrs
|
04:46:39
|
<maurya> djazayeri, for creating the elements in the user's browser it is needed but how do we specify the newly generated element submission that are not in the actions?
|
04:47:24
|
<djazayeri> maurya: oh, sorry, I was thinking about multi-select checkboxes.
|
04:47:32
|
<djazayeri> we're talking multi-select coded obs, right?
|
04:47:40
|
<maurya> yes
|
04:48:30
|
<djazayeri> So, in that case, I would assume that you'd have the newly generated elements submit w3.1, w3.2, w3.3, etc.
|
04:49:08
|
<djazayeri> maurya: ObsSubmissionElement knows it's in select-multi mode, so it looks for all w3.*
|
04:49:21
|
<maurya> yeah similarly , iwas creating a span so i kept w8span1
|
04:50:50
|
<maurya> djazayeri, oh can you point me to the line ? i thought obssubmissionelement only takes a single valu for submission
|
04:51:19
|
<djazayeri> maurya: it does, currently. This is what you'd need to change.
|
04:53:59
|
<maurya> okay..so i must make a change to make it look for elements generated and make obsSubmissionElements be able to submit multiple values?
|
04:57:42
|
<maurya> djazayeri, i was thinking that the formSubmissionController must be changed so as to submit the newly generated values as they will not effect the original formSchema
|
04:58:55
|
<djazayeri> maurya: the values will be submitted anyway in the HTTP POST, because that's standard browser behavior. The issue, I guess, is that ObsSubmissionElement.handleSubmission has something like:
|
04:58:55
|
<djazayeri> Object value = valueWidget.getValue(session.getContext(), submission);
|
04:59:13
|
<maurya> yes
|
05:00:13
|
<djazayeri> and you might need to introduce some utility method that will try to get multiple values by putting the FormEntryContext in some special state, and repeating the widget.getValue for i=1, 2, 3, etc
|
05:06:04
|
<maurya> i dont know if i am making any sense ,but even if i repeat them ,the context wont be having these actions so would it be possible to persist them?
|
05:06:28
|
<djazayeri> maurya: in this case you don't need to create new actions
|
05:07:11
|
<djazayeri> maurya: the existing ObsSubmissionElement (which is an action) *knows* it's select-multi, so it should be responsible for trying to get multiple values.
|
05:08:44
|
<maurya> okay, i've to try it:) thanks:)
|
05:19:34
|
*** maurya has quit IRC
|
05:20:08
|
*** p_m has joined #openmrs
|
05:21:42
|
*** djazayeri has quit IRC
|
05:26:24
|
*** p_m has quit IRC
|
05:31:09
|
*** bryq has joined #openmrs
|
05:31:09
|
*** ChanServ sets mode: +v bryq
|
05:31:10
|
*** suranga has quit IRC
|
05:43:55
|
*** p_m has joined #openmrs
|
05:58:08
|
*** bryq has quit IRC
|
06:02:59
|
*** pushkar has joined #openmrs
|
06:03:21
|
*** p_m has joined #openmrs
|
06:18:40
|
*** pushkar has quit IRC
|
06:19:02
|
*** pushkar has joined #openmrs
|
06:21:04
|
*** p_m has joined #openmrs
|
06:21:31
|
*** p_m has quit IRC
|
06:23:23
|
*** dkayiwa has joined #openmrs
|
06:30:51
|
*** suranga has joined #openmrs
|
06:37:59
|
*** p_m has joined #openmrs
|
06:39:35
|
*** p_m has quit IRC
|
06:42:41
|
*** snoppy has joined #openmrs
|
06:42:50
|
*** snoppy has left #openmrs
|
06:43:10
|
*** snoppy has joined #openmrs
|
06:54:41
|
*** pushkar has quit IRC
|
06:54:55
|
*** pushkar has joined #openmrs
|
06:56:48
|
*** kavuri has joined #openmrs
|
06:57:10
|
*** p_m has joined #openmrs
|
07:05:04
|
*** sunbiz has joined #openmrs
|
07:05:04
|
*** ChanServ sets mode: +v sunbiz
|
07:13:59
|
*** dkayiwa has joined #openmrs
|
07:16:24
|
*** wyclif has quit IRC
|
07:19:50
|
*** kavuri has quit IRC
|
07:27:05
|
*** pushkar has quit IRC
|
07:28:23
|
*** pushkar has joined #openmrs
|
07:37:08
|
*** mgielow has joined #openmrs
|
07:52:25
|
*** snoppy has left #openmrs
|
07:53:39
|
*** sunbiz1 has joined #openmrs
|
07:55:53
|
*** sunbiz has quit IRC
|
07:56:20
|
*** p_m has quit IRC
|
08:08:35
|
*** p_m has joined #openmrs
|
08:10:07
|
*** suranga has quit IRC
|
08:40:10
|
*** magoo_ has joined #openmrs
|
08:47:09
|
*** ShellZero has joined #openmrs
|
08:47:34
|
*** ShellZero is now known as applecool
|
08:48:33
|
<applecool> !seen rafa
|
08:48:33
|
<OpenMRSBot> applecool: rafa was last seen in #openmrs 16 hours and 46 seconds ago: <rafa> bwolfe: nope it works
|
08:51:18
|
*** pushkar has quit IRC
|
08:51:51
|
*** pushkar has joined #openmrs
|
09:05:05
|
*** snoppy has joined #openmrs
|
09:09:01
|
*** pushkar has quit IRC
|
09:17:22
|
*** applecool has quit IRC
|
09:19:45
|
*** dkayiwa has quit IRC
|
09:21:45
|
*** pushkar has joined #openmrs
|
09:25:14
|
*** dkayiwa has joined #openmrs
|
09:26:05
|
<magoo_> hi all
|
09:28:16
|
<magoo_> dkayiwa if am to begin developing in openmrs do i need to first download the maven openmrs svn and compile the svn or i just begin developing following the openmrs coding rules and procedures
|
09:29:55
|
<dkayiwa> magoo_: did you read this? https://wiki.openmrs.org/display/docs/Getting+Started+as+a+Developer
|
09:29:56
|
<OpenMRSBot> <http://ln-s.net/8bkO> (at wiki.openmrs.org)
|
09:32:16
|
*** pushkar has quit IRC
|
09:35:29
|
*** mgielow has quit IRC
|
10:03:57
|
*** bryq has joined #openmrs
|
10:03:57
|
*** ChanServ sets mode: +v bryq
|
10:14:54
|
*** upul` has quit IRC
|
10:17:10
|
<magoo_> dkayiwa am i supposed to install maven as a plugin or as a standalone application
|
10:17:36
|
<dkayiwa> magoo_: what does that wiki page say?
|
10:17:45
|
*** pushkar has joined #openmrs
|
10:17:56
|
*** maurya has joined #openmrs
|
10:18:14
|
<magoo_> okay wiki says that maven should installed
|
10:19:01
|
*** bryq has quit IRC
|
10:19:15
|
<dkayiwa> magoo_: both
|
10:19:32
|
<magoo_> dkayiwa the reason why am asking i have eclipse running on my pc and i managed to install maven as a plugin
|
10:20:55
|
<magoo_> dkayiwa but when i run the command mvn nothing is displayed
|
10:23:36
|
<magoo_> dkayiwa okay i get it
|
10:28:36
|
*** sunbiz1 has quit IRC
|
10:43:15
|
*** nwilkie has joined #openmrs
|
10:50:29
|
*** sgithens has quit IRC
|
10:50:49
|
*** applecool has joined #openmrs
|
10:51:24
|
*** p_m has quit IRC
|
10:51:41
|
*** mgielow has joined #openmrs
|
10:55:17
|
*** magoo_ has quit IRC
|
10:56:09
|
*** rafa has joined #openmrs
|
10:56:09
|
*** ChanServ sets mode: +v rafa
|
10:56:40
|
<applecool> hey rafa :)
|
10:56:41
|
<rafa> applecool: hi
|
10:57:09
|
<applecool> did you check the code yesterday?
|
10:57:17
|
<rafa> applecool: yes
|
10:57:22
|
<applecool> was it good?
|
10:57:27
|
<rafa> applecool: the code was good
|
10:57:31
|
<rafa> applecool: did you add a test?
|
10:57:32
|
<applecool> thanks :)
|
10:57:35
|
<applecool> yup
|
10:57:47
|
<applecool> PackageControllerTest :)
|
10:57:50
|
<rafa> applecool: good
|
10:57:55
|
<applecool> and made it pass! :D
|
10:58:06
|
<rafa> applecool: nice
|
10:58:14
|
<rafa> applecool: now working on what?
|
10:58:17
|
<applecool> rafa: i am having trouble with the 2nd task!
|
10:58:39
|
<rafa> applecool: ok, how can I help you?
|
10:58:44
|
<applecool> do i need to create any bean for that?
|
10:58:49
|
<applecool> no right?
|
10:59:24
|
<rafa> applecool: no
|
10:59:38
|
<applecool> i actually thought its a small and easy task! but i am getting errorS!
|
10:59:47
|
<rafa> applecool: what kind of errors?
|
10:59:59
|
<rafa> applecool: it is small & simple :)
|
11:00:09
|
<applecool> i added the code of byte[] file from FileUpload.java to Package!
|
11:00:18
|
<applecool> first task in that 2nd task
|
11:00:20
|
<applecool> right?
|
11:00:25
|
<rafa> right
|
11:00:31
|
<rafa> and annotated it with @Transient
|
11:00:39
|
<applecool> yup exactly!
|
11:00:41
|
<rafa> and added getters and setters
|
11:01:06
|
<applecool> yup the same right! getName . getFile right?
|
11:01:14
|
<rafa> getFile, setFile
|
11:01:27
|
<rafa> no name
|
11:01:36
|
<rafa> well you have name already
|
11:02:03
|
<applecool> okay! cool removed it :)
|
11:02:32
|
<rafa> applecool: sorry you need getName, setName
|
11:02:37
|
<rafa> applecool: but you have them already
|
11:02:46
|
<rafa> applecool: you don't need to add them
|
11:03:17
|
<applecool> yeah! its already there in the Package.java :)
|
11:03:20
|
<applecool> got it :)
|
11:03:22
|
<rafa> correct
|
11:03:44
|
<rafa> and does that lead to some error?
|
11:03:50
|
<applecool> nope
|
11:03:54
|
<rafa> ok
|
11:04:00
|
<applecool> coming to the FileUploadController
|
11:04:26
|
<rafa> applecool: what error do you get?
|
11:05:39
|
<applecool> i directly changed the FileUpload to Package and instantiated it in the FileUploadController
|
11:06:00
|
<rafa> applecool: ok
|
11:06:30
|
<applecool> then i tried to just build it! and got some different errors! will pastebin it !
|
11:06:32
|
<applecool> just a se
|
11:06:34
|
<applecool> sec
|
11:09:33
|
<applecool> http://pastebin.com/h4SUvNm7
|
11:09:38
|
*** dkayiwa has quit IRC
|
11:09:52
|
<applecool> i think it seems a simple error! but ..
|
11:09:55
|
<applecool> stuck!
|
11:10:27
|
<rafa> @Transient is not recognized in Package
|
11:10:45
|
<rafa> applecool: you're missing an import statement
|
11:11:08
|
*** dkayiwa has joined #openmrs
|
11:11:50
|
<rafa> applecool: Package.java:[34,5] cannot find symbol
|
11:11:51
|
<rafa> [ERROR] symbol : class Transient
|
11:12:01
|
<applecool> rafa: yes
|
11:12:21
|
<rafa> applecool: and an import and you're good
|
11:12:35
|
<applecool> i am actually not getting the AI when i write @Transient! :D
|
11:13:09
|
<rafa> applecool: import javax.persistence.Transient;
|
11:13:34
|
<rafa> applecool: did you put it on getFile?
|
11:14:13
|
<applecool> no just added to the byte[] file
|
11:14:22
|
<applecool> do i need to add it for the getFile too?
|
11:14:41
|
<rafa> applecool: no either way is fine
|
11:14:52
|
<rafa> applecool: on both is not
|
11:15:50
|
<rafa> applecool: if you put it on an annotation on a getter then Hibernate accesses the field via the getter
|
11:16:09
|
<applecool> okay!
|
11:16:10
|
<rafa> applecool: if you put it on a field then Hibernate uses the field directly
|
11:16:20
|
<applecool> okay :)
|
11:16:21
|
<rafa> applecool: it's the only difference
|
11:16:26
|
<applecool> :)
|
11:16:51
|
<rafa> applecool: @Transient actually tells Hibernate not to touch the field so it doesn't really matter if it's on a getter or a field
|
11:17:08
|
<applecool> oh!
|
11:17:21
|
<rafa> applecool: anyway does it compile now?
|
11:17:26
|
*** james_regen has joined #openmrs
|
11:17:26
|
*** ChanServ sets mode: +v james_regen
|
11:17:38
|
<applecool> hmm1 got an another error!
|
11:17:56
|
<applecool> in the FileUploadController now!
|
11:18:06
|
<rafa> what is the error?
|
11:18:31
|
<applecool> again its not able to find the Package constructor i guess! import problem!
|
11:18:58
|
<applecool> http://pastebin.com/tj52Agbe
|
11:19:04
|
<rafa> applecool: why are you not importing classes? :P
|
11:19:42
|
<rafa> applecool: actually now you're justified
|
11:20:12
|
<rafa> applecool: java.lang.Package is a default that you don't have to import
|
11:20:22
|
<rafa> applecool: you need to add import statement manually
|
11:21:32
|
<rafa> applecool: add import org.openmrs.contrib.model.Package;
|
11:21:35
|
<applecool> ok!
|
11:21:50
|
<applecool> yea adde it already :)
|
11:22:47
|
<rafa> applecool: builds now?
|
11:24:08
|
<applecool> in process!
|
11:25:42
|
<applecool> rafa: i have some questions related to the IRC commands!
|
11:25:46
|
<applecool> on openmrs
|
11:26:40
|
<applecool> there? rafa
|
11:26:46
|
<rafa> applecool: yes
|
11:27:20
|
<applecool> yea! i just wanted to know what all the commands which are taught to OpenMRSBot!
|
11:27:22
|
<applecool> :D
|
11:27:28
|
<applecool> i just know !seen
|
11:27:31
|
<rafa> !help
|
11:27:31
|
<OpenMRSBot> rafa: (help [<plugin>] [<command>]) -- This command gives a useful description of what <command> does. <plugin> is only necessary if the command is in more than one plugin.
|
11:28:02
|
<rafa> !commands
|
11:28:04
|
<OpenMRSBot> rafa: action, add, alert, announce, any, apropos, ban add, ban list, ban remove, beer, beer2, beerme, capabilities, capability add, capability list, capability remove, capability set, capability setdefault, capability unset, change, changename, changeset, channel, channels, channelstats, clear, cmd, codereview, commands, config, cpu, cr, cs, cycle, default, defaultcapability, defaultplugin, dehalfop, deop, (3 more messages)
|
11:28:30
|
<applecool> cool! :)
|
11:28:40
|
<rafa> !plugins
|
11:28:40
|
<OpenMRSBot> rafa: Error: "plugins" is not a valid command.
|
11:29:15
|
<rafa> applecool: does it build?
|
11:29:46
|
<applecool> got an error ! need to change something in web-test.xml :)
|
11:29:57
|
<rafa> applecool: no
|
11:30:10
|
<rafa> there should be no need to change tests
|
11:30:21
|
<rafa> applecool: you need to fix fileupload.jsp
|
11:30:42
|
<applecool> yes! yes! understood! :D i got an HTTP error!
|
11:30:51
|
<rafa> applecool: it expects "fileUpload" bean whereas now you have "package"
|
11:30:51
|
<applecool> HTTP error 500
|
11:31:22
|
<rafa> applecool: open fileupload.jsp
|
11:31:35
|
<rafa> applecool: see line 13th
|
11:31:38
|
<applecool> opend already!
|
11:31:50
|
<rafa> applecool: it binds fileUpload bean
|
11:32:01
|
<applecool> okay need to make Package
|
11:32:04
|
<applecool> right?
|
11:32:13
|
<rafa> applecool: actually "package"
|
11:32:32
|
<rafa> applecool: the convention is to start with a lowercase
|
11:33:03
|
<rafa> applecool: so if you have a class FileUpload the default bean name is fileUpload
|
11:33:21
|
<applecool> but package cannt be used as it is a java predefined word
|
11:33:28
|
<applecool> i mean keyword
|
11:33:35
|
<applecool> am i right?
|
11:34:07
|
<rafa> applecool: correct
|
11:34:25
|
<applecool> so what shall we name it! ..
|
11:34:34
|
<applecool> pkg?
|
11:34:53
|
<applecool> na its like a variable name ..
|
11:35:11
|
<applecool> packageupload ?
|
11:35:13
|
<rafa> applecool: actually the easiest way to go will be renaming the class
|
11:35:30
|
<applecool> okay!
|
11:35:33
|
<rafa> applecool: so that we can still use default bean names
|
11:35:46
|
<rafa> applecool: let's name it MetadataPackage
|
11:36:00
|
<applecool> ooh
|
11:36:06
|
<applecool> okay
|
11:36:20
|
<applecool> Package will be MetadataPackage!
|
11:36:24
|
<applecool> .jav
|
11:36:28
|
<applecool> .java
|
11:36:29
|
<rafa> correct
|
11:36:31
|
<rafa> refactor
|
11:36:46
|
<rafa> and now our bean name will be metadataPackage
|
11:36:46
|
<applecool> ?
|
11:36:52
|
<applecool> okay
|
11:37:06
|
<applecool> Ctrl +H
|
11:37:11
|
<rafa> no
|
11:37:13
|
*** sgithens has joined #openmrs
|
11:37:28
|
<rafa> select Package.java and alt + shift + r
|
11:37:41
|
<rafa> applecool:
|
11:37:48
|
<applecool> yes yes
|
11:37:59
|
<applecool> :)
|
11:38:09
|
<applecool> dint made any wrong step :)
|
11:38:48
|
*** wyclif has joined #openmrs
|
11:39:05
|
<applecool> control+Shift+R
|
11:39:11
|
<applecool> or alt?
|
11:39:15
|
*** nwilkie has quit IRC
|
11:39:53
|
<rafa> applecool: on windows it's alt
|
11:40:13
|
<rafa> applecool: you can right click -> refactor -> rename as well ;)
|
11:40:20
|
<applecool> rafa: when you do that ! you would get matching items right?
|
11:41:01
|
<rafa> applecool: now I get the Rename Compilation Unit dialog
|
11:42:21
|
*** bwolfe has joined #openmrs
|
11:42:21
|
*** ChanServ sets mode: +o bwolfe
|
11:42:21
|
<applecool> okay!
|
11:43:35
|
<applecool> i dint get any Rename Compilation Unit dialog! :(
|
11:44:06
|
<rafa> applecool: so do it with the right click
|
11:44:20
|
<applecool> yes renamed it
|
11:44:57
|
<applecool> it is showing as a new file now!
|
11:46:13
|
<applecool> changed the class name in the file too!
|
11:49:07
|
<rafa> applecool: good
|
11:49:12
|
<rafa> applecool: does it still compile?
|
11:49:19
|
<applecool> no it wont obviously
|
11:49:29
|
<rafa> applecool: it should compile
|
11:49:41
|
<rafa> applecool: but it will still fail on tests
|
11:50:06
|
<applecool> because i need to change the Package to MetadataPackage right in the PackageDaoHibernate and so on
|
11:50:24
|
<rafa> applecool: no, when you refactor it is changed everywhere
|
11:50:58
|
<applecool> no it dint ! i dint get any option too! i just got a rename.. option
|
11:51:06
|
<applecool> when i right click!
|
11:51:14
|
<applecool> :(
|
11:51:55
|
<rafa> applecool: are you sure?
|
11:52:07
|
<applecool> yes! dint get it rafa
|
11:52:18
|
<applecool> only a rename option was there
|
11:52:26
|
<rafa> applecool: open PackageManager
|
11:52:31
|
<applecool> and even i tried on other java files too!
|
11:52:35
|
<applecool> okay
|
11:52:45
|
<rafa> applecool: do you see extends GenericManage<MetadataPackage, Long>?
|
11:52:56
|
<applecool> nope
|
11:53:01
|
<applecool> only Package
|
11:53:11
|
*** harshadura has joined #openmrs
|
11:53:13
|
<rafa> applecool: so you didn't do it right
|
11:53:16
|
<applecool> that i what i am changing! no changes on the imports too
|
11:53:23
|
<applecool> oh no
|
11:54:39
|
<rafa> applecool: did you right click Package.java -> Refactor -> Rename in your Eclipse?
|
11:54:53
|
<rafa> applecool: or something else?
|
11:55:04
|
<applecool> right click rafa
|
11:55:35
|
*** mgielow has quit IRC
|
11:55:54
|
<rafa> applecool: did you see any errors in eclipse before doing that?
|
11:56:09
|
<applecool> meaning?
|
11:56:10
|
*** bryq has joined #openmrs
|
11:56:10
|
*** ChanServ sets mode: +v bryq
|
11:56:17
|
<rafa> applecool: errors are red icons on files, packages, project
|
11:56:31
|
<applecool> no
|
11:57:05
|
<rafa> applecool: in the Rename Compilation Unit dialog did you have Update references selected?
|
11:58:06
|
*** mgielow has joined #openmrs
|
11:58:08
|
<applecool> when i select rename i am just getting a dialog box called as "Rename source" with save option thats it
|
11:58:27
|
<applecool> "Rename resource"
|
11:58:47
|
<rafa> applecool: you didn't import the project correctly to your eclipse
|
11:59:20
|
<applecool> :O
|
11:59:26
|
<rafa> applecool: we need to fix that
|
11:59:50
|
<rafa> applecool: revert all changes with git
|
12:00:24
|
<rafa> applecool: git reset --hard
|
12:00:41
|
*** dkayiwa_ has joined #openmrs
|
12:00:50
|
<applecool> doing it!
|
12:00:56
|
*** dkayiwa has quit IRC
|
12:00:56
|
*** dkayiwa_ is now known as dkayiwa
|
12:01:19
|
<applecool> done!
|
12:01:26
|
<rafa> applecool: then right click on the project in eclipse -> delete
|
12:01:38
|
<rafa> applecool: make sure delete project contents on disk is not selected
|
12:02:00
|
<applecool> okay
|
12:02:51
|
<applecool> deleted !
|
12:02:53
|
<rafa> applecool: do you have 3 metadataserver projects or just one?
|
12:03:06
|
<applecool> 3
|
12:03:17
|
<rafa> applecool: have you deleted them all?
|
12:03:24
|
<applecool> yes
|
12:03:29
|
<rafa> ok
|
12:05:28
|
<rafa> applecool: actually let me do something I wanted to do before you import again
|
12:05:46
|
<applecool> okay rafa
|
12:08:43
|
*** magoo_ has joined #openmrs
|
12:11:24
|
<rafa> applecool: how do you feel about renaming form Metadata Sharing Server to Metadata Repository? :) It's shorter and more accurate, isn't it?
|
12:11:44
|
<applecool> cool :) it is nice rafa
|
12:12:49
|
<rafa> applecool: yeah let's use this opportunity to rename
|
12:12:57
|
<rafa> applecool: give me 15 minutes :)
|
12:13:03
|
<applecool> ok :)
|
12:15:17
|
*** bryq has quit IRC
|
12:21:09
|
*** wyclif has quit IRC
|
12:31:00
|
*** mgielow has quit IRC
|
12:37:36
|
*** goutham has quit IRC
|
12:47:06
|
*** magoo_ has quit IRC
|
12:48:33
|
*** dkayiwa has quit IRC
|
12:58:59
|
<rafa> applecool: still there?
|
12:59:04
|
<applecool> yup :)
|
12:59:17
|
<rafa> applecool: sorry okay so :)
|
12:59:49
|
<rafa> applecool: do: git clone https://github.com/rkorytkowski/openmrs-contrib-metadatarepository.git
|
12:59:50
|
<applecool> actually you should not say sorry to me :)
|
12:59:56
|
<applecool> np :)
|
12:59:56
|
<OpenMRSBot> <http://ln-s.net/$FbF> (at github.com)
|
13:00:06
|
<applecool> okay i will :)
|
13:00:28
|
<rafa> then rename the folder from openmrs-contrib-metadatarepository to simply metadatarepository
|
13:01:00
|
<applecool> okay :)
|
13:01:09
|
<rafa> applecool: go to eclipse
|
13:01:24
|
<rafa> applecool: file -> import -> maven -> existing maven projects
|
13:02:12
|
<rafa> applecool: so far so good?
|
13:02:37
|
<applecool> yup :)
|
13:02:38
|
<rafa> applecool: you should be seeing the Import Maven Projects window
|
13:02:58
|
<rafa> applecool: okay browse for the metadatarepository directory
|
13:03:16
|
<applecool> do you want me to select the Add project to working set check box?
|
13:03:29
|
<rafa> applecool: do you use working sets?
|
13:03:29
|
<applecool> yea that part is done!
|
13:03:33
|
<applecool> nope!
|
13:03:34
|
<applecool> :D
|
13:03:37
|
<rafa> applecool: then no :)
|
13:03:46
|
<applecool> okay :)
|
13:03:50
|
<applecool> finish?
|
13:03:56
|
<rafa> applecool: do you see three projects?
|
13:04:01
|
<applecool> yup!
|
13:04:04
|
<rafa> applecool: go next
|
13:04:06
|
<applecool> all selected
|
13:04:14
|
<applecool> yup next!
|
13:04:17
|
*** snoppy has left #openmrs
|
13:04:18
|
<rafa> applecool: do you see any errors?
|
13:04:21
|
<applecool> nope
|
13:04:27
|
<applecool> Finish
|
13:04:28
|
<rafa> applecool: ok, go finish
|
13:04:31
|
<applecool> done
|
13:05:04
|
<rafa> applecool: do you have package explorer view?
|
13:05:21
|
<applecool> Project explorer :)
|
13:05:36
|
<applecool> yes i have it rafa :)
|
13:05:44
|
<rafa> applecool: use Package Explorer
|
13:06:32
|
<applecool> ?
|
13:06:45
|
<rafa> applecool: well Project explorer is fine too
|
13:06:54
|
<applecool> okay!
|
13:07:01
|
<rafa> applecool: try mvn clean install
|
13:07:51
|
*** magoo_ has joined #openmrs
|
13:08:54
|
<applecool> uh oh
|
13:09:08
|
<applecool> errors in db!
|
13:09:17
|
<applecool> as the atble already exists!
|
13:09:20
|
<applecool> table!
|
13:09:21
|
<rafa> applecool: that's ok
|
13:09:31
|
<applecool> okay :)
|
13:09:31
|
<rafa> applecool: it shouldn't break the build
|
13:09:38
|
<applecool> ok
|
13:10:39
|
*** wyclif has joined #openmrs
|
13:13:44
|
*** djazayeri has joined #openmrs
|
13:13:44
|
*** ChanServ sets mode: +o djazayeri
|
13:14:16
|
<rafa> applecool: success?
|
13:14:57
|
<applecool> success
|
13:15:20
|
<applecool> :)
|
13:15:30
|
<rafa> applecool: ok now try renaming Package.java
|
13:15:39
|
<rafa> applecool: use the Project Explorer view
|
13:16:01
|
<rafa> applecool: remember right click -> refactor -> rename
|
13:16:31
|
<rafa> applecool: update references needs to be selected
|
13:16:39
|
<applecool> :( no option
|
13:17:17
|
<rafa> applecool: hmmm
|
13:17:27
|
<rafa> applecool: you need to go through metadatarepository-core
|
13:17:34
|
<rafa> applecool: not the main project
|
13:17:50
|
<applecool> got it!
|
13:18:19
|
<applecool> ok selected refractor ->rename
|
13:18:21
|
<rafa> applecool: ahh that was the mistake :/
|
13:18:23
|
<applecool> got an dialog
|
13:18:30
|
<applecool> seriously! :(
|
13:18:34
|
<applecool> blunder! :(
|
13:18:38
|
<rafa> applecool: you shouldn't work with the main project
|
13:18:49
|
<applecool> hm! got it rafa :)
|
13:18:50
|
<rafa> applecool: always work with core or web
|
13:18:56
|
<applecool> okay :)
|
13:19:04
|
<rafa> applecool: the main project is only there to edit pom.xml
|
13:19:13
|
<applecool> okay
|
13:19:34
|
<applecool> now only update references should be selected right?
|
13:19:38
|
<rafa> applecool: right
|
13:19:40
|
<applecool> nothing else
|
13:20:02
|
<applecool> changing Package to MetadataPackage
|
13:20:05
|
<applecool> right?
|
13:20:14
|
<rafa> right
|
13:20:53
|
<rafa> applecool: you'll also need to change one thing in packageform.jsp
|
13:21:14
|
*** mgielow has joined #openmrs
|
13:21:23
|
<rafa> applecool: your bean is now metadataPackage not package, thus <form:form commandName must say "metadataPackage"
|
13:21:26
|
*** dkayiwa has joined #openmrs
|
13:21:45
|
<rafa> applecool: <form:form commandName="metadataPackage"
|
13:22:13
|
<rafa> applecool: when you change that try running mvn clean install again
|
13:22:23
|
<rafa> applecool: to make sure tests still pass
|
13:22:24
|
*** mseaton has joined #openmrs
|
13:22:24
|
*** ChanServ sets mode: +v mseaton
|
13:22:35
|
<applecool> okay :)
|
13:28:25
|
<applecool> rafa: i need to remove FileUpload.java right?
|
13:28:30
|
<applecool> delete!
|
13:28:35
|
<rafa> applecool: wait
|
13:28:39
|
<applecool> ok
|
13:28:47
|
<rafa> applecool: tests pass now?
|
13:29:17
|
<applecool> no dint run it yet ! just asked you before hand! will do it and tell you! give me a minute
|
13:30:05
|
<rafa> applecool: don't change anything before you have all tests passing
|
13:30:12
|
<applecool> okay
|
13:30:27
|
<rafa> applecool: commit, push and then you can continue with changes
|
13:30:42
|
<rafa> applecool: yes, you'll remove FileUpload
|
13:31:01
|
<applecool> okay :)
|
13:37:28
|
<applecool> i guess in hibernate-cfg.xml file this also should be changed <mapping class="org.openmrs.contrib.metadatarepository.model.Package"/> to <mapping class="org.openmrs.contrib.metadatarepository.model.MetadataPackage"/>
|
13:37:31
|
<applecool> right? rafa
|
13:37:55
|
<rafa> applecool: right
|
13:38:01
|
<rafa> and in persistance.xml
|
13:38:09
|
<applecool> yes :)
|
13:38:30
|
*** magoo_ has joined #openmrs
|
13:42:53
|
*** djazayeri has quit IRC
|
13:46:38
|
<applecool> rafa: there?
|
13:46:44
|
<rafa> applecool: yes
|
13:46:47
|
<applecool> http://pastebin.com/eLqFzwsp
|
13:46:55
|
<applecool> got the same error HTTP !
|
13:47:09
|
<applecool> i changed the fileupload.jsp! too
|
13:47:40
|
<applecool> <spring:bindpath="metadataPackage.*"> right?
|
13:47:54
|
<rafa> applecool: not yet
|
13:48:17
|
<rafa> applecool: Remember we reverted your changes?
|
13:48:23
|
<applecool> yes!
|
13:48:37
|
*** pulasthi7 has joined #openmrs
|
13:48:43
|
<rafa> applecool: you need to change controller again
|
13:48:47
|
<applecool> i made all the changes as did before!
|
13:48:56
|
<applecool> FileUpploadController right?
|
13:49:09
|
<rafa> applecool: I asked you not to change
|
13:49:16
|
<rafa> applecool: before you have all tests passing
|
13:50:01
|
<rafa> applecool: when you refactor you can do only one change and then you must make sure all tests pass
|
13:50:13
|
<rafa> applecool: you can't do more changes unless you have passing tests
|
13:50:56
|
<applecool> i have all the tests passed!
|
13:51:15
|
<rafa> applecool: ok good
|
13:51:21
|
<rafa> applecool: did you commit?
|
13:51:30
|
<applecool> okay let me check once again! i will revert them back and then i will run the tests again!
|
13:51:34
|
<applecool> no i dint commit it
|
13:52:04
|
<rafa> applecool: commit and push
|
13:52:45
|
<applecool> one second! i dint get clarity!
|
13:52:56
|
<applecool> first
|
13:53:14
|
<applecool> when i refracted the file! ie i made the package to MetadataPackage
|
13:53:24
|
<applecool> it changed it everywhere!
|
13:53:49
|
<applecool> except the FileUploadController.java
|
13:54:22
|
<rafa> applecool: correct
|
13:54:25
|
<applecool> and some files like persistence.xml and hibernate-cfg.xml and packageform.jsp
|
13:54:36
|
<applecool> which i need to change!
|
13:54:43
|
<rafa> applecool: then you should have run tests and you would see them failing
|
13:54:50
|
<applecool> yes!
|
13:55:09
|
<rafa> applecool: at that point you can only make changes for the tests to pass
|
13:55:33
|
<rafa> applecool: so first you need to change persistance.xml and hibernate-cfg.xml
|
13:55:38
|
<applecool> okay!
|
13:55:39
|
<rafa> applecool: run tests again :)
|
13:56:01
|
<rafa> applecool: you'd see api and web tests passing, but integration tests failing
|
13:56:15
|
<magoo_> dkayiwa i have followed the instruction on how to step maven as you can see url http://pastebin.com/quf83ySz
|
13:56:39
|
<applecool> so i need to revert back the changes in the packageform.jsp
|
13:56:42
|
<applecool> or let them be?
|
13:56:44
|
*** downey has joined #openmrs
|
13:56:44
|
*** ChanServ sets mode: +o downey
|
13:56:44
|
*** OpenMRSBot sets mode: +o downey
|
13:56:49
|
<rafa> applecool: then you would correct packageform.jsp
|
13:57:02
|
<magoo_> dkayiwa but when i run the command maven --version on command line
|
13:57:05
|
<rafa> applecool: and run tests again
|
13:57:09
|
<applecool> okay! so it should be fileUpload.* it self
|
13:57:56
|
<rafa> applecool: if tests finally pass you commit and push
|
13:57:56
|
<magoo_> dkayiwa according to the command it seem that i have not installed maven
|
13:58:19
|
<magoo_> dkayiwan can you help
|
13:58:46
|
<rafa> applecool: you sholdn't have touched fileupload.jsp
|
13:58:55
|
<rafa> applecool: it didn't cause tests to fail
|
14:00:19
|
<rafa> applecool: it's how we do refactoring :) do one change, run tests and make them pass as soon as possible
|
14:00:26
|
*** venkaban has joined #openmrs
|
14:00:30
|
<applecool> rafa: okay :) i actually thought to do the entire thing and then commit!
|
14:00:37
|
<applecool> cool :)
|
14:00:42
|
<rafa> applecool: no other refactoring is allowed before you make tests pass
|
14:00:47
|
<applecool> got it ! didnt know that
|
14:01:01
|
*** cpower has joined #openmrs
|
14:01:16
|
<rafa> applecool: it's ok
|
14:01:41
|
<cpower> Good morning everyone!
|
14:01:42
|
<magoo_> dkayiwa but when i check on my pc according to the following wiki https://wiki.openmrs.org/display/docs/Using+the+Module+Maven+Archetype
|
14:01:43
|
<OpenMRSBot> <http://ln-s.net/9$wo> (at wiki.openmrs.org)
|
14:01:50
|
*** wyclif has joined #openmrs
|
14:02:00
|
<rafa> applecool: I hope you see a benefit of doing it that way
|
14:02:20
|
<cpower> Are we ready for a great productive day?
|
14:02:30
|
<magoo_> dkayiwa i can the \.m2 folder
|
14:02:49
|
<applecool> rafa: :)
|
14:03:04
|
<applecool> i ran the tests ! all tests passed!
|
14:03:11
|
<applecool> but ultimately build failed!
|
14:03:13
|
<applecool> http://pastebin.com/icUVtPag
|
14:03:18
|
<applecool> here is the stack trace
|
14:03:29
|
<applecool> please check ! if its good i will commit and push!
|
14:03:33
|
<cpower> In a random statement, has anyone played Wii fit? If they did I'm begining to feel like the corny Wii board avatar in my comments.
|
14:04:18
|
<cpower> Oook let's Scrum
|
14:04:24
|
<cpower> !scrumon cpower
|
14:04:24
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
14:04:43
|
<bwolfe> cpower: encouraging us to shed pounds of bugs every day
|
14:05:23
|
<cpower> Order: Wyclif, bwolfe, rafa, mseaton (maybe), dkayiwa, and our new dev venkaban!
|
14:05:26
|
<applecool> rafa: is it good?
|
14:05:34
|
<rafa> applecool: hold on
|
14:05:45
|
<applecool> okay
|
14:06:20
|
<wyclif> ok
|
14:06:22
|
<venkaban> cpower: completed ticket TRUNK 3378 and created a patch. No Blockers
|
14:06:43
|
<wyclif> Tuesday:
|
14:06:43
|
<wyclif> * Catch up with email back log from monday
|
14:06:43
|
<wyclif> * CALC-37 - Get rid of the registration package
|
14:06:43
|
<wyclif> * CALC-36 - Get rid of EmptyCalculationResult
|
14:06:43
|
<wyclif> * CALC-33 - Get rid of Evaluators
|
14:06:44
|
<wyclif> * Update the wiki page at https://wiki.openmrs.org/display/docs/Calculation+Module
|
14:06:48
|
<wyclif> Wednesday:
|
14:06:50
|
<wyclif> * listened into the openmrs university via connect
|
14:06:52
|
<wyclif> * design call
|
14:06:54
|
<wyclif> * Calculation sprint tickets
|
14:06:56
|
<wyclif> Blockers: None
|
14:07:03
|
*** jordank has joined #openmrs
|
14:07:45
|
<bwolfe> oh whoops, suppose thats me
|
14:07:54
|
<bwolfe> was sitting here thinking "whos next!?"
|
14:08:00
|
<bwolfe> Tuesday
|
14:08:00
|
<bwolfe> emails
|
14:08:00
|
<bwolfe> 1.9 test
|
14:08:00
|
<bwolfe> restws-257
|
14:08:00
|
<bwolfe> find projects for NCSU students
|
14:08:01
|
<bwolfe> restws reviews and more tickets
|
14:08:03
|
<bwolfe> (design forum planning...or leave that for cpower+kreddy?)
|
14:08:05
|
<bwolfe> Wednesday
|
14:08:07
|
<bwolfe> review code for suranga
|
14:08:09
|
<bwolfe> email catchup
|
14:08:11
|
<bwolfe> univ call
|
14:08:13
|
<bwolfe> docs for restws
|
14:08:17
|
<bwolfe> last minute setup for design call
|
14:08:19
|
<bwolfe> design call
|
14:08:21
|
<bwolfe> pm call
|
14:08:23
|
<bwolfe> no blockers
|
14:08:29
|
<rafa> Today:
|
14:08:30
|
<rafa> * Started later today to join the design call
|
14:08:30
|
<rafa> * Mentoring duties...
|
14:08:30
|
<rafa> * Reviewed some sprint tickets
|
14:08:30
|
<rafa> * Trying to get back to coding and finish RESTWS-260 - Add getResourceVersion property
|
14:08:30
|
<rafa> * More sprint tickets
|
14:08:30
|
<rafa> No blockers.
|
14:09:56
|
<bwolfe> mseaton?
|
14:10:03
|
<bwolfe> (I don't htink he's sprinting this week)
|
14:10:09
|
<bwolfe> dkayiwa, you can go
|
14:10:12
|
*** snoppy has joined #openmrs
|
14:10:18
|
<dkayiwa> Tagged 1.9.0
|
14:10:18
|
<dkayiwa> Did some small rudimentary testing
|
14:10:18
|
<dkayiwa> Uploaded maven artifacts to nexus
|
14:10:19
|
<dkayiwa> Built and uploaded files to sourceforge
|
14:10:19
|
<dkayiwa> Finished release notes page
|
14:10:19
|
<dkayiwa> Tagged the latest for autobuilding the demo server
|
14:10:20
|
<dkayiwa> Now creating releasing blog and after which send out release email
|
14:10:20
|
<dkayiwa> No Blockers
|
14:11:23
|
<bwolfe> dkayiwa, keep downey in the loop for any changes he needs to do for 1.9
|
14:11:23
|
*** djazayeri has joined #openmrs
|
14:11:23
|
*** ChanServ sets mode: +o djazayeri
|
14:11:35
|
<dkayiwa> bwolfe: like what?
|
14:11:46
|
<bwolfe> venkaban already went. so djazayeri you're the last to go.
|
14:11:58
|
<djazayeri> All week
|
14:12:04
|
<djazayeri> * at planning meetings with TW
|
14:12:05
|
<bwolfe> dkayiwa, dunno, but there is always "secret sauce" that downey sprinkles on everything
|
14:12:25
|
<dkayiwa> bwolfe: he will then have to tell me what that is :)
|
14:12:38
|
<dkayiwa> bwolfe: for am not yet aware of anything i need to tell him :)
|
14:13:44
|
<downey> bwolfe dkayiwa - looking at https://wiki.openmrs.org/display/docs/Release+Process i think the "Major Release" section is not complete/accurate.
|
14:14:20
|
<dkayiwa> downey: what does it miss? :)
|
14:14:29
|
<downey> i'll tell you after the scrum :)
|
14:14:37
|
<dkayiwa> downey: ok :)
|
14:14:45
|
<bwolfe> did we lose cpower?
|
14:14:53
|
<dkayiwa> downey: that will help me know what am missing :D
|
14:14:58
|
*** downey sets mode: +v cpower
|
14:15:03
|
* bwolfe resists making "we need more power" statement in a scottish accent
|
14:15:44
|
<bwolfe> I see no blockers and no discussion points
|
14:15:49
|
<bwolfe> !scrumoff
|
14:15:49
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
14:16:01
|
<bwolfe> ... !scrummary business as usual
|
14:16:08
|
*** djazayeri has quit IRC
|
14:16:15
|
<bwolfe> venkaban, are you working on the next ticket that I had mailed to you?
|
14:16:38
|
<downey> bwolfe: http://morepower.jpg.to/
|
14:17:10
|
<downey> dkayiwa: two things i noticed immediately were updating the http://openmrs.org/download/ page and updating the "latest/default" downloads on source forge project
|
14:17:13
|
<cpower> sorry I got distracted by a Burke
|
14:17:20
|
<venkaban> bwolfe Yes
|
14:17:53
|
<dkayiwa> downey: ok
|
14:18:15
|
<downey> dkayiwa: i'd also add a line for arranging "advertising" on Twitter, Facebook, Google+, etc. :)
|
14:18:35
|
<dkayiwa> downey: are you going to add that? :)
|
14:18:54
|
<cpower> bwolfe, funny
|
14:19:16
|
<cpower> I apologize I was wearing a red shirt for a couple minutes
|
14:19:22
|
<bwolfe> dkayiwa, see! secret sauce. :-D
|
14:19:35
|
<dkayiwa> bwolfe: :)
|
14:19:36
|
<downey> dkayiwa: also, once the "latest" tag is updated we should re-deploy the demo site.
|
14:19:49
|
<dkayiwa> downey: isnt that automatic?
|
14:19:52
|
<downey> dkayiwa: and it should also mention posting the new major release demo data on the wiki "Demo Data" page
|
14:20:12
|
<downey> dkayiwa: it is automatic but only once per day. and once the download is posted people will probably want to see the new version rather immediately :)
|
14:20:26
|
<dkayiwa> downey: it is already updated even now :)
|
14:20:45
|
<downey> dkayiwa: yeah i noticed that earlier when i redeployed it :)
|
14:20:58
|
<dkayiwa> downey: :)
|
14:21:05
|
* downey figures the sauce is no longer secret
|
14:21:12
|
<bwolfe> dkayiwa, how did you end up generating the tag, etc? can you document your steps somewhere on the wiki? (and add comment about whether it was easy or not)
|
14:21:32
|
*** jordank has left #openmrs
|
14:21:37
|
<dkayiwa> bwolfe: i read the steps from the wiki :)
|
14:21:44
|
*** jordank has joined #openmrs
|
14:21:50
|
<dkayiwa> bwolfe: the manual alternative :)
|
14:22:01
|
<downey> cpower: you definitely don't want to be a red shirt, if you plan to survive long
|
14:22:20
|
<bwolfe> dkayiwa, ok, so you just uploaded the war after rebuilding with the right versions in the poms, etc?
|
14:22:44
|
<dkayiwa> bwolfe: yes
|
14:23:04
|
<cpower> downey, yeah I'm talking to my agent...they tell me next season I might get to move up to a gold or blue shirt if I survive long enough
|
14:23:14
|
<downey> cpower: congrats
|
14:24:34
|
<cpower> So do we have any implementers in the room?
|
14:25:03
|
<bwolfe> mseaton can be considered an impl
|
14:25:43
|
<mseaton> hi
|
14:27:09
|
<magoo_> dkayiwa
|
14:28:50
|
<cpower> mseaton, Hello! I was just curious more than anything if there was. You are already working with Kiran to get your topics heard (right?) and scheduled up for sprints in the future
|
14:28:57
|
<applecool> rafa:
|
14:29:11
|
<rafa> applecool: have you pushed?
|
14:29:37
|
<applecool> no! yo u told me to wait right? so i was waiting for your reply
|
14:30:10
|
<magoo_> am getting this error msg when i run the command mvn url http://pastebin.com/VBgaCSYk can someone help
|
14:30:20
|
<rafa> applecool: so what error you get right now?
|
14:30:51
|
<applecool> http://pastebin.com/icUVtPag
|
14:30:56
|
<applecool> same rafa!
|
14:31:11
|
<magoo_> another thing am i supposed to type maven or mvn
|
14:31:16
|
<mseaton> hi cpower. bwolfe means i work for pih and represent a lot of our implementation needs. but i'm firmly a developer. i'm not sure i qualify for what you are looking for... but yes, i'm an activist for what pih needs from openmrs and bring resources to bear on that.
|
14:31:30
|
<applecool> if you want me to go ahead and commit and push ! i will do it!
|
14:31:37
|
<applecool> then i will make the changes!
|
14:31:38
|
<mseaton> and will be engaged with kiran, et al
|
14:31:42
|
<applecool> as you told before!
|
14:32:02
|
<rafa> applecool: commit and push I need to see the code
|
14:32:07
|
<applecool> ok
|
14:32:12
|
<bwolfe> mseaton, would it be better to get your implementers at your sites in touch with kiran instead (or as well as) ?
|
14:32:48
|
<mseaton> bwolfe. not really, no.
|
14:33:03
|
<cpower> mseaton, fair enough.. My goal is just to make sure we are reaching out to you (when you are wearing your PIH hat) and tell you to get anyone else that should have a voice there in touch with Kiran and I.
|
14:33:21
|
<cpower> mseaton, simply put we are here for you!
|
14:33:26
|
<cpower> :-)
|
14:34:13
|
<applecool> rafa: done
|
14:35:15
|
<applecool> rafa: i just made a spelling mistake in the commit message! apologies!
|
14:35:19
|
<rafa> applecool: okay looks good
|
14:35:45
|
<mseaton> cpower - thanks :)
|
14:36:03
|
<rafa> applecool: modify fileupload.jsp
|
14:36:20
|
<applecool> what about the packageform?
|
14:36:24
|
<rafa> applecool: too
|
14:36:41
|
<rafa> applecool: but first fileupload.jsp and run the tests
|
14:36:48
|
<cpower> now I go disclaimer... When I say "we" I mean Kiran and I, and then the community upon agreement to to do the work as prioritized by.... ;-)
|
14:36:51
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @stemail23: Just finished up at #OpenMRS inaugural Sydney gathering. Looks promising. http://t.co/crLvUvl2 <http://twitter.com/OpenMRS/statuses/210376805964726272> || On Twitter: OpenMRS: @icebrk If you're using MySQL, did you set a password for "root" user? If you post your question at http://t.co/THrmxuE5 we can help more. <http://twitter.com/OpenMRS/statuses/210376595054145536>
|
14:37:04
|
<rafa> applecool: I want you to learn to run tests often :)
|
14:37:16
|
<applecool> in fileupload! i should change only one line right?
|
14:37:27
|
*** mgielow has quit IRC
|
14:37:29
|
<rafa> applecool: I won't tell you
|
14:37:36
|
<applecool> ;)
|
14:37:38
|
<rafa> applecool: change what you think you need to change and run tests ;)
|
14:37:53
|
*** dkayiwa has quit IRC
|
14:40:33
|
*** harshadura has quit IRC
|
14:40:57
|
*** magoo_ has quit IRC
|
14:52:47
|
<rafa> applecool: how is it going?
|
14:53:04
|
<applecool> :D
|
14:53:27
|
<applecool> i got an error in fileupload.jsp! so checking it! :D running again!
|
14:53:48
|
<applecool> all tests are passed! except fileupload! :D
|
15:00:03
|
<applecool> rafa: got error again!
|
15:00:24
|
<rafa> applecool: what is the error?
|
15:00:41
|
<applecool> same one as before
|
15:01:04
|
<rafa> applecool: you're still trying to access non existing bean fileUpload, right?
|
15:01:20
|
<rafa> applecool: see line 27
|
15:01:30
|
<rafa> applecool: it states <form:form commandName="fileUpload"
|
15:01:57
|
<applecool> you meant in the packageform right?
|
15:01:58
|
<rafa> applecool: commandName = use fileUpload bean for this form
|
15:02:05
|
<rafa> applecool: no in the fileupload
|
15:02:41
|
<applecool> oh! damn!
|
15:02:47
|
*** magoo_ has joined #openmrs
|
15:04:42
|
<applecool> i changed that already in packageform and didnt change in fiileupload! crass!
|
15:05:00
|
<applecool> i am running again!
|
15:09:30
|
<applecool> whoops! error again!
|
15:10:28
|
<applecool> rafa: without modifying FileUploadController.java how will i be able to pass the test!
|
15:10:52
|
<applecool> and even MetadataPackage.java is also not changed!
|
15:11:37
|
<rafa> applecool: you must modify them :)
|
15:11:50
|
<applecool> hmm
|
15:13:08
|
*** magoo_ has quit IRC
|
15:13:09
|
<rafa> applecool: MetadataPackage is modified already, right?
|
15:13:21
|
<applecool> yeah yeah! it is
|
15:13:21
|
<rafa> applecool: you added byte[] file
|
15:13:25
|
<applecool> yes yes
|
15:13:27
|
<applecool> :D
|
15:14:43
|
<rafa> applecool: and don't forget to remove FileUpload.java ;)
|
15:16:49
|
<applecool> aaaaaaahhh successs!
|
15:17:13
|
<applecool> i was confused by this line rafa rafa: applecool: but first fileupload.jsp and run the tests
|
15:17:21
|
<applecool> which u have told me earlier!
|
15:17:59
|
<applecool> that is y i was whacking my brain without changing the FileUploadController.java! :D
|
15:18:35
|
<rafa> applecool: ohh I wanted to trick you to run tests often :D
|
15:18:54
|
<applecool> haha! anyways learnt nice lessons! :D
|
15:19:01
|
<applecool> you have thrown a curve ball! :D
|
15:19:11
|
<applecool> good teacher rafa :)
|
15:19:36
|
<rafa> applecool: haha good student :D
|
15:19:45
|
<applecool> ;) Thanks!
|
15:20:03
|
*** maurya has quit IRC
|
15:20:08
|
<applecool> i m just running once again the entire project! then i will commit and push! :)
|
15:20:26
|
<rafa> applecool: great! 2nd task done right?
|
15:21:32
|
<applecool> yup :)
|
15:21:54
|
*** nwilkie has joined #openmrs
|
15:22:17
|
<applecool> rafa: no no! you also have mentioned to get rid of the name fileupload
|
15:22:21
|
<applecool> fileupload.jsp
|
15:22:34
|
<rafa> ohh yes :)
|
15:22:45
|
<rafa> but commit and push right now anyway
|
15:22:54
|
<applecool> okay ;)
|
15:23:08
|
<applecool> again i need to do refractoring i guess! :D
|
15:24:14
|
*** kavuri has joined #openmrs
|
15:25:01
|
<applecool> rafa: suggestion for commit message! should i give "Removed FileUpload" or "Fixed fileupload tests"
|
15:26:42
|
*** sunbiz has joined #openmrs
|
15:26:42
|
*** ChanServ sets mode: +v sunbiz
|
15:26:44
|
<rafa> applecool: any meaningful commit message will do so don't think too much on that :) removed is fine
|
15:26:45
|
<applecool> i am going ahead with "modified FileUploadController" :)
|
15:26:58
|
<rafa> applecool: good as well :)
|
15:29:40
|
*** dkayiwa has joined #openmrs
|
15:31:14
|
<applecool> rafa: committed and pushed ;)
|
15:32:43
|
<sunbiz> bwolfe: is text/json the right mime type??
|
15:32:51
|
<sunbiz> I think its application/json
|
15:33:34
|
<sunbiz> bwolfe: Im referring to the page change that you made... u wrote text/json
|
15:34:00
|
<applecool> rafa: there?
|
15:34:34
|
<rafa> applecool: yes, but going to have some dinner
|
15:34:58
|
<applecool> ok just a sec! i have a doubt!
|
15:35:03
|
<rafa> applecool: yes?
|
15:35:05
|
<applecool> did you create a new repo?
|
15:35:18
|
<rafa> applecool: I renamed the old one
|
15:35:40
|
<rafa> applecool: so all previous commits are still there
|
15:35:49
|
<rafa> applecool: but you need to access it with a new link
|
15:35:50
|
<bwolfe> sunbiz, hmm, might be.
|
15:36:05
|
<applecool> okay! because whenever i try to push ! it used to ask me only for password! but it is asking me the username too!
|
15:36:11
|
<applecool> so asked you :)
|
15:36:13
|
<sunbiz> bwolfe: a lot of ppl use text/x-json, but its not the
|
15:36:28
|
<applecool> rafa: okay! yeah new link! how do i get that!
|
15:36:35
|
<rafa> applecool: ohh you can give your username in the url
|
15:36:37
|
<sunbiz> standard accepted way
|
15:36:50
|
<rafa> applecool: the url is https://github.com/rkorytkowski/openmrs-contrib-metadatarepository
|
15:36:55
|
<OpenMRSBot> <http://ln-s.net/$FfD> (at github.com)
|
15:37:41
|
<bwolfe> applecool, does your keyboard have a period? :-D
|
15:37:54
|
<applecool> period? ?
|
15:38:32
|
<applecool> bwolfe: i dint get you :)
|
15:39:26
|
<applecool> ?
|
15:39:35
|
<bwolfe> applecool, I'm just looking back at all your recent posts and they all end with exclamation points. :-)
|
15:39:54
|
<bwolfe> applecool, I'm often times excited to work with rafa too. so I understand!
|
15:40:03
|
<applecool> haha ;)
|
15:40:28
|
<applecool> i donno it became a habit to give an exclamation at the end "!"
|
15:40:35
|
<applecool> bwolfe: haha :D
|
15:40:52
|
<applecool> rafa i will see you later ; have great food :)
|
15:45:28
|
*** cpower has quit IRC
|
15:48:16
|
*** maurya has joined #openmrs
|
15:49:05
|
*** nwilkie has quit IRC
|
15:50:04
|
*** pushkar has quit IRC
|
15:51:53
|
*** bryq has joined #openmrs
|
15:51:53
|
*** ChanServ sets mode: +v bryq
|
15:52:34
|
*** mseaton has quit IRC
|
15:52:46
|
*** mseaton has joined #openmrs
|
15:52:46
|
*** ChanServ sets mode: +v mseaton
|
15:54:35
|
*** applecool has quit IRC
|
15:58:55
|
*** kavuri has quit IRC
|
15:59:22
|
*** mccallumg has joined #openmrs
|
15:59:22
|
*** ChanServ sets mode: +v mccallumg
|
16:00:06
|
*** applecool has joined #openmrs
|
16:01:32
|
*** kavuri has joined #openmrs
|
16:06:58
|
<sunbiz> bwolfe: do u know how to use person attribute searchable thing??
|
16:07:06
|
<sunbiz> there was question posted to the list
|
16:07:09
|
<sunbiz> by one of the interns
|
16:07:44
|
<sunbiz> bwolfe: so when adding a person attribute, we can checkbox searchable
|
16:08:38
|
*** harshadura has joined #openmrs
|
16:09:29
|
<sunbiz> how does someone search a person by this attribute??
|
16:09:53
|
<downey> sunbiz: i think bwolfe is at lunch at the moment, fyi
|
16:10:08
|
<sunbiz> okies...
|
16:10:12
|
*** suranga has joined #openmrs
|
16:10:12
|
*** ChanServ sets mode: +v suranga
|
16:10:14
|
<sunbiz> downey: do u know the answer to that??
|
16:10:41
|
*** harshadura has quit IRC
|
16:11:16
|
<downey> sunbiz: i'm not sure that there's any simple way to do that. dkayiwa, rafa, wyclif - ping, see above question
|
16:12:13
|
*** kreddy has joined #openmrs
|
16:13:37
|
<suranga> hi pulasthi7
|
16:13:48
|
<suranga> pulasthi7, I just signed in
|
16:16:20
|
*** Echidna has quit IRC
|
16:16:21
|
*** Echidna_ has joined #openmrs
|
16:17:24
|
<pulasthi7> hi suranga,
|
16:17:50
|
<pulasthi7> i had a discussion with james about that
|
16:18:04
|
<suranga> pulasthi7, aaah, pretty cool....
|
16:18:24
|
<suranga> pulasthi7, its in the logs, i guess. I should read it up.. mm/// what happened ?
|
16:19:16
|
*** sgithens has quit IRC
|
16:20:15
|
*** venkaban has quit IRC
|
16:21:13
|
<pulasthi7> suranga, not actualy, there was some discussion going on so had to use private chat.
|
16:21:38
|
<suranga> pulasthi7, oh, I see, I was actually looking for it...
|
16:21:59
|
<pulasthi7> suranga, i'll send you the log
|
16:22:10
|
<suranga> pulasthi7, coool
|
16:23:49
|
*** dkayiwa has quit IRC
|
16:26:23
|
*** dkayiwa has joined #openmrs
|
16:27:26
|
*** Mkop has quit IRC
|
16:27:51
|
*** applecool has quit IRC
|
16:28:06
|
*** Mkop has joined #openmrs
|
16:28:06
|
*** ChanServ sets mode: +v Mkop
|
16:31:38
|
*** djazayeri has joined #openmrs
|
16:31:38
|
*** ChanServ sets mode: +o djazayeri
|
16:37:02
|
<suranga> pulasthi7, hmm... this is intresting news
|
16:37:18
|
<suranga> pulasthi7, and very good news too, as I see :-)
|
16:37:26
|
*** venkaban has joined #openmrs
|
16:38:01
|
*** venkaban has joined #openmrs
|
16:39:57
|
*** applecool has joined #openmrs
|
16:42:09
|
<pulasthi7> suranga, james said that he doesn't know about the attributes in message.properties file, do you have any idea on it.
|
16:42:33
|
<pulasthi7> i'm trying to figure out that
|
16:42:40
|
<suranga> pulasthi7, thats what I was looking at too...
|
16:42:51
|
<suranga> pulasthi7, im afraid Im rather new to it myself...
|
16:43:30
|
<suranga> pulasthi7, so basically, we have resolved the problem for everything thats not an attribute, isnt it ?
|
16:45:37
|
<pulasthi7> suranga, yes. i have something to start with now
|
16:46:43
|
<suranga> pulasthi7, at a very basic level, the only problem we have now is with attributes that are displayed on the 'create new configuration' page, but are not included in the properties file, isnt it ?
|
16:46:46
|
*** djazayeri has quit IRC
|
16:48:50
|
<pulasthi7> suranga, as james said they are not related to this i guess.
|
16:50:26
|
<pulasthi7> suranga, according to him we have nothing to do with the properties file
|
16:50:46
|
<pulasthi7> or at least it will be expensive
|
16:54:27
|
<suranga> pulasthi7, I've re-read the email again. so if I've got it correctly, our only major problem is how to map patient attributes, is it ?
|
16:56:33
|
<pulasthi7> suranga, yes, that's the problem now
|
16:57:57
|
<suranga> pulasthi7, we can try this - first, create two threads in your head, assign a higher priority to one, and get focus that on getting this working with the exsisting mappings... but also create a second damien thread, and have that worry about the patient attributes
|
16:58:45
|
<suranga> pulasthi7, I will also try to figure this out from my end...
|
16:59:02
|
*** harshadura has joined #openmrs
|
17:04:57
|
<kreddy> bwolfe, Hi
|
17:07:13
|
*** sunbiz1 has joined #openmrs
|
17:10:28
|
*** sunbiz has quit IRC
|
17:12:00
|
*** kavuri has quit IRC
|
17:13:12
|
<bwolfe> hey kreddy
|
17:13:14
|
<bwolfe> what sup?
|
17:13:25
|
<kreddy> bwolfe,
|
17:14:02
|
<kreddy> I am trying to edit the sprint schedule page but i dont see the table when i click on edit
|
17:15:01
|
<bwolfe> are you on the text-only view?
|
17:15:04
|
<bwolfe> its probalby in the wiki text
|
17:15:15
|
<bwolfe> ther eis a tab at the top to do in wysiwyg editor
|
17:22:12
|
*** applecool has quit IRC
|
17:31:18
|
<suranga> hi snoppy !
|
17:31:42
|
<suranga> snoppy, I see that you have been going through them tickets at a rapid pace :)
|
17:35:32
|
*** sunbiz1 has left #openmrs
|
17:41:03
|
*** kavuri has joined #openmrs
|
17:42:49
|
*** harshadura_ has joined #openmrs
|
17:44:18
|
*** harshadura has quit IRC
|
17:44:29
|
*** harshadura_ is now known as harshadura
|
17:45:47
|
*** goutham has joined #openmrs
|
17:47:39
|
*** dkayiwa_ has joined #openmrs
|
17:48:39
|
*** dkayiwa has quit IRC
|
17:48:39
|
*** dkayiwa_ is now known as dkayiwa
|
17:53:25
|
*** harshadura has quit IRC
|
18:04:26
|
*** wyclif has quit IRC
|
18:15:49
|
*** mseaton has quit IRC
|
18:19:10
|
*** james_regen has quit IRC
|
18:19:30
|
*** wyclif has joined #openmrs
|
18:29:02
|
<suranga> mm... hi pulasthi7 ..
|
18:29:25
|
*** mseaton has joined #openmrs
|
18:29:25
|
*** ChanServ sets mode: +v mseaton
|
18:34:46
|
*** mvorobey has joined #openmrs
|
18:34:58
|
<mvorobey> hi all
|
18:36:00
|
<mvorobey> rafa, hi
|
18:36:19
|
<rafa> mvorobey: hi
|
18:36:47
|
*** djazayeri has joined #openmrs
|
18:36:47
|
*** ChanServ sets mode: +o djazayeri
|
18:37:31
|
<mvorobey> rafa, just FYI, am going to do couple of tickets on current sprint, actually I picked up TRUNK-3324
|
18:37:44
|
<rafa> mvorobey: great
|
18:38:04
|
<mvorobey> rafa, are you sprint leader, yes ?
|
18:38:12
|
<rafa> mvorobey: yes
|
18:38:28
|
<mvorobey> rafa, awesome, then I did everything right :)
|
18:38:43
|
<rafa> mvorobey: :)
|
18:39:08
|
<mvorobey> rafa, I have one question on that ticket, would you like to answer ?
|
18:39:25
|
<rafa> mvorobey: I'll try
|
18:40:08
|
*** kavuri has quit IRC
|
18:40:36
|
<mvorobey> rafa, so, Ticket description says "Check that the drug is not null of the concept is not set", what is this supposed to mean ?
|
18:40:51
|
<mvorobey> maybe of = or ?
|
18:41:06
|
<rafa> mvorobey: yes :)
|
18:41:19
|
<rafa> it should be or
|
18:42:00
|
<rafa> mvorobey: corrected now
|
18:42:09
|
<mvorobey> rafa, do you also have any other validation rules in mind for drug orders ?
|
18:43:40
|
<rafa> mvorobey: I can't think of more
|
18:44:08
|
<mvorobey> rafa, so, anything ?
|
18:44:19
|
<rafa> mvorobey: probably if units are set you need to provide quantity or dose or equivalentDailyDose
|
18:44:54
|
<rafa> or prn
|
18:45:03
|
<mvorobey> rafa, ok, will investigate into that, thanks :)
|
18:45:33
|
*** djazayeri has quit IRC
|
18:46:49
|
<mvorobey> rafa, offtopic question : how to enable save button on http://localhost:8080/openmrs/admin/maintenance/globalProps.form page ? :)
|
18:47:21
|
<rafa> mvorobey: by making some change?
|
18:48:22
|
<mvorobey> rafa, is it ? I made a change, but no button appears for me until I tried to add new property, only thereafter yellow box was shown for me :)
|
18:49:06
|
<rafa> mvorobey: hmm what version are you running?
|
18:49:09
|
<mvorobey> rafa, oh my goodness, I need to click outside the table with properties
|
18:49:24
|
<mvorobey> rafa, you know, it is so intuitive :)
|
18:49:36
|
<mvorobey> rafa, am running trunk version
|
18:49:42
|
<rafa> mvorobey: hmm that is probably a bug ;)
|
18:49:48
|
<rafa> mvorobey: not a feature
|
18:50:39
|
<mvorobey> rafa, have you noticed a picture about bug vs feature when I was showing introductory presentation :) ?
|
18:51:08
|
<rafa> mvorobey: yes :D
|
18:51:51
|
<rafa> mvorobey: lol that is strange behvior indeed
|
18:51:57
|
<rafa> mvorobey: I don't like it at all
|
18:52:00
|
<mvorobey> rafa, so, lets make the cool feature of miserable bug :)
|
18:53:36
|
<mvorobey> rafa, can you check it maybe some later to prove that strange behavior is true for you so we will be able to introduce a bug ?
|
18:53:58
|
<rafa> mvorobey: yes, I've just verified it
|
18:54:05
|
<rafa> mvorobey: do you want to enter a ticket?
|
18:55:17
|
<mvorobey> rafa, not exactly, but if you check that I create the ticket right, I'll do it with pleasure :)
|
18:56:47
|
<rafa> mvorobey: sure, add me to watchers
|
18:57:09
|
<mvorobey> rafa, ok :)
|
19:03:30
|
<snoppy> suranga: hi suranga!
|
19:03:42
|
<snoppy> suranga: Are you still here?
|
19:03:48
|
<mvorobey> rafa, have a look at https://tickets.openmrs.org/browse/TRUNK-3411
|
19:05:26
|
*** goutham has quit IRC
|
19:10:16
|
<mvorobey> dkayiwa, hi
|
19:10:24
|
<dkayiwa> mvorobey: hi
|
19:10:36
|
<mvorobey> dkayiwa, saw you just announced 1.9.0 :)
|
19:10:48
|
<dkayiwa> mvorobey: :D
|
19:11:20
|
<mvorobey> dkayiwa, great, thank you :)
|
19:11:41
|
<dkayiwa> mvorobey: you are welcome. Thank you too for all you have done!!! :)
|
19:11:57
|
<dkayiwa> mvorobey: it is a collective effort :D
|
19:12:05
|
*** djazayeri has joined #openmrs
|
19:12:05
|
*** ChanServ sets mode: +o djazayeri
|
19:12:06
|
<mvorobey> dkayiwa, my piece of work is to small against yours :)
|
19:12:14
|
<mvorobey> to = too
|
19:12:15
|
*** kreddy has quit IRC
|
19:12:38
|
<dkayiwa> mvorobey: that does not matter. all one needs is contribute something, however small it may be :)
|
19:13:06
|
<mvorobey> dkayiwa, everything that I was doing is bothering you with bunch of reviews :)
|
19:13:19
|
<dkayiwa> mvorobey: all are equally important. The smallest of your toes is not less important than your heart :)
|
19:13:37
|
<suranga> hi snoppy sorry, almost missed you again
|
19:13:41
|
<dkayiwa> mvorobey: if you think it was bothering me, then you got it wrong!!! :D
|
19:13:43
|
*** maurya has quit IRC
|
19:13:51
|
<suranga> snoppy, i was going through all your very many tickets :)
|
19:14:05
|
<mvorobey> dkayiwa, thanks, because I was nervous about this :)
|
19:14:27
|
<dkayiwa> mvorobey: one of the ways i learn new things and styles is by reviewing some other people's code, your inclusive!!! :D
|
19:14:49
|
<dkayiwa> mvorobey: yes that is natural the first few times, but its ok :)
|
19:15:02
|
<dkayiwa> mvorobey: next time, you do not have to be :)
|
19:15:13
|
<snoppy> suranga:cool! Now I'm creating dao and services. I have some question
|
19:15:45
|
<mvorobey> dkayiwa, huh, remember the words from video " ... I saw your code and brain corrode ... " :D
|
19:16:06
|
<snoppy> suranga: Should all dao methods in module to throw DAOException?
|
19:16:28
|
<dkayiwa> mvorobey: lolllllllllll :D
|
19:16:38
|
*** goutham has joined #openmrs
|
19:17:06
|
<mvorobey> dkayiwa, it was about my code when your were reviewing it :)
|
19:17:09
|
<dkayiwa> mvorobey: by the way, when i was reviewing your code, i was greatly impressed! You seem to have lots more experience with OpenMRS than i had assumed :D
|
19:17:43
|
<mvorobey> dkayiwa, I'm surprised what you can do with menu Navigate in Eclipse :)
|
19:18:02
|
<dkayiwa> mvorobey: hahahahahahah :D
|
19:18:38
|
<mvorobey> dkayiwa, also you should include "Inspect element" in Chrome and you can be an expert in Openmrs like me :)
|
19:19:00
|
<dkayiwa> mvorobey: lollllllll Very nice tip.... :D
|
19:19:23
|
<mvorobey> dkayiwa, very common thing am assuming, is not it ?
|
19:19:45
|
<dkayiwa> mvorobey: not always :)
|
19:20:10
|
<mvorobey> dkayiwa, share please your oppinion :)
|
19:20:24
|
<mvorobey> oppinion = opinion
|
19:21:03
|
<suranga> hmmm.. snoppy i do know that alomost all of them do... but im not sure if that is a 'must', im afraid...
|
19:21:06
|
<dkayiwa> mvorobey: will do share it at a fee :)
|
19:22:11
|
*** djazayeri has quit IRC
|
19:22:11
|
<mvorobey> dkayiwa, ok, will transfer to you 1000K of imaginary dollars :)
|
19:22:39
|
<dkayiwa> mvorobey: lollll. Let me first dream about them tonight :)
|
19:23:36
|
<mvorobey> dkayiwa, never mind, 1000000 S and we are done right now :)
|
19:23:59
|
<dkayiwa> mvorobey: hahaha. what a bribe!!!! :)
|
19:24:05
|
<mvorobey> imaginary dollars of course
|
19:24:08
|
<mvorobey> :D
|
19:24:13
|
<dkayiwa> :D
|
19:25:00
|
<mvorobey> dkayiwa, no, of course not, am only hiring you for 5 minutes :)
|
19:25:26
|
<dkayiwa> mvorobey: for all that much, would make me run mad. :)
|
19:26:08
|
<mvorobey> dkayiwa, you can easily share them with rafa :)
|
19:26:50
|
<dkayiwa> mvorobey: great temptation! :)
|
19:28:00
|
<mvorobey> dkayiwa, ok, so, need to do my work because my battery is about to be half expired and I only did one commit and fired 10 jokes :)
|
19:28:53
|
<dkayiwa> mvorobey: fair enough for today :D
|
19:28:56
|
<rafa> mvorobey: I believe in sharing! :D
|
19:29:07
|
<rafa> mvorobey: even if I'm not sure what I'll get :D
|
19:29:23
|
<dkayiwa> mvorobey: rafa is not giving up on you :)
|
19:29:38
|
<mvorobey> rafa, huh
|
19:29:50
|
*** bwolfe has quit IRC
|
19:30:25
|
<mvorobey> rafa, my imaginary dollars is almost like the real, but they can be transferred without taxes :)
|
19:30:32
|
<mvorobey> is = are
|
19:31:36
|
<dkayiwa> rafa: are you on design call
|
19:31:50
|
<rafa> dkayiwa: half there
|
19:32:02
|
<rafa> dkayiwa: question to me?
|
19:32:05
|
<mvorobey> rafa, can you answer one question ?
|
19:32:07
|
<dkayiwa> rafa: :D
|
19:32:53
|
<rafa> dkayiwa: guess it's too late huh? :D
|
19:33:01
|
<rafa> mvorobey: yes
|
19:33:02
|
<dkayiwa> rafa: yup :)
|
19:33:21
|
<mvorobey> rafa, there is a method validate_shouldNotFailValidationIfDrugIsNull, with new changes that am going to introduce it should be refactored to validate_shouldFailValidationIfDrugIsNull, do not it ?
|
19:33:46
|
<rafa> mvorobey: makes sense :)
|
19:34:03
|
<mvorobey> rafa, cool, thanks :)
|
19:35:14
|
<mvorobey> rafa, also I need to check if concept is not set, is this about drug's concept ?
|
19:35:24
|
<rafa> mvorobey: yes
|
19:35:49
|
<mvorobey> rafa, awesome, thanks :)
|
19:40:39
|
<dkayiwa> downey: that was first!!! :D
|
19:43:41
|
<downey> dkayiwa: ;-)
|
19:44:10
|
*** Echidna_ has quit IRC
|
19:44:34
|
*** Echidna has joined #openmrs
|
19:44:34
|
*** ChanServ sets mode: +v Echidna
|
19:47:36
|
<downey> dkayiwa: 1.9 is so popular the wiki crashed :D
|
19:47:52
|
<dkayiwa> downey: are you sure???? :)
|
19:48:06
|
<downey> dkayiwa: well, it sounds good anyway ;)
|
19:48:06
|
<dkayiwa> dkayiwa: maybe the video crashed it :D
|
19:48:09
|
<suranga> dkayiwa, downey afraid so
|
19:48:15
|
<suranga> i just tried the link too :)
|
19:48:46
|
*** goutham has quit IRC
|
19:49:43
|
*** pulasthi7 has quit IRC
|
19:49:49
|
<downey> it will be back in just a moment
|
19:50:33
|
<downey> s/moment/now/
|
19:58:35
|
*** mccallumg has quit IRC
|
19:58:36
|
*** mccallumg_ has joined #openmrs
|
19:58:45
|
*** ChanServ sets mode: +v mccallumg_
|
19:59:55
|
*** wyclif has quit IRC
|
20:00:09
|
*** mvorobey has quit IRC
|
20:01:31
|
*** djazayeri has joined #openmrs
|
20:01:31
|
*** ChanServ sets mode: +o djazayeri
|
20:09:00
|
*** djazayeri has quit IRC
|
20:14:03
|
<OpenMRSBot> Recent updates in the world of openmrs: Burke Mamlin: Partial checkout with Subversion <http://blog.burkeware.com/2012/06/partial-checkout-with-subversion/> || On Twitter: OpenMRS: #OpenMRS 1.9 is now available with 377 bugs fixed & 74 new features. Read more and download today! http://t.co/mjBVrk7B #HealthIT #eHealth <http://twitter.com/OpenMRS/statuses/210456528531107841>
|
20:14:51
|
*** wyclif has joined #openmrs
|
20:17:56
|
*** dkayiwa has quit IRC
|
20:21:40
|
*** dkayiwa has joined #openmrs
|
20:43:16
|
<wyclif> hi rafa
|
20:43:21
|
<rafa> hi
|
20:43:33
|
<wyclif> rafa, are you working on RESTWS-148
|
20:43:53
|
<wyclif> rafa, i see it is assigned to you
|
20:44:24
|
<rafa> wyclif: yes
|
20:44:31
|
<rafa> wyclif: it's more of a grouping ticket
|
20:44:36
|
<dkayiwa> hi downey
|
20:44:42
|
<downey> dkayiwa: hey :)
|
20:44:57
|
<dkayiwa> downey: do you have editing permissions for this page? http://openmrs.org/demo/
|
20:45:15
|
<rafa> wyclif: do you have some ideas to put there?
|
20:46:05
|
<wyclif> no ideas, i was just findind out if you are working on it
|
20:46:39
|
<downey> dkayiwa: yeah i do
|
20:46:50
|
<rafa> wyclif: cool
|
20:46:53
|
<downey> dkayiwa: just saw the version number :)
|
20:47:10
|
<dkayiwa> downey: of 1.8? :)
|
20:47:15
|
<downey> dkayiwa: fixed
|
20:47:26
|
<rafa> wyclif: are you an owner of CALC in JIRA?
|
20:47:27
|
<dkayiwa> downey: thanks :D
|
20:48:09
|
*** robbyoconnor has joined #openmrs
|
20:48:09
|
*** ChanServ sets mode: +v robbyoconnor
|
20:48:13
|
<downey> rafa: https://tickets.openmrs.org/browse/CALC
|
20:48:34
|
<rafa> wyclif: I can review code, but I'll not be closing tickets since I don't have rights
|
20:48:52
|
<dkayiwa> downey: do you have an idea of how we can change the TB demo to 1.9? :)
|
20:49:10
|
<downey> dkayiwa: that's run by PIH, perhaps you can send a note to hamish or ellen ball @ PIH
|
20:49:13
|
<wyclif> rafa, for order entry or calculation?
|
20:49:20
|
<rafa> wyclif: for calculation
|
20:49:25
|
<dkayiwa> downey: ok thanks :)
|
20:49:54
|
<wyclif> rafa, am a projec admin for CALC, i can add you
|
20:50:00
|
<wyclif> rafa, yeah
|
20:50:42
|
<rafa> wyclif: ok, thanks
|
20:51:50
|
<wyclif> rafa, done
|
20:52:27
|
<rafa> wyclif: worked, thx
|
20:53:56
|
<wyclif> cool
|
21:07:51
|
*** nwilkie has joined #openmrs
|
21:12:28
|
<venkaban> bwolfe, Hey I have one suggesstion as per the discussion we had in organizing the JIRA tickets
|
21:13:38
|
<venkaban> bwolfe, In the summary section lets have the module name liste first followed by a : which will help the people to know the module in which the problem is
|
21:14:32
|
<venkaban> bwolfe, I assume there are module owners who can then take care of the tickets under their mod(s) and have one or more developers help in organizing the JIRA tickets
|
21:23:13
|
*** downey has quit IRC
|
21:23:20
|
<suranga> Hi everyone... maybe dkayiwa or rafa might know... have you ever tried reversing the spring message process ? that is, how to get the message by passing in the value ? the reverse of <spring:messagecode=''> basically....
|
21:23:28
|
<suranga> is it even possible ? :)
|
21:23:58
|
<dkayiwa> suranga: do you mean pass in value and get the message code/
|
21:23:59
|
<dkayiwa> ?
|
21:24:12
|
<suranga> dkayiwa, exactly.. mm.. is that possible ? :)
|
21:24:33
|
<dkayiwa> suranga: why would you wanna do that?
|
21:25:06
|
<suranga> dkayiwa, mm.. its a long story... basically, i need to make a one way process bi-directional...
|
21:25:30
|
<suranga> dkayiwa, for patientmatching module. if I could do that, it would be cool :-)
|
21:28:07
|
*** mseaton has left #openmrs
|
21:28:57
|
<dkayiwa> suranga: i wish i could understand what you are trying to achieve, form the end user's perspective! :0
|
21:28:59
|
<dkayiwa> :)
|
21:28:59
|
<rafa> suranga: you can load properties file and do whatever you want
|
21:30:03
|
*** wyclif has quit IRC
|
21:30:28
|
*** venkaban has quit IRC
|
21:30:30
|
<suranga> hmm... thanks rafa . dkayiwa I'd love to tell you. But im afraid that my design idea sounds really really stupid at this stage... :-(
|
21:30:38
|
<rafa> suranga: also look at ResourceBundleMessageSource
|
21:30:53
|
<rafa> suranga: it's a spring bean that you can inject
|
21:30:58
|
<rafa> suranga: maybe it has a method you need
|
21:31:22
|
<suranga> dkayiwa, if I ever decide to impelment this (I hope not) i'll send a mail to the dev list seeking advice first... :-)
|
21:31:31
|
<dkayiwa> suranga: oh i can wait until when your idea gets wise. If it ever does. :D
|
21:31:55
|
<suranga> rafa, thanks. im rather new to this subject, so this will be very helpful to me :-) :-) :-)
|
21:32:17
|
<suranga> dkayiwa, i guess 3 am in the morning is not a time to design our code :P
|
21:33:19
|
<dkayiwa> suranga: it can be if you took lots of coffee :)
|
21:34:24
|
<suranga> actually its alll them mosquitoes that are keeping me awake. its impossible to sleep in peace over here :-(
|
21:41:54
|
*** downey has joined #openmrs
|
21:41:54
|
*** ChanServ sets mode: +o downey
|
21:41:54
|
*** OpenMRSBot sets mode: +o downey
|
21:43:22
|
*** snoppy has quit IRC
|
21:46:51
|
*** dkayiwa has quit IRC
|
22:13:19
|
*** suranga has quit IRC
|
22:18:11
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Head of @TWthoughts on last night's 'hack night for humanity' in Australia & how OpenMRS can change #HealthIT globally: http://t.co/i1Z569rK <http://twitter.com/OpenMRS/statuses/210488528742793216>
|
22:18:13
|
*** downey has quit IRC
|
22:20:27
|
*** bryq has quit IRC
|
22:22:50
|
*** mccallumg_ has quit IRC
|
22:30:31
|
*** nwilkie has quit IRC
|
22:36:35
|
*** rafa has quit IRC
|
23:30:06
|
*** wyclif has joined #openmrs
|