00:07:39
|
*** djazayeri has joined #openmrs
|
00:07:39
|
*** ChanServ sets mode: +o djazayeri
|
00:18:19
|
*** djazayeri has quit IRC
|
00:19:29
|
*** nwilkie_ has joined #openmrs
|
00:19:29
|
*** nwilkie has quit IRC
|
00:19:30
|
*** nwilkie_ is now known as nwilkie
|
00:25:13
|
*** nwilkie_ has joined #openmrs
|
00:25:13
|
*** nwilkie has quit IRC
|
00:25:14
|
*** nwilkie_ is now known as nwilkie
|
00:27:22
|
*** nwilkie_ has joined #openmrs
|
00:27:22
|
*** nwilkie has quit IRC
|
00:27:22
|
*** nwilkie_ is now known as nwilkie
|
00:30:17
|
*** nwilkie_ has joined #openmrs
|
00:30:18
|
*** nwilkie has quit IRC
|
00:30:18
|
*** nwilkie_ is now known as nwilkie
|
00:32:37
|
*** nwilkie_ has joined #openmrs
|
00:32:37
|
*** nwilkie has quit IRC
|
00:32:37
|
*** nwilkie_ is now known as nwilkie
|
00:35:42
|
*** nwilkie_ has joined #openmrs
|
00:35:42
|
*** nwilkie has quit IRC
|
00:35:42
|
*** nwilkie_ is now known as nwilkie
|
00:36:36
|
*** nwilkie_ has joined #openmrs
|
00:36:37
|
*** nwilkie has quit IRC
|
00:36:37
|
*** nwilkie_ is now known as nwilkie
|
00:40:58
|
*** nwilkie_ has joined #openmrs
|
00:40:58
|
*** nwilkie has quit IRC
|
00:40:59
|
*** nwilkie_ is now known as nwilkie
|
00:49:05
|
*** nwilkie has quit IRC
|
00:49:11
|
*** nwilkie_ has joined #openmrs
|
00:51:25
|
*** nwilkie has joined #openmrs
|
00:51:26
|
*** nwilkie_ has quit IRC
|
01:02:00
|
*** rafa has joined #openmrs
|
01:02:00
|
*** ChanServ sets mode: +v rafa
|
01:04:54
|
*** nwilkie_ has joined #openmrs
|
01:04:54
|
*** nwilkie has quit IRC
|
01:04:54
|
*** nwilkie_ is now known as nwilkie
|
01:06:01
|
*** rafa has quit IRC
|
01:06:02
|
*** nwilkie has quit IRC
|
01:06:54
|
*** nwilkie has joined #openmrs
|
01:26:55
|
*** nwilkie_ has joined #openmrs
|
01:26:55
|
*** nwilkie has quit IRC
|
01:26:55
|
*** nwilkie_ is now known as nwilkie
|
02:07:05
|
*** nwilkie_ has joined #openmrs
|
02:07:05
|
*** nwilkie has quit IRC
|
02:07:05
|
*** nwilkie_ is now known as nwilkie
|
02:23:21
|
*** nwilkie has quit IRC
|
02:23:36
|
*** nwilkie has joined #openmrs
|
02:24:23
|
*** jordank has joined #openmrs
|
02:26:06
|
*** nwilkie_ has joined #openmrs
|
02:26:32
|
*** nwilkie has quit IRC
|
02:26:32
|
*** nwilkie_ is now known as nwilkie
|
02:46:18
|
*** nwilkie has quit IRC
|
02:47:54
|
*** harshadura has joined #openmrs
|
02:50:42
|
*** jordank has left #openmrs
|
02:51:08
|
*** jordank has joined #openmrs
|
03:01:43
|
*** djazayeri has joined #openmrs
|
03:01:43
|
*** ChanServ sets mode: +o djazayeri
|
03:27:44
|
*** jordank has quit IRC
|
03:30:18
|
*** maurya has joined #openmrs
|
03:30:42
|
*** Maurya_ has joined #openmrs
|
03:32:43
|
*** Maurya_ has left #openmrs
|
03:32:57
|
*** Maurya_ has joined #openmrs
|
03:34:45
|
*** maurya has quit IRC
|
04:02:41
|
*** bryq has joined #openmrs
|
04:02:41
|
*** ChanServ sets mode: +v bryq
|
04:07:18
|
*** harshadura has quit IRC
|
04:19:34
|
*** baitisj has joined #openmrs
|
04:20:20
|
<baitisj> Hi there all -- does Dr. Gerald Douglas ever pop in here?
|
04:38:05
|
*** upul` has joined #openmrs
|
04:38:05
|
*** ChanServ sets mode: +v upul`
|
04:43:30
|
*** djazayeri has quit IRC
|
04:50:00
|
*** bryq has quit IRC
|
04:50:47
|
*** jordank has joined #openmrs
|
05:20:04
|
*** dkayiwa has joined #openmrs
|
05:26:33
|
*** mgielow has joined #openmrs
|
05:28:13
|
*** sunbiz has joined #openmrs
|
05:28:13
|
*** ChanServ sets mode: +v sunbiz
|
05:31:15
|
*** dkayiwa has left #openmrs
|
05:56:20
|
*** ShellZero has joined #openmrs
|
05:56:47
|
*** ShellZero is now known as applecool
|
05:57:21
|
<applecool> !seen rafa
|
05:57:21
|
<OpenMRSBot> applecool: rafa was last seen in #openmrs 15 hours, 51 minutes, and 8 seconds ago: <rafa> bwolfe: will finish today
|
05:57:39
|
<applecool> !seen applecool
|
05:57:39
|
<OpenMRSBot> applecool: applecool was last seen in #openmrs 17 seconds ago: <applecool> !seen rafa
|
05:59:47
|
<sunbiz> bwolfe: ??
|
06:00:00
|
*** suranga has joined #openmrs
|
06:00:00
|
*** ChanServ sets mode: +v suranga
|
06:00:26
|
<suranga> hmmm.. hi bwolfe .. are you still here ? :O
|
06:58:21
|
*** suranga has quit IRC
|
07:25:51
|
*** magoo_ has joined #openmrs
|
07:52:34
|
*** applecool has quit IRC
|
07:58:02
|
*** applecool has joined #openmrs
|
07:59:43
|
*** harshadura has joined #openmrs
|
08:12:07
|
<harshadura> hi anyone thr
|
08:12:28
|
<applecool> yes ;)
|
08:13:07
|
<harshadura> applecool, hi bro i hv a problem regarding js
|
08:13:27
|
<applecool> hi! javascript?
|
08:13:46
|
<harshadura> I need to use the jquery file which is in the core of open mrs rather than separately importing it.
|
08:14:13
|
<harshadura> do u hv idea hw to get done this
|
08:15:09
|
<harshadura> in tag 1.8.3 i checked this file
|
08:15:11
|
<harshadura> http://svn.openmrs.org/openmrs/tags/1.8.0/webapp/src/main/webapp/WEB-INF/view/admin/patients/patientForm.jsp
|
08:15:41
|
<harshadura> it uses a calendar.js file, but that file isnt situated in that folder
|
08:15:50
|
<harshadura> so hw that works :O
|
08:16:06
|
<applecool> hmm! it should be present
|
08:16:16
|
<harshadura> nah bro
|
08:17:51
|
<harshadura> hey bro, got it xD
|
08:17:54
|
<harshadura> its thr
|
08:18:01
|
<harshadura> thanks anyway :)
|
08:18:13
|
<applecool> haha! i was about to give the link!
|
08:18:21
|
<applecool> u got it :) cool :)
|
08:18:35
|
<harshadura> lol thx for ur time bro
|
08:18:56
|
<applecool> dont mention it :) no problem :)
|
08:19:10
|
<harshadura> :)
|
08:23:37
|
*** sunbiz1 has joined #openmrs
|
08:24:36
|
*** sunbiz has quit IRC
|
08:40:14
|
<mgielow> hi, anybody home?
|
08:40:25
|
<applecool> yes :)
|
08:40:33
|
<mgielow> hi applecool :)
|
08:40:44
|
*** baitisj has quit IRC
|
08:40:47
|
<applecool> hi mgielow :)
|
08:41:03
|
<mgielow> i have a question regarding module lifecycle / installtion process.. are you by any chance familiar with that?
|
08:41:23
|
<applecool> hmm! no but let me try
|
08:42:50
|
<applecool> mgielow: what is the question?
|
08:42:57
|
<mgielow> im looking for a way to allow user interaction as early as possible when a module is loaded, so to allow to the user to declare whether e.g. sample data should be installed
|
08:44:17
|
<applecool> okay!
|
08:44:20
|
<mgielow> has that been done in other modules and is there a recommended way to do it?
|
08:44:55
|
<applecool> i donno! i think its there!
|
08:45:03
|
*** deepa_ has joined #openmrs
|
08:45:26
|
<applecool> in general these will be done through a sample-data.xml
|
08:45:46
|
<applecool> i mean the sample data will be given in this particular file!
|
08:46:21
|
<applecool> mgielow: i think i am misleading you! ! did that answer any part of your question?
|
08:46:22
|
<mgielow> ok, but that would be processed as soon as the module is loaded, wouldnt it?
|
08:46:38
|
<applecool> yes i guess!
|
08:47:55
|
<mgielow> ok i see, but ill read up on it anyway. guess i should have a look at some more modules too and see if there's anything that might do something like what im looking for
|
08:48:15
|
<mgielow> thanks for the hints :)
|
08:48:45
|
<applecool> hehe :) no problem! :) mgielow
|
08:52:01
|
*** rafa has joined #openmrs
|
08:52:01
|
*** ChanServ sets mode: +v rafa
|
08:57:41
|
<applecool> hey rafa
|
08:57:51
|
<rafa> applecool: hi
|
08:59:02
|
<applecool> do i need to create a packageList.jsp or should i write it in the mainMenu.jsp ?
|
08:59:17
|
<applecool> as mainMenu.jsp is acting as the welcome page
|
08:59:55
|
<applecool> as of now i added the code to mainMenu.jsp!
|
09:00:26
|
<rafa> applecool: you should rename it to packages.jsp and we're good
|
09:00:47
|
<applecool> which one? mainMenu?
|
09:00:53
|
<rafa> applecool: yes
|
09:01:10
|
<applecool> omg ! then i need to change that everywhere!
|
09:01:30
|
<rafa> applecool: also the link in the menu should be Packages
|
09:01:43
|
<rafa> applecool: ctrl + H :)
|
09:01:59
|
<applecool> i dint get it! link in the menu??
|
09:02:02
|
<applecool> where?
|
09:02:19
|
<rafa> applecool: in the horizontal menu
|
09:02:42
|
<applecool> Ohk! instead of mainMenu it should be Packages!
|
09:02:45
|
<applecool> right?
|
09:02:50
|
<rafa> applecool: where you have links "Main Menu", "Login", etc.
|
09:03:45
|
<rafa> applecool: right
|
09:03:48
|
<applecool> COOL! then my first task is done if i do some small changes
|
09:04:01
|
<rafa> applecool: committed?
|
09:04:06
|
<applecool> no didnt
|
09:04:13
|
<applecool> you told me the changes right
|
09:04:20
|
<applecool> i will do that and then wil commit
|
09:04:24
|
<rafa> applecool: ok
|
09:04:26
|
<applecool> or should i commit it now?
|
09:04:33
|
<applecool> do you want to see it?
|
09:04:52
|
<rafa> applecool: yes
|
09:05:08
|
<applecool> ok wil commit it ! JAM :)
|
09:07:42
|
<applecool> rafa: checking whether there are any images or files in the resources ! :D
|
09:12:39
|
<rafa> applecool: let's change only a link in the menu
|
09:12:54
|
<applecool> rafa: okay
|
09:13:10
|
<applecool> rafa: what should i give in the commit message!
|
09:13:11
|
<applecool> ?
|
09:13:25
|
*** sunbiz1 has quit IRC
|
09:13:39
|
<rafa> applecool: from "Main Menu" to "Packages"
|
09:13:42
|
*** harshadura has quit IRC
|
09:13:52
|
*** sunbiz has joined #openmrs
|
09:13:52
|
*** ChanServ sets mode: +v sunbiz
|
09:14:11
|
<applecool> i dint change those yet!
|
09:14:18
|
<rafa> applecool: ok
|
09:14:35
|
<applecool> Added PackageController?
|
09:14:41
|
<applecool> is it ok for now?
|
09:14:50
|
<rafa> applecool: ok
|
09:15:13
|
<applecool> committed!
|
09:16:13
|
<rafa> applecool: push
|
09:16:50
|
<applecool> done
|
09:17:29
|
<applecool> but i can see some disastrous bug in it!
|
09:20:11
|
*** harshadura has joined #openmrs
|
09:21:52
|
<applecool> rafa: ?
|
09:22:08
|
*** kdeeq has joined #openmrs
|
09:24:01
|
<rafa> applecool: what you mean?
|
09:24:32
|
<applecool> is it proper rafa?
|
09:24:39
|
<applecool> listing?
|
09:24:53
|
<rafa> does it work?
|
09:25:07
|
<applecool> it is working
|
09:25:56
|
<rafa> applecool: so what do you mean by disaster?
|
09:25:59
|
<applecool> but the bug is when the packages are listed ! and when i click on the package name ! it is showing the packageform!
|
09:26:22
|
<applecool> where i can edit the data directly and save or update it or even delete it!
|
09:26:52
|
<applecool> that is the disaster!
|
09:27:00
|
<rafa> we'll want that
|
09:27:08
|
<rafa> applecool: but only when you're logged in
|
09:27:24
|
<rafa> applecool: which is how it works right?
|
09:27:34
|
<applecool> hmm! but this is showing me without logging in! :D
|
09:27:48
|
<applecool> so need to change the priviliges of the packageform!
|
09:27:56
|
<applecool> in the security.xml!
|
09:27:57
|
<rafa> applecool: so you need to add security entry for packageform
|
09:28:04
|
<applecool> yup!
|
09:28:12
|
<applecool> did you run it?
|
09:28:16
|
<rafa> applecool: no
|
09:28:16
|
<applecool> and checked it?
|
09:28:23
|
<applecool> oh!
|
09:28:47
|
<applecool> once if you are free can you run it and check it ?rafa
|
09:28:58
|
<applecool> okay! wait!
|
09:29:23
|
<applecool> so now you just want me to change the link in the horizontal bar to Packages
|
09:29:42
|
<applecool> thats it? or evrything ?
|
09:30:10
|
<applecool> i mean as you told before mainMenu to Packages entirey?
|
09:30:16
|
<applecool> entirely*
|
09:32:27
|
<rafa> applecool: yes, the link is enough
|
09:32:38
|
<applecool> ok will do it!
|
09:38:55
|
<rafa> applecool: by the link I only mean the label :)
|
09:39:01
|
<rafa> applecool: don't change the url ;)
|
09:39:31
|
<applecool> yeah yeah i got it :) need to just change the value in the ApplicationResources.properties :)
|
09:39:52
|
<rafa> applecool: correct :)
|
09:40:01
|
*** magoo_ has quit IRC
|
09:41:46
|
<applecool> Done :)
|
09:41:52
|
<applecool> committed and pushed!
|
09:42:13
|
<applecool> rafa: if you are free please run the web and check :)
|
09:43:15
|
<applecool> and tell me if anything is needed! i actually added another keyword packageMenu.title=Packages and let the mainMenu.title to be as it is!
|
09:43:23
|
<applecool> is it okay rafa?
|
09:44:14
|
<rafa> applecool: isn't mainMenu.title displayed in other places?
|
09:44:22
|
<rafa> applecool: and used in tests?
|
09:44:42
|
<applecool> hmm! need to check with it!
|
09:44:47
|
<applecool> dont remember!
|
09:45:03
|
<rafa> applecool: I think it's safer just to change it to "Packages"
|
09:45:25
|
<applecool> okay so no need to add the extra line
|
09:45:26
|
*** deepa_ has quit IRC
|
09:45:31
|
<applecool> right?
|
09:45:40
|
<applecool> should i go ahead and remove it ?
|
09:45:43
|
<rafa> right
|
09:45:48
|
<applecool> okay
|
09:46:08
|
*** kdeeq has quit IRC
|
09:49:52
|
<rafa> applecool: I've added a comment to your commit. Add PackageControllerTest
|
09:50:14
|
<applecool> okay :) just got a notification ! :) will check it :)
|
09:50:16
|
<rafa> applecool: and before you start with a new task make sure all tests pass
|
09:50:41
|
<applecool> hmm!! that will be always a big task!
|
09:51:49
|
<applecool> yes need to add PackageControllerTest too! :)
|
09:51:57
|
<applecool> will do it rafa :)
|
09:57:04
|
*** pushkar has joined #openmrs
|
09:58:38
|
<harshadura> rafa, can you pls tell me how to access the jquery.min.js file which is at the core openmrs within a Module JSP ?
|
09:58:59
|
<harshadura> I hv tried several ways, but its not working properly
|
09:59:12
|
<harshadura> <openmrs:htmlIncludefile="/scripts/jquery/jquery.min.js"/>
|
09:59:48
|
<harshadura> ^ I think its the proper way, but it doesnt work, can u tell me any suggestions, thanks
|
10:00:07
|
<rafa> <openmrs:htmlIncludefile="${pageContext.request.contextPath}/scripts/jquery/jquery.min.js"/>
|
10:00:35
|
<harshadura> thanks lot rafa, hope this will work
|
10:00:54
|
<rafa> harshadura
|
10:00:56
|
<rafa> harshadura: np
|
10:08:23
|
<applecool> rafa: i made some more changes ! tested the deleting the package and adding a package!
|
10:08:28
|
<applecool> made some fixes!
|
10:08:52
|
<applecool> i guess now there are no mistakes!
|
10:09:03
|
<applecool> i just need to write a test! thats it
|
10:09:47
|
<applecool> rafa: please,check the code and run it when you are free :)
|
10:10:34
|
<rafa> applecool: sure, I'll do it before I go to sleep
|
10:10:46
|
<rafa> applecool: I'm busy right now
|
10:10:49
|
<applecool> thanks rafa :)
|
10:10:56
|
<applecool> okay catch you later :)
|
10:11:14
|
<rafa> applecool: cya
|
10:11:19
|
<applecool> cya :)
|
10:11:50
|
<harshadura> rafa, its still not working, are thr anything to configure inside module to use that core JS files
|
10:12:31
|
<rafa> harshadura: does the browser report file cannot be loaded?
|
10:12:49
|
<harshadura> no rafa
|
10:13:04
|
<rafa> harshadura: then why you say it's not working?
|
10:13:11
|
<rafa> harshadura: what error do you get?
|
10:14:22
|
<harshadura> nothings alerts rafa, but I have done a jquery wizard, it displays as a several forms in this error prone way
|
10:15:08
|
<rafa> harshadura: what bowser do you use?
|
10:15:28
|
<harshadura> whenever I include jquery file inside module resources its working properly
|
10:15:34
|
<harshadura> chrome rafa
|
10:16:12
|
<rafa> harshadura: open developer tools and say what errors it reports
|
10:17:13
|
<rafa> harshadura: are you declaring: var $j = jQuery.noConflict(); ?
|
10:17:33
|
<harshadura> rafa: havent used it before, can u pls giv me a link to refer that, thx
|
10:17:50
|
<harshadura> yes
|
10:17:54
|
<rafa> harshadura: are you using $j(...) instead of $(...) for jQuery?
|
10:18:14
|
<harshadura> yes rafa
|
10:18:47
|
<rafa> harshadura: the shortcut to open dev tools is: ctrl + shift + j
|
10:19:42
|
<harshadura> ahh ok got it rafa, may I paste the log here or pastebin
|
10:19:55
|
<rafa> harshadura: pastebin will be better
|
10:21:17
|
<harshadura> rafa : http://pastebin.com/1niQtvNA
|
10:22:22
|
<rafa> harshadura: pastebin your jsp page
|
10:23:12
|
<harshadura> ok
|
10:24:58
|
<harshadura> rafa : http://pastebin.com/Ecy9fRxf
|
10:26:01
|
<rafa> harshadura: which version of openmrs are you using?
|
10:26:10
|
<harshadura> 1.8.3
|
10:27:41
|
*** suranga has joined #openmrs
|
10:27:41
|
*** ChanServ sets mode: +v suranga
|
10:28:12
|
<rafa> harshadura: is there a reason you don't do <%@ include file="/WEB-INF/template/header.jsp"%>?
|
10:28:50
|
<rafa> harshadura: to display the standard OpenMRS header
|
10:28:59
|
*** suranga has quit IRC
|
10:29:11
|
*** suranga has joined #openmrs
|
10:29:22
|
<harshadura> this is a portlet rafa
|
10:29:32
|
<rafa> harshadura: ohh ok
|
10:29:43
|
<rafa> harshadura: so you have errors in your scripts
|
10:29:53
|
<rafa> harshadura: you use $( whereas you should use $j(
|
10:30:06
|
<rafa> harshadura: line 11, 12
|
10:31:01
|
<harshadura> but rafa, with using the jquery module JS files it works properly.
|
10:31:27
|
<harshadura> ok sure I will change that too
|
10:32:02
|
*** suranga has quit IRC
|
10:32:05
|
<rafa> harshadura: and I think that in a portlet you don't even need to include jquery
|
10:33:07
|
<harshadura> ok rafa I will change that and try again, thanks
|
10:33:31
|
<rafa> harshadura: also line 22
|
10:33:51
|
<rafa> harshadura: I don't see myCanvas anywhere in your portlet
|
10:34:08
|
<rafa> harshadura: thus the error message you get in line 23 that c is null
|
10:34:22
|
<harshadura> whoops ok
|
10:34:47
|
<rafa> harshadura: it's definitely not a problem with jQuery not being included properly
|
10:34:55
|
<rafa> harshadura: fix your scripts
|
10:35:18
|
<harshadura> okay rafa
|
10:40:15
|
<harshadura> rafa, exactly that was the problem, now its working properly, thanks again for your time helping me.
|
10:40:42
|
<rafa> harshadura: you're welcome
|
10:44:52
|
*** applecool has quit IRC
|
10:50:43
|
*** magoo_ has joined #openmrs
|
10:54:01
|
*** suranga has joined #openmrs
|
10:54:01
|
*** ChanServ sets mode: +v suranga
|
11:14:28
|
*** sunbiz1 has joined #openmrs
|
11:15:03
|
*** sunbiz has quit IRC
|
11:16:27
|
*** james_regen has joined #openmrs
|
11:16:27
|
*** ChanServ sets mode: +v james_regen
|
11:24:04
|
<suranga> mm... hi Rafa... any chance for another quick question ? :)
|
11:24:11
|
*** magoo_ has quit IRC
|
11:24:17
|
<rafa> suranga: go ahead
|
11:24:27
|
<suranga> rafa, how does one create a concept mapping when creating a concept ?
|
11:24:39
|
<suranga> Im creating concepts, and I need to add mappings...
|
11:24:54
|
<rafa> suranga: you mean via the UI?
|
11:25:05
|
<suranga> rafa, yep :)
|
11:25:11
|
<suranga> rafa, is that possible ?
|
11:25:33
|
<rafa> suranga: I don't remember...
|
11:25:48
|
<suranga> rafa, ooooops :(
|
11:26:04
|
<suranga> rafa, no worries, I will check it out... or I will bug Ben, maybe :P
|
11:26:30
|
<rafa> suranga: there's Add Mapping button on the create concept form
|
11:26:58
|
<suranga> rafa, yep, but unfortunately, for me its empty......
|
11:27:12
|
<rafa> suranga: you mean concept source is empty?
|
11:27:26
|
*** upul` has quit IRC
|
11:27:32
|
<rafa> suranga: the dropdown?
|
11:27:53
|
<suranga> rafa, afraid so.. my concept mappings drop down is empty
|
11:28:02
|
<suranga> rafa, I did not add demo data :(
|
11:28:12
|
<rafa> suranga: you need to go manage concept sources and add one
|
11:28:30
|
<rafa> suranga: then you'll be able to use it in add mapping
|
11:28:51
|
<suranga> rafa, aaah, that makes sense ! thanks for pointing that out :-)
|
11:29:01
|
<rafa> suranga: np
|
11:35:46
|
*** robbyoconnor has quit IRC
|
11:53:52
|
*** p_m has joined #openmrs
|
12:04:38
|
*** p_m has quit IRC
|
12:07:17
|
<bwolfe> sunbiz1, which option are you using when getting that error?>
|
12:08:32
|
<sunbiz1> advanced
|
12:08:41
|
<bwolfe> and then?
|
12:08:44
|
<sunbiz1> plain new installation... with all the options checked as yes
|
12:08:46
|
<sunbiz1> rgarding the updates
|
12:09:07
|
<sunbiz1> as well as got the error when upgrading from a 1.8.3 installation
|
12:09:16
|
<sunbiz1> which never had patientflag installed
|
12:09:36
|
*** harshadura has quit IRC
|
12:09:50
|
<bwolfe> very interesting
|
12:10:15
|
*** suranga_ has joined #openmrs
|
12:10:29
|
<bwolfe> not sure how/why its happening on upgrade
|
12:10:44
|
<bwolfe> do you still have the old db? can you see if there is a patientflags.database_version GP there?
|
12:10:50
|
<sunbiz1> coz it happens with a new installation as well
|
12:11:02
|
<sunbiz1> nope.. dont have that db
|
12:11:04
|
<sunbiz1> so cant check
|
12:11:17
|
<bwolfe> boo
|
12:11:23
|
<sunbiz1> bwolfe: booo
|
12:11:42
|
<sunbiz1> but u can try a new install
|
12:11:47
|
<sunbiz1> and it will still give that error
|
12:12:40
|
*** suranga has quit IRC
|
12:13:36
|
*** sunbiz1 has quit IRC
|
12:14:04
|
*** suranga_ has quit IRC
|
12:17:14
|
*** p_m has joined #openmrs
|
12:20:05
|
*** nwilkie has joined #openmrs
|
12:21:45
|
*** nwilkie has quit IRC
|
12:24:24
|
*** rafa has quit IRC
|
12:27:07
|
*** rafa has joined #openmrs
|
12:27:07
|
*** ChanServ sets mode: +v rafa
|
12:28:18
|
*** harshadura has joined #openmrs
|
12:32:22
|
*** r0bby has joined #openmrs
|
12:32:22
|
*** ChanServ sets mode: +v r0bby
|
12:36:57
|
*** rafa has quit IRC
|
12:38:45
|
*** rafa has joined #openmrs
|
12:38:45
|
*** ChanServ sets mode: +v rafa
|
12:52:32
|
*** bryq has joined #openmrs
|
12:52:32
|
*** ChanServ sets mode: +v bryq
|
12:53:11
|
*** r0bby_ has joined #openmrs
|
12:53:11
|
*** ChanServ sets mode: +v r0bby_
|
12:54:20
|
*** r0bby has quit IRC
|
12:54:26
|
*** r0bby|droid has joined #openmrs
|
12:54:26
|
*** ChanServ sets mode: +v r0bby|droid
|
12:57:38
|
*** r0bby_ has quit IRC
|
13:00:52
|
*** r0bby has joined #openmrs
|
13:00:52
|
*** ChanServ sets mode: +v r0bby
|
13:00:56
|
*** r0bby|droid has quit IRC
|
13:02:05
|
*** r0bby_ has joined #openmrs
|
13:02:05
|
*** ChanServ sets mode: +v r0bby_
|
13:05:20
|
*** r0bby has quit IRC
|
13:16:05
|
*** magoo_ has joined #openmrs
|
13:19:45
|
*** mseaton has joined #openmrs
|
13:19:45
|
*** ChanServ sets mode: +v mseaton
|
13:23:07
|
*** harshadura has quit IRC
|
13:34:31
|
*** djazayeri has joined #openmrs
|
13:34:31
|
*** ChanServ sets mode: +o djazayeri
|
13:36:27
|
*** sgithens has joined #openmrs
|
13:42:32
|
*** djazayeri has quit IRC
|
13:45:53
|
<bwolfe> pushkar, stumbled across this today: https://wiki.openmrs.org/display/projects/Upload+and+View+or+Download+Image+or+File+in+HTMLForm+Entry+Module
|
13:46:21
|
<bwolfe> pushkar, your module will be /almost/ providing that once you allow the users to upload their own images it will be the same, right?
|
13:55:14
|
*** sgithens has quit IRC
|
13:56:13
|
*** sgithens has joined #openmrs
|
14:01:01
|
*** cpower has joined #openmrs
|
14:01:42
|
<cpower> Good <insert morning, afternoon, evening here>
|
14:02:22
|
<cpower> are we ready to Scrum?
|
14:02:48
|
<bwolfe> silence means yes?
|
14:03:08
|
<bwolfe> dkayiwa will be missing
|
14:03:16
|
<bwolfe> so just wyclif and rafa?
|
14:03:23
|
<bwolfe> and venkata seems to be missing as well...
|
14:03:24
|
<rafa> hi
|
14:03:28
|
<rafa> I'm here
|
14:03:42
|
<cpower> I guess so... a warm and fuzzy crowd today... Also as a side note whoever knows how to program the OpenMRS bot in IRC I would love to talk with them...
|
14:03:48
|
<wyclif> hi
|
14:03:50
|
<cpower> after the scrum
|
14:04:02
|
<cpower> welcome back Wyclif!
|
14:04:09
|
<bwolfe> r0bby_ might be interested. :-)
|
14:04:09
|
<cpower> and let's get started.
|
14:04:10
|
<wyclif> thanks cpower
|
14:04:20
|
<cpower> !scrumon cpower
|
14:04:20
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
14:04:26
|
<wyclif> Friday:
|
14:04:27
|
<wyclif> * TODOs and Improving the UI of the login page as per the UI mockup darius added
|
14:04:27
|
<wyclif> * Create the calculation tickets below:
|
14:04:27
|
<wyclif> - CALC-32 - Add support for caching of token registrations
|
14:04:27
|
<wyclif> - CALC-33 - Get rid of Evaluators
|
14:04:27
|
<wyclif> - CALC-34 - Maintain state when evaluating calculations
|
14:04:29
|
<wyclif> - CALC-35 - Add support for using iterators as input & output to scale better
|
14:04:31
|
<wyclif> - CALC-36 - Get rid of EmptyCalculationResult
|
14:04:33
|
<wyclif> - CALC-37 - Get rid of the registration package
|
14:04:35
|
<wyclif> * Code review for error logging project
|
14:04:37
|
<wyclif> * Weekly call with Dmitry
|
14:04:39
|
<wyclif> Monday ( Took a sick day after i was down with a reaction to something i ate):
|
14:04:41
|
<wyclif> * Rested and i feel much better now
|
14:04:43
|
<wyclif> Tuesday:
|
14:04:44
|
<r0bby_> Not now but certainly at a later date
|
14:04:45
|
<wyclif> * CALC-37 - Get rid of the registration package
|
14:04:49
|
<wyclif> * CALC-36 - Get rid of EmptyCalculationResult
|
14:04:51
|
<wyclif> * CALC-33 - Get rid of Evaluators
|
14:04:53
|
<wyclif> * pick up another sprint ticket
|
14:04:55
|
<wyclif> Blockers: None
|
14:05:06
|
<bwolfe> are those done or in progress?
|
14:05:57
|
<wyclif> bwolfe, done with CAL-37 just need to commit and will be doing the next 2, CAL-36 should take that long
|
14:06:12
|
<cpower> ok, bwolfe, you can go next
|
14:06:14
|
<wyclif> sorry! shouldn't
|
14:06:52
|
<bwolfe> Monday
|
14:06:52
|
<bwolfe> review restws tickets
|
14:06:52
|
<bwolfe> triaged ERR tickets
|
14:06:52
|
<bwolfe> applied restws-178 for roger (locationtag)
|
14:06:52
|
<bwolfe> reviewed restws-189, float
|
14:06:52
|
<bwolfe> review restws-229
|
14:06:56
|
<bwolfe> review restws-243, subclass framework
|
14:06:58
|
<bwolfe> restws-257
|
14:07:00
|
<bwolfe> Tuesday
|
14:07:02
|
<bwolfe> emails
|
14:07:04
|
<bwolfe> 1.9 test
|
14:07:06
|
<bwolfe> restws-257
|
14:07:08
|
<bwolfe> find projects for NCSU students
|
14:07:10
|
<bwolfe> restws reviews and more tickets
|
14:07:12
|
<bwolfe> (design forum planning...or leave that for cpower+kreddy?)
|
14:07:14
|
<bwolfe> no blockers
|
14:07:22
|
<cpower> Rafa after bwolfe
|
14:07:28
|
<rafa> Today:
|
14:07:28
|
<rafa> //before I went to sleep ;)
|
14:07:28
|
<rafa> * Released Privilege Helper 1.0 and created a wiki
|
14:07:28
|
<rafa> //after I woke up
|
14:07:28
|
<rafa> * Fixed & closed RESTWS-199: Investigate and/or document POST behavior of Patient resource
|
14:07:28
|
<rafa> https://tickets.openmrs.org/browse/RESTWS-199
|
14:07:28
|
<rafa> * Working on RESTWS-260: Add getResourceVersion property
|
14:07:29
|
<rafa> https://tickets.openmrs.org/browse/RESTWS-260
|
14:07:29
|
<rafa> Blockers: I keep getting lost in the RESTWS code :-( It's quite complex now...
|
14:08:03
|
<cpower> Anyone else working on this sprint or wanting to add something...
|
14:09:10
|
<cpower> Summary: Disccusion topics: 1. OpenMRSbot, 2. Design Forum Planning Blockers: RESTWS code
|
14:09:19
|
<cpower> !scrumoff
|
14:09:19
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
14:10:38
|
<cpower> bwolfe, we can flip to google chat for the design chat as to not bore the channel.
|
14:10:45
|
<bwolfe> cpower, r0bby_ has written plugins for supybot before, he might be able to again. (when he has time, apparently)
|
14:10:50
|
*** djazayeri has joined #openmrs
|
14:10:50
|
*** ChanServ sets mode: +o djazayeri
|
14:11:25
|
<cpower> Anyone know how to help rafa from getting lost in RESTWS code ;-) and who knows how to program a bot?
|
14:11:27
|
<r0bby_> I have? No...but I learn quickly
|
14:11:33
|
<bwolfe> cpower, I think downey just added a quick setting for the scrumonscrumoff. no plugin needed for that. its the complex "send email with text' that requires a plugin
|
14:11:41
|
<bwolfe> r0bby_, or was it that you wrote a bot?
|
14:12:01
|
<r0bby_> Nope...well in java
|
14:12:16
|
<r0bby_> I worked on a framework
|
14:12:23
|
<bwolfe> rafa, yes, restws is complex under the hood. the nice thing is that complexity makes things easy for most devs...but adding in new features requires you to have a map of djazayeri's brain. ;-)
|
14:12:29
|
*** djazayeri has quit IRC
|
14:12:38
|
<cpower> So the first target for my bot questions will be downey...check.
|
14:13:03
|
<rafa> bwolfe: haha you put it nicely
|
14:13:19
|
<cpower> wow...I guess djazayeri didn't want to give up a map of his brain.
|
14:14:15
|
<bwolfe> in related news:
|
14:14:24
|
<bwolfe> krispykreme++
|
14:16:07
|
<bwolfe> (my wife just came back from the store with a box of them)
|
14:16:19
|
<cpower> bwolfe: sadly my iron stomach to all foods has one weakness...krispykreme...makes me ill every time.
|
14:17:17
|
<bwolfe> wow, really?
|
14:17:28
|
* bwolfe thinks about eating another donut
|
14:19:05
|
* bwolfe eats another donut
|
14:21:28
|
<cpower> bwolfe, yep exotic food, mexican food, and so on I'm good...put a a Krispycreme and something about that much glazed sugar and I'm done for.
|
14:24:34
|
<bwolfe> unfortunate for you
|
14:24:41
|
<bwolfe> but fortunate for your life expectancy I suppose
|
14:26:54
|
<cpower> No, I think the large amounts of wiskey, hamburgers, and cigars make it a wash.
|
14:58:28
|
<magoo_> hi everyone
|
14:58:51
|
<magoo_> what is the meaning of RESTWS-260
|
14:59:03
|
<bwolfe> !ticket RESTWS-260
|
14:59:04
|
<OpenMRSBot> bwolfe: [#RESTWS-260] Add getResourceVersion property - OpenMRS JIRA - https://tickets.openmrs.org/browse/RESTWS-260
|
14:59:33
|
<bwolfe> magoo_, thats for versioning of rest resources
|
15:00:06
|
<bwolfe> magoo_, so that non-backwards compatible updates are specified somehow
|
15:01:04
|
<magoo_> thanks bwolfe
|
15:03:28
|
*** p_m has quit IRC
|
15:10:34
|
<pushkar> bwolfe, sorry i was away
|
15:10:42
|
<bwolfe> np
|
15:11:10
|
<pushkar> our module will provide uploading images
|
15:11:11
|
<pushkar> part
|
15:12:22
|
<pushkar> but I guess we can include uploading of files as a different tag
|
15:13:14
|
<bwolfe> pushkar, nah
|
15:13:26
|
<bwolfe> pushkar, just images is fine. but after you release your module you should go and make a note on that page
|
15:15:08
|
<pushkar> oh okay
|
15:16:12
|
<pushkar> bwolfe can you name another module which has htmlformentry tag handler in it ?
|
15:16:22
|
<bwolfe> did htmlformflowsheet not have it?
|
15:17:43
|
<pushkar> it has but , but I dont know what all the things that I need and if I have another module I can understand things better
|
15:17:47
|
<bwolfe> this google search: https://www.google.com/search?q=custom+htmlformentry+tag&ie=utf-8&oe=utf-8&client=ubuntu&channel=fs#hl=en&client=ubuntu&hs=Zgw&channel=fs&sclient=psy-ab&q=custom+htmlformentry+tag+openmrs&oq=custom+htmlformentry+tag+openmrs&aq=f&aqi=&aql=1&gs_l=serp.3...12112.12849.0.13020.9.7.0.0.0.0.508.2361.2-1j2j2j1.6.0.eqn%2Crate_low%3D0-015%2Crate_high%3D0-015%2Cmin_length%3D2%2Ccconf%3D0-6%2Csecond_pass%3Dfalse.1.0.0.bqg1fivwBv4&pbx=1&bav=on.2,or.r
|
15:17:47
|
<bwolfe> _gc.r_pw.r_cp.r_qf.,cf.osb&fp=21bc3b000d3b8bdf&biw=1440&bih=657 only gave me a link to what mseaton said yesterday! :-) https://wiki.openmrs.org/display/docs/HTML+Form+Entry+Module+HTML+Reference#HTMLFormEntryModuleHTMLReference-Createyourowncustomtagandhandler
|
15:17:53
|
<OpenMRSBot> <http://ln-s.net/$FIM> (at www.google.com)
|
15:18:14
|
*** suranga has joined #openmrs
|
15:18:14
|
*** ChanServ sets mode: +v suranga
|
15:18:38
|
*** maurya has joined #openmrs
|
15:19:35
|
<bwolfe> pushkar, this page has a "custom tags" section: https://wiki.openmrs.org/display/docs/HTML+Form+Entry+Module+Technical+Overview
|
15:19:40
|
<bwolfe> (second link in the google search)
|
15:23:21
|
<pushkar> bwolfe, whats the _gc.r_pw........
|
15:25:59
|
*** sgithens has quit IRC
|
15:26:40
|
<pushkar> bwolfe, okay got it its the continution of the previous message
|
15:27:22
|
<bwolfe> yeah, didn't notice the extra garbage in the link, sorry
|
15:27:59
|
*** djazayeri has joined #openmrs
|
15:27:59
|
*** ChanServ sets mode: +o djazayeri
|
15:28:21
|
*** r0bby has joined #openmrs
|
15:28:21
|
*** ChanServ sets mode: +v r0bby
|
15:29:42
|
*** robbyoconnor has joined #openmrs
|
15:29:42
|
*** ChanServ sets mode: +v robbyoconnor
|
15:31:33
|
<mgielow> bwolfe, hi
|
15:31:38
|
*** r0bby_ has quit IRC
|
15:31:47
|
<bwolfe> hey
|
15:32:36
|
*** r0bby_ has joined #openmrs
|
15:32:36
|
*** ChanServ sets mode: +v r0bby_
|
15:33:04
|
<mgielow> im still looking for a means to allow user interaction on module installation (as early as possible). is there any module that already does such a thing, that you know of and could point me to?
|
15:34:56
|
*** r0bby has quit IRC
|
15:35:03
|
*** robbyoconnor has quit IRC
|
15:36:54
|
*** djazayeri has quit IRC
|
15:37:30
|
<bwolfe> mgielow, what do you mean?
|
15:37:30
|
*** maurya has quit IRC
|
15:37:39
|
<bwolfe> mgielow, user interaction?
|
15:37:52
|
*** snoppy has joined #openmrs
|
15:37:55
|
<bwolfe> meaning allowing a module to ask questions of the installing user?
|
15:37:57
|
*** harshadura has joined #openmrs
|
15:38:11
|
<mgielow> yes, about that
|
15:38:21
|
<mgielow> like if they want to install sample data
|
15:38:33
|
*** jordank has joined #openmrs
|
15:38:37
|
<mgielow> or change specific global properties
|
15:39:44
|
<bwolfe> if you require a GP config, you can put a taglib onto your jsp pages
|
15:39:44
|
<bwolfe> https://wiki.openmrs.org/display/docs/RequireConfiguration+Taglib
|
15:40:18
|
<bwolfe> other than that there is nothing built in right now
|
15:40:47
|
<bwolfe> a gsoc student did a lot of reworking of the module loading/starting/etc (and the page). I don't know if he added anything like that in or not
|
15:41:00
|
<bwolfe> !seen venkaban
|
15:41:00
|
<OpenMRSBot> bwolfe: venkaban was last seen in #openmrs 16 hours, 34 minutes, and 19 seconds ago: <venkaban> downey Hi
|
15:42:13
|
<mgielow> i see, thanks. so the closest thing to do might be a redirect to a setup page, when any one of the module's pages is first accessed
|
15:43:21
|
*** djazayeri has joined #openmrs
|
15:43:21
|
*** ChanServ sets mode: +o djazayeri
|
15:47:25
|
*** pushkar has quit IRC
|
15:48:32
|
*** yansuck has joined #openmrs
|
15:48:38
|
<yansuck> Hi there
|
15:49:20
|
*** yansuck_ has joined #openmrs
|
15:49:29
|
<yansuck_> Hi there
|
15:49:52
|
*** amepps has joined #openmrs
|
15:49:55
|
<amepps> Hello
|
15:50:03
|
<amepps> Anyone using OpenMRS w/glassfish?
|
15:50:58
|
<amepps> ?
|
15:52:56
|
*** yansuck has quit IRC
|
15:55:12
|
*** amepps has quit IRC
|
15:56:50
|
*** amepps has joined #openmrs
|
16:03:52
|
*** amepps has quit IRC
|
16:14:05
|
<rafa> bwolfe: I can't see comments under tickets, do you know how to display them back?
|
16:16:08
|
*** p_m has joined #openmrs
|
16:17:57
|
*** mvorobey has joined #openmrs
|
16:18:01
|
<mvorobey> hi all
|
16:18:29
|
<rafa> hi mvorobey
|
16:20:02
|
<mvorobey> rafa, how it going ? are you ready to open euro2012 ?
|
16:20:56
|
<rafa> mvorobey: I guess
|
16:20:57
|
*** kreddy has joined #openmrs
|
16:21:37
|
<rafa> mvorobey: I hope to see good games
|
16:22:02
|
<mvorobey> rafa, I wish that Poland win over Greece :)
|
16:22:32
|
<rafa> mvorobey: guess what me too :D
|
16:23:17
|
*** pushkar has joined #openmrs
|
16:23:18
|
<mvorobey> rafa, and furthermore I wish that final will be between our teams :)
|
16:23:50
|
<mvorobey> rafa, but reality is not so optimistic as me :D
|
16:23:51
|
<rafa> mvorobey: haha my faith isn't that strong to see Poland in finals ;)
|
16:24:28
|
*** magoo_ has quit IRC
|
16:25:01
|
<rafa> mvorobey: I don't know much about your team
|
16:25:15
|
<rafa> mvorobey: but wish you good luck :D
|
16:26:01
|
<rafa> mvorobey: as long as we don't play against you ;)
|
16:26:33
|
<mvorobey> rafa, thanks :D our team is as slow as my brain after 12 hours of non-stop coding :D
|
16:27:14
|
<rafa> mvorobey: haha funny, but I still see future for your team :D
|
16:28:07
|
<mvorobey> rafa, even do not know, they are bit nervous and first match with Sweden team will show how is how :)
|
16:29:38
|
*** p_m has quit IRC
|
16:29:38
|
<rafa> mvorobey: ha! Ukraine is 50 in FIFA ranking, Poland 65 :D you're good!
|
16:29:55
|
<mvorobey> rafa, by the way, today our team is playing with Turkish team a comradely game, it would be interesting to see how they are ready, so I'd watch that :)
|
16:30:08
|
<mvorobey> rafa, so, very interesting :)
|
16:30:59
|
<mvorobey> rafa, ok, gotta run, see you later :) thanks for chatting, that is always a big pleasure for me to have cosy discussion with you :)
|
16:31:05
|
<rafa> mvorobey: we've played against Andorra recently and we won :D
|
16:31:26
|
<rafa> mvorobey: but they are at the last position in FIFA ranking ;P
|
16:31:36
|
<mvorobey> rafa, PS Andorra is 250 in FIFA :) ?
|
16:31:38
|
*** pushkar has quit IRC
|
16:31:47
|
<mvorobey> rafa, ok, bye :D
|
16:31:51
|
<rafa> mvorobey: yeah it was nice talking to you!
|
16:31:55
|
<rafa> mvorobey: take care!
|
16:31:55
|
*** mvorobey has quit IRC
|
16:35:20
|
*** venkaban has joined #openmrs
|
16:38:13
|
<bwolfe> rafa, still no comments? did you click the first tab? I saw an error like that on one ticket for me yesterday
|
16:38:36
|
<bwolfe> in another browser tab I clicked a diff tab and then refreshed the first tikcet and it was back. I didn't investigate further at the time
|
16:38:54
|
<rafa> bwolfe: the problem is I don't see any tabs :(
|
16:40:19
|
<rafa> bwolfe: can you give me a link to open some tab?
|
16:40:46
|
<bwolfe> ha, sure. but you need to also open an ITSM ticket. :-)
|
16:40:49
|
*** harshadura has joined #openmrs
|
16:40:50
|
*** mccallumg has joined #openmrs
|
16:40:50
|
*** ChanServ sets mode: +v mccallumg
|
16:40:54
|
<rafa> bwolfe: :)
|
16:41:01
|
<bwolfe> https://tickets.openmrs.org/browse/RESTWS-260?page=com.atlassian.jira.plugin.ext.bamboo:bamboo-build-results-tabpanel#issue-tabs
|
16:41:36
|
<rafa> bwolfe: worked :D
|
16:42:15
|
*** p_m has joined #openmrs
|
16:42:26
|
*** harshadura has quit IRC
|
16:45:55
|
*** sgithens has joined #openmrs
|
16:46:05
|
<bwolfe> rafa, FYI: its the "Reviews" tab in tickets that breaks it
|
16:46:18
|
*** mgielow has quit IRC
|
16:46:23
|
<bwolfe> rafa, put that in yoru ticket. clicking either ALL or REVIEWS makes the tabs disappear
|
16:47:34
|
<rafa> bwolfe: maybe fisheye is down...
|
16:47:46
|
<rafa> bwolfe: nope it works
|
16:48:00
|
*** yansuck_ has quit IRC
|
16:49:13
|
<bwolfe> the plugin or connector probably needs config'd
|
16:50:26
|
*** kavuri has joined #openmrs
|
16:56:39
|
*** rafa has quit IRC
|
16:59:08
|
*** pushkar has joined #openmrs
|
16:59:50
|
*** r0bby_ has quit IRC
|
17:01:03
|
*** maurya has joined #openmrs
|
17:07:08
|
*** suranga has quit IRC
|
17:07:47
|
<bwolfe> venkaban, any questions today?
|
17:07:58
|
<venkaban> bwolfe, Hi
|
17:08:11
|
<venkaban> bwolfe, No I am working on the tickets assigned to me
|
17:08:22
|
<venkaban> bwolfe, sorry I missed today's scrum activity
|
17:11:00
|
<bwolfe> ok
|
17:11:41
|
*** pushkar has quit IRC
|
17:12:41
|
*** djazayeri has quit IRC
|
17:14:21
|
*** goutham has joined #openmrs
|
17:37:31
|
*** goutham has quit IRC
|
18:09:06
|
*** kavuri has quit IRC
|
18:34:43
|
*** venkaban has quit IRC
|
18:38:33
|
*** venkaban has joined #openmrs
|
18:42:26
|
*** dkayiwa has joined #openmrs
|
18:50:48
|
*** venkaban has quit IRC
|
18:58:04
|
*** venkaban has joined #openmrs
|
19:02:43
|
*** p_m has quit IRC
|
19:14:26
|
<wyclif> hi mseaton
|
19:19:18
|
*** jordank has quit IRC
|
19:19:50
|
*** jordank has joined #openmrs
|
19:37:58
|
*** cpower has quit IRC
|
19:38:21
|
*** dkayiwa_ has joined #openmrs
|
19:38:34
|
*** james_regen has left #openmrs
|
19:40:45
|
*** dkayiwa has quit IRC
|
19:40:46
|
*** dkayiwa_ is now known as dkayiwa
|
19:43:41
|
*** maurya has quit IRC
|
20:01:25
|
*** nwilkie has joined #openmrs
|
20:02:26
|
*** nwilkie has quit IRC
|
20:08:36
|
*** goutham has joined #openmrs
|
20:15:20
|
*** snoppy has left #openmrs
|
20:15:57
|
*** bryq has left #openmrs
|
20:27:41
|
<mseaton> hi wyclif
|
20:28:30
|
<wyclif> mseaton, it is fine
|
20:28:38
|
<wyclif> mseaton, never mind
|
20:28:39
|
*** mseaton has left #openmrs
|
20:40:21
|
*** venkaban has quit IRC
|
20:46:40
|
*** sgithens has quit IRC
|
20:57:14
|
*** venkaban has joined #openmrs
|
20:59:59
|
<venkaban> bwolfe, Hi
|
21:01:12
|
<venkaban> bwolfe, I cant find the class file RuntimeException in the package org.openmrs.api
|
21:01:28
|
<venkaban> bwolfe, do you have any idea of where it is
|
21:07:59
|
<venkaban> dkayiwa, Hi
|
21:08:05
|
<dkayiwa> venkaban: hi
|
21:10:34
|
<venkaban> dkayiwa, when we change the methods in an api package, how do we move forward in testing?
|
21:11:10
|
<venkaban> bwolfe, my bad I am thinking too much that we have our own runtimeexception class written, thinking too much here
|
21:11:28
|
<dkayiwa> venkaban: did you mean rename exist api methods?
|
21:11:50
|
<venkaban> dkayiwa, well change the implementation in the methods
|
21:12:12
|
<dkayiwa> venkaban: you run all unit tests and ensure they still pass :)
|
21:12:34
|
<venkaban> is tehre an AllTest.java in our package dkayiwa?
|
21:13:00
|
<dkayiwa> venkaban: i do not think so. just do an mvn clean install
|
21:13:22
|
<venkaban> dkayiwa, clean and then maven install?
|
21:13:49
|
<dkayiwa> venkaban: yes mvn clean install
|
21:14:02
|
<venkaban> dkayiwa thanks
|
21:16:16
|
*** goutham has quit IRC
|
21:19:55
|
*** mccallumg has quit IRC
|
21:25:29
|
<venkaban> dkayiwa : maven install went successfull
|
21:25:41
|
<dkayiwa> venkaban: ok
|
21:25:54
|
<venkaban> dkayiwa : now it will be maven build.. right?
|
21:26:23
|
<dkayiwa> venkaban: meaning???
|
21:27:05
|
<venkaban> dkayiwa: like now we run a maven build.. to deploy it in the jetty right
|
21:27:46
|
<dkayiwa> venkaban: you do not have to
|
21:28:00
|
<dkayiwa> venkaban: after a maven install, it should be ready
|
21:28:09
|
<venkaban> dkayiwa: ok
|
21:31:20
|
*** dkayiwa has quit IRC
|
22:22:08
|
*** djazayeri has joined #openmrs
|
22:22:08
|
*** ChanServ sets mode: +o djazayeri
|
22:25:12
|
<venkaban> Hey djazayeri
|
22:27:15
|
*** djazayeri has quit IRC
|
22:33:39
|
*** djazayeri has joined #openmrs
|
22:33:44
|
*** ChanServ sets mode: +o djazayeri
|
22:34:15
|
*** rafa has joined #openmrs
|
22:34:15
|
*** ChanServ sets mode: +v rafa
|
22:40:22
|
*** jordank has quit IRC
|
22:42:59
|
*** djazayeri has quit IRC
|
22:50:26
|
*** rafa has quit IRC
|
23:03:35
|
*** djazayeri has joined #openmrs
|
23:03:44
|
*** ChanServ sets mode: +o djazayeri
|
23:06:45
|
*** jordank has joined #openmrs
|
23:09:41
|
<venkaban> djazayeri Hi
|
23:09:51
|
<djazayeri> venkaban: hi, in a meeting
|
23:10:10
|
<venkaban> djazayeri, ok
|
23:13:19
|
<bwolfe> venkaban, mvn install in root. then mvn jetty:run in the *webapp* directory
|
23:13:34
|
<bwolfe> (I think thats at the bottom of the maven wiki page)
|
23:13:35
|
<bwolfe> http://wiki.openmrs.org/display/docs/Maven
|
23:13:51
|
<venkaban> bwolfe, I did that
|
23:14:07
|
<venkaban> I changed the exception to beused as per the ticket bwolfe
|
23:15:06
|
<venkaban> bwolfe : and also got the tests run successfully.....so the code change is ready for review I guess which is fairly a straight forward one
|
23:16:08
|
<bwolfe> yeah, its meant to be straight forward
|
23:16:17
|
<bwolfe> attach a patch to the ticket and click the "request code review" button
|
23:16:19
|
<bwolfe> !patches
|
23:16:20
|
<OpenMRSBot> bwolfe: "patches" --- http://openmrs.org/wiki/Patches
|
23:18:59
|
*** rafa has joined #openmrs
|
23:18:59
|
*** ChanServ sets mode: +v rafa
|
23:19:11
|
*** rafa has left #openmrs
|
23:35:05
|
*** kreddy has quit IRC
|
23:39:38
|
<venkaban> bwolfe: I will follow the instructions and submit the patch
|
23:54:29
|
*** djazayeri has quit IRC
|