| 00:32:39 | *** r_friedman_away is now known as r_friedman |
| 01:33:21 | *** nwilkie has quit IRC |
| 01:53:28 | *** didymo has joined #openmrs |
| 02:54:35 | *** r_friedman has quit IRC |
| 03:02:37 | *** pulasthi7 has joined #openmrs |
| 03:37:24 | *** bwolfe has quit IRC |
| 03:51:49 | *** mgielow has quit IRC |
| 04:20:22 | *** Goutham has joined #openmrs |
| 04:27:08 | *** bryq has joined #openmrs |
| 04:27:08 | *** ChanServ sets mode: +v bryq |
| 04:33:13 | *** kishoreyekkanti has joined #openmrs |
| 04:37:27 | *** pushkar has joined #openmrs |
| 04:38:11 | *** suranga has joined #openmrs |
| 04:38:11 | *** ChanServ sets mode: +v suranga |
| 04:38:19 | <suranga> good morning pulasthi7 :) |
| 04:38:44 | <pulasthi7> good morning suranga |
| 04:39:23 | <suranga> pulasthi7, whts the problem u are facing with hibernate ? how far have you gone with it :P |
| 04:39:58 | *** pushkar has quit IRC |
| 04:40:17 | <pulasthi7> suranga, I wanted to know how the hibernate connection is initiated. I tried as it is in somewhere else, but no success :( |
| 04:40:43 | <suranga> pulasthi7, are you creating an entirely new hibernate class ? |
| 04:40:47 | <suranga> mm.. do you need one ? |
| 04:41:07 | <suranga> I thought you would only need to add columns the the exsisting one, isnt it ? |
| 04:41:34 | <pulasthi7> no, I'm not creating new one |
| 04:42:08 | <pulasthi7> I want to use the HibernatePatientDAO class |
| 04:42:55 | <pulasthi7> it has some similar code which i can use in my case |
| 04:43:51 | <suranga> mm.. HibernatePatientDAO class class comes from the core, is it ? |
| 04:43:52 | *** bryq has quit IRC |
| 04:44:06 | <pulasthi7> yes, |
| 04:45:18 | <suranga> so this class is basically an Data bases access layer class, its not really used as a hibernate mapping file, right ? |
| 04:46:12 | <suranga> pulasthi7, im looking at hibernatepatientDao now. what exactly do we need to re-use ? |
| 04:46:30 | <pulasthi7> i can use the getDuplicatePatientsByAttributes method of it with some changes i think |
| 04:47:51 | <suranga> hmm pulasthi7 I can show you how to access that DAO class.. but you cant actually change it, because it lives in the OpenMRS core... |
| 04:48:21 | <pulasthi7> no, I'm not changing it. |
| 04:48:22 | <suranga> if you want to change how the method works, you will need to re-implement it in our module :) |
| 04:48:36 | <suranga> aahh, in that case... itll be ok.. give me a minute |
| 04:48:47 | <pulasthi7> i'm using the changed code in a seperate class |
| 04:50:53 | <pulasthi7> suranga, i'm getting the problem with the sessionFactory |
| 04:51:29 | <suranga> pulasthi7, sorry, i got muddled up... you mean you have a new DAO layer class, and want to link it to the session factory ? |
| 04:52:02 | <pulasthi7> suranga, yes |
| 04:52:19 | <suranga> pulasthi7, aha, so has your DAo got a service layer also ? |
| 04:53:01 | <pulasthi7> suranga, didn't get what you mean |
| 04:53:26 | <suranga> mm.. if you have a new DAo layer class, we need to create a service layer class to call it |
| 04:53:48 | <suranga> for example, we dont call the dao layer directly, it needs to go through th servicer layer |
| 04:54:26 | <pulasthi7> i'm going to call it by the controller class |
| 04:54:31 | <suranga> pulasthi7, for example PatientMatchingReportMetadataServiceImpl is the service layer class for HibernatePatientMatchingReportMetadataDAO |
| 04:54:50 | <suranga> aha, yep, but the good design practise is to have a service layer in bitween |
| 04:55:09 | <suranga> pulasthi7, if you dont use a service layer in between, there will be fireworks with the design team :P |
| 04:55:24 | <pulasthi7> suranga, ah got it now, |
| 04:55:32 | <suranga> pulasthi7, basically , the service layer has an interface, and an implementing class |
| 04:55:48 | <suranga> same with the dao layer too, an interface and an implementing class |
| 04:56:08 | <suranga> contoller calls the servicer layer, which in turn calls the dao layer |
| 04:56:38 | <suranga> pulasthi7, in regard to the session factory, did you see the module Applicationcontext.xml file ? |
| 04:57:58 | <pulasthi7> suranga, i'm looking it now |
| 05:00:26 | <suranga> pulasthi7, the application context takes care of the tricky code |
| 05:00:54 | <suranga> pulasthi7, as you can see, mapping happens inside <bean parent="serviceContext"> |
| 05:01:44 | <suranga> thats where the service + dao mix comes into play |
| 05:05:03 | <pulasthi7> suranga, ok, I'm also having a look at the two classes |
| 05:05:41 | <suranga> pulasthi7, the service layer does not need to have any major code at this point, just something to pass on the call to the dao layer |
| 05:06:21 | <suranga> pulasthi7, something like this is quite valid |
| 05:06:22 | <suranga> public void saveGetEncounterLog(GetEncounterLog getEncounterLog) { |
| 05:06:23 | <suranga> logEncounterDAO.saveGetEncounterLog(getEncounterLog); |
| 05:06:23 | <suranga> } |
| 05:09:35 | *** Goutham_vasiredd has joined #openmrs |
| 05:11:30 | *** maurya has joined #openmrs |
| 05:13:13 | *** Goutham has quit IRC |
| 05:16:36 | <suranga> pulasthi7 please give me a minute.. |
| 05:16:57 | <pulasthi7> suranga, ok |
| 05:25:23 | <suranga> hi pulasthi7 I was looking at the database tables... basically the field names that you need you can get from the field_name column of the configuration_entries, right ? |
| 05:25:40 | <suranga> pulasthi7, (im multi tasking, so might be a bit slow today :P) |
| 05:27:08 | *** maurya has quit IRC |
| 05:28:58 | <pulasthi7> suranga, configuration_entry.getFieldName doesn't give the same as the column name |
| 05:30:32 | <suranga> hmm.. pulasthi7 my guess is that somewhere in the patientmatching code, james egg has figured out a way to use the field Name as a column name, since he probably needed to do that anyway.... it should be there somewhere, so we'll have to find it, I guess :P |
| 05:30:54 | <suranga> pulasthi7, we can try looking for how James Egg did it. if we cant find it, we can ask him tonight :) |
| 05:31:27 | <pulasthi7> suranga, yes, I think it's mapped to message.properties file |
| 05:31:39 | <pulasthi7> *messages |
| 05:32:29 | <pulasthi7> i'll try to find where and how it is done |
| 05:33:21 | <suranga> pulasthi7, you are right, but thats only for some of the attributes, I think... |
| 05:33:56 | <suranga> pulasthi7, since James needed to do this too, he probably figured out something. So we could try asking him later (if we cant find it) |
| 05:34:18 | <suranga> pulasthi7, no problem, what are you working on now, the DAO access work ? |
| 05:34:36 | <pulasthi7> suranga, yes |
| 05:35:14 | <suranga> cool. Once you do that, try to get it working for hard coded names (if you cant figure out how James did it) |
| 05:35:33 | <suranga> pulasthi7, that way we can have something in hand to show anyone... |
| 05:35:55 | <pulasthi7> suranga, ok |
| 05:36:05 | <suranga> after we resolve the field names -> column names problem, we can get ritd of the hard coded stuff... |
| 05:36:25 | <suranga> pulasthi7, no need to hard code ALLL the columns, just one or two see if it works... |
| 05:37:42 | <pulasthi7> suranga, ah, ok, I had already done some hardcoding |
| 05:37:47 | *** Goutham_vasiredd has quit IRC |
| 05:38:51 | <suranga> pulasthi7, cool... and also, regarding the bi directional mapping problem. I was looking at the hibernate file, and it seems to be bi- directional. can you name a method signature that you would like to have in the dao layer ? |
| 05:40:47 | *** kishoreyekkanti_ has joined #openmrs |
| 05:41:39 | *** kishoreyekkanti_ has quit IRC |
| 05:41:55 | *** kishoreyekkanti_ has joined #openmrs |
| 05:42:29 | *** kishoreyekkanti has quit IRC |
| 05:44:30 | <pulasthi7> suranga, what is that file? is it PatientMatchingConfiguration.hbm.xml? |
| 05:45:03 | <suranga> pulasthi7, and configurationEntry.hbm.xml |
| 05:46:21 | <suranga> pulasthi7, hmm.. yes, the configEntry class does have getters and setters for PatientMatchingConfiguration.java .... |
| 05:46:51 | *** Goutham_vasiredd has joined #openmrs |
| 05:50:27 | *** maurya has joined #openmrs |
| 05:50:45 | <maurya> hi didymo |
| 05:50:48 | <maurya> hi djazayeri |
| 05:51:21 | <didymo> maurya afternoon |
| 05:51:38 | <maurya> sorry was trying for darius |
| 05:56:55 | *** Goutham_vasiredd has quit IRC |
| 06:00:32 | *** Goutham has joined #openmrs |
| 06:07:59 | *** djazayeri has quit IRC |
| 06:12:04 | *** kishoreyekkanti has joined #openmrs |
| 06:13:56 | *** kishoreyekkanti_ has quit IRC |
| 06:18:07 | *** dkayiwa has joined #openmrs |
| 06:20:42 | *** Goutham has quit IRC |
| 06:27:31 | *** goutham has joined #openmrs |
| 06:33:46 | *** maurya has quit IRC |
| 06:37:17 | <goutham> Dkayiwa, hi |
| 06:37:25 | <dkayiwa> Goutham: hi |
| 06:38:51 | <goutham> Dkayiwa , can you tell me how the user interface should be there in selecting a form |
| 06:39:50 | <dkayiwa> Goutham: you are the one to come up with it :) |
| 06:40:03 | *** suranga has quit IRC |
| 06:40:05 | <dkayiwa> Goutham: then you give me to review :) |
| 06:41:33 | <goutham> Dkayiwa, i thought of a drop down list initially but if there are hundreds of forms then it would be difficult to user |
| 06:41:45 | <dkayiwa> Goutham: ok |
| 06:42:56 | <goutham> Dkayiwa ,how about doing it similar to one in patient dashboard form entry tab |
| 06:43:12 | <dkayiwa> Goutham: that would be awesome!!! :) |
| 06:44:01 | <dkayiwa> Goutham: by letting you be the designer, we benefit from your creativity :D |
| 06:44:45 | <goutham> Dkayiwa, B-) thanks |
| 06:46:58 | <goutham> Dkayiwa, do you think iam going bit slow ? |
| 06:47:39 | <dkayiwa> Goutham: i think your speed is still fair :) |
| 06:49:45 | *** suranga has joined #openmrs |
| 06:50:12 | <goutham> Dkayiwa, :-) |
| 06:51:07 | <goutham> Dkayiwa, so i am going to write a new portlet |
| 06:51:37 | <dkayiwa> Goutham: ok |
| 07:01:20 | *** deepa_ has joined #openmrs |
| 07:01:44 | *** maurya has joined #openmrs |
| 07:17:00 | *** kishoreyekkanti has quit IRC |
| 07:17:14 | *** kishoreyekkanti has joined #openmrs |
| 07:22:23 | *** goutham has quit IRC |
| 07:22:30 | *** Goutham_vasiredd has joined #openmrs |
| 07:24:42 | *** bryq has joined #openmrs |
| 07:24:42 | *** ChanServ sets mode: +v bryq |
| 07:30:01 | *** Goutham_vasiredd has quit IRC |
| 07:32:54 | <maurya> dkayiwa: hi |
| 07:34:36 | *** deepa_ has quit IRC |
| 07:39:11 | *** maurya has quit IRC |
| 07:48:09 | *** rafa has joined #openmrs |
| 07:48:09 | *** ChanServ sets mode: +v rafa |
| 08:07:49 | *** pulasthi7 has quit IRC |
| 08:10:26 | *** sunbiz has joined #openmrs |
| 08:10:26 | *** ChanServ sets mode: +v sunbiz |
| 08:12:49 | *** mgielow has joined #openmrs |
| 08:21:38 | *** snoppy has joined #openmrs |
| 08:23:53 | *** magoo_ has joined #openmrs |
| 08:34:14 | *** ShellZero has joined #openmrs |
| 08:37:42 | *** Goutham_vasiredd has joined #openmrs |
| 08:38:09 | <ShellZero> Hey rafa |
| 08:38:21 | <rafa> ShellZero: hi |
| 08:38:33 | *** ShellZero is now known as applecool |
| 08:38:43 | <applecool> i commented on the line on github |
| 08:38:47 | <applecool> please check |
| 08:38:58 | <applecool> or shall i tell it here why i removed them? |
| 08:39:20 | <rafa> applecool: I get notifications from github you don't have to notify me here :) |
| 08:39:25 | <rafa> applecool: yes, remove them |
| 08:39:32 | <applecool> hehe! :) |
| 08:39:38 | <applecool> yeah i removed them :) |
| 08:39:41 | <applecool> right? |
| 08:39:48 | <rafa> applecool: right |
| 08:39:56 | <rafa> applecool: and the other comments too |
| 08:40:18 | <applecool> ok sure i will remove them |
| 08:44:34 | <applecool> rafa: is my work satisfactory ? |
| 08:44:54 | <applecool> are there any mistakes in my last commit ? |
| 08:45:29 | <rafa> applecool: it was just a few lines :) no mistakes |
| 08:45:50 | <applecool> cool :) Thanks rafa :) |
| 08:46:02 | <rafa> applecool: but we need to speed up |
| 08:46:07 | <applecool> yes |
| 08:46:10 | <applecool> so rafa what would be the next task! adding the packages to the database and listing them in pagination right? |
| 08:46:10 | *** mgielow has quit IRC |
| 08:46:19 | <rafa> applecool: I'm writing you an e-mail :) |
| 08:46:25 | <applecool> okay cool :) |
| 08:47:37 | <applecool> rafa: i have one more request! can we change our scrum timings to 4:30 ! i meant 1 hr late? |
| 08:47:48 | <rafa> applecool: sure |
| 08:48:04 | <applecool> i have got classes till 4:00 at my school |
| 08:48:09 | <applecool> so :) |
| 08:48:10 | <rafa> applecool: starting today? |
| 08:48:40 | <applecool> yeah classes are starting from today ! actually it starts at 2:00 PM here |
| 08:48:41 | <rafa> applecool: you want to have it an hour later starting from today? |
| 08:48:48 | <rafa> applecool: okay |
| 08:49:00 | <applecool> yes :) |
| 08:49:06 | <applecool> is it okay ? |
| 08:49:29 | <rafa> applecool: sure |
| 08:49:39 | <applecool> thanks a lot rafa :) |
| 08:55:50 | <applecool> rafa: now got an error after changing "/" to "/login" ! ! Now the error is in the web-tests.xml ! |
| 08:55:51 | <applecool> http://pastebin.com/1fbsAhz8 |
| 08:56:25 | <applecool> actually before it is showing an error in the line 2 of the login.xmlf right? |
| 08:56:55 | *** dkayiwa has quit IRC |
| 08:57:17 | *** dkayiwa has joined #openmrs |
| 08:57:39 | <rafa> applecool: you pasted only 2 lines? |
| 08:58:36 | <rafa> applecool: which page do you see when you click log out? |
| 08:58:39 | <applecool> yes! do you want to see the entire stack trace? |
| 08:58:46 | <applecool> http://pastebin.com/WtSUFqCg |
| 08:59:05 | <applecool> just a sec! |
| 09:01:53 | <applecool> when i logout its going to mainMenu ! the welcome page |
| 09:02:06 | <applecool> http://localhost:8080/mainMenu |
| 09:02:23 | <rafa> applecool: then you see why your test is failing |
| 09:02:35 | <rafa> applecool: it expects to go back to the login page |
| 09:02:49 | <applecool> hmm. |
| 09:02:51 | <rafa> applecool: it's actually fine to go back to the main menu |
| 09:03:01 | <rafa> applecool: so change the test to expect the main menu |
| 09:03:19 | <rafa> applecool: the error tells you exactly which line to change |
| 09:03:57 | <applecool> but the same line is even there in the login.xmlf file too |
| 09:04:00 | <applecool> which is the 2nd line |
| 09:04:07 | <applecool> so even i need to change that right? |
| 09:04:35 | <rafa> applecool: why? |
| 09:04:46 | <rafa> applecool: you don't have an error in login.xmlf, do you? |
| 09:04:56 | <applecool> nope i dont have |
| 09:05:10 | <applecool> but from that place it is verifying right? |
| 09:05:15 | <rafa> applecool: okay, let's look at the login.xmlf test |
| 09:05:30 | <rafa> applecool: the first line: <invoke description="get Login Page" url="/login"/> |
| 09:05:40 | <rafa> applecool: it tells you to go to the login page |
| 09:05:45 | <applecool> yes |
| 09:05:46 | <rafa> applecool: <verifytitle description="we should see the login title" text=".*${login.title}.*" regex="true"/> |
| 09:06:02 | <rafa> applecool: it tells you to verify the login page was displayed correctly |
| 09:06:08 | <applecool> okay! |
| 09:06:38 | <rafa> it searches the returned page to find ".*{login.title}.*" |
| 09:06:56 | <applecool> ok |
| 09:06:58 | <rafa> applecool: if it finds it then it passes otherwise you'd see an error |
| 09:07:09 | <rafa> <setinputfield description="set user name" name="j_username" value="admin"/> |
| 09:07:09 | <applecool> ok! |
| 09:07:27 | <rafa> this line fills out the login form |
| 09:07:39 | <rafa> it sets "j_username" filed to "admin" |
| 09:07:43 | <rafa> <setinputfield description="set password" name="j_password" value="admin"/> |
| 09:07:48 | <rafa> this line sets password |
| 09:07:53 | <rafa> <clickbutton label="${button.login}" description="Click the submit button"/> |
| 09:07:59 | <rafa> we click a submit button :) |
| 09:08:06 | <applecool> cool! :) |
| 09:08:14 | <rafa> <verifytitle description="Home Page follows if login ok" text=".*${mainMenu.title}.*" regex="true"/> and we test we're show the main page |
| 09:08:38 | <rafa> now in web-tests.xml you can see line:33 |
| 09:08:59 | <applecool> yes seeing |
| 09:09:01 | <applecool> :) |
| 09:09:34 | <rafa> <webtest name="login"> |
| 09:09:56 | <rafa> it brings us to the login page |
| 09:10:03 | *** bryq has quit IRC |
| 09:10:03 | <applecool> yes :) |
| 09:10:12 | <rafa> &config; |
| 09:10:21 | <rafa> does some configuration :) |
| 09:10:26 | <rafa> and then you have steps |
| 09:10:32 | <rafa> first is &login; |
| 09:10:54 | <rafa> which executes exactly what is in the login.xmlf file |
| 09:11:04 | <applecool> it invokes the logout now |
| 09:11:11 | <rafa> yes |
| 09:11:21 | <rafa> and it verifies <verifytitle description="we should see the login title" text=".*${login.title}.*" regex="true"/> |
| 09:11:21 | <applecool> and verifies whether it is going to login or not |
| 09:11:26 | <applecool> yup |
| 09:11:36 | <rafa> applecool: correct, but we actually go back to the main page not the login page |
| 09:11:36 | <applecool> but here it is not going hence we are getting error |
| 09:11:45 | <applecool> ;) |
| 09:11:55 | <rafa> applecool: which is what we want |
| 09:12:03 | <applecool> so the only change we need to do is to change the *${login.title}.* to mainMenu.title |
| 09:12:03 | <rafa> applecool: so we need to correct the test |
| 09:12:16 | <rafa> yes, and the description ;) |
| 09:12:34 | <applecool> description? |
| 09:12:44 | *** nadee has joined #openmrs |
| 09:12:47 | <applecool> yeah yeah got it |
| 09:12:47 | <rafa> description="we should see the login title" |
| 09:13:16 | <applecool> done! i will run and see :P |
| 09:18:24 | <nadee> hi, im trying to create a module using the module wizard, im on the page https://wiki.openmrs.org/display/docs/Using+the+Module+Maven+Archetype , but when i run the mvn -s [path to settings.xml] its giving the error that goal for maven is not specified |
| 09:18:25 | <OpenMRSBot> <http://ln-s.net/9$wo> (at wiki.openmrs.org) |
| 09:19:00 | <nadee> could someone pls point me which goal, i sould specify? |
| 09:19:57 | <applecool> nadee: i guess you need to create a settings.xml file in .m2 folder |
| 09:21:00 | <nadee> yeah, but there s an option said in the page .. without editing the user preferences overall, u can set the setting.xml anywhere (as i understood ) |
| 09:21:13 | <nadee> am i missing something applecool? |
| 09:21:52 | <applecool> hmm.. you are on linux Ubuntu right? |
| 09:22:05 | <nadee> nah, im on windows, |
| 09:22:21 | <applecool> windows! oops i donno! |
| 09:22:23 | <nadee> see the line 'using -s ' |
| 09:22:53 | <nadee> :) thats not a prob, there s a .m2 in windows as well |
| 09:23:12 | <applecool> nadee: yes i know! |
| 09:23:16 | <nadee> :) |
| 09:23:58 | <sunbiz> hi nadee... where are u typing the mvn command?? |
| 09:24:25 | <nadee> inside the folder i need to create a project |
| 09:24:39 | <nadee> i havent created a project yet though |
| 09:24:47 | <sunbiz> mvn -s <settings-xml path> |
| 09:24:52 | <nadee> yeah |
| 09:24:52 | <sunbiz> that is fine... |
| 09:24:55 | <nadee> tried that |
| 09:25:04 | <sunbiz> u need to do mvn -s C:\settings.xml |
| 09:25:09 | <sunbiz> if its located in C |
| 09:25:24 | <nadee> thats what told me no goals etc |
| 09:25:26 | <nadee> see http://pastebin.com/NKqw0eYZ |
| 09:25:34 | <nadee> pastebin |
| 09:25:44 | <nadee> :( i dont get where im running wrong |
| 09:25:58 | <sunbiz> ohhh... blocked by court orders for me... pastebin |
| 09:26:00 | <sunbiz> :( |
| 09:26:23 | <nadee> court orders? |
| 09:26:28 | <nadee> :) |
| 09:26:36 | <sunbiz> sorry... might b my ISP in India |
| 09:26:40 | <applecool> sunbiz: use https: it should work |
| 09:26:45 | <nadee> i see |
| 09:26:54 | <applecool> if you use https ! |
| 09:27:04 | <sunbiz> do u know that there are no spaces |
| 09:27:17 | <sunbiz> between the - and s |
| 09:27:26 | <sunbiz> also u may try --settings |
| 09:27:30 | <nadee> so for you guys the 'goal error' didnt come? |
| 09:28:18 | <sunbiz> IM using mavn 2.2.1 |
| 09:28:54 | <rafa> nadee: can you paste the full log together with the command you give? |
| 09:28:57 | <nadee> hmm im on maven 3 though |
| 09:29:03 | <nadee> sure |
| 09:30:27 | <nadee> rafa : http://pastebin.com/GMXxQtjF |
| 09:31:13 | <rafa> nadee: the command should be: mvn -s settings.xml module-wizard:generate |
| 09:31:22 | <sunbiz> nadee: thats odd... |
| 09:31:28 | <sunbiz> rafa: just -s is fine |
| 09:31:28 | <rafa> nadee: asssuming you have settings.xml in the same directory |
| 09:31:38 | <nadee> oops that was a mistake , wait wrong paste |
| 09:31:40 | <nadee> :) |
| 09:33:06 | <nadee> rafa : http://pastebin.com/66BJR6Jj |
| 09:33:14 | <nadee> extreamly sorry :) |
| 09:33:16 | *** finbrein has joined #openmrs |
| 09:33:22 | <rafa> nadee: still the same... |
| 09:33:53 | <nadee> rafa : pastebin is mvn 3 |
| 09:34:03 | *** Goutham_vasiredd has quit IRC |
| 09:34:19 | <nadee> the command i gave is mvn -s settings.xml |
| 09:34:28 | <rafa> nadee: I stil see you use "mvn -s settings.xml" instead of "mvn -s settings.xml module-wizard:generate" |
| 09:34:41 | <rafa> nadee: that's your mistake |
| 09:34:48 | <nadee> ohh |
| 09:35:16 | <nadee> rafa : alright.. but the wiki said "If you prefer not to modify your user Maven settings, you can point to temporal settings by specifying the -s parameter mvn -s path_to_settings.xml" |
| 09:35:41 | <nadee> :( |
| 09:36:24 | <nadee> rafa : and.. seperately it said "Run the following maven plugin command mvn module-wizard:generate" |
| 09:36:41 | <nadee> i didnt know it had to be combined |
| 09:36:59 | <nadee> thanks a lot for letting me knw rafa :) |
| 09:37:03 | <rafa> nadee: it's what I'm telling you :) |
| 09:37:18 | <sunbiz> rafa: no it doesnt have to be combined |
| 09:37:24 | <sunbiz> its a normal maven command... |
| 09:37:32 | <sunbiz> I just tried it... it works with 3.0.4 and 2.2.1 |
| 09:37:43 | <rafa> sunbiz: but you need to give maven a goal! |
| 09:37:53 | <sunbiz> nope... Im not running a mven build |
| 09:37:59 | <applecool> rafa: got about 3 more errors due to the login.title ! which i made them pass! |
| 09:38:04 | <sunbiz> Im giving maven a command-line arg to run |
| 09:38:23 | <applecool> now i got a new error on line 208! which is for the fileupload verification! |
| 09:38:24 | <rafa> sunbiz: yes, but what's the point of giving only -s? |
| 09:38:28 | <sunbiz> rafa: so no need for any goal |
| 09:38:32 | <sunbiz> mvn --help |
| 09:38:58 | <sunbiz> this doesn't need any targets... just like mvn --version |
| 09:39:25 | <applecool> rafa: http://pastebin.com/ibVNUrnA check this! |
| 09:39:29 | <sunbiz> nadee: seems like some prob with the way u have maven installed... |
| 09:39:52 | <nadee> yah but building/downloading stuff we need to give a goal afaik |
| 09:40:02 | <rafa> sunbiz: again what's the point? :) |
| 09:40:11 | <sunbiz> nadee: yes... for building u need a target |
| 09:40:35 | <nadee> help and version are basic commands which does not need a target |
| 09:40:36 | <sunbiz> rafa: the point is that we should be able to just run mvn -s settings.xml... works for me |
| 09:40:48 | <nadee> rafa : yeah thanks to you its downloading now |
| 09:40:50 | <nadee> :) |
| 09:40:57 | <sunbiz> similar -s doesn't need a target coz its not on ur source files :D |
| 09:41:14 | <rafa> nadee: you're welcome |
| 09:41:22 | <rafa> sunbiz: yeah, but it doesn't do anything alone :P |
| 09:41:34 | <sunbiz> it puts the settings to ur maven repo :P |
| 09:41:49 | <rafa> sunbiz: no it's just a temporal hint |
| 09:41:58 | <rafa> sunbiz: for the current command |
| 09:42:34 | <rafa> applecool: correct that test |
| 09:42:37 | <sunbiz> rafa: so I use that with the mvn deploy command |
| 09:42:45 | <applecool> rafa: yup yup! |
| 09:42:49 | <applecool> i think i got it! |
| 09:42:53 | <applecool> just a sec :) |
| 09:42:57 | <sunbiz> so that I can deploy artifacts to the OpenMRS nexus repo |
| 09:50:09 | <applecool> rafa: http://pastebin.com/UBvCFnPC |
| 09:50:26 | <applecool> i changed it ! but at the end i got an error !!! where do i change this! |
| 09:51:41 | <rafa> applecool: seriously? It tells you the exact line.... :) |
| 09:52:00 | <applecool> i can see that line! but i am confused! :( |
| 09:52:08 | <rafa> <verifytext description="verify original filename displayed on page" text="pom.xml"/> |
| 09:52:16 | <applecool> yes! |
| 09:52:31 | <rafa> so when I upload a file I'm taken to the package form right? |
| 09:52:41 | <applecool> yes exactly |
| 09:53:01 | <rafa> applecool: that means I won't see the original filename there |
| 09:53:13 | <rafa> applecool: so just remove this assumption |
| 09:53:21 | <applecool> hmm |
| 09:53:28 | <applecool> meaning the entire line? |
| 09:53:31 | <rafa> yes |
| 09:54:48 | <rafa> applecool: whenever you change behavior you need to change tests |
| 09:54:58 | <applecool> hmm! |
| 09:55:02 | <rafa> applecool: if you don't have to change tests it means tests are not good enough! |
| 09:55:21 | <applecool> yes got it :) |
| 09:55:55 | <rafa> applecool: don't forget to commit when you fix them all |
| 09:56:06 | <applecool> yup! i wont :) |
| 09:56:16 | <applecool> just saw your mail :) |
| 09:57:07 | <rafa> applecool: this time I gave you as much details as possible |
| 09:57:38 | <rafa> applecool: but again ask questions if something is unclear |
| 09:57:54 | <applecool> yes got it :) |
| 09:58:13 | <applecool> i will ask if i have any doubts! and will avoid bad commits ;) |
| 09:58:42 | <rafa> applecool: commits are never bad ;) |
| 09:59:05 | <applecool> i was referring to the images stuff which i did :P |
| 09:59:27 | <applecool> rafa:that was seriously a mess :D |
| 09:59:57 | <rafa> applecool: ok, I won't argue on that :P |
| 10:00:04 | <applecool> hehe! :D |
| 10:02:49 | <rafa> nadee: I've corrected https://wiki.openmrs.org/display/docs/Using+the+Module+Maven+Archetype. Is it clear enough now? |
| 10:03:28 | <nadee> rafa: oh yes |
| 10:03:34 | <nadee> its cool now |
| 10:03:36 | <nadee> :) |
| 10:03:56 | <rafa> nadee: good |
| 10:04:05 | <rafa> nadee: thx |
| 10:20:52 | <applecool> rafa: :( bad commit |
| 10:21:01 | <rafa> applecool: haha |
| 10:21:03 | <applecool> once again :( damn |
| 10:21:11 | <rafa> applecool: are you using egit? |
| 10:21:13 | <applecool> i undo it |
| 10:21:30 | <applecool> i revert that commit! |
| 10:21:45 | <applecool> and i committed it again and pushed it! |
| 10:22:05 | <applecool> na i have egit! but i am doing it from terminal itself |
| 10:22:40 | <rafa> applecool: maybe gui will be easier for you ;) |
| 10:23:20 | <applecool> nooo |
| 10:23:24 | <applecool> i like terminal |
| 10:23:37 | <rafa> applecool: up to you :) |
| 10:24:02 | *** bryq has joined #openmrs |
| 10:24:02 | *** ChanServ sets mode: +v bryq |
| 10:24:25 | <applecool> i love terminal! but didnt check that file rafa! i checked it only the admin of the resources folder but i dint check the web/webapp/resources/user |
| 10:24:27 | <applecool> damn |
| 10:25:49 | <applecool> rafa: oh no ! i cant see the changed files! |
| 10:26:04 | <rafa> applecool: leave them |
| 10:26:10 | <applecool> ? |
| 10:26:25 | <applecool> i changed the web-tests.xml! can you see those changes? |
| 10:27:51 | <applecool> rafa: yes i can see them! |
| 10:28:06 | *** mgielow has joined #openmrs |
| 10:28:59 | <rafa> applecool: it's too late to get rid of the commits |
| 10:29:09 | <rafa> applecool: you'll have to live with them ;) |
| 10:29:35 | <applecool> sad sad sad! |
| 10:29:45 | <rafa> applecool: be careful in the future |
| 10:29:59 | <applecool> yup! very very careful! got it! |
| 10:30:13 | <applecool> i already said this but made a mistake again! :( :| |
| 10:30:21 | <applecool> but i wont do it from now :D |
| 10:30:51 | <rafa> applecool: also please give more meaningful commit messages |
| 10:31:06 | <applecool> hmm! |
| 10:31:08 | <applecool> okay |
| 10:31:26 | *** nadee has quit IRC |
| 10:31:43 | <applecool> so for today! how it should be ? instead of "Tests passed"? :) |
| 10:32:13 | <rafa> applecool: "Fixed login page tests" |
| 10:32:37 | <applecool> okay cool! Got it :) i need to use some more commonsense :D |
| 10:32:48 | <rafa> applecool: and the last commit "Removed a mistakenly added picture" ;) |
| 10:33:02 | <applecool> :D |
| 10:33:51 | <rafa> applecool: ok, you're all set for today right? |
| 10:34:01 | <applecool> yes! |
| 10:34:20 | <applecool> so what would you suggest rafa? with which task should i move on? |
| 10:34:36 | <rafa> applecool: 1. |
| 10:34:41 | <applecool> okay! :) |
| 10:34:52 | <rafa> applecool: I ordered them for you ;) |
| 10:35:07 | <applecool> cool :) thanks :) :D |
| 10:40:21 | <applecool> rafa: will goto have lunch and start coding |
| 10:40:23 | <applecool> :) |
| 10:40:42 | <applecool> will be back rafa :) |
| 10:41:33 | *** applecool has quit IRC |
| 10:44:31 | *** finbrein has quit IRC |
| 10:51:21 | *** james_regen has joined #openmrs |
| 10:51:21 | *** ChanServ sets mode: +v james_regen |
| 11:02:58 | *** mgielow has quit IRC |
| 11:11:39 | *** didymo has quit IRC |
| 11:17:20 | <suranga> good morning james_regen .. umm... Pulasthi and I were having a slight problem with the module, and were hoping to ask you something .... |
| 11:17:32 | <suranga> james_regen, any chance for a quick question or two ? :) |
| 11:30:54 | <james_regen> suranga: sure |
| 11:31:10 | *** r_friedman has joined #openmrs |
| 11:32:26 | *** goutham has joined #openmrs |
| 11:34:45 | <r_friedman> rafa, thanks for the quick response. I think it might have been just a language issue. "I add" would not have had the same implications as "I'm adding" |
| 11:35:10 | <rafa> r_friedman: yes, I've figured :) sorry for the confusion |
| 11:35:26 | <r_friedman> if that's the worst thing you've ever done, more power to you, rafa :) |
| 11:35:28 | <suranga> ah, thanks james_regen . its been a long time :-) |
| 11:35:33 | <suranga> james_regen, when we store a configuration entry in the xml or database / the name is stored as something like ... |
| 11:35:33 | <suranga> (Patient) Date of Birth or (Patient) Death Date etc. etc. |
| 11:35:33 | <suranga> We were working on task number 2, and we need to find a way to convert this into the variables that they represent. |
| 11:35:33 | <suranga> for example, |
| 11:35:35 | <suranga> (Patient) Date of Birth needs to be converted into something like patient.getDateOfBirth(); etc. |
| 11:35:37 | <suranga> We know you have implemented this somewhere to get the patientmatching working, so we were hoping that you could point us to exactly where this is happening :-) |
| 11:35:51 | <sunbiz> BTW... can some one please try the newly release patientimage module and click and see if the image is shown in the dashboard |
| 11:36:27 | <sunbiz> some1 was not able to see the images in dashboard although it gets uploaded to the applicationdatadirectory correctly |
| 11:36:35 | <sunbiz> Im not able to reproduce the issue |
| 11:36:49 | <sunbiz> and hence not able to solve that implementation's problem |
| 11:37:04 | <sunbiz> patientimage 0.4 |
| 11:37:31 | <james_regen> suranga: you mean how we're accessing it in the module currently when we import it into the scratch table? |
| 11:38:21 | <suranga> james_regen, as in how I can take this string attribute, and use it to get the data that I want... for example |
| 11:39:09 | <suranga> james_regen, as in, if (Patient) Date of Birth attribute is set to 'must match' how does the code identify that it needs to look in patient.getdateofbirth() to get the required value ? :-) |
| 11:41:34 | <james_regen> suranga: oh, i understand now. i need to read more carefully. i'll have to look at the code. i know there's a convention used in going from field name to display name, like the Java object gets put in the parentheses and then there's some way of going from the org.openmrs.Patient.dateofbirth -> (Patient) Date of Birth strings. i'm not sure if there's a method to go the other direction . . .. |
| 11:42:47 | <suranga> james_regen, I see... um.. in that case,for patientmatching purposes, how do you compare the database data with the attributes ? |
| 11:43:06 | <suranga> james_regen, I guess you needed to do this too at one stage, right ? |
| 11:45:17 | <james_regen> are the easily read values for the fields the same as what's in the configuration object and the scratch table column names? i can see the field names being changed to something human readable as the information is read from the database or just on the web page for display purposes, and the code still uses the more cmplicated, explicit names |
| 11:47:09 | <suranga> james_regen, it uses the easily read names, im afraid :( |
| 11:47:34 | <james_regen> suranga: actually, thinking about it more, i'm not sure there is knowledge on what OpenMRS method is used by the time we get to storing the configuration |
| 11:48:28 | <james_regen> the module uses org.regenstrief.linkage objects, and all there has to be is one method of converting between OpenMRS Patient objects and Record objects. as long as that same method is used, then the values and field names will be created consistiently |
| 11:49:33 | <suranga> james_regen, but umm.. for patientmatching purposes (when the time comes to create a final report using strategies) how do you take the configuration entry attribute and match them with the correct data ? |
| 11:49:45 | <suranga> james_regen, terrbly sorry, but I got rather muddled there :) |
| 11:50:45 | <james_regen> suranga: you mean how (Patient) Date of Death ends up with Patient p.getDateofDeath() instead of p.getGender(), for example? |
| 11:51:00 | <suranga> james_regen, exactly ! :) |
| 11:51:20 | <suranga> james_regen, we need to figure out how this identification is made :) |
| 11:53:32 | <james_regen> suranga: i think it's because there is only one patientToRecord() method. so for Patient object p1, Record r = patientToRecord(p1); results in a Record with the values assigned in a certain way. since it's a deterministic process, calling Record r2 = patientToRecord(p1); results in the same values going into the same fields, even if it's called in some other step of the process |
| 11:55:39 | <james_regen> suranga: i feel like i'm answering your quesiton without answering the real question or something |
| 11:56:28 | <suranga> james_regen, let me try to re-phrase that... please give me 5 minutes :) |
| 11:57:11 | <james_regen> suranga: okay. i can see how this one way process has worked until now, but needs to be able to go the other way since finding the number of pairs requires getting information out of the configuration setup |
| 11:59:31 | *** bwolfe has joined #openmrs |
| 11:59:31 | *** ChanServ sets mode: +o bwolfe |
| 12:00:07 | *** mgielow has joined #openmrs |
| 12:00:55 | <suranga> james_regen, basically, what we need to do is, take the user defined strategy, read in the attributes, and extract the paired data. for example, (Patient) Date of Death should return a date object. then we need to compare these data to see if they match. |
| 12:00:55 | <suranga> So do you mean that we cant do this using the exsisting system ? |
| 12:01:59 | <james_regen> suranga: i think we need to add a bit more code. i think information is lost when we got from openmrs Patient objects to Record objects as far as where each field is coming from |
| 12:02:33 | *** bryq has quit IRC |
| 12:03:17 | <suranga> james_regen, ummm... I really dont understand how this is different from the normal patientmatching work that gets done... |
| 12:03:55 | <suranga> james_regen, doesnt it happen the same way ? |
| 12:06:06 | <james_regen> suranga: i can't think of a place currently in the module where configuration information is needed to do something on objects other than Record objects, where the field names and values will match up because they've all been created the same way in the same method. is there something that does that? |
| 12:07:14 | *** mgielow has quit IRC |
| 12:08:16 | <suranga> james_regen, umm... so we are working with Record objects too, right ? |
| 12:09:28 | <suranga> james_regen, during the de duplication process given in the MatchingReportUtils class, you will at some stage need to read in all the database data, and compare them with the must match and should match column too, isnt it ? |
| 12:10:46 | <suranga> james_regen, for example, you are generating a strategy. you have a ton of patient objects to compare. how do you figure out that patient.getDateOfBirth() is a must match column ? |
| 12:12:04 | <bwolfe> dkayiwa, when bug fixing, try to ignore ones labeled as "intro" |
| 12:12:14 | <dkayiwa> bwolfe: ok |
| 12:12:49 | <james_regen> suranga: yes, and as it's read into the table for matching, it'll be labeled in a way to match the fields given in the strategy. so the process is Patient -> Record to get a list of fields the module has found that's available for matching. you can choose "(Patient) Date of Birth" as a must match column. when the matching process is run to create a report, the same Patient -> Record process is called, and the same named "(Patient) Date of Birt |
| 12:14:16 | <james_regen> suranga: the patientToRecord method used in the Patient -> Record process is what knows where to get the information (or better put, maybe how to label the information it finds to (Patient) Date of Brith since it tries to find everything about a Patient). i don't think there's any working backwords to work with patient objects directly until now |
| 12:14:40 | *** harshadura has joined #openmrs |
| 12:16:14 | *** nwilkie has joined #openmrs |
| 12:16:35 | <suranga> james_regen, umm.. thats sounds great. so cant we use your system for our work ? (Sorry, maybe I missed something) |
| 12:16:39 | <suranga> but this sounds fine to me... |
| 12:17:10 | <suranga> james_regen, we read into the table for matching, it'll be labeled in a way to match the fields given in the strategy... |
| 12:18:34 | <james_regen> suranga: no, we can figure out how to go the other direction. there's still one bit fo information from one certain object's field or an attribute value being renamed into just one Record object field. as patientToRecord does it's thing, instead of letting it throw that process information way, we can add code to keep track of where things came from |
| 12:19:37 | <suranga> james_regen, i think I will need to go back and re-read this entire conversation again. I dont think i really understood it totally.. |
| 12:19:56 | <suranga> james_regen, but in the meanwhile, mm.... do you have an idea on how to fix this ? :) |
| 12:21:57 | <james_regen> suranga: add two new methods, one of which patientToRecord will call so we keep this code in one place and use the same code for both directions. the other method . . . hang on, i think i forgot whay i think we need a second one |
| 12:23:13 | <james_regen> suranga: i guess if it was a good idea it'll be thought of again. i can write down what i'm thinking of for this first method, and see if it makes sense and i can try to explain what it does |
| 12:23:58 | <suranga> james_regen, that would be really awesome ! it would really help us out ! :-) |
| 12:31:56 | *** kishoreyekkanti has quit IRC |
| 12:37:38 | *** nwilkie_ has joined #openmrs |
| 12:38:23 | *** nwilkie_ has left #openmrs |
| 12:38:41 | *** nwilkie_ has joined #openmrs |
| 12:40:14 | *** nwilkie__ has joined #openmrs |
| 12:41:16 | *** nwilkie has quit IRC |
| 12:41:16 | *** nwilkie_ is now known as nwilkie |
| 12:57:55 | <suranga> james_regen, hi... james_regen , would it be ok if we asked you some more questions later ? :) |
| 12:58:18 | <james_regen> suranga: sure. i just sent an email with what i was thinking, i hope it makes sense |
| 12:58:37 | <suranga> james_regen, I just saw the alert. totally coool |
| 12:58:49 | <suranga> james_regen, thanks a lot, Im going to read it now :) |
| 13:01:31 | *** downey has joined #openmrs |
| 13:01:31 | *** ChanServ sets mode: +o downey |
| 13:01:31 | *** OpenMRSBot sets mode: +o downey |
| 13:02:50 | <bwolfe> rafa, does restws compile for you? classHierarchyResourceTest fails on line 68 for me on removeProperty |
| 13:02:59 | *** magoo_ has quit IRC |
| 13:03:08 | <rafa> bwolfe: I haven't tried yet |
| 13:03:11 | <bwolfe> doesn't look like a java 1.7 method, so not sure where he is getting that... |
| 13:03:16 | <bwolfe> let me try a clean install |
| 13:03:22 | <bwolfe> perhaps I have some weirdness with my update |
| 13:03:26 | <rafa> bwolfe: finishing privilegehelper... |
| 13:03:30 | <bwolfe> ok |
| 13:05:34 | *** downey has quit IRC |
| 13:05:46 | *** downey has joined #openmrs |
| 13:05:46 | *** ChanServ sets mode: +o downey |
| 13:05:46 | *** OpenMRSBot sets mode: +o downey |
| 13:10:05 | *** magoo_ has joined #openmrs |
| 13:11:42 | <r_friedman> nwilkie, back |
| 13:13:27 | <suranga> hi rafa |
| 13:13:35 | <rafa> suranga: hi |
| 13:13:47 | <suranga> rafa, any chance for quick question on metadata :-) |
| 13:13:57 | <suranga> rafa a really short one :P |
| 13:14:02 | <rafa> suranga: sure |
| 13:14:42 | <rafa> suranga: short question, but a long answer ;) |
| 13:15:28 | <suranga> when exporting concepts using metadata module, I can pick the ones I want one by one. if so, will the module automatically export all the other answer concepts, mappings and sources that I dont explicitely pick, but I'd be wanting anyway ? |
| 13:15:42 | <suranga> sorry, rafa ^^^ |
| 13:15:54 | <rafa> yes :) |
| 13:15:59 | <rafa> that was short :D |
| 13:16:07 | <suranga> ahaha... thanks rafa :p |
| 13:16:29 | <rafa> you're very welcome |
| 13:16:31 | <suranga> rafa, see, thats the benifit of answering my well thought out and awesome questions :-D |
| 13:16:36 | <rafa> I like such questions :D |
| 13:17:41 | <rafa> suranga: awesome people ask awesome questions ;) |
| 13:19:08 | <suranga> rafa, ha haa.. 'wannabe awesomes' like me ask awesome questions. Already awesoms like ben and Darius dont need to ask any questions at all :) |
| 13:19:18 | *** mgielow has joined #openmrs |
| 13:30:00 | *** harshadura has quit IRC |
| 13:30:25 | *** sunbiz1 has joined #openmrs |
| 13:30:28 | *** mgielow has quit IRC |
| 13:30:36 | *** maurya has joined #openmrs |
| 13:31:16 | *** mgielow has joined #openmrs |
| 13:32:12 | *** sunbiz has quit IRC |
| 13:37:49 | *** maurya has quit IRC |
| 13:43:22 | *** harshadura has joined #openmrs |
| 13:43:25 | *** jordank has joined #openmrs |
| 13:44:49 | *** goutham has quit IRC |
| 13:52:27 | *** cpower has joined #openmrs |
| 13:56:37 | <snoppy> hi all! |
| 13:56:53 | *** venkaban has joined #openmrs |
| 13:57:52 | <snoppy> I've just updated openmr with tha latest changes in trunk. And after rebuild I can't start openmrs |
| 13:58:26 | <snoppy> I got an error related with database updates |
| 13:58:28 | *** kavuri has joined #openmrs |
| 13:58:35 | <snoppy> https://gist.github.com/2868540 |
| 13:59:12 | <venkaban> bwolfe, Hi |
| 13:59:21 | <bwolfe> good morning venkaban |
| 13:59:26 | <snoppy> can anybody help? |
| 13:59:37 | *** jordank has quit IRC |
| 13:59:38 | <suranga> hi snoppy , whats the error ? |
| 13:59:40 | <venkaban> bwolfe, I am having trouble in setting up my development environment |
| 14:00:04 | <snoppy> suranga: hi, suranga! https://gist.github.com/2868540 |
| 14:00:09 | <rafa> snoppy: you need to execute: delete from liquibasechangelog where id = "10-insert-new-app-privileges" |
| 14:00:13 | <venkaban> bwolfe, when I do maven install I am getting the errors during the run for tests |
| 14:00:29 | <bwolfe> venkaban, test errors or just text output errors? |
| 14:00:32 | <rafa> snoppy: for all three changesets |
| 14:00:44 | <venkaban> bwolfe, as there is more work scheduled this week, I want this to be fixed immediately |
| 14:00:54 | <venkaban> bwolfe, the test errors |
| 14:01:21 | <bwolfe> venkaban, can you pastebin the errors? are you using java 1.6? did you try a clean install at the root? |
| 14:01:23 | <venkaban> bwolfe, I have jdk 1.6.0 |
| 14:01:33 | <venkaban> bwolfe, I did |
| 14:02:13 | <cpower> Good mornng/afternoon people! |
| 14:02:16 | <suranga> snoppy, please heed the wise words of rafa ^^^ :-) |
| 14:02:29 | <bwolfe> venkaban, ok, pastebin what you see |
| 14:02:35 | <cpower> Are we ready to start our game show called Scrum? |
| 14:02:45 | <bwolfe> big money big money.... |
| 14:02:53 | <snoppy> rafa, suranga: ok. thanks |
| 14:03:35 | <cpower> Let's do it! |
| 14:03:40 | <cpower> !scrumon cpower |
| 14:03:40 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 14:04:26 | <cpower> Order: Rafa, bwolfe, dkayiwa, and Wyclif! come on down |
| 14:04:32 | *** kavuri has quit IRC |
| 14:04:36 | <rafa> Today: |
| 14:04:36 | <rafa> * Sprint preparations |
| 14:04:36 | <rafa> * Had a longer GSoC chat |
| 14:04:36 | <rafa> * Applied requested changes to |
| 14:04:36 | <rafa> !ticket TRUNK-3366 |
| 14:04:36 | <rafa> * Working on releasing privilegehelper and creating some wiki |
| 14:04:36 | <rafa> No blockers. |
| 14:04:37 | <OpenMRSBot> rafa: [#TRUNK-3366] Create module for recording privilege checks - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3366 |
| 14:04:59 | *** mseaton has joined #openmrs |
| 14:04:59 | *** ChanServ sets mode: +v mseaton |
| 14:05:38 | <bwolfe> rafa, ready to focus on this week now? is the module done? |
| 14:06:01 | <rafa> bwolfe: yes, just need to release it and create a wiki |
| 14:06:12 | <rafa> bwolfe: will finish today |
| 14:06:15 | <bwolfe> great |
| 14:06:23 | <bwolfe> before today would be better ;-) |
| 14:06:29 | *** jordank has joined #openmrs |
| 14:06:36 | <bwolfe> Friday |
| 14:06:36 | <bwolfe> created/edited rest tickets |
| 14:06:36 | <bwolfe> call with suranga/jembi about hl7 output |
| 14:06:36 | <bwolfe> set up next sprint with kiran |
| 14:06:36 | <bwolfe> review mvorobey's tag |
| 14:06:37 | <bwolfe> email to venkaban |
| 14:06:39 | <bwolfe> restws ticket comments |
| 14:06:41 | <bwolfe> Monday |
| 14:06:45 | <bwolfe> review restws tickets |
| 14:06:47 | <bwolfe> triaged ERR tickets |
| 14:06:49 | <bwolfe> applied restws-178 for roger (locationtag) |
| 14:06:51 | <bwolfe> reviewed restws-189, float |
| 14:06:53 | <bwolfe> review restws-229 |
| 14:06:55 | <bwolfe> no blockers |
| 14:07:20 | <dkayiwa> Reviewed and applied patch for: Warnings when running ForgotPasswordFormControllerTest - TRUNK-2556 |
| 14:07:20 | <dkayiwa> Tried but failed to reproduce: Searching for observations without filling out the optional search parameter question concept returns empty result set - TRUNK-3282 |
| 14:07:20 | <dkayiwa> Created ticket: TRUNK-3404 |
| 14:07:21 | <dkayiwa> Committed: Retired Visit types appear on the New Visit form - TRUNK-3370 |
| 14:07:21 | <dkayiwa> Committed: Cannot unretire identifier type - TRUNK-2980 |
| 14:07:21 | <dkayiwa> Finishing: BaseContextSensitiveTest does not create Core Global Properties - TRUNK-3028 |
| 14:07:22 | <dkayiwa> And then concentrate on releasing 1.9 |
| 14:07:22 | <dkayiwa> No Blockers |
| 14:09:01 | <cpower> Oh Wyclif.... |
| 14:11:14 | <cpower> ok so at this point I'm going to say Wyclif is not available and will give us an update later. |
| 14:11:32 | <cpower> Anyone else have something to add to today's Scrum? |
| 14:12:22 | <cpower> Summary: No Blockers or Discussion points |
| 14:12:29 | <cpower> !scrumoff |
| 14:12:29 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 14:12:43 | *** bwolfe has quit IRC |
| 14:13:00 | *** bwolfe has joined #openmrs |
| 14:13:00 | *** ChanServ sets mode: +o bwolfe |
| 14:13:46 | <bwolfe> sorry, dropped my connection for some reason. |
| 14:16:20 | <bwolfe> downey, its annoying that the bot only updates the wiki every 30 mins. can't see what I missed yet |
| 14:16:48 | * downey slides OpenMRSBot a coffee |
| 14:17:57 | <dkayiwa> bwolfe: downey yes i too wish that could be made less than 30mins |
| 14:19:54 | <dkayiwa> bwolfe: just asking to confirm, was it agreed that i should just go ahead and release 1.9? Was waiting for the PIH email about testing results .... |
| 14:20:12 | <venkaban> bwolfe, here is the link to the error http://pastebin.com/iQyeMGgB |
| 14:20:24 | *** kavuri has joined #openmrs |
| 14:21:32 | <bwolfe> mseaton, any chance pih's testing is at a place where they have confirmed 1.9's upgradability? I know there are a few minor bugs found, but those are showstoppers, are they? |
| 14:21:54 | <bwolfe> mseaton, if you can email the dev list about that, then dkayiwa can use that as the second "real world tester" of the RC |
| 14:22:03 | <mseaton> bwolfe, ok |
| 14:22:10 | <bwolfe> (you can just reply to his email a long ways back asking for testers) |
| 14:22:31 | <dkayiwa> bwolfe: did you mean dev or implementers list? or even both? :) |
| 14:23:13 | <bwolfe> I assume you sent it to the impl list... |
| 14:23:20 | <dkayiwa> bwolfe: yes |
| 14:25:02 | <venkaban> bwolfe, did you check the link I sent you |
| 14:27:56 | <bwolfe> missed it. looking now |
| 14:29:02 | <snoppy> suranga: Are you here? |
| 14:29:16 | <bwolfe> venkaban, known issue with your version of the jdk. see this post from the mailing list: http://openmrs-mailing-list-archives.1560443.n2.nabble.com/Source-code-compilation-error-td7384420.html |
| 14:29:18 | <bwolfe> "This was a problem of JDK version used. Previously I was using 1.6.0_17, once upgraded in to the 1.6.0_30 it works as expected" |
| 14:29:20 | <OpenMRSBot> <http://ln-s.net/$Eww> (at openmrs-mailing-list-archives.1560443.n2.nabble.com) |
| 14:29:29 | *** pushkar has joined #openmrs |
| 14:31:13 | <venkaban> bwolfe, which version of jdk you have? |
| 14:32:30 | <bwolfe> ben@thinkben:~$ java -version |
| 14:32:30 | <bwolfe> java version "1.6.0_25" |
| 14:32:30 | <bwolfe> Java(TM) SE Runtime Environment (build 1.6.0_25-b06) |
| 14:32:30 | <bwolfe> Java HotSpot(TM) 64-Bit Server VM (build 20.0-b11, mixed mode) |
| 14:35:55 | *** bryq has joined #openmrs |
| 14:35:55 | *** ChanServ sets mode: +v bryq |
| 14:36:08 | *** kavuri has quit IRC |
| 14:39:24 | <snoppy> I created a new module and removed 2  messages_XX.properties files. When I try to upload this module I get error message "No message properties file messages_fr.properties for language fr". Is  messages_fr.properties file must to be in module for uploading it? |
| 14:40:22 | <snoppy> Is settings only EN locale |
| 14:40:41 | <snoppy> *In settings |
| 14:40:56 | *** suranga has quit IRC |
| 14:43:20 | <bwolfe> snoppy, you have to edit hte config.xml file too. its probably still referencing those message files |
| 14:45:05 | <snoppy> bwolfe: oh, yes! you are right! Thanks bwolfe! |
| 14:45:34 | <snoppy> I forgot for it) |
| 14:51:01 | *** pulasthi7 has joined #openmrs |
| 14:53:20 | *** deepa_ has joined #openmrs |
| 14:53:32 | <downey> Hi deepa_ and welcome to the #openmrs IRC channel. |
| 14:53:39 | *** kavuri has joined #openmrs |
| 14:59:00 | *** bwolfe has quit IRC |
| 14:59:06 | *** bwolfe_ has joined #openmrs |
| 14:59:06 | *** ChanServ sets mode: +o bwolfe_ |
| 15:00:34 | *** kavuri has quit IRC |
| 15:02:33 | *** cpower has quit IRC |
| 15:05:31 | *** bwolfe__ has joined #openmrs |
| 15:05:31 | *** bwolfe_ has quit IRC |
| 15:10:45 | *** bwolfe__ is now known as bwolfe |
| 15:10:51 | *** ChanServ sets mode: +o bwolfe |
| 15:14:12 | *** kavuri has joined #openmrs |
| 15:15:04 | <pushkar> bwolfe, hi |
| 15:15:25 | <bwolfe> hey |
| 15:16:10 | <pushkar> how was your weekend ? |
| 15:16:16 | *** magoo_ has quit IRC |
| 15:17:21 | <bwolfe> too short |
| 15:18:23 | <dkayiwa> :) |
| 15:18:28 | <bwolfe> yours? |
| 15:20:52 | <pushkar> great! went to mib3 |
| 15:21:06 | <pushkar> :-) |
| 15:23:57 | *** judy has joined #openmrs |
| 15:24:14 | *** maurya has joined #openmrs |
| 15:24:32 | *** magoo_ has joined #openmrs |
| 15:25:19 | *** sunbiz1 has quit IRC |
| 15:28:46 | *** magoo_ has quit IRC |
| 15:31:21 | <kavuri> I am trying to create an encounter for a patient, but am a bit lost. I created a visit, under which there is a "Add encounter". It asks to enter the encounter id,patient name or id. But I do not have earlier encounters. How can I provide such info |
| 15:31:37 | *** rafa has quit IRC |
| 15:32:42 | <bwolfe> kavuri, hmm, perhaps we need to adjust that now that we have encounters |
| 15:33:01 | <bwolfe> the "visits" tab replaced the "encounters" tab if you have the GP "visits.enabled" set to true. (which is the default) |
| 15:33:23 | <bwolfe> on the only "encounters" tab there was an "Add Encounter" link. This was a shortcut for adding a form. |
| 15:33:44 | <bwolfe> kavuri, for now, go to the formentry tab and fill out a new form for the patient |
| 15:33:48 | <bwolfe> 1 form == 1 encounter |
| 15:34:11 | *** harshadura has quit IRC |
| 15:34:39 | <kavuri> bwolfe: for now I am going to the admin page and adding an encounter from "Manage encounters" |
| 15:34:50 | <kavuri> bwolfe: is this something that is being changed? |
| 15:35:51 | *** deepa_ has quit IRC |
| 15:36:26 | <bwolfe> kavuri, visits are new in 1.9. so this seems to be one of the hiccups: workflow adjustment |
| 15:36:47 | <bwolfe> kavuri, using manage encounters is a very non-user friendly way. :-) |
| 15:36:53 | <bwolfe> the formentry tab is the "correct" way |
| 15:38:29 | <kavuri> bwolfe: agreed. In my view, the better way would be to go from the patient and add an encounter |
| 15:45:16 | <pushkar> bwolfe, if we create a global propety then we should create a dropdown instead of putting a textbox for typing in a concept |
| 15:48:10 | *** mseaton has quit IRC |
| 15:48:14 | *** mseaton1 has joined #openmrs |
| 15:51:14 | *** venkaban has quit IRC |
| 15:54:29 | <downey> jordank: just a reminder to send in your gsoc report from friday as soon as you get a moment. thanks. :) |
| 15:55:20 | <jordank> downey: will do! thanks |
| 15:57:18 | *** harshadura has joined #openmrs |
| 15:59:45 | *** sunbiz has joined #openmrs |
| 15:59:46 | *** ChanServ sets mode: +v sunbiz |
| 16:02:07 | *** sunbiz has left #openmrs |
| 16:02:08 | *** mgielow has quit IRC |
| 16:02:30 | <dkayiwa> hi bwolfe |
| 16:04:41 | <downey> dkayiwa, mseaton1 - just a reminder to send in your gsoc report from friday when you get a chance. thanks. :) |
| 16:09:38 | <mseaton1> downey, url please? |
| 16:10:07 | *** judygichoya has joined #openmrs |
| 16:10:18 | <downey> Hi judygichoya and welcome to the #openmrs IRC channel. |
| 16:12:18 | *** judygichoya has quit IRC |
| 16:12:31 | *** judy has quit IRC |
| 16:12:56 | *** judygichoya has joined #openmrs |
| 16:21:06 | *** mseaton1 has quit IRC |
| 16:21:06 | *** dkayiwa has quit IRC |
| 16:21:07 | *** wyclif has quit IRC |
| 16:22:42 | *** kavuri has quit IRC |
| 16:23:58 | *** nwilkie has quit IRC |
| 16:26:52 | <bwolfe> pushkar, it can still be an autocomplete textbox. you would just be giving the type of things to be searched to the autocomplete. |
| 16:27:04 | *** kreddy has joined #openmrs |
| 16:27:08 | <bwolfe> pushkar, you'd probably also want to set the "show list on focus" property to true so the user can see the list without having to search |
| 16:30:47 | *** dkayiwa has joined #openmrs |
| 16:30:47 | *** wyclif has joined #openmrs |
| 16:34:53 | *** kavuri has joined #openmrs |
| 16:35:42 | *** dkayiwa has quit IRC |
| 16:36:13 | *** dkayiwa has joined #openmrs |
| 16:44:34 | *** mccallumg has joined #openmrs |
| 16:44:34 | *** ChanServ sets mode: +v mccallumg |
| 16:44:36 | *** dkayiwa has quit IRC |
| 16:45:16 | *** dkayiwa has joined #openmrs |
| 16:45:38 | *** pulasthi7 has quit IRC |
| 16:53:27 | *** mseaton has joined #openmrs |
| 16:53:44 | *** ChanServ sets mode: +v mseaton |
| 17:03:37 | *** dkayiwa has quit IRC |
| 17:05:57 | *** magoo_ has joined #openmrs |
| 17:06:21 | *** dkayiwa has joined #openmrs |
| 17:10:01 | *** magoo_ has quit IRC |
| 17:13:53 | *** suranga has joined #openmrs |
| 17:13:53 | *** ChanServ sets mode: +v suranga |
| 17:14:20 | *** goutham has joined #openmrs |
| 17:15:44 | <pushkar> bwolfe, " you would just be giving the type of things to be searched to the autocomplete ". I didnt get this line ben |
| 17:16:22 | <bwolfe> type == list |
| 17:16:53 | <bwolfe> I think there is a way to tell a concept autocomplete to only allow the user to search/choose from a specified list |
| 17:17:22 | <pushkar> yes bu grouping using class |
| 17:17:39 | <pushkar> I have already done that |
| 17:17:55 | <pushkar> *by |
| 17:18:52 | <pushkar> so you are saying that we shopuld be able to select from the list of concepts provided by the global property ?? |
| 17:20:19 | <pushkar> and not by using class? |
| 17:20:51 | *** goutham has quit IRC |
| 17:22:56 | *** dkayiwa has quit IRC |
| 17:25:00 | <pushkar> bwolfe, |
| 17:25:47 | <bwolfe> pushkar, if the admin hasn't defined any concepts for the users to choose from, yes, select by class as you have |
| 17:26:43 | <bwolfe> hmm, maybe there isn't a way to tell an autocomplete what speciifc concept ids are selectable |
| 17:27:03 | <bwolfe> I know you can tell an autocomplete that the only valid selections are the answers to concept_id x |
| 17:27:08 | <bwolfe> but thats not what you want to do |
| 17:27:32 | <bwolfe> so sure, if hte admin defines some concepts, make it a dropdown box |
| 17:29:45 | <pushkar> bwolfe, so should i create a customportlet controller to get the values or is there any other way ?? |
| 17:29:56 | <pushkar> of the concepts |
| 17:31:12 | <pushkar> i mean the concept ids that were defined in global property |
| 17:33:52 | *** harshadura has quit IRC |
| 17:38:34 | *** mvorobey has joined #openmrs |
| 17:38:40 | <mvorobey> hi all |
| 17:39:37 | <bwolfe> pushkar, there is a taglib to use. openmrs:globalProperty. you can use that in your portlet jsp without needing a customc ontroller |
| 17:42:40 | *** r_friedman has quit IRC |
| 17:43:46 | <pushkar> bwolfe, Thanks :-) |
| 17:44:04 | <mvorobey> bwolfe, hi |
| 17:44:24 | <bwolfe> hey |
| 17:44:44 | <mvorobey> bwolfe, need to talk a bit :) |
| 17:45:03 | <bwolfe> ok |
| 17:46:46 | <mvorobey> bwolfe, you commented on TRUNK-3402 that I can use WebConstants.WEBAPP_NAME instead of passing in the contextPath as a variable, but context path could be openmrs-1.6.x for example, does that constant class covers that case ? |
| 17:52:06 | *** venkaban has joined #openmrs |
| 17:52:39 | <bwolfe> yes, it is set at startup by the Listener class. (its a non-constant constant. :-)) |
| 17:55:00 | *** sgithens has joined #openmrs |
| 17:56:35 | <mvorobey> bwolfe, hah, very temporal constant, so can I use it for my purposes, right ? |
| 17:56:42 | <bwolfe> yes |
| 17:58:14 | <mvorobey> bwolfe, do I need recreate review again or you can commit new patch just from first glance :) ? |
| 17:59:08 | <bwolfe> no review needed |
| 18:06:24 | *** venkaban has quit IRC |
| 18:08:29 | <mvorobey> bwolfe, great, it works for me, am not tiring just to say that you are genius :) |
| 18:10:47 | <suranga> bwolfe, hi, mmm... me again :P |
| 18:11:09 | <suranga> bwolfe, Wayne has created a user account in jembi Jira just for you ! :-) |
| 18:13:16 | *** dkayiwa has joined #openmrs |
| 18:15:21 | <mvorobey> suranga, hi, seems that we lost bwolfe :) |
| 18:16:21 | <suranga> mvorobey, I hope not ! he's too valuable too loose.... In fact, I was looking for him to get him to do something for us :P |
| 18:16:35 | <suranga> poor bwolfe :) |
| 18:16:36 | *** jordank has quit IRC |
| 18:16:42 | <mvorobey> suranga, :D |
| 18:17:40 | <mvorobey> suranga, see that you are an early bird today, are not you ? |
| 18:17:51 | <suranga> mvorobey, I always wondered... when ben and Darius come up with a dev. question, who do they ask for help ? :P |
| 18:18:12 | <bwolfe> suranga, I have the account, did you add me to that review yet? |
| 18:18:36 | <bwolfe> mvorobey, its easy to look like a genius when you were the one to write the code. :-) |
| 18:19:00 | <suranga> aha, hi bwolfe I tried to, but I dont think you have activated your account yet... I cant seem to find you on the users list :( |
| 18:19:13 | <bwolfe> "ben" is the username he gave me |
| 18:19:13 | <mvorobey> suranga, it would be twice wonder if they'd ask for help from us :) |
| 18:20:07 | <mvorobey> bwolfe, what did you meant ? |
| 18:21:32 | <bwolfe> mvorobey, I mean I wrote the webapp_constants and Listener stuff (many years ago). so I knew it was there |
| 18:21:35 | <mvorobey> meant = mean |
| 18:22:28 | <mvorobey> bwolfe, then this means that you are genius, and don't say that you are not :) |
| 18:22:32 | <suranga> bwolfe, I cant seem to find you on the jira... do you need to set up a user profile etc. to be visible ? |
| 18:22:42 | <suranga> bwolfe, not sure if you can log into this ? http://jira.jembi.org/source/cru/CR-SHRADAP-2 |
| 18:23:17 | <bwolfe> suranga, I am logged in on that already. but I cannot add myself to the review |
| 18:24:11 | <suranga> bwolfe, mm.. I just created this new review... did you check this, or are you speaking about the older one ? |
| 18:24:48 | <bwolfe> I was talking about #1. but this new #2 looks the same |
| 18:29:07 | <suranga> bwolfe, hmm.. terrible, it seems that theres been a mess up, and I cant add you... hmmm\ |
| 18:29:18 | <suranga> bwolfe, I will need to get back to you on this :( |
| 18:41:12 | <mvorobey> bwolfe, so, would you like to apply that little patch for me now or a bit later ? :) |
| 18:44:58 | <bwolfe> mvorobey, ha, do you need it asap for some reason? you can continue your coding off of your own version :-) |
| 18:47:33 | *** suranga has quit IRC |
| 18:48:19 | <mvorobey> bwolfe, for any reason I do not need it ASAP :) if you will have a time for this during couple of next months, it would be more than great :-) I just said it because my local copy of Openmrs has lots of patches and when am doing every next patch it becomes harder to filter out what I Need to include into new patch :) |
| 18:49:11 | <bwolfe> ha |
| 18:49:19 | <bwolfe> git would make that easier for you |
| 18:50:20 | <dkayiwa> bwolfe: did you say i release from the 1.9.0-RC4 tag? |
| 18:51:09 | <bwolfe> yes, because 1.9.x already has changes. since RC4. so either you copy that tag or you tag 1.9.x at whatever revision RC4 tagged it at |
| 18:51:12 | <mvorobey> bwolfe, yep, it would be great to use git but now am using svn and it's a bit sad |
| 18:52:08 | <dkayiwa> bwolfe: ok |
| 18:53:55 | *** venkaban has joined #openmrs |
| 18:54:57 | <dkayiwa> bwolfe: ever got this error? You don't have a SNAPSHOT project in the reactor projects list. -> [Help 1] |
| 18:55:13 | <dkayiwa> bwolfe: that is when i try to release from the 1.9.0-RC4 tag |
| 18:55:23 | <dkayiwa> bwolfe: it wants it to be a snapshot |
| 18:56:21 | <dkayiwa> bwolfe: am using: mvn release:prepare -Dusername=<scm-username> -Dpassword=<scm-password> -B -DreleaseVersion=1.9.0 -Dtag=1.9.0 -DdevelopmentVersion=1.9.0-RC4 |
| 18:56:26 | <bwolfe> you're trying to do a release:prepare ? |
| 18:56:38 | <bwolfe> dunno |
| 18:56:45 | <bwolfe> I haven't relelased from a tag before |
| 18:56:53 | <dkayiwa> bwolfe: ok |
| 18:57:05 | <bwolfe> check its documentatoin yet? http://maven.apache.org/plugins/maven-release-plugin/ |
| 18:57:11 | <OpenMRSBot> <http://ln-s.net/$F2Y> (at maven.apache.org) |
| 18:57:20 | <dkayiwa> bwolfe: ok |
| 18:59:29 | *** james_regen has quit IRC |
| 18:59:49 | <mseaton> bwolfe, dkayiwa: is there any way to do a release:prepare and skip tests? i tried the -DskipTests option on the release:prepare, but it didn't take... |
| 19:00:04 | <dkayiwa> mseaton: i have never tried it |
| 19:00:35 | <dkayiwa> mseaton: i suspect it is by design to force you run the tests :) |
| 19:01:02 | <bwolfe> agreed |
| 19:01:28 | <dkayiwa> though i do not like maven's forcing me about the good practises :) |
| 19:01:38 | <dkayiwa> needs to be a bit more flexible |
| 19:01:57 | <dkayiwa> dont like computer controlling me :( |
| 19:02:38 | <dkayiwa> bwolfe: i suspect it could be the same with you have to release from a snapshot :( |
| 19:04:13 | <bwolfe> hopefully not |
| 19:06:07 | <mseaton> unfortunately serialization.xstream unit tests are seriously hosed. but we really shouldn't release a snapshot in a bundled module... |
| 19:06:10 | *** snoppy has quit IRC |
| 19:06:53 | <mseaton> dkayiwa, bwolfe: what version of serialization.xstream is in 1.9 right now? |
| 19:07:11 | <bwolfe> dkayiwa, you might be able to release:perform. or just copy the tag manually, check out the new tag, make the pom changes (and commit to a tag, which is bad practice), then do an mvn deploy |
| 19:07:29 | <dkayiwa> mseaton: 0.2.5 |
| 19:07:39 | <bwolfe> dkayiwa, or you can rollback all 1.9.x changes. do the release. then reapply the 1.9.x changes |
| 19:07:39 | <dkayiwa> bwolfe: ok |
| 19:07:39 | <mseaton> ok |
| 19:07:49 | <dkayiwa> bwolfe: ok |
| 19:09:04 | *** kavuri has quit IRC |
| 19:09:21 | <mseaton> bwolfe, if there is space in the catch-up sprint, knocking off the 6 open sxs tickets would be good. that module has no owner and gets absolutely no love or testing, yet it is bundled in the release and required by reporting... |
| 19:11:30 | <bwolfe> not really room in the sprint. but we should make sure that it is in the bug fixing swim lane tickets |
| 19:13:42 | <mvorobey> bwolfe, put the exact versions into wiki page as you've asked for :) |
| 19:14:55 | <bwolfe> great, closing the ticket now! |
| 19:17:24 | <mvorobey> bwolfe, awesome, please, accept my grace :) thanks, Ben, a lot! |
| 19:29:34 | *** suranga has joined #openmrs |
| 19:29:34 | *** ChanServ sets mode: +v suranga |
| 19:31:13 | <suranga> hi mm.. bwolfe have you ever heard of anyone upgrading from openmrs 1.6.5 to 1.8.3 ? :-) |
| 19:31:29 | <suranga> bwolfe, has that worked out ? |
| 19:31:48 | <bwolfe> I'm sure it happens all the time |
| 19:32:03 | <bwolfe> but if you wait about 2 days dkayiwa will have 1.9.0 released and you can jump to that. :-) |
| 19:34:00 | <suranga> bwolfe, no worries, thanks for the info...Im about to try this out now :-) |
| 19:35:17 | *** mvorobey has quit IRC |
| 19:35:18 | *** harshadura has joined #openmrs |
| 19:41:52 | *** jordank has joined #openmrs |
| 19:45:32 | *** venkaban has quit IRC |
| 19:54:24 | *** maurya has quit IRC |
| 20:00:43 | *** burke has joined #openmrs |
| 20:00:43 | *** ChanServ sets mode: +o burke |
| 20:01:55 | <burke> bwolfe: just updated trunk and ran tests. trying to ignore all of the exceptions that flew by, since it says tests passed. release testing failed. is that expected? :-/ |
| 20:02:24 | <bwolfe> how did it fail? |
| 20:02:36 | <burke> org.codehaus.plexus.archiver.ArchiverException: The source must not be a directory. |
| 20:04:03 | <burke> some downloading, followed by [INFO] Configured Artifact: org.openmrs.web:openmrs-webapp:1.10.0-SNAPSHOT:war ... so far, so good. |
| 20:04:16 | <burke> then this line: [INFO] Unpacking /Users/burke/Documents/java/openmrs/webapp/target/classes to |
| 20:04:16 | <burke> /Users/burke/Documents/java/openmrs/release-test/target/1.10.0-SNAPSHOT/webapp |
| 20:04:16 | <burke> with includes null and excludes:null |
| 20:05:11 | *** harshadura_ has joined #openmrs |
| 20:05:33 | <bwolfe> burke, CI says that release-test is currently failing...but I don't know how/why. kishore has been working on it the past few weeks. |
| 20:05:34 | <bwolfe> https://ci.openmrs.org/browse/FUNC-APPTEST |
| 20:06:17 | <burke> https://gist.github.com/2870555 |
| 20:06:47 | <burke> Am I the only one seeing this? Am I the only one running tests? :-/ |
| 20:07:52 | <burke> So, when applying patches we are ignoring any release testing for now? |
| 20:08:00 | <bwolfe> yes |
| 20:08:12 | <bwolfe> release tests are too long ot be run by devs |
| 20:08:34 | *** harshadura has quit IRC |
| 20:08:36 | *** harshadura_ is now known as harshadura |
| 20:08:37 | <bwolfe> they're meant to be CI...which is now telling us its broken. :-p |
| 20:09:14 | <bwolfe> burke, what command did you run? "mvn test" on my machine doesn't run the release tests |
| 20:10:15 | <burke> Eclipse â openmrs (right-click) â Run as... â Maven test |
| 20:11:25 | <burke> What's the command in your run configuration? Does it contain something that suppresses the release testing? |
| 20:12:55 | <bwolfe> command line --> "mvn test" |
| 20:15:06 | <burke> then you sit back and watch the exceptions roll by? ;) |
| 20:16:25 | <bwolfe> then I do something else and come back and look for SUCCESSs. I don't scroll up to see the exceptions. :-) |
| 20:17:19 | <bwolfe> I agree with you that the exceptions are not good...its just not a priority to fix yet |
| 20:18:10 | <burke> running "mvn test" on a fresh checkout of trunk jut now and still get a build failure on openmrs-release-test |
| 20:18:30 | <burke> same error: org.codehaus.plexus.archiver.ArchiverException: The source must not be a directory. |
| 20:18:45 | <burke> so, maybe you are getting that error too and just used to ignoring it? |
| 20:19:34 | <burke> how could you not be running release testing with "mvn test"? maybe you don't have the latest copy from trunk? |
| 20:22:32 | *** snoppy has joined #openmrs |
| 20:24:02 | *** rafa has joined #openmrs |
| 20:24:02 | *** ChanServ sets mode: +v rafa |
| 20:24:05 | *** harshadura has quit IRC |
| 20:24:34 | * bwolfe runs: svn update; mvn test; |
| 20:25:12 | <bwolfe> I always have trunk within a few days of latest. |
| 20:25:28 | <bwolfe> and I would know if I was running release tests. they take 15+ mins to run |
| 20:31:05 | *** snoppy has left #openmrs |
| 20:31:23 | <burke> bwolfe: do you run "mvn test" from the openmrs folder? |
| 20:32:26 | <bwolfe> yes |
| 20:33:05 | *** pushkar has quit IRC |
| 20:34:00 | <burke> I have openmrs, openmrs-api, openmrs-release-test, openmrs-test, openmrs-tools, openmrs-web, and openmrs-webapp folders that all came when I checked out trunk. I am opening a terminal in the "openmrs" folder and running "mvn test" and I get a BUILD FAILURE with all successes + one failure on openmrs-release-test. Do you even see openmrs-release-test in the list? |
| 20:34:47 | <burke> bwolfe: do you see openmrs-release-test.................SUCCESS at the end of the "mvn test" output?!? |
| 20:35:10 | <bwolfe> mine is still running |
| 20:35:47 | <bwolfe> ah ha |
| 20:36:07 | <burke> yours _does_ fail? |
| 20:36:12 | <bwolfe> I see release-test in the list as SUCCESS and it took 2.8 mins to run |
| 20:36:21 | <bwolfe> looking ot see why it failed... |
| 20:36:24 | <bwolfe> err, failed to fail |
| 20:36:39 | <burke> so is there some dependency that I don't have on my machine? |
| 20:37:12 | <bwolfe> [INFO] Unpacking /home/ben/.m2/repository/org/openmrs/web/openmrs-webapp/1.10.0-SNAPSHOT/openmrs-webapp-1.10.0-SNAPSHOT.war to |
| 20:37:12 | <bwolfe> /home/ben/workspace/trunk.openmrs/release-test/target/1.10.0-SNAPSHOT/webapp |
| 20:37:12 | <bwolfe> with includes null and excludes:null |
| 20:37:12 | <bwolfe> [INFO] [resources:resources {execution: default-resources}] |
| 20:37:12 | <bwolfe> [INFO] Using 'UTF-8' encoding to copy filtered resources. |
| 20:37:14 | <bwolfe> [INFO] Copying 34 resources |
| 20:37:16 | <bwolfe> [INFO] [compiler:compile {execution: default-compile}] |
| 20:37:18 | <bwolfe> [INFO] Nothing to compile - all classes are up to date |
| 20:37:20 | <bwolfe> [INFO] [resources:testResources {execution: default-testResources}] |
| 20:37:22 | <bwolfe> [INFO] Using 'UTF-8' encoding to copy filtered resources. |
| 20:37:24 | <bwolfe> [INFO] skip non existing resourceDirectory /home/ben/workspace/trunk.openmrs/release-test/src/test/resources |
| 20:37:27 | <bwolfe> [INFO] [compiler:testCompile {execution: default-testCompile}] |
| 20:37:29 | <bwolfe> [INFO] No sources to compile |
| 20:37:31 | <bwolfe> [INFO] [surefire:test {execution: default-test}] |
| 20:37:33 | <bwolfe> [INFO] No tests to run. |
| 20:37:44 | <bwolfe> "no tests to run" seems key there |
| 20:38:11 | * bwolfe is confused |
| 20:40:44 | <burke> So, where you get the line "[INFO] [resources:resources {execution: default-resources}]", I'm seeing "org.codehaus.plexus.archiver.ArchiverException: The source must not be a directory." https://gist.github.com/2870555#L47 |
| 20:41:31 | <burke> I don't even get to that line |
| 20:41:54 | <bwolfe> a clean install is needed? |
| 20:41:59 | <bwolfe> mvn clean install test |
| 20:42:29 | <bwolfe> burke, is yours downloaded the war or using a local one? |
| 20:43:53 | <burke> I dunno. I completely deleted by local copy of openmrs* and downloaded a fresh one. maybe the release testing is depending on something that hasn't been built? |
| 20:44:04 | <burke> or does it rely on tomcat running locally? |
| 20:44:58 | <bwolfe> it starts up an embedded jetty and runs the tests in an embedded firefox |
| 20:45:01 | *** venkaban has joined #openmrs |
| 20:45:28 | <bwolfe> but it seems like the war file doesn't even download right. or there is something wrong with a setting in your pom |
| 20:45:31 | <burke> perhaps the embedded firefox doesn't like macs? |
| 20:45:53 | <burke> i have firefox installed and it runs fine (though I use chrome most of the time) |
| 20:47:57 | <bwolfe> no, you're not getting that far. the tests aren't even running |
| 20:49:37 | <bwolfe> burke, which version of maven are you using? |
| 20:53:44 | <burke> 3.0.3 |
| 20:55:41 | *** pushkar has joined #openmrs |
| 20:57:11 | <pushkar> bwolfe, I finished putting the dropdown |
| 20:58:07 | <bwolfe> burke, hmm, maybe its a mvn3 thing? I'm on mvn 2.2.1 |
| 20:58:13 | <bwolfe> pushkar, awesome |
| 20:58:45 | <burke> ok. well, i'll ignore it for now. it would be great to actually have some release testing. :-) |
| 20:59:53 | <pushkar> bwolfe, :-) wahat is the next step ? |
| 21:00:29 | <bwolfe> pushkar, whats next on your roadmap? |
| 21:01:43 | <pushkar> I forgot to ask what if the user wants to assosiate an encounter with the observation ?? |
| 21:02:38 | *** bryq has quit IRC |
| 21:03:50 | <bwolfe> pushkar, I suppose you could do that, but thats low use-case |
| 21:04:07 | <bwolfe> adding an optional encounter autocomplete for htat patient is trivial |
| 21:04:24 | <pushkar> bwolfe, okay |
| 21:04:27 | <pushkar> Add ability to add from htmlformentry/xforms |
| 21:04:31 | <bwolfe> yes |
| 21:05:02 | <bwolfe> it would be a new tag in htmlformentry. thats probably easier |
| 21:05:21 | <bwolfe> your module would provide a new type of tag. |
| 21:05:38 | <bwolfe> mseaton, do you know off the top of your head which PIH module adds in a custom htmlformentry tag that pushkar cna use as an example? |
| 21:05:55 | *** sgithens has quit IRC |
| 21:06:02 | <pushkar> I was about to ask you that :) |
| 21:06:03 | <mseaton> try htmlformflowsheet |
| 21:06:36 | <venkaban> bwolfe, I have setup my development environment now |
| 21:06:42 | <pushkar> thanks mseaton |
| 21:07:01 | <venkaban> It took me a while to get throught his bwolfe |
| 21:08:37 | <bwolfe> venkaban, great! |
| 21:08:48 | <bwolfe> venkaban, can you write out what the pain points were so we can update the docs? |
| 21:08:58 | <venkaban> bwolfe, I did |
| 21:09:03 | <bwolfe> awesome |
| 21:09:28 | <venkaban> bwolfe, Can you assign me one ticket as of now to move forward in the sprint |
| 21:09:32 | <bwolfe> do you want to update the wiki page(s) now or wait until you have more info? |
| 21:09:42 | <bwolfe> venkaban, I assigned you one quick ticket off-sprint. do that one first |
| 21:10:07 | <bwolfe> venkaban, does your ticket show up on the "My Tickets" jira dashboard? https://tickets.openmrs.org/secure/Dashboard.jspa?selectPageId=10059 |
| 21:10:11 | <venkaban> bwolfe, I have updated the wiki page during my development environment setup |
| 21:10:23 | <bwolfe> ah, even better! |
| 21:10:26 | * bwolfe goes to look |
| 21:11:19 | <bwolfe> venkaban, I see wiki updates from june 1st from you. anything more from today's setup? |
| 21:12:44 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Serialization Xstream 0.2.6 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=serialization.xstream&version=&0.2.6> |
| 21:12:59 | <bwolfe> bbl, gotta help my wife with the kids for a bit |
| 21:18:51 | <venkaban> bwolfe, only one note is that the jdk version needs to be 1.6.0_30. Other than that there isn't anything. |
| 21:21:33 | <venkaban> bwolfe, the assigned ticket I cant see under my tickets |
| 21:27:16 | *** yansuck has joined #openmrs |
| 21:27:24 | <yansuck> Hello there. |
| 21:28:09 | *** suranga has quit IRC |
| 21:32:18 | *** mseaton has left #openmrs |
| 21:33:13 | <yansuck> Hi I have a question, could anyone teach me how to import org.apache.* properly in eclipse? |
| 21:34:07 | *** mgielow has joined #openmrs |
| 21:34:25 | <dkayiwa> yansuck: how were you doing it? |
| 21:35:27 | *** burke has quit IRC |
| 21:35:30 | <venkaban> bwolfe, the two tickets you emailed me are not under my tickets in dashboard |
| 21:38:05 | *** pushkar has quit IRC |
| 21:38:09 | *** Mkop has quit IRC |
| 21:38:29 | <yansuck> hi |
| 21:38:39 | <yansuck> I run the openmrs trunk in maven |
| 21:39:00 | <yansuck> and it is giving me error at those import org.apache.* |
| 21:39:18 | <yansuck> it fixs those import org.openmrs.* which contains error before i run it in maven |
| 21:39:19 | *** mgielow has quit IRC |
| 21:39:34 | <yansuck> however the apache is still not working X.X |
| 21:39:47 | *** nwilkie has joined #openmrs |
| 21:40:20 | <dkayiwa> yansuck: can you try Ctrl + Shift + O |
| 21:41:36 | <yansuck> Thank you but it deletes the importing line.... |
| 21:45:07 | *** judygichoya has left #openmrs |
| 21:50:01 | *** yansuck has quit IRC |
| 22:24:52 | <venkaban> bwolfe, you there? |
| 22:27:42 | *** Mkop has joined #openmrs |
| 22:27:42 | *** ChanServ sets mode: +v Mkop |
| 22:43:04 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Privilege Helper Module 1.0 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=privilegehelper&version=&1.0> |
| 22:50:22 | *** jordank has quit IRC |
| 22:54:21 | *** jordank has joined #openmrs |
| 23:05:37 | <venkaban> Hey Can anyone give me a link that explains the modules in openMRS regarding the functionality for development |
| 23:06:00 | <venkaban> like what exactly is each module for |
| 23:06:40 | <venkaban> downey Hi |
| 23:09:54 | *** mccallumg has quit IRC |
| 23:18:40 | *** rafa has quit IRC |
| 23:21:08 | *** jordank has quit IRC |
| 23:27:12 | *** venkaban has quit IRC |
| 23:28:20 | *** venkaban has joined #openmrs |
| 23:35:43 | *** downey has quit IRC |
| 23:36:32 | *** kreddy has quit IRC |
| 23:37:56 | *** jordank has joined #openmrs |
| 23:39:16 | *** jordank has quit IRC |
| 23:42:14 | *** venkaban has quit IRC |
| 23:42:32 | *** dkayiwa has quit IRC |