00:17:08
|
*** lh has quit IRC
|
00:27:09
|
*** anupre has joined #openmrs
|
00:36:27
|
*** anupre has quit IRC
|
01:35:25
|
*** suranga has joined #openmrs
|
01:35:25
|
*** ChanServ sets mode: +v suranga
|
02:52:30
|
*** finbrein has quit IRC
|
03:57:18
|
*** maurya has joined #openmrs
|
04:41:44
|
*** applecool has joined #openmrs
|
04:41:51
|
<applecool> !seen rafa
|
04:41:51
|
<OpenMRSBot> applecool: rafa was last seen in #openmrs 12 hours, 24 minutes, and 50 seconds ago: <rafa> applecool: good
|
04:42:28
|
*** applecool has quit IRC
|
04:59:03
|
*** kishoreyekkanti has joined #openmrs
|
05:22:59
|
*** suranga has quit IRC
|
05:27:00
|
*** kishoreyekkanti has quit IRC
|
05:34:58
|
*** suranga has joined #openmrs
|
05:41:08
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: App Framework Module 1.1 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=appframework&version=&1.1>
|
06:12:02
|
*** djazayeri1 has joined #openmrs
|
06:14:02
|
*** djazayeri has quit IRC
|
06:22:52
|
*** kavuri has joined #openmrs
|
06:51:01
|
*** maurya has quit IRC
|
06:54:40
|
*** harshadura has joined #openmrs
|
06:57:04
|
*** goutham has joined #openmrs
|
07:01:39
|
*** suranga has quit IRC
|
07:05:14
|
<goutham> hi all
|
07:06:04
|
<goutham> djazayeri1: there?
|
07:16:56
|
*** kavuri has quit IRC
|
07:28:09
|
*** bryq has joined #openmrs
|
07:28:09
|
*** ChanServ sets mode: +v bryq
|
07:28:40
|
*** kavuri has joined #openmrs
|
07:36:41
|
*** harshadura has quit IRC
|
07:52:31
|
*** kavuri has quit IRC
|
07:53:04
|
*** maurya has joined #openmrs
|
07:55:02
|
*** goutham_ has joined #openmrs
|
07:56:18
|
*** goutham has quit IRC
|
08:05:46
|
*** goutham_ has quit IRC
|
08:14:31
|
*** snoppy has joined #openmrs
|
08:24:45
|
*** snoppy has quit IRC
|
08:25:48
|
*** snoppy has joined #openmrs
|
08:36:05
|
*** kdeeq has joined #openmrs
|
08:36:33
|
*** Goutham has joined #openmrs
|
08:37:50
|
*** djazayeri1 has quit IRC
|
08:37:57
|
*** kavuri has joined #openmrs
|
09:03:08
|
*** kdeeq has quit IRC
|
09:10:14
|
*** maurya has quit IRC
|
09:16:38
|
*** kavuri has quit IRC
|
09:25:56
|
*** snoppy has left #openmrs
|
09:32:51
|
*** Goutham has quit IRC
|
09:40:02
|
*** kavuri has joined #openmrs
|
09:44:07
|
*** Goutham has joined #openmrs
|
10:10:40
|
*** maurya has joined #openmrs
|
10:21:22
|
*** kavuri has quit IRC
|
10:45:50
|
*** harshadura has joined #openmrs
|
10:49:31
|
<harshadura> hi maurya, Goutham, bro do u know hw to request for review in Crucible?
|
10:50:56
|
<Goutham> Harshadura: no dude
|
10:52:37
|
<harshadura> ok Goutham, np thanks bro
|
11:02:49
|
*** harshadura has quit IRC
|
11:06:35
|
*** kishoreyekkanti has joined #openmrs
|
11:40:30
|
*** kishoreyekkanti has quit IRC
|
11:48:31
|
*** sandeep has joined #openmrs
|
11:49:14
|
*** sandeep is now known as Guest96686
|
11:50:06
|
*** Guest96686 has left #openmrs
|
11:55:52
|
*** Goutham has quit IRC
|
11:56:14
|
*** sandeep has joined #openmrs
|
11:56:40
|
*** sandeep is now known as Guest34904
|
11:57:47
|
*** Guest34904 has quit IRC
|
11:58:55
|
*** sandeep has joined #openmrs
|
11:59:21
|
*** sandeep is now known as Guest30940
|
12:00:38
|
*** sandeep has joined #openmrs
|
12:00:48
|
<sandeep> \quit
|
12:00:56
|
*** sandeep has quit IRC
|
12:01:40
|
*** sandeep has joined #openmrs
|
12:02:06
|
*** sandeep is now known as Guest84887
|
12:18:54
|
*** maurya has quit IRC
|
13:15:15
|
*** pulasthi7 has joined #openmrs
|
13:30:46
|
*** maurya has joined #openmrs
|
13:42:38
|
*** snoppy has joined #openmrs
|
13:50:45
|
*** r_friedman has joined #openmrs
|
14:37:10
|
*** r_friedman has quit IRC
|
14:38:02
|
*** pulasthi7 has quit IRC
|
14:43:29
|
*** pulasthi7 has joined #openmrs
|
14:54:11
|
*** pulasthi7 has quit IRC
|
14:56:17
|
*** snoppy has quit IRC
|
15:19:20
|
*** mgielow has joined #openmrs
|
15:39:44
|
*** sunbiz has joined #openmrs
|
15:39:44
|
*** ChanServ sets mode: +v sunbiz
|
16:00:00
|
*** sunbiz has quit IRC
|
16:18:52
|
*** suranga has joined #openmrs
|
16:18:52
|
*** ChanServ sets mode: +v suranga
|
16:23:45
|
*** ShellZero has joined #openmrs
|
16:24:15
|
*** ShellZero is now known as applecool
|
16:24:27
|
<applecool> !seen rafa
|
16:24:27
|
<OpenMRSBot> applecool: rafa was last seen in #openmrs 1 day, 0 hours, 7 minutes, and 25 seconds ago: <rafa> applecool: good
|
17:11:46
|
*** dkayiwa has joined #openmrs
|
17:28:52
|
*** applecool has quit IRC
|
17:33:53
|
*** dkayiwa has quit IRC
|
17:34:51
|
*** applecool has joined #openmrs
|
18:03:12
|
*** djazayeri has joined #openmrs
|
18:03:12
|
*** ChanServ sets mode: +o djazayeri
|
18:18:02
|
*** applecool has quit IRC
|
18:23:51
|
*** applecool has joined #openmrs
|
18:25:00
|
*** maurya has quit IRC
|
18:25:39
|
*** dkayiwa has joined #openmrs
|
18:43:37
|
*** callkalpa has joined #openmrs
|
18:43:46
|
*** callkalpa has left #openmrs
|
19:03:07
|
<applecool> hi dkayiwa
|
19:03:14
|
<dkayiwa> hi applecool
|
19:03:30
|
<applecool> everything is cool cool ?
|
19:03:48
|
<applecool> :D
|
19:04:09
|
<dkayiwa> applecool: hahaaa yes cold :D
|
19:04:31
|
<applecool> no weekend ? :P
|
19:08:19
|
<dkayiwa> applecool: hahaahahah right from Church :D
|
19:08:51
|
<applecool> oh! :) what is the time at your place?
|
19:08:54
|
<applecool> now?
|
19:09:11
|
<dkayiwa> 10pm :)
|
19:10:25
|
<applecool> Oh! 2 and half hours difference from our time! :D
|
19:10:43
|
<dkayiwa> applecool: yes :D
|
19:12:36
|
<applecool> okay dkayiwa i am leaving :) will sleep having cold cold OpenMRS dreams ;)
|
19:13:10
|
<dkayiwa> applecool: :D
|
19:14:02
|
<applecool> bye dkayiwa :) Good night :)
|
19:14:28
|
<dkayiwa> applecool: have a good night tooo :D
|
19:14:41
|
<applecool> Thanks :)
|
19:14:55
|
*** applecool has quit IRC
|
19:18:14
|
*** mgielow has left #openmrs
|
20:40:37
|
*** rafa has joined #openmrs
|
20:40:37
|
*** ChanServ sets mode: +v rafa
|
21:02:53
|
*** suranga has quit IRC
|
21:11:14
|
*** bryq has quit IRC
|
21:12:44
|
*** r_friedman has joined #openmrs
|
21:29:20
|
*** sunbiz has joined #openmrs
|
21:29:20
|
*** ChanServ sets mode: +v sunbiz
|
21:30:46
|
<sunbiz> djazayeri: u there??
|
21:32:10
|
<sunbiz> djazayeri rafa : anyway that Im missing in DelegatingResourceDescription that either a provider can have person or name as required property??
|
21:32:27
|
<sunbiz> the OR for a requiredProperty??
|
22:08:15
|
*** dkayiwa has quit IRC
|
22:09:02
|
*** dkayiwa has joined #openmrs
|
22:26:47
|
*** dkayiwa has quit IRC
|
22:39:31
|
<r_friedman> sunbiz, u there?
|
22:41:54
|
<sunbiz> r_friedman: yes... Im here
|
22:42:03
|
<r_friedman> sunbiz, i think you would make name required and have a property setter for person that also set name
|
22:42:20
|
<sunbiz> but person cant be created just on name
|
22:42:37
|
<r_friedman> then i am not understanding what you are asking
|
22:42:38
|
<sunbiz> r_friedman: we need to be able to add an existing uuid for person or name
|
22:43:02
|
<r_friedman> oh no, not as I understand it
|
22:43:13
|
<sunbiz> ok... so we can create a new provider... we can add a person or name
|
22:43:14
|
<r_friedman> name is not a uuid into person_name, name is text
|
22:43:24
|
<sunbiz> the person uuid is fine... or name test
|
22:43:40
|
<sunbiz> *text
|
22:44:32
|
<r_friedman> right, so you create a person while you create a provider and assign it a name in person_name, then you use that name to set provider.name
|
22:44:55
|
<sunbiz> yes... but to create a new person one also needs a gender
|
22:44:59
|
<sunbiz> at a minimum
|
22:45:11
|
<r_friedman> yes
|
22:45:16
|
<r_friedman> at least for now
|
22:45:54
|
<r_friedman> omrs is very unimaginative wrt gender :-)
|
22:46:02
|
<sunbiz> so... how do I describe these... that the required property is "either a name or person (or givenName+familyName+gender)
|
22:46:21
|
<sunbiz> so... by the hateos rule... one could be redirected
|
22:46:50
|
<sunbiz> if name is missing, it should redirect if Im actually creating a person... so hypermedia should do the work
|
22:46:57
|
<r_friedman> the text name is the required property, it is just that setting person also sets name
|
22:47:22
|
<sunbiz> but I think from the initial discussions we are skipping that level (or whatever the "thoughtworks book" calls it)
|
22:47:38
|
<r_friedman> ?
|
22:48:06
|
<r_friedman> i think everyone wants provider to behave like patient and be able to create the person behind it
|
22:48:33
|
<sunbiz> yes... Im just sayign we still dont have the either THIS or THAT to be a required property
|
22:48:39
|
<sunbiz> or it exists that I dont know abt
|
22:48:48
|
<sunbiz> so... was looking for djazayeri or rafa for an answer
|
22:49:10
|
<r_friedman> all the required property does is reflect the capabilities of the underlying DB for referential integrity
|
22:49:41
|
<sunbiz> r_friedman: true...
|
22:50:00
|
<r_friedman> so you are going to have a custom setter for person that will allow the creation of the person while creating the provider
|
22:50:17
|
<r_friedman> and that same setter will set the name based on the person however created
|
22:50:22
|
<sunbiz> I was saying that using HATEOS [http://en.wikipedia.org/wiki/HATEOAS]
|
22:50:45
|
<sunbiz> if person is being created with only name
|
22:51:07
|
<r_friedman> no, if there is only a name, no person is created
|
22:51:23
|
<sunbiz> true... but person can also be the required property
|
22:51:26
|
<r_friedman> you just set the name text and you're done
|
22:51:31
|
<r_friedman> no, person is definitely not required
|
22:51:40
|
<sunbiz> why??
|
22:51:53
|
<sunbiz> I can skip the name
|
22:51:58
|
<sunbiz> if I have a person
|
22:52:11
|
<sunbiz> right??
|
22:52:16
|
<r_friedman> because the whole idea of the text is to allow for cases where we get a big dump of names from a provider registry
|
22:52:31
|
<r_friedman> no, you can't skip the name if you have a person, you have to fill it in based on the preferred name
|
22:52:48
|
<r_friedman> if you remove the person, the name stays
|
22:52:54
|
<sunbiz> ok... lemme get more clear then...
|
22:53:59
|
<sunbiz> I want to POST to the provider resource --- I can do {"name":"Roger", "identifier":"007"}
|
22:54:31
|
<r_friedman> right
|
22:54:43
|
<sunbiz> but I can also POST {"person":"264187248-1421-asdf-3215sfd", "identifier":"007"}
|
22:54:47
|
<sunbiz> this needs validation
|
22:55:05
|
<sunbiz> using DelegatingResourceDescription
|
22:55:14
|
<sunbiz> and its addRequiredProperty
|
22:55:21
|
<r_friedman> right, the setter for person has got to find the preferred name for the given uuid and also set name
|
22:56:02
|
<sunbiz> true, but currently it checks what is being POST'ed and validated
|
22:56:38
|
<r_friedman> i don't know where the setter gets called
|
22:57:16
|
<r_friedman> it may be necessary for it to modify the POST JSON to include "name":"<name from the person>"
|
22:57:28
|
<sunbiz> r_friedman: so we need a OR and then probably AND check for properties
|
22:57:40
|
<sunbiz> so that we can validate POST
|
22:57:46
|
<r_friedman> no, it just needs to check at the right time -- after the setters have executed
|
22:58:12
|
<sunbiz> it may not necessarily always be like this
|
22:58:37
|
<r_friedman> I have run into this one a few times however
|
22:58:38
|
<sunbiz> where a required may be through another subresource/resource
|
22:59:50
|
<r_friedman> again, I thought that was what setters were for
|
23:00:00
|
<r_friedman> custom setters
|
23:00:44
|
<sunbiz> hmmm... may be
|
23:00:50
|
<r_friedman> take a look at how patient does a write-through to person
|
23:01:06
|
<r_friedman> that's almost exactly what you want here, just with a twist at the end of setting name
|
23:01:08
|
<sunbiz> r_friedman: its extends
|
23:01:34
|
<r_friedman> patient extends person? i doubt it
|
23:01:46
|
<r_friedman> maybe patient resource extends person resource, could be
|
23:02:32
|
<sunbiz> line 33 Patient.java in openmrs-api ----> public class Patient extends Person implements java.io.Serializable {
|
23:02:33
|
<sunbiz>
|
23:03:01
|
<sunbiz> public class Provider extends BaseCustomizableMetadata<ProviderAttribute>
|
23:03:28
|
<sunbiz> although maybe @PropertySetter and some change to where the validation executes
|
23:03:32
|
<sunbiz> could solve the thing...
|
23:04:10
|
<sunbiz> although I still think it will save some processing instead of looking through a resource among its property and setting to another resource
|
23:04:52
|
<r_friedman> take a look at patient resource, in web servcies rest, line 166, the create method
|
23:08:44
|
*** sunbiz has quit IRC
|
23:10:13
|
<r_friedman> sunbiz, it is clear our REST API does not comply with HATEOAS
|
23:11:01
|
<r_friedman> our JSON/XML output is strongly typed and we expect the users to understand the data model sufficiently to use the returned objects successfully
|
23:17:04
|
*** rafa has quit IRC
|