| 00:07:50 | *** Echidna has quit IRC |
| 00:07:50 | *** Echidna has joined #openmrs |
| 00:07:50 | *** ChanServ sets mode: +v Echidna |
| 00:12:37 | *** Mkop has quit IRC |
| 00:13:41 | *** Mkop has joined #openmrs |
| 00:13:41 | *** ChanServ sets mode: +v Mkop |
| 00:16:47 | *** finbrein has joined #openmrs |
| 00:59:43 | *** bwolfe has joined #openmrs |
| 00:59:43 | *** ChanServ sets mode: +o bwolfe |
| 01:27:53 | *** harshadura has joined #openmrs |
| 02:02:48 | *** djazayeri has joined #openmrs |
| 02:02:48 | *** ChanServ sets mode: +o djazayeri |
| 02:04:32 | *** djazayeri1 has quit IRC |
| 02:09:05 | *** r0bby has joined #openmrs |
| 02:09:05 | *** ChanServ sets mode: +v r0bby |
| 02:13:00 | *** robbyoconnor has quit IRC |
| 02:31:22 | *** bwolfe has quit IRC |
| 02:31:35 | *** bwolfe has joined #openmrs |
| 02:31:35 | *** ChanServ sets mode: +o bwolfe |
| 02:38:16 | *** bwolfe has quit IRC |
| 02:40:12 | *** r0bby is now known as robbyoconnor |
| 03:34:15 | *** deeksha has joined #openmrs |
| 03:34:27 | <deeksha> hello |
| 03:34:38 | <deeksha> my admin/test logon is not working |
| 03:34:48 | <deeksha> can anyone provide me pointers to resolve this issue |
| 03:34:59 | *** upul` has joined #openmrs |
| 03:34:59 | *** ChanServ sets mode: +v upul` |
| 03:38:42 | *** deeksha has quit IRC |
| 04:18:58 | *** finbrein has joined #openmrs |
| 04:25:18 | *** harshadura has quit IRC |
| 04:29:26 | <finbrein> hi wluyima |
| 04:32:56 | *** finbrein has quit IRC |
| 04:53:53 | *** finbrein has joined #openmrs |
| 05:01:03 | *** djazayeri1 has joined #openmrs |
| 05:02:55 | *** bwolfe has joined #openmrs |
| 05:02:55 | *** ChanServ sets mode: +o bwolfe |
| 05:02:56 | *** bwolfe has quit IRC |
| 05:02:58 | *** djazayeri has quit IRC |
| 05:20:34 | *** dkayiwa has joined #openmrs |
| 05:24:39 | *** dkayiwa has quit IRC |
| 05:25:39 | *** dkayiwa has joined #openmrs |
| 05:45:21 | <finbrein> hi djazayeri1 |
| 05:45:57 | <finbrein> hi dkayiwa |
| 05:46:04 | <dkayiwa> hi finbrein |
| 05:50:20 | <finbrein> dkayiwa: in ATOM-10, if I pass a null date(Date date = null) to the dateToRfc3339 method, I should get an NPE. could you advise on how to pass in a null date and make sure that it still gives you back something and no exception. |
| 05:50:22 | *** dkayiwa_ has joined #openmrs |
| 05:50:29 | *** dkayiwa has quit IRC |
| 05:50:32 | *** dkayiwa_ is now known as dkayiwa |
| 06:02:08 | *** dkayiwa has quit IRC |
| 06:02:53 | *** sunbiz has joined #openmrs |
| 06:02:53 | *** ChanServ sets mode: +v sunbiz |
| 06:08:00 | *** djazayeri1 has quit IRC |
| 06:12:01 | *** sunbiz1 has joined #openmrs |
| 06:15:21 | *** sunbiz has quit IRC |
| 06:27:03 | *** bryq has joined #openmrs |
| 06:27:03 | *** ChanServ sets mode: +v bryq |
| 06:47:00 | *** dkayiwa has joined #openmrs |
| 06:54:16 | *** Allen has joined #openmrs |
| 06:54:34 | *** Allen is now known as Guest17464 |
| 06:57:07 | *** Guest17464 is now known as AllenM |
| 07:17:44 | *** sunbiz has joined #openmrs |
| 07:17:44 | *** ChanServ sets mode: +v sunbiz |
| 07:22:04 | *** sunbiz1 has quit IRC |
| 07:23:58 | *** bryq has quit IRC |
| 07:26:09 | *** dkayiwa has quit IRC |
| 07:30:41 | *** Allen_ has joined #openmrs |
| 07:31:07 | *** Allen_ is now known as Guest70481 |
| 07:33:47 | *** AllenM has quit IRC |
| 07:33:52 | *** Guest70481 has quit IRC |
| 07:34:46 | *** allen6machary has joined #openmrs |
| 07:41:46 | *** Alex_____ has joined #openmrs |
| 07:42:27 | <Alex_____> Hi, Is sombody who has ever used ODK Clinic ? |
| 07:47:35 | *** ibewes has joined #openmrs |
| 07:48:17 | <ibewes> hello all! |
| 07:48:26 | <Alex_____> hi |
| 07:48:46 | <Alex_____> ibewes : Have you ever used ODK Clinic ? |
| 07:48:54 | <ibewes> sorry, no |
| 07:49:00 | <Alex_____> ok :( |
| 07:49:22 | <Alex_____> ibewes : and XForms ? |
| 07:49:32 | <ibewes> ODK Clinic: that looks awesome! |
| 07:49:52 | <ibewes> no on the XForms as well... sorry, I'm new |
| 07:50:03 | <Alex_____> Ibewes : ok :) |
| 07:51:44 | <ibewes> Alex: you working with those? |
| 07:51:56 | <Alex_____> ibewes: yes |
| 07:52:56 | <ibewes> i'm really curious to see where ODK Clinic goes, that's a very cool project |
| 07:53:42 | <Alex_____> it is ! You can set up very fast an application |
| 07:54:03 | <Alex_____> for your needs |
| 07:58:38 | *** rafa has joined #openmrs |
| 07:58:38 | *** ChanServ sets mode: +v rafa |
| 08:00:12 | <Alex_____> rafa: Hi rafa, I don't know who is the best person to ask my question. Have you ever used XForms with ODK Clinic ? |
| 08:00:33 | <rafa> hi Alex |
| 08:01:00 | <rafa> try contacting Daniel Kayiwa |
| 08:01:15 | <Alex_____> thanks |
| 08:03:57 | *** finbrein has quit IRC |
| 08:09:03 | *** dkayiwa has joined #openmrs |
| 08:12:46 | <Alex_____> dkawiya : Hi dkawiya, rafa said me that you're the appropriate person to ask my question. I have a little issue using XForms with ODK Clinic, maybe you could help me ! :) |
| 08:13:04 | <dkayiwa> Alex_____: i can try :) |
| 08:13:18 | <rafa> hi dkayiwa :) |
| 08:13:27 | <dkayiwa> hi rafa :) |
| 08:16:51 | <Alex_____> dkawiya: I'm using the version 1.1.2 of ODK Clinic. I want to create a new Patient with a specific XForm. When I send the XForm to the server, it appears in the XForms error menu and I have : "ca.uhn.hl7v2.HL7Exception: Could not resolve patient". I saw the error was due because there was no patient.id tag in the xml file, but I have in mine ("<patient.patient_id openmrs_attribute="patient_id" openmrs_table="patient">666</patient. |
| 08:18:27 | <Alex_____> Error Id: 2 Date Error Created: 2012-05-11 09:38:30.0 Error: Error sending form to xform module |
| 08:19:52 | <dkayiwa> Alex_____: do you have a patient with the id 666? |
| 08:21:10 | <Alex_____> dkayiwa: No, but I tried to created the patient with the "New Patient Button" of ODK Clinic. |
| 08:21:41 | <Alex_____> dkawiya: So I filled out all the fields of my XForm |
| 08:21:45 | <dkayiwa> Alex_____: did you enter the patient identifier? |
| 08:22:52 | <Alex_____> dkawiya: Yes because I have <patient.patient_id openmrs_attribute="patient_id" openmrs_table="patient">666</patient.patient_id>" when I'm seeing the xml file of my new patient |
| 08:23:14 | <dkayiwa> Alex_____: patient identifier is different from patient id |
| 08:23:30 | <dkayiwa> Alex_____: the former is assigned by user while the latter is assigned by the database |
| 08:25:09 | <Alex_____> dkayiwa: Ah :( Yes there is no patient identifier tag |
| 08:25:33 | <dkayiwa> Alex_____: then such a form cannot create a new patient |
| 08:26:11 | <Alex_____> dkayiwa : Sure. So have I to add this to my XForm schema ? |
| 08:26:31 | <Alex_____> dkayiwa: And then pull new elements with the designer |
| 08:26:55 | <dkayiwa> Alex_____: no |
| 08:27:18 | <dkayiwa> Alex_____: you would need to use the xform created when you click the "Patient Xform Design" link |
| 08:28:38 | <dkayiwa> hi rafa |
| 08:28:55 | <dkayiwa> rafa: do you have any response to wluyima 's comment on EVNT-15? |
| 08:28:58 | <dkayiwa> !ticket EVNT-15 |
| 08:28:59 | <OpenMRSBot> dkayiwa: [#EVNT-15] Add support for create/update/delete of collections - OpenMRS JIRA - https://tickets.openmrs.org/browse/EVNT-15 |
| 08:30:03 | <rafa> dkayiwa: yes, we want to support service methods like saveGlobalProperties(Collection<GlobalProperty> gps) |
| 08:30:18 | <rafa> dkayiwa: not only saveGlobalProperty(GlobalProperty gp) |
| 08:30:28 | <dkayiwa> rafa: oh i see |
| 08:31:32 | <dkayiwa> rafa: do you mind commenting on the ticket? :) |
| 08:32:02 | <rafa> dkayiwa: was doing that :) |
| 08:32:19 | <dkayiwa> rafa: oh thanks :) |
| 08:36:35 | <Alex_____> dkayiwa: My mistake, I don't see but yes I have the patient Identifier line (" <patient.medical_record_number openmrs_attribute="identifier" openmrs_table="patient_identifier">Abc123</patient.medical_record_number>") |
| 08:36:51 | <Alex_____> dkawiya: So is the error come from another place ? |
| 08:41:05 | <dkayiwa> Alex_____: did you also fill the family name, gender, and birth date? |
| 08:41:24 | <Alex_____> dkayiwa: i founded it, just before you saying that |
| 08:41:43 | <Alex_____> dkawiya: I don't know why but the gender isn't filled out |
| 08:42:50 | <dkayiwa> Alex_____: the client is expected to send gender to the server if the module is to create a new patient |
| 08:46:25 | <Alex_____> dkawiya: I know, I had a gender field in my Xform, but for some reasons the xml file who has sent didn't get the information filled by user |
| 08:46:51 | <dkayiwa> Alex_____: looks like that requires troubleshooting the client |
| 09:04:13 | <Alex_____> dkawiya: Now I have Person Name: Winn bobbbyy cartier Identifier: Acv123 Gender: Male Location: 2 Encounter Date: 2012-05-11 Form Name: Verbal Autopsy v2 v0.2 |
| 09:04:47 | <Alex_____> have I to link the Sex attribute with the concept Male Gender ? |
| 09:04:58 | <Alex_____> (and female) |
| 09:07:00 | *** bryq has joined #openmrs |
| 09:07:00 | *** ChanServ sets mode: +v bryq |
| 09:07:44 | <Alex_____> sorry for this questions but i'm very brand new using OpenMRS (about 1 week) |
| 09:08:40 | *** bryq has quit IRC |
| 09:10:50 | *** dkayiwa has quit IRC |
| 09:12:56 | *** allen6machary has quit IRC |
| 09:23:36 | *** Alex_____ has quit IRC |
| 09:28:42 | *** allen2machary has joined #openmrs |
| 09:32:15 | *** upul` has left #openmrs |
| 09:51:26 | <ibewes> is there a known problem running 'mvn clean install' on the registration module? |
| 09:52:13 | <ibewes> i'm getting an OutOfMemory error (heap space), but I've bumped the allowable mvn memory up to 4GB and am still getting the same issue |
| 10:02:25 | <rafa> ibewes: can you pastebin the mvn console output? |
| 10:04:50 | <ibewes> surely: http://pastebin.com/8WvP4kF4 |
| 10:05:09 | <ibewes> and I can see the mvn is actually using up all of that 4GB |
| 10:06:02 | <ibewes> also, the failure is always at the same step |
| 10:08:14 | <ibewes> given that the error seems related to svnjava, I wonder if there is some issue with my 1.7 local copy? |
| 10:16:17 | *** ibewes has quit IRC |
| 10:18:41 | *** ibewes has joined #openmrs |
| 10:20:29 | <ibewes> rafa: got disconnected there... if you responded I didn't see it |
| 10:20:42 | <ibewes> if not, um, I also didn't see that ;) |
| 10:21:48 | <rafa> ibewes: sorry I didn't notice you answered. Mention rafa so that I get notified :) |
| 10:22:07 | <ibewes> rafa: my apologies |
| 10:22:14 | <rafa> ibewes: let me look in your pastebin |
| 10:23:39 | <rafa> ibewes: did you try running maven in normal mode not debug? |
| 10:24:21 | <ibewes> yup, I just added the debug info in case it helped diagnose |
| 10:24:55 | <rafa> ibewes: can you try disabling the buildnumber-maven-plugin in pom.xml? |
| 10:25:11 | <rafa> ibewes: so that it doesn't use svn |
| 10:25:20 | <rafa> ibewes: just remove it |
| 10:25:22 | <ibewes> rafa: sure |
| 10:25:51 | <rafa> ibewes: it's most likely in omod/pom.xml |
| 10:27:12 | <ibewes> rafa: works now! |
| 10:27:28 | <rafa> ibewes: good |
| 10:27:34 | <rafa> ibewes: did it have: <configuration> |
| 10:27:34 | <rafa> <doCheck>false</doCheck> |
| 10:27:34 | <rafa> <doUpdate>false</doUpdate> |
| 10:27:35 | <rafa> <providerImplementations> |
| 10:27:35 | <rafa> <svn>javasvn</svn> |
| 10:27:35 | <rafa> </providerImplementations> |
| 10:27:35 | <rafa> </configuration> |
| 10:27:36 | <rafa> ? |
| 10:28:27 | <ibewes> rafa: yes, exactly that |
| 10:29:01 | <ibewes> rafa: as well as - <groupId>org.codehaus.mojo</groupId> |
| 10:29:01 | <ibewes> <artifactId>buildnumber-maven-plugin</artifactId> |
| 10:29:01 | <ibewes> <version>1.0-beta-4</version> |
| 10:29:01 | <ibewes> <executions> |
| 10:29:01 | <ibewes> <execution> |
| 10:29:01 | <ibewes> <phase>validate</phase> |
| 10:29:02 | <ibewes> <goals> |
| 10:29:02 | <ibewes> <goal>create</goal> |
| 10:29:03 | <ibewes> </goals> |
| 10:29:03 | <ibewes> </execution> |
| 10:29:05 | <ibewes> </executions> |
| 10:29:23 | <ibewes> rafa: I am using the current trunk version of the registration module |
| 10:29:39 | <rafa> ibewes: it must be some issue with your svn working copy and javasvn |
| 10:30:08 | <rafa> ibewes: I'm still using svn 1.6 |
| 10:30:28 | <rafa> ibewes: maybe javasvn cannot work with 1.7 |
| 10:30:32 | <ibewes> rafa: interesting. As I mentioned above, that is my guess |
| 10:31:10 | <ibewes> rafa: because 1.7 does change the way that the .svn folder works (just one at the root, rather than one in every folder) |
| 10:31:51 | <rafa> ibewes: can you try adding newer version of maven-scm-provider-svnjava to the pom? |
| 10:32:31 | <ibewes> rafa: sure, what would the mvn command to do that be? (sorry, new to maven) |
| 10:33:41 | *** suranga has joined #openmrs |
| 10:33:41 | *** ChanServ sets mode: +v suranga |
| 10:34:02 | <suranga> hmmm.. hi rafa |
| 10:34:42 | <suranga> rafa, in the RESt module, I was wondering where I need to look to change the accept-charset type ? |
| 10:34:53 | <suranga> so that I can return any data type that i like ? :) |
| 10:35:37 | <rafa> suranga: hi |
| 10:35:47 | <suranga> rafa, howdy ! :) |
| 10:35:52 | <rafa> ibewes: try adding to omod/pom.xml: |
| 10:35:53 | <rafa> <plugin> |
| 10:35:54 | <rafa> <groupId>com.google.code.maven-scm-provider-svnjava</groupId> |
| 10:35:54 | <rafa> <artifactId>maven-scm-provider-svnjava</artifactId> |
| 10:35:54 | <rafa> <version>2.0</version> |
| 10:35:54 | <rafa> </plugin> |
| 10:37:32 | <rafa> suranga: hmm that's a spring thing I guess |
| 10:37:45 | <ibewes> rafa: and add the buildnumber-maven-plugin plugin back in? |
| 10:37:50 | <suranga> rafa ooops :) |
| 10:37:55 | <rafa> ibewes: yes |
| 10:38:05 | <suranga> rafa, any idea where this is happening in the REST module ? |
| 10:39:05 | <rafa> suranga: what charset do you want to add? |
| 10:39:16 | <suranga> rafa, I want text/plain |
| 10:39:27 | <rafa> that's not a charset ;) |
| 10:39:40 | <suranga> rafa, oooooooops |
| 10:40:01 | <suranga> rafa, I only just realized that I cant simply return an HL7 message |
| 10:40:26 | <suranga> when I try, it seems to get warped into JSON |
| 10:41:31 | <rafa> suranga: you should be able write directly to HttpServletReponse and return void |
| 10:41:48 | <ibewes> rafa: adding in that plugin did not fix it |
| 10:41:51 | <rafa> suranga: you can write there whatever you want |
| 10:42:19 | <ibewes> rafa: but all I did was update the pom.xml and rerun 'mvn clean install' |
| 10:42:44 | <rafa> ibewes: ok thanks. we'll need to find another solution. I'll look into that later. |
| 10:43:03 | <ibewes> rafa: thanks for your help! |
| 10:43:13 | <rafa> ibewes: np |
| 10:43:28 | <rafa> suranga: is it clear? |
| 10:43:36 | <suranga> rafa, hmmm.... I think :P |
| 10:43:44 | <rafa> suranga: okay :) |
| 10:43:49 | <suranga> rafa, im trying it out actually :-) |
| 10:44:08 | <suranga> rafa, if it doesnt work, you KNOW that i'll get back to you :P |
| 10:44:35 | <rafa> suranga: haha my connection is so bad today... :P |
| 10:45:03 | <suranga> rafa, :D:D:D you should try bens approach on IRC |
| 10:45:10 | <suranga> hasnt he told it to you yet ? |
| 10:45:17 | <rafa> suranga: nope |
| 10:53:07 | *** robbyoconnor has quit IRC |
| 10:54:04 | <ibewes> rafa: is the registration module here still used? https://wiki.openmrs.org/display/docs/Registration+Module |
| 10:55:08 | <rafa> ibewes: not sure, you may ask Janet Riley |
| 10:56:28 | <ibewes> rafa: ok. do you know if there is an "official" openmrs registration module? |
| 10:59:15 | <rafa> ibewes: PIH have done some great work on Patient Registration Module |
| 10:59:29 | <rafa> ibewes: there was a presentation a while ago |
| 10:59:49 | <rafa> ibewes: not sure if they published it anywhere |
| 10:59:52 | <rafa> ibewes: http://openmrs-mailing-list-archives.1560443.n2.nabble.com/Reminder-16-Feb-Developers-Forum-Partners-In-Health-s-Work-In-Progress-td7288959.html |
| 10:59:57 | <OpenMRSBot> <http://ln-s.net/$+Kj> (at openmrs-mailing-list-archives.1560443.n2.nabble.com) |
| 11:00:16 | <ibewes> rafa: ah, thanks... yeah I don't see that in the modules listed on the wiki |
| 11:00:56 | <rafa> ibewes: you may want to contact Michael Seaton from PIH |
| 11:01:46 | <ibewes> rafa: thanks kindly for the contact name! |
| 11:02:27 | <rafa> ibewes: it's also good to ask on the dev list |
| 11:02:39 | <rafa> ibewes: or better the implementers list |
| 11:03:00 | <rafa> ibewes: there may be some other modules I'm not aware of |
| 11:03:05 | <ibewes> rafa: I'm on the dev list |
| 11:03:33 | <ibewes> rafa: and I see that Michael is active on there as well... guess I'll have to bug him :) |
| 11:04:26 | <rafa> ibewes: we prefer to discuss on the list so that others can benefit as well |
| 11:04:54 | <rafa> ibewes: don't hesitate to post there any questions |
| 11:05:08 | <ibewes> rafa: certainly, thanks for the advice |
| 11:10:46 | *** bryq has joined #openmrs |
| 11:10:46 | *** ChanServ sets mode: +v bryq |
| 11:26:53 | *** james_regen has joined #openmrs |
| 11:26:53 | *** ChanServ sets mode: +v james_regen |
| 11:49:08 | *** ibewes has quit IRC |
| 11:49:39 | *** ibewes has joined #openmrs |
| 11:51:16 | *** allen2machary has quit IRC |
| 11:52:13 | *** dkayiwa has joined #openmrs |
| 11:57:57 | <rafa> dkayiwa: you did more ticktets than me in ATOM, so I was hoping you know an answer to https://tickets.openmrs.org/browse/ATOM-1 |
| 11:58:18 | <dkayiwa> rafa: i did the simplest ones :) |
| 11:59:07 | <rafa> dkayiwa: they need to be done by someone after all :D |
| 12:00:06 | <dkayiwa> rafa: hahahaha :D |
| 12:00:13 | <rafa> dkayiwa: so any clue? |
| 12:00:28 | <dkayiwa> rafa: let me look at it |
| 12:02:07 | <dkayiwa> rafa: my connection is very poor today. it is taking long to load |
| 12:02:34 | <rafa> dkayiwa: I'm not in a hurry either ;) |
| 12:02:54 | <dkayiwa> rafa: ok 8) |
| 12:06:56 | <suranga> rafa, I belive your proposed solution workssss :) |
| 12:07:09 | <rafa> suranga: I'm so relieved ;) |
| 12:07:11 | <suranga> rafa, thanks a lot for the tip ! :) |
| 12:07:20 | <rafa> suranga: you're welcome! |
| 12:07:44 | <suranga> rafa, so unfortunately for you, it looks like I wont need to bug you in the immidiate future :D |
| 12:08:05 | <rafa> suranga: define immediate future :D |
| 12:10:25 | <suranga> rafa, wellll.......... immidiate future == not until Monday probably :P |
| 12:10:40 | <rafa> fair enough ;) |
| 12:10:57 | <suranga> rafa, but ONLY regarding that HL& matter only :P |
| 12:11:02 | <suranga> *HL7 |
| 12:11:22 | <rafa> sunbiz: are you a lawyer or something? :P |
| 12:11:43 | <rafa> sunbiz: too many conditions ;) |
| 12:13:02 | <rafa> sunbiz: sorry it was for suranga |
| 12:13:35 | <suranga> rafa, :D:D:D:D: dont worry ! |
| 12:14:42 | * rafa loves Roger's essay e-mails :D |
| 12:15:43 | *** finbrein has joined #openmrs |
| 12:17:14 | <suranga> got to sign off guys, im about six hours late for lunch :P |
| 12:17:18 | *** suranga has quit IRC |
| 12:18:08 | *** finbrein_ has joined #openmrs |
| 12:20:09 | <rafa> ibewes: do you have a JIRA account? |
| 12:20:36 | <rafa> ibewes: I mean OpenMRS id |
| 12:25:14 | *** finbrein_ has quit IRC |
| 12:26:23 | <sunbiz> rafa: no... Im not a lawyer |
| 12:26:24 | <sunbiz> why?? |
| 12:26:45 | <sunbiz> oh... sorry... YES SURANGA IS A LAWYER!! |
| 12:26:54 | <rafa> sunbiz: haha |
| 12:27:05 | * sunbiz love roger's essays as well |
| 12:34:29 | *** dkayiwa has quit IRC |
| 12:35:40 | *** dkayiwa has joined #openmrs |
| 12:39:41 | <finbrein> hi rafa: can you help take a look at ATOM-10 and advise when you have a chance? Thanks |
| 12:40:10 | <rafa> !ticket ATOM-10 |
| 12:40:11 | <OpenMRSBot> rafa: [#ATOM-10] Add unit test for dateToRFC3339 method - OpenMRS JIRA - https://tickets.openmrs.org/browse/ATOM-10 |
| 12:40:40 | <ibewes> rafa: yes I do, under wes@weslandia.org |
| 12:41:13 | <finbrein> rafa: if i make Date dd = null, and pass the null date as a parameter, I get an NPE |
| 12:41:52 | <rafa> ibewes: I reported you problem with the registration module here: https://tickets.openmrs.org/browse/REG-6 |
| 12:41:58 | <rafa> ibewes: you may want to watch it |
| 12:42:24 | <ibewes> rafa: awesome, thanks! |
| 12:43:05 | <rafa> finbrein: I don't see Date dd in your patch, where should I look? |
| 12:43:52 | <finbrein> rafa: is there a way to make the called function to return something without any exception? Is a sanity check necessary in the dateToRfc3339. I have not added the null object but I have that in mind. |
| 12:44:39 | <rafa> finbrein: dateToRfc3339 should throw IllegalArgumentException when the date argument is null |
| 12:44:43 | <finbrein> rafa: i have tried with null and as expected, I get an NPE |
| 12:44:59 | <rafa> finbrein: so you need to fix the dateToRfc... method |
| 12:45:22 | <rafa> finbrein: simple if (date == null) throw new IllegalArguemntException("Date must not be null"); |
| 12:45:48 | <rafa> finbrein: and the test should have @Test(expected = IllegalArgumentException.class) |
| 12:46:30 | <finbrein> rafa: How to go about this? Do I create a new ticket for this method that will be modified? Or I can just go ahead and extend it? |
| 12:46:49 | <rafa> finbrein: sorry it shouldn't throw an exception rather return null |
| 12:46:57 | <rafa> finbrein: if (date == null) return null; |
| 12:47:06 | <rafa> finbrein: I misread |
| 12:47:17 | <rafa> finbrein: do it in the same ticket |
| 12:47:30 | <finbrein> ok, thanks, rafa |
| 12:54:03 | <dkayiwa> rafa: i have looked at ATOM-1 and i do not understand what it is all about :) |
| 12:54:14 | <rafa> dkayiwa: ok thanks! |
| 12:56:25 | *** wluyima has quit IRC |
| 12:59:23 | *** bwolfe has joined #openmrs |
| 12:59:23 | *** ChanServ sets mode: +o bwolfe |
| 13:11:57 | *** isharapremadasa has joined #openmrs |
| 13:12:17 | *** isharapremadasa is now known as isharap |
| 13:22:14 | *** harshadura has joined #openmrs |
| 13:32:18 | *** dawn_ has joined #openmrs |
| 13:32:19 | *** jkeiper has joined #openmrs |
| 13:32:28 | *** ChanServ sets mode: +v dawn_ |
| 13:32:43 | *** pulasthi7 has joined #openmrs |
| 13:32:48 | *** ChanServ sets mode: +v jkeiper |
| 13:35:03 | *** dawn__ has joined #openmrs |
| 13:35:03 | *** ChanServ sets mode: +v dawn__ |
| 13:35:04 | *** dawn_ has quit IRC |
| 13:35:04 | *** dawn__ is now known as dawn_ |
| 13:39:29 | *** wluyima has joined #openmrs |
| 13:46:33 | *** dkayiwa has quit IRC |
| 13:47:11 | <jkeiper> hey folks ... if you don't have any hbm.xml files in your module (nothing stored), should you remove or rename the omod/src/test/resources/test-hibernate.cfg.xml file if you want to do BaseModuleContextSensitiveTest tests? |
| 13:47:34 | <jkeiper> I'm getting an error saying my session-factory element has the wrong content |
| 13:47:50 | <jkeiper> i'm assuming ${hbmConfig} is possibly converting to "null" or the equivalent |
| 13:48:15 | <bwolfe> jkeiper, or just delete that ${} part |
| 13:48:34 | <bwolfe> we need a better solution that that though... |
| 13:50:25 | *** sgithens_ has joined #openmrs |
| 13:50:43 | <jkeiper> bwolfe, yeah ... is that something maven's responsible for populating? |
| 13:51:59 | <bwolfe> yeah |
| 13:52:04 | *** MarkG has joined #openmrs |
| 13:53:05 | <MarkG> looks like the view concept and add new concept pages on the most recent build of trunk throw stack traces... is this a known issue? |
| 13:54:37 | <isharap> Hi mark, i created a ticket for this now as you asked |
| 13:54:44 | <isharap> https://tickets.openmrs.org/browse/TRUNK-3345 |
| 13:54:51 | <isharap> i will add the error log now |
| 13:54:54 | <MarkG> !ticket TRUNK-3345 |
| 13:54:55 | <OpenMRSBot> MarkG: [#TRUNK-3345] Creating a new concept throws a TransientObjectException with the latest build - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3345 |
| 13:55:24 | <MarkG> @ishara looks like the view concept page fails for me as well... can you note that in a comment? |
| 13:55:51 | <bwolfe> all concepts? |
| 13:55:57 | <bwolfe> and what version/revision exactly? |
| 13:56:03 | <bwolfe> (put those in the ticket comments) |
| 13:56:15 | <bwolfe> related to rafa's latest trunk commit? |
| 13:56:28 | <bwolfe> easiest way to debug is look at what concept-related files were changed recently |
| 13:56:54 | <isharap> bwolfe: svn info is |
| 13:56:54 | <isharap> URL: http://svn.openmrs.org/openmrs/trunk Repository Root: http://svn.openmrs.org Repository UUID: 5bac5841-c719-aa4e-b3fe-cce5062f897a Revision: 27343 Node Kind: directory Schedule: normal Last Changed Author: kishoreyekkanti Last Changed Rev: 27341 Last Changed Date: 2012-05-11 13:05:41 +0530 (Fri, 11 May 2012) |
| 13:57:04 | *** mvorobey has joined #openmrs |
| 13:57:20 | <rafa> bwolfe: what did I break again? :) |
| 13:57:35 | <mvorobey> hi all |
| 13:57:50 | <dawn_> mvorobey: hi!! |
| 13:59:13 | *** dkayiwa has joined #openmrs |
| 13:59:14 | *** sunbiz1 has joined #openmrs |
| 13:59:41 | <bwolfe> rafa, viewing concepts? |
| 14:00:18 | <dawn_> !scrumon dawn |
| 14:00:18 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready. |
| 14:00:24 | <dawn_> Hi Team!!! |
| 14:00:30 | <dawn_> Today's order: wluyima , rafa , mvorobey, finbrein , dkayiwa, bwolfe |
| 14:00:49 | <bwolfe> donde esta djazayeri? |
| 14:01:07 | <rafa> bwolfe: hmm I can't think of how I could have broken that... |
| 14:01:08 | <bwolfe> dawn_, reverse alphabetical. I like it |
| 14:01:15 | *** djazayeri has joined #openmrs |
| 14:01:15 | *** ChanServ sets mode: +o djazayeri |
| 14:01:18 | <bwolfe> rafa, thats what they all say |
| 14:01:19 | <rafa> hi! |
| 14:01:26 | *** sunbiz1 has quit IRC |
| 14:01:36 | <djazayeri> hi |
| 14:01:44 | <dawn_> bwolfe: there's less complaining when it's reverse alphabetical :P |
| 14:01:45 | <wluyima> Thursday: |
| 14:01:45 | <wluyima> * Created EVNT-16 - UnsupportedOperationException should handled when calling object.getId() |
| 14:01:45 | <wluyima> * Fixed compilation issued in atom feed module to match the changes in the event module and fixed broken link to view feed page on the module localHeader |
| 14:01:45 | <wluyima> * ATOM-11 - Implement the AtomFeedConfig page |
| 14:01:45 | <wluyima> * Dev call |
| 14:01:47 | <wluyima> Friday |
| 14:01:51 | <wluyima> * ATOM-1 - Implement the AtomFeedUtil.getViewUrl(OpenmrsObject) method |
| 14:01:53 | <wluyima> * ANything else since there are no more sprint tickets |
| 14:01:55 | <wluyima> Blockers: none |
| 14:02:06 | *** sunbiz has quit IRC |
| 14:02:14 | <rafa> Today: |
| 14:02:14 | <rafa> * Reworked TRUNK-3296: Found multiple reference terms |
| 14:02:15 | <rafa> https://tickets.openmrs.org/browse/TRUNK-3296 (need to test again and commit) |
| 14:02:15 | <rafa> * Committed EVNT-17: Correct tests to be less dependent on thread scheduling |
| 14:02:15 | <rafa> https://tickets.openmrs.org/browse/EVNT-17 |
| 14:02:15 | <rafa> * Worked on ATOM-1: Implement the AtomFeedUtil.getViewUrl(OpenmrsObject) method |
| 14:02:15 | <rafa> https://tickets.openmrs.org/browse/ATOM-1 (was unsure how to implement it and stopped working) |
| 14:02:16 | <rafa> * Committed EVNT-15: Add support for create/update/delete of collections |
| 14:02:16 | <rafa> https://tickets.openmrs.org/browse/EVNT-15 |
| 14:02:17 | <rafa> No blockers. |
| 14:02:48 | <mvorobey> * Reworked TRUNK-3300 (but did not attached patch yet) |
| 14:02:48 | <mvorobey> * Bit of work on improving of documentation for In-Page Localization Project |
| 14:02:48 | <mvorobey> Without blockers |
| 14:03:16 | <finbrein> Reworking ATOM-10 |
| 14:03:16 | <finbrein> Making sure I complete it today |
| 14:03:50 | <dkayiwa> Committed response to review comments for: Implement ability to accept an asOfDate parameter - ATOM-6 |
| 14:03:51 | <dkayiwa> Committed response to review comments forr: Use the object modified time - ATOM-2 |
| 14:03:51 | <dkayiwa> Tried but failed to reproduce Wyclif's error for: Event.subscribe(Destination, EventListener) - EVNT-12 |
| 14:03:51 | <dkayiwa> Looked at this ticket but did not claim it because am not sure of what i need to do for it: Implement the AtomFeedUtil.getViewUrl(OpenmrsObject) method - ATOM-1 |
| 14:03:53 | <dkayiwa> Now working on more review comments for: Event.subscribe(Destination, EventListener) - EVNT-12 |
| 14:03:53 | <dkayiwa> And: Implement ability to accept an asOfDate parameter - ATOM-6 |
| 14:03:53 | <dkayiwa> No Blockers |
| 14:04:36 | <bwolfe> Thursday |
| 14:04:36 | <bwolfe> emails |
| 14:04:36 | <bwolfe> design for next sprint with daniel |
| 14:04:36 | <bwolfe> dev call |
| 14:04:36 | <bwolfe> ldrship call |
| 14:04:36 | <bwolfe> doctor's appt |
| 14:04:38 | <bwolfe> EVNT-16 |
| 14:04:40 | <bwolfe> reviewed/will review ATOM and EVNT tickets |
| 14:04:42 | <bwolfe> Friday |
| 14:04:44 | <bwolfe> review atom/event tickets |
| 14:04:46 | <bwolfe> plan dev forum topics |
| 14:04:48 | <bwolfe> interview dev for atlas |
| 14:04:50 | <bwolfe> do ATOM-12, atomfeed jsp |
| 14:04:59 | <bwolfe> djazayeri? |
| 14:05:09 | <djazayeri> Thursday 10-May-2012 |
| 14:05:09 | <djazayeri> * Dev call |
| 14:05:09 | <djazayeri> * Leadership call |
| 14:05:09 | <djazayeri> * Call with Andy about Concept Proposals to MVP/CIEL |
| 14:05:09 | <djazayeri> * started Email conversation about Concept Proposal module |
| 14:05:10 | <djazayeri> * emails about roles/privs |
| 14:05:10 | <djazayeri> * Merged Mark's pull request for UIFR-37 - Update FailureResult so that it uses the message source service to resolve error messages instead of just using default message |
| 14:05:11 | <djazayeri> * More work on "distribution" module |
| 14:05:12 | <djazayeri> Friday 11-May-2012 |
| 14:05:12 | <djazayeri> * Finish first-pass at "distribution" module |
| 14:05:13 | <djazayeri> no blockers |
| 14:06:19 | <dawn_> !scrumoff dawn |
| 14:06:19 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 14:06:32 | <dawn_> Discussion Points: 1) wyclif has some open time, djazayeri and bwolfe where can we best allocate his time? 2) dkayiwa have you sent an email out to the community about the roles and privileges sprint? |
| 14:06:41 | <bwolfe> discussion points: what to do if waiting on a sprint ticket. wyclif: bug fixing and/or web services finishing up (look at previous sprint page). rafal, get your 1.9 tickets in order. dkayiwa, work on 1.9 RC and/or sprint wiki pages + ticket setup for roles/privs sprint |
| 14:06:56 | <dkayiwa> dawn_: i sent yesterday |
| 14:07:14 | <bwolfe> dkayiwa, have you seen https://wiki.openmrs.org/display/RES/Being+a+Sprint+Leader ? |
| 14:07:25 | <dkayiwa> bwolfe: looking .... |
| 14:07:40 | <rafa> I'll be ready with my 1.9 tickets on Monday. |
| 14:07:45 | <dawn_> dkayiwa: thanks! |
| 14:08:20 | <dawn_> Discussion Point: making bwolfe in charge of future lists of discussion points |
| 14:09:35 | <bwolfe> cpower, are you taking over leading the scrums next week? |
| 14:11:33 | <dkayiwa> rafa: does that mean finishing them? |
| 14:11:49 | <rafa> dkayiwa: yes :) |
| 14:12:15 | <dkayiwa> rafa: so does that mean i cannot release 1.9 RC4 before you do that? |
| 14:12:22 | <cpower> wolfe: yes I am |
| 14:12:28 | <rafa> dkayiwa: correct |
| 14:12:47 | <dkayiwa> rafa: ok thanks. will wait for you on Monday |
| 14:13:09 | <dawn_> bwolfe: i'll still be on the scrum too, but lurking rather than leading |
| 14:14:12 | <cpower> bwolfe, have to start practicing my " ! scrum... on/off" and "here's your order" (would you like fries with that?) , and so on...I hope to do Dawn proud. |
| 14:14:42 | <bwolfe> !refer cpower [tabcomplete] |
| 14:14:43 | * OpenMRSBot refers cpower to "tabcomplete" --- Most IRC clients let you easily write someone's nickname in the channel using tab completion. Just type the first few letters, then <tab>, and voila! |
| 14:15:01 | * dawn_ thinks bwolfe is showing off |
| 14:15:03 | <bwolfe> cpower, we need to "learn ya" some irc too. :-) |
| 14:15:16 | <bwolfe> !beerme dawn_ |
| 14:15:16 | * OpenMRSBot slides dawn_ a pint |
| 14:15:49 | <cpower> Yeah I could you a lesson for sure, before this project it was 1991 when I last touched IRC |
| 14:16:06 | <dawn_> bwolfe: i think step 1 is emoticon use. :) the more !!!!!!!! and :) the better |
| 14:16:21 | <cpower> hehehehe |
| 14:16:24 | <cpower> !beerme |
| 14:16:24 | <OpenMRSBot> cpower: (beerme <an alias, 1 argument>) -- Alias for "action slides $1 a pint". |
| 14:16:26 | <dawn_> 1991? hahahaha!!! |
| 14:16:43 | <dawn_> that's awesome |
| 14:16:52 | <bwolfe> 1991 called. it wants its "latest and greatest" technology back. |
| 14:16:59 | <cpower> Yes in 91 I actually ran a BBS ...you know ooooold school internet |
| 14:17:02 | *** lh has quit IRC |
| 14:17:08 | <finbrein> ;) |
| 14:17:47 | <dawn_> rafa: are you looking forward to hosting bwolfe next week? |
| 14:17:56 | *** lh has joined #openmrs |
| 14:18:00 | * dawn_ assumes you two will see each other |
| 14:18:09 | <rafa> dawn_: ohh yeah!! bwolfe be aware :P |
| 14:18:47 | <cpower> !beerme dawn_ |
| 14:18:47 | * OpenMRSBot slides dawn_ a pint |
| 14:19:16 | <cpower> dawn, a beer now since sadly I'm going to miss the party tonight :-( |
| 14:20:05 | <dawn_> cpower: boooo :( |
| 14:20:25 | <bwolfe> rafa, "aware"? meaning I might be mugged? :-) or "wary" in that I won't be able to keep up with your drinking skills? |
| 14:20:59 | <bwolfe> 2 beers for dawn before noon. I foresee an unproductive afternoon ahead! |
| 14:22:05 | <dawn_> bwolfe: can i give a report on that in the scrum on monday? Today: * beer, more beer, nap, party at lorinne's with the team |
| 14:22:17 | <dawn_> bwolfe: i think rafa means "wary" :D |
| 14:22:43 | <dawn_> rafa: we went to the pizza place we took you to when you were here. luckily the pizza did not fall apart this time :D |
| 14:23:25 | <rafa> bwolfe: dawn_: I mean what I mean :D |
| 14:23:50 | <rafa> dawn_: did they hear me last time and learned it right? ;) |
| 14:24:06 | <rafa> bwolfe: I hope you like trash metal ;) |
| 14:24:30 | <dawn_> rafa: i think they heard your comment that the pizza did not resemble pizza, so they fixed it :D :D hhahaa!! |
| 14:24:52 | <rafa> dawn_: very well :D |
| 14:25:12 | <dawn_> rafa: make sure bwolfe brings back some gifts for the team ;) we want some souvenirs from Poland |
| 14:25:56 | <rafa> dawn_: okay, he won't even know what he'll be bringing back ;) |
| 14:27:35 | <rafa> I need to sign off, ttyl |
| 14:28:49 | *** rafa has quit IRC |
| 14:33:43 | *** dkayiwa has left #openmrs |
| 14:34:30 | <dawn_> djazayeri: we're waiting for you for agenda planning |
| 14:34:38 | <dawn_> djazayeri: i hope you phone in soon. the hold music is awwwwful |
| 14:34:53 | <djazayeri> dawn_: oh, sorry, there in a sec, is it the pm call line? |
| 14:35:06 | <dawn_> djazayeri: yesh |
| 14:55:12 | *** ibewes has quit IRC |
| 14:55:57 | *** ibewes has joined #openmrs |
| 14:59:51 | <bwolfe> isharap, your problem is probably due to sgithens_ commit |
| 14:59:57 | <bwolfe> (just now looking at your dev list post) |
| 15:00:03 | <sgithens_> yo |
| 15:00:14 | <bwolfe> (also MarkG) |
| 15:01:20 | <bwolfe> sgithens_, do all of your new methods have @Transactional(readOnly=true) on them? |
| 15:01:37 | <sgithens_> bwolfe: I thought they did yes |
| 15:01:46 | <sgithens_> let me double check |
| 15:04:34 | *** mvorobey has quit IRC |
| 15:09:38 | <sgithens_> hmm, the ones on ProgramWorkflowService didn't get them. Let me change that and try it out |
| 15:09:42 | <cpower> Anyone try out Google Drive yet? |
| 15:14:02 | <jkeiper> cpower, it's just Google Docs with a fancy name |
| 15:14:07 | <jkeiper> (so far) |
| 15:30:12 | *** suranga has joined #openmrs |
| 15:30:12 | *** ChanServ sets mode: +v suranga |
| 15:38:06 | <suranga> hi pulasthi7 :) |
| 15:38:45 | *** dawn_ has quit IRC |
| 15:39:16 | <cpower> jkeiper, but it also saves locally, but yeah I see your point |
| 15:40:10 | <sgithens_> bwolfe isharap : replied on the mail thread |
| 15:42:19 | *** harshadura has quit IRC |
| 15:51:44 | <pulasthi7> hi suranga, |
| 15:52:04 | <suranga> howdy ! |
| 15:52:30 | <suranga> pulasthi7, are we ready to bug james_regen ? :-) |
| 15:52:45 | <suranga> james_regen, helooo, are you here ? |
| 15:53:21 | <pulasthi7> i'm ready here :-) |
| 15:54:14 | <suranga> pulasthi7, lets wait for james_regen |
| 15:54:38 | <suranga> pulasthi7, did u have a chance to debug through the source code yet ? |
| 15:55:44 | <suranga> pulasthi7, I was looking at the R code Dr. Shaun sent... |
| 15:55:59 | <suranga> they are not all that complicated when you look at them for a while :P |
| 15:57:01 | <pulasthi7> sounds good. |
| 15:57:55 | <pulasthi7> i didn't had time to go through it again |
| 15:59:08 | <pulasthi7> suranga, i noticed it now. it's a simple calculation. |
| 15:59:30 | <suranga> pulasthi7, I remember that you had mentioned that same callculation to us once |
| 16:01:45 | <suranga> pulasthi7, its looks like the calculation is not as complex as we may have belived at first ! :D |
| 16:02:40 | <pulasthi7> suranga, yes it seems so. :) |
| 16:05:26 | <pulasthi7> suranga, seems like the complex looking code is for file i/o and parsing. |
| 16:06:40 | <suranga> pulasthi7, its seems that the hardest task from our end would be to figure out how to access the proper data objects, and thats not toooooo hard :P |
| 16:06:46 | <suranga> pulasthi7, over the next few months, we hope to see you on IRC more often.. and get to know some of the good folks from PIH and RG |
| 16:06:59 | <suranga> its aaalllllllllllllllllllllll part of the GSOC experiance... |
| 16:11:02 | <pulasthi7> the exams didn't allow me that for past few days. no more exams now till next year :-) |
| 16:14:20 | <suranga> pulasthi7, exams can be a real headache. our teachers dont realize that we have more importaint things to do than boring old exams |
| 16:14:32 | <suranga> Openmrs is waaay more intresting than exams :P |
| 16:14:57 | <suranga> pulasthi7, when u are trying to understand how the report generation works, this class will come very handy |
| 16:14:58 | <suranga> MatchingReportUtils |
| 16:15:08 | *** GuestQ679906 has joined #openmrs |
| 16:15:37 | <suranga> pulasthi7, it contains all the steps that we go through to calculate the final report |
| 16:16:07 | <suranga> that, and MatchingConfigurationUtils class probably deserve a second and third look :-) |
| 16:16:45 | <pulasthi7> i'll have a look at it. |
| 16:17:17 | <pulasthi7> suranga, if we are going to save the percentages along with the strategies, the database schemas will need to change. so it would affect the task #3 also. isn't it? |
| 16:18:12 | <suranga> pulasthi7, well, yes, the database schema would need to change |
| 16:18:46 | <suranga> but at this point we cant say if task 2 and 3 will involve the very same tables... |
| 16:25:29 | <finbrein> Hi bwolfe: could you advise on ATOM-10. I added some comments. |
| 16:31:08 | *** bryq has quit IRC |
| 16:41:04 | *** bwolfe has quit IRC |
| 16:42:35 | *** robbyoconnor has joined #openmrs |
| 16:42:35 | *** ChanServ sets mode: +v robbyoconnor |
| 16:53:16 | *** bwolfe has joined #openmrs |
| 16:53:25 | *** ChanServ sets mode: +o bwolfe |
| 16:53:28 | <bwolfe> !ticket ATOM-10 |
| 16:53:29 | <OpenMRSBot> bwolfe: [#ATOM-10] Add unit test for dateToRFC3339 method - OpenMRS JIRA - https://tickets.openmrs.org/browse/ATOM-10 |
| 16:55:07 | *** GuestQ679906 has quit IRC |
| 16:56:41 | *** cpower has quit IRC |
| 16:57:09 | <bwolfe> finbrein, you're making that unit test waaaay harder than it needs to be! :-) |
| 17:01:16 | *** isharap has quit IRC |
| 17:06:05 | <finbrein> bwolfe: give me few minutes and i'll get back |
| 17:06:20 | <bwolfe> np |
| 17:10:28 | <finbrein> bwolfe: function setDefaultTimeZone("... is not visible. |
| 17:11:06 | <bwolfe> finbrein, odd |
| 17:11:11 | <bwolfe> TimeZone.setDefault(TimeZone.getTimeZone("EST")); |
| 17:11:19 | <bwolfe> (thats what trunk has) |
| 17:11:34 | <bwolfe> (my memory failed me) |
| 17:14:00 | <finbrein> bwolfe: junit.framework.ComparisonFailure: null expected:<2012-05-08T[19:39:54Z]> but was:<2012-05-08T[22:39:54-05:00]> |
| 17:14:11 | <suranga> hi james_regen , r u here ? |
| 17:14:50 | <bwolfe> finbrein: ?? |
| 17:15:03 | <bwolfe> finbrein: ?? which one is hte one returned by the method? |
| 17:15:30 | <finbrein> bwolfe: the second |
| 17:17:38 | <bwolfe> then put that in the expected string! I didn't look up the right format, I was guessing from your comment. :-) |
| 17:17:50 | *** harshadura has joined #openmrs |
| 17:17:50 | *** ChanServ sets mode: +v harshadura |
| 17:18:31 | <finbrein> bwolfe: but that will change on another machine in a different timezone |
| 17:18:49 | <bwolfe> no, thats why you set the timezone for the jvm for that test |
| 17:19:36 | <bwolfe> finbrein, this is VERY similar to that test class in core that I linked to |
| 17:22:22 | *** Jibesh has joined #openmrs |
| 17:22:46 | *** isharapremadasa has joined #openmrs |
| 17:25:03 | *** isharapremadasa is now known as isharap |
| 17:30:48 | *** anupre has joined #openmrs |
| 17:40:04 | <finbrein> bwolfe: bwolfe: done! thanks ;) |
| 17:43:45 | *** robbyoconnor has quit IRC |
| 17:51:08 | <finbrein> bwolfe: you mentioned commit? |
| 17:51:25 | <bwolfe> indeed |
| 17:56:11 | <finbrein> so how, bwolfe? |
| 17:56:26 | <bwolfe> do you have commit rights? if not, thats the first step. :-) |
| 17:56:35 | <bwolfe> theres a wiki page about htat somewhere.. |
| 17:56:44 | <finbrein> bwolfe: i'll find.. |
| 18:00:21 | *** bwolfe has quit IRC |
| 18:15:22 | *** bwolfe has joined #openmrs |
| 18:15:22 | *** ChanServ sets mode: +o bwolfe |
| 18:16:44 | *** bryq has joined #openmrs |
| 18:16:44 | *** ChanServ sets mode: +v bryq |
| 18:22:59 | *** isharap has quit IRC |
| 18:28:53 | *** r0bby has joined #openmrs |
| 18:28:53 | *** ChanServ sets mode: +v r0bby |
| 18:29:56 | *** sgithens_ has quit IRC |
| 18:30:08 | *** sgithens_ has joined #openmrs |
| 18:38:52 | *** james_regen has quit IRC |
| 18:48:31 | *** Jibesh has left #openmrs |
| 19:09:46 | *** ibewes has quit IRC |
| 19:19:41 | <suranga> ill be signing out for the day guys ! |
| 19:19:46 | <suranga> have a nice weekend !!! |
| 19:24:08 | *** suranga has quit IRC |
| 19:32:32 | *** dawn_ has joined #openmrs |
| 19:32:32 | *** ChanServ sets mode: +v dawn_ |
| 19:37:14 | <djazayeri> bwolfe: I hate modules. :-) |
| 19:37:21 | <bwolfe> djazayeri, sorry to hear that |
| 19:37:28 | <bwolfe> I don't think they hate you |
| 19:37:36 | <djazayeri> bwolfe: I never did anything to hurt them. |
| 19:38:07 | <djazayeri> bwolfe: so, what I'm currently stuck on is that if I do: |
| 19:38:10 | <djazayeri> ModuleFactory.startModule(x) |
| 19:38:15 | <djazayeri> ModuleFactory.getStartedModules() |
| 19:38:27 | <djazayeri> the first line is not failing, but the second line is returning the empty list |
| 19:39:05 | <djazayeri> One possibility is that I could step back and just not start the modules myself, but at this point call ModuleFactory.startModules() and hope it gets it right |
| 19:39:32 | <djazayeri> bwolfe: (I'm seeing this logged error, this is a unit test) |
| 19:39:33 | <djazayeri> ERROR - JDBCExceptionReporter.logExceptions(78) |2012-05-11 12:36:38,267| Timeout trying to lock table "GLOBAL_PROPERTY"; SQL statement: |
| 19:39:33 | <djazayeri> select this_.property as property28_0_, this_.property_value as property2_28_0_, this_.description as descript3_28_0_, this_.uuid as uuid28_0_ from global_property this_ where this_.property=? [50200-135] |
| 19:40:57 | *** dawn_ has quit IRC |
| 19:41:06 | <djazayeri> bwolfe: so I guess my question is, can you think of any reason that calling ModuleFactory.startModule wouldn't immediately update the list of started modules? |
| 19:41:11 | <bwolfe> djazayeri, that GP check is probably the cause |
| 19:41:22 | <bwolfe> can you figure out where exactly that is going to be? |
| 19:42:07 | <djazayeri> annoyingly, we don't have our source code in maven, at least not for 1.8.2, so I can't step through the code there |
| 19:46:52 | <djazayeri> bwolfe: ah, I see the problem, ModuleFactory.startModule doesn't fail if starting the module fails |
| 19:47:00 | <bwolfe> that should be an easy fix. |
| 19:47:00 | <djazayeri> I have to look at moduleStartupError |
| 19:48:37 | <djazayeri> bwolfe: gah, so the problem is that for my test data I'm using a module that required 1.8.3, but the module I'm working on now just requires 1.8.2. |
| 19:48:41 | * djazayeri grins sheepishly |
| 19:48:53 | <djazayeri> maybe I was wrong to hate on modules for this |
| 19:49:26 | <bwolfe> does the javadoc of startModule tell you this? |
| 19:50:16 | <djazayeri> bwolfe: in the 1.9.x code I'm looking at it actually says * @throws ModuleException if the module throws any kind of error at startup or in an activator |
| 19:50:33 | <bwolfe> so it is the module framework's fault :-p |
| 19:53:31 | *** mvorobey has joined #openmrs |
| 19:58:49 | <mvorobey> bwolfe, hi |
| 19:59:17 | *** bryq has quit IRC |
| 19:59:53 | <bwolfe> hi mvorobey |
| 20:00:11 | <mvorobey> bwolfe, saw your comment on TRUNK-3300, thanks for catching possible NPE when reviewing, I gonna add some unit tests for this new feature tomorrow |
| 20:02:16 | <mvorobey> bwolfe, have a great weekend :) |
| 20:02:25 | *** mvorobey has quit IRC |
| 20:03:12 | <bwolfe> cool |
| 20:03:27 | * bwolfe waves at mvorobey after he's already gone |
| 20:03:28 | <bwolfe> :-| |
| 20:05:32 | *** pulasthi7 has quit IRC |
| 20:06:39 | <djazayeri> bwolfe: in our unit test framework, should I expect ModuleUtil.startModule to correctly be able to do a liquibase.xml script? |
| 20:07:21 | <djazayeri> bwolfe: or do I have to do something funky? |
| 20:07:44 | <bwolfe> no, it fails |
| 20:07:56 | <bwolfe> actually, liquibase might work |
| 20:07:58 | <bwolfe> sqldiff fails |
| 20:08:15 | <bwolfe> the problem is that the framework has probably already set up the tables from the hbm files |
| 20:08:29 | <djazayeri> bwolfe: the "it fails" answer is sufficient. :-) |
| 20:08:37 | <djazayeri> I'll revise my test case to use different modules in a zip |
| 20:18:35 | *** bryq has joined #openmrs |
| 20:18:35 | *** ChanServ sets mode: +v bryq |
| 20:22:27 | *** jkeiper has quit IRC |
| 20:32:25 | *** sgithens_ has quit IRC |
| 20:32:31 | <wluyima> djazayeri, bwolfe does the removing a GP work for you from the advanced settings page |
| 20:33:04 | *** dawn_ has joined #openmrs |
| 20:33:26 | <djazayeri> wluyima: don't know |
| 20:40:20 | <bwolfe> I haven't tried recently |
| 20:58:10 | *** rafa has joined #openmrs |
| 20:58:22 | *** ChanServ sets mode: +v rafa |
| 21:00:06 | *** r0bby has quit IRC |
| 21:30:59 | *** lh has quit IRC |
| 21:38:26 | *** bwolfe has quit IRC |
| 21:38:31 | *** bwolfe has joined #openmrs |
| 21:38:31 | *** ChanServ sets mode: +o bwolfe |
| 21:41:07 | *** rafa has quit IRC |
| 21:43:03 | *** bwolfe has quit IRC |
| 21:44:09 | *** MarkG has left #openmrs |
| 21:58:39 | *** wluyima has quit IRC |
| 22:25:37 | *** bryq has quit IRC |