| 00:59:06 | *** chopin_ has joined #openmrs |
| 01:02:04 | *** nwilkie has joined #openmrs |
| 01:08:20 | *** chopin_ has quit IRC |
| 01:32:41 | *** sgithens has joined #openmrs |
| 02:49:07 | *** djazayeri1 has joined #openmrs |
| 02:52:23 | *** djazayeri has quit IRC |
| 03:15:10 | *** djazayeri1 has quit IRC |
| 04:15:46 | *** upul` has joined #openmrs |
| 04:15:46 | *** ChanServ sets mode: +v upul` |
| 04:32:14 | *** bryq has joined #openmrs |
| 04:32:14 | *** ChanServ sets mode: +v bryq |
| 04:35:45 | *** lh has quit IRC |
| 04:45:53 | *** bryq has quit IRC |
| 04:54:42 | *** sunbiz has joined #openmrs |
| 04:54:42 | *** ChanServ sets mode: +v sunbiz |
| 05:12:06 | *** nwilkie has quit IRC |
| 05:12:31 | *** upul` has quit IRC |
| 05:21:09 | *** finbrein has quit IRC |
| 05:21:10 | *** Echidna_ has quit IRC |
| 05:21:10 | *** sunbiz has quit IRC |
| 05:21:10 | *** wyclif has quit IRC |
| 05:21:10 | *** robbyoconnor has quit IRC |
| 05:21:12 | *** sgithens has quit IRC |
| 05:21:12 | *** bwolfe has quit IRC |
| 05:21:12 | *** cpower has quit IRC |
| 05:22:27 | *** sunbiz has joined #openmrs |
| 05:22:27 | *** sgithens has joined #openmrs |
| 05:22:27 | *** wyclif has joined #openmrs |
| 05:22:27 | *** robbyoconnor has joined #openmrs |
| 05:22:27 | *** finbrein has joined #openmrs |
| 05:22:27 | *** bwolfe has joined #openmrs |
| 05:22:27 | *** cpower has joined #openmrs |
| 05:22:27 | *** Echidna_ has joined #openmrs |
| 05:22:27 | *** zelazny.freenode.net sets mode: +vvo sunbiz robbyoconnor bwolfe |
| 05:26:16 | *** finbrein has quit IRC |
| 05:47:30 | *** harshadura has joined #openmrs |
| 06:16:28 | *** djazayeri has joined #openmrs |
| 06:16:28 | *** ChanServ sets mode: +o djazayeri |
| 06:31:50 | *** harshadura has quit IRC |
| 06:55:29 | *** summon has joined #openmrs |
| 07:16:08 | *** dkayiwa has joined #openmrs |
| 07:24:26 | *** harshadura has joined #openmrs |
| 07:30:08 | *** dkayiwa has quit IRC |
| 07:46:39 | *** dkayiwa has joined #openmrs |
| 07:48:35 | *** dkayiwa has quit IRC |
| 08:27:08 | *** harshadura has quit IRC |
| 08:29:14 | *** dkayiwa has joined #openmrs |
| 08:37:36 | *** finbrein has joined #openmrs |
| 08:42:44 | *** rafa has joined #openmrs |
| 08:42:44 | *** ChanServ sets mode: +v rafa |
| 08:55:43 | *** dkayiwa has quit IRC |
| 09:07:14 | *** dkayiwa has joined #openmrs |
| 09:09:51 | *** Mkop has quit IRC |
| 09:09:51 | *** basic` has quit IRC |
| 09:16:28 | *** sunbiz1 has joined #openmrs |
| 09:17:30 | *** sunbiz has quit IRC |
| 09:25:50 | *** dkayiwa has quit IRC |
| 09:27:34 | *** sunbiz has joined #openmrs |
| 09:27:34 | *** ChanServ sets mode: +v sunbiz |
| 09:29:04 | *** sunbiz1 has quit IRC |
| 09:30:59 | *** sunbiz1 has joined #openmrs |
| 09:32:05 | *** sunbiz has quit IRC |
| 09:32:19 | *** finbrein has joined #openmrs |
| 09:34:09 | *** sunbiz has joined #openmrs |
| 09:34:09 | *** ChanServ sets mode: +v sunbiz |
| 09:35:35 | *** sunbiz1 has quit IRC |
| 09:37:29 | *** sunbiz1 has joined #openmrs |
| 09:37:41 | <finbrein> Hi all: the AtomFeed and Event modules are not listed on the modules site. Sparse information on the wiki. Just wondering where they are being used currently and the UI. Need more information. Thanks. |
| 09:38:29 | *** sunbiz has quit IRC |
| 09:43:35 | <finbrein> never mind, found something helpful aleady. |
| 09:46:58 | *** finbrein has quit IRC |
| 09:58:19 | *** Mkop has joined #openmrs |
| 09:58:19 | *** basic` has joined #openmrs |
| 09:58:19 | *** zelazny.freenode.net sets mode: +v Mkop |
| 10:36:34 | *** dkayiwa has joined #openmrs |
| 10:39:32 | *** sunbiz has joined #openmrs |
| 10:39:32 | *** ChanServ sets mode: +v sunbiz |
| 10:41:49 | *** sunbiz1 has quit IRC |
| 10:43:13 | *** sunbiz1 has joined #openmrs |
| 10:45:15 | *** sunbiz has quit IRC |
| 11:03:18 | *** rohitgoyal18 has joined #openmrs |
| 11:09:53 | *** james_regen has joined #openmrs |
| 11:09:53 | *** ChanServ sets mode: +v james_regen |
| 11:15:20 | *** robbyoconnor has quit IRC |
| 11:21:37 | *** bryq has joined #openmrs |
| 11:21:37 | *** ChanServ sets mode: +v bryq |
| 11:23:48 | *** suranga has joined #openmrs |
| 11:23:48 | *** ChanServ sets mode: +v suranga |
| 11:34:08 | *** bryq has quit IRC |
| 11:35:14 | *** bryq has joined #openmrs |
| 11:35:14 | *** ChanServ sets mode: +v bryq |
| 11:41:07 | <dkayiwa> hi rafa |
| 11:41:30 | <dkayiwa> hi bwolfe |
| 11:41:40 | <dkayiwa> djazayeri: wyclif |
| 11:42:21 | <rafa> hi dkayiwa |
| 11:43:04 | <dkayiwa> rafa: do your atomfeed module's unit tests run successfully? |
| 11:43:33 | <rafa> dkayiwa: I haven't worked with atomfeed yet |
| 11:43:39 | <dkayiwa> rafa: ok |
| 11:43:41 | <rafa> dkayiwa: not even checked out |
| 11:43:52 | <dkayiwa> rafa: ok :) |
| 11:48:50 | <suranga> mm.... hi guys, i've just noticed that the ORU_ROI handler doesnt really create a new patient when it cant match the patient id.... |
| 11:49:09 | <suranga> does this means that we can use HL7 to create new patients ? :-) |
| 11:51:23 | <rafa> dkayiwa: btw can you make https://tickets.openmrs.org/browse/STAND-47 ready for work please? |
| 11:52:53 | <rafa> suranga: are you asking what the code does or what it is supposed to do? :) |
| 11:53:03 | <dkayiwa> rafa: done :) |
| 11:53:20 | <suranga> rafa, mm... what is the code supposed to do :-P |
| 11:53:38 | <suranga> can I get it to use my HL7 to create a new patient instance ? |
| 11:53:54 | <rafa> suranga: I can't answer you that |
| 11:54:31 | <suranga> rafa, hmm.. I see... will need to do some further exploring :-) |
| 11:54:38 | <rafa> suranga: I'm not yet very familiar with HL7 |
| 11:54:49 | <rafa> dkayiwa: thanks! |
| 11:54:51 | <suranga> rafa, me two :D |
| 11:58:22 | *** dkayiwa has quit IRC |
| 12:02:45 | <rafa> why is SVN sending 40 MB file when only 10 KB changed :/ |
| 12:05:22 | *** sunbiz has joined #openmrs |
| 12:05:22 | *** ChanServ sets mode: +v sunbiz |
| 12:06:45 | <bwolfe> rafa, what are you updating? |
| 12:06:59 | <rafa> bwolfe: mvp dict in standalone |
| 12:07:16 | <bwolfe> sending the whole zip file probably? |
| 12:07:32 | <bwolfe> I don't think svn handles binary files the same way it does normal ones |
| 12:07:38 | <rafa> bwolfe: it's sql file |
| 12:07:57 | <rafa> bwolfe: I didn't put zip hoping it handles sql files ;) |
| 12:08:21 | <bwolfe> ha |
| 12:08:23 | <bwolfe> hmm |
| 12:08:27 | <bwolfe> its just text, so it should |
| 12:08:42 | <rafa> bwolfe: but apparently it's not that clever :P I hope it works right at least for updating |
| 12:09:27 | *** sunbiz1 has quit IRC |
| 12:11:15 | *** ibewes has joined #openmrs |
| 12:13:41 | <rafa> bwolfe: or maybe it took the server so long to merge the diff, I'll check the next time :D |
| 12:13:53 | *** mvorobey has joined #openmrs |
| 12:13:58 | <mvorobey> hi all |
| 12:14:02 | <rafa> hi |
| 12:14:16 | <mvorobey> rafa, how you doing ? |
| 12:14:30 | <bwolfe> rafa, what was the 10k change? |
| 12:14:39 | <rafa> mvorobey: good, thanks |
| 12:15:18 | <mvorobey> rafa: me too :) trying to by laptop during this week, but with no success yet :) |
| 12:15:18 | <ibewes> hello all |
| 12:15:39 | <mvorobey> bwolfe, hi |
| 12:16:06 | <ibewes> was there a recent change to the version of hibernate in openmrs 1.9.0-SNAPSHOT? |
| 12:16:19 | <mvorobey> bwolfe, can you, please, summarize what else we actually need to do on ATOM-7 ? |
| 12:16:28 | <bwolfe> !ticket ATOM-7 |
| 12:16:29 | <OpenMRSBot> bwolfe: [#ATOM-7] Implement AtomFeedUtil.getAtomFeedStream - OpenMRS JIRA - https://tickets.openmrs.org/browse/ATOM-7 |
| 12:16:29 | <rafa> bwolfe: hmm probably it was more than 10KB, UUIDs of all concepts... yeah okay that's fair then |
| 12:16:55 | *** r0bby has joined #openmrs |
| 12:16:55 | *** ChanServ sets mode: +v r0bby |
| 12:17:01 | <bwolfe> ibewes, I think we did upgrade hibernate in 1.9 |
| 12:17:07 | <rafa> mvorobey: I wonder how much does a laptop cost in Ukraine? |
| 12:17:19 | <bwolfe> ibewes, define "recent" . would have been 5 months ago at least |
| 12:17:21 | <mvorobey> rafa: about 600 $ |
| 12:17:37 | <ibewes> bwolfe: I thought so too, but it appears to have changed to something lower in the last week |
| 12:17:41 | <rafa> starting at $600 or a good one? |
| 12:17:41 | *** r0bby has quit IRC |
| 12:17:59 | *** r0bby has joined #openmrs |
| 12:17:59 | *** ChanServ sets mode: +v r0bby |
| 12:18:45 | <mvorobey> rafa: I think it might be good one, actually I gonna it's ASUS with Intel core i5 and and 4GB RAM and 500GB HDD |
| 12:19:19 | <bwolfe> mvorobey, weren't there a few comments? |
| 12:19:31 | <ibewes> bwolfe: I am using session.doWork in a module, but updated my dependencies today and that does not appear to be found in the current version (3.2.5) |
| 12:19:32 | <rafa> mvorobey: yeah it's quite good |
| 12:20:06 | <rafa> mvorobey: I guess prices are comparable here in Poland |
| 12:20:19 | <ibewes> mvorbey: depending on where you are located, you might want to check out refurbished dell laptops |
| 12:20:52 | <bwolfe> ibewes, hibernate is at 3.6.5 in 1.9.x and in trunk |
| 12:21:34 | <mvorobey> ibewes, thanks, will take it into account |
| 12:22:13 | <ibewes> bwolfe: hrm, that's not what I'm seeing for 1.9.0-SNAPSHOT... but maybe I just need to refresh my dependencies |
| 12:22:33 | *** dkayiwa has joined #openmrs |
| 12:22:49 | <bwolfe> ibewes, 3.2.5 is the old hibernate in 1.8.x and below |
| 12:23:18 | <mvorobey> bwolfe, nope, I thought that we closed opened issues on review, but just noticed that you had discussion with Darius, so am asking you to do summary now, because am not sure what to do |
| 12:24:32 | <ibewes> bwolfe: please correct me if I am wrong, but if I set my openMRSVersion to '1.9.0-SNAPSHOT' in my module pom.xml file shouldn't that then get all the dependencies for that version? |
| 12:25:21 | <bwolfe> ibewes, it should, yes |
| 12:25:34 | <ibewes> bwolfe; changing that version to 1.9.0-RC3 does use hibernate 3.6.5... should I not be using 1.9.0-SNAPSHOT? |
| 12:25:44 | <bwolfe> unless your module is mentioning hibernate |
| 12:26:00 | <bwolfe> ibewes, do you have 1.9.x checked out in your workspace? |
| 12:26:04 | <ibewes> what do you mean by 'mentioning hibernate' |
| 12:26:21 | *** ibewes has quit IRC |
| 12:26:28 | <bwolfe> perhaps you have a really old 1.9.0-SNAPSHOT in your personal maven repo. (from building/"mvn install"ing trunk a long time ago?) |
| 12:26:28 | <mvorobey> rafa: by the way, do you have a laptop ? |
| 12:26:40 | *** ibewes has joined #openmrs |
| 12:26:46 | <rafa> mvorobey: yes, thinkpad L412 |
| 12:26:47 | <bwolfe> perhaps you have a really old 1.9.0-SNAPSHOT in your personal maven repo. (from building/"mvn install"ing trunk a long time ago?) |
| 12:27:32 | <ibewes> bwolfe: that is certainly possible. I have the current trunk checked out... though I'm not using that source directly for my module |
| 12:27:42 | <mvorobey> rafa: I also have an old laptop, but it's a bit slow for my purposes |
| 12:28:17 | <mvorobey> rafa: it takes about 10 minutes to build openmrs without tests, and 25 with tests |
| 12:28:19 | <ibewes> bwolfe: I apologize for these stupid questions, is there documentation on the proper way to keep your personal maven repo up to date on the website? |
| 12:28:44 | <rafa> mvorobey: it has i5 inside and 4 GB RAM so it's enough for my purpose |
| 12:29:07 | <mvorobey> rafa: oh, it's pretty enough :) |
| 12:30:13 | <ibewes> mvorobey: I got an absurd laptop from dell for 1200... so if you can bump up your price a bit you might be able to do the same |
| 12:31:12 | <mvorobey> rafa: anyway, saw your last comment on in-page localization project requirement list, and already updated it list of requirement |
| 12:31:14 | <mvorobey> s |
| 12:31:24 | <mvorobey> requirement = requirements |
| 12:32:03 | <mvorobey> ibewes, unfortunately, I can not bump up my price, am only a pure student with ugly stipend |
| 12:32:06 | <bwolfe> ibewes, doubtful. thats a pretty specific question |
| 12:32:19 | <rafa> mvorobey: good, sorry for being picky ;) but I think it's better to mention it earlier than discover later |
| 12:32:33 | <bwolfe> ibewes, when you run "mvn install" on your copy of code it "installs" those jars into your personal maven repo |
| 12:32:57 | <bwolfe> ibewes, when you run "mvn jetty:run" an "install" is run as part of that process |
| 12:33:22 | <mvorobey> rafa: do not mention it :) it was really useful |
| 12:33:28 | <ibewes> bwolfe: ah... I mistakenly thought that maven would go out and get the most recent version from mavenrepo.openmrs.org |
| 12:33:30 | <bwolfe> ibewes, so you need to do an "svn update" on the copy you have checked out (assuming you have the 1.9.x branch checked out) and then run mvn install on it |
| 12:33:39 | <bwolfe> ibewes, it looks in your personal one first |
| 12:33:51 | <ibewes> ok, thanks very much for the information |
| 12:33:54 | <bwolfe> and since 1.9.0-SNAPSHOT means "this is the latest" it mistakenly thinks you have it |
| 12:33:57 | <ibewes> that makes much more sense |
| 12:34:02 | <ibewes> gotcha |
| 12:34:06 | <rafa> mvorobey: i'm happy to help |
| 12:34:09 | <bwolfe> so if you deleted the 1.9.0-SNAPSHOT from yoru personal it shoudl go find the RIGHT snapshot |
| 12:34:34 | <ibewes> but there is no maven 'get the most up-to-date version' command? |
| 12:34:54 | <mvorobey> rafa: and am happy to receive help of yours :) |
| 12:35:39 | <rafa> ibewes: you can try with -U |
| 12:35:58 | <rafa> ibewes: there's also a tick in eclipse if you run it from there |
| 12:36:33 | <rafa> ibewes: but if your personal is newer it won't help ;) |
| 12:36:56 | <ibewes> rafa: ok, what is the maven command that I would use -U with? |
| 12:37:33 | <rafa> mvn install -U |
| 12:37:57 | <ibewes> rafa, bwolfe: thanks very much for your help |
| 12:39:11 | <rafa> ibewes: np |
| 12:39:32 | <mvorobey> bwolfe, so, what about my question ? |
| 12:39:43 | <bwolfe> mvorobey, responding ont he ticket now |
| 12:39:52 | <mvorobey> bwolfe, thanks so much |
| 12:41:35 | <dkayiwa> hi bwolfe |
| 12:41:59 | <dkayiwa> bwolfe: does your atomfeed project's unit tests run successfully? |
| 12:43:34 | <mvorobey> bwolfe, thanks for comment, will work on it now |
| 12:43:54 | <mvorobey> starting from now, surew |
| 12:44:00 | <mvorobey> surew = sure |
| 12:48:24 | <r0bby> Hi |
| 13:14:30 | <rafa> bwolfe: your t-shirt size? |
| 13:17:04 | *** finbrein has joined #openmrs |
| 13:17:59 | <bwolfe> rafa, L |
| 13:18:48 | <rafa> bwolfe: thx |
| 13:19:04 | *** jriley has joined #openmrs |
| 13:19:27 | *** r0bby has quit IRC |
| 13:26:51 | *** sgithens_ has joined #openmrs |
| 13:27:52 | <ibewes> what is the best practice for including jars in a module? For example, I've got some utility classes in a local jar file that I want to use in a few modules... can this just be packaged in the module omod file? |
| 13:28:20 | *** sgithens_ has quit IRC |
| 13:28:33 | *** sgithens_ has joined #openmrs |
| 13:32:28 | <mvorobey> ibewes, afair, you can not package jar files within module bundle, only classes and resources are supposed to be packaged, but may am wrong, bwolfe, rafa? |
| 13:33:27 | <ibewes> I'm thinking that I'm just trying to do something that I shouldn't be... but I am not sure the best way to reuse those utility classes |
| 13:34:15 | <rafa> mvorobey: ibewes: jars are packaged in omods in the lib folder. If you use maven and list a jar as dependency with the compile scope then it'll be automatically included |
| 13:34:45 | <mvorobey> rafa: great, thanks |
| 13:35:54 | <rafa> mvorobey: so yes it's allowed to package jars, but you need to be sure the jar is not already included by some other module or core otherwise bad things happen :/ |
| 13:36:07 | <mvorobey> ibewes, anyway, have you checked if those classes are in the core project so they can be provided by framework |
| 13:37:13 | <mvorobey> ibewes, ? |
| 13:37:22 | <ibewes> rafa: if I use a compile scope then I am not able to specify the local path to the jar... unless I am missing something |
| 13:37:49 | <ibewes> perhaps a better question is how does OpenMRS handle this? |
| 13:38:13 | <ibewes> mvorobey: those classes are definitely not in the core project... I wrote them :) |
| 13:38:14 | <rafa> ibewes: the jar needs to be present in a maven repo, either local or remote |
| 13:38:39 | <rafa> ibewes: it's also possible to define a repo within your project :) |
| 13:39:16 | <mvorobey> ibewes, aha, that is ok :) |
| 13:40:02 | <mvorobey> that is so cool :D |
| 13:40:22 | <ibewes> ok, so I'd need to package these utility types as a maven module and then reference it from my module |
| 13:40:31 | <rafa> ibewes: I used to have an example how to setup a local repo, but I can't find it right now |
| 13:40:46 | <rafa> ibewes: you can google it |
| 13:41:02 | <rafa> I should start blogging these things ;) |
| 13:41:48 | <mvorobey> rafa: yep, it would be very good, because I'd also like to read about how to setup own local maven repo |
| 13:42:00 | <ibewes> rafa: ok, i'll look for that... thanks once again! |
| 13:43:26 | *** sunbiz1 has joined #openmrs |
| 13:45:03 | *** sunbiz has quit IRC |
| 13:47:42 | *** dawn_ has joined #openmrs |
| 13:47:45 | *** ChanServ sets mode: +v dawn_ |
| 13:54:34 | *** ibewes has quit IRC |
| 13:59:44 | *** sunbiz has joined #openmrs |
| 13:59:44 | *** ChanServ sets mode: +v sunbiz |
| 14:00:36 | <cpower> Let's get this party started |
| 14:00:53 | <dawn_> !scrumon dawn |
| 14:00:53 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready. |
| 14:01:01 | <dawn_> Hi Team!! :) |
| 14:01:26 | <dawn_> Today's Order: wyclif , rafa , mvorobey , finbrein , dkayiwa , djazayeri , bwolfe |
| 14:01:38 | <rafa> hey guys! |
| 14:01:47 | <mvorobey> dawn_, hi |
| 14:02:06 | <djazayeri> hi |
| 14:02:10 | <cpower> Hi Dawn! |
| 14:02:29 | <wyclif> Monday: |
| 14:02:29 | <wyclif> * EVNT-1 - Add ability for action to be null in Event.subscribe |
| 14:02:30 | <wyclif> * EVNT-3 - Finish EVNT.unsubscribe(String, EventListener) |
| 14:02:30 | <wyclif> * EVNT-2 - Finish Event.unsubscribe(Class, Action, Listener) |
| 14:02:30 | <wyclif> Tuesday: |
| 14:02:32 | <wyclif> * EVNT-10 - Implement the ProviderEventAdvice class |
| 14:02:34 | <wyclif> * Pick another sprint ticket |
| 14:02:36 | <wyclif> Blockers: none |
| 14:02:36 | *** sunbiz has quit IRC |
| 14:02:39 | *** sunbiz1 has quit IRC |
| 14:02:50 | <rafa> Today: |
| 14:02:50 | <rafa> * Committed STAND-47: Upgrade MVP from 1.6.4_20120309 to 1.6.4_20120313 |
| 14:02:50 | <rafa> https://tickets.openmrs.org/browse/STAND-47 |
| 14:02:50 | <rafa> * Reworked and testing again TRUNK-3296: Found multiple reference terms |
| 14:02:50 | <rafa> https://tickets.openmrs.org/browse/TRUNK-3296 |
| 14:02:50 | <rafa> TRUNK-3298: concept_reference_term uuids need to remain consistent across implementations during 1.9 upgrade |
| 14:02:50 | <rafa> https://tickets.openmrs.org/browse/TRUNK-3298 |
| 14:02:51 | <rafa> No blockers. |
| 14:03:00 | <mvorobey> Committed patch for https://tickets.openmrs.org/browse/ATOM-7 |
| 14:03:00 | <mvorobey> Finished at the same time - https://tickets.openmrs.org/browse/ATOM-8 |
| 14:03:00 | <mvorobey> Without blockers |
| 14:03:24 | <finbrein> Tuesday: |
| 14:03:24 | <finbrein> Started EVNT-4 |
| 14:03:25 | <finbrein> !ticket EVNT-4 |
| 14:03:25 | <finbrein> Rework ATOM-10 |
| 14:03:25 | <finbrein> -- end -- |
| 14:03:26 | <OpenMRSBot> finbrein: [#EVNT-4] Finish Event.unsetSubscription - OpenMRS JIRA - https://tickets.openmrs.org/browse/EVNT-4 |
| 14:04:40 | <dkayiwa> Committed followup fixes for: FACILITY-11, FACILITY-13 and FACILITY-14 |
| 14:04:41 | <dkayiwa> Committed: Implement ability to accept an asOfDate parameter - ATOM-6 |
| 14:04:41 | <dkayiwa> Reviewed and applied patch for: Validator errors on Save - FACILITY-9 |
| 14:04:41 | <dkayiwa> Working on: Finish GeneralEventAfterAdvice.getSupportedClasses to support modules - EVNT-9 |
| 14:04:41 | <dkayiwa> No Blockers |
| 14:05:31 | <djazayeri> Monday 8-May-2012 |
| 14:05:31 | <djazayeri> * Worked on building an Ubuntu VM dev environment (Eclipse + Maven + SVN really are annoying) |
| 14:05:31 | <djazayeri> * Wrote a couple blog posts about the ITECH project (will share when they're public) |
| 14:05:31 | <djazayeri> * Started the "ozip" discussion |
| 14:05:33 | <djazayeri> Today |
| 14:05:39 | <djazayeri> * Continue with the dev environment |
| 14:05:45 | <djazayeri> * Work on "ozip" module |
| 14:05:48 | <djazayeri> No blockers |
| 14:07:01 | <dawn_> bwolfe: your turn |
| 14:07:18 | <bwolfe> whoa, sorry, missed irc blinking |
| 14:07:36 | <bwolfe> Monday |
| 14:07:36 | <bwolfe> emails |
| 14:07:36 | <bwolfe> reviewed ATOM-3, writeToFeed method |
| 14:07:36 | <bwolfe> triaged RESTWS-252 |
| 14:07:36 | <bwolfe> triaged TRUNK-3327 |
| 14:07:37 | <bwolfe> commented TRUNK-2644, gp varchar |
| 14:07:39 | <bwolfe> (shortened) call with dev |
| 14:07:41 | <bwolfe> call with kieren |
| 14:07:45 | <bwolfe> reviewed ATOM tickets |
| 14:07:47 | <bwolfe> reviewed EVNT tickets |
| 14:07:49 | <bwolfe> reviewed ldrship call |
| 14:07:51 | <bwolfe> reviewed openmrs brochure |
| 14:07:53 | <bwolfe> Tuesday |
| 14:07:55 | <bwolfe> emails |
| 14:07:57 | <bwolfe> reviewed EVNT-7, header file |
| 14:07:59 | <bwolfe> reviewed ATOM-7, getatomfeedstream |
| 14:08:01 | <bwolfe> triaged ERR-312, ERR-314 |
| 14:08:03 | <bwolfe> reviewed EVNT-3, finish unsubscribe method |
| 14:08:05 | <bwolfe> reviewed TRUNK-2895, data model image |
| 14:08:07 | <bwolfe> reviewed ATOM-10, test for datetorfc3339 |
| 14:08:09 | <bwolfe> interview for dev this afternoon |
| 14:08:11 | <bwolfe> review more tickets |
| 14:08:15 | <bwolfe> set up for design call tomorrow |
| 14:08:17 | <bwolfe> no blockers |
| 14:09:01 | <dawn_> Discussion Points: 1) 1.9 Release 2) anything else? |
| 14:09:04 | <dawn_> !scrumoff dawn |
| 14:09:04 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 14:09:12 | <dawn_> bwolfe: it's Kiran, not Kieren :) |
| 14:09:15 | <bwolfe> wyclif, you did EVNT 1, 2, and 3. too bad finbrein took EVNT-4. :-) |
| 14:09:29 | <dawn_> dkayiwa: saw your email on testing. where are we on 1.9 release? |
| 14:09:32 | * bwolfe updates his file |
| 14:09:42 | <wyclif> ok |
| 14:10:10 | <rafa> as for the 1.9 release there are still two blockers that I'm trying to finish |
| 14:10:13 | <dkayiwa> dawn_: we are waiting for atleast two implementations to test |
| 14:10:30 | <finbrein> wyclif can take EVNT-4 as the next in the series |
| 14:10:34 | <rafa> TRUNK-3296 and TRUNK-3298 |
| 14:10:48 | *** mvorobey has quit IRC |
| 14:11:02 | <djazayeri> !ticket trunk-3296 |
| 14:11:03 | <OpenMRSBot> djazayeri: [#TRUNK-3296] Found multiple reference terms - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-3296 |
| 14:11:09 | <djazayeri> !ticket trunk-3298 |
| 14:11:11 | <OpenMRSBot> djazayeri: [#TRUNK-3298] concept_reference_term uuids need to remain consistent across implementations during 1.9 upgrade - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-3298 |
| 14:11:25 | <djazayeri> rafa: what will it take to finish those? just time? |
| 14:11:31 | <finbrein> wyclif, can you check, EVNT-4? |
| 14:11:38 | <wyclif> finbrein, sure |
| 14:11:57 | <rafa> djazayeri: I should commit them today. |
| 14:11:59 | <dawn_> dkayiwa: and we do not have anyone ready to test yet. is that right? |
| 14:12:10 | <rafa> djazayeri: after reviewing we're good to go |
| 14:12:18 | <rafa> djazayeri: I'm testing it right now |
| 14:12:22 | <dkayiwa> dawn_: ampath tried to test but did run into some problems |
| 14:12:50 | <dkayiwa> dawn_: James is going to also do some testing since the facilitydata module blocker tickets are now done |
| 14:13:22 | <finbrein> I wonder why they are EVNT and not EVENT |
| 14:13:22 | <dkayiwa> dawn_: PIH promissed to test, but their time span is longer than we need :) |
| 14:14:38 | <dkayiwa> dawn_: kitovu mobile, and uganda cares wanted to also do some testing, but changed their mind after the infopath formentry did not work with 1.9 |
| 14:14:54 | <dkayiwa> dawn_: will try convince them use the other alternatives :) |
| 14:16:35 | <bwolfe> finbrein, shorter is better |
| 14:17:28 | <djazayeri> bwolfe: but EVNT rather than EVENT is just silly |
| 14:17:31 | <bwolfe> finbrein, and in this case, "event" is a fairly common word. because of jira's "smart searching" if you searched on "main event processing" in jira you would only see tickets in the EVENT project with the phrase "main processing". |
| 14:17:32 | <djazayeri> :-) |
| 14:17:39 | <bwolfe> djazayeri, see above |
| 14:17:41 | <djazayeri> I guess |
| 14:17:58 | <bwolfe> thats the only reason to shorten, imho |
| 14:18:15 | <bwolfe> because 4 chars instead of 5 is silly, I agree. |
| 14:18:54 | <bwolfe> I already hate that we have a SEARCH project. more than a few times I've been stymied by the search results because I had the word "search" in there |
| 14:19:39 | *** lh has joined #openmrs |
| 14:19:39 | *** lh has joined #openmrs |
| 14:20:30 | <bwolfe> finbrein, I was totally joking about the EVNT-4 thing. wyclif doesn't need to do it. if you've started on it, you can stay assigned an finish it. :-) |
| 14:20:33 | <bwolfe> :-D |
| 14:20:35 | <finbrein> ;) |
| 14:20:38 | *** lh has joined #openmrs |
| 14:20:40 | *** lh has joined #openmrs |
| 14:20:42 | <bwolfe> I like your team player attitude though! |
| 14:20:54 | <finbrein> thanks, bwolfe |
| 14:21:00 | <dawn_> dkayiwa: thanks. |
| 14:21:17 | <dawn_> djazayeri: and bwolfe any other suggestions on getting testing done so as to finish 1.9? |
| 14:23:09 | <djazayeri> I think that once james has done testing in near-production, and others have done testing in a test environment, we should be looking to release |
| 14:24:36 | <djazayeri> i.e. my vote would be to not aim for having two implementations running an RC in a production setting. |
| 14:38:26 | <finbrein> !ticket ATOM-10 bwolfe, I used NPE since it will be thrown when trying to use a variable that turns out to be null. IAE failed since the method is designed to allow null value or just any value including date |
| 14:38:27 | <OpenMRSBot> finbrein: [#ATOM-10] Add unit test for dateToRFC3339 method - OpenMRS JIRA - https://tickets.openmrs.org/browse/ATOM-10 bwolfe, I used NPE since it will be thrown when trying to use a variable that turns out to be null. IAE failed since the method is designed to allow null value or just any value including date |
| 14:41:41 | <bwolfe> djazayeri, dawn_, I don't think it was ever "two impls running it in production environment". its "two impls testing with real data and real users". asking impls to upgrade to an RC is a huge request. |
| 14:43:42 | <bwolfe> finbrein, what happens if you give a null date? it uses current time? |
| 14:48:49 | <finbrein> bwolfe, Throws: NullPointerException - if the given pattern is null && IllegalArgumentException - if the given pattern is invalid |
| 14:49:07 | <finbrein> bwolfe, current time should be good |
| 14:56:55 | <finbrein> bwolfe; According to http://docs.oracle.com/javase/6/docs/api/java/text/SimpleDateFormat.html "format" |
| 15:05:42 | <bwolfe> finbrein, the pattern will never be null |
| 15:06:04 | <bwolfe> finbrein, if the given Date is null, it should use the current time. thats the "failing gracefully" |
| 15:06:10 | <bwolfe> can you test for that? :_) |
| 15:06:11 | <bwolfe> :-) |
| 15:08:31 | <finbrein> ok |
| 15:10:31 | *** dawn_ has quit IRC |
| 15:10:40 | *** suranga has quit IRC |
| 15:18:45 | *** bwolfe has quit IRC |
| 15:26:01 | *** bwolfe has joined #openmrs |
| 15:26:01 | *** ChanServ sets mode: +o bwolfe |
| 15:36:25 | <bwolfe> dkayiwa, did you spend any time looking into the "Roles & Privileges" sprint topic? (did we ever ask you to do that?) |
| 15:36:50 | <dkayiwa> bwolfe: no |
| 15:38:39 | <bwolfe> dkayiwa, no to both? |
| 15:39:55 | <dkayiwa> bwolfe: correct |
| 15:40:21 | <bwolfe> dkayiwa, grr, ok. I'll forward you some info |
| 15:42:38 | *** r_friedman has joined #openmrs |
| 15:44:16 | <dkayiwa> bwolfe: ok |
| 15:44:42 | <r_friedman> djazayeri, bwolfe, can't believe nobody's suggested making the file type of the multiple module "zippo" |
| 15:45:49 | *** dkayiwa has quit IRC |
| 15:46:09 | <djazayeri> bwolfe: sorry, somehow I missed that TODO last week. :-( |
| 15:46:21 | <bwolfe> was that your todo or my todo? |
| 15:46:27 | <bwolfe> either way, I'm todoing it now... |
| 15:46:48 | <djazayeri> I don't know whose todo but todo away |
| 15:52:16 | *** lh has quit IRC |
| 16:04:37 | *** cpower14 has joined #openmrs |
| 16:06:13 | *** cpower has quit IRC |
| 16:07:52 | *** dawn_ has joined #openmrs |
| 16:07:52 | *** ChanServ sets mode: +v dawn_ |
| 16:16:36 | *** rohitgoyal18 has quit IRC |
| 16:17:32 | *** lh has joined #openmrs |
| 16:17:32 | *** lh has joined #openmrs |
| 16:30:00 | *** rohitgoyal18 has joined #openmrs |
| 16:36:54 | *** mvorobey has joined #openmrs |
| 16:38:22 | <mvorobey> hi bwolfe |
| 16:38:27 | <bwolfe> yo |
| 16:38:33 | <mvorobey> bwolfe, have a minute or two ? |
| 16:38:41 | <bwolfe> no. only 3 minutes |
| 16:38:53 | <mvorobey> bwolfe, shoot :) |
| 16:39:11 | <mvorobey> bwolfe, I have a question about implementing HEAD call in AtomFeedDownloadServlet |
| 16:40:02 | <mvorobey> bwolfe, as I understand, we need to get content length of reeds file and put in into headers, is not it ? |
| 16:40:11 | <mvorobey> reeds = feeds |
| 16:40:49 | <bwolfe> mvorobey, is that required for a HEAD call? I don't know what all options would go into it |
| 16:41:04 | <bwolfe> mvorobey, you'll have to google for what the atom feed spec says about requests that are HEAD |
| 16:41:18 | <r_friedman> djazayeri, have we implemented combined searches in the current version of restws? That is, if there are searches on the encounter resource for patient and encountertype, to specify one or the other or both in the url? |
| 16:41:46 | <mvorobey> bwolfe, aha, ok, googling, I just thought that you know what exact ... but anyway, lets googling :) |
| 16:42:54 | <bwolfe> I only did HEAD once before in the formentry module's FormDownloadServlet |
| 16:43:04 | <bwolfe> and I think I only put a few things in the headers for that. def not the length of the file |
| 16:43:45 | <mvorobey> bwolfe, ok, am working on this now, thanks |
| 16:52:20 | *** mvorobey_ has joined #openmrs |
| 16:52:20 | *** mvorobey has quit IRC |
| 17:00:39 | *** robbyoconnor has joined #openmrs |
| 17:00:39 | *** ChanServ sets mode: +v robbyoconnor |
| 17:03:01 | <djazayeri> dawn_: on call now |
| 17:03:14 | <dawn_> djazayeri: it will be just you and kiran :) |
| 17:05:18 | <djazayeri> okay |
| 17:05:41 | <dawn_> djazayeri: is kiran on yet? |
| 17:05:44 | <djazayeri> yes |
| 17:05:47 | <dawn_> k |
| 17:05:47 | <djazayeri> we're talking |
| 17:09:24 | *** dawn_ has quit IRC |
| 17:10:50 | *** dawn_ has joined #openmrs |
| 17:10:50 | *** ChanServ sets mode: +v dawn_ |
| 17:15:31 | <dawn_> djazayeri: feel free to let me know how it goes. i've heard good things thus far :) |
| 17:15:41 | <dawn_> djazayeri: or we can chat on the PM call tomorrow |
| 17:17:06 | <bwolfe> r_friedman, don't lie. you were stewing over those extension names all day and HOPING you had an excuse to respond to that thread :-p |
| 17:17:46 | <r_friedman> bwolfe, caught!! |
| 17:17:49 | <bwolfe> dawn_, kiran seems very bright. I think we'll have to change some of our processes to fit him in. but he should be able to do a lot of good for us |
| 17:18:19 | <bwolfe> seems like as a BA he should be help doing meta design for the sprints, not the tickets themselves |
| 17:19:31 | <bwolfe> r_friedman, and ".mvn" isn't taken. just "mvn" is. :-) we should totally use that just to confuse and alienate every newcomer to openmrs! |
| 17:21:19 | <dawn_> bwolfe: sounds good! i think he'll be a great for the team |
| 17:21:32 | <dawn_> bwolfe: just don't ask him about MC Escher, okay? :P |
| 17:25:59 | <bwolfe> dawn_, now I have to |
| 17:27:29 | *** mvorobey_ is now known as mvorobey |
| 17:33:22 | <mvorobey> bwolfe, need to talk with you if you wish |
| 17:36:43 | <bwolfe> ok, talk away |
| 17:36:44 | <bwolfe> :-) |
| 17:37:03 | <mvorobey> bwolfe, after some googling, I can summarize, that it's need to send back Content-Type, Content-Length, If-Modified-Since or ETag headers on HEAD http request for ATOM feed |
| 17:37:27 | <mvorobey> bwolfe, do you agree with this list |
| 17:37:29 | <mvorobey> ? |
| 17:41:43 | <bwolfe> so content-length is required? |
| 17:42:24 | <bwolfe> I guess we can calculate that the first time and cache that and update with each new file. no reason to recalculate from all the files. |
| 17:42:41 | <bwolfe> the if-modified-since is easy to calculate from the <updated> field in the header file |
| 17:46:25 | <mvorobey> bwolfe, I do suspect, that Content-Length is required, because I saw in some tutorials that that header is send back on doHead() call. But there is no specificat about this header in ATOM specifcation |
| 17:46:45 | *** wyclif has quit IRC |
| 17:46:54 | <mvorobey> specificat = specific |
| 17:47:23 | <mvorobey> bwolfe, and what is about ETag ? |
| 17:48:50 | <bwolfe> etag, iirc, is a unique number. it should be different for each different file. so a client could save the etag value from last time they checked. if they do a HEAD call and the etag value has not changed, they know there is no reason to do a GET call. if the etag value is different then something was added and a GET is required |
| 17:49:16 | <mvorobey> bwolfe, we can actually use a date time of the last change of feed content |
| 17:49:17 | <bwolfe> you can use the last modified datetime as the etag I think |
| 17:49:37 | <bwolfe> (unless for some reason a new entry is added that is the exact same time as the previous one) |
| 17:49:42 | <mvorobey> bwolfe, aha, we think in the same way, it is good |
| 17:50:37 | <mvorobey> bwolfe, it's not possible because entry write operation is synchronized |
| 17:51:04 | <mvorobey> bwolfe, so we won't have two entries with the same updatedDate |
| 17:51:35 | <bwolfe> what if the writing takes less than a millisecond? :-) |
| 17:52:15 | <mvorobey> bwolfe, then we should add an extra sleep statement after such fast writting :) |
| 17:52:30 | <bwolfe> haha |
| 17:53:37 | <mvorobey> bwolfe, and what to actually do if such writting occurs ? |
| 17:54:16 | <bwolfe> hmm |
| 17:57:56 | <mvorobey> bwolfe, stop, am just confused, we even do not need a content length for HEAD call, because HEAD actually does not include body, so Content-Length is 0 |
| 17:58:41 | <bwolfe> thats good. unless of course its meant to be the body length if a GET was called |
| 17:59:53 | <mvorobey> bwolfe, hah, you are right, so need to include that header to ? |
| 18:00:06 | <bwolfe> mvorobey, the datetime format for the atom feed is "yyyy-MM-dd'T'HH:mm:ss" this is grouped into seconds. |
| 18:00:16 | *** dawn_ has quit IRC |
| 18:00:22 | <bwolfe> so you can't just use the updated time as that might cover several entries |
| 18:01:00 | *** dawn_ has joined #openmrs |
| 18:01:00 | *** ChanServ sets mode: +v dawn_ |
| 18:01:52 | <mvorobey> bwolfe, shoot, what a bummer :( |
| 18:03:37 | <mvorobey> bwolfe, so I do not see any other way rather then read atom feed stream, calculate necessary headers and sent them without actual response body, but it would not be so fast |
| 18:04:34 | *** dawn__ has joined #openmrs |
| 18:04:34 | *** ChanServ sets mode: +v dawn__ |
| 18:04:34 | *** dawn_ has quit IRC |
| 18:04:34 | *** dawn__ is now known as dawn_ |
| 18:05:51 | <mvorobey> bwolfe, off top question, why do we use file system I/O for ATOM feeds rather then keep feeds in DB (AFAIK DB I/O is much faster) ? |
| 18:06:46 | <bwolfe> mvorobey, my idea was static reading of filestream to outputstream is faster |
| 18:07:04 | <bwolfe> instead of having to construct the entire output from db rows every time |
| 18:07:29 | <bwolfe> mvorobey, correct, you don't want to construct the hold stream just to get the size each time. that defeats the purpose of HEAD ! |
| 18:07:38 | <mvorobey> bwolfe, yep, less memory consumption |
| 18:07:52 | <bwolfe> mvorobey, file size should be calculated and cached each time an entry is added |
| 18:08:16 | <mvorobey> bwolfe, where to cache file size ? |
| 18:08:34 | <bwolfe> mvorobey, can we add it as an element in the header file? |
| 18:08:50 | <bwolfe> then you only have to look at that to get the size, etag, and last modified times |
| 18:09:10 | <djazayeri> mvorobey, bwolfe: is there only a single active feed file at a time? |
| 18:09:21 | <mvorobey> bwolfe, cool, it's so easy, I should not have to say it, but you genius :) |
| 18:09:41 | <mvorobey> you are genius |
| 18:09:58 | <bwolfe> mvorobey, I only have moments of genius |
| 18:09:59 | <mvorobey> djazayeri, yes, now only oe |
| 18:10:05 | <djazayeri> any reason not to just cache that info in member vars in AtomService? |
| 18:10:19 | <mvorobey> oe = one |
| 18:10:20 | <bwolfe> djazayeri, I made a ticket to set it to rolling |
| 18:10:38 | <djazayeri> bwolfe: but even if rolling, only one is being actively appended to |
| 18:10:53 | <mvorobey> djazayeri, yes, onlu one |
| 18:11:01 | <mvorobey> onlu = only |
| 18:15:53 | *** rohitgoyal18 has quit IRC |
| 18:17:47 | <mvorobey> bwolfe, one interesting moment, what if client will sent asOfDate parameter, how to calculate content length and Etag in this case ? or such request parameter is impossible for HEAD call ? |
| 18:18:05 | <mvorobey> sent = send |
| 18:18:09 | <bwolfe> ignore that param for HEAD calls |
| 18:18:45 | <djazayeri> bwolfe, mvorobey: again, I'm totally uninformed, but is there a way to get rid of the asOfDate parameter entirely, and do things via if-modified-since headers? |
| 18:18:51 | <djazayeri> (or some other header) |
| 18:20:27 | <mvorobey> djazayeri, I actually think that if-modified-since is left in HTTP 1.1 for backward compability and it has some other meaning rathyer then asOfDate parameter |
| 18:20:43 | <mvorobey> rathyer = rather |
| 18:24:30 | <bwolfe> sounds similar though mvorobey |
| 18:24:55 | <bwolfe> I haven't heard of it before djazayeri, but if it is meant for something like this, yes. |
| 18:25:33 | <mvorobey> bwolfe, so, shall I get rid of asOfDate ? |
| 18:25:34 | <bwolfe> djazayeri, I thikn its more meant for "show me the whole page 'if modified since'" instead of "give me only modified content added since 'asOfDate'" |
| 18:28:54 | *** wyclif has joined #openmrs |
| 18:32:20 | <djazayeri> bwolfe: good point |
| 18:33:14 | *** r0bby has joined #openmrs |
| 18:33:19 | *** r0bby has joined #openmrs |
| 18:33:19 | *** ChanServ sets mode: +v r0bby |
| 18:37:21 | *** robbyoconnor has quit IRC |
| 18:38:41 | *** r0bby has quit IRC |
| 18:39:47 | *** dawn__ has joined #openmrs |
| 18:39:47 | *** ChanServ sets mode: +v dawn__ |
| 18:39:47 | *** dawn_ has quit IRC |
| 18:39:47 | *** dawn__ is now known as dawn_ |
| 18:43:48 | *** r_friedman has quit IRC |
| 18:44:20 | *** mvorobey has quit IRC |
| 18:44:29 | *** mvorobey has joined #openmrs |
| 18:45:35 | *** dkayiwa has joined #openmrs |
| 18:46:01 | <mvorobey> djazayeri, bwolfe: did I miss something ? |
| 18:46:25 | <bwolfe> mvorobey, missed nothing. I think leave it as it is |
| 18:46:27 | <djazayeri> mvorobey: basically my suggestion was wrong |
| 18:47:36 | <mvorobey> bwolfe, actually for now I only have a method stub for doHead() :) so, please, can you summarize our discussion ? |
| 18:48:59 | *** james_regen has left #openmrs |
| 18:52:52 | *** mvorobey_ has joined #openmrs |
| 18:52:53 | *** mvorobey has quit IRC |
| 18:53:13 | *** mvorobey_ is now known as mvorobey |
| 18:54:57 | <mvorobey> - Content-Length is recalculated everytime when new entry is added |
| 18:55:02 | <mvorobey> - Etag is nothing else then <updated /> tag value |
| 18:55:04 | <mvorobey> - Last-Modified is the same sa Etag |
| 18:55:10 | <mvorobey> bwolfe, right ? |
| 18:55:28 | <mvorobey> sa = as |
| 18:55:52 | <bwolfe> sounds right |
| 18:56:27 | <mvorobey> bwolfe, thanks for help |
| 18:56:36 | <mvorobey> djazayeri, thatnks too |
| 18:56:44 | <bwolfe> (on a call, so only using 10% of my resources for this convo ;-)) |
| 18:56:49 | <mvorobey> thatnks = thanks |
| 18:57:30 | <mvorobey> bwolfe, np, have a nice call :D |
| 18:58:45 | *** sgithens__ has joined #openmrs |
| 18:59:07 | *** dawn_ has quit IRC |
| 18:59:32 | *** dawn_ has joined #openmrs |
| 18:59:32 | *** ChanServ sets mode: +v dawn_ |
| 18:59:48 | *** dawn_ has quit IRC |
| 18:59:56 | *** dawn_ has joined #openmrs |
| 18:59:56 | *** ChanServ sets mode: +v dawn_ |
| 19:01:55 | *** sgithens_ has quit IRC |
| 19:06:03 | *** dave12 has joined #openmrs |
| 19:06:13 | *** dawn_ has quit IRC |
| 19:08:05 | *** dkayiwa has quit IRC |
| 19:17:19 | <wyclif> hi bwolfe |
| 19:20:37 | <bwolfe> hi wyclif |
| 19:21:39 | <wyclif> bwolfe, i wanted to suggest another way to handle EVNT-10 |
| 19:21:55 | <wyclif> bwolfe, i have just added a comment to the ticket |
| 19:21:58 | <bwolfe> !EVNT-10 |
| 19:21:59 | <OpenMRSBot> bwolfe: Error: "EVNT-10" is not a valid command. |
| 19:22:05 | <bwolfe> !ticket EVNT-10 |
| 19:22:08 | <OpenMRSBot> bwolfe: [#EVNT-10] Implement the ProviderEventAdvice class - OpenMRS JIRA - https://tickets.openmrs.org/browse/EVNT-10 |
| 19:22:56 | <bwolfe> wyclif, recommented |
| 19:23:18 | <bwolfe> wyclif, its a good suggestion if we weren't supported 1.8 and below. :-) |
| 19:24:12 | <wyclif> bwolfe, with my approach it still compiles with 1.8 since i dont make direct references to Provider and ProviderService, am only using the fully qualified class name |
| 19:24:32 | <wyclif> name(s) |
| 19:24:55 | <wyclif> bwolfe, can i add a patch and you look at it |
| 19:28:18 | <bwolfe> wyclif, sure |
| 19:29:26 | *** dkayiwa has joined #openmrs |
| 19:31:15 | <bwolfe> wyclif, but half the point is to test out adding the other advice and it still working with previous versions... :-) |
| 19:31:21 | <bwolfe> but lets see your impl. :-) |
| 19:32:16 | <mvorobey> bwolfe, are you ok with using of an updateDate lang value as Etag ? |
| 19:32:28 | <mvorobey> lang = long |
| 19:34:01 | <mvorobey> bwolfe, so we will have entry <etgToken>1398124502</etagToken> within atomheaderfile ? |
| 19:34:28 | <mvorobey> bwolfe, so we will have entry <etagToken>1398124502</etagToken> within atomheaderfile |
| 19:34:39 | *** dkayiwa has quit IRC |
| 19:37:58 | <bwolfe> mvorobey, how are you generating that? I'd rather it not say etag...thats html specific |
| 19:38:22 | *** dawn_ has joined #openmrs |
| 19:38:22 | *** ChanServ sets mode: +v dawn_ |
| 19:38:44 | *** dawn_ has quit IRC |
| 19:38:47 | *** dawn__ has joined #openmrs |
| 19:38:47 | *** ChanServ sets mode: +v dawn__ |
| 19:39:20 | *** mvorobey has quit IRC |
| 19:39:35 | *** mvorobey has joined #openmrs |
| 19:41:12 | *** sgithens__ has quit IRC |
| 19:41:26 | <mvorobey> bwolfe, I 'm here again, what did you say about previous question ? |
| 19:43:17 | <bwolfe> mvorobey, how are you generating that? I'd rather it not say etag...thats html specific |
| 19:43:20 | <bwolfe> mvorobey, bad connection today? |
| 19:50:47 | <mvorobey> bwolfe, yes, it's a terrible weather in my willage, so my connection is awful :( |
| 19:53:07 | <mvorobey> bwolfe, I would generate that by getting long value of updated |
| 19:53:30 | <bwolfe> mvorobey, do you really need to store that in the header file then? |
| 19:54:05 | *** dawn__ has quit IRC |
| 19:54:13 | *** jriley has left #openmrs |
| 19:54:17 | <mvorobey> bwolfe, yes, because updated vale has yyyy-MM-dd'T'HH:mm:ss format which does not include milliseconds |
| 19:55:31 | <mvorobey> bwolfe, and I'd love to have etagToken value as milliseconds (I would name it versionId rather then etagToken) |
| 19:59:09 | <bwolfe> versionId is fine. or even just "version" |
| 20:00:12 | <mvorobey> bwolfe, version meant to be serial value, but it eventually would not be serial, so I'd take versionId |
| 20:00:48 | <bwolfe> def won't be serial. but I don't think matters. version or versionId is up to you |
| 20:01:15 | <mvorobey> bwolfe, ok, thanks :) |
| 20:03:28 | *** summon has left #openmrs |
| 20:04:03 | <bwolfe> wyclif, wheres that patch? |
| 20:04:40 | <wyclif> bwolfe, i was still testing it an ran into some things that i have just been fixing |
| 20:04:51 | <wyclif> bwolfe, give me about 5-10min |
| 20:04:57 | <bwolfe> ah, ok |
| 20:06:32 | *** dkayiwa has joined #openmrs |
| 20:13:48 | *** Mkop has quit IRC |
| 20:14:08 | *** Mkop has joined #openmrs |
| 20:14:08 | *** ChanServ sets mode: +v Mkop |
| 20:15:20 | <dave12> Hi, can anyone confirm I'm sending the right json structure to the user resource in the rest web services module? http://pastebin.com/hQjRRGSL |
| 20:16:49 | *** dkayiwa has quit IRC |
| 20:27:55 | <wyclif> bwolfe, done |
| 20:28:37 | <wyclif> bwolfe, i can actually move that logic in the activator to the Advisor itself |
| 20:30:53 | <bwolfe> dave12, it /looks/ right, what error are you getting? |
| 20:37:08 | *** dawn_ has joined #openmrs |
| 20:37:08 | *** ChanServ sets mode: +v dawn_ |
| 20:39:18 | *** dawn_ has quit IRC |
| 20:41:58 | *** dkayiwa has joined #openmrs |
| 20:43:38 | *** mvorobey has quit IRC |
| 20:44:06 | *** bryq has left #openmrs |
| 20:52:44 | *** dkayiwa_ has joined #openmrs |
| 20:54:35 | *** dkayiwa has quit IRC |
| 20:54:35 | *** dkayiwa_ is now known as dkayiwa |
| 21:00:26 | <bwolfe> dave12, figure anything out? |
| 21:03:32 | <dave12> bwofle, sorry am back now, one second |
| 21:10:29 | <dave12> bwolfe, when I sent that json to /ws/rest/v1/user I get this exception as the response: http://pastebin.com/ABujV1vT |
| 21:12:10 | <dave12> bwolfe, I'm also working from the trunk of rest web services module (rev 27147) |
| 21:24:39 | *** dkayiwa has quit IRC |
| 21:30:48 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Announcements List: 2012 Implementers Meeting: Scholarship Application Now Available! <https://listserv.iupui.edu/cgi-bin/wa-iupui.exe?A2=ind1205&L=openmrs-announce-l&P=73> |
| 21:53:28 | *** rafa has quit IRC |
| 22:39:40 | *** wyclif has quit IRC |
| 22:51:46 | *** sgithens has quit IRC |
| 23:19:54 | *** wyclif has joined #openmrs |
| 23:30:44 | *** lh has quit IRC |
| 23:46:27 | *** maro has joined #openmrs |
| 23:50:01 | *** finbrein has quit IRC |
| 23:57:28 | <dave12> bwolfe, did you try to reproduce the problem? or do you think I should report this as an issue? |