00:00:26
|
*** r_friedman has quit IRC
|
00:04:34
|
<finbrein> djazayeri: one more question, can you pls take a look at this "Location Filter" under "Indicator Definitions"? I can share my screen
|
00:05:30
|
<finbrein> djazayeri: ping
|
00:09:09
|
<djazayeri> finbrein: hi
|
00:09:17
|
<finbrein> hi
|
00:09:34
|
<djazayeri> finbrein: I'm logging into connect now
|
00:10:38
|
<finbrein> djazayeri: The CohortDefinition combo box is not populated with data on the "Location Filter"
|
00:11:34
|
<djazayeri> finbrein: I don't remember exactly how that works, but you have to have pre-created a filter that has a single location as a parameter (I think)
|
00:12:07
|
<djazayeri> finbrein: I mean: do a query like EncounterCohortQuery for any encounters at location=parameter
|
00:12:14
|
<djazayeri> finbrein: save that as "Any encounter at location"
|
00:12:21
|
<djazayeri> finbrein: then I believe it will appear in the dropdown
|
00:12:56
|
<djazayeri> finbrein: also, please make comments on the wiki page saying which parts were not clear. (e.g. that you need to find concepts relevant to your own dictionary, and this one here.)
|
00:13:21
|
<finbrein> djazayeri: ok, i'll
|
00:14:17
|
<djazayeri> finbrein: give it a name with the word location in int
|
00:14:28
|
<djazayeri> e.g. "Any encounter at location"
|
00:14:36
|
<djazayeri> finbrein: also, don't choose a fixed value for location, make it a parameter
|
00:16:31
|
<finbrein> djazayeri: good, ty ;)
|
00:17:02
|
<finbrein> djazayeri: i'll stop sharing now and continue later
|
00:17:20
|
<djazayeri> finbrein: cool
|
00:18:10
|
*** finbrein has quit IRC
|
00:40:47
|
*** robbyoconnor has joined #openmrs
|
00:40:47
|
*** ChanServ sets mode: +v robbyoconnor
|
01:19:59
|
*** james_regen has quit IRC
|
01:20:10
|
*** james_regen has joined #openmrs
|
01:20:10
|
*** ChanServ sets mode: +v james_regen
|
02:01:59
|
*** tobn_g_ has joined #openmrs
|
02:04:08
|
*** tobn_g has quit IRC
|
02:04:08
|
*** tobn_g_ is now known as tobn_g
|
02:40:22
|
*** dmexs has quit IRC
|
02:44:06
|
*** dmexs has joined #openmrs
|
03:09:50
|
*** dmexs has quit IRC
|
03:18:45
|
*** dmexs has joined #openmrs
|
03:28:51
|
*** upul` has joined #openmrs
|
03:28:51
|
*** ChanServ sets mode: +v upul`
|
03:33:50
|
*** dmexs has quit IRC
|
04:43:34
|
*** suranga has joined #openmrs
|
04:43:34
|
*** ChanServ sets mode: +v suranga
|
04:49:28
|
<tobn_g> djazayeri: HTML form entry question/possible bug if you're up?
|
04:51:10
|
*** summon has joined #openmrs
|
04:57:08
|
*** lh has quit IRC
|
05:10:03
|
<djazayeri> tobn_g: I'm typing an email now, and then going to bed, so ask quickly
|
05:10:39
|
<tobn_g> djazayeri: I think it's a bug so will ticket it. Basically having a concept with " or \ seems to kill autofill
|
05:11:18
|
<tobn_g> Like having a Drug AUGMENTIN B.I.D "875"MG 14TAB means that autofill won't find anything when you type AU...
|
05:11:33
|
<djazayeri> sounds like a bug
|
05:12:54
|
<tobn_g> djazayeri: at first just couldn't figure out why those concepts wouldn't show up, then happened to see the " and figured I'd try removing itâ¦got lucky I guess.
|
05:13:03
|
<tobn_g> djazayeri: thanks and have a good night
|
05:13:15
|
<tobn_g> djazayeri: sunny & lovely morning here :)
|
05:15:46
|
*** summon has quit IRC
|
06:04:26
|
*** suranga has quit IRC
|
06:10:51
|
*** summon has joined #openmrs
|
06:22:23
|
*** summon has left #openmrs
|
06:40:25
|
*** pascal``` has joined #openmrs
|
06:41:44
|
*** pascal`` has quit IRC
|
06:46:10
|
*** bryq has joined #openmrs
|
06:46:10
|
*** ChanServ sets mode: +v bryq
|
06:51:56
|
*** bryq has quit IRC
|
07:59:01
|
*** rafa has joined #openmrs
|
07:59:01
|
*** ChanServ sets mode: +v rafa
|
08:05:18
|
*** tobn_g has quit IRC
|
08:23:07
|
*** harshadura has joined #openmrs
|
08:39:16
|
*** harshadura_ has joined #openmrs
|
08:42:07
|
*** harshadura has quit IRC
|
09:35:00
|
*** dkayiwa has joined #openmrs
|
10:30:15
|
*** snoppy has joined #openmrs
|
10:31:14
|
*** summon has joined #openmrs
|
10:31:26
|
*** summon has left #openmrs
|
10:34:12
|
*** dkayiwa has quit IRC
|
10:38:04
|
*** sunbiz has joined #openmrs
|
10:38:11
|
*** ChanServ sets mode: +v sunbiz
|
10:45:44
|
*** dkayiwa has joined #openmrs
|
10:52:11
|
*** robbyoconnor has quit IRC
|
10:57:34
|
*** dkayiwa has quit IRC
|
10:59:21
|
*** dkayiwa has joined #openmrs
|
10:59:31
|
*** bryq has joined #openmrs
|
10:59:31
|
*** ChanServ sets mode: +v bryq
|
11:01:59
|
*** dkayiwa has quit IRC
|
11:10:40
|
*** tobn_g has joined #openmrs
|
11:18:37
|
*** pascal``` has quit IRC
|
11:21:00
|
*** upul` has quit IRC
|
11:24:41
|
*** tobn_g has quit IRC
|
11:31:07
|
*** harshadura_ has quit IRC
|
11:31:17
|
*** harshadura has joined #openmrs
|
11:53:31
|
*** snoppy has left #openmrs
|
12:07:21
|
*** r5friedman has joined #openmrs
|
12:07:29
|
*** r5friedman is now known as r_friedman
|
12:07:59
|
<r_friedman> rafa: hey rafa, got a minute?
|
12:08:06
|
<rafa> r_friedman: hey
|
12:08:19
|
<rafa> yes
|
12:08:25
|
<r_friedman> so i am trying to exercise a junit test
|
12:08:38
|
<r_friedman> everything was fine until i edited my test class
|
12:08:50
|
<r_friedman> since then, jrunner has not been able to find the class
|
12:09:01
|
<r_friedman> even with a clean install, clean project, restart eclipse
|
12:09:38
|
<rafa> r_friedman: do you have automatic builds enabled?
|
12:09:42
|
<r_friedman> yes
|
12:10:23
|
<rafa> r_friedman: do you fire up the test with the rerun test button or run as -> junit test
|
12:10:36
|
<r_friedman> from a debug configuration
|
12:10:41
|
<r_friedman> here is a cute angle
|
12:10:48
|
<r_friedman> my edit consisted of removing 2 lines
|
12:11:25
|
<rafa> r_friedman: try right click on the test file and debug as -> junit test
|
12:11:26
|
<r_friedman> the first time i tried to run it after the edit, the first removed line ran, even though the debug display was pointing to the next unremoved statement
|
12:11:52
|
<rafa> r_friedman: maybe it wasn't recompiled
|
12:11:59
|
<rafa> r_friedman: any build errors?
|
12:12:13
|
<r_friedman> that's why i did clean install, and it compiled clean
|
12:12:25
|
<r_friedman> thereafter it couldn't be found
|
12:12:42
|
<r_friedman> but i will try letting it run all procedures, see if it makes a differnce
|
12:13:14
|
<r_friedman> nope, still can't find it
|
12:13:28
|
<rafa> r_friedman: can you pastebin failure trace?
|
12:13:47
|
<rafa> r_friedman: and check if top menu -> project -> build automatically is ticked
|
12:14:47
|
<r_friedman> http://pastebin.com/zXr0gc2w
|
12:14:53
|
<rafa> r_friedman: also try to edit the file again and save
|
12:14:54
|
<r_friedman> yes it's ticked
|
12:15:39
|
<rafa> r_friedman: and do project - clean
|
12:15:52
|
<r_friedman> made a dummy edit, build started automatically
|
12:16:29
|
<r_friedman> and project clean triggered another build
|
12:16:58
|
<rafa> r_friedman: okay, and now try running the test...
|
12:17:00
|
<r_friedman> and same error
|
12:17:09
|
<rafa> r_friedman: very strange
|
12:17:54
|
<rafa> r_friedman: do you see the class in target/classes?
|
12:17:57
|
<r_friedman> rafa that's why i asked someone who's been awake longer than me
|
12:19:21
|
<r_friedman> rafa no
|
12:19:39
|
*** chopin_ has joined #openmrs
|
12:19:44
|
<rafa> r_friedman: sorry test-classes
|
12:19:49
|
*** chopin_ is now known as jkeiper
|
12:19:52
|
<r_friedman> checked both, rafa
|
12:19:56
|
*** chopin_ has joined #openmrs
|
12:19:59
|
*** ChanServ sets mode: +v jkeiper
|
12:21:00
|
<jkeiper> hi
|
12:21:07
|
<r_friedman> hi jeremy
|
12:21:30
|
<jkeiper> goood morning roger
|
12:21:37
|
<rafa> r_friedman: I have no idea
|
12:21:45
|
<rafa> jkeiper: hey!
|
12:22:06
|
<r_friedman> rafa, how far are you from Rostock?
|
12:22:39
|
<rafa> a few hundred kilometers
|
12:22:54
|
<r_friedman> not a garden spot that you would be visiting i guess
|
12:23:01
|
<rafa> r_friedman: hehe nope
|
12:23:30
|
<rafa> r_friedman: are you going there?
|
12:23:35
|
<r_friedman> my gsoc is from there
|
12:23:47
|
<rafa> r_friedman: I see
|
12:24:16
|
<r_friedman> rafa actually he is not from there, just going to school there
|
12:25:55
|
<jkeiper> heyya rafa
|
12:28:38
|
<rafa> r_friedman: try going to the java build path in properties of the api project and see if there's an entry for src/test/java and the output folder is target/test-classes
|
12:30:11
|
<r_friedman> rafa, looks good
|
12:31:17
|
<rafa> r_friedman: I ran out of ideas. I'd remove the project from eclipse and import it again.
|
12:32:02
|
<r_friedman> ok, i'm going to @ignore the failing tests and do clean install without skip tests first, rafa
|
12:35:35
|
*** dkayiwa has joined #openmrs
|
12:42:47
|
<r_friedman> rafa, found error in build path
|
12:44:55
|
*** wyclif has quit IRC
|
13:00:16
|
*** dawn_ has joined #openmrs
|
13:00:45
|
*** ChanServ sets mode: +v dawn_
|
13:09:03
|
*** dkayiwa has quit IRC
|
13:12:22
|
*** dkayiwa has joined #openmrs
|
13:16:18
|
<dkayiwa> hi jkeiper
|
13:18:04
|
<jkeiper> heyya dkayiwa
|
13:18:05
|
<jkeiper> :-)
|
13:18:32
|
<dkayiwa> jkeiper: just posted my comment on TRUNK-2639 :)
|
13:18:40
|
<dkayiwa> jkeiper: waiting for an answer :)
|
13:18:45
|
<jkeiper> dkayiwa, haha okay
|
13:18:48
|
<jkeiper> in a brief meeting
|
13:19:01
|
<dkayiwa> jkeiper: sorry i meant TRUNK-3143 :)
|
13:19:07
|
*** finbrein has joined #openmrs
|
13:19:09
|
<dkayiwa> !ticket TRUNK-3143
|
13:19:09
|
<jkeiper> np
|
13:19:11
|
<OpenMRSBot> dkayiwa: [#TRUNK-3143] Drug formulary from drug table does not show up in concept widget lookup in infopath - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3143
|
13:20:21
|
*** dmexs_ has joined #openmrs
|
13:21:45
|
*** dmexs_ is now known as dmexs__
|
13:22:17
|
*** dmexs__ is now known as dmexs___
|
13:22:56
|
*** dmexs___ is now known as dmexs_
|
13:23:08
|
*** dmexs_ has quit IRC
|
13:23:13
|
<jkeiper> dkayiwa, essentially this is a formentry-related ticket
|
13:23:29
|
*** dmexs_ has joined #openmrs
|
13:23:34
|
<jkeiper> dkayiwa, i will update the ticket with a typical url letting you see the widget without having infopath installed
|
13:24:10
|
<dkayiwa> jkeiper: thanks!!! :)
|
13:24:58
|
<dkayiwa> jkeiper: should i move the ticket from trunk to formentry?
|
13:25:13
|
<jkeiper> dkayiwa, let's see if it is a trunk problem first :-D
|
13:25:26
|
<jkeiper> (it may already be fixed by proxy if the other ticket fixed the problem)
|
13:26:45
|
*** wyclif has joined #openmrs
|
13:32:11
|
<dkayiwa> jkeiper: being fixed by the other ticket would not surprise me. because this ticket just looks like a duplicate of the other :)
|
13:33:39
|
*** nribeka has joined #openmrs
|
13:33:39
|
*** ChanServ sets mode: +v nribeka
|
13:37:20
|
<dkayiwa> so jkeiper should i wait for you as for TRUNK-3143?
|
13:38:51
|
*** dawn_ has quit IRC
|
13:40:11
|
<dkayiwa> hi wyclif
|
13:40:23
|
<wyclif> hi dkayiwa
|
13:40:51
|
<dkayiwa> wyclif: did you see my comments for TRUNK-3232 ?
|
13:40:55
|
<dkayiwa> !ticket TRUNK-3232
|
13:40:58
|
<OpenMRSBot> dkayiwa: [#TRUNK-3232] Concept search should display the name containing all word tokens when multiple words are entered - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3232
|
13:44:14
|
*** dkayiwa has quit IRC
|
13:46:04
|
*** sgithens has joined #openmrs
|
13:50:07
|
<chopin_> noooooooooooo dkayiwa left!
|
13:50:13
|
<chopin_> it must be dawn
|
13:53:03
|
*** r_friedman has quit IRC
|
13:53:08
|
*** dawn_ has joined #openmrs
|
13:53:15
|
*** ChanServ sets mode: +v dawn_
|
13:53:36
|
*** dawn__ has joined #openmrs
|
13:53:36
|
*** ChanServ sets mode: +v dawn__
|
13:53:36
|
*** dawn_ has quit IRC
|
13:53:36
|
*** dawn__ is now known as dawn_
|
13:53:40
|
<wyclif> dki have commented, it needs a small fix
|
13:54:51
|
<chopin_> wyclif, he's gone
|
13:54:54
|
<chopin_> becase dawn arrived
|
13:55:14
|
<chopin_> s/dawn/dusk
|
13:55:15
|
<chopin_> :-D
|
13:56:14
|
<dawn_> chopin_: who left? daniel?
|
13:56:24
|
<wyclif> chopin_, i figured, thanks
|
13:56:33
|
<chopin_> dawn_, yes ...
|
13:56:34
|
<chopin_> :(
|
13:56:44
|
<dawn_> chopin_: did i scare him away? :D
|
13:56:57
|
<chopin_> it was minutes before you showed up
|
13:57:04
|
<chopin_> 3 to be exact
|
14:00:25
|
<dawn_> !scrumon dawn
|
14:00:25
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready.
|
14:00:29
|
<dawn_> Hi Team!
|
14:00:42
|
<dawn_> Today's Order: wyclif, rafa , jkeiper djazayeri
|
14:00:54
|
<rafa> hi!
|
14:01:17
|
<dawn_> :)
|
14:02:18
|
<wyclif> dawn_, me first again
|
14:02:31
|
<dawn_> wyclif: yes, please
|
14:02:49
|
<wyclif> thursday:
|
14:02:50
|
<wyclif> * design call
|
14:02:50
|
<wyclif> * TRUNK-3316 - Refactor the Order Class
|
14:02:50
|
<wyclif> * TRUNK-3317- Refactor the DrugOrder Class
|
14:02:50
|
<wyclif> * TRUNK-3315 - Add the TestOrder Class, database table and hibernate mappings
|
14:02:50
|
<wyclif> today:
|
14:02:52
|
<wyclif> * order entry tickets
|
14:02:54
|
<wyclif> Blockers: none
|
14:03:09
|
<rafa> Today:
|
14:03:09
|
<rafa> * Finished TRUNK-2193: Add Drug Ingredients to API
|
14:03:09
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-2193
|
14:03:09
|
<rafa> * Testing TRUNK-3296: Found multiple reference terms
|
14:03:09
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-3296
|
14:03:09
|
<rafa> Blockers: need a reply on TRUNK-3296 before I can commit
|
14:03:34
|
<djazayeri> wyclif: you did those tickets?
|
14:03:59
|
<wyclif> djazayeri, worked on them
|
14:04:10
|
<djazayeri> wyclif: i.e. please say: * (verb) (ticket #) - (ticket description)
|
14:04:44
|
<dawn_> jkeiper: you turn
|
14:04:51
|
<wyclif> djazayeri, i was working on TRUNK-3316 and noticed they i couldnt commit code for it without fixing the other 2 for the tests to pass
|
14:05:10
|
<chopin_> Yesterday:
|
14:05:10
|
<chopin_> * worked on TRUNK-3124 - initial structure in place
|
14:05:10
|
<chopin_> * lots of ticket discussion re: concept search
|
14:05:10
|
<chopin_> Today:
|
14:05:10
|
<chopin_> * commit patches from mvorobey
|
14:05:11
|
<chopin_> * write up additional ACM tickets
|
14:05:13
|
<chopin_> * finish TRUNK-3124
|
14:05:15
|
<chopin_> * clean up remaining drug sprint tickets
|
14:05:17
|
<chopin_> Blockers:
|
14:05:21
|
<chopin_> * none
|
14:05:48
|
<dawn_> chopin_: thank! sorry i forgot to add you in the queue
|
14:06:00
|
<chopin_> dawn_, i was listed
|
14:06:04
|
* chopin_ = jkeiper
|
14:06:12
|
<dawn_> (sigh)
|
14:06:18
|
<rafa> :)
|
14:06:21
|
<chopin_> apparently i have two instances running at the same time
|
14:06:21
|
<djazayeri> My report
|
14:06:22
|
* dawn_ needs a list of people's IRC names
|
14:06:30
|
<djazayeri> Thursday 3-May-2012
|
14:06:30
|
<djazayeri> * Dev call
|
14:06:30
|
<djazayeri> * Leadership call
|
14:06:30
|
<djazayeri> * Registered for OSCON
|
14:06:30
|
<djazayeri> * Work on ITECH project
|
14:06:31
|
<djazayeri> * Fixed UIFR-23 - Configure @Validate function to work properly with existing Openmrs validators
|
14:06:31
|
<djazayeri> * Wrote unit test for UIFR-28 - @BindParams should allow bindings to maps
|
14:06:32
|
<djazayeri> * Thought about UIFR-22 - Add the ability to specify a initialization method on @BindParams
|
14:06:32
|
<djazayeri> * Merged Mark's pull request for UIFR-29 SimpleObject.fromObject should not fail if parent node is null
|
14:06:33
|
<djazayeri> Friday 4-May-2012
|
14:06:34
|
<djazayeri> * Work on ITECH project
|
14:06:34
|
<djazayeri> * Hopefully release UI Framework 1.3, UI Library 1.1, App Framework 1.0
|
14:06:35
|
<djazayeri> no blockers
|
14:06:47
|
<chopin_> i registered for OSCON too
|
14:06:48
|
<chopin_> :-D
|
14:07:05
|
<chopin_> takes for freaking ever
|
14:07:47
|
<dawn_> Discussion Points: 1) chopin_ (Jer): estimated date for this sprint finishing 2) djazayeri : next weeks's sprint (which seems we really need ben for)
|
14:07:50
|
<dawn_> !scrumoff dawn
|
14:07:50
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
14:08:03
|
<dawn_> OSCON++
|
14:08:11
|
<djazayeri> discussion topics: rafa blocked on a ticket, chopin sprint status, sunbiz what's JSS's status with needed RESTWS 1.0 released, nribeka push to propose something to mseaton about the patient summary sprint
|
14:08:48
|
<dawn_> rafa: who do you need a comment from for the ticket?
|
14:08:49
|
<rafa> seems like we've got a strong representation for OSCON :D
|
14:08:55
|
<chopin_> i expect the sprint to be done today. there are two in "needs review" that just require committing or closing, and four "in progress", one that is mine, another that i will claim due to inactivity and is very simple to fix, then daniel's two remaining.
|
14:09:18
|
<rafa> from people here: djazayeri or wyclif :)
|
14:09:28
|
*** cpower has joined #openmrs
|
14:09:28
|
<djazayeri> is dkayiwa out for the day?
|
14:09:29
|
<sunbiz> djazayeri: sorry??
|
14:09:36
|
<chopin_> i think he is
|
14:09:37
|
<dawn_> chopin_: so it may be finished by sunday
|
14:09:53
|
<djazayeri> sunbiz: so, we haven't released RESTWS 1.0 yet, though the code is mostly/all committed.
|
14:09:58
|
<chopin_> dawn_, correct ... dkayiwa is probably not going to work on it until at least then
|
14:09:59
|
<dawn_> djazayeri: i think dkayiwa is out for the rest of the day and tomorrow
|
14:10:05
|
<dawn_> chopin_: k
|
14:10:28
|
<djazayeri> sunbiz: do you all need an official release? or do you want to test what's in trunk now and give more feedback before we declare it 1.0?
|
14:11:02
|
<djazayeri> rafa: there was a 'comment' column on concept_map?
|
14:11:05
|
<djazayeri> in the old model?
|
14:11:09
|
<rafa> djazayeri: yes
|
14:11:17
|
<djazayeri> rafa: I didn't know that. :-)
|
14:11:42
|
<rafa> djazayeri: and it seems to be used in MVP
|
14:11:49
|
<djazayeri> oh really?
|
14:12:13
|
<djazayeri> rafa: can you give an example of what the comments are like?
|
14:12:31
|
<djazayeri> e.g. do they really specify the map type? or are they generic comments?
|
14:13:01
|
<rafa> djazayeri: sure, I need a moment to start 1.10 again
|
14:13:14
|
<sunbiz> djazayeri: its working... and we are making new resources for what we need
|
14:13:19
|
*** Mkop has quit IRC
|
14:13:19
|
<djazayeri> rafa: I thought they weren't in 1.10
|
14:13:26
|
<sunbiz> looks like the bugs are ironed out
|
14:13:33
|
<sunbiz> although everyone wants more documentation
|
14:13:36
|
<djazayeri> sunbiz: okay, so as far as you're concerned, we can release the restws trunk as 1.0
|
14:13:38
|
<rafa> djazayeri: they were copied over to description on refernce terms
|
14:13:41
|
<sunbiz> or more understandable documentation
|
14:13:41
|
*** Mkop has joined #openmrs
|
14:13:41
|
*** ChanServ sets mode: +v Mkop
|
14:14:16
|
<djazayeri> sunbiz: specific requests, as tickets, e.g. "the documentation currently looks like X but should be changed to look like Y" are much more likely to get actioned. :-)
|
14:15:02
|
<sunbiz> I dont know... just new devs telling that its hard to understand
|
14:15:13
|
<sunbiz> djazayeri: I agree... dont know what it means though
|
14:17:51
|
<djazayeri> jkeiper: you expect to be able to release the module and declare the sprint complete ~ monday?
|
14:18:24
|
<djazayeri> dawn_: regarding next week's sprint, Ben said he has everything set up, so I'm trusting that.
|
14:18:26
|
<chopin_> depending on what dkayiwa things on his timeline ... perhaps i should say wednesday to be sure
|
14:18:41
|
<chopin_> s/thing/think
|
14:18:58
|
<rafa> djazayeri: the comments are like: Map Type: 2, Map Type: 24, etc.
|
14:19:01
|
<djazayeri> dawn_: there's a dashboard with 23 available tickets
|
14:19:24
|
*** nadee has joined #openmrs
|
14:19:35
|
<djazayeri> rafa: can you do a select/group by and see if there are some that occur very frequently?
|
14:19:38
|
*** dkayiwa has joined #openmrs
|
14:20:06
|
<djazayeri> and we can check the map types to see if those align to things like "same-as", "narrower-than", etc.
|
14:20:46
|
<rafa> mysql> select comment, count(*) from concept_map group by comment;
|
14:20:46
|
<rafa> +----------------------+----------+
|
14:20:46
|
<djazayeri> rafa: if that's the case, then we really ought to be using the comment to try to determine the map type, and then we can drop it.
|
14:20:46
|
<rafa>
|
14:20:46
|
<rafa> +----------------------+----------+
|
14:20:46
|
<rafa>
|
14:20:46
|
<rafa>
|
14:20:46
|
<rafa>
|
14:20:47
|
<rafa>
|
14:20:47
|
<rafa>
|
14:20:48
|
<rafa>
|
14:20:48
|
<rafa>
|
14:20:49
|
<rafa>
|
14:20:49
|
<rafa>
|
14:20:50
|
<rafa>
|
14:20:50
|
<rafa>
|
14:20:51
|
<rafa>
|
14:20:51
|
<rafa>
|
14:20:52
|
<rafa>
|
14:20:52
|
<rafa> +----------------------+----------+
|
14:20:53
|
<rafa> 14 rows in set (9.62 sec)
|
14:21:17
|
<dawn_> djazayeri: i'm not sure when ben returns this weekend, but could you send an email to the community about the sprint on his behalf?
|
14:21:27
|
<djazayeri> dawn_: sure
|
14:21:54
|
<djazayeri> rafa: I think we need to ask Andy about this.
|
14:22:29
|
<dawn_> djazayeri: thanks
|
14:22:58
|
*** rohitgoyal18 has joined #openmrs
|
14:23:26
|
<djazayeri> rafa: what are concept_map_types with id=1 and id=3?
|
14:24:10
|
<djazayeri> rafa: I would propose that we do something like:
|
14:24:55
|
<djazayeri> (1) if the comment matches "Map Type: (\d+)" then use that to determine the map type, and drop it
|
14:25:26
|
<djazayeri> (2) otherwise move the comment to concept_reference_term.description (even though it doesn't really belong there)
|
14:25:56
|
<djazayeri> (3) delete duplicate concept_reference_terms, though this means we may lose some concept_map.comment data
|
14:26:26
|
<djazayeri> rafa: but I'd say email that to the dev list, also including the group/count query from above, and asking whether people are okay with that.
|
14:28:06
|
<dkayiwa> hi wyclif
|
14:28:59
|
<djazayeri> dkayiwa, wyclif, are you clear on that concept name searching ticket?
|
14:29:10
|
<djazayeri> I saw a lot of comments on the ticket, but haven't been following.
|
14:29:10
|
<dkayiwa> djazayeri: not me
|
14:30:28
|
<djazayeri> dkayiwa: what ticket number?
|
14:30:42
|
<dkayiwa> !ticket TRUNK-3232
|
14:30:44
|
<OpenMRSBot> dkayiwa: [#TRUNK-3232] Concept search should display the name containing all word tokens when multiple words are entered - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3232
|
14:31:33
|
<rafa> djazayeri: can we determine (1) without a help from Andy?
|
14:32:12
|
<djazayeri> rafa: you can look in the concept_map_type table and see what types 1 and 3 are.
|
14:32:34
|
<djazayeri> rafa: and see if they're actually forward-looking comments, for the default concept map types in 1.9
|
14:32:55
|
<rafa> djazayeri: you mean concept_map_type in 1.9 right?
|
14:33:00
|
<djazayeri> rafa: yes
|
14:34:13
|
<djazayeri> dkayiwa, wyclif: there are lots of screenshots there and I don't know which one to look at
|
14:34:52
|
<nribeka> djazayeri, when is my time? :)
|
14:35:01
|
<djazayeri> nribeka: just talk!
|
14:35:02
|
<djazayeri> :-)
|
14:35:23
|
<nribeka> designing: patient summary, persisting parameters + data converter from the reporting
|
14:35:28
|
<djazayeri> nribeka: I was just reminding you that if you could send some patient summary design to mseaton (and other), it'd be good
|
14:35:58
|
<nribeka> i'm stuck at trying to decide how to persist the parameters + data converter djazayeri
|
14:35:58
|
<rafa> djazayeri: seems like all concept mappings are migrated as SAME-AS
|
14:36:18
|
<wyclif> djazayeri, neither do i
|
14:36:25
|
<nribeka> djazayeri, http://notes.openmrs.org/Patient-Summary-Design
|
14:36:51
|
<wyclif> djazayeri, ada needs to remove old ones whenever she is putting up new versiob
|
14:36:58
|
<rafa> mysql> select concept_map_type_id, count(*) from concept_reference_map group by concept_map_type_id;
|
14:36:59
|
<rafa> +---------------------+----------+
|
14:36:59
|
<rafa>
|
14:36:59
|
<rafa> +---------------------+----------+
|
14:36:59
|
<rafa>
|
14:36:59
|
<rafa> +---------------------+----------+
|
14:36:59
|
<rafa> 1 row in set (1.89 sec)
|
14:37:05
|
<djazayeri> wyclif: can you walk over and find ada, and have her describe to you?
|
14:37:13
|
<djazayeri> wyclif: I think she intentionally left most of them
|
14:37:45
|
<djazayeri> wyclif: but it would be great if you can have her describe exactly what she wants to see, and type that up as a comment, so dkayiwa knows what to do.
|
14:37:59
|
<wyclif> djazayeri, i recall keeping track of when she was adding them, for most she was putting up an new version
|
14:38:27
|
<djazayeri> rafa: I believe Andy said that migration should actually be done as NARROWER-THAN, not as SAME-AS.
|
14:38:29
|
<wyclif> djazayeri, i know what is saying and i have added a comment
|
14:38:46
|
<djazayeri> dkayiwa: does wyclif's comment clarify?
|
14:39:01
|
<dkayiwa> djazayeri: know, that is why i wanted us chat over it here
|
14:39:08
|
<dkayiwa> djazayeri: know = NO
|
14:39:22
|
<wyclif> rafa, you need to count distinct concept map types in the concept reference term table
|
14:39:23
|
<djazayeri> wyclif, dkayiwa: you two can discuss the ticket then. I will butt out.
|
14:39:36
|
<dkayiwa> djazayeri: because using ticket comments seems to be taking longer
|
14:39:38
|
<rafa> djazayeri: I'm not sure when I ran the update, but maybe it's fixed now
|
14:39:55
|
<wyclif> djazayeri, dkayiwa did you see my last comment
|
14:39:56
|
<djazayeri> rafa: two things: 1 is that we're supposed to be migrating as narrower-than, so yeah, if this is an old migration, that's fine
|
14:40:06
|
<wyclif> dkayiwa, did you see my last comment
|
14:40:13
|
<djazayeri> rafa: 2: there's a concept map type definition table in 1.9, right?
|
14:40:15
|
<dkayiwa> wyclif: yes i did and i wanted to start talking about it from chat (to be faster)
|
14:40:32
|
<djazayeri> rafa: it has 50-100 rows or so
|
14:40:35
|
<rafa> djazayeri: right
|
14:40:47
|
<djazayeri> rafa: what are 1 and 3 in that table?
|
14:40:52
|
<dkayiwa> so wyclif, is that simply removing the second test (&& !conceptName.isFullySpecifiedName())?
|
14:41:10
|
<wyclif> dkayiwa, what ada is saying and i said it too, when name that is not fully specified is marked as preferred is what it displayed, you need to point to the preferred
|
14:41:20
|
<wyclif> dkayiwa, so that if clause needs to be changed
|
14:41:22
|
<rafa> djazayeri: 1 is SAME-AS, 3 is BROADER-THAN
|
14:41:37
|
<dkayiwa> wyclif: changed to which one?
|
14:41:40
|
<rafa> djazayeri: 2 is NARROWER-THAN
|
14:41:59
|
<dkayiwa> wyclif: could you give me what the correct if clause should look like?
|
14:42:00
|
<wyclif> dkayiwa, the if clause i added to the last comment
|
14:42:37
|
<wyclif> dkayiwa, it might not be requiring a change to the if clause only, changing the clause might be one of the steps
|
14:43:00
|
<wyclif> dkayiwa, first of all, do you understand the behavior we want?
|
14:43:24
|
*** mandate has joined #openmrs
|
14:43:35
|
<dkayiwa> wyclif: yes
|
14:43:39
|
<djazayeri> rafa: so, I believe we can interpret those comments as being forward-looking to 1.9. (Since SAME-AS and BROADER-THAN are the most commonly specified, and Andy has said in the past that NARROWER-THAN should be the default)
|
14:43:45
|
<dkayiwa> wyclif: The arrow should point to the preferred Name if any exists, if not then it should point to the fully specified name
|
14:44:27
|
<djazayeri> rafa: so I think that what I proposed earlier is probably right, but I still think you should email the dev list to be sure people are okay with it.
|
14:44:39
|
<dkayiwa> wyclif: what confuses me is that, basing on that if test, the concept name is neither the preferred nor fully specified
|
14:44:41
|
<djazayeri> rafa: mostly people = Andy
|
14:44:58
|
<mandate> I have a problem with encounters the Two button Edit and View the View button is inactive. need your help
|
14:45:03
|
<dkayiwa> wyclif: so am wondering why i should change it
|
14:45:11
|
<rafa> djazayeri: okay
|
14:45:22
|
<wyclif> dkayiwa, wait to look at the code, first understand what the requirement is
|
14:45:31
|
<dkayiwa> wyclif: ok
|
14:45:36
|
<wyclif> dkayiwa, are you able to reproduce what we are saying
|
14:45:58
|
<wyclif> dkayiwa, it is very simple to reproduce
|
14:45:59
|
<djazayeri> nribeka: about persisting parametersâ¦do you want to talk by voice in a bit?
|
14:45:59
|
<dkayiwa> wyclif: running it again.....
|
14:46:06
|
<wyclif> go to sprint1.openmrs.org
|
14:46:08
|
<nribeka> sure darius
|
14:46:10
|
<nribeka> hold on
|
14:46:15
|
<wyclif> go to sprint1.openmrs.org:8080/openmrs
|
14:46:18
|
<djazayeri> nribeka: I have to chat with Mark first.
|
14:46:19
|
<nribeka> lemme go to the conference room next door
|
14:46:20
|
<chopin_> wyclif, is there any way you can mimic the error in a unit test?
|
14:46:28
|
<djazayeri> nribeka: give me 15 minutes
|
14:46:31
|
<nribeka> cool
|
14:46:42
|
<djazayeri> mandate: what openmrs version?
|
14:46:49
|
<djazayeri> mandate: what page?
|
14:46:58
|
<wyclif> chopin_, of course but got no time right now but it is very easy to reproduce
|
14:47:00
|
<djazayeri> mandate: any error message in the javascript log?
|
14:47:27
|
<wyclif> dkayiwa, go to http://sprint1.openmrs.org:8080/openmrs/dictionary/index.htm
|
14:47:29
|
<chopin_> wyclif, sounds like that is the right way for dkayiwa to start then
|
14:47:38
|
<dkayiwa> wyclif: whats the password?
|
14:48:17
|
<wyclif> go to http://sprint1.openmrs.org:8080/openmrs/dictionary/concept.form?conceptId=798
|
14:48:54
|
<nribeka> do you need burke too djazayeri? :P
|
14:49:41
|
<mandate> I'm implementing OpenMrs but have a Problem with patient encounter pages have Edit and View the View button is inactive yet i need to use it need ur support please
|
14:49:48
|
<wyclif> you notice SALBUTAMOL is the fully specified name and VENTOLIN is the preferred name, so what we want is that when i search for SALBUTAMOL, i should see SALBUTAMOL -> VENTOLIN since VENTOLIN is the preferred name
|
14:50:05
|
<wyclif> dkayiwa, you notice SALBUTAMOL is the fully specified name and VENTOLIN is the preferred name, so what we want is that when i search for SALBUTAMOL, i should see SALBUTAMOL -> VENTOLIN since VENTOLIN is the preferred name
|
14:51:06
|
*** mallan has joined #openmrs
|
14:52:16
|
<dkayiwa> wyclif: after setting up as you said, on my trunk, when i search for SALBUTAMOL, i get: SALBUTAMOL INHALER â VENTOLIN
|
14:52:58
|
<dkayiwa> so wyclif are we sure that server is running the trunk code?
|
14:53:05
|
<wyclif> dkayiwa, i dont know what your demo data is, but try it out on sprint1
|
14:53:33
|
<dkayiwa> wyclif: yes i tried it out on sprint1 and it shows as you say (the false result)
|
14:53:38
|
<wyclif> dkayiwa, the problem is with your demo data
|
14:53:41
|
<wyclif> test data
|
14:54:03
|
<wyclif> dkayiwa, it is running Build 27215 which is after your commit
|
14:54:24
|
<wyclif> dkayiwa, anyways you need to fix that because i can reproduce it on my trunk too
|
14:55:07
|
<dkayiwa> wyclif: let me try a fresh install and see
|
14:55:38
|
<wyclif> dkayiwa, and yes that if clause is likely to be the culprit thought the fix might another line of code
|
14:55:56
|
<wyclif> dkayiwa, it is yourdev data that is a problem
|
14:56:24
|
<dkayiwa> wyclif: ok, let me try create brand new demo data based on a trunk war file
|
14:56:28
|
*** sunbiz has quit IRC
|
14:56:47
|
<wyclif> dkayiwa, you need to make sure that concept is set up like the one on sprint1 and save the concept to rebuild that concept's index
|
14:56:59
|
*** mallan has quit IRC
|
14:57:01
|
*** mallan_ has joined #openmrs
|
14:57:16
|
<wyclif> dkayiwa, you probably dont need to refresh demo data
|
14:57:18
|
<mallan_> I'm implementing OpenMrs but have a Problem with patient encounter pages have Edit and View the View button is inactive yet i need to use it need ur support please
|
14:57:22
|
<dkayiwa> wyclif: yes i ensure so on my trunk and failed to reproduce the problem.
|
14:57:26
|
<wyclif> dkayiwa, just save the concept and have ventolin as preferred
|
14:57:51
|
<wyclif> dkayiwa, did you commit and code in relation to that ticket?
|
14:58:07
|
<dkayiwa> wyclif: yes i committed it on the ticket
|
14:58:20
|
<wyclif> let me update
|
14:58:48
|
<djazayeri> mallan_: what OpenMRS version? what page? what kind of forms? is there an error message?
|
14:59:19
|
<dkayiwa> wyclif: then i recreated what is exactly on the sprint1, but do not get what is on sprint1
|
15:00:05
|
<wyclif> dkayiwa, hold on
|
15:00:18
|
<dkayiwa> wyclif: ok
|
15:00:37
|
<djazayeri> nribeka: hi
|
15:00:46
|
<nribeka> yes djazayeri
|
15:00:48
|
<djazayeri> nribeka: I don't think we need burke, but depends on what your question is
|
15:00:59
|
<nribeka> i was just kidding
|
15:01:07
|
<djazayeri> nribeka: skype? adobe connect?
|
15:01:20
|
<djazayeri> nribeka: google talk + etherpad?
|
15:02:52
|
*** dawn_ has quit IRC
|
15:02:52
|
<wyclif> dkayiwa, what is your preferred name and what is your fully spec name?
|
15:03:05
|
<wyclif> dkayiwa, and what do you enter and what do you get?
|
15:03:07
|
<dkayiwa> wyclif: can i send you my screenshot?
|
15:03:27
|
<mallan_> hi
|
15:03:37
|
<dkayiwa> wyclif: my fully specified is: SALBUTAMOL
|
15:03:41
|
<mallan_> <@djazayeri> hi
|
15:03:46
|
<wyclif> dkayiwa, hold on
|
15:03:51
|
<dkayiwa> wyclif: my preffered is: VENTOLIN
|
15:04:15
|
<wyclif> ok
|
15:04:17
|
<djazayeri> mallan_: I'm on a call now, but ask (and say my name)
|
15:04:18
|
<dkayiwa> wyclif: the rest are synonyms with preferred not ticked
|
15:06:05
|
*** nribeka has quit IRC
|
15:07:18
|
<wyclif> and what results do you get?
|
15:07:42
|
<wyclif> dkayiwa, i have just done an svn update, mvn clean install and i can still reproduce it in trunk
|
15:08:00
|
<dkayiwa> wyclif: in that case let me do a fresh install
|
15:08:17
|
<wyclif> dkayiwa, i still dont think that is necessary
|
15:08:29
|
<wyclif> have you tried to save that concept
|
15:08:30
|
<dkayiwa> wyclif: so what do you think i should do?
|
15:08:53
|
<wyclif> dkayiwa, you didnt tell me what you entered and what the results are
|
15:08:53
|
<mallan_> ok <@djazayeri> the patient encounter has edit and view buttons forediting and deleting an encounter page for my case the view button is inactive can you help
|
15:09:16
|
*** nadee has quit IRC
|
15:09:35
|
<dkayiwa> wyclif: i have just saved with fully specified as SALBUTAMOL
|
15:09:43
|
*** lh has joined #openmrs
|
15:10:04
|
<dkayiwa> wyclif: and preferred is VENTOLIN
|
15:10:15
|
<wyclif> dkayiwa, you didnt tell me what you entered and what the results are
|
15:10:28
|
<wyclif> dkayiwa, when you search
|
15:10:39
|
<dkayiwa> wyclif: i search using: SALBUTAMOL
|
15:10:53
|
<dkayiwa> wyclif: and i get: SALBUTAMOL INHALER â VENTOLIN
|
15:11:25
|
<wyclif> dkayiwa, that is strange
|
15:11:33
|
<wyclif> i get SALBUTAMOL
|
15:11:59
|
<dkayiwa> wyclif: do you have any other suggestion for me apart from doing a fresh install?
|
15:12:08
|
<wyclif> dkayiwa, not any more
|
15:12:13
|
<dkayiwa> wyclif: ok
|
15:12:35
|
<dkayiwa> wyclif: by the way, what is scrum time today?
|
15:13:45
|
<wyclif> dkayiwa, ended
|
15:13:51
|
<mandate> <@djazayeri> runing version 1.6.3
|
15:14:00
|
<dkayiwa> wyclif: ohhhh. was i offline???
|
15:14:09
|
<wyclif> dkayiwa, same time as usual besides thursday
|
15:14:17
|
<dkayiwa> wyclif: ohhhhhhhh
|
15:14:20
|
<wyclif> you went offline just before it started
|
15:14:51
|
<djazayeri> mandate: mallan_: What kind of form? XForms, HTML Form, Infopath?
|
15:16:33
|
<djazayeri> mandate: mallan_: on the list encounters tab on the patient dashboard? or after you clicked on a particular encounter?
|
15:16:58
|
<mandate> on the list encounters
|
15:17:18
|
<mandate> tab
|
15:17:38
|
*** mallan_ has quit IRC
|
15:18:35
|
*** rafa has quit IRC
|
15:18:39
|
<djazayeri> mandate: similar to this?
|
15:18:40
|
<djazayeri> https://tickets.openmrs.org/browse/TRUNK-1981
|
15:18:49
|
<mandate> whenever i click on the View button it does not open
|
15:19:44
|
*** nribeka has joined #openmrs
|
15:19:44
|
*** ChanServ sets mode: +v nribeka
|
15:20:19
|
<djazayeri> mandate: what form entry technology? xforms, html form, infopath?
|
15:20:43
|
<mandate> html form
|
15:21:10
|
<djazayeri> mandate: is it the same error mentioned in TRUNK-1981 or https://tickets.openmrs.org/browse/TRUNK-2221 ?
|
15:21:29
|
<mandate> let me view it.
|
15:24:11
|
<mandate> it's simillar to this but my edit button works it's the view button which is inactive
|
15:28:23
|
<wyclif> djazayeri, have you ever run into a situation where writing an HQL query doesn't work when you use a simple name like Order but works if you use the fully qualified name
|
15:28:29
|
*** suranga has joined #openmrs
|
15:28:29
|
*** ChanServ sets mode: +v suranga
|
15:30:19
|
<djazayeri> wyclif: not that I recall
|
15:32:35
|
<wyclif> djazayeri, and it works if use a criteria object
|
15:32:50
|
<wyclif> djazayeri, must be something wrong am doing
|
15:38:49
|
*** dkayiwa has quit IRC
|
15:41:25
|
*** harshadura has quit IRC
|
15:50:12
|
*** dawn_ has joined #openmrs
|
15:50:12
|
*** ChanServ sets mode: +v dawn_
|
16:08:57
|
*** dawn_ has quit IRC
|
16:09:25
|
*** summon has joined #openmrs
|
16:12:23
|
*** summon has left #openmrs
|
16:27:22
|
<djazayeri> mandate: assuming you're using firefox or chrome, can you use firebug or chrome's inspect element to see if there are any error messages in the javascript console, or if the icon has or does not have a link attached to it?
|
16:29:00
|
*** mandate has quit IRC
|
16:30:09
|
*** nribeka has quit IRC
|
17:06:24
|
*** nribeka has joined #openmrs
|
17:06:24
|
*** ChanServ sets mode: +v nribeka
|
17:10:46
|
*** rohitgoyal18 has quit IRC
|
17:18:10
|
*** mvorobey has joined #openmrs
|
17:18:18
|
<mvorobey> hi all
|
17:33:51
|
<cpower> hello
|
17:33:57
|
*** robbyoconnor has joined #openmrs
|
17:33:57
|
*** ChanServ sets mode: +v robbyoconnor
|
17:34:49
|
*** r0bby has joined #openmrs
|
17:34:49
|
*** ChanServ sets mode: +v r0bby
|
17:36:34
|
*** r0bby_ has joined #openmrs
|
17:36:34
|
*** ChanServ sets mode: +v r0bby_
|
17:37:49
|
*** r0bby_ has quit IRC
|
17:38:20
|
*** rohitgoyal18 has joined #openmrs
|
17:38:23
|
<mvorobey> cpower, it seems that I missed todays scrum :(
|
17:39:22
|
*** robbyoconnor has quit IRC
|
17:40:40
|
*** r0bby has quit IRC
|
17:47:07
|
*** lh has quit IRC
|
18:05:08
|
*** lh has joined #openmrs
|
18:05:08
|
*** lh has joined #openmrs
|
18:16:23
|
*** rafa has joined #openmrs
|
18:16:23
|
*** ChanServ sets mode: +v rafa
|
18:16:36
|
<cpower> Yep, that was around 10ish EST today
|
18:17:20
|
<cpower> Don't feel bad, I showed up for the discussion afterward instead of the actual scrum.
|
18:31:49
|
<djazayeri> mvorobey, cpower: every day except for Thursday it's at the same time. 7am pacific. :-)
|
18:34:28
|
<mvorobey> djazayeri, cpower: yep, a bit pity, actually I was trying to buy notebook today,so I missed scrum, and unfortunately did not buy notebook at all
|
18:34:52
|
<mvorobey> djazayeri, cpower : twice pity :(
|
18:35:33
|
*** suranga has quit IRC
|
18:51:31
|
*** mvorobey has quit IRC
|
18:57:55
|
*** rafa has quit IRC
|
19:00:15
|
*** rafa has joined #openmrs
|
19:00:15
|
*** ChanServ sets mode: +v rafa
|
19:01:45
|
*** james_regen has quit IRC
|
19:03:20
|
<wyclif> djazayeri, i figure out the problem after reading the hibernate docs, o wonde why daniel had set auto-impot to false on the hibernate-mapping tag because that means you use fully qualified javaclass name in HQL
|
20:15:42
|
*** nribeka has quit IRC
|
20:23:34
|
<finbrein> djazayeri: HTML Form Entry module. There is a copy on Git and another one in SVN. Are they the same?
|
20:24:19
|
<djazayeri> finbrein: the git one is active
|
20:24:31
|
<finbrein> ok.thanks.
|
20:28:01
|
*** jkeiper has quit IRC
|
20:28:01
|
*** chopin_ has quit IRC
|
20:43:34
|
*** djazayeri has quit IRC
|
20:48:30
|
*** sgithens has quit IRC
|
21:08:50
|
*** nribeka has joined #openmrs
|
21:08:50
|
*** ChanServ sets mode: +v nribeka
|
21:10:13
|
*** bryq has quit IRC
|
21:33:33
|
*** rafa has quit IRC
|
21:51:43
|
*** wyclif has quit IRC
|
21:56:07
|
*** lh has quit IRC
|
23:07:45
|
*** rohitgoyal18 has quit IRC
|