IRC Chat : 2012-05-03 - OpenMRS

01:38:00 <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Congrats to #OpenMRS community members Judy Gichoya & Sarah Bird, recipients of the Anita Borg Memorial Scholarship - http://t.co/VL3RZ8VR <http://twitter.com/OpenMRS/statuses/197856331057733633>
01:59:24 *** jkeiper has joined #openmrs
02:17:40 *** carloshpf has quit IRC
02:41:35 *** r6friedman has joined #openmrs
02:41:48 *** r6friedman is now known as r_friedman
02:42:02 <r_friedman> jkeiper: jeremy, are you really there?
02:43:02 <r_friedman> djazayeri: darius, got a minute?
02:45:10 <r_friedman> fuggedaboudid, tomorrow's another day
02:45:18 *** r_friedman has quit IRC
03:00:28 <jkeiper> oops
03:15:00 *** upul` has joined #openmrs
03:15:00 *** ChanServ sets mode: +v upul`
03:15:52 *** jkeiper has quit IRC
03:19:12 *** wyclif has quit IRC
03:38:40 *** sandeep has joined #openmrs
03:39:06 *** sandeep is now known as Guest39973
03:39:35 *** finbrein has quit IRC
03:40:06 *** Guest39973 has quit IRC
06:52:25 *** bryq has joined #openmrs
06:52:25 *** ChanServ sets mode: +v bryq
06:57:16 *** dkayiwa has joined #openmrs
07:22:08 *** bryq has quit IRC
07:26:40 *** dkayiwa has quit IRC
08:30:27 *** dkayiwa has joined #openmrs
08:50:54 *** bryq has joined #openmrs
08:50:54 *** ChanServ sets mode: +v bryq
09:29:38 *** dkayiwa has quit IRC
10:13:55 *** pascal` has joined #openmrs
10:13:55 *** ChanServ sets mode: +v pascal`
10:13:58 <pascal`> Hi
10:14:14 <pascal`> djazayeri, do you know why when I try and run a report it just queues it and it doesn't actually run?
10:14:24 <pascal`> djazayeri, or do you know how I can get the report in the queue to run?
10:15:46 <pascal`> Anyone? :/
10:20:28 *** dkayiwa has joined #openmrs
10:34:18 *** dkayiwa has quit IRC
10:55:41 *** dkayiwa has joined #openmrs
11:00:23 *** james_regen has joined #openmrs
11:00:23 *** ChanServ sets mode: +v james_regen
11:17:05 *** dkayiwa_ has joined #openmrs
11:18:07 *** dkayiwa has quit IRC
11:18:08 *** dkayiwa_ is now known as dkayiwa
11:25:46 *** jkeiper has joined #openmrs
11:26:01 *** upul` has quit IRC
11:42:42 *** jkeiper has quit IRC
11:42:50 *** jkeiper has joined #openmrs
11:45:03 *** jkeiper has quit IRC
11:51:29 *** dkayiwa has quit IRC
11:56:46 *** dmexs has joined #openmrs
11:58:18 *** dmexs has joined #openmrs
12:01:13 *** tobn_g has joined #openmrs
12:17:14 *** bryq has quit IRC
12:21:25 *** bryq has joined #openmrs
12:21:25 *** ChanServ sets mode: +v bryq
12:26:30 *** dkayiwa has joined #openmrs
12:29:37 *** pascal` has quit IRC
12:35:47 *** tuxilina has joined #openmrs
12:56:19 *** finbrein has joined #openmrs
12:58:34 *** carloshpf has joined #openmrs
13:00:39 *** sgithens has joined #openmrs
13:01:12 *** carloshpf has quit IRC
13:02:04 *** pascal`` has joined #openmrs
13:02:08 <pascal``> Hi
13:02:47 *** mvorobey has joined #openmrs
13:03:02 <mvorobey> hi all
13:33:22 *** cpower has quit IRC
13:34:35 *** downey has joined #openmrs
13:34:35 *** ChanServ sets mode: +o downey
13:34:35 *** OpenMRSBot sets mode: +o downey
13:52:54 *** isharapremadasa has joined #openmrs
13:53:50 *** isharapremadasa is now known as isharap
13:56:47 *** tuxilina has left #openmrs
14:00:39 <downey> hi all, we will be a bit late starting the developers forum
14:01:30 *** sgithens has quit IRC
14:04:52 <djazayeri> pascal``: check the logs to make sure the spring-managed timer task is working
14:05:04 <djazayeri> pascal``: maybe you need to set GPs for scheduler.username and scheduler.password
14:10:47 *** sgithens has joined #openmrs
14:24:36 *** downey_ has joined #openmrs
14:24:36 *** ChanServ sets mode: +o downey_
14:25:00 *** downey has quit IRC
14:25:00 *** downey_ is now known as downey
14:27:17 *** isharap has quit IRC
14:29:33 <pascal``> djazayeri, thanks.
14:30:31 <pascal``> djazayeri, is there anything special that needs to be done to get a module to put links on the admin page in 1.9.
14:30:47 <pascal``> djazayeri, the code in the repo for the basic module looks right, but no links are showing up :(
14:31:43 *** bryq has quit IRC
14:32:22 *** Christian_MSF has joined #openmrs
14:32:35 <downey> Hi Christian_MSF and welcome to the #openmrs IRC channel.
14:33:14 <pascal``> djazayeri, the problem is actually happening on Christian_MSF's setup.
14:34:22 *** mseaton has joined #openmrs
14:34:22 *** ChanServ sets mode: +v mseaton
14:35:17 *** dkayiwa_ has joined #openmrs
14:36:34 *** dkayiwa has quit IRC
14:36:35 *** dkayiwa_ is now known as dkayiwa
14:41:40 <pascal``> maybe you know dkayiwa
14:41:56 <pascal``> Did something change with the admin links extension point in 1.9?
14:42:10 <pascal``> The basic module code in the repo looks right, but I don't see any links :/
14:42:27 <dkayiwa> pascal``: not so sure but i remember having touched something like extension points
14:42:37 <dkayiwa> pascal``: is that 1.9 RC3?
14:47:10 <pascal``> dkayiwa, yeah
14:47:31 *** snoppy has joined #openmrs
14:47:40 <pascal``> dkayiwa, the basic module code in the repo looks good? and its always worked before? but now I see no links :(
14:47:57 <pascal``> dkayiwa, if I enter the URL directly it does work - so the module is correctly loaded - just no admin links.
14:48:14 <dkayiwa> pascal``: could be a bug we introduced in 1.9 :(
15:04:41 *** dkayiwa has quit IRC
15:06:46 <djazayeri> pascal``: for the extension point, you have both the java class, and the snippet in config.xml?
15:22:20 <mvorobey> djazayeri, hi :)
15:22:30 <djazayeri> hi mvorobey
15:22:49 <mvorobey> djazayeri, I have one question on TRUNK-2525
15:22:52 <mvorobey> https://tickets.openmrs.org/browse/TRUNK-2525
15:23:11 <djazayeri> mvorobey: yes?
15:24:32 <mvorobey> djazayeri, as I uderstood from a long discussion we need to show not-editable drug formulations on concept view page and add a link to manage them; that link should point to old Manage Drug Concept page (this should be renamed). Am I understanding it right ?
15:25:55 <djazayeri> mvorobey: Correct. Basically for TRUNK-2525, we want to do what's in the top-left of the mockup.
15:26:53 <mvorobey> djazayeri, a-ha, ok, thamnks
15:26:55 <djazayeri> mvorobey: one point: Jeremy wants to implement this in a module, so that people can use it with OpenMRS < 1.10.
15:27:09 <djazayeri> mvorobey: and I don't know if he's publicized where this is yet.
15:27:30 <mvorobey> djazayeri, so we need to wait for jkeiper and ask him
15:27:34 <djazayeri> mvorobey: I think, though, that you can implement this ticket as a patch against trunk, and Jeremy can move it to where he wants it in the module.
15:27:59 <mvorobey> djazayeri, seems cool for me, thanks
15:28:13 <djazayeri> Alternately: look at the view concept page and see if there is already an extension point suitable for putting the Drug Formulations
15:28:31 *** tobn_g has quit IRC
15:28:42 <mvorobey> and ? add module there ?
15:28:51 *** tobn_g has joined #openmrs
15:29:04 <djazayeri> mvorobey: well, just look at the page and see if there is any extension point that will work for our purposes.
15:29:18 <mvorobey> djazayeri, ok, give me a sec
15:29:29 <mvorobey> or minute, :)
15:31:20 *** sgithens has quit IRC
15:31:23 <djazayeri> mvorobey: I just posted a comment on the ticket, that some work from that mockup is actually part of a different ticket.
15:32:33 <mvorobey> djazayeri, ok, actually, I found two extension points within conceptForm.jsp file
15:34:54 <djazayeri> mvorobey: is that the view page or the edit page?
15:35:56 <djazayeri> mvorobey: I think you want concept.jsp
15:36:14 <mvorobey> djazayeri, considering with Manage Concepts privilege required on that page I can say that it's for editing
15:37:38 <mvorobey> djazayeri, as for concept.jsp - this has two extension points also: one is called conceptHeader, and anotyher one is conceptFooter
15:38:00 <mvorobey> anotyher = another
15:38:48 <deadpool> djazayeri: i am trying to report the bugs but for the project there is no database backup module listed
15:38:51 <deadpool> what should i do?
15:39:06 <djazayeri> deadpool: are you on the dev or impl mailing list?
15:39:22 <deadpool> yeah i am
15:40:26 <mvorobey> djazayeri: so we can use conceptFooter extension for our purposes, do not we ? or just create another one?
15:40:27 <djazayeri> deadpool: email one of them
15:40:59 <djazayeri> mvorobey: I suspect that conceptFooter is lower than we'd ideally want (i.e. I bet it's below the pointless wikipedia/dictionary.com/etc links)
15:41:06 <djazayeri> mvorobey: but I guess it's good enough for now.
15:41:34 <mvorobey> djazayeri, yes, you are right, it's a bit below those links :)
15:41:39 <djazayeri> mvorobey: how about just making the change against trunk for you, and doing a patch that way
15:42:08 <mvorobey> djazayeri, sounds godd for me
15:42:16 <mvorobey> godd = good
15:42:28 <djazayeri> mvorobey: and comment on the ticket telling Jeremy you're doing it that wya.
15:42:39 *** pascal`` has quit IRC
15:43:06 <mvorobey> djazayeri, ok, wil go ahead commenting that, thanks
15:43:13 <mvorobey> wil = will
15:44:01 <deadpool> djazayeri: should i email implementers and dev or just the dev group
15:45:38 <djazayeri> deadpool: you can either email implementers and ask if anyone is successfully using it, or else dev to ask if anyone is maintaining it
15:45:52 <deadpool> djazayeri: will do thanks
15:48:09 *** pascal`` has joined #openmrs
15:49:09 <mvorobey> djazayeri, just commented on that ticket
16:02:38 *** lh has joined #openmrs
16:02:38 *** lh has joined #openmrs
16:34:44 <tobn_g> Anybody have any idea what Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:2.4:unpack-dependencies (Expand moduleApplicationContext and messages) on project oldpatientdata-omod: Error unpacking file: /Users/tobingreensweig/oldpatientdata/api/target/classes to: /Users/tobingreensweig/oldpatientdata/omod/target/classes means when I try to compile a module?
16:35:35 <tobn_g> i'm running mvn clean compile from the folder where my module is on my computer…this has worked previously and I don't think anything has changed in the code since last compile
16:38:15 *** lh has quit IRC
16:40:46 *** pascal`` has quit IRC
16:42:07 *** pascal`` has joined #openmrs
16:52:22 *** suranga has joined #openmrs
16:52:22 *** ChanServ sets mode: +v suranga
17:00:59 *** lh has joined #openmrs
17:10:01 *** tuxilina has joined #openmrs
17:10:06 <downey> Hi tuxilina and welcome to the #openmrs IRC channel.
17:15:11 <tuxilina> hello
17:18:55 *** lh has quit IRC
17:19:13 *** lh has joined #openmrs
17:22:42 *** sgithens has joined #openmrs
17:24:30 *** pascal`` has quit IRC
17:25:55 *** pascal`` has joined #openmrs
17:26:46 *** chopin has joined #openmrs
17:28:52 *** chopin is now known as jkeiper
17:28:58 *** ChanServ sets mode: +v jkeiper
17:29:02 <jkeiper> heyyyyy
17:29:13 <mvorobey> jkeiper, hi :)
17:30:18 <jkeiper> hi mvorobey :-) just back to my desk
17:30:25 <jkeiper> going to review things shortly
17:31:31 <mvorobey> jkeiper, you are welcome :) we was so waiting for you :D
17:31:45 <jkeiper> mvorobey, i bought a house today :-D
17:32:08 <mvorobey> jkeiper, pleace, accept my congratulations !
17:32:12 <mvorobey> :)
17:32:25 <mvorobey> pleace= please
17:32:34 <jkeiper> mvorobey, thanks :-D now that it's over, I can focus!
17:32:52 <mvorobey> :-)
17:40:19 *** r0friedman has joined #openmrs
17:40:28 *** r0friedman is now known as r_friedman
17:40:39 <r_friedman> djazayeri: hey darius, got a minute?
17:41:10 <djazayeri> r_friedman: what's up?
17:41:33 <r_friedman> on 9/21/11, you did an omrsu presentation on how to debug modules
17:41:47 <r_friedman> there's no sign of a recording of that, can you put your hands on it?
17:44:01 *** summon has joined #openmrs
17:44:05 <djazayeri> r_friedman: let me look
17:44:11 <downey> Hi summon and welcome to the #openmrs IRC channel.
17:45:16 <r_friedman> !beerme summon
17:45:16 * OpenMRSBot slides summon a pint
17:45:37 <djazayeri> r_friedman: http://connect.iu.edu/p2fwpznmxrp/
17:45:43 <r_friedman> cool, tks
17:45:53 <djazayeri> r_friedman: if that's the right one, could you please update the University wiki page with the link?
17:46:10 <r_friedman> ok will do
17:48:56 *** dkayiwa has joined #openmrs
17:52:32 *** tuxilina has quit IRC
17:54:36 *** nribeka has joined #openmrs
17:54:36 *** ChanServ sets mode: +v nribeka
17:58:23 *** sgithens has quit IRC
17:58:39 *** sgithens has joined #openmrs
18:05:16 *** lh has quit IRC
18:11:26 <jkeiper> mvorobey, just commented on TRUNK-2525 ... would be great to see a screenshot of your changes :-)
18:12:05 <mvorobey> jkeiper, can you please ait for 15 minutes ?
18:12:09 <mvorobey> wait
18:13:14 <jkeiper> mvorobey, haha you can have more time than that
18:13:21 <jkeiper> mvorobey, just letting you know the update
18:13:47 <mvorobey> jkeiper, I just have to slow PC at home and going to renew it tomorrow
18:13:53 <mvorobey> to = too
18:14:03 <mvorobey> too slow
18:15:55 <jkeiper> ah, no worries here
18:15:59 <jkeiper> you're doing great ;-)
18:27:23 <mvorobey> jkeiper, done, please, see the ticket in jira here https://tickets.openmrs.org/browse/TRUNK-2525
18:27:38 <jkeiper> mvorobey, thanks
18:33:07 *** rafa has joined #openmrs
18:33:10 *** ChanServ sets mode: +v rafa
18:36:47 *** rohitgoyal18 has joined #openmrs
18:42:16 *** dkayiwa has quit IRC
18:43:48 <tobn_g> r_friedman: time for a quick question?
18:44:16 <r_friedman> sure if it's quick
18:45:08 <tobn_g> r_friedman: i think so. in the module i was talking about on openmrsu the other day i'm trying to define a string that is /some/path/here/ID NUMBER
18:45:19 <r_friedman> ok
18:45:30 <tobn_g> r_friedman: in one part of my jsp I was able to use ${model.patient.activeIdentifiers[0]}
18:45:40 <r_friedman> ok
18:45:41 <tobn_g> r_friedman: because that was just generating HTML
18:45:58 <tobn_g> but I have a java part contained in %% and am not sure what to put
18:46:11 <tobn_g> r_friedman: ie not sure how to end the line String filepath = "/media/Cirrus/refugee_www/" +
18:47:05 <r_friedman> so you want % in the filename, is that the problem?
18:47:23 <tobn_g> no, sorry. I was just saying that I have actual java code within the jsp
18:47:50 <tobn_g> to do that you have to put the java in between two % signs
18:48:01 <tobn_g> actually <% %>
18:48:23 *** r9friedman has joined #openmrs
18:48:28 *** r9friedman is now known as r__friedman
18:48:49 <r__friedman> tobn_g: sorry got disconnected
18:48:57 <tobn_g> r__friedman:
18:49:01 <tobn_g> r__friedman: no problem
18:49:11 *** Christian_MSF has quit IRC
18:49:11 <tobn_g> r__friedman was just saying the question is: what do I need to put at the end of the statement "String filepath = "/media/www/" + " such that the end string is the full path
18:49:26 <r__friedman> tobn_g: so I'm still not sure what the problem is
18:49:34 <tobn_g> r__friedman: by full path I meant the patient's ID number
18:49:48 <tobn_g> r__friedman: sorry it's getting late here!
18:50:20 <r__friedman> oh, ok, you want to concatnate the patient id that you're getting from the context or velocity
18:50:35 <tobn_g> correct
18:51:15 <tobn_g> later in the same JSP I generate a link that has the ID and use ${model.patient.activeIdentifiers[0]} to get that. But within the proper java code I'm not sure what to put
18:51:16 *** r_friedman has quit IRC
18:52:36 *** dawn_ has joined #openmrs
18:52:40 *** ChanServ sets mode: +v dawn_
18:52:55 <r__friedman> tobn_g: my expert here say it should be string filename = "blah blah" + ${model....};
18:54:02 <tobn_g> r__friedman: tried that but let me give it a second go just to make sure there wasn't some little syntax mistake. i'll let you know
18:54:03 <r__friedman> he is not quite sure, might not need ${}, just the inside part
18:54:15 <tobn_g> r__friedman: tried that too :-\
18:54:21 *** r__friedman is now known as r_friedman
18:54:51 <r_friedman> tobn_g: might want to ask a better developer like d jazayeri, m seaton, or r afa
18:55:02 <r_friedman> or j keiper
18:55:27 <tobn_g> ok thanks r_friedman i'll tinker and if not bug one of those guys :-)
18:55:35 <mvorobey> tobn_g, have a look at http://www.avajava.com/tutorials/lessons/how-do-i-access-a-jstl-variable-in-a-scriptlet.html
18:55:40 <OpenMRSBot> <http://ln-s.net/$8JQ> (at www.avajava.com)
18:55:53 <r_friedman> tks mvorobey
18:56:00 <tobn_g> thank you mvorobey
18:56:06 <r_friedman> save my motley butt
18:56:17 <mvorobey> r_friedman, tobn_g do not mention it
19:00:23 <dawn_> !scrumon dawn
19:00:23 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready.
19:00:26 <dawn_> Hi Team!
19:00:57 <dawn_> Today's Order: rafa , mvorobey , jkeiper , djazayeri
19:00:59 <mvorobey> dawn_, hi
19:01:00 <jkeiper> hi
19:01:18 <rafa> hi
19:01:26 <rafa> I had a day off :)
19:01:30 <rafa> No blockers.
19:01:45 <mvorobey> * Prepared for review TRUNK-2525 - https://tickets.openmrs.org/browse/TRUNK-2525
19:01:48 <djazayeri> rafa: ah, that's why you haven't replied to my MDS & OpenMRS 1.9 question yet. :-)
19:01:50 <mvorobey> * Attended the dev call, where gave updates on Atlas 1.1 releasing
19:01:52 <mvorobey> No blockers
19:02:32 <rafa> djazayeri: yeah, I wanted to investigate a bit before replying
19:02:39 <dawn_> jkeiper: you turn :)
19:03:15 <jkeiper> Yesterday:
19:03:15 <jkeiper> * approved several tickets
19:03:15 <jkeiper> * finalized design tickets with Darius et al
19:03:15 <jkeiper> * claimed, tagged and mavenized conceptmanagement module
19:03:15 <jkeiper> * continued work on TRUNK-3124
19:03:16 <jkeiper> * lots of ticket discussion re: concept search
19:03:18 <jkeiper> Today:
19:03:20 <jkeiper> * review additional completed tickets in drug sprint
19:03:22 <jkeiper> * keep working on TRUNK-3124
19:03:24 <jkeiper> Blockers:
19:03:28 <jkeiper> * time
19:03:47 <dawn_> :D
19:03:50 <djazayeri> rafa: personally I'd prefer a less-correct reply sooner, and a more correct followup if necessary :-)
19:03:55 <dawn_> djazayeri: your turn
19:04:07 <djazayeri> jkeiper: mvorobey may need guidance about TRUNK-2525 and whether he should rework it into that module
19:04:15 <djazayeri> if you're certain about the module
19:04:20 <jkeiper> djazayeri, yep
19:04:30 <jkeiper> and yes, the module is good
19:04:41 <djazayeri> Wednesday 2-May-2012
19:04:41 <djazayeri> * University call
19:04:41 <djazayeri> * Design call
19:04:41 <djazayeri> * More UI Framework and ITECH work
19:04:41 <djazayeri> * Fixed UIFR-34 - Exceptions on UI Framework pages are not displayed in the browser
19:04:41 <djazayeri> * Implemented "popupForm" widget
19:04:42 <djazayeri> * Improvements to "java.util.Date field" widget
19:04:42 <djazayeri> * Bugfixes to "form" widget to support command objects with hidden fields
19:04:42 <djazayeri> * added "pageLink" javascript function
19:04:44 <djazayeri> * Work on ITECH project
19:04:45 <djazayeri> Thursday 3-May-2012
19:04:45 <djazayeri> * Dev call
19:04:45 <djazayeri> * Leadership call
19:04:46 <djazayeri> * Work on ITECH project
19:04:57 <djazayeri> * do code reviews for Drug UI if jkeiper asks me to
19:04:59 <djazayeri> no blockers
19:05:19 <djazayeri> * merged Mark's pull request for UIFR-29
19:05:56 <dawn_> !scrumoff dawn
19:05:56 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
19:06:00 <dawn_> Discussion points?
19:06:09 <jkeiper> time
19:06:14 <jkeiper> how to make it last longer
19:06:17 * dawn_ needs to connect with daniel to get ETA for 1.9
19:06:40 <djazayeri> jkeiper: sprint status: besides time, what do we need more of? (alternately, whose time do we need more of?)
19:07:26 <jkeiper> honestly, we're moving along quickly. the only ticket with no action is formentry-related
19:07:44 <dawn_> jkeiper: when do you feel all the tickets will be complete
19:07:49 <jkeiper> need to know what to do for TRUNK-2193 (rafal's ticket)
19:08:09 <djazayeri> !ticket trunk-2193
19:08:10 <OpenMRSBot> djazayeri: [#TRUNK-2193] Add Drug Ingredients to API - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2193
19:08:15 <jkeiper> dawn_, all but one should be complete by tomorrow i think, assuming dkayiwa and rafa are not busy tomorrow
19:08:19 <jkeiper> with other things
19:08:55 *** sgithens has quit IRC
19:09:01 <djazayeri> jkeiper: Personally I'm fine if we just let drug_ingredient happen in trunk, i.e. 1.10
19:09:10 <djazayeri> jkeiper: and we need a ticket for its UI :-)
19:09:41 <jkeiper> djazayeri, that's what i was thinking ... so no need to make the UI ticket part of the conceptmanagement module?
19:09:45 <djazayeri> jkeiper: but perhaps you should talk to Ada/Lauren/AMPATH and make sure they'll be okay with just the changes that _will_ be able to go in the module
19:09:46 <jkeiper> just a trunk UI ticket?
19:09:55 <jkeiper> ok
19:09:56 <djazayeri> jkeiper: yeah, just a trunk ticket
19:09:59 <jkeiper> will do
19:10:09 *** dmexs has quit IRC
19:10:19 <jkeiper> the module tickets will come later if needed
19:10:25 <jkeiper> to match trunk's
19:10:34 <djazayeri> jkeiper: I mean, the reason we're doing this sprint now in particular is because AMPATH is asking for it. So as to whether drug ingredients should get dealt with in the module, or just in trunk, you have the authority to decide.
19:10:42 <jkeiper> waiting on downey for ITSM-2449 before i can make those tickets
19:11:00 <downey> !ticket ITSM-2449
19:11:01 <OpenMRSBot> downey: [#ITSM-2449] New Project for Advanced Concept Management Module - OpenMRS JIRA - https://tickets.openmrs.org/browse/ITSM-2449
19:11:07 <jkeiper> djazayeri, ah ... understood. worst case, we replicate trunk's drug_ingredient table in the module and provide a migration mechanism later
19:11:09 <downey> Status: Closed
19:11:45 <jkeiper> downey, oookay. so recent that the drug sprint dashboard didn't recognize it
19:12:06 <jkeiper> you have now contributed 20% to the drug sprint
19:12:08 <jkeiper> :_)
19:12:17 *** dmexs has joined #openmrs
19:14:18 <djazayeri> jkeiper: so, you're feeling pretty confident that the module can be ready-to-release by the end of tomorrow? (+/- testing)
19:14:39 <djazayeri> dkayiwa has two in-progress tickets
19:15:07 <djazayeri> rafa has none. (I don't know if he has time or not.)
19:16:40 *** dawn_ has quit IRC
19:18:06 *** wyclif has joined #openmrs
19:18:24 *** dawn_ has joined #openmrs
19:18:24 *** ChanServ sets mode: +v dawn_
19:19:44 *** dawn_ has quit IRC
19:24:12 <mvorobey> jkeiper, djazayeri: am ready to be informed how to rework my patch on TRUNK-2525 for concept management module
19:26:59 <jkeiper> djazayeri, what's your take on using Vector() vs ArrayList() or HashSet()?
19:27:16 <jkeiper> isn't Vector deprecated?
19:27:51 <djazayeri> jkeiper: Vector is thread-safe, ArrayList is not. ArrayList performs slightly better.
19:28:02 <djazayeri> jkeiper: I always use ArrayList (unless I'm doing something threaded)
19:28:10 <jkeiper> djazayeri, Vector isn't deprecated?
19:28:30 <jkeiper> controllers are instantiated, right?
19:28:43 <jkeiper> or are they essentially singletons?
19:29:07 <djazayeri> jkeiper: controllers are singletons.
19:29:30 <djazayeri> jkeiper: you shouldn't be storing state in your controllers...
19:30:12 <djazayeri> jkeiper: I don't think Vector is @deprecated, but its use is generally not preferred.
19:30:19 *** rafa has quit IRC
19:30:24 <jkeiper> ConceptFormController contains a class (ConceptFormBackingObject) ... just wondering if threadedness is a concern there
19:30:44 <jkeiper> i'll suggest Vector -> ArrayList
19:30:58 <djazayeri> jkeiper: yes. Vector -> ArrayList
19:31:24 <djazayeri> jkeiper: if it's a per-request or per-session instance (usually the case with a form backing object) threading is not an issue
19:31:34 <jkeiper> mmkay thanks
19:31:51 <djazayeri> jkeiper: it's fine to define a class within your controller, but you shouldn't have an instance variable
19:31:57 *** rafa has joined #openmrs
19:31:57 *** ChanServ sets mode: +v rafa
19:32:23 <tobn_g> mvorobey: i'm having a lot of trouble getting the jstl variable to behave with my scriptlet, do you have any experience with that or just grabbed the link?
19:32:48 <mvorobey> tobn_g, yes, I had
19:33:01 <mvorobey> tobn_g, what is the problem ?
19:33:30 <tobn_g> mvorobey: the variable i'm working with is ${model.patient.activeIdentifiers[0]}
19:33:48 <mvorobey> tobn_g, ok
19:34:11 <tobn_g> mvorobey: so I tried to do String mystring = (String)pageContext.getAttribute("model.patient.activeIdentifiers[0]");
19:34:15 *** dkayiwa has joined #openmrs
19:34:16 <djazayeri> tobn_g: although it's generally bad style to use scriptlets, sometimes you have to. In that case it's be <%= ((CastToSomething) pageContext.get("model")).getPatient().getActiveIdentifiers().get(0) %>
19:35:18 <djazayeri> tobn_g: "model" is in the pageContext. you need to get that, and then call methods on it. it gets ugly, because you have to cast.
19:35:29 <mvorobey> tobn_g, you can not get element by key model.patient.activeIdentifiers[0] from page context because it actually does not exists in context
19:35:56 <tobn_g> djazayeri and mvorobey ok that makes sense thank you
19:36:13 <djazayeri> tobn_g: alternately: String mystring = (String) org.apache.commons.beanutils.PropertyUtils.getProperty(pageContext.get("model"), "patient.activeIdentifiers[0]")
19:36:23 <mvorobey> tobn_g, you are welcome
19:37:35 <tobn_g> djazayeri: that seems a bit cleaner. what would be your suggestion instead of this little 3line scriptlet that uses java.io to check for directory and if not creates it?
19:37:40 <mvorobey> djazayeri, I think it also not cute to write such things, it would be better first to cretate vaiable in page context using jsp syntax and then obtain that variable in scriplet in mentioned manner
19:37:50 <tobn_g> djazayeri (and it actually does work btw)
19:38:20 <djazayeri> tobn_g: why are you creating the directory in a jsp page instead of the controller. That's the real problem. :-)
19:38:37 <tobn_g> djazayeri: because i'm a n00b
19:38:49 <djazayeri> tobn_g: is this a portlet?
19:39:23 <tobn_g> djazayeri: yes. the idea being that when the page loads and before the php script in an iframe serves up all the directory browsing stuff, it checks if the proper folder exists and if not makes it
19:40:07 <djazayeri> tobn_g: you should write a controller for your portlet, and create the folder there.
19:40:10 <mvorobey> tobn, so you need to write next <c:setvar="superPath"value="model.patient.activeIdentifiers[0]"/> and then obtain that variable in scriptlet as followings: <% String myPath = (String) pageContext.getAttribute("superPath")%>
19:40:24 <mvorobey> tobn_g, so you need to write next <c:setvar="superPath"value="model.patient.activeIdentifiers[0]"/> and then obtain that variable in scriptlet as followings: <% String myPath = (String) pageContext.getAttribute("superPath")%>
19:40:53 <mvorobey> sorry, the value should be "${"model.patient.activeIdentifiers[0]}"
19:41:37 <tobn_g> djazayeri: ok will give it a try
19:41:48 <djazayeri> I like mvorobey's suggestion for how to make the jsp code less ugly though. :-)
19:41:49 <mvorobey> "${model.patient.activeIdentifiers[0]}", but anyway djazayeri is 101 % right
19:41:51 <tobn_g> mvorobey: are the quotations correct onte last one?
19:42:11 <tobn_g> mvorobey: ok that makes sense
19:42:19 <mvorobey> yep,
19:44:02 <mvorobey> :)
19:44:04 <tobn_g> mvorobey: probably should have learned java before trying to create this module!
19:45:25 <mvorobey> tobn_g, do not mind, you know java, JSP is from another world, I think it was made outside Solar system :)
19:46:40 <tobn_g> mvorobey: by the way "org.openmrs.PatientIdentifier cannot be cast to java.lang.String"
19:46:52 <tobn_g> mvorobey: maybe i will have to go with d jaz's method?
19:47:44 <mvorobey> tobn_g, you need to get name of that identifier before you assigning it to page context variable
19:48:25 <mvorobey> tobn_g, e.g. model.patient.activeIdentifiers[0].name
19:48:30 <mvorobey> or something
19:49:09 <mvorobey> because, model.patient.activeIdentifiers[0] itself returns instance of org.openmrs.PatientIdentifier class
19:50:30 <tobn_g> ah ok
19:52:04 <mvorobey> tobn_g, use model.patient.activeIdentifiers[0].identifier, it should work
19:52:47 <tobn_g> mvorobey: ok
19:53:58 <tobn_g> mvorobey: like a charm :-) can't thank you enough
19:54:17 <mvorobey> jkeiper, you are welcome :)
19:54:33 <mvorobey> tobn_g, you are welcome :)
19:56:07 <mvorobey> jkeiper, sorry, I missed addressee :) anyway, saw your comments on review for TRUNK-2525, will fix them tomorrow, is there anything that you'd like to discuss with me on that ticket ?
19:56:18 <jkeiper> mvorobey, no problem
19:56:23 <jkeiper> mvorobey, nope looks good otherwise!
19:56:41 <jkeiper> mvorobey, when finished perhaps replace your screenshot with the updated one
19:56:52 <mvorobey> jkeiper, but how about porting that module
19:57:31 <mvorobey> to module, sorry
19:57:54 <jkeiper> mvorobey, i am working on the "Manage Drugs" UI portion of that ticket ... so no worries at this time
19:58:26 <mvorobey> jkeiper, ok, so I gonna fix comments and recreate patch
19:58:36 <jkeiper> mvorobey, sounds good to me
20:02:59 *** suranga has quit IRC
20:04:19 <mvorobey> jkeiper, as for adding concept id to URL, can you tell me if the next template is right for this : href="${pageContext.request.contextPath}/admin/concepts/conceptDrug.list?conceptId=${command.concept.conceptId}" ?
20:05:02 <jkeiper> mvorobey, yes ... should not affect the current list page but will take effect with coming improvements
20:05:28 <mvorobey> jkeiper, ok, will test it
20:08:00 *** lh has joined #openmrs
20:08:16 *** lh has joined #openmrs
20:08:47 <jkeiper> mvorobey, thanks!
20:09:10 <mvorobey> jkeiper, you are welcome :D
20:16:41 *** dmexs has quit IRC
20:23:32 <mvorobey> jkeiper, one moment that I would love to reveal, do we really want to show retired drug formulations ?
20:32:15 <mvorobey> jkeiper, am asking this because currently the method ConceptService.getDrugsByConcept(Concept) does not include retired ones
20:34:47 <jkeiper> mvorobey, possibly not ... typically in those situations we have a "toggle retired" link.
20:35:26 <jkeiper> mvorobey, perhaps you can filter to ignore retired and allow the conceptDrug.list page deal with retired
20:36:53 <mvorobey> jkeiper, ok, so I will ignore retired ones and remove the styling handler for them on JSP, are you okay with that ?
20:37:08 <jkeiper> mvorobey, works for me!
20:37:11 <jkeiper> i've got to go
20:37:13 <jkeiper> cya
20:37:27 <mvorobey> jkeiper, bye, have a nice eve :)
20:37:36 <jkeiper> thanks :-D
20:37:47 *** dkayiwa has quit IRC
20:38:37 *** bryq has joined #openmrs
20:38:37 *** ChanServ sets mode: +v bryq
20:38:54 *** downey has quit IRC
20:40:55 *** mvorobey has quit IRC
20:41:42 *** jkeiper has quit IRC
20:47:21 *** rafa has quit IRC
20:52:01 *** rohitgoyal18 has quit IRC
20:56:27 *** bryq has quit IRC
21:02:19 *** jriley has joined #openmrs
21:05:02 <jriley> wyclif, djazayeri, installing 1.9.0 RC_3 seems to have worked. The queries I tried before that took 2-4 minutes took 20-40 seconds (and were returning 200 out of 600 and 1200 matches respectively, which is reasonable
21:05:27 *** jriley has quit IRC
21:05:28 <djazayeri> good!
21:05:33 <wyclif> jriley, cool, thanks for testing
21:05:52 *** nribeka has quit IRC
21:07:15 <wyclif> djazayeri, does she meant it takes 20-40 seconds for the first page to get displayed?
21:07:31 <djazayeri> sounds like it, which still seems very long to me
21:07:35 <wyclif> djazayeri, i f yes, i think that the networking being slow
21:07:46 <wyclif> djazayeri, not the query
21:08:55 <wyclif> djazayeri, when i search on demo.openmrs.org, i know that i get back the first page in no time and i get back all the thousands in less than 10sec
21:12:36 *** bryq has joined #openmrs
21:12:36 *** ChanServ sets mode: +v bryq
21:24:50 *** snoppy has left #openmrs
21:30:39 *** summon has left #openmrs
21:32:16 *** mseaton has quit IRC
21:37:49 *** deadpool has quit IRC
21:40:38 *** djazayeri has quit IRC
21:41:15 *** djazayeri has joined #openmrs
21:41:15 *** ChanServ sets mode: +o djazayeri
21:41:24 *** bryq has quit IRC
21:44:44 *** wyclif has quit IRC
21:53:16 *** dmexs has joined #openmrs
22:25:39 <finbrein> Hi djazayeri:
22:25:50 <djazayeri> hi finbrein
22:25:56 <finbrein> djazayeri: on this page, https://wiki.openmrs.org/display/docs/Building+Reports+%28Step+By+Step+Guide%29#BuildingReports%28StepByStepGuide%29-Step1.%26nbsp%3BBuildCohorts
22:26:25 <finbrein> djazayeri: #8 on the table
22:27:38 <finbrein> djazayeri: the FIXED value=MAIN ACTIVITY is throwing cannot be empty or null exception upon saving the form
22:27:57 <finbrein> djazayeri: pls advise
22:28:29 <djazayeri> finbrein: you set 4 fixed values? (which, question, comparison, values)
22:29:56 <finbrein> djazayeri: i was just following the instruction on that page. Could you provide an example?
22:30:13 <djazayeri> finbrein: I'm looking at the screenshot
22:30:29 <djazayeri> it shows fixed value 4 times, with Last, Main Activity, In, Farmer
22:30:34 <djazayeri> did you set all 4 of those?
22:30:54 <finbrein> djazayeri: yes i did
22:31:20 <djazayeri> finbrein: stack trace?
22:31:35 <djazayeri> finbrein: are you using the latest version of reporting?
22:31:47 <finbrein> djazayeri: 0.7.1
22:32:32 <finbrein> djazayeri: there is no stack trace. I just couldn't save the information. I have been debugging for a while.
22:32:53 <djazayeri> finbrein: is there a stack trace on the server log?
22:33:24 <finbrein> djazayeri: there should be something, i'll check and get back to you
22:48:11 *** robbyoconnor has quit IRC
22:54:54 <finbrein> djazayeri: http://pastebin.com/jWHf2qpH
22:55:19 <finbrein> djazayeri: i added the log to that page
22:56:09 <djazayeri> finbrein: that doesn't seem like a relevant error
22:56:52 <finbrein> djazayeri: the error message is simply "Cannot be empy or null"
22:56:53 <djazayeri> (that stacktrace is because you don't have the formentry module running but there's a scheduled task that tries to run one of its tasks)
22:58:33 <djazayeri> finbrein: does what you're entering look exactly like the screenshot on the wiki page you pointed me to?
22:58:42 <finbrein> djazayeri: true that the HTML form entry module is not installed and running. Usually, reporting module ask for HTML Widget and Serialization.Xstream modules. I'll add this Form Entry Module and try again
22:58:56 <djazayeri> finbrein: no need
22:58:58 <finbrein> djazayeri: exactly the same
22:59:04 <finbrein> djazayeri: ok
22:59:05 <djazayeri> (i.e. name, which, question, comparison, and values)
22:59:47 <djazayeri> finbrein: can you take a screenshot and send to me?
23:00:02 <djazayeri> finbrein: or share your screen on adobe connect (if you're on windows or mac)
23:00:39 <finbrein> djazayeri: ok i can share my screen, just a moment
23:00:58 <djazayeri> finbrein: http://connect.iu.edu/omrsdf
23:04:31 *** wyclif has joined #openmrs
23:06:22 <djazayeri> finbrein: hey
23:06:28 <djazayeri> I believe I know the problem
23:06:42 <djazayeri> finbrein: you're using the demo dictionary, right?
23:06:57 <finbrein> djazayeri: true
23:07:05 <djazayeri> finbrein: the screenshots there show an example done against a different concept dictionary
23:07:38 <djazayeri> finbrein: what's happening is that you haven't actually found and chosen a concept. (the widget has poor UI and doesn't actually show thi.)
23:07:50 <djazayeri> try something like "clinic travel"
23:08:00 <djazayeri> there's a concept for that.
23:08:46 <djazayeri> finbrein: that's what you're supposed to be doing, actually.
23:09:12 <djazayeri> so, basically you need to find an example concept to use in the demo dictionary instead
23:09:49 <djazayeri> in real life someone who's actually building reports for an implementation knows the dictionary pretty well
23:09:59 <djazayeri> finbrein: answer that with "less than 30 minutes" for eaxmple
23:13:07 <finbrein> djazayeri: it is ok now. The concept must exist and i cannot enter a value in the "Observations with this question"
23:13:28 <finbrein> djazayeri: what if it is a parameter and not a Fixed value
23:14:03 <djazayeri> finbrein: if you create a cohort query with parameters, then wherever you _use_ those cohort queries you need to specify (or map) the parameter values
23:14:25 <finbrein> djazayeri: By the way, i don't have to send the screenshot
23:14:35 <djazayeri> finbrein: correct
23:14:57 <djazayeri> finbrein: btw, you can stop screen sharing
23:16:05 <finbrein> djazayeri: ok, thanks