IRC Chat : 2012-05-02 - OpenMRS

00:30:42 *** deadpool has joined #openmrs
00:59:19 *** jkeiper has joined #openmrs
01:13:40 <deadpool> djazayeri: can i ask you a database question?
02:32:15 *** jkeiper has quit IRC
03:04:28 <djazayeri> deadpool: hi
03:29:12 *** upul` has joined #openmrs
03:29:13 *** ChanServ sets mode: +v upul`
03:37:36 *** maro has quit IRC
04:25:46 *** rohitgoyal18 has joined #openmrs
06:07:18 *** bryq has joined #openmrs
06:07:18 *** ChanServ sets mode: +v bryq
06:11:43 *** bryq has quit IRC
06:45:42 *** robbyoconnor has joined #openmrs
06:45:42 *** ChanServ sets mode: +v robbyoconnor
07:30:13 *** dkayiwa has joined #openmrs
07:31:16 *** rafa_ has joined #openmrs
07:31:16 *** ChanServ sets mode: +v rafa_
08:08:07 *** dkayiwa has quit IRC
08:43:15 *** dkayiwa has joined #openmrs
09:48:03 *** bryq has joined #openmrs
09:48:06 *** ChanServ sets mode: +v bryq
09:55:47 *** pascal` has joined #openmrs
09:55:47 *** ChanServ sets mode: +v pascal`
09:55:53 <pascal`> Hi
10:07:40 <pascal`> Anyone have any idea how to get the locked logic module to start?
10:13:50 *** rohitgoyal18 has quit IRC
10:19:44 *** jwild has joined #openmrs
10:24:07 <jwild> Hi rafa_
10:24:19 <rafa_> hi jwild
10:24:25 *** rafa_ is now known as rafa
10:25:33 <jwild> rafa: question about DataTables, started implementing, not sure if I missed something or it is interacting badly with tabs.
10:26:38 <jwild> rafa: changes are in 27190
10:27:13 <rafa> jwild: I'm updating...
10:27:23 <jwild> rafa: cool, thanks
10:27:45 *** rohitgoyal18 has joined #openmrs
10:32:15 <rafa> jwild: you need to add thead to the table with proper columns
10:32:48 <jwild> rafa: ok, and then it will construct tbody?
10:33:05 <rafa> jwild: it should
10:39:15 <jwild> rafa: thanks, that got things started, now debugging JSON malformed. the processing code given doesn't seem to have config for table, just database
10:40:20 <jwild> rafa: scratch that
10:40:49 <rafa> jwild: make sure # of columns returned matches declared in your thead
10:45:51 <jwild> rafa: yes they are, (had to cut dl link for now, is not a db column)
10:49:57 *** rohitgoyal18 has quit IRC
10:56:24 <pascal`> Hi dkayiwa
10:56:28 <pascal`> You around?
10:56:46 <dkayiwa> hi pascal`
10:58:28 <pascal`> dkayiwa, when I click on "Design XForm" from the form page, I'm getting served up and XML document to download, and I'm not taken to the XForm designer.
10:58:34 <pascal`> dkayiwa, have you ever seen this before?
10:58:55 <dkayiwa> pascal`: yes. which version of tomcat are you using?
10:59:29 <pascal`> dkayiwa, it looks like tomcat 6.
10:59:43 <pascal`> dkayiwa, previously tomcat 7 I think, but I think the person reverted back to tomcat 7.
10:59:45 <pascal`> *6
10:59:54 <dkayiwa> pascal`: and which version of java?
11:00:09 *** christian_msf has joined #openmrs
11:00:28 <pascal`> dkayiwa, This problem is actually on christian_msf's system.
11:00:50 <dkayiwa> pascal`: ok
11:01:00 <pascal`> dkayiwa, it might be 1.7
11:01:18 <pascal`> dkayiwa, yeah, 1.7.
11:01:23 <dkayiwa> pascal`: i remember it was reported on versions of java greater than 1.6
11:01:33 <christian_msf> It's 1.7.0_03-b05
11:01:34 <dkayiwa> pascal`: so it makes alot of sense when you say 1.7
11:02:52 <pascal`> dkayiwa, I've asked christian_msf to install 1.6 and check.
11:03:16 <dkayiwa> pascal`: ok
11:26:11 *** upul` has quit IRC
11:31:41 *** jwild has quit IRC
11:34:31 *** rubailly has joined #openmrs
11:36:35 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Metadata Sharing 1.0.7 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=metadatasharing&ampversion=&amp1.0.7>
11:37:06 *** jwild has joined #openmrs
11:42:54 *** james_regen has joined #openmrs
11:43:11 *** ChanServ sets mode: +v james_regen
11:52:20 *** jkeiper has joined #openmrs
12:13:54 *** harshadura has joined #openmrs
12:20:01 *** rubailly has quit IRC
12:37:12 *** ChanServ sets mode: +v jkeiper
12:40:06 *** rohitgoyal18 has joined #openmrs
12:53:45 *** downey has joined #openmrs
12:53:45 *** ChanServ sets mode: +o downey
12:53:45 *** OpenMRSBot sets mode: +o downey
13:00:35 *** jriley has joined #openmrs
13:02:40 *** christian_msf has quit IRC
13:04:09 *** rohitgoyal18 has quit IRC
13:08:33 *** sgithens__ has joined #openmrs
13:08:41 <downey> Hi sgithens__ and welcome to the #openmrs IRC channel.
13:09:29 <sgithens__> good grief, I've had enough random clients open to move up to double underscore sgithens
13:10:48 *** harshadura has quit IRC
13:11:56 <downey> yikes__
13:18:42 *** rubailly has joined #openmrs
13:24:04 *** leonjeru has joined #openmrs
13:25:53 *** bryq has quit IRC
13:27:05 <jkeiper> dkayiwa, how far back does openmrs_tag go?
13:27:54 <dkayiwa> jkeiper: no so sure, but i think 1.8
13:28:13 <jkeiper> ok cool ... i did not know about it :-D
13:28:31 <dkayiwa> jkeiper: hahahah :D chopin :)
13:36:17 *** lh has joined #openmrs
13:38:46 *** leonjeru has quit IRC
13:40:01 *** rubailly has quit IRC
13:40:09 *** wyclif has joined #openmrs
13:48:22 *** jwild has quit IRC
13:57:39 <wyclif> hi dkayiwa
13:57:49 <dkayiwa> hi wyclif
13:58:44 <wyclif> dkayiwa, do you know the prelease version we fixed the problem on the find/create patient page
13:58:55 <wyclif> dkayiwa, when searching for patients
13:58:59 <dkayiwa> wyclif: should be RC3
13:59:18 <wyclif> dkayiwa, but the bug was there in RC2
13:59:28 <dkayiwa> wyclif: yes
13:59:58 <wyclif> hi djazayeri which version was janet testing?
14:00:04 <wyclif> djazayeri, lara, janet?
14:00:22 <djazayeri> 1.9 RC2
14:01:14 *** bryq has joined #openmrs
14:01:14 *** ChanServ sets mode: +v bryq
14:02:18 *** cpower has quit IRC
14:02:22 <wyclif> djazayeri, there was a bug in RC2 on the find patient page from what i know
14:02:28 *** cpower has joined #openmrs
14:02:32 <jriley> sorry,looking at dev call
14:02:42 <wyclif> djazayeri, who was testing?
14:02:51 <djazayeri> it was jriley
14:03:04 *** snoppy has joined #openmrs
14:03:12 <wyclif> jriley, from what i know there was a bug on that find patient page
14:03:29 <jriley> let me catch up...
14:03:39 <wyclif> djazayeri, jriley and that is why i asked her to test on the other manage patient page
14:03:41 *** djazayeri has left #openmrs
14:03:54 *** djazayeri has joined #openmrs
14:03:54 *** ChanServ sets mode: +o djazayeri
14:03:57 <jriley> Ok. I'll upgrade to RC3 and see what happens
14:04:09 <wyclif> jriley, if you use firefox with firebug, you might notice a javascript error on that page
14:04:18 <cpower> Is my schedule off or should we be having the daily scrum now?
14:04:43 <djazayeri> !scrumon djazayeri
14:04:43 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster djazayeri- you may begin when ready.
14:05:02 *** tobn_g has joined #openmrs
14:05:13 <tobn_g> hi jriley
14:05:15 <downey> Hi tobn_g and welcome to the #openmrs IRC channel.
14:05:27 <djazayeri> today's order: wyclif, rafa, dkayiwa, jkeiper, cpower, djazayeri
14:05:32 <djazayeri> anyone I missed?
14:05:36 <rafa> hi
14:06:17 <wyclif> Monday:
14:06:17 <wyclif> * Had to redo merging of trunk changes to order entry branch(painful)
14:06:17 <wyclif> * Order entry design with burke about the OrderTypeHandlers
14:06:17 <wyclif> * Create tickets for Supporting OrderTypeHandlers and OrderNumber algorithms
14:06:17 <wyclif> Tuesday:
14:06:18 <wyclif> * Removing Order groups and Ordersets from order entry branch
14:06:20 <wyclif> * Refactoring existing Order entry code to conform to the new design
14:06:22 <wyclif> * Order-3304 - Add Orderable interface and SimpleOrderable as an implementation
14:06:24 <wyclif> Today:
14:06:26 <wyclif> * Order entry tickets
14:06:46 <wyclif> no blocckers
14:07:01 <rafa> Today:
14:07:01 <rafa> * Setup the release plugin for MDS and released 1.0.7 to our repo
14:07:01 <rafa> * Committed TRUNK-2193: Add Drug Ingredients to API
14:07:01 <rafa> https://tickets.openmrs.org/browse/TRUNK-2193
14:07:01 <rafa> * Broke trunk CI build, but not sure yet why :/
14:07:02 <rafa> No blockers.
14:07:16 <dkayiwa> Committed: Add option to unmap dosage form and route on Concept Drug edit page - TRUNK-3273
14:07:16 <dkayiwa> Committed: Add global properties to limit concepts shown in drug route and dosage form selection to specific concept sets - TRUNK-3247
14:07:17 <dkayiwa> Now working on: Concept search should display the name containing all word tokens when multiple words are entered - TRUNK-3232
14:07:17 <dkayiwa> No Blockers
14:07:35 <jkeiper> Yesterday:
14:07:35 <jkeiper> * committed and closed TRUNK-3300
14:07:35 <jkeiper> * reviewed TRUNK-3273 (dkayiwa) - waiting on backport
14:07:35 <jkeiper> * reviewed TRUNK-3247 (dkayiwa) - waiting on backport
14:07:35 <jkeiper> * reviewed TRUNK-3245 (mvorobey) - minor change needed
14:07:36 <jkeiper> * summarized comments on TRUNK-2525
14:07:38 <jkeiper> * began work on TRUNK-3124
14:07:40 <jkeiper> Today:
14:07:42 <jkeiper> * submit TRUNK-3124 mock-ups to implementers list
14:07:44 <jkeiper> * discuss TRUNK-3125 in OpenMRS design review
14:07:46 <jkeiper> * review additional completed tickets in drug sprint
14:07:48 <jkeiper> Blockers:
14:07:52 <jkeiper> * verification of "way forward" on TRUNK-2525
14:08:24 <djazayeri> cpower: any report from your end?
14:10:32 <djazayeri> I guess not
14:11:03 <djazayeri> my report
14:11:03 <djazayeri> Tuesday 1-May-2012
14:11:04 <djazayeri> * fixed UIFR-32 - Move form widget to uilibrary module
14:11:04 <djazayeri> * fixed UIFR-31 - Parameters with a default value should not fail for being required
14:11:04 <djazayeri> * fixed UIFR-30 - Fragment views do not have the right classloader
14:11:04 <djazayeri> * fixed UIFR-27 - @RequestParams does not appear to properly bind Collections
14:11:04 <djazayeri> * Work on ITECH UI
14:11:05 <djazayeri> Wednesday 2-May-2012
14:11:06 <djazayeri> * University call
14:11:06 <djazayeri> * Design call
14:11:07 <djazayeri> * More UI Framework and ITECH work
14:11:10 <djazayeri> no blockers
14:11:36 <djazayeri> Discussion points:
14:11:44 <djazayeri> 1. "way forward on TRUNK-2525"
14:11:58 <djazayeri> 2. jkeiper to give an update on overall sprint status/progress
14:12:01 <djazayeri> !scrumoff
14:12:01 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
14:12:29 <jkeiper> drug sprint took a hit with May Day
14:12:30 *** finbrein has joined #openmrs
14:12:47 <djazayeri> wyclif: also, before you make significant changes to order & orderservice in trunk, please send an email to the dev list saying what you're about to do
14:12:57 <djazayeri> (not everyone necessarily is following the tickets)
14:13:31 <wyclif> djazayeri, am making changes to the things only that not controversial
14:13:32 *** finbrein has quit IRC
14:13:32 <jkeiper> once drug table and formulary design are complete, we will have about half of the total sprint-related tickets available for work
14:13:55 <jkeiper> wyclif, or so you think ;-)
14:14:20 <djazayeri> wyclif: also, we should have a public discussion about what to do about deprecating/removing
14:14:47 <djazayeri> jkeiper: so do you think we need more resources to get the sprint finished?
14:14:52 <pascal`> Hi
14:15:01 <wyclif> djazayeri, see TRUNK-3318
14:15:10 <djazayeri> !ticket trunk-3318
14:15:11 <OpenMRSBot> djazayeri: [#TRUNK-3318] Deprecate OrderService, OrderType and ORDER_STATUS - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-3318
14:15:12 <wyclif> djazayeri, committed some code
14:15:15 <pascal`> Anyone have a second to help me get the basic module up and running on the current trunk build?
14:15:49 <djazayeri> wyclif: I'm saying please send an email to the dev list to let people know about these changes (and give them a chance to complain, as we tend to do…)
14:16:05 *** Alexis_MSF has joined #openmrs
14:16:07 <djazayeri> wyclif: design discussions and updates should happen on the dev list, not just in tickets.
14:16:07 <jkeiper> djazayeri, after the design call we will know more :-/
14:16:12 <downey> Hi Alexis_MSF and welcome to the #openmrs IRC channel.
14:16:23 <djazayeri> jkeiper: so, about trunk-2525
14:16:26 <djazayeri> !ticket trunk-2525
14:16:27 <OpenMRSBot> djazayeri: [#TRUNK-2525] Need to be able to edit drug dosage forms for concept from within the dictionary editor. - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2525
14:17:02 <djazayeri> jkeiper: what would you like to discuss about that?
14:17:14 <wyclif> djazayeri, i recall we discussed that on the devlist and design call'
14:17:27 <djazayeri> pascal`: do you run into a particular error? FWIW I never use the basic module, I always use the maven archetype now
14:17:28 <jkeiper> djazayeri, just need to know if my summary is accurate and we can move forward with coding
14:18:21 <djazayeri> jkeiper: "formularies will not have any impact on concept or drug searches"
14:18:26 <djazayeri> formularies *are* drugs
14:18:32 <djazayeri> formulations, rather
14:18:52 <pascal`> djazayeri, I had change the openmrs version in the pom file to be able to install it in 1.9.0
14:19:00 <pascal`> djazayeri, but not it wont build
14:19:22 <Alexis_MSF> [INFO] Unable to find resource 'org.openmrs.api:openmrs-api:pom:1.9.0' in repository openmrs-repo (http://mavenrepo.openmrs.org/nexus/content/repositories/public)
14:19:23 <OpenMRSBot> <http://ln-s.net/8-2X> (at mavenrepo.openmrs.org)
14:19:33 <pascal`> djazayeri, I'm actually helping out Alexis_MSF
14:19:37 <jkeiper> djazayeri, okay ... so they are concepts?
14:19:41 <pascal`> djazayeri, he pasted the error above.
14:19:51 <djazayeri> jkeiper: the things I'm calling "formulations" in my mockup are *drugs*
14:19:54 <djazayeri> i.e. rows in the drug table
14:19:59 <djazayeri> so searching for drugs should find them
14:20:01 <wyclif> jriley, i have just confirmed the fix to that search page was made after RC1, so that page should be fine
14:20:23 <djazayeri> pascal`, Alexis_MSF: the issue is that 1.9 is not released yet, so you won't find 1.9.0 in maven
14:20:38 <jkeiper> djazayeri, hrm okay ... so do they show up in "Manage Drugs" as individual drugs, or are they meant to be grouped there by concept?
14:20:40 <pascal`> djazayeri, is there any way around it?
14:20:47 <djazayeri> pascal`, Alexis_MSF: http://mavenrepo.openmrs.org/nexus/content/repositories/public/org/openmrs/openmrs/1.9.0-RC3/
14:20:48 <wyclif> jriley, are you running standalone or against your own database
14:20:53 <djazayeri> try 1.9.0-RC3
14:20:56 <jriley> wyclif, my own database
14:21:01 <jriley> So I'll upgrade to RC3 and see what happens
14:21:11 <wyclif> ok
14:21:18 <pascal`> djazayeri, thanks! I'll give it a try.
14:21:44 <djazayeri> jkeiper: in my mockup, the page on the top-right is intended to be a reworking of the current "Manage Concept Drugs" page
14:21:49 *** isharapremadasa has joined #openmrs
14:22:07 <djazayeri> with (1) a better title, (2) a search feature, (3) paging
14:22:07 *** isharapremadasa is now known as isharap
14:22:33 <Alexis_MSF> thanks
14:22:48 <jriley> Wyclif, I may not get to the upgrade until late afternoon after an appointment, but it's my next priority
14:22:58 <jriley> And thank you for looking into it.
14:23:08 <pascal`> djazayeri, thanks, that did the trick.
14:23:48 <djazayeri> jkeiper: does that make sense? I.e. we're not adding any new pages at all, just refactoring the currently-poorly-titled "Manage Concept Drugs"
14:24:07 <djazayeri> such that it works better and _also_ supports a mode where you limit it to a specific concept only
14:24:21 <wyclif> jriley, ok
14:24:21 <Alexis_MSF> djazayeri: I get this error now: Module requires version between 1.9.0 and , Current code version is 1.9.0.26883
14:25:04 *** Mkop1 is now known as Mkop
14:25:19 <pascal`> djazayeri, how do you specify that second version.. the "to" version?
14:25:31 <jkeiper> djazayeri, oh ... i see.
14:25:51 <djazayeri> pascal`, Alexis_MSF: is that from config.xml or from pom.xml?
14:26:38 <pascal`> djazayeri, I changed pom.zml
14:26:40 <pascal`> *xml
14:27:00 <djazayeri> I mean: is the error coming from compiling the module, or from uploading it to the webapp?
14:27:09 <djazayeri> jkeiper: so…is it clear?
14:27:13 <jkeiper> djazayeri, okay ... i'll modify my comment to suit by removing that line.
14:27:31 <jkeiper> hopefully "formulary" will not confuse someone looking for "drugs"
14:28:16 <djazayeri> jkeiper: we should be able to fix it all in code review via messages.properties, right? :-)
14:28:35 <djazayeri> jkeiper: can you work this into the mockup you said you were going to make on the other ticket?
14:29:34 <pascal`> djazayeri, it says something like: <require_version>${openMRSVersion}</require_version> in config.xml
14:29:49 <pascal`> djazayeri, and it looks like openMRSVersion is defined in pom.xml
14:30:02 <pascal`> djazayeri, maybe rafa can help, since it looks like he was last to modify those files.
14:30:08 <djazayeri> pascal`: you can try changing config.xml to just say 1.9.0 instead of ${openMRSVersion}
14:30:43 <djazayeri> pascal`: I think OpenMRS doesn't know how to handle non-numeric version numbers, (e.g. 1.9.0-RC3)
14:31:11 <pascal`> djazayeri, okay cool, Alexis_MSF and I will give that a try.
14:31:26 <jkeiper> djazayeri, yep and yep
14:32:18 <Alexis_MSF> djazayeri, that's work now, thanks a lot !
14:33:36 <djazayeri> rafa: hey, btw, did you get to the 1.9 blocker tickets, around concept source/map uuids?
14:34:49 <rafa> djazayeri: yes, on Monday. I wanted to test them today, but didn't have time.
14:35:08 <rafa> djazayeri: now I'm struggling with a failing bamboo :/
14:35:22 <djazayeri> rafa: okay; top priority is to test those (and figure out bamboo)
14:35:45 <djazayeri> rafa: could be a test with sporadic failures, having to do with timing?
14:36:19 <rafa> djazayeri: it seems like it's a timing issue
14:36:31 <rafa> djazayeri: it doesn't fail on my pc
14:37:20 <djazayeri> rafa: after that, for the rest of your time this week, (if you have any!), look into whether there are significant "bugfix" tickets to deal with. If not, you should redirect some time into the Drug UI sprint. (We neglected to plan for the holidays!)
14:38:23 <rafa> djazayeri: okay
14:43:30 <djazayeri> rafa: btw, was there a particular reason you decided to move MDS to git?
14:43:37 <djazayeri> (I completely agree with moving it.)
14:44:28 <rafa> djazayeri: speed :)
14:44:57 <rafa> djazayeri: I don't like waiting for svn commands
14:44:59 <djazayeri> speed of what? the ability to do local commits, branches, and switches?
14:45:35 <rafa> djazayeri: in my impression almost every command works faster in git
14:45:52 <rafa> djazayeri: including pushes and pulls form the server
14:46:20 *** Alexis_MSF has quit IRC
14:47:07 *** jriley has left #openmrs
14:48:11 <rafa> djazayeri: I want to mark SchedulerServiceTest#shouldSaveLastExecutionTime as ignored before we figure out how to properly test it
14:48:58 <djazayeri> rafa: fine by me. it's @Ignored in 1.9.x already
14:49:08 <djazayeri> at least in the version of the code I'm looking at
14:49:16 <rafa> djazayeri: actually almost all tests in SchedulerServieTest use Thread.sleep which we should get rid of
14:52:27 <djazayeri> rafa: see TRUNK-1964
14:52:36 <djazayeri> wyclif claims to have fixed the test that's breaking for you
14:52:47 <djazayeri> so maybe you need to mark that ticket as Rework Needed.
14:53:10 <djazayeri> rafa: I agree we need to fix those tests to not fail randomly. :-)
14:53:28 <djazayeri> downey: btw, JIRA has been pretty slow for the last week or so.
14:56:23 *** lh has quit IRC
14:57:00 <wyclif> djazayeri, rafa i fixed something else, if you read the ticket comments i noted that there was another problem with that Thread.sleep
14:58:26 <wyclif> djazayeri, rafa which makes one of the tests fail randomly i think it is shouldAllowTwoTasksInitMethodsToRunConcurrently
14:59:04 *** dkayiwa has quit IRC
15:02:25 *** nribeka has joined #openmrs
15:02:25 *** ChanServ sets mode: +v nribeka
15:03:35 *** nribeka has quit IRC
15:04:28 *** nribeka has joined #openmrs
15:04:28 *** ChanServ sets mode: +v nribeka
15:04:44 *** nribeka_ has joined #openmrs
15:04:59 *** nribeka has quit IRC
15:05:06 *** nribeka has joined #openmrs
15:05:06 *** ChanServ sets mode: +v nribeka
15:05:16 *** nribeka has quit IRC
15:05:52 *** pascal` has quit IRC
15:05:55 *** nribeka has joined #openmrs
15:05:55 *** ChanServ sets mode: +v nribeka
15:06:59 *** sgithens__ has quit IRC
15:11:32 *** nribeka has quit IRC
15:17:52 *** lh has joined #openmrs
15:29:01 *** rafa has quit IRC
15:29:53 *** nribeka has joined #openmrs
15:29:53 *** ChanServ sets mode: +v nribeka
15:30:35 <deadpool> djazayeri: can i ask you a database question?
15:31:45 *** cpower has quit IRC
15:32:03 <deadpool> djazayeri: i backed up my database and right now am trying to restore it but i keep on getting an error and i tried googling the error and for some reason it hasn't really solved the problem
15:34:30 <deadpool> this is the error i get http://pastebin.com/DWxiyvVJ
15:36:44 <deadpool> and this is my sql file http://temp-share.com/show/Pf3Ygu592
15:40:14 *** dkayiwa has joined #openmrs
15:40:46 *** rubailly has joined #openmrs
15:44:36 *** cpower has joined #openmrs
15:46:09 <djazayeri> deadpool: what tool did you use to do the backup?
15:46:49 <deadpool> openmrs backup module
15:47:10 *** isharap has quit IRC
15:48:13 *** dkayiwa has quit IRC
15:49:44 <djazayeri> deadpool: I haven't used that module, do you know who the module author is?
15:49:47 <djazayeri> can you ping them via one of the lists?
15:50:13 <deadpool> yeah i can
15:50:21 <djazayeri> deadpool: you're using mysql, I assume
15:50:25 <deadpool> yes
15:50:34 <deadpool> i tried restoring using the command line and all
15:50:48 <deadpool> but i get the error on the first table it is trying to create
15:51:08 <djazayeri> deadpool: I don't know if there's something funky with the syntax of the ` around the table name
15:51:21 <deadpool> hmm could be
15:51:36 <djazayeri> deadpool: can you paste the first few lines of the dump?
15:52:00 <deadpool> what do you mean?
15:52:05 <deadpool> when trying to backup?
15:52:17 *** finbrein has joined #openmrs
15:52:28 <djazayeri> deadpool: you pasted a link to a .sql.zip. I don't want to download, unzip, etc
15:52:40 <djazayeri> can you just send along the first few lines of the file?
15:52:44 <deadpool> oh yeah i can
15:53:11 *** deadpool has quit IRC
15:53:32 *** pulasthi7 has joined #openmrs
15:53:40 *** deadpool has joined #openmrs
15:55:22 <deadpool> djazayeri: this is the first two tables in the the sql dump http://pastebin.com/8eVAXU2V
15:57:07 <djazayeri> I wonder if the issue is that the prior command (ending in CHARSET=utf8) doesn't have a ; after it
15:57:25 <djazayeri> deadpool: but I don't know any more than you do.
15:58:08 <deadpool> djazayeri: i was thinking the same thing but then it was an automatic backup so there shouldn't be a problem
15:59:39 <djazayeri> deadpool: presumably if this module has been tested to work, it shouldn't have a glaring error like that, but I don't know anything about the module.
16:00:07 <deadpool> djazayeri: i can try and see what happens if i put the semicolon at the end of the tables
16:11:57 <deadpool> djazayeri: found the problems
16:12:10 <deadpool> it is kinda of a pain
16:12:26 <deadpool> you were right about the semicolon and also there is another syntax problem
16:13:02 <deadpool> when inserting data if the data has an escape character it gives an error if not properly escaped
16:13:26 <deadpool> do you want me to write those bugs up?
16:13:41 <djazayeri> deadpool: yes, it seems worthwhile to create tickets and to email the module author
16:13:50 <djazayeri> who owns that module?
16:14:15 <djazayeri> i.e. if it's missing a required semicolon, it seems like the module is completely non-functional, and nobody should be using that version...
16:15:58 <deadpool> the last person to modify the code was bwolfe but i think the author was mathias lin
16:16:47 <djazayeri> deadpool: anyway, yes, you should document the error
16:17:05 <deadpool> i will
16:17:33 *** snoppy has left #openmrs
16:26:30 <deadpool> djazayeri: thanks for the help
16:28:38 *** basic- has joined #openmrs
16:28:48 <downey> Hi basic- and welcome to the #openmrs IRC channel.
16:29:11 *** bryq1 has joined #openmrs
16:30:28 *** bryq has quit IRC
16:31:43 *** basic- has quit IRC
16:38:59 *** nadee has joined #openmrs
16:56:56 *** rohitgoyal18 has joined #openmrs
17:03:09 *** sgithens has joined #openmrs
17:04:11 *** nadee has quit IRC
17:21:01 *** rohitgoyal18 has quit IRC
17:26:58 <pulasthi7> hi james_regen
17:31:08 *** mvorobey has joined #openmrs
17:31:16 <mvorobey> hi all
17:32:43 <mvorobey> hi jkeiper
17:33:15 <jkeiper> heyya mvorobey
17:33:33 <mvorobey> jkeiper, just saw your comment on TRUNK-3245, thanks for this note I will take care of it
17:34:29 <jkeiper> mvorobey, np
17:34:43 <mvorobey> jkeiper, good :)
17:34:50 *** rohitgoyal18 has joined #openmrs
17:44:19 *** mseaton has joined #openmrs
17:44:19 *** ChanServ sets mode: +v mseaton
17:44:41 <mseaton> jkeiper, question about drug mgmt ui changes...
17:45:05 <mseaton> i notice you say you are implementing this for 1.10 this week.
17:45:52 <jkeiper> mseaton, yes
17:46:07 <mseaton> i haven't been involved in all of the meetings / discussions, so apologies if this has been discussed and agreed, but i would think if data model / api changes are not significant (or do not play a significant role in a UI feature) that this could/should be done in a module potentially...
17:46:08 <jkeiper> mseaton, it just means that i am working on it this week and it is for 1.10
17:46:49 <jkeiper> mseaton, it's just a change to the management page ... improving a flawed design
17:46:53 <mseaton> we started an "advanced concept mgmt" module a few years ago for gsoc because so much is lacking in the dictionary ui. would be a potential module to take on
17:46:59 <jkeiper> mseaton, doesn't change the data model
17:47:27 <mseaton> jkeiper, i get that. and i agree that a fix / improvement to core is good...but no-one using 1.9, 1.8, 1.7 will get to use it...
17:48:02 <mseaton> so if the work doesn't depend on anything in 1.10, you might consider just overriding the manage drug page in a module, so that a broader community of users can take advantage
17:48:23 <mseaton> then, this can be rolled into 1.10 as a native feature once it has evolved a bit and gotten lots of field use
17:48:35 <jkeiper> mseaton, ah i get your point
17:49:01 <jkeiper> i planned on doing just that for AMPATH alreadty
17:49:05 <mseaton> something to consider - not sure if djazayeri has weighed in already on this point, but i wanted to raise it
17:49:20 <jkeiper> mseaton, makes sense ... i'll bring it up on the design review call
17:49:25 <jkeiper> (in 10 minutes)
17:49:30 <mseaton> i'll be there :)
17:50:15 <jkeiper> haha good!
17:51:40 <mvorobey> jkeiper, I just updated patch for TRUNK-3245 with minor changes that you have asked :)
17:51:52 <jkeiper> thanks mvorobey
17:52:08 <mvorobey> jkeiper, no problems :)
18:02:48 <djazayeri> jkeiper, mseaton, etc, design call now
18:02:56 <djazayeri> nribeka: you there?
18:30:07 <mseaton> i'm on
18:37:25 <nribeka> woohooo mseaton ++
18:51:16 *** rubailly has quit IRC
18:53:40 *** nribeka has quit IRC
18:59:31 *** docaeby has joined #openmrs
18:59:36 <downey> Hi docaeby and welcome to the #openmrs IRC channel.
19:01:45 <docaeby> Having trouble taking OpenMRS for test drive, what format should patient id numbers be in?
19:04:28 *** nribeka has joined #openmrs
19:04:28 *** ChanServ sets mode: +v nribeka
19:07:24 <jkeiper> if i'm about to mavenize a module (conceptmanagement), should i branch or tag as "pre-mavenization"? rather, which is it: branch or tag? i know i need to do one of the two.
19:09:36 *** nribeka has quit IRC
19:12:47 <jkeiper> mseaton, it is currently called the "Concept Search Module" but the code space is conceptmanagement .... what should the official name of the module be, if you had to name it?
19:12:53 <jkeiper> Concept Management Module?
19:13:45 <mseaton> jkeiper: yeah, i don't know why that was done. it's meant to be conceptmanagement module. we should replace all Concept Search references
19:14:51 <jkeiper> jkeiper, so "Concept Management Module" is appropriate?
19:15:42 <jkeiper> hahaha i mean mseaton ---^
19:16:01 <mseaton> mseaton, i mean jkeiper, yes.
19:16:24 <jkeiper> heh ok ... i'm suggesting CMGMT as the project key :-D
19:16:29 <jkeiper> can't get more confusing than that
19:16:42 <mseaton> SGTM
19:17:07 <mseaton> (sounds good to me)
19:17:17 <jkeiper> heh
19:17:22 *** mvorobey has quit IRC
19:18:38 <jkeiper> mseaton, ah ... this is why i thought it was called "Advanced ...": https://wiki.openmrs.org/display/projects/Advanced+Concept+Management+Module
19:19:07 <mseaton> jkeiper. i'm fine with the "advanced" monikor. it's the "Concept Search" module name i object to
19:19:18 <jkeiper> ok, i'll stick with Advanced
19:19:25 <jkeiper> ACMGMTMOD
19:20:26 *** docaeby has quit IRC
19:22:29 *** nribeka has joined #openmrs
19:22:29 *** ChanServ sets mode: +v nribeka
19:27:39 *** james_regen has left #openmrs
19:34:40 <jkeiper> mseaton, does the pre-mavenization code belong in a tag or in a branch?
19:34:45 <jkeiper> branches are for merging (I thought)
19:34:49 <jkeiper> so i figured tagging was appropriate
19:35:00 <jkeiper> or should I *gasp* move it to GIT?!
19:35:39 <mseaton> jkeiper, i think you can just tag it and move on in trunk. not sure if this module was ever released or not.
19:35:45 <jkeiper> ok
19:40:49 *** pulasthi7 has quit IRC
19:43:01 *** dkayiwa has joined #openmrs
19:50:09 *** nribeka has quit IRC
19:53:22 <djazayeri> mseaton: you there?
19:53:35 <djazayeri> can you give a very quick update on your order group spike on the call?
20:05:01 <tobn_g> hi downey do you have time for a quick server admin question?
20:05:22 *** nribeka has joined #openmrs
20:05:22 *** ChanServ sets mode: +v nribeka
20:08:39 <jkeiper> tobn_g, downey is on the phone atm
20:08:43 <jkeiper> fy
20:08:44 <jkeiper> i
20:09:09 <tobn_g> jkeiper: thanks, atm?
20:09:18 <jkeiper> at the moment
20:09:20 *** sgithens has quit IRC
20:09:32 <tobn_g> jkeiper: thanks :-)
20:09:32 <jkeiper> s/the/this
20:09:35 <jkeiper> np
20:15:44 *** jkeiper has quit IRC
20:19:12 *** rohitgoyal18 has quit IRC
20:24:27 *** rafa has joined #openmrs
20:24:27 *** ChanServ sets mode: +v rafa
20:24:45 *** rafa has quit IRC
20:26:10 *** nribeka has quit IRC
20:26:25 *** tobn_g has quit IRC
20:39:02 *** mseaton has left #openmrs
21:01:34 *** mseaton has joined #openmrs
21:01:34 *** ChanServ sets mode: +v mseaton
21:01:44 *** mseaton has left #openmrs
21:23:03 *** bryq1 has quit IRC
21:37:39 *** wyclif has quit IRC
21:38:53 *** downey has quit IRC
22:30:49 *** wyclif has joined #openmrs
22:49:36 *** dkayiwa_ has joined #openmrs
22:51:19 *** carloshpf has joined #openmrs
22:51:30 *** dkayiwa has quit IRC
22:54:09 *** dkayiwa_ has quit IRC
23:49:43 *** lh has quit IRC