IRC Chat : 2012-05-01 - OpenMRS

00:22:06 *** deadpool has joined #openmrs
00:39:00 *** deadpool has quit IRC
00:46:55 <finbrein> robbyocnnor: Oh, I can see the pages now.
00:47:09 <finbrein> robbyoconnor: Oh, I can see the pages now.
00:50:16 <finbrein> robbyoconnor: pages cannot be removed?
00:50:57 <finbrein> robbyoconnor: next time, I have to check that similar pages don't exist
00:55:54 <robbyoconnor> ask Michael
00:56:03 <robbyoconnor> I'm not quite sure
00:56:27 <robbyoconnor> what you should've been writing is how to do Git with IDEA
01:01:50 *** rafa has joined #openmrs
01:01:50 *** ChanServ sets mode: +v rafa
01:05:09 <finbrein> robbyoconnor: that's my intention to develop the page bit-by-bit this week.(GIT). I don't want to do everything at once. Besides, I am just going to try out IDEA - never used it before.
01:06:41 *** rafa has quit IRC
01:09:10 <robbyoconnor> it's a great IDE
01:24:55 *** jkeiper has joined #openmrs
02:24:33 *** rohitgoyal18 has joined #openmrs
02:28:30 *** jkeiper has quit IRC
02:29:19 *** rohitgoyal18 has quit IRC
02:34:45 *** jkeiper has joined #openmrs
02:44:38 *** djazayeri has joined #openmrs
02:44:38 *** ChanServ sets mode: +o djazayeri
04:48:28 *** finbrein has quit IRC
06:09:42 *** bryq has joined #openmrs
06:09:42 *** ChanServ sets mode: +v bryq
06:15:38 *** bryq has quit IRC
06:58:56 *** rohitgoyal18 has joined #openmrs
07:29:28 *** rohitgoyal18 has quit IRC
08:06:33 *** finbrein has joined #openmrs
08:06:45 *** finbrein has quit IRC
09:10:25 *** snoppy has joined #openmrs
09:34:19 *** bryq has joined #openmrs
09:34:19 *** ChanServ sets mode: +v bryq
09:54:01 *** finbrein has joined #openmrs
10:32:55 *** robbyoconnor has quit IRC
10:47:47 *** leonjeru has joined #openmrs
10:49:31 *** harshadura has joined #openmrs
10:58:21 *** leonjeru has quit IRC
11:10:13 *** harshadura has quit IRC
11:25:34 *** james_regen has joined #openmrs
11:25:34 *** ChanServ sets mode: +v james_regen
11:25:39 *** harshadura has joined #openmrs
11:28:38 *** bryq has quit IRC
11:43:27 *** bryq has joined #openmrs
11:43:27 *** ChanServ sets mode: +v bryq
12:31:48 *** harshadura has quit IRC
12:39:38 *** ChanServ sets mode: +v jkeiper
12:40:24 <jkeiper> is "svn propset --revprop -r X svn:author" the only way to set a different author if you are committing a patch?
12:40:42 <jkeiper> (and is that what we do?)
12:40:53 * jkeiper notices that it's May Day
12:45:35 <jkeiper> arrrrgh, that doesn't work
12:45:36 <jkeiper> :-/
12:46:38 *** bryq has quit IRC
13:10:44 *** sgithens_ has joined #openmrs
13:14:39 *** Ranjan has joined #openmrs
13:15:00 *** dawn_ has joined #openmrs
13:15:02 *** ChanServ sets mode: +v dawn_
13:15:06 *** Ranjan has quit IRC
13:15:12 *** dawn_ has quit IRC
13:25:40 *** dawn_ has joined #openmrs
13:25:40 *** ChanServ sets mode: +v dawn_
13:25:41 *** robbyoconnor has joined #openmrs
13:25:41 *** ChanServ sets mode: +v robbyoconnor
13:26:00 *** dawn_ has quit IRC
13:26:05 *** dawn_ has joined #openmrs
13:26:05 *** ChanServ sets mode: +v dawn_
13:34:18 *** dawn_ has quit IRC
13:37:08 *** robbyoconnor has quit IRC
13:38:53 *** bryq has joined #openmrs
13:38:53 *** ChanServ sets mode: +v bryq
13:41:57 *** dawn_ has joined #openmrs
13:41:57 *** ChanServ sets mode: +v dawn_
13:54:52 *** sgithens__ has joined #openmrs
13:54:53 *** sgithens_ has quit IRC
13:56:11 *** kishoreyekkanti has joined #openmrs
14:01:13 <dawn_> !scrumon dawn
14:01:13 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready.
14:01:18 <djazayeri> jkeiper: hey, when committing someone else's patch you just do
14:01:24 <dawn_> Hi Team. I believe it's a holiday for most of the team
14:01:26 <djazayeri> comment <br/>author: author
14:01:32 <dawn_> Today's Order: wyclif , Mkop , jkeiper , djazayeri
14:01:37 <jkeiper> djazayeri, oh?
14:01:47 <jkeiper> not --username?
14:01:58 <wyclif> Monday:
14:01:58 <wyclif> * Redo merging of trunk changes to order entry branch(I'm considering making changes to the old branch)
14:01:58 <wyclif> * Order entry design with burke about the OrderTypeHandlers
14:01:58 <wyclif> * Create tickets for Supporting OrderTypeHandlers and OrderNumber algorithms
14:01:58 <wyclif> Tuesday:
14:01:59 <wyclif> * Work on some order entry tickets
14:02:01 <wyclif> Blockers: none
14:03:11 <dawn_> Mkop: your turn (if you have updates)
14:03:26 <Mkop> haha. haven't touched openmrs in years. I'm just a lurker
14:03:32 <dawn_> haha! k
14:03:33 <Mkop> someone please -v me :-)
14:03:36 <dawn_> jkeiper: your turn
14:03:37 <jkeiper> heh
14:03:41 <jkeiper> Yesterday:
14:03:41 <jkeiper> * held introductory meeting
14:03:41 <jkeiper> * reviewed patches for TRUNK-3300
14:03:41 <jkeiper> * reviewed commits for TRUNK-3273
14:03:41 <jkeiper> * discussed TRUNK-3125 at length
14:03:42 <jkeiper> * began work on TRUNK-3124
14:03:44 <jkeiper> Today:
14:03:46 <jkeiper> * committed trunk patch for TRUNK-3300
14:03:48 <jkeiper> * finish committing patches for TRUNK-3300
14:03:50 <jkeiper> * review additional completed tickets in drug sprint
14:03:52 <jkeiper> * finalize TRUNK-3125
14:03:54 <jkeiper> * generate tickets from TRUNK-3124 if search-related
14:03:56 <jkeiper> * continue work on TRUNK-3124
14:04:00 <jkeiper> Blockers:
14:04:02 <jkeiper> * minor issue with setting author while committing
14:04:20 <jkeiper> s/finalize/finalize design of
14:04:37 <dawn_> djazayeri: your turn
14:05:11 <djazayeri> Friday-Weekend-Monday
14:05:12 <djazayeri> * More work on RESTWS-243 to allow creating an encounter-with-orders
14:05:12 <djazayeri> * Finally committed RESTWS-243 (the big RESTWS subclass ticket)
14:05:12 <djazayeri> * Looked into state of Concept Proposal module
14:05:12 <djazayeri> * Addressed some UI Framework tickets that were blocking MarkG
14:05:12 <djazayeri> * Fixed UIFR-14 (@BindParams doesn't appear to properly bind Collections)
14:05:13 <djazayeri> * Fixed UIFR-15 (Allow modules to register their own custom converters)
14:05:13 <djazayeri> * Fixed UIFR-19 (Fragment actions don't work for fragments in subdirectories)
14:05:14 <djazayeri> * Fixed UIFR-26 (ClassCastException when trying to view a page after reloading the UI Framework module)
14:05:14 <djazayeri> * Released UI Framework 1.2
14:05:15 <djazayeri> * Drug Sprint kickoff meeting
14:05:16 <djazayeri> * Mockup for one of the sprint tickets
14:05:16 <djazayeri> * Started UIFR-27 (@RequestParams does not appear to properly bind Collections)
14:05:29 <djazayeri> Today
14:05:34 <djazayeri> * Finish UIFR-27
14:05:47 <djazayeri> * work on ITECH project
14:05:59 <djazayeri> no blockers
14:06:43 <dawn_> djazayeri: did i miss anyone?
14:07:06 <djazayeri> not that I see on IRC
14:07:09 <dawn_> !scrumoff dawn
14:07:09 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
14:07:11 <jkeiper> dawn_, mvorobey would have been it
14:07:15 <dawn_> Discussion Points: 1) Blocker: minor issue with setting author while committing
14:07:22 <dawn_> jkeiper: thanks!
14:08:54 <Mkop> djazayeri: please -v me!
14:08:58 <djazayeri> jkeiper: applying a patch would have a commit message like
14:08:59 <djazayeri> Applying patch that does feature x or fixes bug y. see ticket TRUNK-123
14:08:59 <djazayeri> Author: bwolfe
14:09:11 <djazayeri> -v Mkop
14:09:32 <jkeiper> /msg chanserv --v Mkop
14:09:38 <jkeiper> -----^
14:10:30 <djazayeri> msg ChanServ -v Mkop
14:11:48 *** sgithens__ has quit IRC
14:12:04 *** sgithens__ has joined #openmrs
14:13:05 *** ChanServ sets mode: -v Mkop
14:13:17 <Mkop> yay! finally
14:13:30 <djazayeri> We'll see if the bot auto-voices you next time you log on
14:13:31 <djazayeri> :-)
14:14:19 <jkeiper> heh
14:14:28 <jkeiper> so djazayeri, do you do that from the command line with a \n or something?
14:14:57 <djazayeri> jkeiper: I don't know about the command line. I always commit from my IDE
14:14:57 <jkeiper> like "svn ci -m'TRUNK-3300 - foo<br/>author: mvorobey'"
14:15:03 <jkeiper> djazayeri, oh
14:15:10 <djazayeri> jkeiper: I doubt that <br/> would work
14:15:15 <jkeiper> boo
14:15:26 <jkeiper> i can commit from ide too ... just like the command line
14:15:47 <jkeiper> apparently our repo isn't set up to allow post-commit changing of authors
14:16:16 *** dawn_ has quit IRC
14:17:48 <djazayeri> jkeiper: it used to allow it
14:18:02 <jkeiper> maybe it's just me then
14:18:04 <djazayeri> I recall revising commit messages in the past, or maybe asking ben to
14:18:12 <djazayeri> but that was years ago
14:18:28 <jkeiper> commit messages, yes ... svn:author no.
14:18:35 <jkeiper> no biggie i guess
14:18:40 <jkeiper> as long as mvorobey doesn't mind ;-)
14:19:02 <djazayeri> jkeiper: oh, yeah, we don't bother to do that
14:19:11 <djazayeri> we just indicate the real author in the commit message
14:19:18 <jkeiper> ohhh
14:19:22 <djazayeri> we don't actually change the real author of the commit
14:19:24 <jkeiper> so it's just an acknowledgement
14:19:26 <jkeiper> ah
14:19:28 <djazayeri> yeah
14:19:30 <jkeiper> i thought that's what it was doing
14:19:31 <jkeiper> hah
14:19:33 <jkeiper> strange
14:19:57 <djazayeri> jkeiper: see Sample commit message at https://wiki.openmrs.org/display/docs/Patches
14:20:14 <jkeiper> ok
14:20:20 <jkeiper> is it wrong to assign it to that user if we can?
14:20:38 <djazayeri> jkeiper: or rather Applying patches to trunk and other branches at https://wiki.openmrs.org/display/docs/Subversion+Code+of+Conduct
14:20:39 <OpenMRSBot> <http://ln-s.net/97kC> (at wiki.openmrs.org)
14:20:48 <djazayeri> jkeiper: not wrong I guess, but we've never done it
14:21:07 <djazayeri> jkeiper: perhaps it won't work because the person in question probably doesn't have commit privs
14:21:13 <djazayeri> jkeiper: just do what everyone else does
14:21:14 <djazayeri> brb
14:21:28 <jkeiper> :-)
14:25:15 *** snoppy has left #openmrs
14:27:53 *** finbrein has quit IRC
14:30:03 *** sgithens__ has quit IRC
14:36:19 *** dawn_ has joined #openmrs
14:36:19 *** ChanServ sets mode: +v dawn_
14:38:01 <jkeiper> djazayeri, not sure if you know what the deal is with this:
14:38:04 <jkeiper> !ticket ITSM-2445
14:38:05 <OpenMRSBot> jkeiper: OpenMRS JIRA - Log in - https://tickets.openmrs.org/browse/ITSM-2445
14:38:11 <jkeiper> uhh
14:38:24 <jkeiper> TRUNK-3300 is in an unchangeable state (at least for me)
14:38:38 <jkeiper> !ticket TRUNK-3300
14:38:41 <OpenMRSBot> jkeiper: [#TRUNK-3300] Concept Drug Search doesnt work when searching by Drug ID - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3300
14:39:08 <jkeiper> ohhhhh NOW it shows up
14:39:13 <jkeiper> nvm
14:40:42 <djazayeri> jkeiper: for me it says it's in status=Approved (which is rare, but I guess it's accessible from pre-commit code review)
14:41:11 <djazayeri> jkeiper: the action I have available on it is "Committed - Close"
14:41:13 <jkeiper> it said Approved but did not have a way of saying "Committed - Close"
14:41:18 <jkeiper> until just now
14:41:23 <jkeiper> must have needed commits to all branches
14:41:27 <jkeiper> or something
14:41:34 <jkeiper> after first commit to trunk i didn't see it
14:41:34 <djazayeri> jkeiper: did it have a crucible review?
14:41:48 <djazayeri> you're not allowed to close a ticket until any associated crucible reviews are closed
14:41:51 <jkeiper> yep, summarized that too ... ohhhhhhh
14:41:56 <jkeiper> okay, interesting
14:42:02 <jkeiper> but there were also no other ways to move forward
14:42:05 <jkeiper> or backward
14:42:22 <jkeiper> yeah, i summarized the review after approving
14:42:27 <jkeiper> that must be it
14:45:44 *** nadee has joined #openmrs
14:50:42 <jkeiper> wyclif, is buea.openmrs.org:8080/openmrs for drug sprint?
14:50:47 <jkeiper> (it's not working)
14:51:11 <jkeiper> or is there a sprint build?
14:51:17 <djazayeri> jkeiper: buea is not for the drug sprint (there is no sprint build server)
14:51:24 <jkeiper> o
14:51:29 <jkeiper> k
14:51:31 <jkeiper> thx
14:53:31 <jkeiper> fwiw, it's broke ;-)
14:53:50 *** dawn_ has quit IRC
14:58:45 *** isharapremadasa has joined #openmrs
14:59:44 *** isharapremadasa is now known as isharap
15:01:19 <wyclif> hi jkeiper
15:01:42 <jkeiper> hi wyclif, nvm ... djazayeri answered me :-)
15:01:53 <wyclif> jkeiper, ok
15:47:27 *** kishoreyekkanti has quit IRC
15:58:46 *** isharap has quit IRC
15:58:54 *** suranga has joined #openmrs
15:58:54 *** ChanServ sets mode: +v suranga
16:08:10 *** nadee has quit IRC
16:12:43 *** rohitgoyal18 has joined #openmrs
16:22:14 <suranga> hi james_regen
16:22:23 <suranga> james_regen, you're not really here, are you ?
16:23:02 <james_regen> hi suranga
16:23:19 <suranga> james_regen, mm.. isnt it a holiday over there in the US ?
16:23:21 <suranga> wow
16:23:32 <james_regen> nope, no holiday
16:24:05 <suranga> james_regen, ooops :-)
16:24:59 <suranga> james_regen, remember our GSOC task which involves calculating the number of potential pairs formed by particular blocking strategy ?
16:25:07 <james_regen> yes
16:25:20 <suranga> one of the proposed solutions was to take an already written R code file, and convert it into java
16:25:38 <suranga> mmm.... I cant seem to find this R file in the OpenMRS trunk.... :-)
16:26:18 <james_regen> shaun has that R script. he uses it when analyzing data. i don't think anything R related is in svn
16:26:46 <suranga> oh, I see
16:27:12 <james_regen> i'm not sure how easily it will be to use, though. R loads the data somehow, and i'm not sure if we would need to load the data somewhere in a similar fashion
16:27:39 <james_regen> i would guess HQL would be the way to solve it, but i could be wrong. i haven't looked into the R script much
16:27:50 <suranga> right now we were favouring doing an HQL query to calcilate this
16:28:10 <suranga> james_regen, ah, looks like we both favour HQL :-)
16:28:37 <suranga> james_regen, have u used HQL elseware in the patientmatching module ?
16:28:40 <james_regen> while incomplete, there was a class that used HQL to form pairs that was written a while ago.
16:28:57 <suranga> ah, great !
16:29:09 <suranga> (wonder if you remember its name ;-)
16:29:11 <james_regen> it only worked with one blocking field, i got it working with just one, and saw that it was pretty slow
16:29:45 <james_regen> but it was slow iterating over Patient objects returned from the query. just doing a count() would probably be fast
16:31:45 <james_regen> i think i tmight be org.regenstrief.linkage.io.OpenMRSFormPairs
16:33:46 <james_regen> hmm, it doesn't look great, but it's at least code to look at as a start
16:33:53 *** finbrein has joined #openmrs
16:37:00 <suranga> james_regen, one more question, assume my configuration has a must match column and a should match column. If so,
16:37:03 <suranga> do we need to do something like
16:37:04 <suranga> a) select count(*) from person a, person b where a.dob = b.dob and a.gender = b.gender
16:37:04 <suranga> and sum the total calculations for all potential patient pairs ? this means, if there are n possible patient pairs I do it n times and sum up the totals ?
16:38:48 <james_regen> suranga: all you need to include in the query would be the must match fields, since that's the only field that determines what records get paired up. so if dob were the must match and gender were the should match, it would only need to be elect count(*) from person a, person b where a.dob = b.dob
16:39:31 <suranga> james_regen, I see
16:39:36 <james_regen> if both gender and dob were must match, then what ou had would give the correct number.
16:40:04 <suranga> james_regen, but we would need to do it for all patient combinations, and sum up the total, correct ? :-)
16:41:05 <james_regen> i'm not sure where the different numbers are coming from. do you mean all different blocking runs?
16:45:11 <suranga> sorry, I meant, in this case, patient a and patient b represent the two patients from each possible patient pair, correct ?
16:47:47 <james_regen> suranga: yes, though i think the count(*) returns the number of pairs, and that it gives you the answer directly. thinking about it, the where clause might need to be more sophisticated
16:48:41 <suranga> james_regen, Ii suspect we will need a.UID <> b.UID
16:48:49 <suranga> I think, that is :-)
16:49:20 <james_regen> or a.UID > b.UID (or the other way around) so you avoid pairs that are the same two people swapped left and right
17:09:11 <jkeiper> suranga, are you talking about what ada encountered?
17:13:51 <suranga> hi jkeiper
17:14:05 <suranga> sorry, I thought u guys were all enjoying may day holiday
17:14:36 <suranga> jkeiper, I went through all the logs in the regenstrief test server, but I cant seem to find anything wrong
17:14:53 <suranga> in fact, I was about to reply to the email...
17:17:25 *** pulasthi7 has joined #openmrs
17:19:45 <jkeiper> suranga, we don't celebrate May 1 ... i have a final today! :-D
17:20:40 <suranga> jkeiper, my deepest sympathies :P
17:20:50 <suranga> my own finals start on the 10th :P
17:21:30 <jkeiper> haha
17:21:31 <jkeiper> thanks
17:21:59 <jkeiper> suranga, perhaps we can turn up logging to find the problems
17:22:17 <jkeiper> perhaps when we find particular data that we know should match we could log information
17:22:20 <jkeiper> just for this test
17:22:27 <jkeiper> or create a unit test! :-D
17:23:14 <suranga> jkeiper, hmm.. turning up logging would be a good idea...
17:24:08 <suranga> jkeiper, I also faced some networking problem because I kept getting timeouts from the regenstrief test server :-(
17:24:19 <jkeiper> ah
17:41:33 *** finbrein has quit IRC
17:55:45 *** jkeiper has quit IRC
18:10:51 *** finbrein has joined #openmrs
18:21:23 *** finbrein has quit IRC
18:21:36 *** finbrein has joined #openmrs
18:27:08 *** bryq has quit IRC
18:32:06 *** rafa has joined #openmrs
18:32:06 *** ChanServ sets mode: +v rafa
18:32:37 *** rafa has quit IRC
18:44:22 *** bryq has joined #openmrs
18:44:22 *** ChanServ sets mode: +v bryq
18:45:55 *** suranga has quit IRC
18:46:45 *** pulasthi7 has quit IRC
18:53:48 *** harshadura has joined #openmrs
18:58:10 *** sgithens__ has joined #openmrs
19:20:51 *** lh has joined #openmrs
19:20:51 *** lh has joined #openmrs
19:35:24 <cpower> d
19:36:56 *** wyclif has quit IRC
19:37:08 *** harshadura has quit IRC
19:51:52 *** james_regen has left #openmrs
19:57:50 *** wyclif has joined #openmrs
20:17:26 *** lh has quit IRC
20:24:53 *** wyclif has quit IRC
20:31:24 *** sgithens__ has quit IRC
20:37:29 *** rohitgoyal18 has quit IRC
20:47:27 *** bryq has quit IRC
21:11:55 *** dawn_ has joined #openmrs
21:11:55 *** ChanServ sets mode: +v dawn_
21:12:51 *** dawn_ has quit IRC
21:19:41 <finbrein> ping djazayeri
21:19:46 <djazayeri> hi finbrein
21:20:32 <finbrein> djazayeri: do you have some minutes? I want to get a better understanding of ticket REPORT-348
21:20:43 <djazayeri> !ticket report-348
21:20:46 <OpenMRSBot> djazayeri: [#REPORT-348] Allow incremental cell values in repeating sections of excel template - OpenMRS JIRA - https://tickets.openmrs.org/browse/report-348
21:21:17 <finbrein> Asked to generate, name, gender and error checking
21:21:19 <djazayeri> finbrein: do you know about excel templates in the reporting module in general?
21:21:35 <finbrein> No
21:22:02 <finbrein> https://wiki.openmrs.org/display/docs/Building+Reports+%28Step+By+Step+Guide%29 - being checking this page
21:22:28 <djazayeri> And this seems like the specifics of Excel templates:
21:22:28 <djazayeri> https://wiki.openmrs.org/x/VQFl
21:23:04 <finbrein> thanks
21:23:21 <djazayeri> finbrein: you may want to comment on the ticket and ask Ellen to attach an example of the Excel she'd like to be using.
21:24:04 <finbrein> djazayeri: I will. What about the "error checking"? it is not a property
21:24:53 <djazayeri> finbrein: meaning that she wants to use an excel formula that does error checking
21:25:07 <djazayeri> i.e. the error checking is coded in the excel template, like =if(isblank(A10))
21:25:19 <djazayeri> that's the point of the ticket
21:25:51 <djazayeri> that if that row is "repeating", the copies of the row should use A11, A12, A13, etc
21:26:18 <djazayeri> I don't know how well Apache POI handles formulas.
21:27:54 <finbrein> djazayeri: thanks i'll investigate
21:42:16 *** robwil has joined #openmrs
21:43:30 <robwil> hi, I've got a quick question about openmrs-standalone if anyone is available
22:12:56 *** robwil has quit IRC
22:51:08 *** Mkop has quit IRC
22:51:47 *** djazayeri has quit IRC
22:51:49 *** finbrein has quit IRC
22:51:49 *** Echidna_ has quit IRC
23:00:56 *** finbrein has joined #openmrs
23:00:56 *** djazayeri has joined #openmrs
23:00:56 *** Echidna_ has joined #openmrs
23:00:56 *** zelazny.freenode.net sets mode: +o djazayeri
23:01:07 *** Mkop has joined #openmrs
23:01:07 *** ChanServ sets mode: +v Mkop
23:26:20 *** Mkop1 has joined #openmrs
23:26:20 *** ChanServ sets mode: +v Mkop1
23:32:38 *** Mkop has quit IRC
23:42:31 *** maro has joined #openmrs
23:42:31 *** finbrein has quit IRC