| 02:18:18 | *** harshadura has joined #openmrs |
| 02:55:59 | *** bwolfe_ has quit IRC |
| 03:15:09 | *** djazayeri has joined #openmrs |
| 03:15:09 | *** ChanServ sets mode: +o djazayeri |
| 03:25:12 | *** djazayeri has quit IRC |
| 03:35:36 | *** r_friedman has quit IRC |
| 03:39:29 | *** djazayeri has joined #openmrs |
| 03:39:29 | *** ChanServ sets mode: +o djazayeri |
| 03:44:49 | *** finbrein has quit IRC |
| 03:50:06 | *** harshadura has quit IRC |
| 04:21:28 | *** kavuri has joined #openmrs |
| 04:26:07 | *** upul` has joined #openmrs |
| 04:26:07 | *** ChanServ sets mode: +v upul` |
| 04:36:55 | *** finbrein has joined #openmrs |
| 04:44:06 | *** bryq has joined #openmrs |
| 04:44:06 | *** ChanServ sets mode: +v bryq |
| 04:48:29 | *** bryq has quit IRC |
| 04:49:01 | *** Echidna_ has joined #openmrs |
| 04:49:01 | *** Echidna has quit IRC |
| 04:51:27 | *** kavuri has quit IRC |
| 05:08:20 | *** kavuri has joined #openmrs |
| 05:15:00 | *** finbrein has quit IRC |
| 05:15:14 | *** finbrein has joined #openmrs |
| 05:45:25 | *** finbrein has quit IRC |
| 05:45:40 | *** finbrein has joined #openmrs |
| 06:12:29 | *** finbrein has quit IRC |
| 06:20:09 | *** finbrein has joined #openmrs |
| 06:21:32 | *** bryq has joined #openmrs |
| 06:21:32 | *** ChanServ sets mode: +v bryq |
| 06:56:29 | *** bryq has quit IRC |
| 06:59:18 | *** kavuri has quit IRC |
| 07:05:05 | *** dkayiwa has joined #openmrs |
| 07:24:55 | <finbrein> dkayiwa: I have checked some module controller test classes and read the following pages (https://wiki.openmrs.org/display/docs/Unit+Tests) and (https://wiki.openmrs.org/display/docs/Module+Unit+Testing) for Unit Testing and Module Unit Testing respectively. The @should annotation is not used in the class to be tested in Module unit testing. Usually, it used when testing the core classes. Could you clarify?. Thanks. |
| 07:25:03 | <OpenMRSBot> <http://ln-s.net/90Rl> (at wiki.openmrs.org) |
| 07:26:25 | <finbrein> dkayiwa: I have checked some module controller test classes and read the following pages (https://wiki.openmrs.org/display/docs/Unit+Tests) and (https://wiki.openmrs.org/display/docs/Module+Unit+Testing) for Unit Testing and Module Unit Testing respectively. |
| 07:26:25 | <finbrein> dkayiwa:The @should annotation is not used in the class to be tested in Module unit testing. Usually, it used when testing the core classes. |
| 07:26:25 | <finbrein> dkayiwa: Could you clarify?. Thanks |
| 07:26:26 | <OpenMRSBot> <http://ln-s.net/90Rl> (at wiki.openmrs.org) |
| 07:27:45 | <finbrein> Hi All! ;) |
| 07:28:06 | <finbrein> I have checked some module controller test classes and read the following pages (https://wiki.openmrs.org/display/docs/Unit+Tests) and (https://wiki.openmrs.org/display/docs/Module+Unit+Testing) for Unit Testing and Module Unit Testing respectively. |
| 07:28:10 | <OpenMRSBot> <http://ln-s.net/90Rl> (at wiki.openmrs.org) |
| 07:28:20 | <finbrein> The @should annotation is not used in the class to be tested in Module unit testing. Usually, it used when testing the core classes. |
| 07:28:48 | <finbrein> Could someone clarify please.thanks. |
| 07:30:50 | <finbrein> I am using the Eclipse Test case generator plugin. And it will be useful and helpful to use the annotations. Making things faster. |
| 07:42:46 | *** dkayiwa has quit IRC |
| 07:44:30 | *** dkayiwa has joined #openmrs |
| 07:50:38 | *** dkayiwa has quit IRC |
| 07:57:23 | *** rafa has joined #openmrs |
| 07:57:23 | *** ChanServ sets mode: +v rafa |
| 08:04:02 | *** kavuri has joined #openmrs |
| 08:21:09 | *** kavuri has quit IRC |
| 08:37:46 | *** kavuri has joined #openmrs |
| 08:43:19 | *** alexis_ has joined #openmrs |
| 08:43:43 | *** pascal` has joined #openmrs |
| 08:43:43 | *** ChanServ sets mode: +v pascal` |
| 08:43:49 | <pascal`> Hi alexis_ |
| 08:43:56 | <alexis_> hi |
| 08:44:10 | *** ludovicrossel has joined #openmrs |
| 08:44:25 | <pascal`> Hi ludovicrossel |
| 08:44:34 | <pascal`> alexis_++ |
| 08:44:37 | <pascal`> ludovicrossel++ |
| 08:44:51 | <pascal`> !karma |
| 08:44:51 | <OpenMRSBot> pascal`: Highest karma: "bwolfe" (102), "dkayiwa" (46), and "groovy" (30). Lowest karma: "emacs" (-10), "[INFO] ----------------------------------------------------------------------" (-9), and "windows" (-8). You (pascal`) are ranked 4 out of 338. |
| 08:45:08 | <pascal`> !ticket TRUNK-2345 |
| 08:45:09 | <OpenMRSBot> pascal`: Issue Does Not Exist - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2345 |
| 08:45:16 | <pascal`> !ticket TRUNK-1245 |
| 08:45:20 | <OpenMRSBot> pascal`: [#TRUNK-1245] Create relationship between Patient Program and Patient Group - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-1245 |
| 08:48:09 | *** alexis_ has quit IRC |
| 09:13:48 | *** isharap has joined #openmrs |
| 09:18:32 | *** didymo has quit IRC |
| 09:33:12 | <finbrein> Hi rafa |
| 09:33:19 | <rafa> hi |
| 09:33:32 | <finbrein> I have checked some module controller test classes and read the following pages (https://wiki.openmrs.org/display/docs/Unit+Tests) and (https://wiki.openmrs.org/display/docs/Module+Unit+Testing) for Unit Testing and Module Unit Testing respectively. |
| 09:33:33 | <OpenMRSBot> <http://ln-s.net/90Rl> (at wiki.openmrs.org) |
| 09:33:41 | <finbrein> The @should annotation is not used in the class to be tested in Module unit testing. Usually, it used when testing the core classes. |
| 09:33:54 | <finbrein> rafa: Could you clarify?. Thanks |
| 09:34:24 | <rafa> finbrein: we use it in modules as well |
| 09:34:36 | <finbrein> rafa: ok |
| 09:41:59 | *** ludovicrossel has quit IRC |
| 10:26:40 | *** isharap has quit IRC |
| 10:57:52 | *** dileepsisila has joined #openmrs |
| 11:02:07 | <dileepsisila> +rafa: ok.......thanks......... which open mrs version is most suitable for do metadata sharing server project? |
| 11:03:36 | <dileepsisila> rafa: ok.......thanks......... which open mrs version is most suitable for do metadata sharing server project? |
| 11:04:00 | <rafa> dileepsisila: the mds server should be a separate application that only communicates with the mds module |
| 11:04:39 | <rafa> dileepsisila: the mds module needs to run on any version from 1.6+ |
| 11:04:54 | <dileepsisila> ya i got the answer |
| 11:05:25 | <dileepsisila> thanks......... |
| 11:06:16 | *** upul` has quit IRC |
| 11:08:56 | *** james_regen has joined #openmrs |
| 11:08:56 | *** ChanServ sets mode: +v james_regen |
| 11:19:27 | *** dileepsisila has quit IRC |
| 11:28:25 | *** pascal` has quit IRC |
| 11:28:52 | *** snoppy has joined #openmrs |
| 11:39:33 | *** kavuri has quit IRC |
| 11:52:58 | *** dkayiwa has joined #openmrs |
| 12:03:08 | *** bwolfe_ has joined #openmrs |
| 12:03:08 | *** ChanServ sets mode: +o bwolfe_ |
| 12:12:27 | *** androx has joined #openmrs |
| 12:18:29 | *** wyclif has quit IRC |
| 12:21:51 | *** androx has quit IRC |
| 12:22:08 | *** androx has joined #openmrs |
| 12:28:28 | *** downey has joined #openmrs |
| 12:28:28 | *** OpenMRSBot sets mode: +o downey |
| 12:28:28 | *** ChanServ sets mode: +o downey |
| 12:59:46 | *** bwolfe_ is now known as bwolfe |
| 13:00:05 | <bwolfe> dkayiwa, what were the queries you used last week to pick tickets? can you email those to me? |
| 13:00:11 | *** wyclif has joined #openmrs |
| 13:00:33 | <dkayiwa> bwolfe: you are the one who gave me the query :) |
| 13:00:45 | <dkayiwa> bwolfe: open tickets that have attachments :) |
| 13:01:11 | <bwolfe> dkayiwa, that is all? |
| 13:01:14 | <bwolfe> nothing else? |
| 13:01:29 | <dkayiwa> bwolfe: let me email you? |
| 13:04:31 | <dkayiwa> bwolfe: i changed it a bit. sent |
| 13:12:02 | <finbrein> downey: is it possible to have the "Remove Permission" for JIRA? I am asking because I like to remove the existing patches when I add a new patch. Currently, I am adding a suffix -v{n} |
| 13:20:04 | *** androx has quit IRC |
| 13:25:44 | *** cpower has joined #openmrs |
| 13:25:59 | <downey> Hi cpower and welcome to the #openmrs IRC channel. |
| 13:26:42 | <cpower> Hello, just checking to see if I could reach this on my Ipad before the scrum today |
| 13:27:14 | *** cpower has quit IRC |
| 13:33:00 | *** dawn_ has joined #openmrs |
| 13:33:06 | *** Jibesh has joined #openmrs |
| 13:33:17 | *** ChanServ sets mode: +v dawn_ |
| 13:39:27 | *** harshadura has joined #openmrs |
| 13:40:03 | *** sgithens_ has joined #openmrs |
| 13:41:52 | <finbrein> Hi downey: I asked a question earlier. Could you advise pleas. thanks. |
| 13:48:48 | *** skathol has joined #openmrs |
| 13:54:18 | *** jriley has joined #openmrs |
| 13:56:25 | *** mseaton has joined #openmrs |
| 13:56:25 | *** ChanServ sets mode: +v mseaton |
| 13:56:33 | *** mvorobey has joined #openmrs |
| 13:56:39 | <mvorobey> hi all |
| 13:57:39 | *** Mkop has joined #openmrs |
| 13:57:39 | *** ChanServ sets mode: +v Mkop |
| 13:58:19 | <dawn_> mvorobey: hi! |
| 14:00:09 | <dawn_> !scrumon dawn |
| 14:00:09 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready. |
| 14:00:19 | <dawn_> HI Team! I hope everyone had a nice weekend! |
| 14:00:53 | <bwolfe> HELLO dawn_ |
| 14:01:05 | <mvorobey> hi dawn_ :) yep, it was wonderful, but I caught a cold this weekend unfortunately :( |
| 14:01:25 | *** nadee has joined #openmrs |
| 14:01:51 | <djazayeri> hi dawn_, sunny in seattle = a good weeken |
| 14:01:53 | <djazayeri> d |
| 14:01:56 | <finbrein> dawn_: no weekend |
| 14:02:00 | *** r_friedman has joined #openmrs |
| 14:02:12 | <dawn_> Today's order: wyclif , skathol , sgithens_ , rafa , mvorobey , finbrein, dkayiwa , djazayeri , bwolfe , mseaton |
| 14:02:22 | <dawn_> If you have updates, I can't see who all is participating at the moment |
| 14:02:27 | <wyclif> Friday: |
| 14:02:28 | <wyclif> * Call with Mike, burke and lara on order entry |
| 14:02:28 | <wyclif> * Draft wiki page with the design proposal of the order entry API |
| 14:02:28 | <wyclif> * Created module project in SVN, created module project in jira |
| 14:02:28 | <wyclif> * Catch up wth emails |
| 14:02:28 | <wyclif> Monday: |
| 14:02:30 | <wyclif> * Create tickets for the sprint and dashboard |
| 14:02:32 | <wyclif> * Set up maven project for the module |
| 14:02:34 | <wyclif> * Start development work for the module |
| 14:02:36 | <wyclif> Blockers: None |
| 14:02:55 | <skathol> RESTWS-212 - ConceptResource: answerTo and memberOf searches |
| 14:02:55 | <skathol> * Unit tests are written, but don't work on H2. Ignored for now. |
| 14:02:55 | <skathol> * Complete, awaiting review |
| 14:02:55 | <skathol> RESTWS-215 - UserResource, RoleResource, PrivilegeResource support |
| 14:02:55 | <skathol> * Complete, awaiting review |
| 14:02:56 | <skathol> RESTWS-242 - UserResource create and update |
| 14:02:56 | <skathol> * Complete, awaiting review |
| 14:03:03 | <skathol> Blockers: None |
| 14:03:45 | <bwolfe> wyclif, get the module shell committed early. absolute latest is EOB today |
| 14:03:54 | <dawn_> sgithens_: any updates? |
| 14:03:55 | *** jriley has left #openmrs |
| 14:03:56 | <bwolfe> wyclif, (which means sending email to code@openmrs soon) |
| 14:03:57 | <wyclif> bwolfe, sure |
| 14:03:59 | <sgithens_> I'm not working on the current sprint. But I need to look at getting commit access so I can merge a ticket that Ben reviewed for me. Either to trunk, or at least a branch. |
| 14:04:03 | *** jriley has joined #openmrs |
| 14:04:09 | <bwolfe> !commitaccess |
| 14:04:10 | <OpenMRSBot> bwolfe: Error: "commitaccess" is not a valid command. |
| 14:04:21 | <dawn_> sgithens_: we can bring that up at the end of the scrum :) |
| 14:04:22 | <bwolfe> !svnaccess |
| 14:04:22 | <OpenMRSBot> bwolfe: "svnaccess" --- http://openmrs.org/wiki/Developers#Requesting_Subversion_Repository_Access |
| 14:04:28 | <dawn_> rafa: your turn :) |
| 14:04:31 | <rafa> Friday/Weekend: |
| 14:04:31 | <rafa> * Fixed the jsslab module build |
| 14:04:31 | <rafa> * Committed: |
| 14:04:31 | <rafa> + RESTWS-224: ResourceDocCreator should generate documentation for POST content |
| 14:04:31 | <rafa> https://tickets.openmrs.org/browse/RESTWS-224 |
| 14:04:31 | <bwolfe> sgithens_ ^^ |
| 14:04:31 | <rafa> + RESTWS-241: Define creatable/updatable properties on Person, PersonAddress, and PersonName resources |
| 14:04:32 | <rafa> https://tickets.openmrs.org/browse/RESTWS-241 |
| 14:04:33 | <rafa> + RESTWS-227: Define creatable/updatable properties on Cohort and CohortMember resources |
| 14:04:33 | <rafa> https://tickets.openmrs.org/browse/RESTWS-227 |
| 14:04:34 | <rafa> + RESTWS-235: Define creatable/updatable properties on HL7Message resource |
| 14:04:34 | <rafa> https://tickets.openmrs.org/browse/RESTWS-235 |
| 14:04:35 | <rafa> + RESTWS-237: Define creatable/updatable properties on Location resource |
| 14:04:35 | <rafa> https://tickets.openmrs.org/browse/RESTWS-237 |
| 14:04:36 | <rafa> Today: |
| 14:04:36 | <rafa> * Fixed per review: RESTWS-226: Resources need to specify what fields are editable, not blindly expose all delegate properties |
| 14:04:37 | <rafa> https://tickets.openmrs.org/browse/RESTWS-226 |
| 14:04:37 | <rafa> * Committed: |
| 14:04:38 | <rafa> + RESTWS-240: Define creatable/updatable properties on Patient and PatientIdentifier resources |
| 14:04:38 | <rafa> https://tickets.openmrs.org/browse/RESTWS-240 |
| 14:04:39 | <rafa> * Started with: RESTWS-202: Implement support for forms |
| 14:04:39 | <rafa> https://tickets.openmrs.org/browse/RESTWS-202 |
| 14:04:40 | <rafa> No blockers. |
| 14:04:44 | <mvorobey> * Work in progress - https://tickets.openmrs.org/browse/ATLAS-33 |
| 14:04:44 | <mvorobey> * Tried to investigate https://tickets.openmrs.org/browse/ATLAS-36 |
| 14:04:44 | <mvorobey> * Gonna pick the next ticket from Atlas Dashboard |
| 14:04:44 | <mvorobey> * No blockers |
| 14:04:57 | <finbrein> RESTWS-239 for review |
| 14:04:57 | <finbrein> RESTWS-232 & RESTWS-238, need to make some changes |
| 14:04:57 | <finbrein> -- end -- |
| 14:04:59 | <sgithens_> bwolfe: cheers |
| 14:05:07 | <bwolfe> skathol, your blocker is "waiting on reviews". :-) |
| 14:05:24 | <bwolfe> r_friedman, see rafa's jsslab comment? :-) |
| 14:05:52 | <dawn_> dkayiwa: your turn :) |
| 14:06:02 | <r_friedman> bwolfe: where? |
| 14:06:03 | <bwolfe> rafa, discussion point: RESTWS finishing thoughts? 1ish more day before an RC? |
| 14:06:09 | <dkayiwa> Reviewed and applied patch for: default error handler should try to record what user generated error in log - TRUNK-2509 |
| 14:06:09 | <dkayiwa> Reviewed and applied patch for: Allow modules to define strongly-typed global properties - TRUNK-2732 |
| 14:06:10 | <dkayiwa> Reviewed and applied patch for: Patient.getActiveIdentifiers() should always put the preferred identifier at the top of the list - TRUNK-2188 |
| 14:06:10 | <dkayiwa> Reviewed and applied patch for: Handle form UUIDs in HL7 processing - TRUNK-3288 |
| 14:06:10 | <dkayiwa> Reviewed and rejected: Errors when running ContextWithModuleTest - TRUNK-2543 |
| 14:06:10 | <dkayiwa> Failed to cleanly apply: java.lang.NullPointerException when navigating to /admin/concepts/conceptDrug.form - TRUNK-1850 |
| 14:06:11 | <dkayiwa> Now reviewing: Errors and exceptions when running HL7ServiceTest - TRUNK-2552 |
| 14:07:13 | <dawn_> djazayeri: your turn :) |
| 14:07:29 | <djazayeri> Friday 20-Apr-2012 |
| 14:07:29 | <djazayeri> * reviews for sprint tickets |
| 14:07:29 | <djazayeri> * started refactoring and addressing review comments on RESTWS-243 - Support for resource-per-class-hierarchy |
| 14:07:29 | <djazayeri> * talked with Andy and Jan about MVP dictionary |
| 14:07:29 | <djazayeri> Monday 23-Apr-2012 |
| 14:07:29 | <djazayeri> * review RESTWS tickets |
| 14:07:30 | <djazayeri> * finish RESTWS-243 - Support for resource-per-class-hierarchy |
| 14:07:30 | <djazayeri> * (design discussions on that ticket) |
| 14:07:46 | <djazayeri> blockers: need to finish design discussions about RESTWS-243 |
| 14:08:09 | <dawn_> bwolfe: your turn :) |
| 14:08:09 | <bwolfe> !ticket RESTWS-243 |
| 14:08:10 | <OpenMRSBot> bwolfe: [#RESTWS-243] Implement framework code to support for Resource-per-class-hierarchy approach to hiding inheritance - OpenMRS JIRA - https://tickets.openmrs.org/browse/RESTWS-243 |
| 14:08:40 | <bwolfe> Friday |
| 14:08:40 | <bwolfe> emails |
| 14:08:40 | <bwolfe> reviewed Darius' ws commit |
| 14:08:40 | <bwolfe> atom feed module work |
| 14:08:40 | <bwolfe> design call setup |
| 14:08:41 | <bwolfe> sprint schedule review |
| 14:08:43 | <bwolfe> triaged RCM-80 |
| 14:08:45 | <bwolfe> triage more tickets |
| 14:08:47 | <bwolfe> Monday |
| 14:08:49 | <bwolfe> triaged 4 tickets |
| 14:08:51 | <bwolfe> emails to professors about projects |
| 14:08:53 | <bwolfe> call with prof about project |
| 14:08:55 | <bwolfe> rg meeting |
| 14:08:59 | <bwolfe> new dev interview |
| 14:09:01 | <bwolfe> event/atomfeed tickets |
| 14:09:03 | <bwolfe> bug fixing dashboard setup |
| 14:09:17 | <bwolfe> (no blockers yet) |
| 14:09:33 | <dawn_> mseaton: your turn :) |
| 14:09:40 | <mseaton> Friday: |
| 14:09:47 | <mseaton> order entry design call |
| 14:09:49 | <mseaton> pih stuff |
| 14:09:52 | <mseaton> Today: |
| 14:09:56 | *** bryq has joined #openmrs |
| 14:09:56 | *** ChanServ sets mode: +v bryq |
| 14:10:00 | <mseaton> order entry design / tickets |
| 14:10:04 | <mseaton> pih stuff some more |
| 14:10:07 | <mseaton> no blockers |
| 14:10:13 | <djazayeri> @Everyone, bwolfe is this week's bug-fixer, and you should point people who want guidance about contributing this week to him. |
| 14:10:31 | <bwolfe> mseaton, who authorized this "pih stuff" ?! :-p |
| 14:11:15 | <dawn_> !scrumoff dawn |
| 14:11:15 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 14:11:17 | <dawn_> Discussion Points: 1) djazayeri : updates on RESTWS sprint (what's left and when can we finish it?), 2) dkayiwa : 1.9RC3 updates 3) darius' blocker: finish design discussions on RESTWS-243 |
| 14:12:07 | <djazayeri> Regarding the RESTWS sprint, there are no remaining available tickets (great!) and 12 tickets in needs-review. Thanks people for doing that over the weekend! |
| 14:12:49 | <djazayeri> There are still 8 in-progress. finbrein, suranga, r_friedman, skathol, rafa: what's your ETA on those? |
| 14:13:05 | <dawn_> djazayeri: i see 1 "should" |
| 14:13:11 | <r_friedman> RESTWS-178 Patch submitted |
| 14:13:21 | <r_friedman> RESTWS-219 Research complete, needs review as to next steps |
| 14:13:23 | <djazayeri> dawn_: ben marked that as 1.0, but it should be 1.1 |
| 14:13:25 | <finbrein> djazayeri: ETA ?!? |
| 14:13:35 | <djazayeri> ETA = Estimated Time of Arrival. |
| 14:13:49 | <r_friedman> creation of Order objects probably already done/to be done as part of demo |
| 14:13:53 | <dawn_> djazayeri: okay |
| 14:13:54 | <rafa> djazayeri: I'll complete RESTWS-202 today |
| 14:14:28 | <skathol> djazayeri: My in progress ticket should have been in review - just updated it. |
| 14:14:36 | <djazayeri> skathol: great, thanks! |
| 14:14:56 | <rafa> r_friedman: can you do the same for RESTWS-219? |
| 14:14:56 | <djazayeri> finbrein: you claimed RESTWS-238 on Friday nightâwill you be able to do that one today? |
| 14:14:58 | <finbrein> djazayeri: got it! I'll take one of those 8 |
| 14:15:01 | <rafa> r_friedman: is it ready for review? |
| 14:15:14 | <finbrein> djazayeri: yes |
| 14:15:26 | <finbrein> ;) |
| 14:15:27 | <djazayeri> finbrein: great |
| 14:15:31 | <r_friedman> rafa, 219 is only investigate, we have to decide what to do now we know the answer |
| 14:16:05 | <djazayeri> r_friedman: I'll look at that after this post-scrum discussion |
| 14:16:20 | <r_friedman> ok |
| 14:17:25 | <djazayeri> So, dawn_, I believe people will mostly be finishing those tickets up today. |
| 14:18:02 | <dawn_> djazayeri: sounds good! |
| 14:18:08 | <r_friedman> djazayeri: how many RESTWS tickets that should be done remain unworked? |
| 14:18:11 | <djazayeri> dawn_: roger and I have an ongoing design discussion which we also need to resolve |
| 14:18:15 | <rafa> djazayeri: I believe RESTWS-199 is covered by RESTWS-266 |
| 14:18:32 | <djazayeri> r_friedman: 7 are in-progress, 13 in needs-review |
| 14:18:54 | <r_friedman> djazayeri: so no burning need to pick up more tickets? |
| 14:19:04 | <djazayeri> r_friedman: correct, not on RESTWS |
| 14:19:17 | <djazayeri> r_friedman: unless you want to look at fixVersion 1.1 tickets. |
| 14:19:34 | <r_friedman> djazayeri: yes, you tend to put off those of concern to me :-)) |
| 14:19:39 | <dawn_> djazayeri: design discussion around REST-243, yes? |
| 14:19:50 | <djazayeri> yes |
| 14:20:23 | <r_friedman> now? |
| 14:20:36 | <bwolfe> lets redesign it a few more times... |
| 14:20:44 | <rafa> :D |
| 14:20:55 | <djazayeri> not this instant, let's go through the lighter discussion topics first |
| 14:21:26 | <r_friedman> rafa: bwolfe said you had a comment on jsslab, where is it? |
| 14:21:32 | <bwolfe> r_friedman, quick question on it: what does ?!t mean ?? |
| 14:21:42 | <bwolfe> r_friedman, its about 500 lines that way ^^ |
| 14:21:43 | <dawn_> dkayiwa: where do we stand with 1.9RC3? |
| 14:21:48 | <dkayiwa> As for 1.9 Updates, I have not had any testing response from PIH. Ampath - waiting for a response about how their testing. |
| 14:22:00 | <bwolfe> oy |
| 14:22:01 | <r_friedman> bwolfe: when i had my back turned !! |
| 14:22:13 | <rafa> r_friedman: I meant that it's fixed, did you try it? |
| 14:22:40 | <r_friedman> rafa, yes, it's great, I really appreciate it ... it was above and beyond to fix the interface changes |
| 14:23:03 | <rafa> r_friedman: ok |
| 14:23:06 | <dawn_> dkayiwa: can we ping PIH and AMPATH again and see what the testing outcomes were or was that already done? |
| 14:23:20 | <dkayiwa> dawn_: ok let me do that now |
| 14:23:59 | <dawn_> dkayiwa: thanks |
| 14:24:07 | <dkayiwa> :) |
| 14:24:14 | <dawn_> dkayiwa: are there any other issues other than not hearing back about testing? |
| 14:24:25 | <dkayiwa> dawn_: NONE :) |
| 14:25:27 | <dawn_> dkayiwa: sounds good :) hopefully they will respond so we can be finished |
| 14:25:44 | <dkayiwa> dawn_: i can give them a response deadline :) |
| 14:26:18 | <dawn_> dkayiwa: great! make it as soon as possible :D |
| 14:26:42 | <dkayiwa> dawn_: will tell them this week is the deadline :) |
| 14:26:49 | <dawn_> dkayiwa: Tuesday maybe. I think that puts it well over a week for testing |
| 14:27:02 | <dawn_> dkayiwa: end of the day Tuesday |
| 14:27:06 | <dkayiwa> dawn_: ok |
| 14:27:10 | <dawn_> :) |
| 14:27:15 | <dkayiwa> :D |
| 14:27:29 | <dawn_> djazayeri: and r_friedman : last discussion point is your design. go for it |
| 14:27:39 | <r_friedman> everybody's pretty f*ing smiley for monday morning |
| 14:27:44 | <dawn_> before i forget: mvorobey: hope you are feeling better! finbrein : make sure you take a break since you didn't this weekend. :) |
| 14:28:01 | <dawn_> r_friedman: join the club, man :P |
| 14:28:23 | *** nadee1 has joined #openmrs |
| 14:28:25 | <bwolfe> r_friedman, dawn_ and dkayiwa are always smiley regardless of the day of the week |
| 14:28:34 | <downey> Hi nadee1 and welcome to the #openmrs IRC channel. |
| 14:28:45 | <dawn_> for once, bwolfe is right: :D |
| 14:28:47 | <dkayiwa> bwolfe: d:) |
| 14:28:58 | <bwolfe> Q.E.D. |
| 14:29:00 | <dawn_> hahaha!!! :D |
| 14:29:13 | <djazayeri> Well, r_friedman sent a long email to the dev list about subclasses which I still have to read before I can really have the discussion... |
| 14:29:16 | <mvorobey> dawn_, thanks, I'm feeling much better :) |
| 14:29:19 | <r_friedman> best we can get out of bwolfe is :-/ |
| 14:29:37 | *** nadee1 has left #openmrs |
| 14:29:55 | *** nadee has quit IRC |
| 14:29:58 | <bwolfe> r_friedman, better than >:O |
| 14:30:01 | <dawn_> r_friedman: +1 hahahaha!! |
| 14:30:07 | <bwolfe> dawn_, :-/ |
| 14:30:49 | <bwolfe> dkayiwa, be sure to be explicit to ampath about how to test it. I don't think they were using the RTH module |
| 14:31:20 | <dkayiwa> bwolfe: ok |
| 14:31:53 | <bwolfe> dkayiwa, you could also send an email to the implementers again asking to either 1) test it using RTH and here are the 1,2,3 steps or 2) ask them to report back about successes/failures with updating because we have a requirement ot hear from 2 implementations before moving from RC to release (and link to release process page section that has that info) |
| 14:32:07 | <r_friedman> brb |
| 14:32:25 | <dkayiwa> bwolfe: ok |
| 14:35:18 | *** lh has joined #openmrs |
| 14:37:58 | *** skathol has quit IRC |
| 14:38:39 | *** bwolfe has quit IRC |
| 14:42:08 | <r_friedman> downey: what's the EDT release time? |
| 14:48:04 | <downey> r_friedman: 19:00 UTC = 3pm EDT :) http://go.openmrs.org/time |
| 14:48:21 | <r_friedman> downey: tks |
| 14:49:02 | *** gauravpaliwal has joined #openmrs |
| 14:49:02 | *** ChanServ sets mode: +v gauravpaliwal |
| 14:49:08 | <r_friedman> downey: is the acceptance page still available to mentors? |
| 14:49:55 | <r_friedman> or is the melange site current? |
| 14:50:02 | <downey> r_friedman: i'm in the process of moving everything over for this afternoon right now in fact so melange is your canonical source of info |
| 14:50:17 | <r_friedman> tks |
| 14:52:47 | <r_friedman> djazayeri: you want to postpone to a time certain? |
| 14:53:54 | <r_friedman> djazayeri: i am unavailable from about 11:30 to about 3 |
| 14:56:58 | *** jriley has left #openmrs |
| 14:57:15 | *** jriley has joined #openmrs |
| 14:58:06 | <wyclif> djazayeri, order entry module should require 1.9, right? |
| 14:59:14 | <djazayeri> r_friedman: you want to talk at 3pm eastern? |
| 14:59:36 | <wyclif> mseaton, , order entry module should require 1.9, right? |
| 14:59:38 | <djazayeri> wyclif: is there a reason it can't work in 1.8? |
| 14:59:51 | <wyclif> djazayeri, dont think so |
| 14:59:56 | <wyclif> probably 1.7 too |
| 14:59:57 | <r_friedman> djazayeri: ok, i can't promise it will be exactly 3, depends onthe doctor |
| 15:00:09 | <djazayeri> r_friedman: okay, well, you know where I'll be. |
| 15:00:22 | <r_friedman> djazayeri: maybe you can have looked at 219 also |
| 15:00:23 | <wyclif> djazayeri, am trying to find out from mseaton |
| 15:00:55 | <mseaton> wyclif: we should target the earliest possible release, without adding undue work. |
| 15:01:00 | <djazayeri> wyclif: one question is whether any of the order fields refer to the new provider tables |
| 15:01:17 | <mseaton> if there is something in 1.9 that isn't in 1.8 that you need, then make it 1.9 dependent |
| 15:01:18 | *** pascal` has joined #openmrs |
| 15:01:18 | *** ChanServ sets mode: +v pascal` |
| 15:01:24 | <pascal`> Hi |
| 15:01:31 | <mseaton> otherwise, make it 1.8 dependent (or 1.7) |
| 15:01:33 | <wyclif> none that am aware of |
| 15:01:40 | <djazayeri> wyclif: assuming that order will have some fields that reference provider, then we should require 1.9. If not, make it 1.8/1.7 |
| 15:01:48 | <djazayeri> hi pascal` |
| 15:01:55 | <pascal`> Hey djazayeri |
| 15:02:20 | <wyclif> djazayeri, mseaton ,from the design i proposed, there are no reference to providers |
| 15:02:34 | *** Jibesh has left #openmrs |
| 15:02:59 | <wyclif> djazayeri, mseaton did you guys see the proposed design wiki page? |
| 15:03:13 | <djazayeri> wyclif: are any references to providers expected to be added in the future? |
| 15:03:16 | <djazayeri> wyclif: link? |
| 15:03:18 | <mseaton> wyclif: in general with module development, you should aim for the earliest supportable release |
| 15:04:33 | <djazayeri> wyclif: what is "User orderer"? How does this differ from OpenmrsData.creator? |
| 15:04:44 | <mseaton> wyclif: i haven't looked at it in detail yet. will do soon |
| 15:05:05 | <mseaton> shouldn't "orderer" actually be a provider? |
| 15:06:55 | <wyclif> djazayeri, probably user should be a provider |
| 15:07:06 | <wyclif> since orders are associated to encounters |
| 15:07:49 | <djazayeri> wyclif: I guess the question is whether we should be recording the "orderer" directly on order, or saying that all orders in an encounter are ordered by the encounter's provider(s) |
| 15:07:49 | <wyclif> djazayeri, apparently we wanted to get rid of users, encounter is required so we can get rid orderer and use the encounter provider |
| 15:08:01 | <wyclif> djazayeri, that is what am trying to say |
| 15:08:10 | <djazayeri> wyclif: that said, I don't know if that's good enough because encounter can have multiple providers. |
| 15:08:34 | <djazayeri> wyclif: I'm not an expert on order entry use cases... |
| 15:08:44 | <wyclif> djazayeri, will talk to burke |
| 15:10:08 | *** suranga has joined #openmrs |
| 15:10:08 | *** ChanServ sets mode: +v suranga |
| 15:10:58 | <suranga> hi downey gauravpaliwal , just to say that I mailed my article to linux for you at last :-) |
| 15:11:30 | <downey> congrats suranga |
| 15:13:40 | <suranga> downey, I didnt say that they accepted it yet :-) |
| 15:15:38 | <suranga> mm.. hi djazayeri .. regarding (long overdue) https://tickets.openmrs.org/browse/RESTWS-220 |
| 15:22:42 | *** lugaid13 has joined #openmrs |
| 15:22:53 | <downey> Hi lugaid13 and welcome to the #openmrs IRC channel. |
| 15:23:09 | <lugaid13> Hi! |
| 15:23:18 | <djazayeri> suranga: yes? |
| 15:23:45 | <lugaid13> I have the same problem as described here https://answers.openmrs.org/questions/324/the-following-modules-are-marked-as-core-by-openmrs-but-were-unable-to-start-logic-v05?page=1#583 |
| 15:23:58 | <lugaid13> The question has a lot of views, but no answers |
| 15:24:16 | <suranga> djazayeri, umm.. ok, I did the change u suggested, but it causes a test case to fail. I've been wrestling with this for a while, but am not very clear on how to solve this... |
| 15:24:24 | <suranga> (hence the delay) |
| 15:24:44 | <djazayeri> suranga: okay, for what it's worth, in a situation like that please comment on the ticket or mention it during the scrum |
| 15:25:10 | <suranga> djazayeri, sorry, will do... |
| 15:25:33 | <suranga> djazayeri, umm.. in this case, the test is failing because java.lang.ClassCastException: org.openmrs.Encounter cannot be cast to org.openmrs.module.webservices.rest.SimpleObject |
| 15:25:48 | <suranga> I cant figure out why / what causes this to break :( |
| 15:26:05 | <pascal`> Hey downey, what did uou do with downeym? |
| 15:26:14 | <djazayeri> suranga: that's if you add one line for valueCodedName? |
| 15:26:39 | <suranga> djazayeri, yes :( |
| 15:27:03 | <suranga> pascal`, he underwent a name change a while back :) |
| 15:27:24 | <pascal`> !seen downeym |
| 15:27:24 | <OpenMRSBot> pascal`: downeym was last seen in #openmrs 9 weeks, 3 days, 19 hours, 15 minutes, and 0 seconds ago: <downeym> Hi downey and welcome to the #openmrs IRC channel. |
| 15:29:16 | <djazayeri> suranga: stack trace via pastebin? |
| 15:29:26 | <djazayeri> suranga: also, are you using the latest code? |
| 15:29:49 | *** pascal` has quit IRC |
| 15:32:13 | <suranga> djazayeri, i will re check everything before pastebin ing |
| 15:33:34 | *** suranga_ has joined #openmrs |
| 15:36:43 | *** suranga has quit IRC |
| 15:38:23 | <suranga_> djazayeri, http://pastebin.com/biqFTxxa :-( |
| 15:41:40 | <djazayeri> suranga_: what's the one-line change you've made that causes that error? |
| 15:43:31 | <r_friedman> downey: did Anatomical Drawing get a slot? |
| 15:45:51 | *** rafa has quit IRC |
| 15:46:43 | <suranga_> djazayeri, for ObsResource, I added description.addProperty("obsCodedName", findMethod("getConceptName")); for the two representations |
| 15:47:07 | <suranga_> djazayeri, however, I also needed to add if (delegate instanceof Obs) { |
| 15:47:08 | <suranga_> Obs o = (Obs) delegate; |
| 15:47:08 | <suranga_> if (o.getValueCodedName() != null) |
| 15:47:08 | <suranga_> description.addProperty("obsCodedName"); |
| 15:47:08 | <suranga_> } |
| 15:47:31 | <suranga_> to DataDelegatingCrudResource because it was asking for it (test case failiure) |
| 15:47:52 | *** hemanth_92 has joined #openmrs |
| 15:48:23 | <djazayeri> suranga_: first off, I'd say to just call it "valueCodedName", like the underlying property name |
| 15:48:36 | <djazayeri> suranga_: you should not need to specify findMethod. |
| 15:49:20 | <djazayeri> and you definitely shouldn' t make changes to DataDelegatingCrudResource while doing this |
| 15:49:37 | <djazayeri> (if things break that require it, it's probably a sign of something else we did wrong) |
| 15:51:02 | *** hemanth_92 has quit IRC |
| 15:52:23 | *** isharapremadasa has joined #openmrs |
| 15:52:48 | *** isharapremadasa is now known as isharap |
| 15:55:25 | <r_friedman> wyclif: mseaton djazayeri re Orderer, this is the provider who ordered the order. Different from creator unless doing direct entry. Not needed if there are no encounterless orders, but until there are conditional orders, the occurrence of the condition might cause an order without an encounter. |
| 15:57:00 | *** dawn__ has joined #openmrs |
| 15:57:01 | *** dawn_ has quit IRC |
| 15:57:01 | *** dawn__ is now known as dawn_ |
| 15:57:01 | *** ChanServ sets mode: +v dawn_ |
| 15:59:49 | <r_friedman> wyclif: mseaton djazayeri : also prescription refills can be encounterless unless you want to have a special encounter type for them |
| 16:00:34 | <djazayeri> hmm, okay |
| 16:02:13 | *** pulasthi7 has joined #openmrs |
| 16:03:08 | *** dawn_ has quit IRC |
| 16:04:05 | <mseaton> hi wyclif |
| 16:04:25 | *** sgithens_ has quit IRC |
| 16:06:26 | <wyclif> hi mseaton |
| 16:08:52 | <wyclif> mseaton, ? |
| 16:09:08 | <mseaton> hi wyclif, sorry. decided to comment on the wiki page. stay tuned. |
| 16:09:43 | <wyclif> mseaton, ok |
| 16:11:16 | <gauravpaliwal> suranga_: thanks :) |
| 16:13:32 | <gauravpaliwal> hopefully linux for you will come up with awesome openmrs article soon !! |
| 16:14:54 | *** r_friedman has quit IRC |
| 16:14:58 | *** dkayiwa_ has joined #openmrs |
| 16:15:55 | <finbrein> djazayeri: Please take a look when you have a free time and let me know if it is good - http://bit.ly/I52sQc |
| 16:16:15 | *** aman_ has joined #openmrs |
| 16:16:24 | <downey> Hi aman_ and welcome to the #openmrs IRC channel. |
| 16:16:33 | <aman_> hi |
| 16:16:43 | <djazayeri> finbrein: looking at it now, and note that you don't need to use an url shortener when pasting links to tickets |
| 16:17:03 | <djazayeri> finbrein: in fact I prefer you don't. :-) |
| 16:17:04 | <aman_> i missed GSOC this year, how many students did open mrs get this time ? |
| 16:17:26 | *** dkayiwa has quit IRC |
| 16:17:26 | *** dkayiwa_ is now known as dkayiwa |
| 16:17:50 | <finbrein> power working djazayeri: ;) |
| 16:18:27 | <djazayeri> finbrein: I was already looking at your ticket comment (email notification) but I can't tell if bit.ly/... is the same thing without clicking. :-) |
| 16:19:13 | <finbrein> djazayeri: https://tickets.openmrs.org/browse/RESTWS-238?focusedCommentId=184853&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-184853 |
| 16:19:18 | <downey> aman_: It will be announced at 19:00 UTC :) |
| 16:19:26 | <aman_> ok |
| 16:19:29 | *** downey is now known as downey|away |
| 16:19:30 | *** aman_ has left #openmrs |
| 16:20:29 | *** gauravpaliwal has quit IRC |
| 16:20:52 | <djazayeri> finbrein: commented on ticket. There are some fields you're missing (which I got from looking at Obs.java) |
| 16:21:05 | <finbrein> ok |
| 16:28:27 | <finbrein> djazayeri: one more thing: there are unit tests already in the controller test classes for creatable and updatable. So no need to add test cases this time. |
| 16:29:22 | <djazayeri> finbrein: okay; if those existing tests are too simple, or don't cover enough, you can consider adding another, but I guess that's optional. |
| 16:32:07 | *** nribeka has joined #openmrs |
| 16:32:07 | *** ChanServ sets mode: +v nribeka |
| 16:37:26 | <nribeka> hi all. i ran into this exception. anyone knows what could cause this? http://pastebin.com/yF9E9pWD |
| 16:39:13 | <mseaton> nribeka: what version of omrs / tomcat? |
| 16:48:29 | *** nadee has joined #openmrs |
| 16:50:21 | <nribeka> oopps i forgot asking that important question. will get back to you later mike :) |
| 16:56:59 | *** MarkG has joined #openmrs |
| 16:57:27 | *** dkayiwa has quit IRC |
| 16:58:34 | *** dawn_ has joined #openmrs |
| 16:58:34 | *** ChanServ sets mode: +v dawn_ |
| 17:02:41 | *** snoppy has quit IRC |
| 17:02:58 | *** dawn_ has quit IRC |
| 17:07:18 | *** dkayiwa has joined #openmrs |
| 17:07:33 | *** nribeka has quit IRC |
| 17:08:03 | *** sgithens_ has joined #openmrs |
| 17:15:51 | *** nadee has quit IRC |
| 17:19:19 | *** dawn_ has joined #openmrs |
| 17:19:19 | *** ChanServ sets mode: +v dawn_ |
| 17:21:50 | *** dawn_ has quit IRC |
| 17:22:18 | *** lugaid13 has quit IRC |
| 17:25:30 | *** dawn_ has joined #openmrs |
| 17:25:30 | *** ChanServ sets mode: +v dawn_ |
| 17:26:00 | *** dawn_ has quit IRC |
| 17:26:03 | *** Rahul_ has joined #openmrs |
| 17:37:33 | *** Rahul_ has left #openmrs |
| 17:42:00 | *** dawn_ has joined #openmrs |
| 17:42:00 | *** ChanServ sets mode: +v dawn_ |
| 17:43:18 | *** dawn_ has quit IRC |
| 17:45:43 | *** rafa has joined #openmrs |
| 17:45:43 | *** ChanServ sets mode: +v rafa |
| 17:46:03 | *** jriley has left #openmrs |
| 17:51:06 | *** snoppy has joined #openmrs |
| 17:55:23 | *** deepaganu has joined #openmrs |
| 17:55:33 | <downey|away> Hi deepaganu and welcome to the #openmrs IRC channel. |
| 17:56:05 | <djazayeri> dkayiwa: I've noticed a few "how did you create this patch" comments... |
| 17:56:19 | <dkayiwa> djazayeri: yes |
| 17:56:29 | <dkayiwa> djazayeri: any suggestions? |
| 17:56:30 | <djazayeri> dkayiwa: on TRUNK-2019, the patch is over 1 year old |
| 17:56:47 | <dkayiwa> djazayeri: ok |
| 17:57:05 | <djazayeri> dkayiwa: which is bad on our part, so I think that you should see whether manually applying it is feasible |
| 17:57:23 | <dkayiwa> djazayeri: ok |
| 17:57:45 | <djazayeri> i.e. if we've let a patch wait that long, we should try extra to apply it before going back to its author. :-) |
| 17:57:59 | <dkayiwa> djazayeri: ok :) |
| 18:03:21 | *** deepaganu has quit IRC |
| 18:05:30 | *** suranga_ has quit IRC |
| 18:06:03 | *** nribeka has joined #openmrs |
| 18:06:03 | *** ChanServ sets mode: +v nribeka |
| 18:06:24 | *** snoppy has left #openmrs |
| 18:11:00 | *** sgithens_ has quit IRC |
| 18:11:29 | *** bwolfe has joined #openmrs |
| 18:11:29 | *** ChanServ sets mode: +o bwolfe |
| 18:15:35 | *** nribeka has quit IRC |
| 18:18:42 | <wyclif> hi mseaton |
| 18:20:01 | <wyclif> mseaton, i assume the module should separate tables from those in core and then we will have to add scripts to copy over the existing data, right? |
| 18:20:22 | <wyclif> mseaton, use separate tables |
| 18:26:35 | *** sgithens_ has joined #openmrs |
| 18:27:48 | *** nribeka has joined #openmrs |
| 18:27:48 | *** ChanServ sets mode: +v nribeka |
| 18:31:05 | *** suranga_ has joined #openmrs |
| 18:33:20 | *** nribeka has quit IRC |
| 18:34:11 | *** isharap has quit IRC |
| 18:40:50 | *** MarkG1 has joined #openmrs |
| 18:42:31 | *** bwolfe has quit IRC |
| 18:43:19 | *** MarkG has quit IRC |
| 18:43:56 | <djazayeri> suranga_: btw, you forgot to click Request Code Review on that patch |
| 18:44:00 | <djazayeri> (I did it) |
| 18:44:52 | *** suranga__ has joined #openmrs |
| 18:46:24 | *** suranga_ has quit IRC |
| 18:48:53 | *** nribeka has joined #openmrs |
| 18:48:53 | *** ChanServ sets mode: +v nribeka |
| 18:58:37 | *** maurya has joined #openmrs |
| 18:59:11 | *** dawn_ has joined #openmrs |
| 18:59:11 | *** ChanServ sets mode: +v dawn_ |
| 19:01:43 | *** mseaton has left #openmrs |
| 19:03:49 | *** r_friedman has joined #openmrs |
| 19:04:14 | *** hemanth_92 has joined #openmrs |
| 19:04:47 | <r_friedman> hey hemanth |
| 19:04:53 | <hemanth_92> yes |
| 19:05:02 | <r_friedman> have you heard anything? |
| 19:05:07 | <hemanth_92> sorry i was absent |
| 19:05:15 | <hemanth_92> i had and still having exams |
| 19:05:16 | <hemanth_92> nope |
| 19:05:16 | <r_friedman> i mean by e-mail |
| 19:05:21 | <hemanth_92> none |
| 19:05:44 | <r_friedman> ok, it's supposed to be happening now |
| 19:05:48 | <hemanth_92> okay |
| 19:06:02 | <hemanth_92> i think google's server's fried right now |
| 19:06:11 | <r_friedman> hehe |
| 19:07:03 | <hemanth_92> this is nerve wracking! |
| 19:07:17 | <r_friedman> can't be worse then exams :-) |
| 19:09:29 | <r_friedman> djazayeri: you want to get it on? |
| 19:10:06 | <djazayeri> r_friedman: let me go grab a sandwichâI will need sustenance for this design discussion |
| 19:10:19 | <r_friedman> go for it, darius |
| 19:10:36 | <downey|away> sandwiches++ |
| 19:10:55 | <r_friedman> !sandwich downey |
| 19:10:56 | <OpenMRSBot> r_friedman: Error: "sandwich" is not a valid command. |
| 19:11:04 | <djazayeri> r_friedman: would you mind, either as a reply to burke's dev list email, or in an etherpad, providing the specific examples for superclass/subclass? |
| 19:11:12 | *** djazayeri is now known as djazayeri|gettin |
| 19:11:16 | <r_friedman> downey, I thought you had that ticket |
| 19:11:21 | *** djazayeri|gettin is now known as djazayeri|away |
| 19:11:32 | <downey|away> !beerme r_friedman |
| 19:11:32 | * OpenMRSBot slides r_friedman a pint |
| 19:12:35 | *** isharapremadasa has joined #openmrs |
| 19:15:02 | *** downey|away has quit IRC |
| 19:15:10 | *** downey has joined #openmrs |
| 19:15:10 | *** ChanServ sets mode: +o downey |
| 19:15:10 | *** OpenMRSBot sets mode: +o downey |
| 19:17:51 | *** dkayiwa_ has joined #openmrs |
| 19:18:41 | *** dileepsisila has joined #openmrs |
| 19:19:12 | *** dkayiwa has quit IRC |
| 19:19:13 | *** dkayiwa_ is now known as dkayiwa |
| 19:22:04 | <suranga__> looks like google servers r down :-) |
| 19:22:16 | <downey> suranga__: Patience. :) |
| 19:22:36 | <downey> suranga__: http://goo.gl/KGKn2 |
| 19:23:13 | <suranga__> downey, I see :D |
| 19:23:28 | <suranga__> looks like the students have fried the server |
| 19:24:15 | <downey> suranga__: vertical axis is queries per second |
| 19:24:46 | *** MarkG has joined #openmrs |
| 19:24:52 | <djazayeri|away> r_friedman: can you prep/frame our discussion by , either as a reply to burke's dev list email, or in an etherpad, providing the specific examples for superclass/subclass? |
| 19:25:54 | <r_friedman> djazayeri|away: am doing, had to deal with stupid remote e-mail |
| 19:26:12 | *** djazayeri|away is now known as djazayeri |
| 19:26:12 | <r_friedman> also not stupid wife |
| 19:27:10 | <djazayeri> ok |
| 19:27:56 | *** MarkG1 has quit IRC |
| 19:28:04 | <r_friedman> djazayeri: http://notes.openmrs.org/subclass-design |
| 19:28:32 | *** kavuri has joined #openmrs |
| 19:29:04 | *** dileepsisila has quit IRC |
| 19:29:30 | <kavuri> Hi djazayeri, got a question about authentication using apache http auth library with openmrs and in android |
| 19:30:41 | <kavuri> djazayeri: in a standalone client using apache http client library I am able to authenticate to openmrs |
| 19:30:56 | <kavuri> djazayeri: but in android, I always get authenticated as false |
| 19:31:08 | *** riomus has joined #openmrs |
| 19:31:22 | <kavuri> any experience with this kind of problems or if seen that someone had similar issues? |
| 19:31:32 | <riomus> hi all |
| 19:31:34 | <riomus> i'm here to ask about gsoc |
| 19:32:10 | <riomus> did openmrs get some students?? because on gsoc accepted students proposal thery is nothing for openmrs |
| 19:32:33 | <downey> riomus: The list at http://www.google-melange.com/gsoc/projects/list/google/gsoc2012 is still being updated, it's taking longer than planned. |
| 19:33:04 | <riomus> do you know who have been accepted for openmrs?? |
| 19:33:32 | *** dkayiwa_ has joined #openmrs |
| 19:34:09 | <djazayeri> kavuri: I have no experience with that |
| 19:34:15 | *** mvorobey has quit IRC |
| 19:34:19 | *** dkayiwa has quit IRC |
| 19:34:24 | <riomus> any one?? |
| 19:34:40 | <downey> riomus: http://go.openmrs.org/soc2012 |
| 19:34:56 | *** dkayiwa_ has quit IRC |
| 19:35:05 | <djazayeri> kavuri: are cookies enabled, e.g. for jsessionid? |
| 19:35:20 | *** dkayiwa has joined #openmrs |
| 19:35:38 | <kavuri> djazayeri: is enabling cookies mandatory? |
| 19:35:47 | *** riomus has quit IRC |
| 19:36:01 | <djazayeri> r_friedman: rather than code samples, I'd start with defining the REST urls we want to support with specific examples. |
| 19:36:20 | <djazayeri> kavuri: not mandatoryâI guess you can provide basic authentication with every request |
| 19:36:52 | <djazayeri> kavuri: if cookies are enabled, your session should be maintained in the background |
| 19:37:50 | <kavuri> djazayeri: I will try with cookies enabled, but I doubt if that is the problem |
| 19:37:52 | *** nadee1 has joined #openmrs |
| 19:38:13 | <r_friedman> djazayeri: take my 9? examples, substitute "order" for superclass, substitute order, drugorder and hivdrugorder for subclass |
| 19:38:17 | <djazayeri> kavuri: hitting the session field? |
| 19:38:26 | *** nadee1 has left #openmrs |
| 19:38:43 | <djazayeri> r_friedman: I know, but explicitly put it down that way so we (and burke) can discuss specifics. |
| 19:39:02 | *** nadee has joined #openmrs |
| 19:39:24 | <djazayeri> kavuri: sorry, mistyped. Are you hitting the session resource? or a normal resource? |
| 19:39:41 | <kavuri> djazayeri: session resource |
| 19:40:32 | <djazayeri> kavuri: if you hit the session resource, and you provide basic auth in the header, it should return that you are authenticated |
| 19:41:38 | *** pulasthi7 has quit IRC |
| 19:42:10 | <suranga__> djazayeri, patch file finally attached to REST 220 :-) |
| 19:44:48 | <djazayeri> r_friedman: hmm, I forgot, but I actually have a call in 15 mins; let's talk now |
| 19:45:02 | <djazayeri> anyone else who wants to discuss REST and subclasses, you're welcome to join. |
| 19:45:11 | <r_friedman> ok |
| 19:45:57 | <r_friedman> so darius, as we know, our designs are fairly close to each other |
| 19:45:57 | <kavuri> djazayeri: I was sending the credentials not in the header, but in the body (using the HttpHost), now I sent it in the header and it works |
| 19:46:14 | <djazayeri> kavuri: great |
| 19:46:28 | <r_friedman> djazayeri: the main differences are as follows as I see it: |
| 19:46:52 | <r_friedman> 1. I use a virtual discriminator, you use a discriminator field |
| 19:47:33 | <r_friedman> 2. You try to do as much setup as possible in the superclass, then let it delegate; while I delegate through Spring and let the gets and reps handle the differences |
| 19:48:26 | <djazayeri> r_friedman: right; the difference is philosophical. I argue that, for purposes of rest, subclasses are *not* resources |
| 19:49:01 | <r_friedman> I know you do, I just disagree with you. |
| 19:49:17 | <r_friedman> djazayeri: I think you're influenced by being a core developer just as I'm influenced by being a module developer |
| 19:49:47 | <r_friedman> djazayeri: as a module developer, I want my own objects with their own services, own privileges, own representations, etc. |
| 19:50:00 | <r_friedman> djazayeri: I want to do everything you can as a core developer |
| 19:50:19 | <r_friedman> I want to have powerful subclasses which can spawn strong subsubclasses |
| 19:50:41 | <djazayeri> r_friedman: you're allowed to do that |
| 19:50:52 | <djazayeri> but REST does not really support inheritance |
| 19:51:09 | <djazayeri> and it doesn't support subclasses, hence we should implement things to really not use them |
| 19:51:31 | <djazayeri> a module can override a core resource |
| 19:51:32 | <r_friedman> djazayeri: just because REST doesn't support inheritance, it doesn't mean than my lab order is any less than the core drug order or even the core order |
| 19:51:43 | *** suranga__ has quit IRC |
| 19:51:45 | <r_friedman> djazayeri: but 2 modules can't |
| 19:52:06 | <djazayeri> r_friedman: your lab order *is* no less than the core drug order. Drug order isn't a resource either |
| 19:52:14 | <djazayeri> it's just a type of document that can be handled by the order resource |
| 19:52:26 | <djazayeri> let's look at the specific cases from the etherpad |
| 19:52:50 | <djazayeri> e.g. let's say there's an HIV Drug Order with uuid=1234 |
| 19:53:28 | <r_friedman> ok |
| 19:53:32 | <djazayeri> you're saying I should be able to "GET order/1234?t=drugorder" and get back an HIV Drug Order as if it were a plain DrugOrder. |
| 19:53:38 | <djazayeri> I disagree that this should be allowed |
| 19:54:00 | <r_friedman> no, you get back a polymorphic drugorder |
| 19:54:18 | <djazayeri> order/1234 is a document that represents an HIV Drug Order. HIV Drug Order is solely responsible for its representations, and we don't allow its superclasses to handle it. |
| 19:54:22 | <r_friedman> it looks like an hivdrugorder |
| 19:54:46 | <nadee> djazayeri: hi darius, so Im on the symmetric project :) not the reporting one.. |
| 19:54:50 | <djazayeri> okay, maybe I misread that one, but then what' the difference between order/1234?t=drugorder and order/1234?t=hibdrugorder |
| 19:55:04 | <djazayeri> nadee: yeah, sad for me, but good for you! |
| 19:55:08 | *** kavuri has quit IRC |
| 19:55:33 | <r_friedman> none the way you've written it, but t=drugorder can use a named rep that belongs to drugorder |
| 19:55:51 | <djazayeri> r_friedman: right, and I'm saying that should not be allowed |
| 19:55:57 | <nadee> djazayeri : amm.. im on glad and sad both :) btw thanks for all the help with reporting |
| 19:55:59 | <djazayeri> Under the hood, it's a drug order |
| 19:56:26 | <djazayeri> r_friedman: but for REST purposes, it is *not* a drug order. It's an hivdrugorder document served by the order resource |
| 19:56:35 | <r_friedman> no, under the hood it's always an hivdrugorder; there's a difference between the object and its representations |
| 19:56:51 | *** james_regen has quit IRC |
| 19:57:00 | <r_friedman> that's polymorphism |
| 19:57:37 | <djazayeri> r_friedman: yes, there's polymorphism under the hood, but I'm saying (and I'm saying this because of expert advice) that we should *not* expose this via rest. |
| 19:58:03 | <djazayeri> r_friedman: another of the particular points you're making is that you want your resource to control creation more explicitly |
| 19:58:07 | *** isharap has joined #openmrs |
| 19:58:07 | *** isharapremadasa has quit IRC |
| 19:58:10 | <djazayeri> but this isn't actually how things work in core. |
| 19:58:47 | <djazayeri> i.e. in core if I do OrderService.saveOrder(anHivDrugOrder), that will work, with a CREATE ORDERS privilege check |
| 19:59:14 | *** didymo has joined #openmrs |
| 19:59:21 | <downey> Hi didymo and welcome to the #openmrs IRC channel. |
| 19:59:29 | <r_friedman> djazayeri: and i would like to see that have an hivdrugorder privilege check |
| 20:00:00 | <djazayeri> r_friedman: I have a call now, but can you reply to the dev list email with the extra specifications from the etherpad? |
| 20:00:14 | <r_friedman> sure i will pound away |
| 20:04:23 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Congratulations & good luck to our 18 highly-talented #GSoC students this year! http://t.co/iMQ0OW1X #OpenMRS #ICT4D <http://twitter.com/OpenMRS/statuses/194509535254282240> |
| 20:07:33 | <hemanth_92> r_friedman, got rejected :( |
| 20:08:24 | <r_friedman> hemanth_92: e-mail coming |
| 20:08:32 | *** bwolfe has joined #openmrs |
| 20:08:32 | *** ChanServ sets mode: +o bwolfe |
| 20:09:24 | *** bryq has quit IRC |
| 20:09:32 | <hemanth_92> r_friedman, already got the mail that my application got rejected |
| 20:09:52 | <r_friedman> hemanth_92: personal from me |
| 20:11:47 | <djazayeri> didymo: can you accept dawn_'s skype contact request? |
| 20:12:42 | <didymo> djazayeri: will do need to get another computer BRB |
| 20:13:01 | <r_friedman> !computerme didymo |
| 20:13:02 | <OpenMRSBot> r_friedman: Error: "computerme" is not a valid command. |
| 20:20:17 | <bwolfe> r_friedman, not as easy as beerme, unfortunately |
| 20:20:42 | <djazayeri> !awesomeapple27"monitorme |
| 20:20:43 | <OpenMRSBot> djazayeri: Error: "awesomeapple27"monitorme" is not a valid command. |
| 20:21:06 | *** hemanth_92 has quit IRC |
| 20:21:50 | <downey> !napme |
| 20:21:51 | <OpenMRSBot> downey: Error: "napme" is not a valid command. |
| 20:22:13 | <r_friedman> downey, you mean !5hourenergyme |
| 20:22:24 | <dawn_> :D hahaha! |
| 20:22:24 | <downey> r_friedman: i like the way you think :) |
| 20:29:10 | <bwolfe> djazayeri, only 27 inches? :-/ |
| 20:29:31 | <downey> bwolfe: i like the way you think :) |
| 20:29:48 | <djazayeri> bwolfe: how big do you think my desk is? |
| 20:30:16 | <r_friedman> bwolfe: oh, you're talking desk size |
| 20:32:31 | *** maurya has quit IRC |
| 20:40:15 | *** downey has quit IRC |
| 20:41:17 | <finbrein> Hi All, My proposal to re-implement the birt module on top of the reporting module has been accepted. Thanks. ;) Time to work the work by working very hard and with full speed. Thank you again. I appreciate. ;) |
| 20:44:40 | *** isharap has quit IRC |
| 20:51:48 | *** isharapremadasa has joined #openmrs |
| 21:05:47 | <didymo> lh: ping |
| 21:06:57 | *** dawn_ has quit IRC |
| 21:07:29 | <lh> didymo, pong |
| 21:10:39 | *** nribeka has quit IRC |
| 21:11:38 | *** wyclif has quit IRC |
| 21:20:40 | *** Mkop has quit IRC |
| 21:22:05 | <r_friedman> finbrein: your project done yet? |
| 21:23:03 | <finbrein> r_friedman: do you mean my ticket? |
| 21:23:32 | <r_friedman> i tought u were working very hard and with full speed? should take only an hour |
| 21:23:48 | <r_friedman> 2 hours if you have to drink shots while you're doing it |
| 21:24:31 | <finbrein> r_friedman: lol :x) |
| 21:25:27 | *** Mkop has joined #openmrs |
| 21:25:27 | *** ChanServ sets mode: +v Mkop |
| 21:25:43 | <finbrein> r_friedman: since it lasts for 3 months, then there is a need to work hard and fast to meet the deadline |
| 21:26:14 | *** MarkG has left #openmrs |
| 21:30:29 | <nadee> :) congrats to everyone who got selected for gsoc this summer! and to everyone who worked hard too! |
| 21:30:42 | <r_friedman> finbrein: all i get is a tee shirt, i get to be rude and demanding to my mentees |
| 21:32:27 | <finbrein> r_friedman: 1 T-shirt : really?!? Motivation++ as well ;) Thanks nadee! |
| 21:33:17 | <nadee> :) |
| 21:33:28 | <r_friedman> finbrein: my mentees also have to listen to my long and boring stories of times long past |
| 21:34:02 | <bwolfe> r_friedman, no we don't |
| 21:34:06 | <bwolfe> /kickban r_friedman |
| 21:34:08 | <finbrein> r_friedman: i wish you were my mentor |
| 21:34:13 | <harshadura> Congratz gsoc mates and Thank you so much OpenMRS :) :) :) |
| 21:34:15 | *** sgithens_ has quit IRC |
| 21:34:40 | <finbrein> harshadura: hi. thanks++ |
| 21:34:51 | <bwolfe> finbrein, who is your mentor? |
| 21:35:10 | <r_friedman> bwolfe, tell me you don't want to hear about the time i slung an 8" floppy disk at my boss |
| 21:35:15 | <harshadura> finbrein, :) |
| 21:35:16 | <finbrein> bwolfe: Justin++ |
| 21:35:45 | <finbrein> bwolfe: jmiranda (Justin Miranda) |
| 21:36:19 | <isharapremadasa> Yes, thanks a lot OpenMRS for the opportunity and looking forward for a great summer of code! |
| 21:37:39 | <harshadura> Congratz sisters nadee, isharapremadasa :) :) |
| 21:38:20 | <finbrein> Hi isharapremadasa, congrats! |
| 21:39:31 | <bwolfe> finbrein, justin is good. just make sure he doesn't try to get you to "boil the ocean" |
| 21:40:50 | <bwolfe> r_friedman, do tell |
| 21:40:55 | <finbrein> bwolfe: Oh, lol ;) I have worked with him a little bit and I really enjoyed working with him |
| 21:41:42 | <r_friedman> bwolfe: you've gotta beer me for real to hear that one |
| 21:42:29 | <nadee> thanks harshadura |
| 21:42:36 | <finbrein> r_friedman: How about Juice? Now I have to run for saying this to one of our mentors oooooooooooo |
| 21:43:17 | <bwolfe> finbrein, perhaps Mike's Hard Lemonade. thats like juice |
| 21:43:35 | <r_friedman> finbrein, that's ok, i'm only a backup mentor, you can say what you like about me |
| 21:43:50 | <finbrein> bwolfe: Apple juice or something |
| 21:44:05 | <bwolfe> boo |
| 21:44:26 | <r_friedman> hard lemonade sounds good |
| 21:45:22 | <r_friedman> palm wine is very traditional, but yucchy |
| 21:46:43 | <finbrein> r_friedman: I like that |
| 21:46:59 | <finbrein> Have you tried r_friedman? |
| 21:47:32 | <finbrein> r_friedman: there is koskenkorva here |
| 21:47:36 | <r_friedman> finbrein: oh yes, by itself and mixed with Coke |
| 21:47:57 | <finbrein> r_friedman: haha |
| 21:48:21 | <r_friedman> yumm barley |
| 21:49:24 | *** nadee has quit IRC |
| 21:49:36 | <r_friedman> sounds like that koskenkorva could knock you out for the whole winter |
| 21:50:54 | <finbrein> r_friedman: there is another one. Good when you are in the forest to hunt down moose and pick mushrooms |
| 21:51:05 | *** isharapremadasa has quit IRC |
| 21:51:13 | <finbrein> r_friedman: it is called "Jägermeister" |
| 21:51:34 | <finbrein> r_friedman: http://steamcommunity.com/groups/kylmaajaksya |
| 21:51:51 | <r_friedman> finbrein, we know well that jagermeister, the moose and i would be hugging and singing duets |
| 21:52:28 | <finbrein> r_friedman: Are you in Alaska? |
| 21:53:04 | <r_friedman> finbrein, not even close. more like my own private idaho |
| 21:53:14 | <finbrein> r_friedman: haha |
| 21:53:22 | *** dkayiwa has quit IRC |
| 21:54:33 | <finbrein> r_friedman: are there mooses in Idaho? Don't even know the plural, moose or mooses |
| 21:54:58 | <finbrein> r_friedman: We've got moose and bears |
| 21:55:28 | <r_friedman> moose is plural, my wife is mooses friedman |
| 21:56:05 | <r_friedman> we've got cockroaches |
| 21:56:32 | <finbrein> r_friedman: cockroaches in America? |
| 21:56:55 | <finbrein> r_friedman: I haven't seen a cockroach in Finland |
| 21:57:04 | <r_friedman> finbrein, german cockroaches, but they live up north; in the south we have big ones called palmetto bugs |
| 21:57:35 | <r_friedman> that's because finnish housewives are too neat to leave a crumb, finbrein |
| 21:57:36 | <finbrein> r_friedman: i am hearing mooses as a name for the first time. Must be a joke |
| 21:58:11 | <r_friedman> finbrein: if i'm saying it, it's probably a bad joke |
| 21:58:44 | <finbrein> r_friedman: How I enjoy working with the Americans? There is always fun in addition to hard work |
| 21:59:14 | <r_friedman> the gulag it's not |
| 22:00:14 | <r_friedman> i guess we work so much we confuse it with social life |
| 22:00:56 | <finbrein> r_friedman: 2 weeks holiday in 365 or 366 days, is that typical in America? |
| 22:01:28 | <r_friedman> finbrein: that's starting, after 5 years usually goes to 3, after 10 years 4 |
| 22:01:40 | <r_friedman> after 15 you're fired |
| 22:01:54 | <finbrein> r_friedman: Americans are very hardworking, we are diligent |
| 22:01:56 | *** mnunez has joined #openmrs |
| 22:02:33 | <finbrein> r_friedman: there's always a way out |
| 22:02:40 | *** mnunez has left #openmrs |
| 22:03:02 | <r_friedman> finbrein: my oboe teacher was a finn, you don't need to tell me |
| 22:03:10 | <finbrein> r_friedman: Americans get better salary as reward for hardwork |
| 22:03:35 | <finbrein> r_friedman: the equation is balanced |
| 22:03:45 | <r_friedman> finbrein: haha, but the class difference is so big, the $ doesn't make up for it |
| 22:04:58 | <r_friedman> a director of my company gets $2.5 million per year just for travel expenses |
| 22:05:12 | <r_friedman> and he's not even full time |
| 22:06:27 | <r_friedman> finbrein: sounds like we have the summer to yakk, i need to get some work done |
| 22:06:37 | <r_friedman> talk to you later |
| 22:06:48 | <finbrein> r_friedman: me too. ok |
| 22:06:53 | <r_friedman> finbrein: go celebrate gsoc with some jagermeister |
| 22:07:08 | <finbrein> ;) ;) ;) |
| 22:17:04 | *** rafa has quit IRC |
| 22:20:08 | *** wyclif has joined #openmrs |
| 22:30:42 | *** r_friedman is now known as r_friedman_away |
| 23:40:00 | <robbyoconnor> finbrein: congrats =) |
| 23:40:48 | <robbyoconnor> I expect awesome things from you! |