00:36:12
|
*** lh has joined #openmrs
|
01:24:38
|
* r_friedman is lurking
|
01:30:38
|
*** lh has quit IRC
|
01:50:35
|
* robbyoconnor is lurking too...in that creepy way
|
01:50:37
|
<robbyoconnor> :D
|
01:57:51
|
* djazayeri is writing code
|
02:11:36
|
*** r_friedman has quit IRC
|
02:43:45
|
*** finbrein has quit IRC
|
02:47:27
|
*** upul` has joined #openmrs
|
02:47:27
|
*** ChanServ sets mode: +v upul`
|
03:23:52
|
*** finbrein has joined #openmrs
|
03:51:16
|
*** morristic has joined #openmrs
|
04:00:05
|
*** morristic has quit IRC
|
04:00:16
|
*** morristic has joined #openmrs
|
04:24:40
|
*** p_m has joined #openmrs
|
04:28:01
|
*** rohitgoyal18 has joined #openmrs
|
04:42:29
|
*** morristic has quit IRC
|
04:42:58
|
*** morristic has joined #openmrs
|
04:47:12
|
*** sk has joined #openmrs
|
05:00:38
|
*** finbrein has quit IRC
|
05:16:35
|
*** bryq has joined #openmrs
|
05:16:35
|
*** ChanServ sets mode: +v bryq
|
05:21:43
|
*** bryq has quit IRC
|
05:33:04
|
*** sk has quit IRC
|
05:47:14
|
*** rohitgoyal18 has quit IRC
|
05:48:52
|
*** sunbiz has joined #openmrs
|
05:48:52
|
*** ChanServ sets mode: +v sunbiz
|
05:49:44
|
*** sk has joined #openmrs
|
05:50:50
|
<sunbiz> djazayeri: u there??
|
05:51:02
|
<djazayeri> sunbiz: hi
|
05:51:10
|
<sunbiz> hi
|
05:51:25
|
<sunbiz> djazayeri: why do u say getAll should be PageableResult
|
05:51:36
|
<sunbiz> I thought u said it should refactored to return a SimpleObject
|
05:51:51
|
<djazayeri> sunbiz: when I was looking at the review, I thought it should be PageableResult.
|
05:51:53
|
<sunbiz> which I think is the correct thing... because getAll is the result
|
05:52:16
|
<djazayeri> Then when I looked back at the code I wrote for search, I see I was returning SimpleObject there
|
05:52:24
|
<sunbiz> its what is used by the BaseCrudController
|
05:52:27
|
<djazayeri> (see my ticket comment after completing the review)
|
05:52:31
|
<sunbiz> yes... saw that
|
05:52:55
|
<djazayeri> It still feels more appropriate that the result should be a PageableResult, but maybe that's not easy to do at this point?
|
05:52:59
|
<sunbiz> the impl method doGetAll returns PageableResult
|
05:53:17
|
<sunbiz> djazayeri: it should be not too hard to do
|
05:53:46
|
<sunbiz> but I feel its more clearer now... that the doGetAll returns PageableResult and getAll returns SimpleObject
|
05:54:21
|
<djazayeri> sunbiz: I'm fine leaving it like that; we could always refactor it later. ;-)
|
05:54:46
|
<djazayeri> sunbiz: could you take 5 minutes and see how big the code implications are if you change search and getAll to return PageableResult?
|
05:55:01
|
<djazayeri> is there a domino effect to everything, or would it actually be a small change?
|
05:55:20
|
<djazayeri> No need to actually _make_ the change now, I'm just curious.
|
06:00:34
|
<sunbiz> djazayeri: rafa had fixed that test
|
06:00:42
|
<sunbiz> by changing the tests :)
|
06:00:52
|
<djazayeri> sunbiz: I wondered if it was his fault. :-)
|
06:00:53
|
<sunbiz> djazayeri: added the watchers back
|
06:02:04
|
<djazayeri> thanks
|
06:18:31
|
<sunbiz> djazayeri: make that into a Util methos
|
06:18:35
|
<sunbiz> *method
|
06:18:50
|
<sunbiz> getResultsList(SimpleObject)
|
06:18:57
|
<sunbiz> djazayeri: sounds good??
|
06:19:20
|
<djazayeri> or even getResultSize(SimpleObject) returns int
|
06:19:29
|
<djazayeri> (or both)
|
06:19:53
|
<sunbiz> both is good as well
|
06:25:37
|
*** rafa has joined #openmrs
|
06:25:37
|
*** ChanServ sets mode: +v rafa
|
06:28:01
|
*** rafa has quit IRC
|
06:47:21
|
*** upul` has quit IRC
|
06:47:33
|
*** bryq has joined #openmrs
|
06:47:33
|
*** ChanServ sets mode: +v bryq
|
07:37:57
|
*** sk has quit IRC
|
07:44:27
|
*** dkayiwa has joined #openmrs
|
07:49:27
|
*** dkayiwa has quit IRC
|
08:01:07
|
*** p_m has quit IRC
|
08:18:02
|
*** sunbiz has quit IRC
|
08:22:39
|
*** snoppy has joined #openmrs
|
08:29:53
|
*** ksinkar has joined #openmrs
|
08:30:36
|
*** ksinkar_ has joined #openmrs
|
08:31:33
|
<ksinkar_> hey guys I have downloaded the openmrs source code and am trying to run the server on my machine which is ubuntu , I just ran the run_on_linux.sh script
|
08:34:16
|
*** ksinkar has quit IRC
|
08:34:19
|
<ksinkar_> on what port can I access openmrs?
|
09:00:42
|
*** ibewes has joined #openmrs
|
09:08:08
|
*** bryq has quit IRC
|
09:18:46
|
<ibewes> greetings... I am working on a module and want to update to the latest version of OpenMRS (1.9.whatever) from 1.8.2, what is the easiest way to do this in Eclipse or Intellij?
|
09:26:58
|
*** ksinkar_ is now known as ksinkar
|
09:28:35
|
<ksinkar> when I try to run the standalone open mrs, it is unable to find the mysql pid?
|
09:42:58
|
*** snoppy has quit IRC
|
09:53:47
|
*** harshadura has joined #openmrs
|
10:25:01
|
*** harshadura has quit IRC
|
10:44:49
|
*** morristic has quit IRC
|
10:55:29
|
*** harshadura has joined #openmrs
|
10:57:27
|
*** finbrein has joined #openmrs
|
11:06:25
|
<robbyoconnor> ksinkar: if you know IDEA -- use IDEA ; most of the team uses eclipse -- I use IDEA
|
11:06:54
|
<robbyoconnor> er wait nvm wait around
|
11:24:53
|
*** robbyoconnor has quit IRC
|
11:39:17
|
*** bwolfe_ has joined #openmrs
|
11:39:17
|
*** ChanServ sets mode: +o bwolfe_
|
11:55:41
|
*** dkayiwa has joined #openmrs
|
12:01:39
|
*** dkayiwa_ has joined #openmrs
|
12:02:05
|
*** dkayiwa has quit IRC
|
12:02:06
|
*** dkayiwa_ is now known as dkayiwa
|
12:06:43
|
*** dkayiwa has quit IRC
|
12:18:02
|
*** rafa has joined #openmrs
|
12:18:05
|
*** ChanServ sets mode: +v rafa
|
12:19:49
|
*** wyclif has quit IRC
|
12:20:12
|
*** dkayiwa has joined #openmrs
|
12:31:27
|
*** james_regen has joined #openmrs
|
12:31:27
|
*** ChanServ sets mode: +v james_regen
|
12:47:37
|
<dkayiwa> hi bwolfe_
|
12:47:40
|
*** finbrein has joined #openmrs
|
12:48:08
|
<bwolfe_> hey dkayiwa
|
12:48:10
|
*** bwolfe_ is now known as bwolfe
|
12:48:27
|
<dkayiwa> bwolfe: did we change the middle name to become required?
|
12:48:47
|
<dkayiwa> bwolfe: am getting MiddleName.invalid when i do not enter one
|
12:49:14
|
<bwolfe> dkayiwa, its possible one of my recent commits on trunk did it...
|
12:49:26
|
<bwolfe> I committed somethign about regex on API names
|
12:49:39
|
<dkayiwa> bwolfe: yes i saw that in debug mode :)
|
12:49:50
|
<dkayiwa> bwolfe: if (personName.getMiddleName() != null && !personName.getMiddleName().matches(namePattern))
|
12:50:13
|
<bwolfe> you should change those so they don't act on empty strings either
|
12:51:10
|
<dkayiwa> bwolfe: ok
|
12:57:11
|
*** dileepsisila has joined #openmrs
|
13:00:46
|
*** harshadura has quit IRC
|
13:08:14
|
*** wyclif has joined #openmrs
|
13:09:38
|
<dileepsisila> bwolfe: hi
|
13:12:54
|
*** harshadura has joined #openmrs
|
13:18:22
|
*** finbrein has quit IRC
|
13:22:00
|
*** sgithens_ has joined #openmrs
|
13:25:55
|
<bwolfe> hi dileepsisila
|
13:27:35
|
*** bryq has joined #openmrs
|
13:27:35
|
*** ChanServ sets mode: +v bryq
|
13:30:47
|
*** finbrein has joined #openmrs
|
13:31:31
|
*** MarkG has joined #openmrs
|
13:32:04
|
<dileepsisila> bwolfe: https://wiki.openmrs.org/display/~dileepsisila/New+Feature+for+Open-MRS
|
13:32:16
|
<dileepsisila> can you see this?
|
13:35:26
|
<bwolfe> I see the page, yes.
|
13:37:08
|
<dileepsisila> this is a my idea, it can apply your system
|
13:40:25
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Today: Follow our friends @IntraHealth for #SwitchPoint for innovation in global health & more. Live video starts now: http://t.co/0KpL0VfQ <http://twitter.com/OpenMRS/statuses/193326727223709698>
|
13:42:52
|
*** pulasthi7 has joined #openmrs
|
13:47:52
|
<wyclif> hi dkayiwa
|
13:47:52
|
*** r_friedman has joined #openmrs
|
13:48:50
|
<r_friedman> djazayeri: hi, am reviewing stuff, have to go to meeting, will miss scrum, no progress on ticket
|
13:50:37
|
<r_friedman> rafa, another jsslab developer is having same problem as me with test application context failing under JUnit. should have asked you yesterday if this was your problem rather than just telling you about broken test. could you investigate, this is a blocker for me? i have to go to a meeting, will be back in about an hour
|
13:51:05
|
*** dawn_ has joined #openmrs
|
13:51:35
|
*** dileepsisila has left #openmrs
|
13:53:06
|
*** ChanServ sets mode: +v dawn_
|
13:54:34
|
<rafa> r_friedman: yeah, I saw that problem with the hibernate configuration and it wasn't an easy fix for me
|
13:54:45
|
<rafa> r_friedman: I'll need to investigate more
|
14:00:19
|
*** rohitgoyal18 has joined #openmrs
|
14:00:34
|
*** skathol has joined #openmrs
|
14:01:16
|
<dawn_> !scrumon dawn
|
14:01:16
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready.
|
14:01:22
|
<dawn_> Hi Team!
|
14:01:41
|
<rafa> hi
|
14:01:46
|
<bwolfe> hi
|
14:01:48
|
<dawn_> Today's order: wyclif , r_friedman , rafa , skathol, finbrein, djazayeri , dkayiwa , bwolfe
|
14:02:08
|
<rafa> r_friedman is afk
|
14:02:28
|
<wyclif> Thursday:
|
14:02:28
|
<wyclif> * dev call
|
14:02:28
|
<wyclif> * Created a Review of the order-entry branch and went through it to determine level of variation from trunk
|
14:02:28
|
<wyclif> * Compare order-entry branch with where we want to be to determine level of variation
|
14:02:28
|
<wyclif> * sent out an email summarising the findings
|
14:02:30
|
<wyclif> Friday:
|
14:02:32
|
<wyclif> * Need to catch up with Burke, if given a go a head, draft a wiki page with the design proposal of the order entry API
|
14:02:35
|
<wyclif> * Otherwise join Daniel in the swim lane, i know ben suggested picking something in the sprint instead
|
14:02:37
|
<wyclif> Blockers: None
|
14:02:54
|
<rafa> Today:
|
14:02:55
|
<rafa> * I went to a JEE workshop by Adam Bien and I haven't worked much yet.
|
14:02:55
|
<rafa> * Reviewed CR-MOD-403: Support for Resource-per-class-hierarchy (pre-commit)
|
14:02:55
|
<rafa> * Later today and tomorrow I'll get things done:
|
14:02:55
|
<rafa> + RESTWS-224: ResourceDocCreator should generate documentation for POST content
|
14:02:55
|
<rafa> https://tickets.openmrs.org/browse/RESTWS-224
|
14:02:56
|
<rafa> + Remaining subtasks of RESTWS-226: Resources need to specify what fields are editable, not blindly expose all delegate properties
|
14:02:56
|
<rafa> https://tickets.openmrs.org/browse/RESTWS-226 subtasks.
|
14:02:57
|
<rafa> No blockers.
|
14:03:15
|
<skathol> RESTWS-215 - Changes to user, role, and privilege services complete - working on unit tests
|
14:03:15
|
<skathol> * Tests are failing, currently investigating why
|
14:03:15
|
<skathol> * Having difficulty debugging unit tests - hibernate mapping file generates errors when I run junit through eclipse.
|
14:03:15
|
<skathol> Blockers: Difficulty with unit tests.
|
14:03:47
|
<finbrein> ++ start ++
|
14:03:47
|
<finbrein> Investigated RESTWS-239
|
14:03:47
|
<finbrein> I shalll continue with the ticket today
|
14:03:47
|
<finbrein> ++ end ++
|
14:04:23
|
<djazayeri> !ticket RESTWS-239
|
14:04:24
|
<OpenMRSBot> djazayeri: [#RESTWS-239] Define creatable/updatable properties on PatientIdentifierType resource - OpenMRS JIRA - https://tickets.openmrs.org/browse/RESTWS-239
|
14:04:47
|
<djazayeri> finbrein: After updates I can comment about that
|
14:05:01
|
<finbrein> ok
|
14:05:31
|
<djazayeri> Thursday 19-Apr-2012
|
14:05:31
|
<djazayeri> * Dev call
|
14:05:31
|
<djazayeri> * Leadership call
|
14:05:31
|
<djazayeri> * Review sprint tickets and apply them (overdue from Wednedsday)
|
14:05:31
|
<djazayeri> * Implemented and submitted patch for RESTWS-243 - Support for resource-per-class-hierarchy
|
14:05:48
|
<djazayeri> * this was a 20-hour day...
|
14:05:58
|
<djazayeri> Friday 20-Apr-2012
|
14:06:00
|
<djazayeri> * sleep a bit more
|
14:06:11
|
<djazayeri> * reviews for sprint tickets
|
14:06:24
|
<djazayeri> * refactor and address review comments on RESTWS-243
|
14:06:32
|
<djazayeri> * talk with Andy and Jan about MVP dictionary
|
14:06:47
|
<djazayeri> blocker: waiting for people to comment on RESTWS-243 review
|
14:06:59
|
<djazayeri> (maybe they have already, I haven't looked at my email yet)
|
14:07:03
|
<bwolfe> they have
|
14:07:09
|
<bwolfe> :_)
|
14:07:10
|
<djazayeri> great
|
14:07:12
|
<bwolfe> err, :-)
|
14:07:45
|
<bwolfe> dkayiwa, ?
|
14:07:50
|
<dkayiwa> Committed: Changing concept names with the ui doesn't save - TRUNK-3149
|
14:07:50
|
<dkayiwa> Reviewed and applied patch for: Fix concept search for phrases with multiple words - TRUNK-3249
|
14:07:50
|
<dkayiwa> Reviewed and rejected patch for: Errors and exceptions when running ORUR01HandlerTest - TRUNK-2553
|
14:07:51
|
<dkayiwa> Reviewed and applied patch for: PersonAddress isBlank() method needs to be updated to use the latest address fields; also probably should handle "blank" case or be renamed is null - TRUNK-2467
|
14:07:51
|
<dkayiwa> Now reviewing: Allow modules to define strongly-typed global properties - TRUNK-2732
|
14:07:51
|
<dkayiwa> No Blockers
|
14:08:35
|
<bwolfe> !ticket TRUNK-2553
|
14:08:36
|
<OpenMRSBot> bwolfe: [#TRUNK-2553] Errors and exceptions when running ORUR01HandlerTest - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2553
|
14:08:50
|
<bwolfe> Thursday
|
14:08:50
|
<bwolfe> emails
|
14:08:50
|
<bwolfe> sprint setup
|
14:08:50
|
<bwolfe> dev call
|
14:08:50
|
<bwolfe> ldrship/enterprise call
|
14:08:51
|
<bwolfe> pamphlet disc with dawn/michael
|
14:08:52
|
<bwolfe> atom feed module
|
14:08:54
|
<bwolfe> atom feed sprint setup
|
14:08:56
|
<bwolfe> Friday
|
14:08:58
|
<bwolfe> emails
|
14:09:00
|
<bwolfe> reviewed Darius' ws commit
|
14:09:02
|
<bwolfe> atom feed module work
|
14:09:04
|
<bwolfe> design call setup
|
14:09:08
|
<bwolfe> sprint schedule review
|
14:09:10
|
<bwolfe> triaged RCM-80
|
14:09:12
|
<bwolfe> triage more tickets
|
14:09:14
|
<bwolfe> finish sprint setup for atom feed
|
14:09:16
|
<bwolfe> phone interview with poss new dev
|
14:09:18
|
<bwolfe> (no blockers)
|
14:09:20
|
<bwolfe> (no discussion points)
|
14:09:34
|
<dkayiwa> :)
|
14:09:39
|
<bwolfe> wyclif: are there no ws tickets for you to claim?
|
14:09:59
|
<wyclif> looking....
|
14:10:01
|
<dawn_> !scrumoff dawn
|
14:10:01
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
14:10:04
|
<dawn_> Discussion Points: 1) wyclif : when will you catch up with Burke about the design proposal? 2) skathol : blocker: Unit test difficulties 3) djazayeri and finbrein : discuss RESTWS-239, 4) bwolfe and djazayeri : let's catch up for the sprints starting next week
|
14:10:06
|
<djazayeri> according to the dashboard there are 16 left
|
14:10:56
|
<djazayeri> wyclif: and quite a few of those are quick-to-do, i.e. defining creatable and editable fields on resources
|
14:11:06
|
<bwolfe> wyclif, def take a ws ticket instead of a general bug fixing
|
14:11:27
|
<djazayeri> wyclif: which requires looking at the underlying java class, and copying over its properties, with some thought
|
14:12:07
|
<wyclif> djazayeri, let let pick up some WS tickets
|
14:12:39
|
<bwolfe> skathol, which test is causing you issues?
|
14:13:20
|
<djazayeri> finbrein: about RESTWS-239 and similar tickets
|
14:13:33
|
<wyclif> djazayeri, bwolfe i find it still not worth it for me to draft up a reasonable design proposal since we are still undecided on a couple of things, i will try to join mike and burke for a call late today
|
14:13:51
|
<bwolfe> wyclif, you can draft most of it though, right?
|
14:13:56
|
<skathol> When I build with unit tests in maven, I can see errors in the surefire reports, but I can't debug.
|
14:14:07
|
<bwolfe> leave the two sections with questionable status untouched (or with a note that it might change)
|
14:14:25
|
<wyclif> bwolfe, may be but service layer stuff would depend alot on how we model the domain objects
|
14:14:53
|
<rafa> skathol: what error do you get trying to debug?
|
14:14:58
|
<skathol> When I run directly in eclipse, initialization fails, I think due to format of test-hibernate.cfg.xml
|
14:15:08
|
<djazayeri> wyclif: the remaining design points are mostly around: "do we start from the current codebase, or start from scratch on a new version of Order"
|
14:15:29
|
<djazayeri> wyclif: but regardless, there will definitely *be* an Order class, and subclasses, and it will have a service
|
14:15:33
|
<rafa> skathol: can you pastebin the stacktrace?
|
14:16:02
|
<djazayeri> wyclif: can you examine the possibilities around letting Mike and/or others start working on order groups ASAP?
|
14:16:04
|
<wyclif> djazayeri, are we adding back order types?
|
14:16:27
|
<skathol> http://pastebin.com/zRWysThu
|
14:16:44
|
<djazayeri> wyclif: from the design call, it seems like we need them, but they should not be the hibernate discriminator
|
14:16:55
|
<wyclif> djazayeri,
|
14:16:57
|
<wyclif> ok
|
14:17:01
|
<djazayeri> wyclif: though certain order subclasses may require certain ordertypes
|
14:17:11
|
<djazayeri> finbrein: sorry, I got distracted
|
14:17:13
|
<djazayeri> about that ticket.
|
14:17:20
|
<wyclif> bwolfe, djazayeri , if i'm to do draft, then i might wait to pick a WS ticket
|
14:17:34
|
<djazayeri> wyclif: yes, that's what I'd suggest
|
14:18:11
|
<rafa> skathol: I get the very same error
|
14:18:25
|
<bwolfe> rafa, in trunk or web services?
|
14:18:46
|
<finbrein> djazayeri: RESTWS-239...?!?
|
14:18:57
|
<rafa> bwolfe: it's in web services and what seems to help is run mvn install -Dskip.Tests and then debug in Eclipse
|
14:19:02
|
<djazayeri> finbrein: basically the idea behind that ticket is that ticket is that you should look at the underlying domain object (PatientIdentifierType) and look at all its own properties
|
14:19:19
|
<djazayeri> finbrein: as well as a couple from BaseOpenmrsMetadata (name and description)
|
14:19:36
|
<rafa> bwolfe: it's quite consistent and I need to repeat the steps whenever I edit the java file
|
14:19:43
|
<djazayeri> finbrein: and just list off most of those in the getCreatableFields method
|
14:19:56
|
<rafa> bwolfe: I haven't figured out why yet
|
14:19:57
|
<dawn_> bwolfe: and djazayeri : with 16 tickets remaining, are we going to have enough developer time next week for the Order Entry and Atlas Module sprints?
|
14:20:31
|
<rafa> skathol: can you try if it helps for you?
|
14:20:32
|
<djazayeri> finbrein: you should also look at PatientIdentifierType.hbm.xml and PatientIdentifierTypeValidator to see which of those fields should be required
|
14:20:50
|
<skathol> rafa: I'll give it a try
|
14:20:54
|
<djazayeri> finbrein: and if you have any questions about whether or not to include a field, feel free to ask
|
14:21:09
|
<djazayeri> dawn_: quite a few of the tickets are non-essential
|
14:21:18
|
<djazayeri> let me review the dashboard
|
14:21:30
|
<finbrein> ok.thanks. djazayeri
|
14:22:11
|
<skathol> rafa: that seems to work - thanks
|
14:22:47
|
<rafa> skathol: good, but still I'd love to fix that, it's annoying
|
14:23:31
|
<djazayeri> dawn_: There are 29 unresolved tickets
|
14:23:59
|
<djazayeri> dawn_: I think ~10 of them are non-essential, and can easily be bumped to 1.1
|
14:24:13
|
<skathol> rafa: agreed. there must be a hbm mapping resource that is created during maven build, and cleaned up after the test plugin runs?
|
14:24:26
|
<djazayeri> dawn_: the biggest thing is that there are 10 tickets in-progress
|
14:25:25
|
<djazayeri> dawn_: and there are a couple of big Must tickets that rafa and I are currently working on
|
14:25:26
|
<skathol> rafa: test-hibernate.cfg.xml did not change...
|
14:25:30
|
<rafa> skathol: I can run the test plugin multiple times and it breaks only after I change some java file and eclipse recompiles it
|
14:25:31
|
<dawn_> djazayeri: right. so I am wondering if we can bump the non-essential tickets off of the dashboard so people can see to focus on the ones we need.
|
14:26:16
|
<djazayeri> dawn_: I'll go through and do that, though if people are picking tickets from the dashboard it should be relatively clear
|
14:26:24
|
<dawn_> djazayeri: so if we take the ~10 off and there are 19 tickets remaining. I just want to make sure we can wrap that up to have full dev time for those who are available next week (though I'm not sure how realistic that is)
|
14:26:29
|
<djazayeri> dawn_: my bigger concern is people finishing the tickets they have now, given that it's friday
|
14:27:06
|
*** pulasthi7 has quit IRC
|
14:27:21
|
<skathol> another question... there are no privileges in standardTestDataset. How critical is it to generate unit tests for the PrivilegeController and PrivilegeResource that I created? It will take me some time to learn how to create an xml data file.
|
14:27:34
|
<djazayeri> dawn_: I would estimate needing ~2 days each from Rafal and I next week, as well as some time from finbrein, roger, sunbiz, skathol, and suranga to finish their current tickets
|
14:27:50
|
<djazayeri> skathol: the quick way is to create in your test via the service...
|
14:28:12
|
<djazayeri> skathol: e.g. Context.getUserService().savePrivilege(new Privilege(â¦))
|
14:28:24
|
<rafa> djazayeri: I have one whole day today/tomorrow
|
14:29:24
|
<djazayeri> dawn_: so, given that rafa owes a day today/tomorrow, I think we'll need 3 total days from him and me next week for the two big tickets we're working on, plus finishing-ticket time from others as mentioned
|
14:29:46
|
<djazayeri> dawn_: so I think we should account for that, but it shouldn't derail the work we're planning to do next week
|
14:30:21
|
<djazayeri> bwolfe and I will discuss later
|
14:32:43
|
<rafa> djazayeri: skathol: I've got a fix actually. I removed ${hbmConfig} from test-hibernate.cfg.xml since there are no hbms anyway. It worked like a charm. I'll commit.
|
14:32:58
|
<djazayeri> rafa: great!
|
14:33:29
|
<skathol> rafa: djazayeri: thanks for the help - I have competing priorities, but I will try to finish today, including privilege tests.
|
14:33:57
|
<djazayeri> skathol: we appreciate it, especially in the presence of competing priorities!
|
14:34:01
|
<skathol> rafa: nice, and thanks again!
|
14:34:32
|
<bwolfe> rafa, isn't that the fix I told roger last week? :-/
|
14:35:04
|
<dawn_> djazayeri: are you sure you can give 3 total days next week?
|
14:35:05
|
<skathol> djazayeri: no problem, it's fun :-)
|
14:35:20
|
<rafa> bwolfe: maybe, I didn't know you discuss it
|
14:35:35
|
<bwolfe> rafa, and we need a more general fix for that. because any module with that in it will fail...but shouldn't. I'm not enough of a maven whiz to know what/where the fix is though
|
14:35:50
|
<dawn_> djazayeri: do we have an idea of the workload next week (number of tickets, level of difficulty)? That will play a factor
|
14:35:54
|
<djazayeri> dawn_: I mean 3 total days between rafal and I; and I'll have a clearer picture at the end of today how much work is left
|
14:35:54
|
<bwolfe> rafa, maybe it was earlier this week. and maybe it was jsut in my head. who knows
|
14:36:12
|
<rafa> bwolfe: seems like eclipse is overwriting the file whenever something is changed in the project
|
14:36:38
|
<rafa> bwolfe: but it can't replace ${hbmConfig}
|
14:37:36
|
<rafa> bwolfe: it's replaced by maven-openmrs-plugin?
|
14:38:10
|
<rafa> bwolfe: eclipse doesn't support our plugin :)
|
14:38:34
|
<rafa> bwolfe: the quick solution is not to use ${hbmConfig} rather list hbms manually
|
14:39:08
|
<djazayeri> dawn_: there are now 7 remaining open tickets; 4 are Musts; they are all low-complexity for someone experienced with OpenMRS and with the web services module; i.e. rafal could finish them all in < 1 day
|
14:40:39
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: In the developing world, even people who don't know how to read & write know how to send a text message - Amod Kumar #SwitchPoint #mHealth <http://twitter.com/OpenMRS/statuses/193338778318942209>
|
14:41:55
|
<rafa> djazayeri: I'll finish today/tomorrow with RESTWS-148 and remaning creatable/updatable
|
14:42:12
|
<rafa> djazayeri: I don't know what the ticket for forms is
|
14:43:22
|
<djazayeri> rafa: the forms ticket is basically that jkeiper did most of the work already, but that two things that he made resources need to become subresources
|
14:43:24
|
<dawn_> djazayeri: thanks. that helps me understand the timeline!
|
14:44:07
|
<rafa> djazayeri: ok
|
14:45:20
|
<djazayeri> Now, I am going to look at the resource-per-class-hierarchy review, and then sleep a couple more hours...
|
14:45:34
|
<djazayeri> does anybody have any questions for me now, especially about RESTWS-related things?
|
14:59:57
|
*** dawn_ has quit IRC
|
15:00:13
|
*** dkayiwa_ has joined #openmrs
|
15:00:40
|
*** dkayiwa has quit IRC
|
15:00:40
|
*** dkayiwa_ is now known as dkayiwa
|
15:01:01
|
*** ksinkar has quit IRC
|
15:01:08
|
*** ksinkar has joined #openmrs
|
15:01:47
|
*** MarkG has quit IRC
|
15:02:14
|
*** skathol has quit IRC
|
15:03:10
|
*** dileepsisila has joined #openmrs
|
15:05:28
|
*** ksinkar has quit IRC
|
15:06:03
|
*** ksinkar has joined #openmrs
|
15:06:32
|
*** jmiranda has joined #openmrs
|
15:06:46
|
*** ChanServ sets mode: +o jmiranda
|
15:08:23
|
<jmiranda> hey djazayeri or bwolfe, i am trying to deploy the birt module to openmrs standalone
|
15:08:34
|
<jmiranda> and i keep getting the following error
|
15:08:55
|
<djazayeri> dkayiwa: standalone ^^
|
15:09:08
|
<jmiranda> Cannot resolve reference to bean 'hL7Service' while setting bean property 'hl7Service'
|
15:09:25
|
<dkayiwa> jmiranda: which version of standalone?
|
15:09:47
|
<jmiranda> 1.8.3 i think
|
15:10:38
|
<jmiranda> dkayiwa, yeah 1.8.3
|
15:11:00
|
<dkayiwa> jmiranda: can you pastebin the entire stack trace?
|
15:11:05
|
<jmiranda> yup
|
15:12:25
|
<jmiranda> dkayiwa, http://pastebin.com/Qd8zrpJa
|
15:12:38
|
<dkayiwa> jmiranda: ok
|
15:13:06
|
<bwolfe> jmiranda, is the birtmodule supplying its own xerces jar?
|
15:13:18
|
<jmiranda> dkayiwa, i'll check
|
15:13:18
|
<djazayeri> I'm going to let dkayiwa and bwolfe take this one
|
15:13:25
|
<bwolfe> Constructor threw exception; nested exception is org.apache.xerces.impl.dv.DVFactoryException: DTD factory class org.apache.xerces.impl.dv.dtd.DTDDVFactoryImpl does not extend from DTDDVFactory.
|
15:13:25
|
<djazayeri> going offline for a couple hours
|
15:13:30
|
<bwolfe> gnight djazayeri
|
15:13:32
|
<jmiranda> djazayeri, thanks
|
15:14:10
|
*** dawn_ has joined #openmrs
|
15:14:10
|
*** ChanServ sets mode: +v dawn_
|
15:16:47
|
<jmiranda> bwolfe, dkayiwa: yeah just found xerces in the birt module (i just updated the birt libs to birt runtime 3.7.2, so i guess that's a new dependency)
|
15:17:21
|
<jmiranda> bwolfe, dkayiwa: thanks
|
15:20:51
|
*** dkayiwa has quit IRC
|
15:22:11
|
*** dkayiwa has joined #openmrs
|
15:23:44
|
*** dkayiwa has quit IRC
|
15:24:36
|
*** ibewes has quit IRC
|
15:27:49
|
*** dawn_ has quit IRC
|
15:39:53
|
*** kavuri has joined #openmrs
|
15:42:46
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @IntraHealth: IntraHealth's Dykki Settle: Health workers = health care #SwitchPoint <http://twitter.com/OpenMRS/statuses/193360393337442304>
|
15:55:49
|
*** lh has joined #openmrs
|
15:55:49
|
*** lh has joined #openmrs
|
15:57:09
|
*** jmiranda has quit IRC
|
16:04:33
|
*** suranga has joined #openmrs
|
16:04:44
|
*** MarkG has joined #openmrs
|
16:05:08
|
<kavuri> hi, in the openmrs webapp, what is the way to make it run over https? I do not see any property in properties.xml
|
16:11:29
|
<r_friedman> rafa, i'm back -- does your chat with skathol above relate to my problem? is the fix that I remove the session-factory tag from test-hibernate.cfg.xml or that I remove the whole file?
|
16:12:34
|
<rafa> r_friedman: it's a different case
|
16:12:51
|
<r_friedman> ok
|
16:13:22
|
<rafa> r_friedman: but I have a question do you use RuleDefinition.hbm.xml somewhere in tests?
|
16:13:41
|
<r_friedman> rafa: yes
|
16:13:58
|
<rafa> r_friedman: and it's only in tests on purpose?
|
16:14:40
|
<r_friedman> rafa, we have one object that contains a rule definition, and although we have logic in the project, it wasn't getting picked up, so we added it
|
16:15:07
|
<rafa> r_friedman: I see
|
16:18:29
|
<rafa> kavuri: see https://wiki.openmrs.org/display/docs/Troubleshooting+Tomcat
|
16:21:07
|
*** Rahul has joined #openmrs
|
16:30:01
|
*** ksinkar has quit IRC
|
16:40:51
|
*** robbyoconnor has joined #openmrs
|
16:40:51
|
*** ChanServ sets mode: +v robbyoconnor
|
16:41:59
|
*** r0bby has joined #openmrs
|
16:41:59
|
*** ChanServ sets mode: +v r0bby
|
16:45:10
|
<rafa> r_friedman: why is liquibase.xml empty?
|
16:45:23
|
<rafa> r_friedman: sqldiff as well
|
16:45:41
|
*** robbyoconnor has quit IRC
|
16:45:42
|
<rafa> r_friedman: do you have somewhere a valid version?
|
16:45:45
|
<r_friedman> rafa: because we haven't done that yet, we're working on a test db
|
16:46:41
|
<r_friedman> you want me to dropbox or e-mail it to you?
|
16:49:14
|
<rafa> r_friedman: commit?
|
16:49:55
|
<r_friedman> rafa, think not
|
16:50:38
|
<r_friedman> your @ openmrs.org has 4 or 5 letters before @?
|
16:51:01
|
<rafa> r_friedman: it's rafal in front
|
16:51:18
|
*** snoppy has joined #openmrs
|
17:03:45
|
*** dawn_ has joined #openmrs
|
17:03:45
|
*** ChanServ sets mode: +v dawn_
|
17:05:39
|
<r_friedman> rafa: away for about 4 hours
|
17:05:46
|
*** r_friedman has quit IRC
|
17:07:31
|
*** chopin__ has joined #openmrs
|
17:07:44
|
*** chopin__ is now known as jkeiper
|
17:08:05
|
*** ChanServ sets mode: +v jkeiper
|
17:09:41
|
*** ksinkar has joined #openmrs
|
17:10:12
|
<kavuri> rafa: how to enable ssl in eclipse?
|
17:10:34
|
<rafa> in eclipse?
|
17:12:58
|
<kavuri> rafa: yes, I doubt if running webapp in eclipse would use tomcat configuration in my ubuntu host
|
17:14:02
|
*** r0bby has quit IRC
|
17:14:08
|
<rafa> kavuri: do you want to configure tomcat to run with ssl from eclipse for development?
|
17:14:17
|
<rafa> kavuri: why would one need that?
|
17:14:26
|
*** r0bby has joined #openmrs
|
17:14:26
|
*** ChanServ sets mode: +v r0bby
|
17:14:42
|
<kavuri> rafa: hmm..thats how I am testing it
|
17:15:02
|
<kavuri> rafa: or what would be the easiest way ?
|
17:15:11
|
<rafa> kavuri: well you can run tomcat outside of eclipse and debug remotely
|
17:15:38
|
<rafa> see debug configurations -> remote java application
|
17:15:42
|
<kavuri> rafa: deploying openmrs.war everytime to tomcat is tedious..thought eclipse would help
|
17:16:25
|
<rafa> kavuri: I don't know how to help you
|
17:16:37
|
<kavuri> rafa: thats fine..I will figure out
|
17:16:57
|
<kavuri> rafa: when I run webapp in eclipse, it starts the jetty server without ssl
|
17:17:18
|
*** shanakaf has joined #openmrs
|
17:17:30
|
*** r0bby has quit IRC
|
17:19:32
|
*** downey has joined #openmrs
|
17:19:32
|
*** ChanServ sets mode: +o downey
|
17:19:32
|
*** OpenMRSBot sets mode: +o downey
|
17:19:38
|
*** Rahul has quit IRC
|
17:25:29
|
*** MarkG has quit IRC
|
17:25:42
|
*** MarkG has joined #openmrs
|
17:28:01
|
*** dawn_ has quit IRC
|
17:28:02
|
*** dawn__ has joined #openmrs
|
17:28:06
|
*** ChanServ sets mode: +v dawn__
|
17:29:16
|
*** r0bby has joined #openmrs
|
17:29:16
|
*** ChanServ sets mode: +v r0bby
|
17:30:11
|
*** r0bby is now known as r0bby|OpenMRS
|
17:31:10
|
*** MarkG has quit IRC
|
17:31:53
|
<djazayeri> Back
|
17:31:56
|
<djazayeri> Feeling 1000% better
|
17:32:33
|
*** r0bby|OpenMRS is now known as OpenMRS|r0bby
|
17:33:43
|
*** mseaton has joined #openmrs
|
17:33:43
|
*** ChanServ sets mode: +v mseaton
|
17:34:35
|
*** MarkG has joined #openmrs
|
17:37:45
|
*** isharap has joined #openmrs
|
17:39:04
|
*** MarkG has quit IRC
|
17:39:58
|
*** MarkG has joined #openmrs
|
17:42:10
|
<dawn__> bwolfe: and djazayeri : what would you suggest as the best resources to send to the business analyst to get caught up to speed with OpenMRS?
|
17:42:31
|
*** dileepsisila has quit IRC
|
17:43:21
|
<bwolfe> djazayeri, 100% better? were you that drained or was your early morning nap that good? :-)
|
17:43:29
|
<bwolfe> dawn__, up to speed as far as dev or just about openmrs?
|
17:43:36
|
*** wyclif has quit IRC
|
17:43:43
|
<djazayeri> bwolfe: I was that drainedâyesterday I basically worked from 7am to 3am
|
17:43:48
|
<dawn__> bwolfe: dev stuff
|
17:44:11
|
<OpenMRS|r0bby> hey dawn__
|
17:44:56
|
<dawn__> OpenMRS|r0bby: hi robby! how are you?
|
17:45:21
|
*** downey is now known as OpenMRS|downey-a
|
17:45:30
|
*** OpenMRS|downey-a is now known as OpenMRS|downey
|
17:47:07
|
<OpenMRS|r0bby> good
|
17:50:24
|
<djazayeri> dawn__: dev in general, or what we happen to be working on now, and in the near future?
|
17:51:05
|
<dawn__> djazayeri: bwolfe : what comes to mind for me is the sprint schedule, perhaps data model would be helpful, looking at JIRA should be useful as well. these are the only things coming to mind
|
17:52:27
|
<jkeiper> djazayeri, 1000% is just a fancy way to say 10x
|
17:52:38
|
<bwolfe> "look at jira" is not useful :-p
|
17:52:57
|
<bwolfe> 100% == 2x
|
17:54:47
|
<dawn__> bwolfe: i know this. that's why i'm asking you as a lead dev what information within JIRA would be helpful for him to review
|
17:55:11
|
<dawn__> bwolfe: from the perspective of a BA
|
17:55:30
|
<djazayeri> dawn__: release process
|
17:57:10
|
<bwolfe> hmm, not sure anything in jira is helpful. except maybe some example sprint dashboards
|
17:58:35
|
*** wyclif has joined #openmrs
|
17:58:41
|
<bwolfe> dawn__, "about" page on openmrs.org. "technical overview" page in openmrs wiki. "data model" page in openmrs wiki, "release Process" page in wiki. "sprint scheudule" "how to be a sprint leader"
|
17:59:58
|
<dawn__> bwolfe: and djazayeri thanks. anything else?
|
18:00:09
|
* dawn__ writes the email and adds ben and darius
|
18:00:21
|
* dawn__ has a meeting
|
18:00:30
|
*** dawn__ has quit IRC
|
18:02:24
|
*** downey has joined #openmrs
|
18:02:24
|
*** ChanServ sets mode: +o downey
|
18:02:24
|
*** OpenMRSBot sets mode: +o downey
|
18:04:17
|
<OpenMRS|r0bby> hey downey
|
18:04:19
|
<OpenMRS|r0bby> lol
|
18:04:35
|
<downey> Hi OpenMRS|r0bby and welcome to the #openmrs IRC channel.
|
18:04:46
|
<OpenMRS|r0bby> wtf lol
|
18:04:49
|
<OpenMRS|r0bby> LOL
|
18:04:55
|
*** OpenMRS|downey has quit IRC
|
18:05:03
|
*** downey is now known as OpenMRS|downey
|
18:05:37
|
*** OpenMRS|downey has quit IRC
|
18:08:20
|
*** dawn_ has joined #openmrs
|
18:08:20
|
*** ChanServ sets mode: +v dawn_
|
18:09:09
|
*** dawn__ has joined #openmrs
|
18:09:09
|
*** ChanServ sets mode: +v dawn__
|
18:11:44
|
*** james_regen has quit IRC
|
18:12:34
|
*** dawn_ has quit IRC
|
18:12:34
|
*** dawn__ is now known as dawn_
|
18:17:09
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: #FF @IntraHealthOPEN - changing the way the world thinks about health, technology & the developing world. http://t.co/iB9FYauW #SwitchPoint <http://twitter.com/OpenMRS/statuses/193391409640906753>
|
18:18:42
|
*** dawn__ has joined #openmrs
|
18:18:42
|
*** ChanServ sets mode: +v dawn__
|
18:18:42
|
*** dawn_ has quit IRC
|
18:18:42
|
*** dawn__ is now known as dawn_
|
18:29:06
|
*** nadee has joined #openmrs
|
18:32:04
|
*** jkeiper has quit IRC
|
18:35:39
|
*** dawn_ has quit IRC
|
18:45:21
|
*** downey has joined #openmrs
|
18:45:21
|
*** OpenMRSBot sets mode: +o downey
|
18:45:21
|
*** ChanServ sets mode: +o downey
|
18:45:39
|
*** downey is now known as OpenMRS|downey
|
18:47:16
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @downey: If you want a creative solution, take a zero off the budget. - @caseycaplowe at #SwitchPoint <http://twitter.com/OpenMRS/statuses/193400883030130688>
|
18:48:20
|
<bwolfe> OpenMRS|downey, how do you take a 0 off of a $0.0 budget? :-/
|
18:48:31
|
<OpenMRS|downey> bwolfe: Nothing is free. :)
|
18:48:45
|
<OpenMRS|r0bby> OpenMRS: you got 100% of $0.00
|
18:49:27
|
<OpenMRS|r0bby> you know what's free
|
18:49:29
|
<OpenMRS|r0bby> love
|
18:49:33
|
<OpenMRS|r0bby> LOVE IS FREE!
|
18:49:37
|
<OpenMRS|r0bby> 420!
|
18:50:17
|
*** dawn_ has joined #openmrs
|
18:50:17
|
*** ChanServ sets mode: +v dawn_
|
18:51:07
|
*** dawn__ has joined #openmrs
|
18:51:07
|
*** ChanServ sets mode: +v dawn__
|
18:51:07
|
*** dawn_ has quit IRC
|
18:51:09
|
*** dawn__ is now known as dawn_
|
18:54:42
|
*** shanakaf has quit IRC
|
19:02:51
|
*** maro has joined #openmrs
|
19:06:34
|
*** finbrein has quit IRC
|
19:10:11
|
*** dawn_ has quit IRC
|
19:14:41
|
*** wyclif has quit IRC
|
19:17:34
|
*** lh has quit IRC
|
19:18:53
|
*** dawn_ has joined #openmrs
|
19:18:53
|
*** ChanServ sets mode: +v dawn_
|
19:20:43
|
*** Mkop has quit IRC
|
19:21:34
|
*** dawn__ has joined #openmrs
|
19:21:34
|
*** ChanServ sets mode: +v dawn__
|
19:23:19
|
*** dawn_ has quit IRC
|
19:25:47
|
*** dawn__ has quit IRC
|
19:35:22
|
*** maro is now known as finbrein
|
19:39:11
|
*** lh has joined #openmrs
|
19:42:40
|
*** OpenMRS|downey is now known as downey
|
19:42:45
|
*** OpenMRS|r0bby is now known as r0bby
|
19:46:06
|
<r0bby> cya all
|
19:46:06
|
*** r0bby has left #openmrs
|
19:47:12
|
*** isharap has quit IRC
|
19:47:15
|
*** kavuri has quit IRC
|
19:49:39
|
*** cpower has joined #openmrs
|
19:50:20
|
*** rohitgoyal18 has quit IRC
|
20:02:06
|
*** rohitgoyal18 has joined #openmrs
|
20:02:26
|
*** nadee has quit IRC
|
20:07:05
|
*** bryq has quit IRC
|
20:09:07
|
*** rohitgoyal18 has quit IRC
|
20:12:09
|
*** wyclif has joined #openmrs
|
20:24:44
|
*** r_friedman has joined #openmrs
|
20:24:59
|
<r_friedman> rafa, can't believe you're still awake!
|
20:25:50
|
<bwolfe> its not even midnight in poland yet...
|
20:26:04
|
<bwolfe> although it is a friday night. lets hope he's on IRC on his phone from a bar. ;-)
|
20:26:23
|
<rafa> bwolfe: haha
|
20:26:29
|
<rafa> bwolfe: I'm home
|
20:26:44
|
<r_friedman> rafa, got your e-mail, thanks a lot ... did you update the ws dependency to 1.0?
|
20:27:18
|
<rafa> r_friedman: no it's still 0.9-SNAPSHOT
|
20:27:37
|
<r_friedman> rafa, good ... i didn't know the interface had changed, what did I miss?
|
20:28:14
|
<rafa> r_friedman: RESTWS-211 I think
|
20:29:09
|
<r_friedman> oh, i didn't know it had been done, i thought it was awaitng the spring
|
20:29:10
|
<r_friedman> sprint
|
20:29:45
|
<rafa> r_friedman: we're sprinting right now ;)
|
20:30:03
|
<r_friedman> rafa, yes :) but i thought the sprint was 1.0, not 0.9
|
20:30:09
|
*** dawn_ has joined #openmrs
|
20:30:09
|
*** ChanServ sets mode: +v dawn_
|
20:30:12
|
*** dawn_ has quit IRC
|
20:30:31
|
<r_friedman> rafa, although with all darius' changes, guess it will have to be 0.92
|
20:30:42
|
<rafa> r_friedman: 0.9 was not released actually
|
20:30:47
|
<rafa> r_friedman: or I missed something
|
20:31:05
|
<r_friedman> rafa, it may not have been released but it's buildable
|
20:31:21
|
<djazayeri> no, 0.9 was not released because r_friedman didn't want us to. :-)
|
20:31:37
|
<rafa> r_friedman: here you go :)
|
20:31:59
|
<r_friedman> djazayeri: well, why didn't you not release it without 211?
|
20:32:52
|
<djazayeri> r_friedman: I wanted to release it as <1.0. ;-)
|
20:33:26
|
<r_friedman> djazayeri: i'm not interested in what you wanted to release, i'm interested in what you wanted to not release
|
20:33:27
|
<djazayeri> Anyway, the current plan is to get, probably not by the end of today, but by early next week, to "1.0 RC".
|
20:33:39
|
<djazayeri> r_friedman: too many negatives, I'm confused
|
20:34:09
|
<djazayeri> Perhaps we'll call it 0.9.5.
|
20:34:18
|
<r_friedman> djazayeri: read the trial of Clevinger in Catch-22
|
20:35:46
|
<djazayeri> r_friedman: I'll reread it after we get 1.0 out. :-)
|
20:37:00
|
<r_friedman> djazayeri: actually from reading your code this morning, it looks like it's really easy, I just send you the whole pile of crap as a NeedsPaging
|
20:37:44
|
*** didymo has joined #openmrs
|
20:38:04
|
<djazayeri> r_friedman: what ticket is this about? (and yes, you basically just return a NeedsPaging if there isn't an underlying service method that can do it faster)
|
20:38:16
|
<didymo> God Morning One and all
|
20:38:20
|
<didymo> Good
|
20:38:23
|
<didymo> sorry
|
20:38:27
|
<didymo> Good Morning
|
20:38:46
|
<djazayeri> good morning
|
20:38:50
|
<r_friedman> djazayeri: 211 but speaking of which, who enforces the max records limit, does that go on inside ws rest or is it up to the service?
|
20:39:16
|
<djazayeri> r_friedman: I think that WS enforces it. I forget exactly where.
|
20:39:31
|
<djazayeri> i.e. if you try to request a page size of 1000000000, then you'll get back BAD_REQUEST
|
20:39:38
|
*** mseaton has left #openmrs
|
20:53:47
|
*** bwolfe_ has joined #openmrs
|
20:53:47
|
*** ChanServ sets mode: +o bwolfe_
|
20:57:31
|
*** bwolfe has quit IRC
|
20:58:02
|
*** bwolfe_ has quit IRC
|
21:09:06
|
<didymo> djazayeri did you get my email OK? Just making sure I used the correct email address.
|
21:14:03
|
*** MarkG has left #openmrs
|
21:15:35
|
*** suranga has quit IRC
|
21:16:23
|
*** cpower has quit IRC
|
21:19:15
|
*** snoppy has quit IRC
|
21:21:28
|
<djazayeri> didymo: yes I did
|
21:21:53
|
<djazayeri> can we talk early next week?
|
21:22:09
|
<djazayeri> I need to look at my schedule.
|
21:26:00
|
*** sgithens_ has quit IRC
|
21:26:50
|
<djazayeri> didymo: also i'd like to loop bwolfe in
|
21:47:07
|
<didymo> djazayeri: sure the more the merrier
|
21:47:37
|
<didymo> if we make it Tuesday Mornig my time Monday afternoon your time??
|
21:50:17
|
<didymo> djazayeri: on my way to the Gym, I'll back back in about an hour and a half to two hours if you are still awake, we can confirm phone times by email or here
|
21:50:32
|
<djazayeri> didymo: I'm sending an email now
|
21:50:38
|
<didymo> Have a Great "Evening"??
|
21:50:40
|
<djazayeri> I'll include your time suggestion in it
|
21:50:42
|
<didymo> thanks
|
21:50:48
|
<djazayeri> didymo: I'm in Seattle, so it's afternoon.
|
21:50:49
|
<djazayeri> ciao
|
21:50:53
|
<didymo> ttfn
|
21:51:08
|
<didymo> Wollongong South of Sydney Australia
|
21:51:17
|
<didymo> about 80km south or 50 miles
|
22:15:48
|
*** rafa has quit IRC
|
22:57:16
|
*** wyclif has quit IRC
|
22:58:27
|
*** mseaton has joined #openmrs
|
22:58:27
|
*** ChanServ sets mode: +v mseaton
|
23:01:41
|
*** mseaton has left #openmrs
|
23:02:39
|
*** lh has quit IRC
|
23:07:16
|
<finbrein> djazayeri: Is it okay if include uniquenessBehavior?
|
23:07:37
|
<djazayeri> finbrein: why do you ask?
|
23:07:49
|
<finbrein> djazayeri: one of the properties in the PatientIdentifierType class
|
23:08:02
|
<finbrein> djazayeri: i saw your comment
|
23:08:15
|
<djazayeri> finbrein: Is it @since 1.9? If so, and we do include it, we need to add it to the allowedMissingProperties list
|
23:08:37
|
<djazayeri> finbrein: it's an enum, and I think the framework handles those fine, so I think we should add it.
|
23:08:39
|
<finbrein> djazayeri: yes
|
23:18:47
|
*** lh has joined #openmrs
|
23:20:15
|
*** morristic has joined #openmrs
|
23:33:55
|
*** r_friedman is now known as r_friedman_away
|
23:48:08
|
*** deadpool has quit IRC
|
23:52:43
|
*** ksinkar has quit IRC
|