IRC Chat : 2012-04-19 - OpenMRS

00:00:03 *** mseaton has left #openmrs
00:07:49 *** djazayeri1 has joined #openmrs
00:09:05 *** djazayeri has quit IRC
00:22:28 *** djazayeri1 is now known as djazayeri
00:22:28 *** ChanServ sets mode: +o djazayeri
01:56:51 *** harshadura has joined #openmrs
01:56:58 *** carloshpf has quit IRC
02:08:08 *** harshadura has quit IRC
02:14:05 *** bwolfe has joined #openmrs
02:14:05 *** ChanServ sets mode: +o bwolfe
02:24:44 <robbyoconnor> hai bwolfe
02:27:13 <bwolfe> hi r1bby
02:42:23 <robbyoconnor> why did you pick the 1?
02:48:02 <bwolfe> 1 > 0
02:52:11 *** upul` has joined #openmrs
02:52:11 *** ChanServ sets mode: +v upul`
03:00:40 *** djazayeri1 has joined #openmrs
03:02:08 *** djazayeri has quit IRC
03:07:12 *** finbrein has quit IRC
03:44:41 *** isharapremadasa has joined #openmrs
03:47:42 *** isharapremadasa is now known as isharap
03:49:35 *** bwolfe has quit IRC
03:50:40 *** djazayeri1 is now known as djazayeri
03:50:40 *** ChanServ sets mode: +o djazayeri
04:03:32 *** sk has joined #openmrs
04:06:15 *** finbrein has joined #openmrs
04:07:06 *** finbrein has quit IRC
04:27:31 *** isharap has quit IRC
05:03:11 *** Rahul has joined #openmrs
05:08:16 *** bryq has joined #openmrs
05:08:16 *** ChanServ sets mode: +v bryq
05:19:34 *** shripad has joined #openmrs
05:19:49 <shripad> Hi
05:20:04 <shripad> has anybody run FindBug on MRS source code
05:23:03 *** bryq has quit IRC
05:42:30 *** shripad has left #openmrs
06:06:41 *** isharapremadasa has joined #openmrs
06:14:53 *** finbrein has joined #openmrs
06:20:19 *** kishoreyekkanti has joined #openmrs
06:26:38 *** kishoreyekkanti has quit IRC
06:26:52 *** kishoreyekkanti has joined #openmrs
06:53:57 *** sk has quit IRC
07:06:17 *** sk has joined #openmrs
07:13:03 *** antonalsekeiev has joined #openmrs
07:26:26 <antonalsekeiev> Greetings! I moved my GSoC page into "Human Resouce Module" section in openmrs documentation as my possible mentor Roger Friedman told me. But recently administrators moved this page back to my home space. I moved it back into "Human Resource Module" section today
07:27:31 *** antonalsekeiev has quit IRC
07:31:02 *** harshadura has joined #openmrs
07:35:49 *** dkayiwa has joined #openmrs
07:40:23 *** harshadura has quit IRC
07:50:33 *** rafa has joined #openmrs
07:50:33 *** ChanServ sets mode: +v rafa
07:50:48 *** maro has joined #openmrs
07:52:18 *** maro has quit IRC
07:52:36 *** maro has joined #openmrs
07:54:23 *** finbrein has quit IRC
07:57:27 *** maro has quit IRC
07:58:03 *** finbrein has joined #openmrs
07:59:01 *** finbrein has joined #openmrs
08:04:18 *** rafa has quit IRC
08:04:59 *** maro has joined #openmrs
08:08:28 *** finbrein has quit IRC
08:09:02 *** bryq has joined #openmrs
08:09:02 *** ChanServ sets mode: +v bryq
08:24:40 *** maro has quit IRC
08:25:18 *** finbrein has joined #openmrs
08:27:55 *** maro has joined #openmrs
08:30:50 *** finbrein has quit IRC
08:31:48 *** rafa has joined #openmrs
08:31:48 *** ChanServ sets mode: +v rafa
08:36:49 *** kishoreyekkanti has quit IRC
08:37:52 *** kishoreyekkanti has joined #openmrs
08:39:25 <maro> Hi rafa: can i go ahead and modify the resource and sub-resource names in RESTWS-204 from plural to singular? I can see you have already made changes in the wiki.
08:39:53 <rafa> maro: I did that in the code as well
08:39:56 <rafa> maro: did you update?
08:40:04 <maro> rafa: @SubResource(parent = CohortResource.class, path = "members") , changing the "members" to "member" for example
08:40:11 <maro> rafa: no
08:40:18 <rafa> maro: the wiki is generated from the code btw ;)
08:40:25 <maro> rafa: then the problem is solved already
08:40:38 <rafa> maro: true ;)
08:40:42 <maro> rafa:true, i remember
08:41:27 <maro> rafa: i will unassign, i guess you should assign to yourself after and close it
08:41:50 <rafa> !ticket RESTWS-204
08:41:52 <OpenMRSBot> rafa: [#RESTWS-204] Standardize resource name casing - OpenMRS JIRA - https://tickets.openmrs.org/browse/RESTWS-204
08:42:59 <rafa> maro: I did that as part of https://tickets.openmrs.org/browse/RESTWS-210
08:43:35 <rafa> maro: RESTWS-204 relates to different things
08:45:59 <rafa> maro: btw where are you based?
08:46:36 <maro> rafa: Vaasa, Finland
08:46:58 <maro> rafa: stay in helsinki sometimes
08:48:00 <rafa> maro: nice, I've never been there
08:48:30 <rafa> maro: I'm quite close, Gdansk, Poland :)
08:48:50 *** isharapremadasa has quit IRC
08:49:01 <maro> rafa: you are welcome to visit, i can be there in Poland for a visit too! ;)
08:50:33 <rafa> maro: sure I will
08:50:46 <rafa> maro: let me know when you're coming :)
08:51:07 <maro> rafa: ok, I'll
08:52:34 *** rafa has quit IRC
09:01:43 *** bryq has quit IRC
09:11:14 *** snoppy has joined #openmrs
09:34:39 *** sk has quit IRC
09:39:09 *** bryq has joined #openmrs
09:39:09 *** ChanServ sets mode: +v bryq
09:52:22 *** sk has joined #openmrs
09:53:53 *** bryq has quit IRC
10:10:26 *** upul` has quit IRC
10:15:00 *** Rahul has left #openmrs
10:18:19 *** didymo has quit IRC
10:29:30 *** kishoreyekkanti_ has joined #openmrs
10:30:36 *** kishoreyekkanti_ has quit IRC
10:31:39 *** kishoreyekkanti has quit IRC
10:46:45 *** sk has quit IRC
10:48:57 *** rafa has joined #openmrs
10:48:57 *** ChanServ sets mode: +v rafa
10:51:40 *** snoppy has quit IRC
10:55:39 *** kishoreyekkanti has joined #openmrs
10:56:15 *** downey has joined #openmrs
10:56:15 *** ChanServ sets mode: +o downey
10:56:15 *** OpenMRSBot sets mode: +o downey
10:58:38 *** james_regen has joined #openmrs
10:58:38 *** ChanServ sets mode: +v james_regen
10:59:58 <downey> kishoreyekkanti++
11:00:11 <downey> kishoreyekkanti: good news about the tests, thanks!
11:00:49 <kishoreyekkanti> downey: no issues. btw. How are you! Its been a long time :)
11:01:06 <downey> kishoreyekkanti: am doing good thanks. how about you?
11:01:19 <kishoreyekkanti> downey: yep, me too doing great!
11:02:40 <downey> kishoreyekkanti: cool. :) hey let me ask you, we are getting access to some testing tools neoload & dynatrace courtesy indiana university. do you know anyone good at TW who could join one of their people for a talk about performance/load testing strategy? i will also talk to wishnie but thought you might know someone too
11:04:30 *** snoppy has joined #openmrs
11:04:47 <kishoreyekkanti> downey: hm.. there are good amount of people who can help you on that bit. Not sure who will be available during the discussion. As you said, wishnie would be the right person. btw is the physical presence needed for the talk?
11:05:04 <downey> kishoreyekkanti: no sorry, just during one of our weekly phone conferences
11:06:11 <kishoreyekkanti> downey: cool. that would be more easier to handle. Anyways i'll leave that to wishnie.
11:06:57 <kishoreyekkanti> downey: I know couple of people who were doing this strategy. I'll ask them first if they have some time to join the call. When would be this call happening?
11:07:46 <downey> kishoreyekkanti: not until sometime in june
11:10:10 <kishoreyekkanti> downey: Oh cool thats good amount of time. so, the expectation would be some one who can discuss and help in the strategy or join the call to explain what are some of the best practices to follow during performance/load testing
11:10:49 <downey> kishoreyekkanti: well we want people to start thinking about how performance & load testing is done, the goals, how you design tests, etc. the IU person would speak more about the specifics of their tools, i imagine
11:11:48 *** snoppy has quit IRC
11:12:48 <kishoreyekkanti> downey: cool. I'll keep this in my mind and talk to people around regarding the same. When ever you have some idea on the date, please let me know.
11:13:05 <downey> kishoreyekkanti: yup will let yo uknow
11:17:05 *** sk has joined #openmrs
11:17:12 <downey> Hi sk and welcome to the #openmrs IRC channel.
11:22:29 <sk> thanks downey
11:22:41 <sk> downey: I also go by the id kavuri
11:22:45 <sk> :)
11:22:53 <downey> sk: oh cool. welcome back :)
11:26:22 *** rafa has quit IRC
11:28:48 *** rafa has joined #openmrs
11:28:48 *** ChanServ sets mode: +v rafa
11:34:11 *** bwolfe has joined #openmrs
11:34:11 *** ChanServ sets mode: +o bwolfe
11:37:08 *** sk has quit IRC
11:52:47 *** maro has quit IRC
11:53:02 *** maro has joined #openmrs
11:53:08 <downey> Hi maro and welcome to the #openmrs IRC channel.
11:53:40 <maro> Hi downey, maro=finbrein ;)
11:53:52 <downey> maro: oh hi :)
11:55:27 <maro> downey: seems there is a a convention here, initial of the given name concatenated with the last name
11:55:55 <downey> maro: it's a fairly common one, but not always :)
11:58:40 <maro> rafa: In "/webservices.rest-omod/src/main/java/org/openmrs/module/webservices/rest/web/v1_0/controller/PersonAddressController.java" of the RESTWS, Line 27: @RequestMapping(value = "/rest/" + RestConstants.VERSION_1 + "/person/{parentUuid}/addresse")
11:59:17 <rafa> maro: thx
11:59:21 <maro> rafa: the "addresse"? = address
11:59:42 <rafa> maro: yes, I'll fix that.
12:00:19 <rafa> maro: done
12:03:07 *** Jibesh has joined #openmrs
12:03:53 *** Jibesh has left #openmrs
12:13:40 *** chopin has joined #openmrs
12:14:28 <chopin> dkayiwa, hey man
12:14:37 <dkayiwa> hey chopin
12:14:44 <chopin> dkayiwa, :-D
12:14:53 <dkayiwa> chopin: :D
12:14:56 <chopin> dkayiwa, do you have a way to check for an existing patient based on the uuid?
12:15:18 <dkayiwa> chopin: not implemented but possible :)
12:20:43 *** wyclif has quit IRC
12:30:48 *** sunbiz has joined #openmrs
12:30:48 *** ChanServ sets mode: +v sunbiz
12:44:28 <chopin> dkayiwa, should i make a ticket for it? I'd like to refer to uuids when i export data as xforms
12:44:39 <chopin> dkayiwa, also wondered if we could include a uuid attribute in the <form/> tag
12:46:20 <dkayiwa> chopin: yes
12:48:53 <chopin> ok, i'll add tickets for tose
12:48:54 <chopin> those
12:48:55 <chopin> heh
12:49:51 <dkayiwa> chopin: 8)
12:52:30 *** wyclif has joined #openmrs
13:01:27 *** chopin has quit IRC
13:03:37 *** wyclif has quit IRC
13:03:48 *** chopin_ has joined #openmrs
13:04:07 *** chopin has joined #openmrs
13:06:13 *** MarkG has joined #openmrs
13:07:26 *** nribeka has joined #openmrs
13:07:26 *** ChanServ sets mode: +v nribeka
13:10:56 *** kishoreyekkanti has quit IRC
13:15:39 *** chopin_ is now known as jkeiper
13:15:46 *** ChanServ sets mode: +v jkeiper
13:16:14 *** kishoreyekkanti has joined #openmrs
13:26:07 *** harshadura has joined #openmrs
13:34:17 *** kishoreyekkanti has joined #openmrs
13:39:44 *** mvorobey has joined #openmrs
13:40:28 <mvorobey> hi all
13:41:00 <dkayiwa> hi mvorobey :)
13:41:20 <mvorobey> dkayiwa, how is it going?
13:41:37 <dkayiwa> mvorobey: not bad. and you?
13:42:20 *** bwolfe has quit IRC
13:42:33 <mvorobey> dkayiwa, good-good too :) spring is about to really begin so my mood gets better and better :)
13:42:48 <dkayiwa> mvorobey: :D
13:43:21 <dkayiwa> mvorobey: here all the time is good weather :)
13:43:58 <mvorobey> dkayiwa, :) and what season of the year is in Uganda now ?
13:44:40 <dkayiwa> mvorobey: we have only wet and dry seasons :)
13:44:56 <dkayiwa> mvorobey: difference being rainfall :)
13:45:15 <dkayiwa> mvorobey: temperatures almost the same
13:45:37 <mvorobey> dkayiwa, oh, is it warm ?
13:46:00 <dkayiwa> mvorobey: yes
13:46:06 <mvorobey> dkayiwa, we are having something about a cold wet spring now
13:46:16 <dkayiwa> mvorobey: ok
13:46:46 <mvorobey> dkayiwa, ok Daniel :D thanks for sharing with me
13:46:58 <dkayiwa> mvorobey: you too :)
13:47:52 <mvorobey> dkayiwa, it is every time a big pleasant to talk with you about anything :)
13:48:04 <mvorobey> pleasure
13:48:23 <dkayiwa> mvorobey: hahahahah :)
13:49:12 <mvorobey> dkayiwa, is not it ? :) you are funny guy :D
13:49:37 <mvorobey> dkayiwa, me too :D
13:50:39 *** isharapremadasa has joined #openmrs
13:51:51 *** isharapremadasa is now known as isharap
13:52:37 <dkayiwa> mvorobey: i have never been so d:)
13:53:43 <mvorobey> dkayiwa, oh, really, the am confused you with another else dkayiwa :)
13:53:53 <mvorobey> then
13:54:50 *** wyclif has joined #openmrs
13:55:03 <dkayiwa> mvorobey: :D
13:55:13 <mvorobey> dkayiwa, with another fun and cheerful dkayiwa, sorry :)
13:55:43 <dkayiwa> mvorobey: hahaha. you are funnier [:)
13:56:05 <mvorobey> dkayiwa, may be :D
13:56:11 *** kishoreyekkanti has quit IRC
13:59:29 *** bwolfe has joined #openmrs
13:59:29 *** ChanServ sets mode: +o bwolfe
13:59:42 *** wyclif has quit IRC
14:00:55 *** maro is now known as finbrein
14:00:56 *** wyclif has joined #openmrs
14:06:17 *** sgithens_ has joined #openmrs
14:07:56 *** skathol has joined #openmrs
14:08:04 <downey> Hi skathol and welcome to the #openmrs IRC channel.
14:08:37 *** mccallumg has joined #openmrs
14:08:37 *** ChanServ sets mode: +v mccallumg
14:15:22 *** skathol has left #openmrs
14:17:18 *** bwolfe has quit IRC
14:17:53 <sunbiz> djazayeri: u here??
14:17:54 *** chopin has quit IRC
14:17:59 *** jkeiper has quit IRC
14:18:01 <djazayeri> yes, on the dev call
14:18:08 <sunbiz> oppss... thu today
14:19:09 *** chopin has joined #openmrs
14:19:20 *** jkeiper has joined #openmrs
14:20:00 <sunbiz> djazayeri: the unit tests are failing now...
14:20:08 <sunbiz> because they want to do size on SimpleObject
14:20:29 *** bryq has joined #openmrs
14:20:29 *** ChanServ sets mode: +v bryq
14:20:30 <sunbiz> mayb I can override the size method in SimpleObject
14:20:30 <djazayeri> sunbiz: oh, you mean that tens/hundreds fail if you make that change?
14:20:39 <sunbiz> nope... 8 tests
14:20:42 *** jkeiper has quit IRC
14:21:09 <sunbiz> SimpleObject size should calculate the internal objects size, not results... which will always be 1
14:21:29 <sunbiz> djazayeri: so... I can override the SimpleObject's size method
14:21:48 <sunbiz> to calculate the real size
14:21:54 <sunbiz> is that acceptable solution??
14:22:41 <djazayeri> sunbiz: must things look at a SimpleObject? Or can they look at a SearchResult?
14:22:50 <djazayeri> sunbiz: what test are you looking at?
14:23:22 <sunbiz> it returns a SimpleObject
14:23:24 <sunbiz> getAll
14:23:37 *** bwolfe has joined #openmrs
14:23:37 *** ChanServ sets mode: +o bwolfe
14:23:43 <djazayeri> getAll on a base interface?
14:23:44 <sunbiz> it works fine... just the unit tests failing
14:25:24 *** nribeka has quit IRC
14:25:49 <djazayeri> sunbiz: looking at the "Listable" interface, it has getAll returns a List<Object>
14:26:01 <djazayeri> sunbiz: shouldn't that change to have getAll return SearchResult
14:26:28 <sunbiz> I've changed it to return NeedsPaging
14:26:43 <djazayeri> sunbiz: I think it should return SearchResult, since they don't necessarily always need paging.
14:26:56 <sunbiz> getAll should always need paging
14:27:02 <sunbiz> can it already be paged ever??
14:27:27 <djazayeri> sunbiz: I think we _should_ hope to support AlreadyPaged too, since otherwise it's too easy to do DoS
14:27:31 <djazayeri> what tests call size of getall?
14:27:35 <sunbiz> atleast that's what I thought
14:27:53 <sunbiz> shouldListAllUsers
14:27:59 <sunbiz> shouldListAllUnRetiredDrugs
14:28:02 <sunbiz> etc...
14:28:25 <djazayeri> SearchResult is just the superclass of NeedsPaging, so that's not a big deal to switch
14:28:34 <sunbiz> sure...
14:28:50 <sunbiz> just it sounds like "Search" "Result"
14:29:04 <sunbiz> and its not necessarily searching
14:29:32 <djazayeri> sunbiz: fair point, we could rename it to PageableResults (or something)
14:29:58 <djazayeri> sunbiz: looking at BaseCrudController.getAll, it returns a List<Object> but I think that needs to be refactored to return a SimpleObject
14:30:09 <sunbiz> thats what I've done now
14:30:36 *** mseaton has joined #openmrs
14:30:36 *** ChanServ sets mode: +v mseaton
14:30:36 <sunbiz> and thats when the tests result.size fails
14:30:50 <sunbiz> so... overriding the size will make it easy
14:30:58 <djazayeri> sunbiz: no, don't override size on SimpleObject
14:31:12 <sunbiz> djazayeri: why??
14:31:29 <djazayeri> sunbiz: because a SimpleObject is not necessarily a list of results
14:31:44 <djazayeri> sunbiz: Change the 8 unit tests so they're actually testing the right thing
14:32:23 <djazayeri> in this case you can do PropertyUtils.getProperty(result, "results")
14:32:25 <djazayeri> and then test size() on that
14:32:45 <sunbiz> djazayeri: true
14:32:52 <sunbiz> thanks
14:45:12 *** Rahul has joined #openmrs
14:45:19 *** pulasthi7 has joined #openmrs
14:51:24 *** Rahul has quit IRC
14:52:48 <mccallumg> downey: I heard my name about 5 minutes ago (I was on another call at the time)
14:52:49 *** sgithens_ has quit IRC
14:53:04 <downey> mccallumg: hey. :)
14:53:25 <mccallumg> downey: hi
15:01:23 *** bwolfe_ has joined #openmrs
15:01:23 *** ChanServ sets mode: +o bwolfe_
15:02:10 *** bwolfe has quit IRC
15:03:58 <sunbiz> djazayeri: lemme also rename to PageableResults part of the same ticket??
15:04:26 <djazayeri> sunbiz: okay
15:05:58 *** chopin has quit IRC
15:07:03 *** downey_ has joined #openmrs
15:07:03 *** ChanServ sets mode: +o downey_
15:07:04 *** downey has quit IRC
15:07:04 *** downey_ is now known as downey
15:07:55 *** wyclif has quit IRC
15:09:00 *** bwolfe_ has quit IRC
15:09:05 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: HTML Form Entry 1.9.3 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=htmlformentry&ampversion=&amp1.9.3>
15:09:28 <rafa> djazayeri: hey, RESTWS-226 is waiting on a green light before I actually start to change resources :)
15:09:43 *** jkeiper has joined #openmrs
15:10:07 *** wyclif has joined #openmrs
15:10:23 <djazayeri> rafa: on a call, will try to peek now
15:10:27 <djazayeri> !ticket restws-226
15:10:28 <OpenMRSBot> djazayeri: [#RESTWS-226] Resources need to specify what fields are editable, not blindly expose all delegate properties - OpenMRS JIRA - https://tickets.openmrs.org/browse/restws-226
15:11:20 <djazayeri> rafa: you want the code reviewed?
15:11:38 <djazayeri> or did you have a question?
15:11:45 <rafa> djazayeri: just say if it's what you wanted
15:12:03 <rafa> djazayeri: look at the code
15:14:08 <rafa> djazayeri: Roger actually wants not to fail if wrong properties provided, but just skip updating them
15:14:20 <djazayeri> I disagree with roger there
15:14:41 <rafa> me too
15:16:15 <sunbiz> I see a lot of unit test error
15:16:26 <sunbiz> for the webservices.rest module
15:16:29 <rafa> sunbiz: my fault
15:16:33 <sunbiz> I didnt do tht
15:16:34 <sunbiz> :D
15:17:05 <rafa> sunbiz: I hope to fix it in the next few hours :)
15:18:15 *** lh has joined #openmrs
15:18:15 *** lh has quit IRC
15:18:15 *** lh has joined #openmrs
15:19:05 <djazayeri> rafa: it looks good to me—I wonder whether we're going to need to add a parameter to the methods, but i'll figure that out later today in another ticket
15:19:53 <rafa> djazayeri: great thanks. I'll start modifying resources.
15:20:04 <djazayeri> rafa: for the location example, is the default rep the same as the editable properties?
15:20:20 <rafa> djazayeri: I believe so
15:20:38 <rafa> djazayeri: I did it the same
15:21:14 <rafa> djazayeri: well except auditInfo
15:21:23 *** deadpool has joined #openmrs
15:21:24 <rafa> djazayeri: and retireReason
15:21:25 <djazayeri> rafa: but auditInfo isn't in the DEFAULT rep
15:21:43 <rafa> djazayeri: right sorry
15:22:05 <rafa> djazayeri: so only retireReason is added to the editable props
15:22:18 <djazayeri> rafa: no more brainpower now, but can you spend 5 minutes thinking whether we can make creatable/editable/default-listable be the same?
15:22:30 <djazayeri> I don't think you should be able to edit retireReason
15:22:38 <djazayeri> you should set that by doing a DELETE
15:22:49 <djazayeri> or to edit retired
15:22:56 <djazayeri> but seeing that it's retired does seem important in the default view
15:23:24 *** bwolfe_ has joined #openmrs
15:23:24 *** ChanServ sets mode: +o bwolfe_
15:23:50 <rafa> djazayeri: so do we want to allow editing retired?
15:24:05 <djazayeri> rafa: not editing retired by a POST
15:24:14 <djazayeri> (though I don't know how we un-retire...)
15:24:24 <rafa> djazayeri: :)
15:24:41 <djazayeri> rafa: you should not be able to retire through an update. you have to do a DELETE
15:25:33 <rafa> djazayeri: only allow for retired false while updating?
15:25:48 <djazayeri> rafa: can't pay enough attention to think that through
15:25:54 <djazayeri> maybe
15:26:01 *** dileepsisila has joined #openmrs
15:26:15 *** chopin has joined #openmrs
15:27:13 <rafa> djazayeri: okay, it can be decided later
15:34:07 *** bwolfe_ has quit IRC
15:35:31 *** bwolfe_ has joined #openmrs
15:35:31 *** ChanServ sets mode: +o bwolfe_
15:39:59 *** bwolfe_ has quit IRC
15:40:27 *** rohitgoyal18 has joined #openmrs
15:40:27 *** mvorobey has quit IRC
15:43:29 *** bwolfe_ has joined #openmrs
15:43:29 *** ChanServ sets mode: +o bwolfe_
15:47:10 *** nadee has joined #openmrs
15:52:05 *** dileepsisila has quit IRC
15:52:46 *** snoppy has joined #openmrs
15:53:58 *** bwolfe_ has quit IRC
15:55:14 *** bwolfe_ has joined #openmrs
15:55:14 *** ChanServ sets mode: +o bwolfe_
16:05:10 <rafa> djazayeri: how do updates for collections work? are they merged or overwritten when posting?
16:05:35 <djazayeri> rafa: how do they work now or how should they be?
16:05:45 <rafa> djazayeri: how they should be :)
16:06:59 *** suranga has joined #openmrs
16:06:59 *** ChanServ sets mode: +v suranga
16:07:28 *** bwolfe_ has quit IRC
16:07:37 <djazayeri> rafa: offhand I think that posting to a collection overwrites it, but that frequently we expose the collection as a sub-resource, which allows add/remove
16:10:18 <djazayeri> rafa: my call finished, I can think 100% now
16:10:33 <djazayeri> rafa: I still think posting to a collection property should overwrite it
16:10:34 *** kavuri has joined #openmrs
16:10:57 <rafa> djazayeri: I guess we need tests for that :)
16:11:05 <djazayeri> rafa: yeah
16:12:05 <rafa> djazayeri: the minimum I want to do today is to fix all existing unit tests, I'll add extra tests tomorrow
16:12:21 <rafa> djazayeri: I need to leave home in two hours
16:12:42 <djazayeri> rafa: agreed about fixing existing tests
16:12:49 <djazayeri> others can also pick up tickets now for this!
16:13:43 <djazayeri> rafa: it would also be okay to @Ignore tests if you then mention that @Ignored test on the relevant subticket of your ticket
16:14:04 <djazayeri> i.e. if you @Ignore a test for creating a patient, comment that on the Patient & PatientIdentifier resource sub-task
16:14:28 <djazayeri> sunbiz: got my reply about the #3-type-things?
16:14:50 <rafa> djazayeri: okay, I'll do.
16:15:01 <djazayeri> sunbiz: I was thinking that it's an important business case to be able to do things like get all orders for a patient, not caring whether they're drug orders or lab orders
16:15:14 <djazayeri> sunbiz: and same goes for concept/conceptnumeric/conceptcomplex
16:16:13 <sunbiz> yes... saw that
16:16:44 <djazayeri> sunbiz: my question is: are you convinced? :-)
16:16:58 <sunbiz> why wouldnt u do a getAll on .../drugorder instead
16:18:21 <sunbiz> and also order?patient=1234 another resource as a parameter
16:18:26 <sunbiz> is again extremely complex
16:19:10 *** isharap has quit IRC
16:20:07 <djazayeri> sunbiz: you're saying to get all orders for a patient I need to do a GET to one resource per type of order, e.g. drugorder, laborder, etc
16:20:40 <djazayeri> sunbiz: I'm saying that order?patient=1234 would give you all orders for that patient
16:21:01 <djazayeri> (and each of those has a type: "DrugOrder" or something)
16:21:08 *** harshadura has quit IRC
16:21:16 <sunbiz> djazayeri: isnt that represented as each order subclasses representations
16:21:17 <djazayeri> sunbiz: and order?patient=1234&t=DrugOrder will just get you the drug orders
16:22:22 <sunbiz> so... what other can the parameter be??
16:23:10 <djazayeri> sunbiz: t=Order (for "plain" orders), t=DrugOrder, t=MyModuleOrder
16:24:08 *** nadee has quit IRC
16:24:20 <djazayeri> sunbiz: jeff wishnie suggested that for the subclass-links-to-superclass model, we also have the superclass link to the particular subclass
16:24:24 <djazayeri> which seems like a good idea
16:25:14 <djazayeri> in that model you could get all Orders (of any type) by hitting the Order resource, and get more details about them by hitting the DrugOrder/LabOrder/etc resources
16:26:04 <djazayeri> but I still think I find it more intuitive to exposing all different order types via a single Order resource, and the document returned differs depending on the actual type of the order
16:26:24 <sunbiz> djazayeri: what do u think about /order/person/1234
16:26:33 <sunbiz> sorry patient
16:27:10 <djazayeri> sunbiz: as opposed to /order?patient=1234?
16:27:46 <djazayeri> well, the advantage of using query params is it makes it obvious how you would combine them
16:27:54 <djazayeri> in order/person/1234 better REST style?
16:28:00 <sunbiz> yea
16:28:41 <sunbiz> though... query parameter are more generally available to all resources
16:29:10 <sunbiz> so... unless we want to have patient available query to all resources or most... that will make commonsense to ppl coming to our API
16:30:04 <djazayeri> sunbiz: honestly I'm not too interested in trying to change this bit now...
16:30:19 *** snoppy has quit IRC
16:30:31 <djazayeri> i.e. before releasing 1.0, since we've got enough work on our plates for clarifying resource creation/update via POSTs.
16:30:40 <wyclif> djazayeri, dkayiwa has any of you guys ever merged trunk changes into the order-entry branch?
16:30:50 <djazayeri> wyclif: look at svn, I have no recollection
16:30:53 <wyclif> djazayeri, dkayiwa just curious, am trying to do that
16:31:09 <dkayiwa> wyclif: not me
16:31:15 <wyclif> djazayeri, i seem to see no merge. anyways i was just pinging you just in case
16:31:25 <djazayeri> wyclif: if I did, I don't recall. :-)
16:31:29 <wyclif> djazayeri, ok
16:31:40 <djazayeri> sunbiz: is exposing /order?patient=1234 bad?
16:32:03 <djazayeri> sunbiz: because we could always add /order/patient/1234 in 1.1, 1.2, etc
16:32:38 <sunbiz> complex = bad
16:33:00 <sunbiz> so... I cant have a common-style to query resources in the client
16:33:34 <djazayeri> sunbiz: I don't understand why query parameters should be standard across all resources
16:34:01 <djazayeri> and I also don't understand what's complex about or unintuitive about a query like /order?patient=1234 or /obs?patient=1234
16:35:24 <sunbiz> djazayeri: because the same can be done through /order/patient
16:35:32 <sunbiz> and I can get get orders for all patient
16:35:53 <sunbiz> order/person/1234 is all orders by a doctor
16:36:11 *** snoppy has joined #openmrs
16:36:14 <sunbiz> drugorder/patient/12345 is drugorders for patient 12345
16:36:26 <djazayeri> sunbiz: how would you get orders for a patient by a doctor?
16:36:31 <sunbiz> order/location/1 is all orders at location 1
16:36:43 <djazayeri> or all orders for a patient at a location?
16:37:01 <sunbiz> djazayeri: do work at the client end
16:37:28 *** pulasthi7 has quit IRC
16:38:08 <djazayeri> sunbiz: hmm…is the theory that since there's surely a cache somewhere, it's better to make fewer queries that fetch more data each?
16:39:07 <sunbiz> yes that... but also that I can work around with more stuff
16:39:13 <sunbiz> on the client-side
16:39:46 *** wyclif has quit IRC
16:39:59 *** wyclif has joined #openmrs
16:40:32 *** wyclif has quit IRC
16:44:33 *** mwalo has joined #openmrs
16:44:40 <downey> Hi mwalo and welcome to the #openmrs IRC channel.
16:45:56 *** wyclif has joined #openmrs
16:49:28 <djazayeri> sunbiz: interesting points. that would be pretty much a complete redesign of all our queries, and I don't see how we can do that at this point...
16:49:47 <djazayeri> sunbiz: can you post to the dev list though?
16:53:56 <sunbiz> okk
16:57:10 *** dkayiwa has quit IRC
17:10:49 <kavuri> sunbiz: I ran a sample http test client to perform a basic authentication, but I get a response "HTTP/1.1 405 Method Not Allowed"
17:11:00 <kavuri> sunbiz: got the same response using curl
17:11:26 <kavuri> Is there something I am missing
17:12:33 <kavuri> sunbiz: the url I am using is http://localhost:8080/openmrs/ws/rest/v1/session
17:15:40 <djazayeri> kavuri: does the server log show any exception or stacktrace?
17:16:25 *** shanakaf has joined #openmrs
17:17:49 <kavuri> djazayeri: no errors in the server log
17:19:17 <djazayeri> kavuri: this is what I get from a recent build of restws (not the one in the module repo...)
17:19:18 <djazayeri> curl http://localhost:8019/openmrs19/ws/rest/v1/session
17:19:29 <djazayeri> {
17:19:29 <djazayeri> "authenticated": false,
17:19:29 <djazayeri> "sessionId": "1gqapmj8v6txx"
17:19:29 <djazayeri> }
17:20:28 <djazayeri> kavuri: and doing -u admin:Admin123 correctly then returns authenticated: true
17:20:55 <kavuri> djazayeri: with curl, I surely get a not supported error
17:21:10 <djazayeri> kavuri: you're using a recent build?
17:21:13 <kavuri> djazayeri: {"error":{"message":"Request method 'GET' not supported","code":"org.springframework.web.servlet.mvc.annotation.AnnotationMethodHandlerAdapter$ServletHandlerMethodResol ...
17:21:47 <kavuri> djazayeri: I have version 1.9
17:21:56 <kavuri> djazayeri: but some 2 weeks old
17:22:22 <djazayeri> kavuri: should have worked then. are there more lines to the stacktrace that you can pastebin?
17:24:29 <kavuri> djazayeri: http://pastebin.com/Zi4kPqVz
17:27:47 <djazayeri> kavuri: I can't tell anything from the error message. Usually the "method not supported" error on a resource that's supposed to support it means there's an additional error message in the server logs
17:28:31 <kavuri> djazayeri: I will checkout the latest code and try it out. Could be the version I have has issues
17:28:58 <djazayeri> kavuri: latest code right this second may break…
17:29:09 <djazayeri> rafa: should the latest code be working?
17:29:19 <rafa> djazayeri: yes
17:29:58 <djazayeri> kavuri: okay, go ahead and try
17:30:06 <kavuri> djazayeri: ok..will do
17:31:46 <kavuri> djazayeri: btw. my question yesterday about change log for sync might have been answered by the module that bwolfe is working on, which is an atom feed with the changes
17:32:41 <djazayeri> kavuri: yes definitely something that should be explored
17:37:40 <rafa> djazayeri: kavuri: actually tried clean build again and see two tests failing in ConceptControllerTest
17:37:55 <rafa> sunbiz: looks like you worked on getAll
17:38:18 <rafa> sunbiz: do you know what might be going wrong in there?
17:47:28 <djazayeri> rafa: sunbiz changed getAll so it returns a PageableResults instead of a List<Object>. He said there were 8 broken unit tests, and I thought he fixed those, but maybe he missed a couple.
17:47:29 *** dkayiwa has joined #openmrs
17:48:10 <djazayeri> rafa: possibly the fix is to get the size of PropertyUtils.getProperty(result, "results")...
17:48:55 <rafa> djazayeri: it might be my fault that he overlooked it because at some point I introduced more than 40 failures :D
17:49:15 <rafa> djazayeri: left him a message under RESTWS-211
17:49:47 <rafa> djazayeri: aResult is null
17:51:48 *** shanakaf has quit IRC
17:51:59 <rafa> djazayeri: okay got you
17:54:59 *** sgithens_ has joined #openmrs
17:56:55 *** jkeiper has quit IRC
17:58:45 *** chopin has quit IRC
18:01:43 *** rafa has quit IRC
18:07:43 *** mwalo has quit IRC
18:17:23 <mseaton> djazayeri: what would you expect to happen if i called Provider.getName(); ?
18:17:24 *** lh has quit IRC
18:17:36 *** wyclif has quit IRC
18:17:38 *** lh has joined #openmrs
18:17:49 *** wyclif has joined #openmrs
18:18:26 *** wyclif has joined #openmrs
18:18:32 <djazayeri> mseaton: I'd expect: getPerson() != null ? getPerson.getName() : this.getName()
18:18:58 <mseaton> djazayeri: reasonable. i don't think this is what is done.
18:19:05 <djazayeri> rather: getPerson() != null ? getPerson.getName().getFullName() : this.getName()
18:19:26 <djazayeri> I think you're right (that it doesn't)
18:19:38 <djazayeri> setName should probably fail if getPerson() != null
18:22:22 <mseaton> djazayeri: i tried to make a point in the provider attributes thread earlier in the month and it was either ignored or lost. i'll put it out there again here. in a nutshell, if a Provider is more similar to a User than to a Person (eg. it defines one or more "roles" in the health care system a particular person can have, just like a User is really a "UserAccount"), then why is Person optional on provider?
18:23:32 <mseaton> was a decision made where we said "ugh, we don't want to have to know ages and genders for every provider, so we can't make them have to be persons"? or was there a better reason than this?
18:23:33 <djazayeri> mseaton: The reasoning was that we wanted to support "import a list of 10000 providers from the gvmt or an insurance company, that I have minimal details on"
18:24:03 <mseaton> djazayeri: i would argue then that gender and birthdate should just be made optional on person then...and required on Patient.
18:24:11 <djazayeri> mseaton: and burke and I were worried that creating persons for these would be a resource overhead
18:24:18 <djazayeri> mseaton: probably we were overthinking things.
18:24:36 <mseaton> djazayeri: now we are in limbo though. you can't make any necessary assumptions
18:25:06 <djazayeri> mseaton: I think you are probably right, but I don't know how feasible it is to make that change after 1.9RC3…
18:25:08 <mseaton> i get the reasoning, but i think lessening the restrictions on person would have solved the same problem
18:25:10 <djazayeri> can you email the dev list?
18:25:17 <djazayeri> mseaton: I don't disagree
18:25:19 <mseaton> well, i did.
18:25:43 <djazayeri> mseaton: well, again now (just 2-3 sentences, and I'll reply)
18:25:55 <mseaton> i'm on it
18:26:14 <djazayeri> mseaton: especially if MarkG can comment on how he was forced to resolve this in the provider management module
18:26:49 <mseaton> i was already writing the email, but decided to sanity check it here first
18:30:25 *** sgithens_ has quit IRC
18:40:08 <MarkG> i made the assumption that, for the purpose of the module, a provider = "a person who has one or more provider metadata objects associated with them"
18:40:22 *** downey has quit IRC
18:40:25 <djazayeri> MarkG: I know, but reply to Mike's email and say that. :-)
18:40:38 *** r_friedman has joined #openmrs
18:40:45 <MarkG> djazayeri: okay...
18:40:59 <djazayeri> i.e. to make the code work you had to actually ignore/exclude all the non-person providers
18:57:16 *** bwolfe has joined #openmrs
18:57:16 *** ChanServ sets mode: +o bwolfe
18:58:34 *** skathol has joined #openmrs
19:00:27 <bwolfe> !scrumon bwolfe
19:00:27 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster bwolfe- you may begin when ready.
19:00:57 <bwolfe> ok, scrum order: 1) bug fixing swim lane: dkayiwa. 2) atom feed spike: bwolfe 3) web services: djazayeri, wyclif, skathol, sunbiz, finbrein, r_friedman, chopin (absent), mykola (absent)
19:02:30 <bwolfe> daniel, are you around?
19:03:47 <djazayeri> seems like a no
19:04:09 <bwolfe> yes, does seem that way
19:04:13 <bwolfe> guess I'll start :-/
19:04:26 <bwolfe> Wednesday:
19:04:26 <bwolfe> univ call
19:04:26 <bwolfe> design call
19:04:26 <bwolfe> event module wiki updates
19:04:26 <bwolfe> reviewed tickets
19:04:27 <bwolfe> pm call
19:04:29 <bwolfe> Thursday
19:04:31 <bwolfe> emails
19:04:33 <bwolfe> sprint setup
19:04:35 <bwolfe> dev call
19:04:37 <bwolfe> ldrship/enterprise call
19:04:39 <bwolfe> pamphlet disc with dawn/michael
19:04:41 <bwolfe> atom feed module
19:04:45 <bwolfe> atom feed sprint setup
19:05:03 <bwolfe> (no blockers)
19:05:19 <djazayeri> wyclif: you go next
19:05:48 <wyclif> Wednesday:(picked up bug tickets as i waited for order entry feed back from the design call)
19:05:48 <wyclif> * TRUNK-1729 - Exit Patient from Care: Exclude automatic program workflow state transition to PATIENT DIED for completed programs
19:05:48 <wyclif> * design call
19:05:48 <wyclif> * Fixed bug with location autocomplete in html formentry where it doesn't display the last submitted value on errors
19:05:48 <wyclif> Thursday:
19:05:50 <wyclif> * dev call
19:05:52 <wyclif> * Merge trunk changes into order entry (Quite Painful)
19:05:54 <wyclif> * Compare the trunk and order entry branch to determine level of variation
19:05:58 <wyclif> * Compare order-entry branch with where we want to be to determine level of variation
19:06:00 <wyclif> Blockers: None
19:06:44 <bwolfe> I'd prefer you take tickets from the sprint topic if there are smallish ones available, not general bug fixing....
19:06:56 <bwolfe> but good work getting stuff done while waiting. :-)
19:06:59 <djazayeri> wyclif: for what it's worth, can't you just compare the head of the order-entry branch to the revision where it was branched?
19:07:02 <dkayiwa> sorry i had stepped off my laptop
19:07:13 <r_friedman> and into the b;ie
19:07:17 <r_friedman> blue
19:07:46 <djazayeri> wyclif: there can't have been many changes to order & orderservice in trunk since then
19:07:58 <wyclif> djazayeri, that works too and
19:08:08 <djazayeri> dkayiwa: go ahead and give your report
19:08:24 <dkayiwa> Committed: Unit of work - transaction bounary is not correct - Patient.form maybe more places - TRUNK-229
19:08:24 <dkayiwa> Committed: htmlInclude tag should be synchronized - TRUNK-266
19:08:25 <dkayiwa> Reviewed and applied patch for: Trying to save a new field type without name should display an error message - TRUNK-2979
19:08:25 <dkayiwa> Reviewed and applied patch for: Location description should not be required - TRUNK-2708
19:08:26 <dkayiwa> Reviewed and applied patch for: Applying patch for: Exception not caught in WebModuleUtil.java - TRUNK-3243
19:08:26 <dkayiwa> Reviewed and applied patch for: When creating a new patient, pre-populate the "Identifier Type" field - TRUNK-2511
19:08:26 <dkayiwa> Reviewed, applied patch and closed: Error reported by PepfarReportFromXmlTest - TRUNK-2549
19:08:26 <dkayiwa> Reviewed and applied patch for: Errors and exceptions thrown by ObsServiceTest - TRUNK-2551
19:08:27 <dkayiwa> Reviewed and applied patch for: Error and exceptions reported by PepfarReportSerializationTest - TRUNK-2548
19:08:27 <dkayiwa> Reviewed and applied patch for: Error and exception when running OptionsFormControllerTest - TRUNK-2554
19:08:27 <dkayiwa> No Blockers
19:09:31 <djazayeri> dkayiwa: that's a lot of tickets. :-)
19:09:41 <dkayiwa> djazayeri: small ones :)
19:09:46 <bwolfe> !ticket TRUNK-266
19:09:49 <OpenMRSBot> bwolfe: [#TRUNK-266] htmlInclude tag should be synchronized - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-266
19:10:03 <djazayeri> On to Web Service sprint people
19:10:16 <djazayeri> Wednesday 18-Apr-2012
19:10:16 <djazayeri> * University call
19:10:16 <djazayeri> * Design call
19:10:16 <djazayeri> * Project Management call
19:10:16 <djazayeri> * did NOT do reviews on sprint tickets. <- My bad, too busy. Apologies to mvorobey, fibrein, r_friedman, rafa, skathol
19:10:16 <djazayeri> * Wrote long emails after the design call
19:10:16 <djazayeri> * Created RESTWS-226 - Resources need to specify what fields are editable, not blindly expose all delegate properties
19:10:17 <djazayeri> * Created 16 sub-tasks for RESTWS-226
19:10:17 <djazayeri> * Created RESTWS-243 - Implement framework code to support for Resource-per-class-hierarchy approach to hiding inheritance
19:10:18 <djazayeri> Thursday 19-Apr-2012
19:10:19 <djazayeri> * Dev call
19:10:19 <djazayeri> * Leadership call
19:10:20 <djazayeri> * Review sprint tickets and apply them (overdue from yesterday)
19:10:20 <djazayeri> * Do sprint tickets, particularly RESTWS-243
19:10:21 <bwolfe> djazayeri, did you go?
19:10:25 <djazayeri> no blockers except for time
19:10:34 <bwolfe> oh, sorry, you're too fast
19:11:21 <bwolfe> skathol, are you around?
19:11:32 <skathol> RESTWS-212 - Added memberOf and answerTo searchs to concept
19:11:33 <skathol> * Done - awaiting review
19:11:33 <skathol> RESTWS-215 - Making changes to fields returned by the role resource
19:11:33 <skathol> * Know what I need to do, will probably finish later today.
19:11:33 <skathol> I have no other assigned tickets - will probably look for one after I finish RESTWS-215.
19:12:13 <djazayeri> skathol: cool, any blockers?
19:12:19 <skathol> no blockers
19:12:56 <djazayeri> sunbiz: your turn
19:13:07 <sunbiz> *Discovered that test page doesn't work
19:13:07 <sunbiz> *Created RESTWS-244
19:13:07 <sunbiz> *Committed code to RESTWS-244 and followed up on Ben's comment
19:13:07 <sunbiz> *RESTWS-211 finished, committed code and now under review
19:13:07 <sunbiz> Looking for another ticket now
19:13:21 <djazayeri> !ticket RESTWS-211
19:13:22 <OpenMRSBot> djazayeri: [#RESTWS-211] Get All should behave consistently to Search: it should return paged results, and respect the max number of results - OpenMRS JIRA - https://tickets.openmrs.org/browse/RESTWS-211
19:13:54 <bwolfe> blockers?
19:13:56 <djazayeri> sunbiz: rafa mentioned there were still two broken tests; are those yours?
19:14:12 <djazayeri> sunbiz: no need to answer that now, just check later and deal with them if relevant
19:14:14 <sunbiz> djazayeri: those were fixed
19:14:20 <djazayeri> great
19:14:22 <djazayeri> blockers?
19:14:23 <sunbiz> no failing tests anymore
19:14:25 <sunbiz> no blockers
19:14:32 <sunbiz> looking for new ticket
19:14:34 <djazayeri> finbrein: your turn
19:14:36 <finbrein> ** start **
19:14:36 <finbrein> RESTWS-204
19:14:36 <finbrein> Checked the resources and sub-resources for lower and singular cases
19:14:36 <finbrein> Added instructions to the wiki
19:14:36 <finbrein> ** end **
19:14:48 <kavuri> djazayeri: I just downloaded the latest from trunk and I do not see any broken tests..except that when I run I get this error: "No plugin found for prefix 'jetty' in the current project and in the plugin groups"
19:14:52 <djazayeri> finbrein: planning to pick up another ticket?
19:15:01 <djazayeri> kavuri: wait till after the sprint
19:15:04 <finbrein> djazayeri: yup!
19:15:08 <kavuri> djazayeri: sorry
19:15:11 <bwolfe> djazayeri, s/sprint/scrum
19:15:29 <djazayeri> finbrein: there are a bunch of sub-tasks to RESTWS-226
19:15:30 <r_friedman> s/summer/scrum/
19:15:46 <finbrein> ok, i'll take a look
19:15:52 <djazayeri> r_friedman: your turn
19:16:04 <r_friedman> reinstalled eclipse
19:16:14 <r_friedman> tests still bomb in JUnit
19:16:30 <r_friedman> tests run under Jetty but results don't seem right
19:16:35 <bwolfe> r_friedman, you have the hardest time with unit tests :-/
19:16:38 *** isharapremadasa has joined #openmrs
19:16:49 <r_friedman> bwolfe: i have the hardest time with everything!!
19:17:06 <djazayeri> finbrein: (if you look at them from https://tickets.openmrs.org/secure/Dashboard.jspa?selectPageId=11751 then you'll get them sorted by priority)
19:17:11 <r_friedman> reviewed two tickets waiting on me
19:17:15 <finbrein> haha!
19:17:38 <r_friedman> posted darius' remarks to restws-216
19:18:15 <djazayeri> r_friedman: blockers (besides IDE mishaps?)
19:18:31 <r_friedman> occasional job requirements :-)
19:18:58 <djazayeri> r_friedman: bah :-)
19:19:09 <djazayeri> suranga: got a report?
19:19:12 <r_friedman> that's ok, i'm about to get fired
19:19:51 <djazayeri> (r_friedman: don't get fired. we'd be very sad if we got you fired.)
19:20:39 <r_friedman> i've only picked the 2nd most powerful person in the division to have a fight with
19:20:57 <djazayeri> suranga: ?
19:21:10 <djazayeri> !scrumoff
19:21:10 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
19:21:27 <bwolfe> is suranga sprinting?
19:21:29 <djazayeri> I didn't see any discussion topics
19:21:36 <djazayeri> suranga is working on a sprint ticket
19:21:59 <bwolfe> I see
19:22:01 <djazayeri> Were there any discussion points?
19:22:20 <bwolfe> I didn't see any
19:22:26 <bwolfe> except for kavuri's question
19:22:30 <djazayeri> kavuri had a question
19:22:39 <djazayeri> (bwolfe: you're faster this time!)
19:22:47 <r_friedman> just darius writing 26 subtasks before anyone has read his ticket
19:22:52 <kavuri> djazayeri: yes, I was saying that there were no failed tests
19:22:59 <kavuri> djazayeri: I checked out the latest code
19:23:09 <kavuri> djazayeri: but I get this error, "No plugin found for prefix 'jetty' in the current project and in the plugin groups"
19:23:13 <sunbiz> r_friedman: dont fight then...
19:23:19 <bwolfe> kavuri, execute jetty:run from the "webapp" dir
19:23:24 <kavuri> djazayeri: when I try to run
19:24:32 <r_friedman> sunbiz, haha the advice given by my Indian colleague, but we West Africans prefer to work out our differences openly
19:24:33 <kavuri> bwolfe: thanks..I was running it from trunk..
19:26:03 <dkayiwa> r_friedman: i did not know that you are a West African :)
19:26:10 <bwolfe> kavuri, who told you there were failing tests in trunk?
19:26:16 <r_friedman> dkayiwa: they call me Mr. Ghana -)
19:26:20 <kavuri> bwolfe: rafa
19:26:23 <sunbiz> r_friedman: Im sure most ppl think Indians fight over everything :) with the swords in the scabbard though
19:26:34 <dkayiwa> r_friedman: would be scared if you were Nigerian :)
19:26:41 <sunbiz> dkayiwa: lol!!
19:26:42 <kavuri> bwolfe: I saw that he updated in the daily scrum that those were fixed now
19:26:49 <bwolfe> kavuri, was he referring to the webservices.rest module trunk code?
19:27:14 <kavuri> bwolfe: not specifically, about couple of tests in the whole trunk
19:27:20 <bwolfe> sunbiz, you don't have a scabbard?!
19:27:32 <djazayeri> sorry, rafa had mentioned failing tests, I didn't know they were already fixed
19:27:34 <djazayeri> ignore that
19:27:48 <dkayiwa> sunbiz: most conmen in Africa come from Nigeria :)
19:27:48 <r_friedman> bwolfe: of course he does, it's a right of passage to get your scabbard
19:28:19 <dkayiwa> sunbiz: i even one fell a victim of them :)
19:29:03 <r_friedman> dkayiwa: we had one computer that never worked right, we called it the Nigerian computer
19:29:17 <dkayiwa> r_friedman: hahahahahaha :D
19:29:18 * robbyoconnor dances really badly in the middle of the channel:P
19:29:46 <bwolfe> /kickban robbyoconnor nobaddancingallowed
19:30:01 <robbyoconnor> dancing is TOTALLY allowed in this establishment
19:30:21 <robbyoconnor> bwolfe: so you better not dance then!
19:30:28 <robbyoconnor> *trollface.jpg*
19:30:42 <r_friedman> bwolfe: juggles babies
19:30:55 <robbyoconnor> juggle the babies *AND* dance...
19:31:04 <bwolfe> I dance with my babies
19:31:09 <bwolfe> and they dance better than me
19:31:30 <robbyoconnor> speaking of babies...my brother and his wife are due to have a baby any day now
19:35:38 <kavuri> djazayeri: after installing the latest build, I still get method not supported and no error logs in the server side
19:36:15 <kavuri> djazayeri: I was trying the url: http://localhost:8080/openmrs/ws/rest/v1/session
19:36:20 <kavuri> not openmrs19
19:36:35 <kavuri> djazayeri: if I use openmrs19, I get a page not found
19:36:49 <djazayeri> kavuri: ignore openmrs19, that's jsut where I have it deployed
19:37:19 <kavuri> djazayeri: I had to manually deploy the webservices plugin into openmrs
19:37:20 <kavuri> core
19:37:34 <kavuri> djazayeri: is that expected? I thought it was part of the core
19:37:59 <sunbiz> bwolfe: I do have a scabbard
19:38:06 <sunbiz> the swords are always inside it
19:38:11 <sunbiz> although there are fights
19:38:28 <sunbiz> yea... dkayiwa: I've heard that before
19:38:37 <djazayeri> kavuri: it's a module
19:38:44 <djazayeri> you have to deploy it, yes
19:38:48 <djazayeri> kavuri: can you try running jetty in debug mode instead?
19:38:55 <djazayeri> are you using eclipse?
19:38:58 <sunbiz> Nigerian spam is big... sadly on the OpenMRS list it seems the spam comes from Indian IT peripheral companies :P
19:38:59 <kavuri> djazayeri: yes
19:39:04 <kavuri> djazayeri: using eclipse
19:39:20 <dkayiwa> sunbiz: :)
19:39:27 <djazayeri> so basically you can do Debug As to do the maven build for jetty:run
19:40:00 <kavuri> djazayeri: yes, also I enabled the debug output option
19:40:14 <kavuri> djazayeri: will update shortly
19:40:25 <djazayeri> kavuri: run it under the debugger, and put a breakpoint on the line of the get method in SessionController
19:40:28 <djazayeri> and see if it gets there
19:41:48 <kavuri> djazayeri: whats the path of the file SessionController?
19:42:16 <djazayeri> kavuri: use control-shift-T (or command-shift-T) in eclipse
19:42:55 <kavuri> djazayeri: hmm..no hits :(
19:43:13 <kavuri> djazayeri: is it part of the webservices module?
19:43:21 <djazayeri> kavuri: yeah, it's the webservices.rest module
19:43:24 <kavuri> djazayeri: because I do not have it in my source tree
19:43:27 <djazayeri> oh
19:43:35 <djazayeri> you'll need it there to put a breakpoint there. :-)
19:43:37 <djazayeri> if you must know, it's org.openmrs.module.webservices.rest.web.v1_0.controller.SessionController under
19:43:40 <djazayeri> omod
19:43:48 <kavuri> djazayeri: but I have it installed from openmrs webview
19:43:50 <djazayeri> but that won't help if it's not in the source tree
19:44:14 <djazayeri> kavuri: you built it locally, but from the command line, not from eclipse?
19:44:39 <kavuri> djazayeri: I built the openmrs core logic from eclipse
19:46:45 <djazayeri> kavuri: so, if you're not seeing any error messages in the logs, I suggest trying the debugger, which would require that you get the module into eclipse, either via New Project -> Checkout Maven Project from SCM, or possibly by importing the existing one into eclipse
19:47:05 <djazayeri> kavuri: I don't know why you're getting an error I'm not seeing
19:47:08 <djazayeri> (gotta run for a bit)
19:50:58 *** james_regen has quit IRC
19:51:41 *** skathol has quit IRC
19:54:25 *** isharapremadasa has quit IRC
19:54:26 *** sunbiz has left #openmrs
19:56:07 <djazayeri> dkayiwa: hi
19:56:14 <dkayiwa> djazayeri: hi
19:56:24 <djazayeri> regarding TRUNK-3149, about the edit concept page
19:56:33 <djazayeri> currently it displays an interface with tabs
19:57:02 <djazayeri> I'm assuming the tabs it chooses to show are in a list property in the jsp, right?
19:57:29 <djazayeri> I'm just saying to make sure that list has at least the allowed locales (from the GP) and *also* all locales that the concept has any names in.
19:57:34 <dkayiwa> djazayeri: tabs for concept names?
19:57:44 <djazayeri> dkayiwa: tabs for *locales*
19:58:23 <dkayiwa> djazayeri: let me check again
19:58:28 <djazayeri> dkayiwa: my concern is that given the logic, if you edit and save a concept, it could *lose* names that aren't shown in the UI.
19:58:39 <dkayiwa> djazayeri: ok
19:58:39 <djazayeri> dkayiwa: maybe I'm wrong about that, in which case you can just close the ticket
19:59:15 <dkayiwa> djazayeri: i only fixed the problem which was reported. never looked into other implications. so you could be right :)
19:59:24 <djazayeri> dkayiwa: but if it's the case that saving a concept will lose non-displayed names, I just want to make sure you're displaying all names, e.g. if the concept happens to have a name in a language that is not in your allowed locales GP.
19:59:49 <djazayeri> e.g. if you get a concept from the MVP dictionary with multiple translations, but you only enable english, editing the concept should not throw away the french names
19:59:57 <djazayeri> (and ideally it would show then, in a French tab)
20:00:06 <djazayeri> dkayiwa: but check and see whether this is a real issue or not.
20:00:11 <dkayiwa> djazayeri: ok
20:03:07 *** sunbiz has joined #openmrs
20:03:07 *** ChanServ sets mode: +v sunbiz
20:06:20 *** bryq has quit IRC
20:11:49 <dkayiwa> djazayeri: just cross check and the tabs are already there
20:12:14 <dkayiwa> djazayeri: there is a tab for each allowed locale
20:13:09 <kavuri> djazayeri: it works...ran in debug mode and the method was being called..
20:13:32 <kavuri> djazayeri: the combination of latest openmrs + an older version of webservices REST module was failing
20:15:40 <kavuri> djazayeri: got to hit the bed now..feeling sleepy
20:15:51 <kavuri> kavuri: signing off
20:16:45 <djazayeri> dkayiwa: cool, and are they controlled by a list that you can trivially add another locale to?
20:17:09 <dkayiwa> djazayeri: let me check that
20:18:31 *** r_friedman has quit IRC
20:21:38 *** kavuri has quit IRC
20:24:19 *** rohitgoyal18 has quit IRC
20:36:47 *** suranga has quit IRC
20:39:13 <sunbiz> djazayeri: there are also subresources... should they be paged as well??
20:39:50 *** bwolfe_ has joined #openmrs
20:39:50 *** ChanServ sets mode: +o bwolfe_
20:40:37 <djazayeri> sunbiz: yes, I think those should be paged too
20:41:11 <sunbiz> djazayeri: so will the properties have results[] in them as well ??
20:43:37 *** bwolfe has quit IRC
20:44:08 *** bwolfe_ has quit IRC
20:54:34 <sunbiz> djazayeri: so it will add results to the subresource as well
20:54:42 <sunbiz> djazayeri: do we want it like that??
20:55:17 <djazayeri> sunbiz: sorry, went to get lunch
20:55:37 <djazayeri> sunbiz: I think it should behave exactly the same way that resources work
20:57:08 <djazayeri> sunbiz: i.e. we should change SubResource.getAll(…) to return a PageableResult
20:57:12 <djazayeri> instead of a List<Object>
21:00:23 <sunbiz> djazayeri: yup... done that
21:05:27 *** mseaton has left #openmrs
21:08:54 *** mccallumg has quit IRC
21:17:20 <djazayeri> sunbiz: you haven't committed yet, right? (I.e. I'm going to mark RESTWS-211 as rework needed for now)
21:18:06 <sunbiz> committed
21:18:10 <sunbiz> just now
21:18:23 <djazayeri> okay, please create a crucible review now that there are ~4 commits
21:22:42 *** snoppy has left #openmrs
21:24:11 *** lh has quit IRC
21:24:56 <sunbiz> djazayeri: done
21:25:28 <sunbiz> djazayeri: I wondered what the 4th commit was... then I remember rafa helped clear some unit tests
21:25:48 <djazayeri> yup. :-)
21:57:04 *** sunbiz has left #openmrs
22:07:07 * robbyoconnor does backflips
22:18:09 *** MarkG has quit IRC
22:19:07 *** MarkG has joined #openmrs
22:23:55 *** MarkG has quit IRC
22:30:10 *** wyclif has quit IRC
22:39:35 *** dkayiwa has quit IRC
22:39:56 *** r_friedman has joined #openmrs
22:40:08 <r_friedman> djazayeri: hi darius
22:40:16 <djazayeri> hi
22:40:23 <r_friedman> can we go private?
22:43:58 *** dkayiwa has joined #openmrs
22:53:46 *** dkayiwa has quit IRC
23:26:13 *** wyclif has joined #openmrs