| 00:00:20 | <finbrein> djazayeri: I am trying to understand the resources and representation for OpenMRS once and for all. Are there common properties found in almost all representations in OpenMRS, what are they? What are the unique representation for the Patient resource? I saw 'preferredIdentifier' and 'preferredName' in /webservices.rest-omod/src/main/java/org/openmrs/module/webservices/rest/web/v1_0/resource/PatientResource.java |
| 00:01:52 | <djazayeri> finbrein: all of our resources have a standard "ref" representation |
| 00:02:34 | <djazayeri> finbrein: many metadata resources have similar properties in their representations |
| 00:02:40 | <djazayeri> (name, description, retired) |
| 00:02:54 | <djazayeri> finbrein: data resources vary more |
| 00:03:01 | <djazayeri> finbrein: and subclasses are particularly tricky. |
| 00:03:31 | <djazayeri> finbrein: also, in some cases we discovered over the years that we don't like the way we did things in the Java domain objects, and we're trying to improve on things in web services |
| 00:03:46 | <djazayeri> finbrein: preferredIdentifier is a good example of that |
| 00:04:47 | <djazayeri> hmm, actually preferredIdentifier isn't implemented the way I though |
| 00:05:01 | <djazayeri> finbrein: preferredName on the person resource is a good example of that. :-) |
| 00:05:55 | <djazayeri> finbrein: In the java object model, Person.names is a list, and each PersonName has an isPreferred property. |
| 00:06:32 | <djazayeri> finbrein: in the web service model we cleaned this up so that the person/names resource does *not* have a boolean preferred property |
| 00:06:46 | <djazayeri> but rather the person has a list of names, and a pointer to a single preferredName |
| 00:07:04 | <djazayeri> finbrein: is this clarifying at all? :-) |
| 00:07:06 | <finbrein> ok |
| 00:07:23 | <finbrein> yes, it helps |
| 00:07:25 | <djazayeri> finbrein: I just sent a long email to the dev list about subclasses (though it will take a moment to be delivered) |
| 00:37:21 | *** r7friedman has joined #openmrs |
| 00:37:35 | *** r7friedman is now known as r_friedman |
| 00:37:42 | <r_friedman> djazayeri: hi darius |
| 00:39:01 | <r_friedman> bwolfe: hi ben |
| 00:42:54 | <djazayeri> hi r_friedman |
| 00:43:11 | <r_friedman> hi darius ... should we be testing against 1.8 or 1.9? |
| 00:43:25 | <djazayeri> r_friedman: in theory it should work against both |
| 00:43:47 | <djazayeri> ideally some of us happen to be testing against 1.8 and others against 1.9 |
| 00:43:57 | <djazayeri> r_friedman: you can pick arbitrarily |
| 00:44:01 | <r_friedman> ok, i think i have an idea |
| 00:44:24 | <finbrein> djazayeri: I have read your recent email 'REST WS and subclasses' and I agree with you on the POSTing content for a Patient object for example. It would be more convenient and intuitive to have just one set of properties for someone who is not used to the OpenMRS API and wants to learn and use it. The current implementation is not convenient and intuitive having "preferredIdentifier" and "preferredName" as two sets of properties ea |
| 00:44:24 | <finbrein> ch having a set of properties. |
| 00:45:15 | <djazayeri> r_friedman: you should really run whatever jss is planning to run in production |
| 00:45:35 | <djazayeri> finbrein: I don't quite understand |
| 00:46:03 | <djazayeri> finbrein: you mean because both Patient and Person have preferredName? |
| 00:46:13 | <r_friedman> djazayeri: tks |
| 00:47:12 | <robbyoconnor> finbrein: go take a nap!!! |
| 00:47:13 | <robbyoconnor> :) |
| 00:47:20 | <robbyoconnor> you're human! |
| 00:47:28 | <robbyoconnor> surely nobody will fault you for sleeping! |
| 00:47:53 | <robbyoconnor> even though I'm fairly certain some devs don't sleep |
| 00:49:21 | <finbrein> ;) robbyoconnor: I had a nap about 2 hours ago and I can continue with my task now. thanks. |
| 00:52:16 | <robbyoconnor> carry on! |
| 00:54:35 | <finbrein> djazayeri: my mistake, I haven't used JSON pretty much. I want to say we could have a set of properties {"identifier", "identifierType", "location", "givenName", "familyName", "birthdate", "gender"} for the patient but I know better now. If we group them into "preferredIdentifier" and "preferredName" in JSON, it will be decoded properly on the webpage. |
| 01:08:31 | *** lh has quit IRC |
| 01:15:58 | <finbrein> djazayeri: hi |
| 01:16:08 | <djazayeri> hi |
| 01:17:05 | <djazayeri> finbrein: hi |
| 01:17:41 | <finbrein> djazayeri: In the sample API request for patient, we have "preferredIdentifier" and "preferredName". For the "preferredName", don't you think it would be more descriptive to use "personName"? |
| 01:18:17 | <finbrein> djazayeri: since we have "givenName" and "familyName" in it |
| 01:18:47 | <djazayeri> finbrein: personally I think that having preferredXyz (where we also support a collection of xyz) is more intuitive and consistant |
| 01:19:49 | <djazayeri> but I may be too close to OpenMRS to have a good sense of what's intuitive for someone new to the system |
| 01:20:01 | *** harshadura has quit IRC |
| 01:20:21 | <djazayeri> My concern is that, since we actually support a person having multiple names, it confuses the issue to have a single personName property. |
| 01:27:25 | <finbrein> djazayeri: i am looking at it from the JSON data where we have "preferredName":{ "givenName":"Michael", "familyName":"Aro" }, for example. How it is interpreted by the web service. In the "person_name" table of the openmrs database, we "preferred", "given_name" and "family_name" fields. |
| 01:28:47 | <finbrein> djazayeri: I am thinking rather than having "preferredIdentifier":{"identifier":"abc123ez", |
| 01:28:47 | <finbrein> "identifierType":"8d79403a-c2cc-11de-8d13-0010c6dffd0f","location":"Unknown Location"} and "preferredName":{ "givenName":"Michael", "familyName":"Aro" } |
| 01:30:02 | <finbrein> djazayeri: we should have: "personIdentifier":{"identifier":"abc123ez","identifierType":"8d79403a-c2cc-11de-8d13-0010c6dffd0f","location":"Unknown Location"} and "personName":{ "givenName":"Michael", "familyName":"Aro" } |
| 01:30:37 | <djazayeri> finbrein: how would they create a patient with 2 identifiers then? |
| 01:30:51 | <finbrein> djazayeri: what will the web service do when it receives the JSON data? |
| 01:33:00 | *** benf has joined #openmrs |
| 01:33:37 | *** benf is now known as Guest95545 |
| 01:34:24 | <djazayeri> finbrein: practically, it calls the relevant method for setPreferredIdentifier (or setPatientIdentifier) |
| 01:35:27 | <djazayeri> finbrein: I could certainly imagine deciding that when you create a Patient you are _not_ allowed to specify the preferredIdentifier/patientIdentifier property, but rather you have to specify identifiers (as a list, maybe with just a single element), and the top element in the list becomes the preferred one |
| 01:35:50 | <djazayeri> finbrein: then the preferredIdentifier property can be used only for updates, to switch which existing identifier is the preferred one. |
| 01:38:01 | <finbrein> thanks for the explanations djazayeri |
| 01:38:24 | <djazayeri> finbrein: to be clear, I have described a way we *might* want it to work. |
| 01:39:02 | <djazayeri> right now, when you specify a preferredIdentifier property, it (because of the "remappedProperties") calls setPatientIdentifier |
| 01:39:29 | <djazayeri> I don't know if your'e allowed to create a patient with multiple identifiers in a single POST right now. |
| 01:39:46 | <djazayeri> i.e. I don't know if that works correctly. |
| 01:42:13 | <finbrein> djazayeri: What are multiple identifiers? |
| 01:42:51 | <djazayeri> finbrein: I could have Clinic ID = 12345678-9, and National ID = 535234 |
| 01:42:53 | <finbrein> djazayeri: I think we have only the "identifier" |
| 01:43:12 | <djazayeri> finbrein: meaning that a patient can have more than one Identifier. |
| 01:43:56 | <finbrein> djazayeri: ok |
| 01:46:44 | <finbrein> djazayeri: Well I don't much about the medical side of things |
| 01:47:21 | <finbrein> djazayeri: but I understand now that we can have Clinic ID and National ID |
| 01:47:59 | <finbrein> djazayeri: Are they always different from each other? |
| 01:48:18 | <djazayeri> finbrein: typically |
| 01:48:34 | <djazayeri> finbrein: the idea is that there can be multiple identifier _types_ |
| 01:48:54 | <djazayeri> finbrein: https://wiki.openmrs.org/x/mhEz |
| 01:48:55 | <djazayeri> gotta run |
| 01:48:59 | <finbrein> djazayeri: that is very clear |
| 01:49:11 | <finbrein> djazayeri: please don't go ;) |
| 01:49:33 | <finbrein> djazayeri: ok, thanks and talk later |
| 01:50:07 | *** Mkop has quit IRC |
| 01:50:46 | *** Mkop has joined #openmrs |
| 01:50:46 | *** ChanServ sets mode: +v Mkop |
| 02:09:33 | *** nwilkie has joined #openmrs |
| 02:10:10 | <nwilkie> hello out there, I'm having a problem creating encounters using the Webservices.REST module |
| 02:11:10 | <nwilkie> Using a close approximation of the text from https://tickets.openmrs.org/browse/RESTWS-141, which Darius mentions works at https://groups.google.com/a/openmrs.org/group/implementers/browse_thread/thread/4c1d1a1bb018d66d/4652a29d82fea329?lnk=gst&q=Web+services+encounter#4652a29d82fea329, |
| 02:11:15 | <OpenMRSBot> <http://ln-s.net/$2-n> (at groups.google.com) |
| 02:11:32 | <nwilkie> I get a org.hibernate.exception.ConstraintViolationException: could not insert: [org.openmrs.Encounter] |
| 02:15:00 | <r_friedman> nwilkie: that says that either you have left out a required field or that you are trying to link to an object that doesn't exist |
| 02:15:48 | <nwilkie> thanks r_friedman! do you know how I find a list of required fields? |
| 02:16:10 | <nwilkie> for encounter, patient, etc |
| 02:16:18 | <nwilkie> so that I can see where I'm going wrong |
| 02:16:29 | *** Rahul has quit IRC |
| 02:17:25 | <r_friedman> nwilkie: well, you can look at the data model or you can go to svn and look up the <object>.hbm.xml files |
| 02:17:34 | <r_friedman> nwilkie: what os are you running? |
| 02:18:01 | <nwilkie> the server is on Ubuntu |
| 02:18:19 | <r_friedman> nwilkie: and the client is ... |
| 02:18:27 | <nwilkie> I'm running on a mac |
| 02:18:36 | <nwilkie> just testing using a Chrome plugin |
| 02:18:48 | <nwilkie> submitting JSON commands directly |
| 02:19:03 | <r_friedman> ok, np, just making sure that you weren't having a CR-LF problem |
| 02:19:09 | <nwilkie> so I at least know what works before I program into my android app |
| 02:19:54 | <nwilkie> there's one more error I get if you have the time to take a look |
| 02:19:57 | <nwilkie> ConversionException: obs on class org.openmrs.Encounter |
| 02:20:11 | <nwilkie> thrown from org.openmrs.module.webservices.rest.web.resource.impl.BaseDelegatingResource |
| 02:20:48 | <nwilkie> my obs is super simple: "obs": [{ "concept":"WEIGHT", "value":"70" } ] |
| 02:20:59 | <nwilkie> within the encounter |
| 02:21:06 | <nwilkie> is there some syntax error I'm making here? |
| 02:23:00 | <nwilkie> and if I use the concept UUID in place of WEIGHT, I just go back to getting the ConversionException |
| 02:25:43 | <nwilkie> And BTW the message for the ConversionException reads "Unable to convert object into response content" |
| 02:29:01 | <r_friedman> nwilkie: never seen that before |
| 02:29:41 | <nwilkie> darn |
| 02:30:22 | <nwilkie> are you aware of anywhere that I could find working examples of OpenMRS REST code that I could model mine after? Or an app that uses it? |
| 02:30:38 | <nwilkie> Then I could just look for what they're doing differently |
| 02:31:06 | <r_friedman> nwilkie: if you put the addressee's name in the message, it will beep and tell him/her you've written. you can do the unique part of the name and then tab and irc will fill it in for you, so right now you could do r<tab> and get me |
| 02:31:43 | <nwilkie> r_friedman: ah, sorry I'm not well versed with IRC |
| 02:32:19 | <r_friedman> nwilkie: np, just that's why you don't get a quick response, we're not always watching |
| 02:32:41 | <r_friedman> it looks like that exception is a catch-all exception |
| 02:33:08 | <nwilkie> r_friedman: so not very descriptive of the problem, then |
| 02:33:20 | <r_friedman> nwilkie: not in the least |
| 02:33:48 | <bwolfe> !refer r_friedman [tabcomplete] |
| 02:33:49 | * OpenMRSBot refers r_friedman to "tabcomplete" --- Most IRC clients let you easily write someone's nickname in the channel using tab completion. Just type the first few letters, then <tab>, and voila! |
| 02:33:53 | <bwolfe> :-) |
| 02:34:23 | <bwolfe> nwilkie, there are some sample rest applications in the svn repo: http://svn.openmrs.org/openmrs-contrib/examples/webservices/ |
| 02:34:25 | <nwilkie> r_friedman: well I'm trying to use the UUIDs as my identifiers describing the patient, location, etc. Is this the right way to go? |
| 02:34:36 | <r_friedman> nwilkie: why don't you try this: get an existing encounter and try to create a new one with a new uuid |
| 02:34:40 | <bwolfe> nwilkie, and finbrein was working on a wiki page with example POST content just today |
| 02:34:53 | <r_friedman> nwilkie: no, you should generate one |
| 02:35:15 | <r_friedman> some people put in garbage: abcdef |
| 02:35:35 | <r_friedman> i usually use mysql select uuid(); and cut and paste |
| 02:36:04 | <nwilkie> bwolfe: I didn't see this, is it under the module's page? |
| 02:36:20 | <nwilkie> r_friedman: oh, so if I make a new object I need to generate the UUID on the client side? |
| 02:36:29 | <nwilkie> r_friedman: I assumed this was something I needed the server to do |
| 02:36:41 | <nwilkie> r_friedman: so I left it out of the request |
| 02:36:59 | <r_friedman> nwilkie: you are right, POST ...v1/<object> should generate a uuid for you |
| 02:37:10 | <bwolfe> nwilkie, looks like its two below: https://wiki.openmrs.org/display/docs/POST+Create+Patient |
| 02:37:29 | <nwilkie> r_friedman: also, I did try to request an encounter, then post it back with just a small change to the date or something (and the uuid removed, etc) |
| 02:37:47 | <r_friedman> nwilkie: and? |
| 02:38:21 | <r_friedman> nwilkie: what representation did you use? |
| 02:39:26 | <nwilkie> r_friedman: it gave me uuids |
| 02:39:35 | <nwilkie> r_friedman: so I used those first, then tried names |
| 02:39:46 | <r_friedman> nwilkie: sounds like you used ref |
| 02:39:57 | <nwilkie> bwolfe: posting a new patient did work! that's a relief |
| 02:40:06 | <nwilkie> r_friedman: no, it gave me the full obs list, i'm using default |
| 02:40:39 | <nwilkie> r_friedman: I misunderstood what you meant by representation |
| 02:40:42 | <r_friedman> nwilkie: well an obs can't belong to 2 encounters, so you need to cut that piece |
| 02:41:26 | <nwilkie> r_friedman: I took out the uuids for each ob so it looked like the JSON code I posted earlier |
| 02:41:31 | *** mathiaslin has quit IRC |
| 02:41:53 | <r_friedman> nwilkie: you can't do it at one fell swoop |
| 02:42:17 | <nwilkie> r_friedman: you can't include the obs in with the encounter? |
| 02:43:17 | <r_friedman> nwilkie: no, I don't think so, I think you have to create the obs, then create/update the obs collectoin in the encounter |
| 02:44:48 | <r_friedman> nwilkie: you may even have to create the encounter first, then create the obs referring to the encounter, then update the obs collection in the encounter |
| 02:45:32 | <nwilkie> r_friedman: That's really good to know! I was going off advice from the mailing list, where darius said this was supposed to work: https://tickets.openmrs.org/browse/RESTWS-141 |
| 02:45:40 | <r_friedman> nwilkie: we will be talking about this at the design meeting wed pm |
| 02:46:20 | <r_friedman> darius should know, but we keep finding unanticipated corners of REST |
| 02:46:26 | <nwilkie> r_friedman: ah so it's not resolved how this should work |
| 02:46:33 | <nwilkie> r_friedman: that makes me feel less stupid for not getting this |
| 02:47:38 | <r_friedman> nwilkie: there is a difference between the representation and the resource, whether we can create subresources or linked resources or subclass resources from within the resource is a question |
| 02:48:04 | <r_friedman> nwilkie: also whether it makes a difference if the relationship between the resources is one-to-many or many-to-many |
| 02:49:10 | <nwilkie> r_friedman: I can see why that would be an issue |
| 02:49:14 | <r_friedman> nwilkie: the thing is, we tried to design the reps to be useful to the user as is by expanding fields that we thought they'd be interested in, but that doesn't help them know what the required fields or updatable fields are |
| 02:49:47 | <nwilkie> r_friedman: ah, so I was going off an incorrect assumption there |
| 02:50:19 | <r_friedman> nwilkie: it might be correct, darius is usually correct, sometimes we don't execute things as he envisioned them |
| 02:50:34 | *** rohitgoyal18 has joined #openmrs |
| 02:51:31 | <r_friedman> nwilkie: when it comes to REST, sunbiz is always correct, darius is mostly correct, and i find all the snags |
| 02:52:00 | <nwilkie> r_friedman: well you certainly found me, a rats nest of snags |
| 02:52:21 | <r_friedman> nwilkie: my pleasure :) |
| 02:57:23 | *** upul` has joined #openmrs |
| 02:57:23 | *** ChanServ sets mode: +v upul` |
| 02:59:26 | <nwilkie> r_friedman: thanks so much for helping me out. I checked out the hibernate xml, and I can't see anything wrong with what I'm putting up. It looks like you guys are in the middle of a Webservices sprint, so perhaps I should just wait until the end of the week and then look at v1.0? |
| 02:59:34 | <nwilkie> r_friedman: is that a realistic goal? |
| 03:00:17 | <r_friedman> nwilkie: sure. i just looked at 141, and don't think that should work. i think you need uuids for location, encounter type and concept |
| 03:00:48 | <nwilkie> r_friedman: THANK YOU! I thought I was going crazy trying to figure out where in the code that was getting converted |
| 03:01:03 | <r_friedman> whether you can do the obs from the encounter is the quesiton i was focusing on |
| 03:01:21 | <nwilkie> r_friedman: but it still doesn't work with uuids, so oh well :/ |
| 03:01:36 | <r_friedman> it should work with uuids and no obs |
| 03:01:48 | <nwilkie> r_friedman: I get the error even if I remove the obs object from the JSON |
| 03:02:01 | <r_friedman> try to retrieve it first to make sure you didn't create it at least in part |
| 03:02:45 | <nwilkie> r_friedman: I'd happily give you an l/p to my test server if at any point in this development sprint you wanted to see the error I'm talking about |
| 03:03:01 | <nwilkie> r_friedman: and the code I'm using to submit |
| 03:03:02 | <r_friedman> are you running 1.8 or 1.9 on your server? |
| 03:03:21 | <nwilkie> 1.8 |
| 03:03:31 | <r_friedman> ok |
| 03:03:40 | <nwilkie> and this is the code I'm submitting without obs: { "encounterDatetime": "2011-10-10T00:00:00.000+0200", "patient":"4b17a6f4-1202-42b0-9f97-6ab04c3cfb56", "location":"8d6c993e-c2cc-11de-8d13-0010c6dffd0f", "encounterType":"8d5b27bc-c2cc-11de-8d13-0010c6dffd0f", "voided":false } |
| 03:03:42 | <nwilkie> just fyi |
| 03:04:10 | <r_friedman> nwilkie: provider? |
| 03:04:29 | <nwilkie> r_friedman: no, i did not include that |
| 03:04:32 | <nwilkie> let me give it a shot |
| 03:04:36 | <nwilkie> you certainly saw that quickly! |
| 03:04:53 | <r_friedman> as i say, i find snags :) |
| 03:05:46 | <r_friedman> nwilkie: make sure location is a location, provider is a user, patient is a patient |
| 03:05:54 | <r_friedman> encounter type is an encounter type |
| 03:06:58 | <r_friedman> nwilkie: also is voided being shown as 0 or false? maybe should be 0 |
| 03:07:11 | <nwilkie> r_friedman: I'll try all of that right now |
| 03:07:24 | <r_friedman> nwilkie: enjoy |
| 03:08:41 | <nwilkie> r_friedman: holy mother of god you did it |
| 03:08:50 | <nwilkie> r_friedman: I was just missing the provider |
| 03:09:10 | <nwilkie> r_friedman: that's like 5 hours of my time, and you saw it in 2 seconds |
| 03:09:23 | <nwilkie> r_friedman: THIS is why I'm not a programmer |
| 03:09:25 | <r_friedman> nwilkie: tag, now you're the expert |
| 03:09:51 | <nwilkie> r_friedman: haha, so that's how experts get so bitter. trial and error error error error error error |
| 03:10:23 | <r_friedman> nwilkie: that's way 13 years old is a good age for a programmer, you're willing to bang your head against the wall until you figure it out |
| 03:12:41 | <nwilkie> r_friedman: agreed. 28 year olds are old dogs |
| 03:13:08 | <nwilkie> r_friedman: and as a med student I'm wary of the concussions from banging my head against a wall |
| 03:13:21 | <r_friedman> nwilkie: 66 year olds are toothless old dogs |
| 03:13:40 | <nwilkie> r_friedman: there's no way in hell you're 66 |
| 03:13:51 | <r_friedman> yep |
| 03:14:18 | <r_friedman> but if you're a med student, at least your memory still works |
| 03:15:56 | <nwilkie> r_friedman: I could swear I saw an image of you on a form at some point and you were like 20 |
| 03:16:05 | <r_friedman> haha that's my kid |
| 03:16:09 | <nwilkie> r_friedman: so apparently my memory is not quite what you'd want in a doctor! |
| 03:16:12 | <nwilkie> r_friedman: aaaah ok |
| 03:16:31 | <nwilkie> r_friedman: well I can't thank you enough for helping me, this is huge for me |
| 03:16:48 | <r_friedman> np, that's the community |
| 03:16:59 | <nwilkie> r_friedman: I'm trying to get Doctors without Borders onto OpenMRS and I'm building an android app for them to get up and running |
| 03:17:30 | <nwilkie> r_friedman: we're deploying to cameroon to keep track of cholera patients to start out, but if it works out it'll be in much wider usage |
| 03:17:33 | <r_friedman> nwilkie: oh, we talked to some guys from Geneva about Openmrs, a chinese or korean guy, i forget which, was quite active for a while |
| 03:17:43 | <nwilkie> r_friedman: Thang! |
| 03:17:48 | <nwilkie> r_friedman: yes, he's the head honcho |
| 03:17:59 | <nwilkie> r_friedman: REALLY smart man |
| 03:18:21 | <r_friedman> nwilkie: yes, he was good to have around |
| 03:18:42 | <r_friedman> nwilkie: too many honchos have attitudes but he didn't |
| 03:18:47 | <nwilkie> r_friedman: he's going with another EHR suite for their new hospital, but he's letting me do OpenMRS for their mobile projects |
| 03:19:25 | <r_friedman> nwilkie: cool, you need to talk to Daniel Kayiwa, he is the one who works most with mobile |
| 03:19:33 | <nwilkie> r_friedman: no, he's super down to earth. he has been so kind through this project |
| 03:19:44 | <nwilkie> r_friedman: does Daniel come on IRC a lot? |
| 03:20:04 | <r_friedman> yes, but he's in Uganda, so he's 6 hours ahead of EDT |
| 03:21:17 | <nwilkie> r_friedman: good to know! but I end up having to stay up until early in the morning many days anyway, so that's fine with me |
| 03:22:01 | <r_friedman> he's the author of xforms, he's done some work on REST, I don't know what is attitude is toward replacing XForms with REST calls, guess it depends on the device |
| 03:22:18 | <nwilkie> r_friedman: oooh yes I have talked to him |
| 03:22:32 | <nwilkie> r_friedman: briefly |
| 03:23:04 | <nwilkie> r_friedman: I'm personally not a big fan of javarosa, even though the XForms plugin is great |
| 03:23:37 | <nwilkie> r_friedman: that's what prompted me to get away from ODK |
| 03:23:43 | <r_friedman> nwilkie: the pace of mobile technology over the past 3 years has been just incredible |
| 03:24:09 | <nwilkie> r_friedman: yes it has, I absolutely love being involved |
| 03:24:20 | <nwilkie> r_friedman: especially when you get to start from scratch. very liberating |
| 03:24:25 | <nwilkie> r_friedman: though onerous |
| 03:25:00 | <r_friedman> nwilkie: a new concept of app, more limited, more disposable, more dependent on back end DBs |
| 03:26:14 | <r_friedman> nwilkie: although the sensor stuff is keen also |
| 03:26:50 | <nwilkie> yeah, we're going for the whole disposable idea |
| 03:26:55 | <nwilkie> make an app for cholera |
| 03:27:07 | <nwilkie> use it as it's useful |
| 03:27:33 | <nwilkie> r_friedman: then make a separate app for something else we want to do with all the tweaks they want |
| 03:27:44 | <r_friedman> so i work at cdc, i know about surveillance and all, what are the goals of the app? |
| 03:27:49 | <nwilkie> r_friedman: including for events like particular catastrophes |
| 03:28:12 | *** bwolfe has quit IRC |
| 03:28:12 | <nwilkie> r_friedman: oh cool, I didn't know that you were at the CDC! |
| 03:28:40 | <r_friedman> yeah, in fact i'm friends with the people in charge of the cholera investigation in Hati |
| 03:28:44 | <nwilkie> r_friedman: well as you noted we are doing surveillance, and that's the main goal |
| 03:29:12 | <nwilkie> r_friedman: but we're also trying to get performance data for MSF. How their patients are doing, how much meds they're using |
| 03:29:12 | <r_friedman> individual case reports? or ticks on a map? or what? |
| 03:30:02 | <r_friedman> nwilkie: so MSF has clinics/hospitals? |
| 03:30:29 | <nwilkie> r_friedman: we're going to monitor the data live. So we're collecting a full report for each patient, then aggregating the location data to preempt epidemics where we can |
| 03:30:38 | <r_friedman> are you looking for endemic cholera or outbreak cholera? |
| 03:30:50 | <nwilkie> r_friedman: MSF works with a water sanitization group to deal with epidemics when we see them |
| 03:30:53 | <nwilkie> r_friedman: both |
| 03:31:04 | <nwilkie> r_friedman: but the real benefit will be in outbreaks |
| 03:31:09 | <djazayeri> hi r_friedman and nwilkie |
| 03:31:16 | <r_friedman> hey djazayeri |
| 03:31:18 | <djazayeri> was there actually a question for me? I haven't scrolled up all the way |
| 03:31:34 | <r_friedman> we worked it out with a pencil |
| 03:31:36 | <nwilkie> r_friedman: they can't set up good IT infrastructure at the makeshift clinics, so moblile phones are perfect |
| 03:31:59 | <nwilkie> yes, it was a simple omission on my part |
| 03:32:01 | <r_friedman> but djazayeri , on restws-178 |
| 03:32:34 | <r_friedman> my test always explodes in junit, but other tests also explode similiarly, just not as consistently |
| 03:32:54 | <r_friedman> but my test works like a real test on mvn install |
| 03:33:27 | <djazayeri> r_friedman: you mean they don't work in eclipse if you right click and run as junit test? |
| 03:33:34 | <djazayeri> but they pass in the maven build? |
| 03:33:35 | <r_friedman> correct |
| 03:33:53 | <r_friedman> well, they don't pass yet because the save isn't working |
| 03:34:07 | <r_friedman> but they don't explode |
| 03:34:08 | <djazayeri> r_friedman: if you run just a single test does it blow up? |
| 03:34:16 | <r_friedman> yes |
| 03:34:47 | <r_friedman> djazayeri: i think there's got to be osmething not right with test application context |
| 03:35:00 | <djazayeri> r_friedman: strange |
| 03:35:07 | <r_friedman> as i say, I can make other tests blow up as well |
| 03:35:09 | <djazayeri> this is in RESTWS, not the jsslab module, right? |
| 03:35:13 | <r_friedman> right |
| 03:35:35 | <r_friedman> maybe it's something like memory allocation on my machine |
| 03:35:56 | <djazayeri> r_friedman: do they blow up with OutOfMemory? |
| 03:36:11 | <r_friedman> no, they blow up with hibernate mapping errors |
| 03:36:34 | <r_friedman> failure to create sessionFactory in test application context |
| 03:37:02 | <djazayeri> r_friedman: very strange |
| 03:37:07 | <djazayeri> well, just trust the maven build for now |
| 03:37:32 | <r_friedman> problem is, it won't run as debug, not very convenient |
| 03:37:46 | <djazayeri> r_friedman: doh |
| 03:37:57 | <djazayeri> r_friedman: try intellij. :-) |
| 03:38:14 | <r_friedman> djazayeri: right |
| 03:38:29 | <r_friedman> shall i pastebin the class? |
| 03:38:57 | <djazayeri> r_friedman: the tests work in eclipse before you create the test class? |
| 03:39:25 | <r_friedman> djazayeri: no, i don't know how to do them without a class |
| 03:39:48 | <r_friedman> djazayeri: you mean just doing the calls? |
| 03:40:02 | <djazayeri> r_friedman: I mean, when you did a clean checkout did the tests pass in eclipse? |
| 03:40:28 | <r_friedman> djazayeri: as i say, no, but they are detecting what i believe to be legitimate problems |
| 03:41:19 | <djazayeri> r_friedman: if they pass for everyone else, and for you in the maven build, I feel like it must be something about your eclipse. :-P |
| 03:41:47 | <r_friedman> djazayeri: could be |
| 03:42:18 | *** r0bby has quit IRC |
| 03:43:39 | <r_friedman> djazayeri: if i just write everything right the frirst time, the tests won't be important |
| 03:43:59 | <djazayeri> r_friedman: the tests will still be important, but debugging them won't be... |
| 03:44:21 | <djazayeri> r_friedman: there's probably a command-line argument you can pass to the maven build that will tell it to only run a specific test |
| 03:44:45 | <djazayeri> if you can't debug the tests, at least that might make it a lot faster to run a single test after a code modification. |
| 03:45:00 | <r_friedman> djazayeri: quite. i will try to find that. thanks, g'nte, i'm fading fast |
| 03:45:05 | <djazayeri> gnight |
| 03:45:15 | *** r_friedman has quit IRC |
| 03:59:28 | *** rohitgoyal18 has quit IRC |
| 04:21:41 | *** rohitgoyal18 has joined #openmrs |
| 05:08:43 | *** rohitgoyal18 has quit IRC |
| 05:15:01 | *** sk has quit IRC |
| 05:25:30 | *** hari_ has joined #openmrs |
| 05:31:42 | *** sk has joined #openmrs |
| 06:05:01 | *** hari_ has quit IRC |
| 06:07:26 | *** bryq has joined #openmrs |
| 06:07:26 | *** ChanServ sets mode: +v bryq |
| 06:18:24 | *** bryq has quit IRC |
| 06:18:58 | *** bryq has joined #openmrs |
| 06:18:58 | *** ChanServ sets mode: +v bryq |
| 06:36:32 | *** bryq has quit IRC |
| 06:56:29 | *** sk has quit IRC |
| 06:57:01 | *** snoppy has joined #openmrs |
| 07:20:10 | *** robbyoconnor has quit IRC |
| 07:20:38 | *** robbyoconnor has joined #openmrs |
| 07:20:38 | *** ChanServ sets mode: +v robbyoconnor |
| 07:23:36 | *** mvorobey has joined #openmrs |
| 07:23:50 | <mvorobey> hi all |
| 07:31:06 | *** rafa has joined #openmrs |
| 07:31:06 | *** ChanServ sets mode: +v rafa |
| 07:40:20 | *** shetyeakash has joined #openmrs |
| 07:40:36 | *** shetyeakash is now known as shetyekash |
| 07:41:22 | <shetyekash> I dont see any way to download a module's code? |
| 07:41:40 | <shetyekash> I needed to look at Patient Image module for learning activity |
| 07:49:47 | <robbyoconnor> shetyekash: svn repository. |
| 07:51:29 | <shetyekash> robbyoconnor: thanks got it |
| 07:56:16 | *** sk has joined #openmrs |
| 08:04:27 | *** shetyekash has quit IRC |
| 08:06:34 | *** dkayiwa has joined #openmrs |
| 08:42:32 | *** snoppy has left #openmrs |
| 08:49:22 | *** rafa has quit IRC |
| 09:05:07 | *** suranga has joined #openmrs |
| 09:05:07 | *** ChanServ sets mode: +v suranga |
| 09:05:53 | <suranga> m... hi dkayiwa ... quick question... do u know of any openmRS module that generates a HL7 message ? :-) |
| 09:40:21 | *** suranga has quit IRC |
| 09:45:05 | *** dkayiwa has quit IRC |
| 09:47:14 | *** kishoreyekkanti has joined #openmrs |
| 09:52:39 | *** dkayiwa has joined #openmrs |
| 10:00:46 | <kishoreyekkanti> dkayiwa: Hey how are you!! |
| 10:01:44 | <dkayiwa> hi kishoreyekkanti |
| 10:02:00 | <kishoreyekkanti> dkayiwa: Hey its been a long time |
| 10:02:02 | <dkayiwa> kishoreyekkanti: how are you today? long time :) |
| 10:02:09 | <kishoreyekkanti> dkayiwa: lol yep |
| 10:02:15 | <dkayiwa> :D |
| 10:02:27 | <kishoreyekkanti> dkayiwa: was busy with some other stuff. Got some time today to work on OpenMRS |
| 10:02:43 | <dkayiwa> kishoreyekkanti: oh good to see you back!!! :) |
| 10:02:57 | <kishoreyekkanti> dkayiwa: thank you!! :) |
| 10:03:04 | <dkayiwa> kishoreyekkanti: so what are you working on today? |
| 10:03:38 | <kishoreyekkanti> dkayiwa: I'm looking at embedding mysql for release testing module |
| 10:03:56 | <kishoreyekkanti> dkayiwa: I mean running the jbehave release tests in the embeded mysql database. |
| 10:04:09 | <dkayiwa> kishoreyekkanti: oh i see |
| 10:04:10 | <kishoreyekkanti> dkayiwa: currently we need to configure the url to a running mysql db |
| 10:04:19 | <dkayiwa> kishoreyekkanti: must be fun exploring that :) |
| 10:04:39 | <kishoreyekkanti> dkayiwa: :) yeah its fun and challenging.. |
| 10:04:57 | <dkayiwa> kishoreyekkanti: hahahaha. yes there is no fun without challenges :) |
| 10:04:57 | <kishoreyekkanti> dkayiwa: btw i've seen webapp using some depedencies to mysql-mxj-dbfiles |
| 10:05:19 | <dkayiwa> kishoreyekkanti: it is not supposed to, as far was i know |
| 10:05:21 | <kishoreyekkanti> dkayiwa: do you have any idea why/where we are configuring it |
| 10:05:30 | <kishoreyekkanti> dkayiwa: ohh ;) |
| 10:05:45 | <dkayiwa> kishoreyekkanti: it is the standalone that needs them |
| 10:05:50 | <dkayiwa> kishoreyekkanti: not the webapp |
| 10:06:07 | <kishoreyekkanti> dkayiwa: ahh yes. I've seen it in the standalone |
| 10:06:15 | <dkayiwa> kishoreyekkanti: yu[ |
| 10:06:16 | <dkayiwa> p |
| 10:06:38 | <kishoreyekkanti> dkayiwa: I've bit lost when i was looking at standalone code as it was little complex to understand the configuration. |
| 10:07:12 | <dkayiwa> kishoreyekkanti: oh sorry |
| 10:07:57 | <kishoreyekkanti> dkayiwa: cool, any ways i'll look at it now. |
| 10:08:13 | <kishoreyekkanti> dkayiwa: i'll be hanging around. catch you back soon! :) |
| 10:08:54 | <dkayiwa> kishoreyekkanti: see ya :) |
| 10:17:58 | *** Shripad has joined #openmrs |
| 10:18:21 | <Shripad> Hi |
| 10:18:36 | <Shripad> did anybody run FindBug on OpenMRS codebase? |
| 10:18:48 | <Shripad> I tried that today |
| 10:18:54 | <Shripad> and found some interesting issues |
| 10:23:38 | <Shripad> for example Module class defined equals but does not define hashcode |
| 10:25:48 | *** Shripad has left #openmrs |
| 10:26:00 | *** Shripad has joined #openmrs |
| 10:29:55 | *** Shripad has left #openmrs |
| 10:54:12 | *** rafa has joined #openmrs |
| 10:54:12 | *** ChanServ sets mode: +v rafa |
| 10:54:13 | *** upul` has quit IRC |
| 10:54:24 | <rafa> hi dkayiwa |
| 10:54:28 | <dkayiwa> hi rafa |
| 10:54:49 | <rafa> regarding problems with the release testing |
| 10:55:09 | <rafa> we need to change the code to give more detailed errors from mysql |
| 10:55:24 | <dkayiwa> rafa: i agree |
| 10:55:59 | <rafa> dkayiwa: I don't know how, but it needs to be investigated :) |
| 10:56:17 | <rafa> dkayiwa: fun is yours :) |
| 10:56:28 | <dkayiwa> rafa: very very true. first step is creating the ticket |
| 10:56:35 | <dkayiwa> rafa: and then vote for it :) |
| 10:56:48 | <rafa> dkayiwa: haha I'll vote :D |
| 10:57:26 | *** bryq has joined #openmrs |
| 10:57:26 | *** ChanServ sets mode: +v bryq |
| 10:57:33 | <dkayiwa> rafa: that way it wil appear in my list of tickets with most votes to work on |
| 10:57:35 | <dkayiwa> :) |
| 10:58:11 | <rafa> dkayiwa: we don't need many votes, do we? |
| 10:58:51 | <dkayiwa> rafa: the highest number of votes for the remaining tickets is 1 :) |
| 10:59:11 | <dkayiwa> rafa: so if you can get two votes, it will come top on my list :) |
| 11:09:33 | *** suranga has joined #openmrs |
| 11:18:57 | *** sk has quit IRC |
| 11:24:02 | *** downey has joined #openmrs |
| 11:24:02 | *** OpenMRSBot sets mode: +o downey |
| 11:24:02 | *** ChanServ sets mode: +o downey |
| 11:33:21 | *** nwilkie has quit IRC |
| 11:35:08 | *** james_regen has joined #openmrs |
| 11:35:08 | *** ChanServ sets mode: +v james_regen |
| 11:56:16 | *** wyclif has quit IRC |
| 12:01:29 | *** nribeka has quit IRC |
| 12:05:29 | *** bwolfe has joined #openmrs |
| 12:05:29 | *** ChanServ sets mode: +o bwolfe |
| 12:05:55 | <bwolfe> dkayiwa, if you are looking for tickets or other work, you can also start reviewing/applying attachments by devs: https://tickets.openmrs.org/secure/IssueNavigator.jspa?mode=hide&requestId=10072 |
| 12:05:56 | <OpenMRSBot> <http://ln-s.net/8zah> (at tickets.openmrs.org) |
| 12:06:04 | <bwolfe> (thats the "open tickets with attachments" query) |
| 12:06:16 | <dkayiwa> bwolfe: ok |
| 12:29:59 | *** suranga has quit IRC |
| 12:43:09 | *** bwolfe has quit IRC |
| 12:43:23 | *** nribeka has joined #openmrs |
| 12:43:23 | *** ChanServ sets mode: +v nribeka |
| 12:48:11 | *** jmiranda has joined #openmrs |
| 12:49:03 | *** wyclif has joined #openmrs |
| 12:55:12 | *** AndroUser has joined #openmrs |
| 12:55:22 | <downey> Hi AndroUser and welcome to the #openmrs IRC channel. |
| 12:56:13 | *** AndroUser has left #openmrs |
| 13:02:05 | *** jriley has joined #openmrs |
| 13:02:29 | *** MarkG has joined #openmrs |
| 13:03:49 | *** kavuri has joined #openmrs |
| 13:04:07 | <kavuri> djazayeri: I have added freeconferencing to my skype account |
| 13:04:13 | <kavuri> djazayeri: and someone needs to approve it? |
| 13:05:28 | <djazayeri> kavuri: unfortunately freeconferencing's skype user isn't online all the time, and it looks like now it is not |
| 13:05:50 | <kavuri> djazayeri: how do I attend today's call? |
| 13:06:02 | <kavuri> the open university call |
| 13:06:11 | <djazayeri> kavuri: can you join via adobe connect? |
| 13:06:27 | <kavuri> djazayeri: never did that..can you send some link? |
| 13:06:37 | <djazayeri> connect.openmrs.org and click the breeze.iu.edu link for OpenMRS University |
| 13:06:49 | <djazayeri> kavuri: http://breeze.iu.edu/omrsu/ |
| 13:07:42 | <kavuri> djazayeri: joining now..how about voice? |
| 13:08:38 | *** downey sets mode: +v wyclif |
| 13:08:42 | *** downey sets mode: +v jriley |
| 13:08:44 | *** downey sets mode: +o jmiranda |
| 13:08:44 | *** ChanServ sets mode: -o jmiranda |
| 13:08:50 | *** downey sets mode: +v jmiranda |
| 13:08:53 | *** downey sets mode: +v dkayiwa |
| 13:08:56 | *** downey sets mode: +v MarkG |
| 13:09:00 | <djazayeri> kavuri: can you not hear janet and I talking? |
| 13:09:12 | <kavuri> djazayeri: yes, I can |
| 13:17:45 | *** mvorobey_ has joined #openmrs |
| 13:17:49 | <mvorobey_> hi all |
| 13:18:53 | *** mvorobey_ has quit IRC |
| 13:22:55 | *** mseaton has joined #openmrs |
| 13:23:07 | *** ChanServ sets mode: +v mseaton |
| 13:46:25 | *** downey has quit IRC |
| 13:49:13 | *** r6friedman has joined #openmrs |
| 13:49:24 | *** r6friedman is now known as r_friedman |
| 13:49:28 | *** downey has joined #openmrs |
| 13:49:28 | *** OpenMRSBot sets mode: +o downey |
| 13:49:28 | *** ChanServ sets mode: +o downey |
| 13:50:08 | <r_friedman> hi rafa, are you done with the synch catastrophe? |
| 13:50:21 | <rafa> r_friedman: hi, yes |
| 13:50:22 | <dkayiwa> r_friedman: :D |
| 13:51:07 | *** bwolfe-tab has joined #openmrs |
| 13:51:07 | *** ChanServ sets mode: +o bwolfe-tab |
| 13:51:11 | <r_friedman> rafa, I have a couple of mavenish problems. one we were working on we tried something that didn't work |
| 13:51:19 | <downey> Hi bwolfe-tab and welcome to the #openmrs IRC channel. |
| 13:51:40 | <bwolfe-tab> Irc in a web app on a tablet |
| 13:52:03 | * bwolfe-tab plans for worst experience ever... |
| 13:52:24 | <rafa> r_friedman: could you remind me what was that? |
| 13:52:35 | <r_friedman> rafa, haha was hoping you could remind me |
| 13:52:58 | <dkayiwa> bwolfe-tab: i have broken CI for 1.6.x But looked at my commit and failed to see what is wrong with it |
| 13:53:07 | <rafa> r_friedman: ohh I remember, it's moving test from omod to api |
| 13:53:11 | <jriley> dkayiwa! It's wonderful that 1.9 RC 3 is out! I'm going to update my installation. Is there anything in particular you need tested so it can be the official release? |
| 13:53:17 | <r_friedman> problem 1 was that the lab module is no longer seeing the test-jar created by ws-rest |
| 13:53:43 | <dkayiwa> jriley: first of all the new features :) |
| 13:53:51 | <r_friedman> you're right about 2, i was going to let you move things as soon as i got updated, but when i updated, i ran into problem 1 |
| 13:53:57 | <rafa> r_friedman: that I checked and it worked for me :/ |
| 13:53:57 | <jriley> Anything that changed between rc2 and rc3? |
| 13:54:11 | <rafa> r_friedman: I mean problem 2 |
| 13:54:17 | <rafa> r_friedman: pff problem 1 |
| 13:54:21 | <dkayiwa> jriley: only bug fixes |
| 13:54:52 | <dkayiwa> by the way jriley you have been lost for a while. were you fine? :) |
| 13:54:56 | <rafa> r_friedman: do you still have a problem with that? I've modified ws to create test-jars |
| 13:55:04 | <jriley> Ok. I'll work some fix checking into my path |
| 13:55:17 | <r_friedman> rafa, yes the jars get created, but the lab module can't find them |
| 13:55:25 | <rafa> r_friedman: can you update ws and try clean install again on that and later on lab |
| 13:55:27 | <jriley> dkayiwa, yes, fine. My laptop was getting fixed. I had a loaner, but it was a very long five days |
| 13:55:53 | <dkayiwa> jriley: oh sorry about that. Good to see you back!!! :D |
| 13:56:09 | <jriley> I missed my keyboard shortcuts. And my IDE. And my address book. And ... :) |
| 13:56:20 | <r_friedman> rafa, updated ws yesterday after your e-mail, but have work in progress in it now |
| 13:56:47 | <dkayiwa> jriley: oh sorry. :( |
| 13:56:58 | <r_friedman> did clean install on jsslab and got problem 1 -- which had been working fine for a while |
| 13:57:12 | <jriley> All better now. |
| 13:57:15 | <r_friedman> rafa, i upgraded the dependencies and that's what broke it |
| 13:57:59 | <dkayiwa> jriley: And you will get even better! :) |
| 13:58:08 | <rafa> r_friedman: hmm that is really strange, because I've checked out jsslab and no problems with that |
| 13:58:31 | <rafa> r_friedman: there must be something strange going on with your eclipse :) |
| 13:58:44 | <r_friedman> rafa, i haven't checked in what's here, i wanted to make sure it worked first |
| 13:59:02 | <r_friedman> rafa, but my eclipse is acting strange, I probably should uninstall and reinstall |
| 13:59:35 | <rafa> r_friedman: you mean you have not committed changes in jsslab? |
| 13:59:37 | <r_friedman> rafa, let me check in what i have in jsslab, then i will reinstall eclipse |
| 13:59:46 | <r_friedman> rafa, yes |
| 13:59:58 | <rafa> r_friedman: commit and let me see |
| 14:01:27 | <r_friedman> rafa, checked in -- looks like i had already done so, only a couple of small changes left |
| 14:01:50 | <r_friedman> pls take a look, look at problem 2, and I will reinstall eclipse |
| 14:02:11 | <djazayeri> !scrumon bwolfe-tab |
| 14:02:11 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster bwolfe-tab- you may begin when ready. |
| 14:02:13 | <rafa> r_friedman: still works fine |
| 14:02:20 | <djazayeri> (or bwolfe-tab, do you want me to lead today?) |
| 14:02:32 | <rafa> r_friedman: okay, I'll deal with the 2. |
| 14:03:25 | <djazayeri> today's order: dkayiwa, wyclif, bwolfe-tab, web-services: djazayeri, rafa, finbrein, r_friedman |
| 14:03:54 | <djazayeri> (anyone I'm missing?) |
| 14:03:58 | <dkayiwa> Spent some time on: Unit of work - transaction bounary is not correct - Patient.form maybe more places - TRUNK-229. I have not yet got a solution for it. |
| 14:03:59 | <dkayiwa> Committed: Reporting module should never return results for voided patients by default - REPORT-32 |
| 14:03:59 | <dkayiwa> Committed: Changing concept names with the ui doesn't save - TRUNK-3149 |
| 14:03:59 | <dkayiwa> Looked into: htmlformentry: repeated questions are unable to maintain the order of their answers - HTML-10. And i need direction on the way forward for it. |
| 14:04:00 | <dkayiwa> Now working on: htmlInclude tag should be synchronized - TRUNK-266 |
| 14:04:00 | <dkayiwa> No Blockers |
| 14:04:33 | <wyclif> Tuesday: |
| 14:04:33 | <wyclif> * Update the discussion etherpad with new structure for DrugOrders |
| 14:04:33 | <wyclif> * order entry the design |
| 14:04:33 | <wyclif> Today:(pick up bug ticket until after the design call) |
| 14:04:33 | <wyclif> * Exit Patient from Care: Exclude automatic program workflow state transition to PATIENT DIED for completed programs |
| 14:04:35 | <wyclif> * design call |
| 14:04:39 | <wyclif> * pick another bug ticket if done with above ticket before design call |
| 14:04:41 | <wyclif> Blockers: None |
| 14:04:45 | <djazayeri> dkayiwa: FWIW, "no blockers" and "I need direction on the way forward" aren't compatible |
| 14:04:54 | <dkayiwa> djazayeri: ok |
| 14:05:02 | <dkayiwa> :) |
| 14:05:37 | <dkayiwa> copy and paste with No Blockers at the end :) |
| 14:05:46 | <djazayeri> wyclif: will you send an email out before the design call so people can look? |
| 14:06:04 | <djazayeri> next up: bwolfe-tab |
| 14:06:12 | <wyclif> djazayeri, can look? |
| 14:06:26 | <djazayeri> wyclif: so people can look at your proposal before the call, and digest it |
| 14:06:40 | <wyclif> djazayeri, currently we have an etherpad |
| 14:07:18 | <djazayeri> wyclif: if you have completed design work for now, and you're now working on bugfix tickets, please send an email to the dev list pointing to the etherpad, in case people have comments in the next 4 hours before the call |
| 14:07:22 | <djazayeri> bwolfe-tab: ping |
| 14:07:37 | <wyclif> djazayeri, ok |
| 14:07:50 | <djazayeri> okay, let's move on to the RESTWS sprint |
| 14:08:09 | <djazayeri> my report |
| 14:08:10 | <djazayeri> Tuesday 17-Apr-2012 |
| 14:08:10 | <djazayeri> * Created RESTWS-224 - ResourceDocCreator should generate documentation for POST content |
| 14:08:10 | <djazayeri> * Reviewed RESTWS-214 - Self link has wrong URL for module resources |
| 14:08:10 | <djazayeri> * Closed RESTWS-207 - Search and Get All queries should allow you to specify the desired representation |
| 14:08:10 | <djazayeri> * Reviewed RESTWS-180 - Modify WSDoc annotation to support links |
| 14:08:11 | <djazayeri> * Looked up some UI Framework functionality for Mark, and created UIFR-13 - Document the @BindParams and @Validate annotations |
| 14:08:11 | <djazayeri> * Designed RESTWS-221 - Decide how sub-classes should be handled |
| 14:08:12 | <djazayeri> * Helped jriley with FACILITY-9 - Validator errors on Save |
| 14:08:12 | <djazayeri> * Investigated TRUNK-3286 - FacilityData validator error is pertinent to Trunk |
| 14:08:13 | <djazayeri> Wednesday 18-Apr-2012 |
| 14:08:14 | <djazayeri> * University call |
| 14:08:14 | <djazayeri> * Design call |
| 14:08:15 | <djazayeri> * Project Management call |
| 14:08:15 | <djazayeri> * Sprint reviews and tickets |
| 14:08:33 | <djazayeri> rafa: you're up |
| 14:08:36 | <rafa> Today: |
| 14:08:36 | <rafa> * Investigated a little bit java.lang.RuntimeException: duplicate method: writeReplace in org.openmrs.module.htmlformentry.HtmlForm_$$_javassist_84 |
| 14:08:36 | <rafa> * Committed RESTWS-210: Rename subresources (e.g. person/_uuid_/attributes) to be singular, not plural |
| 14:08:36 | <rafa> https://tickets.openmrs.org/browse/RESTWS-210 |
| 14:08:36 | <rafa> * Corrected RESTWS-184: Allow HL7 messages to be submitted as-is via web service |
| 14:08:36 | <rafa> https://tickets.openmrs.org/browse/RESTWS-184 |
| 14:08:36 | <rafa> * Corrected RESTWS-180: Modify WSDoc annotation to support links |
| 14:08:37 | <rafa> https://tickets.openmrs.org/browse/RESTWS-180 |
| 14:08:37 | <rafa> * Will pick up a new rest ticket. |
| 14:08:38 | <rafa> No blockers. |
| 14:09:01 | <finbrein> Hi Everyone, my report today |
| 14:09:08 | <finbrein> Added the page for RESTWS-216 |
| 14:09:13 | <finbrein> Awaiting a feedback and move on to the next ticket |
| 14:09:20 | <djazayeri> !ticket RESTWS-216 |
| 14:09:21 | <OpenMRSBot> djazayeri: [#RESTWS-216] Add page describing POST content - OpenMRS JIRA - https://tickets.openmrs.org/browse/RESTWS-216 |
| 14:10:28 | <djazayeri> finbrein: I'd suggest moving onto another ticket now, as today's design discussion may affect RESTWS-216 |
| 14:10:37 | <djazayeri> finbrein: e.g. RESTWS-204 |
| 14:10:41 | <djazayeri> r_friedman: your turn |
| 14:10:51 | *** bwolfe-tab has quit IRC |
| 14:10:52 | <finbrein> djazayeri: noted |
| 14:10:54 | <r_friedman> rafa, tks for working on doc, very helpful |
| 14:11:07 | <r_friedman> working on RESTWS-178, almost done |
| 14:11:18 | <djazayeri> !ticket RESTWS-178 |
| 14:11:19 | <OpenMRSBot> djazayeri: [#RESTWS-178] Add Resource for LocationTag - OpenMRS JIRA - https://tickets.openmrs.org/browse/RESTWS-178 |
| 14:11:27 | <r_friedman> query, do you want me to update test data in core to include tags and tag maps or just use a custom data file? |
| 14:11:37 | *** bwolfe has joined #openmrs |
| 14:11:37 | *** ChanServ sets mode: +o bwolfe |
| 14:11:44 | <r_friedman> need to reinstall eclipse |
| 14:11:47 | <djazayeri> r_friedman: just use a custom data file in the restws module |
| 14:12:09 | <r_friedman> end of report |
| 14:12:40 | <djazayeri> mvorobey: any restws sprint updates? |
| 14:13:37 | <mvorobey> djazayeri, a few |
| 14:13:58 | <mvorobey> * Re-worked RESTWS-214 |
| 14:14:02 | <mvorobey> * No blockers |
| 14:14:06 | <djazayeri> !ticket restws-214 |
| 14:14:07 | <OpenMRSBot> djazayeri: [#RESTWS-214] Self link has wrong URL for module resources - OpenMRS JIRA - https://tickets.openmrs.org/browse/restws-214 |
| 14:14:51 | <djazayeri> thanks mvorobey |
| 14:14:55 | <djazayeri> !scrumoff |
| 14:14:55 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 14:15:03 | <djazayeri> bwolfe: you still have a chance to give an update |
| 14:15:09 | <djazayeri> otherwise, a few discussion points |
| 14:15:25 | <djazayeri> dkayiwa: TRUNK-229 |
| 14:15:28 | <djazayeri> !ticket TRUNK-229 |
| 14:15:28 | <bwolfe> ok, sorry for dropping off. thanks for picking up the slack darius |
| 14:15:28 | <OpenMRSBot> djazayeri: [#TRUNK-229] Unit of work - transaction bounary is not correct - Patient.form maybe more places - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-229 |
| 14:15:39 | <djazayeri> and dkayiwa: HTML-10 |
| 14:15:42 | <djazayeri> !ticket HTML-10 |
| 14:15:43 | <OpenMRSBot> djazayeri: [#HTML-10] htmlformentry: repeated questions are unable to maintain the order of their answers - OpenMRS JIRA - https://tickets.openmrs.org/browse/HTML-10 |
| 14:17:10 | <djazayeri> looking at HTML-10 (MarkG, correct me if I'm wrong), this seems like a complex problem, that requires a solution in core |
| 14:17:40 | <djazayeri> dkayiwa: you'd be a great person to create a core ticket for the required functionality (or to find an existing one and vote on it!) |
| 14:17:55 | <dkayiwa> djazayeri: ok |
| 14:18:03 | <djazayeri> Looking at TRUNK-229 |
| 14:19:11 | <rafa> r_friedman: tests in jsslab are not in a good shape |
| 14:19:18 | <rafa> r_friedman: they don't pass :) |
| 14:19:19 | <djazayeri> dkayiwa: have you verified where exactly the SQL update happens? |
| 14:19:39 | <r_friedman> rafa, yes it is known that laborder test doesn't work |
| 14:19:57 | <djazayeri> dkayiwa: is it in SimpleFormController.onBindAndValidate like Marc says? |
| 14:20:22 | <dkayiwa> djazayeri: not verified yet |
| 14:20:25 | <r_friedman> things that depend on laborder don't work, rafa |
| 14:21:29 | <MarkG> djazayeri: yes |
| 14:21:52 | <MarkG> djazayeri: any particulary reason why this ticket has come up now? |
| 14:22:22 | <djazayeri> MarkG: dkayiwa is working on bugfixes to core and bundled modules |
| 14:22:26 | <djazayeri> he's looking at tickets with votes |
| 14:22:34 | <MarkG> djazayeri: ah, got it |
| 14:22:49 | <MarkG> djazayeri: but yes, it really would need a core fix of some kind |
| 14:23:24 | <djazayeri> MarkG, dkayiwa: would this be solved if obs had a formFieldId property, saying which formField it came from? |
| 14:23:35 | <djazayeri> (well, that could solve it in xforms, but not htmlformentry) |
| 14:23:59 | <mseaton> djazayeri: if i go vote on all of the new facilitydata tickets, will these get done? (they are all pretty quick and easy I think). or are we limited to only certain strategic modules? |
| 14:24:15 | <dkayiwa> djazayeri: i do not think that would solve it even in xforms |
| 14:24:35 | <dkayiwa> djazayeri: the formfield would be one (with multiple obs members) |
| 14:24:45 | <djazayeri> mseaton: we set the boundaries as core + bundled modules from 1.9RC3 + metadata sharing + formentry |
| 14:24:58 | <djazayeri> dkayiwa: oh, right |
| 14:25:34 | *** kavuri has quit IRC |
| 14:25:37 | <djazayeri> mseaton: if they're trivial "module won't start in 1.9" sort of issues you could nicely ask dkayiwa to fix them, and it would be up to him whether he thinks they're important enough |
| 14:25:43 | <mseaton> djazayeri: right, that's what i thought. well, if you're looking for quick wins that multiple implementations are hoping for (james arbaugh, janet, us), they're there for the taking |
| 14:26:02 | <djazayeri> if he'd have to learn the workings of a new module, that's a tougher sell |
| 14:26:13 | *** harshadura has joined #openmrs |
| 14:26:33 | <mseaton> fair enough. but if we're having a hard time finding tickets to work on, there's plenty i could recommend :) |
| 14:26:55 | <dkayiwa> mseaton: plenty you could vote for :) |
| 14:27:21 | <mseaton> dkayiwa: will do! unfortunately one cannot vote for tickets they create. |
| 14:27:54 | <dkayiwa> mseaton: oh i see!!! Just create and the whole PIH team votes :) |
| 14:27:54 | <djazayeri> dkayiwa: maybe you should do a jira query for: all projects, unresolved, complexity=low, order by votes desc |
| 14:28:19 | <djazayeri> dkayiwa: i.e. to look at non-strategic modules to see if they have highly-voted issues that are easy to fix |
| 14:28:36 | <dkayiwa> djazayeri: did you intend to mean complexity != (NOT EQUAL) low ? |
| 14:28:38 | <djazayeri> just to have another source of bugs to look at |
| 14:28:45 | <djazayeri> dkayiwa: I mean complexit = low |
| 14:28:52 | <dkayiwa> djazayeri: ok |
| 14:29:18 | <bwolfe> whats the list of modules you ARE looking at? |
| 14:29:21 | <djazayeri> dkayiwa: you'd still make a judgment call as to whether anything is highly-voted-enough to do |
| 14:29:30 | <dkayiwa> djazayeri: ok |
| 14:29:58 | <djazayeri> bwolfe: the original query I suggested was |
| 14:29:59 | <dkayiwa> djazayeri: bwolfe had given me this: https://tickets.openmrs.org/secure/IssueNavigator.jspa?mode=hide&requestId=10072 |
| 14:29:59 | <djazayeri> project in ("OpenMRS Trunk", "OpenMRS Standalone", "Release Testing Helper", "Module Maven Archetype", "HTML Form Entry Module", "Reporting Module", "HTML Widgets", "Reporting Compatability Module", "Serialization XStream", "XForms Module", "Patient Flags Module", "Form Entry Module", "Metadata Sharing Module") |
| 14:29:59 | <OpenMRSBot> <http://ln-s.net/8zah> (at tickets.openmrs.org) |
| 14:31:02 | <djazayeri> dkayiwa: that's a good one |
| 14:31:06 | *** finbrein has quit IRC |
| 14:31:10 | <dkayiwa> djazayeri: ok |
| 14:31:32 | <djazayeri> dkayiwa: at the end of the week, maybe you can share with us what broader searches you tried that were useful at finding worthwhile tickets |
| 14:31:46 | <dkayiwa> djazayeri: ok |
| 14:32:33 | <bwolfe> dkayiwa, about 1.6.x failing. did you still have questions about that? is the test passing when run independently? |
| 14:32:52 | <dkayiwa> bwolfe: i think the test is buggy |
| 14:32:53 | <r_friedman> try reporter=r.friedman |
| 14:33:20 | <dkayiwa> bwolfe: ConceptTest.getName_shouldReturnExactNameLocaleMatchGivenExactEqualsTrue |
| 14:33:35 | <bwolfe> r_friedman, this query works great for me! delete from tickets where reporter=r.friedman :-D |
| 14:33:53 | <dkayiwa> bwolfe: i feel it should be "Assert.assertNotNull" instead of "Assert.assertNull" |
| 14:34:29 | <bwolfe> dkayiwa, if its passing independently but failing as a group, then there are some other things getting set in static fields or caches that are not getting cleared. e.g if another test sets a GP, that gets cached (and I don't think it gets uncached) |
| 14:34:32 | * bwolfe looks at the test |
| 14:34:38 | <r_friedman> bwolfe: give me delete rights and i'll come up with some good ones too |
| 14:34:52 | <dkayiwa> bwolfe: it does still fail both as a group and independently |
| 14:34:57 | <djazayeri> r_friedman: create a ticket for it. ;-) |
| 14:35:11 | <bwolfe> dkayiwa, boo, that means you didn't test before committing! |
| 14:35:14 | <wyclif> hi MarkG |
| 14:35:27 | <dkayiwa> bwolfe: ;) |
| 14:35:52 | <r_friedman> djazayeri: sure, but ben will delete it |
| 14:36:10 | <dkayiwa> bwolfe: i think i fixed a bug and exposed a buggy unit test :) |
| 14:36:22 | <nribeka> hi all |
| 14:36:29 | <wyclif> hi djazayeri |
| 14:36:33 | <djazayeri> hi wyclif |
| 14:36:35 | <dkayiwa> hi nribeka |
| 14:36:38 | <bwolfe> or maybe the test was testing the exisitng functionality :-p |
| 14:36:46 | <nribeka> when i install a new module, i get this exception. anyone knows about this: http://pastebin.com/4MXYnppx |
| 14:37:09 | <wyclif> in form entry, handleSubmission and validateSubmission, what gets called first? |
| 14:37:15 | <djazayeri> rafa: does MDS work with OpenMRS 1.9, by the way? |
| 14:37:17 | <dkayiwa> bwolfe: testing to ensure the bug remains :) |
| 14:37:26 | <wyclif> djazayeri, hfe |
| 14:37:31 | <djazayeri> wyclif: in html form entry, validate gets called before handle |
| 14:37:45 | <rafa> djazayeri: with some types it does, but not with concepts |
| 14:37:49 | <bwolfe> nribeka, your liquibase tables were updated |
| 14:37:56 | <bwolfe> nribeka, someone tried to run 1.9+ on your database |
| 14:38:12 | <rafa> djazayeri: I mean exporting works fine in most cases even for concepts, but you can't import ;) |
| 14:38:21 | <wyclif> djazayeri, so if am redisplaying the form upon errors, then wont the previous value be rendered? |
| 14:38:23 | <djazayeri> rafa: you can't import them at all, even if they come from 1.9? |
| 14:38:48 | <djazayeri> wyclif: previous values are supposed to be re-populated in the widgets, yes |
| 14:38:58 | <bwolfe> dkayiwa, I agree with you. should be assertNotNull. |
| 14:38:59 | <rafa> djazayeri: right, I would guess it's because of changes to concept mappings |
| 14:39:14 | <dkayiwa> bwolfe: what a relief!!! thanks :) |
| 14:39:14 | <djazayeri> rafa: that's unfortunate |
| 14:39:14 | <rafa> djazayeri: but I haven't investigated it at all |
| 14:39:17 | <djazayeri> (not your fault) |
| 14:39:25 | <wyclif> djazayeri, am running into a bug where the the new value gets set i.e the locationId is correct but the location name is wrong |
| 14:39:30 | <bwolfe> dkayiwa-- for not running unit tests before committing |
| 14:39:37 | <djazayeri> dkayiwa-- |
| 14:39:39 | <dkayiwa> bwolfe: :D |
| 14:39:59 | <dkayiwa> djazayeri: bwolfe was used to running them the maven way. not in 1.6 :) |
| 14:40:10 | <wyclif> djazayeri, since for openmrs objects with custom property editors we actually use the id |
| 14:40:36 | <djazayeri> wyclif: you mean the hidden value is set correctly to the id, but the name is not displayed? |
| 14:41:04 | <djazayeri> wyclif: the values are reset via javascript |
| 14:41:08 | <wyclif> djazayeri, exactly |
| 14:41:24 | <djazayeri> wyclif: look for a method that starts with "getSet" (I think in FormEntrySession) |
| 14:41:35 | <djazayeri> wyclif: if you need to change the generated JS, it would be there. |
| 14:42:00 | <djazayeri> rafa: any idea how much work it would take to make MDS work with 1.9? |
| 14:44:02 | <nribeka> bwolfe, what should i do? |
| 14:44:11 | <rafa> djazayeri: It's hard to tell without looking closely. |
| 14:44:25 | <nribeka> bwolfe, it's just regular module that i'm trying to install to 1.8x |
| 14:44:27 | <bwolfe> nribeka, delete those columns it complains about |
| 14:44:41 | <bwolfe> nribeka, but did you every attempt to load trunk/1.9.x against that db? |
| 14:44:49 | <rafa> djazayeri: My plan is to mavenize soon so that I can at least run tests against 1.9 |
| 14:44:52 | <bwolfe> if so, then liquibase upgrades the tables even if you don't ever fully start openmrs |
| 14:44:53 | <djazayeri> rafa: okay, thanks. |
| 14:45:10 | <bwolfe> maven++ |
| 14:46:25 | <nribeka> ooo ic ic bwolfe |
| 14:47:06 | *** ChanServ sets mode: +v r_friedman |
| 14:47:34 | *** finbrein has joined #openmrs |
| 14:48:31 | *** snoppy has joined #openmrs |
| 14:49:39 | <wyclif> djazayeri, it becomes tricky with fields that use a hidden field and a display field since the display field value is never actually submitted to the server |
| 14:50:31 | <djazayeri> wyclif: do we need an onChange listener on the hidden field, that is capable of querying the server for the display value? |
| 14:51:33 | <djazayeri> downey: TRUNK-2967. If this should be in ITSM, can you pull it there? |
| 14:51:37 | <wyclif> djazayeri, that is a possible solution |
| 14:51:57 | *** lh has joined #openmrs |
| 14:51:57 | *** lh has joined #openmrs |
| 14:52:37 | <djazayeri> wyclif: can you think of a better one? |
| 14:52:54 | <wyclif> djazayeri, not really |
| 14:53:14 | <wyclif> djazayeri, i think the html form controller should typically first bingd values, validate and then process |
| 14:53:26 | <wyclif> djazayeri, though this a major design issue |
| 14:53:52 | <djazayeri> wyclif: and that's not a change that will happen on a minor feature ticket. :-) |
| 14:53:59 | <wyclif> djazayeri, i agree |
| 14:54:23 | <wyclif> i implement your suggestion unless i think of something else |
| 14:57:38 | <wyclif> djazayeri, the only thing i can think of is when validation fails for the field, i still set the new field value but this would require that i do the same for any sumission element that use the location widget |
| 14:58:17 | <downey> !ticket TRUNK-2967 |
| 14:58:18 | <OpenMRSBot> downey: [#TRUNK-2967] Fix Performance tests - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2967 |
| 14:58:28 | *** bryq has quit IRC |
| 14:58:33 | *** suranga has joined #openmrs |
| 14:58:33 | *** ChanServ sets mode: +v suranga |
| 14:59:19 | <downey> djazayeri: TRUNK-2967 is related to the fact that the tests are written using a several-year old version of Selenium that's no longer compatible with Firefox. They'll need to be re-written or at least reworked substantially. I'm pretty sure you probably don't want me attempting that. (At least alone!) :) |
| 14:59:56 | <djazayeri> downey: okay, it's not clear from the ticket comments that the work-to-be-done should be done by you |
| 15:00:22 | <downey> djazayeri: Yeah, I wrote something up to this effect elsewhere (Iist, email, etc.) so I will add it into that ticket |
| 15:00:27 | <djazayeri> downey: thanks |
| 15:00:36 | <djazayeri> wyclif: I think you should follow the spirit of how HFE tries to work |
| 15:01:18 | <MarkG> wyclif: is this trying to fix my last comment on HTML-71? |
| 15:01:18 | *** ChanServ sets mode: +o jmiranda |
| 15:01:19 | <djazayeri> wyclif: i.e. HFE uses javascript to re-set the value; it happens to do this to the hidden field; you should pick up on that with an onChange, if you can |
| 15:01:30 | *** dkayiwa has quit IRC |
| 15:01:43 | <wyclif> djazayeri, ok |
| 15:01:55 | <djazayeri> wyclif: but see what MarkG says |
| 15:02:05 | <wyclif> djazayeri, ok |
| 15:02:13 | <bwolfe> downey, why can't we just use an old version of selenium on our server? :-) |
| 15:02:38 | <MarkG> wyclif: what are we trying to go? |
| 15:02:39 | <downey> bwolfe: we could, as long as we don't need to use a browser for the tests :) |
| 15:02:53 | <bwolfe> downey + older browser |
| 15:03:01 | <downey> lynx++ |
| 15:03:09 | <MarkG> wyclif: or, i meant, what are we tring to do? :) |
| 15:03:28 | <bwolfe> too new downey |
| 15:03:30 | <bwolfe> mosaic++ |
| 15:03:43 | <downey> bwolfe: telnet + HTTP |
| 15:03:46 | <wyclif> MarkG, the issue where the previous value is not displayed |
| 15:03:57 | <MarkG> right... |
| 15:04:29 | <wyclif> MarkG, what is happening is that actually the value is set on the hidden form field but not the display field of the autocomplete |
| 15:04:50 | <MarkG> wyclif: what use case it this? |
| 15:05:27 | <wyclif> am responding to your last comment on the ticket |
| 15:05:33 | <wyclif> MarkG, HTML-71 |
| 15:06:08 | <wyclif> MarkG, if i change the location or blank it out, upon validation errors, the old value is what gets displayed in the display input |
| 15:07:11 | <MarkG> wyclif: right... so are you trying to implement a) when the form redisplays, the location field stays blank, or b) when the form redisplays, since the display field is repopulated, the hidden field should also be repopulated? |
| 15:07:41 | <MarkG> wyclif: right now the previous value is displayed, it just appears that the hidden value is not set (so form validation fails on save) |
| 15:07:53 | <wyclif> MarkG, yeah, but in reality the hidden form field gets blanked out it is the display field that isn't |
| 15:08:40 | <wyclif> MarkG, a similar problem happend when you edit the field to a new value, upon validation errors, the correct location id is set on the hidden input but not the correct name on the form field |
| 15:08:47 | <wyclif> sorry on the display field |
| 15:09:09 | <wyclif> MarkG, the opposite is true |
| 15:09:36 | <MarkG> wyclif: got it.. i will have to look at the code... what is your propsed solution? |
| 15:09:55 | <wyclif> the hidden field changes to what the user entered on the last submission but the location widget doesn't know about the knew widget |
| 15:10:02 | <wyclif> new |
| 15:10:15 | <wyclif> MarkG, the hidden field changes to what the user entered on the last submission but the location widget doesn't know about the new value |
| 15:10:47 | <wyclif> MarkG, and this is because validation is done before binding values and there is no way to solve this from the widget |
| 15:11:24 | <wyclif> MarkG, so since the new value is set via javascript, we have to do the same for the display input |
| 15:12:15 | <MarkG> wyclif: give me a few minutes... i will take a look at the js code... |
| 15:16:09 | *** bryq has joined #openmrs |
| 15:16:09 | *** ChanServ sets mode: +v bryq |
| 15:25:57 | <MarkG> wyclif: did you take a look at how the existing autocomplete widget for obs works? |
| 15:26:13 | <MarkG> wyclif: some javascript is defined that resets the display values |
| 15:26:31 | <MarkG> see FormEntrySession: 695-714 |
| 15:26:37 | <wyclif> MarkG, that is what am tryin gto do |
| 15:27:48 | <MarkG> the obs autocomplete uses a combination of a hidden field and a display field... i don't remember exactly how it works, but it appears to work... can you not mimic what is happening there? |
| 15:28:33 | <MarkG> what you are saying is that the widget value doesn't get bound because validation fails? |
| 15:29:13 | <wyclif> MarkG, am adding logic in that loop to check if it a location widget, and i add javascript to set the display name for the location with the matching id |
| 15:29:35 | <MarkG> looking at how the obs autocomplete works, the hidden widget has an id of "w8_hid" and the display field has a id of "w8" |
| 15:30:42 | <MarkG> wyclif: i don't think you want to explicitly look for a location widget in that loop... |
| 15:32:20 | <suranga> djazayeri, hi.. mm.. regarding https://tickets.openmrs.org/browse/RESTWS-220 |
| 15:33:55 | <suranga> based on your very last comment about making valueCodedName its ownproperty... doesnt that mean that jers patch is what you need ? sorry to raise this matter again, but the comment has rather muddled me up :-) |
| 15:35:04 | <djazayeri> suranga: let me look at the patch |
| 15:35:36 | <suranga> djazayeri, sure. let me know what improvements it needs :-) |
| 15:35:52 | <MarkG> wyclif: I *think* you want to change it so that display widget is called "w8", and then it will redisplay properly... the hidden field should be called "w8_hid", and then the getValue method of the LocationWidget should to a request.getParameter(context.getFieldName(this)) if the widget *is not* type = autocomplete, but request.getParameter(context.getFieldName(this) + "_hid") if the widget *is* type=autocomplete |
| 15:36:08 | <MarkG> wyclif: or, at least, i think, from looking at quickly... :) does that make sense |
| 15:36:17 | <djazayeri> suranga: |
| 15:36:45 | <MarkG> wyclif: look at the getValue mehtods in AutoCompleteWidget and LocationWidget |
| 15:37:16 | <djazayeri> suranga: in jeremy's patch, he treats valueCodedName as if it were a regular valueXyz field |
| 15:37:18 | <djazayeri> right? |
| 15:37:29 | *** jriley has quit IRC |
| 15:37:38 | <suranga> djazayeri, correct.. |
| 15:38:03 | <wyclif> MarkG, i looked at those already and they dont seem to help |
| 15:38:10 | <djazayeri> suranga: I'm saying it should _not_ behave like the other valueXyz fields. It should behave like any other regular field, like obsDatetime |
| 15:38:20 | <MarkG> wyclif: why not? |
| 15:38:50 | <djazayeri> suranga: though, ideally valueCodedName would only be displayed if the value is coded |
| 15:39:22 | <wyclif> MarkG, by the time the generateHtml method is called, the new value is unknown to the widget since binding hasn't yet occurred |
| 15:39:48 | <wyclif> MarkG, and i can't call getValue since i have no httpRequest object inside the widget |
| 15:39:59 | <suranga> djazayeri, by sayinf that 'it should behave like any other regular field, do u mean that u want me to run it into the ConversionUtil.convert ? |
| 15:40:26 | <wyclif> the fix can be dne from FormEntrySession.getSetLastSubmissionFieldsJavascript |
| 15:40:31 | <wyclif> MarkG, the fix can be dne from FormEntrySession.getSetLastSubmissionFieldsJavascript |
| 15:41:01 | <wyclif> MarkG, since even the values of the other field is all done from there via js |
| 15:41:22 | <djazayeri> suranga: look at everywhere that obsDatetime occurs in ObsResource |
| 15:41:31 | <wyclif> MarkG, heading for lunch, will attach a patch of my solution when i getback |
| 15:41:36 | <djazayeri> suranga: obsDatetime is a "normal" property |
| 15:41:37 | <MarkG> okay... |
| 15:42:25 | <djazayeri> suranga: so just do something similar, like: description.addProperty("valueCodedDatetime"); |
| 15:42:42 | <djazayeri> suranga: (it should be a REF in the default represetnation, and a DEFAULT in the full representation) |
| 15:43:42 | <suranga> djazayeri, ah, I thought u wanted me to convert it into something...hmmm... I think I get it now ! :) |
| 15:44:51 | <r_friedman> wyclif: did you send out an e-mail with the etherpad for drug orders? |
| 15:45:21 | <djazayeri> r_friedman: I didn't get the email |
| 15:45:33 | *** kishoreyekkanti has quit IRC |
| 15:48:06 | *** nadee has joined #openmrs |
| 15:51:35 | <djazayeri> wyclif: send the email! |
| 15:51:57 | <djazayeri> wyclif: it helps us to go into a design discussion having read the materials beforehand... |
| 15:52:10 | <djazayeri> r_friedman: I bet it's just the etherpad for today's design call, but I haven't looked yet |
| 15:53:04 | *** rafa has quit IRC |
| 15:55:22 | *** rubailly has joined #openmrs |
| 15:55:35 | <downey> Hi rubailly and welcome to the #openmrs IRC channel. |
| 15:55:51 | <rubailly> Hi d |
| 15:55:52 | <rubailly> thanks |
| 15:56:47 | <r_friedman> djazayeri: today's etherpad points to this: http://notes.openmrs.org/orders-service and https://wiki.openmrs.org/display/RES/Order+Entry+Sprint+1+Use+Cases |
| 16:02:50 | <rubailly> Hi Mark |
| 16:02:58 | <rubailly> do you have a second/ |
| 16:03:15 | <rubailly> I have a small question about the relationship tag |
| 16:03:28 | <MarkG> rubailly: sure |
| 16:03:47 | <rubailly> I'd like to know if javascript id tag is enabled for the relationship tag |
| 16:03:56 | <rubailly> I wanted to access the tag with javascript like the way we can do this with |
| 16:04:07 | <rubailly> the obs tag but it seems with the relationship tag, this is not possible |
| 16:05:46 | <MarkG> rubailly: yes, it is not enabled for the relationship tag... do you want to add this functionality? :) |
| 16:07:10 | <rubailly> I would be happy to have this as I'm currently trying to access the value to check if it has been set or not and the issue some kind of warning |
| 16:09:41 | <rubailly> can we have a ticket about this |
| 16:10:09 | <MarkG> rubailly: yes, can you add a ticket about adding this functionality? |
| 16:10:28 | <rubailly> yes |
| 16:10:31 | <rubailly> thanks |
| 16:13:05 | *** goutham has joined #openmrs |
| 16:14:03 | *** goutham has joined #openmrs |
| 16:15:46 | <MarkG> rubailly: if you want to work on this yourself, you should looked: |
| 16:15:55 | <MarkG> !ticket HTML-205 |
| 16:15:58 | <OpenMRSBot> MarkG: [#HTML-205] Enable javascript id tag on encounter date - OpenMRS JIRA - https://tickets.openmrs.org/browse/HTML-205 |
| 16:17:11 | <MarkG> rubailly: this is the ticket for adding this functionality to encounter... I added this a few months ago, so you could follow the same pattern to add it to the Relationship tag... |
| 16:17:44 | <MarkG> rubailly: if you click on the "github" tag for the tickets, it links to all the commits I made so you can see what i did to implement it |
| 16:17:56 | *** r_friedman has quit IRC |
| 16:18:19 | *** mvorobey has quit IRC |
| 16:19:11 | *** Guest95545 has quit IRC |
| 16:19:36 | *** nadee has quit IRC |
| 16:20:54 | *** Rahul has joined #openmrs |
| 16:28:01 | <wyclif> djazayeri, i have sent the email, sorry for the delay, made a mistake to go for lunch before sending it out |
| 16:28:15 | <djazayeri> thanks wyclif |
| 16:31:46 | *** kavuri has joined #openmrs |
| 16:40:21 | *** goutham has joined #openmrs |
| 16:46:24 | *** goutham has quit IRC |
| 16:52:47 | *** Rahul has quit IRC |
| 16:58:37 | <didymo> djazayeri ping |
| 16:58:46 | <djazayeri> didymo: hi |
| 16:58:54 | <didymo> God Morning |
| 16:58:57 | <djazayeri> (yes, I know, the traditional response should be "pong") |
| 16:59:22 | <didymo> my appologies for missing the OpenMRS Uni time slot, I would have been awake for 21 hours at that point I amanaged to fall aslepp |
| 17:00:25 | <didymo> mind if I email you directly? The local University woud like to use OpenMRS in a final year subject and wuo d like to work with the OpenMRS comunity to have the students work on something to contribute back |
| 17:01:04 | *** kishoreyekkanti has joined #openmrs |
| 17:01:11 | <didymo> mind if I email you, when I am more awake, what our aims and objects are and ask for sm guidence as to how you see the stuends being of assitance to teh project? |
| 17:01:16 | *** kishoreyekkanti has left #openmrs |
| 17:01:36 | <rubailly> thanks Mark... |
| 17:02:05 | <rubailly> I'm going to start working on that |
| 17:02:07 | <djazayeri> didymo: sure, email me when you're more awake |
| 17:02:13 | <didymo> thanks. |
| 17:02:34 | <didymo> back to bed for me 3 am here Good NIhgt Peoples |
| 17:02:41 | <didymo> ttfn |
| 17:03:13 | *** harshadura has quit IRC |
| 17:06:51 | *** goutham has joined #openmrs |
| 17:07:38 | *** MarkG1 has joined #openmrs |
| 17:08:54 | *** goutham has quit IRC |
| 17:10:55 | *** MarkG has quit IRC |
| 17:15:20 | *** r5friedman has joined #openmrs |
| 17:15:33 | *** r5friedman is now known as r_friedman |
| 17:16:02 | <r_friedman> rubailly: you can even have a ticket about somebody writing a ticket if you want :) |
| 17:18:55 | <suranga> hmm.. djazayeri its like this, I can do as you said and add valuecodedName to the representaton.. but the problem is that valuecodedname is optional, and spring cant work in the event of an Obs without that value specified... |
| 17:19:10 | <suranga> i tried setting a flag, but since getValue() is static... |
| 17:23:12 | *** sgithens_ has joined #openmrs |
| 17:25:11 | *** pulasthi7 has joined #openmrs |
| 17:25:56 | <sgithens_> Do 'date' concept types allow adding any validation rules in the concept dictionary like numeric ones do? |
| 17:26:06 | <djazayeri> sgithens: no |
| 17:26:12 | <djazayeri> sgithens_: no |
| 17:26:16 | <sgithens_> thanks! |
| 17:26:52 | <djazayeri> suranga: you should literally have to add 2 lines to add valueCodedName to the two reps |
| 17:27:19 | <bwolfe> djazayeri, have to go to a mandatory hipaa training now. I'll be on the design call late. :-( |
| 17:27:36 | <suranga> djazayeri, aha, yes, but then it looks for those values in every single Obs |
| 17:27:50 | <suranga> and not just ones which may are valueCoded() |
| 17:30:34 | *** mccallumg has joined #openmrs |
| 17:30:34 | *** ChanServ sets mode: +v mccallumg |
| 17:32:17 | <djazayeri> suranga: look at convertToRef in MetadataDelegatingCrudResource, what it does with "retired" |
| 17:34:55 | <suranga> thanks djazayeri , will do :) |
| 17:39:18 | <rubailly> @r_friedman.. sure. |
| 17:39:34 | <rubailly> thanks :) |
| 17:40:10 | <rubailly> I've created one here: https://tickets.openmrs.org/browse/HTML-337 |
| 17:44:48 | <mccallumg> Hey suranga |
| 17:45:03 | <suranga> mccallumg, howdy !!! |
| 17:45:22 | <suranga> mccallumg, hows it going ? |
| 17:45:44 | <mccallumg> I saw your email to the list ⦠"We at Jembi Health". I like that. |
| 17:46:00 | <suranga> i'm having a great time .. they are actually paying me to work with OpenMRS :-) |
| 17:47:30 | <mccallumg> I know. Nice! Things are well here. I have much work to do - reviewing a draft standard for physician EMR data portability. |
| 17:54:49 | <suranga> mccallumg, too bad we wont get to work on the same project this year :-( |
| 17:55:30 | <mccallumg> Yes. yes. You finish school then maybe we can work together on another project at some point. |
| 18:02:55 | *** dkayiwa has joined #openmrs |
| 18:04:55 | *** wyclif has quit IRC |
| 18:12:13 | *** mseaton has left #openmrs |
| 18:13:09 | *** sgithens_ has quit IRC |
| 18:24:18 | *** wyclif has joined #openmrs |
| 18:29:41 | *** robbyoconnor has quit IRC |
| 18:32:50 | *** dkayiwa has quit IRC |
| 18:33:15 | *** dkayiwa has joined #openmrs |
| 18:35:09 | *** kavuri has quit IRC |
| 18:40:36 | *** snoppy has left #openmrs |
| 18:43:11 | *** bwolfe has quit IRC |
| 18:45:16 | *** pulasthi7 has quit IRC |
| 18:49:00 | *** goutham has joined #openmrs |
| 18:49:11 | *** rubailly has quit IRC |
| 18:51:26 | *** goutham has quit IRC |
| 19:15:46 | *** bwolfe has joined #openmrs |
| 19:15:46 | *** ChanServ sets mode: +o bwolfe |
| 19:31:34 | *** jmiranda has quit IRC |
| 19:32:03 | *** goutham has joined #openmrs |
| 19:33:48 | *** goutham has quit IRC |
| 19:33:53 | *** MarkG1 has quit IRC |
| 19:34:18 | *** MarkG has joined #openmrs |
| 19:38:48 | *** MarkG has quit IRC |
| 19:39:27 | *** suranga has quit IRC |
| 19:40:11 | *** suranga has joined #openmrs |
| 19:41:53 | *** suranga has quit IRC |
| 19:43:13 | *** bwolfe has quit IRC |
| 19:59:00 | *** james_regen has quit IRC |
| 20:05:01 | *** wyclif has quit IRC |
| 20:19:52 | *** wyclif has joined #openmrs |
| 20:38:54 | *** robbyoconnor has joined #openmrs |
| 20:38:54 | *** ChanServ sets mode: +v robbyoconnor |
| 20:54:44 | *** sgithens_ has joined #openmrs |
| 20:58:07 | *** nribeka has quit IRC |
| 21:03:56 | *** r_friedman has quit IRC |
| 21:05:34 | *** wyclif has quit IRC |
| 21:10:18 | *** sgithens_ has quit IRC |
| 21:19:44 | *** Amazed has joined #openmrs |
| 21:19:57 | <Amazed> hello all |
| 21:19:59 | <downey> Hi Amazed and welcome to the #openmrs IRC channel. |
| 21:20:33 | <Amazed> so whats up? |
| 21:23:42 | <robbyoconnor> Hey all |
| 21:24:58 | <Amazed> hello robbyoconnor |
| 21:27:56 | *** dkayiwa has quit IRC |
| 21:45:40 | * downey looks up |
| 21:47:56 | *** Amazed has quit IRC |
| 22:01:55 | *** bryq has quit IRC |
| 22:05:03 | *** downey has quit IRC |
| 22:38:26 | *** wyclif has joined #openmrs |
| 22:50:56 | *** carloshpf has joined #openmrs |
| 22:52:11 | *** mccallumg has quit IRC |
| 23:40:37 | *** lh has quit IRC |
| 23:53:53 | *** mseaton has joined #openmrs |
| 23:53:53 | *** ChanServ sets mode: +v mseaton |