IRC Chat : 2012-04-16 - OpenMRS

00:02:32 *** r_friedman is now known as r_friedman_away
00:36:23 *** mathiaslin has joined #openmrs
01:47:29 *** r_friedman_away is now known as r_friedman
02:20:23 <robbyoconnor> Hey all!
02:20:37 <robbyoconnor> hey r_friedman! Happy Day before Monday!
02:42:45 <r_friedman> robbyoconnor: and a happy webservices.rest sprint to you too,
02:43:14 *** r_friedman has quit IRC
02:45:32 <robbyoconnor> I'm not participating
03:28:51 *** upul` has joined #openmrs
03:28:51 *** ChanServ sets mode: +v upul`
04:16:21 *** nadee has joined #openmrs
04:18:02 <nadee> djazayeri: hi darius, you have a moment?
04:21:37 <nadee> hi devs, can some one please tell me if we can include demo data for 1.8.x ? or is it something new on trunk?
04:23:49 *** inane has joined #openmrs
04:23:56 * inane waves cautiously
04:24:33 <nadee> or can we use a database created with the setup wizard for trunk (im seeing 101 tables here, that contains demo data) , to be used as the database for a new setup of openmrs 1.8.x (usually this setup brings a database with 95 tables)
04:31:17 *** basanta_ has joined #openmrs
04:37:17 <djazayeri> nadee: still there?
04:37:31 <nadee> hi, yeah
04:38:15 <djazayeri> unfortunately the "demo data" included with the war file really only includes demo concepts, but only 2 patients
04:38:19 <djazayeri> who don't really have any data
04:40:13 <nadee> i see, so things have to be done manually.. but at least it had concepts etc afair
04:40:26 <djazayeri> nadee: you could also look at https://wiki.openmrs.org/x/GwRN
04:41:27 <djazayeri> You should be able to start from Demo-1.8.0.sql.zip, and the webapp will upgrade it for you when it starts up
04:41:57 <djazayeri> nadee: you don't strictly need this, but obviously building reports will seem more realistic with 5000 patients instead of 2.
04:42:27 <nadee> yeah.. thats y i was looking for this
04:43:06 <djazayeri> gotta run now, though I'll peek here in another 20 minutes or so to see if there's anything I can answer quickly before going to bed.
04:43:23 <nadee> thanks darius!
04:48:39 <inane> is there a scheduler/appointment follow-up module?
04:53:46 *** nadee has quit IRC
04:55:44 *** nadee has joined #openmrs
04:55:50 <inane> bw
05:03:49 *** rohitgoyal18 has joined #openmrs
05:14:43 *** basanta_ has quit IRC
05:24:49 *** rohitgoyal18 has quit IRC
05:32:56 <inane> how would one create a program?
05:38:37 *** faisalinux has joined #openmrs
05:38:54 <faisalinux> hi
05:39:14 <faisalinux> need a help as currently I am working on OpenMRS 1.5.4
05:39:21 <faisalinux> for using diabetics modul
05:39:33 <faisalinux> @bwolfe
05:39:56 <faisalinux> so can someone please help me as I am facing so many issues right now
05:41:41 *** nadee has quit IRC
05:44:30 *** faisalinux_ has joined #openmrs
05:47:28 *** faisalinux_ has quit IRC
06:03:55 *** faisalinux has quit IRC
06:09:23 *** pulasthi7 has joined #openmrs
06:17:50 *** mathiaslin has quit IRC
06:23:45 *** mathiaslin has joined #openmrs
07:09:27 *** dkayiwa has joined #openmrs
07:33:35 *** bryq has joined #openmrs
07:33:35 *** ChanServ sets mode: +v bryq
07:35:51 *** sgithens_ has joined #openmrs
07:36:08 *** dkayiwa has quit IRC
07:38:08 *** rahul_ has joined #openmrs
08:21:51 *** snoppy has joined #openmrs
08:23:50 *** sk has joined #openmrs
08:25:37 <inane> wb
08:35:53 *** bryq has quit IRC
08:43:00 *** bryq has joined #openmrs
08:43:05 *** ChanServ sets mode: +v bryq
08:48:48 *** bryq has quit IRC
08:49:20 <inane> how does one create an encounter?
09:07:09 *** suranga has joined #openmrs
09:07:09 *** ChanServ sets mode: +v suranga
09:10:55 <inane> hey suranga
09:11:13 <inane> how does one create an encounter against a person?
09:12:44 <rahul_> inane: u will an add encounter link in this page ../openmrs/admin/encounters/index.htm
09:22:53 <inane> rahul: got it (+: thank you. suranga and i were just atlking about it in PM too
09:25:48 <rahul_> inane: :)
09:27:07 *** harshadura has joined #openmrs
09:30:30 *** mathiaslin has quit IRC
09:31:02 *** mathiaslin has joined #openmrs
09:32:03 <inane> so i created a location, and tried to attach an encounter at that location. now an exception appeared.
09:35:28 *** mathiaslin has quit IRC
09:37:57 *** suranga has quit IRC
09:42:49 *** inane has quit IRC
09:54:21 *** r0bby has joined #openmrs
09:54:21 *** ChanServ sets mode: +v r0bby
09:57:25 *** robbyoconnor has quit IRC
10:30:40 *** dkayiwa has joined #openmrs
10:55:27 *** james_regen has joined #openmrs
10:55:27 *** ChanServ sets mode: +v james_regen
11:20:01 *** rahul_ has quit IRC
11:23:38 *** james_regen has quit IRC
11:25:17 *** upul` has quit IRC
11:33:53 *** james_regen has joined #openmrs
11:33:53 *** ChanServ sets mode: +v james_regen
12:27:39 *** rafa has joined #openmrs
12:27:39 *** ChanServ sets mode: +v rafa
12:27:58 <rafa> hi dkayiwa :)
12:28:08 <dkayiwa> rafa: :)
12:28:34 <dkayiwa> rafa: did you say that you succeeded with the release testing helper module on your big pentaho dataset?
12:28:48 <rafa> dkayiwa: yes
12:29:27 <rafa> dkayiwa: the db dump was around 370 MB
12:29:29 <dkayiwa> rafa: let me first ask these guys which version of the RTH module they are using
12:29:48 *** pusakat has joined #openmrs
12:30:16 <rafa> dkayiwa: are you answering to the process terminated abnormaly... in the dev list?
12:30:23 <dkayiwa> rafa: yes
12:30:39 <rafa> dkayiwa: ask if they're using standalone or war
12:30:56 <rafa> dkayiwa: seems like they've got locked liquibasechangelog
12:31:13 <dkayiwa> rafa: that is after the test data import failed
12:31:40 <dkayiwa> rafa: that is after the: The process terminated abnormally while adding test data
12:31:53 <rafa> dkayiwa: ohh I missed that line
12:31:56 <rafa> dkayiwa: ok
12:32:38 <dkayiwa> rafa: on mine, i completely failed to succeed. kept getting the mysql has gone away error message while trying to import test data
12:32:50 <rafa> dkayiwa: I wonder if there's a way to get a better error messages from mysqldump
12:32:58 <rafa> dkayiwa: are you using standalone?
12:33:01 <dkayiwa> rafa: that would be very very useful
12:33:05 <dkayiwa> rafa: yes standalone
12:33:20 <rafa> dkayiwa: hmmm I used it too
12:34:04 <dkayiwa> rafa: and how did you solve it? were you just lucky? :)
12:34:21 <rafa> dkayiwa: I did it twice and it worked
12:34:46 <dkayiwa> rafa: ok
12:35:05 <rafa> dkayiwa: our standalone may have a low wait_timeout
12:35:16 <rafa> dkayiwa: can you increase it and try again?
12:35:20 <dkayiwa> rafa: ok
12:35:30 <dkayiwa> rafa: increase it like to what value?
12:35:59 <dkayiwa> rafa: by the way, that param is not in our standalone by default :)
12:36:13 *** pusakat has quit IRC
12:37:56 <rafa> dkayiwa: ohh then default should be 28800 secs and that is more than enough :/
12:38:03 <dkayiwa> rafa: ok
12:38:18 <rafa> dkayiwa: when does that gone away happen?
12:38:26 <rafa> dkayiwa: after a while or at the beginning?
12:38:32 <dkayiwa> rafa: by the way, the dump file is a temp file which gets deleted immediately, so how did you see it?
12:38:45 <rafa> dkayiwa: I copied it over :)
12:38:46 <dkayiwa> rafa: let me run it again now and see when
12:38:53 <dkayiwa> rafa: before it got deleted?
12:39:10 <rafa> dkayiwa: yes, the import takes a while and it was enough time to copy it ;)
12:39:19 <dkayiwa> rafa: ok :)
12:41:16 <rafa> dkayiwa: have you already read http://dev.mysql.com/doc/refman/5.0/en/gone-away.html?
12:41:20 <OpenMRSBot> <http://ln-s.net/$1N5> (at dev.mysql.com)
12:41:25 <dkayiwa> rafa: No
12:42:03 <rafa> dkayiwa: then see if anything applies to your configuration
12:42:12 <dkayiwa> rafa: ok thanks
12:55:22 <dkayiwa> rafa: just got the same exact error message as Manu :)
12:55:38 <dkayiwa> rafa: including the liquibase error in the log
12:56:33 <dkayiwa> rafa: what do you recommend that i should do as the next step?
12:56:45 <dkayiwa> rafa: this time i did not get the mysql has gone away error
12:56:54 <rafa> dkayiwa: did you change something?
12:57:13 <dkayiwa> rafa: did the default standalone
12:57:24 <dkayiwa> rafa: without changing anything
12:58:20 <dkayiwa> rafa: and am using the big pentaho dataset
12:58:25 <rafa> dkayiwa: I'd copy the dump file and try to import it manually
12:59:13 <rafa> dkayiwa: Maybe, it'll give you a better error message
12:59:24 <dkayiwa> rafa: let me try that. i copied it when it was 271.9 MB let me hope that was all :)
12:59:27 *** sgithens_ has quit IRC
12:59:55 <rafa> dkayiwa: you just need to peek at the end of the file
13:00:08 <rafa> dkayiwa: it should end with comments enabling forgeign keys checks, etc..
13:00:14 <dkayiwa> rafa: ok
13:00:18 <rafa> dkayiwa: if you have that then it's all
13:05:43 *** downey has joined #openmrs
13:05:43 *** ChanServ sets mode: +o downey
13:05:43 *** OpenMRSBot sets mode: +o downey
13:24:53 *** nadee has joined #openmrs
13:27:21 <dkayiwa> hi rafa
13:27:27 <rafa> hi
13:27:31 *** nribeka has joined #openmrs
13:27:31 *** ChanServ sets mode: +v nribeka
13:27:33 <dkayiwa> rafa: am getting this:
13:27:35 <dkayiwa> ERROR 1231 (42000): Variable 'time_zone' can't be set to the value of 'NULL'
13:27:36 <dkayiwa> ERROR 1231 (42000): Variable 'sql_mode' can't be set to the value of 'NULL'
13:27:36 <dkayiwa> ERROR 1231 (42000): Variable 'foreign_key_checks' can't be set to the value of 'NULL'
13:27:36 <dkayiwa> ERROR 1231 (42000): Variable 'unique_checks' can't be set to the value of 'NULL'
13:27:37 <dkayiwa> ERROR 1231 (42000): Variable 'character_set_client' can't be set to the value of 'NULL'
13:27:37 <dkayiwa> Query OK, 0 rows affected (0.00 sec)
13:27:37 <dkayiwa> ERROR 1231 (42000): Variable 'collation_connection' can't be set to the value of 'NULL'
13:27:37 <dkayiwa> ERROR 1231 (42000): Variable 'sql_notes' can't be set to the value of 'NULL'
13:29:00 <rafa> dkayiwa: was it just after you started or later?
13:29:07 <dkayiwa> rafa: later
13:29:18 <dkayiwa> rafa: i think those are the last lines in the sql dump tile
13:29:21 <dkayiwa> file
13:29:27 <rafa> dkayiwa: yes
13:29:35 <rafa> dkayiwa: I wonder why they're NULLs
13:29:44 <rafa> dkayiwa: they should have had old values
13:29:59 <rafa> dkayiwa: how did you run the dump?
13:30:16 *** MarkG has joined #openmrs
13:30:41 <rafa> dkayiwa: what command?
13:30:49 <dkayiwa> rafa: source
13:31:17 <rafa> dkayiwa: did you use root account?
13:31:47 <dkayiwa> rafa: the one used by the standalone
13:32:06 <dkayiwa> rafa: which is uname=openmrs, pw=test
13:36:16 *** sgithens_ has joined #openmrs
13:36:27 <rafa> dkayiwa: can you check if the tables were actually imported?
13:36:40 <dkayiwa> rafa: ok
13:36:59 *** harshadura has quit IRC
13:37:45 *** downey sets mode: +v MarkG
13:37:51 *** downey sets mode: +v sgithens
13:37:55 *** downey sets mode: +v sgithens_
13:37:58 *** downey sets mode: +v dkayiwa
13:38:25 *** jriley has joined #openmrs
13:43:31 <dkayiwa> rafa: the tables were all created
13:43:40 <dkayiwa> rafa: some have data and others do not
13:43:59 <dkayiwa> rafa: like the users table is empty
13:44:25 <rafa> dkayiwa: so it failed before getting to the last lines of the dump
13:44:44 <dkayiwa> rafa: there a number of error messages in between
13:44:45 <rafa> dkayiwa: the problem is what makes it fail
13:45:09 <rafa> dkayiwa: like?
13:45:31 <dkayiwa> rafa: first error is: ERROR 1452 (23000): Cannot add or update a child row: a foreign key constraint fails (`openmrs`.`encounter`, CONSTRAINT `encounter_location` FOREIGN KEY (`location_id`) REFERENCES `location` (`location_id`))
13:46:13 <rafa> dkayiwa: it shouldn't have happened. foreign keys were supposed to be disabled :/
13:46:29 <rafa> dkayiwa: can you paste how does the beginning of the dump look like?
13:46:40 <dkayiwa> rafa: let me do it again. just scrolled through the long log and see the mysql gone away error :)
13:46:57 <dkayiwa> Query OK, 0 rows affected (0.01 sec)
13:46:57 <dkayiwa> Query OK, 0 rows affected (0.00 sec)
13:46:58 <dkayiwa> ERROR 2006 (HY000): MySQL server has gone away
13:46:58 <dkayiwa> No connection. Trying to reconnect...
13:46:59 <dkayiwa> Connection id: 37
13:46:59 <dkayiwa> Current database: openmrs
13:47:00 <dkayiwa> ERROR 2006 (HY000): MySQL server has gone away
13:47:00 <dkayiwa> No connection. Trying to reconnect...
13:47:00 <dkayiwa> Connection id: 38
13:47:01 <dkayiwa> Current database: openmrs
13:47:01 <dkayiwa> ERROR 2006 (HY000): MySQL server has gone away
13:47:01 <dkayiwa> ERROR 2006 (HY000): MySQL server has gone away
13:47:02 <dkayiwa> No connection. Trying to reconnect...
13:47:02 <dkayiwa> Connection id: 39
13:47:03 <dkayiwa> Current database: openmrs
13:47:03 <dkayiwa> Query OK, 0 rows affected, 1 warning (0.10 sec)
13:47:03 <dkayiwa> Query OK, 0 rows affected (0.00 sec)
13:47:08 <rafa> dkayiwa: ohhh that is the reason why you see foreign key constraint errors
13:47:16 <dkayiwa> rafa: makes sense
13:47:35 <rafa> dkayiwa: mysql client reconnected
13:47:42 <dkayiwa> rafa: yes
13:47:48 <rafa> dkayiwa: and lost info about disabled foreign key constraints
13:48:02 <dkayiwa> rafa: so do you suggest i try it again with a long wait_timeout?
13:48:10 <rafa> dkayiwa: we need to figure out why do you get this has gone away
13:48:20 <dkayiwa> rafa: correct
13:48:25 <rafa> dkayiwa: yes, maybe it's overwritten in some place to some smaller value
13:48:42 <rafa> dkayiwa: can you also find in the log the first time it says has gone away?
13:48:46 *** downey sets mode: +v jriley
13:48:48 <rafa> dkayiwa: and what is right before that
13:49:07 <dkayiwa> rafa: i pasted it here
13:49:24 <dkayiwa> Query OK, 0 rows affected (0.00 sec)
13:49:25 <dkayiwa> ERROR 2006 (HY000): MySQL server has gone away
13:49:51 <rafa> dkayiwa: yeah, but what was the OK query :)
13:50:28 <dkayiwa> rafa: how do i find out which query it is? :)
13:50:55 <rafa> dkayiwa: I don't know. I hoped it was written a few lines above ;)
13:51:13 <dkayiwa> rafa: the clint log does not include it
13:51:16 <dkayiwa> client
13:52:31 <rafa> dkayiwa: it most likely fills tables in the alphabetical order, if you can identify the first table that has no data...
13:53:27 <dkayiwa> rafa: ok. should i start by looking for that or with adjusting the wait_timeout?
13:54:09 <rafa> try with the timeout and max allowed packet
13:54:38 <dkayiwa> rafa: i have &server.max_allowed_packet=32M
13:54:44 <dkayiwa> rafa: should i increase it?
13:54:45 <rafa> max allowed packet must be set for both server and client
13:54:55 <rafa> why not double it
13:55:02 <dkayiwa> rafa: ok
13:55:23 <dkayiwa> rafa: and for wait_timeout, what value?
13:55:49 <dkayiwa> rafa: by the way, the server (with test data) successfully dumped the file
13:55:57 <rafa> it's in secs so anything like 36000
13:56:08 <dkayiwa> rafa: ok
13:56:19 *** pulasthi7 has quit IRC
13:56:27 <rafa> dkayiwa: by the client I mean mysql and server mysqld on the import side
13:56:55 *** dmexs_ has joined #openmrs
13:57:12 <rafa> dkayiwa: you need to start client with mysql --max_allowed_packet=64M
13:57:19 <dkayiwa> rafa: ok
13:57:46 *** dmexs_ has quit IRC
14:07:09 *** bwolfe has quit IRC
14:08:08 *** pulasthi7 has joined #openmrs
14:15:41 *** Karesh has joined #openmrs
14:17:39 <dkayiwa> rafa: thanks. query successful and commandline :D
14:17:53 <dkayiwa> rafa: not sure which of the two i needed
14:18:11 <dkayiwa> rafa: but i suspect maxallowed packet size
14:18:22 <rafa> dkayiwa: okay, we need to set them in the standalone
14:18:51 <dkayiwa> rafa: let me rerun with one of the two to get which was the cause
14:20:01 *** Karesh has quit IRC
14:21:09 *** nribeka has quit IRC
14:24:53 *** gauravpaliwal has joined #openmrs
14:24:53 *** ChanServ sets mode: +v gauravpaliwal
14:28:51 *** bwolfe has joined #openmrs
14:28:51 *** ChanServ sets mode: +o bwolfe
14:29:31 *** isharapremadasa has joined #openmrs
14:30:25 *** isharapremadasa is now known as isharap
14:32:31 *** snoppy has quit IRC
14:33:54 *** r9friedman has joined #openmrs
14:33:58 *** r9friedman is now known as r_friedman
14:38:25 *** nribeka has joined #openmrs
14:38:25 *** ChanServ sets mode: +v nribeka
14:40:21 *** dawn_ has joined #openmrs
14:40:27 <r_friedman> rafa: hi rafa
14:40:28 *** ChanServ sets mode: +v dawn_
14:43:11 <dkayiwa> hi r_friedman
14:43:20 <r_friedman> dkayiwa: hi daniel
14:43:30 <dkayiwa> r_friedman: concerning RESTWS-180
14:44:24 <dkayiwa> r_friedman: what do you mean by: This does not work when there are no entries in the resource's table
14:44:24 <dkayiwa> r_friedman: on the comment for: 2012-01-24 16:07:04 EST
14:44:43 <r_friedman> dkayiwa: ok, got it up, let me check
14:44:51 <dkayiwa> ok
14:45:20 *** Mkop has joined #openmrs
14:45:20 *** ChanServ sets mode: +v Mkop
14:47:25 <r_friedman> dkayiwa: ok, what i'm saying is, suppose you have a resource WidgetResource with an underlying object Widget and table widget
14:47:36 <dkayiwa> ok
14:47:47 <r_friedman> if the widget table is empty, the catalog fails
14:48:13 <dkayiwa> r_friedman: what do you mean by widget table?
14:48:35 <dkayiwa> r_friedman: or do you have an example that i can test with
14:48:40 <r_friedman> the table in which instances of the Widget object are stored
14:49:41 <dkayiwa> r_friedman: like the database users table for the UserResource?
14:49:52 <rafa> hi r_friedman
14:50:01 <r_friedman> rafa, be back in sec
14:50:12 <rafa> ok
14:50:40 <r_friedman> dkayiwa: you just need to use a table that won't run into referential integrity problems if you delete all its records, like user or location
14:50:54 <r_friedman> maybe something in logic or reporting
14:50:59 <dkayiwa> r_friedman: ok
14:51:11 *** nribeka has quit IRC
14:51:15 <r_friedman> delete all the records, then try to do a catalog
14:51:24 <dkayiwa> r_friedman: ok
14:51:55 <r_friedman> dkayiwa: got it?
14:52:09 <dkayiwa> r_friedman: yes thanks :)
14:53:17 <r_friedman> rafa, i can't turn my attention to the sprint until I can commit a new lab module head, and i am having a maven problem
14:54:00 *** ChanServ sets mode: +v r_friedman
14:54:01 *** harshadura has joined #openmrs
14:54:27 <rafa> r_friedman: I love maven problems ;)
14:54:41 <dkayiwa> rafa: :D
14:55:03 <r_friedman> I need the testing part of webservices.rest as a jar to refer to its methods, and i am creating it using the maven jar plugin, and i can see it in the target directory
14:55:31 <r_friedman> but maven can't find it in the openmrs repo
14:55:54 <r_friedman> I had the problem when I first did this, and it healed itself
14:56:39 <r_friedman> but I got a clean version of webservices.rest and added in the build and now its back again
14:57:27 <r_friedman> rafa, u are the expertest at maven :-)
14:58:14 <rafa> you mean using the maven jar plugin <goal>test-jar<goal>?
14:58:21 <bwolfe> r_friedman, are you running mvn install at the root ?
14:58:58 <r_friedman> rafa, yes; bwolfe i use the plugin and point to the parent project
14:59:08 <r_friedman> bwolfe: eclipse plugin
15:00:08 <rafa> r_friedman: is your lab pom committed?
15:00:15 <r_friedman> no but can do
15:00:28 <dawn_> !scrumon dawn
15:00:28 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready.
15:00:39 <dawn_> Hi Team! Hope you all had a nice weekend 8)
15:00:44 <rafa> r_friedman: please do I'll have a look
15:00:45 <djazayeri> hi team
15:00:54 <rafa> hi
15:00:55 *** wyclif has joined #openmrs
15:01:14 <dawn_> There are several tasks going on this week, so i want to try getting updates by task (just a pilot test)
15:01:21 <djazayeri> good idea
15:01:34 <dawn_> Today's order: 1) Atom Feed: bwolfe ,
15:01:39 <dawn_> 2) Bug Fix: dkayiwa ,
15:01:46 <dawn_> 3) RESTWS1.0: djazayeri , rafa , r_friedman
15:01:48 <dawn_> 4) Order Entry: wyclif
15:02:18 <dawn_> Fromt he wiki we are missing a few ppl, but let's get started and try this today
15:02:20 <dawn_> bwolfe: your turn :)
15:02:26 <djazayeri> people participating in the web services sprint are: djazayeri, rafa, r_friedman, (saptarshi), (skathol), (mvorobey), (surangak), finbrein
15:02:43 <dawn_> djazayeri: thanks!
15:02:51 <bwolfe> need to ping those other restws people
15:03:06 <r_friedman> is this the usual scrum time?
15:03:39 <bwolfe> r_friedman, https://wiki.openmrs.org/display/RES/Daily+Scrum+Meeting
15:04:03 <bwolfe> 1) atom feed spike
15:04:05 <bwolfe> today:
15:04:05 <bwolfe> final look into REPORT-352
15:04:05 <bwolfe> reviewed 2 tickets
15:04:05 <bwolfe> triaged tickets
15:04:05 <bwolfe> emails/ticket comments
15:04:06 <bwolfe> review merck applicants
15:04:08 <bwolfe> worked on eventbus module
15:04:12 <bwolfe> friday:
15:04:14 <bwolfe> slogged through rest of email and commented/reviewed a bunch of happenings
15:04:16 <bwolfe> applied TRUNK-2498, validate email address
15:04:18 <bwolfe> applied TRUNK-2616, validate name regex in api
15:04:20 <bwolfe> dev planning call
15:04:22 <bwolfe> started work on REPORT-352, stoppable report runs
15:04:24 <bwolfe> reviewed git tutorial from wednesday
15:04:31 <bwolfe> blocker was getting reporting to report for me. but I just punted the ticket with a patch and moved on. ;-)
15:05:34 <dawn_> dkayiwa: your turn
15:05:36 <dkayiwa> Was working on: Modify WSDoc annotation to support links - RESTWS-180
15:05:37 <dkayiwa> And go distracted with troubleshooting RTH module on 1.9.0 RC3 to get a response for Manu Tarus's email
15:05:37 <dkayiwa> Was lucky to reproduce his exact problem and am about to send an email after what i have tested to solve it. Thanks rafa for the tips. :)
15:05:37 <dkayiwa> No Blockers
15:06:22 <djazayeri> wyclif: your turn
15:06:27 <wyclif> Friday:
15:06:28 <wyclif> * TRUNK-1955 - Relationships lost when creating a new patient and results not refreshed
15:06:28 <wyclif> * RCM-15 - Include Patient Attributes when doing a data export
15:06:28 <wyclif> * Investigated and left comment and patch for REPORT-166 - Ensure that all date-based queries are appropriately handling boundary conditions
15:06:28 <wyclif> * IRC discussion with mike, mark, darius and ben about META-217 - Recent MDS versions break Sync, leading to potential data loss
15:06:30 <wyclif> Monday:
15:06:32 <wyclif> * Read wiki page notes from earlier discussions of the new order entry API
15:06:34 <wyclif> * Look at the current order entry API in the order entry branch and figure out the things to borrow
15:06:36 <wyclif> * Start on the design process
15:06:38 <wyclif> Blockers: None
15:07:05 <djazayeri> —Begin REST Web Services Topic ---
15:07:18 <djazayeri> Friday 13-Apr-2012
15:07:18 <djazayeri> * Prepared dashboard for RESTWS 1.0 Sprint
15:07:18 <djazayeri> * Created RESTWS-217, RESTWS-218, RESTWS-219, RESTWS-220
15:07:18 <djazayeri> * Created META-217, META-218
15:07:18 <djazayeri> * Released a quick-fix of MDS 1.0.5.1 that fails to start if Sync is running
15:07:19 <djazayeri> * Another commit on REPORT-330 (First pass at Data Export replacement in the reporting framework)
15:07:20 <djazayeri> Monday 16-Apr-2012
15:07:20 <djazayeri> * Review the 9 needs-review RESTWS-1.0 tickets
15:07:21 <djazayeri> * Work on a sprint ticket or two
15:07:22 <djazayeri> no blockers
15:07:58 <dawn_> rafa: you turn :)
15:08:13 <rafa> Today:
15:08:13 <rafa> * Finished up REPORT-223: Run Report page does not properly handle Collection parameters
15:08:13 <rafa> https://tickets.openmrs.org/browse/REPORT-223
15:08:13 <rafa> * Investigated META-218: Recent MDS versions break Sync, leading to potential data loss and got a solution, but
15:08:13 <rafa> waits on Mark's suggestion to implement it differently
15:08:13 <rafa> * Will pick up a rest ticket.
15:08:13 <rafa> No blockers.
15:08:20 *** nribeka has joined #openmrs
15:08:20 *** ChanServ sets mode: +v nribeka
15:08:51 <dawn_> r_friedman: your turn :)
15:08:56 <r_friedman> starting work on RESTWS-178; blocker is maven issue with Lab Module that I need to get out before sprinting
15:09:12 <djazayeri> r_friedman: is that the test-jar issue?
15:09:17 <r_friedman> djazayeri: yep
15:09:24 <djazayeri> okay, let's discuss after scrum
15:09:33 <r_friedman> ok
15:09:38 <djazayeri> saptarshi, sunbiz, you here under a different nick?
15:09:48 <djazayeri> sk are you skathol?
15:10:20 <djazayeri> and if so, are you working on a RESTWS ticket now?
15:11:05 <djazayeri> mykola, mvorobey, are you here under a different nick?
15:11:05 <dawn_> !scrumoff dawn
15:11:05 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
15:11:15 <djazayeri> surangak: are you here under a different nick?
15:11:21 *** harshadura has quit IRC
15:11:22 <dawn_> djazayeri: working on an email to get everyone together. i think the challenge learned on this is getting everyone's IRC names
15:11:32 <djazayeri> finbrein: are you working on a RESTWS ticket now?
15:11:46 <djazayeri> (and if so, give a quick report)
15:12:11 <r_friedman> djazayeri: on your e-mail, include the schedule at the page ben linked me to
15:12:58 <djazayeri> dawn_: perhaps we should switch to the new scrum schedule starting tomorrow...
15:13:03 <djazayeri> would be much easier
15:14:22 *** sgithens_ has quit IRC
15:14:25 <dawn_> djazayeri: i can do that and make an announcement (tho we need to find a time for Thursday)
15:15:02 <r_friedman> djazayeri: rafa pom committed
15:15:12 <rafa> r_friedman: ok
15:15:17 <djazayeri> r_friedman: that will produce and install the test-jars?
15:15:39 *** suranga has joined #openmrs
15:15:39 *** ChanServ sets mode: +v suranga
15:15:46 <r_friedman> djazayeri: no, this is the module's pom, djazayeri
15:15:57 *** mvorobey has joined #openmrs
15:16:13 <mvorobey> hi all
15:16:17 <djazayeri> hi mvorobey
15:16:25 <mvorobey> am I late for scrun today ?
15:16:34 <mvorobey> scrum
15:16:39 <r_friedman> mvorobey: we have scrummed and scrammed
15:16:46 <djazayeri> you just missed it, but you can go now if you want to report what you're working on in RESTWS
15:17:00 <mvorobey> :) yes I have :)
15:17:09 <mvorobey> * Prepared for review RESTWS-217
15:17:09 <mvorobey> * Gonna pick the next ticket from the sprint dashboard
15:17:09 <mvorobey> * No blockers
15:17:16 <djazayeri> mvorobey: great!
15:18:08 <djazayeri> r_friedman: is there any issue that discussion would help with? or are you just solving it now?
15:19:14 <r_friedman> djazayeri: i had started discussing it with rafa. the test jar is being created, i can see it in the project. but maven is complaining that it can't find it in the openmrs repo. and when i look at the repo view in eclipse, it's not there
15:19:54 <mvorobey> djazayeri, I was trying to investigate into RESTWS-214, but I'm not sure that I'm clear in goal of that ticket , can you help me with that ?
15:19:54 <rafa> djazayeri: r_friedman I'll actually commit a change for creating and installing tests in rest
15:20:04 <djazayeri> okay, great
15:20:21 <r_friedman> rafa +1
15:20:53 <finbrein> djazayeri: working on the sprint ticket RESTWS-216
15:21:15 *** lh has joined #openmrs
15:22:09 <MarkG> fwiw, if anyone is trying to reach anyone at PIH, our email is down
15:22:31 *** isharap has quit IRC
15:22:40 <rafa> djazayeri: r_friedman done
15:23:03 <r_friedman> mvorobey: i know about 214. if you are referring to a module-created resource, the link should have the module name after the v1
15:23:31 <rafa> r_friedman: can you try updating rest and installing again?
15:23:43 <r_friedman> rafa will do
15:23:54 <djazayeri> mvorobey: oh, sorry, just saw your comment
15:25:10 <mvorobey> r_friedman, djazayeri: aha, ok, so jsslab - it's a module name :) It seems more clear for me
15:25:36 <mvorobey> am not familiar with jsslab module at all :(\
15:26:05 <r_friedman> mvorobey: i'd tell you about it, but then i'd have to kill you
15:26:22 <suranga> hi dkayiwa .. mm r u around ?
15:26:49 <rafa> djazayeri: any big ws tickets?
15:26:50 <bwolfe> dkayiwa, if there are common problems with the RTH module, we need to put those into the error messages (as well as where they are on the wiki)
15:27:03 <bwolfe> dkayiwa, I'm thikning about the zerotime thing and the max_allowed_packet
15:27:16 <djazayeri> mvorobey: you don't need to be. the idea is that BaseDelegatingXyz (I forget which one) should have a method you can optionally override that adds a namespace
15:27:18 <mvorobey> r_friedman, oh, shoot, I'm gonna to be killed by someone ? I need help :D
15:27:29 <suranga> actually, this is more general question ; why did we make our Hl7 messages asyncrhonus ? as in, why did we decide to go with a Hl7 quwue, and have a scheduled task to run it ?
15:28:38 <djazayeri> mvorobey: and the getUri method should call that new method, and if it returns non-null, include that in the URI in the right place
15:28:49 <r_friedman> mvorobey: that's why we define interfaces, so you don't have to get into the kill zone
15:29:58 <djazayeri> mvorobey: do our comments make sense?
15:30:02 <mvorobey> r_friedman, djazayeri: ok. it's more clear for me, but you guys - are the best, lol :D
15:30:08 <dkayiwa> bwolfe: ok
15:30:14 <djazayeri> rafa: the biggest ws ticket is currently in-progress by saptarshi
15:30:56 <djazayeri> mvorobey: if you're working on RESTWS-214, don't forget to claim it!
15:31:22 <djazayeri> rafa: I guess you can take over RESTWS-180, which dkayiwa looked at a bit today
15:32:00 <rafa> djazayeri: okay, thx
15:32:10 <r_friedman> rafa, no joy. should the lab pom say "test" or "tests"?
15:32:13 <djazayeri> rafa: to clarify, between what MarkG did over the weekend, and what you did today, is the MDS issue "under control"?
15:32:18 <dkayiwa> bwolfe: by "we need to put those into the error messages" do you mean in the application's error message that is printed out?
15:32:34 <djazayeri> rafa: in particular, do we know if it breaks the AuditableInterceptor in trukn?
15:32:53 <mvorobey> djazayeri, I'm still only gonna to pick up it :) would not you mind if i do it ?
15:32:54 <rafa> djazayeri: yes, it does break AuditableInterceptor
15:33:01 <bwolfe> dkayiwa, yes. th eone that the user sees
15:33:03 <rafa> djazayeri: it breaks all interceptors
15:33:24 <dkayiwa> bwolfe: ok let me do that now
15:33:28 <djazayeri> rafa: so…the current version of MDS should not be used against what versions of core?
15:33:47 <djazayeri> all recent ones?
15:34:31 <rafa> djazayeri: all versions with "new" interceptors mechanism
15:34:36 <MarkG> djazayeri: yes, it breaks auditable interceptor in trunk... i sent out an email about it, but our email is down....
15:34:51 <rafa> MarkG: hi
15:35:36 <djazayeri> rafa, MarkG: the new auditable interceptor is included in the latest stable 1.8.(3?) right?
15:37:00 <rafa> djazayeri: it's in 1.8.x
15:37:00 <djazayeri> suranga: you clicked the wrong button on RESTWS-220
15:37:00 <MarkG> djazayeri: you mean the chaining interceptor?
15:37:29 <djazayeri> MarkG: I mean: what released versions of OpenMRS is MDS contraindicated for
15:37:31 <MarkG> i'm pretty sure it is all 1.8.x and 1.9.x... not quite sure if it is in all releases of 1.7.x
15:38:03 <suranga> djazayeri, ummm I had no idea I clicked on anything yet... sorry :-)
15:38:04 <MarkG> djazayeri: let me look up the build number
15:38:26 <djazayeri> suranga: it says you're the assignee, but it's still in Ready for Work
15:38:42 <djazayeri> suranga: our JIRA UI is slightly annoying: you should never click "assign to me"
15:38:45 <dkayiwa> bwolfe: for such a small thing, do i need to first create a ticket? Or can i just make the code change and commit?
15:38:50 <djazayeri> suranga: but rather "claim ticket" on the right instead
15:39:01 <suranga> djazayeri, ooops, sorry, embarassing... and this after 1.5 years with you guys :P\
15:39:05 <bwolfe> dkayiwa, aren't there tickets for the errors already? just make a side note about them there
15:39:18 <dkayiwa> bwolfe: ok let me check
15:39:20 <MarkG> anything after 23210 in the 1.6.x line, and 23211 in the 1.7.x line will be problematic
15:39:25 <djazayeri> downey: can we add some CSS to JIRA to hide the bad non-workflow assign buttons?
15:39:45 <djazayeri> MarkG & rafa: those include the latest released versions on our downloads page, right
15:39:46 <djazayeri> ?
15:40:24 <bwolfe> djazayeri, downey already did it. where are you seeing it?
15:40:55 <bwolfe> oh wait, seems the button is back
15:41:02 <bwolfe> he HAD fixed it a week or so ago
15:41:32 <MarkG> djazayeri: yes
15:41:54 <MarkG> 1.6.x still uses the old AOP auditing, so auditing still happens in 1.6.x
15:43:12 <djazayeri> so, rafa: since MDS makes our latest stable released versions lose data, I think we need to email the lists, and either pull the module from the repository, or release another quick-fix that won't run in 1.7.x or 1.8.x until that is fixed
15:44:25 <rafa> djazayeri: I've got a fix and need to test it with sync.
15:44:38 <rafa> djazayeri: It works with AuditableInterceptor
15:44:42 <djazayeri> rafa: okay
15:45:04 <djazayeri> rafa: what is testing with sync waiting on?
15:45:05 *** harshadura has joined #openmrs
15:45:07 <djazayeri> do you need mark's help?
15:45:18 <djazayeri> or you just need time?
15:45:33 <rafa> djazayeri: I'm starting with that right away
15:45:43 <mvorobey> djazayeri, now, when I'm calling openmrs/ws/rest/v1l/location//"uuid", am receiving rel URL as "self" or something, what does it mean ?
15:47:33 <djazayeri> mvorobey: the "self link" is most useful when you only have a mini-representation of a resource included in another one
15:48:12 <djazayeri> e.g. if I fetch an encounter, I can look at "encounter.patient.links[rel=self]" and that tells me where to fetch the patient from.
15:48:13 <mvorobey> djazayeri, ok. got it
15:49:37 <mvorobey> djazayeri, so, can I pick restws-214 or some one else did it ?
15:50:14 <djazayeri> mvorobey: if it's open in jira, you can claim it
15:50:54 <djazayeri> mvorobey: nobody else is working on it that I know of
15:51:16 <mvorobey> djazayeri, oh, thanks, i gonna claim it, i'll have a question, I'm sure :)
15:52:12 *** dawn_ has quit IRC
15:52:29 <mvorobey> djazayeri, from where can I get module name for URI ? (class, method etc)
15:53:29 <suranga> hmm.. hi djazayeri ... so I've requested a code review for RESTWS-220
15:53:59 <suranga> djazayeri, what im basically doing is asking you if the patch for jeremys RESTWS-213 will solve my ticket
15:54:08 <suranga> djazayeri, :-P
15:57:51 <suranga> hi mm... bwolfe I was wondering why u guys made hl7 processing asynchronus ? is it because you anticipate that it will take a lot of time to process ?
16:00:07 *** bryq has joined #openmrs
16:00:07 *** ChanServ sets mode: +v bryq
16:06:02 <downey> djazayeri / bwolfe - which workflow button are you talking about?
16:07:09 *** dawn_ has joined #openmrs
16:07:09 *** ChanServ sets mode: +v dawn_
16:07:36 *** gauravpaliwal has left #openmrs
16:10:57 *** jriley has left #openmrs
16:12:07 <djazayeri> downey: on RESTWS-216, suranga was able to assign to himself without getting it "In Progress"
16:12:24 <djazayeri> I assume he clicked the assign button on the left, rather than the "workflow" buttons on the right
16:12:35 <downey> djazayeri: We disabled the "Assign to Me" but not "Assign"
16:12:39 <downey> suranga ^
16:13:08 <suranga> djazayeri, I clicked assign -> assign to me
16:13:19 <djazayeri> downey: why didn't we disable Assign too?
16:13:31 <suranga> so when I click on assign, I get to pick myself again :-)
16:13:48 <downey> djazayeri: No one asked me to. :)
16:14:18 <djazayeri> downey: I can see where it might be necessary to clean things up where our transitions aren't right, but maybe we can also tweak the button to make it smaller or greyed out, or something
16:14:29 <djazayeri> or maybe we just remove that one too and see what happens. :-)
16:15:29 <downey> djazayeri: the latter is much more doable within JIRA since we're not allowed to hack it :-/
16:22:03 *** mvorobey_ has joined #openmrs
16:22:03 *** mvorobey has quit IRC
16:28:48 *** mathiaslin has joined #openmrs
16:31:08 <djazayeri> downey: I think we should remove it
16:32:23 *** dawn_ has quit IRC
16:35:44 <downey> djazayeri: it's already done
16:35:49 <djazayeri> great!
16:45:19 <finbrein> djazayeri: Are you aware that I am working on RESTWS-216?
16:46:26 <djazayeri> finbrein: have you claimed it in JIRA?
16:46:36 <downey> !ticket RESTWS-216
16:46:37 <OpenMRSBot> downey: [#RESTWS-216] Add page describing POST content - OpenMRS JIRA - https://tickets.openmrs.org/browse/RESTWS-216
16:46:41 <finbrein> djazayeri: yes
16:46:46 <djazayeri> finbrein: then I'm aware. :-)
16:47:22 <djazayeri> finbrein: actually I was aware when I asked this morning, but I wanted you to give a quick update for the scrum
16:49:27 <finbrein> djazayeri: I was working with jmiranda on birt last week and had to take a look before continuing with RESTWS-216. Now I am focusing on RESTWS-216
16:50:26 *** mathiaslin has quit IRC
16:51:37 <finbrein> djazayeri: i had to do a few tutorials on RESTful webservices since it is new to me
16:52:10 <djazayeri> finbrein: cool
16:53:48 *** isharapremadasa has joined #openmrs
16:54:16 *** isharapremadasa is now known as isharap
16:57:18 *** downey sets mode: +v wyclif
16:59:27 *** sunbiz has joined #openmrs
16:59:27 *** ChanServ sets mode: +v sunbiz
17:03:45 <downey> lh: red hat question for you when you have a free moment or two
17:07:06 *** mvorobey has joined #openmrs
17:07:12 *** mvorobey_ has quit IRC
17:13:09 *** rafa has quit IRC
17:26:16 *** rafa has joined #openmrs
17:26:16 *** ChanServ sets mode: +v rafa
17:28:31 *** kavuri has joined #openmrs
17:30:20 <kavuri> Hi downey, got a question about hospital entity. As far as I could see in the openmrs data model, there is no entity like a hospital. Is it so that openmrs is expected to cater to one single hospital?
17:30:55 *** mvorobey has quit IRC
17:31:56 <downey> kavuri: I might be missing something, but I think a hospital is generally considered a Location.
17:32:56 <kavuri> downey: right I thought I could use a location. The idea I had was that a group of providers (doctors) would belong to a hospital and a hospital could in itself belong to a group of hospitals
17:33:59 <downey> kavuri: not sure if there's any easy way to group locations, but someone else here might be :)
17:34:04 <kavuri> downey: guess I can create multiple locations and make one single location as the parent of all other locations? To represent a group of hospitals
17:37:54 *** nadee has quit IRC
17:39:58 *** rohitgoyal18 has joined #openmrs
17:49:30 *** isharap has quit IRC
17:54:56 *** dkayiwa has quit IRC
17:56:04 *** dkayiwa has joined #openmrs
17:56:22 <djazayeri> kavuri: you can use the Location data model (which includes parentLocation) to build up a location hierarchy
17:56:38 <djazayeri> this is intended to represent actual physical location hierarchy, though
17:56:54 <djazayeri> e.g. Hospital X is in Eastern Province
17:57:04 <djazayeri> or Operating Room A is in Hospital X
17:57:47 <djazayeri> kavuri: in OpenMRS 1.9 we introduce "Location Attributes" which would let you add a "Hospital Group" attribute to locations
17:57:54 <djazayeri> that would be the right approach
17:58:28 <kavuri> djazayeri: sounds like what I am looking for.
17:59:14 <kavuri> djazayeri: guess the task of associating "Hospital group" to a bunch of locations is still upto the one who would build up the data model for a particular hospital, right?
17:59:42 <kavuri> djazayeri: I mean the interpretation of the hospital group to the group of locations
17:59:59 <djazayeri> kavuri: yeah, you'd have to figure out how to work this into your UI
18:00:04 <djazayeri> (gotta run, back in a bit)
18:00:14 <kavuri> thanks djazayeri ..this helps
18:13:24 <r_friedman> kavuri: I would be very wary of using the location hierarchy for this, everybody expects this to be a geographical hierarchy, so if the organizational hierarchy crosses geographic boundaries, I would look for someplace else to put it, like location attribute (1.9+) or location tag (1.8-)
18:14:06 <r_friedman> kavuri: you could take over an unused geographical level and put the group name in there
18:15:27 <kavuri> r_friedman: could you please point me to the geographical level you are refering to? (I am still new to the data model of openmrs)
18:16:42 *** Echidna has quit IRC
18:16:43 <r_friedman> kavuri: we have about 12 address fields in location
18:17:38 <r_friedman> kavuri: i don't know what country you're from, but most countries don't use more than 6 (I think we need 6 for India)
18:17:59 *** Echidna has joined #openmrs
18:18:03 *** ChanServ sets mode: +v Echidna
18:18:07 <kavuri> r_friedman: I am from India, and yes, probably 6 would be good enough
18:18:36 <r_friedman> kavuri: so that means you have 6 others you can use as you want
18:19:15 <r_friedman> kavuri: i have a project in India, we gave some thought to using 6 in English and having the lower 3 or 4 in the local script
18:19:44 <r_friedman> kavuri: that would still leave 2 to be used as classifiers
18:19:47 <kavuri> r_friedman: right, I am just worried with the fact, as to what if I would end up too much over loading location with a hospital entity
18:20:22 <kavuri> r_friedman: how about creating a new entity called hospital and group of hospitals?
18:20:35 <r_friedman> kavuri: well, location attribute is the right way to do it, but you probably don't want to build your system on an unreleased version either
18:20:37 <kavuri> r_friedman: and ofcourse, a hospital would be linked to a location
18:20:59 <r_friedman> kavuri: hold on a second, let me tell you how we're doing it
18:24:20 <r_friedman> kavuri: we have state, district, city, then the hospital in the city and the wards/departments in the hospital; we also have town, which is in either city or province, in which we have clinics
18:25:58 <r_friedman> kavuri: we use location tags to indicate labs, either inside the hospital or external labs where specimens are sent. The external labs are at the hospital level, the internal lab is under the hospital level
18:27:20 <r_friedman> but all of these (state, district, city, town, hospital, external lab, ward/department) are locations
18:28:31 <kavuri> r_friedman: infact, this model does serve the purpose of hospital + group of hospitals. As long as the idea of location is this, I guess it should be fine
18:29:09 <kavuri> r_friedman: but like I said earlier, I just want to make sure that the term location is not being over loaded and used for other purposes
18:30:39 <r_friedman> kavuri: i wouldn't worry about overloading, just remember there's a single hierarchy; so if you want to use a location field to indicate whether a facility is government, private, religious, NGO or whatever you need for statistical purposes, that's fine
18:30:52 <r_friedman> not all of the address fields have to participate in the hierarchy
18:32:01 <kavuri> r_friedman: sounds fine...I will continue with location. Thanks r_friedman for the clarification.
18:32:13 <kavuri> will have to signoff for the day. Quite late here already
18:32:20 <r_friedman> kavuri: feel free to catch me here or at openmrs university
18:32:30 <kavuri> r_friedman: sure. Thanks
18:32:55 *** kavuri has quit IRC
18:56:05 *** james_regen has left #openmrs
19:00:03 <r0bby> sunbiz, pinggggggggggggggggggggggggggggggggg
19:00:23 <djazayeri> sunbiz: oh, hey, you're online, ping me when you get the chance
19:01:14 <djazayeri> sunbiz: (regarding RESTWS tickets)
19:01:40 <djazayeri> bwolfe: did we decide that get-all in RESTWS is not going to include retired metadata?
19:01:53 <djazayeri> I have no recollection of that, but I see a unit test asserting it for concept
19:03:03 <bwolfe> sunbiz, ping. I don't need to talk to you, just wanted to be like the cool kids and get your attention
19:03:11 <bwolfe> djazayeri, I don't remember having a discussion about it
19:03:38 <bwolfe> djazayeri, I would assume we would do the same as we do in core: retired metadata is included by default. voided data is not included
19:04:39 <djazayeri> bwolfe: same here, but all 5 examples I've looked at call getAllXyz(false)
19:05:24 <bwolfe> djazayeri, intersting. anything in the wiki pages about it?
19:05:38 <r_friedman> sunbiz: pyongyang
19:07:49 <r_friedman> bwolfe: djazayeri: it would be nice to have a side-by-side comparison of the expectations for metadata v. data -- in addition to the one you describe, metadata has name and description; retire returns the retired object, void returns void
19:08:25 <bwolfe> r_friedman, theres a wiki page about "metadata vs data" I think
19:09:41 <djazayeri> bwolfe: you actually edited a wiki page on Jun 1 2011 saying that doGetAll should not include retired
19:09:42 <djazayeri> https://wiki.openmrs.org/pages/viewpage.action?pageId=29524942
19:10:12 <suranga> mm.. hi djazayeri
19:10:26 <djazayeri> bwolfe: I guess it was intentional then, so forget I asked
19:10:28 <djazayeri> hi suranga
19:10:35 <bwolfe> interesting. I still have no memory of it :-p
19:10:59 <suranga> djazayeri, I was wondering if I could make the HL7 processing syncronus by calling the processor class direclty...
19:11:21 <djazayeri> suranga: in client code, you mean?
19:11:29 <suranga> as in , instead of putting hl7 into the queue, I call the hl7 processor straight away...
19:11:38 <djazayeri> I think that may be possible, though I'm not sure
19:11:45 <bwolfe> suranga, dkayiwa does this in the xforms module I think.
19:11:54 <suranga> aaaaah !
19:12:03 <suranga> I see..
19:12:07 <r_friedman> bwolfe: the closest thing is a page by Ellen Ball from 10/10 https://wiki.openmrs.org/display/docs/Voiding+and+Retiring+Concepts
19:12:25 <suranga> djazayeri, by client code u mean anything that accesss OpenMRS, right >
19:12:40 <suranga> djazayeri, I was figuring on changing the core itself :-)
19:13:01 <djazayeri> suranga: no, you cannot change the default behavior of core by getting rid of the queue...
19:13:14 <djazayeri> suranga: I mean, you "can", but you "may not"
19:13:52 <suranga> djazayeri, sorry did not get what u mean.. I wanted to call the processor class directly... why u say I 'may not ? :-)
19:14:08 <djazayeri> suranga: client code is allowed to call the processor directly
19:14:13 <bwolfe> r_friedman, I was thinking of this page: https://wiki.openmrs.org/display/docs/API+Service+Template
19:14:31 <djazayeri> suranga: you are not allowed to modify core code to change its behavior, without leading a dev list discussion about it
19:14:47 <suranga> aah, i see djazayeri
19:19:33 *** sunbiz has quit IRC
19:19:35 *** sunbiz1 has joined #openmrs
19:21:44 * suranga wonders if dkayiwa is still here :P
19:22:02 <dkayiwa> suranga: almost :)
19:22:45 <suranga> hi dkayiwa bwolfe says that you implemented a synchonus HL7 processins system in xforms...
19:22:50 <suranga> dkayiwa, mm.. is that right ?
19:24:26 <dkayiwa> suranga: bwolfe is never wrong :)
19:24:36 <bwolfe> ha
19:25:00 <suranga> dkayiwa, so basically instead of stuffing things into your queue, you called the processor class directly, is it ?
19:25:11 <dkayiwa> suranga: yes
19:25:27 <suranga> dkayiwa, mm.. this does not sound too complicted to me :-)
19:25:49 <suranga> dkayiwa, this looks like just a single line of code then ? is it ?
19:26:32 <dkayiwa> suranga: not complicated
19:26:52 <suranga> dkayiwa, mm.. can u remember the exact class u did it in ? :
19:26:55 <suranga> :-)
19:28:41 <dkayiwa> suranga: FormEntryQueueProcessor
19:28:58 <suranga> dkayiwa, yayyy !!!
19:29:05 <dkayiwa> suranga: in this package org.openmrs.module.xforms.formentry
19:29:06 <suranga> dkayiwa, thanksssss :-)
19:30:12 <dkayiwa> suranga: the transformFormEntryQueue message creates an HL7InQueue object
19:30:45 <suranga> dkayiwa, but we are not going to do that, right ? :-)
19:31:36 <dkayiwa> suranga: you are going to :)
19:32:08 <suranga> dkayiwa, but mm... I thought the point was to avoid the queue entirely right ?
19:32:21 <dkayiwa> suranga: it is just an object
19:32:23 <suranga> mm.. I thought that we would be just calling the processor directly ?
19:32:31 *** rohitgoyal18 has quit IRC
19:33:15 <dkayiwa> suranga: you will also look at HL7InQueueProcessor
19:33:39 <dkayiwa> suranga: and method processHL7InQueue(
19:33:58 <suranga> dkayiwa, mmm... the HL7InQueueProcessor is from the core right ?
19:34:39 <dkayiwa> suranga: No
19:34:52 <dkayiwa> suranga: in package org.openmrs.module.xforms.formentry
19:36:14 <dkayiwa> suranga: the HL7InQueue is just an object i construct to reuse the formentry hl7 processing classes. but it is not queued since i pass the object directly to the api for processing
19:36:34 <sunbiz1> bwolfe , djazayeri , r_friedman : the ping wasnt waking me up... sorry guys
19:37:17 *** sunbiz1 has left #openmrs
19:37:21 *** sunbiz1 has joined #openmrs
19:37:29 <suranga> dkayiwa, so when the hl7 request comes in, I constrcut an Hl7inqueue object... and pass it into the HL& in queue processor right ?
19:37:41 *** sunbiz1 has left #openmrs
19:37:52 *** sunbiz1 has joined #openmrs
19:37:59 *** sunbiz1 has left #openmrs
19:38:03 <suranga> dkayiwa, so i assume u wont make use of the hl7inqueue table at all ?
19:38:25 *** sunbiz has joined #openmrs
19:38:25 *** ChanServ sets mode: +v sunbiz
19:39:39 <dkayiwa> suranga: i do not store anything in the hl7inqueue table because i do not call the Context.getHL7Service().saveHL7InQueue method
19:40:10 <suranga> dkayiwa, mmm.... I think I understand what you've done :-)
19:40:18 <suranga> dkayiwa, I hope, that is :P
19:40:27 <dkayiwa> suranga: :)
19:40:58 <suranga> dkayiwa, if not, I shall bug u tomorrow ! :D
19:41:32 <dkayiwa> suranga: the reason i created the hl7InQueue object is because i wanted to archive it
19:41:37 <djazayeri> sunbiz: I was just checking on the two RESTWS tickets you have assigned to you
19:41:52 <djazayeri> sunbiz: and wanted to know if you think you'll be able to complete them in the next few days
19:42:35 <suranga> dkayiwa, mm.. so u mean that after processing, the hl7 message goes into the archive or error tables based on their result, is it ?
19:44:03 <dkayiwa> suranga: am the one who puts its there. i could as well decide not too
19:44:18 <dkayiwa> suranga: just wanted to mimic what formentry was doing as much a possible :)
19:45:08 <suranga> dkayiwa, im thinking, take HL& -> create HL7inQueue object ->call HL7InQueueProcessor -> store in error or archive table
19:46:24 <dkayiwa> suranga: yes
19:47:57 <sunbiz> djazayeri: the getAll paging one yes
19:48:25 *** jblaya has joined #openmrs
19:48:27 <djazayeri> sunbiz: great!
19:48:34 <downey> Hi jblaya and welcome to the #openmrs IRC channel.
19:48:56 <djazayeri> sunbiz: about the other ticket (singular-vs-plural names) do you want to un-claim it?
19:49:03 <djazayeri> or might you still do it?
19:51:11 <sunbiz> djazayeri: unclaimed
19:51:21 <djazayeri> cool
20:08:39 <r_friedman> bwolfe: djazayeri: on RESTWS-178 (resource for LocationTag), Ben already has a class in Encounter called LocationTagController. Shall I call the REST controller LocationTagRestController or should Ben change his class' name?
20:09:35 <djazayeri> r_friedman: it's not a problem for them to have the same classname, but I imagine it's a problem that they're both annotated with @Controller
20:09:53 <r_friedman> no, it's screwing up the application context
20:10:00 <djazayeri> r_friedman: can you do @Controller("restwsLocationTagController") in the rest one?
20:10:03 *** wyclif has quit IRC
20:10:12 <djazayeri> but call it LocationTagController for its classname?
20:12:49 *** bryq has quit IRC
20:15:31 *** pulasthi7 has quit IRC
20:16:10 <r_friedman> djazayeri: doesn't seem to work, different error message but still having trouble injecting
20:16:19 <djazayeri> r_friedman: what's the error message?
20:20:30 <r_friedman> djazayeri: tons of blah blah blah boiling down to a hibernate mapping error
20:21:26 <r_friedman> which doesn't make any sense because I haven't changed any mapping file or db table
20:22:08 <djazayeri> r_friedman: you sure it's that? want to pastebin?
20:23:24 <r_friedman> djazayeri: http://pastebin.com/5zKZXmHs
20:25:50 *** wyclif has joined #openmrs
20:26:22 <djazayeri> r_friedman: yeah, that's a pretty blah blah blah error message
20:26:44 <djazayeri> if only we were using git, you could switch over to the master revision and make just the small change. :-)
20:26:59 <djazayeri> Do you have many code changes that could be causing it?
20:27:13 <bwolfe> Invocation of init method failed; nested exception is org.hibernate.MappingException: invalid configuration
20:27:17 <bwolfe> its a hibernate mapping issue
20:27:27 <bwolfe> did you change an object that is mapped?
20:27:44 <r_friedman> bwolfe: no
20:27:54 <bwolfe> did you include TestingApplicationContext.xml for a special reason?
20:28:07 <r_friedman> bwolfe: it's already there
20:28:17 <bwolfe> r_friedman, is this during testing or during module load in webapp?
20:28:25 <r_friedman> bwolfe: junit testing
20:28:49 <bwolfe> The content of element type "session-factory" must match "(property*,mapping*,(class-cache|collection-cache)*,event*,listener*)".
20:28:59 <bwolfe> that TestingApplicationContext uses some maven args, iirc
20:29:06 <bwolfe> perhaps maven isn't doing its thing?
20:29:11 <bwolfe> have you tried a maven clean?
20:29:25 <r_friedman> bwolfe: stand by
20:32:44 *** nribeka has quit IRC
20:37:16 <r_friedman> bwolfe: failed the same way in mvn clean install after eclipse project clean all
20:39:45 <bwolfe> hmm
20:39:52 <bwolfe> do you have mapping files?
20:39:56 *** downey has quit IRC
20:40:03 <bwolfe> can you just clear the TestingApplicationContext file temporarily?
20:46:18 <r_friedman> bwolfe: you mean have no TestingApplicationContext file at all?
20:47:50 <r_friedman> bwolfe: i have not changed mapping files, just did a diff
20:55:15 *** amnesiacandres has joined #openmrs
20:56:05 <amnesiacandres> Hallo all. Greetings from Mexico
20:57:07 <bwolfe> hola mexico
20:57:23 <amnesiacandres> nice, this is active
20:57:54 <bwolfe> amnesiacandres, it comes and goes
20:58:43 <amnesiacandres> bwolfe, just found out about this project, do you have any idea if it has something like a datamining module
20:59:16 <r_friedman> amnesiacandres: Hola andres, ¿dónde estás?
21:00:31 <amnesiacandres> r_friedman , estoy en Monterrey. Tu?
21:02:44 <r_friedman> Si, estamos trabajando con Pentaho, vea Reunion de developers desde hace pocos meses o busque a Andy Kanter
21:02:53 <r_friedman> estoy en Atlanta
21:03:19 <r_friedman> acabé de regresar desde Colómbia donde se casó djazayeri
21:04:24 <amnesiacandres> pues felicidades a cjazayeri. Justo esta aqui un colombiano de visita
21:05:33 <r_friedman> amnesiacandres: vea https://wiki.openmrs.org/pages/viewpage.action?pageId=27689370
21:05:50 <djazayeri> gracias. :-)
21:21:46 *** sunbiz has quit IRC
21:21:55 *** amnesiacandres has left #openmrs
21:22:07 *** r0bby is now known as robbyoconnor
21:23:07 <r_friedman> djazayeri: bwolfe: changing name of method to LocationTagRestController doesn't work either. the table does not include changed by/date changed fields but OpenMRSBaseMetadata and auditinfo are probably looking for them. Doubt that would cause a mapping error, any thoughts?
21:24:01 <djazayeri> r_friedman: can you make sure you're starting from a clean workspace?
21:24:22 <r_friedman> already did, eclipse clean all projects, mvn clean install
21:24:24 <djazayeri> I don't see why you'd be seeing mapping errors from just adding a controller
21:24:44 <djazayeri> r_friedman: I mean more in terms of doing an svn revert to anything that isn't relevant
21:24:48 <djazayeri> but obviously be careful before doing that
21:24:51 <djazayeri> so as not to lose work
21:25:05 <r_friedman> djazayeri: well, I've added a controller, a resource and a test class
21:25:23 <r_friedman> i just got a clean webservices.rest this am
21:27:25 <djazayeri> r_friedman: I don't know what's up then...
21:28:25 <djazayeri> r_friedman: you sure you didn't accidentally add some odd hibernate annotation instead of the expected one? :-)
21:37:33 *** MarkG has quit IRC
21:37:53 *** MarkG has joined #openmrs
21:42:19 *** MarkG has quit IRC
21:56:04 *** wyclif has quit IRC
22:01:20 *** rafa has quit IRC
22:18:13 <r_friedman> djazayeri: with the resource, the controller named LocationTagRestController, the controller @Controller having no annotation, and the test not in the project, I can run Jetty and the resource does not appear in the catalog (even though it shows lab module resources). Does this give you any clues?
22:18:46 <djazayeri> r_friedman: but when you add the @Controller annotation things break?
22:19:01 <r_friedman> No @Controller is there, just with no parameter, i misspoke
22:20:04 <djazayeri> r_friedman: do other tests run correctly?
22:20:09 *** dkayiwa has quit IRC
22:20:13 <r_friedman> djazayeri: yes
22:20:15 <djazayeri> r_friedman: presumably so, since you did an mvn package
22:20:27 <djazayeri> r_friedman: and adding the test causes build/test failure?
22:20:53 <r_friedman> well i haven't tried that, there's obviously something wrong if the resource doesn't show up in the catalog
22:21:24 <djazayeri> r_friedman: yeah, I forget how the catalog is built, and I have a commit dialog open now so I can't look at the code...
22:21:26 <djazayeri> give me 5 minutes
22:21:35 <r_friedman> ok
22:22:31 <r_friedman> djazayeri: never mind, the table is empty, that's why it doesn't show up, that's one of my reported bugs for this sprint
22:22:37 <djazayeri> r_friedman: ah, yes
22:23:12 <r_friedman> well let me remedy that and try again
22:24:50 *** Mkop has quit IRC
22:25:26 *** Mkop has joined #openmrs
22:25:26 *** ChanServ sets mode: +v Mkop
22:31:11 <r_friedman> djazayeri: well, it's still not in the catalog but i can find it!!
22:34:11 <djazayeri> r_friedman: in ResourceDocCreator I see //Remove resources without controllers
22:34:12 <djazayeri> maybe that?
22:38:56 <r_friedman> djazayeri: does that mean I need to give @Controller a parameter? or change the resource name to LocationTagRestResource?
22:39:15 <r_friedman> or pass the buck to the bug
22:39:56 <djazayeri> r_friedman: does your controller extend a base class?
22:43:10 <r_friedman> djazayeri: yes, basecrudcontroller
22:43:59 <r_friedman> looks like i would have to change the resource name, I would rather have Ben change the name of his routine
22:44:14 <djazayeri> unfortunately Ben's class is in core.
22:44:22 <r_friedman> yep
22:44:28 <djazayeri> r_friedman: is this merely a documentation issue?
22:44:34 <djazayeri> or is it not working with the different name?
22:45:03 <r_friedman> no it works, it's just not in the catalog
22:45:59 <r_friedman> maybe it just needs some other way to find the resources; isn't there an array of singletons it could use?
22:47:03 <djazayeri> r_friedman: peeking at the ResourceDocCreator code, it seems like a limitation (i.e. bug) there, where it tries to get the resource name by convention rather than looking at the BaseCrudController<ResourceName>
22:47:11 <djazayeri> I'd file a bug for that
22:47:49 <djazayeri> but r_friedman, can you verify what happens now that things are building, if you rename the controller to its expected name, but do @Controller("restwsLocationTagController")
22:47:49 <r_friedman> djazayeri: ok will do
22:51:35 *** suranga has quit IRC
22:58:53 <r_friedman> djazayeri: with those changes, it is still not in catalog but still works
22:59:14 <djazayeri> r_friedman: hmm, well, that's better, in any case
22:59:25 <djazayeri> r_friedman: I guess create a ticket for it not showing up in the catalog.
22:59:38 <r_friedman> djazayeri: done
22:59:46 *** wyclif has joined #openmrs
22:59:50 <r_friedman> so now i will add the test and watch it explode
23:12:41 <r_friedman> djazayeri: ok, so i add in the test and get the same hibernate mapping error message.
23:12:57 <djazayeri> r_friedman: can you pastebin the test?
23:13:26 <r_friedman> djazayeri: but i have an idea, in the test data there's only one line for locationtag: <location_tag/>
23:13:49 <r_friedman> i want to try deleting that line and seeing what happens
23:14:08 <djazayeri> okay, there should be some tags in the standardTestDataset, right?
23:14:31 <r_friedman> djazayeri: prob shld be but aren't
23:14:45 <djazayeri> oh, nm, no location tags
23:15:55 <r_friedman> djazayeri: so i know how to deal with that, but right now need to go home and cook dinner, Beth called and wondered where it was
23:16:33 <djazayeri> r_friedman: yeah, I want you to still be here on the sprint tomorrow. :-)
23:17:08 <r_friedman> djazayeri: i've got a little credit, she still remembers what she ate during my 2 weeks in Colombia
23:18:02 *** r_friedman has quit IRC
23:18:45 <djazayeri> you left leftovers?
23:24:07 *** lh has quit IRC
23:59:59 *** mathiaslin has joined #openmrs