| 00:54:33 | *** jmiranda has joined #openmrs |
| 01:25:12 | *** mathiaslin has joined #openmrs |
| 01:32:30 | *** robbyoconnor has joined #openmrs |
| 01:32:30 | *** ChanServ sets mode: +v robbyoconnor |
| 01:44:19 | *** lh has quit IRC |
| 02:02:42 | *** chopin_ has joined #openmrs |
| 02:13:25 | *** finbrein has quit IRC |
| 02:18:51 | *** mathiaslin has quit IRC |
| 02:19:23 | *** mathiaslin has joined #openmrs |
| 03:33:54 | *** lh has joined #openmrs |
| 03:33:54 | *** lh has joined #openmrs |
| 03:36:43 | *** deadpool_ has quit IRC |
| 03:40:26 | *** deadpool_ has joined #openmrs |
| 03:50:09 | *** jmiranda has quit IRC |
| 04:41:08 | *** dewmal has joined #openmrs |
| 04:41:44 | <dewmal> /join #gcj |
| 04:42:18 | *** dewmal_ has joined #openmrs |
| 04:48:02 | *** djazayeri has quit IRC |
| 05:16:24 | *** bryq has joined #openmrs |
| 05:16:24 | *** ChanServ sets mode: +v bryq |
| 05:22:37 | *** gauravpaliwal has joined #openmrs |
| 05:22:37 | *** ChanServ sets mode: +v gauravpaliwal |
| 05:26:01 | *** bryq has quit IRC |
| 05:26:29 | <deadpool_> does anyone know how long a hibernate session stays valid for? |
| 05:26:33 | <deadpool_> before it closes? |
| 05:36:03 | *** pulasthi7 has joined #openmrs |
| 05:38:04 | *** gauravpaliwal has quit IRC |
| 05:39:06 | *** goutham has joined #openmrs |
| 06:09:59 | *** gauravpaliwal has joined #openmrs |
| 06:09:59 | *** ChanServ sets mode: +v gauravpaliwal |
| 06:10:05 | *** djazayeri has joined #openmrs |
| 06:10:05 | *** ChanServ sets mode: +o djazayeri |
| 06:13:42 | <deadpool_> djazayeri: quick hibernate question after lets say i do a saveOrUpdate can i run a getCurrentSession.getTransaction.commit() manuall? |
| 06:14:03 | <deadpool_> will it affect any other methods because i assume the commits happen automatically |
| 06:16:38 | *** harshadura has joined #openmrs |
| 06:25:19 | *** finbrein has joined #openmrs |
| 06:27:52 | *** mathiasl_ has joined #openmrs |
| 06:27:55 | *** mathiaslin has quit IRC |
| 06:43:15 | *** morristic has joined #openmrs |
| 07:01:23 | *** MarkG has joined #openmrs |
| 07:10:33 | *** suranga has joined #openmrs |
| 07:10:33 | *** ChanServ sets mode: +v suranga |
| 07:13:07 | *** morristic has quit IRC |
| 07:26:35 | *** MarkG has quit IRC |
| 07:33:38 | *** deadpool_ has quit IRC |
| 07:46:11 | *** deadpool_ has joined #openmrs |
| 07:46:53 | *** suranga has quit IRC |
| 08:02:13 | *** bryq has joined #openmrs |
| 08:02:13 | *** ChanServ sets mode: +v bryq |
| 08:02:44 | *** deadpool has joined #openmrs |
| 08:04:24 | *** deadpool_ has quit IRC |
| 08:08:01 | *** deadpool has quit IRC |
| 08:09:07 | *** cosmin has quit IRC |
| 08:10:14 | <harshadura> hi djazayeri |
| 08:14:55 | *** deadpool has joined #openmrs |
| 08:19:09 | *** finbrein has quit IRC |
| 08:20:14 | *** deadpool has quit IRC |
| 08:25:24 | *** gauravpaliwal has left #openmrs |
| 08:27:19 | *** deadpool has joined #openmrs |
| 08:29:38 | *** dewmal has quit IRC |
| 08:30:08 | *** deadpool_ has joined #openmrs |
| 08:30:09 | *** dewmal_ has quit IRC |
| 08:33:35 | *** deadpool has quit IRC |
| 08:35:34 | *** deadpool_ has quit IRC |
| 08:43:33 | *** deadpool_ has joined #openmrs |
| 08:48:58 | *** dewmal_ has joined #openmrs |
| 08:49:19 | *** dewmal has joined #openmrs |
| 08:53:33 | *** bryq has quit IRC |
| 08:57:07 | <OpenMRSBot> Recent updates in the world of openmrs: Shazin Sadakath: Low Cost Earth Quake Alarm using Arduino <http://shazsterblog.blogspot.com/2012/04/low-cost-earth-quake-alarm-using.html> |
| 08:59:04 | *** deadpool has joined #openmrs |
| 08:59:40 | *** deadpool_ has quit IRC |
| 09:11:03 | *** deadpool_ has joined #openmrs |
| 09:14:09 | *** deadpool has quit IRC |
| 09:14:10 | *** hari_ has joined #openmrs |
| 09:16:07 | *** lh has quit IRC |
| 09:16:31 | *** hemanth_92 has joined #openmrs |
| 09:17:33 | *** deadpool_ has quit IRC |
| 09:17:33 | *** hemanth_92 has quit IRC |
| 09:30:28 | *** deadpool_ has joined #openmrs |
| 09:30:49 | *** dewmal_ has quit IRC |
| 09:31:10 | *** dewmal has quit IRC |
| 09:56:09 | *** opieng has joined #openmrs |
| 09:57:51 | *** rafa has joined #openmrs |
| 09:58:01 | *** ChanServ sets mode: +v rafa |
| 10:00:58 | *** opieng has quit IRC |
| 10:01:08 | *** dewmal_ has joined #openmrs |
| 10:01:08 | *** dewmal has joined #openmrs |
| 10:11:57 | *** finbrein has joined #openmrs |
| 10:16:41 | *** pulasthi7 has quit IRC |
| 10:21:20 | *** snoppy has joined #openmrs |
| 10:21:28 | *** dkayiwa has joined #openmrs |
| 10:22:48 | *** dewmal_ has quit IRC |
| 10:22:48 | *** dewmal has quit IRC |
| 10:43:01 | *** opieng has joined #openmrs |
| 10:46:59 | *** opieng has joined #openmrs |
| 10:47:20 | *** opieng has quit IRC |
| 10:52:04 | <dkayiwa> hi rafa |
| 10:52:32 | <dkayiwa> rafa: standalone's demo mode still takes you through the database setup to run a changeset |
| 10:52:40 | <dkayiwa> rafa: do you think we should fix that? |
| 10:52:58 | <dkayiwa> rafa: and the changeset is: Increase size of drug name column to 255 characters Modify data type jkeiper |
| 10:53:42 | <rafa> dkayiwa: hi |
| 10:54:18 | <rafa> dkayiwa: hmmm yes it should be done while building the standalone... |
| 10:54:31 | <dkayiwa> rafa: what could be missing? |
| 10:55:18 | <rafa> dkayiwa: maybe we're using a wrong version of the jars in standalone/pom.xml |
| 10:55:31 | <dkayiwa> rafa: ok |
| 10:56:48 | <rafa> dkayiwa: we're using a released version |
| 10:57:00 | <dkayiwa> rafa: ok |
| 10:58:10 | <rafa> dkayiwa: if you install the latest 1.9.0-SNAPSHOT to your local repo |
| 10:58:18 | *** opieng has joined #openmrs |
| 10:58:20 | <rafa> dkayiwa: then you should be able to build the standalone against it |
| 10:58:22 | <dkayiwa> rafa: ok |
| 10:58:29 | *** opieng has quit IRC |
| 10:58:33 | <rafa> dkayiwa: giving -Dopenmrs.version=1.9.0-SNAPSHOT |
| 10:58:43 | <dkayiwa> rafa: ok let me do so. thanks :) |
| 10:58:48 | *** opieng has joined #openmrs |
| 10:59:29 | *** opieng has quit IRC |
| 11:02:15 | <harshadura> dkayiwa : can u jz giv me a hint, how to make sure "there are error messages on the session" when writing a test case? or a sample code snippet if possible. thanks |
| 11:02:46 | <dkayiwa> harshadura: have you taken a look at the existing controller unit tests? |
| 11:03:06 | <harshadura> yes dkayiwa, I looked others too |
| 11:03:37 | <dkayiwa> harshadura: can you pastebin what you have and i look at it? |
| 11:03:54 | <harshadura> okay dkayiwa sure |
| 11:05:40 | <harshadura> dkayiwa : http://pastebin.com/7Lz8nqMm |
| 11:05:52 | *** deadpool has joined #openmrs |
| 11:05:57 | <dkayiwa> ok |
| 11:07:54 | *** deadpool_ has quit IRC |
| 11:17:51 | <harshadura> dkayiwa, any hints of doing this |
| 11:22:02 | <dkayiwa> harshadura: can you sent just for one method? |
| 11:22:42 | <harshadura> dkayiwa, sorry didn got your question? |
| 11:23:12 | <dkayiwa> harshadura: pastebin only the unit test method you are trying to write |
| 11:23:28 | <harshadura> dkayiwa, okay sure |
| 11:24:32 | <harshadura> dkayiwa, http://pastebin.com/FdztziCy |
| 11:25:52 | *** chopin_ has quit IRC |
| 11:26:41 | *** deadpool has quit IRC |
| 11:30:33 | *** james_regen has joined #openmrs |
| 11:30:33 | *** ChanServ sets mode: +v james_regen |
| 11:31:41 | *** hari_ has quit IRC |
| 11:34:05 | <harshadura> dkayiwa : you still thr |
| 11:35:40 | *** downey has joined #openmrs |
| 11:35:40 | *** OpenMRSBot sets mode: +o downey |
| 11:35:40 | *** ChanServ sets mode: +o downey |
| 11:38:30 | *** opieng has joined #openmrs |
| 11:39:36 | <dkayiwa> harshadura: does this unit test fail? |
| 11:40:56 | <harshadura> no dkayiwa it passes, Ben told to check for session errors also |
| 11:44:03 | <dkayiwa> harshadura: does the controller put the error in the session? |
| 11:45:07 | *** opieng has joined #openmrs |
| 11:45:37 | *** opieng_ has joined #openmrs |
| 11:46:01 | *** opieng_ has joined #openmrs |
| 11:46:14 | <downey> Hi opieng_ and welcome to the #openmrs IRC channel. |
| 11:46:28 | <harshadura> dkayiwa, I am not exactly sure abt that. but I think it doesnt, Is thr a way to check for session errors? can you provide me a sample code link, thanks |
| 11:47:13 | *** opieng_ has quit IRC |
| 11:48:02 | <dkayiwa> harshadura: if the controller does not put the error in the session, then i do not see why you need a unit test for it |
| 11:54:55 | <harshadura> dkayiwa : here's the main Controller can u jz confirm? http://pastebin.com/D6i6RDdf |
| 12:12:55 | <harshadura> hi rafa, u thr |
| 12:13:02 | <rafa> harshadura: hi |
| 12:14:00 | *** wyclif has quit IRC |
| 12:18:15 | <harshadura> rafa, I am working on this ticket : https://tickets.openmrs.org/browse/TRUNK-2751 , I have fixed the error in the controller class, after that Ben told me to write a test case for that, I hv written the Test case, but it tends to fail. can u jz tell me whats wrong with that test case. I referred LocationFormControllerTest to write that Test Case cause it isnt spring 3 annotated one. |
| 12:18:39 | *** chopin_ has joined #openmrs |
| 12:19:57 | <chopin_> hey |
| 12:20:03 | *** chopin_ is now known as jkeiper |
| 12:20:11 | *** ChanServ sets mode: +v jkeiper |
| 12:22:02 | <harshadura> rafa : here's the test case I hv written : http://pastebin.com/LsdUS4mh |
| 12:22:05 | <rafa> harshadura: what is the error message that you get? |
| 12:22:19 | *** cosmin has joined #openmrs |
| 12:23:23 | <harshadura> rafa, its a NPE heres the Error log : http://pastebin.com/0d05ahGi |
| 12:25:36 | *** mathiasl_ has quit IRC |
| 12:25:41 | *** bwolfe has joined #openmrs |
| 12:25:41 | *** ChanServ sets mode: +o bwolfe |
| 12:27:49 | <rafa> harshadura: the way to get BindingResult is http://stackoverflow.com/questions/3886065/spring-3-web-request-interceptor-how-do-i-get-bindingresult |
| 12:28:07 | <rafa> harshadura: it's null in your case thus the NPE |
| 12:29:01 | *** cosmin has quit IRC |
| 12:29:10 | *** mathiaslin has joined #openmrs |
| 12:29:47 | <rafa> harshadura: you can test if a birthdate was persisted correctly as well by getting the person via Context.getPersonService().getPersonById(100)... It's even better this way. |
| 12:30:46 | <harshadura> rafa, thanks lot for the hint, I will do in that manner. |
| 12:31:02 | <rafa> harshadura: you're welcome |
| 12:31:35 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Release Testing Helper 1.1-SNAPSHOT uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=releasetestinghelper&version=&1.1-SNAPSHOT> |
| 12:33:23 | *** mathiaslin has quit IRC |
| 12:39:39 | <bwolfe> who released a snapshot of RTH ?? |
| 12:40:51 | <bwolfe> oh, looks like it was dkayiwa. but he has subsequently fixed it, it seems |
| 12:40:52 | <bwolfe> :-) |
| 12:41:01 | <dkayiwa> bwolfe: i had accidentally done so. but deleted it the next minute :( |
| 12:41:30 | <downey> Hi bwolfe and welcome to the #openmrs IRC channel. |
| 12:41:43 | <bwolfe> ha |
| 12:41:46 | <bwolfe> thanks downeybot |
| 12:41:50 | <dkayiwa> bwolfe: the maven release plugin does not change the version in the config.xml file |
| 12:42:01 | <rafa> hi bwolfe |
| 12:42:06 | <bwolfe> dkayiwa, it does if its set up right |
| 12:42:21 | <dkayiwa> bwolfe: how do we set it up right ? |
| 12:42:27 | <bwolfe> someone changed the RTH one to not reference the maven variable (might have been me) |
| 12:42:31 | <dkayiwa> bwolfe: by the way welcome back :) |
| 12:42:39 | <bwolfe> dkayiwa, look at the config of all the other mavenized modules |
| 12:42:51 | <dkayiwa> bwolfe: oh i seeeeee |
| 12:51:44 | <jkeiper> dkayiwa, questions for you about xforms |
| 12:51:55 | <dkayiwa> ok chopin :) |
| 12:52:03 | <jkeiper> dkayiwa, does xforms create a new person if it does not exist, before submitting the HL7? |
| 12:52:41 | <dkayiwa> jkeiper: yes if the patient identifier is specified |
| 12:53:02 | <jkeiper> dkayiwa, so the patient identifier is the primary means of finding the patient in the system? can it be done via uuid as well? |
| 12:53:28 | <dkayiwa> jkeiper: the primary means has been the database patientId integer |
| 12:53:44 | <dkayiwa> jkeiper: the patient identifier was only looked at if the patientId was missing |
| 12:53:57 | <jkeiper> dkayiwa, if that does not exist then ... okay. have you considered using uuid as well? |
| 12:54:13 | <dkayiwa> jkeiper: just never thought of it |
| 12:54:14 | <jkeiper> dkayiwa, reason for it is that i must process forms designated for one server on another :-( |
| 12:54:33 | <jkeiper> dkayiwa, also do you refer to the form by formId?. .. i assume that is just passed along to the HL7 processor ... |
| 12:54:54 | <dkayiwa> jkeiper: but should be a very quick fix. as long as you tell me the name of the xml node to look into for the uuid |
| 12:55:09 | <dkayiwa> jkeiper: yes by the integer formId |
| 12:55:14 | <jkeiper> dkayiwa, ok i'll consider it as a possible solution :-D |
| 12:55:24 | <dkayiwa> jkeiper: ok :) |
| 12:55:38 | <jkeiper> dkayiwa, do you also add attributes, addresses, names to a patient if they do not exist during your pre-processing? |
| 12:56:05 | <dkayiwa> jkeiper: yes when creating the new patient |
| 12:56:18 | <jkeiper> dkayiwa, if the patient already exists, do you? |
| 12:56:29 | <dkayiwa> jkeiper: in that case no |
| 12:56:40 | <jkeiper> dkayiwa, ok ... a few more questions ... |
| 12:56:46 | <dkayiwa> jkeiper: ok |
| 12:56:55 | <jkeiper> dkayiwa, the creator of new patients, etc ... is that the currently-logged-in user? |
| 12:57:02 | <jkeiper> dkayiwa, or can that be specified in the form? |
| 12:57:23 | <dkayiwa> jkeiper: i get that from the submitted xml |
| 12:57:44 | <dkayiwa> jkeiper: so whoever submits the xml is responsible for that |
| 12:57:45 | <jkeiper> dkayiwa, ah okay ... i should look in an example to find the node for that |
| 12:58:03 | <jkeiper> dkayiwa, everything HCT submits comes up as Super User |
| 12:58:05 | <jkeiper> !!! |
| 12:58:06 | <OpenMRSBot> jkeiper: Error: "!!" is not a valid command. |
| 12:58:10 | <dkayiwa> jkeiper: currently when i get an xml submission, i use the currently logged on user |
| 12:58:13 | <jkeiper> OpenMRSBot, thanks. |
| 12:58:13 | <OpenMRSBot> jkeiper: Error: "thanks." is not a valid command. |
| 12:58:17 | <jkeiper> OpenMRSBot, okay. |
| 12:58:18 | <OpenMRSBot> jkeiper: Error: "okay." is not a valid command. |
| 12:58:20 | <jkeiper> OpenMRSBot, whatev. |
| 12:58:21 | <OpenMRSBot> jkeiper: Error: "whatev." is not a valid command. |
| 12:59:00 | <dkayiwa> jkeiper: that is because they login as so to submit the xml |
| 12:59:16 | <jkeiper> dkayiwa, so if the XML is submitted by a scheduled task ... it is daemon or super user |
| 12:59:43 | <jkeiper> dkayiwa, there is no node for storing the person who entered the data? |
| 12:59:51 | <jkeiper> i believe there is for formentry |
| 12:59:58 | <dkayiwa> jkeiper: an example if when you dump the xml in the xforms queue on the file system, i use whatever user you put in |
| 13:00:26 | <jkeiper> dkayiwa, sorry, i'm getting confused ... there _is_ a node to hold the enterer's userId? |
| 13:00:29 | <dkayiwa> jkeiper: xforms is 99% like formentry when it comes to form processing |
| 13:01:06 | <jkeiper> dkayiwa, hahaha okay ... i think HCT just forgot to put that data into the form. |
| 13:01:10 | * jkeiper is fixing a lot of stuff |
| 13:01:16 | <jkeiper> gotta run, thanks dkayiwa |
| 13:01:17 | <dkayiwa> jkeiper: formentry, and xforms use enterer |
| 13:01:22 | <dkayiwa> jkeiper: cool |
| 13:01:44 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Release Testing Helper 1.2 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=releasetestinghelper&version=&1.2> |
| 13:02:54 | *** mseaton has joined #openmrs |
| 13:03:01 | *** ChanServ sets mode: +v mseaton |
| 13:03:04 | *** jkeiper has quit IRC |
| 13:05:33 | *** wyclif has joined #openmrs |
| 13:12:39 | *** Felipo has joined #openmrs |
| 13:15:54 | *** MarkG has joined #openmrs |
| 13:18:46 | *** Felipo has quit IRC |
| 13:20:10 | *** sgithens has joined #openmrs |
| 13:22:05 | *** jmiranda has joined #openmrs |
| 13:23:18 | *** jkeiper has joined #openmrs |
| 13:26:52 | *** sgithens has quit IRC |
| 13:27:21 | *** mathiaslin has joined #openmrs |
| 13:27:38 | *** Felipo has joined #openmrs |
| 13:28:45 | *** mathiaslin has quit IRC |
| 13:34:52 | *** opieng_ has joined #openmrs |
| 13:35:11 | *** bryq has joined #openmrs |
| 13:35:11 | *** ChanServ sets mode: +v bryq |
| 13:37:28 | *** opieng has joined #openmrs |
| 13:46:16 | *** maurya has joined #openmrs |
| 13:47:30 | *** sgithens has joined #openmrs |
| 13:48:46 | *** goutham has quit IRC |
| 13:52:31 | *** Felipo has quit IRC |
| 13:59:10 | *** sgithens has quit IRC |
| 13:59:44 | *** robbyoconnor has quit IRC |
| 14:01:47 | *** mathiaslin has joined #openmrs |
| 14:06:40 | *** sgithens has joined #openmrs |
| 14:08:13 | *** sai has joined #openmrs |
| 14:08:20 | <downey> Hi sai and welcome to the #openmrs IRC channel. |
| 14:08:30 | *** sai has quit IRC |
| 14:13:57 | *** saimanohar has joined #openmrs |
| 14:14:09 | *** jkeiper has quit IRC |
| 14:14:34 | *** sgithens has quit IRC |
| 14:15:27 | *** dileepsisila has joined #openmrs |
| 14:15:57 | *** Ashoras has joined #openmrs |
| 14:17:18 | <dileepsisila> bwolfe: hi |
| 14:18:46 | <bwolfe> hi dileepsisila |
| 14:19:35 | <dileepsisila> bwolfe: i sent a proposal for inpage localization project |
| 14:20:59 | <bwolfe> dileepsisila, ok, I'm not actually the primary mentor for that anymore. :-) |
| 14:21:41 | *** applecool has joined #openmrs |
| 14:22:46 | <dileepsisila> can i get the Mr. rafal nick name |
| 14:22:46 | <dileepsisila> or mail adrress |
| 14:23:02 | <bwolfe> dileepsisila, rafa is the new primary mentor |
| 14:28:25 | <rafa> bwolfe, dileepsisila: actually I'm a backup mentor for that project. |
| 14:29:50 | *** nribeka has joined #openmrs |
| 14:29:50 | *** ChanServ sets mode: +v nribeka |
| 14:32:24 | <nribeka> mseaton, can i give you another pastebin :P |
| 14:32:39 | <mseaton> nribeka sure. |
| 14:32:49 | <nribeka> sorry took me 2 days longer, sick on monday and need to do other project yesterday :D |
| 14:35:06 | <mseaton> nribeka: why don't i see any tickets assigned to you in the reporting module? |
| 14:35:26 | *** dileepsisila has quit IRC |
| 14:35:26 | <mseaton> are you doing this work for a particular reporting ticket we can create? |
| 14:35:59 | <nribeka> http://pastebin.com/GqMWiTnE |
| 14:36:04 | <nribeka> i didn't create any ticket :( |
| 14:36:12 | <nribeka> we can create some probably hahahaha ... |
| 14:36:40 | *** dileepsisila has joined #openmrs |
| 14:37:02 | <nribeka> mseaton, the base evaluation will be in: BaseObsQueryEvaluator |
| 14:37:33 | <mseaton> nribeka: do you want to create a ticket that encapsulates what you are doing here, then attach this patch to it as a proposed full/partial solution? |
| 14:38:05 | <nribeka> ok mseaton |
| 14:38:53 | *** lh has joined #openmrs |
| 14:38:53 | *** lh has joined #openmrs |
| 14:42:04 | <nribeka> done mseaton |
| 14:42:17 | <nribeka> !ticket REPORT-371 |
| 14:42:18 | <OpenMRSBot> nribeka: [#REPORT-371] Create ObsDataSetDefinition along with Obss Data definition and Obss Query - OpenMRS JIRA - https://tickets.openmrs.org/browse/REPORT-371 |
| 14:51:19 | *** dkayiwa has quit IRC |
| 14:51:59 | *** dkayiwa has joined #openmrs |
| 14:52:19 | <wyclif> hi MarkG |
| 14:53:09 | <wyclif> MarkG, seen your comment for HTML-71 |
| 14:53:29 | <wyclif> MarkG, how about if i add a global property and you leave it in there |
| 14:53:51 | <wyclif> wyclif, i can do this in the next couple of minutes |
| 14:55:14 | <mseaton> nribeka: thanks, will look at it |
| 14:55:14 | <MarkG> wyclif: i' |
| 14:55:58 | <MarkG> wyclif: i'm going to pull it out, but feel create a fork and push it up there and then we can work through it |
| 14:58:36 | <MarkG> wyclif: it wouldn't normally be a big deal, but i just want to do a release sometime in the next couple or hours and i don't have time to do a review right now... |
| 14:58:46 | <nribeka> ok mseaton. the query is unit tested along with the obs dataset definition |
| 14:58:53 | <MarkG> wyclif: if it wasn't for the release, i'd just leave it in there for now |
| 14:58:55 | <nribeka> you can change the ticket title too hahaha ... |
| 14:59:28 | <wyclif> MarkG, i think the addition is very straight forward |
| 15:00:14 | <wyclif> MarkG, the changes are small, even though crucible is making it look like it is much |
| 15:00:41 | <wyclif> MarkG, when you move over code, crucible makes appear like you deleted lines and added new code |
| 15:01:00 | <wyclif> MarkG, i can add the global property to make it configurable |
| 15:01:07 | <MarkG> wyclif: it is straightforward, it is not like i think your changes are bad, i just don't have time to look at it right now... |
| 15:01:30 | <wyclif> MarkG, am not so good with git to start dealing with repositories |
| 15:01:45 | <wyclif> MarkG, ok |
| 15:03:05 | <wyclif> MarkG, you can revert the change before releasing, and put it back after |
| 15:04:11 | *** saimanohar has quit IRC |
| 15:04:18 | *** pushkar has joined #openmrs |
| 15:04:32 | <djazayeri> bwolfe: are you/we talking to jembi now? |
| 15:04:40 | <MarkG> wyclif: it is not very hard, and you should learn... :) |
| 15:05:00 | <wyclif> MarkG, will try |
| 15:05:18 | *** r4friedman has joined #openmrs |
| 15:05:21 | <MarkG> wyclif: i have to go to a meeting now, but when i get back, i will revert your changed but also figure out what the functionality should be and comment on the ticket (i think i agree with Darius) |
| 15:05:27 | *** r4friedman is now known as r_friedman |
| 15:06:29 | <MarkG> wyclif: then you can make your changes, push them up to your remote repo, and i can pull them into the module... |
| 15:06:48 | <MarkG> wyclif: i don't mean to push this off for days or anything... |
| 15:06:53 | <djazayeri> wyclif: The quick description of how to do what Mark is saying is: |
| 15:07:00 | <djazayeri> 1. Create yourself an account on github |
| 15:07:31 | <djazayeri> 2. go to github.com/openmrs/openmrs-module-htmlformentry and click fork, (to fork the main repo to *your* git repo) |
| 15:07:56 | <djazayeri> 3. you would then clone your own fork to your local machine |
| 15:08:00 | <djazayeri> 4. (write the code) |
| 15:08:10 | <djazayeri> 5. (commit the code) |
| 15:08:24 | <djazayeri> 6. push the code back up to *your* git repo |
| 15:08:58 | <bwolfe> djazayeri, I am talking now. you want in? |
| 15:09:05 | <djazayeri> 7. From github.com/wyclif/openmrs-module-htmlformentry, initiate a "pull request" (which basically tells mark "please pull this" |
| 15:09:14 | <djazayeri> bwolfe: I'm interested in lurking |
| 15:09:45 | <djazayeri> wyclif: so it's actually only an extra 5 minutes or so of work |
| 15:09:48 | *** applecool has quit IRC |
| 15:10:22 | *** maurya_ has joined #openmrs |
| 15:11:13 | <wyclif> djazayeri, thanks |
| 15:13:48 | *** bryq has quit IRC |
| 15:14:25 | <djazayeri> downey: I can't do "release" from JIRA. I get "authentication failed" |
| 15:15:53 | *** mvorobey has joined #openmrs |
| 15:17:41 | <mvorobey> hi all |
| 15:21:36 | *** maurya has quit IRC |
| 15:22:55 | *** wyclif has quit IRC |
| 15:22:56 | *** pushkar has quit IRC |
| 15:24:08 | *** wyclif has joined #openmrs |
| 15:24:22 | *** bryq has joined #openmrs |
| 15:24:22 | *** ChanServ sets mode: +v bryq |
| 15:26:36 | <djazayeri> hi |
| 15:32:22 | *** snoppy has quit IRC |
| 15:33:12 | *** pulasthi7 has joined #openmrs |
| 15:36:07 | *** Rahul has joined #openmrs |
| 15:37:39 | <mvorobey> mseaton, hi Mike :) |
| 15:40:08 | *** jmiranda has quit IRC |
| 15:46:14 | *** suranga has joined #openmrs |
| 15:46:14 | *** ChanServ sets mode: +v suranga |
| 15:46:40 | <suranga> yay ! bwolfe is back !!!!!!!!!!!! |
| 15:47:02 | <suranga> bwolfe, umm... heard u had a rather bad Easter :-( |
| 15:47:39 | *** MarkG1 has joined #openmrs |
| 15:48:31 | <bwolfe> suranga, yeah, spent easter on morphine :-) |
| 15:48:55 | <suranga> bwolfe, how do you feel now ? |
| 15:49:05 | <suranga> must have been a terrible experiance... |
| 15:49:36 | *** dileepsisila has quit IRC |
| 15:49:40 | <suranga> IRC was very lonely without you and dkayiwa ... everyone was asking djazayeri allll the questions :P |
| 15:50:09 | *** MarkG has quit IRC |
| 15:51:52 | <bwolfe> poor djazayeri |
| 15:52:33 | <bwolfe> suranga, wasn't that bad really. just a lot of stomach pain |
| 15:53:43 | <maurya_> hi all |
| 15:54:07 | <maurya_> any suggestions how i can get to contact sgithens |
| 15:59:40 | <MarkG1> djazayeri: thanks for giving wyclif the lowdown |
| 16:00:10 | <djazayeri> MarkG1: we should do a screencast about it |
| 16:00:28 | <MarkG1> wyclif: i'm back from my meeting... i just commented on the ticket on what do you... thanks for doing this, and let me know if you encounter any problems with doing the fork... |
| 16:00:33 | <djazayeri> I will, once you and sgithens have got the process well-documented |
| 16:00:52 | *** applecool has joined #openmrs |
| 16:01:04 | <MarkG1> djazayeri: i don't mind doing a screencast... |
| 16:01:06 | <applecool> Hi Rahul |
| 16:01:14 | <applecool> sorry Rahul |
| 16:01:19 | <applecool> HI rafa |
| 16:01:29 | <MarkG1> djazayeri: i also figure there must be a good example of it already somewhere... it seems pretty common |
| 16:01:53 | <djazayeri> MarkG1: for sure, but it's always nice to have the precise workflow we want for OpenMRS documented |
| 16:02:00 | <MarkG1> fair enough... |
| 16:02:07 | <rafa> hi applecool |
| 16:02:20 | <Rahul> hi suranga |
| 16:02:21 | <applecool> this is harsha |
| 16:02:37 | <applecool> just read your comment |
| 16:02:55 | <applecool> i need to provide the timepline and the goals |
| 16:02:58 | <applecool> right |
| 16:03:07 | <suranga> hi Rahul |
| 16:03:09 | <rafa> right |
| 16:07:13 | <mathiaslin> Where can I find an overview of the possible parameter I can use in the REST web services API? For example, that I could use 'q' as the query parameter for a patient. I can't find anything in the wiki (i.e. https://wiki.openmrs.org/display/docs/REST+Web+Service+Resources) |
| 16:07:14 | <OpenMRSBot> <http://ln-s.net/8z-a> (at wiki.openmrs.org) |
| 16:10:36 | *** dileepsisila has joined #openmrs |
| 16:12:05 | <Rahul> suranga: i want to discuss about UI mockups |
| 16:22:06 | *** dileepsisila has quit IRC |
| 16:24:43 | *** Ashoras has quit IRC |
| 16:26:35 | *** jmiranda has joined #openmrs |
| 16:27:17 | *** dileepsisila has joined #openmrs |
| 16:29:36 | *** applecool has quit IRC |
| 16:29:36 | *** maurya_ has quit IRC |
| 16:30:03 | *** bryq has quit IRC |
| 16:31:12 | *** maurya has joined #openmrs |
| 16:32:05 | <maurya> !sgithens |
| 16:32:05 | <OpenMRSBot> maurya: Error: "sgithens" is not a valid command. |
| 16:33:03 | * finbrein "IS ON 'CLOUD' NINE ;)" |
| 16:46:41 | *** applecool has joined #openmrs |
| 16:57:15 | *** bwolfe has quit IRC |
| 16:57:19 | *** bwolfe_ has joined #openmrs |
| 16:57:19 | *** ChanServ sets mode: +o bwolfe_ |
| 16:59:36 | *** dileepsisila has quit IRC |
| 17:01:14 | *** jkeiper has joined #openmrs |
| 17:01:33 | <wyclif> MarkG1, ok |
| 17:06:32 | *** Rahul has quit IRC |
| 17:06:38 | *** ChanServ sets mode: +o jmiranda |
| 17:06:54 | *** bwolfe_ is now known as bwolfe |
| 17:07:04 | <bwolfe> !refer maurya [seen sgithens] |
| 17:07:04 | * OpenMRSBot refers maurya to sgithens was last seen in #openmrs 1 day, 1 hour, 12 minutes, and 28 seconds ago: <sgithens> err, MarkG |
| 17:07:15 | <jmiranda> finbrein, i just created the new branch at http://svn.openmrs.org/openmrs-modules/birtmodule/branches/3.7.2/ |
| 17:08:20 | <jmiranda> finbrein, i need to make some changes to the included birt libraries but feel free to download the source now |
| 17:08:45 | <jmiranda> this will work with birt runtime 3.7.2, so download that version if you haven't already |
| 17:10:17 | *** Rahul has joined #openmrs |
| 17:10:39 | *** sgithens has joined #openmrs |
| 17:12:20 | <MarkG1> wyclif: how it is going? i think i should be able to apply your changes back to the main branch after i get the release out... i'm struggling a bit with maven right now though... :) |
| 17:12:52 | <bwolfe> MarkG1, struggling how so? |
| 17:13:05 | <bwolfe> MarkG1, are you using the release:prepare maven archetype? |
| 17:13:13 | <bwolfe> https://wiki.openmrs.org/display/docs/Module+Tagging+and+Releasing |
| 17:13:26 | *** maurya_ has joined #openmrs |
| 17:13:31 | <maurya_> hi sgithens |
| 17:13:46 | <wyclif> MarkG1, ok |
| 17:13:46 | *** maurya has quit IRC |
| 17:13:52 | <MarkG1> bwolfe: yeah, and it is hanging when it tries to download something from mavenrepo... or at least it appers to be hanging... |
| 17:14:12 | *** jmiranda has quit IRC |
| 17:14:17 | <MarkG1> bwolfe: i'm going to try it another time before i start to complain, however... :) |
| 17:14:24 | <MarkG1> bwolfe: could just be our network or something |
| 17:14:50 | <djazayeri> mathiaslin: the wiki page you link to has ?q listed there on the patient resource |
| 17:15:11 | <bwolfe> MarkG1, where is is downloading from? |
| 17:15:12 | <djazayeri> mathiaslin: what else are you looking for? |
| 17:15:59 | <djazayeri> MarkG1: my recollection is that the first time each day you run the full build scripts for HFE, it downloads a 40mb war file from somewhere |
| 17:16:29 | <MarkG1> i've already run clean package several times... |
| 17:17:01 | <MarkG1> djazayeri: i think we fixed the 40mb thing by moving the release-tests into their own profile |
| 17:17:05 | <djazayeri> rafa: for REPORT-367 (your blocker) where are you doing this from? |
| 17:17:20 | <djazayeri> I mean are you adding a DSD to a Report Definition? Or crateing a new DSD? |
| 17:18:07 | <sgithens> maurya_ Hi! |
| 17:18:19 | <sgithens> Just got your email, will go check on the updated prop now |
| 17:18:26 | <maurya_> ok |
| 17:18:34 | <rafa> djazayeri: administration -> report definitions -> edit icon in the right column -> [+] New Dataset Definition |
| 17:18:38 | <mathiaslin> djazayeri: i thought the web services would allow a search within the identifiers (UUID, ID, etc.) as well, not just firstname, lastname, as in the search form in the OMRS web client |
| 17:18:42 | <djazayeri> rafa: okay, it works for me |
| 17:18:51 | <mathiaslin> but i guess it's not the case, I already figured it out. thanks |
| 17:19:02 | <djazayeri> mathiaslin: the q delegates to the underlying PatientService call |
| 17:19:20 | <djazayeri> mathiaslin: it will also search by identifier (that's an exact match, not a partial one) |
| 17:19:30 | <djazayeri> not by primary key id though |
| 17:19:30 | <rafa> djazayeri: ok, thanks |
| 17:19:34 | <mathiaslin> djazayeri: yes, i meant partial though |
| 17:21:02 | <MarkG1> maven is working for me now... i think it may have been a network error here... sorry i wasn |
| 17:21:33 | <finbrein> Hi jmiranda, I will, I'm going out. Will be right back |
| 17:21:40 | <MarkG1> that was just meant as an aside, not a public complaint about maven... :) |
| 17:30:40 | <suranga> hi bwolfe , im about to start modifying the web services rest module.. I need to modify the response fo get encounterbyUuid. I found the encountercontroller that fetched encounter by patient, but have failed the ones that lets us retrive by uuid.. |
| 17:31:04 | <suranga> mm... bwolfe .. any chance of pointing me to where it is :-) |
| 17:31:57 | <bwolfe> suranga, probably in the parent methods |
| 17:32:05 | <bwolfe> there is a lot of inheritance used in the restws module |
| 17:32:16 | <bwolfe> suranga, what is being returned by the method now? |
| 17:32:44 | <suranga> mm... bwolfe I found the controller class that returns enciounters by patients |
| 17:32:52 | <suranga> (thats in the encountercontroller) |
| 17:33:12 | <suranga> but have failed to find anywhere where the getencounterbyuuid gets triggerd |
| 17:33:26 | <suranga> mm.. do u mean it comes from a class in the core itself ? :-) |
| 17:34:35 | <bwolfe> no |
| 17:34:42 | <bwolfe> look at the parent class to EncounterController |
| 17:36:19 | <suranga> bwolfe, u r right.. I found it in the basecrudController :-) |
| 17:36:22 | <suranga> bwolfe, :-) |
| 17:36:51 | <suranga> bwolfe, thanks for pointing it out.. let me see how far I can go... |
| 17:39:11 | *** applecool has quit IRC |
| 17:40:51 | *** maurya_ has quit IRC |
| 17:42:01 | <MarkG1> djazayeri: you got the maven release plugin to work for you? did you configure your github username and password in your settings file? |
| 17:42:20 | <bwolfe> suranga, what do you need to modify it to?? |
| 17:42:46 | <suranga> bwolfe, unfortunately, the REST module returns stuff as JSON objects |
| 17:43:00 | <suranga> bwolfe, I need to convert it to return Hl7 instead... |
| 17:43:10 | <bwolfe> suranga, terrible idea |
| 17:43:16 | <bwolfe> :-) |
| 17:43:19 | <suranga> im rather wondering how I can represent an enormous encounter in HL7 |
| 17:43:37 | <bwolfe> an encounter in hl7 is just an oru_or1 |
| 17:44:12 | <bwolfe> you should instead have a new url that you can fetch a patients encounter(s) that is under the /hl7 part of the url |
| 17:44:19 | <bwolfe> I chatted with ryan/wayne about it earlier today |
| 17:44:52 | <suranga> aha ! bwolfe they said that willl talk to you ;P |
| 17:45:27 | <suranga> bwolfe, mm.. so a new url - this also fetches encounters by uuid, is it ? |
| 17:46:09 | <mathiaslin> I try to build the webservices.rest module with mvn, and getting error: the path '[..]/webservices.rest' appears to be part of a Subversion 1.7 or greater', however 'svn help' tells me i have the svn client 1.7.4 |
| 17:46:50 | <mathiaslin> only 'Rest Web Services OMOD' fails with that though |
| 17:47:46 | <sgithens> If I want to test cancelling a report, what's the easiest way to make a test report that is going to take at least a couple minutes to run, assuming I just have the demo data from a standard install? |
| 17:47:55 | <downey> !seen sunbiz |
| 17:47:55 | <OpenMRSBot> downey: sunbiz was last seen in #openmrs 3 weeks, 1 day, 3 hours, 43 minutes, and 30 seconds ago: <sunbiz> will respond sometime later |
| 17:48:19 | <downey> guess that's an appropriate most recent comment :) |
| 17:50:09 | *** bwolfe has quit IRC |
| 17:50:40 | *** bwolfe has joined #openmrs |
| 17:50:40 | *** ChanServ sets mode: +o bwolfe |
| 17:51:53 | <bwolfe> sgithens, can you do a "sql" report that does some sort of sleep() call ? |
| 17:52:15 | *** downey has quit IRC |
| 17:52:24 | *** downey has joined #openmrs |
| 17:52:24 | *** OpenMRSBot sets mode: +o downey |
| 17:52:24 | *** ChanServ sets mode: +o downey |
| 17:52:43 | <sgithens> bwolfe: I'll try that |
| 17:52:58 | <bwolfe> suranga, the url would be something like /ws/v1/hl7/encounter?patient=uuid&encounter=uuid&limit=X&dateStart=Y&dateEnd=Z |
| 17:53:07 | <bwolfe> each of those params would be optional |
| 17:53:21 | <djazayeri> MarkG1: maven release:prepare with git just worked for me IIRC. I didn't change anything |
| 17:53:32 | <djazayeri> maybe I happened to have the right credentials in my .settings already? |
| 17:53:43 | <suranga> mm... bwolfe if I give the uuid, why do I need to specify the start and end date ? |
| 17:53:52 | <suranga> or, right, sorry |
| 17:54:19 | <suranga> bwolfe, actually, what does the datestart and dateend refer to ? :-) |
| 17:54:46 | <djazayeri> MarkG1: nah, actually I have nothing git-related in my .m2/settings file |
| 17:55:04 | <djazayeri> but perhaps my git settings (wherever those are) have it |
| 17:55:22 | <djazayeri> IIRC github gave me some commands for where to set those |
| 17:55:25 | <MarkG1> djazayeri: it hangs for me when it tried to do a push to the remote repo... however, this makes sense when i looked and saw that in my settings referred to the server as github.org instead of github.com. |
| 17:56:15 | <MarkG1> it is easy enough for me to finish manually... i will modify my settings and then see if it works next time... |
| 17:57:23 | *** Rahul has joined #openmrs |
| 18:12:16 | <dkayiwa> hi bwolfe |
| 18:12:51 | <bwolfe> hi dkayiwa |
| 18:12:52 | <dkayiwa> hi downey |
| 18:13:44 | <dkayiwa> bwolfe: downey sorry just got an answer for what i was about to ask :) |
| 18:14:00 | <bwolfe> glad I could help. :-) |
| 18:14:18 | <dkayiwa> bwolfe: :D :D :D |
| 18:15:15 | <downey> dkayiwa: :D |
| 18:15:17 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: HTML Form Entry 1.9.2 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=htmlformentry&version=&1.9.2> |
| 18:18:04 | *** bryq has joined #openmrs |
| 18:18:04 | *** ChanServ sets mode: +v bryq |
| 18:26:01 | *** jmiranda has joined #openmrs |
| 18:26:10 | *** ChanServ sets mode: +o jmiranda |
| 18:35:42 | <MarkG1> wyclif: okay, i got the release out the door and i think i successfully reapplied your changes to the master branch |
| 18:36:43 | <wyclif> MarkG1, cool |
| 18:36:44 | <MarkG1> what you can do now is go to github and click on the "fork" button to fork openmrs/openmrs-module-htmlformentry to your own local wyclif/openmrs-module-htmlformentry |
| 18:37:07 | <wyclif> MarkG1, had you disabled forking? |
| 18:37:19 | <MarkG1> wyclif: i don't think so, does it not let you? |
| 18:37:29 | <wyclif> MarkG1, actually i managed to fork but couldn't clone |
| 18:37:48 | <wyclif> MarkG1, i was getting a strange error about pack-not found and i gave up |
| 18:39:08 | <MarkG1> if you still have the master branch cloned, i think what you want to do is to add your new forked branch as a remote... let me try it out here and let you know if/how it works |
| 18:40:27 | *** jkeiper has quit IRC |
| 18:42:24 | <MarkG1> wyclif: are you using the git bash? |
| 18:42:56 | <wyclif> was doing it from eclipse |
| 18:43:07 | <wyclif> tried command line with git command too |
| 18:43:21 | <MarkG1> wyclif: i'm using intellij now, so i can't tell you how to do it through eclipse, but from the comand line do: |
| 18:43:22 | <wyclif> git clone ...... |
| 18:43:47 | <wyclif> MarkG1, i did git clone git@github.com:wluyima/openmrs-module-formentry.git |
| 18:43:59 | <MarkG1> yep... try |
| 18:44:36 | <MarkG1> git remote add wluyima https://github.com/wluyima/openmrs-module-formentry.git |
| 18:45:36 | <MarkG1> i think you could clone, but you'd have to do that in another working directory... it won't let you overwrite your existing clone (just a guess) |
| 18:46:05 | <MarkG1> by doing a git remote add you are saying associate another remote repo with this git directory |
| 18:46:35 | *** mathiaslin has quit IRC |
| 18:48:06 | *** dkayiwa has quit IRC |
| 18:48:11 | <suranga> rafa, thank u so much for the response to my mail. that was really helpful ! :-) |
| 18:48:14 | *** dkayiwa has joined #openmrs |
| 18:49:11 | <rafa> suranga: you're welcome. |
| 18:52:12 | <MarkG1> wyclif: did that work for you? |
| 18:52:12 | *** dkayiwa has quit IRC |
| 18:53:12 | <MarkG1> the next step would be to do a "git fetch wluyima" (which says "get all the branches/info in the remote repo wluyima and add them to my local repo") |
| 18:53:33 | <MarkG1> then you could do "git checkout wluyima/master to check out your master branch |
| 18:53:46 | *** dkayiwa has joined #openmrs |
| 18:55:08 | <wyclif> MarkG1, i already succeeded in forking, it is cloning that is failing |
| 18:56:03 | <MarkG1> wyclif: see my previous comments... i think you want to add it as a remote, not clone it |
| 18:56:41 | *** dkayiwa has quit IRC |
| 18:59:13 | *** james_regen has quit IRC |
| 19:00:39 | <wyclif> MarkG1, ok, i will try that, thanks! |
| 19:02:49 | <bwolfe> !scrumon bwolfe |
| 19:02:49 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster bwolfe- you may begin when ready. |
| 19:02:57 | <MarkG1> after the "git fetch" and "git checkout" I mentioned above, do a "git merge origin/master" to pull in the latest changes i made to the module |
| 19:03:20 | <bwolfe> wyclif, sgithens, nribeka, mseaton, djazayeri, bwolfe. anyone I miss that is sprinting this week? |
| 19:03:45 | <rafa> me! |
| 19:03:54 | <bwolfe> oh, haha |
| 19:03:59 | <bwolfe> sorry, you go last ;-) |
| 19:04:10 | <bwolfe> actually, mvorobey can go last |
| 19:04:55 | <bwolfe> wyclif, are you ready? |
| 19:04:59 | <wyclif> yeah |
| 19:05:13 | <wyclif> was that the order or question? |
| 19:05:22 | <wyclif> i mean the listing of names above |
| 19:05:24 | <bwolfe> thats the order |
| 19:05:36 | <bwolfe> so you're up |
| 19:05:50 | <wyclif> wednesday: |
| 19:05:50 | <wyclif> * RG HIPPA training |
| 19:05:50 | <wyclif> * design call |
| 19:05:50 | <wyclif> * HTML-71 - Add search to location selector |
| 19:05:50 | <wyclif> Thursday: |
| 19:05:51 | <wyclif> * dev call |
| 19:05:53 | <wyclif> * Add type attribute to encounterLocation tag and document it |
| 19:05:55 | <wyclif> * REPORT-166 - Ensure that all date-based queries are appropriately handling boundary conditions |
| 19:05:57 | <wyclif> * pick another bug ticket |
| 19:05:59 | <wyclif> Blockers: None |
| 19:06:30 | <sgithens> * REPORT-337 Working through which fields map to where in my dialog. |
| 19:06:30 | <sgithens> * Need to create a local report that will take a long time |
| 19:06:30 | <sgithens> to run for testing cancellation. (need to try bens suggestion) |
| 19:06:30 | <sgithens> * Hoping to finish this still this week before COB tomorrow. |
| 19:06:30 | <sgithens> At the very least there may be a few things from the mockup |
| 19:06:31 | <sgithens> that don't show up yet. |
| 19:06:37 | <sgithens> Only blocker is time. |
| 19:06:42 | <djazayeri> wyclif: discussion point for after: how are you picking tickets |
| 19:06:49 | <djazayeri> !ticket report-33 |
| 19:06:50 | <OpenMRSBot> djazayeri: [#REPORT-33] PatientIdentifierCohortEvaluator calls PatientService.getPatients(String, String, List ) incorrectly - OpenMRS JIRA - https://tickets.openmrs.org/browse/report-33 |
| 19:06:53 | <djazayeri> !ticket report-337 |
| 19:06:54 | <OpenMRSBot> djazayeri: [#REPORT-337] Improve UI of the Report Evaluation Page - OpenMRS JIRA - https://tickets.openmrs.org/browse/report-337 |
| 19:06:59 | <nribeka> i think i need a cheat sheet for this |
| 19:07:16 | *** suranga has quit IRC |
| 19:07:37 | <bwolfe> nribeka, cheat sheet for what? |
| 19:07:38 | <djazayeri> sgithens: in case I forgot to comment on the ticket and just said this on IRC, cancelling threads in Java is deprecated |
| 19:07:48 | <bwolfe> nribeka, you're up |
| 19:08:03 | <nribeka> wednesday: |
| 19:08:03 | <nribeka> - hipaa training |
| 19:08:03 | <nribeka> - REPORT-371 |
| 19:08:03 | <nribeka> thursday: |
| 19:08:03 | <nribeka> - ampath call |
| 19:08:04 | <nribeka> - dev call |
| 19:08:09 | <nribeka> blocker: none |
| 19:08:23 | <nribeka> discussion: need to talk with mseaton and probably djazayeri on provider from encounter |
| 19:08:42 | <djazayeri> !ticket report-371 |
| 19:08:43 | <OpenMRSBot> djazayeri: [#REPORT-371] Create ObsDataSetDefinition along with Obss Data definition and Obss Query - OpenMRS JIRA - https://tickets.openmrs.org/browse/report-371 |
| 19:08:53 | <djazayeri> nribeka: you solved that ticket? |
| 19:09:47 | <nribeka> yeah, i put a patch on it. the ticket is actually to accommodate what i've been working on during the sprint |
| 19:10:00 | <mseaton> completed yesterday/today: |
| 19:10:05 | <mseaton> !ticket REPORT-360 |
| 19:10:06 | <OpenMRSBot> mseaton: [#REPORT-360] One the "custom report" page, if a data set is added with a key that contains spaces, you will not be able to edit or remove this key - OpenMRS JIRA - https://tickets.openmrs.org/browse/REPORT-360 |
| 19:10:09 | <mseaton> !ticket REPORT-316 |
| 19:10:10 | <OpenMRSBot> mseaton: [#REPORT-316] Cohort query doesnt allow subset view by types - OpenMRS JIRA - https://tickets.openmrs.org/browse/REPORT-316 |
| 19:10:15 | <mseaton> reverted: |
| 19:10:19 | <mseaton> !ticket REPORT-49 |
| 19:10:20 | <OpenMRSBot> mseaton: [#REPORT-49] Add a mechanism for tagging / categorizing reports and other reporting elements - OpenMRS JIRA - https://tickets.openmrs.org/browse/REPORT-49 |
| 19:10:21 | <mseaton> (sorry wyclif) |
| 19:10:35 | <mseaton> discussion / blocker around redesign of tags in REPORT-49 |
| 19:10:51 | <mseaton> lots of conference calls, ticket reviews, etc. |
| 19:10:55 | <mseaton> no other issues |
| 19:11:11 | <djazayeri> nribeka: just pointing out that it's helpful when you say *what* you did to a ticket, in the scrum report. :-) |
| 19:11:22 | <djazayeri> My report |
| 19:11:40 | <djazayeri> Wednesday 11-Apr-2012 |
| 19:11:40 | <djazayeri> * University call |
| 19:11:40 | <djazayeri> * Design call |
| 19:11:40 | <djazayeri> * Project management call |
| 19:11:40 | <djazayeri> * Prepare for next week's Web Services 1.0 sprint |
| 19:11:40 | <djazayeri> * Did REPORT-368 (wrong scheduler.password GP will lock your admin account) |
| 19:11:40 | <djazayeri> * Released Reporting 0.7.1.1 |
| 19:11:41 | <djazayeri> Thursday 12-Apr-2012 |
| 19:11:42 | <djazayeri> * Dev call |
| 19:11:42 | <djazayeri> * Leadership call |
| 19:11:43 | <djazayeri> * Meet with Bill and Jan from ITECH |
| 19:11:43 | <djazayeri> * More work on REPORT-330 |
| 19:11:56 | <djazayeri> (https://tickets.openmrs.org/browse/REPORT-330 |
| 19:11:56 | <djazayeri> ) |
| 19:12:15 | <djazayeri> (first pass data export replacement in reporting framework) |
| 19:12:17 | <djazayeri> no blockers |
| 19:12:38 | <mvorobey> * Closed report-353 |
| 19:12:40 | <mvorobey> Investigated report-223 |
| 19:12:40 | <mvorobey> No blockers |
| 19:12:54 | <bwolfe> !ticket REPORT-368 |
| 19:12:55 | <OpenMRSBot> bwolfe: [#REPORT-368] If scheduler.password is wrong, then the reporting module will quickly lock your admin account - OpenMRS JIRA - https://tickets.openmrs.org/browse/REPORT-368 |
| 19:13:21 | <djazayeri> !ticket report-353 |
| 19:13:22 | <OpenMRSBot> djazayeri: [#REPORT-353] Format cron expressions nicely within Scheduled Reports table - OpenMRS JIRA - https://tickets.openmrs.org/browse/report-353 |
| 19:13:25 | <djazayeri> !ticket report-223 |
| 19:13:26 | <OpenMRSBot> djazayeri: [#REPORT-223] Run Report page does not properly handle Collection parameters - OpenMRS JIRA - https://tickets.openmrs.org/browse/report-223 |
| 19:13:31 | <bwolfe> mvorobey jumped in line. :-) |
| 19:13:51 | <mvorobey> bwolfe, sorry, I was before you :) |
| 19:14:03 | <bwolfe> and poor forgotten rafa |
| 19:14:06 | <bwolfe> my update: |
| 19:14:08 | <mvorobey> bwolfe, but should have to be after :) |
| 19:14:17 | <bwolfe> Sunday-Wednesday: |
| 19:14:17 | <bwolfe> recovered from appendectomy |
| 19:14:17 | <bwolfe> today: |
| 19:14:17 | <bwolfe> emails |
| 19:14:17 | <bwolfe> reviewed a bunch of tickets (which I should link to) |
| 19:14:17 | <bwolfe> commented on more tickets (which I don't really need to link to) |
| 19:14:19 | <bwolfe> triaged 2 tickets (which I should link to) |
| 19:14:21 | <bwolfe> dev call |
| 19:14:23 | <bwolfe> call with jembi about hl7 input/output |
| 19:14:25 | <bwolfe> leadership call |
| 19:14:27 | <bwolfe> reviewed gsoc projects |
| 19:14:29 | <bwolfe> no blockers now that my appendix is out |
| 19:14:57 | <bwolfe> discussion for after: mseaton, want me to take up a reporting ticket tomorrow? or should I just plan for next week? |
| 19:15:09 | <bwolfe> also discussion: whats the status of the sprint? |
| 19:15:44 | <bwolfe> rafa, now you're up |
| 19:15:56 | <rafa> bwolfe: ohh that was a long queue |
| 19:15:58 | <rafa> Today: |
| 19:15:58 | <rafa> * Worked on REPORT-244: Update reporting dashboard UI to better support systems with lots of reports in a variety of categories, but stopped due to redesing in REPORT-49. |
| 19:15:58 | <rafa> * Had a lot of GSoC discussions |
| 19:15:58 | <rafa> * Investigated on REPORT-367: New Dataset Definition fails and finally got it running on 1.6.x. It's frustrating, but I still don't know the reason why it fails for me on 1.8.x and 1.10.x. Anyway, I'm fine working with 1.6.x. |
| 19:15:58 | <rafa> No blockers. |
| 19:16:46 | <djazayeri> rafa: maybe try stopping other modules and see if there's a bad module interaction? |
| 19:17:11 | <bwolfe> anyone I miss? |
| 19:17:24 | <bwolfe> otherwise I'm scrumoffing... |
| 19:17:26 | <rafa> djazayeri: I started with a clean installation |
| 19:17:49 | <bwolfe> !scrumoff |
| 19:17:49 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 19:17:56 | <djazayeri> We had several discussion topics |
| 19:17:58 | <sgithens> djazayeri: I think wyclif commented on the ticket saying he added a dwr endpoint to cancel reports. I haven't tested it yet, because I still need to make a long running report. |
| 19:18:03 | <nribeka> mseaton, do you have a minute? :D |
| 19:18:19 | <djazayeri> nribeka: first let's list the discussion topics. :-) |
| 19:18:23 | <bwolfe> starting with discussions from the top: |
| 19:18:24 | <wyclif> sgithens, that was reverted |
| 19:18:29 | <bwolfe> wyclif: discussion: need to talk with mseaton and probably djazayeri on provider from encounter |
| 19:18:38 | <nribeka> that's me bwolfe |
| 19:18:53 | <sgithens> wyclif: Oh. So there sint' a way to cancel reports now? I think that was the highlight of this new UI dialog? |
| 19:18:57 | <djazayeri> darius: wyclif: discussion point for after: how are you picking tickets |
| 19:18:58 | <bwolfe> stupid middle-click... |
| 19:19:07 | <downey> bwolfe: congrats on clearing your blocker |
| 19:19:09 | <wyclif> sgithens, no |
| 19:19:15 | <bwolfe> wyclif: discussion point for after: how are you picking tickets |
| 19:19:18 | <bwolfe> thanks downey |
| 19:19:31 | <wyclif> i had actually a dwr method for canceling a queued and not running report |
| 19:19:58 | <wyclif> sgithens, there is a ticket first of all to find a way to cancel a running report since this is currently not possible |
| 19:20:41 | <sgithens> wyclif: Gotcha, I'll just comment out those buttons for now :) |
| 19:20:54 | <wyclif> by vote but this meaningless since the max number of votes for the tickets matching the query is 1 and there several with 1 vote |
| 19:21:15 | <djazayeri> wyclif: okay, so how are you breaking ties between all those things with 1 vote? |
| 19:21:30 | <djazayeri> whichever seems fun? whichever seems useful? |
| 19:21:46 | <wyclif> djazayeri, personal judgement depending on what seems for urgent or a quick win |
| 19:21:53 | <djazayeri> okay, fair enough |
| 19:23:17 | <wyclif> djazayeri, basically am trying to avoid tickets that require alot of time sincei only hae i day left |
| 19:23:25 | <djazayeri> wyclif: perfect |
| 19:23:29 | <djazayeri> wyclif: discussion: need to talk with mseaton and probably djazayeri on provider from encounter |
| 19:23:31 | <djazayeri> what's up with this? |
| 19:23:53 | <djazayeri> actually that was nribeka |
| 19:24:21 | <nribeka> it's more like i don't know how to do it djazayeri + mseaton |
| 19:24:37 | <djazayeri> do what? |
| 19:24:47 | <nribeka> so i have encounter dataset, and getting the id, type, and encounter datetime is simple and already available |
| 19:24:48 | <djazayeri> I don't know what "provider from encounter" means exactly |
| 19:24:56 | *** mccallumg has joined #openmrs |
| 19:24:56 | *** ChanServ sets mode: +v mccallumg |
| 19:24:58 | *** dkayiwa has joined #openmrs |
| 19:25:00 | <nribeka> but i have the need to get provider data |
| 19:25:15 | <nribeka> provider age, provider gender, provider name for example |
| 19:25:21 | <mseaton> rafa: for better or worse i now get your "green" error. i updated to latest from 1.8.x. still think from this it's a bug in core. |
| 19:25:45 | <nribeka> i hope you're getting me djazayeri + mseaton |
| 19:26:20 | <djazayeri> nribeka: so you don't want to just expose the provider, but attributes of the provider |
| 19:26:26 | <djazayeri> rafa: I get the error too now after updating |
| 19:26:37 | <nribeka> yes djazayeri |
| 19:26:58 | <rafa> mseaton, djazayeri: okay, at least I know where to look now |
| 19:27:00 | <djazayeri> nribeka: also this is further complicated by the fact that provider changes in 1.9. :-) |
| 19:27:23 | <djazayeri> nribeka: ignoring those though... |
| 19:27:24 | <rafa> mseaton: did you note a rev you used before? |
| 19:27:46 | <mseaton> rafa, no. i can tell you the files that updated though |
| 19:27:51 | <djazayeri> nribeka: surely you should expose just "provider", right? |
| 19:28:08 | <rafa> mseaton: that would be great |
| 19:28:14 | <nribeka> maybe exposing the provider and configuring the converter, would that work? |
| 19:28:19 | <mseaton> nribeka: the "value" of the column can be a Provider object, then you can use a data converter to get data off of it |
| 19:28:45 | <djazayeri> rafa: look at webapp/src/main/webapp/WEB-INF/template/headerMinimal.jsp |
| 19:28:55 | <mseaton> rafa: |
| 19:28:56 | <mseaton> update /home/mseaton/workspace/openmrs-1.8.x -r HEAD --force |
| 19:28:56 | <mseaton> U /home/mseaton/workspace/openmrs-1.8.x/api/src/main/java/org/openmrs/api/db/hibernate/HibernateUserDAO.java |
| 19:28:56 | <mseaton> U /home/mseaton/workspace/openmrs-1.8.x/api/src/main/java/org/openmrs/api/db/hibernate/HibernateContextDAO.java |
| 19:28:56 | <mseaton> U /home/mseaton/workspace/openmrs-1.8.x/api/src/main/resources/liquibase-update-to-latest.xml |
| 19:28:56 | <mseaton> U /home/mseaton/workspace/openmrs-1.8.x/api/src/main/resources/org/openmrs/api/db/hibernate/Obs.hbm.xml |
| 19:28:56 | <mseaton> U /home/mseaton/workspace/openmrs-1.8.x/api/src/main/resources/org/openmrs/api/db/hibernate/Drug.hbm.xml |
| 19:28:56 | <mseaton> U /home/mseaton/workspace/openmrs-1.8.x/webapp/src/main/webapp/WEB-INF/view/scripts/jquery-ui/js/jquery-ui-datepicker-i18n.js |
| 19:28:58 | <mseaton> U /home/mseaton/workspace/openmrs-1.8.x/webapp/src/main/webapp/WEB-INF/template/headerMinimal.jsp |
| 19:28:58 | <mseaton> U /home/mseaton/workspace/openmrs-1.8.x/web/src/main/java/org/openmrs/module/web/controller/ModuleListController.java |
| 19:28:58 | <mseaton> U /home/mseaton/workspace/openmrs-1.8.x/web/src/main/resources/openmrs-servlet.xml |
| 19:28:58 | <mseaton> Updated to revision 26884. |
| 19:29:02 | <nribeka> so i need to create EncounterProviderDataEvaluator and configurable ProviderConverter? |
| 19:30:04 | <nribeka> yeah mseaton, that would work right? |
| 19:30:06 | <mseaton> nribeka: that would be one way of doing it, yes. |
| 19:30:21 | <mseaton> it's similar to how we do PersonAddress at the moment |
| 19:30:26 | <mseaton> a person can have multiple addresses. |
| 19:30:50 | <nribeka> ok. lemme try it mseaton |
| 19:30:54 | <mseaton> we have a PreferredAddressDataDefinition which will return a PersonAddress object and can be added to a row-per-person dsd |
| 19:31:15 | <mseaton> and you can re-use this for multiple columns by using different converters to show different properties: cityVillage, address1, etc. |
| 19:31:19 | <nribeka> some of the data definition is there but the evaluator is missing :p |
| 19:32:21 | <djazayeri> nribeka, mseaton: thoughts about how to deal with the fact that encounter.provider is deprecated in 1.9? |
| 19:32:44 | <djazayeri> I guess you can have "provider" give you a single (Person) provider |
| 19:33:07 | <djazayeri> and some 19ext module can add "providers" which gives you multiple EncounterProviders |
| 19:33:15 | <mseaton> djazayeri: yes |
| 19:33:27 | <mseaton> it's ugly |
| 19:33:33 | <mseaton> i hope it was worth it :) |
| 19:34:51 | <mseaton> rafa: definitely headerminimal looks like the issue. |
| 19:36:25 | <djazayeri> rafa, mseaton: yeah |
| 19:37:01 | <nribeka> ugh yeah djazayeri. multi provider thing. maybe that will work |
| 19:37:42 | <djazayeri> looks like bwolfe's fix for TRUNK-3145, backported by dkayiwa, broke things for rafa |
| 19:37:57 | <bwolfe> !ticket TRUNK-3145 |
| 19:37:57 | <nribeka> mseaton, i created BasePatientEncounterQuery -> support locations, encounter types, date time range, time modifier (last and first) |
| 19:37:58 | <OpenMRSBot> bwolfe: [#TRUNK-3145] When you delete an encounter you are not returned to the dashboard and the dashboard isnt refreshed when click back - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3145 |
| 19:38:00 | <dkayiwa> :( |
| 19:38:43 | <nribeka> current example of encounter query doesn't accommodate all my needs :P |
| 19:38:57 | *** pulasthi7 has quit IRC |
| 19:39:02 | <djazayeri> bwolfe: you updated headerMinimal to be more like headerFull, including adding css for the given theme |
| 19:39:46 | <djazayeri> I wonder if that only breaks things when included in an iframe? |
| 19:40:13 | <bwolfe> hmm, yes, possibly |
| 19:41:02 | *** Rahul has quit IRC |
| 19:41:07 | <djazayeri> indeed, in 1.8.x clicking on View for an HTML Form opens a popup with an error in it |
| 19:41:28 | <djazayeri> I mean: viewing an encounter entered via an html form |
| 19:41:35 | <bwolfe> I'm on the fence about the theme css being included for headerMinimal. it might contain changes needed (like font/colors/etc) but could contain changes that alter the location of divs, etc |
| 19:41:42 | <djazayeri> javax.servlet.jsp.JspTagException: Theme 'green': No message found under code 'favicon.png' for locale 'en_GB'. |
| 19:41:48 | <wyclif> MarkG1, can i commit to trunk for hfe now? |
| 19:42:16 | <djazayeri> bwolfe (& rafa): maybe we should get rid of that in 1.8.x? |
| 19:42:25 | <djazayeri> I.e. don't change the behavior in a minor version... |
| 19:44:07 | <djazayeri> definitely we need to make it work in all versions though. :-) |
| 19:44:32 | <bwolfe> favicon.png isn't defined in the 1.8.x defaults.properties |
| 19:44:43 | <bwolfe> backport this to that file in 1.8.x: favicon.png=/images/openmrs-favicon.png |
| 19:44:59 | <djazayeri> rafa: you following this? |
| 19:45:22 | <djazayeri> actually, this isn't necessarily rafal's ticket |
| 19:45:23 | <MarkG1> wyclif: sure... it is probably more confusing now becuase of the different states everything is in... |
| 19:45:48 | <djazayeri> in fact, this is probably ben's ticket. I'll reopen the problematic one |
| 19:46:13 | <djazayeri> actually, i'll create a new one |
| 19:47:23 | <bwolfe> eclipse-- |
| 19:48:56 | <djazayeri> rafa: did you say that reporting doesn't work in 1.9.x because of this? |
| 19:49:42 | <wyclif> MarkG1, i have tried to synnhronize my working directory with trunk |
| 19:50:41 | <rafa> djazayeri: sorry I'm back |
| 19:50:57 | <MarkG1> wyclif: are you saying that it isn't working? |
| 19:50:58 | <djazayeri> rafa: just answer my last questionâ¦did this issue break reporting for you in 1.9.x? |
| 19:51:32 | <rafa> djazayeri: it might have been that or some other issue |
| 19:51:40 | <rafa> djazayeri: I'll fire it up again and test |
| 19:52:28 | *** mvorobey has quit IRC |
| 19:52:56 | <wyclif> MarkG1, what not working |
| 19:53:14 | *** downey has quit IRC |
| 19:53:20 | <wyclif> MarkG1, i wil do the forking in my free time |
| 19:53:23 | <MarkG1> djazayeri: so jetty is now picking up my gsp changes live, but i don't have the controllers recompiling in real time yet... i will have to see if there is some intellij equivalent of build automatically... |
| 19:53:47 | <wyclif> MarkG1, i just want to commit the TODOs after for adding the new attribute and unit tests |
| 19:53:49 | <djazayeri> MarkG1: yeahâ¦it's probably possible to use a maven plugin for it also... |
| 19:54:17 | <MarkG1> wyclif: i just meant when you said "MarkG1, i have tried to synnhronize my working directory with trunk" were you asking me a question, or just telling me you had done it... :) |
| 19:54:20 | <djazayeri> well, not sure about that |
| 19:54:48 | <wyclif> MarkG1, it is working |
| 19:55:07 | <MarkG1> wyclif: okay, cool... i will check it out... probably not til tomorrow though... |
| 19:55:55 | <djazayeri> off to lunch |
| 19:57:08 | <MarkG1> djazayeri: okay, i will let you know how i do... |
| 19:57:36 | <djazayeri> MarkG1: To enable compiling files on every save, you can use the EclipseMode plugin: http://plugins.intellij.net/plugin/?id=3822 (third-party development, not bundled). |
| 19:57:42 | <djazayeri> from http://www.jetbrains.com/idea/documentation/migration_faq.html |
| 19:57:45 | <OpenMRSBot> <http://ln-s.net/$02y> (at www.jetbrains.com) |
| 19:57:51 | <djazayeri> off to lunch |
| 19:57:53 | <wyclif> MarkG1, how do the widets handle invalid values, throw exception or ignore them with the default, i.e if a user enters an invalid type |
| 19:57:54 | <MarkG1> djazayeri: the fact that it is now picking up my gsp changes live means that it has the path right, correct? |
| 19:58:00 | <djazayeri> yes |
| 19:58:08 | <MarkG1> djazayeri: thanks |
| 19:58:14 | <wyclif> MarkG1, that is not dropdown nor autocomplete |
| 19:58:43 | <MarkG1> wyclif: ie, type="some_invalid_type" |
| 19:58:48 | <wyclif> MarkG1, yeah |
| 19:59:12 | <MarkG1> wyclif: my preference would be to throw an exception, though it might be good to see what others do.. |
| 19:59:56 | <rafa> djazayeri: it works in 1.9 now (it had a different problem with non existing table) |
| 20:00:59 | <rafa> djazayeri: reporting_definition_tag which is now gone anyway |
| 20:04:11 | *** r_friedman has quit IRC |
| 20:25:40 | *** dkayiwa has left #openmrs |
| 20:30:15 | *** downey has joined #openmrs |
| 20:30:15 | *** ChanServ sets mode: +o downey |
| 20:30:15 | *** OpenMRSBot sets mode: +o downey |
| 20:39:24 | *** robbyoconnor has joined #openmrs |
| 20:39:24 | *** ChanServ sets mode: +v robbyoconnor |
| 20:39:49 | *** downey has quit IRC |
| 20:40:07 | *** lh has quit IRC |
| 20:40:34 | *** bryq has quit IRC |
| 20:40:49 | <robbyoconnor> nribeka: pm |
| 20:41:22 | *** downey has joined #openmrs |
| 20:41:22 | *** ChanServ sets mode: +o downey |
| 20:41:22 | *** OpenMRSBot sets mode: +o downey |
| 20:46:49 | *** downey has quit IRC |
| 20:47:38 | *** downey_ has joined #openmrs |
| 20:47:38 | *** ChanServ sets mode: +o downey_ |
| 20:52:43 | *** downey_ is now known as downey |
| 20:53:03 | *** robbyoconnor has quit IRC |
| 21:00:22 | *** rafa has quit IRC |
| 21:06:11 | *** littlee has joined #openmrs |
| 21:06:18 | <downey> Hi littlee and welcome to the #openmrs IRC channel. |
| 21:08:27 | <littlee> hi |
| 21:08:40 | *** finbrein has quit IRC |
| 21:09:03 | *** littlee has quit IRC |
| 21:09:23 | *** finbrein has joined #openmrs |
| 21:20:53 | *** sgithens has quit IRC |
| 21:26:03 | *** nribeka has quit IRC |
| 21:39:01 | *** mseaton has left #openmrs |
| 21:49:54 | <finbrein> Hi bwolfe: could you advise on the ticket TRUNK-3219. I have added a comment, in addition to comments from MarkG1 and djazayeri. thanks. |
| 21:50:05 | <downey> !ticket TRUNK-3219 |
| 21:50:06 | <OpenMRSBot> downey: [#TRUNK-3219] getProvidersByPerson should allow option to include (or not include) retired providers - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3219 |
| 21:50:34 | *** downey has quit IRC |
| 22:00:18 | *** downey has joined #openmrs |
| 22:00:18 | *** ChanServ sets mode: +o downey |
| 22:00:18 | *** OpenMRSBot sets mode: +o downey |
| 22:05:44 | <finbrein> djazayeri: can i change the status to 'Request Code Review'. Could you provide more information about creating ticket for the metadata |
| 22:06:15 | <djazayeri> finbrein: yes, Request Code Review on 3219 |
| 22:06:23 | <djazayeri> about creating a new ticket |
| 22:06:41 | <djazayeri> (you might want to quickly peek at something like EncounterType or Location first to see if this is already done) |
| 22:06:48 | <djazayeri> but the ticket would be something like: |
| 22:09:04 | <djazayeri> "Our API's getAll and get methods that search for metadata include retired items (which is correct) but those items should be sorted last. Go through all existing services, and for every getAllXyz (or other get method) for metadata, the DAO is returning the retired metadata last. |
| 22:09:17 | <djazayeri> Also, add unit tests to verify this." |
| 22:09:26 | <djazayeri> finbrein: something like that |
| 22:10:08 | <finbrein> ok |
| 22:20:29 | *** wyclif has quit IRC |
| 22:57:29 | <finbrein> i added this ticket TRUNK-3279 |
| 22:58:10 | <finbrein> djazayeri & downey: A new ticket, TRUNK-3279 |
| 23:07:32 | *** MarkG1 has quit IRC |
| 23:23:10 | *** wyclif has joined #openmrs |
| 23:31:47 | *** downey has quit IRC |
| 23:49:11 | *** lh has joined #openmrs |