IRC Chat : 2012-04-11 - OpenMRS

00:13:50 *** finbrein has quit IRC
00:14:44 *** finbrein has joined #openmrs
00:26:12 *** harshadura has joined #openmrs
00:44:37 *** wyclif has joined #openmrs
01:30:09 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: OpenMRS UI Framework 1.1 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=uiframework&ampversion=&amp1.1>
01:33:40 *** suranga has joined #openmrs
01:33:40 *** ChanServ sets mode: +v suranga
01:39:08 *** lh has joined #openmrs
01:51:14 <suranga> hi djazayeri :-)
01:51:45 <suranga> djazayeri, im afraid I have a teeny weeny problem... in case you are stil here.....
01:51:52 <djazayeri> hi suranga
01:52:04 <suranga> djazayeri, Yay !
01:52:34 <suranga> djazayeri, wanted to talk to you earlier today, but you were getting bugged from all sides.. so put it off for today :-)
01:53:07 <suranga> djazayeri, im trying to use curl to send a post message with Hl7 in it...
01:53:17 <suranga> the get works fine... but post is a problem...
01:53:34 <suranga> based on the mailing list and stuff i see online, im trying this,
01:53:53 <suranga> echo '{"source":"LOCAL","sourceKey":"test","data":"MSH|^~\\&|FORMENTRY|AMRS|HL7LISTENER|AMRS|20060809121931||ORU^R01|formentry-20060809121931|P|2.5|1||||||||2^AMRS-ELDORET^http://schema.openmrs.org/2006/FormEntry/formId^URI\rPID|||123^^^^||jeff^marc^price||20011114|M|||20371^02^2400^724||||||724^Y||||||02|||11|20371|724^ESPA?A^N||N\rPV1||O|1^Unknown||||2^Ima Doc (2-6)|||||||||||||||||||||||||||||||||||||20060807|||||||V\rORC|RE||||||||20060807161605|1^Su
01:53:54 <suranga> per User\rOBR|1|||1238^MEDICAL RECORD OBSERVATIONS^99DCT\rOBX|1|NM|5089^WEIGHT (KG)^99DCT||70|||||||||20060807"}'
01:54:27 <suranga> wonder if you can see anything wrong in it ? for example, having sourcekey as = test ?
01:55:04 <suranga> djazayeri, im getting a...
01:55:06 <suranga> --------
01:55:07 <suranga> {"error":{"message":"Could not read JSON: Unexpected character (''' (code 39)): expected a valid value (number, String, array, object, 'true', 'false'
01:55:07 <suranga> or 'null')\n at [Source: org.mortbay.jetty.HttpParser$Input@1815bc; line: 1, column: 2]; nested exception is org.codehaus.jackson.JsonParseException:
01:55:07 <suranga> Unexpected character (''' (code 39)): expected a valid value (number, String, array, object, 'true', 'false' or 'null')\n at [Source: org.mortbay.jet
01:56:03 <djazayeri> suranga: I'm not sure what the error is.
01:56:14 <djazayeri> is there a ' in there somewhere that would need to be escaped?
01:56:47 <suranga> djazayeri, do we escape using the traditinal \ character ?
01:57:06 <djazayeri> I don't know exactly
01:57:14 <djazayeri> suranga: are you on windows or other?
01:57:28 <suranga> djazayeri, windows :-(
01:57:42 <djazayeri> so, what you've got there looks like the syntax I used on osx/linux
01:57:53 <suranga> the echo part right ?
01:58:04 <djazayeri> I don't know if echo 'json'
01:58:25 <suranga> actually i tried nother version for windows .. but ended up with the same issue :P
01:58:40 <suranga> so i guesses i would show you this one..
01:59:05 <suranga> mm... djazayeri , how would u normally send a post of hl7 into openmrs ?
01:59:17 <djazayeri> suranga: not from windows. :-)
01:59:18 <suranga> would u use curl ? or groovy :-)
01:59:34 <djazayeri> suranga: actually I never do this in practice
01:59:41 <djazayeri> for testing ws.rest, I was using curl
02:03:09 *** mseaton has left #openmrs
02:11:31 <suranga> djazayeri, yay !
02:11:36 <suranga> djazayeri, i think it works
02:11:51 <suranga> can I show u the result ? (just to confirm ?)
02:31:58 *** upul` has joined #openmrs
02:31:59 *** ChanServ sets mode: +v upul`
03:08:11 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: UI Library Module 1.0 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=uilibrary&ampversion=&amp1.0>
03:15:01 *** upul` has quit IRC
03:50:37 *** deadpool has joined #openmrs
03:59:07 <deadpool> djazayeri: do you know anything about hibernate transaction rollback?
04:06:09 *** upul` has joined #openmrs
04:06:09 *** ChanServ sets mode: +v upul`
04:21:41 *** upul` has quit IRC
04:33:58 *** Felipo has joined #openmrs
04:35:37 <Felipo> Hello, i developing a module with de archetype tool, but when deploit it, the module no resolve the message.properties file
04:38:27 <Felipo> somebody help me?
04:55:04 *** Echidna has quit IRC
04:55:12 *** Echidna has joined #openmrs
04:55:12 *** ChanServ sets mode: +v Echidna
05:00:09 <djazayeri> hola Felipo
05:00:31 <djazayeri> Do all the messages in your messages.properties file start with the module id?
05:00:50 *** deadpool has quit IRC
05:20:23 *** harshadura has quit IRC
05:23:04 <Felipo> Hola Darius, ya lo arregle, estaba llamando mal las propiedades
05:23:30 <Felipo> aun no me acostumbro al key sensitive
05:23:41 <djazayeri> bueno
05:23:51 <Felipo> ya me ha pasado varias veces con algunas cosas
05:23:58 <Felipo> como va todo?
05:24:03 <Felipo> mucho trabajo?
05:24:18 <djazayeri> Una buena cantidad, si!
05:24:55 <Felipo> Mario se fue, y me toco tomar todo el desarrollo a mi...
05:25:12 <Felipo> entonces estoy aprendiendo a hacer todo esto
05:26:07 <djazayeri> entonces mucho trabajo para ti tambien...
05:28:42 <Felipo> a lot
05:29:12 *** Rahul_ has joined #openmrs
05:35:48 <finbrein> hi djazayeri:Could you advise on the best approach to apply to this problem; TRUNK-3219
05:36:00 <finbrein> I have two options
05:36:02 <djazayeri> !ticket trunk-3219
05:36:03 <OpenMRSBot> djazayeri: [#TRUNK-3219] getProvidersByPerson should allow option to include (or not include) retired providers - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-3219
05:36:12 <finbrein> or ways of solving it
05:38:08 <djazayeri> finbrein: one thing, note my comment on TRUNK-3170
05:38:52 <djazayeri> specifically: the default behavior should be to _inclue_ retired
05:39:02 <finbrein> One way is to use the existing getProvidersByPerson(person) method in the class HibernateProviderDAO and do return getProvidersByPerson(person,false) to delegate to a new method getProvidersByPerson(Person person, boolean includeRetired)
05:39:18 <djazayeri> so the existing method should actually do getProvidersByPerson(person, true)
05:39:32 <djazayeri> finbrein: okay, so what's the alternative?
05:41:14 <finbrein> i understand it will now be return getProvidersByPerson(person, true) in the existing getProvidersByPerson(Person person) method but use the right if...statement in the new method with the boolean parameter
05:42:27 <finbrein> The second approach is to leave the existing getProvidersByPerson(Person person) AS-IS
05:42:56 *** Rahul_ has quit IRC
05:44:56 <finbrein> and create a another getProvidersByPerson(Person person, boolean includeRetired) and make changes in other classes that are calling the existing method to be able to call this one by adding a new statement to those classes. For example in ORUR01handler.java and Encounter.java
05:46:03 <djazayeri> finbrein: it's better style to have the one-arg version delegate to the two-arg version, so that we are confident that they behave consistently
05:46:09 <finbrein> Right now objects are calling getProvidersByPerson(person) but no entry yet for getProvidersByPerson(person, true) in those classes
05:46:43 <finbrein> ok, thank you
05:46:44 <djazayeri> also, you should not need to change any methods that currently call this
05:47:00 <djazayeri> if they're currently calling the method that includes retired providers, they can continue doing so
05:47:03 <djazayeri> finbrein: np
06:12:10 *** bryq has joined #openmrs
06:12:10 *** ChanServ sets mode: +v bryq
06:14:11 *** deadpool has joined #openmrs
06:22:47 <suranga> djazayeri, in case u r still awake, it works awesomely now :-)
06:29:54 *** bryq has quit IRC
06:43:05 *** suranga has quit IRC
06:44:42 *** Jibesh has joined #openmrs
06:44:54 *** Jibesh has left #openmrs
06:49:26 *** dkayiwa has joined #openmrs
06:49:48 *** deadpool has quit IRC
06:50:23 *** deadpool has joined #openmrs
07:10:44 *** pushkar has joined #openmrs
07:26:41 *** pushkar has quit IRC
07:28:32 *** guy has joined #openmrs
07:28:58 *** guy is now known as Guest41572
07:35:46 *** Jibesh has joined #openmrs
07:43:06 *** suranga has joined #openmrs
07:43:06 *** ChanServ sets mode: +v suranga
07:43:23 <suranga> aha ! dkayiwa is back !
07:43:28 <suranga> dkayiwa, Happy easter !!!
07:43:43 <dkayiwa> Happy Easter suranga :)
07:43:57 <dkayiwa> suranga: yes am finally back after a very long weekend :)
07:44:05 <suranga> dkayiwa, we missed you over here :p
07:44:11 <suranga> ben is also missing :P
07:44:57 <dkayiwa> suranga: oh am finally back
07:45:04 <dkayiwa> suranga: Ben had an operation
08:00:35 *** littlee has joined #openmrs
08:01:21 *** deadpool has quit IRC
08:02:06 *** deadpool has joined #openmrs
08:04:19 *** finbrein has quit IRC
08:14:58 *** rafa has joined #openmrs
08:14:58 *** ChanServ sets mode: +v rafa
08:28:10 *** littlee has quit IRC
08:28:14 *** finbrein has joined #openmrs
08:29:54 *** upul` has joined #openmrs
08:29:54 *** ChanServ sets mode: +v upul`
08:33:09 *** dkayiwa has quit IRC
08:39:25 *** deadpool has quit IRC
08:40:09 *** deadpool has joined #openmrs
08:47:06 *** Felipo has quit IRC
08:51:55 *** suranga_ has joined #openmrs
08:54:06 *** suranga has quit IRC
08:57:48 *** pulasthi7 has joined #openmrs
09:01:30 *** bryq has joined #openmrs
09:01:30 *** ChanServ sets mode: +v bryq
09:05:48 <deadpool> djazayeri: if i do a session.flush in my module and then a commit will it be a problem?
09:08:48 *** bryq has quit IRC
09:11:34 *** lh has quit IRC
09:14:49 *** suranga_ has quit IRC
09:26:48 *** lh has joined #openmrs
09:27:49 *** deadpool has quit IRC
09:28:43 *** deadpool has joined #openmrs
09:32:30 *** sthaiya has joined #openmrs
09:32:38 *** Jibesh has left #openmrs
09:33:55 *** sthaiya has quit IRC
09:34:06 *** sthaiya has joined #openmrs
09:41:52 <mathiaslin> when i try to create a new html form (manage html forms / new) in 1.8.3, trying to add an observation to the form, I have no widgets to select from (the html widgets module is installed though), but I'm getting an exception: Caused by: javassist.bytecode.DuplicateMemberException: duplicate method: writeReplace in org.openmrs.module.htmlformentry.HtmlForm_$$_javassist_86
09:43:07 <mathiaslin> might that be a conflict that i have two instances running (openmrs183, and openmrs - which is the latest trunk snapshop), using the same /user/.OpenMRS/modules folder? - but the app context is a different one though for both of course.
09:58:37 *** upul` has quit IRC
10:02:35 *** deadpool_ has joined #openmrs
10:04:05 *** deadpool has quit IRC
10:07:42 <mathiaslin> (I'm referring to the HTML Form Entry Designer WYSIWYG features).
10:21:48 *** Jibesh has joined #openmrs
10:21:53 *** Jibesh has left #openmrs
10:31:47 <finbrein> hi all, i want to test an object and database. I have one instance here which i would like to clarify. openmrs-api/src/test/java/org/openmrs/api/ProviderServiceTest - method getAllProviders_shouldGetAllProviders()
10:34:12 <finbrein> in the standardTestDataset.xml on the path: openmrs-api/src/test/resources/org/openmrs/include/ - not up to eight providers are in the file as tested in this method earlier mentioned.
10:34:24 <finbrein> could you advise
10:35:36 *** deadpool_ has quit IRC
10:36:32 *** deadpool_ has joined #openmrs
10:49:08 *** james_regen has joined #openmrs
10:49:08 *** ChanServ sets mode: +v james_regen
10:54:07 <finbrein> hi james: could you advise . thanks .
10:54:28 <finbrein> hi james_regen: could you advise
10:54:51 *** snoppy has joined #openmrs
11:13:23 <james_regen> hi finbrein
11:13:34 <finbrein> hi james_regen
11:16:50 <finbrein> actually i want a better understanding why the tested method i mentioned was able to pass the test when there is only one provider entry in the dataset to test the Provider object/class against the in-memory DB
11:17:51 <finbrein> in the method, 8 providers are reflected if you include both retired and not retired. 7 for not retired
11:19:03 <james_regen> finbrein: this doesn't sound familiar to me. is there another james that i might be confused with? i work on the patient matching module with suranga
11:20:27 <finbrein> james_regen: np, i wish someone can clarify later
11:23:33 *** gauravpaliwal has joined #openmrs
11:23:33 *** ChanServ sets mode: +v gauravpaliwal
11:41:32 *** pulasthi7 has quit IRC
11:55:47 *** gauravpaliwal has left #openmrs
11:57:14 *** r8friedman has joined #openmrs
11:57:30 *** r8friedman is now known as r_friedman
11:58:38 <r_friedman> rafa hi rafa, got a minute?
11:58:45 <rafa> r_friedman: hi
11:58:48 <rafa> sure
11:59:10 <r_friedman> i'd like to ask about the interaction between test case generation and the maven archetype
11:59:42 <r_friedman> the test case generator wants to put test cases in the api project, probably as a result of the old module structure
12:00:03 <r_friedman> but in the new module structure, testing takes place in the omod
12:00:23 <r_friedman> the result is a need to copy back and forth
12:00:47 <rafa> r_friedman: It's not entirely right. In the NEW module structure, testing takes place in the api and omod.
12:01:00 <rafa> r_friedman: It depends on what you test.
12:01:18 <r_friedman> oh dear, that is not so great
12:01:32 <rafa> r_friedman: If you test the api then tests should go in the api. If you test controllers then tests should go in the omod
12:01:55 <r_friedman> but the services are in the api
12:02:17 <rafa> r_friedman: right and you should test them in the api subproject
12:02:41 <r_friedman> but that means we have to duplicate resources, like custom data
12:03:07 <r_friedman> because the DAOs and the REST resources are in the omod
12:03:22 *** pulasthi7 has joined #openmrs
12:03:33 <rafa> r_friedman: they should be in the api as well
12:03:39 <rafa> r_friedman: not in the omod
12:04:01 <rafa> r_friedman: I mean DAOs
12:04:21 <rafa> r_friedman: REST controllers should go in the omod
12:04:23 <r_friedman> you are right, daos are in api
12:04:52 <r_friedman> what about standalone page controllers?
12:05:21 <rafa> r_friedman: all controllers go in the omod, it's the view
12:06:29 <r_friedman> ok, so I will try to get that structure working and see how it goes
12:06:35 <r_friedman> thanks much
12:07:16 <rafa> r_friedman: you're welcome. Ping me if you need help with fixing it. I've done it a few times already.
12:07:46 <r_friedman> rafa, i may need that help, I think i've gotten svn confused about the structure of my api
12:08:34 <r_friedman> although after this morning i'll just move it to git :-)
12:08:49 <rafa> r_friedman: good move :D
12:11:13 *** bryq has joined #openmrs
12:11:13 *** ChanServ sets mode: +v bryq
12:13:15 *** sgithens_ has quit IRC
12:37:12 *** wyclif has quit IRC
12:41:08 <r_friedman> rafa, when i try to test in api, I get a class not found error for the very class from which i initiated junit http://pastebin.com/7GGn6Ub8
12:49:32 *** nribeka has joined #openmrs
12:49:32 *** ChanServ sets mode: +v nribeka
12:52:39 *** suranga has joined #openmrs
12:52:39 *** ChanServ sets mode: +v suranga
12:53:16 * suranga walks in
12:53:30 <suranga> only just found out that there was a earthquake in sri lanka 3 hours back .. and also a tsunami warning
12:53:48 <suranga> hope everyone is safe !
12:54:11 <rafa> r_friedman: Actually, it's better you don't rearrange the project. It's not that straightforward. I can do it for you in my spare time over the weekend.
12:55:52 <r_friedman> rafa, thanks, I am upgrading dependencies and don't want to check this in until my co-workers are ready to do so, I'll get in touch again when that's done
12:56:22 <rafa> r_friedman: okay
12:57:34 <suranga> r_friedman, thanks again for pointing me to curl. it was a major help :-)
12:57:58 *** bryq has quit IRC
12:59:31 *** suranga has quit IRC
13:00:49 *** MarkG has joined #openmrs
13:06:02 *** downey has joined #openmrs
13:06:02 *** OpenMRSBot sets mode: +o downey
13:06:02 *** ChanServ sets mode: +o downey
13:08:08 *** harshadura has joined #openmrs
13:12:20 *** sgithens has joined #openmrs
13:19:56 *** mseaton has joined #openmrs
13:19:56 *** ChanServ sets mode: +v mseaton
13:27:11 *** wyclif has joined #openmrs
13:27:21 <mseaton> hi wyclif
13:27:35 <wyclif> hi mseaton
13:28:20 <mseaton> wyclif, are you planning any more follow-up work on REPORT-49, or are you slotted to go into bug-fixing support mode, and would rather someone else take the remaining work on?
13:29:04 <wyclif> mseaton, am fine with someone doing the remaining work
13:29:18 <wyclif> mseaton, i started on the bug fixing sprint
13:29:36 <wyclif> mseaton, but there is still that discussion point
13:29:44 *** dkayiwa has joined #openmrs
13:30:17 <wyclif> mseaton, if we store the the name of the interface, how do we construct the definition object given a definition tag
13:30:31 <wyclif> or given a definition summary
13:31:33 <mseaton> wyclif, yes, there are still some open questions. i will look at this question in more detail. i also want to make sure anyone working on this ticket is on the same page, because i'm thinking of redesigning the tags to be represented in many-to-many (eg. 2 tables instead of 1).
13:31:35 <wyclif> mseaton, otherwise we will end up fetching all definitions and looping over all to find the one with the matching uuid
13:34:05 <wyclif> mseaton, the way it is right now, a tag can be applied to many definitions and a definition can have many tags, so what other many-to-many relationship do you mean
13:37:49 <mseaton> wyclif: the way it is now, each time a tag with the text "Data Quality" is applied to a definition, a separate tag with the text "Data Quality" must be created. and there is no way to have any additional metadata associated with _every_ instance of all tags named "Data Quality".
13:38:28 <mseaton> wyclif: what we are proposing is instead to have a single "Data Quality" tag that is not directly associated with any definition objects.
13:38:46 <mseaton> then if you want to associate this to one or more definitions, you do so via a mapping table (eg. many-to-many)
13:39:04 <wyclif> mseaton, got you
13:39:33 <wyclif> mseaton, so you wnt to add a table to store the tags\
13:40:14 <mseaton> wyclif, right. this would allow us, for example, to have localized translations of each tag, etc. stored on the single instance of a tag and re-used.
13:40:26 <mseaton> it's a design change
13:40:27 <wyclif> ok
13:41:46 <wyclif> mseaton, so do we want o have the list of tags to be a property of the definitions and viceversa or one has to call the service for the tags?
13:42:24 <wyclif> mseaton, am seeing as though the code i wrote might completely change/discarded depending on what we choose
13:42:57 <mseaton> wyclif, hopefully we won't discard, just modify. we'll see.
13:43:02 <wyclif> ok
13:43:33 <mseaton> wyclif, i'll spend a little time on it today and see how far i can take it.
13:44:35 <wyclif> ok
13:45:36 <mseaton> do you have uncommitted code on this, wyclif/
13:45:37 *** dkayiwa_ has joined #openmrs
13:46:19 *** dkayiwa has quit IRC
13:46:21 *** dkayiwa_ is now known as dkayiwa
13:46:35 <wyclif> mseaton, no
13:47:45 <wyclif> the only fixes made after your comments are for changes to in sqldiff file to remove the database prefix and charset and these are committed, the rest are pending
13:47:54 <mseaton> ok
13:53:46 *** cosmin has joined #openmrs
13:53:55 <downey> Hi cosmin and welcome to the #openmrs IRC channel.
13:59:21 *** mvorobey has joined #openmrs
14:00:28 *** mvorobey_ has joined #openmrs
14:01:19 *** mvorobey_ has joined #openmrs
14:01:24 *** mvorobey__ has joined #openmrs
14:01:30 *** sthaiya has quit IRC
14:01:32 <mvorobey_> hi all
14:03:42 <mseaton> hi mvorobey_
14:03:54 *** mvorobey has quit IRC
14:03:56 *** mvorobey_ is now known as mvorobey
14:05:37 <mvorobey> mseaton, I'm going to add patch for REPORT-353 (that is very simple and pretty straightforward), it also contains very small bug fix for schedule widget that I found out when was testing it, are you okay with that ?
14:05:58 <mseaton> mvorobey: yes, sounds good
14:06:31 <mvorobey> mseaton, sorry, I meant scheduled reports table widget (not cron editing one)
14:06:42 <mseaton> mvorobey: sure!
14:06:54 <mvorobey> mseaton, :)
14:07:04 <mseaton> mvorobey: i made some changes yesterday, make sure you update. thanks for fixing the bugs!
14:07:23 <mvorobey> mseaton, I have already updated it :)
14:08:49 *** rohitgoyal18 has joined #openmrs
14:14:59 <djazayeri> mathiaslin: did you get the htmlformentry issue resolved?
14:24:46 *** dawn_ has joined #openmrs
14:24:46 *** ChanServ sets mode: +v dawn_
14:28:24 <mathiaslin> djazayeri: I've sent a mail to the dev mailing list, there were several issues in the htmlformentry (used in 1.8.3)
14:29:15 <mathiaslin> djazayeri: but no, it's not resolved yet. (I even reinstalled 1.8.3 again, this time without any parallel 1.9 instance running, and also cleaned the .OpenMRS directory as well)
14:29:38 <djazayeri> mathiaslin: yeah, I was going to say that the duplicate readResolve / writeReplace is a red herring
14:31:31 <djazayeri> mathiaslin: the html form entry designer doesn't work, unfortunately. the student who was working on the project last summer never quite completed it.
14:32:04 <djazayeri> there is no active development happening on it now, though I hope someday someone can pick it up again...
14:33:12 <mathiaslin> djazayeri: oh ok, I see. That's why. The wiki pages looked different than the module, therefore I was wondering
14:33:46 <djazayeri> mathiaslin: probably the wiki pages refer to the new-but-incomplete version of the module, but I haven't looked at them in a while.
14:33:55 <dawn_> !scrumon dawn
14:33:55 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready.
14:34:04 <dawn_> Hi Team. Sorry I'm late. Had a meeting run over
14:34:21 <dawn_> Today's order: wyclif , sgithens , rafa, mvorobey , mseaton , dkayiwa , djazayeri
14:34:38 <mathiaslin> djazayeri: no problem, actually the module isn't that important to me at the moment, it's just that i was setting up a new 1.8.3 environment, with the common modules in it. I thought that one was one of them, but I can go with the regular html form entry, no problem.
14:34:38 <rafa> hi
14:34:47 <mvorobey> hi dawn_ :)
14:34:59 <dawn_> :)
14:35:12 <dawn_> wyclif: your turn :) #1 two days in a row
14:35:39 <wyclif> Tuesday:
14:35:39 <wyclif> * TRUNK-2442 - Person attributes do not display on patient search results
14:35:39 <wyclif> * Updated the wiki page for the search widgets to reflect the changes
14:35:39 <wyclif> * Scoring GSoC proposals
14:35:39 <wyclif> wednesday:
14:35:40 <wyclif> * university call
14:35:42 <wyclif> * RG HIPPA training- this is compulsory
14:35:44 <wyclif> * HTML-71 - Add search to location selector
14:35:46 <wyclif> * pick another sprint ticket
14:35:48 <wyclif> Blockers: None
14:35:53 <sgithens> * Updating git workflow notes from omrs uni meeting.
14:35:53 <sgithens> * Making progress on sprint ticket, but I need
14:35:53 <sgithens> to get back and comment on a few things.
14:35:53 <sgithens> * Unblocker: My laptop finally showed up.
14:36:18 <djazayeri> we like unblockers
14:36:23 <rafa> :)
14:36:24 <dawn_> unblockers++
14:36:32 <rafa> Today:
14:36:32 <rafa> * Created REPORT-367: New Dataset Definition fails
14:36:32 <rafa> https://tickets.openmrs.org/browse/REPORT-367
14:36:32 <rafa> * Worked on REPORT-242: Update reporting dashboard UI to better support systems with lots of reports in a variety of categories
14:36:32 <rafa> https://tickets.openmrs.org/browse/REPORT-242 (will complete tomorrow)
14:36:32 <rafa> * University Call
14:36:32 <rafa> Blockers: It'd be good to have an installation with sample reports so that I don't have to create them manually (which is not entirely possible due to REPORT-367)
14:37:20 <dawn_> mvorobey: you turn :)
14:37:28 <mvorobey> * Prepared for review REPORT-353
14:37:28 <mvorobey> * Re-worked portlet for REPORT-312 as jsp tag.
14:37:28 <mvorobey> * No blockers.
14:37:37 <djazayeri> !ticket report-353
14:37:38 <OpenMRSBot> djazayeri: [#REPORT-353] Format cron expressions nicely within Scheduled Reports table - OpenMRS JIRA - https://tickets.openmrs.org/browse/report-353
14:37:42 <djazayeri> !ticket report-312
14:37:44 <OpenMRSBot> djazayeri: [#REPORT-312] Create improved widget for editing a cron expression - OpenMRS JIRA - https://tickets.openmrs.org/browse/report-312
14:38:01 <dawn_> mseaton: your turn :)
14:39:05 <dawn_> dkayiwa: can you go now and share your updates please? :)
14:39:17 <dkayiwa> Done some rudimentary testing
14:39:18 <dkayiwa> Started on release notes page
14:39:18 <dkayiwa> Created source-forge folder
14:39:18 <dkayiwa> Now working on tagging and then upload war and standalone files before sending announcement email for 1.9 RC3
14:39:19 <dkayiwa> No Blockers
14:39:49 <djazayeri> dkayiwa: have we dealt with the sort-of-blocker bug Mark reported yesterday?
14:40:14 <dkayiwa> djazayeri: i though it was only for the reporting module :)
14:40:32 <dawn_> djazayeri: you turn
14:40:36 <dkayiwa> djazayeri: so answer to your question in NO
14:40:39 <djazayeri> save this for a discussion topic
14:40:43 <dkayiwa> ok
14:40:48 <dawn_> djazayeri: will do
14:40:51 <djazayeri> Tuesday 10-Apr-2012
14:40:51 <djazayeri> * commented on / freed up a bunch of intro tickets
14:40:51 <djazayeri> * Finished UIFR-7
14:40:51 <djazayeri> * Released 1.0 of UI Widget Library module
14:40:51 <djazayeri> * Finished revising the UI Framework Tutorial documentation
14:40:52 <djazayeri> * Took some screenshots for the git University call. Didn't use them. :-(
14:40:53 <djazayeri> Wednesday 11-Apr-2012
14:40:53 <djazayeri> * University call
14:40:54 <djazayeri> * Design call
14:40:54 <djazayeri> * Project management call
14:40:55 <djazayeri> * More work on REPORT-330
14:40:55 <djazayeri> * Prepare for next week's Web Services 1.0 sprint.
14:40:56 <djazayeri> no blockers
14:41:25 <dawn_> Discussion Points: 1) Blockers: It'd be good to have an installation with sample reports so that I don't have to create them manually (which is not entirely possible due to REPORT-367) and 2) addressing the bug Mark reported yesterday
14:41:30 <dawn_> !scrumoff dawn
14:41:30 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
14:42:15 <dawn_> !ticket report-367
14:42:16 <OpenMRSBot> dawn_: [#REPORT-367] New Dataset Definition fails - OpenMRS JIRA - https://tickets.openmrs.org/browse/report-367
14:42:19 <djazayeri> Regarding sgithens's request for an install with sample reports: would be a great idea, and we should try to do that for the next sprint
14:42:24 <djazayeri> next reporting sprint
14:42:43 <dawn_> djazayeri: noted
14:42:55 <djazayeri> not much to do now
14:43:14 <rafa> djazayeri: it was my request and isn't an sql dump enough? :)
14:43:22 *** bryq has joined #openmrs
14:43:22 *** ChanServ sets mode: +v bryq
14:43:51 <djazayeri> rafa: oh, okay your request...
14:44:10 <djazayeri> I'm sure you can ask mseaton for a sqldump of a db with some reports
14:44:40 <djazayeri> dkayiwa: regarding the bug MarkG reported yesterday...
14:44:44 <rafa> I'll do that thx
14:44:53 <djazayeri> Someone should verify this, but it does seem like a blocker
14:45:00 <dkayiwa> djazayeri: ok
14:45:26 <dawn_> djazayeri: dkayiwa : who will be the "someone" to verify that?
14:45:30 <djazayeri> i.e. if you do a new installation, not using the standalone, your admin account will get locked pretty quickly, because of the scheduled reporting task
14:45:46 <dkayiwa> dawn_: i can do that
14:45:57 <dawn_> dkayiwa: sounds good. :)
14:46:12 <djazayeri> dkayiwa: the fix might need to be made in reporting
14:46:23 <dkayiwa> djazayeri: correct
14:46:23 <djazayeri> but let us know as soon as you've verified the bug
14:46:29 <dkayiwa> djazayeri: ok
14:46:59 <djazayeri> and we'll go from there
14:47:08 <dkayiwa> djazayeri: ok
14:49:15 <dawn_> rafa: what can we discuss about the blocker you reported?
14:49:48 <rafa> dawn_: I'm fine with what djazayeri suggested :)
14:49:57 <rafa> dawn_: I'll contact mseaton
14:50:00 <dawn_> rafa: k
14:50:09 <mseaton> uh oh
14:50:20 <dawn_> :D mseaton is here just in time
14:50:28 <rafa> mseaton: I've just e-mailed you :)
14:51:22 <djazayeri> mseaton: about MarkG's 1.9 blocker bug from yesterday (which dkayiwa is now verifying)...
14:51:36 <djazayeri> is the reporting fix straightforward?
14:52:14 <djazayeri> can we assign that to someone ASAP during this sprint, and have them write the code against the reporting 0.7.0 tag, and do just a bugfix release as 0.7.0.1 or something?
14:52:20 <djazayeri> mseaton: ^^
14:52:51 <mseaton> djazayeri: yes, would prefer it not to be me.
14:53:08 <mseaton> (djazayeri: happy birthday)
14:53:36 <djazayeri> mseaton: can you write out the TODOs in the ticket though?
14:54:10 <djazayeri> or rather create a reporting ticket, and link to it here?
14:54:35 <mseaton> djazayeri: well, it'd be better for someone who knows about daemon / scheduler and the proper way to support it in 1.6 and beyond to do it.
14:55:13 <djazayeri> mseaton: are these plain scheduled tasks?
14:55:20 <mseaton> djazayeri, no
14:55:20 <djazayeri> or spring tasks?
14:55:22 <mseaton> spring
14:55:51 <djazayeri> mseaton: what classname should I look at?
14:56:07 <wyclif> dkayiwa, hi
14:56:24 <mseaton> AbstractReportTask I think
14:56:41 <mseaton> then there are 3 or 4 actual scheduled tasks that inherit from this
14:56:59 <djazayeri> perfect
14:57:09 <mseaton> you can see their configuration in moduleApplicationContext.xml
14:57:38 <wyclif> i have noticed a bug in ShortPatientFormValidator, it should ignore voided addresses when validating person addresses
14:57:45 <wyclif> dkayiwa, i have noticed a bug in ShortPatientFormValidator, it should ignore voided addresses when validating person addresses
14:58:03 <djazayeri> wyclif: should that fix be in the validator?
14:58:18 <wyclif> djazayeri, yes in the short patient form validator
14:58:42 <djazayeri> oh, duh, sorry!
14:58:54 <djazayeri> create a ticket for it?
14:59:00 <djazayeri> is it a 1.9 blocker?
14:59:07 <wyclif> djazayeri, yes it is
14:59:59 <djazayeri> wyclif: it's a new bug in 1.9 that wasn't in 1.8?
15:00:04 <wyclif> if you edit an address a new value and then edit again back to the old value, this fails since it will be duplicating the original voided value
15:00:10 <wyclif> djazayeri, not sure
15:00:17 <wyclif> but it is a quick fix
15:00:22 <djazayeri> wyclif: test it on demo
15:00:28 <djazayeri> if it's not new for 1.9, it's not a blcoker
15:00:37 <wyclif> ok
15:01:16 <mathiaslin> MarkG: do you have a minute to talk about the ticket https://tickets.openmrs.org/browse/TRUNK-1640 ?
15:02:18 *** mseaton has quit IRC
15:03:43 *** opieng1 has joined #openmrs
15:03:56 <downey> Hi opieng1 and welcome to the #openmrs IRC channel.
15:04:17 *** mseaton has joined #openmrs
15:04:17 *** ChanServ sets mode: +v mseaton
15:04:29 *** opieng has quit IRC
15:05:15 <wyclif> actually it is there in 1.8
15:05:43 <wyclif> djazayeri, actually it is there in 1.8
15:05:48 <djazayeri> wyclif: okay, so file a bug, but mark it as fixVersion=1.9.1
15:11:43 *** jmiranda has joined #openmrs
15:15:16 *** rafa has quit IRC
15:18:21 <wyclif> djazayeri, actually if i recall this is not a bug, it was intentional, the reason was that instead of creating a new persona address with duplicate fields, just unvoid the duplicate
15:18:37 <wyclif> djazayeri, from the long form
15:19:02 <djazayeri> wyclif: I disagree with the idea of unvoiding the old one
15:19:11 <djazayeri> though it's arguable
15:19:43 <wyclif> djazayeri, the reason is why create two identical address
15:20:22 <wyclif> djazayeri, and i recall we choose that retired/voided metadata should be included when looking up duplicates
15:21:06 <djazayeri> wyclif: though in this case addresses are not metadata, and they're voided, not retired
15:22:24 <wyclif> and i wonder why the long and short form are not consistent, on the long form editing is allowed but on the short form when you edit, the old gets voided and new one is created with the new value
15:22:25 <djazayeri> wyclif: I would argue that if you delete something (i.e. void it), and then re-enter it again, it's (slightly) meaningful to have both, i.e. the old deleted one.
15:22:58 <djazayeri> wyclif: my personal preference would be that neither the long or the short form try to do anything clever, and just create a new address if you enter one
15:23:34 <djazayeri> some other UI might actually show you a voided address, and let you unvoid it, but I disapprove of trying to be clever and unvoiding in the main UI.
15:24:23 <djazayeri> wyclif: the short form does not show voided addresses, right?
15:24:31 <djazayeri> (does it even show multiple addresses?)
15:24:40 <wyclif> djazayeri, the short form only show one address the preferred
15:25:19 <djazayeri> Any idea what the behavior is when you modify that? Does it edit the existing preferred address?
15:27:41 <djazayeri> wyclif: anyway, do create a ticket for this, and move on. :-)
15:29:12 <wyclif> djazayeri, we still need to fix this before releasing 1.9
15:29:21 <djazayeri> wyclif: we do not
15:29:47 <djazayeri> wyclif: if it's a bug in 1.8, then it does not block the release of 1.9.
15:30:49 <djazayeri> 1.9 will definitely have bugs when released (just as 1.8.3 does) and we're not committing to fix all known bugs before we can release...
15:32:09 *** mvorobey has quit IRC
15:32:12 <djazayeri> mseaton: REPORT-367 seems like a blocker; do you want to assess it and include it in the sprint?
15:32:33 <mseaton> djazayeri: will do. in a meeting currently.
15:32:37 <djazayeri> np
15:38:55 *** dawn_ has quit IRC
15:39:41 *** dawn_ has joined #openmrs
15:39:41 *** ChanServ sets mode: +v dawn_
15:40:06 *** dawn__ has joined #openmrs
15:40:06 *** ChanServ sets mode: +v dawn__
15:40:06 *** dawn_ has quit IRC
15:40:07 *** dawn__ is now known as dawn_
15:41:14 <djazayeri> dkayiwa: have you just done a clean 1.9 install with or without demo data?
15:42:22 <mseaton> REPORT-367 looks like a non-reporting-related problem. any ideas djazayeri?
15:43:07 <djazayeri> mseaton: presumably it's exposed by reporting trying to import a particular header page, right?
15:44:21 *** rohitgoyal18 has quit IRC
15:53:07 <sgithens> djazayeri Mark: I think I'm down with the notes on the etherpad page for today.
15:53:29 <sgithens> s/down/done/
15:54:35 <sgithens> err, MarkG
15:55:27 <dkayiwa> djazayeri: are you asking for what i have done to try reproduce Mark's bug?
15:56:08 <djazayeri> dkayiwa: I want to know if the default install with demo data creates GPs for scheduler.username and scheduler.password
15:56:16 <djazayeri> just wondering if you've just done that install?
15:56:28 *** rohitgoyal18 has joined #openmrs
15:56:53 <dkayiwa> djazayeri: yes it creates them
15:57:05 <djazayeri> Ah, I see that now in OpenmrsConstants...
15:57:54 <dkayiwa> djazayeri: though i have not yet been able to reproduce Mark's bug :)
15:57:59 <mseaton> djazayeri: i'm running 1.8.x and don't get the bug in REPORT-367.
15:59:12 <djazayeri> mseaton: meh. okay, I just commented on the ticket asking rafal what version he's running
15:59:22 <mseaton> oh, me too
15:59:37 <djazayeri> great, now he'll learn that he should include that in the initial bug report. ;-)
16:01:07 <dkayiwa> djazayeri: finally reproduce it
16:01:29 <dkayiwa> djazayeri: i had logged in too fast before it had made the lockout number of login attempts
16:03:08 <dkayiwa> djazayeri: as per your email, the GP is always set
16:03:46 *** dawn_ has quit IRC
16:04:08 *** dawn_ has joined #openmrs
16:04:08 *** ChanServ sets mode: +v dawn_
16:04:28 <dkayiwa> djazayeri: why do we store the SCHEDULER_PASSWORD_PROPERTY as clear text?
16:05:25 <dkayiwa> hi wy
16:05:27 <dkayiwa> wyclif:
16:06:15 <wyclif> hi djazayeri
16:06:24 <dkayiwa> wyclif: :D
16:06:28 <wyclif> sorry not djazayeri but dkayiwa
16:06:37 <dkayiwa> :D
16:06:54 <dkayiwa> wyclif: thanks for the tickets. are you going to work on them? :)
16:09:00 *** dawn_ has quit IRC
16:12:33 <wyclif> it depends on their priority and if we want to include them in 1.9
16:12:43 <wyclif> dkayiwa, it depends on their priority and if we want to include them in 1.9
16:12:59 <dkayiwa> wyclif: ok
16:13:15 <wyclif> dkayiwa, they seeme important to me, nice to include in 1.9 even though they exist in 1.8
16:13:16 <dkayiwa> wyclif: would they be easy to fix?
16:13:45 <djazayeri> dkayiwa: I strongly recommend not adding non-blocker issues to 1.9 at this point.
16:14:04 <dkayiwa> djazayeri: ok
16:14:52 <wyclif> i think one is not a blocker
16:15:23 <wyclif> but the one where things get saved to the database when errors are found seems like a blocker
16:15:26 *** dkayiwa has quit IRC
16:16:20 <djazayeri> wyclif, dkayiwa: if it was a bug in 1.8, and is still a bug in 1.9, it is *not* a blocker for 1.9. Even if it seems serious.
16:16:45 <wyclif> ok
16:19:04 *** suranga has joined #openmrs
16:19:04 *** ChanServ sets mode: +v suranga
16:19:22 *** dkayiwa has joined #openmrs
16:22:47 *** MarkG has quit IRC
16:30:00 <djazayeri> downey: btw, the current discussion on "possible 1.9 blocker bug" is basically impossible to have effectively on the dev list because of the mail delivery delay
16:31:03 <downey> djazayeri: sounds like time to move it to IRC or a dev meeting
16:31:16 <djazayeri> downey: burke isn't on irc
16:32:05 <djazayeri> and "wait for a dev meeting" isn't a solution for discussing blocker bugs. :-)
16:33:03 <downey> djazayeri: yeah, i'd hope not. :) e-mail has never been suitable for real-time group discussions. too many variables baked in to its design
16:35:06 <djazayeri> downey: yeah, but as long as the messages are delivered in a timely fashion, it basically works
16:35:42 <djazayeri> downey: I'm just saying that as soon as we can get to google groups for our mailing lists, and get rid of the annoying delay, it will improve things a lot.
16:35:52 <downey> djazayeri: +infinity to that :)
16:47:35 <suranga> hi pulasthi7
16:47:45 <suranga> pulasthi7, i was looking at https://tickets.openmrs.org/browse/PTM-59
16:48:07 <pulasthi7> hi suranga
16:49:13 <suranga> pulasthi7, I was trying to recreate this bug... mm.. could you please give me the steps that will result in a file with .xml.xml ? :)
16:49:32 *** MarkG has joined #openmrs
16:50:31 <pulasthi7> when saving the configuration file, select an existing xml file to overwrite.
16:51:55 <pulasthi7> then instead of replacing that file, it will create a new file appending .xml after the given file.
16:54:35 <suranga> pulasthi7, oh, right ! u mean the swing interface !
16:54:54 <pulasthi7> suranga :yes.
16:54:59 <suranga> i was trying the web interface :P
17:01:38 *** p_m has joined #openmrs
17:02:29 *** snoppy has quit IRC
17:02:49 *** dawn_ has joined #openmrs
17:03:01 *** ChanServ sets mode: +v dawn_
17:03:43 *** nribeka has quit IRC
17:04:25 *** wyclif has quit IRC
17:04:49 *** lh has quit IRC
17:05:53 *** p_m has quit IRC
17:06:10 *** p_m has joined #openmrs
17:08:48 *** dawn_ has quit IRC
17:15:03 *** p_m has quit IRC
17:16:24 *** inane has joined #openmrs
17:16:30 * inane waves cautiously
17:16:35 <downey> Hi inane and welcome to the #openmrs IRC channel.
17:16:46 <inane> downey, are you a bot?
17:17:00 <downey> inane: Only when I haven't had enough caffeine. :)
17:17:15 <inane> just making sure (+:
17:17:20 <downey> :)
17:17:48 <inane> do you use openMRS frequently?
17:18:00 *** p_m has joined #openmrs
17:19:02 <downey> inane: I help out with the people who are building it :)
17:20:45 <mathiaslin> hm, i'm sending emails to the dev mailing list, i see them in the web-based archive, but not receiving them in my inbox myself, nor are they in my spam folder (only happens since today)... weird. are they getting through?
17:20:59 <downey> mathiaslin: I'll check. Are you subscribed to the list?
17:21:39 <downey> mathiaslin: Last one from you was at Wed, 11 Apr 2012 19:24:19 +0800
17:22:08 *** p_m has quit IRC
17:22:39 <mathiaslin> downey: yes i'm subscribed. i'm getting mails from others. i also got my own mail i sent one/two days ago, but not today (today = subject: "Regarding ticket TRUNK-1640: Add roles-based form display feature"
17:22:47 *** dawn_ has joined #openmrs
17:23:27 <mathiaslin> maybe a tmp issue, i'll check again tomorrow. just wanted to make sure they at least get through
17:23:44 <downey> mathiaslin: Actually, I see that one too.
17:23:50 <mathiaslin> ok
17:24:15 *** rohitgoyal18 has quit IRC
17:24:28 <downey> mathiaslin: let me check one more thing.
17:25:29 <downey> mathiaslin: OK, you are in fact still set to receive copies of your own postings
17:25:46 <mathiaslin> downey: (i'm using gmail to send, where it's sending on behalf of my other (subscribed) address. but that shouldn't be an issue i think.)
17:26:05 <mathiaslin> alright i just wait and see if it's just a temporary issue
17:26:09 <downey> mathiaslin: no, it shouldn't matter.
17:27:23 *** p_m has joined #openmrs
17:31:33 *** mseaton has quit IRC
17:32:04 *** p_m has quit IRC
17:32:08 <inane> back. had to run to put left-overs away
17:32:14 *** p_m has joined #openmrs
17:32:51 <inane> i'm not building it. more like trying to customize it for a friend who seeks to use it in a research project
17:36:44 *** p_m has quit IRC
17:39:15 *** mseaton has joined #openmrs
17:39:15 *** ChanServ sets mode: +v mseaton
17:40:34 *** lh has joined #openmrs
17:40:34 *** lh has joined #openmrs
17:46:51 <dkayiwa> hi djazayeri
17:51:14 *** p_m has joined #openmrs
17:51:21 <djazayeri> hi dkayiwa
17:51:34 <dkayiwa> djazayeri: are you working on the reporting module fix?
17:51:43 <djazayeri> dkayiwa: about to commit
17:51:50 <djazayeri> and release a new module version
17:51:50 <dkayiwa> djazayeri: ok thanks
17:54:21 *** mathiaslin has quit IRC
17:59:21 *** p_m has quit IRC
18:06:13 *** wyclif has joined #openmrs
18:06:32 *** nribeka has joined #openmrs
18:06:32 *** ChanServ sets mode: +v nribeka
18:08:38 *** nribeka has quit IRC
18:09:52 *** nribeka has joined #openmrs
18:09:52 *** ChanServ sets mode: +v nribeka
18:26:17 *** snoppy has joined #openmrs
18:26:27 *** dkayiwa has quit IRC
18:29:59 *** dkayiwa has joined #openmrs
18:36:37 *** pulasthi7 has quit IRC
18:40:01 *** r_friedman has quit IRC
18:49:33 *** p_m has joined #openmrs
19:06:58 <finbrein> Hi djazayeri: I added patches for the following tickets: TRUNK-3219, TRUNK-3205 & TRUNK-2803. Please take a look for feedbacks when you get a chance.
19:14:56 <suranga> got to sign off for the day guys.. see you tomorrow........
19:15:01 *** suranga has quit IRC
19:26:16 *** inane has quit IRC
19:29:50 *** james_regen has left #openmrs
19:54:19 *** sgithens has quit IRC
19:57:14 *** sgithens has joined #openmrs
20:01:48 *** chopin_ has joined #openmrs
20:01:51 *** sgithens has quit IRC
20:09:35 *** bryq has quit IRC
20:23:18 *** jmiranda has quit IRC
20:26:33 *** dkayiwa has quit IRC
20:28:26 *** dkayiwa has joined #openmrs
20:36:11 *** chopin_ has quit IRC
20:38:43 <dkayiwa> djazayeri: will you tell me after releasing a new version of the reporting module?
20:43:49 <djazayeri> dkayiwa: I will, sorry, stuck in calls right now
20:48:06 <dkayiwa> djazayeri: ok
21:08:38 *** finbrein has quit IRC
21:12:37 *** nribeka has quit IRC
21:14:56 *** finbrein has joined #openmrs
21:32:16 *** snoppy has left #openmrs
21:49:57 *** p_m has quit IRC
21:52:58 *** dkayiwa_ has joined #openmrs
21:54:38 *** dkayiwa has quit IRC
21:55:05 *** dkayiwa_ is now known as dkayiwa
21:59:08 *** mseaton has left #openmrs
22:14:46 *** wyclif has quit IRC
22:23:31 *** dkayiwa has quit IRC
22:25:03 *** dkayiwa has joined #openmrs
22:30:51 *** MarkG has quit IRC
22:31:16 *** MarkG has joined #openmrs
22:31:19 *** harshadura has quit IRC
22:35:56 *** MarkG has quit IRC
22:40:53 *** opieng1 has quit IRC
22:51:14 *** dkayiwa has quit IRC
22:51:54 *** downey has quit IRC
23:14:00 *** wyclif has joined #openmrs
23:58:27 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Reporting 0.7.1.1 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=reporting&ampversion=&amp0.7.1.1>