| 01:04:39 | *** Felipo has joined #openmrs |
| 01:09:57 | *** harshadura has joined #openmrs |
| 01:12:20 | *** mseaton has joined #openmrs |
| 01:12:20 | *** ChanServ sets mode: +v mseaton |
| 01:40:57 | *** mathiaslin has joined #openmrs |
| 01:45:51 | *** Felipo has quit IRC |
| 01:45:51 | *** applecool has quit IRC |
| 02:03:04 | *** harshadura has quit IRC |
| 02:09:53 | *** finbrein has quit IRC |
| 02:13:19 | *** mseaton has quit IRC |
| 02:20:11 | *** applecool has joined #openmrs |
| 02:32:39 | *** applecool has quit IRC |
| 02:38:33 | *** jmiranda has quit IRC |
| 02:40:10 | *** applecool has joined #openmrs |
| 02:48:09 | <r0bby_> lh!!!!!!!!!! |
| 03:15:30 | *** upul` has joined #openmrs |
| 03:15:30 | *** ChanServ sets mode: +v upul` |
| 03:26:24 | *** applecool has quit IRC |
| 03:34:12 | *** suranga has joined #openmrs |
| 03:34:12 | *** ChanServ sets mode: +v suranga |
| 03:34:39 | *** pulasthi7 has joined #openmrs |
| 03:38:53 | <suranga> hi djazayeri ... are u still awake ? :) |
| 03:39:03 | * suranga hopes so :) |
| 03:39:19 | <djazayeri> suranga: it's only 8:40pm. yes |
| 03:39:39 | <suranga> wow, great.. djazayeri , i have a question :) |
| 03:40:42 | <suranga> so im supposed to be sending a hl7 message into the rest module.. the hl7 message will contain either 1. Save patient encounter |
| 03:40:43 | <suranga> 2. Query for previous patient encounter(s) |
| 03:40:43 | <suranga> 3. Get encounter... |
| 03:41:08 | <suranga> can u see any possibility that this works in the current setup ? (which I would need to implement?) |
| 03:41:52 | <suranga> what I read up says it should work fine, and that the HL7 hnandler will convert the message into an object... but I just wanted to check :-) |
| 03:48:42 | <suranga> mm... hi djazayeri (hope he is not at dinner:) |
| 03:48:57 | <djazayeri> hi |
| 03:49:42 | <djazayeri> This window isn't at the top of my attention |
| 03:50:13 | <djazayeri> suranga: you're trying to fetch data? |
| 03:50:16 | <djazayeri> or insert it? |
| 03:50:27 | <suranga> both :-) |
| 03:50:40 | *** rohitgoyal18 has joined #openmrs |
| 03:50:55 | <suranga> djazayeri, i need to save an encounter, retreive it or query for previous |
| 03:51:46 | <djazayeri> so, fetching data won't work (via hl7) because that's not implemented in core |
| 03:51:54 | <djazayeri> though you can obviously fetch data via web services |
| 03:52:49 | <djazayeri> suranga: sending an ORU-R01 (to create an encounter) or an ADT-A28 (create patient) will work |
| 03:53:17 | <djazayeri> one key point is that you need to pass a value for hl7source in the rest call |
| 03:53:34 | <djazayeri> actually, that may not be right |
| 03:53:42 | <djazayeri> anyway, it should work, as far as I know. |
| 03:53:42 | <suranga> djazayeri, .. hmm... so this means, to create I send a HL7 message, and to retreive the data I make a web service call, is it ? :) |
| 03:54:14 | <djazayeri> suranga: are you specifically sending data from a non-OpenMRS system, and that's why you want to use hl7? |
| 03:54:23 | <suranga> djazayeri, mm.. sorry, im a bit mixed up now... |
| 03:54:39 | <suranga> djazayeri, yep, thats the idea... so we need to send via Hl7 :) |
| 03:54:58 | <djazayeri> suranga: you can use web services to post an hl7 message to OpenMRS that will create an encounter |
| 03:55:04 | <djazayeri> as far as I know, that will work |
| 03:55:37 | <suranga> aha ! this is done via a call to POST /openmrs/ws/rest/v1/hl7, with the hl87 mesage in the body, correct ? |
| 03:56:02 | <djazayeri> I believe you need to POST some json content |
| 03:56:41 | <suranga> djazayeri, and you mean to say that I cant retrieve via HL7, but only via a web serivce call, right ? |
| 03:57:10 | <djazayeri> suranga: if you want to retrieve an encounter, you'd do that via GET .../ws/rest/v1/encounter |
| 03:58:02 | <suranga> djazayeri, this would retrive an OpenMRS encounter ojbect, correct ? :) |
| 03:58:06 | <djazayeri> yes |
| 03:58:31 | <djazayeri> suranga: and for what it's worth, the most straightforward way to create an encounter is just by doing a POST to .../encounter |
| 03:58:39 | <djazayeri> but you can do it by hl7 if there's some reason to |
| 03:59:11 | <suranga> djazayeri, i will need to check on that... will consult my boss :-) |
| 03:59:38 | <suranga> djazayeri, but please, one last one... can I do a Query for previous patient encounter(s) using hl7 (or the normal HL7) ? :-) |
| 03:59:59 | <djazayeri> suranga: i guess technically you should be able to fetch back an hl7 message that has been sent to OpenMRS. |
| 04:00:06 | <djazayeri> you can't fetch a general encounter |
| 04:00:50 | <suranga> djazayeri, hmm... so web services wont let me retrive an encounter .....? |
| 04:01:01 | <djazayeri> I mean: if you send an hl7 message to create an encounter, I think you can re-fetch that same hl7 message back |
| 04:01:27 | <suranga> oh, the entire hl7 message is stored in the db after processing ? wow ! |
| 04:01:28 | <djazayeri> but if someone creates an encounter via some other mechanism, you can't get that as hl7 |
| 04:03:16 | <suranga> djazayeri, so if someone creates an encounter via a web service call, I cant get it back as Hl7.... but if I create the encounter using HL7, then I can retreive that old Hl7 message back, OR the encounter object via a web services call ? |
| 04:03:27 | <djazayeri> yes |
| 04:03:34 | <suranga> djazayeri, awesomeee! |
| 04:07:41 | *** rohitgoyal18 has quit IRC |
| 04:14:31 | *** lh has quit IRC |
| 04:14:35 | *** suranga has quit IRC |
| 04:20:04 | *** rohitgoyal18 has joined #openmrs |
| 04:36:03 | *** rohitgoyal18 has quit IRC |
| 04:43:28 | *** suranga has joined #openmrs |
| 04:43:28 | *** ChanServ sets mode: +v suranga |
| 04:54:19 | <suranga> mm.. hi djazayeri ... still there ? :) |
| 05:26:14 | *** goutham has joined #openmrs |
| 05:32:14 | *** deadpool has quit IRC |
| 05:42:55 | *** Teddy_ has joined #openmrs |
| 05:44:17 | *** deadpool has joined #openmrs |
| 05:48:25 | <Teddy_> What is the replacement for Activator class coz its seen as depricated |
| 05:49:07 | *** rohitgoyal18 has joined #openmrs |
| 05:50:16 | *** finbrein has joined #openmrs |
| 05:56:52 | *** bryq has joined #openmrs |
| 05:56:52 | *** ChanServ sets mode: +v bryq |
| 05:57:35 | *** rohitgoyal18 has quit IRC |
| 06:05:49 | *** snoppy has joined #openmrs |
| 06:06:15 | *** bryq has quit IRC |
| 06:14:50 | <goutham> Teddy_:guess replacement for activator class is org.openmrs.module.ModuleActivator |
| 06:20:53 | *** deadpool_ has joined #openmrs |
| 06:20:55 | *** mathiaslin has quit IRC |
| 06:24:19 | *** deadpool has quit IRC |
| 06:32:32 | *** mathiaslin has joined #openmrs |
| 06:37:18 | <Teddy_> goutham: Thanks |
| 06:40:01 | *** goutham has quit IRC |
| 06:40:53 | *** pulasthi7 has quit IRC |
| 06:41:13 | *** deadpool_ has quit IRC |
| 06:41:59 | *** deadpool_ has joined #openmrs |
| 06:43:46 | *** Teddy_ has quit IRC |
| 06:47:27 | *** goutham has joined #openmrs |
| 06:52:32 | *** applecool has joined #openmrs |
| 06:53:40 | *** suranga has quit IRC |
| 07:01:47 | *** dkayiwa has joined #openmrs |
| 07:09:53 | *** deadpool has joined #openmrs |
| 07:12:14 | *** deadpool_ has quit IRC |
| 07:22:18 | <applecool> hi dkayiwa |
| 07:22:26 | <dkayiwa> hi applecool |
| 07:22:32 | <applecool> i added some patches |
| 07:23:37 | <applecool> the update form schema is a small project |
| 07:23:46 | <applecool> cant we merge it with the filters |
| 07:23:52 | <applecool> as an extra credit |
| 07:24:09 | <dkayiwa> applecool: small for GSOC? |
| 07:24:38 | <applecool> i mean three months is a long time |
| 07:24:41 | <applecool> isnt it |
| 07:24:58 | <dkayiwa> applecool: less than that |
| 07:26:16 | <applecool> all my tickets are "In Progress" |
| 07:26:23 | <applecool> would that be OK ? |
| 07:26:43 | <applecool> i am having my internal exams going on and wont be able to solve any more of them |
| 07:26:51 | *** deadpool_ has joined #openmrs |
| 07:27:22 | <applecool> how was you easter dkayiwa |
| 07:27:45 | <dkayiwa> applecool: was a beautiful one. spent it with my parents at their country home :) |
| 07:27:50 | <dkayiwa> applecool: how was yours? |
| 07:28:06 | <applecool> i was busy with my exam preparation |
| 07:28:14 | <applecool> :( |
| 07:30:21 | <applecool> dkayiwa: i tried to give provide as much information as i could |
| 07:30:38 | <applecool> anything that i can do |
| 07:30:48 | *** deadpool has quit IRC |
| 07:32:24 | <applecool> but in the update form schema we would be changing the existing page itself right |
| 07:32:34 | <applecool> dkayiwa: |
| 07:32:50 | <applecool> I estimated very less time in my proposal |
| 07:33:30 | *** Teddy_ has joined #openmrs |
| 07:34:16 | <dkayiwa> applecool: when estimating time for software development, we are always advised to more than double what we think it could take us :) |
| 07:34:40 | <applecool> oh... |
| 07:34:47 | <applecool> would that affect my porposal |
| 07:34:54 | <applecool> i cant change it now :( |
| 07:35:22 | <applecool> i know this time the competetion is very tough |
| 07:35:35 | <applecool> still would try my luck ;) |
| 07:40:56 | *** deadpool has joined #openmrs |
| 07:44:21 | *** deadpool_ has quit IRC |
| 07:51:17 | <applecool> dkayiwa: any further feedback ? |
| 07:51:40 | <dkayiwa> applecool: will give it along the way |
| 07:51:52 | <applecool> didnt get you |
| 07:52:06 | <dkayiwa> applecool: meaning will give if anything crosses my mind |
| 07:52:27 | <dkayiwa> applecool: in the meantime, you can fix as many tickets as you can :) |
| 07:54:06 | <applecool> that would be difficult at the moment , coz i am having my exams , would try fixing them as soon as i am done with them |
| 07:54:11 | <applecool> till then tc |
| 07:54:18 | *** applecool has quit IRC |
| 08:06:55 | *** deadpool has quit IRC |
| 08:20:10 | *** deadpool has joined #openmrs |
| 08:27:55 | *** rafa has joined #openmrs |
| 08:28:00 | *** ChanServ sets mode: +v rafa |
| 08:53:59 | *** dkayiwa has quit IRC |
| 08:54:11 | *** Teddy_ has quit IRC |
| 08:58:54 | *** Teddy_ has joined #openmrs |
| 09:08:10 | *** bryq has joined #openmrs |
| 09:08:10 | *** ChanServ sets mode: +v bryq |
| 09:13:25 | *** deadpool has quit IRC |
| 09:21:09 | *** dkayiwa has joined #openmrs |
| 09:24:23 | <dkayiwa> hi rafa |
| 09:24:29 | <rafa> hi djazayeri |
| 09:24:34 | <rafa> hi dkayiwa :) |
| 09:24:48 | <dkayiwa> rafa: how was your long weekend? :) |
| 09:25:41 | <rafa> dkayiwa: good, thanks! yours? |
| 09:26:03 | <dkayiwa> rafa: great too :) |
| 09:26:21 | <dkayiwa> rafa: do you have any 1.9 tickets that you are still working on? |
| 09:26:32 | <dkayiwa> rafa: or did you finish them all? |
| 09:26:42 | <rafa> dkayiwa: no, I finished last week |
| 09:27:11 | <rafa> dkayiwa: can you test the rth module? |
| 09:27:24 | <dkayiwa> rafa: ok |
| 09:27:37 | <rafa> dkayiwa: it worked for me, but if I remember right you reported some problems |
| 09:27:52 | <rafa> dkayiwa: I'm curious if my fixes will work for you |
| 09:28:04 | <dkayiwa> rafa: it works perfectly for small databases :) |
| 09:28:16 | *** deadpool has joined #openmrs |
| 09:28:25 | <dkayiwa> rafa: did you try a big one like the one we had for the pentaho sprint? |
| 09:28:39 | <rafa> dkayiwa: yes, I tried that and it worked |
| 09:29:18 | <dkayiwa> rafa: oh, did it work only after your fixes? or even before? :) |
| 09:29:28 | <rafa> dkayiwa: after the fixes |
| 09:29:39 | <dkayiwa> rafa: cool, will test it again today |
| 09:30:05 | <rafa> dkayiwa: &zeroDateTimeBehavior=convertToNull is still necessary |
| 09:30:13 | <dkayiwa> rafa: ok |
| 09:30:23 | <rafa> dkayiwa: I added it to the rth wiki |
| 09:30:34 | <dkayiwa> rafa: did you notice my comment on the ticket about BLOBS? |
| 09:31:18 | <rafa> dkayiwa: I don't remember |
| 09:31:36 | <dkayiwa> rafa: just sent it a few mins ago :) |
| 09:31:46 | <rafa> dkayiwa: ohh then no :) |
| 09:31:59 | <dkayiwa> rafa: 8) |
| 09:33:10 | <rafa> dkayiwa: I copied that part over from the sync module |
| 09:33:29 | <rafa> dkayiwa: I'm not sure what is the purpouse of that cast |
| 09:33:40 | <rafa> dkayiwa: I'll think it over |
| 09:34:21 | <dkayiwa> rafa: it completely changes the data :) |
| 09:35:41 | <rafa> dkayiwa: how do you compare it? |
| 09:38:10 | <rafa> dkayiwa: in.read() returns a byte so casting it to char shouldn't change it |
| 09:40:16 | <dkayiwa> rafa: when i looked at the data in the sql dump file |
| 09:40:23 | <dkayiwa> rafa: they look very very different |
| 09:40:32 | <rafa> dkayiwa: but from what? |
| 09:41:06 | <dkayiwa> rafa: the two output.print(char c) from output.print(int i) |
| 09:42:03 | <rafa> dkayiwa: ohh that should be different |
| 09:42:11 | <dkayiwa> rafa: in.read() returns an integer |
| 09:42:47 | <rafa> dkayiwa: yes, but we need to encode it for a dump file as char |
| 09:42:48 | <dkayiwa> rafa: so after casting to char, we are using output.print(char c) instead of output.print(int i) |
| 09:43:16 | <dkayiwa> rafa: ok |
| 09:43:21 | <rafa> dkayiwa: we should check if after import it's decoded correctly |
| 09:43:29 | <dkayiwa> rafa: sure |
| 09:43:47 | <rafa> dkayiwa: i.e. if the source is the same as the destination |
| 09:43:59 | <dkayiwa> rafa: correct |
| 09:44:32 | <rafa> dkayiwa: I copied the code over and I assumed it's right, but it's worth checking |
| 09:44:43 | <dkayiwa> rafa: ok |
| 09:45:52 | <rafa> dkayiwa: formentry_xsn uses longblob |
| 09:48:45 | <dkayiwa> rafa: ok |
| 09:50:26 | *** upul` has quit IRC |
| 09:57:56 | <rafa> dkayiwa: when I try to open a form to enter I get 2012-04-10 11:55:55.460::WARN: /openmrs/moduleServlet/formentry/formDownload |
| 09:57:57 | <rafa> java.lang.UnsupportedOperationException: Templates no longer exist on Forms. Use Form Attributes. |
| 09:58:12 | <rafa> dkayiwa: do you know how to go around that issue? |
| 09:59:00 | *** kmit has joined #openmrs |
| 09:59:37 | <dkayiwa> rafa: ok |
| 09:59:41 | <kmit> \nick Maurya |
| 09:59:48 | *** kmit is now known as maurya |
| 09:59:58 | <maurya> hi sgithens_ |
| 10:00:01 | <dkayiwa> rafa: does it allow you enter the data |
| 10:00:25 | <rafa> dkayiwa: no it displays the 500 error page |
| 10:00:53 | <rafa> dkayiwa: I can't open the form |
| 10:00:56 | <dkayiwa> rafa: which version of openmrs |
| 10:01:17 | <rafa> dkayiwa: the latest and imported forms from 1.6 pentaho |
| 10:01:45 | <dkayiwa> rafa: are you using htmlformentry? |
| 10:02:03 | <rafa> dkayiwa: no it's form entry |
| 10:02:43 | <dkayiwa> rafa: the latest formentry module? |
| 10:03:28 | <rafa> dkayiwa: it's the one from 1.6 packaged by the rth module I guess |
| 10:03:32 | <dkayiwa> i think formentry is not yet fixed |
| 10:03:32 | <dkayiwa> that is why we have not even bundled it |
| 10:03:41 | <rafa> dkayiwa: ohh I see |
| 10:03:45 | <rafa> dkayiwa: ok |
| 10:04:02 | <rafa> dkayiwa: then I need a different way to test if blob is transfered correctly |
| 10:04:21 | <dkayiwa> rafa: yes |
| 10:04:42 | *** docaeby has joined #openmrs |
| 10:05:15 | *** deadpool has quit IRC |
| 10:06:04 | *** pulasthi7 has joined #openmrs |
| 10:06:22 | <docaeby> Hello? |
| 10:06:57 | *** deadpool has joined #openmrs |
| 10:07:18 | <docaeby> I'm an obstetrician/gynecologist and working on a masters in ETEC. How can I get involved in OpenMRS? |
| 10:08:11 | *** bryq has quit IRC |
| 10:08:14 | <rafa> docaeby: welcome! See http://openmrs.org/help/ |
| 10:08:40 | <docaeby> Thanks! |
| 10:12:13 | <docaeby> I'll be back! |
| 10:12:32 | *** docaeby has quit IRC |
| 10:13:46 | *** Teddy_ has quit IRC |
| 10:15:03 | *** deadpool has quit IRC |
| 10:27:05 | *** deadpool has joined #openmrs |
| 10:36:41 | *** maurya has quit IRC |
| 10:42:33 | *** deadpool has quit IRC |
| 10:44:13 | *** anu_GSOC has joined #openmrs |
| 10:56:23 | *** deadpool has joined #openmrs |
| 11:00:05 | *** deadpool_ has joined #openmrs |
| 11:00:36 | *** james_regen has joined #openmrs |
| 11:00:36 | *** ChanServ sets mode: +v james_regen |
| 11:00:46 | *** deadpool has quit IRC |
| 11:05:16 | <rafa> dkayiwa: hi |
| 11:37:26 | <dkayiwa> hi rafa |
| 11:37:47 | <rafa> dkayiwa: blobs are wrong indeed |
| 11:38:06 | <rafa> dkayiwa: we may need to encode them in hex |
| 11:38:07 | <dkayiwa> rafa: aha tell me |
| 11:38:15 | <dkayiwa> rafa: oh yah |
| 11:38:38 | <dkayiwa> thats the way of transfering blobs as char |
| 11:38:49 | <dkayiwa> rafa: makes perfect sense |
| 11:39:46 | <dkayiwa> so rafa are you working on that now? |
| 11:39:49 | <rafa> dkayiwa: yes |
| 11:39:57 | <dkayiwa> rafa: ok |
| 11:56:18 | *** nribeka has joined #openmrs |
| 11:56:18 | *** ChanServ sets mode: +v nribeka |
| 12:16:58 | <deadpool_> hey has anyone noticed that the mrn number generator jumps some numbers |
| 12:17:06 | <deadpool_> has anyone found a reason why it does that? |
| 12:25:42 | *** mathiaslin has quit IRC |
| 12:44:46 | *** deadpool_ has quit IRC |
| 12:49:44 | *** mathiaslin has joined #openmrs |
| 12:51:38 | *** snoppy has quit IRC |
| 12:54:17 | <dkayiwa> hi rafa |
| 12:54:25 | <rafa> dkayiwa: hi |
| 12:54:27 | <dkayiwa> rafa: can you assign yourself to RELTEST-21 |
| 12:54:33 | <rafa> dkayiwa: ok |
| 12:54:42 | <dkayiwa> rafa: thanks |
| 12:57:34 | *** deadpool_ has joined #openmrs |
| 12:58:12 | *** sthaiya has joined #openmrs |
| 12:58:22 | <dkayiwa> rafa: did you see my comment for TRUNK-3241 ? |
| 12:58:50 | *** sthaiya has quit IRC |
| 12:59:43 | <rafa> dkayiwa: it may be I forgot to run the formatter |
| 12:59:52 | *** mvorobey has joined #openmrs |
| 12:59:56 | *** anu_GSOC has quit IRC |
| 13:00:23 | <dkayiwa> rafa: ok, would that require another commit after formatting? |
| 13:00:43 | <mvorobey> hi all |
| 13:00:51 | <dkayiwa> hi |
| 13:03:52 | *** deadpool_ has quit IRC |
| 13:06:56 | *** mseaton has joined #openmrs |
| 13:06:56 | *** ChanServ sets mode: +v mseaton |
| 13:07:02 | *** deadpool_ has joined #openmrs |
| 13:11:25 | <dkayiwa> rafa: do you have sometime to commit the formatted code :) |
| 13:17:23 | *** sgithens_ has quit IRC |
| 13:19:12 | <dkayiwa> hi mseaton |
| 13:19:21 | <dkayiwa> mseaton: do you think we can now close TRUNK-1727? |
| 13:19:27 | <dkayiwa> !ticket TRUNK-1727 |
| 13:19:28 | <OpenMRSBot> dkayiwa: [#TRUNK-1727] Inconsistencies between exiting a patient from care and marking them as deceased - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-1727 |
| 13:22:05 | *** snoppy has joined #openmrs |
| 13:25:14 | *** pulasthi7 has quit IRC |
| 13:25:43 | *** deadpool_ has quit IRC |
| 13:29:01 | *** dawn_ has joined #openmrs |
| 13:29:09 | *** ChanServ sets mode: +v dawn_ |
| 13:34:44 | <mvorobey> mseaton, hi |
| 13:37:06 | *** goutham has quit IRC |
| 13:43:35 | *** deadpool_ has joined #openmrs |
| 13:47:09 | *** bryq has joined #openmrs |
| 13:47:09 | *** ChanServ sets mode: +v bryq |
| 13:47:48 | *** dkayiwa has quit IRC |
| 13:50:41 | *** dkayiwa has joined #openmrs |
| 13:50:43 | *** rohitgoyal18 has joined #openmrs |
| 13:50:49 | *** Jibesh has joined #openmrs |
| 13:59:19 | *** MarkG has joined #openmrs |
| 14:00:33 | <dawn_> !scrumon dawn |
| 14:00:33 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready. |
| 14:00:36 | <dawn_> Hi Team! |
| 14:00:52 | <dawn_> Today's order: wyclif , sgithens , rafa , mvorobey , mseaton, dkayiwa , djazayeri |
| 14:00:59 | <rafa> hi! |
| 14:01:09 | <mvorobey> hi, dawn_ |
| 14:01:16 | <sgithens> word |
| 14:01:24 | <dawn_> :D |
| 14:01:36 | <wyclif> Monday: |
| 14:01:36 | <wyclif> * REPORT-49 - Add a mechanism for tagging / categorizing reports and other reporting elements |
| 14:01:36 | <wyclif> * GSoC appication reviews |
| 14:01:36 | <wyclif> Tuesday: |
| 14:01:36 | <wyclif> * TRUNK-2442 - Person attributes do not display on patient search results |
| 14:01:37 | <wyclif> * HTML-71 - Add search to location selector |
| 14:01:39 | <wyclif> Blockers: None |
| 14:02:02 | <dawn_> sgithens: your turn |
| 14:02:06 | <sgithens> !ticket REPORT-337 |
| 14:02:06 | <sgithens> Filling in portlet contents |
| 14:02:06 | <sgithens> Will have some questions in a bit about the |
| 14:02:06 | <sgithens> right hand side of the dialog. |
| 14:02:07 | <sgithens> No blockers. |
| 14:02:07 | <OpenMRSBot> sgithens: [#REPORT-337] Improve UI of the Report Evaluation Page - OpenMRS JIRA - https://tickets.openmrs.org/browse/REPORT-337 |
| 14:02:21 | <mvorobey> * Re-worked REPORT-312 as portlet |
| 14:02:21 | <mvorobey> * Work in progress - REPORT-353 |
| 14:02:21 | <mvorobey> * No blockers |
| 14:02:26 | <rafa> Today: |
| 14:02:26 | <rafa> * Started with REPORT-242: Update reporting dashboard UI to better support systems with lots of reports in a variety of categories |
| 14:02:26 | <rafa> https://tickets.openmrs.org/browse/REPORT-242 |
| 14:02:26 | <rafa> * Committed RELTEST-21: BLOB data is not properly dumped when using the Test Installation method |
| 14:02:26 | <rafa> https://tickets.openmrs.org/browse/RELTEST-21 |
| 14:02:26 | <rafa> No blockers. |
| 14:02:46 | <dawn_> mseaton: you turn :) |
| 14:03:53 | <dawn_> dkayiwa: let's skip over mike. can you share your updates now, please? :) |
| 14:04:10 | <dkayiwa> Did some 1.9 RC3 ticket administration |
| 14:04:11 | <dkayiwa> Did code review and closed most of the remaining 1.9 RC3 post commits |
| 14:04:11 | <dkayiwa> Now working on: Location hierarchy, tree widget, should be used by the Reporting Module - REPORT-287 |
| 14:04:12 | <dkayiwa> No Blockers |
| 14:04:34 | <dawn_> djazayeri: you turn :) |
| 14:04:40 | <dkayiwa> r |
| 14:04:53 | <djazayeri> Monday 09-Apr-2012 |
| 14:04:53 | <djazayeri> * (worked on) UIFR-7 (Modules need to be able to provide resources) |
| 14:04:53 | <djazayeri> * (worked on) Create UI Widget Library module so I can finish fixing the UI Framework docs |
| 14:04:53 | <djazayeri> * Created TRUNK-3271, TRUNK-3270 |
| 14:04:53 | <djazayeri> * Created EMMA-24 (required modules should have scope=provided) |
| 14:04:53 | <djazayeri> * Quick Bug-Fixer JIRA query for wyclif |
| 14:04:53 | <djazayeri> * Meeting with Jan from ITech |
| 14:04:54 | <djazayeri> Tuesday 10-Apr-2012 |
| 14:04:55 | <djazayeri> * Finish UIFR-7 |
| 14:04:55 | <djazayeri> * Finish UI Widget Library module |
| 14:04:56 | <djazayeri> * More work on REPORT-330 |
| 14:04:56 | <djazayeri> * Prepare for University call tomorrow (about git) |
| 14:05:44 | <dawn_> djazayeri: any blockers? |
| 14:05:50 | <dawn_> mseaton: you there? |
| 14:05:52 | <sgithens> git++ |
| 14:06:09 | <djazayeri> a bit stuck on UIFR-7, and trying to reimplement something similar to to ModuleResourcesServlet |
| 14:06:13 | <djazayeri> but I'll figure it out |
| 14:06:48 | <dawn_> !scrumoff dawn |
| 14:06:48 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 14:07:06 | <dawn_> Discussion points: 1) dkayiwa : update on 1.9 release 2) mseaton update on sprint progress overall |
| 14:07:48 | <dkayiwa> dawn_: waiting for rafa to finish the BLOB issue on release testing helper module |
| 14:07:53 | *** mathiaslin has joined #openmrs |
| 14:08:12 | <rafa> dkayiwa: I committed it a sec ago |
| 14:08:25 | <dkayiwa> rafa: oh thanks |
| 14:08:27 | <dkayiwa> :) |
| 14:09:04 | <dkayiwa> rafa: can you also respond to TRUNK-3241 ? |
| 14:09:19 | <rafa> dkayiwa: !ticket TRUNK-3241 |
| 14:09:21 | <dawn_> dkayiwa: now that rafa committed that ticket, what else needs to be done? |
| 14:09:26 | <rafa> !ticket TRUNK-3241 |
| 14:09:27 | <OpenMRSBot> rafa: [#TRUNK-3241] PersonAddresses get voided and recreated on form submission - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3241 |
| 14:09:57 | <dkayiwa> dawn_: waiting on rafa and wyclif response on TRUNK-3242 |
| 14:10:28 | <deadpool_> djazayeri: can i ask you a mysql question? |
| 14:10:42 | <deadpool_> i have a manual counter for patient ids |
| 14:10:43 | <rafa> !ticket TRUNK-3242 |
| 14:10:45 | <OpenMRSBot> rafa: [#TRUNK-3242] Overview tab on patient dashboard fails to load when patient has been exited from care - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3242 |
| 14:11:04 | <deadpool_> sometimes it skips the ids i think because sometimes the transactions fail and it doesn't commit |
| 14:11:18 | <djazayeri> dkayiwa: TRUNK-3242 seems like it has already been backported to 1.9.x, right? |
| 14:11:37 | <djazayeri> deadpool_: okay, so what's the question? |
| 14:11:50 | <djazayeri> deadpool_: (that sounds plausible) |
| 14:12:30 | <dkayiwa> djazayeri: yes |
| 14:12:39 | <deadpool_> so my question is that the counter skips numbers sometimes which is kinda annoying |
| 14:12:48 | <deadpool_> how do we stop a failed transaction |
| 14:12:57 | <deadpool_> or rollback |
| 14:12:59 | <deadpool_> so the counter doesn't get updated |
| 14:13:21 | <djazayeri> dkayiwa: so, what are we actually waiting on for 1.9 RC3? |
| 14:13:29 | <wyclif> hi mseaton |
| 14:14:18 | <dkayiwa> djazayeri: testing and then release RC3 |
| 14:14:58 | <djazayeri> deadpool_: there's no general way to do that; depends on what your code looks like. But if you're relying on the internal patient_id primary key being meaningful, that's bad style. |
| 14:15:27 | <deadpool_> i am using the mrn generator |
| 14:15:31 | <deadpool_> and that is what it is using |
| 14:15:46 | <djazayeri> deadpool_: i.e. you shouldn't care if the primary key column skips some values. |
| 14:15:56 | <djazayeri> deadpool_: oh, not the pk, you mean the identifiers... |
| 14:16:23 | <dawn_> dkayiwa: does that mean another week of testing since we were waiting on a couple of tickets? |
| 14:16:53 | <dkayiwa> dawn_: no |
| 14:17:12 | <dkayiwa> dawn_: i plan to release by tmorrow |
| 14:17:21 | <djazayeri> deadpool_: I don't know how that module works; possibly one could tweak the module to reclaim ids if the patient creation fails, but I have no idea. |
| 14:17:36 | <dkayiwa> dawn_: that is assuming you are asking RC3 |
| 14:20:19 | <dawn_> dkayiwa: ah, sorry. i mean the final 1.9 |
| 14:20:54 | <deadpool_> djazayeri: thanks i will look online to see how to do it |
| 14:24:07 | <dkayiwa> dawn_: yes after one week |
| 14:30:52 | *** MarkG has quit IRC |
| 14:33:47 | <mseaton> hi wyclif |
| 14:33:54 | *** deadpool_ has quit IRC |
| 14:34:10 | *** dkayiwa has quit IRC |
| 14:34:53 | *** rohitgoyal18 has quit IRC |
| 14:38:46 | <wyclif> can look at the comments and UI for TRUNK-1727 |
| 14:38:56 | <wyclif> mseaton, can you look at the comments and UI for TRUNK-1727 |
| 14:39:02 | <dawn_> mseaton: how is the overall sprint going from your perspective? do you see any issues that may cause us not to finish on time? |
| 14:41:34 | <mseaton> dkayiwa: regarding TRUNK-1727, i don't have strong opinions and have only been somewhat following. if all involved in this ticket are happy with the result, then i'm happy to have it closed. thanks! |
| 14:44:31 | <mseaton> dawn_ sorry i missed the sprint. things are looking good i think. will have a better answer tomorrow for you. |
| 14:46:29 | *** rohitgoyal18 has joined #openmrs |
| 14:48:18 | *** Felipo has joined #openmrs |
| 14:50:18 | *** deadpool_ has joined #openmrs |
| 14:52:06 | *** deadpool has joined #openmrs |
| 14:52:54 | <dawn_> mseaton: okay. thanks! |
| 14:54:18 | <Felipo> hello |
| 14:54:38 | *** deadpool_ has quit IRC |
| 14:56:59 | *** Jibesh has quit IRC |
| 14:57:19 | <Felipo> i am developing a module and load the jsp but no renderized the content, i use tag lib Form |
| 14:57:45 | *** lh has joined #openmrs |
| 14:57:45 | *** lh has joined #openmrs |
| 14:59:11 | <djazayeri> hola Felipo |
| 14:59:23 | <djazayeri> I don't understand |
| 14:59:49 | <djazayeri> You have a jsp that uses <form:form>â¦, but it isn't working? |
| 15:04:44 | <djazayeri> @Felipo, do you have a controller for the page also? What url are you using to access it? One that ends in .form/.list, or .htm? |
| 15:05:59 | *** jrliey has joined #openmrs |
| 15:11:54 | <Felipo> hi |
| 15:11:58 | <djazayeri> hi |
| 15:12:01 | <djazayeri> (si, aqui!) |
| 15:13:01 | <Felipo> no appears my sent msg |
| 15:13:17 | *** juano has joined #openmrs |
| 15:13:21 | <juano> hi all |
| 15:13:28 | <djazayeri> Felipo: are you getting an error message? |
| 15:13:32 | <djazayeri> on the screen, or in the logs? |
| 15:14:50 | <juano> sorry but i have the next problem in the instalation of openMRS 1,9RC2 and Postgresql |
| 15:14:52 | <juano> Server log file output: WARN - OpenmrsUtil.getRuntimePropertiesFilePathName(2464) |2012-04-10 12:01:22,154| Unable to find properties file: C:\\Application Data\OpenMRS\openmrs (1)-runtime.properties WARN - OpenmrsUtil.getRuntimeProperties(2401) |2012-04-10 12:01:22,155| Unable to find a runtime properties file. Initial setup is needed. View the webapp to run the setup wizard. WARN - OpenmrsUtil.getRuntimePropertiesFilePathName(2438) |
| 15:15:56 | <djazayeri> Felipo: are you using jetty or tomcat? |
| 15:16:09 | <juano> ERROR - Context.getServiceContext(255) |2012-04-10 12:09:49,856| serviceContext is null. Creating new ServiceContext() |
| 15:16:24 | <juano> sorry |
| 15:16:33 | <djazayeri> juano: if it's a long error message, use pastebin! |
| 15:16:53 | <juano> but the specific error is ERROR - Context.getServiceContext(255) |2012-04-10 12:09:49,856| serviceContext is null. Creating new ServiceContext() |
| 15:17:27 | <djazayeri> Felipo: yes, you need to fix that error |
| 15:17:37 | <djazayeri> maybe it should be "email" instead of "Email"? |
| 15:17:58 | <djazayeri> juano: we'd need to see the full error message |
| 15:19:14 | <djazayeri> juano: and I have zero experience using OpenMRS with postgresql... |
| 15:19:18 | <juano> ok the error ... http://pastebin.com/fRVCxTCK |
| 15:19:57 | <djazayeri> juano: did you run the initial setup wizard once? |
| 15:20:51 | *** nribeka has quit IRC |
| 15:21:33 | <juano> yes, you run the wizard and create the tables when you get this erroe in the log. |
| 15:21:37 | *** dawn_ has quit IRC |
| 15:21:57 | <juano> yes, running the wizard and create the tables when you get this erroe in the log. |
| 15:22:12 | <juano> error, sorry |
| 15:22:58 | <djazayeri> juano: can you check whether the runtime properties file that it mentions exists? |
| 15:23:12 | <djazayeri> it seems like you deployed something like "openmrs (1).war" to tomcat? |
| 15:23:41 | <juano> yes |
| 15:23:49 | <juano> openmrs(1).war |
| 15:24:11 | <djazayeri> I assume tomcat is okay with having ( and ) in the context path? |
| 15:25:02 | *** p_m has joined #openmrs |
| 15:25:16 | *** harshadura has joined #openmrs |
| 15:25:34 | *** nribeka has joined #openmrs |
| 15:25:34 | *** ChanServ sets mode: +v nribeka |
| 15:25:40 | <djazayeri> juano: anyway, is there an "openmrs (1)-runtime.properties" file somewhere? |
| 15:25:58 | <djazayeri> it's possible that OpenMRS isn't dealing well with the space and the parens, but I don't know. |
| 15:29:33 | *** deadpool has quit IRC |
| 15:30:09 | *** deadpool has joined #openmrs |
| 15:30:28 | *** rafa has quit IRC |
| 15:33:02 | *** suranga has joined #openmrs |
| 15:33:02 | *** ChanServ sets mode: +v suranga |
| 15:34:27 | <juano> ok thans |
| 15:38:46 | *** juano has quit IRC |
| 15:39:45 | *** p_m has quit IRC |
| 15:53:47 | *** p_m has joined #openmrs |
| 16:05:34 | *** p_m has quit IRC |
| 16:10:24 | *** isharapremadasa has joined #openmrs |
| 16:13:08 | *** snoppy has quit IRC |
| 16:17:15 | *** isharapremadasa is now known as isharap |
| 16:18:44 | <isharap> hi i'm having some problem in testing with TRUNK-248, and need some help in working with hibernate criterias? |
| 16:19:46 | <isharap> i am writing a unit test to check 'prepare a criteria from a patient name and identifier' |
| 16:20:32 | <isharap> for PatientSearchCriteriaTest class prepareCriteriaTest method |
| 16:20:54 | <isharap> i created a session and added a criteria for Patient.class |
| 16:21:28 | <isharap> but i have no clue how this refers to the patient data in a table or whereever |
| 16:22:26 | <isharap> can someone pls tell me where does this criteria look for patient data when it is created? |
| 16:24:33 | *** p_m has joined #openmrs |
| 16:30:13 | *** p_m has quit IRC |
| 16:31:32 | <djazayeri> isharap: have you skimmed http://docs.jboss.org/hibernate/core/3.3/reference/en/html/querycriteria.html ? |
| 16:31:35 | <OpenMRSBot> <http://ln-s.net/9z4b> (at docs.jboss.org) |
| 16:31:46 | <djazayeri> generally the Patient object is mapped to the patient table |
| 16:31:55 | <djazayeri> and it extends the person table |
| 16:32:05 | <djazayeri> so it has a collection of rows in the person_name table, etc |
| 16:35:07 | *** p_m has joined #openmrs |
| 16:39:11 | *** Felipo has quit IRC |
| 16:39:40 | <isharap> Is there any test records table or etc. that i can use with this criteria? as when i create the criteria and calls it with a given name, it always returns an empty list |
| 16:40:02 | <isharap> it is may be that the name doesnt included in the records |
| 16:40:18 | <isharap> however i tried with Context classes entries but didnt succeed |
| 16:40:40 | <djazayeri> isharap: if you're writing a unit test, make sure it extends BaseContextSensitiveTest, and then it will have data (defined in standardTestDataset.xml) |
| 16:40:55 | *** p_m has quit IRC |
| 16:43:11 | <isharap> djazayeri : yes i extended BaseContextSensitiveTest, but i was using PatientServiceTest-findPatients.xml file's data. can't this be done using that? |
| 16:43:24 | <djazayeri> isharap: yes, it can be done using that |
| 16:43:35 | <djazayeri> did you do executeDataSet() ? |
| 16:43:40 | <djazayeri> e.g. in an @Before? |
| 16:43:44 | <djazayeri> or in the test itself? |
| 16:44:17 | <isharap> yes, executeDataSet(FIND_PATIENTS_XML) but inside my test method |
| 16:45:42 | <djazayeri> isharap: then I don't know why doing a criteria query won't find them |
| 16:45:47 | <djazayeri> can you pastebin your test method? |
| 16:45:52 | <djazayeri> or test class? |
| 16:46:24 | <isharap> sure i will do it now |
| 16:46:49 | <mseaton> hi mvorobey |
| 16:47:01 | <mvorobey> mseaton, hi |
| 16:47:28 | <mseaton> mvorobey: good work on the cron widget. unfortunately, i have a few issues and a few requests :) |
| 16:47:49 | <mvorobey> mseaton, go ahead, am listening :) |
| 16:47:57 | <mseaton> how would you prefer to walk through those? here? on the ticket? on the review? |
| 16:48:32 | <mvorobey> mseaton, I would prefer to have them listed on ticket |
| 16:48:40 | <mseaton> ok, will do |
| 16:49:01 | <mvorobey> mseaton, thanks for quick review :) |
| 16:49:16 | <mseaton> one question mvorobey - where did you get that javascript - did you write it yourself? or did you find it online? |
| 16:49:34 | <mvorobey> mseaton, I wrote it by myself |
| 16:49:44 | <mseaton> mvorobey: wow, great. nice! |
| 16:50:52 | <mvorobey> mseaton, You are putting me to the blush :) |
| 16:51:49 | <isharap> djazayeri: http://pastebin.com/RzfGapFy this is the test method |
| 16:54:10 | *** p_m has joined #openmrs |
| 16:54:46 | *** suranga has quit IRC |
| 16:55:18 | *** suranga has joined #openmrs |
| 16:55:59 | <djazayeri> isharap: try moving the executeDataSet to the top of the method |
| 16:56:11 | <djazayeri> and do an assert for ensuring that testpatient is not null |
| 16:56:40 | <djazayeri> if you're getting back a result from there, but not getting back a result from criteria.list(), then you might be calling the criteria wrong |
| 16:57:03 | <djazayeri> isharap: I don't know what the code for PatientSearchCriteria looks like, but is it supposed to be a sub-criteria? or an independent one? |
| 16:58:39 | <isharap> it prepares a criteria by taking the name and identifier of the pateint |
| 16:58:56 | <isharap> wait i will paste it for you djazayeri :) |
| 16:59:09 | <djazayeri> isharap: I don't particularly want to look at it now... |
| 16:59:13 | <djazayeri> :-) |
| 16:59:21 | <djazayeri> that was more of a hint for you |
| 16:59:44 | *** p_m has quit IRC |
| 17:00:50 | *** lh has quit IRC |
| 17:01:39 | <isharap> sure i will try the swapping executeDataSet() and see if anything returns in that case |
| 17:01:39 | <isharap> :) |
| 17:02:20 | <djazayeri> isharap: if you verify that the service call *is* giving you a patient, then the problem is the way you're calling the criteria... |
| 17:02:21 | * suranga sees everyone is busy so goes back to have another go :-) |
| 17:03:11 | *** lh has joined #openmrs |
| 17:05:58 | <isharap> i did debug the code and testpatient is not null, it has all the fields in it. I simply cant get it applied through prepareCriteria methodd |
| 17:07:18 | <isharap> i fel that i am not exactly getting what this prepareCriteria method exactly does :( |
| 17:07:34 | <isharap> is there anyone i can contact for tht? |
| 17:08:04 | <djazayeri> isharap: I'm not sure that method supports giving it both name and identifier |
| 17:08:16 | <djazayeri> isharap: try just giving it one? |
| 17:11:39 | *** p_m has joined #openmrs |
| 17:15:56 | <mvorobey> mseaton, I have couple of questions about your comments on review |
| 17:16:10 | <mseaton> mvorobey: sure, still in progress, but happy to discuss |
| 17:16:43 | <mvorobey> mseaton, ok, then see my replies on your comments :) |
| 17:19:22 | *** p_m has quit IRC |
| 17:20:18 | *** dawn_ has joined #openmrs |
| 17:20:18 | *** ChanServ sets mode: +v dawn_ |
| 17:20:38 | <mvorobey> mseaton, I can not clearly understand what you meant about date format localization on datepicker |
| 17:21:38 | <isharap> djazayeri : i did what you told me and figured out what i have been doing wrong, actually the original method restrcits the voided pateint entries from the criteria, that is why it gave an empty list, i have been using the asserting wrong |
| 17:22:01 | <isharap> will create a patch and add soon with the tests |
| 17:22:09 | <isharap> thanks a lot for the guide :) |
| 17:22:39 | <djazayeri> np |
| 17:32:12 | *** p_m has joined #openmrs |
| 17:32:25 | <suranga> jkeiper, helooo |
| 17:32:30 | <suranga> jkeiper, r u here ? |
| 17:37:14 | *** harshadura has quit IRC |
| 17:42:05 | *** jrliey has left #openmrs |
| 17:43:15 | *** isharap has quit IRC |
| 17:48:14 | *** lh has quit IRC |
| 17:52:06 | *** lh has joined #openmrs |
| 17:52:06 | *** lh has joined #openmrs |
| 17:59:26 | *** p_m has quit IRC |
| 17:59:42 | *** Collins has joined #openmrs |
| 18:00:44 | <Collins> How do I get the name of a location to be displayed in a jsp file in a module? |
| 18:06:52 | *** kernelhunter92 has joined #openmrs |
| 18:11:54 | *** wyclif has quit IRC |
| 18:13:38 | *** p_m has joined #openmrs |
| 18:17:06 | <Collins> How do I get the name of a location to be displayed in a jsp file in a module? |
| 18:28:00 | *** jkeiper has quit IRC |
| 18:40:17 | *** suranga has quit IRC |
| 18:40:17 | <djazayeri> Collins: you mean something like ${ loc.name } ? |
| 18:40:32 | <djazayeri> Collins: or better: <openmrs:formatlocation="${loc}"/> |
| 18:43:02 | *** p_m has quit IRC |
| 18:45:07 | *** rohitgoyal18 has quit IRC |
| 18:46:54 | <Collins> djazayeri: please check the code at http://pastebin.com/NHFbXRLk |
| 18:48:05 | <djazayeri> Collins: what's the question? I see you're iterating over locations, and you are displaying some of their values |
| 18:48:08 | <djazayeri> (properties) |
| 18:49:34 | <Collins> Am trying to display location names on the jsp page. Sorry, the network is shaky over here. |
| 18:49:53 | <djazayeri> Collins: ${ locations.name } should work |
| 18:50:06 | <djazayeri> just like you did with locationId, but use the name property |
| 18:51:10 | <Collins> djazayeri: let me try that. thanks |
| 18:52:08 | <mvorobey> mseaton, have a minute ? |
| 18:52:28 | <mseaton> mvorobey: sure |
| 18:53:52 | <Collins> djazayeri: It worked. Thanks alot |
| 18:54:06 | <mvorobey> mseaton, I am afraid that we can not use dateField widget within our cron editing widget because it loads via iframe that has -index lower that modal window and we can not change iframe z-index at all. may be you know any workaround on this ? |
| 18:56:35 | *** wyclif has joined #openmrs |
| 18:57:21 | <mseaton> mvorobey: if you can't use dateField.tag, then try just using the code that is encapsulated in it. you can see it uses the <openmrs:formatDate.../> tag to display the defaultValue. |
| 18:57:50 | *** deadpool has quit IRC |
| 18:58:26 | *** deadpool has joined #openmrs |
| 19:07:08 | <mvorobey> mseaton, but how it can help us ? |
| 19:07:45 | <mvorobey> mseaton, it won't solve issue with locale specific date format |
| 19:07:55 | <mseaton> mvorobey: it will not? |
| 19:08:47 | <mvorobey> mseaton, jsp tag openmrs:formatDate renders on server, and datepicker works in client browser at least |
| 19:08:54 | *** MarkG has joined #openmrs |
| 19:10:47 | <mvorobey> mseaton, basically, as workaround we can use jquery datepicker and pass <openmrs:datePattern/> as dateFormat to it |
| 19:11:03 | <mseaton> mvorobey: that'll probably work, yes. |
| 19:11:25 | <mvorobey> mseaton, good :) ok |
| 19:11:37 | *** Felipo has joined #openmrs |
| 19:11:59 | <Felipo> Hello, the Module Maven Archetype must be replace the tags in the config.xml and in the messages.properties file?? |
| 19:17:51 | <mvorobey> mseaton, shoot, it still won't work because openmrs date format is dd/mm/yyyy which is not a valid javascript date format (dd/mm/yy) because 4 digits year in javascript has patter yy :( |
| 19:18:15 | <mseaton> mvorobey: i think there is an existing solution here. djazayeri ? |
| 19:20:24 | <mvorobey> mseaton, how about jQuery('#${id}once-scheduleDate').datepicker({ dateFormat : '<openmrs:datePattern/>'.replace('yyyy', 'yy')}); ? |
| 19:20:38 | <djazayeri> mvorobey: look and see how it's done in the htmlformentry module, for example |
| 19:20:45 | <djazayeri> or, presumably, in core |
| 19:21:46 | <mseaton> mvorobey: can you use the dateField.tag widget, and make it's z-index lower by wrapping it in a span? |
| 19:22:51 | <mvorobey> mseaton, will it work ? i think that iframe has own z-index and it does not inherit from span |
| 19:23:16 | <mseaton> mvorobey: i mean to change the z-index of the datepicker |
| 19:24:39 | <mvorobey> mseaton, but openmrs datepicker is provided by iframe and we can not modify it |
| 19:25:21 | <mseaton> mvorobey: maybe with css? |
| 19:25:33 | <mseaton> on it's class? |
| 19:25:48 | <mvorobey> mseaton, we can not modify css of iframe too |
| 19:28:00 | <mvorobey> mseaton, but jQuery('#${id}once-scheduleDate').datepicker({ dateFormat : '<openmrs:datePattern/>'.replace('yyyy', 'yy')}); works fine for me |
| 19:29:12 | <mseaton> mvorobey: leave it this way for now to get it working. we can raise another ticket as needed to convert this to use a standard openmrs datepicker tag in the future. |
| 19:29:49 | <mvorobey> mseaton, ok, it seems to be more reasonable for now |
| 19:30:08 | <mseaton> djazayeri: i want to get REPORT-233 ready for work |
| 19:30:13 | <mseaton> !ticket REPORT-233 |
| 19:30:14 | <OpenMRSBot> mseaton: [#REPORT-233] Reports should have a published vs non-published property, which controls what reports are displayed on Reporting homepage - OpenMRS JIRA - https://tickets.openmrs.org/browse/REPORT-233 |
| 19:30:34 | <mseaton> we have been going back and forth on ticket comments. can we find a resolution? |
| 19:31:33 | <mseaton> and djazayeri, on a related note, should we modify REPORT-49 in some way to support localizing tags for display? |
| 19:31:39 | <mseaton> !ticket REPORT-49 |
| 19:31:40 | <OpenMRSBot> mseaton: [#REPORT-49] Add a mechanism for tagging / categorizing reports and other reporting elements - OpenMRS JIRA - https://tickets.openmrs.org/browse/REPORT-49 |
| 19:31:58 | *** lh has quit IRC |
| 19:32:39 | *** dawn_ has quit IRC |
| 19:34:46 | <djazayeri> mseaton: so, what approach are you suggesting? |
| 19:35:07 | <djazayeri> that we allow messages.properties to do the localization? |
| 19:35:26 | <djazayeri> and that when someone creates one, we do a reverse lookup in messages.properties? |
| 19:36:06 | <mvorobey> mseaton, I finished re-working cron-editing widget as tag and fixed all your comments. Please, see update review on that ticket. |
| 19:36:53 | <mseaton> djazayeri: well, not sure. we could potentially add a property to the DefinitionTag class called "displayCode", which if non-null, tries to display the tag with this message code. or we could do something like the metadata localization project aimed to do, where for displayCode we allow "fr:Oui:en:Yes:es:Si" |
| 19:37:02 | <mseaton> mvorobey: great! will look soon |
| 19:37:12 | <mvorobey> mseaton, thanks :) |
| 19:37:54 | <djazayeri> mseaton: I like the metadata localization project idea, but not sure about putting it into just the reporting module |
| 19:38:06 | <mseaton> but djazayeri, if we do this, we probably want to have DefinitionTag be many-to-many |
| 19:38:17 | <mseaton> rather than one-to-many |
| 19:40:01 | *** Collins has quit IRC |
| 19:40:18 | <djazayeri> mseaton: seems like a lot of workâdo you see it as worthwhile? |
| 19:40:24 | <djazayeri> I agree that it would be better that way |
| 19:42:17 | <mseaton> djazayeri: you think it would be better to have a single DefinitionTag that represented "Favorite", which many definitions could link to? rather than just essentially a String on a Definition that could be used to categorize it? |
| 19:43:08 | <djazayeri> mseaton: In some data modeling sense, I think it would be better to have an object that represents tags, and definitions just point to those |
| 19:43:22 | <djazayeri> butâ¦if I were implement things, I probably wouldn't bother |
| 19:43:52 | <djazayeri> though it's hard to do localization without that |
| 19:43:58 | <djazayeri> hard/impossible |
| 19:44:33 | <mseaton> djazayeri: right. |
| 19:45:09 | <mseaton> djazayeri: localization aside for now. what about figuring out the published/non-published and quick-link things? |
| 19:45:23 | <mseaton> are you convinced that these should be not gp-configurable? |
| 19:45:31 | *** james_regen has quit IRC |
| 19:47:36 | <mseaton> djazayeri: or i guess we could make the tags have these properties directly? or something similar. |
| 19:47:51 | <djazayeri> mseaton: my take is that we have a single hardcoded tag for "published" |
| 19:48:23 | <djazayeri> like the way that gmail's "inbox" works (at least to the end-user) |
| 19:49:02 | <djazayeri> I prefer the idea of publishing individual reports, rather than saying that _other_ tags are published |
| 19:49:21 | <djazayeri> but I'm not _convinced_, no |
| 19:49:59 | <mseaton> djazayeri: do you think tags are right for this, or should we just punt this published issue and solve it by having a proper "published" boolean property on each definition type when we re-do the data model? |
| 19:51:22 | <djazayeri> using tags seems fine to me |
| 19:52:04 | <djazayeri> you mean that each individual class (and thus each instance) would get a published property? |
| 19:52:19 | <mseaton> djazayeri: yes. |
| 19:52:49 | <djazayeri> I guess that's better than tags, if nobody is pressed to do publishing now, before that refactoring |
| 19:53:21 | <mseaton> djazayeri: or alternatively, we could take a convention-driven approach and allow a user to configure a global property that says "hideAllDefinitionsWithNameContainingText" |
| 19:53:36 | <mseaton> so someone could, say, put "DRAFT" in the name of anything they didn't want to show up |
| 19:54:30 | <djazayeri> that seems okay as a quick solution |
| 19:54:44 | <djazayeri> but i'd prefer to add a proper boolean in the long run |
| 19:54:53 | <mseaton> djazayeri: sounds like a plan |
| 19:55:50 | <mseaton> wyclif: have you been following this at all? |
| 19:56:32 | <wyclif> mseaton, no |
| 19:56:59 | <mseaton> wyclif: how far along are you with the ticket to support definition tags? |
| 19:57:14 | <wyclif> mseaton, done |
| 19:57:25 | <mseaton> wyclif: checked in? |
| 19:57:32 | <wyclif> i hadn't yet committed the code though |
| 19:57:41 | <wyclif> mseaton, because i didnt like th UI i had created |
| 19:57:54 | <wyclif> mseaton, but let me check it in in the next 5min |
| 19:57:58 | <mseaton> wyclif: ok |
| 19:58:05 | <wyclif> mseaton, and you guys loot at it |
| 19:58:16 | <wyclif> mseaton, the ticket was really bigger than i thought |
| 19:58:35 | <mseaton> wyclif: ok, well one thing we were just discussing is that we might need tags to stand alone, and be linked to definitions via a many-to-many mapping table |
| 19:58:42 | <mseaton> :) |
| 19:58:56 | <wyclif> mseaton, i added a small UI to the report editor page just for the fast pass, it is open for change or be implemented as a portlet |
| 19:59:14 | <wyclif> ok |
| 19:59:32 | <mseaton> but check in what you've got and we can take it from there. can you create a post-commit review too please? |
| 20:01:30 | *** dkayiwa has joined #openmrs |
| 20:01:54 | <wyclif> mseaton, sure |
| 20:12:43 | *** lh has joined #openmrs |
| 20:12:43 | *** lh has joined #openmrs |
| 20:23:29 | *** dkayiwa has quit IRC |
| 20:24:55 | *** dkayiwa has joined #openmrs |
| 20:28:01 | *** nribeka has quit IRC |
| 20:34:13 | *** mvorobey has quit IRC |
| 20:39:56 | *** deadpool has quit IRC |
| 20:40:29 | *** deadpool has joined #openmrs |
| 20:41:59 | *** r0bby_ has quit IRC |
| 20:44:37 | <MarkG> to people with reporting module experience.... does the reporting module auto-schedule some task to run when it is installed? does this task run frequently? |
| 20:44:59 | *** mseaton has quit IRC |
| 20:49:01 | *** mseaton has joined #openmrs |
| 20:49:01 | *** ChanServ sets mode: +v mseaton |
| 20:51:54 | *** bryq has quit IRC |
| 20:54:41 | <wyclif> mseaton, and djazayeri , code for tagging is committed |
| 20:56:58 | *** deadpool has quit IRC |
| 20:57:32 | *** deadpool has joined #openmrs |
| 20:58:34 | *** lh has quit IRC |
| 20:59:24 | *** sgithens has quit IRC |
| 21:14:11 | *** Felipo has quit IRC |
| 21:15:48 | *** deadpool has quit IRC |
| 21:16:35 | *** deadpool has joined #openmrs |
| 21:17:14 | *** dkayiwa has quit IRC |
| 21:21:08 | *** dkayiwa has joined #openmrs |
| 21:21:18 | *** mseaton has left #openmrs |
| 21:47:41 | *** dkayiwa has quit IRC |
| 22:07:57 | *** MarkG has quit IRC |
| 22:12:24 | *** wyclif has quit IRC |
| 22:13:52 | *** deadpool has quit IRC |
| 23:08:28 | *** sgithens_ has joined #openmrs |
| 23:23:56 | *** mseaton has joined #openmrs |
| 23:23:56 | *** ChanServ sets mode: +v mseaton |