| 00:05:15 | *** jkeiper has joined #openmrs |
| 01:13:48 | *** Jibesh has joined #openmrs |
| 01:25:03 | *** djazayeri has joined #openmrs |
| 01:25:03 | *** ChanServ sets mode: +o djazayeri |
| 01:48:45 | *** Jibesh has left #openmrs |
| 01:49:13 | *** mathiaslin has joined #openmrs |
| 01:54:55 | *** djazayeri1 has joined #openmrs |
| 01:54:55 | *** djazayeri has quit IRC |
| 02:08:19 | *** isharapremadasa has joined #openmrs |
| 02:09:13 | *** isharapremadasa is now known as isharap |
| 02:35:26 | *** isharap has quit IRC |
| 02:38:33 | *** r_friedman_away is now known as r_friedman |
| 03:06:10 | <r_friedman> djazayeri1: you there? |
| 03:07:36 | *** jkeiper has quit IRC |
| 03:27:18 | *** upul` has joined #openmrs |
| 03:27:18 | *** ChanServ sets mode: +v upul` |
| 03:38:30 | *** r_friedman has quit IRC |
| 03:43:35 | *** sumitverma has joined #openmrs |
| 04:06:41 | *** sumitverma has quit IRC |
| 04:12:40 | *** rohitgoyal18 has joined #openmrs |
| 04:28:05 | *** finbrein has quit IRC |
| 04:33:46 | *** pulasthi7 has joined #openmrs |
| 04:42:24 | *** goutham has joined #openmrs |
| 05:05:06 | *** pulasthi has joined #openmrs |
| 05:07:33 | *** pulasthi7 has quit IRC |
| 05:07:39 | *** pulasthi7 has joined #openmrs |
| 05:11:10 | *** pulasthi has quit IRC |
| 05:40:32 | *** rohitgoyal18 has quit IRC |
| 05:50:54 | *** finbrein has joined #openmrs |
| 05:53:06 | *** harshadura has joined #openmrs |
| 06:07:38 | *** harshadura has quit IRC |
| 06:11:47 | *** Jibesh has joined #openmrs |
| 06:36:45 | *** djazayeri1 has quit IRC |
| 07:19:50 | *** suranga has joined #openmrs |
| 07:19:50 | *** ChanServ sets mode: +v suranga |
| 07:55:26 | *** Jibesh has quit IRC |
| 09:10:04 | *** pushkar has joined #openmrs |
| 09:40:00 | *** harshadura has joined #openmrs |
| 09:57:56 | *** upul` has quit IRC |
| 10:01:49 | *** harshadura has quit IRC |
| 10:07:20 | *** snoppy has joined #openmrs |
| 10:20:38 | *** harshadura has joined #openmrs |
| 10:20:51 | *** pushkar has quit IRC |
| 10:24:21 | *** harshadura has quit IRC |
| 10:25:21 | <pulasthi7> hi suranga , |
| 10:25:39 | <pulasthi7> i |
| 10:25:46 | <suranga> hi pulasthi7 ! I saw your ticket :) |
| 10:26:03 | *** pushkar has joined #openmrs |
| 10:26:20 | <pulasthi7> :) is it ok? |
| 10:26:26 | <suranga> unfortunately, didnt get to open it and read it yet, but you've folowed the correct approach ! |
| 10:27:08 | <suranga> i could not come online last friday.. but i see you've mnaged to surive without me ;P |
| 10:28:28 | <pulasthi7> it's ok. hope i did it right. btw i'm having a problem of saving the configuration to the file. |
| 10:30:25 | <pulasthi7> i'm getting an AbstractMethodError exception. from XMLTransformer class. |
| 10:31:02 | <pulasthi7> i tried debugging but i failed to find the reason. |
| 10:32:56 | *** pushkar has quit IRC |
| 10:34:06 | <pulasthi7> then i googled for the error, there it says that the problem may be with the JDK versions. |
| 10:35:39 | <pulasthi7> i then tried the tried with the jdk 1.7 but no success. any idea of what could be the reason? |
| 10:39:01 | <suranga> pulasthi7, i wil try this today, and hopefully recreate the error |
| 10:39:18 | <suranga> then, hopefully, i will be able to use your patch to fix it :-) |
| 10:39:56 | *** suranga has quit IRC |
| 10:56:14 | *** deadpool has quit IRC |
| 10:58:35 | *** MarkG1 has joined #openmrs |
| 11:08:19 | *** deadpool has joined #openmrs |
| 11:21:36 | *** james_regen has joined #openmrs |
| 11:21:36 | *** ChanServ sets mode: +v james_regen |
| 11:23:29 | *** applecool has joined #openmrs |
| 12:02:08 | *** robbyoconnor has quit IRC |
| 12:08:33 | *** nribeka has joined #openmrs |
| 12:08:33 | *** ChanServ sets mode: +v nribeka |
| 12:10:39 | *** r0friedman has joined #openmrs |
| 12:11:16 | *** r0friedman is now known as r_friedman |
| 12:22:57 | *** jkeiper has joined #openmrs |
| 12:37:06 | *** applecool has quit IRC |
| 12:53:58 | *** goutham is now known as king |
| 12:54:13 | *** king is now known as rahul |
| 12:54:35 | *** rahul is now known as goutham |
| 12:57:32 | *** rohitgoyal18 has joined #openmrs |
| 13:05:45 | *** mvorobey has joined #openmrs |
| 13:07:14 | <mvorobey> hi all |
| 13:25:07 | *** mseaton has joined #openmrs |
| 13:25:07 | *** ChanServ sets mode: +v mseaton |
| 13:30:36 | *** wyclif has joined #openmrs |
| 13:30:41 | <wyclif> hi mseaton |
| 13:30:49 | <mseaton> hi wyclif |
| 13:32:12 | <wyclif> mseaton, how comes definitionService.getDefinition(String uuid, Class clazz) retunrs the definition with a null uuid? |
| 13:33:40 | *** snoppy has left #openmrs |
| 13:34:29 | <mseaton> wyclif, it probably doesn't really belong there, but this is a convenience method which either gets the underlying definition by uuid, or if null, instantiates a new definition of the passed type. mainly used for retrieving a model object for a create/edit definition page. |
| 13:34:52 | <mseaton> it's a bit of an ugly method to exist on a service... |
| 13:37:31 | <wyclif> mseaton, but should it be returning the definition with no uuid yet i called get by uuid, i would assume it would have the same passed in uuid |
| 13:37:47 | <wyclif> this is in BaseDefinitionService |
| 13:38:36 | <mseaton> wyclif: i assume you are using trunk? this wasn't an issue in any version of openmrs i developed against previously, but probably is now that uuid is set in the constructor. in previous versions it was null until the object was saved. |
| 13:38:46 | <wyclif> mseaton, yes |
| 13:39:14 | <mseaton> wyclif, so this is something that should get cleaned up. feel free to create tickets... |
| 13:39:59 | <wyclif> mseaton, OK |
| 13:40:26 | *** goutham has quit IRC |
| 13:48:20 | *** pushkar has joined #openmrs |
| 13:49:25 | <pushkar> hi r_friedman |
| 13:52:42 | *** isharapremadasa has joined #openmrs |
| 13:55:46 | *** lh has quit IRC |
| 13:57:08 | *** isharapremadasa is now known as isharap |
| 14:01:52 | <pushkar> r_friedman: r u there |
| 14:02:59 | *** downey has joined #openmrs |
| 14:03:01 | *** downey has joined #openmrs |
| 14:03:01 | *** ChanServ sets mode: +o downey |
| 14:03:01 | *** OpenMRSBot sets mode: +o downey |
| 14:03:29 | <pushkar> r_friedman: is it ok if we edit our wiki pages now |
| 14:04:24 | <pushkar> r_friedman: since i cant change my proposal , i wanted to edit some more changes in the wiki pages |
| 14:05:52 | *** lh has joined #openmrs |
| 14:05:52 | *** lh has joined #openmrs |
| 14:06:09 | <downey> Hi lh :) |
| 14:08:11 | <lh> downey, good morning! |
| 14:10:19 | *** maurya has joined #openmrs |
| 14:11:02 | <maurya> hi wyclif |
| 14:11:28 | <wyclif> hi MarkG1 |
| 14:11:32 | <wyclif> sorry MarkG1 |
| 14:11:38 | <wyclif> hi maurya |
| 14:12:29 | <maurya> I have updated the proposal as per the suggested by micheal and robert |
| 14:12:52 | <maurya> did you get a chance to see , the implementation is on the wiki page though |
| 14:16:55 | *** harshadura has joined #openmrs |
| 14:18:24 | *** sgithens_ has joined #openmrs |
| 14:18:28 | <r_friedman> pushkar: why don't you just e-mail sai and me? or you can start your own wiki page under HR module as Pushkar's GSOC Plan or something like that |
| 14:19:10 | <pushkar> i have already created my page which i am updating as per my understanding |
| 14:19:22 | <downey> pushkar: You can also feel free to add pages to your own personal wiki space, if that's helpful. |
| 14:19:45 | <pushkar> i am taking help of http://ihris.capacityplus.org/iHRIS/Manage/ to understand things better |
| 14:20:22 | <r_friedman> pushkar: we'd love to hear more from you, but it has to be with the understanding that it will have nothing to do with your selection. we're not allowed to let you know by word or deed what's happening with your application until the official announcement date |
| 14:20:37 | <downey> :) |
| 14:20:45 | <pushkar> yes , I know that rule |
| 14:21:04 | <pushkar> but the thing is I have my internal exams too , so i would also be busy with that |
| 14:21:13 | <pushkar> they are starting from day after tomorrow |
| 14:21:29 | <r_friedman> pushkar: please put Sai and me as watchers on your page |
| 14:22:25 | <pushkar> ok |
| 14:23:17 | <r_friedman> pushkar: also feel free to e-mail or request a chat or call or use the wiki in a bloggish way if there are issues that you want to clarify |
| 14:23:33 | <pushkar> sure r_friedman |
| 14:27:32 | <r_friedman> mseaton: mike, got a minute, or are you sprinting? |
| 14:32:35 | <mseaton> r_friedman, sure what's up? |
| 14:33:33 | <r_friedman> tks mike ... it appears that doing jsp pages other than OpenMRS forms and extensions is just a matter of writing controllers and jsp pages, right? |
| 14:33:40 | *** bryq has joined #openmrs |
| 14:33:40 | *** ChanServ sets mode: +v bryq |
| 14:34:13 | <r_friedman> mseaton: and all you have to do is link to them. do you have to do anything special to get back into the normal openmrs workflow? |
| 14:34:39 | <r_friedman> and where do you usually put the files for your standalone pages? |
| 14:35:20 | <r_friedman> and is there a module i could look at that would show examples? |
| 14:35:24 | <pushkar> r_friedman: added you and saimanohar as watchers |
| 14:36:12 | <r_friedman> pushkar: yep, got a notice to that effect ... remember the small changes checkbox will keep us from being spammed |
| 14:36:33 | <pushkar> sure r_friedman |
| 14:37:01 | <mseaton> r_friedman: yes, exactly. almost all modules add one or more standalone pages. i would pick your favorite developer - one whom you think writes good code to copy - and look at one of their modules. happy to point you to some of mine if helpful. |
| 14:37:02 | *** maurya has quit IRC |
| 14:37:23 | <r_friedman> mseaton: please |
| 14:37:42 | <r_friedman> mseaton: maybe with use of role-based hompage |
| 14:39:29 | *** jmiranda has joined #openmrs |
| 14:39:35 | <mseaton> r_friedman: what do you mean by "get back into the normal openmrs workflow"? |
| 14:40:31 | <r_friedman> mseaton: probably i mean linking back to the homepage or the dashboard, it sort of answers itself |
| 14:40:51 | *** pushkar has quit IRC |
| 14:41:30 | <mvorobey> mseaton, hi :) |
| 14:41:32 | <mseaton> r_friedman - yeah, you would typically just have a link back to a known page. if you wanted to create content within the normal openmrs pages, that would be done either with overwriting URLs to use your custom pages instead of the provided pages, or by using extension points to alter the existing pages |
| 14:41:53 | <mseaton> mvorobey: hey - looking at your patch now. looking good so far from what i can see ! |
| 14:43:38 | <mvorobey> mseaton, :) just FYI: I also have a patch for REPORT-353, but probably will attach it after you apply that one that you are reviewing know |
| 14:43:57 | <r_friedman> mseaton: thanks, it's all starting to make sense |
| 14:44:56 | *** r_friedman is now known as r_friedman_away |
| 14:45:25 | *** isharap has quit IRC |
| 14:45:58 | *** apurv has joined #openmrs |
| 14:46:24 | *** dawn_ has joined #openmrs |
| 14:47:02 | <mseaton> r_friedman: you have 2 options really with your pages: if you just want a more-or-less vanilla jsp page, with no custom data in the model, all you need is the jsp, and you can access it with the .htm extension. so, if you put a page called "index.jsp" in your "rogermodule" module at path /web/module/index.jsp, you would access it by going to a page at localhost:8080/module/rogermodule/index.htm |
| 14:47:14 | *** ChanServ sets mode: +v dawn_ |
| 14:47:47 | <mseaton> r_friedman: if you want custom data in the model, then you need to write a controller which handles this same url, puts data in the model, and then passes it to the view, for example: |
| 14:48:21 | <mseaton> http://svn.openmrs.org/openmrs-modules/custommessage/trunk/web/src/org/openmrs/module/custommessage/web/controller/CustomMessageController.java |
| 14:48:40 | <mseaton> http://svn.openmrs.org/openmrs-modules/custommessage/trunk/web/module/index.jsp |
| 14:51:26 | *** rohitgoyal18 has quit IRC |
| 14:56:29 | <mseaton> r_friedman: to access your page that uses your controller, it has to be referred to by ".../index.form", rather than ".../index.htm" |
| 14:59:17 | *** djazayeri has joined #openmrs |
| 14:59:17 | *** ChanServ sets mode: +o djazayeri |
| 14:59:26 | <mseaton> mvorobey: trying out your patch right now. having trouble scheduling a report for today 2 minutes from now. |
| 14:59:42 | <mseaton> mvorobey: "Please enter a date in format dd/mm/yyyy. Do not enter a date value in the past." |
| 15:00:26 | <dawn_> !scrumon dawn |
| 15:00:26 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready. |
| 15:00:31 | <dawn_> Hi Team! |
| 15:00:40 | <mvorobey> dawn_, hi :) |
| 15:00:45 | <mvorobey> mseaton, it means that you scheduled report for past time |
| 15:00:45 | <djazayeri> hi |
| 15:01:36 | <mvorobey> mseaton, I found out what is wrong :) |
| 15:01:37 | <dawn_> Today's order: wyclif , sgithens, mvorobey mseaton , djazayeri , |
| 15:01:56 | <wyclif> Friday: |
| 15:01:56 | <wyclif> * Order entry discussion with Burke |
| 15:01:56 | <wyclif> * REPORT-49 - Add a validator for the definition tags and make UI changes for tagging to the manage report definition page) |
| 15:01:56 | <wyclif> Monday: |
| 15:01:56 | <wyclif> * Complete UI changes to support tagging from the manage report definition page |
| 15:01:58 | <wyclif> * REPORT-352 - Provide ability to stop reports during the course of an execution |
| 15:02:00 | <wyclif> Blockers: None |
| 15:02:30 | *** pushkar has joined #openmrs |
| 15:02:30 | <dawn_> sgithens_: your turn :) |
| 15:02:50 | <sgithens_> * Some impediments last week getting 1.8.x and trunk to startup with |
| 15:02:50 | <sgithens_> a scratch db. Commented/put patch on relevant jiras. Everything seems to be |
| 15:02:50 | <sgithens_> working today. |
| 15:02:50 | <sgithens_> * Stubbing out UI for REPORT-337 portlet today |
| 15:03:10 | <dawn_> sgithens_: any blockers? |
| 15:03:17 | *** harshadura has quit IRC |
| 15:03:19 | <sgithens_> not any more |
| 15:03:27 | <sgithens_> just the issues getting trunk to startup on friday |
| 15:03:38 | <dawn_> sgithens_: thanks |
| 15:03:42 | <dawn_> mvorobey: your turn :) |
| 15:03:43 | <mvorobey> * Prepared for review REPORT-312 |
| 15:03:43 | <mvorobey> * Gonna pick the next ticket |
| 15:03:43 | <mvorobey> * No blockers |
| 15:04:07 | <djazayeri> !ticket REPORT-312 |
| 15:04:08 | <OpenMRSBot> djazayeri: [#REPORT-312] Create improved widget for editing a cron expression - OpenMRS JIRA - https://tickets.openmrs.org/browse/REPORT-312 |
| 15:04:25 | <dawn_> mseaton: your turn :) |
| 15:05:39 | <dawn_> djazayeri: can you go now? |
| 15:06:02 | <djazayeri> Friday 06-Apr-2012 |
| 15:06:02 | <djazayeri> * (made initial commit) REPORT-330 (First pass at Data Export replacement) |
| 15:06:02 | <djazayeri> * (worked on) Create UI Widget Library module so I can finish fixing the UI Framework docs |
| 15:06:02 | <djazayeri> Today 09-Apr-2012 |
| 15:06:02 | <djazayeri> * More on REPORT-330 after I get feedback from mseaton |
| 15:06:02 | <djazayeri> * (finish) Create UI Widget Library module so I can finish fixing the UI Framework docs |
| 15:06:03 | <djazayeri> * Create ticket (or vote on existing one) about Module Maven Archetype needing to include dependencies with scope=provided |
| 15:06:25 | <djazayeri> was stuck on the archetype/provided issue, but figured it out eventually |
| 15:06:31 | <djazayeri> currently need feedback from mseaton |
| 15:07:11 | <dawn_> !scrumoff dawn |
| 15:07:11 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 15:07:25 | <djazayeri> Where's ben? |
| 15:07:30 | *** MarkG1 has quit IRC |
| 15:07:59 | <dawn_> djazayeri: ben won't be in til wednesday. |
| 15:08:03 | <djazayeri> oh |
| 15:08:11 | <djazayeri> okay |
| 15:08:37 | <djazayeri> wyclif: we're going to switch up your schedule for this week |
| 15:09:04 | <wyclif> djazayeri, this week? |
| 15:09:16 | <djazayeri> yes |
| 15:09:26 | <wyclif> djazayeri, is that for the order entry stuff? |
| 15:09:32 | <djazayeri> no |
| 15:09:44 | <djazayeri> This week is still the reporting sprint |
| 15:09:44 | <wyclif> djazayeri, for what? |
| 15:10:09 | <wyclif> what do you want me to do? |
| 15:10:51 | <djazayeri> wyclif: this week, we want you to be on "bug-fixing duty" |
| 15:11:24 | <mvorobey> mseaton, I have already fixed that issue with trouble scheduling a report for today 2 minutes from now, it works correctly know |
| 15:11:46 | <djazayeri> The idea is that we want to always have one person (rotating ~ every week) working on top-voted bug-fixes. |
| 15:12:04 | <djazayeri> last week was Rafal (sort of), this week is you, next week is Daniel |
| 15:12:09 | <wyclif> djazayeri, can i have today to complete what am working on |
| 15:12:14 | <djazayeri> wyclif: yes |
| 15:12:32 | <wyclif> djazayeri, it is a big ticket am about to complete and dont want to leave unfinished |
| 15:12:40 | <djazayeri> wyclif: sure, no problem |
| 15:13:00 | <wyclif> djazayeri, i cans start on the bug fixing later today |
| 15:13:03 | <wyclif> can |
| 15:13:34 | <djazayeri> Go ahead and take the morning to finish off your currently-in-progress ticket(s) |
| 15:15:19 | <wyclif> djazayeri, ok |
| 15:15:32 | <wyclif> djazayeri, i will have to drop the other ticket |
| 15:15:40 | <wyclif> djazayeri, wont have time to complete it |
| 15:15:43 | <djazayeri> wyclif: which one is that? |
| 15:15:57 | <djazayeri> maybe you can revisit it later this week. |
| 15:16:38 | <wyclif> djazayeri, ok |
| 15:17:07 | <djazayeri> wyclif: you mean report-352? |
| 15:17:41 | <wyclif> djazayeri, yes |
| 15:17:56 | <wyclif> djazayeri, wasn't yet started |
| 15:18:11 | <wyclif> djazayeri, though mike had assigned it to me |
| 15:18:41 | <djazayeri> wyclif: he probably had. once mseaton gets back on irc we can see how high-priority that one is. |
| 15:19:08 | <wyclif> djazayeri, ok |
| 15:19:33 | *** deadpool has quit IRC |
| 15:31:21 | *** jkeiper has quit IRC |
| 15:32:41 | *** deadpool has joined #openmrs |
| 15:33:02 | *** jkeiper has joined #openmrs |
| 15:34:17 | *** r_friedman_away is now known as r_friedman |
| 15:35:20 | <r_friedman> djazayeri: hey darius, got a minute? |
| 15:37:11 | *** mvorobey has quit IRC |
| 15:38:48 | *** sgithens_ has quit IRC |
| 15:48:08 | *** sgithens has joined #openmrs |
| 15:50:49 | *** MarkG has joined #openmrs |
| 15:53:17 | *** sgithens has quit IRC |
| 15:55:04 | <djazayeri> hi r_friedman |
| 15:55:10 | <r_friedman> hey darius |
| 15:55:58 | <djazayeri> you have a question? |
| 15:56:00 | <r_friedman> when we try to use the resource-level tests from webservices.rest in the lab module, we have to copy files into our space (util, BaseDelegating...Test) |
| 15:56:16 | <r_friedman> is that a POM problem, a distribution problem, a repo problem or what? |
| 15:56:45 | <djazayeri> you have a module that depends on webservices.rest? |
| 15:56:50 | <r_friedman> yes |
| 15:57:05 | <djazayeri> you definitely shouldn't have to copy files anywhere to make unit tests run |
| 15:57:13 | <djazayeri> actually... |
| 15:58:01 | <djazayeri> That said, the standard include you probably have in pom.xml will only include the real code, not the test code. |
| 15:58:15 | <djazayeri> So I believe you need to add another dependency in the pom to get the test code |
| 15:58:46 | <r_friedman> which pom djazayeri ? |
| 15:59:54 | <djazayeri> r_friedman: I don't know this very well, so take this advice as non-authoritative. But look at the <classifier>test</classifier> line here: |
| 15:59:55 | <djazayeri> https://github.com/OpenMRS/openmrs-module-htmlformentry19ext/blob/master/pom.xml |
| 16:00:00 | <OpenMRSBot> <http://ln-s.net/9yXe> (at github.com) |
| 16:00:24 | <djazayeri> r_friedman: and then here: https://github.com/OpenMRS/openmrs-module-htmlformentry19ext/blob/master/api/pom.xml |
| 16:00:26 | <OpenMRSBot> <http://ln-s.net/9yXf> (at github.com) |
| 16:01:13 | *** sgithens has joined #openmrs |
| 16:01:27 | <djazayeri> (in the second link it's the <classifier>tests</classifier> (though I don't know if one is a typo) |
| 16:02:33 | <r_friedman> djazayeri: ok tks will try both -- we should hook up Monica's brother in Romania with gsoc Melania Galea |
| 16:03:11 | <mseaton> djazayeri: i'm here |
| 16:03:29 | <djazayeri> hi mseaton |
| 16:04:10 | <mseaton> djazayeri, wyclif: the ticket in question i was hoping wyclif would do involved having reports run in threads that could be killed off if needed if the user wanted to cancel their execution... |
| 16:04:14 | <djazayeri> The idea is that rafal will join the reporting sprint tomorrow, and wyclif will leave it to do bug-fixing. Aside from wyclif finishing out his current ticket, any reporting-related comments? |
| 16:04:26 | <mseaton> but someone else could certainly work on it. |
| 16:04:35 | <mseaton> not sure if wyclif had a plan of attack for it or not yet |
| 16:04:39 | <djazayeri> is it actually safe to kill a thread? |
| 16:04:45 | <mseaton> dunno |
| 16:04:54 | <mseaton> safe how? |
| 16:05:26 | <djazayeri> http://docs.oracle.com/javase/1.5.0/docs/guide/misc/threadPrimitiveDeprecation.html |
| 16:05:34 | <OpenMRSBot> <http://ln-s.net/9yXo> (at docs.oracle.com) |
| 16:07:48 | <wyclif> djazayeri, the approach wont e actually calling stop |
| 16:07:49 | <mseaton> djazayeri: i don't actually care how it happens. the requirement we were hoping to meet is that if a user clicks "Cancel" on a running report, that the system does what it can to actually cancel the execution in the background, to free up those resources. |
| 16:07:59 | <mseaton> if it can |
| 16:08:11 | <wyclif> there has to be a way to cancel its execution |
| 16:08:50 | <djazayeri> mseaton: okay, it's possible the "correct" way to do this will require adding a cancel() method to the Evaluator interfaces... |
| 16:08:58 | <djazayeri> but that kind of defeats the purpose |
| 16:09:07 | <djazayeri> anyway, that's a question for whoever does the ticket. |
| 16:09:11 | *** pushkar has quit IRC |
| 16:09:49 | <mseaton> djazayeri: right. happy to give this to rafal if he is taking over from wyclif. wyclif, if you have any particular design you were going to adopt, can you document the ticket? |
| 16:10:14 | <mseaton> djazayeri: you said you were waiting for my feedback? |
| 16:10:30 | <wyclif> ok |
| 16:10:42 | <djazayeri> mseaton: I see your ticket comment actually, hadn't seen it when I wrote that |
| 16:11:19 | <mseaton> mvorobey: i don't see a revised patch to try out. |
| 16:19:31 | *** apurv has quit IRC |
| 16:25:41 | *** suranga has joined #openmrs |
| 16:25:41 | *** ChanServ sets mode: +v suranga |
| 16:26:18 | *** dawn_ has quit IRC |
| 16:27:33 | *** dawn_ has joined #openmrs |
| 16:27:33 | *** ChanServ sets mode: +v dawn_ |
| 16:28:00 | *** dawn__ has joined #openmrs |
| 16:28:00 | *** dawn_ has quit IRC |
| 16:28:00 | *** dawn__ is now known as dawn_ |
| 16:28:01 | *** ChanServ sets mode: +v dawn_ |
| 16:30:19 | *** dawn_ has quit IRC |
| 16:37:04 | *** dawn_ has joined #openmrs |
| 16:37:04 | *** ChanServ sets mode: +v dawn_ |
| 16:49:36 | *** dawn_ has quit IRC |
| 16:50:32 | *** dawn_ has joined #openmrs |
| 16:50:32 | *** ChanServ sets mode: +v dawn_ |
| 16:50:39 | *** applecool has joined #openmrs |
| 16:53:57 | *** nribeka has quit IRC |
| 16:56:36 | *** rohitgoyal18 has joined #openmrs |
| 17:04:09 | <r_friedman> djazayeri: hey Darius, still having problems, got a minute? |
| 17:04:37 | <djazayeri> r_friedman: what's up? |
| 17:04:56 | <r_friedman> so my existing POM points to 0.8, it can't find tests in 0.8 |
| 17:05:14 | <r_friedman> I tried to change to 0.9, it can't find anything at all even though I've compiled it in my workspace |
| 17:06:40 | <r_friedman> djazayeri: although I didn't try test singular |
| 17:07:15 | <djazayeri> r_friedman: you did mvn install locally? |
| 17:07:20 | <r_friedman> yes |
| 17:07:21 | <djazayeri> of the latest ws-rest? |
| 17:07:37 | <djazayeri> make sure you point to a snapshot version |
| 17:07:46 | <djazayeri> I don't know if it's 0.9-SNAPSHOT or 1.0-SNAPSHOT |
| 17:07:57 | <r_friedman> maybe not the latest latest but one that has the tests in it, it is 0.9 SNAPSHOT |
| 17:08:14 | <djazayeri> (or did you check out an 0.9 tag, which I don't think exists) |
| 17:08:31 | <r_friedman> no, I checked out trunk when it was set to build 0.9 |
| 17:12:21 | <r_friedman> djazayeri: do i need to do a publish? |
| 17:12:36 | <djazayeri> mvn install is what puts it in your local maven repo |
| 17:12:47 | <djazayeri> and after you've done that once, any mvn package will update it there |
| 17:13:13 | <djazayeri> and in your other module's pom, you're referring to ws.rest as 0.9-SNAPSHOT? |
| 17:13:16 | <djazayeri> r_friedman: |
| 17:13:36 | <r_friedman> ah no I wasn't, just 0.9 |
| 17:13:50 | <r_friedman> i will try that and test singular |
| 17:17:09 | *** lh has quit IRC |
| 17:19:40 | *** bryq has quit IRC |
| 17:22:45 | <r_friedman> djazayeri: test singular seems to work better, but it still can't be found in the openmrs repo, it's not looking in my workspace |
| 17:23:51 | <djazayeri> r_friedman: eclipse has a view (window -> show view -> (other)) that lets you look at your local maven repo and/or your workspace maven repo |
| 17:23:54 | <djazayeri> can you make sure it's there? |
| 17:27:53 | *** dawn_ has quit IRC |
| 17:31:25 | <r_friedman> djazayeri: in workspace projects, there is org.openmrs.module.webservices.rest, entries for project pom, api jar and omod jar -- no other references to the module |
| 17:31:50 | <r_friedman> do i need to put the test dependency into the api as well as the omod? |
| 17:33:00 | <r_friedman> all 3 references are to 0.9-SNAPSHOT |
| 17:38:13 | <r_friedman> djazayeri: ? |
| 17:44:14 | <djazayeri> r_friedman: you're building ws.rest with the tests, right? (i.e. you're not doing skipTests) |
| 17:44:27 | <r_friedman> yep |
| 17:44:49 | <r_friedman> can redo if you think it might help |
| 17:45:03 | <djazayeri> MarkG: do you recall whether we had to do anything particular to make the htmlformentry module publish its test jars? |
| 17:50:14 | <djazayeri> r_friedman: looking at HTML Form Entry's main pom, I see usage of the maven-jar-plugin to do the test-jar |
| 17:50:15 | <djazayeri> https://github.com/OpenMRS/openmrs-module-htmlformentry/blob/master/pom.xml |
| 17:50:19 | <OpenMRSBot> <http://ln-s.net/9y__> (at github.com) |
| 17:50:26 | <djazayeri> dunno if that needs to be added to ws.rest, or what |
| 17:50:39 | *** jmiranda has quit IRC |
| 17:50:51 | <djazayeri> but that might be because MarkG was doing something funky to allow testing against different OpenMRS versions |
| 17:53:49 | *** lh has joined #openmrs |
| 17:53:49 | *** lh has joined #openmrs |
| 17:55:20 | <r_friedman> djazayeri: you want me to try that with webservices.rest or wait for someone who knows what they're doing? |
| 17:56:50 | *** mathiaslin has quit IRC |
| 18:03:46 | *** r_friedman has quit IRC |
| 18:05:41 | <MarkG> djazayeri: just catching up to this chain now... |
| 18:07:00 | <MarkG> djazayeri: what is the issue... did we publish the test jars so that the 1.9 ext module could use them? |
| 18:08:54 | <djazayeri> MarkG: do you remember if we had to do something special (either a maven command, or a change to the pom) so that other modules (e.g. hfe19ext) could use the test-jars from hfe as maven dependencies? |
| 18:09:27 | <MarkG> djazayeri: no, but i'm taking a look now |
| 18:09:57 | <djazayeri> MarkG: thanks. |
| 18:15:03 | <MarkG> djazayeri: so, you included the htmlformentry-api dependency twice within the ext module API, the second time with a "classifier" element.. does that ring any bells? |
| 18:15:04 | <MarkG> https://github.com/OpenMRS/openmrs-module-htmlformentry19ext/blob/master/api/pom.xml |
| 18:15:05 | <OpenMRSBot> <http://ln-s.net/9yXf> (at github.com) |
| 18:15:20 | <djazayeri> MarkG: yes. I pointed roger to that |
| 18:15:35 | <djazayeri> his issue is that ws.rest doesn't seem to be publishing the test-jar to maven |
| 18:15:46 | <MarkG> go tit |
| 18:15:50 | <MarkG> got it, that is... |
| 18:15:52 | <djazayeri> MarkG: I'm wondering if we did anything to the *core* hfe module |
| 18:16:44 | <MarkG> i don't remember doing anything... |
| 18:17:32 | <MarkG> what module are we looking for? where is it in the maven repo? |
| 18:17:59 | <djazayeri> MarkG: webservices.rest, but not published to the public repo yet |
| 18:18:22 | <MarkG> djazayeri: you are right, though, it look like only the htmlformentry module has it's test jars published... |
| 18:18:28 | <MarkG> i *might* have done that manually? |
| 18:18:48 | *** nadee has joined #openmrs |
| 18:19:21 | <djazayeri> dunno |
| 18:19:39 | *** bryq has joined #openmrs |
| 18:19:39 | *** ChanServ sets mode: +v bryq |
| 18:20:22 | *** kernelhunter92 has joined #openmrs |
| 18:20:32 | <MarkG> looking at the timestamps in the repo, it doesn't look like i did it manually... |
| 18:21:00 | <djazayeri> MarkG: |
| 18:21:00 | <djazayeri> I see usage of the maven-jar-plugin to do the test-jar |
| 18:21:00 | <djazayeri> djazayeri @ 10:50 |
| 18:21:00 | <djazayeri> https://github.com/OpenMRS/openmrs-module-htmlformentry/blob/master/pom.xml |
| 18:21:01 | <OpenMRSBot> <http://ln-s.net/9y__> (at github.com) |
| 18:21:30 | <djazayeri> any idea if that plugin is for the funky test-against-different-versions stuff you're doing? |
| 18:22:34 | <MarkG> djazayeri: no... it is not for the test against different versions... |
| 18:22:52 | <MarkG> djazayeri: looking at it now, that is probably it... ie, what we did to get the test jars packages as well... |
| 18:22:57 | <kernelhunter92> !seen r_friedman |
| 18:22:57 | <OpenMRSBot> kernelhunter92: r_friedman was last seen in #openmrs 27 minutes and 36 seconds ago: <r_friedman> djazayeri: you want me to try that with webservices.rest or wait for someone who knows what they're doing? |
| 18:23:50 | *** antonalekseyev has joined #openmrs |
| 18:24:06 | <MarkG> http://maven.apache.org/plugins/maven-jar-plugin/test-jar-mojo.html |
| 18:24:10 | <OpenMRSBot> <http://ln-s.net/9yaf> (at maven.apache.org) |
| 18:26:10 | <MarkG> here's the documentation... |
| 18:26:11 | <MarkG> http://maven.apache.org/plugins/maven-jar-plugin/usage.html |
| 18:26:13 | <OpenMRSBot> <http://ln-s.net/9yan> (at maven.apache.org) |
| 18:26:40 | <MarkG> look at the "how to create a jar containing test classes" section.. |
| 18:27:20 | <applecool> !seen dkayiwa |
| 18:27:20 | <OpenMRSBot> applecool: dkayiwa was last seen in #openmrs 4 days, 10 hours, 53 minutes, and 46 seconds ago: <dkayiwa> robbyoconnor: oh yes :) |
| 18:27:50 | <djazayeri> applecool: dkayiwa is out till tomorrow (Easter is a public holiday in Uganda) |
| 18:27:59 | <MarkG> djazayeri: so it looks like this is a valid way to do it... |
| 18:28:10 | <MarkG> i gotta run to the airport... |
| 18:28:11 | <applecool> djazayeri: Oh :) |
| 18:28:25 | <djazayeri> MarkG: ciao. will tell roger when he gets back. thanks! |
| 18:29:44 | <MarkG> djazayeri: just to pick up christian, i'm not going anywhere... |
| 18:29:55 | <djazayeri> ha, okay! |
| 18:30:42 | *** r8friedman has joined #openmrs |
| 18:30:45 | *** jmiranda has joined #openmrs |
| 18:30:50 | *** r8friedman is now known as r_friedman |
| 18:32:43 | <r_friedman> djazayeri: ok, i tried the plugin, rebuilt webservices.rest -- nothing new in target, lab still can't find the test |
| 18:33:28 | <djazayeri> r_friedman: hmm, not sure what's up there |
| 18:33:51 | <r_friedman> ok, guess we can live with copied files |
| 18:33:55 | <djazayeri> per conversation with MarkG when you were offline, we think that plugin is what's necessary |
| 18:34:25 | <r_friedman> djazayeri: does it require any further action than to have it in the <build> section? |
| 18:34:43 | <djazayeri> r_friedman: I don't really know any more than you do about maven |
| 18:34:59 | <r_friedman> ok, should i wait for rafa? he seems to know it |
| 18:35:20 | <djazayeri> r_friedman: if you want to wait, create a ticket for next week's sprint. |
| 18:35:32 | <r_friedman> ok, good idea |
| 18:35:45 | *** kernelhunter92 has left #openmrs |
| 18:36:06 | *** hemanth_92 has joined #openmrs |
| 18:38:15 | *** downey has quit IRC |
| 18:38:42 | <r_friedman> djazayeri: hey, it may actually have worked, i didn't have an import in one file |
| 18:39:05 | <r_friedman> hemanth_92: hi hemanth |
| 18:39:18 | <hemanth_92> r_friedman, hi |
| 18:39:36 | <r_friedman> can you participate in call tonight, hemanth_92 |
| 18:39:45 | <hemanth_92> when? |
| 18:41:44 | *** jkeiper has quit IRC |
| 18:44:26 | *** pulasthi7 has quit IRC |
| 18:49:00 | *** hemanth_92 has quit IRC |
| 18:57:10 | *** jriley has joined #openmrs |
| 18:59:04 | *** rohitgoyal18 has quit IRC |
| 19:00:51 | *** r_friedman has quit IRC |
| 19:02:28 | *** mseaton has quit IRC |
| 19:03:17 | *** mseaton has joined #openmrs |
| 19:03:17 | *** ChanServ sets mode: +v mseaton |
| 19:03:49 | *** mseaton has quit IRC |
| 19:04:05 | *** mseaton has joined #openmrs |
| 19:04:05 | *** ChanServ sets mode: +v mseaton |
| 19:04:15 | *** mseaton1 has joined #openmrs |
| 19:05:19 | <jriley> I have a reporting question/sanity check. Is it correct that row-per-encounter reporting isn't implemented in the UI yet? Can I stop looking for one? |
| 19:05:57 | *** jmiranda has quit IRC |
| 19:07:01 | *** mseaton1 has quit IRC |
| 19:08:23 | *** mseaton has quit IRC |
| 19:11:25 | *** jriley has left #openmrs |
| 19:19:05 | *** james_regen has left #openmrs |
| 19:21:03 | *** suranga has quit IRC |
| 19:27:12 | *** bryq has quit IRC |
| 19:40:30 | <MarkG> djazayeri: fwiw, from the docs, it seems like the maven-jar-plugin is always used to build the standard jars, you just don't have to configure it by default... so by adding it to the pom, you aren't really adding it, but just specifying it explicitly so you can add the goal to build the test-jars as well.. or something like that... it is coming back to me now... |
| 19:46:00 | *** downey has joined #openmrs |
| 19:46:00 | *** ChanServ sets mode: +o downey |
| 19:46:00 | *** OpenMRSBot sets mode: +o downey |
| 20:04:19 | *** dawn_ has joined #openmrs |
| 20:04:19 | *** ChanServ sets mode: +v dawn_ |
| 20:04:42 | *** dawn_ has quit IRC |
| 20:04:44 | *** dawn__ has joined #openmrs |
| 20:04:44 | *** ChanServ sets mode: +v dawn__ |
| 20:08:20 | *** dawn__ has quit IRC |
| 20:14:18 | *** jmiranda has joined #openmrs |
| 20:16:29 | *** lh has quit IRC |
| 20:23:26 | *** antonalekseyev has quit IRC |
| 20:33:21 | *** nadee has quit IRC |
| 21:04:17 | *** robbyoconnor has joined #openmrs |
| 21:04:17 | *** ChanServ sets mode: +v robbyoconnor |
| 21:20:02 | *** downey has quit IRC |
| 21:23:43 | *** lh has joined #openmrs |
| 21:45:34 | *** wyclif has quit IRC |
| 21:58:28 | *** jkeiper has joined #openmrs |
| 22:00:24 | *** MarkG has quit IRC |
| 22:36:32 | *** robbyoconnor has quit IRC |
| 22:36:50 | *** robbyoconnor has joined #openmrs |
| 22:36:50 | *** ChanServ sets mode: +v robbyoconnor |
| 22:39:38 | *** robbyoconnor has quit IRC |
| 22:39:59 | *** sgithens_ has joined #openmrs |
| 22:40:23 | *** robbyoconnor has joined #openmrs |
| 22:40:24 | *** ChanServ sets mode: +v robbyoconnor |
| 22:44:39 | *** Felipo has joined #openmrs |
| 22:46:12 | *** Felipo has quit IRC |
| 22:46:36 | *** Felipo has joined #openmrs |
| 22:46:42 | <Felipo> hello every |
| 22:49:22 | *** r0bby has joined #openmrs |
| 22:49:22 | *** ChanServ sets mode: +v r0bby |
| 22:50:29 | *** robbyoconnor has quit IRC |
| 22:52:48 | *** r0bby_ has joined #openmrs |
| 22:53:00 | *** ChanServ sets mode: +v r0bby_ |
| 22:55:24 | *** r0bby has quit IRC |
| 22:59:20 | *** r0bby_ has quit IRC |
| 23:00:19 | *** r0bby_ has joined #openmrs |
| 23:00:19 | *** ChanServ sets mode: +v r0bby_ |
| 23:00:36 | <Felipo> i am making a module and the structure with the Archetype tool, and create a new jsp, but when make a request to this, get the 404 error |
| 23:01:19 | <djazayeri> Felipo: hola. |
| 23:01:51 | <djazayeri> I just happened to look over at this window now, but it's usually better to say someone's name (like "djazayeri: I am making a moduleâ¦") to make sure your message is seen. |
| 23:02:06 | <djazayeri> Especially if it's after 5pm US Eastern time. :-) |
| 23:02:23 | <djazayeri> Felipo: do you have a controller to go along with your JSP? |
| 23:04:18 | *** r0bby_ has quit IRC |
| 23:04:39 | *** r0bby_ has joined #openmrs |
| 23:04:39 | *** ChanServ sets mode: +v r0bby_ |
| 23:06:13 | <Felipo> Yes, i have one |
| 23:10:22 | *** r0bby_ has quit IRC |
| 23:10:53 | *** r0bby_ has joined #openmrs |
| 23:10:53 | *** ChanServ sets mode: +v r0bby_ |
| 23:25:50 | *** r0bby_ has quit IRC |
| 23:26:47 | *** r0bby_ has joined #openmrs |
| 23:26:47 | *** ChanServ sets mode: +v r0bby_ |
| 23:43:46 | *** Felipo has quit IRC |
| 23:49:40 | *** wyclif has joined #openmrs |