IRC Chat : 2012-04-05 - OpenMRS

00:07:03 <r0bby> hey peoples
00:07:12 <r0bby> hey djazayeri -- jus saying hi
00:07:23 <djazayeri> hi r0bby
00:08:01 *** harshadura has joined #openmrs
00:11:21 *** harshadura has quit IRC
00:11:31 *** harshadura has joined #openmrs
01:02:20 <downey> hi r0bby
01:02:40 <downey> Hi r0bby and welcome to the #openmrs IRC channel.
01:07:40 *** wyclif has joined #openmrs
01:07:46 <wyclif> hi djazayeri
01:07:51 <djazayeri> hi wyclif
01:08:44 <wyclif> for REPORT-49, aren't those methods supposed to be added/removed to/from DefinitionService ?
01:08:48 <wyclif> djazayeri, for REPORT-49, aren't those methods supposed to be added/removed to/from DefinitionService ?
01:09:01 <wyclif> djazayeri, and not BaseDefinitionService\
01:10:12 <djazayeri> wyclif: I think they should probably be added to both the interface and the base class, yes.
01:12:56 <wyclif> djazayeri, the implementation will in the Base class ofcourse
01:13:19 <wyclif> djazayeri, i just meant the superi nterface where to define the,
01:13:31 <wyclif> djazayeri, i just meant the super interface where to define them
01:14:03 <djazayeri> wyclif: I think we're adding this "tagging" ability to all definitions, so it should go on DefinitionService (and BaseDefinitionService)
01:14:15 <wyclif> right
01:40:08 *** r0bby is now known as robbyoconnor
01:41:20 *** harshadura has quit IRC
02:03:51 *** harshadura has joined #openmrs
02:15:56 *** harshadura has quit IRC
02:27:44 *** harshadura has joined #openmrs
03:06:01 *** dileepsisila has joined #openmrs
03:51:15 *** finbrein has quit IRC
04:10:03 *** finbrein has joined #openmrs
04:37:28 *** downey has quit IRC
05:06:18 *** goutham has joined #openmrs
05:28:16 *** harshadura has quit IRC
05:28:21 *** dileepsisila has quit IRC
05:48:08 *** djazayeri1 has joined #openmrs
05:51:41 *** djazayeri has quit IRC
05:57:13 *** djazayeri1 has quit IRC
06:01:02 *** djazayeri has joined #openmrs
06:01:02 *** ChanServ sets mode: +o djazayeri
06:14:02 *** dkayiwa has joined #openmrs
06:25:01 *** upul` has joined #openmrs
06:25:01 *** ChanServ sets mode: +v upul`
06:26:36 *** apurvmehra has joined #openmrs
06:39:04 *** finbrein has quit IRC
06:46:48 *** deadpool has quit IRC
06:51:42 *** bryq has joined #openmrs
06:51:42 *** ChanServ sets mode: +v bryq
06:54:11 *** apurvmehra has quit IRC
06:58:56 *** deadpool has joined #openmrs
06:59:47 *** nadee has joined #openmrs
07:01:16 *** apurvmehra has joined #openmrs
07:02:08 *** djazayeri has quit IRC
07:02:51 <deadpool> dkayiwa: do you know how to unlock a user
07:06:50 <dkayiwa> deadpool: in openmrs?
07:07:01 <deadpool> yea
07:07:02 <deadpool> h
07:07:12 <dkayiwa> deadpool: how did you unlick him? :)
07:07:20 <dkayiwa> unlick = lock :)
07:07:38 <deadpool> unlick?
07:07:44 <dkayiwa> deadpool: sorry typing error
07:07:52 <dkayiwa> deadpool: how did you lock him
07:08:01 <deadpool> oh login attempts
07:08:36 <dkayiwa> deadpool: i think you should be able to manipulate the database and unlock him :)
07:09:53 *** apurvmehra is now known as apurv
07:11:35 *** dileepsisila has joined #openmrs
07:12:27 <dileepsisila> <dkayiwa>https://wiki.openmrs.org/display/projects/In-page+Localization+(Design+Page) i like to contribute this gsoc projects also
07:12:28 <dkayiwa> deadpool: i think you can use the edit user page
07:12:45 <dkayiwa> deadpool: it has loginAttempts
07:12:50 <dileepsisila> <dkayiwa> can i get detiails about it
07:14:09 <dkayiwa> dileepsisila: doesnt the project page have the details?
07:15:00 <dkayiwa> deadpool: the same page also has ability to enable the acount
07:19:29 <dileepsisila> <dkayiwa> yaaa... i followed it, it is a webpage localization project using spring tag libiraries
07:19:53 <dileepsisila> <dkayiwa> i used it for my university projects
07:21:47 <dileepsisila> <dkayiwa> i got the correct idea what is the project and problem and solution
07:22:21 <dileepsisila> <dkayiwa> but in this link, desing tasks are available so i am confusing some of them are
07:22:33 <dileepsisila> <dkayiwa> can you help me
07:22:41 <dkayiwa> dileepsisila: have you talked to the project mentor?
07:23:09 <dileepsisila> <dkayiwa> i tried catch him but i couldn't catch him
07:23:21 <dkayiwa> dileepsisila: who is he?
07:23:50 <dileepsisila> <dkayiwa> Ben wolfe
07:24:12 <dileepsisila> <dkayiwa>srry Mr. Ben wolfe
07:24:16 <dkayiwa> dileepsisila: how did you try catch him?
07:24:43 <dileepsisila> <dileepsisila> from the irc support
07:25:27 <dkayiwa> dileepsisila: what did he say?
07:26:33 <dileepsisila> <dkayiwa> no ne when i logged to the system, he was not here, so can i get a time for chat with him
07:26:56 <dkayiwa> dileepsisila: can you send him an email?
07:28:28 <dileepsisila> <dkayiwa> ok... i also added a comment to the project i think gsoc deadline is tommorow, if i get a reply from him , it is very supported to my project proposal
07:28:43 <dkayiwa> ok
07:33:09 <robbyoconnor> dkayiwa: it's friday actually
07:33:33 <dkayiwa> robbyoconnor: oh yes :)
07:34:00 <robbyoconnor> 12:00pm PT
07:34:05 <robbyoconnor> 3pm Eastern ;)
07:34:59 <robbyoconnor> Today felt like Thursday
07:35:00 <robbyoconnor> :/
07:37:44 <robbyoconnor> dileepsisila: you can also e-mail the dev list (all mentors are on it) and ask your questions there.
07:42:32 <robbyoconnor> dileepsisila: I STRONGLY advise you to ask on the dev list -- and be patient =)
07:42:38 <robbyoconnor> good luck.
07:47:31 *** apurv has quit IRC
07:52:31 *** apurvmehra has joined #openmrs
08:03:45 *** snoppy has joined #openmrs
08:17:31 *** apurvmehra has quit IRC
08:23:29 *** olabode has joined #openmrs
08:24:06 *** sanchitsharma98 has joined #openmrs
08:42:31 *** olabode has quit IRC
08:44:07 *** sanchitsharma98 has quit IRC
08:57:50 *** bryq has quit IRC
09:09:48 *** finbrein has joined #openmrs
09:38:24 *** rafa has joined #openmrs
09:38:24 *** ChanServ sets mode: +v rafa
09:41:10 *** sgithens_ has quit IRC
09:42:16 *** antonalsekeiev has joined #openmrs
09:52:38 *** bryq has joined #openmrs
09:52:38 *** ChanServ sets mode: +v bryq
09:53:46 *** dileepsisila has quit IRC
10:06:25 *** dkayiwa has quit IRC
10:08:25 *** dkayiwa has joined #openmrs
10:18:59 <nadee> hi, I'm working on https://tickets.openmrs.org/browse/TRUNK-2296, and commented regarding my query on it.
10:20:45 <nadee> Can anyone please help me with this since daruis is not around, thought of asking on irc
10:21:13 <nadee> Am i on right track?
10:26:18 *** bryq has quit IRC
10:32:45 <nadee> wyclif , you have any openion on this please? Just noted your comment on agreement
10:35:26 *** upul` has quit IRC
10:36:54 *** bryq has joined #openmrs
10:36:54 *** ChanServ sets mode: +v bryq
11:00:28 *** james_regen has joined #openmrs
11:00:28 *** ChanServ sets mode: +v james_regen
11:47:56 *** nadee has quit IRC
11:51:20 *** nadee has joined #openmrs
11:56:44 *** bryq has quit IRC
12:00:17 *** dkayiwa has left #openmrs
12:05:36 *** wyclif has quit IRC
12:07:51 *** dkayiwa has joined #openmrs
12:16:56 *** dkayiwa has left #openmrs
12:47:13 *** nribeka has joined #openmrs
12:47:13 *** ChanServ sets mode: +v nribeka
13:00:32 *** nadee has quit IRC
13:01:40 *** nadee has joined #openmrs
13:04:55 *** nribeka has quit IRC
13:06:15 *** nribeka has joined #openmrs
13:06:15 *** ChanServ sets mode: +v nribeka
13:08:57 *** MarkG has joined #openmrs
13:20:40 *** downey has joined #openmrs
13:20:40 *** OpenMRSBot sets mode: +o downey
13:20:40 *** ChanServ sets mode: +o downey
13:22:43 *** rafa_ has joined #openmrs
13:22:43 *** ChanServ sets mode: +v rafa_
13:24:38 *** rafa has quit IRC
13:34:16 *** mseaton has joined #openmrs
13:34:16 *** ChanServ sets mode: +v mseaton
13:34:47 *** downey has quit IRC
13:37:42 *** downey has joined #openmrs
13:37:42 *** OpenMRSBot sets mode: +o downey
13:37:43 *** ChanServ sets mode: +o downey
13:42:39 *** rafa has joined #openmrs
13:42:39 *** ChanServ sets mode: +v rafa
13:43:54 *** rafa_ has quit IRC
13:47:12 *** pulasthi7 has joined #openmrs
13:49:49 *** wyclif has joined #openmrs
13:52:19 *** nimanthab has joined #openmrs
13:52:25 *** rafa has quit IRC
13:52:35 <downey> Hi nimanthab and welcome to the #openmrs IRC channel.
13:53:26 <nimanthab> Thanks downey :)
13:53:49 <nimanthab> I am looking for directions to connect to the OpenMRS developer forum
13:54:04 <downey> nimanthab: go.openmrs.org/devmtg
13:55:12 <nimanthab> downey: Thanks. I added the freeconferencing user. Do I have to call that
13:55:25 <nimanthab> *that user?
13:55:44 <nimanthab> I am trying to connect via skype
13:57:31 *** goutham has quit IRC
13:57:54 <downey> yes
13:58:03 <downey> sorry, looks like someone took out that statement in the wiki page :)
14:01:12 <nimanthab> I called that user and I get an automated reply asking me to enter the access code. I entered it via the dial pad but it doesn't work. It keeps on asking me for the access code
14:01:15 <nimanthab> :(
14:01:53 <downey> nimanthab: see https://wiki.openmrs.org/display/RES/How+to+Join+the+Developers+Forum
14:05:35 <nimanthab> Thanks.. I am trying again.
14:07:12 *** djazayeri has joined #openmrs
14:07:12 *** ChanServ sets mode: +o djazayeri
14:08:04 *** bwolfe has joined #openmrs
14:08:04 *** ChanServ sets mode: +o bwolfe
14:12:14 <nimanthab> Still can't connect. The dial pad icon is not shown in my call window :(
14:17:29 *** mccallumg has joined #openmrs
14:17:29 *** ChanServ sets mode: +v mccallumg
14:21:52 *** jmiranda has joined #openmrs
14:22:05 *** ChanServ sets mode: +o jmiranda
14:27:22 *** downey has quit IRC
14:27:29 *** downey has joined #openmrs
14:27:29 *** ChanServ sets mode: +o downey
14:27:29 *** OpenMRSBot sets mode: +o downey
14:29:07 *** harshadura has joined #openmrs
14:31:44 *** rafa has joined #openmrs
14:31:44 *** ChanServ sets mode: +v rafa
14:34:19 *** anu_GSOC has joined #openmrs
14:37:42 *** dileepsisila has joined #openmrs
14:38:08 <dileepsisila> <@bwolfe>
14:38:24 <dileepsisila> <@bwolfe> are you here?
14:39:43 <bwolfe> I am here. not there.
14:39:44 <bwolfe> ;-)
14:40:57 <dileepsisila> <@bwolfe>i sent a mail to you about my project proposal, i got the reply
14:41:06 <dileepsisila> <@bwolfe>thanks for your reply
14:41:32 <dileepsisila> <@bwolfe>you said about 4 design in the url link
14:41:56 <dileepsisila> <@bwolfe>https://wiki.openmrs.org/display/projects/In-page+Localization+%28Design+Page%29#
14:42:20 <dileepsisila> <@bwolfe> so i like to implement design 3 and 4
14:45:33 <dileepsisila> <@bwolfe> so can i use one 1 design or both design to gsoc project
14:45:56 <bwolfe> dileepsisila, up to you
14:46:14 <bwolfe> but your proposal had 90% history of things that exist and 10% things you'd like to do
14:46:26 <bwolfe> a lot of proposals have implementation suggestions
14:46:32 <bwolfe> tools, options, mockups, etc
14:46:54 <bwolfe> oh, and your personal wiki page link was wrong. :-)
14:51:05 <dileepsisila> <@bwolfe> or realy sorry, https://wiki.openmrs.org/display/~dileepsisila/Home
14:51:14 <dileepsisila> this is the correct one
14:52:05 *** mseaton1 has joined #openmrs
14:52:26 *** mseaton has quit IRC
14:54:01 *** snoppy has quit IRC
14:54:44 *** mseaton1 has left #openmrs
14:55:14 *** mseaton has joined #openmrs
14:55:14 *** ChanServ sets mode: +v mseaton
14:56:02 <nribeka> mseaton, quick question
14:57:21 *** snoppy has joined #openmrs
15:00:04 *** mvorobey has joined #openmrs
15:00:19 <mvorobey> hi all
15:01:05 <djazayeri> hi mvorobey
15:03:18 <mseaton> nribeka, whats up?
15:04:01 <nribeka> mseaton, i'm wondering about AllObsQuery and AllEncounterQuery
15:04:25 <mseaton> nribeka, wondering about how awesome they are?
15:04:36 *** nimanthab has quit IRC
15:04:42 <nribeka> hahahahaha ... (change what i type to this)
15:05:33 <nribeka> well i'm wondering if we should expose parameters to make them return: all x (x is the encounter type) encounter or all cd4 obs?
15:05:46 <nribeka> and make the params optional
15:07:20 *** rafa has quit IRC
15:07:38 *** djazayeri1 has joined #openmrs
15:08:23 *** djazayeri has quit IRC
15:12:14 *** hemanth_92 has joined #openmrs
15:14:20 *** apurv has joined #openmrs
15:14:25 *** snoppy has left #openmrs
15:14:34 <downey> Hi apurv and welcome to the #openmrs IRC channel.
15:15:09 *** anu_GSOC has quit IRC
15:15:41 *** nribeka has quit IRC
15:16:01 <apurv> hi downey, glad to be here !!
15:18:21 *** rafa has joined #openmrs
15:18:22 *** ChanServ sets mode: +v rafa
15:19:25 <mvorobey> mseaton, hi Mike :)
15:19:38 <mseaton> hi mvorobey
15:20:11 <mvorobey> mseaton, would you like to assess https://tickets.openmrs.org/browse/REPORT-353 ?
15:20:35 *** MarkG has quit IRC
15:20:51 <mvorobey> mseaton, so I can begin work on it
15:21:08 *** bwolfe has quit IRC
15:21:41 *** MarkG has joined #openmrs
15:22:05 *** antonalsekeiev has quit IRC
15:26:15 *** MarkG has quit IRC
15:26:28 *** sanchitsharma98 has joined #openmrs
15:26:39 <downey> Hi sanchitsharma98 and welcome to the #openmrs IRC channel.
15:26:48 <sanchitsharma98> hi downey
15:28:40 <mvorobey> mseaton, and one more question, where I should place javascript library within reporting module ?
15:29:00 <mseaton> mvorobey: on another call. give me a few minutes
15:29:15 <mvorobey> mseaton, np :)
15:33:54 *** mccallumg has quit IRC
15:35:36 *** suranga has joined #openmrs
15:35:36 *** ChanServ sets mode: +v suranga
15:36:41 *** apurv has quit IRC
15:38:45 *** rafa has quit IRC
15:39:11 *** dileepsisila has quit IRC
15:46:12 *** Indie has joined #openmrs
15:46:24 <downey> Hi Indie and welcome to the #openmrs IRC channel.
15:46:37 <Indie> hey, hows it going?
15:52:58 *** mccallumg has joined #openmrs
15:52:58 *** ChanServ sets mode: +v mccallumg
15:54:19 *** MarkG has joined #openmrs
16:00:42 *** r_friedman has joined #openmrs
16:02:06 *** anu_GSOC has joined #openmrs
16:04:34 *** jmiranda has quit IRC
16:07:28 *** jriley has joined #openmrs
16:10:13 *** lhawthor has joined #openmrs
16:10:18 *** lhawthor is now known as lh
16:10:24 *** lh has joined #openmrs
16:20:46 *** jmiranda has joined #openmrs
16:20:49 *** harshadura has quit IRC
16:21:00 *** ChanServ sets mode: +o jmiranda
16:21:37 <mseaton> mvorobey: sorry, i made that ticket ready for work
16:22:35 <mseaton> mvorobey: javascript, css, images, etc are placed under web/module/resources
16:24:47 <mvorobey> mseaton, I already found that place, but thanks anyway :)
16:29:14 <mvorobey> mseaton, I think that REPORT-353 can go after REPORT-312, what do you think ?
16:29:51 <mseaton> mvorobey: yes REPORT-312 is more important
16:30:45 <mseaton> mvorobey: i'm going to apply REPORT-339 patch now. great work, thanks!
16:31:43 <mvorobey> mseaton, do not mention it :)
16:31:53 *** Indie has quit IRC
16:32:28 <mvorobey> mseaton, I have some questions on REPORT-312
16:35:34 <mseaton> mvorobey: sure.
16:36:00 <jriley> How can I unlock a user account from within MySQL? I did a clean install of 1.9 RC2, which contains the bug that locks out the admin account. I don't see where the user # login attempts or lockout timestamp are stored
16:36:17 <jriley> And as a brand new install, there are no additional accounts to log in with
16:37:05 <mvorobey> mseaton, as I understood from mockup there should be possibility to edit simple cron using GUI elements, and to enter more sophisticated expressions within text fields. What is possible value for each dropdown on that widget ? and should it be created as modal popup or we can extend existing jsp for now ?
16:37:42 <mseaton> i think a modal popup is probably best / easiest.
16:38:07 <mseaton> basically, the user should first choose from the drop down, either "Once", "Every Day", "Every Week", etc
16:38:31 <mseaton> then, depending on which of these they check, they should see the corresponding options next to it
16:38:56 <mseaton> for the "Every month" case, i'm envisoning options being:
16:39:00 <mseaton> The first day
16:39:01 <mseaton> The last day
16:39:34 <mseaton> the 1st, the 2nd day, the 3rd day, ...
16:39:56 <mseaton> with an option to add as we go, more complex options (eg. the first weekday, etc)
16:40:01 <mvorobey> mseaton, so, if user selects option "Once" he sees certain inputs, and if he selects "Every Day " he sees another ones, yes?
16:40:18 <mseaton> mvorobey: yes, like in the mockup on REPOT-335
16:40:25 <mseaton> !ticket REPORT-335
16:40:26 <OpenMRSBot> mseaton: [#REPORT-335] Update the "Run Report" page to include information about previous and current evaluations of the report - OpenMRS JIRA - https://tickets.openmrs.org/browse/REPORT-335
16:40:39 <mseaton> the mockup for this is buried in the mockup for that ticket
16:40:48 *** kdeeq has joined #openmrs
16:40:54 <downey> Hi kdeeq and welcome to the #openmrs IRC channel.
16:42:32 *** dave_r has joined #openmrs
16:43:11 <mccallumg> Hi downey and welcome to the #openmrs IRC channel.
16:43:46 <mvorobey> mseaton, is possibility of adding more complex crons gonna be provided by "Advanced" select option ?
16:43:58 <dave_r> Hi, is there anyone here that may help with the REST web services?
16:44:02 <mseaton> yes, exactly. just a text field for entering a cron expression there.
16:44:10 <mseaton> mvorobey: back in about 2 hours
16:44:48 <mvorobey> mseaton, thanks for design discussion, good luck :)
16:45:06 <jriley> Reinstall it is.
16:49:41 <robbyoconnor> hey jriley!
16:49:53 <jriley> Hey, robbyoconnor!
16:52:37 <dave_r> if I'm creating a patient with the rest ws, does any1 know how to add attributes to be saved with patient?
16:53:38 *** kmit has joined #openmrs
16:55:06 <dave_r> my current payload is here: http://pastebin.com/g0RUL4tw
17:01:13 *** nribeka has joined #openmrs
17:01:13 *** ChanServ sets mode: +v nribeka
17:04:49 <robbyoconnor> hey nribeka
17:07:30 *** dileepsisila has joined #openmrs
17:10:48 <nribeka> yo robbyoconnor
17:11:00 <robbyoconnor> What's poppin?
17:11:03 <nribeka> sup robby the man ...
17:11:10 <nribeka> just lurking around as usual ...
17:14:09 <finbrein> hi all
17:14:27 <jmiranda> hey finbrein
17:14:56 <jmiranda> finbrein, let me guess ... you have a question about the reporting module
17:15:10 <finbrein> ;) jmiranda
17:15:27 <finbrein> the mind reader
17:15:30 <finbrein> lol
17:15:34 *** isharapremadasa has joined #openmrs
17:16:39 *** rafa has joined #openmrs
17:16:39 *** ChanServ sets mode: +v rafa
17:16:43 <jmiranda> finbrein, this actually might be the problem
17:16:44 <jmiranda> https://tickets.openmrs.org/browse/TRUNK-3109
17:16:46 <isharapremadasa> nick isharap
17:16:55 <jmiranda> !ticket TRUNK-3109
17:16:56 <OpenMRSBot> jmiranda: [#TRUNK-3109] Remove java keywords from jsp - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3109
17:16:57 <isharapremadasa> oops sorry pls ignore that
17:17:15 *** isharapremadasa is now known as isharap
17:19:18 <finbrein> i am having an issue when i click on the Simple Patient DataSet , found in Administration >> Manage Report Definitions >> Simple Patient DataSet . It crashes when I click on the + sign.Logic and Data Export Data Sets worked as expected. The other data sets did not. The trace is here - http://pastebin.com/G1fRggHN . Could you advise?
17:19:39 <finbrein> My App Server - Tomcat 7.0.26
17:21:50 <jmiranda> finbrein, the workaround is to disable the setting via a command-line argument
17:22:18 <finbrein> ah, ok, thanks jmiranda
17:22:19 <jmiranda> in your start script, add "-Dorg.apache.el.parser.SKIP_IDENTIFIER_CHECK=true" to the CATALINA_OPTS property
17:22:59 <jmiranda> there's a code change that we can/should make to the reporting module, but that might not get into a release for awhile
17:23:39 <jmiranda> mseaton, who owns the reporting module? can finbrein add a ticket for this issue?
17:25:32 <dave_r> hi jmiranda, would you be able to help with a question I have on the rest web services module?
17:26:11 <jmiranda> dave_r, there's a very good chance i won't be able to help :)
17:26:24 <jmiranda> dave_r, but you may ask anyway
17:27:44 <dave_r> ok thank you. i'm trying to create a patient through the rest ws. i am able to do that successfully. now i'm trying to create with attributes, but when I try to create I get class cast exception
17:28:48 <r_friedman> !ticket TRUNK-2963
17:28:49 <OpenMRSBot> r_friedman: [#TRUNK-2963] Saving state triggered conversion should show error message for missing information. - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2963
17:29:03 <dave_r> this is the json I'm sending: http://pastebin.com/b0jVxtC8
17:30:06 *** MarkG1 has joined #openmrs
17:31:18 <dave_r> and this is the abbreviated response: http://pastebin.com/yWrAkbgi
17:31:26 *** MarkG has quit IRC
17:32:08 <dave_r> is there anything you might see I'm doing wrong?
17:33:09 *** Jianhua has joined #openmrs
17:33:21 *** kmit has quit IRC
17:33:23 <downey> Hi Jianhua and welcome to the #openmrs IRC channel.
17:36:01 *** bwolfe has joined #openmrs
17:36:01 *** ChanServ sets mode: +o bwolfe
17:36:34 *** anu_GSOC has quit IRC
17:36:41 *** harshadura has joined #openmrs
17:43:20 *** rafa has quit IRC
17:43:40 *** bryq has joined #openmrs
17:43:40 *** ChanServ sets mode: +v bryq
17:46:41 *** sanchitsharma98 has quit IRC
17:50:14 *** ravina96 has joined #openmrs
17:50:28 <downey> Hi ravina96 and welcome to the #openmrs IRC channel.
17:50:50 <ravina96> hi thank you
17:51:45 <ravina96> what exactly is this chatroom used for?
17:53:28 <jmiranda> dave_r, sorry just saw that you replied. taking a look
17:55:06 <jmiranda> ravina96, mostly discussions about openmrs development issues
17:55:38 <ravina96> oh, okay. is everyone who is a part of this chatroom help with the coding of the openmrs?
17:59:18 <jmiranda> ravina96, mostly but there are also some users/implementers (i assume), as well as aspiring openmrs developers (e.g. google summer of code candidates)
18:00:21 <jmiranda> are you hosting the restws yourself or calling an instance out on the web?
18:00:36 <jmiranda> (sorry that was for dave_r)
18:02:38 *** bwolfe has quit IRC
18:03:21 *** ravina96 has quit IRC
18:03:28 <jmiranda> dave_r, the reason i ask is because i was hoping you might have access to the log files
18:03:49 *** kdeeq has quit IRC
18:05:46 <dave_r> i am hosting it locally
18:06:19 <dave_r> I have it running in Tomcat with remote debugging, and am trying to step through it in eclipse. is there a log file i can send you?
18:09:03 *** downey has quit IRC
18:09:10 *** downey has joined #openmrs
18:09:10 *** ChanServ sets mode: +o downey
18:09:10 *** OpenMRSBot sets mode: +o downey
18:09:47 <jmiranda> dave_r, bear with me. i haven't worked with openmrs in over a year, so i'm downloading the source for the module to take a look.
18:10:53 <jmiranda> dave_r, this is the webservices.rest module correct?
18:11:05 <dave_r> jmiranda, oh, i hope this is not a burden. If your not familiar then thats ok
18:11:07 <r_friedman> dave_r, i've been working with that module, maybe i can help
18:11:23 <jmiranda> r_friedman, does it support patient attributes?
18:11:31 <dave_r> @jmiranda yes thats the module
18:11:33 <r_friedman> yes
18:11:45 <dave_r> r_friendman, I am trying to create a patient with attributes
18:12:06 <dave_r> r_friendman, i can create a patient without attributes successfully, but now I want to create with attributes
18:12:32 <r_friedman> dave_r, do you know which attribute types you want to create?
18:12:36 <dave_r> r_friendman, here is my json
18:12:38 <dave_r> http://pastebin.com/b0jVxtC8
18:14:51 <r_friedman> dave_r, you say you can create a patient without attributes ... does that include with the patient identifier?
18:15:01 <dave_r> yes
18:16:04 <r_friedman> dave_r, it should work just like patient identifier ... what behavior are you seeing?
18:16:08 <jmiranda> dave_r, what does your code for adding attributes to the patient look like
18:16:22 <r_friedman> jmiranda: that's his pastebin
18:16:22 <jmiranda> dave_r, before it's serialized to json
18:16:36 <dave_r> r_friendman, wait a second, that might be an older version of the json, checking again
18:17:32 <jmiranda> r_friedman, i mean the java code used to populate the patient (assuming he's creating the object, then serializing to json)
18:18:15 <r_friedman> jmiranda: ok, i was assuming the opposite
18:18:28 <dave_r> r_friendman, I've just confirmed, that json I pasted will create a patient if I remove the "attributes" property
18:18:36 <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Only 24 hours left for students to apply for Google Summer of Code - read more and apply now: http://t.co/iMQ0OW1X #GSoC #OpenMRS <http://twitter.com/OpenMRS/statuses/187956818700550144>
18:19:10 <r_friedman> dave_r: and with the property?
18:19:20 *** downey_ has joined #openmrs
18:19:20 *** ChanServ sets mode: +o downey_
18:19:57 <dave_r> r_friendman, here is response json: http://pastebin.com/fb8HGSyp
18:21:19 *** downey has quit IRC
18:21:29 <dave_r> jmiranda, I'm using the Jackson JSON library, specifically the JsonNode API
18:22:01 *** downey has joined #openmrs
18:22:01 *** ChanServ sets mode: +o downey
18:22:01 *** OpenMRSBot sets mode: +o downey
18:22:01 <jmiranda> dave_r, so you're creating the json from scratch? or taking a Patient object and converting it to json?
18:22:12 <r_friedman> dave_r, attributes belong to person, not patient
18:22:26 <r_friedman> try adding the collection to the associated person
18:22:31 *** isharap has quit IRC
18:23:09 <dave_r> r_friendman, do you know how I can do that? is there something I need to change in the json?
18:23:26 <dave_r> jmiranda, I am creating the json from scratch (building the JsonNode document)
18:23:36 *** downey_ has quit IRC
18:24:54 <dave_r> jmiranda, the serialized json is at the pastebin. I'm currently testing by using RESTClient 2.3.3 with that json as the body
18:24:58 <r_friedman> dave_r: after you create the patient, you should get back new json with a person field, use that uuid to get the person, then add the attributes
18:25:48 <dave_r> r_friendman, ahh ok. so 2 separate request?
18:26:21 <r_friedman> dave_r: not guaranteed, i've never done it, but that looks like what is necessary
18:30:03 *** bwolfe has joined #openmrs
18:30:03 *** ChanServ sets mode: +o bwolfe
18:30:14 *** snoppy has joined #openmrs
18:31:41 <dave_r> r_friendman: ok, I just created a patient, then used the person link. I posted a json object with the attributes property. Here is the response: http://pastebin.com/NBPZq2qy
18:32:31 *** Jianhua has quit IRC
18:32:56 *** nadee has quit IRC
18:32:58 <r_friedman> dave_r, sorry to take long, there's no n in my name so i'm not getting a ping
18:33:19 <r_friedman> give me a couple of minutes, i'm on skype also
18:33:32 <dave_r> r_friedman, my apologies :) didn't notice
18:33:46 *** dileepsisila has quit IRC
18:34:08 *** bwolfe has quit IRC
18:34:29 <dave_r> r_friedman: here is the json object i posted to the person resource link, http://pastebin.com/UdDbw2Hz
18:34:34 <r_friedman> dave_r, np, sorry to juggle you
18:36:31 *** nadee has joined #openmrs
18:36:59 <dave_r> r_friedman, in BaseDelegatingResource, the setProperty method, it looks like the attributes property is remapped to activeAttributes. On line 288 it fails to find a write method
18:38:00 <r_friedman> dave_r, could you try this: post person/(uuid)/attribute providing attribute type and value?
18:40:35 <dave_r> r_friedman, interesting, now seeing: http://pastebin.com/b9bC7zWG
18:41:23 *** downey has quit IRC
18:41:43 <finbrein> jmiranda: voala! It worked with Tomcat 6! Thanks
18:41:46 <dave_r> r_friedman, I also had to use person/uuid/attributes instead of just attribute
18:42:21 <r_friedman> dave_r, oh yeah, we're fighting over naming and capitalization conventions :-)
18:43:22 *** rafa has joined #openmrs
18:43:22 *** ChanServ sets mode: +v rafa
18:43:34 <dave_r> r_friedman, possibly success.. 1 sec
18:44:23 <dave_r> r_friedman, it was a success. here is the payload I used http://pastebin.com/ytBu3E43
18:45:02 <dave_r> r_friedman, thank you for the help. not to bother you more :) but do you know if there is a way to get a list of all attributes in the system? or will I need to hard code uuid?
18:45:28 *** deadpool has quit IRC
18:45:56 <r_friedman> dave_r, cool, could you write a dev list e-mail describing your experience? Because I don't think all subresources act consistently, although it may be because of the hidden person level in patient
18:47:03 *** dushyant has joined #openmrs
18:47:31 <r_friedman> dave_r, i know we were discussing this. could you mention this in your dev list e-mail to remind us, we're talking about rest.webservices next Wed pm
18:48:25 <r_friedman> dave_r, also you might try ...v1/catalog to see what methods are available
18:49:51 *** dushyant has quit IRC
18:49:54 *** downey has joined #openmrs
18:49:54 *** ChanServ sets mode: +o downey
18:49:54 *** OpenMRSBot sets mode: +o downey
18:50:47 *** dileepsisila has joined #openmrs
18:50:57 *** Indie has joined #openmrs
18:51:22 <dileepsisila> bwolfe is here
18:55:14 *** mvorobey has quit IRC
18:55:42 <dave_r> r_friedman, there is a way to access all the attributes in the system (/ws/rest/v1/personattributetype)
18:57:04 <dave_r> r_friedman, thanks again for all the help
18:57:07 *** rafa has quit IRC
18:57:17 *** rafa has joined #openmrs
18:57:17 *** ChanServ sets mode: +v rafa
18:57:42 <r_friedman> dave_r, yes, personattributetype is right, i was thinking you wanted to get all attribute values regardless of person, not all types sorry
19:02:21 *** deadpool has joined #openmrs
19:03:05 *** dawn_ has joined #openmrs
19:03:12 *** ChanServ sets mode: +v dawn_
19:03:22 <dawn_> !scrumon dawn
19:03:22 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready.
19:03:27 <dawn_> Hi Everyone!
19:03:31 <wyclif> hi
19:03:54 *** bwolfe_ has joined #openmrs
19:03:54 *** ChanServ sets mode: +o bwolfe_
19:04:10 <dawn_> today's order: wyclif , mseaton , rafa , djazayeri1 , bwolfe_
19:04:17 *** djazayeri1 is now known as djazayeri
19:04:18 <rafa> hi
19:04:18 *** ChanServ sets mode: +o djazayeri
19:04:23 *** bwolfe_ is now known as bwolfe
19:05:25 <wyclif> v
19:05:27 <wyclif> wednesday:
19:05:27 <wyclif> * minor TODOs for REPORT-336
19:05:27 <wyclif> * email and irc discussions with mike and darius for some report tickets
19:05:27 <wyclif> * REPORT-49 - Add a mechanism for tagging / categorizing reports and other reporting elements
19:05:27 <wyclif> * regenstrief WIP(Paul will be presenting)
19:05:28 <wyclif> * design call
19:05:29 <wyclif> Thursday:
19:05:31 <wyclif> * Still working on REPORT-49 - Add a mechanism for tagging / categorizing reports and other reporting elements
19:05:34 <wyclif> * skype chat with mike about the GSoC project for logging errors to database
19:05:36 <wyclif> * dev call
19:05:38 <wyclif> * GSoC application reviews
19:05:40 <wyclif> Blockers: none
19:06:11 <dawn_> mseaton: your turn
19:07:00 *** downey has quit IRC
19:07:00 *** dileepsisila has quit IRC
19:07:11 <dawn_> rafa: can you go please? :)
19:07:16 <rafa> Today:
19:07:16 <rafa> * Committed tests for TRUNK-3241: PersonAddresses get voided and recreated on form submission
19:07:16 <rafa> https://tickets.openmrs.org/browse/TRUNK-3241
19:07:16 <rafa> * Failed on TRUNK-3234: Failed to run sql dump file with testing installation method
19:07:16 <rafa> https://tickets.openmrs.org/browse/TRUNK-3234 and related
19:07:16 <rafa> TRUNK-3022: Unable to use the the new release testing feature to upgrade a 1.6.4 database
19:07:16 <rafa> https://tickets.openmrs.org/browse/TRUNK-3022
19:07:17 <rafa> Blockers: TRUNK-3022, TRUNK-3234 need ideas on how to handle big imports/exports
19:07:25 *** downey has joined #openmrs
19:07:25 *** ChanServ sets mode: +o downey
19:07:25 *** OpenMRSBot sets mode: +o downey
19:07:47 <djazayeri> okay, let's come back to that discussion point
19:07:55 <dawn_> djazayeri: your turn
19:08:02 <djazayeri> Wednesday 04-Apr-2012
19:08:02 <djazayeri> * University call
19:08:02 <djazayeri> * Thoughtworks catchup call
19:08:02 <djazayeri> * Design call
19:08:02 <djazayeri> * Project Management call
19:08:02 <djazayeri> * (started) Create UI Widget Library module so I can finish fixing the UI Framework docs
19:08:02 <djazayeri> * (started) REPORT-330 (First pass at Data Export replacement)
19:08:03 <djazayeri> Thursday 04-Apr-2012
19:08:04 <djazayeri> * Dev call
19:08:04 <djazayeri> * Leadership call
19:08:05 <djazayeri> * (continue) REPORT-330 (First pass at Data Export replacement)
19:08:05 <djazayeri> * (continue) Create UI Widget Library module so I can finish fixing the UI Framework docs
19:08:06 <djazayeri> no blockers
19:08:14 <dawn_> bwolfe: your turn
19:08:42 * dawn_ is watching ben type
19:09:03 * dawn_ is waiting for ben to copy and paste
19:09:05 <bwolfe> emails
19:09:05 <bwolfe> debate TRUNK-3232 with wyclif and ada
19:09:05 <bwolfe> fixed TRUNK-3248
19:09:05 <bwolfe> spiked a little bit more on the eventbu1Gs module
19:09:05 <bwolfe> leadership call
19:09:06 <bwolfe> dev call
19:09:10 <bwolfe> done
19:09:14 <bwolfe> and now I need to go by a car
19:09:21 <bwolfe> (that is a blocker)
19:09:29 <dawn_> mseaton: are you there?
19:09:32 <bwolfe> *buy
19:09:54 <djazayeri> he's "away" on skype
19:10:14 <dawn_> !scrumoff dawn
19:10:14 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
19:10:20 <bwolfe> boo mseaton
19:10:24 <dawn_> Discussion topics: Blockers: TRUNK-3022, TRUNK-3234 need ideas on how to handle big imports/exports
19:10:46 <downey> !ticket TRUNK-3022
19:10:47 <OpenMRSBot> downey: [#TRUNK-3022] Unable to use the the new release testing feature to upgrade a 1.6.4 database - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3022
19:11:41 <djazayeri> rafa: so…the OOM occurs from building the ZIP because the ZIP is too big?
19:11:47 <djazayeri> or from dumping data?
19:11:50 <djazayeri> or from writing a string?
19:12:03 <rafa> djazayeri: from dumping data
19:12:34 <rafa> djazayeri: but even if we assing more memory it's terrribly slow...
19:12:53 <djazayeri> rafa: are we writing it to a string? to an outputstream?
19:13:00 <rafa> djazayeri: to outputstream
19:13:52 <djazayeri> Where in the code does this happen?
19:14:04 *** Echidna_ has quit IRC
19:14:12 <djazayeri> How can writing data to an outputstream lead to an OOM? Unless we're holding onto stuff in the background...
19:14:37 <djazayeri> is it because we've got an enormous resultset that we're paging through?
19:14:44 <djazayeri> -> iterating through?
19:14:59 *** Jianhua has joined #openmrs
19:15:06 <nribeka> i'm looking for mseaton too bwolfe hahaha ...
19:15:23 *** Echidna has joined #openmrs
19:15:23 *** ChanServ sets mode: +v Echidna
19:15:24 <rafa> djazayeri: there might be something wrong with how ResultSet is used
19:15:25 <nribeka> he's quite the celebrity for the last few days ...
19:16:06 <rafa> djazayeri: I need to run it with a profiler
19:16:20 <djazayeri> rafa: is there some code I can look at?
19:16:25 <rafa> djazayeri: to be sure where the problem is
19:16:27 <rafa> yes
19:16:28 <djazayeri> is this in the RTH module?
19:16:38 <wyclif> is it because the result set is too big to put in memory
19:16:40 <rafa> it's in the RTH module in HibernateTestingDao
19:16:59 <wyclif> why not do add ing a limit and fetch bits
19:17:04 <nribeka> maybe this rafa + djazayeri http://dev.mysql.com/doc/refman/5.0/en/connector-j-reference-implementation-notes.html
19:17:08 <OpenMRSBot> <http://ln-s.net/9x1M> (at dev.mysql.com)
19:17:42 <nribeka> see the ResultSet part to correctly stream data from database
19:18:21 <rafa> nribeka: in code we have conn.createStatement(ResultSet.TYPE_SCROLL_SENSITIVE, ResultSet.CONCUR_READ_ONLY);
19:18:34 <rafa> nribeka: the doc suggests conn.createStatement(java.sql.ResultSet.TYPE_FORWARD_ONLY,
19:18:34 <rafa> java.sql.ResultSet.CONCUR_READ_ONLY);
19:18:36 *** dileepsisila has joined #openmrs
19:19:46 <dileepsisila> <bwolfe> thanks for your ideas and now i think i am at correct way. but i have some question about the project
19:21:01 <dileepsisila> <bwolfe> when i translate word in firefox plugin , can you say which location should i save it? it can be server location or in my local machine location.
19:21:14 <djazayeri> rafa: indeed the comments in the link wyclif sent under the ResultSet header seem like they should solve this
19:22:08 *** bwolfe has quit IRC
19:22:48 <rafa> djazayeri: ok, I'll try that
19:23:08 <djazayeri> rafa: for what it's worth, I don't really care about slowness, as long as it doesn't take hours
19:23:14 *** MarkG1 has quit IRC
19:23:20 <djazayeri> but do you know what the really big tables are that we're dealing with?
19:23:59 *** dawn_ has quit IRC
19:24:15 <wyclif> djazayeri, it was win who added the link
19:24:35 <djazayeri> oh, right.
19:24:38 <djazayeri> nribeka++
19:24:38 <rafa> djazayeri: Daniel reported it takes hours given much more memory
19:24:53 <rafa> djazayeri: before it fails
19:24:55 <wyclif> but it looks like that blocks any connections to the DB until all the rows are fetched and will cause exceptions if any other requets are made
19:24:57 <djazayeri> rafa: do you know what tables are the huge ones?
19:25:39 <wyclif> djazayeri, so it seems that implementations will be down while this is taking place
19:25:44 <rafa> djazayeri: formentry_xsn is one example, not sure about others
19:26:11 <wyclif> did you read this: You must read all of the rows in the result set (or close it) before you can issue any other queries on the connection, or an exception will be thrown.
19:26:48 <wyclif> after reading it again, that shouldn't be a problem i guess
19:27:02 *** dawn_ has joined #openmrs
19:27:02 *** ChanServ sets mode: +v dawn_
19:27:04 <djazayeri> yeah, read it, not a problem
19:27:42 <djazayeri> rafa or nribeka: how big is formentry_xsn on ampath?
19:28:18 <dileepsisila> <+suranga> r u here
19:28:35 *** dawn_ has quit IRC
19:28:38 <djazayeri> nribeka / rafa: approx how many total rows versus how many non-archived rows?
19:29:00 <djazayeri> We could hardcode some custom select statements for specific tables
19:29:14 <rafa> djazayeri: I don't have access to that data. I just have some dump file from Daniel.
19:29:23 <djazayeri> nribeka: you there?
19:29:45 <nribeka> hmm
19:29:51 <djazayeri> i.e. somewhere we say that if there's a formentry_xsn table then we only do "select * from formentry_xsn where archived = false" (or whatever)
19:30:03 <djazayeri> nribeka: approximate or outdated numbers are fine
19:30:07 <nribeka> sorry, xchat on the new ubuntu doesn't really give notification
19:30:17 <nribeka> i can have a look at it
19:30:18 <nribeka> hold on
19:30:28 <dileepsisila> <@djazayeri> i have little bit question about localization webpages on openmrs can you help me
19:30:30 <nribeka> we have table per file option on
19:31:10 <djazayeri> if we're talking about 100 active forms, and 5000 archived ones, each one having a 1MB BLOB, then limiting to the non-archived versions might solve our problem.
19:31:36 <djazayeri> dileepsisila: I don't know much about that project
19:31:50 *** hemanth_92 has quit IRC
19:32:07 <nribeka> djazayeri: 344M
19:32:43 <djazayeri> nribeka: that's the size of the formentry_xsn table, on disk?
19:32:51 <nribeka> yeah
19:33:02 <djazayeri> that includes archived rows too?
19:33:03 <dileepsisila> <@djazayeri>ok, i want to know only, existing system is supported to localization language, and spring tag libraries use for it
19:33:09 *** MarkG has joined #openmrs
19:33:44 <djazayeri> dileepsisila: I don't understand the question. Currently we have localizations stored in messages.properties files for different locales, and we use the <spring:message/> tag
19:33:48 <nribeka> should include all xsns djazayeri
19:34:15 <djazayeri> nribeka: I haven't used formentry in many years. Remind me if you're still storing all the old versions of xsn files in that table
19:34:19 <nribeka> jeremy created a page to remove some old archived xsns
19:34:23 <nribeka> used to be bigger i think
19:34:26 <djazayeri> or are all 344MB active?
19:34:40 <suranga> hi dileepsisila
19:35:09 <nribeka> i think it is jer set it to store 1 active and 1 archived (older version) of the xsns
19:35:35 <djazayeri> nribeka: so presumably limiting to active only would cut the size in half
19:35:54 <nribeka> should be. i think it used to be around 600mb
19:36:20 <dileepsisila> <+suranga> hi suranga, i like to contribute web page localization project to gsoc
19:36:44 <dileepsisila> <+suranga>https://wiki.openmrs.org/display/projects/In-page+Localization+%28Design+Page%29
19:37:14 <suranga> dileepsisila, that is a great idea... but unfortunately, im not too proficient on that idea... :)
19:37:28 <djazayeri> rafa: anyway, I suggest both tweaking the connection settings, and also adding hardcoded where clauses for specific tables, specifically formentry_xsn
19:37:49 <dileepsisila> <+suranga> ok, thanks
19:38:55 <rafa> djazayeri: okay, I'll do that and try again
19:40:38 *** bryq has quit IRC
19:43:53 <djazayeri> okay, off to grab lunch
19:53:28 *** nadee has quit IRC
19:53:51 *** james_regen has left #openmrs
19:57:07 *** shanakaf has joined #openmrs
19:59:41 *** rafa has quit IRC
20:00:37 *** mvorobey has joined #openmrs
20:01:20 *** mvorobey has quit IRC
20:02:07 *** jriley has quit IRC
20:05:35 <mseaton> jmiranda / finbrein: see my response on the dev list. this was fixed during the sprint this week and should no longer be an issue if you run the reporting module from trunk
20:05:48 <jmiranda> mseaton, yeah i saw it
20:06:11 <mseaton> bwolfe / dawn_ sorry i missed the scrum yet again :)
20:06:18 <mseaton> nribeka, i'm back
20:06:34 <jmiranda> mseaton, finbrein is just trying to get his dev environment set up
20:07:11 <mseaton> finbrein, jmiranda: i building from trunk isn't an option, try running tomcat 6 instead
20:07:18 <jmiranda> so probably downloading modules, rather than building from code
20:07:26 <mseaton> (or the skip identifier check thing that jmiranda said)
20:07:28 <jmiranda> yeah, we already did that
20:07:34 <jmiranda> he's using tomcat6 now
20:07:48 <mseaton> jmiranda: ok, issue solved. no need for a new ticket was my point
20:08:16 <jmiranda> mseaton, sounds good. i asked because i wasn't sure whether it had been reported before or not
20:08:18 <mseaton> thanks for helping
20:08:42 <finbrein> can i close the ticket because it has already been created, mseaton.
20:08:50 <nribeka> mseaton, how do you want to do this?
20:09:05 <nribeka> should i create a pastebin?
20:09:43 <nribeka> i think the ObsDataSetDefinition works pretty much like the EncounterDataSetDefinition
20:10:12 <nribeka> some questions i want to ask are:
20:10:29 <mseaton> finbrein: done - i closed it as a dup of REPORT-311.
20:10:55 *** Indie has quit IRC
20:11:12 <finbrein> mseaton, excellent ;)
20:11:39 <nribeka> 1. do we want to create one Query object with lots of configurable properties (concept in question, coded answer, encounter types) or create separate Query object (MostRecentCodedObsQuery, MostRecentNumericObsQuery, FirstCodedObsQuery)
20:11:44 <mseaton> nribeka: pastebin is fine
20:11:54 <nribeka> this is for the row filter mseaton
20:12:17 <wyclif> hi mseaton
20:12:40 <mseaton> nribeka, do you have something coded already you want to review, or are you trying to design it out first?
20:12:43 <mseaton> hi wyclif
20:13:12 <wyclif> mseaton, djazayeri do we want tags to inherited i.e if i put a tag on definition, then all it applies to its subclasses?
20:13:42 <mseaton> wyclif: ? tags don't go at the class level. they go at the instance level.
20:14:07 <wyclif> mseaton, i thought we are tagging definitions
20:14:07 <mseaton> wyclif: no we don't want them inherited. you can tag individual instances only
20:14:25 <mseaton> wyclif: yes, instances of definitions. not types of definitions.
20:14:35 <mseaton> type is on the table as a convenience
20:14:38 <mseaton> to allow you to say:
20:14:38 <wyclif> mseaton, that means you cant tag a none concrete class i.e base classes and interfaces
20:14:42 <nribeka> mseaton,
20:14:44 <nribeka> http://pastebin.com/bS5Cy4CD
20:14:52 <mseaton> get me all objects that are of type CohortDefinition and tagged with Data Quality
20:14:57 <nribeka> it's coded. i just want to define some more row filters
20:15:29 <wyclif> mseaton, got you, i think i had i misunderstood something
20:15:49 <mseaton> wyclif: great!
20:16:01 <mseaton> nribeka: looking now...
20:17:27 <nribeka> most of them are copied from the encounter mseaton
20:17:46 <nribeka> some of the differences only in the AllObsQuery
20:17:55 <nribeka> and the evaluator
20:20:20 <mseaton> nribeka: i have to admit, i haven't given much thought at all to the existing encounter queries that are there. so they aren't necessarily great examples to model from. my gut would be to have a primary ObsQuery (and a primary EncounterQuery), which can have all properties null (and act like an AllObsQuery or an AllEncounterQuery) or can have one or more properties specified to limit the returned Obs and Encounters.
20:21:04 <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @ShellZero: @OpenMRS Developer Call was awesome! :) <http://twitter.com/OpenMRS/statuses/187988251536138240>
20:21:41 <nribeka> so i put all property i can think of right now in the AllObsQuery and the other ObsQuery extends the AllObsQuery so they get the same properties (maybe not the best design now i think of it)
20:23:18 <nribeka> mseaton, i was just thinking most of the ObsQuery will use similar properties but the way we evaluate them will differ (LastCodedObsQuery, FirstCodedObsQuery, LastNumericObsQuery etc)
20:24:10 <mseaton> nribeka: the AllObsQuery was meant to be a non-configuable query that could just be used to get back every Obs. it was not originally meant to be configurable to limit the Obs returned to some subset.
20:24:53 <mseaton> nribeka: the way darius did it with Cohort Definitions, is he had a BaseObsCohortDefinition, and then NumericObsCohortDefinition extends BaseObsCohortDefinition...
20:25:37 <nribeka> ah that's a better approach i think
20:26:11 <mseaton> the main reason they need to be separated out into separate classes for Numeric, Coded, etc, is because you may want to limit them by Numeric Range, one or more coded options, etc
20:26:36 <mseaton> if you aren't going to limit by value at all (eg. only limit by obsDatetime and concept), then you don't need the separate classes
20:27:26 <mseaton> here's what i might propose:
20:27:31 <mseaton> rename AllObsQuery to BaseObsQuery
20:27:52 <mseaton> it should return all Obs by default if no properties are configured, and should be a concrete class
20:28:37 *** pulasthi7 has quit IRC
20:28:39 <mseaton> it should allow for filtering by (at minimum) onOrAfterDate, onOrBeforeDate, List<Concept> concepts
20:28:55 <mseaton> so you could say, give me all Weights and CD4s during month X
20:30:33 <mseaton> also you could include a TimeModifier whichPerPerson and Integer howManyPerPerson property which would allow you to tell it to include "last 3 weights for each person", "most recent weight for each person"
20:30:39 <mseaton> nribeka: thoughts?
20:30:45 <nribeka> and then the sub class would be: the numeric (configurable property: numeric values) and the coded (configurable property: list of potential coded values).
20:30:50 <mseaton> djazayeri: any thoughts?
20:30:55 <nribeka> mseaton, yeah that make sense i think
20:31:05 <nribeka> djazayeri is out for lunch i think
20:31:06 <mseaton> nribeka: exactly, see djazayeri work on cohort definitions for examples
20:31:19 <djazayeri> i am watching irc flow by
20:31:27 <djazayeri> what ticket?
20:31:29 <nribeka> ouch he's here
20:31:34 <djazayeri> is this for obsdatadef?
20:31:41 <mseaton> obsquery
20:32:12 <djazayeri> obsquery…for patientdatadef?
20:32:14 <mseaton> eg, give me all obs (in a cohort-like-thingy) that match x criteria
20:32:35 <mseaton> to limit the rows of a row-per-obs dataset
20:32:43 <djazayeri> ah ok
20:32:45 <mseaton> or just to query the obs in your db
20:33:20 <djazayeri> makes sense to me as you wrote it
20:35:50 <mseaton> ok, cool. win, you happy with this?
20:36:04 <nribeka> ok mseaton. i will change the code and probably will change the encounter query too
20:36:05 <mseaton> er. nribeka?
20:36:16 <mseaton> sweet, thanks!
20:36:17 <nribeka> i will have a look at the cohort definition
20:36:45 <nribeka> will poke you again tomorrow (probably) or monday if i'm not done tomorrow
20:38:30 <mseaton> nribeka, poke away. i'll be around.
20:38:43 <nribeka> kewl kewl ...
20:45:01 *** dileepsisila has quit IRC
20:54:15 <suranga> hi wyclif :)
20:54:27 <suranga> finally managed to attaches patches for your reviews on CR-TRUNK-659
20:54:29 <suranga> :-)
20:55:25 <wyclif> hi suranga
20:55:38 <suranga> wyclif, :-)
20:55:52 <suranga> now i can stop hiding on IRC :P
20:57:50 <wyclif> suranga, why?
20:59:03 <suranga> wyclif, it feels so much better after you finish something you are supposed to do :-)
20:59:55 <nribeka> suranga boy, you can hide again now ...
21:00:15 <wyclif> suranga, sure and what is that?
21:01:01 <suranga> nribeka, now im hiding from jer, Ada and james (outstanding patientmatching bugs :-) :P
21:02:29 *** nribeka has quit IRC
21:14:05 *** dileepsisila has joined #openmrs
21:17:16 *** snoppy has quit IRC
21:19:00 * Jianhua exit
21:19:10 *** Jianhua has quit IRC
21:19:42 *** Indie has joined #openmrs
21:26:44 *** mseaton has left #openmrs
21:32:36 *** MarkG has quit IRC
21:35:29 *** dushyant has joined #openmrs
21:35:36 <downey> Hi dushyant and welcome to the #openmrs IRC channel.
21:45:11 *** dave_r has quit IRC
21:54:18 *** wyclif has quit IRC
22:01:18 *** r_friedman has quit IRC
22:01:30 *** dushyant has quit IRC
22:29:14 *** suranga has quit IRC
22:45:08 *** shanakaf has quit IRC
22:59:35 *** downey has quit IRC
23:04:48 *** wyclif has joined #openmrs
23:14:04 <robbyoconnor> hey wyclif :)
23:46:16 *** dileepsisila has quit IRC