IRC Chat : 2012-04-04 - OpenMRS

00:10:49 *** sgithens has quit IRC
00:46:52 *** wyclif has joined #openmrs
01:30:45 *** mseaton has joined #openmrs
01:30:45 *** ChanServ sets mode: +v mseaton
01:46:49 *** mseaton has quit IRC
02:06:20 *** mseaton has joined #openmrs
02:06:21 *** ChanServ sets mode: +v mseaton
02:09:14 <deadpool> bwolfe: i have a question about doing a hibernate search
02:10:42 <bwolfe> ok
02:10:44 <deadpool> i have this function http://pastebin.com/tRUQ2Gyc
02:11:48 <deadpool> and i am getting an error saying that it can't resolve the property inventoryname.prescribedname
02:12:10 <deadpool> inventoryname is an class which invoice.class has
02:12:19 <bwolfe> right, you need an addAlias("inventoryname", "inventoryname") after the createCriteria
02:12:26 <bwolfe> I assume inventoryname is a separate object?
02:12:31 <deadpool> yeah
02:12:46 <bwolfe> the addAlias is essentially that join
02:12:54 <bwolfe> once you put that in there you can do your dot notation like you have it
02:13:10 *** r_friedman has joined #openmrs
02:13:28 <r_friedman> !last downeym
02:13:28 <OpenMRSBot> r_friedman: (last [--{from,in,on,with,without,regexp} <value>] [--nolimit]) -- Returns the last message matching the given criteria. --from requires a nick from whom the message came; --in requires a channel the message was sent to; --on requires a network the message was sent on; --with requires some string that had to be in the message; --regexp requires a regular expression the message must match; (1 more message)
02:13:37 <bwolfe> FYI: make sure that your last line doesn't fail with an "index out of bounds" exception.
02:13:50 <bwolfe> !refer r_friedman [seen downeym]
02:13:50 * OpenMRSBot refers r_friedman to downeym was last seen in #openmrs 6 weeks, 5 days, 6 hours, 1 minute, and 27 seconds ago: <downeym> Hi downey and welcome to the #openmrs IRC channel.
02:13:57 <bwolfe> !refer r_friedman [seen downey]
02:13:57 * OpenMRSBot refers r_friedman to downey was last seen in #openmrs 5 hours, 36 minutes, and 51 seconds ago: <downey> isharap: Ooops, I must have missed you. :)
02:14:08 <bwolfe> he changed nicks roger
02:14:38 <r_friedman> bwolfe: is his e-mail mdowney or downeym?
02:15:08 <deadpool> bwolfe: so do you do something like this Criteria crit = sessionFactory.getCurrentSession().createCriteria(Inventory.class).addAlias("inventoryname","inventoryname")
02:15:24 <bwolfe> r_friedman, I think he is michael.at.openmrs
02:15:33 <bwolfe> deadpool, yes
02:15:34 <r_friedman> ok tks will try
02:38:07 <deadpool> bwolfe: thanks it works but it isi not addAlias it is createAlias
02:38:18 <bwolfe> so close!
02:48:21 *** Preeti has joined #openmrs
03:02:24 <r_friedman> !beer bwolfe
03:02:24 * OpenMRSBot slides bwolfe a pint
03:03:06 * bwolfe snags the pint, spilling it slightly
03:05:17 *** mseaton has quit IRC
03:28:26 *** upul` has joined #openmrs
03:28:26 *** ChanServ sets mode: +v upul`
03:40:34 *** r_friedman has quit IRC
03:42:06 *** Preeti has quit IRC
04:05:41 *** bwolfe has quit IRC
04:11:34 *** Indie_ has joined #openmrs
04:23:19 *** Indie_ has quit IRC
04:23:45 *** Indie_ has joined #openmrs
04:26:31 *** Indie_ has quit IRC
05:12:54 *** dileepsisila has joined #openmrs
05:21:16 *** dileepsisila has quit IRC
05:53:55 *** Rahul has joined #openmrs
06:04:11 *** Rahul has quit IRC
06:08:33 *** bryq has joined #openmrs
06:08:33 *** ChanServ sets mode: +v bryq
06:25:28 *** bryq has quit IRC
07:15:15 *** robbyoconnor has joined #openmrs
07:15:15 *** ChanServ sets mode: +v robbyoconnor
07:23:41 <finbrein> hi jmiranda
07:24:18 <finbrein> !jmiranda
07:24:19 <OpenMRSBot> finbrein: Error: "jmiranda" is not a valid command.
07:24:32 <finbrein> !last jmiranda
07:24:32 <OpenMRSBot> finbrein: (last [--{from,in,on,with,without,regexp} <value>] [--nolimit]) -- Returns the last message matching the given criteria. --from requires a nick from whom the message came; --in requires a channel the message was sent to; --on requires a network the message was sent on; --with requires some string that had to be in the message; --regexp requires a regular expression the message must match; (1 more message)
07:25:08 <finbrein> !refer jmiranda
07:25:08 <OpenMRSBot> finbrein: (refer <an alias, 2 arguments>) -- Alias for "action refers $1 to $2".
07:26:30 <finbrein> !refer finbrein [seen jmiranda]
07:26:30 * OpenMRSBot refers finbrein to jmiranda was last seen in #openmrs 1 day, 9 hours, 34 minutes, and 46 seconds ago: <jmiranda> i'll read through it tomorrow and add my comments to the proposal
07:27:26 <finbrein> hi robbyoconnor :-)
07:28:07 <finbrein> hi robbyoconnor ;)
07:28:23 *** free__ has joined #openmrs
07:29:06 <finbrein> hi nribeka
07:29:10 <robbyoconnor> hi
07:32:07 <finbrein> could you help with an issue, robbyoconnor. I want to clarify the relevant OpenMRS versions for birt reports module. Are they in the range OpenMRS 1.4.0 - 1.5? I imported the added omod for birt2_5_1 to OpenMRS 1.8.3 and I'm having a startup error.
07:32:55 <finbrein> I read the mailing archive and their is a similar issue where you simply change backslashes to forward slashes. I am using Win7.
07:33:31 <finbrein> I can paste the log and error message in pastebin.
07:35:16 <finbrein> http://pastebin.com/R07kcguP
07:37:06 *** free__ has quit IRC
07:37:29 *** dkayiwa has joined #openmrs
07:37:51 <finbrein> Are you there robbyoconnor?
07:42:16 <finbrein> hi all, i need help
07:46:55 <dkayiwa> finbrein: you just ask and anyone can answer you :)
07:49:16 <finbrein> thanks dkayiwa. I would like to clarify the relevant OpenMRS versions for the BIRT Reports Module. Are the OpenMRS versions in the range 1.4 - 1.5 only for BIRT 2_5_1? That is the latest version of BIRT Reports Module.
07:52:22 <finbrein> In any case, I added BIRT 2_5_1 to OpenMRS 1.8.3. Set the Global Properties but I'm getting error due to startup. I have read the mails in the implementers archive and their was a similar issue with the advice to replace backslahes with forward slashes, which I did. This is meant for the birt.HOME.
07:52:41 <finbrein> I have the logs in here - http://pastebin.com/R07kcguP
07:53:26 <robbyoconnor> finbrein: can't help you
07:53:40 <finbrein> ok, thanks robbyoconnor
07:53:45 <robbyoconnor> jmiranda is your likely would-be mentor
07:53:48 <robbyoconnor> speak to him
07:54:06 <robbyoconnor> though he's probably sleeping
07:54:17 *** maurya has joined #openmrs
07:54:18 <finbrein> ok
07:56:41 <finbrein> I have also checked the source codes related to this - BirtModuleActivator.java class and method startup(), line 61
07:57:44 <finbrein> There is a Platform class from the Eclipse framework with a method start.
08:01:11 <robbyoconnor> the Activator is a special type class
08:03:20 <robbyoconnor> it is run when the module itself is started
08:03:24 <robbyoconnor> and stopped
08:04:12 <finbrein> ok
08:04:13 <robbyoconnor> (that is for OpenMRS)
08:04:24 <finbrein> true
08:04:34 <robbyoconnor> not birt
08:06:31 <finbrein> but the BirtModuleActivator object is called. but the Eclipse BIRT Platform is failing to start
08:08:05 <finbrein> Due to a wrong path to the Report Engine or BIRT Runtime on my machine. By the way, I am using Release 2_5_1 for the Engine. A compatible one.
08:11:56 *** harshadura has joined #openmrs
08:15:03 <finbrein> thanks robbyoconnor - i'll do more digging
08:24:52 *** robbyoconnor has quit IRC
08:30:01 *** robbyoconnor has joined #openmrs
08:30:01 *** ChanServ sets mode: +v robbyoconnor
08:35:49 *** teddy has joined #openmrs
08:38:15 * teddy How do I get rid of the error "Unable to load/find moduleActivator" from the current basic module instance?
08:40:08 <finbrein> teddy: https://wiki.openmrs.org/display/docs/Troubleshooting+Compilation
08:40:09 <OpenMRSBot> <http://ln-s.net/8uh5> (at wiki.openmrs.org)
08:41:06 <finbrein> What is your OS, teddy?
08:43:30 <teddy> finbrein: ubuntu
08:44:43 <finbrein> from this line "2. Problem :" is relevant on the page.
08:53:30 *** nadee has joined #openmrs
08:55:21 <teddy> finbrein: I can't see the MODULE_ID tag in the omod's pom.xml
08:57:08 *** isharapremadasa has joined #openmrs
08:58:04 <finbrein> teddy: I am a newbie to the modules or plugins. I might not be able to help very much. I did a search to fetch that page. Which of the modules are you having issues with?
08:59:11 <teddy> finbrein: I am using the basic module, checked out from the svn
08:59:24 <finbrein> robbyoconnor: I'll send a nice email to the mailing list for everyone to read.
09:00:13 <teddy> finbrein: Any pointers to how I can solve the problem, anyone in the chat room. Lots of appreciation finbrein
09:00:37 <finbrein> teddy: you can also send an email to the implementers and developers mailing lists. I can check this basic module for the tags.
09:01:19 <teddy> finbrein: That will really help. Thanks for the support
09:01:33 *** isharapremadasa is now known as isharap
09:01:51 <nadee> hi, can someone please point me where I can find the jetty log?
09:02:00 <nadee> when running the webapp
09:06:51 *** upul` has quit IRC
09:07:43 *** deadpool has quit IRC
09:10:01 *** teddy has quit IRC
09:10:09 <nadee> actually there are some error messages on the browser, but they are not printed on the console (the commandline)
09:21:19 *** deadpool has joined #openmrs
09:39:43 *** harshadura has quit IRC
09:42:00 *** dileepsisila has joined #openmrs
09:42:20 *** fmir864 has joined #openmrs
09:42:24 <dileepsisila> dkayiwa, hi
09:43:27 <dileepsisila> <dkayiwa> r u here?
09:43:35 <dkayiwa> yes
09:43:40 *** goutham has joined #openmrs
09:44:53 <dileepsisila> <dkayiwa> yestere i sent a patch
09:45:37 <dileepsisila> https://tickets.openmrs.org/browse/TRUNK-3238
09:46:41 *** fmir864 has quit IRC
09:46:52 <dkayiwa> ok
09:47:04 <dileepsisila> https://tickets.openmrs.org/browse/TRUNK-1980
09:47:24 <dileepsisila> thanks for your instrunction.....
09:48:58 <dileepsisila> <dkayiwa> i like to contribute openmrs gsoc projects
09:51:43 *** nadee has quit IRC
09:57:31 *** dileepsisila has quit IRC
09:59:10 *** fmi864 has joined #openmrs
09:59:17 *** maurya_ has joined #openmrs
10:01:20 <isharap> djazayeri: hi, can i discuss about TRUNK-3008?
10:01:45 *** fmir864 has joined #openmrs
10:03:21 *** fmi864 has quit IRC
10:03:35 *** fmir864 is now known as tpkck7
10:05:05 <tpkck7> when i try to build openmrs trunk [ERROR] Failed to execute goal org.codehaus.mojo:buildnumber-maven-plugin:1.0:create occurs. Am I missing something?
10:09:36 *** maurya_ has quit IRC
10:10:33 *** maurya_ has joined #openmrs
10:10:48 *** maurya_ has quit IRC
10:17:18 *** r0bby has joined #openmrs
10:17:18 *** ChanServ sets mode: +v r0bby
10:17:42 *** rafa has joined #openmrs
10:17:42 *** ChanServ sets mode: +v rafa
10:20:09 <finbrein> robbyoconnor: finally it's working, my mistake
10:24:57 *** Mkop2 has joined #openmrs
10:24:57 *** ChanServ sets mode: +v Mkop2
10:27:08 *** robbyoconnor has quit IRC
10:27:08 *** Mkop has quit IRC
10:28:21 *** isharap has quit IRC
10:31:55 <tpkck7> i had a error when building workspace but it's solved by following the wiki to create a amven proxy server.
10:35:51 *** gauravpaliwal has joined #openmrs
10:35:51 *** ChanServ sets mode: +v gauravpaliwal
10:59:11 *** tpkck7 has quit IRC
11:11:34 *** hemanth_92 has joined #openmrs
11:12:11 *** maurya_ has joined #openmrs
11:13:15 *** hemanth_92 has left #openmrs
11:18:21 *** maurya_ has quit IRC
11:20:20 *** maurya_ has joined #openmrs
11:20:26 *** maurya has quit IRC
11:21:32 *** maurya_ is now known as maurya
11:21:37 <maurya> hi i am trying to build phr module ,it's throwing a null pointer exception when i'm trying to upload the omod file
11:23:11 *** james_regen has joined #openmrs
11:23:11 *** ChanServ sets mode: +v james_regen
11:30:01 *** maurya has quit IRC
11:31:24 *** maurya has joined #openmrs
11:31:31 <maurya> hi i am trying to build phr module ,it's throwing a null pointer exception when i'm trying to upload the omod file
11:31:46 <maurya> can anyone help ?
11:31:54 <gauravpaliwal> maurya: error ?
11:32:11 <gauravpaliwal> maurya: paste it on the pastebin,org
11:33:24 <maurya> http://pastebin.com/XLfJvbDV
11:37:48 <maurya> gauravpaliwal:
11:38:50 <gauravpaliwal> maurya: while uploading naah ?
11:39:05 *** hemanth_92 has joined #openmrs
11:39:43 *** harshadura has joined #openmrs
11:41:33 <maurya> gauravpaliwal: yes
11:42:58 *** bwolfe has joined #openmrs
11:42:58 *** ChanServ sets mode: +o bwolfe
11:43:25 <maurya> gauravpaliwal: are you getting the same problem?
11:44:59 <rafa> dkayiwa: hi
11:45:04 <dkayiwa> rafa: hi
11:45:09 <rafa> dkayiwa: do you know how to exit a patient from care?
11:45:23 <dkayiwa> rafa: yes using the patient dashboard
11:45:39 <rafa> dkayiwa: yeah, I can't find the button
11:45:50 <rafa> dkayiwa: can you be more precise, please?
11:46:03 <dkayiwa> rafa: are you looking at the overview tab?
11:46:10 <rafa> dkayiwa: yes
11:46:25 <dkayiwa> rafa: Do you see the Patient Actions groupbox?
11:46:36 <rafa> dkayiwa: yes, it's empty...
11:46:47 <dkayiwa> rafa: which version of openmrs?
11:46:55 <rafa> latest trunk
11:47:09 <dkayiwa> rafa: can you try refresh the browser?
11:47:23 <gauravpaliwal> maurya: which version of tomcat ?
11:47:25 <rafa> dkayiwa: still empty
11:47:42 <dkayiwa> rafa: it could be broken on trunk :(
11:48:27 <maurya> gauravpaliwal: 7.022
11:48:36 <rafa> dkayiwa: can you try it?
11:48:48 <rafa> dkayiwa: I created a new patient and actions are still empty
11:48:50 <dkayiwa> rafa: ok let me do si
11:48:51 <gauravpaliwal> maurya: try with 6.*
11:49:56 <maurya> rafa: i think you should set the global property
11:50:37 <rafa> maurya: which one?
11:50:49 <maurya> rafa: concept.reasonExitedCare
11:52:02 <maurya> gauravpaliwal: is it working for you with tomcat 6.* ??
11:52:25 <rafa> maurya: thanks that helped!
11:52:31 <gauravpaliwal> maurya: nvr tried it
11:53:49 <maurya> rafa: :) np
11:54:25 <maurya> gauravpaliwal: okay i'll try :-) thanks
12:05:21 *** nribeka has quit IRC
12:05:28 <maurya> gauravpaliwal: I am getting the same error in 6.* !
12:06:00 <gauravpaliwal> maurya: :( who is the maintainer of that module
12:06:00 <gauravpaliwal> ?
12:06:58 <maurya> gauravpaliwal: hui xiao
12:10:00 *** nadee has joined #openmrs
12:13:18 <maurya> gauravpaliwal:
12:13:51 <gauravpaliwal> maurya: try downloading it from the modules.openmrs.org
12:13:56 <gauravpaliwal> instead of building
12:14:11 <gauravpaliwal> because may be some issue with build environment
12:16:43 <maurya> gauravpaliwal: its not there in modules.openmrs.org
12:17:05 <gauravpaliwal> :(
12:17:38 *** hemanth_92 has quit IRC
12:21:13 <maurya> bwolfe: do you have any idea about phr module ? I am trying to install it from morning but its not working
12:23:49 <bwolfe> maurya, how is it not working?
12:23:56 <bwolfe> have you tried on lower versions of openmrs?
12:25:53 <gauravpaliwal> bwolfe: he is getting this : (05:03:24 PM) maurya: http://pastebin.com/XLfJvbDV
12:25:58 <maurya> bwolfe: yes I am using 1.8.3
12:27:47 *** snoppy has joined #openmrs
12:27:48 <bwolfe> you could just delete the log4j.xml from the config folder
12:27:49 <bwolfe> http://svn.openmrs.org/openmrs-modules/personalhr/trunk/metadata/
12:28:02 <bwolfe> if you're in linux, you can do it very easily:
12:28:29 <bwolfe> 1) double click on omod (zip) file 2) delete log4j.xml 3) close zip file box and choose "update zip"
12:28:51 <maurya> bwolfe: while trying to upload the omod file its throwing a nullpoint exception
12:30:02 <bwolfe> we should put a try/ catch around the log4j line in WebModuleUtil.startModule: DOMConfigurator.configure
12:30:11 <bwolfe> maurya or gauravpaliwal, can you open a ticket for that?
12:30:59 <gauravpaliwal> maurya: are you opening the ticket ?
12:31:13 <maurya> gauravpaliwal: yes
12:31:21 <gauravpaliwal> :)
12:34:03 *** lh has joined #openmrs
12:35:02 *** lh has joined #openmrs
12:36:09 *** wyclif has quit IRC
12:41:13 *** nribeka has joined #openmrs
12:41:13 *** ChanServ sets mode: +v nribeka
12:46:33 *** rubailly has joined #openmrs
12:47:58 *** rubailly has left #openmrs
12:50:17 *** gauravpaliwal has left #openmrs
12:50:50 *** rubailly has joined #openmrs
12:56:41 * finbrein got a lot of energy
12:57:08 * finbrein is excited
12:57:20 <nribeka> woohooo ...
12:58:58 *** bryq has joined #openmrs
12:58:58 *** ChanServ sets mode: +v bryq
13:01:01 *** downey has joined #openmrs
13:01:01 *** OpenMRSBot sets mode: +o downey
13:01:01 *** ChanServ sets mode: +o downey
13:01:21 *** mseaton has joined #openmrs
13:01:21 *** ChanServ sets mode: +v mseaton
13:01:31 *** nadee_ has joined #openmrs
13:01:41 <downey> Hi nadee_ and welcome to the #openmrs IRC channel.
13:02:06 <nadee_> hi downey
13:03:00 <nadee_> looks like im on two instances, one with my name and another with underscore appended :)
13:03:37 *** nadee_ has quit IRC
13:04:11 *** nadee has quit IRC
13:05:03 *** lh has quit IRC
13:06:00 *** nadee has joined #openmrs
13:06:54 *** lh has joined #openmrs
13:06:54 *** lh has joined #openmrs
13:07:11 *** isharapremadasa has joined #openmrs
13:08:09 *** isharapremadasa is now known as isharap
13:08:10 *** MarkG has joined #openmrs
13:08:35 <djazayeri> hi all
13:08:39 <bwolfe> https://wiki.openmrs.org/display/RES/OpenMRS+University
13:08:40 <OpenMRSBot> <http://ln-s.net/98-d> (at wiki.openmrs.org)
13:08:44 <djazayeri> we're doing the OpenMRS University call now
13:08:50 <djazayeri> see the link ben sent
13:08:50 <bwolfe> (link for darius above)
13:09:08 <djazayeri> if anyone has any questions about anything OpenMRS-related, we're doing an open Q&A session
13:09:15 <bwolfe> anyone and everyone is welcome
13:09:26 <finbrein> Are you awake, jmiranda? ;)
13:09:29 <djazayeri> so join us on the OpenMRS University link from connect.openmrs.org, or from ben's like above
13:09:36 <bwolfe> rfriedman has the floor right now...
13:10:20 <maurya> bwolfe: now its getting loaded but its not starting
13:10:21 <maurya> http://pastebin.com/HVTA84Tp
13:11:06 *** Rahul has joined #openmrs
13:11:20 <bwolfe> maurya, is the messaging module installed?
13:11:25 <bwolfe> if so, which version>
13:11:27 <bwolfe> ?
13:13:01 <maurya> yes ,messaging4all
13:14:28 <maurya> bwolfe: yes ,messaging4all
13:14:33 *** rafa has quit IRC
13:15:34 *** lh has quit IRC
13:17:12 <bwolfe> I don't know what that module is
13:17:17 <bwolfe> I thought it was just called "messaging"
13:17:31 <bwolfe> https://modules.openmrs.org/modules/view.jsp?module=messaging
13:17:31 *** Rahul has quit IRC
13:19:37 <maurya> messaging4all is a branch under messaging
13:19:41 <maurya> bwolfe:
13:19:53 <bwolfe> ah
13:20:03 <maurya> https://svn.openmrs.org/openmrs-modules/messaging/branches/messaging4all
13:22:35 <djazayeri> isharap: if you have a question about a ticket, you can also ask it directly on the ticket, especially if the person you're asking it to is not online
13:23:13 <maurya> bwolfe: I was mentioned in the phr module documentation to download the above module
13:25:18 *** wyclif has joined #openmrs
13:29:59 <maurya> bwolfe:
13:30:43 *** jmwogi has joined #openmrs
13:31:38 <jmwogi> mseaton, have you got a minute?
13:31:51 <mseaton> jmwogi - sure!
13:32:47 <jmwogi> the configurations in the Report Administration ought to be general configuration, right? i.e some of the ones you posted in the ticket
13:35:01 *** goutham has quit IRC
13:37:00 <isharap> djazayeri : sure, now the ticket description is very clear. i will start work on it. :)
13:37:10 <djazayeri> great!
13:38:38 <nribeka> hi mseaton
13:38:49 <mseaton> hi nribeka
13:39:21 <nribeka> so for obs, do you think we need separate data definition for value coded, value numeric etc?
13:40:08 <MarkG> isharap: i just added some comments to your HTML-3 commits. Things generally look good, I just had a couple questions. You can go ahead and response to my comment on github.
13:42:02 <nadee> hi devs, im trying a remote debug on IDEA, with my maven_opts set, and im running mvn jetty:run on webapp. But it extreamly time consuming to start, like an hour almost! any options I could get it done with less time please?
13:42:36 <isharap> MarkG: sure i will check it now and reply
13:43:14 <nribeka> nadee, i'm using idea
13:44:03 <nadee> nribeka : hi, I have set the maven_opts to -Xdebug - Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=8000
13:44:54 <MarkG> isharap: sounds good... i am actually writing another comment now, but i think you will get an email alert when i finish. thanks for working on this! are you working on another HTML ticket now?
13:45:16 <nribeka> nadee, my runner: "env MAVEN_OPTS='-Xdebug -Xnoagent -Djava.compiler=NONE -Xrunjdwp:transport=dt_socket,address=4000,server=y,suspend=n -Xmx512m -Xms512m -XX:PermSize=256m -XX:MaxPermSize=256m -XX:NewSize=128m -Djava.awt.headless=true -XX:+UseConcMarkSweepGC' mvn jetty:run -Djetty.port=8081"
13:45:35 <nadee> and I assume its no wrong.. but running the mvn jetty:run on webapp takes quite a lot of time on debug mode..
13:46:16 *** rubailly has quit IRC
13:46:32 <nribeka> maybe it got to do with your memory allocation and the size of your computer's physical memory
13:46:49 <nadee> nribeka, im on windows for the moment :( I assume this is what you set on the .bashrc?
13:47:17 <nadee> so in my case, iI set an env variable for maven_opts
13:49:03 <nadee> nribeka, thanks! i'll try setting the other options as well on my var, may be a memory problem
13:51:00 <mseaton> nribeka: haven't thought much about it, but i think yes in order to accurately indicate the datatype
13:55:39 *** Rahul has joined #openmrs
13:56:34 <nribeka> ok mseaton
13:56:56 <nribeka> i have a unit test for it and it seems to be working like i want it to be
13:57:06 <MarkG> isharap: everything looks good overall... can you add another commit that adds the new unit test I talked about, and removes the two old unit tests, the changes to applyTemplates, and the printlin? Then we should be good to go. You can add this patch directly to your patch-6 branch. thanks!
13:57:08 <nribeka> nadee, ok
14:00:24 <isharap> MarkG: allright will do it right now .
14:00:58 <MarkG> isharap: thanks!
14:02:14 *** r0bby is now known as robbyoconnor
14:03:21 *** maurya has quit IRC
14:06:33 *** MarkG has left #openmrs
14:06:45 *** MarkG has joined #openmrs
14:10:26 *** dawn_ has joined #openmrs
14:10:26 *** ChanServ sets mode: +v dawn_
14:10:56 *** nadee has quit IRC
14:12:31 *** jmwogi has quit IRC
14:12:56 *** Rahul has quit IRC
14:18:15 *** dkayiwa has quit IRC
14:24:10 *** dkayiwa has joined #openmrs
14:27:10 <finbrein> mseaton: could we have published and unpublished for a report
14:28:09 *** Akamau has joined #openmrs
14:28:15 <downey> Hi Akamau and welcome to the #openmrs IRC channel.
14:28:17 <finbrein> mseaton: I am making a UI for the BIRT Module
14:29:47 <mseaton> finbrein, yes there is a ticket for publish/unpublished reports here: https://tickets.openmrs.org/browse/REPORT-233
14:30:09 <finbrein> i'll check it out
14:30:11 <mseaton> finbrein: what sort of BIRT module UI are you making? is this for a particular ticket? GSoC?
14:30:21 <finbrein> GSoC
14:30:46 *** MarkG has left #openmrs
14:30:48 <mseaton> ok, let me know if you have any more questions
14:30:55 <dawn_> !scrumon dawn
14:30:55 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready.
14:30:58 <dawn_> Hi Everyone :)
14:31:01 *** MarkG has joined #openmrs
14:31:12 <dawn_> Today's order: wyclif , dkayiwa , djazayeri , bwolfe , mseaton
14:31:25 *** pulasthi7 has joined #openmrs
14:32:05 <wyclif> tuesday:
14:32:05 <wyclif> * complete REPORT-33
14:32:05 <wyclif> * Reviewed GSoc project proposals
14:32:05 <wyclif> * started on REPORT-49 - Page to view the current report generation queue and enable canceling queued items
14:32:05 <wyclif> wednesday:
14:32:07 <wyclif> * continue with REPORT-49 - Page to view the current report generation queue and enable canceling queued items
14:32:10 <wyclif> * regenstrief WIP(Paul will be presenting)
14:32:12 <wyclif> * design call
14:32:14 <wyclif> Blockers
14:32:16 <wyclif> none
14:32:21 *** MarkG has left #openmrs
14:32:26 <dkayiwa> Abandoned: (Because it was taking me longer than i sensed it should) Update reporting dashboard UI to better support systems with lots of reports in a variety of categories - REPORT-242
14:32:27 <dkayiwa> Committed: Mode Statistic available in logic indicator - REPORT-270
14:32:27 <dkayiwa> Now working on: EL exceptions in JSP pages when using Tomcat 7 due to class keyword - REPORT-311
14:32:27 <dkayiwa> No Blockers
14:33:14 <dawn_> djazayeri: your turn
14:33:16 *** MarkG has joined #openmrs
14:33:17 <djazayeri> Tuesday 03-Apr-2012
14:33:17 <djazayeri> * Revised UI Framework documentation
14:33:17 <djazayeri> * Thought about claiming REPORT-330 (First pass at Data Export replacement)
14:33:17 <djazayeri> Wednesday 04-Apr-2012
14:33:17 <djazayeri> * University call
14:33:17 <djazayeri> * Thoughtworks catchup call
14:33:18 <djazayeri> * Design call
14:33:18 <djazayeri> * Project Management call
14:33:19 <djazayeri> * Create UI Widget Library module so I can finish fixing the UI Framework docs
14:33:19 <djazayeri> * Start REPORT-330 (First pass at Data Export replacement)
14:33:40 <djazayeri> no blockers, but I expect I'll find it hard to test REPORT-330 if mseaton hasn't done the data definition ticket first
14:34:21 <dawn_> bwolfe: your turn
14:34:32 <bwolfe> today:
14:34:32 <bwolfe> triaged 10 tickets
14:34:32 <bwolfe> reviewed 2 of rafal's tickets
14:34:32 <bwolfe> atom feed module (discussion points to be had)
14:34:40 <bwolfe> psuedo blocker ^^
14:34:49 <bwolfe> *pseudo
14:35:07 <dawn_> mseaton: your turn
14:35:15 <mseaton> yesterday
14:35:15 <mseaton> * REPORT-335
14:35:15 <mseaton> * Reporting design / ticket review
14:35:15 <mseaton> * REPORT-346 started
14:35:15 <mseaton> today:
14:35:15 <mseaton> * REPORT-346 finish
14:35:16 <mseaton> * More design / ticket review
14:35:16 <mseaton> * Design call
14:35:17 <mseaton> * Project mgmt call
14:35:29 <mseaton> no blockers.
14:35:30 <djazayeri> !ticket report-335
14:35:31 <OpenMRSBot> djazayeri: [#REPORT-335] Update the "Run Report" page to include information about previous and current evaluations of the report - OpenMRS JIRA - https://tickets.openmrs.org/browse/report-335
14:35:36 <djazayeri> !ticket report-346
14:35:37 <OpenMRSBot> djazayeri: [#REPORT-346] Create UI management pages for adding / editing / deleting Data Definitions - OpenMRS JIRA - https://tickets.openmrs.org/browse/report-346
14:35:52 <djazayeri> I'm looking forward to that one. :-)
14:35:55 <mseaton> hmm, not 335
14:35:57 <mseaton> i meant
14:36:02 <mseaton> !ticket REPORT-345
14:36:03 <dawn_> !scrumoff dawn
14:36:03 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
14:36:04 <OpenMRSBot> mseaton: [#REPORT-345] Do not flatten dataset by default if added to a column of a RowPerObject dataset - OpenMRS JIRA - https://tickets.openmrs.org/browse/REPORT-345
14:36:26 <mseaton> djazayeri: first pass (very rough) done
14:36:46 <mseaton> djazayeri: able to talk about some of the finer points?
14:37:08 <djazayeri> sure
14:37:20 <djazayeri> bwolfe: you had a discussion point too. for here?
14:37:34 <bwolfe> yeah, just a general one
14:37:35 <dawn_> Discussion points: 1) TRUNK-3022 in 1.9, 2) Ben's discussion on atom feed module
14:37:43 <djazayeri> !ticket trunk-3022
14:37:45 <OpenMRSBot> djazayeri: [#TRUNK-3022] Unable to use the the new release testing feature to upgrade a 1.6.4 database - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-3022
14:38:07 <dawn_> that one is listed as a blocker on the 1.9 dashboard and is unassigned
14:38:18 <dawn_> that one = TRUNK-3022
14:38:50 <djazayeri> Daniel had it assigned to him until today, and unassigned himself
14:39:07 <bwolfe> djazayeri, all options I can find and think of for hooking into this atom feed revolve around AOP. but you had said off-the-cuff at one meeting that there might be a non-aop solution. did you have any weight behind that, or is that an empty guess?
14:39:09 <djazayeri> I guess rafal will pick that up, now that he's on bugfix duty this week
14:39:24 <bwolfe> (other option is for a hibernate interceptor, which is also sub-par)
14:39:25 <wyclif> mseaton, when do u have time to discuss the design of logging errors to database
14:39:42 <djazayeri> (no rafa on irc now though)
14:39:45 <dawn_> dkayiwa: can you let rafal know or assign him to the TRUNK-3022 ticket?
14:39:58 <mseaton> wyclif anytime
14:40:09 <dkayiwa> dawn_: yes i did let him know :)
14:40:19 <dawn_> dkayiwa: okay :)
14:40:50 <djazayeri> bwolfe: I don't know of a way other than AOP, unless we do a large-scale refactoring, which we should eventually do (but not now)
14:41:02 <wyclif> even now?
14:41:13 <mseaton> wyclif, sure
14:41:30 <djazayeri> bwolfe: I think what we should do is create an "eventqueue" module
14:41:46 <djazayeri> bwolfe: in the first pass, that module will generate events by using AOP
14:42:16 <djazayeri> bwolfe: but it will allow *listening* on events by some cleaner and more intuitive mechanism for "register a listener"
14:42:17 <bwolfe> yeah, thats what I was thinking. although I was going with "eventbus"
14:42:21 <djazayeri> bwolfe: sure
14:42:33 <wyclif> mseaton, skype or irc
14:42:44 <mseaton> wyclif, either way is fine
14:42:55 <wyclif> i prefer skype, i hate typing
14:42:59 <djazayeri> bwolfe: so for the moment we use AOP to determine which events to fire, but we expect to do it properly in core when we have time
14:43:01 <wyclif> let me get a room
14:43:21 <wyclif> mseaton, i prefer skype, let me get a room
14:43:24 <djazayeri> bwolfe: is that what you were thinking?
14:44:56 <bwolfe> djazayeri, yes, unfortunately.
14:45:10 <bwolfe> I was hoping you knew something I didn't :-)
14:45:12 <djazayeri> bwolfe: shouldn't be that painful, should it? :-)
14:45:30 <bwolfe> no, its easy. its just more AOP
14:45:52 <bwolfe> (I'd like to avoid adding more aop whenever possible...we already have 3 default advice classes on every service)
14:48:01 <djazayeri> bwolfe: I completely agree, which is why we need to replace it in core soon
14:48:42 *** bryq has quit IRC
14:49:07 <djazayeri> bwolfe: maybe follow mseaton's approach with the calculation module, and put it under the org.openmrs.event package (rather than under org.openmrs.module) assuming that this will move to core in 1.10/1.11
14:52:29 *** bryq has joined #openmrs
14:52:29 *** ChanServ sets mode: +v bryq
14:55:51 *** rafa has joined #openmrs
14:55:51 *** ChanServ sets mode: +v rafa
14:59:49 *** bryq has quit IRC
15:01:16 *** bryq has joined #openmrs
15:01:16 *** ChanServ sets mode: +v bryq
15:01:38 *** dawn_ has quit IRC
15:04:44 <wyclif> hi mseaton , pauls presentation is about to start, can we do this after the design call
15:04:56 <mseaton> wyclif, sure
15:06:57 *** downey has quit IRC
15:07:34 *** bryq has quit IRC
15:10:13 *** isharap has quit IRC
15:10:38 *** downey has joined #openmrs
15:10:38 *** ChanServ sets mode: +o downey
15:10:38 *** OpenMRSBot sets mode: +o downey
15:12:24 <djazayeri> mseaton: you had a ticket you wanted to discuss?
15:12:30 <djazayeri> (I may have a call in a sec)
15:12:48 <mseaton> djazayeri - i'm ok for now hacking. perhaps touch base on it later
15:12:52 <djazayeri> okay
15:15:31 *** mvorobey has joined #openmrs
15:15:36 <mvorobey> hi all
15:22:06 *** Akamau has quit IRC
15:24:44 *** wyclif has quit IRC
15:25:34 *** dawn_ has joined #openmrs
15:25:34 *** ChanServ sets mode: +v dawn_
15:34:40 *** lhawthor has joined #openmrs
15:34:45 <downey> Hi lhawthor and welcome to the #openmrs IRC channel.
15:35:38 *** lhawthor is now known as lh
15:35:55 *** lh has quit IRC
15:35:55 *** lh has joined #openmrs
15:42:10 <downey> :)
15:47:42 <mvorobey> mseaton, hi mike, have you a minute ?
15:48:05 <mseaton> mvorobey, yes
15:48:56 <mvorobey> mseaton, can you point me what can be wrong with reporting module if I got "Unable to load tag handler class "org.openmrs.module.reporting.web.taglib.DisplayLabelTag" for tag "rpt:displayLabel""
15:49:19 <mseaton> mvorobey: problem i believe is a bug in trunk. try 1.8.x
15:49:30 <mseaton> mvorobey: bwolfe knows details
15:50:12 <mvorobey> mseaton, bummer, I just moved to trunk from 1.6.x, and need to move down again :)
15:51:26 *** suranga has joined #openmrs
15:51:26 *** ChanServ sets mode: +v suranga
15:51:58 <mseaton> bwolfe - do you have a ticket number for that issue?
15:52:53 <mvorobey> mseaton, moving to 1.6.x back :)
15:55:11 *** Indie_ has joined #openmrs
15:55:21 <mseaton> mvorobey, should be fine
15:55:55 *** pushkar has joined #openmrs
15:55:57 <mvorobey> mseaton, it was fine but I mistakely ran 1.10.x instead of 1.6.x
15:56:02 <pushkar> downey: Hi
15:56:15 <mvorobey> mseaton, and got such error on trunk
15:56:56 <downey> pushkar: Hello
15:57:20 <pushkar> downey: can you please move ticket OTHER-18 to hr module
15:57:31 <downey> pushkar: sure
15:58:00 <downey> pushkar: done
15:58:37 *** Indie_ has quit IRC
15:58:58 <pushkar> downey:thank you
16:00:40 *** goutham has joined #openmrs
16:01:50 *** dkayiwa has quit IRC
16:04:08 *** r_friedman has joined #openmrs
16:04:38 <mvorobey> mseaton, can you answer one more question ?
16:05:37 *** dkayiwa has joined #openmrs
16:07:13 *** Mkop2 is now known as mkop
16:07:16 *** mkop is now known as Mkop
16:15:02 *** hemanth_92 has joined #openmrs
16:24:19 *** bryq has joined #openmrs
16:24:19 *** ChanServ sets mode: +v bryq
16:26:07 *** jmiranda has quit IRC
16:26:26 *** snoppy has quit IRC
16:30:24 <mseaton> mvorobey, what's up?
16:31:02 <mvorobey> mseaton, everything is ok, now
16:31:08 <mvorobey> mseaton, :)
16:31:44 *** downey has quit IRC
16:32:33 *** dawn_ has quit IRC
16:34:11 *** goutham has quit IRC
16:34:42 *** wyclif has joined #openmrs
16:38:58 <hemanth_92> hi
16:40:11 <hemanth_92> as of now, the rest calls support querying via name/uuid only right?
16:40:22 *** downey has joined #openmrs
16:40:22 *** ChanServ sets mode: +o downey
16:40:22 *** OpenMRSBot sets mode: +o downey
16:45:09 <bwolfe> hemanth_92, depends on the object
16:45:15 *** jmiranda has joined #openmrs
16:45:26 *** ChanServ sets mode: +o jmiranda
16:46:28 <hemanth_92> i mean, if i want to search for a patient via his father's name, or his location (say birth place), can i do that?
16:50:07 *** Mkop has quit IRC
16:50:38 *** dkayiwa has quit IRC
16:50:48 *** Mkop has joined #openmrs
16:50:48 *** ChanServ sets mode: +v Mkop
16:51:33 *** bwolfe has quit IRC
16:57:04 *** dkayiwa has joined #openmrs
16:59:28 <jmiranda> finbrein, you there?
17:00:13 <jmiranda> i just looked through the IRC logs from this morning and saw your questions
17:04:43 *** bwolfe has joined #openmrs
17:04:43 *** ChanServ sets mode: +o bwolfe
17:06:52 <finbrein> jmiranda: hi
17:07:06 *** MarkG has quit IRC
17:07:15 <jmiranda> finbrein, still having issues with BIRT?
17:07:33 <finbrein> No, i was able to figure it
17:08:21 <jmiranda> finbrein, path issue? permission issue?
17:09:05 <finbrein> yes it was - the path I specified for the BIRT Engine was completely wrong.
17:09:18 <jmiranda> that error is one of the most common issues people have encountered when starting with the birt module
17:09:32 <jmiranda> we're hoping to remove that issue totally with the new version of the module
17:09:55 <finbrein> ok
17:09:56 <jmiranda> by packaging the runtime with the module (or specifying it as a dependency)
17:10:56 *** mvorobey has quit IRC
17:11:16 *** pushkar has quit IRC
17:11:32 <finbrein> I have being working on the UI mockups (proposed), not ready yet. I'll send a notification as soon as it ready.
17:11:41 <jmiranda> the fact that you ran into that issue is apropos
17:11:47 <jmiranda> cool
17:11:57 *** shanakaf has joined #openmrs
17:12:04 <downey> Hi shanakaf and welcome to the #openmrs IRC channel.
17:13:18 *** mvorobey has joined #openmrs
17:13:57 *** r0bby has joined #openmrs
17:13:58 *** ChanServ sets mode: +v r0bby
17:16:57 *** robbyoconnor has quit IRC
17:19:54 *** suranga_ has joined #openmrs
17:20:55 *** shanakaf_ has joined #openmrs
17:20:59 *** suranga has quit IRC
17:21:00 <downey> Hi shanakaf_ and welcome to the #openmrs IRC channel.
17:25:44 <r_friedman> rafa: hey rafa, you really there?
17:44:01 *** MarkG has joined #openmrs
17:44:02 *** mvorobey has quit IRC
17:44:39 *** mvorobey has joined #openmrs
17:51:01 <mvorobey> mseaton, mike, do you have a minute ?
17:51:20 <mseaton> mvorobey, sure
17:55:50 *** Indie_ has joined #openmrs
17:56:08 <mvorobey> mseaton, Within mockup for REPORT-339 you have shown Schedule cron expression as human readable string, but we currently operating only with cron alike 0 0 12 ? * WED. So, do I need to add extra utility to convert cron to human readable string ?
17:57:06 <mseaton> mvorobey - that would be great if you could. perhaps check the quartz library to see if it exists?
17:58:48 <mvorobey> mseaton, ok, will trying to do something on it, thanks
17:59:12 *** dkayiwa has quit IRC
18:04:19 *** dkayiwa has joined #openmrs
18:04:25 *** rafa has quit IRC
18:05:24 *** Indie_ has quit IRC
18:05:36 <djazayeri> bwolfe: design call?
18:08:21 *** bwolfe has quit IRC
18:10:23 *** wyclif has quit IRC
18:12:13 *** dileepsisila has joined #openmrs
18:12:25 *** snoppy has joined #openmrs
18:13:02 *** sanchit has joined #openmrs
18:13:16 <downey> Hi sanchit and welcome to the #openmrs IRC channel.
18:13:22 <sanchit> hi
18:14:03 <dileepsisila> <dkayiwa> i like to contribute human resouce module gsoc task so can i get the mentor nick name
18:14:30 <dkayiwa> r_friedman: ?
18:16:35 <dileepsisila> <r_friedman> hi..........are you here now?
18:18:51 <dileepsisila> <dkayiwa> do you know about this project?
18:19:04 <dkayiwa> dileepsisila: not much
18:20:00 *** bwolfe has joined #openmrs
18:20:00 *** ChanServ sets mode: +o bwolfe
18:25:29 *** bwolfe has quit IRC
18:25:32 *** wyclif has joined #openmrs
18:26:59 <dileepsisila> <dkayiwa> human resource module task was done at the last year gsoc project. i think, in this year openmrs need to improve this module
18:28:05 <dkayiwa> ok
18:30:35 *** Indie_ has joined #openmrs
18:33:12 *** shanakaf_ has quit IRC
18:43:20 *** dawn_ has joined #openmrs
18:43:20 *** ChanServ sets mode: +v dawn_
18:45:21 <nribeka> dileepsisila, r_friedman is in a meeting right now
18:54:11 *** shanakaf has quit IRC
18:54:52 <mvorobey> mseaton, I checked quartz library for functionality that returns human readable cron, but there is no such functionality, also I found out some 3rd-party implementation of that feature, but it seems to work not very nice, for instance for expression like - 0 30 10-13 ? * WED,FRI it returns following :
18:55:41 <mvorobey> On the 0th second,
18:55:41 <mvorobey> On the 30th minute,
18:55:41 <mvorobey> For every hour from 10 through 13
18:55:41 <mvorobey> whatever day-of-the-month falls upon WED,FRI ,
18:55:41 <mvorobey> every month,
18:55:41 <mvorobey> and the following days of the week: WED, FRI.
18:56:59 <mvorobey> mseaton, does such cron description acceptable ?
18:57:01 <mseaton> mvorobey, for now just create a utility method that takes a cron expression and a Locale, and returns a user-friendly String.
18:57:45 <mvorobey> mseaton, sorry, what do you mean under User-Friendly String ?
18:57:52 <mvorobey> for example
18:57:53 <mseaton> mvorobey: you can just return the String as-is for now, potentially matching a few of the most common patters (the 95% case) - eg. the options that you allow the user to specify in the widget
18:58:34 <mvorobey> mseaton, i.e. 0 30 10-13 ? * WED,FRI ?
18:58:37 *** Indie_ has quit IRC
18:59:03 <mseaton> mvorobey: for something as complicated as "0 30 10-13 ? * WED,FRI", just return it as-is.
18:59:04 *** dawn_ has quit IRC
18:59:23 <mseaton> mvorobey: if there are simpler, very common variants, try to display that subset a bit more nicely
18:59:35 <mseaton> eg. Every Monday at 17:00
19:00:52 <mvorobey> mseaton, you know there are a lot of simpler variants :(
19:01:44 <mseaton> :) mvorobey: the formatting of this expression is not the primary purpose of the ticket. if you want, create a new ticket specifically to format a cron expression nicely, and we can handle it there.
19:02:12 <mvorobey> mseaton, it seems more reasonable to me
19:02:32 <mvorobey> mseaton, will create separate ticket
19:05:03 *** suranga_ has quit IRC
19:08:36 *** finbrein has quit IRC
19:17:01 *** maurya has joined #openmrs
19:17:14 *** finbrein has joined #openmrs
19:18:17 <maurya> downey: hi, can you please change the ticket other-20 to trunk
19:18:36 <downey> !ticket OTHER-20
19:18:37 <OpenMRSBot> downey: [#OTHER-20] Exception not caught in WebModuleUtil.java - OpenMRS JIRA - https://tickets.openmrs.org/browse/OTHER-20
19:19:09 <downey> !ticket TRUNK-3243
19:19:10 <OpenMRSBot> downey: [#TRUNK-3243] Exception not caught in WebModuleUtil.java - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3243
19:19:22 <downey> maurya: done
19:19:37 <maurya> downey: thank you:)
19:21:28 <mvorobey> mseaton, I just created new ticket for formatting crons - https://tickets.openmrs.org/browse/REPORT-353
19:31:37 *** mvorobey has quit IRC
19:34:57 *** james_regen has quit IRC
19:40:47 *** dkayiwa has quit IRC
19:41:32 *** dkayiwa has joined #openmrs
19:43:05 *** snoppy has quit IRC
19:45:09 *** sanchit has quit IRC
19:50:51 *** maurya has quit IRC
20:06:14 *** wyclif has quit IRC
20:10:40 *** r_friedman has quit IRC
20:20:54 *** MarkG has quit IRC
20:21:18 *** wyclif has joined #openmrs
20:21:20 *** MarkG has joined #openmrs
20:21:59 *** mseaton has quit IRC
20:25:29 *** MarkG has quit IRC
20:29:20 *** jmiranda has quit IRC
20:30:25 *** lh has quit IRC
20:31:18 *** snoppy has joined #openmrs
20:31:25 *** MarkG has joined #openmrs
20:32:31 *** dileepsisila has quit IRC
20:38:10 *** mseaton has joined #openmrs
20:38:11 *** ChanServ sets mode: +v mseaton
20:47:33 *** maurya has joined #openmrs
20:53:28 *** snoppy has left #openmrs
20:54:21 <maurya> MarkG: i've added a new patch for html-92 ,can you review it and see if the implementation is right?
20:56:02 *** pulasthi7 has quit IRC
20:57:38 *** nribeka has quit IRC
21:03:48 *** bryq has quit IRC
21:05:00 <MarkG> maurya: what happened to the unit tests? :)
21:05:42 <MarkG> maurya: can you create a new branch in your github repo called html-92 and put the unit tests and further commits there?
21:08:20 <maurya> MarkG: i'll complete the unit test part,i just wanted to know if the implementation was in the right direction..:)
21:09:29 <maurya> MarkG: yeah i'll create the branch.
21:11:22 <MarkG> maurya: it looks like your new patch only makes changes to the ObsTagHandler, correct?
21:11:36 <wyclif> hi mseaton,
21:11:40 <mseaton> hi wyclif
21:12:02 <wyclif> am working on REPORT-49 and i was just wondering because am new to this part of the code
21:12:07 <maurya> MarkG: yes
21:12:39 <wyclif> mseaton, reporting_definition_tag.defintion_uuid is a foreign key to serialized_object?
21:13:04 <mseaton> wyclif, no. not fk'd
21:13:05 <wyclif> mseaton, or there is no need to link the tables?
21:13:06 *** jmiranda has joined #openmrs
21:13:11 <MarkG> maurya: i think you were more on the right track before... when you were working on the ObsSubmissionElement... :) why did you switch?
21:14:09 <mseaton> wyclif, correct. no need to link the tables.
21:14:21 <mseaton> not all definitions will necessarily be in serialized_object
21:15:37 <wyclif> mseaton, ok
21:15:42 <wyclif> thanks
21:15:49 <maurya> MarkG: i explained the same in my mail..:), the html obs tag works in such a way that it can return only a single element is registered and only the single element is added in the actions which is responsible for adding the data in the database
21:16:05 <wyclif> but we want to have a composite key for definition_uuid and tag?
21:16:22 <wyclif> mseaton, but we want to have a composite unique key for definition_uuid and tag?
21:16:34 <mseaton> yes
21:16:43 <wyclif> mseaton, got you
21:17:47 <maurya> MarkG: so what i did earlier registered the whole multiplecheckbox widget got registered but the singular checkboxes in it were not added to the database as they are not registered specifically
21:19:35 <MarkG> maurya: so what is the new strategy you are going for?
21:19:54 <wyclif> mseaton, and i guess the method marked for removal have to be deprecated and not deleted?
21:20:14 <mseaton> wyclif, you can go ahead and delete.
21:20:18 <wyclif> mseaton, ok
21:22:19 <maurya> MarkG: so in this new implementation i'm taking taking the request for the new multiple checkbox and am registering them individually
21:23:22 <maurya> MarkG: there are some other ways, but that would be needing a lot of code refactoring
21:23:31 *** harshadura has quit IRC
21:24:23 <wyclif> mseaton, i thought for classes we have the property as a string for the class name and not Class object
21:24:32 *** Mkop has quit IRC
21:24:44 <mseaton> yeah. i think you're right - roger also advocated for that. can you do that instead?
21:24:51 <wyclif> mseaton, ok
21:27:09 <maurya> MarkG: so, i am a little confused to decide which way would be better. but if we are not to change much of the existing code,i suppose this would be the most feasible
21:28:51 <MarkG> maurya: your approach is interesting... I'
21:29:13 <MarkG> m not quite sure if it is the right approach, but it might be worth pursuing...
21:29:29 <MarkG> honestly, this ticket is going to take a little more thought...
21:30:03 <MarkG> maurya: did you confirm that your changes didn't break any existing unit tests?
21:30:44 <maurya> MarkG: i can explain everything in detail if i can have a skype call with you, i can even explain the other ways of implementing it
21:34:22 <maurya> MarkG: yeah , i only called the existing code multiple times,so i didn't get any failures with the existing tests
21:38:29 <MarkG> maurya: i'm kind of busy right now for a skype call... why don't you put a summary of your approaches in your proposal for the Google Summer of Code project, since the ticket is actually part of the project, so it will be good for your application...
21:41:48 <maurya> MarkG: ohkay fine..:) can i also include the existing implementation to make the difference more clear?
21:42:40 <MarkG> maurya: sure... you mean in your proposal show how it is currently implemented and how you would change it?
21:42:45 *** carloshpf has joined #openmrs
21:42:59 <maurya> MarkG: yes!
21:43:14 <MarkG> maurya: sounds fine to me
21:43:51 *** snoppy has joined #openmrs
21:44:00 *** snoppy has left #openmrs
21:44:03 <maurya> MarkG: thanks a lot::)
21:44:52 <MarkG> maurya: you're welcome!
21:46:54 *** hemanth_92 has quit IRC
21:49:13 *** maurya has quit IRC
21:59:47 *** dkayiwa has quit IRC
22:01:34 *** MarkG has quit IRC
22:02:11 *** MarkG has joined #openmrs
22:05:54 *** wyclif has quit IRC
22:06:30 *** MarkG has quit IRC
22:28:19 *** carloshpf has quit IRC
22:33:04 *** mseaton has left #openmrs
22:38:20 *** downey has quit IRC
23:41:13 *** jmiranda has quit IRC
23:54:35 *** downey has joined #openmrs
23:54:35 *** ChanServ sets mode: +o downey
23:54:35 *** OpenMRSBot sets mode: +o downey