| 00:06:51 | <robbyoconnor> hey mseaton! |
| 00:12:01 | <finbrein> I'll do the needful robbyoconnor, thanks for your feedback! |
| 00:12:36 | <mseaton> wyclif, robby hey |
| 00:12:52 | <finbrein> nice sharing the SMART principle with us - good stuff. |
| 00:13:09 | <robbyoconnor> finbrein: it's amazing |
| 00:13:53 | <finbrein> true! |
| 00:16:14 | <robbyoconnor> finbrein: just remember define measures of completion (usually a singular one, if using multiple ones see if you can break it up more) and deadlines |
| 00:16:29 | <robbyoconnor> your mentor ultimately is in charge however! |
| 00:16:31 | *** anu_GSOC has quit IRC |
| 00:19:25 | <wyclif> mseaton, a report in queue is one requested or scheduled, sorry for my dumb questions but the javadocs say nothing |
| 00:20:24 | *** anu_GSOC has joined #openmrs |
| 00:23:18 | <finbrein> I'll break the system down bit by bit as I gain more insight into how the pieces fit together into the whole - all comments would be fine with me. Please keep them coming. And thank you all for the feedbacks. |
| 00:25:28 | <mseaton> wyclif, good question. if you notice in the mockup on the ticket, there are 2 reports demonstrated in the mockup - one is actively being generated, and one is next in line to be generated. these represent ReportRequests with Status of REQUESTED, and PROCESSING respectively. |
| 00:25:54 | <mseaton> or, the other way around, but you see what i mean |
| 00:26:20 | <wyclif> ok |
| 00:26:23 | <mseaton> the SCHEDULED status means that the ReportRequest has been Scheduled with a Cron expression to be run later, either as a one off or regularly. |
| 00:26:31 | <wyclif> ok |
| 00:26:38 | <mseaton> so it should not be included in this view, as it is not in line to be Generated per se. |
| 00:27:12 | <mseaton> there is another ticket for viewing the list of Scheduled reports, which would pull the report requests with SCHEDULED status. |
| 00:30:36 | <wyclif> ok |
| 00:31:06 | <wyclif> mseaton, the other pages on the admin page seem to be broken for me, is the same for you |
| 00:31:39 | *** mseaton has quit IRC |
| 00:31:48 | *** mseaton has joined #openmrs |
| 00:31:48 | *** ChanServ sets mode: +v mseaton |
| 00:32:05 | <mseaton> wyclif, broken how? |
| 00:32:39 | <wyclif> mseaton, nothing gets displayed |
| 00:34:14 | <mseaton> wyclif, no i don't have that problem. |
| 00:34:27 | <mseaton> wyclif, can you disable your code autoformatter for this project? |
| 00:35:02 | <wyclif> mseaton, ok |
| 00:35:13 | <wyclif> mseaton, the error i get is org.apache.jasper.JasperException: /WEB-INF/view/module/reporting/reports/manageReportDesigns.jsp(67,22) PWC6032: Unable to load tag handler class "org.openmrs.module.reporting.web.taglib.DisplayLabelTag" for tag "rpt:displayLabel" |
| 00:35:16 | <mseaton> most of the code has not been run through the formatter before, and it will make it tough to review |
| 00:35:47 | <mseaton> wyclif: no idea what PWC6032 is. maybe a tomcat version issue? |
| 00:36:13 | *** anu_GSOC has quit IRC |
| 00:40:42 | *** anu_GSOC has joined #openmrs |
| 00:41:41 | *** dileepsisila has quit IRC |
| 00:46:43 | *** harshadura has joined #openmrs |
| 00:49:46 | *** sumitverma has joined #openmrs |
| 00:51:49 | *** anu_GSOC has quit IRC |
| 01:17:06 | *** sumitverma has quit IRC |
| 01:27:53 | <harshadura> hi mccallumg |
| 01:32:20 | <harshadura> hi bwolfe u thr |
| 01:36:21 | *** anu_GSOC has joined #openmrs |
| 01:36:37 | *** sgithens has joined #openmrs |
| 01:40:14 | *** harshadura has quit IRC |
| 01:40:56 | *** harshadura has joined #openmrs |
| 01:43:14 | *** harshadura has joined #openmrs |
| 01:44:52 | *** harshadura has joined #openmrs |
| 01:46:59 | <bwolfe> hi harshadura |
| 01:48:03 | <harshadura> hi bwolfe, please can you review my gsoc proposal at melange? |
| 01:53:41 | *** anu_GSOC has quit IRC |
| 02:04:56 | *** finbrein has quit IRC |
| 02:05:10 | *** finbrein has joined #openmrs |
| 02:09:58 | <harshadura> bwolfe u still thr |
| 02:28:10 | *** Rahul has joined #openmrs |
| 02:32:21 | <harshadura> hi robbyoconnor |
| 02:34:54 | <robbyoconnor> harshadura: i won't be making final decisions on your proposal -- so what bwolfe thinks is important...be patient! |
| 02:35:48 | <harshadura> no i want to ask a question regarding a ticket |
| 02:36:43 | <mccallumg> hi harshadura |
| 02:43:35 | <harshadura> robbyoconnor, i jz came to ask a question regarding a bug ticket, feeling guilty, sorry if i offended someone |
| 02:46:49 | <robbyoconnor> you didn't offend anybody! |
| 02:47:06 | <robbyoconnor> And I can't help with tickets...I haven't touched OpenMRS code in ...years |
| 02:47:49 | <harshadura> robbyoconnor, okay np |
| 02:56:15 | <mccallumg> harshadura: I saw you sent an email to the implementer's list about android project ideas. |
| 02:56:47 | <mccallumg> harshadura: someone who might be good to talk to is Daniel Pepper <daniel.pepper@gmail.com> |
| 02:57:08 | <mccallumg> If I'm not mistaken, he's in india |
| 02:59:22 | <mccallumg> harshadura: whoa. wait a second. raxa has their own gsoc project https://google-melange.appspot.com/gsoc/org/google/gsoc2012/raxa |
| 02:59:26 | <OpenMRSBot> <http://ln-s.net/9vk7> (at google-melange.appspot.com) |
| 02:59:53 | <harshadura> okay mccallumg, cool :) |
| 03:00:03 | <mccallumg> harshadura: very cool. Daniel Pepper and Saptarshi are probably leading this. |
| 03:01:09 | <harshadura> mccallumg, this is a different org nah? |
| 03:01:23 | <mccallumg> harshadura: https://raxaemr.atlassian.net/wiki/display/RAXAJSS/Google+Summer+of+Code+2012+at+the+Raxa+JSS+EMR |
| 03:01:29 | <OpenMRSBot> <http://ln-s.net/9vk9> (at raxaemr.atlassian.net) |
| 03:02:33 | <mccallumg> harshadura: yes. it is a different org - but based on openmrs. I didn't realize until this moment that they were doing their own gsoc. |
| 03:03:30 | <mccallumg> harshadura: they're good people. definitely worth considering their project listings. |
| 03:05:07 | <mccallumg> harshadura: their motech project looks interesting. |
| 03:07:19 | *** harshadura has quit IRC |
| 03:08:56 | *** harshadura has joined #openmrs |
| 03:08:58 | *** upul` has joined #openmrs |
| 03:08:58 | *** ChanServ sets mode: +v upul` |
| 03:12:00 | <harshadura> mccallumg, can I ask a question related to a bug ticket? |
| 03:12:45 | <mccallumg> harshadura: you can. I don't know openmrs as well as the full-time employees. |
| 03:15:00 | <harshadura> okay mccallumg, np |
| 03:15:11 | <mccallumg> harshadura: what's your question? |
| 03:16:52 | <harshadura> I am working on this bug ticket now > https://tickets.openmrs.org/browse/TRUNK-2498, Ben told me to write a unit test case, can u giv me a brief guide hw to test that one? |
| 03:20:27 | <mccallumg> so you need to be sure that it won't accept an invalid email address after you made the fix, right? |
| 03:21:27 | <harshadura> yeah mccallumg |
| 03:23:42 | <mccallumg> harshadura: and the patch only affects the form controller source file? |
| 03:24:22 | <harshadura> only another one, its message.properties file |
| 03:31:54 | <mccallumg> harshadura: have you looked at this form controller test? https://source.openmrs.org/browse/OpenMRS/trunk/web/src/test/java/org/openmrs/scheduler/web/controller/SchedulerFormControllerTest.java?r=23726 |
| 03:36:26 | <harshadura> okay mccallumg, thanks |
| 03:40:23 | <mccallumg> harshadura: so maybe onSubmit_shouldNotAcceptInvalidEmailAddress test method? |
| 03:59:11 | <bwolfe> harshadura, I'll take a look at your app soon |
| 03:59:24 | <bwolfe> !refer harshadura [unittesting] |
| 03:59:25 | <OpenMRSBot> bwolfe: Error: "unittesting" is not a valid command. |
| 03:59:30 | <bwolfe> !refer harshadura [unittests] |
| 03:59:31 | <OpenMRSBot> bwolfe: Error: "unittests" is not a valid command. |
| 03:59:32 | <bwolfe> grr |
| 03:59:45 | <bwolfe> https://wiki.openmrs.org/display/docs/Unit+Tests |
| 03:59:56 | <bwolfe> and https://wiki.openmrs.org/display/docs/Unit+Testing+With+at-should+Annotation |
| 04:00:09 | <bwolfe> ok, gotta head to bed. night y'all |
| 04:00:52 | <harshadura> okay, gn bwolfe :) |
| 04:04:34 | *** bwolfe has quit IRC |
| 04:20:19 | <harshadura> mccallumg u thr |
| 04:20:33 | <mccallumg> hi harshadura |
| 04:21:35 | <harshadura> sorry for bothering, I am confused hw to check the validation inside the controller class using the outside test case |
| 04:23:34 | <harshadura> System.out.println(modelAndView.getModel().get("notificationAddress")); |
| 04:23:45 | <harshadura> this gives me null value :/ |
| 04:27:13 | <mccallumg> harshadura: Is this after the onSubmit method has been called? |
| 04:28:05 | <harshadura> yes |
| 04:28:40 | *** mseaton has quit IRC |
| 04:28:58 | <harshadura> mccallumg, is thr any way to find out that error notification has popped out in the view? |
| 04:34:38 | *** deadpool has quit IRC |
| 04:38:18 | <mccallumg> harshadura: bottom of this post |
| 04:38:19 | <mccallumg> http://www.scarba05.co.uk/blog/2010/03/integration-testing-of-springs-mvc-annotation-mapppings-for-controllers/ |
| 04:38:23 | <OpenMRSBot> <http://ln-s.net/9vlY> (at www.scarba05.co.uk) |
| 04:38:40 | *** Rahul_ has joined #openmrs |
| 04:38:43 | <mccallumg> harshadura: get the binding result |
| 04:38:55 | <mccallumg> harshadura: then check the errors |
| 04:39:33 | <harshadura> thanks lot mccallumg, this seems really helpful |
| 04:39:47 | *** Rahul_ has quit IRC |
| 04:41:40 | *** bryq has joined #openmrs |
| 04:41:40 | *** ChanServ sets mode: +v bryq |
| 04:42:53 | <mccallumg> ok. me going to bed. night all. |
| 04:43:00 | *** mccallumg has left #openmrs |
| 04:43:57 | <harshadura> okay mccallumg, gn |
| 04:47:50 | *** deadpool has joined #openmrs |
| 04:47:56 | *** bryq has quit IRC |
| 06:02:44 | *** dkayiwa has joined #openmrs |
| 06:30:33 | *** ullmann_ has quit IRC |
| 06:52:09 | <harshadura> hi dkayiwa : u thr |
| 06:52:33 | <dkayiwa> hi harshadura \ |
| 06:54:31 | *** noni has joined #openmrs |
| 06:55:25 | <harshadura> dkayiwa, I need to track errors of the OptionFormController test case. so i knew we can use something called below line to track whether an error occurred. but I have no idea what to replace to "location" in that. can u tell me wat to replace there |
| 06:55:25 | <harshadura> BeanPropertyBindingResult bindingResult = (BeanPropertyBindingResult) modelAndView.getModel().get( |
| 06:55:25 | <harshadura> "org.springframework.validation.BindingResult.optionsForm"); |
| 06:55:25 | <harshadura> |
| 06:55:46 | <harshadura> sorry location = optionsForm |
| 06:56:32 | <dkayiwa> harshadura: can you pastebin what you have |
| 06:56:38 | <harshadura> ok |
| 06:56:41 | <harshadura> sorry |
| 06:58:02 | <harshadura> dkayiwa : http://paste.ubuntu.com/912596/ |
| 06:58:36 | * noni need help with a module, reinstallation says its already there yet I uninstalled it |
| 06:58:55 | <harshadura> jz i need to knw is what to replace for "optionForm" |
| 06:59:03 | <dkayiwa> noni: try restart the server |
| 06:59:08 | <harshadura> in "org.springframework.validation.BindingResult.optionsForm" |
| 07:07:06 | <dkayiwa> harshadura: i need to look at the entire unit test |
| 07:07:30 | * noni dkayiwa: I have restarted both the server and the computer but the same error repeats |
| 07:07:45 | <dkayiwa> noni: which module is that? |
| 07:08:09 | <noni> dkayiwa: its a new module I have created |
| 07:09:13 | <noni> I cloned it from patient data transfer module and stripped everything else apart from the clinic table |
| 07:09:55 | <dkayiwa> can you send me the omod file? |
| 07:10:27 | <noni> where do I send it to? |
| 07:10:47 | <dkayiwa> dkayiwa at openmrs dot org |
| 07:12:00 | <noni> In a moment. Thanks |
| 07:13:42 | *** deadpool has quit IRC |
| 07:14:46 | *** bryq has joined #openmrs |
| 07:14:46 | *** ChanServ sets mode: +v bryq |
| 07:17:55 | *** jmiranda has quit IRC |
| 07:20:27 | <noni> dkayiwa: I have sent you the omod file |
| 07:21:52 | <dkayiwa> noni: which version of openmrs are you using? |
| 07:24:27 | <noni> dkayiwa: 1.8.0 |
| 07:25:41 | <dkayiwa> noni: can you try the latest release in the 1.8 series |
| 07:26:43 | <noni> dkayiwa: You mean, I replace the .war file? |
| 07:27:11 | *** deadpool has joined #openmrs |
| 07:27:11 | <dkayiwa> noni: upgrade your openmrs version |
| 07:27:22 | <noni> Ok. Let me do that. |
| 07:28:51 | <harshadura> dkayiwa : pls can u check it> http://paste.ubuntu.com/912625/ |
| 07:29:25 | *** bryq has quit IRC |
| 07:32:23 | *** BigC_ has joined #openmrs |
| 07:32:34 | *** BigC_ has left #openmrs |
| 07:33:03 | *** applecool has joined #openmrs |
| 07:33:10 | <applecool> dkayiwa: Hi |
| 07:33:46 | <applecool> I just uploaded the mockups for the Filtering Forms on Dashboard! Could you please check them? |
| 07:33:52 | <applecool> dkayiwa: |
| 07:34:18 | <dkayiwa> applecool: thanks i sent a question for you |
| 07:34:28 | *** jmiranda has joined #openmrs |
| 07:35:53 | <applecool> As i am an intern,it is difficult for me to provide you the svn credentials of the repository but i can tell you the architecture ! |
| 07:36:04 | <applecool> explain the architecture! * |
| 07:36:16 | <applecool> And the local code is available on my system |
| 07:36:30 | <dkayiwa> applecool: do you have anything else that you have control over and it is in java? |
| 07:38:04 | <applecool> the patientatcenter project which is under development, i have that code . so i could show you that! |
| 07:38:24 | <applecool> And the k-9mail enhancement too |
| 07:38:37 | <dkayiwa> applecool: is it in svn? |
| 07:38:50 | <applecool> which one? |
| 07:39:02 | <dkayiwa> applecool: the one which you can show me |
| 07:39:11 | <applecool> the patientatcenter is not on svn |
| 07:39:36 | <applecool> but the k-9 enhancement is on github |
| 07:39:54 | <dkayiwa> applecool: can you give me the url? |
| 07:40:34 | <applecool> https://github.com/k9mail/k-9/commit/5819d273946bbb9dd3e15af9025d8cd2c51eea0d |
| 07:40:41 | <OpenMRSBot> <http://ln-s.net/9vnm> (at github.com) |
| 07:41:54 | <dkayiwa> applecool: which userid did you use for the github project? |
| 07:42:05 | <applecool> i am with the name ShellZero on k-9 |
| 07:42:23 | <applecool> i mentioned it on my proposal too |
| 07:42:37 | <dkayiwa> applecool: ok :) |
| 07:42:58 | <applecool> Do you want to see the IVR example too |
| 07:43:15 | <dkayiwa> applecool: is it in java? |
| 07:43:20 | <applecool> i have the Source code with me (though it a cheating) ;) |
| 07:43:30 | <applecool> yes! |
| 07:43:31 | <applecool> :) |
| 07:43:33 | <applecool> JSP |
| 07:43:38 | <dkayiwa> applecool: what do you mean by it is cheating? |
| 07:44:18 | <applecool> i am not supposed to show the sourcecode as i am an intern and i have signed the NDA with the company |
| 07:44:22 | <applecool> ;) |
| 07:44:32 | <dkayiwa> applecool: in that case then do not |
| 07:44:56 | <dkayiwa> applecool: we only look at that which is allowed for public consumption :) |
| 07:45:00 | <applecool> ok!Thanks but i can explain you the entire code which i have done! |
| 07:45:35 | <dkayiwa> applecool: for now, can you update your proposal with as many urls as you can that link to code i can look at? |
| 07:45:43 | <applecool> i can give you the reference of my tech lead so that you can ask about my performance |
| 07:45:56 | <dkayiwa> applecool: hahahahahaha :D |
| 07:46:01 | <applecool> Ok! :) |
| 07:46:16 | *** noni has quit IRC |
| 07:46:16 | <dkayiwa> applecool: the urls to the public code will be enough :) |
| 07:46:28 | <applecool> why hahahhaha i am serious about the reference part! :) |
| 07:46:47 | <dkayiwa> applecool: :) |
| 07:47:05 | <applecool> ok i will update the urls :) |
| 07:47:17 | <applecool> any more feedback to make my proposal look better |
| 07:47:35 | <applecool> do you think i stand any chances! |
| 07:47:35 | <applecool> ? |
| 07:47:59 | <applecool> you are free to ignore the above question ;) |
| 07:48:45 | <dkayiwa> applecool: lets see how it goes :) |
| 07:49:15 | <applecool> \me i m nervous |
| 07:49:27 | *** jmiranda has quit IRC |
| 07:49:30 | * applecool i m nervous |
| 07:50:14 | <applecool> Any more suggestions ? dkayiwa |
| 07:50:53 | <dkayiwa> applecool: those are the ones i have for now. in the meantime, what i would suggest is for you to do as many tickets as you have the time for :) |
| 07:51:28 | <applecool> ok i would do it :) thanks ! :) |
| 07:51:37 | <applecool> And i have one more query |
| 07:52:04 | <applecool> what about the update form schema module? Do you want me to add the mockups for that too? |
| 07:52:04 | *** snoppy has joined #openmrs |
| 07:52:24 | <applecool> i dint get any comments or feedback on that proposal ! |
| 07:52:33 | <dkayiwa> applecool: yes please do |
| 07:53:41 | <dkayiwa> applecool: when did you last commit to the k9mail project? |
| 07:54:02 | *** jmiranda has joined #openmrs |
| 07:55:26 | <applecool> the developer of k-9mail cketti has himself commited that code yesterday morning :) |
| 07:55:57 | <applecool> and sent me a mail at 2:56 IST |
| 07:56:00 | <applecool> :) |
| 07:56:19 | <applecool> i meant cketti who was the developer sent me a mail! :) |
| 07:57:17 | <dkayiwa> applecool: does that mean you never committed your code (meaning it was all along seated at you computer? :) |
| 08:00:03 | <applecool> yes! actually he asked us to give the patch and he commited it and included our name in this URL https://github.com/k9mail/k-9/commit/5819d273946bbb9dd3e15af9025d8cd2c51eea0d |
| 08:00:03 | <OpenMRSBot> <http://ln-s.net/9vnm> (at github.com) |
| 08:01:41 | <dkayiwa> applecool: who did you work with on that patch? |
| 08:02:22 | <applecool> means? |
| 08:02:42 | <dkayiwa> am refering to the "us" |
| 08:02:54 | <dkayiwa> "he asked US" |
| 08:03:15 | <applecool> ok! my friend who is also a developer! |
| 08:03:21 | <applecool> kernelhunter92 |
| 08:04:01 | <dkayiwa> applecool: ok, you can update the proposal with as many urls as you can, and do as many tickets as you have the time for :) |
| 08:04:25 | <applecool> his name is hemanth |
| 08:04:26 | <applecool> :) |
| 08:04:49 | <applecool> Thanks ! :) |
| 08:04:53 | <applecool> i will do it :) |
| 08:07:45 | <dkayiwa> harshadura: do you have a patch for what you currently have? |
| 08:08:00 | <applecool> dkayiwa: when you are free,please look at the Ui mockups and please do provide your feedback on them so that i could even work on them if i made some errors! :) |
| 08:09:32 | <harshadura> hi dkayiwa, yeah hw can i send you? |
| 08:09:36 | <dkayiwa> applecool: no problem. do not worry so much about the mockups for now. The most critical aspect that you should for now concentrate on is prove your practical skills. So doing more tickets is of more higher priority than the mockups for now :) |
| 08:09:40 | <dkayiwa> harshadura: yes |
| 08:10:19 | <applecool> dkayiwa: Ok sure! :) i will :) Thanks a lot dkayiwa |
| 08:10:31 | <dkayiwa> applecool: any gsoc applicant can do mockups, but not many can do tickets :) |
| 08:10:44 | <harshadura> dkayiwa, do I hv to attach it to ticket? |
| 08:11:01 | <dkayiwa> harshadura: not for now. just pastebin it and sent me the url |
| 08:11:32 | <applecool> dkayiwa: So i will definitely work on tickets ! :) :) |
| 08:12:11 | <dkayiwa> applecool: yes they are the best way we can know about one's skill in relation to openmrs :) |
| 08:12:15 | <harshadura> okay dkayiwa |
| 08:14:19 | <applecool> :) |
| 08:14:52 | <dkayiwa> applecool: ofcourse there are also some other aspects we look into like, likelihood for one to stay around the community even after the end of gsoc, etc :) |
| 08:16:18 | <applecool> I would love to :) |
| 08:16:40 | <applecool> Do you think i should mention this in my proposal? dkayiwa |
| 08:17:09 | <dkayiwa> applecool: every one says that. So it is not about saying it. :) |
| 08:17:32 | <harshadura> dkayiwa : here it is. can you review it. > http://paste.ubuntu.com/912666/ |
| 08:18:00 | <applecool> hmm! but i will be there definitely :) |
| 08:18:04 | <applecool> :) |
| 08:18:16 | <dkayiwa> applecool: that does not count :) |
| 08:18:28 | <applecool> haha! Ok :) |
| 08:18:34 | <dkayiwa> applecool: we just it not basing on what one says :) |
| 08:18:48 | <applecool> hmm :) |
| 08:19:10 | <dkayiwa> applecool: many have said so and then run away after being paid :) |
| 08:19:36 | <applecool> haha!! :P |
| 08:20:13 | <dkayiwa> applecool: but some few have stayed and even became mentors :) |
| 08:21:06 | <applecool> ok :) |
| 08:21:30 | <dkayiwa> harshadura: can you use pastebin.com? |
| 08:21:44 | <applecool> actually i am not running after money! :D |
| 08:22:01 | <applecool> and if i stay can i be a mentor next year? |
| 08:22:09 | <dkayiwa> applecool: that only God knows :) |
| 08:22:27 | <applecool> haha! :D |
| 08:22:57 | <harshadura> dkayiwa : http://pastebin.com/2w6GnQuh |
| 08:23:31 | <applecool> ok dkayiwa i am very very hungry as it is afternoon here! need to have some lunch! and i need to start solving tickets immediately |
| 08:23:41 | <applecool> :) |
| 08:24:11 | <dkayiwa> applecool: go and eat as much as you can :) |
| 08:24:31 | <applecool> Bye dkayiwa ! i will get back to you soon :) |
| 08:24:40 | <dkayiwa> 8) |
| 08:24:41 | <applecool> Bubhye ! :) have a nice day! :) |
| 08:24:50 | <dkayiwa> same to you |
| 08:25:35 | <applecool> thanks :) |
| 08:25:37 | *** applecool has left #openmrs |
| 08:25:46 | *** maurya has joined #openmrs |
| 08:26:11 | <maurya> hi i am running through an error while installing openmrs 1.8.3 |
| 08:26:36 | <maurya> the text is getting displayed on the browser than the UI |
| 08:29:40 | <dkayiwa> harshadura: your changes are making other existing unit tests fail |
| 08:30:08 | <dkayiwa> harshadura: can you ensure that existing unit tests do not fail after your changes? |
| 08:30:22 | <dkayiwa> harshadura: before you even start adding your tests |
| 08:31:42 | <harshadura> dkayiwa : are those test cases written by me working in your machine? |
| 08:32:14 | <harshadura> im confused how it could be happen, I didn changed anything in other test cases |
| 08:32:35 | <dkayiwa> harshadura: you made changes in the OptionsFormController which makes existing tests in OptionsFormControllerTest fail |
| 08:33:08 | <dkayiwa> harshadura: in otherwards, can you remove your tests from OptionsFormControllerTest and then run this class. you will see that the tests in it fail |
| 08:33:31 | <dkayiwa> harshadura: but if i revert your changes in OptionsFormController, the tests pass |
| 08:34:44 | <harshadura> dkayiwa, okay I'll check some more. thanks |
| 08:42:44 | *** harshadura has quit IRC |
| 08:51:53 | *** harshadura has joined #openmrs |
| 08:57:49 | <harshadura> dkayiwa, thanks for the hint, now I fixed that problem, the previous test cases are working now, but the new ones are still caused to fail |
| 08:58:14 | <dkayiwa> harshadura: send another patch |
| 08:58:17 | <harshadura> can i giv u the new patch. |
| 08:58:21 | <harshadura> okay dkayiwa |
| 09:00:01 | *** maurya has quit IRC |
| 09:03:03 | <harshadura> dkayiwa, http://pastebin.com/DF6U6aFk |
| 09:06:50 | *** rafa has joined #openmrs |
| 09:06:50 | *** ChanServ sets mode: +v rafa |
| 09:07:47 | <dkayiwa> harshadura: how many new test methods have you added? |
| 09:07:53 | <dkayiwa> hi rafa |
| 09:07:57 | <rafa> hi dkayiwa |
| 09:08:19 | <harshadura> dkayiwa, I added 3 new test cases |
| 09:09:10 | <dkayiwa> rafa: well come back |
| 09:09:11 | <dkayiwa> :) |
| 09:09:19 | <rafa> dkayiwa: thanks! |
| 09:09:37 | <dkayiwa> rafa: am very much interested in knowing what you did to fix the communication link failure for the standalone :) |
| 09:10:25 | <rafa> dkayiwa: I did nothing... |
| 09:10:41 | <rafa> dkayiwa: It worked for me on Windows ever since |
| 09:10:45 | <dkayiwa> rafa: hahahaha. it just started working all the sudden ? |
| 09:10:55 | <rafa> dkayiwa: I haven't tried on Linux after my changes yet.... |
| 09:11:15 | <dkayiwa> rafa: looks like wyclif did :) |
| 09:11:22 | <dkayiwa> rafa: and works on mac os too :) |
| 09:11:32 | <rafa> dkayiwa: that's good |
| 09:12:27 | <dkayiwa> rafa: looks like you can be in a better position than me in handling the release testing helper module ticket for big databases :) |
| 09:12:38 | <dkayiwa> harshadura: i get a NPE with your test |
| 09:13:34 | <rafa> dkayiwa: heh I could try. Which ticket is that? |
| 09:16:13 | <harshadura> yeah dkayiwa me too getting NPE, pls can u giv me a hint whats wrong with that code? |
| 09:16:40 | <dkayiwa> rafa: TRUNK-3234 |
| 09:16:43 | <dkayiwa> !ticket TRUNK-3234 |
| 09:16:44 | <OpenMRSBot> dkayiwa: [#TRUNK-3234] Failed to run sql dump file with testing installation method - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3234 |
| 09:17:36 | <rafa> dkayiwa: okay, I'll look into that. |
| 09:17:43 | <dkayiwa> rafa: thanks |
| 09:32:32 | <harshadura> dkayiwa, can u pls tell me is this line correct? |
| 09:32:40 | <harshadura> BeanPropertyBindingResult bindingResult = (BeanPropertyBindingResult) modelAndView.getModel().get( |
| 09:32:41 | <harshadura> "org.springframework.validation.BindingResult.location"); |
| 09:38:38 | <dkayiwa> harshadura: change location to: opts |
| 09:39:54 | *** dileepsisila has joined #openmrs |
| 09:40:51 | <dileepsisila> <dkayiwa> |
| 09:40:56 | <dileepsisila> <dkayiwa> ya sure |
| 09:42:11 | <dileepsisila> <dkayiwa> i am a new guy to the open mrs. i like to contribute open mrs gsoc projects. so i downloaded source code and built it using maven building tool |
| 09:43:12 | <dileepsisila> <dkayiwa> it was built successfully and then i considered the installation part |
| 09:43:46 | <dileepsisila> <dkayiwa> i choosed simple installation type |
| 09:44:33 | <dileepsisila> <dkayiwa> then at the database creating part, i encountered errors |
| 09:44:36 | <dileepsisila> first one is |
| 09:45:16 | <harshadura> dkayiwa, thanks lot, now its working properly, finally can you tell me how you found that its "opts" instead of "location" whr shud I search it? |
| 09:45:19 | <dileepsisila> There was an error while updating the database to the latest. file: liquibase-core-data.xml. Error: Migration failed for change set liquibase-core-data.xml::1226412230538-33::ben (generated): Reason: liquibase.exception.DatabaseException: Error executing SQL INSERT INTO `order_type` (`creator`, `date_created`, `description`, `name`, `order_type_id`, `retired`, `uuid`) VALUES (1, '2008-08-15', 'Order of medications for the patien |
| 09:45:43 | <dkayiwa> harshadura: in the openmts-servlet.xml |
| 09:46:05 | <dkayiwa> harshadura: you will see the controller which is configured with commandName = opts |
| 09:46:22 | <dileepsisila> <dkayiwa> So i went to liquibase-core-data.xml file and then i was able to find the error. in this file, |
| 09:46:46 | <harshadura> thanks lot dkayiwa, this is really helpful |
| 09:47:02 | <dkayiwa> dileepsisila: can you pastebin the entire log? |
| 09:47:58 | <dileepsisila> <dkayiwa> so there was two duplicate entry in the primary key. |
| 09:48:54 | <dileepsisila> <dkayiwa> There was an error while updating the database to the latest. file: liquibase-core-data.xml. Error: Migration failed for change set liquibase-core-data.xml::1226412230538-33::ben (generated): Reason: liquibase.exception.DatabaseException: Error executing SQL INSERT INTO `order_type` (`creator`, `date_created`, `description`, `name`, `order_type_id`, `retired`, `uuid`) VALUES (1, '2008-08-15', 'Order of medications for |
| 09:49:22 | <dkayiwa> dileepsisila: can you pastebin the contents of the entire tomcat log? |
| 09:50:06 | <dileepsisila> now i haven't it |
| 09:50:46 | <dileepsisila> <dkayiwa> i was able to fix this error changing liquibase-core-data.xml file |
| 09:51:30 | <dileepsisila> <dkayiwa> there are duplicate entry in order_type_id primary key |
| 09:53:30 | <dileepsisila> <dkayiwa> after fixing this error i encountered another error. |
| 09:54:07 | <dileepsisila> <dkayiwa> i have it's tomcat log. Caused by: liquibase.exception.DatabaseException: Error executing SQL CREATE UNIQUE INDEX `order_type_uuid_index` ON `order_type`(`uuid`): Duplicate entry '131168f4-15f5-102d-96e4-000c29c2a5d7' for key 'order_type_uuid_index' |
| 09:54:53 | <dileepsisila> <dkayiwa>at liquibase-core-data.xml file, i bolded error occuring line. if uuid is unique index, we canât give same value for two rows. this is the reason for error . |
| 09:55:50 | <dileepsisila> <dkayiwa> same values of 131168f4-15f5-102d-96e4-000c29c2a5d7 here |
| 09:56:02 | <dileepsisila> i changed and i was able to fix it |
| 09:56:03 | <dkayiwa> dileepsisila: do you know pastebin.com? |
| 09:56:20 | <dileepsisila> <dkayiwa> no |
| 09:56:59 | <dkayiwa> dileepsisila: go to that url and paste |
| 09:57:56 | <dileepsisila> <dkayiwa>ok..... |
| 09:58:44 | <dileepsisila> <dkayiwa> do you want to entire tomcat log |
| 09:59:14 | <dkayiwa> dileepsisila: yes |
| 10:00:00 | <dileepsisila> <dkayiwa> i wrote it like a report. can i paste it in pastebin.com |
| 10:00:24 | <dkayiwa> dileepsisila: no. just copy from the log file and paste |
| 10:00:38 | <dileepsisila> ok... |
| 10:00:46 | <dileepsisila> wait |
| 10:05:01 | *** dileepsisila has quit IRC |
| 10:15:23 | <dkayiwa> good |
| 10:21:08 | <harshadura> dkayiwa, in the last test case Its an "all valued Accepted scenario-successful". when I check if thrs any error on it. it shud return false no. but it gives null pointer exception. what you think abt that? |
| 10:22:01 | <dkayiwa> harshadura: which method is that |
| 10:22:11 | <harshadura> sorry, i mean this one this one > shouldAcceptValidNotificationAddress |
| 10:24:53 | <dkayiwa> harshadura: on which line is the NPE? |
| 10:25:29 | <harshadura> dkayiwa, org.junit.Assert.assertFalse(bindingResult.hasErrors()); |
| 10:25:39 | <harshadura> this line dkayiwa |
| 10:26:13 | <harshadura> all others ran well. |
| 10:29:10 | <dkayiwa> harshadura: line number |
| 10:29:29 | *** deadpool has quit IRC |
| 10:29:46 | <harshadura> dkayiwa i changed the code lil bit, the line numbers may differ, sorry, almost last line |
| 10:29:51 | <harshadura> before curly braces |
| 10:34:54 | <dkayiwa> harshadura: give me the line number and and current changes you have on pastebin |
| 10:35:11 | <harshadura> okay dkayiwa |
| 10:36:35 | <harshadura> dkayiwa, http://pastebin.com/yYu6VE4t |
| 10:41:18 | *** deadpool has joined #openmrs |
| 10:45:09 | *** dileepsisila has joined #openmrs |
| 10:45:49 | <harshadura> dkayiwa u thr |
| 10:46:08 | <dkayiwa> harshadura: yes waiting for the line number |
| 10:46:32 | <harshadura> dkayiwa, I send u the patch |
| 10:46:40 | <harshadura> dkayiwa, http://pastebin.com/yYu6VE4t |
| 10:47:04 | <harshadura> line 148 |
| 10:48:11 | <dkayiwa> harshadura: is that the line number according to pastebin? |
| 10:48:40 | <harshadura> sorry |
| 10:49:28 | <harshadura> dkayiwa 215 |
| 10:52:18 | *** snoppy has quit IRC |
| 10:52:34 | <dkayiwa> harshadura: which variable is null on that line |
| 10:52:53 | <harshadura> dkayiwa, bindingResult.hasErrors() |
| 10:53:37 | <dkayiwa> harshadura: that is not a variable |
| 10:54:34 | <harshadura> dkayiwa, pls can u refer the error log > http://pastebin.com/TeSBYDS2 |
| 10:55:43 | *** maurya has joined #openmrs |
| 10:55:52 | <maurya> hi djazayeri1 |
| 10:56:05 | <maurya> have some queries |
| 10:56:09 | <maurya> u there djazayeri1 |
| 10:57:02 | <maurya> hi dkayiwa |
| 10:57:48 | <harshadura> dkayiwa, I think when the response has no errors, it sets the "bindingResult.hasErrors() == null" |
| 10:57:55 | *** upul` has quit IRC |
| 10:57:57 | <harshadura> is it? |
| 10:58:56 | <maurya> dkayiwa: |
| 10:59:26 | *** hemanth_92 has joined #openmrs |
| 11:00:15 | <dkayiwa> harshadura: check to be sure which variable is null |
| 11:00:18 | <dkayiwa> hi maurya |
| 11:00:59 | <maurya> i was working with the html form enhancement |
| 11:01:14 | <maurya> and submitted a patch for multiple check box |
| 11:01:29 | <maurya> but i dont think i have implemented it correctly |
| 11:01:48 | <maurya> i have varioud implementations and wanted to discuss with you |
| 11:01:57 | <maurya> if i ma going on a correct track |
| 11:02:13 | <maurya> can we have a quick skype call , so i can shouw you the code too |
| 11:02:34 | <maurya> my skype id srimaurya |
| 11:03:19 | <maurya> dkayiwa: |
| 11:04:25 | <dileepsisila> <dkayiwa> srry for delay |
| 11:04:46 | <dileepsisila> <dkayiwa> in that time i was in the university |
| 11:05:00 | <dileepsisila> <dkayiwa> so my tomcat log |
| 11:05:10 | <dileepsisila> <dkayiwa> http://pastebin.com/cxcDsTCz |
| 11:05:28 | <maurya> dkayiwa: can i have your skype id |
| 11:05:37 | *** robbyoconnor has quit IRC |
| 11:05:57 | *** hemanth_92 has quit IRC |
| 11:07:20 | <dileepsisila> dkayiwa, i my log here http://pastebin.com/cxcDsTCz |
| 11:07:25 | <dkayiwa> maurya: who is your mentor? |
| 11:08:30 | <dkayiwa> dileepsisila: you said you had fixed it |
| 11:09:00 | <dileepsisila> dkayiwa, yes i was able to fix it |
| 11:11:47 | <maurya> dkayiwa: Mark Goodrich, but can you spare some time,i've got some options and i'm unable to decide which one would be better |
| 11:12:05 | *** harshadura has quit IRC |
| 11:12:30 | *** dileepsisila_ has joined #openmrs |
| 11:12:38 | <dkayiwa> maurya: it is more appropriate to discuss with your mentor first :) |
| 11:13:21 | *** dileepsisila has quit IRC |
| 11:13:24 | <dileepsisila_> dkayiwa, srry my network connection was breadk down |
| 11:13:44 | <dileepsisila_> dkayiwa, nw it is ok |
| 11:14:47 | <maurya> okay :) |
| 11:14:59 | <dkayiwa> maurya: :D |
| 11:15:37 | <dileepsisila_> <dkayiwa> i fixed this error change the liquibase-core-data.xml data |
| 11:17:06 | <dileepsisila_> <dkayiwa> r u here |
| 11:17:41 | <dkayiwa> dileepsisila_: yes |
| 11:18:14 | <dileepsisila_> <dkayiwa> is it error in open mrs |
| 11:18:48 | <dkayiwa> dileepsisila_: you can create a ticket for it and then attach your patch |
| 11:19:47 | <dileepsisila_> <dkayiwa> i fixed this error and at the last stage there was an another error |
| 11:20:44 | <dileepsisila_> <dkayiwa> tomcat log said Caused by: liquibase.exception.DatabaseException: Error executing SQL CREATE UNIQUE INDEX `order_type_uuid_index` ON `order_type`(`uuid`): Duplicate entry '131168f4-15f5-102d-96e4-000c29c2a5d7' for key 'order_type_uuid_index' |
| 11:21:24 | <dileepsisila_> <dkayiwa> do you hear about this error |
| 11:21:57 | <dkayiwa> dileepsisila_: you can create a ticket for it and then attach your patch |
| 11:22:31 | <dileepsisila_> <dkayiwa> ok thanks can you give url for patching |
| 11:23:06 | <dkayiwa> dileepsisila_: you will attach it on the ticket |
| 11:23:51 | <dileepsisila_> <dkayiwa> where is ticket location |
| 11:24:02 | <dkayiwa> jira |
| 11:26:29 | <dileepsisila_> <dkayiwa> then i choosed create issue. can you say my path is ok or not |
| 11:27:39 | *** harshadura has joined #openmrs |
| 11:29:07 | <dkayiwa> dileepsisila_: can you ask fellow gsoc students to help you on that? |
| 11:29:27 | <dkayiwa> dileepsisila_: we encourage students helping one another :) |
| 11:30:19 | <dileepsisila_> <dkayiwa> : ) i will ask thank u |
| 11:31:23 | <harshadura> dkayiwa, still im stuck with that error, pls can u help me |
| 11:32:26 | <dkayiwa> harshadura: which variable is null |
| 11:33:00 | <harshadura> dkayiwa, thrs no variable in that line, its a method |
| 11:33:09 | <harshadura> org.junit.Assert.assertTrue(bindingResult.hasErrors()); |
| 11:34:08 | <dkayiwa> harshadura: method calls are made on variables |
| 11:34:34 | <dkayiwa> harshadura: so you can check which variable is null before the method call |
| 11:38:41 | *** james_regen has joined #openmrs |
| 11:38:41 | *** ChanServ sets mode: +v james_regen |
| 11:39:10 | <harshadura> okay dkayiwa |
| 11:43:49 | *** harshadura has quit IRC |
| 12:02:56 | *** maurya has quit IRC |
| 12:04:01 | *** hemanth_92 has joined #openmrs |
| 12:05:51 | *** dileepsisila_ has quit IRC |
| 12:07:03 | *** nribeka has joined #openmrs |
| 12:07:03 | *** ChanServ sets mode: +v nribeka |
| 12:16:34 | *** snoppy has joined #openmrs |
| 12:21:37 | *** bryq has joined #openmrs |
| 12:21:37 | *** ChanServ sets mode: +v bryq |
| 12:26:33 | *** bwolfe has joined #openmrs |
| 12:26:34 | *** ChanServ sets mode: +o bwolfe |
| 12:28:37 | *** jkeiper has quit IRC |
| 12:31:11 | *** kdeeq has joined #openmrs |
| 12:35:01 | *** Rahul has quit IRC |
| 12:37:14 | *** satyag has joined #openmrs |
| 12:52:39 | *** maurya has joined #openmrs |
| 12:52:58 | *** deadpool has quit IRC |
| 12:55:19 | *** nribeka has quit IRC |
| 12:58:19 | *** nadee has joined #openmrs |
| 13:00:09 | *** nribeka has joined #openmrs |
| 13:00:09 | *** ChanServ sets mode: +v nribeka |
| 13:09:36 | *** maurya has quit IRC |
| 13:10:17 | *** dkayiwa_ has joined #openmrs |
| 13:10:46 | *** dkayiwa has quit IRC |
| 13:10:46 | *** dkayiwa_ is now known as dkayiwa |
| 13:11:00 | *** mseaton has joined #openmrs |
| 13:11:00 | *** ChanServ sets mode: +v mseaton |
| 13:12:10 | *** pushkar has joined #openmrs |
| 13:12:24 | <pushkar> bwolfe: hi |
| 13:12:28 | *** kdeeq has quit IRC |
| 13:13:11 | <bwolfe> hey |
| 13:14:35 | <pushkar> bwolfe: i found bugs in hr module how should i report them . the module is not listed in projects list |
| 13:14:59 | <bwolfe> you can use the OTHER project. ("Unsupported - Other" is the full name) |
| 13:15:07 | <bwolfe> put rfriedman's name as a watcher |
| 13:15:48 | <pushkar> bwolfe: okay :-) thank you |
| 13:16:08 | *** mvorobey has joined #openmrs |
| 13:16:47 | <mvorobey> hi all |
| 13:19:57 | *** hemanth_92 has quit IRC |
| 13:20:01 | *** pushkar has quit IRC |
| 13:20:06 | *** maurya has joined #openmrs |
| 13:20:45 | <nadee> hi devs, could someone please point me how to start on issue https://tickets.openmrs.org/browse/TRUNK-2296 ? |
| 13:20:55 | *** jmiranda has quit IRC |
| 13:21:33 | <nadee> Im kind of new on spring, but happy to learn , any guide would be great! |
| 13:23:39 | <bwolfe> nadee, not sure where to start |
| 13:23:45 | <bwolfe> try to duplicate the error |
| 13:23:50 | <bwolfe> then look at that class and try some other options |
| 13:25:37 | *** harshadura has joined #openmrs |
| 13:26:50 | *** sgithens_ has joined #openmrs |
| 13:32:55 | <dkayiwa> bwolfe: do we have any group box widget for the mockup on REPORT-242 ? |
| 13:33:07 | <bwolfe> !ticket REPORT-242 |
| 13:33:08 | <OpenMRSBot> bwolfe: [#REPORT-242] Update reporting dashboard UI to better support systems with lots of reports in a variety of categories - OpenMRS JIRA - https://tickets.openmrs.org/browse/REPORT-242 |
| 13:34:25 | <bwolfe> dkayiwa, group by widget? which part do you mean? the "reports by category (view all)" box? |
| 13:34:36 | <dkayiwa> bwolfe: yes |
| 13:34:47 | <bwolfe> thats a "fieldset" in html |
| 13:34:48 | <dkayiwa> bwolfe: "reports by category (view all)" box |
| 13:34:56 | <dkayiwa> bwolfe: oh :) |
| 13:42:37 | <nadee> ben, required class is org.openmrs.validator.PersonNameValidator.java. Issue says that, instead of the regular validate(object, errors), go for validatePersonName(personName, errors, true, false) |
| 13:43:27 | <nadee> ben, but inside regular validate method itself, its calling the said longer method, after checking for errors |
| 13:43:59 | <nadee> i.e. after the check if (!errors.hasErrors()) |
| 13:44:30 | *** wyclif has quit IRC |
| 13:44:50 | <nadee> ben, can you kindly show me what is exactly required.. |
| 13:45:12 | <bwolfe> unfortunately I cannot right now nadee :-/ |
| 13:45:58 | *** snoppy has quit IRC |
| 13:46:44 | <nadee> ben, cool, will take a look more |
| 13:47:44 | *** jmiranda has joined #openmrs |
| 13:47:58 | *** ChanServ sets mode: +o jmiranda |
| 13:48:15 | *** dawn_ has joined #openmrs |
| 13:49:02 | *** ChanServ sets mode: +v dawn_ |
| 13:55:26 | *** maurya has quit IRC |
| 13:55:36 | *** wyclif has joined #openmrs |
| 13:59:03 | *** bwolfe is now known as zzz |
| 13:59:50 | *** kdeeq has joined #openmrs |
| 14:00:19 | <dawn_> !scrumon dawn |
| 14:00:19 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready. |
| 14:00:27 | <dawn_> Hi Team :) |
| 14:00:35 | <dawn_> Today's order: bwolfe , djazayeri1 , dkayiwa , rafa , mseaton , mvorobey , sgithens , wyclif |
| 14:00:43 | <rafa> hi! |
| 14:00:51 | <dkayiwa> hi |
| 14:01:05 | <mvorobey> hi, dawn_ |
| 14:01:10 | <zzz> who is bwolfe? |
| 14:01:26 | <zzz> I don't see a bwolfe dawn_ |
| 14:01:39 | <dawn_> ben wolfe! |
| 14:01:43 | <dawn_> :D |
| 14:01:48 | <dawn_> ben: it's your turn |
| 14:01:52 | <wyclif> hi |
| 14:01:54 | <dawn_> mvorobey: hi |
| 14:01:56 | <zzz> *sigh* |
| 14:01:58 | *** zzz is now known as bwolfe |
| 14:02:01 | <bwolfe> today: |
| 14:02:01 | <bwolfe> reviewed TRUNK-3197 obs sort option |
| 14:02:01 | <bwolfe> applied TRUNK-3238, db startup error |
| 14:02:01 | <bwolfe> reviewed TRUNK-2509, default error handler |
| 14:02:01 | <bwolfe> reviewed TRUNK-3229, reselecting visit atts |
| 14:02:02 | <bwolfe> actually start on the atom feed spike |
| 14:02:04 | <bwolfe> no blockers |
| 14:02:21 | <dawn_> djazayeri1: your turn |
| 14:03:08 | *** djazayeri1 is now known as djazayeri |
| 14:03:09 | *** ChanServ sets mode: +o djazayeri |
| 14:03:13 | <djazayeri> yesterday |
| 14:03:22 | <djazayeri> * cleared the email queue |
| 14:03:41 | <djazayeri> * email summarizing UI and App work from before going offline |
| 14:03:59 | <djazayeri> * looked at reporting sprint tickets, but didn't yet pick one to do |
| 14:04:00 | <djazayeri> today |
| 14:04:09 | <djazayeri> * revise UI Framework documentation |
| 14:04:15 | <djazayeri> * start a sprint ticket |
| 14:04:17 | <djazayeri> no blockers |
| 14:04:43 | <dawn_> dkayiwa: your turn :) |
| 14:04:43 | <dkayiwa> Looked into: An exception is thrown when creating/editing a indicator and parameter is selected from the dropdown - REPORT-194 |
| 14:04:44 | <dkayiwa> Looked into: Null Pointer Exception occurs if you enter invalid logic expressions in columns within a LogicDataSetDefinition prior to saving it for the first time - REPORT-267 |
| 14:04:44 | <dkayiwa> Looked into: Display error messages when required fields are blank when previewing an indicator definition - REPORT-193 |
| 14:04:44 | <dkayiwa> Looked into my gsoc student proposals |
| 14:04:44 | <dkayiwa> Lots of IRC in the morning |
| 14:04:45 | <dkayiwa> Working on: Update reporting dashboard UI to better support systems with lots of reports in a variety of categories - REPORT-242 |
| 14:04:45 | <dkayiwa> No Blockers |
| 14:05:00 | <dkayiwa> :D |
| 14:05:04 | <dawn_> :D |
| 14:05:09 | <bwolfe> dkayiwa, lots of looking... |
| 14:05:21 | <rafa> Today: |
| 14:05:22 | <rafa> * Committed TRUNK-3229: Reselect visit attribute values on error |
| 14:05:22 | <rafa> https://tickets.openmrs.org/browse/TRUNK-3229 |
| 14:05:22 | <rafa> * Committed TRUNK-3235: in liquibase changeset 20110301-1030, the new concept mapping types should use standardized uuids instead of random ones |
| 14:05:22 | <rafa> https://tickets.openmrs.org/browse/TRUNK-3235 |
| 14:05:22 | <rafa> * Started with TRUNK-3234: Failed to run sql dump file with testing installation method |
| 14:05:22 | <rafa> https://tickets.openmrs.org/browse/TRUNK-3234 |
| 14:05:23 | <rafa> No blockers. |
| 14:05:28 | <dkayiwa> bwolfe: was not sure of which ticket to do. so i tried out a number of them :) |
| 14:05:54 | <dawn_> mseaton: your turn |
| 14:06:43 | <bwolfe> mseaton is probably playing babysitter again :-) |
| 14:07:02 | <dawn_> mvorobey: could you list your updates now? not sure mike is available :) |
| 14:07:08 | <mvorobey> * Setup reporting module and picked up REPORT-339 |
| 14:07:10 | <mvorobey> * Reworked TRUNK-250 |
| 14:07:15 | <mvorobey> * Had a design discussion with Ben on that |
| 14:07:20 | <mvorobey> * No blockers |
| 14:07:50 | <djazayeri> !ticket report-339 |
| 14:07:51 | <OpenMRSBot> djazayeri: [#REPORT-339] Add a page to manage all scheduled reports - OpenMRS JIRA - https://tickets.openmrs.org/browse/report-339 |
| 14:08:04 | <dawn_> sgithens: your turn |
| 14:09:10 | <dawn_> wyclif: could you list your updates now? not sure steve is available :) |
| 14:09:11 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Announcements List: Save the Date: 2012 Implementers Meeting <https://listserv.iupui.edu/cgi-bin/wa-iupui.exe?A2=ind1204&L=openmrs-announce-l&P=75> |
| 14:09:13 | <wyclif> monday: |
| 14:09:13 | <wyclif> * Review TODO for - TRUNK-1727 - Inconsistencies between exiting a patient from care and marking them as deceased |
| 14:09:13 | <wyclif> * REPORT-336 - Page to view the current report generation queue and enable canceling queued items |
| 14:09:13 | <wyclif> tuesday: |
| 14:09:13 | <wyclif> * complete REPORT-33 |
| 14:09:15 | <wyclif> * pick up another sprint ticket |
| 14:09:17 | <wyclif> Blockers - Can't view reporting pages from admin section because tags are not getting packaged |
| 14:09:46 | <dawn_> thanks, everyone! we can get updates from mseaton and sgithens soon |
| 14:09:48 | <dawn_> !scrumoff dawn |
| 14:09:48 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 14:10:12 | <djazayeri> wyclif: is the "tags not getting packaged" an error that only you are having, or others too? |
| 14:10:22 | <dawn_> Discussion points: 1) 1.9 2) Wyclif's blocker: Can't view reporting pages from admin section because tags are not getting packaged |
| 14:10:45 | <wyclif> djazayeri, the tag handler classes |
| 14:11:10 | <bwolfe> wyclif, thats a trunk issue |
| 14:11:23 | <bwolfe> I ran into that with RPC, let me commit something here in 2 minutes |
| 14:11:33 | <wyclif> bwolfe, thanks bwolfe |
| 14:11:35 | <djazayeri> bwolfe: meaning that if wyclif just runs 1.9.x or 1.8.x he should be fine? |
| 14:11:49 | <wyclif> bwolfe, you are savior i thought it was the module |
| 14:12:09 | <wyclif> bwolfe, wasted alot of time time yesterday |
| 14:12:18 | <djazayeri> wyclif: did you mention it on IRC? |
| 14:12:54 | <djazayeri> when you find yourself blocked on something, you don't need to wait until the next scrum to mention it. |
| 14:12:55 | <djazayeri> :-) |
| 14:13:19 | <wyclif> djazayeri, i mentioned it to mseaton |
| 14:13:44 | <djazayeri> sounds like you should have mentioned it to bwolfe instead. (too bad he was on a half day) |
| 14:14:07 | <djazayeri> anyway, general point is to ask about blockers as early as possible. |
| 14:14:07 | <bwolfe> wyclif, committed in trunk 26774 |
| 14:14:15 | <wyclif> thanks |
| 14:14:18 | <djazayeri> other discussion point: 1.9 |
| 14:14:29 | <dawn_> dkayiwa: is all that's left for 1.9RC2 rafal's completion of TRUNK-3235 followed by additional testing? |
| 14:14:45 | <bwolfe> wyclif, and since others weren't seeing the error, you could have used 1.9.x to get moving again. :-) |
| 14:14:57 | <sgithens_> dawn_ Sorry. Checkout'd, compiled reporting module and getting familier with it |
| 14:15:00 | <bwolfe> rafa, what dashboard are you using? |
| 14:15:08 | <dkayiwa> dawn_: NO |
| 14:15:19 | <wyclif> bwolfe, i just had no clue it was a module issue |
| 14:15:30 | <wyclif> bwolfe, a trunk issue |
| 14:15:31 | <dkayiwa> dawn_: he has a few other tickets to work on |
| 14:15:34 | <dawn_> sgithens_: no worries. thanks for the update |
| 14:15:59 | <sgithens_> is it always at 10 sharp? |
| 14:15:59 | <wyclif> bwolfe, it was only the modul's links that were broken so i assumed it was in the module |
| 14:16:56 | <bwolfe> wyclif, right, that was my first guess with RPC too |
| 14:16:56 | *** dawn_ has quit IRC |
| 14:17:23 | *** dawn_ has joined #openmrs |
| 14:17:23 | *** ChanServ sets mode: +v dawn_ |
| 14:17:25 | <djazayeri> sgithens: https://wiki.openmrs.org/x/SoK5AQ |
| 14:17:31 | <bwolfe> but for future times, instead of working on it for half a day, ask if anyone else has an issue and/or try other versions to see when it starts failing |
| 14:17:38 | <mseaton> dawn_ sorry, had a meeting run late |
| 14:17:44 | <djazayeri> different times each day |
| 14:18:33 | <wyclif> bwolfe, actuall y was able to write the code but just couldn't test it |
| 14:19:06 | <wyclif> bwolfe, so i was still able to be productive in some way |
| 14:19:44 | <dawn_> sgithens: if you think you will be in the scrum each day, i can add your email into the calendar I have for reminders |
| 14:20:41 | <dawn_> dkayiwa: any thoughts on when those tickets will be finished to wrap up 1.9? :) |
| 14:20:46 | <sgithens_> dawn_ : that would make it more likely for me to be in the scrum |
| 14:21:02 | <dawn_> mseaton: no worries. feel free to share your updates now |
| 14:21:23 | *** jkeiper has joined #openmrs |
| 14:21:45 | <dawn_> sgithens_: IUPUI email or gmail? |
| 14:22:16 | <sgithens_> dawn_ : IUPUI |
| 14:23:02 | <dkayiwa> dawn_: this week should be enough to have all of them done :) |
| 14:23:20 | <dkayiwa> dawn_: then we shall have RC3 :) |
| 14:23:46 | <rafa> bwolfe: I'm using a jira filter for 1.9.0 |
| 14:27:18 | <bwolfe> rafa, link? |
| 14:27:30 | <rafa> https://tickets.openmrs.org/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+TRUNK+AND+resolution+%3D+Unresolved+and+fixVersion%3D%22OpenMRS+1.9.0%22 |
| 14:28:19 | <bwolfe> rafa, feel free to be the second reviewer on those post-commit ones (and backport if need-be) |
| 14:28:36 | <rafa> bwolfe: cool |
| 14:31:03 | *** dkayiwa has quit IRC |
| 14:31:57 | *** cloud|windoze has joined #openmrs |
| 14:32:47 | *** cloud|windoze has quit IRC |
| 14:36:37 | *** goutham has joined #openmrs |
| 14:44:24 | *** satyag has quit IRC |
| 14:49:55 | *** dawn_ has quit IRC |
| 14:51:14 | <mseaton> djazayeri / dkayiwa, can we talk tagging reporting objects at some point ? |
| 14:51:56 | <mseaton> dkayiwa: you said you are picking up REPORT-242? |
| 14:54:16 | <djazayeri> mseaton: yes, we can |
| 14:55:03 | *** maurya has joined #openmrs |
| 14:55:50 | *** jmiranda has quit IRC |
| 14:55:51 | <mseaton> djazayeri: unfortunately, i plan to redesign the persistence stuff at some point, and i don't see a great way to do this in a future-proof way right now. i'm thinking just a simple table with "id", "definition_uuid", "tag" columns, which could be used to tag any reporting definition by uuid |
| 14:56:36 | <djazayeri> mseaton: that seems fine to me anyway |
| 14:56:39 | <mseaton> this won't perform particularly well, as you'd need to first get all definitions of type "X" by uuid, and then get all tags in that collection of uuids, and then organize the definitions by tag, and then display them |
| 14:56:49 | *** jkeiper has quit IRC |
| 14:56:53 | <mseaton> but maybe ok for now? |
| 14:57:09 | <djazayeri> what about having a definition_type column? |
| 14:57:21 | <djazayeri> for the top-level interface, e.g. CohortDefinition |
| 14:57:36 | <mseaton> well, it's a bit redundant |
| 14:57:53 | <mseaton> we certainly could do that though |
| 14:58:00 | <djazayeri> yeah, but it would allow you to get all tags for CohortDefinitions, for example |
| 14:58:07 | <mseaton> yes |
| 14:58:22 | <djazayeri> which seems like it would perform better in some cases |
| 14:58:44 | <mseaton> i would just worry about inconsistency creeping in - not sure if it ever would, but it opens the possibility |
| 14:59:25 | <djazayeri> yeah, but it seems like at some point you'd like to be able to say "get all cohort definitions tagged with PEPFAR" |
| 14:59:36 | *** goutham has quit IRC |
| 14:59:46 | <mseaton> you definitely would |
| 15:00:16 | <djazayeri> or rather: you'd like to be able to search for things by tag, and then, given the uuid, be able to fetch it more efficiently, without having to potentially search all definition tables |
| 15:00:43 | *** satyag has joined #openmrs |
| 15:01:23 | *** dawn_ has joined #openmrs |
| 15:01:23 | *** ChanServ sets mode: +v dawn_ |
| 15:02:19 | <mseaton> ok, i'm fine with it. it's most likely a temporary solution anyway (though you never know). |
| 15:02:58 | *** kmit has joined #openmrs |
| 15:03:02 | <mseaton> i'll update the ticket, thanks! |
| 15:03:46 | <djazayeri> mseaton: if you avoid having a "get all definitions with tag" service method, that will help the eventual migration to a new implementation, right? |
| 15:04:38 | <mseaton> djazayeri, why? |
| 15:05:14 | *** harshadura has quit IRC |
| 15:05:20 | <djazayeri> mseaton: I assume you're calling this a temporary solution because you intend to change the persistence mechanism to have a different table (and tag table) for each definition type, right? |
| 15:05:41 | <mseaton> possibly yes, though that needs more discussion too :) |
| 15:05:53 | <mseaton> but already we have a service for each definition type |
| 15:06:04 | <mseaton> so having a method "getAllCohortDefinitionsWithTag(String)" seems future proof |
| 15:06:05 | <djazayeri> right, but if you have a "get all definitions of any type, with tag=x" then that won't work in the new model |
| 15:06:11 | <djazayeri> yeah, that does |
| 15:06:27 | <djazayeri> sorry, I meant to not have a "with any type" variant |
| 15:06:33 | <mseaton> oh, i see what you were saying before. i don't think we need "with any type" |
| 15:08:02 | *** jmiranda has joined #openmrs |
| 15:08:20 | <mseaton> djazayeri: i guess this needs to be an OpenmrsObject with a uuid, huh? |
| 15:08:40 | <djazayeri> mseaton: the tag? |
| 15:08:46 | <djazayeri> if you want it to sync, I guess. |
| 15:09:26 | <mseaton> yeah. it's not really possible to implement as just a Set<String> on each definition with the current model + with our proposed design. |
| 15:10:49 | *** harshadura has joined #openmrs |
| 15:12:05 | <djazayeri> I can't think of another way |
| 15:22:06 | *** kmit has quit IRC |
| 15:23:08 | <mvorobey> mseaton, hi Mike :) am working on REPORT-339 and having configuration error , can you help me ? |
| 15:23:22 | <mseaton> mvorobey - i can try :) |
| 15:23:42 | <mvorobey> mseaton, so, I can not login into OpenMrs because of : |
| 15:23:43 | <mvorobey> org.openmrs.api.context.ContextAuthenticationException: Invalid number of connection attempts. Please try again later. |
| 15:24:14 | <mvorobey> mseaton, that error began occurring after I installed reporting module |
| 15:24:16 | <mseaton> sounds like invalid credentials - try restarting tomcat to get a fresh set of attempts, and try again |
| 15:24:25 | <mseaton> probably the scheduler? |
| 15:24:28 | <mvorobey> mseaton, I tried |
| 15:24:30 | <mseaton> not sure why that would happen |
| 15:24:36 | <mvorobey> mseaton, yes, scheduler |
| 15:24:50 | <mseaton> is it configured with your username? |
| 15:25:13 | <mvorobey> mseaton, do not know, where is his conf file is usually located ? |
| 15:25:25 | *** goutham has joined #openmrs |
| 15:26:44 | <mvorobey> mseaton, with Global Properties ? |
| 15:27:32 | *** pushkar has joined #openmrs |
| 15:29:36 | *** goutham has quit IRC |
| 15:31:01 | *** kdeeq has quit IRC |
| 15:31:51 | <mseaton> mvorobey: yes, you set the scheduler username and password with global properties |
| 15:31:59 | <mseaton> this is not limited to the reporting module though |
| 15:32:25 | <mvorobey> mseaton, I found them, problem with password, thanks for help :) |
| 15:32:37 | <mseaton> mvorobey: no problem |
| 15:32:47 | *** Rahul has joined #openmrs |
| 15:38:27 | *** mvorobey has quit IRC |
| 15:39:54 | *** dawn_ has quit IRC |
| 15:49:16 | *** dawn_ has joined #openmrs |
| 15:49:16 | *** ChanServ sets mode: +v dawn_ |
| 15:49:20 | *** goutham has joined #openmrs |
| 15:49:38 | *** dawn_ has quit IRC |
| 15:49:40 | *** dawn__ has joined #openmrs |
| 15:49:40 | *** ChanServ sets mode: +v dawn__ |
| 15:49:47 | *** pulasthi7 has joined #openmrs |
| 15:56:54 | *** maurya has quit IRC |
| 16:01:36 | *** dawn__ has quit IRC |
| 16:08:40 | *** dawn_ has joined #openmrs |
| 16:08:40 | *** ChanServ sets mode: +v dawn_ |
| 16:09:36 | *** rafa has quit IRC |
| 16:09:36 | *** dawn_ has quit IRC |
| 16:13:41 | *** suranga has joined #openmrs |
| 16:13:41 | *** ChanServ sets mode: +v suranga |
| 16:14:49 | *** alpha_jet has joined #openmrs |
| 16:21:41 | *** pushkar has quit IRC |
| 16:23:49 | *** r_friedman has joined #openmrs |
| 16:26:05 | *** hemanth_92 has joined #openmrs |
| 16:31:35 | <hemanth_92> hi |
| 16:35:00 | *** satyag has quit IRC |
| 16:46:11 | *** jkeiper has joined #openmrs |
| 16:46:48 | *** satyag has joined #openmrs |
| 16:51:19 | <nribeka> mseaton, do you have a minute? :) |
| 16:51:34 | <mseaton> nribeka: about to run to lunch. what's up? |
| 16:52:15 | <nribeka> quick question: i think patient join point to obs is person.personId not patient.patientId |
| 16:52:20 | <nribeka> patientJoinProperties.put(Obs.class, "person.personId"); |
| 16:52:24 | *** wyclif_ has joined #openmrs |
| 16:52:41 | <nribeka> HibernateDataSetQueryDAO line 99 |
| 16:52:42 | <mseaton> probably right |
| 16:52:50 | *** Ashford has joined #openmrs |
| 16:53:14 | <nribeka> i will talk a bit more after your lunch if you're not busy mseaton |
| 16:53:20 | *** satyag has quit IRC |
| 16:53:44 | <mseaton> nribeka: sounds good. this method is sort of hacky anyway |
| 16:53:50 | <hemanth_92> i have a query about the rest services, any body up for it? |
| 16:53:58 | <nribeka> ok mseaton |
| 16:54:06 | <nribeka> hemanth_92, you can ask bwolfe :) |
| 16:54:26 | <hemanth_92> okay |
| 16:55:06 | <bwolfe> who is this bwolfe you speak of? |
| 16:55:44 | *** janet_ has joined #openmrs |
| 16:56:41 | *** wyclif_ has quit IRC |
| 16:57:43 | <hemanth_92> bwolfe, i wanted to know if there is a rest call for getting the details of the patients . because the rest call i'm using is getting me only the name, UUID |
| 16:58:04 | <bwolfe> hemanth_92, what are you using? |
| 16:58:07 | <bwolfe> what url? |
| 16:58:20 | <hemanth_92> http://raxaemr.jelastic.servint.net/openmrs/ws/rest/v1/patient?q=John |
| 16:58:28 | <OpenMRSBot> <http://ln-s.net/9w2U> (at raxaemr.jelastic.servint.net) |
| 16:58:52 | <hemanth_92> and another rest url which is giving me the entire details |
| 17:00:55 | <r_friedman> hemanth_92: I'm back. Yes, I think we have a ticket to allow ?v=full&q=John |
| 17:01:21 | <hemanth_92> oh, okay |
| 17:01:54 | <hemanth_92> got it! thanks r_friedman |
| 17:01:58 | <bwolfe> right. when you search right now all you get is the small output |
| 17:02:16 | <bwolfe> you can't influence it yet. but soon you will be able to add the v=full as roger mentioned |
| 17:02:45 | <bwolfe> for now you can just do a second call to the url in the results to get the default or full represenation of the patient |
| 17:03:02 | <hemanth_92> but isn't it working now? because its getting me the entire info! |
| 17:03:08 | <hemanth_92> http://raxaemr.jelastic.servint.net/openmrs/ws/rest/v1/patient?v=full&q=John |
| 17:03:11 | <OpenMRSBot> <http://ln-s.net/9w2e> (at raxaemr.jelastic.servint.net) |
| 17:03:51 | <bwolfe> hemanth_92, which version are you using? |
| 17:04:00 | <bwolfe> it might be in the trunk code of restws already |
| 17:04:14 | <hemanth_92> its the jelastic server |
| 17:04:23 | <hemanth_92> http://raxaemr.jelastic.servint.net/openmrs |
| 17:06:04 | <r_friedman> hemanth_92: prob have to ask saptarshi that |
| 17:06:17 | <hemanth_92> okay |
| 17:08:00 | <hemanth_92> thanks r_friedman , bwolfe |
| 17:08:28 | <bwolfe> its quite possible saptarshi is using the trunk code of restws |
| 17:09:27 | *** satyag has joined #openmrs |
| 17:11:05 | *** mccallumg has joined #openmrs |
| 17:11:05 | *** ChanServ sets mode: +v mccallumg |
| 17:11:30 | *** rohitgoyal18 has joined #openmrs |
| 17:13:51 | *** maurya has joined #openmrs |
| 17:16:58 | *** alpha_jet has quit IRC |
| 17:21:23 | *** satyag has quit IRC |
| 17:22:06 | *** Ashford has quit IRC |
| 17:27:51 | *** deadpool has joined #openmrs |
| 17:28:38 | <deadpool> bwolfe: do you know how to trouble shoot an errno 150 when trying to create a table in the database? |
| 17:29:06 | <deadpool> it has to do with a foreign key but i don't konw what is wrong with it |
| 17:29:07 | <bwolfe> I've seen it a few times before |
| 17:29:14 | <bwolfe> but I can't remember how to deal with it |
| 17:29:30 | <bwolfe> deadpool, are both tables the same type? |
| 17:29:30 | *** kmit has joined #openmrs |
| 17:29:36 | <bwolfe> are the columsn the same type? |
| 17:29:49 | <deadpool> uh i think so |
| 17:29:51 | <deadpool> what do you mean |
| 17:30:23 | <deadpool> bwolfe: http://pastebin.com/JZmkXZqz |
| 17:30:33 | <deadpool> problem comes when trying to enter billing details |
| 17:30:37 | <wyclif> am heading out for lunch |
| 17:31:03 | <bwolfe> deadpool, which table? |
| 17:31:07 | *** jmiranda has quit IRC |
| 17:31:24 | <deadpool> bwolfe: billing_details |
| 17:31:33 | *** jmiranda has joined #openmrs |
| 17:32:40 | <bwolfe> for any values you put in? |
| 17:33:05 | <deadpool> i can't create the table |
| 17:33:15 | <bwolfe> deadpool, you really should prefix all of your tables with "billing_" if that is the name of your module. that way nothign will clash later (you can leave all your objects named whatever you want, just the tables should have the prefix) |
| 17:33:25 | <deadpool> oh ok |
| 17:33:28 | <deadpool> i can do that |
| 17:34:30 | <bwolfe> deadpool, contraint names must be unique across all tables in mysql |
| 17:35:08 | <deadpool> names meaning? |
| 17:35:17 | <bwolfe> you can guarantee it by putting hte table name in the contraint name |
| 17:35:28 | <bwolfe> change CONSTRAINT `abc constraint` FOREIGN KEY (`department`) REFERENCES `department` (`id`), to CONSTRAINT `billing_details abc constraint` FOREIGN KEY (`department`) REFERENCES `department` (`id`), |
| 17:36:32 | *** wyclif has quit IRC |
| 17:37:08 | *** mseaton1 has joined #openmrs |
| 17:37:17 | *** janet_ has left #openmrs |
| 17:37:50 | *** mseaton2 has joined #openmrs |
| 17:37:55 | <deadpool> ah for the description |
| 17:39:20 | *** mseaton has quit IRC |
| 17:41:19 | <rohitgoyal18> hi bwolfe. |
| 17:41:27 | <bwolfe> hey |
| 17:41:30 | *** mseaton1 has quit IRC |
| 17:41:42 | <rohitgoyal18> i was working on ticket number 3197 |
| 17:42:20 | <rohitgoyal18> the problem with HibernateObsDAO is that the functions have been referenced in ObsDAO as well. |
| 17:43:05 | <rohitgoyal18> and one function is again used in ObsServiceImpl. |
| 17:43:41 | <rohitgoyal18> so unless, the changes are made in all 3 places, how could it be fixed? |
| 17:45:59 | <rohitgoyal18> bwolfe, in the reply for that ticket, you told me that ObsDAO is not fixed among various versions. |
| 17:46:24 | *** jmiranda has quit IRC |
| 17:47:38 | <bwolfe> !ticket TRUNK-3197 |
| 17:47:39 | <OpenMRSBot> bwolfe: [#TRUNK-3197] Add an option for each sort Obs on each column in asc/desc - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3197 |
| 17:48:38 | <bwolfe> rohitgoyal18, I don't follow you. my comment was just that you are only adding a new private method (that is @deprecated for some reason) in your latest patch |
| 17:48:51 | <bwolfe> if that method isn't being called by anything, then your patch does nothing. :-) |
| 17:49:11 | *** nadee has quit IRC |
| 17:51:21 | <rohitgoyal18> no, before that i had made changes to 3 files. These were calling the function that i modified. By default it is sorting the values in descending order. Unless the function is overloaded, we cant make it sort Asc or Dsc according to us.... |
| 17:58:29 | *** deadpool has quit IRC |
| 18:01:29 | *** nribeka has quit IRC |
| 18:07:13 | *** nribeka has joined #openmrs |
| 18:07:14 | *** ChanServ sets mode: +v nribeka |
| 18:08:21 | *** kmit has quit IRC |
| 18:11:49 | *** deadpool has joined #openmrs |
| 18:13:31 | <bwolfe> rohitgoyal18, ok, went and looked at the code |
| 18:14:12 | <bwolfe> so you need to change the createGetObservationsCriteria method to add the asc/desc option. then change the methods that call that. then change the methods in the service layer than call that |
| 18:14:25 | <bwolfe> you only have to deprecate anything in the service layer. the dao layer can just be changed directly |
| 18:15:17 | *** hemanth_92 has quit IRC |
| 18:17:02 | <rohitgoyal18> bwolfe, ok. thanks a lot. |
| 18:17:31 | *** goutham has quit IRC |
| 18:18:01 | *** harshadura has quit IRC |
| 18:18:05 | *** mccallumg has quit IRC |
| 18:21:22 | *** Rahul has quit IRC |
| 18:23:31 | *** jkeiper has quit IRC |
| 18:26:48 | *** shanakaf has joined #openmrs |
| 18:27:56 | *** wyclif has joined #openmrs |
| 18:31:14 | <shanakaf> Hi Wyclif..I'm Shanaka from Sri Lanka |
| 18:32:23 | <shanakaf> I just mailed the dev list saying i want to work on Merge Concepts module project |
| 18:33:55 | *** wyclif has quit IRC |
| 18:38:02 | *** snoppy has joined #openmrs |
| 18:41:53 | *** jmiranda has joined #openmrs |
| 18:47:46 | <sgithens_> mseaton2: I'm seeing problems loading the report tags, any ideas what's wrong? http://pastebin.com/4KnCh6mV |
| 18:48:04 | *** suranga_ has joined #openmrs |
| 18:49:14 | <mseaton2> sgithens: wyclif was having the same issue. bwolfe told him it was a bug in trunk that he was hoping to quickly fix earlier. i recommend using 1.8.x for development. |
| 18:49:54 | <mseaton2> sgithens_ |
| 18:50:26 | <sgithens_> mseaton2: thanks, I'll roll back to 1.8.x for this work |
| 18:51:08 | *** suranga has quit IRC |
| 18:52:43 | <mseaton2> bwolfe (or anyone else): do i show up as mseaton2 and if so, how do i change that? |
| 18:53:29 | *** mseaton2 has left #openmrs |
| 18:53:54 | *** mseaton has joined #openmrs |
| 18:53:54 | *** ChanServ sets mode: +v mseaton |
| 18:54:38 | <sgithens_> mseaton: Looks like you back to the original mseaton now |
| 18:55:23 | <mseaton> i rebooted my client, didn't gain any new irc wisdom |
| 19:00:09 | <bwolfe> mseaton, see the irc page in the openmrs wiki for the most useful commands |
| 19:00:16 | <bwolfe> but its /nick mseaton |
| 19:00:30 | <bwolfe> or you can do /ghost mseaton yourpassowrd to kick your other nickname |
| 19:00:54 | <mseaton> bwolfe, thanks. is that in this chat, or elsewhere - directly on nickserv? |
| 19:01:02 | *** jkeiper has joined #openmrs |
| 19:01:32 | *** robbyoconnor has joined #openmrs |
| 19:01:32 | *** ChanServ sets mode: +v robbyoconnor |
| 19:01:49 | *** robbyoconnor has quit IRC |
| 19:02:09 | *** robbyoconnor has joined #openmrs |
| 19:02:09 | *** ChanServ sets mode: +v robbyoconnor |
| 19:04:14 | * robbyoconnor goes to review proposals |
| 19:04:30 | *** shanakaf has quit IRC |
| 19:08:40 | <snoppy> bwolfe: hi bwolfe! |
| 19:10:06 | <snoppy> bwolfe: I've attach new patch for TRUNK-2509 |
| 19:12:47 | <bwolfe> !ticket TRUNK-2509 |
| 19:12:48 | <OpenMRSBot> bwolfe: [#TRUNK-2509] default error handler should try to record what user generated error in log - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2509 |
| 19:22:25 | <robbyoconnor> I want the supybot plugin used for !ticket |
| 19:22:27 | <robbyoconnor> :) |
| 19:22:34 | <robbyoconnor> i wanna see it :) |
| 19:25:01 | *** maurya has quit IRC |
| 19:27:48 | *** wyclif has joined #openmrs |
| 19:34:08 | <bwolfe> robbyoconnor, its just the alias plugin I think |
| 19:35:08 | <robbyoconnor> ah |
| 19:46:25 | *** downey has joined #openmrs |
| 19:46:25 | *** ChanServ sets mode: +o downey |
| 19:46:25 | *** OpenMRSBot sets mode: +o downey |
| 19:49:26 | *** james_regen has left #openmrs |
| 19:51:51 | *** rohitgoyal18 has quit IRC |
| 19:54:49 | *** r0bby has joined #openmrs |
| 19:54:49 | *** ChanServ sets mode: +v r0bby |
| 19:56:49 | *** robbyoconnor has quit IRC |
| 19:56:55 | *** r0bby is now known as robbyoconnor |
| 20:03:04 | *** mccallumg has joined #openmrs |
| 20:03:04 | *** ChanServ sets mode: +v mccallumg |
| 20:08:45 | *** r_friedman has quit IRC |
| 20:08:59 | *** jkeiper has quit IRC |
| 20:18:09 | *** Indie_ has joined #openmrs |
| 20:18:23 | <downey> Hi Indie_ and welcome to the #openmrs IRC channel. |
| 20:21:53 | *** Indie_ has left #openmrs |
| 20:22:31 | *** Indie_ has joined #openmrs |
| 20:32:32 | *** dkayiwa has joined #openmrs |
| 20:35:47 | *** isharap has joined #openmrs |
| 20:35:54 | <downey> Hi isharap and welcome to the #openmrs IRC channel. |
| 20:36:46 | <isharap> Thank you downey, but i have been here earlier :) |
| 20:37:06 | <downey> isharap: Ooops, I must have missed you. :) |
| 20:40:59 | *** maurya has joined #openmrs |
| 20:42:21 | <isharap> hi djazayeri, can i talk to you? |
| 20:42:30 | <djazayeri> hi |
| 20:43:03 | <isharap> im working on HTML-3 to filter out comments as suggested by Mark |
| 20:43:19 | <isharap> i tried with a simeple test html like, |
| 20:43:39 | <isharap> <htmlform><section><!-- test comment --></section><submit/></htmlform> |
| 20:43:53 | <isharap> but when it iterates and give the child nodes, |
| 20:44:16 | <isharap> it shows that childnode list length as 2 |
| 20:44:32 | <djazayeri> child nodes of what? |
| 20:44:45 | <isharap> <htmlform> |
| 20:44:58 | <isharap> seems it doesnt get COMMENT NODE |
| 20:45:27 | <djazayeri> hmm, maybe that's a setting on the dom parser? |
| 20:46:09 | <isharap> but i have tried with other methods, this way and it does get the chilren node list correct |
| 20:46:56 | <isharap> as an example, loadRenderElementsForEachRepeatElement() in FormEntryGenerator class this works fine |
| 20:47:03 | *** bryq has left #openmrs |
| 20:47:31 | *** maurya has quit IRC |
| 20:48:13 | <djazayeri> isharap: what is the actual goal here? is it to preserve the commented sections, or is it okay to get rid of them? |
| 20:48:17 | <isharap> djazayeri: btw i hv used Node.COMMENT_NODE to identiy comment node, is there any other wy to do it? |
| 20:49:13 | <djazayeri> isharap: I'm not actually familiar with working with the document/element/etc libararies |
| 20:49:13 | <isharap> to get rid of comments or either remove text inside the comments |
| 20:49:21 | <djazayeri> I don't know if comment_node is the best way or not |
| 20:49:58 | <djazayeri> isharap: I don't remember exactly how the code worksâ¦is the repeat tag just a regular tag, or does it have special-case handling? |
| 20:51:13 | <isharap> it has special case handling, when form created <repeat> tags are first handled seperately beform going into other tags |
| 20:51:34 | <djazayeri> hmm. |
| 20:51:34 | *** morristic has joined #openmrs |
| 20:51:49 | <djazayeri> So, I agree with Mark's suggestion to just strip comments out of the document |
| 20:51:51 | <isharap> in tht method, if there are commented out repeat tags, they are also taken as repeat blocks |
| 20:52:14 | <djazayeri> i.e. strip out all comments first, so any commented out repeat is not run. |
| 20:52:16 | <isharap> yes that is wht i was trying to do |
| 20:52:50 | <isharap> but i cant get the comment tag included into child list to work onto eliminate it |
| 20:53:00 | <isharap> thts what i 've been trying |
| 20:53:30 | <djazayeri> isharap: have things already been parsed into a Document at that point? |
| 20:53:46 | <djazayeri> I mean: is the input and output to stripComments a String, or a Document? |
| 20:54:27 | <isharap> input : string (which is xml of html data) |
| 20:54:30 | *** Indie_ has quit IRC |
| 20:54:33 | <isharap> output also string |
| 20:54:43 | <djazayeri> isharap: Mark's suggestion was to use regex to do this |
| 20:55:00 | <djazayeri> instead of parsing it to a Document and then writing it out to a String. |
| 20:55:30 | <djazayeri> alternately you could just do this manually with String.indexOf() |
| 20:57:11 | <isharap> i was not sure of how to use regex to do that , thts why i first tried with parsing, can u pls tell me how to do it with Regex? |
| 20:57:39 | <djazayeri> I don't know how you'd do this using Document parsing, but I think that would likely be slower-performing. |
| 20:58:33 | <djazayeri> for regex, you'd have to write a regular expression that matches "Something <!-- a comment --> and then more" and use the replace function |
| 20:59:46 | <isharap> you mean string replace()? |
| 21:00:28 | <djazayeri> yes |
| 21:02:10 | <isharap> which means use the xml string of the form and find out for comments using regex and replace them with "" |
| 21:02:11 | <isharap> ? |
| 21:03:30 | <djazayeri> yes, replace "<!--*-->" with "" (probably with some escaping) |
| 21:06:37 | <isharap> ok then, i will try this way. thank you very much djazayeri :) |
| 21:06:45 | <djazayeri> np, good luck! |
| 21:08:55 | *** mseaton has left #openmrs |
| 21:10:15 | *** robbyoconnor has quit IRC |
| 21:10:47 | *** robbyoconnor has joined #openmrs |
| 21:10:47 | *** ChanServ sets mode: +v robbyoconnor |
| 21:14:50 | *** robbyoconnor has quit IRC |
| 21:15:19 | *** robbyoconnor has joined #openmrs |
| 21:15:19 | *** ChanServ sets mode: +v robbyoconnor |
| 21:18:15 | <wyclif> hi djazayeri |
| 21:18:20 | <djazayeri> hi wyclif |
| 21:18:50 | <wyclif> djazayeri, when running a report what are allowed values for 'Schedule this for a later time' field |
| 21:20:08 | <djazayeri> wyclif: is that in a current page? |
| 21:20:16 | <djazayeri> or is it part of a ticket? |
| 21:20:20 | <djazayeri> I don't know the answer offhand |
| 21:20:38 | <wyclif> djazayeri, it on the run report page |
| 21:20:54 | <wyclif> i cant seem to know what to enter, it doesnt say anythung |
| 21:21:05 | <djazayeri> wyclif: let me install the latest module code |
| 21:22:22 | <wyclif> djazayeri, ok, thanks |
| 21:23:17 | *** suranga_ has quit IRC |
| 21:24:04 | *** robbyoconnor has quit IRC |
| 21:29:54 | *** snoppy has left #openmrs |
| 21:33:55 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Mark your calendars for the 2012 #OpenMRS Implementers Meeting, 9-12 October, Philippines. More info to come! http://t.co/sYXVLkAC #OMRS12 <http://twitter.com/OpenMRS/statuses/187277258757640192> |
| 21:36:11 | <djazayeri> wyclif: that field clearly needs some in-line documentation, but it appears that it's a cron expression of some sort |
| 21:36:41 | <wyclif> djazayeri, ok, so how do i schedule a report? |
| 21:37:28 | <djazayeri> wyclif: probably that way. I believe there are a couple of sprint tickets for improving the UI of this... |
| 21:37:42 | <wyclif> djazayeri, ok |
| 21:37:58 | <wyclif> djazayeri, it is getting tricky for me to test what am working on |
| 21:38:11 | <djazayeri> what are you working on? |
| 21:38:57 | <wyclif> djazayeri, viewing queued and reports in progress so that a user can cancel them |
| 21:39:46 | <djazayeri> ah yes, it'd be nice to be able to queue some. |
| 21:40:56 | <djazayeri> wyclif: see https://tickets.openmrs.org/browse/REPORT-312 |
| 21:41:18 | <djazayeri> wyclif: that ticket describes the cron expression format |
| 21:43:02 | <wyclif> djazayeri, cool that is what i need thanks! |
| 21:44:20 | *** downey has quit IRC |
| 21:45:45 | <wyclif> djazayeri, and if a report is being run, how do i cancel it, is there a single method on the service that does this? |
| 21:46:01 | <djazayeri> wyclif: no idea, I haven't looked at that code since mike added it |
| 21:46:09 | <wyclif> djazayeri, ok, will ask him |
| 21:46:34 | <wyclif> djazayeri, actually might be existent, to be added from TRUNK-337 |
| 21:46:58 | <wyclif> hi sgithens |
| 21:50:28 | *** dkayiwa has quit IRC |
| 21:53:12 | *** morristic has quit IRC |
| 22:34:20 | *** pulasthi7 has quit IRC |
| 22:45:11 | *** apurvmehra has joined #openmrs |
| 22:46:48 | *** apurvmehra has quit IRC |
| 22:52:12 | *** apurvmehra has joined #openmrs |
| 23:06:37 | <isharap> hi djazayeri i worked out that issue of comments, added the patch too. Thanks agn :) |
| 23:08:01 | *** isharap has quit IRC |
| 23:08:05 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: OpenMRS UI Framework 1.0-SNAPSHOT uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=uiframework&version=&1.0-SNAPSHOT> |
| 23:40:01 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: OpenMRS UI Framework 1.0 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=uiframework&version=&1.0> |
| 23:48:52 | *** mccallumg has quit IRC |
| 23:49:38 | *** wyclif has quit IRC |