00:13:58
|
*** lh has quit IRC
|
00:17:14
|
*** selvam1991 has quit IRC
|
01:06:21
|
*** wyclif has joined #openmrs
|
01:27:58
|
*** bwolfe has joined #openmrs
|
01:27:58
|
*** ChanServ sets mode: +o bwolfe
|
01:40:07
|
<r_friedman> bwolfe: ben, you there?
|
01:40:15
|
<bwolfe> no
|
01:40:27
|
<r_friedman> good, i wanted to say nasty things about you
|
01:40:49
|
<bwolfe> go ahead
|
01:41:01
|
<r_friedman> bwolfe: i think i am pretty close to understanding how to do what I want to do
|
01:42:42
|
<r_friedman> i've used @skipbasesetup and initializeInMemoryDatabase and executeDataSet with a dataset containing all tables, both base openmrs and module, and authenticate().
|
01:43:01
|
<r_friedman> The problem is that I can't come up with a username/password that authenticate will accept
|
01:43:44
|
<r_friedman> bwolfe: is @SkipBaseSetup an annotation to the test class or to each test method?
|
01:44:32
|
<bwolfe> each method
|
01:46:15
|
<r_friedman> bwolfe: ok, so why aren't my 2 superusers working (admin and roger)
|
01:51:52
|
<bwolfe> r_friedman, have you tried printing out the contents of the talbe to make sure you're operating against the right one?
|
01:52:13
|
<bwolfe> r_friedman, TestUtils.printTableContents(getConnection(), "users", "person");
|
01:52:24
|
*** suranga has joined #openmrs
|
01:52:24
|
*** ChanServ sets mode: +v suranga
|
01:54:04
|
<r_friedman> bwolfe: where is TestUtils?
|
01:55:39
|
<bwolfe> in openmrs
|
01:55:47
|
<bwolfe> type it and then push controls-shift-o in eclipse
|
01:55:48
|
<r_friedman> 1.8.x?
|
01:55:51
|
<bwolfe> it will find it for you
|
01:55:58
|
<bwolfe> or type it and push control-space
|
01:56:04
|
<bwolfe> 1.4+ I think
|
01:58:20
|
<r_friedman> Util is singular and it's printOutTableContents, but close enuf for govt work
|
01:58:56
|
<bwolfe> heh
|
01:59:03
|
<bwolfe> I told you I wasn't here :-p
|
02:00:23
|
*** mseaton has joined #openmrs
|
02:00:23
|
*** ChanServ sets mode: +v mseaton
|
02:00:33
|
*** mseaton has left #openmrs
|
02:01:29
|
*** harshadura has joined #openmrs
|
02:07:57
|
*** harshadura has quit IRC
|
02:08:14
|
*** harshadura has joined #openmrs
|
02:13:36
|
<r_friedman> bwolfe: helps not to have them retired. now it's stopped even asking me to authenticate -- and I didn't do anything to my runtime.properties
|
02:16:20
|
<bwolfe> r_friedman, do you have an admin/test user? it tries that by default
|
02:16:25
|
<bwolfe> only if that fails does it ask you
|
02:16:39
|
<bwolfe> there is also a RP for the test username and password if you don't want to type it
|
02:16:42
|
<r_friedman> bwolfe: yep yep
|
02:17:04
|
<r_friedman> bwolfe: tks much, gotta pack to leave Medellin for Cali tomorrow
|
02:17:24
|
<r_friedman> feel like an asshole sitting in a hotel room doing this shit so much
|
02:17:30
|
<bwolfe> I thought you were staying for the wedding...
|
02:17:44
|
<r_friedman> wedding is in Cali, I came a week early to visit Medellin
|
02:19:14
|
<bwolfe> oh, Cali != California...
|
02:19:23
|
<bwolfe> r_friedman, so you're visiting your hotel room? :-)
|
02:20:18
|
<r_friedman> bwolfe: well, it rained some yesterday and today, and last friday i had to take a day of rest because my feet were bloody from so much walking
|
02:20:54
|
<r_friedman> bwolfe: the real problem is i've been working in english on this shit and i came here to improve my spanish
|
02:21:16
|
<bwolfe> haha
|
02:21:46
|
<bwolfe> puedo escribir en espanol...
|
02:22:51
|
<r_friedman> haha i'm sure it would recognize PruebaUtil.escribaContenidosDeTabla
|
02:23:03
|
<bwolfe> that'd be awesome
|
02:23:14
|
<r_friedman> joaquim would come in his pants
|
02:23:19
|
<bwolfe> would make reading code 100x more difficult...
|
02:23:34
|
<r_friedman> hey, if it makes it more difficult, by all means let's do it
|
02:36:12
|
*** testdroider has left #openmrs
|
02:59:46
|
*** r_friedman has quit IRC
|
03:03:28
|
*** robbyoconnor has joined #openmrs
|
03:03:28
|
*** ChanServ sets mode: +v robbyoconnor
|
03:27:15
|
*** mseaton has joined #openmrs
|
03:27:15
|
*** ChanServ sets mode: +v mseaton
|
03:27:25
|
*** mseaton has left #openmrs
|
03:30:24
|
*** saimanohar has joined #openmrs
|
03:39:34
|
*** anu_GSOC has joined #openmrs
|
04:04:19
|
*** harshadura has quit IRC
|
04:08:54
|
*** anu_GSOC has quit IRC
|
04:12:37
|
*** selvam1991 has joined #openmrs
|
04:24:31
|
*** harshadura has joined #openmrs
|
04:29:49
|
*** selvam1991 has quit IRC
|
04:34:49
|
*** suranga has quit IRC
|
04:36:04
|
*** bwolfe has quit IRC
|
04:54:29
|
*** harshadura has quit IRC
|
04:57:29
|
*** manash_ has joined #openmrs
|
05:01:17
|
*** pushkar has joined #openmrs
|
05:42:19
|
*** morristic has joined #openmrs
|
06:00:25
|
*** manash_ has quit IRC
|
06:00:41
|
*** manash_ has joined #openmrs
|
06:16:53
|
*** manash_ has quit IRC
|
06:20:52
|
*** apurvtwr has joined #openmrs
|
06:24:04
|
*** harshadura has joined #openmrs
|
06:25:11
|
*** apurvtwr has quit IRC
|
06:42:13
|
*** selvam1991 has joined #openmrs
|
07:03:01
|
*** harshadura has quit IRC
|
07:05:51
|
*** bryq has joined #openmrs
|
07:05:51
|
*** ChanServ sets mode: +v bryq
|
07:09:43
|
*** upul` has joined #openmrs
|
07:09:43
|
*** ChanServ sets mode: +v upul`
|
07:14:05
|
*** selvam1991 has quit IRC
|
07:23:46
|
*** dkayiwa has joined #openmrs
|
07:25:48
|
*** bryq has quit IRC
|
07:43:36
|
*** maurya has joined #openmrs
|
07:53:29
|
*** anu_GSOC has joined #openmrs
|
07:54:11
|
*** maurya has quit IRC
|
07:54:56
|
*** maurya has joined #openmrs
|
07:59:09
|
*** pushkar has quit IRC
|
08:00:17
|
*** applecool has joined #openmrs
|
08:00:52
|
<applecool> hi dkayiwa
|
08:00:56
|
<applecool> didnt get any response from the implmenters list
|
08:00:58
|
<applecool> ;(
|
08:01:00
|
<dkayiwa> hi
|
08:01:15
|
<dkayiwa> applecool: i did not see your email on the implementers list
|
08:01:32
|
<dkayiwa> did you subscribe to it first?
|
08:01:49
|
<applecool> yes i did
|
08:02:05
|
<dkayiwa> i have not seen your email yet
|
08:02:08
|
<applecool> implementers@openmrs.org
|
08:02:24
|
<applecool> and i didnt even get an bounce
|
08:02:26
|
<applecool> mail
|
08:02:44
|
<dkayiwa> may be you resend
|
08:03:08
|
<applecool> just now resend it
|
08:03:21
|
<applecool> please can you check if got there in the mailing list
|
08:03:53
|
*** harshadura has joined #openmrs
|
08:05:24
|
*** snoppy has joined #openmrs
|
08:07:36
|
<dkayiwa> applecool: you may want to talk to Michael D about it
|
08:09:08
|
<applecool> wait
|
08:09:17
|
<applecool> now just check it again please
|
08:09:29
|
<applecool> i think i goofed up something yesterday
|
08:10:10
|
<applecool> got a confirmation now
|
08:10:24
|
<applecool> did you receive the mail on implementers list
|
08:10:29
|
<applecool> dkayiwa:
|
08:12:28
|
<dkayiwa> not yet
|
08:15:54
|
<applecool> this is an email which i got from list servr
|
08:15:56
|
<applecool> Your subscription to the OpenMRS Implementers' mailing list has been accepted. To send e-mail to OpenMRS Implementers: <mailto:implementers@openmrs.org>
|
08:18:22
|
*** selvam1991 has joined #openmrs
|
08:20:35
|
<applecool> i got confirmation mail , and then send it again , did you get the mail now dkayiwa
|
08:21:00
|
<dkayiwa> applecool: it takes some minutes to get it
|
08:29:05
|
<maurya> dkayiwa: hi,when i'm downloading htmlformentry.omod from module repository, i'm getting 1.9 as the version , but when i'm downloading the sourcecode from svn htmlformentry/trunk, i'm getting 1.7.4
|
08:29:57
|
*** mvorobey has joined #openmrs
|
08:30:03
|
<dkayiwa> maurya: i think htmlformentry was changed to git
|
08:30:08
|
<mvorobey> hi all
|
08:33:21
|
*** applecool has quit IRC
|
08:33:21
|
*** maurya has quit IRC
|
08:35:16
|
*** maurya has joined #openmrs
|
08:36:47
|
<maurya> dkayiwa: okay,can you please give me the git url?
|
08:37:13
|
<dkayiwa> maurya: can you check on the htmlformentry sprint page?
|
08:38:23
|
<maurya> thank you:)
|
08:39:07
|
*** anu_GSOC has quit IRC
|
08:42:16
|
*** applecool has joined #openmrs
|
08:43:07
|
<applecool> hi mvorobey
|
08:57:05
|
*** suranga has joined #openmrs
|
08:57:05
|
*** ChanServ sets mode: +v suranga
|
08:57:06
|
*** upul` has quit IRC
|
08:57:47
|
*** anu_GSOC has joined #openmrs
|
08:58:26
|
<suranga> hi... anyone familiar with HISP india online today ? :)
|
09:24:02
|
<dkayiwa> applecool: i finally saw your email on the implementers list
|
09:24:21
|
<dkayiwa> applecool: i think you would have addressed it to the implementers instead of AMPATH
|
09:24:35
|
<applecool> Oh
|
09:24:38
|
<dkayiwa> applecool: infact i have never seen AMPATH ask for such a feature :)
|
09:24:54
|
<applecool> should i change it
|
09:24:55
|
<dkayiwa> applecool: but seen lost of others like Evelyn, etc ask for it
|
09:25:17
|
<applecool> did nt get you
|
09:25:35
|
<dkayiwa> applecool: looks like you addressed it to AMPATH only
|
09:25:59
|
<applecool> no its not that
|
09:26:07
|
<dkayiwa> applecool: some users may not respond since they are not part of AMPATH
|
09:26:09
|
<applecool> it is only to get their ideas
|
09:26:21
|
<applecool> oh then should i change the content
|
09:26:36
|
<dkayiwa> applecool: but AMPATH guys have never asked for such a feature
|
09:26:45
|
<applecool> i know
|
09:26:51
|
<applecool> shall i resend the m ail
|
09:26:56
|
<dkayiwa> applecool: in otherwards, you are restricting it to only AMPATH ideas
|
09:27:20
|
<applecool> ok got it
|
09:27:23
|
<dkayiwa> applecool: it should be to all implementers
|
09:27:29
|
<applecool> ok
|
09:27:36
|
<applecool> will resend one more mail
|
09:27:40
|
<applecool> should i ?
|
09:28:08
|
<dkayiwa> applecool: in order not to spam the list, (since you have already sent twice) you can leave it at that
|
09:28:09
|
<applecool> i thought they would be the immediate users
|
09:28:17
|
<dkayiwa> applecool: and NOT send another
|
09:28:22
|
<applecool> :(
|
09:28:31
|
<applecool> ok '
|
09:28:35
|
<dkayiwa> applecool: they (AMPATH) may even never use that feature
|
09:28:50
|
<applecool> which means i wont get ideas from the other implementers
|
09:28:53
|
<dkayiwa> applecool: OpenMRS is not for AMPATH :)
|
09:29:00
|
<applecool> i know :(
|
09:29:11
|
<dkayiwa> applecool: some implementers may think you are only interested in AMPATH ideas
|
09:29:17
|
<applecool> yes i agree
|
09:30:50
|
<applecool> well what do i do now dkayiwa
|
09:33:25
|
<dkayiwa> applecool: wait and see what happens :)
|
09:35:00
|
<applecool> did i lose my chance of getting there
|
09:37:43
|
<dkayiwa> applecool: i do not think so :)
|
09:38:41
|
<applecool> do ade , burke , jeremy come on irc
|
09:55:22
|
<suranga> mmm... i hope u mean Ada* :-)
|
10:02:26
|
*** anu_GSOC has quit IRC
|
10:03:03
|
*** pm___ has joined #openmrs
|
10:04:41
|
*** maurya_ has joined #openmrs
|
10:05:51
|
*** maurya has quit IRC
|
10:08:46
|
*** maurya_ has quit IRC
|
10:12:06
|
*** applecool has quit IRC
|
10:14:30
|
<snoppy> hi all!
|
10:14:49
|
<snoppy> can I ask question abut using some of moduls?
|
10:15:44
|
<snoppy> Yesterday I installed Access Logging Module
|
10:16:21
|
<snoppy> It started succes. But I can't to use it because i have to errors.
|
10:16:32
|
<snoppy> *two
|
10:17:02
|
<snoppy> First error in such options as Query Access Log and Manage the Access Log. It's in "Attempt to redefine the prefix form.." : http://pastebin.com/bUKhCVgt
|
10:17:53
|
<snoppy> Second error in option Purge the Access Log. It's exception like "java.lang.ClassCastException" : http://pastebin.com/u9kwNB8a
|
10:19:21
|
<snoppy> can I create the ticket in project "Automated Error Reports"?
|
10:21:24
|
*** suranga has quit IRC
|
10:24:19
|
*** maurya has joined #openmrs
|
10:25:55
|
<dkayiwa> snoppy: can you first send the error to the dev list?
|
10:26:35
|
<mvorobey> hi, snoppy, I think you need to wait while bwolfe, djazayeri or MarkG will be available in this IRC room. Now it is about 5 AM in US so they are probably sleeping :) but dkayiwa is right, you need to sent it to devs mailing list
|
10:27:23
|
<snoppy> ok
|
10:27:43
|
<dkayiwa> mvorobey: actually we want to discourage the practice of waiting for others. we want knowledge transfer throught the community :)
|
10:28:32
|
<dkayiwa> mvorobey: you and me or some body else other than Ben, Darius, MarkG should be able to help him :D
|
10:29:31
|
<dkayiwa> mvorobey: snoppy So no more waiting of US wake up time to ask questions. :D
|
10:29:58
|
<mvorobey> dkayiwa, you are right :)
|
10:30:12
|
<dkayiwa> snoppy: you did the right thing to start by asking here at IRC :)
|
10:30:13
|
*** morristic has joined #openmrs
|
10:30:36
|
<snoppy> okey. I understand)
|
10:30:52
|
<dkayiwa> snoppy: after getting no solution here, next step is dev list where all that are not on IRC can be found :)
|
10:38:00
|
<snoppy> tnx. sended.
|
10:40:44
|
*** bryq has joined #openmrs
|
10:40:44
|
*** ChanServ sets mode: +v bryq
|
10:54:00
|
*** pm___ has quit IRC
|
10:54:36
|
*** maurya has quit IRC
|
10:55:31
|
*** mvorobey has quit IRC
|
10:56:40
|
*** pm___ has joined #openmrs
|
10:59:26
|
*** magiclko has joined #openmrs
|
11:01:11
|
*** pm___ has quit IRC
|
11:02:20
|
*** pm___ has joined #openmrs
|
11:08:18
|
*** pm___ has quit IRC
|
11:43:09
|
*** james_regen has joined #openmrs
|
11:43:09
|
*** ChanServ sets mode: +v james_regen
|
11:43:29
|
*** bwolfe has joined #openmrs
|
11:43:29
|
*** ChanServ sets mode: +o bwolfe
|
11:51:13
|
*** opieng2 has joined #openmrs
|
11:52:37
|
*** morristic has quit IRC
|
11:58:10
|
*** wyclif has quit IRC
|
12:01:49
|
*** allen_ has joined #openmrs
|
12:02:15
|
*** allen_ is now known as Guest76057
|
12:03:22
|
<magiclko> Hi everyone, just wondering does openMRS has something related to survey management? I mean, like patients can give some sort of satisfaction survey or admin can ask few questions regarding how good they are or something like that?
|
12:03:40
|
*** Guest76057 has quit IRC
|
12:06:09
|
<magiclko> oh, and if not, how often is this thing requested? ;)
|
12:14:06
|
*** dkayiwa has quit IRC
|
12:17:50
|
*** raju_ has joined #openmrs
|
12:21:18
|
<bwolfe> magiclko, there is no module that does that that I know of
|
12:21:33
|
<bwolfe> magiclko, I also haven't heard it as a request. but it seems like a common enough task.
|
12:21:47
|
<bwolfe> have you looked through the module repository to see if anything like that exists?
|
12:21:49
|
<bwolfe> !modules
|
12:21:49
|
<OpenMRSBot> bwolfe: "modules" --- http://openmrs.org/wiki/Modules
|
12:21:51
|
<bwolfe> !modulerepo
|
12:21:52
|
<OpenMRSBot> bwolfe: Error: "modulerepo" is not a valid command.
|
12:21:55
|
<bwolfe> !modulerepository
|
12:21:56
|
<OpenMRSBot> bwolfe: Error: "modulerepository" is not a valid command.
|
12:22:07
|
<bwolfe> !learn modulerepository as http://modules.openmrs.org
|
12:22:07
|
<OpenMRSBot> bwolfe: The operation succeeded.
|
12:23:54
|
<magiclko> bwolfe : i did, couldn't find anything of this sort
|
12:24:17
|
*** raju_ has quit IRC
|
12:24:24
|
*** dkayiwa has joined #openmrs
|
12:27:07
|
<magiclko> bwolfe: well considering i'm a GSoC aspirant, what do you think about it as a project idea?
|
12:27:43
|
<bwolfe> I think its a good project idea and you should add it as a comment on the unassigned projects page at http://projects.openmrs.org .... BUT
|
12:28:34
|
<bwolfe> as a gsoc project, it is not good. we only have a certain number of mentors and those are already claiming projects they either proposed or have been proposed for a while by community requests
|
12:28:46
|
<bwolfe> a project without a mentor is dead in the water.
|
12:29:20
|
<bwolfe> you're welcome to propose it and apply for it, but I would suggest also applying for one of our projects that already has a mentor as well
|
12:29:23
|
<bwolfe> !bwolfesays
|
12:29:23
|
<OpenMRSBot> bwolfe: "bwolfesays" --- FYI to all potential GSoC Applicants: OpenMRS welcomes multiple applications for multiple projects within openmrs. Actually, we encourage it! Sometimes we get quality students only applying to a low priority project. So pick a few projects that interest you, apply to all of them, and put comments in them saying which other ones you've applied to
|
12:29:28
|
<bwolfe> !bwolfealsosays
|
12:29:28
|
<OpenMRSBot> bwolfe: "bwolfealsosays" --- To greatly increase your chances of getting accepted by openmrs you should demonstrate your knowledge/skills in both java and potentially openmrs. The best way to do that is to finish a few small tickets. Type !trivialtickets and !introtickets for links to some that we have defined.
|
12:29:38
|
<magiclko> yeah, i have read those ones ;)
|
12:29:44
|
<bwolfe> (had to throw in my standard GSoC text as well) :-)
|
12:30:11
|
<magiclko> hehe, i'll add it anyway. Maybe next year this might interest some mentors or maybe after this years GSoC, i might do it ;)
|
12:30:26
|
<bwolfe> magiclko, https://answers.openmrs.org/questions/369/how-to-implement-satisfaction-surveys-for-patients-in-openmrs
|
12:31:45
|
<magiclko> bwolfe : i did see it, but i think it's a bit different
|
12:32:16
|
<bwolfe> not too much different. :-)
|
12:32:34
|
<magiclko> that's one to one conversation,
|
12:33:07
|
<magiclko> while this one is like a general survey thing.
|
12:35:52
|
<magiclko> and well, last year i was a GSoC student for a survey organisation(LimeSurvey), so i think it shouldn't be that difficult to integrate both :)
|
12:38:41
|
<magiclko> but anyway, i can see a lot of challenging projects already listed on soc project idea page, will definately look into those ;)
|
12:41:03
|
*** nribeka has joined #openmrs
|
12:41:03
|
*** ChanServ sets mode: +v nribeka
|
12:48:52
|
*** downey has joined #openmrs
|
12:48:52
|
*** ChanServ sets mode: +o downey
|
12:48:53
|
*** OpenMRSBot sets mode: +o downey
|
12:51:18
|
*** mvorobey has joined #openmrs
|
12:51:23
|
*** harshadura has quit IRC
|
12:52:00
|
*** mseaton has joined #openmrs
|
12:52:00
|
*** ChanServ sets mode: +v mseaton
|
12:54:36
|
*** mseaton1 has joined #openmrs
|
12:55:05
|
*** mseaton1 has left #openmrs
|
12:55:27
|
*** mseaton1 has joined #openmrs
|
12:55:38
|
*** mseaton1 has left #openmrs
|
12:55:40
|
*** pm_ has joined #openmrs
|
12:55:44
|
*** mseaton1 has joined #openmrs
|
12:55:47
|
<downey> Hi pm_ and welcome to the #openmrs IRC channel.
|
12:55:48
|
*** isharapremadasa has joined #openmrs
|
12:55:56
|
<downey> Hi isharapremadasa and welcome to the #openmrs IRC channel.
|
12:56:14
|
*** harshadura has joined #openmrs
|
12:56:36
|
<isharapremadasa> thank you very much, this is my first time here
|
12:57:35
|
*** mseaton has quit IRC
|
12:58:00
|
<downey> isharapremadasa: thanks for joining us
|
12:58:44
|
<isharapremadasa> Hi, i hope to apply for GSoC this year, can i use this chat to get more information regarding that?
|
12:59:15
|
<downey> isharapremadasa: sure. also be sure to first read http://go.openmrs.org/soc2012
|
13:00:28
|
<isharapremadasa> yes, i first read all the details given in the ideas page.
|
13:00:44
|
<downey> isharapremadasa: great
|
13:01:05
|
<isharapremadasa> i could build the system correctly so now i am trying to fix some introductiry tickets
|
13:01:15
|
<isharapremadasa> that is where i need some info
|
13:01:17
|
<isharapremadasa> :)
|
13:02:45
|
<isharapremadasa> do we need to add a comment and inform others that i have started working on it?
|
13:02:58
|
<isharapremadasa> i mean in addition to assign the ticket to myself
|
13:03:28
|
<downey> isharapremadasa: all you need to do is click the "claim issue" button
|
13:03:37
|
<downey> isharapremadasa: that will mark it as "in progress" and assign it to yourself
|
13:03:39
|
*** sunbiz has joined #openmrs
|
13:03:39
|
*** ChanServ sets mode: +v sunbiz
|
13:04:30
|
*** r1friedman has joined #openmrs
|
13:05:29
|
<isharapremadasa> yes i did that. Also i need to know that if i have some questions regarding the ticket, which is the best way to ask it ?
|
13:05:32
|
*** r1friedman is now known as r_friedman
|
13:05:47
|
<isharapremadasa> is it sending a mail to the thread or adding a comment in ticket?
|
13:06:31
|
<downey> isharapremadasa: you could try asking here, or maybe contact the person who created the issue, or if all else fails write to our developer mailing list
|
13:09:24
|
<isharapremadasa> err... actually im afraid i did the reverse, i have to clarify some things with TICKET-248, i first sent a mail to dev list
|
13:09:46
|
*** anu_GSOC has joined #openmrs
|
13:09:49
|
<isharapremadasa> will it be fine if i add a comment there also with my qusetion now?
|
13:10:04
|
<downey> isharapremadasa: sure, if you like you can do that
|
13:10:59
|
<isharapremadasa> sure i will do it, hope that i will get it cleared soon :)
|
13:11:33
|
<isharapremadasa> Thanks a lot for helping me!
|
13:15:40
|
<downey> isharapremadasa: no problem
|
13:19:17
|
<mvorobey> mseaton1, hi Mike
|
13:19:53
|
<mseaton1> hi mvorobey (am i mseaton1 now? how did i manage to do that?)
|
13:20:19
|
<mvorobey> mseaton1, I do not know :)
|
13:20:39
|
<mvorobey> mseaton1, Today I woke up, opened calculation sprint dashboard and was pleasantly surprised - no tickets available :) that is great, does that mean that we will have module released till to sprint end?
|
13:22:11
|
<mseaton1> mvorobey - means that the sprint is finishing a bit early yes. not sure if we will actually release the module this week - will need to discuss with others. thanks for all of your help with the sprint - it made a huge difference!
|
13:22:11
|
*** sgithens has quit IRC
|
13:23:53
|
*** sgithens has joined #openmrs
|
13:24:12
|
*** mseaton1 has left #openmrs
|
13:24:19
|
*** mseaton1 has joined #openmrs
|
13:24:36
|
<mvorobey> mseaton1, don't mention it :) You have done 7 tickets against 4 of mine :) You are sprint winner of sorts :)
|
13:24:59
|
<mseaton1> smoke and mirrors
|
13:25:13
|
*** mseaton1 has quit IRC
|
13:25:44
|
<dkayiwa> mvorobey: did you scare away mseaton1? :)
|
13:26:01
|
<mvorobey> dkayiwa, :D nope?
|
13:26:04
|
<mvorobey> nope
|
13:26:09
|
<dkayiwa> :D
|
13:26:49
|
<mvorobey> dkayiwa, today IRC is fighting against Mike :)
|
13:27:44
|
*** mseaton has joined #openmrs
|
13:27:47
|
<dkayiwa> mvorobey: hahahahaha
|
13:27:50
|
*** ChanServ sets mode: +v mseaton
|
13:28:40
|
*** mseaton has left #openmrs
|
13:28:55
|
<mvorobey> dkayiwa, again we lost him :)
|
13:29:16
|
<dkayiwa> oh men!!!!! :)
|
13:29:41
|
<mvorobey> do'nt mention it :)
|
13:29:53
|
<mvorobey> do'nt = don't
|
13:30:00
|
<dkayiwa> :D
|
13:30:08
|
<mvorobey> life is weird :)
|
13:30:19
|
<dkayiwa> and more so for mseaton :)
|
13:30:33
|
<mvorobey> dkayiwa,: :D
|
13:30:49
|
<mvorobey> dkayiwa: :D hahahaah
|
13:31:05
|
<dkayiwa> :)
|
13:36:04
|
*** wyclif has joined #openmrs
|
13:37:54
|
*** mseaton has joined #openmrs
|
13:37:54
|
*** ChanServ sets mode: +v mseaton
|
13:38:30
|
<mseaton> wyclif, are you on?
|
13:38:56
|
<wyclif> mseaton, sure
|
13:39:30
|
<mseaton> i'm going to start looking over the calculation module a bit more holistically today, to review the structure, packaging, etc
|
13:39:41
|
<wyclif> mseaton, ok
|
13:40:45
|
<mseaton> you don't have much uncommitted, correct?
|
13:42:25
|
<wyclif> none
|
13:42:56
|
<wyclif> besides the tests you recommended when checking parameter values and datatypes
|
13:43:18
|
<wyclif> mseaton, and am just adding them now\
|
13:43:21
|
<wyclif> do we plan to release it this week?
|
13:47:32
|
<mseaton> wyclif - see my recent email. i think i'd prefer to review with burke and darius when they are back from vacation
|
13:48:22
|
*** applecool has joined #openmrs
|
13:48:24
|
<wyclif> mseaton, sounds fine
|
13:48:31
|
<applecool> dkayiwa: hi
|
13:49:39
|
<dkayiwa> hi applecool
|
13:50:20
|
<applecool> just solved a bug-2976
|
13:50:35
|
<applecool> though it was a minor one ;)
|
13:50:47
|
<mseaton> wyclif: how do you feel about removing a bunch of sub-packages that only have 1-2 classes or interfaces in them?
|
13:51:16
|
<mseaton> (eg. util, validator, provider...)
|
13:51:37
|
<dkayiwa> applecool: ok thats good :) better than nothing
|
13:52:01
|
<applecool> :)
|
13:52:15
|
<wyclif> mseaton, am fine if it makes sense to put them in another
|
13:52:49
|
*** optieng has joined #openmrs
|
13:52:59
|
<downey> Hi optieng and welcome to the #openmrs IRC channel.
|
13:53:11
|
<mseaton> wyclif - i waffle between what is best. normally i like sub-packages. in this case, because we are building a framework with very little actual implementation classes, it feels nicer to have more in the top-level api to me
|
13:53:26
|
<wyclif> mseaton, ok
|
13:53:38
|
<optieng> downey, hi
|
13:53:43
|
<mseaton> ah, you're so agreeable wyclif!
|
13:54:06
|
*** optieng has quit IRC
|
13:54:09
|
<wyclif> mseaton, ha ha ha
|
13:54:10
|
*** opieng2 has quit IRC
|
13:54:15
|
*** opieng1 has quit IRC
|
13:54:20
|
*** opieng has quit IRC
|
13:54:33
|
*** opieng has joined #openmrs
|
13:54:47
|
<downey> Hi opieng and welcome to the #openmrs IRC channel.
|
13:56:06
|
<wyclif> mseaton, about your comment to test List<Location>, do you mean if the datatype is java.util.List and i pass in a List<Location?>
|
13:56:16
|
*** applecool has quit IRC
|
13:56:54
|
<mseaton> no, i mean if the datatype is the string "List<Location>", regardless of what you pass in, this should not fail just because List<Location> cannot be cast to a class
|
13:57:03
|
*** MarkG has joined #openmrs
|
13:57:10
|
<mseaton> wyclif
|
13:58:10
|
<wyclif> ok, i will add the test, i think if i cant load the class, i let the evaluation continue with the assumption the dev will know how to resolve it
|
13:58:31
|
<mseaton> yes, the code looks like it does this correctly. just wanted a test to confirm
|
13:58:39
|
<wyclif> ok
|
13:59:04
|
*** maurya has joined #openmrs
|
13:59:18
|
<maurya> hi sunbiz
|
13:59:38
|
<maurya> just send you an email regarding the Upload file html enhancement
|
13:59:47
|
*** snoppy has quit IRC
|
14:00:01
|
<sunbiz> hi maurya
|
14:00:28
|
*** pushkar has joined #openmrs
|
14:00:31
|
<sunbiz> maurya: I dont seem to see that email
|
14:00:35
|
<sunbiz> when did u send it??
|
14:00:43
|
<maurya> oh i have send you on gmail account
|
14:00:45
|
<maurya> now
|
14:01:12
|
<pushkar> hi r_friedman
|
14:01:26
|
<pushkar> i have send you a mail regarding the hr module
|
14:01:37
|
<pushkar> did you get any chance to see it
|
14:03:15
|
<r_friedman> hi pushkar, I haven't seen it yet, I'm flying today and am mostly packed up
|
14:03:31
|
<pushkar> oh ok
|
14:03:55
|
<r_friedman> pushkar, could you forward to my name here with . instead of _ @mindspring.com?
|
14:04:00
|
<pushkar> so maybe tomorrow we can discuss about it
|
14:04:16
|
<sunbiz> maurya: got it now...
|
14:04:24
|
<sunbiz> will respond sometime later
|
14:04:34
|
<maurya> sure i will be online sunbiz
|
14:04:58
|
<pushkar> you want me to forward it to the mindspring mail id
|
14:05:00
|
<pushkar> r_friedman:
|
14:05:18
|
<r_friedman> yes please
|
14:06:14
|
<pushkar> sent you may get it by now :)
|
14:06:17
|
<pushkar> r_friedman:
|
14:06:30
|
*** maurya_ has joined #openmrs
|
14:07:08
|
*** maurya_ has quit IRC
|
14:09:19
|
<wyclif> mseaton, am going to commit the test, so you might need to update again if you are still refactoring things
|
14:09:19
|
<maurya> mseaton: can i discuss the loggin errors in database with you now
|
14:09:32
|
<mseaton> wyclif - please svn update first
|
14:09:36
|
<mseaton> maurya sure
|
14:09:43
|
<wyclif> mseaton, i have already and picked your changes
|
14:09:51
|
*** pm_ has quit IRC
|
14:10:13
|
<r_friedman> pushkar, I have not received it, did you replace the _ with . ?
|
14:10:28
|
<pushkar> i guess no let me do it
|
14:10:37
|
<mseaton> wyclif - ok, but just committed again.
|
14:11:13
|
<wyclif> got the second too
|
14:12:30
|
<pushkar> r_friedman: can you please check the private message
|
14:12:51
|
*** sunbiz has left #openmrs
|
14:12:55
|
<maurya> i was just wondering the two tables you have included in the design
|
14:13:23
|
<mseaton> wyclif - great. got your changes too
|
14:13:37
|
<maurya> are they getting populated currently , in the Haiti implementation
|
14:15:03
|
<wyclif> goog
|
14:15:06
|
<wyclif> good
|
14:19:15
|
*** isharapremadasa is now known as ishara
|
14:20:42
|
*** dawn_ has joined #openmrs
|
14:21:35
|
*** ChanServ sets mode: +v dawn_
|
14:21:36
|
<mseaton> maurya, yes
|
14:21:45
|
<wyclif> r_friedman, did you get the test passing?
|
14:21:58
|
<mseaton> but maurya, the existing one is not openmrs
|
14:22:27
|
<downey> MarkG & sgithens - any chance i can bribe you to put up a profile photo on the wiki?
|
14:22:38
|
<maurya> sorry mseaton didnt get you '
|
14:22:47
|
<r_friedman> wyclif: nope
|
14:23:02
|
<r_friedman> wyclif, I have no problem with that table in jetty
|
14:23:12
|
<sgithens> downey: Which wiki? The openmrs wiki, or a google code one?
|
14:23:32
|
<downey> sgithens: openmrs :)
|
14:23:33
|
<wyclif> r_friedman, i have got some time, so am going to look at it in the next couple of minutes
|
14:23:46
|
<mseaton> maurya: in our legacy haiti application, we are logging exceptions to database tables like the ones described on the project page. however, this is not built on openmrs, it is a different technology we use for that project (pre-dates openmrs)
|
14:23:52
|
<r_friedman> downey, why don't you just put up one of your choice, if they don't like it they can change it
|
14:23:58
|
<wyclif> r_friedman, what problem are you running in now?
|
14:24:47
|
<maurya> but we can use the same technology in Openmrs too right ?
|
14:25:08
|
<MarkG> downey: sure, not a problem
|
14:25:17
|
<r_friedman> wyclif: when I try to executeDataSet I get a table does not exist for jsslab_test
|
14:25:25
|
<pushkar> r_friedman: did you get my mail now
|
14:25:36
|
<r_friedman> pushkar, yes I have responded
|
14:25:46
|
<pushkar> oh i didnt check that
|
14:26:03
|
<MarkG> downey: i will pull one off my home computer and do it tonight...
|
14:26:35
|
<sgithens> downey: cool, I'll find something to upload
|
14:26:49
|
*** ishara is now known as isharap
|
14:26:52
|
<downey> thanks gentlemen :)
|
14:27:05
|
<wyclif> r_friedman, will look at it
|
14:27:18
|
<r_friedman> wyclif: i am holding my breath
|
14:27:50
|
<downey> !beerme r_friedman
|
14:27:50
|
* OpenMRSBot slides r_friedman a pint
|
14:28:48
|
<wyclif> r_friedman, ok
|
14:29:14
|
* r_friedman is holding his breath, so cannot drink beer
|
14:29:23
|
<downey> straw?
|
14:29:29
|
<pushkar> oh it would be great talking to you see you then
|
14:29:47
|
<r_friedman> downey: intravenous
|
14:30:02
|
<isharap> Hi MarkG, i would like to know more details about project, HTML Form Entry Module Enhancements
|
14:30:14
|
<isharap> can i have your mail address for that?
|
14:30:16
|
<dawn_> !scrumon dawn
|
14:30:16
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready.
|
14:30:24
|
<MarkG> isharap: sure...
|
14:30:24
|
<dawn_> Hi Team! Scrum time :)
|
14:30:30
|
<dawn_> Today's order: bwolfe , dkayiwa , mvorobey , wyclif , mseaton
|
14:30:46
|
<MarkG> isharap: it is mgoodrich@pih.org
|
14:31:07
|
*** harshadura has quit IRC
|
14:31:11
|
*** apurvtwr has joined #openmrs
|
14:31:21
|
*** pushkar has quit IRC
|
14:31:22
|
<isharap> MarkG, thanks will send you mail today :)
|
14:31:33
|
*** ChanServ sets mode: +v dkayiwa
|
14:31:33
|
<dawn_> bwolfe: are you ready?
|
14:31:46
|
<bwolfe> scrum time already?
|
14:32:02
|
<dkayiwa> :)
|
14:32:06
|
*** ChanServ sets mode: +v mvorobey
|
14:32:12
|
*** ChanServ sets mode: +v wyclif
|
14:32:12
|
* bwolfe is not ready
|
14:32:23
|
* bwolfe blames it on chopin
|
14:32:23
|
<dkayiwa> Done some 1.9 ticket administration
|
14:32:24
|
<dkayiwa> Committed: Standalone should allow choosing expert or demo mode when run with -commandline option - STAND-46
|
14:32:24
|
<dkayiwa> Now reviewing the pending 1.9 RC tickets
|
14:32:24
|
<dkayiwa> No Blockers
|
14:32:25
|
*** ChanServ sets mode: +v MarkG
|
14:32:37
|
<dawn_> mvorobey: your turn :)
|
14:32:46
|
<mvorobey> * Some paperwork with wiki pages for In-page localization tool
|
14:32:57
|
<mvorobey> * No blokers
|
14:33:08
|
<dawn_> wyclif: your turn :)
|
14:33:14
|
*** ChanServ sets mode: +v r_friedman
|
14:33:21
|
*** ChanServ sets mode: +v sgithens
|
14:33:25
|
<wyclif> tuesday:
|
14:33:25
|
<wyclif> * code review (CALC-28)
|
14:33:25
|
<wyclif> * Renamed Results, made other minor code refactorings
|
14:33:25
|
<wyclif> * update module documentation with the above changes and other recent changes in the module
|
14:33:25
|
<wyclif> * complete CALC-25 - Add a check to enforce ParameterDefinition datatypes
|
14:33:25
|
<wyclif> today:
|
14:33:27
|
<wyclif> * Address review comment for CALC-25
|
14:33:29
|
<wyclif> * Work on 1.9 tickets
|
14:33:31
|
<wyclif> Blockers: none
|
14:33:54
|
<dawn_> mseaton: then bwolfe :)
|
14:34:01
|
*** isharap has quit IRC
|
14:34:18
|
<mseaton> Yesterday:
|
14:34:18
|
<mseaton> !ticket CALC-30
|
14:34:18
|
<mseaton> !ticket CALC-28
|
14:34:18
|
<mseaton> !ticket CALC-17
|
14:34:18
|
<mseaton> Today:
|
14:34:19
|
<mseaton> * Reviewing codebase, moving around way more files than I ought to
|
14:34:19
|
<mseaton> * Preparing for reporting sprint
|
14:34:20
|
<OpenMRSBot> mseaton: [#CALC-30] Provide a feature to test a calculation registration against one or more patients - OpenMRS JIRA - https://tickets.openmrs.org/browse/CALC-30
|
14:34:21
|
<OpenMRSBot> mseaton: [#CALC-28] Allow CalculationProviders to auto-register tokens, but make it user-initiated - OpenMRS JIRA - https://tickets.openmrs.org/browse/CALC-28
|
14:34:22
|
<OpenMRSBot> mseaton: [#CALC-17] Refactor reporting module to expose its functionality to the calculation module - OpenMRS JIRA - https://tickets.openmrs.org/browse/CALC-17
|
14:34:38
|
<mseaton> not blocked
|
14:35:12
|
<dawn_> bwolfe: your turn
|
14:35:24
|
<bwolfe> today:
|
14:35:25
|
<bwolfe> investigate TRUNK-3153, logic not starting
|
14:35:25
|
<bwolfe> univ call...for 10 mins, no one called in :-(
|
14:35:25
|
<bwolfe> TRUNK-3162, portuguese translation
|
14:35:25
|
<bwolfe> investigate messaging options for atom feed project
|
14:35:25
|
<bwolfe> help mseaton set up next week's sprint? otherwise, 1.9 or 1.10 tickets
|
14:35:27
|
<bwolfe> design call
|
14:35:29
|
<bwolfe> (lack of) pm call
|
14:35:31
|
<bwolfe> done
|
14:35:39
|
<mseaton> do we have a design call?
|
14:35:51
|
*** james_regen1 has joined #openmrs
|
14:36:12
|
<bwolfe> it'll be limited on the openmrs side :-/
|
14:36:18
|
<dawn_> !scrumoff dawn
|
14:36:18
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
14:37:02
|
<maurya> but we can use the same technology in Openmrs too right ?
|
14:37:17
|
<dawn_> dkayiwa: and bwolfe it was mentioned that rafal hasn't committed the dataset yet. Is that a blocker for us?
|
14:37:28
|
<dkayiwa> dawn_: no
|
14:37:39
|
<dkayiwa> dawn_: though would be good to have :)
|
14:38:09
|
<bwolfe> maurya, who was that question directed at?
|
14:38:16
|
<mseaton> maurya: sure, of course
|
14:38:18
|
<maurya> so you mean to say that we dont have that implemented in openmrs but would like to have a feature in Openmrs now ?
|
14:38:23
|
*** james_regen has quit IRC
|
14:38:24
|
<mseaton> right :)
|
14:38:53
|
<maurya> bwolfe: it was for mseaton sorry didnt address it earlier
|
14:39:09
|
* bwolfe scrolled up and found it. thanks
|
14:39:39
|
<bwolfe> dkayiwa, so we don't want the mvp stuff for 1.9.0 ? have we ever promised that? Or did we already tell people we'd put that in 1.9.1 ?
|
14:39:57
|
<dkayiwa> bwolfe: am not sure if we had promissed :)
|
14:40:40
|
<dkayiwa> bwolfe: but i think rafa is done with it
|
14:40:49
|
<dkayiwa> bwolfe: i think he just forgot to commit :)
|
14:41:45
|
<dawn_> dkayiwa: thanks! :)
|
14:42:18
|
<dkayiwa> dawn_: thanks for??? :)
|
14:42:39
|
<maurya> mseaton: might be restricted on only those parts of a stack trace that provide useful, actionable information only this part would be a bit tricky rest everything mentioned in wiki can be done easily
|
14:42:48
|
<dawn_> dkayiwa: for answering my question :)
|
14:43:24
|
*** harshadura has joined #openmrs
|
14:43:45
|
<mseaton> maurya: maybe identify any lines containing org.openmrs in the stack trace or some other smart matching
|
14:44:34
|
<dkayiwa> dawn_: oh i see :)
|
14:46:30
|
<dawn_> :D
|
14:47:34
|
<maurya> mseaton: so can i send you the action plan for this
|
14:49:13
|
<wyclif> mseaton, dont forget the change the class names in the module application context and the provider class in the test data
|
14:49:37
|
<mseaton> wyclif. right, thanks. will do that now.
|
14:54:23
|
*** dawn_ has quit IRC
|
14:56:04
|
<anu_GSOC> MarkG:hi :)
|
14:56:31
|
<MarkG> anu_GSOC: hello
|
14:57:22
|
<anu_GSOC> MarkG:I see your comment there.For that Nullpointer exception.As a quik check I have included the error line in a try catch block.
|
14:58:06
|
<anu_GSOC> MarkG:HtmlFormSchemaController.java:68
|
14:58:21
|
*** maurya has quit IRC
|
14:58:33
|
<MarkG> anu_GSOC: okay... you marked the ticket as unable to reproduce... did you mean to do that?
|
14:59:34
|
*** dawn_ has joined #openmrs
|
14:59:35
|
*** ChanServ sets mode: +v dawn_
|
15:00:02
|
<anu_GSOC> MarkG:no
|
15:00:31
|
<anu_GSOC> MarkG:It worked for you?
|
15:00:50
|
<MarkG> anu_GSOC: yes, it worked for me
|
15:02:39
|
<anu_GSOC> MarkG:Then what could posibbly be cause that exception?
|
15:03:04
|
*** dawn_ has quit IRC
|
15:03:26
|
*** r_friedman has quit IRC
|
15:05:10
|
*** saimanohar has joined #openmrs
|
15:08:07
|
*** apurvtwr has quit IRC
|
15:08:32
|
*** finbrein has joined #openmrs
|
15:09:16
|
*** maurya has joined #openmrs
|
15:09:31
|
<maurya> Hi MarkG
|
15:09:57
|
<MarkG> anu_GSOC: it looks like in your case it is possible that the module was unable to load the html form properly? i'm not quite sure why that would be happening?
|
15:10:10
|
<MarkG> hi maurya
|
15:10:42
|
<maurya> i was looking at the HTMLForm entry module to see how are the tags getting created and rendered
|
15:11:44
|
*** finbrein has quit IRC
|
15:12:08
|
<maurya> and got the hang off encounterProvider and datebeing rendered , validated and stored
|
15:12:32
|
<MarkG> maurya: sounds good
|
15:12:41
|
<maurya> i would be intrested in implementing HTML Form Entry Module Enhancements for this year
|
15:12:56
|
*** Jibesh has joined #openmrs
|
15:12:59
|
<maurya> so wanted to discuss few things with you
|
15:14:23
|
<maurya> do we have to create only two tags
|
15:14:28
|
*** Jibesh has left #openmrs
|
15:14:39
|
<maurya> or some more would be added when we get on the project
|
15:14:45
|
<maurya> MarkG:
|
15:15:44
|
<maurya> MarkG: In the current tags they have included the drop down and you want it to ajaxify them ?
|
15:16:04
|
<maurya> MarkG: for autocomplete
|
15:20:35
|
<maurya> MarkG: also i didnt get "Dynamic Abilitiy to remove required status" mentioned in the extra credit
|
15:25:32
|
<MarkG> maurya: for the dropdown, yes, we want to allow the option of a jquery-style autocomplete instead of a drop-down... this would assumedly use ajax (but it might not have to)
|
15:26:35
|
<MarkG> maurya: for "dynamic ability to remove required status" there is a JIRA ticket associated with it (and most of the features) I will add links to those tickets to the project page
|
15:26:53
|
<maurya> MarkG: that would be good
|
15:26:58
|
<maurya> MarkG:
|
15:30:05
|
<maurya> i also saw a mail from Ranjib regarding the HTML-50
|
15:30:31
|
<maurya> MarkG: would that be included as extra credit
|
15:34:16
|
<MarkG> maurya: re: HTML-50... I still need to figure that out
|
15:34:31
|
<MarkG> maurya: i also added all the links to the tickets to the project page
|
15:39:11
|
*** maurya has quit IRC
|
15:44:26
|
*** suranga has joined #openmrs
|
15:44:26
|
*** ChanServ sets mode: +v suranga
|
15:49:43
|
*** snoppy has joined #openmrs
|
15:51:12
|
*** bwolfe has quit IRC
|
15:58:00
|
*** kavuri has joined #openmrs
|
16:01:02
|
*** pm_ has joined #openmrs
|
16:04:12
|
<mseaton> wyclif?
|
16:04:19
|
<wyclif> hi mseaton
|
16:05:13
|
*** maurya has joined #openmrs
|
16:05:34
|
<mseaton> do we need to make any changes to core or logic to remove logic as a core module?
|
16:06:23
|
<wyclif> as far as i know that is what we agreed on
|
16:06:41
|
<wyclif> calculation becomes the core module and logic ceases to be a core module
|
16:06:53
|
<mseaton> i don't think we'll have any core modules
|
16:06:58
|
<mseaton> both are optional
|
16:07:24
|
<mseaton> to start with
|
16:07:40
|
<wyclif> why was logic a core module?
|
16:08:40
|
<wyclif> mseaton, because if we are dropping it, then there have to be changes on core to be made
|
16:08:46
|
<mseaton> well, the idea was that it would be part of core but separated out into a module so that it could potentially have a quicker upgrade path
|
16:09:06
|
<mseaton> i don't think anything in core depends on it. if it does, then yes, that will need to be changed. i'll make a core ticket now
|
16:09:57
|
*** pm_ has quit IRC
|
16:10:18
|
*** bwolfe has joined #openmrs
|
16:10:18
|
*** ChanServ sets mode: +o bwolfe
|
16:11:00
|
<wyclif> mseaton, ok
|
16:11:15
|
<mseaton> !ticket TRUNK-3169
|
16:11:16
|
<OpenMRSBot> mseaton: [#TRUNK-3169] Remove Logic Module as a core module - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3169
|
16:15:16
|
*** bwolfe has quit IRC
|
16:20:01
|
*** maurya has quit IRC
|
16:22:33
|
*** pm_ has joined #openmrs
|
16:24:22
|
<wyclif> mseaton, where do you want the @Transactional in the module, The service or dao layer? i think we trying to come up with a convention in core
|
16:25:15
|
<mseaton> wyclif i defer to rafal. serviceimpl or hibernatedao is fine
|
16:26:36
|
<wyclif> mseaton, they are in HIbernateDAO
|
16:26:50
|
<mseaton> wyclif, works for me
|
16:27:03
|
<mseaton> better for performance i think
|
16:28:53
|
<wyclif> ok
|
16:29:57
|
*** pm_ has quit IRC
|
16:32:03
|
*** pulasthi7 has joined #openmrs
|
16:32:13
|
<downey> Hi pulasthi7 and welcome to the #openmrs IRC channel.
|
16:34:24
|
*** magiclko1 has joined #openmrs
|
16:36:11
|
*** magiclko has quit IRC
|
16:36:18
|
*** magiclko1 is now known as magiclko
|
16:41:47
|
*** mvorobey_ has joined #openmrs
|
16:41:47
|
*** mvorobey has quit IRC
|
16:42:17
|
*** mvorobey__ has joined #openmrs
|
16:42:22
|
<downey> Hi mvorobey__ and welcome to the #openmrs IRC channel.
|
16:42:43
|
*** pm_ has joined #openmrs
|
16:42:58
|
*** mvorobey_ has quit IRC
|
16:43:54
|
<mvorobey__> downey, hi downey :) glad to here your greetings in my address :)
|
16:44:02
|
<downey> :)
|
16:44:07
|
<downey> thanks____
|
16:44:22
|
*** mvorobey__ is now known as mvorobey
|
16:44:33
|
<mvorobey> that is more correct
|
16:44:56
|
<mvorobey> I meant nickname without _____ of course :)
|
16:52:27
|
*** heydlind has joined #openmrs
|
16:52:37
|
<downey> Hi heydlind and welcome to the #openmrs IRC channel.
|
16:55:41
|
<mseaton> wyclif. i'm done w/ my refactoring of packages. have a few questions to address later. you'll need to modify your logic integration to reflect the new packaging.
|
16:56:18
|
<mseaton> wyclif - happy to discuss decisions i made further if you disagree. will be back in a bit...
|
16:56:41
|
*** heydlind has quit IRC
|
17:07:56
|
*** dave_r has quit IRC
|
17:08:02
|
<wyclif> mseaton, sorry i was having lunch
|
17:08:17
|
<wyclif> mseaton, i have actually done that
|
17:08:34
|
*** gauravpaliwal has joined #openmrs
|
17:08:34
|
*** ChanServ sets mode: +v gauravpaliwal
|
17:09:23
|
<gauravpaliwal> downey: ping !!
|
17:09:50
|
*** bwolfe has joined #openmrs
|
17:09:50
|
*** ChanServ sets mode: +o bwolfe
|
17:10:07
|
<gauravpaliwal> bwolfe: ping
|
17:10:22
|
<bwolfe> pong
|
17:10:31
|
<gauravpaliwal> bwolfe:haha, If some student ping us on IM , should we ask them to use IRC or reply to them on IM ?
|
17:10:45
|
<gauravpaliwal> bwolfe: :D
|
17:10:54
|
<bwolfe> all general/public questions should be in irc or the dev list
|
17:11:04
|
<bwolfe> some private questions are ok in IM
|
17:11:36
|
<gauravpaliwal> bwolfe: private :P
|
17:11:37
|
<gauravpaliwal> :D
|
17:14:46
|
<downey> gauravpaliwal: hi, sorry
|
17:15:01
|
<downey> gauravpaliwal: what bwolfe said. :)
|
17:15:46
|
<gauravpaliwal> downey: thanks :)
|
17:22:30
|
*** pulasthi7 has quit IRC
|
17:23:03
|
*** pulasthi7 has joined #openmrs
|
17:24:36
|
*** apurvtwr has joined #openmrs
|
17:25:34
|
*** pm_ has quit IRC
|
17:25:43
|
*** apurvtwr has left #openmrs
|
17:27:58
|
*** harshadura has quit IRC
|
17:28:03
|
*** MarkG1 has joined #openmrs
|
17:31:50
|
*** MarkG has quit IRC
|
17:33:11
|
*** apoorvarao has joined #openmrs
|
17:33:25
|
<downey> Hi apoorvarao and welcome to the #openmrs IRC channel.
|
17:36:07
|
<apoorvarao> Hi :) I'm interested in working on the HR module. Can you give me a few pointers on how to start?
|
17:36:55
|
<gauravpaliwal> apoorvarao: who is your mentor ?
|
17:37:09
|
<gauravpaliwal> apoorvarao: I mean probable mentor for project ?
|
17:37:20
|
<apoorvarao> Roger Friedman
|
17:38:25
|
<gauravpaliwal> apoorvarao: cool, then do you know his IRC nick ?
|
17:39:15
|
<apoorvarao> No.
|
17:39:30
|
<apoorvarao> Have you worked on OpenMRS before?
|
17:39:55
|
<gauravpaliwal> apoorvarao: yes
|
17:41:07
|
<apoorvarao> I'm new to it. How do I get his IRC nick? It's not in his profile.
|
17:42:13
|
<gauravpaliwal> downey: do you know Roger Friedman IRC nick ?
|
17:42:43
|
*** selvam1991 has quit IRC
|
17:43:30
|
*** selvam1991 has joined #openmrs
|
17:44:07
|
<apoorvarao> gauravpaliwal: Thank you! :)
|
17:46:07
|
*** selvam1991 has quit IRC
|
17:47:53
|
<suranga> gauravpaliwal, rfriedman, isnt he ?
|
17:48:37
|
<gauravpaliwal> apoorvarao : try rfriedman suranga: thanks :)
|
17:49:58
|
*** selvam1991 has joined #openmrs
|
17:53:58
|
*** chopin has joined #openmrs
|
17:54:41
|
<chopin> suranga
|
17:54:49
|
*** ChanServ sets mode: +v chopin
|
17:55:28
|
<suranga> hi chopin
|
17:55:35
|
<apoorvarao> gauravpaliwal: rfriedman does not exist :(
|
17:55:37
|
<suranga> i seem to have caused a buggie :-(
|
17:55:56
|
<suranga> I just re created using the regenstrief server
|
17:56:05
|
<suranga> NOW I see the error chopin :-(
|
17:56:12
|
<chopin> suranga, just committed the fix to foreign keys
|
17:56:30
|
<chopin> suranga, but we still get duplicated strategies after editing
|
17:56:42
|
<chopin> suranga, we really should just reference the id instead of the name when calling it up
|
17:56:57
|
<chopin> because more than one strategy can have the same name
|
17:56:58
|
<chopin> (at this time)
|
17:57:08
|
<chopin> suranga, we should have unit tests ;-)
|
17:57:24
|
<chopin> (i added a few for PTM-49 but they are not committed yet)
|
17:57:39
|
<suranga> hi chopin mm.. do u mean u solved the problem ? wow
|
17:57:47
|
<suranga> i didnt quite get you im afraid ...
|
17:58:07
|
<chopin> suranga, i fixed the error i was getting (could not load a strategy to edit it)
|
17:58:19
|
<chopin> but now when i save the changed strategy, it creates a new one
|
17:58:23
|
<chopin> so now i have two with the same name
|
17:58:35
|
<chopin> and then when i go to edit it, i will get yet another error
|
17:58:42
|
<chopin> because it cannot pull just one by its name
|
17:58:50
|
<chopin> that is why we need to use configurationId as the parameter
|
17:58:51
|
<chopin> for editing
|
17:58:54
|
<suranga> chopin, mm... I did add a check in the controller and the sql to stop that...
|
17:59:00
|
<chopin> and a simple DAO method to get it
|
17:59:10
|
<chopin> suranga, it didn't stop me ;-)
|
17:59:29
|
*** nribeka has quit IRC
|
17:59:45
|
<suranga> chopin, agreed, we need to make the change... Im now trying to re create using mmy local machine, then I can start fixin...
|
17:59:52
|
<chopin> it actually does not need very much effort in the service and dao layers to just pull an object for editing
|
18:00:07
|
<chopin> suranga, update to latest for my HBM.XML files
|
18:00:16
|
<chopin> then you can just create one strategy, then try to edit it
|
18:00:23
|
<chopin> save it again
|
18:00:24
|
*** finbrein has joined #openmrs
|
18:00:25
|
<chopin> you will see
|
18:00:26
|
<chopin> :-D
|
18:01:48
|
<suranga> chopin, im wondering if this is possibly because I deleted all my tables and created them again, while you guys did the correct thing by merely upgrading on the changeset :)
|
18:01:55
|
<suranga> bad bad /me !
|
18:02:04
|
<chopin> haha
|
18:02:07
|
<chopin> it's fine
|
18:02:09
|
<chopin> at least it worked
|
18:02:10
|
<chopin> for me
|
18:02:51
|
<chopin> but still, you should be able to click "edit" for one that exists, try to save it and then see two of them
|
18:02:58
|
<chopin> with the same name
|
18:03:37
|
<apoorvarao> gauravpaliwal: Is there any way to find out Rodger Friedman's Nick?
|
18:03:43
|
<suranga> chopin, I will check that out...
|
18:03:52
|
<chopin> apoorvarao: r_friedman
|
18:03:54
|
<gauravpaliwal> apoorvarao: may be email ?
|
18:03:58
|
<chopin> apoorvarao, or some variation of it
|
18:04:04
|
<suranga> apoorvarao, freidman is not logged in right now.. he may come back later....
|
18:04:50
|
*** bwolfe has quit IRC
|
18:05:10
|
*** bwolfe has joined #openmrs
|
18:05:10
|
*** ChanServ sets mode: +o bwolfe
|
18:05:51
|
*** anu_GSOC has quit IRC
|
18:09:41
|
<apoorvarao> gauravpaliwal: His email address is not disclosed. Thanks anyway :) I'll check here later.
|
18:10:07
|
<gauravpaliwal> apoorvarao: see this : (11:33:53 PM) chopin: apoorvarao: r_friedman
|
18:11:57
|
<apoorvarao> gauravpaliwal: That's not it either.
|
18:12:23
|
<gauravpaliwal> :(
|
18:13:07
|
<gauravpaliwal> apoorvarao: pinged u his email
|
18:13:14
|
<gauravpaliwal> and that is correct AFAIK :)
|
18:13:50
|
<gauravpaliwal> :D
|
18:28:21
|
*** apoorvarao has quit IRC
|
18:30:09
|
<chopin> suranga, if you need help let me know
|
18:30:34
|
<suranga> chopin, no worries, but one again, my apologies :(
|
18:31:26
|
*** pulasthi7 has quit IRC
|
18:33:38
|
*** pm_ has joined #openmrs
|
18:43:42
|
<suranga> chopin, I think I theee the putty cat !
|
18:43:50
|
<suranga> chopin, i mean the error :)
|
18:44:05
|
<suranga> the unique constraint i set on the db was not getting set !
|
18:44:30
|
<downey> o.O
|
18:45:34
|
*** nribeka has joined #openmrs
|
18:45:34
|
*** ChanServ sets mode: +v nribeka
|
18:46:40
|
<suranga> downey, maybe IRC logs are a bad idea... it keeps a record of my ignorance :)
|
18:47:14
|
<downey> suranga: :) think twice before "enter"
|
18:50:16
|
<chopin> suranga, hahaa
|
18:50:21
|
<chopin> suranga, okay
|
18:50:41
|
<chopin> suranga, still ... i have a feeling that making name unique will not allow us to save
|
18:50:47
|
<chopin> something elemental is wrong with the editing
|
18:51:13
|
<suranga> chopin, I agree
|
18:51:18
|
<suranga> and also on the tesr cases
|
18:51:38
|
<suranga> my plan was to give ada something to test on... and then work on moving to IDs
|
18:52:00
|
<suranga> I guess having unique names is not going to hurt us, would it ?
|
18:52:40
|
<suranga> chopin, initially, I was using lists, but then switched to sets. In between, something went haywire :)
|
18:53:27
|
<chopin> suranga, it's just very easy to use IDs
|
18:53:36
|
<chopin> suranga, so i see a lot of deleted lines rather than new ones ;-)
|
18:53:40
|
<chopin> suranga, in your future
|
19:02:16
|
*** mvorobey has quit IRC
|
19:05:38
|
*** bwolfe has quit IRC
|
19:06:40
|
*** bwolfe has joined #openmrs
|
19:06:40
|
*** ChanServ sets mode: +o bwolfe
|
19:09:48
|
*** dave_r has joined #openmrs
|
19:11:23
|
*** gautam has joined #openmrs
|
19:11:29
|
<downey> Hi gautam and welcome to the #openmrs IRC channel.
|
19:12:32
|
<dave_r> Hi downey, could you help me with the rest web services?
|
19:13:36
|
<downey> dave_r: My guess is someone here could help you out. What's happening?
|
19:14:44
|
<dave_r> well, i'm having a hard time creating a patient. Initially my JSON payload was incorrect, but I think I've fixed it, but now I'm getting an exception in the DAO layer: http://pastebin.com/J2MUBj1b
|
19:15:18
|
<dave_r> when I look at the code, it fails on this line: query.setInteger("idType", patientIdentifier.getIdentifierType().getPatientIdentifierTypeId());
|
19:17:32
|
<dave_r> I have been providing the UUID because that what the web services are giving me, but it seems this method is looking for the id. but I don't see that as a property from the web services. i'm wondering if there is something I need to add?
|
19:19:59
|
<downey> bwolfe: ^
|
19:20:28
|
* bwolfe reads
|
19:21:32
|
<bwolfe> dave_r, where is that line?
|
19:21:38
|
<bwolfe> what class/line number?
|
19:22:47
|
*** james_regen1 has left #openmrs
|
19:27:42
|
*** gauravpaliwal has left #openmrs
|
19:35:01
|
*** gautam has quit IRC
|
19:38:07
|
*** pm_ has quit IRC
|
19:38:46
|
*** magiclko has quit IRC
|
19:42:32
|
<dave_r> ok,nvm i got it. my apologies, after look at the unit tests I see my JSON structure was wrong, now working as expected :)
|
19:43:10
|
*** dkayiwa_ has joined #openmrs
|
19:43:28
|
*** dkayiwa has quit IRC
|
19:43:29
|
*** dkayiwa_ is now known as dkayiwa
|
19:45:07
|
<dave_r> is there a wiki page for the JSON structure that should be sent?
|
19:46:43
|
<dave_r> i originally was using the response JSON as my template, but I guess that will not work for creation
|
19:46:48
|
*** dkayiwa has quit IRC
|
19:51:49
|
*** selvam1991 has quit IRC
|
19:52:15
|
*** selvam1991 has joined #openmrs
|
19:54:19
|
*** dkayiwa has joined #openmrs
|
19:58:19
|
*** finbrein has quit IRC
|
20:06:19
|
<bwolfe> dave_r, I don't think we have a json structure page.
|
20:07:11
|
<bwolfe> dave_r, there is an examples page with some example POSTs
|
20:07:16
|
*** chopin has quit IRC
|
20:15:59
|
*** nribeka has quit IRC
|
20:22:35
|
<dave_r> ok
|
20:26:56
|
*** simosx has joined #openmrs
|
20:27:01
|
<downey> Hi simosx and welcome to the #openmrs IRC channel.
|
20:27:21
|
<simosx> thanks auto-downey ;-)
|
20:27:27
|
<downey> :D
|
20:29:53
|
*** sunbiz has joined #openmrs
|
20:29:53
|
*** ChanServ sets mode: +v sunbiz
|
20:37:27
|
*** panagiotes has joined #openmrs
|
20:37:41
|
<downey> Hi panagiotes and welcome to the #openmrs IRC channel.
|
20:38:28
|
<panagiotes> hello there
|
20:39:34
|
<panagiotes> i have seen your application openMRS, i have installed the war and it works
|
20:40:13
|
<panagiotes> I would like to participate in the framework of the GSoC 2012 in your project
|
20:40:24
|
<panagiotes> So far I have got a problem
|
20:40:38
|
*** bwolfe has quit IRC
|
20:41:13
|
<panagiotes> with the downloading of the app in the eclipse ide
|
20:42:16
|
<panagiotes> it seems that it downloads the app from the svn
|
20:43:00
|
<panagiotes> but i get an error: time out for the retrieve f a context.jar
|
20:43:12
|
*** sunbiz has quit IRC
|
20:44:24
|
<panagiotes> and when it finises downloading the app the are errors in 2 of the projects
|
20:45:27
|
<panagiotes> however it builds the app and produces a war with the maven build selection from run as ... menu
|
20:49:12
|
<panagiotes> the produced war works fine
|
20:50:10
|
<panagiotes> have you got any idea for the errors? it seems that there is a problem with the dependences
|
20:51:00
|
<downey> hmm, not possible to say without specific messages. could be a networking issue, but might be nothing
|
20:51:27
|
<panagiotes> i checked build path and project facets
|
20:51:35
|
<panagiotes> everuthing seems ok
|
20:52:15
|
<panagiotes> one of the hilights is in aclass of the com.sun pakages
|
20:53:22
|
<panagiotes> from which i think we should not be using its classes normally
|
20:53:35
|
*** wyclif has quit IRC
|
20:54:45
|
*** dkayiwa has quit IRC
|
20:55:32
|
<suranga> panagiotes, I think u r referring to the first comment on this link https://wiki.openmrs.org/display/docs/Step+by+Step+Installation+for+Developers
|
20:55:33
|
<OpenMRSBot> <http://ln-s.net/8_PW> (at wiki.openmrs.org)
|
20:56:29
|
<panagiotes> Yes i red this document
|
20:56:38
|
<panagiotes> and i applyed all steps
|
20:58:24
|
*** mseaton has left #openmrs
|
20:58:33
|
<suranga> panagiotes, the errors u get, are they from the webapp project ?
|
20:59:54
|
<panagiotes> i use m2e 1.x which separate projects for modules or Support multiple maven modules
|
21:00:09
|
<suranga> since your errors dont seem to be interferring with the build, I was thinking that u may be referring to the errors u get from the jsps in the webapp folder...
|
21:00:43
|
<panagiotes> yes the most are in the webapp project
|
21:01:09
|
<panagiotes> but the are also errors in the tools project
|
21:02:00
|
* suranga goes to look.......
|
21:08:55
|
<panagiotes> i have also tried to download the app using STS but i got more errors there
|
21:09:22
|
<panagiotes> from 3 projects, webapp tools and an other
|
21:10:14
|
<panagiotes> one
|
21:10:38
|
<panagiotes> i used STS 2.9.0
|
21:20:38
|
<panagiotes> in the eclipse indigo i got errors in 2 projects, tools and webapp
|
21:25:06
|
*** nribeka has joined #openmrs
|
21:25:06
|
*** ChanServ sets mode: +v nribeka
|
21:25:49
|
*** bryq has quit IRC
|
21:27:39
|
*** nribeka has quit IRC
|
21:29:25
|
*** r0friedman has joined #openmrs
|
21:29:27
|
<panagiotes> i am installing the whole thing from the begging now
|
21:29:43
|
*** r0friedman is now known as r_friedman
|
21:30:20
|
<panagiotes> after the installation of the openmrs modules and the restart i got the following message:
|
21:32:01
|
<panagiotes> The OpenMRS Dependency installer has encountered an error, remote version 1.4.X while local 1.6.18
|
21:32:07
|
* r_friedman is checking his connection
|
21:33:34
|
* r_friedman 's connection sucks
|
21:39:28
|
<r_friedman> snoppy: moscow is no match for madrid, but referee is keeping them in
|
21:45:20
|
<snoppy> r_friedman:what are you talking about?)
|
21:45:48
|
<snoppy> football?))
|
21:46:02
|
<r_friedman> snoppy: csk moscow v. real madrid on now, 9 minutes left, 1-0 RM
|
21:48:36
|
<snoppy> oh...moscow win?
|
21:49:17
|
<snoppy> lucky)
|
21:50:02
|
<r_friedman> no, real madrid winning, now 5 mins left
|
21:50:30
|
<snoppy> )
|
21:52:13
|
<snoppy> r_friedman: anyway Shakhtar the Best!:-D
|
21:52:38
|
<r_friedman> are they in UEFA?
|
21:54:58
|
<snoppy> It was the chempion of UEFA
|
21:57:24
|
<snoppy> I don't football fan))) but as I know it is the last winner of UEFA
|
21:57:48
|
<r_friedman> snoppy, moscow just scored with less than a minute left in extra time
|
21:58:48
|
*** simosx has quit IRC
|
22:00:42
|
<snoppy> 1:1?
|
22:00:59
|
*** downey has quit IRC
|
22:01:27
|
<snoppy> Lol=) Losers)
|
22:03:31
|
<snoppy> r_friedman: results of previous match was 4:1?
|
22:04:15
|
<r_friedman> snoppy, i only follow mexican league
|
22:05:01
|
<r_friedman> plus spain
|
22:05:06
|
<snoppy> ok)
|
22:05:10
|
<r_friedman> sometimes, and ghana
|
22:05:50
|
<r_friedman> everybody in ghana follows Prmier League, so when I'm going there I have to keep up with that
|
22:12:06
|
*** r_friedman has quit IRC
|
22:12:09
|
<snoppy> real football fan) for some reason I don't like this game, although I was played it. I like more bascketball )
|
22:12:22
|
*** snoppy has left #openmrs
|
22:20:51
|
*** selvam1991 has quit IRC
|
22:21:24
|
*** selvam1991 has joined #openmrs
|
22:31:41
|
*** dave_r has quit IRC
|
22:35:51
|
*** selvam1991 has quit IRC
|
22:39:49
|
*** selvam1991 has joined #openmrs
|
22:47:23
|
*** MarkG1 has quit IRC
|
22:47:48
|
*** MarkG has joined #openmrs
|
22:50:06
|
*** wyclif has joined #openmrs
|
22:51:48
|
*** suranga has quit IRC
|
22:52:05
|
*** MarkG has quit IRC
|
22:57:33
|
*** r8friedman has joined #openmrs
|
22:57:53
|
*** r8friedman is now known as r_friedman
|
22:58:01
|
<r_friedman> wyclif: hi, u there?
|
22:59:10
|
*** lh has joined #openmrs
|
22:59:33
|
*** lh has joined #openmrs
|
23:19:16
|
<wyclif> hi r_friedman
|
23:19:34
|
<r_friedman> hi wycliff, any luck?
|
23:20:51
|
<r_friedman> hi wyclif any luck?
|
23:21:07
|
<r_friedman> don't know why i always spell your name with 2 fs
|
23:22:47
|
<wyclif> r_friedman, i emailed u
|
23:24:14
|
<r_friedman> wyclif: i have checked both my e-mails and haven't received it
|
23:24:58
|
<r_friedman> wyclif, could you resend it to my username here with . instead of _ @mindspring.com
|
23:25:10
|
<wyclif> r_friedman, sent to r.friedman@openmrs.org
|
23:25:42
|
<r_friedman> wyclif: if i have an account at openmrs.org I'm unaware of it
|
23:26:17
|
<wyclif> r_friedman, In DeltaLabOrderServiceTest, they are failing because jsslab_test rows are commented out in the test datasets, so liquibase doesn't create the table if there are no rows added to it.
|
23:26:17
|
<wyclif> Questions:
|
23:26:17
|
<wyclif> Why do you have two different datasets?
|
23:26:17
|
<wyclif> Why are you having all those rows in your test data, why not just add only the rows specific to the module and use the standard dataset in core for the others?
|
23:26:18
|
<wyclif> FYI, everything worked for me when i uncommented the jsslab_test rows
|
23:26:59
|
<r_friedman> wyclif: because i need some additional rows in openmrs tables and that didn't work
|
23:27:09
|
<wyclif> but the files are too big and they take memory
|
23:27:52
|
<r_friedman> wyclif: do you think my problem could be running out of memory?
|
23:27:59
|
<wyclif> r_friedman, still you can add them but just adding the rows you need
|
23:28:54
|
<wyclif> dont add unnecessary data to the file
|
23:30:06
|
<r_friedman> wyclif: I'll give that a try. But I'm more concerned about why jsslab_test worked for you but not for me
|
23:30:29
|
*** selvam1991 has quit IRC
|
23:35:12
|
<wyclif> r_friedman, i said it is because the rows for that table are commented out in test dataset, uncomment them
|
23:35:44
|
<r_friedman> wyclif, they were commented out because they were causing an error
|
23:36:03
|
<r_friedman> wyclif: every time i ran with them uncommented, i got the table does not exist error
|
23:36:07
|
<wyclif> r_friedman, then you need to fic them
|
23:36:16
|
<r_friedman> wyclif: fix what?
|
23:36:22
|
<wyclif> r_friedman, it is the other wat round
|
23:36:34
|
<wyclif> commenting them causes the problem
|
23:36:40
|
<wyclif> u need to uncomment them
|
23:36:43
|
<wyclif> that is what i did
|
23:36:53
|
<wyclif> and why do u have 2 datasets
|
23:37:59
|
<r_friedman> wyclif: when i run it uncommented, i get the error
|
23:38:27
|
<r_friedman> i have 2 datasets because one contains only the records i need and the other contains the standard test data plus the records i need
|
23:39:49
|
<r_friedman> wyclif: i just ran only the records i need, uncommented, and got the table does not exist error
|
23:40:20
|
*** carloshpf has joined #openmrs
|
23:40:43
|
<r_friedman> wyclif: if you think it is a memory issue, tell me what type of memory i need to increase
|
23:42:40
|
*** kavuri has quit IRC
|
23:42:42
|
<wyclif> r_friedman, i would sayget rid of one
|
23:43:06
|
<wyclif> r_friedman, i have never seen anyone do this
|
23:43:23
|
<r_friedman> wyclif: i only run one of them, i don't run them both
|
23:43:26
|
<wyclif> r_friedman, remove all the rows and maintain those the tables in your module
|
23:43:43
|
<r_friedman> wyclif: that doesn't work, i need to create concepts and locations etc.
|
23:43:48
|
<wyclif> r_friedman, eitherway, they are taking up too much memory for no reason
|
23:44:00
|
<wyclif> there is a testdataset from core, just use that
|
23:44:08
|
<r_friedman> wyclif: they don't take up any memory if they're not loaded
|
23:44:18
|
<wyclif> r_friedman, remove that annotation @SkipTestdata
|
23:44:33
|
<r_friedman> wyclif: i just told you that i ran only the records i needed (the delta data)
|
23:44:37
|
<r_friedman> and still got the error
|
23:44:40
|
<wyclif> r_friedman, my point is that u dont need to do that
|
23:44:51
|
<r_friedman> i don't need to do what?
|
23:45:01
|
<r_friedman> and you are wrong about @SkipTestData
|
23:45:20
|
<wyclif> r_friedman, to include those extra rows like concept, location etc
|
23:45:38
|
<r_friedman> if i don't put in @SkipTestData, then I can't add data to the openmrs tables
|
23:45:52
|
<r_friedman> wyclif, they are part of the data model, they've got to be there
|
23:45:55
|
<wyclif> r_friedman, you are extendind moduleContextsentive test and that comes with that data by defaeult
|
23:46:24
|
<wyclif> r_friedman, so adding them again s un necessary
|
23:46:38
|
<r_friedman> wyclif, it comes with the standard test data, but i can't add any records to those tables
|
23:47:00
|
<r_friedman> that is why i did skiptestdata and put the test data in with my data
|
23:47:20
|
<wyclif> r_friedman, to add your own just include rows in your customDataset
|
23:47:35
|
<r_friedman> but what i just did was put in only those records in openmrs tables that i need (the delta data) and still got the error
|
23:48:03
|
<wyclif> r_friedman, and that is bad practice
|
23:48:04
|
<r_friedman> wycliff, i'm sorry, maybe we should stop working together, but i have done what you said many times and it doesn't work
|
23:49:08
|
<wyclif> r_friedman, it worked for me, but i had trouble becaeuse of memory issues and they were taking long to execute
|
23:50:03
|
<r_friedman> wyclif: what memory issues did you have? did you get error messages? and mine weren't taking a long time, just a couple of seconds to load
|
23:50:14
|
<wyclif> r_friedman, anyways you can do it the way you wish, it is just that when d it the way others do it, some can easily help when things are similar
|
23:50:50
|
<wyclif> r_friedman, anyways you can do it the way you wish, it is just that when you do it the way others do it, someone can easily help when things are similar
|
23:50:51
|
*** lh has quit IRC
|
23:51:09
|
<wyclif> r_friedman, and it could be the reason you get these errors
|
23:51:41
|
<r_friedman> wyclif, I went over this with Ben, and he said it should work
|
23:51:47
|
<wyclif> r_friedman, ok
|
23:52:14
|
<r_friedman> wyclif, it would be helpful if you told me how you knew there were memory problems
|
23:54:55
|
<wyclif> r_friedman, am running tring out the tests just to make sure that things are working for me
|
23:57:35
|
<r_friedman> wyclif: don't expect the laborder one to work, it has a problem deep in Hibernate, but the labspecimen one did work for me with the large custom dataset and lab_test commented out
|
23:59:02
|
<wyclif> r_friedman, what is the name of the specimen one
|
23:59:55
|
<r_friedman> wyclif: getLabSpecimenByUuid_shouldGetByUuid() in LabOrderServiceTest
|