| 01:10:35 | *** anu_GSOC has joined #openmrs |
| 01:45:04 | *** anu_GSOC has quit IRC |
| 01:45:37 | *** anu_GSOC has joined #openmrs |
| 01:55:16 | *** anu_GSOC has quit IRC |
| 01:56:06 | *** anu_GSOC has joined #openmrs |
| 02:11:24 | *** anu_GSOC has quit IRC |
| 02:52:59 | *** sgithens has joined #openmrs |
| 03:04:44 | *** harshadura has quit IRC |
| 03:21:16 | *** harshadura has joined #openmrs |
| 03:25:07 | *** dmexs has quit IRC |
| 03:38:25 | *** sgithens has quit IRC |
| 04:12:32 | *** harshadura has quit IRC |
| 04:14:17 | *** bwolfe has quit IRC |
| 05:28:39 | *** upul` has joined #openmrs |
| 05:28:39 | *** ChanServ sets mode: +v upul` |
| 05:37:51 | *** suranga has joined #openmrs |
| 05:37:51 | *** ChanServ sets mode: +v suranga |
| 05:43:19 | *** bryq has joined #openmrs |
| 05:43:19 | *** ChanServ sets mode: +v bryq |
| 05:45:13 | *** bryq has quit IRC |
| 06:34:59 | *** goutham has joined #openmrs |
| 06:37:02 | *** dkayiwa has joined #openmrs |
| 06:43:47 | *** tinashe has joined #openmrs |
| 06:46:32 | *** tinashe has left #openmrs |
| 07:19:13 | *** suranga has quit IRC |
| 07:48:07 | *** dkayiwa has quit IRC |
| 07:52:33 | *** batkinson has joined #openmrs |
| 08:02:38 | *** r0bby has quit IRC |
| 08:09:29 | *** ibewes has joined #openmrs |
| 08:11:33 | <ibewes> does OpenMRS have any built-in workflow engine or a module that does the same? |
| 08:12:33 | <ibewes> also, hello all! |
| 08:34:21 | *** tinashe has joined #openmrs |
| 08:34:50 | <tinashe> Hi OpenMRS... |
| 08:35:06 | *** bryq has joined #openmrs |
| 08:35:06 | *** ChanServ sets mode: +v bryq |
| 08:35:12 | <ibewes> good morning, or whatever it is where you are :) |
| 08:36:10 | <tinashe> Hi...Tinashe here...just got a question...I developed the Quickstats module...I just wanted to know if it is being put into use... |
| 08:38:23 | <tinashe> see the module is still not under modules.openmrs.org ... |
| 08:41:21 | <tinashe> anyone... |
| 08:41:31 | <upul`> tinashe: you can build and upload the module to the repository, isn't it |
| 08:42:03 | <tinashe> yes...but aint got permission and I am not organization bound atm... |
| 08:43:59 | <upul`> tinashe: I think you can create an account through id.openmrs.org |
| 08:44:47 | <upul`> ibewes: there's a workflow function described in here, https://wiki.openmrs.org/display/docs/Administering+Programs,+Workflows+and+States |
| 08:45:06 | <tinashe> Okay...will check with Ben if need is there to put it up the repo... |
| 08:47:17 | <tinashe> will check with Ben Later...cheers... |
| 08:47:29 | *** tinashe has left #openmrs |
| 09:01:24 | <ibewes> upul`: thanks... I'll check that out |
| 09:01:33 | *** robbyoconnor has joined #openmrs |
| 09:01:33 | *** ChanServ sets mode: +v robbyoconnor |
| 09:06:43 | *** bryq has quit IRC |
| 09:07:41 | <ibewes> upul`: so these are workflows that only operate under the context of a program? |
| 09:09:30 | *** bryq has joined #openmrs |
| 09:09:30 | *** ChanServ sets mode: +v bryq |
| 09:09:33 | <ibewes> what I'd like to find (rather than create) is something to support the workflow of a patient as they go through the hospital |
| 09:12:19 | <upul`> ibewes: I'm not familiar with this but you could create a program for hospital admittance. isn't it |
| 09:13:08 | <upul`> anyway you could get an expert view when bwolfe or somebody logs in |
| 09:14:19 | *** dkayiwa has joined #openmrs |
| 09:14:32 | <upul`> or dkayiwa |
| 09:14:40 | <ibewes> upul`: yeah, I am working on a team to create a HMIS with OpenMRS |
| 09:14:42 | <dkayiwa> upul`: |
| 09:15:12 | <ibewes> dkayiwa: I was asking about workflow engines within OpenMRS |
| 09:15:35 | <ibewes> specifically to support the workflow of a patient through a hospital or clinic |
| 09:15:45 | <dkayiwa> ibewes: not sure of what you mean by workflow engine :) |
| 09:16:23 | <ibewes> heh... yeah that's a pretty abstract term |
| 09:16:56 | <ibewes> I guess I just wondered if there we support for general workflows built into OpenMRS |
| 09:17:35 | <ibewes> ie, patient registers -> Nursing -> Clinical Visit -> lab, etc -> billing |
| 09:17:48 | <dkayiwa> ibewes: have you ever used openmrs? |
| 09:18:06 | <ibewes> just the demo sites and messing around with a local install |
| 09:18:20 | <ibewes> kinda fumbling around in the dark, quite honestly |
| 09:18:40 | <dkayiwa> ibewes: did you read the openmrs book? |
| 09:19:03 | <dkayiwa> ibewes: the getting started with openmrs? |
| 09:19:10 | <dkayiwa> http://en.flossmanuals.net/openmrs-guide/ |
| 09:19:36 | <ibewes> just started reading that today, I had been spending most of my time on the dev wiki |
| 09:20:11 | <dkayiwa> ibewes: ok |
| 09:21:27 | <ibewes> I take it that I'm missing some basic concepts... thus RTFM? |
| 09:21:49 | <dkayiwa> you will get them after reading |
| 09:22:00 | *** mvorobey has joined #openmrs |
| 09:22:13 | <mvorobey> hi all |
| 09:22:41 | <dkayiwa> hi mvorobey |
| 09:22:54 | <ibewes> ok, I'll read through that... so do you have any suggestions on concepts I'm obviously lacking? |
| 09:23:05 | <ibewes> right now I don't know what I don't know... heh |
| 09:24:06 | <dkayiwa> ibewes: after reading that, you will know what you dont and need to know :) |
| 09:26:39 | <ibewes> hah! That's the hope at least |
| 09:26:55 | <ibewes> thanks very much for your help... sorry to bother with such basic questions |
| 09:27:20 | <dkayiwa> ibewes: you are welcome. we are here to help one another :D |
| 09:27:49 | <ibewes> I look forward to knowing enough to help others ;) |
| 09:28:12 | <dkayiwa> ibewes: wowwwwwwww!!! thats so so so 8) |
| 09:28:50 | <dkayiwa> ibewes: even by the little you know today, there are plenty you can help :) |
| 09:32:01 | <ibewes> heh... sure doesn't feel like it. New to Java (since University), new to Eclipse, new to OpenMRS |
| 09:33:00 | <ibewes> after 15 years with MS dev (c# with Visual Studio) I feel like I'm in another country... interestingly enough I also am physically |
| 09:35:05 | *** mvorobey has quit IRC |
| 09:38:54 | *** mvorobey has joined #openmrs |
| 09:42:10 | *** bryq has quit IRC |
| 09:56:17 | *** bryq has joined #openmrs |
| 09:56:17 | *** ChanServ sets mode: +v bryq |
| 10:00:28 | *** bryq has quit IRC |
| 10:07:56 | *** bryq has joined #openmrs |
| 10:07:56 | *** ChanServ sets mode: +v bryq |
| 10:31:23 | <dkayiwa> ibewes: hahahaha. c# and java are cousins. :) |
| 10:37:16 | <ibewes> yup, so I'm speaking the same language, different dialect... heh |
| 10:45:13 | *** dkayiwa_ has joined #openmrs |
| 10:46:26 | *** dkayiwa has quit IRC |
| 10:46:28 | *** dkayiwa_ is now known as dkayiwa |
| 10:50:53 | *** bryq has quit IRC |
| 11:19:33 | *** bryq has joined #openmrs |
| 11:19:33 | *** ChanServ sets mode: +v bryq |
| 11:24:31 | *** james_regen has joined #openmrs |
| 11:24:31 | *** ChanServ sets mode: +v james_regen |
| 11:26:30 | *** cloud|windoze has joined #openmrs |
| 11:33:33 | *** upul` has quit IRC |
| 11:46:36 | *** dkayiwa has quit IRC |
| 12:03:08 | *** cloud|windoze has quit IRC |
| 12:04:12 | *** cloud|windoze has joined #openmrs |
| 12:05:22 | *** wyclif has quit IRC |
| 12:18:57 | *** bryq has quit IRC |
| 12:26:36 | *** cloud|windoze has quit IRC |
| 12:29:36 | *** cloud|windoze has joined #openmrs |
| 12:42:58 | *** dkayiwa has joined #openmrs |
| 12:51:45 | *** wyclif has joined #openmrs |
| 12:52:26 | *** downey has joined #openmrs |
| 12:52:26 | *** OpenMRSBot sets mode: +o downey |
| 12:52:39 | *** ChanServ sets mode: +o downey |
| 12:52:43 | *** bwolfe has joined #openmrs |
| 12:52:43 | *** ChanServ sets mode: +o bwolfe |
| 13:12:10 | *** dkayiwa has quit IRC |
| 13:13:12 | *** maurya has joined #openmrs |
| 13:16:18 | *** dkayiwa has joined #openmrs |
| 13:16:24 | *** batkinson has quit IRC |
| 13:37:56 | *** goutham has quit IRC |
| 13:45:40 | *** pushkar has joined #openmrs |
| 13:56:53 | *** mseaton has joined #openmrs |
| 14:15:42 | <maurya> dkayiwa: hi, i've submitted the patch for trunk-2880 |
| 14:15:58 | <dkayiwa> !ticket trunk-2889 |
| 14:15:59 | <OpenMRSBot> dkayiwa: [#TRUNK-2889] Autocomplete widgets should not lose initial value on losing focus - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2889 |
| 14:16:07 | <dkayiwa> maurya: ok |
| 14:16:45 | <dkayiwa> !ticket trunk-2880 |
| 14:16:46 | <OpenMRSBot> dkayiwa: [#TRUNK-2880] No success or failure message on saving locale and theme - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2880 |
| 14:18:56 | <maurya> dkayiwa: and i have a question,i've been going through this year's applications for projects and i have some ideas, do you think that i can proceed talking to the mentors about them or do you think it is a little bit early |
| 14:19:05 | <maurya> ? |
| 14:19:45 | <pushkar> dkayiwa: hi, even I have the same doubt.. |
| 14:19:48 | <dkayiwa> maurya: did you try to ask downey about it? |
| 14:20:17 | <maurya> dkayiwa: no.. |
| 14:20:48 | <dkayiwa> maurya: you can ask him. whatever he says, do just that :) |
| 14:20:58 | <maurya> dkayiwa: okay..:) |
| 14:21:08 | <maurya> downey: hi |
| 14:23:27 | <downey> maurya: hello. you're welcome to talk to mentors about projects but keep in mind that Google have not yet announced participating organizations :) |
| 14:24:49 | <maurya> downey: okay..:) |
| 14:27:53 | <pushkar> downey: the link to the Lab Module UI is deleted is it there for gsoc ?? |
| 14:28:49 | *** anu_GSOC has joined #openmrs |
| 14:29:58 | *** maurya_ has joined #openmrs |
| 14:32:31 | <downey> pushkar: thanks, i have fixed the link |
| 14:33:33 | <pushkar> downey: :-) |
| 14:41:38 | *** test123 has joined #openmrs |
| 14:41:50 | <downey> Hi test123 and welcome to the #openmrs IRC channel. |
| 14:43:34 | *** cloud|windoze has quit IRC |
| 14:56:26 | *** dawn_ has joined #openmrs |
| 14:56:31 | *** ChanServ sets mode: +v dawn_ |
| 14:57:43 | <test123> hey |
| 14:58:03 | <test123> i am trying to get the openmrs test case generator plugin for eclipse |
| 14:58:35 | <test123> the OpenMRS Database ODA has some problems in installation |
| 14:58:40 | <test123> Cannot complete the request. See the error log for details. |
| 14:58:40 | <test123> "OpenMRS Dependency Installer" will be ignored because it is already installed. |
| 14:58:40 | <test123> "Behavior Test Generator" will be ignored because it is already installed. |
| 14:58:44 | <test123> this is the error i got |
| 14:58:49 | <test123> can anyone help here? |
| 15:00:39 | <dawn_> !scrumon dawn |
| 15:00:39 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready. |
| 15:01:10 | <dawn_> bwolfe: djazayeri wyclif , dkayiwa , mseaton , mvorobey : hi |
| 15:01:34 | <wyclif> hi |
| 15:01:36 | <mseaton> hey |
| 15:01:41 | <djazayeri> hi |
| 15:01:50 | <mvorobey> hi, dawn_ |
| 15:01:51 | *** downey sets mode: +v mseaton |
| 15:01:52 | <dawn_> Today's order: bwolfe , djazayeri, wyclif , dkayiwa , mseaton , mvorobey |
| 15:02:03 | *** downey sets mode: +v dkayiwa |
| 15:03:00 | <dawn_> bwolfe: you ready? |
| 15:03:20 | <dawn_> djazayeri: can you go? |
| 15:03:23 | <djazayeri> Yeah |
| 15:03:37 | <djazayeri> Saturday & Sunday |
| 15:03:37 | <djazayeri> * Packaged up 2.x UI Framework as a new "uiframework" module |
| 15:03:37 | <djazayeri> * Started building an "app framework" module |
| 15:03:39 | <djazayeri> Today |
| 15:03:48 | <djazayeri> * Finish first-pass at "appframework" module |
| 15:04:02 | *** bwolfe has quit IRC |
| 15:04:14 | <djazayeri> * I'm available for any design issues for the Calculation sprint |
| 15:04:29 | <wyclif> Friday: |
| 15:04:29 | <wyclif> * TODOs for sprint tickets with review comments |
| 15:04:29 | <wyclif> * Investigated about REPORT-166 but didnt get time to code anything - Ensure that all date-based queries are appropriately handling boundary conditions |
| 15:04:29 | <wyclif> * Preparing for this week's sprint i.e make some changes in the code not block DEVs whose days start before those In US |
| 15:04:30 | <wyclif> * TODO-32 - Install artifacts to the nexus repo for the latest release in the 1.6.x line |
| 15:04:32 | <djazayeri> * (but I won't primarily be working on the sprint, I'll be doing a spike on ui stuff.) |
| 15:04:32 | <wyclif> Today: |
| 15:04:36 | <wyclif> * Made some code refactorings as per review comments |
| 15:04:38 | <wyclif> * update the wiki documentation for the module to match the changes |
| 15:04:40 | <wyclif> * Pick up a sprint ticket |
| 15:04:42 | <wyclif> Blockers: none |
| 15:04:44 | <wyclif> I have a discussion point |
| 15:05:01 | <dkayiwa> Working on and about to finish: Xform should include duplicate form schema elements - XFRM-54 |
| 15:05:02 | <dkayiwa> No Blockers |
| 15:05:20 | *** rafa has joined #openmrs |
| 15:05:20 | *** ChanServ sets mode: +v rafa |
| 15:05:27 | *** bwolfe has joined #openmrs |
| 15:05:49 | *** rafa has quit IRC |
| 15:06:05 | <dawn_> wyclif: noted. we can address the discussion point at the end |
| 15:06:06 | <mseaton> Nothing specific planned for me |
| 15:06:09 | <djazayeri> dkayiwa: you should finish XFRM-54 before starting on the sprint |
| 15:06:13 | <mseaton> Will pickup some calc tickets |
| 15:06:23 | <dkayiwa> djazayeri: yes i should finish it by today |
| 15:06:25 | <mseaton> And do the reporting module component |
| 15:06:28 | <mseaton> and code review / design |
| 15:06:31 | *** bwolfe has joined #openmrs |
| 15:06:31 | *** ChanServ sets mode: +o bwolfe |
| 15:07:02 | <dawn_> mvorobey: your turn :) |
| 15:07:12 | <mvorobey> * Added patches for LOGIC-93 this weekend |
| 15:07:24 | <mvorobey> * Gonna pick more tickets from Dashboard |
| 15:07:29 | <mvorobey> * No blockers |
| 15:08:05 | <dawn_> bwolfe: your turn |
| 15:08:12 | <bwolfe> today: |
| 15:08:12 | <bwolfe> call with EWM |
| 15:08:12 | <bwolfe> emails |
| 15:08:12 | <bwolfe> calc sprint tickets |
| 15:08:12 | <bwolfe> record university video on code review? (ping djazayeri) |
| 15:08:31 | <bwolfe> no blockers |
| 15:08:42 | <djazayeri> bwolfe: oh yeah, want to discuss that? |
| 15:09:21 | <dawn_> !scrumoff dawn |
| 15:09:21 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 15:09:25 | <dawn_> wyclif: what was your discussion point? |
| 15:09:25 | <bwolfe> yeah, just let me know what you want djazayeri |
| 15:09:27 | <djazayeri> I'd still love it if you can lead that discussion |
| 15:09:30 | <djazayeri> bwolfe: okay |
| 15:09:36 | <bwolfe> want a video, or just a discussion around it? |
| 15:10:33 | <djazayeri> bwolfe: video is better, but (prepared) live discussion is also sufficient, as it requires less time to prepare. |
| 15:11:54 | <djazayeri> wyclif: ? |
| 15:12:24 | <wyclif> ok |
| 15:12:35 | <wyclif> should we rename Results to PatientResults? |
| 15:12:47 | <mseaton> well, the problem is that |
| 15:12:54 | <mseaton> we are planning things like "ObsResult" |
| 15:12:56 | *** rafa has joined #openmrs |
| 15:12:56 | *** ChanServ sets mode: +v rafa |
| 15:13:03 | <mseaton> which is a Result that has an Obs as it's result |
| 15:13:07 | <mseaton> so having PatientResult |
| 15:13:18 | <mseaton> would imply that it is a Result that contains a Patient as the "value" |
| 15:13:31 | <mseaton> rather than being an interface that is used for PatientCalculation-based results |
| 15:13:42 | <djazayeri> What is patient-specific about the Result interface? |
| 15:13:56 | <mseaton> so, I'd rather we keep Result as is |
| 15:14:12 | <mseaton> and try to make the Cohort-related stuff more generic |
| 15:14:23 | <wyclif> the calculationContext and calculation are instance of PatientXX. i suggest we create super interfaces for these |
| 15:14:34 | <mseaton> eg. rather than call it Cohort, call it "get all results for these integer ids" |
| 15:15:12 | <djazayeri> wyclif, so a Result would have "Calculation getCalculation()" and "CalculationContext getCalculationContext()"... |
| 15:15:34 | <mseaton> that is what i would expect... |
| 15:15:41 | <djazayeri> but for the moment those would be empty interfaces extended by PatientCalculation and PatientCalculationContext |
| 15:15:53 | <djazayeri> I think that's fine. |
| 15:15:55 | <mseaton> right |
| 15:16:07 | <wyclif> djazayeri, basically what i mean, am adding super interfaces for calculation context, calculation so that Result uses these |
| 15:16:09 | <djazayeri> wyclif: +1 to creating superinterfaces for those |
| 15:16:12 | <mseaton> CalculationContext could have a "getNow()" method as common |
| 15:16:26 | <wyclif> same thing for calculation provider |
| 15:16:47 | <djazayeri> I agree with introducing the superinterfaces now. |
| 15:16:53 | <mseaton> Provider is less necessary I think. |
| 15:17:07 | <mseaton> in theory a Provider could Provide both Patient, Encounter, and other types of Calculations |
| 15:17:13 | <djazayeri> But only move methods that really obviously belong in the superclass up. |
| 15:17:32 | <djazayeri> e.g. getNow(). |
| 15:17:33 | <mseaton> so I don't think we need a "PatientProvider" specifically. just "CalculationProvider" is sufficient |
| 15:17:46 | <wyclif> but we have Calculationprovider.getCalculation returning a PatientCalculation, this needs to change to return Calculation |
| 15:17:59 | <wyclif> djazayeri, right |
| 15:18:13 | <mseaton> really? why not just have CalculationProvider.getCalculation return a Calculation |
| 15:18:25 | <wyclif> mseaton, that is what am saying |
| 15:18:37 | <mseaton> oh, right. i see. cool. |
| 15:18:38 | <djazayeri> I guess that's okay. |
| 15:19:17 | <wyclif> mseaton, djazayeri i will create a ticket for this and show you the changes for review |
| 15:19:18 | <mseaton> the only thing we need to look out for is we will need a way for users to say "I want all PatientCalculations" |
| 15:19:26 | <mseaton> or "all EncounterCalculations" |
| 15:19:32 | <wyclif> mseaton, i will add a ticket for that |
| 15:19:43 | <mseaton> if this will come by querying the Providers ultimately, then we should think about this. |
| 15:20:17 | <mseaton> we didn't really resolve the "Result" question, did we? |
| 15:20:30 | <djazayeri> I think we did... |
| 15:20:42 | <djazayeri> we just need to introduce the superinterfaces for Calculation and CalculationContext |
| 15:20:57 | <wyclif> mseaton, i will change the return types to the super interfaces |
| 15:21:01 | <mseaton> ok, you're right. |
| 15:21:09 | <djazayeri> the annoying bit is that if you evaluate a patient calculation, and you want to access its context, you'll probably have to cast to PatientCalculationContext. |
| 15:21:11 | <wyclif> and the variable types |
| 15:21:18 | <djazayeri> But that seems okay. |
| 15:21:32 | <wyclif> djazayeri, how about making them parameterized |
| 15:21:39 | <mseaton> you only need to cast it if you need the specific things in it |
| 15:21:54 | <djazayeri> wyclif: I haven't looked at the sprint dashboard, but is it set up in a way that it's obvious what tickets are easy to pick up first? |
| 15:21:58 | <mseaton> eg. you should be able to get the calculation without casting |
| 15:22:12 | <wyclif> mseaton, djazayeri, how about making them parameterized |
| 15:22:33 | <mseaton> it sounds good in theory. you might end up tearing your hair out though |
| 15:22:49 | <djazayeri> e.g. PatientCalculationContext implements CalculationContext<Patient>? |
| 15:22:57 | <wyclif> djazayeri, yeah |
| 15:23:12 | <mseaton> i would try it and if you end up running in circles, have an exit strategy |
| 15:23:29 | <djazayeri> yeah |
| 15:23:54 | <wyclif> one more quetion guys |
| 15:23:58 | <wyclif> one more question guys |
| 15:24:36 | <wyclif> we have PatientCalculationContext.getFromCache that needs to be implemented see CALC-a8 |
| 15:24:58 | <wyclif> it seems vague to me in that the context to search it unsepcified |
| 15:25:07 | <wyclif> it seems vague to me in that the context to search it unsepecified |
| 15:25:15 | <djazayeri> wyclif: what ticket #? |
| 15:25:25 | <wyclif> CALC-18 |
| 15:25:34 | <wyclif> !ticket CALC-18 |
| 15:25:35 | <OpenMRSBot> wyclif: [#CALC-18] Implement CalculationService.getFromCache(Cohort cohort, Calculation calculation) - OpenMRS JIRA - https://tickets.openmrs.org/browse/CALC-18 |
| 15:25:54 | <djazayeri> I was just looked at the design wiki page... |
| 15:25:59 | <djazayeri> I think we should get rid of that method. |
| 15:26:06 | *** bryq has joined #openmrs |
| 15:26:06 | *** ChanServ sets mode: +v bryq |
| 15:26:11 | <djazayeri> you already have a getFromCache method that returns an object, right? |
| 15:27:23 | <djazayeri> wyclif: ^^ |
| 15:28:12 | <wyclif> yes |
| 15:29:28 | <wyclif> djazayeri, actually am wrong, this methods is in CalculationContext, so it seems fine sorry for my mistake |
| 15:29:30 | <djazayeri> wyclif: then I'd say to close CALC-18 as won't-fix. If Mike, Tammy, or Win discovers something driven by an actual need, we can add it then. |
| 15:29:42 | <wyclif> djazayeri, ok |
| 15:32:46 | <djazayeri> bwolfe, dkayiwa, rafa, mvorobey, if you have any questions about what to do for the sprint, e.g. what the ticket is asking you to do, or how the underlying design works, don't hesitate to ask wyclif and mseaton. |
| 15:33:17 | <rafa> djazayeri: sure, thanks |
| 15:34:04 | <rafa> djazayeri: when do we scrum today? |
| 15:34:07 | <mvorobey> djazayeri: thanks |
| 15:34:19 | <djazayeri> rafa: we just did scrum |
| 15:34:22 | <mvorobey> rafa: you are a bit late with scrum :D |
| 15:34:26 | <rafa> djazayeri: ohh |
| 15:34:32 | <rafa> djazayeri: sorry |
| 15:34:38 | <wyclif> is the My Tickets widget on the dashboard working for you guys? |
| 15:34:55 | <djazayeri> rafa: oops, we didn't notice that you didn't give your update |
| 15:35:08 | <dkayiwa> :) rafa |
| 15:35:15 | <rafa> djazayeri: I wasn't probably here |
| 15:35:20 | <rafa> djazayeri: I came late |
| 15:35:32 | <rafa> djazayeri: actually my day of work just started |
| 15:35:47 | <rafa> djazayeri: I had a very intense weekend... |
| 15:35:56 | <djazayeri> hopefully in a good way |
| 15:36:06 | <rafa> djazayeri: yes :) |
| 15:36:09 | <wyclif> guys you have to keep updating your working copies since am making a couple of refactorings |
| 15:38:07 | <bwolfe> wyclif, define "is it working?" I have nothing in my box, but probably because nothing is assigned to me |
| 15:39:26 | <wyclif> bwolfe, when i pick a ticket, is it supposed to display it? |
| 15:39:42 | <bwolfe> if you did the query right, yes |
| 15:41:39 | <bwolfe> wyclif, whats the query name you are using for that box? |
| 15:42:51 | <wyclif> bwolfe, just a sec |
| 15:42:57 | <djazayeri> gotta run, back in 45 mins or so |
| 15:43:23 | <wyclif> bwolfe, My Tickets for Calculation Sprint |
| 15:44:52 | <bwolfe> wyclif, you have to take out "and issuetype = Bug" ...and probably the order by votes |
| 15:47:07 | <wyclif> bwolfe, thanks now it works, i had just copied and pasted from the last sprint |
| 15:53:57 | <mvorobey> wyclif: do you have a minute? |
| 15:54:05 | <wyclif> mvorobey, sure |
| 15:54:23 | *** sdan has joined #openmrs |
| 15:55:18 | <mvorobey> wyclif: I have a question about CALC-19. As far as I know there is already TokenRegistrationValidator class within logic module. So, we need to move that class to calculation module or something? |
| 15:55:29 | <mvorobey> !ticket CALC-19 |
| 15:55:30 | *** test123 has quit IRC |
| 15:55:30 | <OpenMRSBot> mvorobey: [#CALC-19] Add a TokenRegistrationValidator - OpenMRS JIRA - https://tickets.openmrs.org/browse/CALC-19 |
| 15:55:50 | <wyclif> mvorobey, what is the question? |
| 15:56:19 | *** ibewes has quit IRC |
| 15:56:39 | <mvorobey> wyclif: do we need to move that class to calculation module? |
| 15:56:46 | <mvorobey> from logic module |
| 15:58:27 | <wyclif> see the description |
| 15:58:40 | <wyclif> mvorobey, for now just implement what the description says |
| 15:59:15 | <mvorobey> wyclif: ok, thanks a lot! |
| 16:01:22 | <wyclif> mvorobey, no problem |
| 16:02:33 | *** Tammy has joined #openmrs |
| 16:02:48 | <downey> Hi Tammy and welcome to the #openmrs IRC channel. |
| 16:03:16 | *** ibewes has joined #openmrs |
| 16:03:21 | <downey> Hi ibewes and welcome to the #openmrs IRC channel. |
| 16:04:13 | *** dawn_ has quit IRC |
| 16:06:01 | *** dawn_ has joined #openmrs |
| 16:06:01 | *** ChanServ sets mode: +v dawn_ |
| 16:06:23 | <Tammy> hello |
| 16:07:21 | *** burke has joined #openmrs |
| 16:07:21 | *** ChanServ sets mode: +o burke |
| 16:07:31 | *** pushkar has quit IRC |
| 16:08:11 | <djazayeri> hi Tammy |
| 16:09:09 | <djazayeri> mvorobey: in general you can look to how things are done in the Logic module for guidance, but in the end we want both the logic module _and_ the calculation module to work 100%. |
| 16:11:07 | <wyclif> mseaton, djazayeri , looks like we should move createCalculationContext to CalculationUtil or introduce a super interface for calculation services |
| 16:11:17 | *** pushkar has joined #openmrs |
| 16:11:21 | *** test123 has joined #openmrs |
| 16:11:36 | <djazayeri> wyclif: where is it now? |
| 16:11:46 | <wyclif> in PatientCalculationService |
| 16:12:01 | <djazayeri> wyclif: what's wrong with just leaving it there? |
| 16:12:15 | <wyclif> and i need to make SimplecCalculationContext more generic by moving it out\ |
| 16:13:22 | <wyclif> i can leave it there by introducing a super interface to contain it |
| 16:13:23 | <djazayeri> wyclif: I don't understand why you need to do this. what code/design doesn't work if you leave it in PatientCalculationService? |
| 16:15:25 | <djazayeri> wyclif: generally speaking let's hold off on generic-izing things except where absolutely necessary. |
| 16:16:07 | <wyclif> djazayeri, ok |
| 16:16:09 | <djazayeri> wyclif: The main point is that we know we'll _eventually_ want to generalize it, thus we want to avoid doing things now that prevent _future_ generalization. E.g. we want to use the name PatientCalculation so that we save Calculation for later. |
| 16:16:30 | <djazayeri> but until we actually have the second use-case to generalize to, let's not speculate. |
| 16:18:38 | <wyclif> djazayeri, ok |
| 16:20:12 | <mvorobey> djazayeri, ok, does this mean that we will have two copies of TokenRegistration class within both these modules? |
| 16:21:05 | <djazayeri> mvorobey: yes, but they'll be in different packages. |
| 16:21:24 | <djazayeri> mvorobey: it's possible that the one in logic will eventually disappear |
| 16:21:34 | <djazayeri> but that's a question for the future |
| 16:21:54 | <mvorobey> djazayeri: so we will just copy one from logic into calculation and do some code refactoring |
| 16:23:47 | *** suranga has joined #openmrs |
| 16:23:47 | *** ChanServ sets mode: +v suranga |
| 16:24:17 | <djazayeri> mvorobey: I don't know if we'll copy it directly. I don't think the specs for it are exactly the same. |
| 16:24:31 | <djazayeri> but it might be that copying-and-editing is the way to go |
| 16:24:46 | <mvorobey> djazayeri: aha understand, thanks for this |
| 16:28:54 | *** Tammy has left #openmrs |
| 16:32:08 | *** sdan has quit IRC |
| 16:33:18 | *** sdan has joined #openmrs |
| 16:33:56 | <mvorobey> wyclif, mseaton : is there a way to get TokenRegistration by its providerClassName? |
| 16:34:08 | <wyclif> hi mvorobey |
| 16:34:57 | <ibewes> downey: thanks for the welcome... a long ways back |
| 16:35:05 | <wyclif> mvorobey, that would be right |
| 16:35:16 | <wyclif> mvorobey, sorry that wouldn't be correct |
| 16:36:05 | <mvorobey> wyclif: why? |
| 16:36:08 | <wyclif> mvorobey, what are you trying to do? |
| 16:37:08 | <mvorobey> wyclif: inside TokenRegistrationValidator am trying to get TokenRegistration by providerClassName to check if this is unique |
| 16:37:32 | <wyclif> mvorobey, typically a token name will be the name of the calculation to look up from the associated provider |
| 16:37:39 | *** dawn_ has quit IRC |
| 16:37:53 | <wyclif> mvorobey, use uuid or name |
| 16:38:22 | <wyclif> mvorobey, or id |
| 16:40:26 | <mvorobey> wyclif: as for uuid, I don't really think that we need to check it anyway, because it should be unique across different token registrations, is not it? |
| 16:40:26 | *** pushkar has quit IRC |
| 16:40:45 | <wyclif> mvorobey, i have updated the description after seeing what you mean |
| 16:42:14 | <wyclif> djazayeri, for registered tokens, names should be unique within a specific provider and not table, right? |
| 16:42:31 | <wyclif> mvorobey, hold on |
| 16:43:04 | <mvorobey> wyclif: ok, just read new description, thanks for clarifications |
| 16:44:07 | <djazayeri> wyclif, mvorobey: tokens need to be globally unique |
| 16:44:45 | <djazayeri> i.e. if the reporting provider and the logic provider both support a "weight" rule, only one of them is allowed to have a token registered for it. |
| 16:45:07 | *** ibewes has quit IRC |
| 16:45:08 | <mvorobey> djazayeri: so, the token name should be globally unique, yes? |
| 16:45:16 | <djazayeri> mvorobey: yes |
| 16:46:37 | <mvorobey> djazayeri: and should be unique not only within the same provider? |
| 16:46:50 | <djazayeri> mvorobey: *globally* unique. |
| 16:47:19 | <mvorobey> djazayeri: ok, thanks :D |
| 16:47:25 | <wyclif> djazayeri, thanks for editing the description |
| 16:47:49 | <djazayeri> mvorobey: to clarify, "name" should be globally unique, whereas "ruleName" can be anything |
| 16:48:10 | <djazayeri> (or whatever "ruleName" was renamed to.) |
| 16:48:58 | <mvorobey> djazayeri: yes |
| 16:49:19 | <djazayeri> i.e. the thing that's externally-facing must be unique, but the internal thing can be anything |
| 16:51:48 | *** mseaton has quit IRC |
| 17:05:19 | <djazayeri> bwolfe: I'd like to access the spring applicationContext from a module's activator |
| 17:05:29 | <djazayeri> offhand I don't think this is possible |
| 17:05:42 | <djazayeri> bwolfe: do you know if it is? |
| 17:05:55 | <bwolfe> I don't think so |
| 17:06:03 | <bwolfe> what do you need to do ? |
| 17:06:09 | <bwolfe> I think you can get a bean through the Context |
| 17:06:14 | <bwolfe> (or servicecontext only?) |
| 17:06:50 | <djazayeri> I want to get all beans that implement AppDescriptor. |
| 17:07:01 | <djazayeri> maybe that's what Context.getRegisteredComponents does... |
| 17:08:18 | <djazayeri> actually, yeah, that should work. |
| 17:12:56 | *** dkayiwa has quit IRC |
| 17:23:43 | *** anu_GSOC has quit IRC |
| 17:25:08 | *** sdan has quit IRC |
| 17:33:19 | *** burke has quit IRC |
| 17:37:04 | *** dmexs has joined #openmrs |
| 17:39:01 | *** dmexs has quit IRC |
| 17:40:43 | *** dmexs has joined #openmrs |
| 17:41:19 | *** dmexs has quit IRC |
| 17:56:33 | *** rajithd has joined #openmrs |
| 17:56:49 | <downey> Hi rajithd and welcome to the #openmrs IRC channel. |
| 17:56:58 | <rajithd> hi all |
| 17:57:57 | *** mvorobey has quit IRC |
| 17:58:26 | *** rajithd has quit IRC |
| 17:58:42 | <suranga> hi james_regen :-) |
| 18:03:08 | *** sgithens_ has quit IRC |
| 18:17:15 | *** downey has quit IRC |
| 18:19:49 | *** dkayiwa has joined #openmrs |
| 18:20:37 | *** downey has joined #openmrs |
| 18:20:37 | *** ChanServ sets mode: +o downey |
| 18:20:37 | *** OpenMRSBot sets mode: +o downey |
| 18:26:53 | *** rafa has quit IRC |
| 18:27:51 | <james_regen> suranga: hi |
| 18:28:32 | <suranga> james_regen, I got good news and bad news :P |
| 18:28:42 | <james_regen> ok |
| 18:29:11 | <suranga> the bad news is that over the past week I was terribly stuck with a problem in moving Mutual information scoring to the web ui... |
| 18:29:35 | <suranga> the good news is that I managed to fix it at the nth hour, so I dont have to bug you about it |
| 18:29:51 | <suranga> I tested it out to check if it works, it seems ok.. |
| 18:30:03 | *** rafa has joined #openmrs |
| 18:30:03 | *** ChanServ sets mode: +v rafa |
| 18:30:12 | <suranga> so I may have to commit siome changed code into the module tomorrow or so... |
| 18:30:26 | <james_regen> suranga: okay, i'm glad you got it working |
| 18:31:19 | <suranga> james_regen, my problem was that the matching config were insisting that they take the 'dummy' datasource instead of the real mysql one.. but not it is ok :-) |
| 18:31:34 | <suranga> will keep you updated on when / what changes I commit :-) |
| 18:49:41 | *** downey has quit IRC |
| 18:51:05 | *** downey has joined #openmrs |
| 18:51:05 | *** ChanServ sets mode: +o downey |
| 18:51:05 | *** OpenMRSBot sets mode: +o downey |
| 18:59:13 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Simple Lab Entry 1.7.3 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=simplelabentry&version=&1.7.3> |
| 19:00:01 | *** maurya has quit IRC |
| 19:00:02 | *** harshadura has joined #openmrs |
| 19:02:30 | *** amourphious has joined #openmrs |
| 19:02:41 | <downey> Hi amourphious and welcome to the #openmrs IRC channel. |
| 19:03:03 | <amourphious> hello |
| 19:04:37 | <amourphious> i attended a session by Dr.surjit nundy he told me about this open mrs and i'm kind of interested in the project but need guidence how to start |
| 19:14:38 | *** amourphious has quit IRC |
| 19:20:28 | <wyclif> hi djazayeri |
| 19:20:39 | <djazayeri> hi wyclif |
| 19:21:39 | <wyclif> djazayeri, was the intention for CalculationProvider.getCalculation(name, config) supposed to take in fully qualified class name or logicl name or we can do both |
| 19:21:56 | <djazayeri> wyclif: it can take whatever the provider wants it to take |
| 19:22:07 | <djazayeri> e.g. the ClasspathBasedOne will surely take a class name |
| 19:22:31 | <wyclif> ok |
| 19:22:54 | <djazayeri> I think that most "framework-y" modules will use classname, but utility modules (e.g. Win wants to write some custom calculations for AMPATH) may take logical names |
| 19:23:11 | <wyclif> djazayeri, ok |
| 19:25:50 | *** james_regen has left #openmrs |
| 19:47:52 | *** test123 has quit IRC |
| 20:03:53 | <harshadura> hi bwolfe |
| 20:04:04 | <bwolfe> hi harshadura |
| 20:04:49 | <harshadura> I am working on this bug ticket now https://tickets.openmrs.org/browse/TRUNK-3123 |
| 20:04:58 | <harshadura> Please can you mention where are the places (like whats are the JSPs) have to be edited to fix this problem? |
| 20:15:15 | *** harshadura has quit IRC |
| 20:16:49 | *** rafa has quit IRC |
| 20:26:27 | *** harshadura has joined #openmrs |
| 20:34:32 | *** suranga has quit IRC |
| 20:34:37 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Synchronization 1.0.1 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=sync&version=&1.0.1> |
| 21:00:41 | *** wluyima has joined #openmrs |
| 21:00:42 | *** wyclif has quit IRC |
| 21:00:49 | *** wluyima has quit IRC |
| 21:01:11 | *** wyclif has joined #openmrs |
| 21:15:30 | <wyclif> hi djazayeri |
| 21:16:24 | <wyclif> djazayeri, am trying to add calculation to logic as a dependency, but it is not getting picked up by maven |
| 21:16:33 | <wyclif> djazayeri, any ideas |
| 21:22:36 | *** wyclif has quit IRC |
| 21:41:32 | *** bryq has quit IRC |
| 21:44:42 | *** dkayiwa has quit IRC |
| 22:00:53 | *** harshadura has quit IRC |
| 22:35:26 | *** downey has quit IRC |
| 23:04:29 | *** dmexs has joined #openmrs |
| 23:32:10 | *** dmexs has quit IRC |
| 23:35:46 | *** dmexs has joined #openmrs |
| 23:48:04 | *** wyclif has joined #openmrs |