| 00:11:39 | *** flow has joined #openmrs |
| 00:13:31 | <flow> Hi Folks, Anyone have experience of OPenMrs on Ubuntu and Property Files ? Mine seems r to be written and so install wizard does not end and when I access /openmrs, the wizard staarts again. I saw somewhere this can happen when the property file does not exist. |
| 00:23:31 | *** wyclif has joined #openmrs |
| 00:44:34 | *** robbyoconnor has quit IRC |
| 00:44:59 | *** robbyoconnor has joined #openmrs |
| 00:44:59 | *** ChanServ sets mode: +v robbyoconnor |
| 01:39:11 | *** flow has quit IRC |
| 01:43:36 | <bwolfe> why is it that flow always signs off just minutes before I get back to my computer... |
| 02:17:39 | <wyclif> hi djazayeri |
| 02:17:49 | <djazayeri> hi wyclif |
| 02:18:34 | <wyclif> djazayeri, isn't the fix for RCM-43 supposed to be in trunk? |
| 02:20:33 | <djazayeri> wyclif: remind me what table those things are stored inâ¦report_object? |
| 02:20:43 | <djazayeri> that holds both data exports and cohort builder queries, right? |
| 02:21:07 | <wyclif> report object |
| 02:21:08 | <djazayeri> Honestly I'm pretty surprised that this ticket is ranked, though I see mseaton voted on it. |
| 02:21:24 | <djazayeri> wyclif: yeah, that seems like it would need to be a trunk fix. |
| 02:22:22 | <djazayeri> what does report_object have now? retired or voided flag? |
| 02:22:36 | <wyclif> djazayeri, but again core doesn't have a service for reports |
| 02:22:51 | <wyclif> could be in reporting module |
| 02:23:15 | <djazayeri> wyclif: ReportObject.hbm.xml is in core. |
| 02:23:29 | <djazayeri> So is ReportObjectService. |
| 02:24:49 | <wyclif> seen them, never knew this |
| 02:25:29 | <djazayeri> wyclif: what I would do is comment on the ticket that this is going to require a core data model change, change the ticket's issueType to be New Feature rather than Bug, mention that it won't be done until 1.10 at the earliest, and unassign yourself from the ticket. |
| 02:25:41 | <djazayeri> i.e. that ticket doesn't fit in a bugfixing sprint |
| 02:26:07 | <wyclif> ok, thanks |
| 02:34:58 | <djazayeri> wyclif: would you mind creating a ticket back in RCM that depends on the one you moved to core (TRUNK-3095) just saying "after core supports retiring ReportObjects, fix RCM to take advantage of that"? |
| 02:36:35 | <wyclif> ok |
| 02:36:40 | <wyclif> djazayeri, ok |
| 02:45:05 | *** surangak has joined #openmrs |
| 03:28:21 | *** bwolfe has quit IRC |
| 03:28:32 | *** robbyoconnor has quit IRC |
| 03:42:37 | *** surangak has quit IRC |
| 03:45:41 | *** Mkop has quit IRC |
| 03:46:09 | *** Mkop has joined #openmrs |
| 03:46:09 | *** ChanServ sets mode: +v Mkop |
| 03:50:20 | *** upul` has joined #openmrs |
| 03:50:20 | *** ChanServ sets mode: +v upul` |
| 03:58:58 | *** burke has joined #openmrs |
| 03:58:58 | *** ChanServ sets mode: +o burke |
| 04:00:13 | *** burke has quit IRC |
| 04:14:03 | *** Mkop1 has joined #openmrs |
| 04:14:03 | *** ChanServ sets mode: +v Mkop1 |
| 04:14:11 | *** Mkop has quit IRC |
| 04:22:28 | *** goutham has joined #openmrs |
| 06:22:43 | *** bryq has joined #openmrs |
| 06:22:43 | *** ChanServ sets mode: +v bryq |
| 06:46:23 | *** dmexs has joined #openmrs |
| 07:09:53 | *** robbyoconnor has joined #openmrs |
| 07:09:53 | *** ChanServ sets mode: +v robbyoconnor |
| 07:19:37 | *** r0bby_ has joined #openmrs |
| 07:19:37 | *** ChanServ sets mode: +v r0bby_ |
| 07:23:44 | *** robbyoconnor has quit IRC |
| 07:27:56 | *** bryq has quit IRC |
| 07:28:53 | *** r0bby_ is now known as robbyoconnor |
| 07:41:41 | *** goutham has quit IRC |
| 07:51:28 | *** rahul_ has joined #openmrs |
| 07:57:09 | *** magoo_ has joined #openmrs |
| 08:03:46 | *** magoo_ has quit IRC |
| 08:12:26 | *** dmexs has quit IRC |
| 08:21:06 | *** dkayiwa has joined #openmrs |
| 08:41:51 | *** rafa has joined #openmrs |
| 08:41:51 | *** ChanServ sets mode: +v rafa |
| 08:45:17 | *** dkayiwa has quit IRC |
| 08:50:10 | *** dkayiwa has joined #openmrs |
| 09:51:42 | *** akanter has joined #openmrs |
| 09:51:58 | <akanter> anybody listening? |
| 10:05:05 | <akanter> I'll send an email to the list |
| 10:05:48 | <dkayiwa> akanter: you can get better attention when you mention name :) |
| 10:08:01 | <akanter> didn't know you were awake |
| 10:08:01 | <akanter> ahh |
| 10:08:11 | <akanter> but of course you are on my time zone |
| 10:08:14 | <akanter> :) |
| 10:08:31 | <dkayiwa> :D |
| 10:08:33 | <akanter> Daniel, I just sent an email to the implementers list |
| 10:08:41 | <dkayiwa> akanter: ok |
| 10:09:22 | <akanter> basically I want to take an infopath form which was submitted on one server, edit it and resubmit it on a new server. The problem is that the .xml file in the archive folder under formentry, even after editing does not resubmit |
| 10:09:57 | <dkayiwa> akanter: what errors does it give you? |
| 10:10:30 | <akanter> I have to go grab a bite to eat before they close in 15 min... so will be right back... but there is error anywhere that I can see. It just doesn't process. I will send u the email directly |
| 10:10:48 | <dkayiwa> ok |
| 10:11:44 | <dkayiwa> just remember to include my or anyone else's name when you type. That way it makes their window alert them |
| 10:11:53 | <dkayiwa> akanter: eg dkayiwa ,........ |
| 10:16:27 | *** magoo_ has joined #openmrs |
| 10:24:36 | *** magoo_ has quit IRC |
| 10:24:38 | <akanter> ahh like dkayiwa: did you get my email? |
| 10:25:27 | <dkayiwa> akanter: oh yes :) |
| 10:25:28 | <akanter> dkayiwa: or do you have to start with it? |
| 10:25:43 | <dkayiwa> akanter: no. you can put it anywhere |
| 10:26:02 | <akanter> ok thanks dkayiwa |
| 10:26:16 | <dkayiwa> you are welcome akanter |
| 10:26:44 | <dkayiwa> akanter: type the first character of the name and then press TAB will autocomplete for you :) |
| 10:27:01 | <akanter> dkayiwa: it occurred to me that the client machines probably have copies of the xsn files which were submitted to the server and we could try editing them from there (rather than using the .xml) |
| 10:27:15 | <dkayiwa> akanter: ok |
| 10:27:54 | <akanter> dkayiwa: do you think there is a way to resubmit the .xml from the archive folders? Either formentry, xforms or xformhelper? |
| 10:28:14 | <dkayiwa> akanter: yes it should work. did you say the error logs were empty? |
| 10:28:33 | <akanter> I looked at the server log from the admin page |
| 10:28:45 | <dkayiwa> akanter: that one does not include all |
| 10:29:10 | <dkayiwa> akanter: you must be missing like one small thing which we can detect from the logs |
| 10:34:46 | <akanter> dkayiwa: do you know which logfile it would be in under ubuntu? |
| 10:35:09 | <dkayiwa> akanter: can you start by checking catalina.out? |
| 10:42:06 | *** akanter has quit IRC |
| 10:42:23 | *** mvorobey has joined #openmrs |
| 10:42:33 | <mvorobey> hi all |
| 10:43:12 | <dkayiwa> hey |
| 10:56:39 | *** goutham has joined #openmrs |
| 11:26:08 | *** upul` has quit IRC |
| 11:29:12 | *** Mkop1 has quit IRC |
| 11:30:42 | *** Mkop has joined #openmrs |
| 11:30:42 | *** ChanServ sets mode: +v Mkop |
| 11:36:33 | *** dkayiwa has quit IRC |
| 11:38:23 | *** Mkop1 has joined #openmrs |
| 11:38:23 | *** ChanServ sets mode: +v Mkop1 |
| 11:38:23 | *** Mkop has quit IRC |
| 11:44:50 | *** dkayiwa has joined #openmrs |
| 11:53:08 | *** james_regen has joined #openmrs |
| 11:53:08 | *** ChanServ sets mode: +v james_regen |
| 12:20:36 | *** r6friedman has joined #openmrs |
| 12:32:13 | *** bwolfe has joined #openmrs |
| 12:32:13 | *** ChanServ sets mode: +o bwolfe |
| 12:33:58 | *** dkayiwa has quit IRC |
| 12:37:57 | *** dkayiwa has joined #openmrs |
| 12:45:54 | <r6friedman> bwolfe: hi ben |
| 12:47:17 | <bwolfe> hi roger |
| 12:47:26 | <r6friedman> bwolfe: got time for a question? |
| 12:47:30 | <bwolfe> sure |
| 12:47:53 | <r6friedman> suppose you have a superclass (order) and its subclass (laborder) |
| 12:48:13 | <r6friedman> both of them have their methods in different services |
| 12:48:23 | <r6friedman> permissions are set at the service level |
| 12:49:18 | <r6friedman> can order methods mung laborders with only order permissions? |
| 12:49:35 | <r6friedman> can laborder methods use order methods with only laborder permissions? |
| 12:51:24 | <r6friedman> bwolfe: my thought is that they can't call services but laborder can use order methods it extends |
| 12:52:04 | *** dkayiwa has quit IRC |
| 12:52:12 | <bwolfe> r6friedman, we don't put permissions on the pojo objects |
| 12:52:21 | <bwolfe> so only service methods have privileges and protections |
| 12:52:43 | <r6friedman> bwolfe: right, that's why I think the pojo methods could be used |
| 12:52:56 | <bwolfe> saving an order might cause hibernate to propagate saves to laborder though |
| 12:53:04 | <bwolfe> what kind of actions were you thinking? |
| 12:53:40 | <r6friedman> if you want to discontinue a lab order, you'd use order.setDiscontinued |
| 12:54:22 | <r6friedman> or laborder.setDiscontinued which would actually run order.setDiscontinued |
| 12:55:18 | <r6friedman> bwolfe: i may be overthinking this, i'm just trying to decide whether it makes sense to have laborder privileges in addition to order privileges |
| 13:21:03 | <bwolfe> r6friedman, I would look at the laborder privs as extending the order privs too. so if someone has general "order" privileges, they should be able to do things with labs. but someone with just lab privs shoudl not be able to modify all other types of orders. |
| 13:21:05 | <bwolfe> no? |
| 13:22:32 | <r6friedman> bwolfe: Seems to make sense, but not sure about things like reporting -- might want to have a polymorphism-aware report of all orders |
| 13:23:02 | <r6friedman> or the reverse, want to use a report designed for orders but just for laborders |
| 13:25:23 | <r6friedman> bwolfe: what do you think about REST? if somebody does GET order/x?v=full and x is a laborder, should it do laborder.full or order.full? |
| 13:26:31 | *** wyclif has quit IRC |
| 13:28:33 | <bwolfe> r6friedman, how do we handle concept/conceptnumeric? |
| 13:28:38 | <bwolfe> I can't remember... |
| 13:28:56 | <r6friedman> bwolfe: i'll take a look |
| 13:37:59 | <r6friedman> bwolfe: you didn't forget, nothing was done |
| 13:38:10 | <bwolfe> heh |
| 13:38:17 | <bwolfe> so getting a concpet gets you only a concept? |
| 13:38:38 | <r6friedman> bwolfe: and a lot of extraneous xml :-) |
| 13:41:47 | <r6friedman> bwolfe: it occurs to me that if we follow darius' rule that an object belongs in one and only one URI, we can't have subclasses as independent objects |
| 13:42:17 | <r6friedman> bwolfe: resources, that is. So we would have to have a subclass subresource that had the additional information |
| 13:42:54 | *** downey has joined #openmrs |
| 13:42:54 | *** ChanServ sets mode: +o downey |
| 13:42:54 | *** OpenMRSBot sets mode: +o downey |
| 13:50:51 | *** goutham has quit IRC |
| 13:55:32 | <bwolfe> r6friedman, but a concept form of a concpetnumeric is a different resource (kind of) |
| 13:56:19 | <r6friedman> bwolfe: burke was quite insistent that he wanted to be able to list all orders for a patient, regardless of what type |
| 13:56:35 | <r6friedman> bwolfe: and i can see why |
| 13:58:00 | <r6friedman> so it seems laborder x should be accessed as order/x/laborder/x even if it's defined in a module |
| 13:58:47 | <r6friedman> the rep of laborder can recapitulate the info from the parent order, but it can't be updated |
| 13:59:11 | <r6friedman> either that, or it has to delegate the updating of superclass fields to the superclass resource |
| 14:01:47 | <r6friedman> bwolfe: wonder what happens if you do a post and the body refers to a field that isn't in the resource. probably throws an error |
| 14:01:55 | *** sgithens has joined #openmrs |
| 14:02:08 | <bwolfe> dunno. my guess would be that it ignores it |
| 14:02:38 | <r6friedman> well that would be bliss, at least the subclass woldn't have to rebuild the body |
| 14:02:47 | *** dkayiwa has joined #openmrs |
| 14:10:21 | * downey ears are burning |
| 14:12:58 | *** magicaltrout has quit IRC |
| 14:13:03 | *** magicaltrout has joined #openmrs |
| 14:13:05 | *** dkayiwa has quit IRC |
| 14:16:59 | *** pushkar has joined #openmrs |
| 14:18:09 | <pushkar> djazayeri: Hi |
| 14:18:12 | <pushkar> https://source.openmrs.org/cru/CR-TRUNK-642#CFR-19285 |
| 14:18:21 | *** maurya has joined #openmrs |
| 14:18:44 | *** wyclif has joined #openmrs |
| 14:30:47 | *** magoo_ has joined #openmrs |
| 14:44:07 | <djazayeri> rafa: question about STAND-36 and fixing the MVP dictionary |
| 14:44:16 | <rafa> djazayeri: yes |
| 14:44:26 | <djazayeri> are the duplicates exact? i.e. same name, locale, and tags? |
| 14:44:29 | *** downey_ has joined #openmrs |
| 14:44:29 | *** ChanServ sets mode: +o downey_ |
| 14:44:52 | <djazayeri> or do they have the same name and locale, but different tags (or some other field different)? |
| 14:45:12 | <rafa> djazayeri: they're not really duplicate concepts |
| 14:45:23 | <rafa> djazayeri: it's just that translation to spanish was not done right |
| 14:45:40 | <rafa> djazayeri: let me find you an example |
| 14:47:04 | *** downey has quit IRC |
| 14:47:07 | *** downey_ is now known as downey |
| 14:47:46 | <rafa> djazayeri: http://www.maternalconceptlab.com/search.php?q=abdomen+distendido&source=openmrs |
| 14:47:59 | <OpenMRSBot> <http://ln-s.net/9hQN> (at www.maternalconceptlab.com) |
| 14:48:06 | <rafa> you can see there that 3 different english concepts have the same name in spanish |
| 14:48:34 | <rafa> Andy said it was due to some automatic merging based on concept mappings |
| 14:48:45 | <pushkar> djazayeri: I have a question about TRUNK-2240 |
| 14:48:46 | *** magoo_ has quit IRC |
| 14:49:31 | *** downey_ has joined #openmrs |
| 14:49:31 | *** ChanServ sets mode: +o downey_ |
| 14:49:49 | <djazayeri> rafa: oh, so these are actually bugs in the dictionary... |
| 14:49:58 | <rafa> djazayeri: yes |
| 14:50:15 | <djazayeri> pushkar: yes? what's the question? |
| 14:50:24 | <rafa> djazayeri: Andy didn't want to loose these translations entirely |
| 14:50:38 | *** downey has quit IRC |
| 14:50:39 | *** downey_ is now known as downey |
| 14:50:49 | <rafa> djazayeri: I suggested to make them INDEX_TERMs |
| 14:51:21 | <pushkar> you asked me to implement the endvisit button using form but If we use a form we won't have the endvisit popup after the submit to show the validation errors because the page is getting reloaded.So should I show the validation errors in the visitform page instead of the endvisit popup??? |
| 14:51:49 | <rafa> djazayeri: so that they wouldn't be validated for uniquness |
| 14:52:21 | <djazayeri> rafa: I guess we could change our upgrade scripts to look for a custom concept_name_tag called "indexterm", and you could manually add that tag on the offending names |
| 14:52:26 | <djazayeri> in the source dictionary |
| 14:52:32 | <djazayeri> (or andy could) |
| 14:53:05 | <djazayeri> rafa: is that what you mean? |
| 14:53:13 | <rafa> djazayeri: yes, that would be fine |
| 14:53:25 | <djazayeri> okay |
| 14:53:32 | <rafa> djazayeri: I wrote SQL queries to tag them right |
| 14:53:54 | <rafa> djazayeri: there are around 4k such dupes so it would be impossible for andy to do it manually ;) |
| 14:54:22 | <djazayeri> rafa: it's a bit odd to be retroactively changing our 1.7 upgrade script at this late date, soâ¦do it carefully. :-) |
| 14:54:37 | <djazayeri> AFAIK nobody is actually using tags |
| 14:54:55 | <djazayeri> so that shouldn't be a problem. |
| 14:55:33 | <djazayeri> rafa: do note that it would be nice to handle this in the MDS code that converts between 1.6/1.7+ reps of concepts |
| 14:55:37 | <rafa> djazayeri: the other way is to add 1, 2, 3,.. to them as I suggested |
| 14:55:49 | *** bwolfe has quit IRC |
| 14:56:11 | <rafa> djazayeri: but I guess it's not entirely right |
| 14:56:34 | <djazayeri> rafa: ask Andy if that's okay |
| 14:56:46 | <rafa> djazayeri: okay |
| 14:57:08 | <djazayeri> pushkar: after you submit the form, the page will reload. If in the controller you set the session variable OPENMRS_ERR_ATTR, that string will be displayed at the top of the screen. |
| 14:57:50 | <djazayeri> pushkar: yes, that would show the error on the visitform page, not the popup. |
| 14:58:09 | <djazayeri> The only option they're allowed to set in the popup is the end date+time, right? |
| 14:58:38 | <djazayeri> It's fine if they then have to click End Visit again if they got that wrong the first time. |
| 14:59:03 | <pushkar> okay...:-) |
| 14:59:33 | <djazayeri> pushkar: one thing to test out thoughâif you're setting the default value for that field via js on the client, make sure to test the case where the time zone on the server makes it be an earlier hour than what's on the client |
| 15:00:58 | <pushkar> djazayeri: I didn't get you can you please repeat that |
| 15:01:58 | <djazayeri> imagine the server is in San Francisco (west) but the client is in New York (east) |
| 15:02:44 | <djazayeri> if the client clicks End Visit, then "Submit" on the popup, it should not fail because he's trying to close the visit 3 hours in the future (from the perspective of the server) |
| 15:06:30 | <djazayeri> pushkar: does that make sense? |
| 15:07:26 | <sgithens> Is there a versioned version of the Javascript libraries functions that you put at the top of your <htmlform/> ? From this page: https://wiki.openmrs.org/display/docs/HTML+Form+Entry+Module+Javascript |
| 15:07:27 | *** rafa has quit IRC |
| 15:07:27 | <OpenMRSBot> <http://ln-s.net/9Biw> (at wiki.openmrs.org) |
| 15:07:50 | <pushkar> yes |
| 15:09:22 | <pushkar> djazayeri: i guess there is no method to get the current datetime in the datetime picker I searched but I didnt find it |
| 15:10:09 | <djazayeri> pushkar: you could leave it blank to represent "now" and have that value be filled in on the server |
| 15:10:28 | *** bwolfe has joined #openmrs |
| 15:10:28 | *** ChanServ sets mode: +o bwolfe |
| 15:10:47 | <djazayeri> sgithens: I think those are just helpful examples that someone has put there |
| 15:11:29 | <pushkar> djazayeri: okay.....:-) |
| 15:11:50 | <sgithens> djazayeri: So we haven't turned those into a standard sort of js library for HTML Forms? ( |
| 15:12:06 | *** bryq has joined #openmrs |
| 15:12:06 | *** ChanServ sets mode: +v bryq |
| 15:12:06 | <sgithens> or something similar |
| 15:12:39 | *** ChanServ sets mode: +v wyclif |
| 15:12:39 | *** ChanServ sets mode: +v r6friedman |
| 15:13:12 | *** dkayiwa has joined #openmrs |
| 15:15:51 | *** r6friedman has quit IRC |
| 15:22:26 | *** dawn_ has joined #openmrs |
| 15:22:40 | *** ChanServ sets mode: +v dawn_ |
| 15:24:14 | <djazayeri> sgithens: that would be goodâI don't know that anyone in the community has done it. |
| 15:26:21 | <sgithens> djazayeri: Cool. I'm building up my first production HTML Form for a project, when I get done, I'll rip out the project specific stuff and check in a the working shell somewhere, and maybe think about that while I'm doing it. |
| 15:26:40 | <djazayeri> sgithens: okay, cool |
| 15:27:00 | <djazayeri> fwiw I don't know if there's a mechanism for including a js file |
| 15:27:12 | <djazayeri> so, if you can think of how that should work, create a ticket for that too. |
| 15:28:07 | <wyclif> hi dkayiwa |
| 15:29:06 | <wyclif> dkayiwa, can you reply to my comment on XFRM-47 and see the snapshot |
| 15:30:26 | *** pushkar has quit IRC |
| 15:30:33 | <dawn_> !scrumon dawn |
| 15:30:33 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready. |
| 15:32:25 | <dawn_> bwolfe: djazayeri dkayiwa and wyclif : aloha |
| 15:33:29 | <wyclif> hey |
| 15:33:49 | <bwolfe> is it time? |
| 15:33:51 | <bwolfe> is it time already? |
| 15:34:56 | <djazayeri> so says dawn |
| 15:35:02 | <djazayeri> want me to go first? |
| 15:35:48 | <djazayeri> bwolfe: ? |
| 15:35:54 | <wyclif> yeah |
| 15:36:06 | <bwolfe> one sec |
| 15:36:11 | <bwolfe> dawn is having internet problems |
| 15:36:24 | <dkayiwa> just like me :) |
| 15:36:43 | *** dawn_ has quit IRC |
| 15:38:02 | <bwolfe> ok, guess I'm leading. dawn is a slacker |
| 15:38:15 | <bwolfe> lets go in the order she listed above |
| 15:38:22 | <bwolfe> today: |
| 15:38:22 | <bwolfe> triaged tickets |
| 15:38:22 | <bwolfe> random ticket comments |
| 15:38:22 | <bwolfe> listened in on the univ call |
| 15:38:22 | <bwolfe> TRUNK-2240, end visit button |
| 15:38:23 | <bwolfe> TRUNK-33, reduce object use |
| 15:38:26 | <bwolfe> no blockers yet |
| 15:39:15 | <djazayeri> me next |
| 15:39:20 | <djazayeri> Tuesday 28-Feb-2012 |
| 15:39:20 | <djazayeri> * Committed @since for TRUNK-3066 (backporting is annoying...) |
| 15:39:20 | <djazayeri> * Discussed TRUNK-2619 with mvorobey |
| 15:39:20 | <djazayeri> * Recorded OpenMRS University presentation for tomorrow |
| 15:39:20 | <djazayeri> ** had trouble because when I build the standalone it doesn't work (used beta instead) |
| 15:39:20 | <wyclif> yeah |
| 15:39:20 | <djazayeri> * Worked on TRUNK-2704 (create new person while adding relationship) |
| 15:39:21 | <djazayeri> * Reviewed TRUNK-1800 |
| 15:39:21 | <djazayeri> * random ticket comments |
| 15:39:22 | <djazayeri> Wednesday 29-Feb-2012 |
| 15:39:22 | <djazayeri> * University call |
| 15:39:23 | <djazayeri> * Reviewed TRUNK-337 |
| 15:39:24 | <djazayeri> * planned: Design call |
| 15:39:24 | <djazayeri> * planned: Project Management call |
| 15:39:24 | <djazayeri> * planned: Finish TRUNK-2704 (create new person while adding relationship) |
| 15:39:25 | <djazayeri> * ??? |
| 15:39:26 | <djazayeri> Issue: when I build the standalone, it doesn't work for me. |
| 15:39:52 | <dkayiwa> Reviewed, tested and closed: Small fixes for newpatient.form - TRUNK-198 |
| 15:39:53 | <dkayiwa> Committed response to review comments for: Encounter.removeProvider and setProvider should void the EncounterProvider, not remove it - TRUNK-3059 |
| 15:39:53 | <dkayiwa> Had internet problems and just been out in town renewing my second sim card backup. |
| 15:39:53 | <dkayiwa> No Blockers |
| 15:40:08 | <wyclif> yesterday: |
| 15:40:09 | <wyclif> * revisited and backported TRUNK-3048 - When searching for patients by name, exact matches should be shown first |
| 15:40:09 | <wyclif> * TRUNK-324 - Go through the TODO items code and create tickets out of them |
| 15:40:09 | <wyclif> * Looked into RCM-43(moved it to trunk) and created RCM-78 as a follow up ticket in the module |
| 15:40:09 | <wyclif> * Made a change to Short patient form not to display the location combo when creating a new patient(back ported it too) |
| 15:40:11 | <wyclif> Today: |
| 15:40:13 | <wyclif> * XFRM-47 - Need to use the new provider API to get the list of providers |
| 15:40:16 | <wyclif> * design call |
| 15:40:18 | <wyclif> * pick another sprint ticket |
| 15:40:19 | <wyclif> Blockers: Bug blocking me with XFRM-47, see the snapshot i attached to the ticket |
| 15:41:35 | <wyclif> dkayiwa, are you aware of that bug? |
| 15:41:47 | <dkayiwa> !ticket xfrm-47 |
| 15:41:47 | <bwolfe> ok, a few discussion points |
| 15:41:48 | <OpenMRSBot> dkayiwa: [#XFRM-47] Need to use the new provider API to get the list of providers - OpenMRS JIRA - https://tickets.openmrs.org/browse/xfrm-47 |
| 15:41:52 | <bwolfe> !scrumoff |
| 15:41:52 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 15:42:23 | <djazayeri> wyclif: "not displaying location combo"? what's up with that? |
| 15:42:26 | <dkayiwa> wyclif: problem or feature? |
| 15:42:43 | <wyclif> dkayiwa, that is what you asked me to fix |
| 15:42:45 | <bwolfe> xfrm-47 is first. then we need to discuss darius' inability to build, then a 1.9 status |
| 15:43:06 | <dkayiwa> wyclif: i tested your fix and it now works perfectly :) |
| 15:43:11 | <mvorobey> djazayeri: hi, thanks for quick so review on TRUNK-337 |
| 15:43:53 | <mvorobey> djazayeri: Darius, you said, that you want to have TRUNK-337 made for 1.10, but am currently working on it with 1.8.x. Does it mean that I need to re-work it for 1.10? |
| 15:44:06 | <wyclif> !TRUNK-337 |
| 15:44:07 | <OpenMRSBot> wyclif: Error: "TRUNK-337" is not a valid command. |
| 15:44:11 | <wyclif> !ticket TRUNK-337 |
| 15:44:12 | <OpenMRSBot> wyclif: [#TRUNK-337] Refactor openmrs:format tag to support an "object" property - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-337 |
| 15:44:18 | <djazayeri> mvorobey: it means we'll need to commit the code to trunk, and we won't backport it. |
| 15:44:34 | <djazayeri> mvorobey: we backport bugfixes, but not new features. |
| 15:44:58 | <djazayeri> mvorobey: ideally you would create a patch against trunk, rather than 1.8.x. |
| 15:45:25 | <mvorobey> dfjazayeri: ok, thanks, I think that it not a big problem |
| 15:45:41 | <mvorobey> djazayeri: sorry for typos |
| 15:45:52 | <djazayeri> mvorobey: if necessary someone can take your 1.8.x patch and manually apply it to trunk. |
| 15:46:17 | <bwolfe> shouldn't be many changes between the two |
| 15:46:50 | <mvorobey> djazayeri: I'm going to re-work the ticket considering with your comments on review and create a patch off 1.10 |
| 15:46:54 | <djazayeri> yeahâsome things were added to FormatTag in 1.9 though. |
| 15:47:53 | <djazayeri> dkayiwa: looks like you need to help wyclif get around the bug he posted a screenshot of. |
| 15:48:22 | <djazayeri> dkayiwa: any comment for him right now, based on the screenshot? |
| 15:49:44 | *** dkayiwa has quit IRC |
| 15:50:13 | <djazayeri> okay, no dkayiwa |
| 15:50:29 | <djazayeri> that's going to make getting a 1.9 update hard. |
| 15:52:25 | <djazayeri> bwolfe, wyclif: can one of you try (in the background, e.g. while you go for lunch) doing a clean build of the standalone |
| 15:52:36 | *** Rahul has joined #openmrs |
| 15:52:38 | <wyclif> djazayeri, sure |
| 15:52:41 | <djazayeri> and then starting that and choosing Demo Mode? |
| 15:52:52 | <wyclif> djazayeri, ok |
| 15:52:59 | *** dkayiwa has joined #openmrs |
| 15:53:05 | <djazayeri> thanks |
| 15:53:16 | *** Rahul has quit IRC |
| 15:53:36 | <djazayeri> rafa has a blocker issue on TRUNK-3103. |
| 15:53:54 | <wyclif> !ticket TRUNK-3103 |
| 15:53:55 | <OpenMRSBot> wyclif: [#TRUNK-3103] Adding a new concept name fails - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3103 |
| 15:54:45 | <wyclif> i figured there is going to be a bunch of issues there due to the recent changes we made in 1.9 |
| 15:54:57 | <wyclif> i figured there is going to be a bunch of issues there due to the recent changes we made in trunk |
| 15:55:51 | <wyclif> i would say saving a concept should be transactional and we need to look closely at all the methods it invokes in the process |
| 15:56:12 | <wyclif> the methods does and checks numerous things |
| 15:57:06 | <djazayeri> dkayiwa: you back? |
| 16:02:43 | <dkayiwa> djazayeri: yes |
| 16:03:50 | <djazayeri> dkayiwa: looks like you need to help wyclif get around the bug he posted a screenshot of. |
| 16:03:51 | <djazayeri> 7:47 |
| 16:03:51 | <djazayeri> dkayiwa: any comment for him right now, based on the screenshot? |
| 16:04:14 | <dkayiwa> djazayeri: ok |
| 16:04:24 | <dkayiwa> djazayeri: which ticket number? |
| 16:04:26 | <wyclif> dkayiwa, looks like the wrong concept id is being set |
| 16:04:34 | <wyclif> XFRM-47 |
| 16:04:47 | <dkayiwa> wyclif: ok checking it out.... |
| 16:05:26 | *** maurya has quit IRC |
| 16:06:27 | <dkayiwa> wyclif: do you have the steps to reproduce it? |
| 16:06:43 | <dkayiwa> wyclif: does it happen with just some forms or all of them? |
| 16:07:57 | <djazayeri> I have a call now, but dkayiwa, please inform us what we need to be doing for 1.9 RC. |
| 16:08:07 | <djazayeri> (I'll finish the ticket I stole today.) |
| 16:08:18 | <dkayiwa> djazayeri: now or after your call? |
| 16:08:24 | <wyclif> i opened the patient dashboard for horatio and tried to create an encounter using xform |
| 16:08:49 | <djazayeri> dkayiwa: you can say so now. |
| 16:08:54 | <wyclif> selected the location, provider, entered weight and saved |
| 16:09:26 | <dkayiwa> wyclif: does it happen for every form |
| 16:09:34 | <dkayiwa> wyclif: or just certain forms? |
| 16:11:35 | <wyclif> dkayiwa, let me create a new form and test with it |
| 16:15:27 | <wyclif> dkayiwa, i have created a new form, when i open it for data entry, i get the error below: |
| 16:15:30 | <wyclif> dkayiwa, No form layout found. Please first open the form in the form designer, then click the Design Surface tab and ensure that you have some widgets loaded. Then save the form and try again. |
| 16:16:35 | <dkayiwa> wyclif: after creating the form, while in the form designer, ensure that you select the design surface tab before saving |
| 16:16:42 | <dkayiwa> wyclif: that should fix it |
| 16:17:18 | <wyclif> dkayiwa, fgot past that |
| 16:17:23 | <dkayiwa> ok |
| 16:17:23 | <wyclif> dkayiwa, got past that |
| 16:26:32 | *** surangak has joined #openmrs |
| 16:33:16 | <wyclif> dkayiwa, i think with the new form i got past the problem, now i can work on the ticket, thanks |
| 16:33:44 | <dkayiwa> wyclif: ok |
| 16:33:58 | <wyclif> dkayiwa, wait!! |
| 16:34:28 | <wyclif> i think i still have the problem i didnt realise it because i selected a provider that is not associated with a person |
| 16:34:36 | <dkayiwa> ok |
| 16:34:51 | <wyclif> dkayiwa, though i think i can work on the ticket even if the other bug is still there |
| 16:35:13 | <wyclif> i will create a ticket for it when i get done with XFRM-47 |
| 16:39:37 | *** dkayiwa_ has joined #openmrs |
| 16:40:19 | <dkayiwa_> wyclif: sorry for being on and off. the fibre option cable in the ocean got broken. so all telecom providers have internet problems |
| 16:41:05 | <wyclif> man!! that must be causing tons of problems |
| 16:42:01 | *** dkayiwa has quit IRC |
| 16:44:44 | *** dkayiwa_ has quit IRC |
| 16:46:51 | *** rafa has joined #openmrs |
| 16:46:51 | *** ChanServ sets mode: +v rafa |
| 16:47:11 | *** dkayiwa has joined #openmrs |
| 16:57:36 | <mvorobey> djazayeri: Darius, have a little minute ? :) |
| 17:00:56 | <djazayeri> hi mvorobey |
| 17:01:25 | <mvorobey> djazayeri: I'm currently asking you about TRUNK-2619. |
| 17:01:46 | <mvorobey> djazayeri: So, as outcome from mailing list discussion I understood, that we need to add new state CURRENT_AND_FUTURE for order. Can I start working on this or just need to wait more for answers on your last question there? |
| 17:02:05 | <djazayeri> mvorobey: I think you can just add that new state. |
| 17:02:35 | <mvorobey> djazayeri: thanks, Darius, going to upload new patch and update review |
| 17:02:44 | <djazayeri> okay,g reat |
| 17:02:52 | <mvorobey> :) |
| 17:05:37 | <mvorobey> djazayeri: uploaded patch and updated review |
| 17:06:11 | <djazayeri> mvorobey: okay, i'll look at them later |
| 17:07:57 | <mvorobey> djazayeri: thanks, Darius, sorry if am exhausting you with this :) |
| 17:13:57 | <dkayiwa> hi rafa |
| 17:14:03 | <rafa> dkayiwa: hi |
| 17:14:13 | <dkayiwa> rafa: are you working on TRUNK-3103 " |
| 17:14:15 | <dkayiwa> ? |
| 17:14:19 | <dkayiwa> !ticket TRUNK-3103 |
| 17:14:20 | <OpenMRSBot> dkayiwa: [#TRUNK-3103] Adding a new concept name fails - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3103 |
| 17:14:33 | <rafa> dkayiwa: yes, I'm trying to figure it out |
| 17:14:47 | <dkayiwa> rafa: do you mind claiming it? |
| 17:15:11 | <rafa> dkayiwa: done |
| 17:15:22 | <dkayiwa> rafa: thanks :) |
| 17:15:32 | <dkayiwa> rafa: are you blocking on STAND-36 ? |
| 17:15:36 | <dkayiwa> !ticket STAND-36 |
| 17:15:37 | <OpenMRSBot> dkayiwa: [#STAND-36] Automatically create MVP/CIEL dictionary-based dataset as part of the standalone build process - OpenMRS JIRA - https://tickets.openmrs.org/browse/STAND-36 |
| 17:15:58 | <rafa> dkayiwa: yes, I need a response from Andy |
| 17:16:13 | <rafa> dkayiwa: I've e-mailed him |
| 17:16:19 | <djazayeri> dkayiwa: note that STAND-36 is not required for the RC |
| 17:16:38 | <dkayiwa> djazayeri: oh thanks for the clarification :) |
| 17:17:18 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: HTML Form Entry 1.9.0 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=htmlformentry&version=&1.9.0> |
| 17:17:35 | <dkayiwa> rafa: am i right to assume that you are done with TRUNK-3005? |
| 17:17:38 | <dkayiwa> !ticket TRUNK-3005 |
| 17:17:39 | <OpenMRSBot> dkayiwa: [#TRUNK-3005] ConceptValidator finds duplicate names only for the current system locale - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3005 |
| 17:17:46 | <rafa> dkayiwa: yes |
| 17:18:04 | <dkayiwa> rafa: ok thanks. so waiting for wyclif and bwolfe to review it |
| 17:18:10 | <rafa> dkayiwa: yes |
| 17:18:19 | <dkayiwa> 8) |
| 17:19:20 | *** mvorobey has quit IRC |
| 17:25:50 | <dkayiwa> bwolfe: are you leaving TRUNK-2240 to Pushkar? |
| 17:25:52 | <dkayiwa> !ticket TRUNK-2240 |
| 17:25:54 | <OpenMRSBot> dkayiwa: [#TRUNK-2240] Allow "end this visit now" from edit visit page - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2240 |
| 17:27:43 | <dkayiwa> djazayeri: bwolfe do you agree that we should close TRUNK-251 and then let Baily do the remaining work as TRUNK-3087 ? |
| 17:27:52 | <dkayiwa> !ticket TRUNK-251 |
| 17:27:53 | <OpenMRSBot> dkayiwa: [#TRUNK-251] Add delete (and retire?) for program states in the workflow - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-251 |
| 17:28:04 | <dkayiwa> !ticket TRUNK-308 |
| 17:28:05 | <OpenMRSBot> dkayiwa: [#TRUNK-308] Concept Dictionary not saving properly - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-308 |
| 17:29:11 | <surangak> im off everyone... its pretty late over here :-) |
| 17:29:58 | <djazayeri> dkayiwa: re: trunk-251 and trunk-308, if the functionality in the first ticket is "complete" and functional, then yes, I agree. |
| 17:30:19 | <dkayiwa> djazayeri: ok |
| 17:34:01 | *** surangak has quit IRC |
| 17:50:49 | *** pushkar has joined #openmrs |
| 17:53:55 | *** goutham has joined #openmrs |
| 17:57:16 | *** dawn_ has joined #openmrs |
| 17:57:59 | *** dawn_ has quit IRC |
| 17:59:21 | <pushkar> djazayeri: you asked me add a method to end visit ... is it required ?? |
| 17:59:48 | <pushkar> in visitservice |
| 18:02:12 | <wyclif> djazayeri, dkayiwa i think the bug causing the issue in XFRM-47 is in core |
| 18:02:24 | <dkayiwa> oh |
| 18:05:51 | <wyclif> apparently xforms is submitting the correct providerId but the oruro1 handler only searches for providers by matching on person.personId and never provider.providerId |
| 18:06:15 | <wyclif> and yet not all providers are associated to persons |
| 18:15:10 | *** rafa has quit IRC |
| 18:26:17 | <bwolfe> pushkar, adding to the service would be convenient. then it is only a one-line call from the controller method |
| 18:26:46 | <bwolfe> wyclif, so oruor1 needs fixing? is xforms telling the processor that it is submitting a providerId vs a personId (or is it just hte integer?) |
| 18:26:52 | *** rafa has joined #openmrs |
| 18:26:52 | *** ChanServ sets mode: +v rafa |
| 18:28:01 | <pushkar> bwolfe: yes but in my case it increases the code |
| 18:29:42 | <bwolfe> pushkar, not by much. :-) |
| 18:29:58 | <wyclif> bwolfe, xform is not specifying whether it is a provider or person id but still the handler doesn't make an y check, it always assumes personId |
| 18:31:39 | <bwolfe> so xforms should tell it |
| 18:31:41 | <bwolfe> e.g. |
| 18:32:13 | <bwolfe> 123^Provider's Name^99PROV vs 33^Person's name^99PER |
| 18:36:41 | *** maurya has joined #openmrs |
| 18:37:17 | <pushkar> bwolfe: since I am using VisitValidator I have to set the stopdate of the visit.I guess it would be better to use saveVisit instead of endvisit method .but if you want to have endVisit method I will write it but not use it |
| 18:38:14 | <wyclif> bwolfe, the xslt in xform that transforms the xml to hl7 needs to handle the providers smartly i.e specify if providerId or personId |
| 18:38:25 | <bwolfe> pushkar, you would move the setting and validating to the service end visit method. then the endVisit method calls the savevisit |
| 18:38:31 | <bwolfe> the controller method only has to call endvisit |
| 18:38:45 | <wyclif> bwolfe, but still the ORURO1 handler needs to be fixed too to do the same |
| 18:39:01 | <bwolfe> wyclif, that specification should be in the xml |
| 18:39:28 | <pushkar> bwolfe: okay |
| 18:39:56 | <wyclif> bwolfe, right but that wont solve the problem |
| 18:40:49 | <bwolfe> fix xml + fix orur01 |
| 18:41:13 | <wyclif> correct |
| 18:46:33 | *** james_regen has left #openmrs |
| 18:57:14 | *** downey_ has joined #openmrs |
| 18:57:14 | *** ChanServ sets mode: +o downey_ |
| 18:59:28 | *** dkayiwa has quit IRC |
| 19:00:48 | *** downey has quit IRC |
| 19:00:48 | *** downey_ is now known as downey |
| 19:05:56 | *** wyclif has quit IRC |
| 19:06:37 | <maurya> bwolfe: hi |
| 19:06:48 | <maurya> bwolfe: https://tickets.openmrs.org/browse/TRUNK-3059 |
| 19:07:35 | <bwolfe> what about it maurya? |
| 19:08:36 | <maurya> bwolfe: dont we need to change the unit tests for methods getprovidersbyroles and getprovidersbyrole as the actual methods have been changed? |
| 19:10:22 | *** harshadura has joined #openmrs |
| 19:28:11 | *** harshadura has quit IRC |
| 19:29:31 | *** wyclif has joined #openmrs |
| 19:30:26 | *** goutham has quit IRC |
| 19:35:10 | *** Mkop has joined #openmrs |
| 19:35:10 | *** ChanServ sets mode: +v Mkop |
| 19:36:22 | *** Mkop1 has quit IRC |
| 19:42:37 | *** Mkop1 has joined #openmrs |
| 19:42:40 | *** Mkop1 has joined #openmrs |
| 19:42:40 | *** ChanServ sets mode: +v Mkop1 |
| 19:42:49 | *** Mkop has quit IRC |
| 19:52:26 | <maurya> bwolfe: |
| 19:59:46 | <bwolfe> maurya, commented for you |
| 20:06:11 | <maurya> okay:) |
| 20:10:49 | *** burke has joined #openmrs |
| 20:10:49 | *** ChanServ sets mode: +o burke |
| 20:12:00 | <burke> downey: noticed that JIRA links are broken in Confluence, at least on road map pages (https://wiki.openmrs.org/x/7gBl) saying there isn't an application link to JIRA. |
| 20:13:14 | <burke> downey: should I just add an application link for JIRA within Confluence? |
| 20:15:59 | <burke> downey: attempting to make an application link b/w Confluence & JIRA fails. :-( |
| 20:27:02 | <downey> burke: taking a look now |
| 20:29:09 | *** bwolfe has quit IRC |
| 20:34:49 | <downey> burke: I think everything's back ⦠confirm if you get a chance? |
| 20:35:19 | <burke> downey: yup. it's fixed. thx. |
| 20:38:46 | *** downey_ has joined #openmrs |
| 20:38:46 | *** ChanServ sets mode: +o downey_ |
| 20:39:17 | *** downey has quit IRC |
| 20:39:18 | *** downey_ is now known as downey |
| 20:40:26 | *** pushkar has quit IRC |
| 21:04:36 | *** maurya has quit IRC |
| 21:09:15 | *** wyclif has quit IRC |
| 21:31:56 | *** wyclif has joined #openmrs |
| 21:36:30 | *** dkayiwa has joined #openmrs |
| 21:42:55 | *** burke has quit IRC |
| 21:51:19 | *** bryq has quit IRC |
| 21:52:28 | <dkayiwa> hi djazayeri |
| 21:54:08 | <djazayeri> hi dkayiwa, on a call |
| 21:55:11 | <dkayiwa> djazayeri: it is you, Ben, and Rafal that have the pending three 1.9 RC tickets. Does it still make sense sending that information to the dev list? |
| 21:55:20 | <djazayeri> dkayiwa: yes |
| 21:55:32 | <dkayiwa> djazayeri: ok |
| 21:55:33 | *** rafa has quit IRC |
| 22:01:32 | *** rafa has joined #openmrs |
| 22:01:32 | *** ChanServ sets mode: +v rafa |
| 22:01:40 | *** rafa has quit IRC |
| 22:03:55 | *** sgithens has quit IRC |
| 22:05:09 | <dkayiwa> djazayeri: sent you an email |
| 22:05:46 | <djazayeri> dkayiwa: will reply in a second |
| 22:05:54 | <dkayiwa> ok |
| 22:19:31 | *** wyclif has quit IRC |
| 22:28:01 | *** burke has joined #openmrs |
| 22:28:01 | *** ChanServ sets mode: +o burke |
| 22:40:09 | *** dkayiwa_ has joined #openmrs |
| 22:42:39 | *** dkayiwa has quit IRC |
| 22:42:39 | *** dkayiwa_ is now known as dkayiwa |
| 22:56:19 | *** dkayiwa has left #openmrs |
| 23:27:55 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Register 1.2 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=register&version=&1.2> |
| 23:44:34 | *** burke is now known as burke_away |